{"action":"created","issue":{"url":"https://api.github.com/repos/n3-charts/line-chart/issues/243","labels_url":"https://api.github.com/repos/n3-charts/line-chart/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/n3-charts/line-chart/issues/243/comments","events_url":"https://api.github.com/repos/n3-charts/line-chart/issues/243/events","html_url":"https://github.com/n3-charts/line-chart/pull/243","id":82845804,"number":243,"title":" Proposed structure now executable typescript","user":{"login":"chaosmail","id":2969388,"avatar_url":"https://avatars.githubusercontent.com/u/2969388?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosmail","html_url":"https://github.com/chaosmail","followers_url":"https://api.github.com/users/chaosmail/followers","following_url":"https://api.github.com/users/chaosmail/following{/other_user}","gists_url":"https://api.github.com/users/chaosmail/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosmail/subscriptions","organizations_url":"https://api.github.com/users/chaosmail/orgs","repos_url":"https://api.github.com/users/chaosmail/repos","events_url":"https://api.github.com/users/chaosmail/events{/privacy}","received_events_url":"https://api.github.com/users/chaosmail/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-30T15:50:40Z","updated_at":"2015-05-30T15:52:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/n3-charts/line-chart/pulls/243","html_url":"https://github.com/n3-charts/line-chart/pull/243","diff_url":"https://github.com/n3-charts/line-chart/pull/243.diff","patch_url":"https://github.com/n3-charts/line-chart/pull/243.patch"},"body":"Hi Sébastien,\r\n\r\nfirst thanks for your awesome and super quick work to provide this awesome new infrastructure. I did my best to add the new proposed structure into this framework. Honestly, it is awesome working with so much cool stuff like gulp, node, typescript etc. it is motivating me a lot.\r\n\r\nPlease mind, we need to check on the following things:\r\n* check names for angular services, modules and directives\r\n* unify file names for src/ and dirnames (lowercase, uppercase, ..)\r\n* check the module names, class names and interface names\r\n* check the structure (is BaseFactory in module utils, etc)\r\n* gulp tasks\r\n* how to provide a minified version\r\n\r\nI will add more useful tests soon; I just wanted to provide you early access to my code.\r\n\r\nBest,\r\nChristoph"},"comment":{"url":"https://api.github.com/repos/n3-charts/line-chart/issues/comments/107056629","html_url":"https://github.com/n3-charts/line-chart/pull/243#issuecomment-107056629","issue_url":"https://api.github.com/repos/n3-charts/line-chart/issues/243","id":107056629,"user":{"login":"chaosmail","id":2969388,"avatar_url":"https://avatars.githubusercontent.com/u/2969388?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosmail","html_url":"https://github.com/chaosmail","followers_url":"https://api.github.com/users/chaosmail/followers","following_url":"https://api.github.com/users/chaosmail/following{/other_user}","gists_url":"https://api.github.com/users/chaosmail/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosmail/subscriptions","organizations_url":"https://api.github.com/users/chaosmail/orgs","repos_url":"https://api.github.com/users/chaosmail/repos","events_url":"https://api.github.com/users/chaosmail/events{/privacy}","received_events_url":"https://api.github.com/users/chaosmail/received_events","type":"User","site_admin":false},"created_at":"2015-05-30T15:52:40Z","updated_at":"2015-05-30T15:52:40Z","body":"And again, the build code is in the repo. Maybe we can have some elegant way to avoid this."}}