{"action":"created","issue":{"url":"https://api.github.com/repos/hammerlab/guacamole/issues/346","labels_url":"https://api.github.com/repos/hammerlab/guacamole/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/hammerlab/guacamole/issues/346/comments","events_url":"https://api.github.com/repos/hammerlab/guacamole/issues/346/events","html_url":"https://github.com/hammerlab/guacamole/pull/346","id":98233450,"number":346,"title":"refactor clique-finding","user":{"login":"ryan-williams","id":465045,"avatar_url":"https://avatars.githubusercontent.com/u/465045?v=3","gravatar_id":"","url":"https://api.github.com/users/ryan-williams","html_url":"https://github.com/ryan-williams","followers_url":"https://api.github.com/users/ryan-williams/followers","following_url":"https://api.github.com/users/ryan-williams/following{/other_user}","gists_url":"https://api.github.com/users/ryan-williams/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-williams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-williams/subscriptions","organizations_url":"https://api.github.com/users/ryan-williams/orgs","repos_url":"https://api.github.com/users/ryan-williams/repos","events_url":"https://api.github.com/users/ryan-williams/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-williams/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-07-30T18:37:37Z","updated_at":"2015-07-30T19:55:04Z","closed_at":"2015-07-30T19:36:49Z","pull_request":{"url":"https://api.github.com/repos/hammerlab/guacamole/pulls/346","html_url":"https://github.com/hammerlab/guacamole/pull/346","diff_url":"https://github.com/hammerlab/guacamole/pull/346.diff","patch_url":"https://github.com/hammerlab/guacamole/pull/346.patch"},"body":"(PR on top of #343)\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/hammerlab/guacamole/346)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/hammerlab/guacamole/issues/comments/126457777","html_url":"https://github.com/hammerlab/guacamole/pull/346#issuecomment-126457777","issue_url":"https://api.github.com/repos/hammerlab/guacamole/issues/346","id":126457777,"user":{"login":"ryan-williams","id":465045,"avatar_url":"https://avatars.githubusercontent.com/u/465045?v=3","gravatar_id":"","url":"https://api.github.com/users/ryan-williams","html_url":"https://github.com/ryan-williams","followers_url":"https://api.github.com/users/ryan-williams/followers","following_url":"https://api.github.com/users/ryan-williams/following{/other_user}","gists_url":"https://api.github.com/users/ryan-williams/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-williams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-williams/subscriptions","organizations_url":"https://api.github.com/users/ryan-williams/orgs","repos_url":"https://api.github.com/users/ryan-williams/repos","events_url":"https://api.github.com/users/ryan-williams/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-williams/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T19:55:04Z","updated_at":"2015-07-30T19:55:04Z","body":"yea, scala's `reduce` omits the initial argument, returns the same type as the elems. It has only the \"combiner\" bits and not the \"zeroValue\" bits that we looked at in RDD's `combineByKey` hierarchy.\n\nInterestingly, in RDD-land, `reduceByKey` is consistent with this, but `foldByKey` assumes that the `zeroValue` and `output` are of the same type as the elements, whereas `aggregateByKey` is more analogous to `foldLeft` here in that the initial value and output can be an arbitrary type.\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala, line 186 \\[r1\\]](https://reviewable.io:443/reviews/hammerlab/guacamole/346#-JvVPM1SbqbTtrLMW_UO)** ([raw file](https://github.com/hammerlab/guacamole/blob/a81b4890f0d0c7467b5396f5a627581bd10c3cdb/src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala#L186)):</sup>\ngood call, can you fix?\n\n---\n\n<sup>**[src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala, line 197 \\[r1\\]](https://reviewable.io:443/reviews/hammerlab/guacamole/346#-JvVOPJ_F0E079vmLJae)** ([raw file](https://github.com/hammerlab/guacamole/blob/a81b4890f0d0c7467b5396f5a627581bd10c3cdb/src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala#L197)):</sup>\nwell, they're in scope from the `case class` definition above (would work for regular `class` too)\n\n---\n\n<sup>**[src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala, line 252 \\[r1\\]](https://reviewable.io:443/reviews/hammerlab/guacamole/346#-JvVQ5QrUQKd2Hdeub1m)** ([raw file](https://github.com/hammerlab/guacamole/blob/a81b4890f0d0c7467b5396f5a627581bd10c3cdb/src/main/scala/org/hammerlab/guacamole/commands/StructuralVariantCaller.scala#L252)):</sup>\nhm yea, well it's the same as `.filter(n => clique.nodeIsConnected(n))` in scala, whereas it's not in JS\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/hammerlab/guacamole/346)\n<!-- Sent from Reviewable.io -->\n"}}