{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/platform/pulls/comments/34591526","id":34591526,"diff_hunk":"@@ -225,6 +236,14 @@ func (u *User) AddNotifyProp(key string, value string) {\n \tu.NotifyProps[key] = value\n }\n \n+func (u *User) GetDisplayName() string {\n+\tif u.Nickname != \"\" {\n+\t\treturn u.Nickname\n+\t} else {","path":"model/user.go","position":56,"original_position":56,"commit_id":"b2c573d7c17d481b9f8e117c32608919bc3ce7df","original_commit_id":"b2c573d7c17d481b9f8e117c32608919bc3ce7df","user":{"login":"coreyhulen","id":1431746,"avatar_url":"https://avatars.githubusercontent.com/u/1431746?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyhulen","html_url":"https://github.com/coreyhulen","followers_url":"https://api.github.com/users/coreyhulen/followers","following_url":"https://api.github.com/users/coreyhulen/following{/other_user}","gists_url":"https://api.github.com/users/coreyhulen/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyhulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyhulen/subscriptions","organizations_url":"https://api.github.com/users/coreyhulen/orgs","repos_url":"https://api.github.com/users/coreyhulen/repos","events_url":"https://api.github.com/users/coreyhulen/events{/privacy}","received_events_url":"https://api.github.com/users/coreyhulen/received_events","type":"User","site_admin":false},"body":"should also have case for FullName?","created_at":"2015-07-14T16:58:18Z","updated_at":"2015-07-14T16:58:18Z","html_url":"https://github.com/mattermost/platform/pull/177#discussion_r34591526","pull_request_url":"https://api.github.com/repos/mattermost/platform/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments/34591526"},"html":{"href":"https://github.com/mattermost/platform/pull/177#discussion_r34591526"},"pull_request":{"href":"https://api.github.com/repos/mattermost/platform/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/platform/pulls/177","id":39862748,"html_url":"https://github.com/mattermost/platform/pull/177","diff_url":"https://github.com/mattermost/platform/pull/177.diff","patch_url":"https://github.com/mattermost/platform/pull/177.patch","issue_url":"https://api.github.com/repos/mattermost/platform/issues/177","number":177,"state":"open","locked":false,"title":"MM-825 Replace FullName field with separate FirstName and LastName fields and repurpose the existing FullName as Nickname","user":{"login":"hmhealey","id":3277310,"avatar_url":"https://avatars.githubusercontent.com/u/3277310?v=3","gravatar_id":"","url":"https://api.github.com/users/hmhealey","html_url":"https://github.com/hmhealey","followers_url":"https://api.github.com/users/hmhealey/followers","following_url":"https://api.github.com/users/hmhealey/following{/other_user}","gists_url":"https://api.github.com/users/hmhealey/gists{/gist_id}","starred_url":"https://api.github.com/users/hmhealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmhealey/subscriptions","organizations_url":"https://api.github.com/users/hmhealey/orgs","repos_url":"https://api.github.com/users/hmhealey/repos","events_url":"https://api.github.com/users/hmhealey/events{/privacy}","received_events_url":"https://api.github.com/users/hmhealey/received_events","type":"User","site_admin":false},"body":"Changes made:\r\n1) Renamed all existing references to the FullName field to Nickname\r\n2) Added FirstName and LastName fields, populated from the previous FullName if possible, and use them wherever it makes sense\r\n3) Added GetDisplayName helper function to be more consistent how we're referring to users in the UI. Currently, this is to use the nickname if possible and fall back to the username if that's not available.\r\n\r\nSince the first two commits (for 1 above) are a bunch of find and replaces, it may be easier to review this on a commit by commit basis since they're fairly self-contained.","created_at":"2015-07-13T22:14:11Z","updated_at":"2015-07-14T16:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae27597f2edcb8837debb9af76463e063a9a7f28","assignee":{"login":"crspeller","id":3191642,"avatar_url":"https://avatars.githubusercontent.com/u/3191642?v=3","gravatar_id":"","url":"https://api.github.com/users/crspeller","html_url":"https://github.com/crspeller","followers_url":"https://api.github.com/users/crspeller/followers","following_url":"https://api.github.com/users/crspeller/following{/other_user}","gists_url":"https://api.github.com/users/crspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/crspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crspeller/subscriptions","organizations_url":"https://api.github.com/users/crspeller/orgs","repos_url":"https://api.github.com/users/crspeller/repos","events_url":"https://api.github.com/users/crspeller/events{/privacy}","received_events_url":"https://api.github.com/users/crspeller/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/platform/pulls/177/commits","review_comments_url":"https://api.github.com/repos/mattermost/platform/pulls/177/comments","review_comment_url":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/platform/issues/177/comments","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/b2c573d7c17d481b9f8e117c32608919bc3ce7df","head":{"label":"hmhealey:mm825","ref":"mm825","sha":"b2c573d7c17d481b9f8e117c32608919bc3ce7df","user":{"login":"hmhealey","id":3277310,"avatar_url":"https://avatars.githubusercontent.com/u/3277310?v=3","gravatar_id":"","url":"https://api.github.com/users/hmhealey","html_url":"https://github.com/hmhealey","followers_url":"https://api.github.com/users/hmhealey/followers","following_url":"https://api.github.com/users/hmhealey/following{/other_user}","gists_url":"https://api.github.com/users/hmhealey/gists{/gist_id}","starred_url":"https://api.github.com/users/hmhealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmhealey/subscriptions","organizations_url":"https://api.github.com/users/hmhealey/orgs","repos_url":"https://api.github.com/users/hmhealey/repos","events_url":"https://api.github.com/users/hmhealey/events{/privacy}","received_events_url":"https://api.github.com/users/hmhealey/received_events","type":"User","site_admin":false},"repo":{"id":38433989,"name":"mattermost-platform","full_name":"hmhealey/mattermost-platform","owner":{"login":"hmhealey","id":3277310,"avatar_url":"https://avatars.githubusercontent.com/u/3277310?v=3","gravatar_id":"","url":"https://api.github.com/users/hmhealey","html_url":"https://github.com/hmhealey","followers_url":"https://api.github.com/users/hmhealey/followers","following_url":"https://api.github.com/users/hmhealey/following{/other_user}","gists_url":"https://api.github.com/users/hmhealey/gists{/gist_id}","starred_url":"https://api.github.com/users/hmhealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmhealey/subscriptions","organizations_url":"https://api.github.com/users/hmhealey/orgs","repos_url":"https://api.github.com/users/hmhealey/repos","events_url":"https://api.github.com/users/hmhealey/events{/privacy}","received_events_url":"https://api.github.com/users/hmhealey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmhealey/mattermost-platform","description":"Open source team communication across PC & phones, with archiving & search, in Golang and React","fork":true,"url":"https://api.github.com/repos/hmhealey/mattermost-platform","forks_url":"https://api.github.com/repos/hmhealey/mattermost-platform/forks","keys_url":"https://api.github.com/repos/hmhealey/mattermost-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmhealey/mattermost-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmhealey/mattermost-platform/teams","hooks_url":"https://api.github.com/repos/hmhealey/mattermost-platform/hooks","issue_events_url":"https://api.github.com/repos/hmhealey/mattermost-platform/issues/events{/number}","events_url":"https://api.github.com/repos/hmhealey/mattermost-platform/events","assignees_url":"https://api.github.com/repos/hmhealey/mattermost-platform/assignees{/user}","branches_url":"https://api.github.com/repos/hmhealey/mattermost-platform/branches{/branch}","tags_url":"https://api.github.com/repos/hmhealey/mattermost-platform/tags","blobs_url":"https://api.github.com/repos/hmhealey/mattermost-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmhealey/mattermost-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmhealey/mattermost-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmhealey/mattermost-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmhealey/mattermost-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hmhealey/mattermost-platform/languages","stargazers_url":"https://api.github.com/repos/hmhealey/mattermost-platform/stargazers","contributors_url":"https://api.github.com/repos/hmhealey/mattermost-platform/contributors","subscribers_url":"https://api.github.com/repos/hmhealey/mattermost-platform/subscribers","subscription_url":"https://api.github.com/repos/hmhealey/mattermost-platform/subscription","commits_url":"https://api.github.com/repos/hmhealey/mattermost-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmhealey/mattermost-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmhealey/mattermost-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmhealey/mattermost-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmhealey/mattermost-platform/contents/{+path}","compare_url":"https://api.github.com/repos/hmhealey/mattermost-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmhealey/mattermost-platform/merges","archive_url":"https://api.github.com/repos/hmhealey/mattermost-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmhealey/mattermost-platform/downloads","issues_url":"https://api.github.com/repos/hmhealey/mattermost-platform/issues{/number}","pulls_url":"https://api.github.com/repos/hmhealey/mattermost-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hmhealey/mattermost-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hmhealey/mattermost-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmhealey/mattermost-platform/labels{/name}","releases_url":"https://api.github.com/repos/hmhealey/mattermost-platform/releases{/id}","created_at":"2015-07-02T13:21:29Z","updated_at":"2015-07-08T20:07:52Z","pushed_at":"2015-07-14T15:49:51Z","git_url":"git://github.com/hmhealey/mattermost-platform.git","ssh_url":"git@github.com:hmhealey/mattermost-platform.git","clone_url":"https://github.com/hmhealey/mattermost-platform.git","svn_url":"https://github.com/hmhealey/mattermost-platform","homepage":"http://mattermost.org","size":3307,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"e38ea318a1287710313a0c86fecb76dff8a923aa","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":37448451,"name":"platform","full_name":"mattermost/platform","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/platform","description":"Open source Slack-alternative in Golang and React","fork":false,"url":"https://api.github.com/repos/mattermost/platform","forks_url":"https://api.github.com/repos/mattermost/platform/forks","keys_url":"https://api.github.com/repos/mattermost/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/platform/teams","hooks_url":"https://api.github.com/repos/mattermost/platform/hooks","issue_events_url":"https://api.github.com/repos/mattermost/platform/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/platform/events","assignees_url":"https://api.github.com/repos/mattermost/platform/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/platform/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/platform/tags","blobs_url":"https://api.github.com/repos/mattermost/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/platform/languages","stargazers_url":"https://api.github.com/repos/mattermost/platform/stargazers","contributors_url":"https://api.github.com/repos/mattermost/platform/contributors","subscribers_url":"https://api.github.com/repos/mattermost/platform/subscribers","subscription_url":"https://api.github.com/repos/mattermost/platform/subscription","commits_url":"https://api.github.com/repos/mattermost/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/platform/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/platform/merges","archive_url":"https://api.github.com/repos/mattermost/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/platform/downloads","issues_url":"https://api.github.com/repos/mattermost/platform/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/platform/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/platform/releases{/id}","created_at":"2015-06-15T06:50:02Z","updated_at":"2015-07-14T15:31:09Z","pushed_at":"2015-07-14T16:07:29Z","git_url":"git://github.com/mattermost/platform.git","ssh_url":"git@github.com:mattermost/platform.git","clone_url":"https://github.com/mattermost/platform.git","svn_url":"https://github.com/mattermost/platform","homepage":"http://mattermost.org","size":4757,"stargazers_count":2227,"watchers_count":2227,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":18,"forks":175,"open_issues":18,"watchers":2227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/177"},"html":{"href":"https://github.com/mattermost/platform/pull/177"},"issue":{"href":"https://api.github.com/repos/mattermost/platform/issues/177"},"comments":{"href":"https://api.github.com/repos/mattermost/platform/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/platform/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/platform/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/platform/statuses/b2c573d7c17d481b9f8e117c32608919bc3ce7df"}}}}