{"action":"opened","number":3257,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/3257","id":44800225,"html_url":"https://github.com/juju/juju/pull/3257","diff_url":"https://github.com/juju/juju/pull/3257.diff","patch_url":"https://github.com/juju/juju/pull/3257.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/3257","number":3257,"state":"open","locked":false,"title":"store the charm settings in the same transaction that adds the service","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"body":"This fixes part of https://bugs.launchpad.net/juju-core/+bug/1486553  i/o timeout errors can cause non-atomic service deploys - the part about settings not getting set atomically when the service is added, so you can have a service added without the settings set correctly.\r\n\r\nNow the setting and service add are done in the same transaction, so if there's a service, it has the right settings, period.\r\n\r\nThis does not fix the second part of the problem, where the units may not get assigned, that can still happen (so if you deploy a service with non-zero units, you might get a service with zero units).","created_at":"2015-09-11T16:09:11Z","updated_at":"2015-09-11T16:09:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/3257/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/3257/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/3257/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/dd9f82b3b31c16135fe96bad1fad8a525db54b4e","head":{"label":"natefinch:fix-1486553-1.25","ref":"fix-1486553-1.25","sha":"dd9f82b3b31c16135fe96bad1fad8a525db54b4e","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"repo":{"id":25370863,"name":"juju","full_name":"natefinch/juju","owner":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natefinch/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/natefinch/juju","forks_url":"https://api.github.com/repos/natefinch/juju/forks","keys_url":"https://api.github.com/repos/natefinch/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natefinch/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natefinch/juju/teams","hooks_url":"https://api.github.com/repos/natefinch/juju/hooks","issue_events_url":"https://api.github.com/repos/natefinch/juju/issues/events{/number}","events_url":"https://api.github.com/repos/natefinch/juju/events","assignees_url":"https://api.github.com/repos/natefinch/juju/assignees{/user}","branches_url":"https://api.github.com/repos/natefinch/juju/branches{/branch}","tags_url":"https://api.github.com/repos/natefinch/juju/tags","blobs_url":"https://api.github.com/repos/natefinch/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natefinch/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natefinch/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/natefinch/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natefinch/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/natefinch/juju/languages","stargazers_url":"https://api.github.com/repos/natefinch/juju/stargazers","contributors_url":"https://api.github.com/repos/natefinch/juju/contributors","subscribers_url":"https://api.github.com/repos/natefinch/juju/subscribers","subscription_url":"https://api.github.com/repos/natefinch/juju/subscription","commits_url":"https://api.github.com/repos/natefinch/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/natefinch/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/natefinch/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/natefinch/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/natefinch/juju/contents/{+path}","compare_url":"https://api.github.com/repos/natefinch/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natefinch/juju/merges","archive_url":"https://api.github.com/repos/natefinch/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natefinch/juju/downloads","issues_url":"https://api.github.com/repos/natefinch/juju/issues{/number}","pulls_url":"https://api.github.com/repos/natefinch/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/natefinch/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/natefinch/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natefinch/juju/labels{/name}","releases_url":"https://api.github.com/repos/natefinch/juju/releases{/id}","created_at":"2014-10-17T18:12:48Z","updated_at":"2015-05-05T20:01:44Z","pushed_at":"2015-09-11T16:06:49Z","git_url":"git://github.com/natefinch/juju.git","ssh_url":"git@github.com:natefinch/juju.git","clone_url":"https://github.com/natefinch/juju.git","svn_url":"https://github.com/natefinch/juju","homepage":"juju.ubuntu.com","size":58597,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:1.25","ref":"1.25","sha":"5cd599b6ef08b5fdb212614641d5d383fbef16f3","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-09-10T13:44:06Z","pushed_at":"2015-09-11T16:07:59Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":94604,"stargazers_count":320,"watchers_count":320,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":91,"forks":106,"open_issues":91,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/3257"},"html":{"href":"https://github.com/juju/juju/pull/3257"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/3257"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/3257/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/3257/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/3257/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/dd9f82b3b31c16135fe96bad1fad8a525db54b4e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":43,"deletions":46,"changed_files":15}}