{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/ros2/rmw/pulls/18","id":38815926,"html_url":"https://github.com/ros2/rmw/pull/18","diff_url":"https://github.com/ros2/rmw/pull/18.diff","patch_url":"https://github.com/ros2/rmw/pull/18.patch","issue_url":"https://api.github.com/repos/ros2/rmw/issues/18","number":18,"state":"closed","locked":false,"title":"changes to support proper life cycle of rmw objects","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"The most notable change is that I've added the node handle as an argument to the destroy function for publishers and subscribers (it will be needed with server and client as well, but not until other things are fixed).\r\n\r\nOtherwise I also added a function to \"demangle\" c++ symbols so that I can print nicer error messages in the rmw implementations. However, to do this I had to change the \"error_handling\" file and therefore the library to C++. That's should be ok though since the API remains C only.\r\n\r\nConnects ros2/ros2#69","created_at":"2015-06-29T20:49:09Z","updated_at":"2015-07-15T21:23:09Z","closed_at":"2015-07-15T21:23:08Z","merged_at":"2015-07-15T21:23:08Z","merge_commit_sha":"34b2506f1676b0ca40826936fb57d2bcc5054b6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw/pulls/18/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw/pulls/18/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw/issues/18/comments","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/d154af8a3e25c8542106f5860eebecb1e33c7d8a","head":{"label":"ros2:memory_audit","ref":"memory_audit","sha":"d154af8a3e25c8542106f5860eebecb1e33c7d8a","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"name":"rmw","full_name":"ros2/rmw","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","created_at":"2014-08-07T21:35:58Z","updated_at":"2015-04-30T00:26:40Z","pushed_at":"2015-07-15T21:23:08Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":620,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"0f0d7a2e31ca6b3e3a169e2bd04356324d19529d","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"name":"rmw","full_name":"ros2/rmw","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","created_at":"2014-08-07T21:35:58Z","updated_at":"2015-04-30T00:26:40Z","pushed_at":"2015-07-15T21:23:08Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":620,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw/pulls/18"},"html":{"href":"https://github.com/ros2/rmw/pull/18"},"issue":{"href":"https://api.github.com/repos/ros2/rmw/issues/18"},"comments":{"href":"https://api.github.com/repos/ros2/rmw/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw/statuses/d154af8a3e25c8542106f5860eebecb1e33c7d8a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"comments":7,"review_comments":8,"commits":1,"additions":213,"deletions":4,"changed_files":8}}