{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/crust/issues/330","labels_url":"https://api.github.com/repos/maidsafe/crust/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/330/comments","events_url":"https://api.github.com/repos/maidsafe/crust/issues/330/events","html_url":"https://github.com/maidsafe/crust/pull/330","id":107201510,"number":330,"title":"**WIP DO NOT MERGE IT**: add handshake to connection establishment","user":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/maidsafe/crust/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"inetic","id":40127,"avatar_url":"https://avatars.githubusercontent.com/u/40127?v=3","gravatar_id":"","url":"https://api.github.com/users/inetic","html_url":"https://github.com/inetic","followers_url":"https://api.github.com/users/inetic/followers","following_url":"https://api.github.com/users/inetic/following{/other_user}","gists_url":"https://api.github.com/users/inetic/gists{/gist_id}","starred_url":"https://api.github.com/users/inetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inetic/subscriptions","organizations_url":"https://api.github.com/users/inetic/orgs","repos_url":"https://api.github.com/users/inetic/repos","events_url":"https://api.github.com/users/inetic/events{/privacy}","received_events_url":"https://api.github.com/users/inetic/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-09-18T13:20:40Z","updated_at":"2015-09-18T21:08:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/330","html_url":"https://github.com/maidsafe/crust/pull/330","diff_url":"https://github.com/maidsafe/crust/pull/330.diff","patch_url":"https://github.com/maidsafe/crust/pull/330.patch"},"body":"Solves https://maidsafe.atlassian.net/browse/MAID-1353\r\n\r\nCurrently an \"empty\" message is sent as the handshake, but the plan is\r\nto change the message to exchange public endpoints which will help with\r\nhole punching.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/330)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/crust/issues/comments/141569339","html_url":"https://github.com/maidsafe/crust/pull/330#issuecomment-141569339","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/330","id":141569339,"user":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T21:08:44Z","updated_at":"2015-09-18T21:08:44Z","body":"- `service::test::bootstrap` test is failing because `Event::BootstrapFinished` is being emitted before `Event::OnConnect` and `Event::OnAccept`. Needs to delay new node confirmation until the handshake is finished.\r\n- I'm still investigating why `service::test::connection_manager_start` is hanging. Hopefully is the same issue as above, then I can tackle the two problems with a single patch."}}