{"action":"created","comment":{"url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments/40572207","id":40572207,"diff_hunk":"@@ -26,18 +26,56 @@ https://raw.githubusercontent.com/fluid-project/chartAuthoring/master/LICENSE.tx\n             },\n             dataEntryPanel: {\n                 type: \"floe.chartAuthoring.dataEntryPanel\",\n-                createOnEvent: \"onTemplatesLoaded\",\n-                container: \"{chartAuthoring}.container\",\n+                createOnEvent: \"onPieChartReady\",","path":"src/js/chartAuthoring.js","position":6,"original_position":6,"commit_id":"5ea5e0bac6cb49f9a5f2ebe49e06f94346c2ac44","original_commit_id":"5ea5e0bac6cb49f9a5f2ebe49e06f94346c2ac44","user":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"body":"I found that independently instantiating them caused this error related to the modelRelay configuration: \r\n\r\n> infusion-custom.js:12039 Uncaught Error: Assertion failure - check console for more details: Error in modelRelay record member \"target\": {floe.chartAuthoring.pieChart}.model.dataSet must be a reference to an existing component\r\n\r\nI found this was also true if the modelRelay was configured in the pieChart component instead of the dataEntryPanel.","created_at":"2015-09-28T16:21:55Z","updated_at":"2015-09-28T16:21:55Z","html_url":"https://github.com/fluid-project/chartAuthoring/pull/7#discussion_r40572207","pull_request_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments/40572207"},"html":{"href":"https://github.com/fluid-project/chartAuthoring/pull/7#discussion_r40572207"},"pull_request":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7","id":46159757,"html_url":"https://github.com/fluid-project/chartAuthoring/pull/7","diff_url":"https://github.com/fluid-project/chartAuthoring/pull/7.diff","patch_url":"https://github.com/fluid-project/chartAuthoring/pull/7.patch","issue_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/7","number":7,"state":"open","locked":false,"title":"Pull request for FLOE-412 (connection of data entry form and pie chart)","user":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"body":"This supplies the model relaying between the data entry form and the pie chart component. Includes a basic demo where you can enter data and see the chart update in real time.","created_at":"2015-09-28T13:59:15Z","updated_at":"2015-09-28T16:21:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b67aec65c6221af707325ee54bf2b7868d244cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7/commits","review_comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7/comments","review_comment_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/7/comments","statuses_url":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/5ea5e0bac6cb49f9a5f2ebe49e06f94346c2ac44","head":{"label":"waharnum:FLOE-412","ref":"FLOE-412","sha":"5ea5e0bac6cb49f9a5f2ebe49e06f94346c2ac44","user":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"repo":{"id":40918997,"name":"chartAuthoring","full_name":"waharnum/chartAuthoring","owner":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waharnum/chartAuthoring","description":"A tool for authoring accessible charts for the web.","fork":true,"url":"https://api.github.com/repos/waharnum/chartAuthoring","forks_url":"https://api.github.com/repos/waharnum/chartAuthoring/forks","keys_url":"https://api.github.com/repos/waharnum/chartAuthoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waharnum/chartAuthoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waharnum/chartAuthoring/teams","hooks_url":"https://api.github.com/repos/waharnum/chartAuthoring/hooks","issue_events_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues/events{/number}","events_url":"https://api.github.com/repos/waharnum/chartAuthoring/events","assignees_url":"https://api.github.com/repos/waharnum/chartAuthoring/assignees{/user}","branches_url":"https://api.github.com/repos/waharnum/chartAuthoring/branches{/branch}","tags_url":"https://api.github.com/repos/waharnum/chartAuthoring/tags","blobs_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waharnum/chartAuthoring/statuses/{sha}","languages_url":"https://api.github.com/repos/waharnum/chartAuthoring/languages","stargazers_url":"https://api.github.com/repos/waharnum/chartAuthoring/stargazers","contributors_url":"https://api.github.com/repos/waharnum/chartAuthoring/contributors","subscribers_url":"https://api.github.com/repos/waharnum/chartAuthoring/subscribers","subscription_url":"https://api.github.com/repos/waharnum/chartAuthoring/subscription","commits_url":"https://api.github.com/repos/waharnum/chartAuthoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/waharnum/chartAuthoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/waharnum/chartAuthoring/contents/{+path}","compare_url":"https://api.github.com/repos/waharnum/chartAuthoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waharnum/chartAuthoring/merges","archive_url":"https://api.github.com/repos/waharnum/chartAuthoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waharnum/chartAuthoring/downloads","issues_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues{/number}","pulls_url":"https://api.github.com/repos/waharnum/chartAuthoring/pulls{/number}","milestones_url":"https://api.github.com/repos/waharnum/chartAuthoring/milestones{/number}","notifications_url":"https://api.github.com/repos/waharnum/chartAuthoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waharnum/chartAuthoring/labels{/name}","releases_url":"https://api.github.com/repos/waharnum/chartAuthoring/releases{/id}","created_at":"2015-08-17T18:35:53Z","updated_at":"2015-08-17T18:35:54Z","pushed_at":"2015-09-28T16:03:33Z","git_url":"git://github.com/waharnum/chartAuthoring.git","ssh_url":"git@github.com:waharnum/chartAuthoring.git","clone_url":"https://github.com/waharnum/chartAuthoring.git","svn_url":"https://github.com/waharnum/chartAuthoring","homepage":null,"size":1570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluid-project:master","ref":"master","sha":"71408f7b48ca0cd70fad37a994dfaf3d95cb2e80","user":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"repo":{"id":37926920,"name":"chartAuthoring","full_name":"fluid-project/chartAuthoring","owner":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluid-project/chartAuthoring","description":"A tool for authoring accessible charts for the web.","fork":false,"url":"https://api.github.com/repos/fluid-project/chartAuthoring","forks_url":"https://api.github.com/repos/fluid-project/chartAuthoring/forks","keys_url":"https://api.github.com/repos/fluid-project/chartAuthoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluid-project/chartAuthoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluid-project/chartAuthoring/teams","hooks_url":"https://api.github.com/repos/fluid-project/chartAuthoring/hooks","issue_events_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/events{/number}","events_url":"https://api.github.com/repos/fluid-project/chartAuthoring/events","assignees_url":"https://api.github.com/repos/fluid-project/chartAuthoring/assignees{/user}","branches_url":"https://api.github.com/repos/fluid-project/chartAuthoring/branches{/branch}","tags_url":"https://api.github.com/repos/fluid-project/chartAuthoring/tags","blobs_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/{sha}","languages_url":"https://api.github.com/repos/fluid-project/chartAuthoring/languages","stargazers_url":"https://api.github.com/repos/fluid-project/chartAuthoring/stargazers","contributors_url":"https://api.github.com/repos/fluid-project/chartAuthoring/contributors","subscribers_url":"https://api.github.com/repos/fluid-project/chartAuthoring/subscribers","subscription_url":"https://api.github.com/repos/fluid-project/chartAuthoring/subscription","commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluid-project/chartAuthoring/contents/{+path}","compare_url":"https://api.github.com/repos/fluid-project/chartAuthoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluid-project/chartAuthoring/merges","archive_url":"https://api.github.com/repos/fluid-project/chartAuthoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluid-project/chartAuthoring/downloads","issues_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues{/number}","pulls_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls{/number}","milestones_url":"https://api.github.com/repos/fluid-project/chartAuthoring/milestones{/number}","notifications_url":"https://api.github.com/repos/fluid-project/chartAuthoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluid-project/chartAuthoring/labels{/name}","releases_url":"https://api.github.com/repos/fluid-project/chartAuthoring/releases{/id}","created_at":"2015-06-23T15:16:51Z","updated_at":"2015-06-24T17:07:26Z","pushed_at":"2015-09-28T13:59:15Z","git_url":"git://github.com/fluid-project/chartAuthoring.git","ssh_url":"git@github.com:fluid-project/chartAuthoring.git","clone_url":"https://github.com/fluid-project/chartAuthoring.git","svn_url":"https://github.com/fluid-project/chartAuthoring","homepage":null,"size":1586,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7"},"html":{"href":"https://github.com/fluid-project/chartAuthoring/pull/7"},"issue":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/7"},"comments":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/5ea5e0bac6cb49f9a5f2ebe49e06f94346c2ac44"}}}}