{"action":"opened","number":100,"pull_request":{"url":"https://api.github.com/repos/astroswego/plotypus/pulls/100","id":54770652,"html_url":"https://github.com/astroswego/plotypus/pull/100","diff_url":"https://github.com/astroswego/plotypus/pull/100.diff","patch_url":"https://github.com/astroswego/plotypus/pull/100.patch","issue_url":"https://api.github.com/repos/astroswego/plotypus/issues/100","number":100,"state":"open","locked":false,"title":"Unnecessary phasing fix","user":{"login":"dwysocki","id":1548964,"avatar_url":"https://avatars.githubusercontent.com/u/1548964?v=3","gravatar_id":"","url":"https://api.github.com/users/dwysocki","html_url":"https://github.com/dwysocki","followers_url":"https://api.github.com/users/dwysocki/followers","following_url":"https://api.github.com/users/dwysocki/following{/other_user}","gists_url":"https://api.github.com/users/dwysocki/gists{/gist_id}","starred_url":"https://api.github.com/users/dwysocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwysocki/subscriptions","organizations_url":"https://api.github.com/users/dwysocki/orgs","repos_url":"https://api.github.com/users/dwysocki/repos","events_url":"https://api.github.com/users/dwysocki/events{/privacy}","received_events_url":"https://api.github.com/users/dwysocki/received_events","type":"User","site_admin":false},"body":"This solves most of the problem described in #77. I'm stealing the description of this pull request from the commit that contains most of the changes.\r\n\r\nThe main point of this commit was to deal with temporal-space data\r\ninstead of phase-space data wherever possible. This was especially\r\nimportant in the `Fourier` class, to prepare for multiperiodic signal\r\nsupport. Now the period needs to be provided to `Fourier` before\r\n`Fourier.fit` or `Fourier.transform` is called. To allow for setting the\r\n`period` parameter properly when `Fourier` is nested within another\r\nestimator, I had to make `Fourier` a subclass of scikit-learn's\r\n`BaseEstimator`, which we should have done long ago.\r\n\r\nMost of the changes in `get_lightcurve` deal with replacing `phase` with\r\n`time`. There are also some changes which deal with providing the\r\ncorrect data when dealing with masked arrays. There is also a new piece\r\nof code which passes the period into the `Fourier` object, which\r\nrequired a little bit of hackery (see the comments before the call to\r\n`predictor.set_params`).\r\n\r\nThe `rephase` function in `plotypus.periodogram` was also modified, such\r\nthat masked values are still rephased.","created_at":"2015-12-30T00:59:47Z","updated_at":"2015-12-30T00:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astroswego/plotypus/pulls/100/commits","review_comments_url":"https://api.github.com/repos/astroswego/plotypus/pulls/100/comments","review_comment_url":"https://api.github.com/repos/astroswego/plotypus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astroswego/plotypus/issues/100/comments","statuses_url":"https://api.github.com/repos/astroswego/plotypus/statuses/43e39e80d62f219c1946ea39aa008279fa643f4a","head":{"label":"astroswego:unnecessary-phasing-fix","ref":"unnecessary-phasing-fix","sha":"43e39e80d62f219c1946ea39aa008279fa643f4a","user":{"login":"astroswego","id":7622941,"avatar_url":"https://avatars.githubusercontent.com/u/7622941?v=3","gravatar_id":"","url":"https://api.github.com/users/astroswego","html_url":"https://github.com/astroswego","followers_url":"https://api.github.com/users/astroswego/followers","following_url":"https://api.github.com/users/astroswego/following{/other_user}","gists_url":"https://api.github.com/users/astroswego/gists{/gist_id}","starred_url":"https://api.github.com/users/astroswego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroswego/subscriptions","organizations_url":"https://api.github.com/users/astroswego/orgs","repos_url":"https://api.github.com/users/astroswego/repos","events_url":"https://api.github.com/users/astroswego/events{/privacy}","received_events_url":"https://api.github.com/users/astroswego/received_events","type":"Organization","site_admin":false},"repo":{"id":13476523,"name":"plotypus","full_name":"astroswego/plotypus","owner":{"login":"astroswego","id":7622941,"avatar_url":"https://avatars.githubusercontent.com/u/7622941?v=3","gravatar_id":"","url":"https://api.github.com/users/astroswego","html_url":"https://github.com/astroswego","followers_url":"https://api.github.com/users/astroswego/followers","following_url":"https://api.github.com/users/astroswego/following{/other_user}","gists_url":"https://api.github.com/users/astroswego/gists{/gist_id}","starred_url":"https://api.github.com/users/astroswego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroswego/subscriptions","organizations_url":"https://api.github.com/users/astroswego/orgs","repos_url":"https://api.github.com/users/astroswego/repos","events_url":"https://api.github.com/users/astroswego/events{/privacy}","received_events_url":"https://api.github.com/users/astroswego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astroswego/plotypus","description":"A Python library and command line utility for manipulating and plotting stellar lightcurves.","fork":false,"url":"https://api.github.com/repos/astroswego/plotypus","forks_url":"https://api.github.com/repos/astroswego/plotypus/forks","keys_url":"https://api.github.com/repos/astroswego/plotypus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astroswego/plotypus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astroswego/plotypus/teams","hooks_url":"https://api.github.com/repos/astroswego/plotypus/hooks","issue_events_url":"https://api.github.com/repos/astroswego/plotypus/issues/events{/number}","events_url":"https://api.github.com/repos/astroswego/plotypus/events","assignees_url":"https://api.github.com/repos/astroswego/plotypus/assignees{/user}","branches_url":"https://api.github.com/repos/astroswego/plotypus/branches{/branch}","tags_url":"https://api.github.com/repos/astroswego/plotypus/tags","blobs_url":"https://api.github.com/repos/astroswego/plotypus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astroswego/plotypus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astroswego/plotypus/git/refs{/sha}","trees_url":"https://api.github.com/repos/astroswego/plotypus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astroswego/plotypus/statuses/{sha}","languages_url":"https://api.github.com/repos/astroswego/plotypus/languages","stargazers_url":"https://api.github.com/repos/astroswego/plotypus/stargazers","contributors_url":"https://api.github.com/repos/astroswego/plotypus/contributors","subscribers_url":"https://api.github.com/repos/astroswego/plotypus/subscribers","subscription_url":"https://api.github.com/repos/astroswego/plotypus/subscription","commits_url":"https://api.github.com/repos/astroswego/plotypus/commits{/sha}","git_commits_url":"https://api.github.com/repos/astroswego/plotypus/git/commits{/sha}","comments_url":"https://api.github.com/repos/astroswego/plotypus/comments{/number}","issue_comment_url":"https://api.github.com/repos/astroswego/plotypus/issues/comments{/number}","contents_url":"https://api.github.com/repos/astroswego/plotypus/contents/{+path}","compare_url":"https://api.github.com/repos/astroswego/plotypus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astroswego/plotypus/merges","archive_url":"https://api.github.com/repos/astroswego/plotypus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astroswego/plotypus/downloads","issues_url":"https://api.github.com/repos/astroswego/plotypus/issues{/number}","pulls_url":"https://api.github.com/repos/astroswego/plotypus/pulls{/number}","milestones_url":"https://api.github.com/repos/astroswego/plotypus/milestones{/number}","notifications_url":"https://api.github.com/repos/astroswego/plotypus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astroswego/plotypus/labels{/name}","releases_url":"https://api.github.com/repos/astroswego/plotypus/releases{/id}","created_at":"2013-10-10T16:20:44Z","updated_at":"2015-11-03T23:58:32Z","pushed_at":"2015-12-30T00:56:02Z","git_url":"git://github.com/astroswego/plotypus.git","ssh_url":"git@github.com:astroswego/plotypus.git","clone_url":"https://github.com/astroswego/plotypus.git","svn_url":"https://github.com/astroswego/plotypus","homepage":"","size":2722,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":31,"forks":1,"open_issues":31,"watchers":7,"default_branch":"master"}},"base":{"label":"astroswego:develop","ref":"develop","sha":"6e8c3461ab21633062ec7260780f920c03bbb331","user":{"login":"astroswego","id":7622941,"avatar_url":"https://avatars.githubusercontent.com/u/7622941?v=3","gravatar_id":"","url":"https://api.github.com/users/astroswego","html_url":"https://github.com/astroswego","followers_url":"https://api.github.com/users/astroswego/followers","following_url":"https://api.github.com/users/astroswego/following{/other_user}","gists_url":"https://api.github.com/users/astroswego/gists{/gist_id}","starred_url":"https://api.github.com/users/astroswego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroswego/subscriptions","organizations_url":"https://api.github.com/users/astroswego/orgs","repos_url":"https://api.github.com/users/astroswego/repos","events_url":"https://api.github.com/users/astroswego/events{/privacy}","received_events_url":"https://api.github.com/users/astroswego/received_events","type":"Organization","site_admin":false},"repo":{"id":13476523,"name":"plotypus","full_name":"astroswego/plotypus","owner":{"login":"astroswego","id":7622941,"avatar_url":"https://avatars.githubusercontent.com/u/7622941?v=3","gravatar_id":"","url":"https://api.github.com/users/astroswego","html_url":"https://github.com/astroswego","followers_url":"https://api.github.com/users/astroswego/followers","following_url":"https://api.github.com/users/astroswego/following{/other_user}","gists_url":"https://api.github.com/users/astroswego/gists{/gist_id}","starred_url":"https://api.github.com/users/astroswego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroswego/subscriptions","organizations_url":"https://api.github.com/users/astroswego/orgs","repos_url":"https://api.github.com/users/astroswego/repos","events_url":"https://api.github.com/users/astroswego/events{/privacy}","received_events_url":"https://api.github.com/users/astroswego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astroswego/plotypus","description":"A Python library and command line utility for manipulating and plotting stellar lightcurves.","fork":false,"url":"https://api.github.com/repos/astroswego/plotypus","forks_url":"https://api.github.com/repos/astroswego/plotypus/forks","keys_url":"https://api.github.com/repos/astroswego/plotypus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astroswego/plotypus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astroswego/plotypus/teams","hooks_url":"https://api.github.com/repos/astroswego/plotypus/hooks","issue_events_url":"https://api.github.com/repos/astroswego/plotypus/issues/events{/number}","events_url":"https://api.github.com/repos/astroswego/plotypus/events","assignees_url":"https://api.github.com/repos/astroswego/plotypus/assignees{/user}","branches_url":"https://api.github.com/repos/astroswego/plotypus/branches{/branch}","tags_url":"https://api.github.com/repos/astroswego/plotypus/tags","blobs_url":"https://api.github.com/repos/astroswego/plotypus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astroswego/plotypus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astroswego/plotypus/git/refs{/sha}","trees_url":"https://api.github.com/repos/astroswego/plotypus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astroswego/plotypus/statuses/{sha}","languages_url":"https://api.github.com/repos/astroswego/plotypus/languages","stargazers_url":"https://api.github.com/repos/astroswego/plotypus/stargazers","contributors_url":"https://api.github.com/repos/astroswego/plotypus/contributors","subscribers_url":"https://api.github.com/repos/astroswego/plotypus/subscribers","subscription_url":"https://api.github.com/repos/astroswego/plotypus/subscription","commits_url":"https://api.github.com/repos/astroswego/plotypus/commits{/sha}","git_commits_url":"https://api.github.com/repos/astroswego/plotypus/git/commits{/sha}","comments_url":"https://api.github.com/repos/astroswego/plotypus/comments{/number}","issue_comment_url":"https://api.github.com/repos/astroswego/plotypus/issues/comments{/number}","contents_url":"https://api.github.com/repos/astroswego/plotypus/contents/{+path}","compare_url":"https://api.github.com/repos/astroswego/plotypus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astroswego/plotypus/merges","archive_url":"https://api.github.com/repos/astroswego/plotypus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astroswego/plotypus/downloads","issues_url":"https://api.github.com/repos/astroswego/plotypus/issues{/number}","pulls_url":"https://api.github.com/repos/astroswego/plotypus/pulls{/number}","milestones_url":"https://api.github.com/repos/astroswego/plotypus/milestones{/number}","notifications_url":"https://api.github.com/repos/astroswego/plotypus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astroswego/plotypus/labels{/name}","releases_url":"https://api.github.com/repos/astroswego/plotypus/releases{/id}","created_at":"2013-10-10T16:20:44Z","updated_at":"2015-11-03T23:58:32Z","pushed_at":"2015-12-30T00:56:02Z","git_url":"git://github.com/astroswego/plotypus.git","ssh_url":"git@github.com:astroswego/plotypus.git","clone_url":"https://github.com/astroswego/plotypus.git","svn_url":"https://github.com/astroswego/plotypus","homepage":"","size":2722,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":31,"forks":1,"open_issues":31,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astroswego/plotypus/pulls/100"},"html":{"href":"https://github.com/astroswego/plotypus/pull/100"},"issue":{"href":"https://api.github.com/repos/astroswego/plotypus/issues/100"},"comments":{"href":"https://api.github.com/repos/astroswego/plotypus/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/astroswego/plotypus/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/astroswego/plotypus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astroswego/plotypus/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/astroswego/plotypus/statuses/43e39e80d62f219c1946ea39aa008279fa643f4a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":110,"deletions":89,"changed_files":4}}