{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/sarama/issues/234","labels_url":"https://api.github.com/repos/Shopify/sarama/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/sarama/issues/234/comments","events_url":"https://api.github.com/repos/Shopify/sarama/issues/234/events","html_url":"https://github.com/Shopify/sarama/pull/234","id":52397680,"number":234,"title":"Retry more than once","user":{"login":"eapache","id":1706826,"avatar_url":"https://avatars.githubusercontent.com/u/1706826?v=3","gravatar_id":"","url":"https://api.github.com/users/eapache","html_url":"https://github.com/eapache","followers_url":"https://api.github.com/users/eapache/followers","following_url":"https://api.github.com/users/eapache/following{/other_user}","gists_url":"https://api.github.com/users/eapache/gists{/gist_id}","starred_url":"https://api.github.com/users/eapache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eapache/subscriptions","organizations_url":"https://api.github.com/users/eapache/orgs","repos_url":"https://api.github.com/users/eapache/repos","events_url":"https://api.github.com/users/eapache/events{/privacy}","received_events_url":"https://api.github.com/users/eapache/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-18T18:12:45Z","updated_at":"2015-02-19T15:28:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/sarama/pulls/234","html_url":"https://github.com/Shopify/sarama/pull/234","diff_url":"https://github.com/Shopify/sarama/pull/234.diff","patch_url":"https://github.com/Shopify/sarama/pull/234.patch"},"body":"Implement multiple in-order retries in the producer.\r\n\r\nThe mental model here is a fairly straightforward expansion of the existing single-retry logic (where the messages go through the pipeline again, and the `leaderDispatcher` pauses un-retried messages until all the retries have happened in order to preserve ordering).\r\n\r\nThe new version just keeps track of the high-watermark retry in progress (aka how many times the most-retried in-flight message has been retried) and makes sure that all messages with a lower retry-count are paused until the chaser has been seen. \r\n\r\nFixes #232"},"comment":{"url":"https://api.github.com/repos/Shopify/sarama/issues/comments/75071045","html_url":"https://github.com/Shopify/sarama/pull/234#issuecomment-75071045","issue_url":"https://api.github.com/repos/Shopify/sarama/issues/234","id":75071045,"user":{"login":"eapache","id":1706826,"avatar_url":"https://avatars.githubusercontent.com/u/1706826?v=3","gravatar_id":"","url":"https://api.github.com/users/eapache","html_url":"https://github.com/eapache","followers_url":"https://api.github.com/users/eapache/followers","following_url":"https://api.github.com/users/eapache/following{/other_user}","gists_url":"https://api.github.com/users/eapache/gists{/gist_id}","starred_url":"https://api.github.com/users/eapache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eapache/subscriptions","organizations_url":"https://api.github.com/users/eapache/orgs","repos_url":"https://api.github.com/users/eapache/repos","events_url":"https://api.github.com/users/eapache/events{/privacy}","received_events_url":"https://api.github.com/users/eapache/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T15:28:25Z","updated_at":"2015-02-19T15:28:25Z","body":"@Shopify/kafka this is ready for review. Let me know if you want a walkthrough meeting (it's actually a fairly small number of lines-of-code changed, but the logic can be fairly subtle)."}}