{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/43136705","id":43136705,"diff_hunk":"@@ -63,10 +66,21 @@ public RecordCollector(Producer<byte[], byte[]> producer) {\n         this.offsets = new HashMap<>();\n     }\n \n-    public <K, V> void send(ProducerRecord<K, V> record, Serializer<K> keySerializer, Serializer<V> valueSerializer) {\n+    public void send(ProducerRecord<byte[], byte[]> record) {\n+        this.producer.send(record, callback);\n+    }\n+\n+    public <K, V> void send(ProducerRecord<K, V> record, Serializer<K> keySerializer, Serializer<V> valueSerializer,","path":"streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollector.java","position":null,"original_position":25,"commit_id":"302adcb821c2d9622aebda179d799525cbdf3f7e","original_commit_id":"fceeb9b0ad20cb3fe8a99f2cc9d9dc24a5a1f258","user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2015-10-27T15:22:23Z","updated_at":"2015-10-27T15:22:23Z","html_url":"https://github.com/apache/kafka/pull/309#discussion_r43136705","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/43136705"},"html":{"href":"https://github.com/apache/kafka/pull/309#discussion_r43136705"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/309","id":47676955,"html_url":"https://github.com/apache/kafka/pull/309","diff_url":"https://github.com/apache/kafka/pull/309.diff","patch_url":"https://github.com/apache/kafka/pull/309.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/309","number":309,"state":"open","locked":false,"title":"KAFKA-2649 Add support for custom partitioning in topology sinks","user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"body":"Added option to use custom partitioning logic within each topology sink.","created_at":"2015-10-14T15:45:45Z","updated_at":"2015-10-27T15:22:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6db80b677e7320a69f87af60d5af218d731878b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/309/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/309/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/309/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/302adcb821c2d9622aebda179d799525cbdf3f7e","head":{"label":"rhauch:kafka-2649","ref":"kafka-2649","sha":"302adcb821c2d9622aebda179d799525cbdf3f7e","user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"repo":{"id":40898643,"name":"kafka","full_name":"rhauch/kafka","owner":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhauch/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/rhauch/kafka","forks_url":"https://api.github.com/repos/rhauch/kafka/forks","keys_url":"https://api.github.com/repos/rhauch/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhauch/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhauch/kafka/teams","hooks_url":"https://api.github.com/repos/rhauch/kafka/hooks","issue_events_url":"https://api.github.com/repos/rhauch/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/rhauch/kafka/events","assignees_url":"https://api.github.com/repos/rhauch/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/rhauch/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/rhauch/kafka/tags","blobs_url":"https://api.github.com/repos/rhauch/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhauch/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhauch/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhauch/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhauch/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/rhauch/kafka/languages","stargazers_url":"https://api.github.com/repos/rhauch/kafka/stargazers","contributors_url":"https://api.github.com/repos/rhauch/kafka/contributors","subscribers_url":"https://api.github.com/repos/rhauch/kafka/subscribers","subscription_url":"https://api.github.com/repos/rhauch/kafka/subscription","commits_url":"https://api.github.com/repos/rhauch/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhauch/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhauch/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhauch/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhauch/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/rhauch/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhauch/kafka/merges","archive_url":"https://api.github.com/repos/rhauch/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhauch/kafka/downloads","issues_url":"https://api.github.com/repos/rhauch/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/rhauch/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/rhauch/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/rhauch/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhauch/kafka/labels{/name}","releases_url":"https://api.github.com/repos/rhauch/kafka/releases{/id}","created_at":"2015-08-17T13:51:02Z","updated_at":"2015-08-17T13:51:05Z","pushed_at":"2015-10-27T15:22:19Z","git_url":"git://github.com/rhauch/kafka.git","ssh_url":"git@github.com:rhauch/kafka.git","clone_url":"https://github.com/rhauch/kafka.git","svn_url":"https://github.com/rhauch/kafka","homepage":null,"size":24654,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"2fd645ac2fec7cf089cb8175ee47823b67a07226","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-10-27T12:46:18Z","pushed_at":"2015-10-27T15:22:20Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":40524,"stargazers_count":2115,"watchers_count":2115,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1253,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":98,"forks":1253,"open_issues":98,"watchers":2115,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/309"},"html":{"href":"https://github.com/apache/kafka/pull/309"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/309"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/302adcb821c2d9622aebda179d799525cbdf3f7e"}}}}