{"action":"created","issue":{"url":"https://api.github.com/repos/influxdb/influxdb-python/issues/144","labels_url":"https://api.github.com/repos/influxdb/influxdb-python/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/influxdb/influxdb-python/issues/144/comments","events_url":"https://api.github.com/repos/influxdb/influxdb-python/issues/144/events","html_url":"https://github.com/influxdb/influxdb-python/pull/144","id":65264914,"number":144,"title":"Issue 143 (proposed)","user":{"login":"gst","id":38055,"avatar_url":"https://avatars.githubusercontent.com/u/38055?v=3","gravatar_id":"","url":"https://api.github.com/users/gst","html_url":"https://github.com/gst","followers_url":"https://api.github.com/users/gst/followers","following_url":"https://api.github.com/users/gst/following{/other_user}","gists_url":"https://api.github.com/users/gst/gists{/gist_id}","starred_url":"https://api.github.com/users/gst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gst/subscriptions","organizations_url":"https://api.github.com/users/gst/orgs","repos_url":"https://api.github.com/users/gst/repos","events_url":"https://api.github.com/users/gst/events{/privacy}","received_events_url":"https://api.github.com/users/gst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-30T17:49:34Z","updated_at":"2015-03-30T18:12:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb-python/pulls/144","html_url":"https://github.com/influxdb/influxdb-python/pull/144","diff_url":"https://github.com/influxdb/influxdb-python/pull/144.diff","patch_url":"https://github.com/influxdb/influxdb-python/pull/144.patch"},"body":"Fix issue #143 \r\n\r\nAdapted `format_query_response()` to also handle tags returned.\r\n\r\nI'd like some advices on the format I use to distinguish same serie with different tags.\r\nBasically : if there are some tag(s) returned by a query then store them in the result by providing a unique entry for each such unique serie + tag(s) value(s) with `name = (row['name'], tuple(tags.values()))`\r\n\r\nNow after thinking about it twice I think in fact I should also include the tags.keys() somewhere.. also more than probably in the `name` attribute of each result dict with `name = (row['name'], tuple(tags.items()))`   (*items* simply instead of *values* so) ; so that the caller can know which tag value correspond to which tag name..  otherwise if the groupby is done on multiple tags so then the caller can't know for sure the order of the tags as returned in the answer.\r\n\r\nwdyt ?\r\n"},"comment":{"url":"https://api.github.com/repos/influxdb/influxdb-python/issues/comments/87777380","html_url":"https://github.com/influxdb/influxdb-python/pull/144#issuecomment-87777380","issue_url":"https://api.github.com/repos/influxdb/influxdb-python/issues/144","id":87777380,"user":{"login":"ReAzem","id":2706882,"avatar_url":"https://avatars.githubusercontent.com/u/2706882?v=3","gravatar_id":"","url":"https://api.github.com/users/ReAzem","html_url":"https://github.com/ReAzem","followers_url":"https://api.github.com/users/ReAzem/followers","following_url":"https://api.github.com/users/ReAzem/following{/other_user}","gists_url":"https://api.github.com/users/ReAzem/gists{/gist_id}","starred_url":"https://api.github.com/users/ReAzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReAzem/subscriptions","organizations_url":"https://api.github.com/users/ReAzem/orgs","repos_url":"https://api.github.com/users/ReAzem/repos","events_url":"https://api.github.com/users/ReAzem/events{/privacy}","received_events_url":"https://api.github.com/users/ReAzem/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T18:12:27Z","updated_at":"2015-03-30T18:12:27Z","body":"> so we can't use a dict as one of its component (not hashable)\r\n\r\nYou are right! :(\r\n\r\n> so my tags.items() good second choice I think..\r\n\r\nAbsolutely."}}