{"action":"closed","number":867,"pull_request":{"url":"https://api.github.com/repos/INN/Largo/pulls/867","id":43235050,"html_url":"https://github.com/INN/Largo/pull/867","diff_url":"https://github.com/INN/Largo/pull/867.diff","patch_url":"https://github.com/INN/Largo/pull/867.patch","issue_url":"https://api.github.com/repos/INN/Largo/issues/867","number":867,"state":"closed","locked":false,"title":"Import NPQ mobile nav styles into Largo","user":{"login":"benlk","id":1754187,"avatar_url":"https://avatars.githubusercontent.com/u/1754187?v=3","gravatar_id":"","url":"https://api.github.com/users/benlk","html_url":"https://github.com/benlk","followers_url":"https://api.github.com/users/benlk/followers","following_url":"https://api.github.com/users/benlk/following{/other_user}","gists_url":"https://api.github.com/users/benlk/gists{/gist_id}","starred_url":"https://api.github.com/users/benlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlk/subscriptions","organizations_url":"https://api.github.com/users/benlk/orgs","repos_url":"https://api.github.com/users/benlk/repos","events_url":"https://api.github.com/users/benlk/events{/privacy}","received_events_url":"https://api.github.com/users/benlk/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\nThis copies over the NPQ styles into Largo.\r\n\r\n- Carets point right before drop-downs are opened, and then point down.\r\n- Third-level and fourth-level menu items are hidden more forcefully\r\n- Highlights on active and hovered menu items are removed *on mobile only*\r\n- Menu hamburger becomes dark on light, using the standard link color for the bars. Previously, this had used the link color for the box and white for the bars.\r\n- Text and carets in sticky nav are now all using the standard link color.\r\n- Remove all styles pertaining to `.nav-middle` and `.nav-collapse`, which were not found in any Largo HTML, PHP, CSS, or JavaScript.\r\n\r\nBefore (Using plain Largo)\r\n\r\n<img width=\"717\" alt=\"screen shot 2015-08-24 at 7 31 39 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455227/d0fa3d34-4a96-11e5-8a4a-b3d63b1aa374.png\">\r\n<img width=\"717\" alt=\"screen shot 2015-08-24 at 7 31 46 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455229/d104b2f0-4a96-11e5-8b04-9ec32ad6eff2.png\">\r\n<img width=\"718\" alt=\"screen shot 2015-08-24 at 7 31 55 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455228/d1032660-4a96-11e5-9a3b-f2be26138d0c.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"716\" alt=\"screen shot 2015-08-24 at 7 30 06 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455210/b343b036-4a96-11e5-8e0a-b324c1983aa1.png\">\r\n<img width=\"718\" alt=\"screen shot 2015-08-24 at 7 30 21 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455211/b346067e-4a96-11e5-81e2-017bb0b23076.png\">\r\n<img width=\"717\" alt=\"screen shot 2015-08-24 at 7 30 36 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455209/b343088e-4a96-11e5-9db9-10e0a0f72402.png\">\r\n<img width=\"716\" alt=\"screen shot 2015-08-24 at 7 30 54 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9455208/b341d450-4a96-11e5-8d1b-886c063b5c77.png\">\r\n\r\n## To do\r\n\r\n- [x] check child themes\r\n    - [x] NPQ (Customized)\r\n    - [x] Voice of OC (Uses a bright Yellow, also heavily customized)\r\n    - [x] Current.org\r\n    - [x] City Limits\r\n    - [x] Youth Today\r\n    - [x] Catalyst Chigao - will rpobably need custom work on .icon-bars\r\n    - [x] Where else have we done heavy header customization?\r\n- [x] check other browsers\r\n    - [ ] IE\r\n    - [x] Safari\r\n    - [x] Firefox\r\n    - [ ] Old Android\r\n- [x] create post-deploy list of sites to update, and what updates they need\r\n\r\n## Why\r\n\r\nFor [SN-4](http://jira.inn.org/browse/SN-4) and #807. (See also #732)","created_at":"2015-08-24T23:42:58Z","updated_at":"2015-09-17T14:25:18Z","closed_at":"2015-09-17T14:25:17Z","merged_at":null,"merge_commit_sha":"3e41972865fbe505e3ba45c2771fc6b4ea699a0e","assignee":{"login":"rnagle","id":72608,"avatar_url":"https://avatars.githubusercontent.com/u/72608?v=3","gravatar_id":"","url":"https://api.github.com/users/rnagle","html_url":"https://github.com/rnagle","followers_url":"https://api.github.com/users/rnagle/followers","following_url":"https://api.github.com/users/rnagle/following{/other_user}","gists_url":"https://api.github.com/users/rnagle/gists{/gist_id}","starred_url":"https://api.github.com/users/rnagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnagle/subscriptions","organizations_url":"https://api.github.com/users/rnagle/orgs","repos_url":"https://api.github.com/users/rnagle/repos","events_url":"https://api.github.com/users/rnagle/events{/privacy}","received_events_url":"https://api.github.com/users/rnagle/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/INN/Largo/milestones/13","html_url":"https://github.com/INN/Largo/milestones/0.5.4%20-%20Header/Navigation","labels_url":"https://api.github.com/repos/INN/Largo/milestones/13/labels","id":1232007,"number":13,"title":"0.5.4 - Header/Navigation","description":"","creator":{"login":"aschweigert","id":490703,"avatar_url":"https://avatars.githubusercontent.com/u/490703?v=3","gravatar_id":"","url":"https://api.github.com/users/aschweigert","html_url":"https://github.com/aschweigert","followers_url":"https://api.github.com/users/aschweigert/followers","following_url":"https://api.github.com/users/aschweigert/following{/other_user}","gists_url":"https://api.github.com/users/aschweigert/gists{/gist_id}","starred_url":"https://api.github.com/users/aschweigert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschweigert/subscriptions","organizations_url":"https://api.github.com/users/aschweigert/orgs","repos_url":"https://api.github.com/users/aschweigert/repos","events_url":"https://api.github.com/users/aschweigert/events{/privacy}","received_events_url":"https://api.github.com/users/aschweigert/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":3,"state":"open","created_at":"2015-07-29T17:23:02Z","updated_at":"2015-09-17T14:25:17Z","due_on":"2015-09-30T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/INN/Largo/pulls/867/commits","review_comments_url":"https://api.github.com/repos/INN/Largo/pulls/867/comments","review_comment_url":"https://api.github.com/repos/INN/Largo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INN/Largo/issues/867/comments","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/5129dc2bd6ef5a9b79bb0da7cc3882e28084d2d1","head":{"label":"INN:SN-4-mobile-nav-styles","ref":"SN-4-mobile-nav-styles","sha":"5129dc2bd6ef5a9b79bb0da7cc3882e28084d2d1","user":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":3789101,"name":"Largo","full_name":"INN/Largo","owner":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INN/Largo","description":"A WordPress framework for news websites. Finely crafted and expertly honed by the Institute for Nonprofit News.","fork":true,"url":"https://api.github.com/repos/INN/Largo","forks_url":"https://api.github.com/repos/INN/Largo/forks","keys_url":"https://api.github.com/repos/INN/Largo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/Largo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/Largo/teams","hooks_url":"https://api.github.com/repos/INN/Largo/hooks","issue_events_url":"https://api.github.com/repos/INN/Largo/issues/events{/number}","events_url":"https://api.github.com/repos/INN/Largo/events","assignees_url":"https://api.github.com/repos/INN/Largo/assignees{/user}","branches_url":"https://api.github.com/repos/INN/Largo/branches{/branch}","tags_url":"https://api.github.com/repos/INN/Largo/tags","blobs_url":"https://api.github.com/repos/INN/Largo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/Largo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/Largo/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/Largo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/Largo/languages","stargazers_url":"https://api.github.com/repos/INN/Largo/stargazers","contributors_url":"https://api.github.com/repos/INN/Largo/contributors","subscribers_url":"https://api.github.com/repos/INN/Largo/subscribers","subscription_url":"https://api.github.com/repos/INN/Largo/subscription","commits_url":"https://api.github.com/repos/INN/Largo/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/Largo/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/Largo/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/Largo/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/Largo/contents/{+path}","compare_url":"https://api.github.com/repos/INN/Largo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/Largo/merges","archive_url":"https://api.github.com/repos/INN/Largo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/Largo/downloads","issues_url":"https://api.github.com/repos/INN/Largo/issues{/number}","pulls_url":"https://api.github.com/repos/INN/Largo/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/Largo/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/Largo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/Largo/labels{/name}","releases_url":"https://api.github.com/repos/INN/Largo/releases{/id}","created_at":"2012-03-21T17:11:36Z","updated_at":"2015-09-06T20:58:32Z","pushed_at":"2015-09-16T21:27:10Z","git_url":"git://github.com/INN/Largo.git","ssh_url":"git@github.com:INN/Largo.git","clone_url":"https://github.com/INN/Largo.git","svn_url":"https://github.com/INN/Largo","homepage":"http://largoproject.org","size":18161,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":278,"forks":37,"open_issues":278,"watchers":74,"default_branch":"master"}},"base":{"label":"INN:master","ref":"master","sha":"22c1fc36cb01f5cdb58111cfb63f1f1447cd1c79","user":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":3789101,"name":"Largo","full_name":"INN/Largo","owner":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INN/Largo","description":"A WordPress framework for news websites. Finely crafted and expertly honed by the Institute for Nonprofit News.","fork":true,"url":"https://api.github.com/repos/INN/Largo","forks_url":"https://api.github.com/repos/INN/Largo/forks","keys_url":"https://api.github.com/repos/INN/Largo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/Largo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/Largo/teams","hooks_url":"https://api.github.com/repos/INN/Largo/hooks","issue_events_url":"https://api.github.com/repos/INN/Largo/issues/events{/number}","events_url":"https://api.github.com/repos/INN/Largo/events","assignees_url":"https://api.github.com/repos/INN/Largo/assignees{/user}","branches_url":"https://api.github.com/repos/INN/Largo/branches{/branch}","tags_url":"https://api.github.com/repos/INN/Largo/tags","blobs_url":"https://api.github.com/repos/INN/Largo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/Largo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/Largo/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/Largo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/Largo/languages","stargazers_url":"https://api.github.com/repos/INN/Largo/stargazers","contributors_url":"https://api.github.com/repos/INN/Largo/contributors","subscribers_url":"https://api.github.com/repos/INN/Largo/subscribers","subscription_url":"https://api.github.com/repos/INN/Largo/subscription","commits_url":"https://api.github.com/repos/INN/Largo/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/Largo/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/Largo/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/Largo/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/Largo/contents/{+path}","compare_url":"https://api.github.com/repos/INN/Largo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/Largo/merges","archive_url":"https://api.github.com/repos/INN/Largo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/Largo/downloads","issues_url":"https://api.github.com/repos/INN/Largo/issues{/number}","pulls_url":"https://api.github.com/repos/INN/Largo/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/Largo/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/Largo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/Largo/labels{/name}","releases_url":"https://api.github.com/repos/INN/Largo/releases{/id}","created_at":"2012-03-21T17:11:36Z","updated_at":"2015-09-06T20:58:32Z","pushed_at":"2015-09-16T21:27:10Z","git_url":"git://github.com/INN/Largo.git","ssh_url":"git@github.com:INN/Largo.git","clone_url":"https://github.com/INN/Largo.git","svn_url":"https://github.com/INN/Largo","homepage":"http://largoproject.org","size":18161,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":278,"forks":37,"open_issues":278,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INN/Largo/pulls/867"},"html":{"href":"https://github.com/INN/Largo/pull/867"},"issue":{"href":"https://api.github.com/repos/INN/Largo/issues/867"},"comments":{"href":"https://api.github.com/repos/INN/Largo/issues/867/comments"},"review_comments":{"href":"https://api.github.com/repos/INN/Largo/pulls/867/comments"},"review_comment":{"href":"https://api.github.com/repos/INN/Largo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INN/Largo/pulls/867/commits"},"statuses":{"href":"https://api.github.com/repos/INN/Largo/statuses/5129dc2bd6ef5a9b79bb0da7cc3882e28084d2d1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":0,"commits":71,"additions":2847,"deletions":2649,"changed_files":71}}