{"comment":{"url":"https://api.github.com/repos/jrburke/gaia/comments/12796070","html_url":"https://github.com/jrburke/gaia/commit/87fe6551eb87b1ae36f0f7fcbb20a61752f8b378#commitcomment-12796070","id":12796070,"user":{"login":"jrburke","id":73359,"avatar_url":"https://avatars.githubusercontent.com/u/73359?v=3","gravatar_id":"","url":"https://api.github.com/users/jrburke","html_url":"https://github.com/jrburke","followers_url":"https://api.github.com/users/jrburke/followers","following_url":"https://api.github.com/users/jrburke/following{/other_user}","gists_url":"https://api.github.com/users/jrburke/gists{/gist_id}","starred_url":"https://api.github.com/users/jrburke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrburke/subscriptions","organizations_url":"https://api.github.com/users/jrburke/orgs","repos_url":"https://api.github.com/users/jrburke/repos","events_url":"https://api.github.com/users/jrburke/events{/privacy}","received_events_url":"https://api.github.com/users/jrburke/received_events","type":"User","site_admin":false},"position":11,"line":11,"path":"apps/email/js/cards/lst/edit_toolbar.js","commit_id":"87fe6551eb87b1ae36f0f7fcbb20a61752f8b378","created_at":"2015-08-19T22:16:02Z","updated_at":"2015-08-19T22:16:02Z","body":"I share your general paranoia around getters and setters. I have traditionally avoided them because of the side effects submarines. In the edit_toolbar case I was playing with matching the traditional style of the construct: DOM elements have getter/setter style in this fashion. Trying to be sure I was not stuck in my old crusty ways. But then DOM elements have weird horrible stuff around attribute/property reflection too, so maybe emulating their traditional style is not so desirable. :)\r\n\r\nI will update edit_toolbar to use the `updateDomX: function(value)` convention instead of `set X(value)`. I might still play around with the property/attribute combo getter/setter thing just out of curiosity. Although it will be a side project, just started having flashbacks from the weirdness in attributes vs properties from Dojo and jQuery library code as I do the experiment.\r\n"}}