{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21","id":46862446,"html_url":"https://github.com/libopenstorage/openstorage/pull/21","diff_url":"https://github.com/libopenstorage/openstorage/pull/21.diff","patch_url":"https://github.com/libopenstorage/openstorage/pull/21.patch","issue_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/21","number":21,"state":"closed","locked":false,"title":"Makefile suggestions","user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"body":"This is not ready to merge, but more of a conversation piece that I thought you might find helpful :)\r\n\r\nTwo reference points for Makefiles I use:\r\n\r\n- https://github.com/pachyderm/pachyderm/blob/master/Makefile\r\n- https://github.com/peter-edge/go-flights/blob/master/Makefile\r\n\r\nSo some themes here:\r\n\r\n- I figure GOPATH is up to the user to set, esp as some people like to have it as an individual thing per repository.\r\n- No need to do a blank assignment for BUILD_OPTIONS\r\n- Not everyone uses ctags, no real use for the Makefile\r\n- Removed @'s, I like to see what is going on\r\n- Added how I update code :)\r\n- Added godep usage with golang 1.5 vendor experiment. We can talk about this.\r\n- My pretest check suite: lint, vet, errcheck. Not everyone likes this, but put it in there for reference\r\n- Tests in docker (I think all the tests here should just be in Docker, we do this in Pachyderm, but we can discuss/I'm happy to help out).\r\n- This is in preparation for all tests in docker/CI.","created_at":"2015-10-06T04:52:10Z","updated_at":"2015-10-08T22:41:56Z","closed_at":"2015-10-08T22:41:56Z","merged_at":null,"merge_commit_sha":"5cd11aa6f6aaba465cbe6c260b9a3af953ec7074","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/21/comments","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/d7f7d454b222a3667d8dab3e4206377000ab3a72","head":{"label":"peter-edge:makefile","ref":"makefile","sha":"d7f7d454b222a3667d8dab3e4206377000ab3a72","user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"repo":{"id":43728869,"name":"openstorage","full_name":"peter-edge/openstorage","owner":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter-edge/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":true,"url":"https://api.github.com/repos/peter-edge/openstorage","forks_url":"https://api.github.com/repos/peter-edge/openstorage/forks","keys_url":"https://api.github.com/repos/peter-edge/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter-edge/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter-edge/openstorage/teams","hooks_url":"https://api.github.com/repos/peter-edge/openstorage/hooks","issue_events_url":"https://api.github.com/repos/peter-edge/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/peter-edge/openstorage/events","assignees_url":"https://api.github.com/repos/peter-edge/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/peter-edge/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/peter-edge/openstorage/tags","blobs_url":"https://api.github.com/repos/peter-edge/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter-edge/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter-edge/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter-edge/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter-edge/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/peter-edge/openstorage/languages","stargazers_url":"https://api.github.com/repos/peter-edge/openstorage/stargazers","contributors_url":"https://api.github.com/repos/peter-edge/openstorage/contributors","subscribers_url":"https://api.github.com/repos/peter-edge/openstorage/subscribers","subscription_url":"https://api.github.com/repos/peter-edge/openstorage/subscription","commits_url":"https://api.github.com/repos/peter-edge/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter-edge/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter-edge/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter-edge/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/peter-edge/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/peter-edge/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter-edge/openstorage/merges","archive_url":"https://api.github.com/repos/peter-edge/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter-edge/openstorage/downloads","issues_url":"https://api.github.com/repos/peter-edge/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/peter-edge/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/peter-edge/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/peter-edge/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter-edge/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/peter-edge/openstorage/releases{/id}","created_at":"2015-10-06T03:58:00Z","updated_at":"2015-10-06T03:58:01Z","pushed_at":"2015-10-08T22:38:25Z","git_url":"git://github.com/peter-edge/openstorage.git","ssh_url":"git@github.com:peter-edge/openstorage.git","clone_url":"https://github.com/peter-edge/openstorage.git","svn_url":"https://github.com/peter-edge/openstorage","homepage":"","size":785,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"cc7bf2f42b5ec28e9932e2804397ede6f523b5fd","user":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars.githubusercontent.com/u/13478636?v=3","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39651750,"name":"openstorage","full_name":"libopenstorage/openstorage","owner":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars.githubusercontent.com/u/13478636?v=3","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":false,"url":"https://api.github.com/repos/libopenstorage/openstorage","forks_url":"https://api.github.com/repos/libopenstorage/openstorage/forks","keys_url":"https://api.github.com/repos/libopenstorage/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/openstorage/teams","hooks_url":"https://api.github.com/repos/libopenstorage/openstorage/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/openstorage/events","assignees_url":"https://api.github.com/repos/libopenstorage/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/openstorage/tags","blobs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/openstorage/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/openstorage/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/openstorage/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/openstorage/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/openstorage/subscription","commits_url":"https://api.github.com/repos/libopenstorage/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/openstorage/merges","archive_url":"https://api.github.com/repos/libopenstorage/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/openstorage/downloads","issues_url":"https://api.github.com/repos/libopenstorage/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/openstorage/releases{/id}","created_at":"2015-07-24T19:01:34Z","updated_at":"2015-10-01T23:29:27Z","pushed_at":"2015-10-08T22:40:59Z","git_url":"git://github.com/libopenstorage/openstorage.git","ssh_url":"git@github.com:libopenstorage/openstorage.git","clone_url":"https://github.com/libopenstorage/openstorage.git","svn_url":"https://github.com/libopenstorage/openstorage","homepage":"","size":785,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":15,"forks":8,"open_issues":15,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21"},"html":{"href":"https://github.com/libopenstorage/openstorage/pull/21"},"issue":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/21"},"comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/openstorage/statuses/d7f7d454b222a3667d8dab3e4206377000ab3a72"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":11,"additions":83,"deletions":327,"changed_files":8}}