{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6354","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6354/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6354/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6354/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6354","id":91904908,"number":6354,"title":"Gitian windows signing normalization","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-29T20:40:51Z","updated_at":"2015-06-30T05:55:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6354","html_url":"https://github.com/bitcoin/bitcoin/pull/6354","diff_url":"https://github.com/bitcoin/bitcoin/pull/6354.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6354.patch"},"body":"Sorry for yet another PR here. This one includes @michagogo's suggestions and doc changes. It replaces #6343 and #6342.\r\n\r\nTeach gitian to output a *-win-unsigned.tar.gz similar to OSX. The signer will attempt to combine any \"*-unsigned.exe\" with a matching \"*-unsigned.exe.pem\" from the detatched signature repo.\r\n\r\nAlso note that the new target signature dir for windows has changed from \"${VERSION}-win\" to \"${VERSION}-win-unsigned\".\r\n\r\nTested with a phony tag and signature.\r\n\r\nSafe for backport, should be good to go for rc3."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/116987358","html_url":"https://github.com/bitcoin/bitcoin/pull/6354#issuecomment-116987358","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6354","id":116987358,"user":{"login":"Michagogo","id":2559390,"avatar_url":"https://avatars.githubusercontent.com/u/2559390?v=3","gravatar_id":"","url":"https://api.github.com/users/Michagogo","html_url":"https://github.com/Michagogo","followers_url":"https://api.github.com/users/Michagogo/followers","following_url":"https://api.github.com/users/Michagogo/following{/other_user}","gists_url":"https://api.github.com/users/Michagogo/gists{/gist_id}","starred_url":"https://api.github.com/users/Michagogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michagogo/subscriptions","organizations_url":"https://api.github.com/users/Michagogo/orgs","repos_url":"https://api.github.com/users/Michagogo/repos","events_url":"https://api.github.com/users/Michagogo/events{/privacy}","received_events_url":"https://api.github.com/users/Michagogo/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T05:55:45Z","updated_at":"2015-06-30T05:55:45Z","body":"Minor nit: NSIS shouldn't output installers with `unsigned` in the name. Unless I'm misunderstanding, the `.dmg` that the (non-gitian) build process for OS X outputs doesn't contain that in the name, and that's a good thing. The `{un,}signed` only makes sense in the context of the gitian process, so gitian should include it in output file names, but the normal build process (e.g. if you're building yourself) shouldn't."}}