{"action":"created","issue":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/239","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/239/comments","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/239/events","html_url":"https://github.com/riptano/cassandra-dtest/pull/239","id":69918466,"number":239,"title":"Adds smoke tests for cqlsh","user":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars.githubusercontent.com/u/3753769?v=3","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-21T18:31:08Z","updated_at":"2015-04-28T16:28:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/239","html_url":"https://github.com/riptano/cassandra-dtest/pull/239","diff_url":"https://github.com/riptano/cassandra-dtest/pull/239.diff","patch_url":"https://github.com/riptano/cassandra-dtest/pull/239.patch"},"body":"These aren't comprehensive tests, but they add basic coverage. I used the titles of the stubbed [cqlsh parsing tests in C* trunk](https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/test/test_cql_parsing.py) as a starting point.\r\n\r\nI may have found a bug in pre-trunk releases with [CREATE INDEX](https://github.com/riptano/cassandra-dtest/blob/b712395bc318ab41b26762ba395e3866ac36f4be/cqlsh_tests.py#L749) and [DROP INDEX](https://github.com/riptano/cassandra-dtest/blob/b712395bc318ab41b26762ba395e3866ac36f4be/cqlsh_tests.py#L776) handling. I think they may just be bugs in the cqlsh parser. I've marked the tests for these statements `@since('3.0')` until I can isolate the bug.\r\n\r\nPinging @thobbs in case he wants to have a look."},"comment":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments/97127285","html_url":"https://github.com/riptano/cassandra-dtest/pull/239#issuecomment-97127285","issue_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/239","id":97127285,"user":{"login":"ptnapoleon","id":3408144,"avatar_url":"https://avatars.githubusercontent.com/u/3408144?v=3","gravatar_id":"","url":"https://api.github.com/users/ptnapoleon","html_url":"https://github.com/ptnapoleon","followers_url":"https://api.github.com/users/ptnapoleon/followers","following_url":"https://api.github.com/users/ptnapoleon/following{/other_user}","gists_url":"https://api.github.com/users/ptnapoleon/gists{/gist_id}","starred_url":"https://api.github.com/users/ptnapoleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptnapoleon/subscriptions","organizations_url":"https://api.github.com/users/ptnapoleon/orgs","repos_url":"https://api.github.com/users/ptnapoleon/repos","events_url":"https://api.github.com/users/ptnapoleon/events{/privacy}","received_events_url":"https://api.github.com/users/ptnapoleon/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T16:28:45Z","updated_at":"2015-04-28T16:28:45Z","body":"His +1 is good enough for me. But just in case, I also think it looks good, +1."}}