{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/6679","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6679/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6679/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6679/events","html_url":"https://github.com/mozilla/pdf.js/pull/6679","id":118368754,"number":6679,"title":"Improve the comment and deprecation warning for `PDFJS.openExternalLinksInNewWindow`","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-core","name":"1-core","color":"DDDDDD"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-23T12:14:12Z","updated_at":"2015-11-24T21:18:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6679","html_url":"https://github.com/mozilla/pdf.js/pull/6679","diff_url":"https://github.com/mozilla/pdf.js/pull/6679.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6679.patch"},"body":"This patch:\r\n - Updates the JSDoc comment in `api.js`, to more clearly point out that `PDFJS.openExternalLinksInNewWindow` is deprecated, and explains what to use instead.\r\n\r\n - Changes the `warn`, in `isExternalLinkTargetSet()`, to use the new `deprecated` function instead. Also updates the message with more detailed information about what to use instead.\r\n\r\n - Changes the pre-processor tag to ensure the deprecation warning is seen in all build types where it could possibly matter (in case people are using `PDFJS.openExternalLinksInNewWindow` in e.g. custom-built extensions).\r\n\r\nThese changes were prompted by seeing http://stackoverflow.com/questions/33813373/pdf-js-how-to-open-hyperlinks-in-a-new-tab-window, since it seems to me that the current comments/warnings might not be worded well enough."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/159407800","html_url":"https://github.com/mozilla/pdf.js/pull/6679#issuecomment-159407800","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6679","id":159407800,"user":{"login":"pdfjsbot","id":1036361,"avatar_url":"https://avatars.githubusercontent.com/u/1036361?v=3","gravatar_id":"","url":"https://api.github.com/users/pdfjsbot","html_url":"https://github.com/pdfjsbot","followers_url":"https://api.github.com/users/pdfjsbot/followers","following_url":"https://api.github.com/users/pdfjsbot/following{/other_user}","gists_url":"https://api.github.com/users/pdfjsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pdfjsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdfjsbot/subscriptions","organizations_url":"https://api.github.com/users/pdfjsbot/orgs","repos_url":"https://api.github.com/users/pdfjsbot/repos","events_url":"https://api.github.com/users/pdfjsbot/events{/privacy}","received_events_url":"https://api.github.com/users/pdfjsbot/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T21:18:13Z","updated_at":"2015-11-24T21:18:13Z","body":"#### From: Bot.io (Linux)\n\n----\n\n# Received\n\nCommand **cmd_test** from @timvandermeij received. Current queue size: 0\n\nLive output at: http://107.21.233.14:8877/1b3656556ff2c8b/output.txt"}}