{"action":"closed","number":260,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260","id":49381826,"html_url":"https://github.com/MarlinFirmware/MarlinDev/pull/260","diff_url":"https://github.com/MarlinFirmware/MarlinDev/pull/260.diff","patch_url":"https://github.com/MarlinFirmware/MarlinDev/pull/260.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/260","number":260,"state":"closed","locked":false,"title":"Removing Button updates fron ISR file","user":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"body":"lcd_buttons_update is done frequently (more often than in this context) in lcd_update so i do not see the need to have this burden in ISR routine also. i have not met any consequencies of removing all updates.\r\n\r\nOriginally by @justmyopinion in https://github.com/MarlinFirmware/Marlin/pull/2720\r\n\r\n@Wackerbarth, @Roxy-3DPrintBoard  you seemed to be interested in this over here in Dev","created_at":"2015-11-01T21:48:58Z","updated_at":"2015-11-01T23:14:47Z","closed_at":"2015-11-01T23:14:47Z","merged_at":null,"merge_commit_sha":"5263e26a5b0448975a4fa8d1811faa83b2002b9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/260/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/statuses/00393a5b7f64f8aaba05f537680ad5a6c65dc8d7","head":{"label":"AnHardt:rm-buttonupdate-ISR","ref":"rm-buttonupdate-ISR","sha":"00393a5b7f64f8aaba05f537680ad5a6c65dc8d7","user":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"repo":{"id":43880203,"name":"MarlinDev","full_name":"AnHardt/MarlinDev","owner":{"login":"AnHardt","id":211931,"avatar_url":"https://avatars.githubusercontent.com/u/211931?v=3","gravatar_id":"","url":"https://api.github.com/users/AnHardt","html_url":"https://github.com/AnHardt","followers_url":"https://api.github.com/users/AnHardt/followers","following_url":"https://api.github.com/users/AnHardt/following{/other_user}","gists_url":"https://api.github.com/users/AnHardt/gists{/gist_id}","starred_url":"https://api.github.com/users/AnHardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnHardt/subscriptions","organizations_url":"https://api.github.com/users/AnHardt/orgs","repos_url":"https://api.github.com/users/AnHardt/repos","events_url":"https://api.github.com/users/AnHardt/events{/privacy}","received_events_url":"https://api.github.com/users/AnHardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnHardt/MarlinDev","description":"Development tree for Marlin firmware. See MarlinFirmware/Marlin for releases.","fork":true,"url":"https://api.github.com/repos/AnHardt/MarlinDev","forks_url":"https://api.github.com/repos/AnHardt/MarlinDev/forks","keys_url":"https://api.github.com/repos/AnHardt/MarlinDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnHardt/MarlinDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnHardt/MarlinDev/teams","hooks_url":"https://api.github.com/repos/AnHardt/MarlinDev/hooks","issue_events_url":"https://api.github.com/repos/AnHardt/MarlinDev/issues/events{/number}","events_url":"https://api.github.com/repos/AnHardt/MarlinDev/events","assignees_url":"https://api.github.com/repos/AnHardt/MarlinDev/assignees{/user}","branches_url":"https://api.github.com/repos/AnHardt/MarlinDev/branches{/branch}","tags_url":"https://api.github.com/repos/AnHardt/MarlinDev/tags","blobs_url":"https://api.github.com/repos/AnHardt/MarlinDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnHardt/MarlinDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnHardt/MarlinDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnHardt/MarlinDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnHardt/MarlinDev/statuses/{sha}","languages_url":"https://api.github.com/repos/AnHardt/MarlinDev/languages","stargazers_url":"https://api.github.com/repos/AnHardt/MarlinDev/stargazers","contributors_url":"https://api.github.com/repos/AnHardt/MarlinDev/contributors","subscribers_url":"https://api.github.com/repos/AnHardt/MarlinDev/subscribers","subscription_url":"https://api.github.com/repos/AnHardt/MarlinDev/subscription","commits_url":"https://api.github.com/repos/AnHardt/MarlinDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnHardt/MarlinDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnHardt/MarlinDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnHardt/MarlinDev/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnHardt/MarlinDev/contents/{+path}","compare_url":"https://api.github.com/repos/AnHardt/MarlinDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnHardt/MarlinDev/merges","archive_url":"https://api.github.com/repos/AnHardt/MarlinDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnHardt/MarlinDev/downloads","issues_url":"https://api.github.com/repos/AnHardt/MarlinDev/issues{/number}","pulls_url":"https://api.github.com/repos/AnHardt/MarlinDev/pulls{/number}","milestones_url":"https://api.github.com/repos/AnHardt/MarlinDev/milestones{/number}","notifications_url":"https://api.github.com/repos/AnHardt/MarlinDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnHardt/MarlinDev/labels{/name}","releases_url":"https://api.github.com/repos/AnHardt/MarlinDev/releases{/id}","created_at":"2015-10-08T10:07:39Z","updated_at":"2015-10-08T10:07:45Z","pushed_at":"2015-11-01T22:24:27Z","git_url":"git://github.com/AnHardt/MarlinDev.git","ssh_url":"git@github.com:AnHardt/MarlinDev.git","clone_url":"https://github.com/AnHardt/MarlinDev.git","svn_url":"https://github.com/AnHardt/MarlinDev","homepage":"","size":26063,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarlinFirmware:master","ref":"master","sha":"e97a3a0638394acf26bc519eacf2a004bff41ddf","user":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars.githubusercontent.com/u/10418365?v=3","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":40061250,"name":"MarlinDev","full_name":"MarlinFirmware/MarlinDev","owner":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars.githubusercontent.com/u/10418365?v=3","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarlinFirmware/MarlinDev","description":"Development tree for Marlin firmware. See MarlinFirmware/Marlin for releases.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/MarlinDev","forks_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/MarlinDev/releases{/id}","created_at":"2015-08-01T22:01:17Z","updated_at":"2015-10-16T14:23:40Z","pushed_at":"2015-11-01T22:32:14Z","git_url":"git://github.com/MarlinFirmware/MarlinDev.git","ssh_url":"git@github.com:MarlinFirmware/MarlinDev.git","clone_url":"https://github.com/MarlinFirmware/MarlinDev.git","svn_url":"https://github.com/MarlinFirmware/MarlinDev","homepage":"","size":30098,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":109,"forks":70,"open_issues":109,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260"},"html":{"href":"https://github.com/MarlinFirmware/MarlinDev/pull/260"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/260"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/MarlinDev/statuses/00393a5b7f64f8aaba05f537680ad5a6c65dc8d7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":0,"deletions":7,"changed_files":2}}