{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4807","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4807/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4807/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4807/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4807","id":84423486,"number":4807,"title":"[WIP] Read-only input data in common tests","user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-03T08:02:48Z","updated_at":"2015-07-01T09:54:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4807","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4807","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4807.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4807.patch"},"body":"Following PR #4775, I added checks in estimator checks in order to verify `Estimator` behavior on read only mem-mapped data.\r\n\r\nA few issues there :\r\n- [ ] registering _clean_temp_memory with atexit yield failure, as it called at the end of every test, and delete _TEMP_MEMORY whereas the next test has already begun.\r\n- [ ] I overloaded make_blobs into _make_blobs in order to be able to easily yield a read-only memmap X which is only positive. This looks quite messy though.\r\n- [ ] cf PR #4775, this does not introduce tests that fails on current master, whereas `sklearn/linear_model/cd_fast.pyx` still raise errors on some use cases. This is related to the fact that we cannot make Lasso fails using simple read-only memmap as input."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/117572068","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4807#issuecomment-117572068","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4807","id":117572068,"user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T09:54:09Z","updated_at":"2015-07-01T09:54:09Z","body":"Thanks to the range of `check_array` in `validation.py`, Transformer`, `Estimator`, `Classifier` and `Regressor` are now tested on read only memmap input (I have checked it).\r\n\r\nWe observe no failure using files `cd_fast.c` from master, with which an error is raised in `test_dict_learning.test_dict_learning_lassocd_readonly_data` (see PR#4775)"}}