{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/opesci-fd/pulls/comments/38814272","id":38814272,"diff_hunk":"@@ -224,53 +210,66 @@ def converge_test():\n     c = 0.4*s\n     dt = c/(s**2)\n     tmax = 5.0\n-    eigenwave3d(domain_size, (s, s, s), dt, tmax, o_step=False, o_converge=True,\n-                omp=True, simd=False, ivdep=True, io=False,\n+    eigenwave3d(domain_size, (s, s, s), dt, tmax, output_vts=False, o_converge=True,\n+                omp=True, simd=False, ivdep=True,\n                 filename='tmp/test3d_'+str(s)+'.cpp')\n \n     s = s*2\n     dt = c/(s**2)\n-    eigenwave3d(domain_size, (s, s, s), dt, tmax, o_step=False, o_converge=True,\n-                omp=True, simd=False, ivdep=True, io=False,\n+    eigenwave3d(domain_size, (s, s, s), dt, tmax, output_vts=False, o_converge=True,\n+                omp=True, simd=False, ivdep=True,\n                 filename='tmp/test3d_'+str(s)+'.cpp')\n \n     s = s*2\n     dt = c/(s**2)\n-    eigenwave3d(domain_size, (s, s, s), dt, tmax, o_step=False, o_converge=True,\n-                omp=True, simd=False, ivdep=True, io=False,\n+    eigenwave3d(domain_size, (s, s, s), dt, tmax, output_vts=False, o_converge=True,\n+                omp=True, simd=False, ivdep=True,\n                 filename='tmp/test3d_'+str(s)+'.cpp')\n \n     s = s*2\n     dt = c/(s**2)\n-    eigenwave3d(domain_size, (s, s, s), dt, tmax, o_step=False, o_converge=True,\n-                omp=True, simd=False, ivdep=True, io=False,\n+    eigenwave3d(domain_size, (s, s, s), dt, tmax, output_vts=False, o_converge=True,\n+                omp=True, simd=False, ivdep=True,\n                 filename='tmp/test3d_'+str(s)+'.cpp')\n \n \n def main():\n-    if len(sys.argv) > 2:\n-        print 'too many arguments!'\n-        return\n-\n-    if len(sys.argv) == 1:\n-        default()\n-        return\n-\n-    if sys.argv[1] == 'cx1':\n-        cx1()\n-        return\n-\n-    if sys.argv[1] == 'converge':\n+    ModeHelp = \"\"\"Avalable testing modes:\n+default:   Eigenwave test case on a unit cube grid (100 x 100 x 100)\n+\n+read:      Test for model intialisation from input file; computes\n+           eigenwave on a unit cube grid (200 x 200 x 200)\n+\n+converge:  Convergence test of the (2,4) scheme; halves spacing","path":"tests/eigenwave3d.py","position":199,"original_position":199,"commit_id":"9e15dac8dba224dd7528d3f93f5f8d88ab1ef699","original_commit_id":"9e15dac8dba224dd7528d3f93f5f8d88ab1ef699","user":{"login":"ctjacobs","id":5470627,"avatar_url":"https://avatars.githubusercontent.com/u/5470627?v=3","gravatar_id":"","url":"https://api.github.com/users/ctjacobs","html_url":"https://github.com/ctjacobs","followers_url":"https://api.github.com/users/ctjacobs/followers","following_url":"https://api.github.com/users/ctjacobs/following{/other_user}","gists_url":"https://api.github.com/users/ctjacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/ctjacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctjacobs/subscriptions","organizations_url":"https://api.github.com/users/ctjacobs/orgs","repos_url":"https://api.github.com/users/ctjacobs/repos","events_url":"https://api.github.com/users/ctjacobs/events{/privacy}","received_events_url":"https://api.github.com/users/ctjacobs/received_events","type":"User","site_admin":false},"body":"What exactly do you mean by the (2,4) scheme here?","created_at":"2015-09-05T19:53:10Z","updated_at":"2015-09-05T19:53:10Z","html_url":"https://github.com/opesci/opesci-fd/pull/34#discussion_r38814272","pull_request_url":"https://api.github.com/repos/opesci/opesci-fd/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/comments/38814272"},"html":{"href":"https://github.com/opesci/opesci-fd/pull/34#discussion_r38814272"},"pull_request":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/opesci/opesci-fd/pulls/34","id":44218377,"html_url":"https://github.com/opesci/opesci-fd/pull/34","diff_url":"https://github.com/opesci/opesci-fd/pull/34.diff","patch_url":"https://github.com/opesci/opesci-fd/pull/34.patch","issue_url":"https://api.github.com/repos/opesci/opesci-fd/issues/34","number":34,"state":"open","locked":false,"title":"Refactor eigenwave script","user":{"login":"mlange05","id":5585005,"avatar_url":"https://avatars.githubusercontent.com/u/5585005?v=3","gravatar_id":"","url":"https://api.github.com/users/mlange05","html_url":"https://github.com/mlange05","followers_url":"https://api.github.com/users/mlange05/followers","following_url":"https://api.github.com/users/mlange05/following{/other_user}","gists_url":"https://api.github.com/users/mlange05/gists{/gist_id}","starred_url":"https://api.github.com/users/mlange05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlange05/subscriptions","organizations_url":"https://api.github.com/users/mlange05/orgs","repos_url":"https://api.github.com/users/mlange05/repos","events_url":"https://api.github.com/users/mlange05/events{/privacy}","received_events_url":"https://api.github.com/users/mlange05/received_events","type":"User","site_admin":false},"body":"This merge refactors the eigenwave3d.py example script to provide a ncie and clean user interface, including automatic parallel execution and an optional flag for solution output. More specifically it includes:\r\n* Automatic parallel execution that sets `OMP_NUM_PROCS` and the affinity at run-time\r\n* Improved user interface for the eigenwave3d.py script through use of an ArgumentParser\r\n* New flags for test script, including a compiler flag, run-time execution and an output flag\r\n* Updated README entries for example script and dependency installation\r\n\r\nNote, that this wants PR #32 to land first.","created_at":"2015-09-04T13:36:30Z","updated_at":"2015-09-05T19:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52865cb397977659254772a038378c7045837c1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opesci/opesci-fd/pulls/34/commits","review_comments_url":"https://api.github.com/repos/opesci/opesci-fd/pulls/34/comments","review_comment_url":"https://api.github.com/repos/opesci/opesci-fd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/opesci-fd/issues/34/comments","statuses_url":"https://api.github.com/repos/opesci/opesci-fd/statuses/9e15dac8dba224dd7528d3f93f5f8d88ab1ef699","head":{"label":"opesci:refactor-eigenwave-script","ref":"refactor-eigenwave-script","sha":"9e15dac8dba224dd7528d3f93f5f8d88ab1ef699","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":32512811,"name":"opesci-fd","full_name":"opesci/opesci-fd","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/opesci-fd","description":"Solvers for 3D wave equation","fork":false,"url":"https://api.github.com/repos/opesci/opesci-fd","forks_url":"https://api.github.com/repos/opesci/opesci-fd/forks","keys_url":"https://api.github.com/repos/opesci/opesci-fd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/opesci-fd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/opesci-fd/teams","hooks_url":"https://api.github.com/repos/opesci/opesci-fd/hooks","issue_events_url":"https://api.github.com/repos/opesci/opesci-fd/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/opesci-fd/events","assignees_url":"https://api.github.com/repos/opesci/opesci-fd/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/opesci-fd/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/opesci-fd/tags","blobs_url":"https://api.github.com/repos/opesci/opesci-fd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/opesci-fd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/opesci-fd/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/opesci-fd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/opesci-fd/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/opesci-fd/languages","stargazers_url":"https://api.github.com/repos/opesci/opesci-fd/stargazers","contributors_url":"https://api.github.com/repos/opesci/opesci-fd/contributors","subscribers_url":"https://api.github.com/repos/opesci/opesci-fd/subscribers","subscription_url":"https://api.github.com/repos/opesci/opesci-fd/subscription","commits_url":"https://api.github.com/repos/opesci/opesci-fd/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/opesci-fd/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/opesci-fd/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/opesci-fd/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/opesci-fd/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/opesci-fd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/opesci-fd/merges","archive_url":"https://api.github.com/repos/opesci/opesci-fd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/opesci-fd/downloads","issues_url":"https://api.github.com/repos/opesci/opesci-fd/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/opesci-fd/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/opesci-fd/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/opesci-fd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/opesci-fd/labels{/name}","releases_url":"https://api.github.com/repos/opesci/opesci-fd/releases{/id}","created_at":"2015-03-19T09:39:45Z","updated_at":"2015-09-01T19:13:30Z","pushed_at":"2015-09-05T07:34:15Z","git_url":"git://github.com/opesci/opesci-fd.git","ssh_url":"git@github.com:opesci/opesci-fd.git","clone_url":"https://github.com/opesci/opesci-fd.git","svn_url":"https://github.com/opesci/opesci-fd","homepage":null,"size":2199,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"c87c7954195e0435174db16b3fa45e2dc6c51634","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":32512811,"name":"opesci-fd","full_name":"opesci/opesci-fd","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/opesci-fd","description":"Solvers for 3D wave equation","fork":false,"url":"https://api.github.com/repos/opesci/opesci-fd","forks_url":"https://api.github.com/repos/opesci/opesci-fd/forks","keys_url":"https://api.github.com/repos/opesci/opesci-fd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/opesci-fd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/opesci-fd/teams","hooks_url":"https://api.github.com/repos/opesci/opesci-fd/hooks","issue_events_url":"https://api.github.com/repos/opesci/opesci-fd/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/opesci-fd/events","assignees_url":"https://api.github.com/repos/opesci/opesci-fd/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/opesci-fd/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/opesci-fd/tags","blobs_url":"https://api.github.com/repos/opesci/opesci-fd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/opesci-fd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/opesci-fd/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/opesci-fd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/opesci-fd/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/opesci-fd/languages","stargazers_url":"https://api.github.com/repos/opesci/opesci-fd/stargazers","contributors_url":"https://api.github.com/repos/opesci/opesci-fd/contributors","subscribers_url":"https://api.github.com/repos/opesci/opesci-fd/subscribers","subscription_url":"https://api.github.com/repos/opesci/opesci-fd/subscription","commits_url":"https://api.github.com/repos/opesci/opesci-fd/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/opesci-fd/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/opesci-fd/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/opesci-fd/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/opesci-fd/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/opesci-fd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/opesci-fd/merges","archive_url":"https://api.github.com/repos/opesci/opesci-fd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/opesci-fd/downloads","issues_url":"https://api.github.com/repos/opesci/opesci-fd/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/opesci-fd/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/opesci-fd/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/opesci-fd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/opesci-fd/labels{/name}","releases_url":"https://api.github.com/repos/opesci/opesci-fd/releases{/id}","created_at":"2015-03-19T09:39:45Z","updated_at":"2015-09-01T19:13:30Z","pushed_at":"2015-09-05T07:34:15Z","git_url":"git://github.com/opesci/opesci-fd.git","ssh_url":"git@github.com:opesci/opesci-fd.git","clone_url":"https://github.com/opesci/opesci-fd.git","svn_url":"https://github.com/opesci/opesci-fd","homepage":null,"size":2199,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/34"},"html":{"href":"https://github.com/opesci/opesci-fd/pull/34"},"issue":{"href":"https://api.github.com/repos/opesci/opesci-fd/issues/34"},"comments":{"href":"https://api.github.com/repos/opesci/opesci-fd/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/opesci-fd/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/opesci-fd/statuses/9e15dac8dba224dd7528d3f93f5f8d88ab1ef699"}}}}