{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/comments/31259414","id":31259414,"diff_hunk":"@@ -513,6 +516,7 @@ func (dump *MongoDump) dumpIterToWriter(\n \t\t\treturn fmt.Errorf(\"error writing to file: %v\", err)\n \t\t}\n \t\tprogressCount.Inc(1)\n+\t\tdump.count += 1","path":"mongodump/mongodump.go","position":30,"original_position":30,"commit_id":"bd27a304dbe4d7093b96dc12770a158334833d48","original_commit_id":"bd27a304dbe4d7093b96dc12770a158334833d48","user":{"login":"3rf","id":1242478,"avatar_url":"https://avatars.githubusercontent.com/u/1242478?v=3","gravatar_id":"","url":"https://api.github.com/users/3rf","html_url":"https://github.com/3rf","followers_url":"https://api.github.com/users/3rf/followers","following_url":"https://api.github.com/users/3rf/following{/other_user}","gists_url":"https://api.github.com/users/3rf/gists{/gist_id}","starred_url":"https://api.github.com/users/3rf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3rf/subscriptions","organizations_url":"https://api.github.com/users/3rf/orgs","repos_url":"https://api.github.com/users/3rf/repos","events_url":"https://api.github.com/users/3rf/events{/privacy}","received_events_url":"https://api.github.com/users/3rf/received_events","type":"User","site_admin":false},"body":"You're right that this could be better. The two interfaces are left over from a design plan that ended up changing. At this point, I'd recommend merging both interfaces into one (just keep the name \"Progressor\"). This might require some very minor updates for the other tools as well.","created_at":"2015-05-28T17:51:16Z","updated_at":"2015-05-28T17:51:16Z","html_url":"https://github.com/mongodb/mongo-tools/pull/20#discussion_r31259414","pull_request_url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/comments/31259414"},"html":{"href":"https://github.com/mongodb/mongo-tools/pull/20#discussion_r31259414"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20","id":36392840,"html_url":"https://github.com/mongodb/mongo-tools/pull/20","diff_url":"https://github.com/mongodb/mongo-tools/pull/20.diff","patch_url":"https://github.com/mongodb/mongo-tools/pull/20.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-tools/issues/20","number":20,"state":"open","locked":false,"title":"TOOLS-750: add the final count of dumped documents with mongodump","user":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?v=3","gravatar_id":"","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"body":"This does not resolve the issue since it doesn't explain why the first count is different than the final number of dumped documents, but at least it shows the difference and avoid user to run a `bsondump --objcheck` to know how many documents where dumped.","created_at":"2015-05-28T10:35:01Z","updated_at":"2015-05-28T17:51:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fdcba117822c65d2ce558879def0ac4f283cce9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/mongo-tools/issues/20/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-tools/statuses/bd27a304dbe4d7093b96dc12770a158334833d48","head":{"label":"ramnes:master","ref":"master","sha":"bd27a304dbe4d7093b96dc12770a158334833d48","user":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?v=3","gravatar_id":"","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"repo":{"id":36428862,"name":"mongo-tools","full_name":"ramnes/mongo-tools","owner":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?v=3","gravatar_id":"","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramnes/mongo-tools","description":"","fork":true,"url":"https://api.github.com/repos/ramnes/mongo-tools","forks_url":"https://api.github.com/repos/ramnes/mongo-tools/forks","keys_url":"https://api.github.com/repos/ramnes/mongo-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramnes/mongo-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramnes/mongo-tools/teams","hooks_url":"https://api.github.com/repos/ramnes/mongo-tools/hooks","issue_events_url":"https://api.github.com/repos/ramnes/mongo-tools/issues/events{/number}","events_url":"https://api.github.com/repos/ramnes/mongo-tools/events","assignees_url":"https://api.github.com/repos/ramnes/mongo-tools/assignees{/user}","branches_url":"https://api.github.com/repos/ramnes/mongo-tools/branches{/branch}","tags_url":"https://api.github.com/repos/ramnes/mongo-tools/tags","blobs_url":"https://api.github.com/repos/ramnes/mongo-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramnes/mongo-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramnes/mongo-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramnes/mongo-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramnes/mongo-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ramnes/mongo-tools/languages","stargazers_url":"https://api.github.com/repos/ramnes/mongo-tools/stargazers","contributors_url":"https://api.github.com/repos/ramnes/mongo-tools/contributors","subscribers_url":"https://api.github.com/repos/ramnes/mongo-tools/subscribers","subscription_url":"https://api.github.com/repos/ramnes/mongo-tools/subscription","commits_url":"https://api.github.com/repos/ramnes/mongo-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramnes/mongo-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramnes/mongo-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramnes/mongo-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramnes/mongo-tools/contents/{+path}","compare_url":"https://api.github.com/repos/ramnes/mongo-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramnes/mongo-tools/merges","archive_url":"https://api.github.com/repos/ramnes/mongo-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramnes/mongo-tools/downloads","issues_url":"https://api.github.com/repos/ramnes/mongo-tools/issues{/number}","pulls_url":"https://api.github.com/repos/ramnes/mongo-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ramnes/mongo-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ramnes/mongo-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramnes/mongo-tools/labels{/name}","releases_url":"https://api.github.com/repos/ramnes/mongo-tools/releases{/id}","created_at":"2015-05-28T09:40:55Z","updated_at":"2015-05-28T09:40:57Z","pushed_at":"2015-05-28T10:27:41Z","git_url":"git://github.com/ramnes/mongo-tools.git","ssh_url":"git@github.com:ramnes/mongo-tools.git","clone_url":"https://github.com/ramnes/mongo-tools.git","svn_url":"https://github.com/ramnes/mongo-tools","homepage":null,"size":73379,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"a442b80366fb98cb3e91f71f04824a6a31100dae","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=3","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":23876346,"name":"mongo-tools","full_name":"mongodb/mongo-tools","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=3","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-tools","description":"","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-tools","forks_url":"https://api.github.com/repos/mongodb/mongo-tools/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-tools/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-tools/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-tools/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-tools/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-tools/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-tools/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-tools/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-tools/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-tools/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-tools/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-tools/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-tools/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-tools/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-tools/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-tools/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-tools/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-tools/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-tools/releases{/id}","created_at":"2014-09-10T13:56:13Z","updated_at":"2015-05-28T09:40:54Z","pushed_at":"2015-05-28T16:28:32Z","git_url":"git://github.com/mongodb/mongo-tools.git","ssh_url":"git@github.com:mongodb/mongo-tools.git","clone_url":"https://github.com/mongodb/mongo-tools.git","svn_url":"https://github.com/mongodb/mongo-tools","homepage":null,"size":73379,"stargazers_count":159,"watchers_count":159,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":5,"forks":46,"open_issues":5,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20"},"html":{"href":"https://github.com/mongodb/mongo-tools/pull/20"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-tools/issues/20"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-tools/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-tools/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-tools/statuses/bd27a304dbe4d7093b96dc12770a158334833d48"}}}}