{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/34826030","id":34826030,"diff_hunk":"@@ -1173,7 +1173,6 @@ assert.throws(function() {\n   var b = new Buffer(1);\n   b.equals('abc');\n });\n-","path":"test/parallel/test-buffer.js","position":13,"original_position":13,"commit_id":"7f8acb6450ba1522af649587854e1eec55268b54","original_commit_id":"7f8acb6450ba1522af649587854e1eec55268b54","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Wups, unintentional whitespace change.  I'll revert that before I land it.","created_at":"2015-07-16T19:09:38Z","updated_at":"2015-07-16T19:09:38Z","html_url":"https://github.com/nodejs/io.js/pull/2193#discussion_r34826030","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/2193","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/34826030"},"html":{"href":"https://github.com/nodejs/io.js/pull/2193#discussion_r34826030"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2193"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2193","id":40137394,"html_url":"https://github.com/nodejs/io.js/pull/2193","diff_url":"https://github.com/nodejs/io.js/pull/2193.diff","patch_url":"https://github.com/nodejs/io.js/pull/2193.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2193","number":2193,"state":"open","locked":false,"title":"src: make base64 decoding 10-15% faster","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Make the inner loop execute fewer compare-and-branch executions per\r\nprocessed byte, resulting in a 10-15% speedup.\r\n\r\nThis coincidentally fixes an out-of-bounds read:\r\n\r\n    while (unbase64(*src) < 0 && src < srcEnd)\r\n\r\nShould have read:\r\n\r\n    while (src < srcEnd && unbase64(*src) < 0)\r\n\r\nBut this commit removes the offending code altogether.\r\n\r\nFixes: #2166\r\n\r\nR=@trevnorris?\r\n\r\nCI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/155/","created_at":"2015-07-16T14:49:14Z","updated_at":"2015-07-16T19:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d29a0f42485bb7cf2e98ba88d4d117d51ef43de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/2193/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/2193/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2193/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/7f8acb6450ba1522af649587854e1eec55268b54","head":{"label":"bnoordhuis:optimize-base64-decode","ref":"optimize-base64-decode","sha":"7f8acb6450ba1522af649587854e1eec55268b54","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"repo":{"id":27560441,"name":"io.js","full_name":"bnoordhuis/io.js","owner":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnoordhuis/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/bnoordhuis/io.js","forks_url":"https://api.github.com/repos/bnoordhuis/io.js/forks","keys_url":"https://api.github.com/repos/bnoordhuis/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnoordhuis/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnoordhuis/io.js/teams","hooks_url":"https://api.github.com/repos/bnoordhuis/io.js/hooks","issue_events_url":"https://api.github.com/repos/bnoordhuis/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/bnoordhuis/io.js/events","assignees_url":"https://api.github.com/repos/bnoordhuis/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/bnoordhuis/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/bnoordhuis/io.js/tags","blobs_url":"https://api.github.com/repos/bnoordhuis/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnoordhuis/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnoordhuis/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnoordhuis/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnoordhuis/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bnoordhuis/io.js/languages","stargazers_url":"https://api.github.com/repos/bnoordhuis/io.js/stargazers","contributors_url":"https://api.github.com/repos/bnoordhuis/io.js/contributors","subscribers_url":"https://api.github.com/repos/bnoordhuis/io.js/subscribers","subscription_url":"https://api.github.com/repos/bnoordhuis/io.js/subscription","commits_url":"https://api.github.com/repos/bnoordhuis/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnoordhuis/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnoordhuis/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnoordhuis/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnoordhuis/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/bnoordhuis/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnoordhuis/io.js/merges","archive_url":"https://api.github.com/repos/bnoordhuis/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnoordhuis/io.js/downloads","issues_url":"https://api.github.com/repos/bnoordhuis/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/bnoordhuis/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bnoordhuis/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bnoordhuis/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnoordhuis/io.js/labels{/name}","releases_url":"https://api.github.com/repos/bnoordhuis/io.js/releases{/id}","created_at":"2014-12-04T21:15:25Z","updated_at":"2014-12-30T16:28:26Z","pushed_at":"2015-07-16T14:47:18Z","git_url":"git://github.com/bnoordhuis/io.js.git","ssh_url":"git@github.com:bnoordhuis/io.js.git","clone_url":"https://github.com/bnoordhuis/io.js.git","svn_url":"https://github.com/bnoordhuis/io.js","homepage":null,"size":139825,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"v0.12"}},"base":{"label":"nodejs:master","ref":"master","sha":"6c3aabf455f5ed9c65bd6ae1ea208c752317216b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Future Node.js releases will be based on io.js","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-07-16T13:54:19Z","pushed_at":"2015-07-16T18:28:57Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":188797,"stargazers_count":12867,"watchers_count":12867,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1024,"mirror_url":null,"open_issues_count":306,"forks":1024,"open_issues":306,"watchers":12867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2193"},"html":{"href":"https://github.com/nodejs/io.js/pull/2193"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2193"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2193/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2193/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2193/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/7f8acb6450ba1522af649587854e1eec55268b54"}}}}