{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/27372471","id":27372471,"diff_hunk":"@@ -115,13 +118,18 @@ class APPLESEED_DLLSYMBOL ShaderGroup\n     // Return true if the shader group contains at least one debug closure.\n     bool has_debug() const;\n \n-    // Return true if the shader group uses dPdtime.\n+    // Return true if the shader group uses the dPdtime global.\n     bool uses_dPdtime() const;\n \n+    // Return the surface area of an object.\n+    // Can only be called if the shader group has emission closures.\n+    double surface_area(const AssemblyInstance* ass, const ObjectInstance* obj) const;","path":"src/appleseed/renderer/modeling/shadergroup/shadergroup.h","position":21,"original_position":21,"commit_id":"54c6f119583ddfa69a127b967be8c11227117399","original_commit_id":"54c6f119583ddfa69a127b967be8c11227117399","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars.githubusercontent.com/u/321290?v=3","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"`get_surface_area()`","created_at":"2015-03-30T08:12:49Z","updated_at":"2015-03-30T08:12:49Z","html_url":"https://github.com/appleseedhq/appleseed/pull/724#discussion_r27372471","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/27372471"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/724#discussion_r27372471"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724","id":32182436,"html_url":"https://github.com/appleseedhq/appleseed/pull/724","diff_url":"https://github.com/appleseedhq/appleseed/pull/724.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/724.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/724","number":724,"state":"open","locked":false,"title":"OSL surface area","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"body":"surfacearea() can now be used in OSL shaders that have emission closures.\r\nBecause of hierarchical instancing, the surface area cannot be stored in the objects themselves.\r\nInstead, it's stored in the ShaderGroups.\r\n\r\nI'll add a test scene when I can run appleseed.studio (it does not compile for me at the moment).\r\n\r\nFor some reason I cannot rebase this PR. Git shows 1 commit in my local repo but when I push it \r\nI get 4.\r\n","created_at":"2015-03-29T14:34:34Z","updated_at":"2015-03-30T08:12:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"336a5500e8f93cb763a59123ae132d310fcc16b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/724/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/54c6f119583ddfa69a127b967be8c11227117399","head":{"label":"est77:est_osl_surface_area","ref":"est_osl_surface_area","sha":"54c6f119583ddfa69a127b967be8c11227117399","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"repo":{"id":10621343,"name":"appleseed","full_name":"est77/appleseed","owner":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est77/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":true,"url":"https://api.github.com/repos/est77/appleseed","forks_url":"https://api.github.com/repos/est77/appleseed/forks","keys_url":"https://api.github.com/repos/est77/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est77/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est77/appleseed/teams","hooks_url":"https://api.github.com/repos/est77/appleseed/hooks","issue_events_url":"https://api.github.com/repos/est77/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/est77/appleseed/events","assignees_url":"https://api.github.com/repos/est77/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/est77/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/est77/appleseed/tags","blobs_url":"https://api.github.com/repos/est77/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est77/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est77/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/est77/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est77/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/est77/appleseed/languages","stargazers_url":"https://api.github.com/repos/est77/appleseed/stargazers","contributors_url":"https://api.github.com/repos/est77/appleseed/contributors","subscribers_url":"https://api.github.com/repos/est77/appleseed/subscribers","subscription_url":"https://api.github.com/repos/est77/appleseed/subscription","commits_url":"https://api.github.com/repos/est77/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/est77/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/est77/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/est77/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/est77/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/est77/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est77/appleseed/merges","archive_url":"https://api.github.com/repos/est77/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est77/appleseed/downloads","issues_url":"https://api.github.com/repos/est77/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/est77/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/est77/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/est77/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est77/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/est77/appleseed/releases{/id}","created_at":"2013-06-11T12:49:35Z","updated_at":"2015-03-29T14:23:04Z","pushed_at":"2015-03-29T19:26:55Z","git_url":"git://github.com/est77/appleseed.git","ssh_url":"git@github.com:est77/appleseed.git","clone_url":"https://github.com/est77/appleseed.git","svn_url":"https://github.com/est77/appleseed","homepage":"http://appleseedhq.net/","size":531464,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"80aff86b4d04b8635fe3eafe4a944f23baad6495","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","created_at":"2010-07-02T16:33:51Z","updated_at":"2015-03-29T19:39:13Z","pushed_at":"2015-03-29T19:39:15Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":600191,"stargazers_count":170,"watchers_count":170,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":170,"forks":58,"open_issues":170,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/724"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/724"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/54c6f119583ddfa69a127b967be8c11227117399"}}}}