{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/8905","labels_url":"https://api.github.com/repos/atom/atom/issues/8905/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/8905/comments","events_url":"https://api.github.com/repos/atom/atom/issues/8905/events","html_url":"https://github.com/atom/atom/pull/8905","id":107926698,"number":8905,"title":"Use logical coordinates in DisplayBuffer","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-23T14:02:30Z","updated_at":"2015-09-26T16:36:12Z","closed_at":"2015-09-26T16:05:10Z","pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/8905","html_url":"https://github.com/atom/atom/pull/8905","diff_url":"https://github.com/atom/atom/pull/8905.diff","patch_url":"https://github.com/atom/atom/pull/8905.patch"},"body":"This PR moves all the code that handles pixel positions into `TextEditorPresenter`, where it belongs. This is part of the effort to merge #8811, as we realized we needed the `DisplayBuffer` to be clean before proceeding with measurements.\r\n\r\nThis refactoring was quite big, so I'd :heart: to gather some feedback on the changes I have made (both on code quality and regressions).\r\n\r\nWhat's missing:\r\n\r\n- [x] Fix missing failing specs.\r\n- [x] Fix package specs (by shimming the original API).\r\n- [x] Maintain a scroll queue to preserve scroll history.\r\n- [x] Serialize scroll state in terms of logical coordinates.\r\n- [x] Confirm that packages work as expected.\r\n- [x] Confirm that atom core works as expected.\r\n- [x] Shim `TextEditor` APIs to use their `TextEditorElement` counterpart.\r\n- [x] Fix discovered bugs.\r\n\r\nThanks! :bow:\r\n\r\n/cc: @nathansobo @atom/feedback "},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/143468649","html_url":"https://github.com/atom/atom/pull/8905#issuecomment-143468649","issue_url":"https://api.github.com/repos/atom/atom/issues/8905","id":143468649,"user":{"login":"nathansobo","id":1789,"avatar_url":"https://avatars.githubusercontent.com/u/1789?v=3","gravatar_id":"","url":"https://api.github.com/users/nathansobo","html_url":"https://github.com/nathansobo","followers_url":"https://api.github.com/users/nathansobo/followers","following_url":"https://api.github.com/users/nathansobo/following{/other_user}","gists_url":"https://api.github.com/users/nathansobo/gists{/gist_id}","starred_url":"https://api.github.com/users/nathansobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathansobo/subscriptions","organizations_url":"https://api.github.com/users/nathansobo/orgs","repos_url":"https://api.github.com/users/nathansobo/repos","events_url":"https://api.github.com/users/nathansobo/events{/privacy}","received_events_url":"https://api.github.com/users/nathansobo/received_events","type":"User","site_admin":true},"created_at":"2015-09-26T16:36:12Z","updated_at":"2015-09-26T16:36:12Z","body":"💥🎉🇮🇹"}}