{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/45410473","id":45410473,"diff_hunk":"@@ -413,16 +410,18 @@ fi_ibv_rdm_tagged_process_recv(struct fi_ibv_rdm_ep *ep,\n \t\t\t\t\t struct fi_ibv_rdm_tagged_request,\n \t\t\t\t\t queue_entry);\n \n+\t\t\tconst int data_len = arrived_len -\n+\t\t\t\tsizeof(struct fi_ibv_rdm_tagged_header);\n+\n \t\t\tif (found_request->len < data_len) {\n-\t\t\t\tFI_IBV_ERROR\n-\t\t\t\t    (\"%s: %d RECV TRUNCATE, data_len=%d, posted_len=%d, \"\n-\t\t\t\t     \"conn %p, tag 0x%llx, tagmask %llx\\n\",\n-\t\t\t\t     __FUNCTION__, __LINE__, data_len,\n-\t\t\t\t     found_request->len, found_request->conn,\n-\t\t\t\t     (long long unsigned int)found_request->tag,\n-\t\t\t\t     (long long unsigned int)found_request->\n-\t\t\t\t     tagmask);\n-\t\t\t\tabort();\n+\t\t\t\tVERBS_INFO(FI_LOG_EP_DATA,\n+\t\t\t\t\t\"%s: %d RECV TRUNCATE, data_len=%d, posted_len=%d, \"\n+\t\t\t\t\t\"conn %p, tag 0x%llx, tagmask %llx\\n\",\n+\t\t\t\t\t__FUNCTION__, __LINE__, data_len,\n+\t\t\t\t\tfound_request->len, found_request->conn,\n+\t\t\t\t\tfound_request->tag,\n+\t\t\t\t\tfound_request->tagmask);\n+//\t\t\t\treturn -FI_EOTHER;","path":"prov/verbs/src/ep_rdm/verbs_tagged_ep_rdm.c","position":43,"original_position":43,"commit_id":"40d865fb4b57d47b449c831c040938f60e52b6d4","original_commit_id":"40d865fb4b57d47b449c831c040938f60e52b6d4","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Note that the return statement is commented out.  I'm not sure if this is intentional.  Would an assert() be useful here?","created_at":"2015-11-19T22:26:05Z","updated_at":"2015-11-19T22:26:05Z","html_url":"https://github.com/ofiwg/libfabric/pull/1472#discussion_r45410473","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/45410473"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1472#discussion_r45410473"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472","id":50954239,"html_url":"https://github.com/ofiwg/libfabric/pull/1472","diff_url":"https://github.com/ofiwg/libfabric/pull/1472.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1472.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1472","number":1472,"state":"open","locked":false,"title":"Bunch of cleanups for verbs/RDM","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"Per commits:\r\n1) CQ opening difference for RDM/MSG replaced by domain->rdm statement instead of attr->format\r\n2) Rename request matching functions\r\n3) Remove FI_IBV_ERROR macro, used VERBS_INFO. Add return code in case of unsuccessful repost receives\r\n4) Error handling in fi_ibv_open_rdm_ep\r\n5) Fix 6 coverity issues\r\n6) verbs: verbs_util macros do not use fi_log correctly #1463","created_at":"2015-11-17T14:37:52Z","updated_at":"2015-11-19T22:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f899f76d62ae2d395995c3a89e6c410f32fdce9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1472/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/40d865fb4b57d47b449c831c040938f60e52b6d4","head":{"label":"evgeny-leksikov:master","ref":"master","sha":"40d865fb4b57d47b449c831c040938f60e52b6d4","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":44616498,"name":"libfabric","full_name":"evgeny-leksikov/libfabric","owner":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evgeny-leksikov/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/libfabric","forks_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/releases{/id}","created_at":"2015-10-20T15:38:55Z","updated_at":"2015-10-29T18:45:18Z","pushed_at":"2015-11-19T08:49:51Z","git_url":"git://github.com/evgeny-leksikov/libfabric.git","ssh_url":"git@github.com:evgeny-leksikov/libfabric.git","clone_url":"https://github.com/evgeny-leksikov/libfabric.git","svn_url":"https://github.com/evgeny-leksikov/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":8428,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"0644818a9f6cc0da12c7858e06f37d8a8fae7c44","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-11-09T14:05:35Z","pushed_at":"2015-11-19T17:18:52Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":9106,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":53,"forks":53,"open_issues":53,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1472"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1472"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1472/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1472/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/40d865fb4b57d47b449c831c040938f60e52b6d4"}}}}