{"action":"created","issue":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/160","labels_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/160/comments","events_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/160/events","html_url":"https://github.com/solarkennedy/puppet-consul/pull/160","id":98474071,"number":160,"title":"[install] use data_dir from config_hash","user":{"login":"teaforthecat","id":360112,"avatar_url":"https://avatars.githubusercontent.com/u/360112?v=3","gravatar_id":"","url":"https://api.github.com/users/teaforthecat","html_url":"https://github.com/teaforthecat","followers_url":"https://api.github.com/users/teaforthecat/followers","following_url":"https://api.github.com/users/teaforthecat/following{/other_user}","gists_url":"https://api.github.com/users/teaforthecat/gists{/gist_id}","starred_url":"https://api.github.com/users/teaforthecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teaforthecat/subscriptions","organizations_url":"https://api.github.com/users/teaforthecat/orgs","repos_url":"https://api.github.com/users/teaforthecat/repos","events_url":"https://api.github.com/users/teaforthecat/events{/privacy}","received_events_url":"https://api.github.com/users/teaforthecat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-31T21:28:58Z","updated_at":"2015-08-01T16:33:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/160","html_url":"https://github.com/solarkennedy/puppet-consul/pull/160","diff_url":"https://github.com/solarkennedy/puppet-consul/pull/160.diff","patch_url":"https://github.com/solarkennedy/puppet-consul/pull/160.patch"},"body":"the data_dir variable in install.pp appears to be unused making it\r\nimpossible to change the owner of the data_dir directory. This makes it possible to change the owner of the data_dir, as well as force consistency with the configuration."},"comment":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/comments/126935746","html_url":"https://github.com/solarkennedy/puppet-consul/pull/160#issuecomment-126935746","issue_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/160","id":126935746,"user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T16:33:54Z","updated_at":"2015-08-01T16:33:54Z","body":"Yea, I don't mind moving the data_dir to be injected into the install class, but if you do that, please remove that other plumbing that aj linked to.\r\n\r\nI does look like we don't have tests coverage for ensuring that the owner is set correctly. So if isn't, please add a test to ensure it is correct and stays correct."}}