{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30","id":54279184,"html_url":"https://github.com/perfectsense/brightspot-base/pull/30","diff_url":"https://github.com/perfectsense/brightspot-base/pull/30.diff","patch_url":"https://github.com/perfectsense/brightspot-base/pull/30.patch","issue_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/30","number":30,"state":"closed","locked":false,"title":"Improve social share template and data","user":{"login":"jpencola","id":102225,"avatar_url":"https://avatars.githubusercontent.com/u/102225?v=3","gravatar_id":"","url":"https://api.github.com/users/jpencola","html_url":"https://github.com/jpencola","followers_url":"https://api.github.com/users/jpencola/followers","following_url":"https://api.github.com/users/jpencola/following{/other_user}","gists_url":"https://api.github.com/users/jpencola/gists{/gist_id}","starred_url":"https://api.github.com/users/jpencola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpencola/subscriptions","organizations_url":"https://api.github.com/users/jpencola/orgs","repos_url":"https://api.github.com/users/jpencola/repos","events_url":"https://api.github.com/users/jpencola/events{/privacy}","received_events_url":"https://api.github.com/users/jpencola/received_events","type":"User","site_admin":false},"body":"Refactors the data structure to support a list of service objects, each\r\none allowing a template/name/publicKey. This allows a way for us to\r\nexpanded upon those attributes (per social network) in the future;\r\nwhereas a list of strings does not. \r\n\r\nThis is not a backwards compatible change. The corresponding view-model Java will need to be updated to provide a list of `objects` vs. `strings` to the `services` field. Each of the objects will need to be mapped to a new template renderer found in `/assets/templates/base/elements/social-share-item`. ","created_at":"2015-12-21T17:03:29Z","updated_at":"2015-12-21T17:07:55Z","closed_at":"2015-12-21T17:07:55Z","merged_at":"2015-12-21T17:07:55Z","merge_commit_sha":"bb8eb045854ef0deb16eb76297ee0b67a2be8ac4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30/commits","review_comments_url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30/comments","review_comment_url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/30/comments","statuses_url":"https://api.github.com/repos/perfectsense/brightspot-base/statuses/8636e71fb1a6c587fc191698af4355cac145d11e","head":{"label":"perfectsense:feature/social-share-items","ref":"feature/social-share-items","sha":"8636e71fb1a6c587fc191698af4355cac145d11e","user":{"login":"perfectsense","id":260618,"avatar_url":"https://avatars.githubusercontent.com/u/260618?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectsense","html_url":"https://github.com/perfectsense","followers_url":"https://api.github.com/users/perfectsense/followers","following_url":"https://api.github.com/users/perfectsense/following{/other_user}","gists_url":"https://api.github.com/users/perfectsense/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectsense/subscriptions","organizations_url":"https://api.github.com/users/perfectsense/orgs","repos_url":"https://api.github.com/users/perfectsense/repos","events_url":"https://api.github.com/users/perfectsense/events{/privacy}","received_events_url":"https://api.github.com/users/perfectsense/received_events","type":"Organization","site_admin":false},"repo":{"id":37214128,"name":"brightspot-base","full_name":"perfectsense/brightspot-base","owner":{"login":"perfectsense","id":260618,"avatar_url":"https://avatars.githubusercontent.com/u/260618?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectsense","html_url":"https://github.com/perfectsense","followers_url":"https://api.github.com/users/perfectsense/followers","following_url":"https://api.github.com/users/perfectsense/following{/other_user}","gists_url":"https://api.github.com/users/perfectsense/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectsense/subscriptions","organizations_url":"https://api.github.com/users/perfectsense/orgs","repos_url":"https://api.github.com/users/perfectsense/repos","events_url":"https://api.github.com/users/perfectsense/events{/privacy}","received_events_url":"https://api.github.com/users/perfectsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/perfectsense/brightspot-base","description":"","fork":false,"url":"https://api.github.com/repos/perfectsense/brightspot-base","forks_url":"https://api.github.com/repos/perfectsense/brightspot-base/forks","keys_url":"https://api.github.com/repos/perfectsense/brightspot-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perfectsense/brightspot-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perfectsense/brightspot-base/teams","hooks_url":"https://api.github.com/repos/perfectsense/brightspot-base/hooks","issue_events_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/events{/number}","events_url":"https://api.github.com/repos/perfectsense/brightspot-base/events","assignees_url":"https://api.github.com/repos/perfectsense/brightspot-base/assignees{/user}","branches_url":"https://api.github.com/repos/perfectsense/brightspot-base/branches{/branch}","tags_url":"https://api.github.com/repos/perfectsense/brightspot-base/tags","blobs_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perfectsense/brightspot-base/statuses/{sha}","languages_url":"https://api.github.com/repos/perfectsense/brightspot-base/languages","stargazers_url":"https://api.github.com/repos/perfectsense/brightspot-base/stargazers","contributors_url":"https://api.github.com/repos/perfectsense/brightspot-base/contributors","subscribers_url":"https://api.github.com/repos/perfectsense/brightspot-base/subscribers","subscription_url":"https://api.github.com/repos/perfectsense/brightspot-base/subscription","commits_url":"https://api.github.com/repos/perfectsense/brightspot-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/perfectsense/brightspot-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/perfectsense/brightspot-base/contents/{+path}","compare_url":"https://api.github.com/repos/perfectsense/brightspot-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perfectsense/brightspot-base/merges","archive_url":"https://api.github.com/repos/perfectsense/brightspot-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perfectsense/brightspot-base/downloads","issues_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues{/number}","pulls_url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls{/number}","milestones_url":"https://api.github.com/repos/perfectsense/brightspot-base/milestones{/number}","notifications_url":"https://api.github.com/repos/perfectsense/brightspot-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perfectsense/brightspot-base/labels{/name}","releases_url":"https://api.github.com/repos/perfectsense/brightspot-base/releases{/id}","created_at":"2015-06-10T18:14:17Z","updated_at":"2015-10-28T18:51:22Z","pushed_at":"2015-12-21T17:07:55Z","git_url":"git://github.com/perfectsense/brightspot-base.git","ssh_url":"git@github.com:perfectsense/brightspot-base.git","clone_url":"https://github.com/perfectsense/brightspot-base.git","svn_url":"https://github.com/perfectsense/brightspot-base","homepage":null,"size":3999,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"perfectsense:master","ref":"master","sha":"25158af6ba9022089731959ed9d2da45f74bf71b","user":{"login":"perfectsense","id":260618,"avatar_url":"https://avatars.githubusercontent.com/u/260618?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectsense","html_url":"https://github.com/perfectsense","followers_url":"https://api.github.com/users/perfectsense/followers","following_url":"https://api.github.com/users/perfectsense/following{/other_user}","gists_url":"https://api.github.com/users/perfectsense/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectsense/subscriptions","organizations_url":"https://api.github.com/users/perfectsense/orgs","repos_url":"https://api.github.com/users/perfectsense/repos","events_url":"https://api.github.com/users/perfectsense/events{/privacy}","received_events_url":"https://api.github.com/users/perfectsense/received_events","type":"Organization","site_admin":false},"repo":{"id":37214128,"name":"brightspot-base","full_name":"perfectsense/brightspot-base","owner":{"login":"perfectsense","id":260618,"avatar_url":"https://avatars.githubusercontent.com/u/260618?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectsense","html_url":"https://github.com/perfectsense","followers_url":"https://api.github.com/users/perfectsense/followers","following_url":"https://api.github.com/users/perfectsense/following{/other_user}","gists_url":"https://api.github.com/users/perfectsense/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectsense/subscriptions","organizations_url":"https://api.github.com/users/perfectsense/orgs","repos_url":"https://api.github.com/users/perfectsense/repos","events_url":"https://api.github.com/users/perfectsense/events{/privacy}","received_events_url":"https://api.github.com/users/perfectsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/perfectsense/brightspot-base","description":"","fork":false,"url":"https://api.github.com/repos/perfectsense/brightspot-base","forks_url":"https://api.github.com/repos/perfectsense/brightspot-base/forks","keys_url":"https://api.github.com/repos/perfectsense/brightspot-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perfectsense/brightspot-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perfectsense/brightspot-base/teams","hooks_url":"https://api.github.com/repos/perfectsense/brightspot-base/hooks","issue_events_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/events{/number}","events_url":"https://api.github.com/repos/perfectsense/brightspot-base/events","assignees_url":"https://api.github.com/repos/perfectsense/brightspot-base/assignees{/user}","branches_url":"https://api.github.com/repos/perfectsense/brightspot-base/branches{/branch}","tags_url":"https://api.github.com/repos/perfectsense/brightspot-base/tags","blobs_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perfectsense/brightspot-base/statuses/{sha}","languages_url":"https://api.github.com/repos/perfectsense/brightspot-base/languages","stargazers_url":"https://api.github.com/repos/perfectsense/brightspot-base/stargazers","contributors_url":"https://api.github.com/repos/perfectsense/brightspot-base/contributors","subscribers_url":"https://api.github.com/repos/perfectsense/brightspot-base/subscribers","subscription_url":"https://api.github.com/repos/perfectsense/brightspot-base/subscription","commits_url":"https://api.github.com/repos/perfectsense/brightspot-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/perfectsense/brightspot-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/perfectsense/brightspot-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/perfectsense/brightspot-base/contents/{+path}","compare_url":"https://api.github.com/repos/perfectsense/brightspot-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perfectsense/brightspot-base/merges","archive_url":"https://api.github.com/repos/perfectsense/brightspot-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perfectsense/brightspot-base/downloads","issues_url":"https://api.github.com/repos/perfectsense/brightspot-base/issues{/number}","pulls_url":"https://api.github.com/repos/perfectsense/brightspot-base/pulls{/number}","milestones_url":"https://api.github.com/repos/perfectsense/brightspot-base/milestones{/number}","notifications_url":"https://api.github.com/repos/perfectsense/brightspot-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perfectsense/brightspot-base/labels{/name}","releases_url":"https://api.github.com/repos/perfectsense/brightspot-base/releases{/id}","created_at":"2015-06-10T18:14:17Z","updated_at":"2015-10-28T18:51:22Z","pushed_at":"2015-12-21T17:07:55Z","git_url":"git://github.com/perfectsense/brightspot-base.git","ssh_url":"git@github.com:perfectsense/brightspot-base.git","clone_url":"https://github.com/perfectsense/brightspot-base.git","svn_url":"https://github.com/perfectsense/brightspot-base","homepage":null,"size":3999,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30"},"html":{"href":"https://github.com/perfectsense/brightspot-base/pull/30"},"issue":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/issues/30"},"comments":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/perfectsense/brightspot-base/statuses/8636e71fb1a6c587fc191698af4355cac145d11e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"trhoppe","id":1325346,"avatar_url":"https://avatars.githubusercontent.com/u/1325346?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoppe","html_url":"https://github.com/trhoppe","followers_url":"https://api.github.com/users/trhoppe/followers","following_url":"https://api.github.com/users/trhoppe/following{/other_user}","gists_url":"https://api.github.com/users/trhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoppe/subscriptions","organizations_url":"https://api.github.com/users/trhoppe/orgs","repos_url":"https://api.github.com/users/trhoppe/repos","events_url":"https://api.github.com/users/trhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/trhoppe/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":119,"deletions":35,"changed_files":7}}