{"action":"created","issue":{"url":"https://api.github.com/repos/micropython/micropython/issues/1201","labels_url":"https://api.github.com/repos/micropython/micropython/issues/1201/labels{/name}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1201/comments","events_url":"https://api.github.com/repos/micropython/micropython/issues/1201/events","html_url":"https://github.com/micropython/micropython/pull/1201","id":71103096,"number":1201,"title":"Replace py-version.sh with makeversionhdr.py, written in Python.","user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars.githubusercontent.com/u/6187689?v=3","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-26T18:27:52Z","updated_at":"2015-04-29T09:14:55Z","closed_at":"2015-04-28T22:55:37Z","pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1201","html_url":"https://github.com/micropython/micropython/pull/1201","diff_url":"https://github.com/micropython/micropython/pull/1201.diff","patch_url":"https://github.com/micropython/micropython/pull/1201.patch"},"body":"To build uPy currently requires make (for Makefile), bash (for py-version.sh) and Python (for makeqstrdata.py).  That seems pretty reasonable except when you learn that on Windows py-version.sh needs ugly work around like this: https://github.com/micropython/micropython/commit/c52f1258a8ececbaf25331c6cbfc373e6ed133b4\r\n\r\nSo this PR replaces py-version.sh with a Python version, makeversionhdr.py (Py 2 and 3 compatible).  This eliminates the need for bash to run build scripts (at least for the core py stuff).\r\n\r\nYes the Python version of py-version.sh is longer than the bash version, but it's also more robust and easier to add new features.\r\n\r\nAlso, py-version.h was renamed to mpversion.h for filename consistency with mpconfig*.h.\r\n\r\n@stinos: can you check that this actually works with Windows?  May need some tweaks..."},"comment":{"url":"https://api.github.com/repos/micropython/micropython/issues/comments/97365419","html_url":"https://github.com/micropython/micropython/pull/1201#issuecomment-97365419","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1201","id":97365419,"user":{"login":"stinos","id":1902997,"avatar_url":"https://avatars.githubusercontent.com/u/1902997?v=3","gravatar_id":"","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T09:14:55Z","updated_at":"2015-04-29T09:14:55Z","body":"Thanks!"}}