{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/comments/26034794","id":26034794,"diff_hunk":"@@ -183,19 +190,35 @@\n         run_command([\"inspect\", \"--exclude-scope=packages,repositories\", example_host])\n       end\n \n-      it \"forwards the --skip-files option to the InspectTask\" do\n-        expect_any_instance_of(InspectTask).to receive(:inspect_system).\n-          with(\n-            an_instance_of(SystemDescriptionStore),\n-            example_host,\n-            example_host,\n-            an_instance_of(CurrentUser),\n-            Inspector.all_scopes,\n-            skip_files: \"/foo/bar\"\n-          ).\n-          and_return(description)\n+      it \"forwards the --skip-files option to the InspectTask as an unmanaged_files filter\" do\n+        expect_any_instance_of(InspectTask).to receive(:inspect_system) do |_instance, _store,\n+          _host, _name, _user, _scopes, filter, _options|\n+          expect(filter.element_filter_for(\"/unmanaged_files/files/name\").matchers).\n+            to include(\"/foo/bar\", \"/baz\")\n+        end.and_return(description)\n \n-        run_command([\"inspect\", \"--skip-files=/foo/bar\", example_host])\n+        run_command([\"inspect\", \"--skip-files=/foo/bar,/baz\", example_host])\n+      end\n+\n+      it \"the --skip-files option reads a list of excluded files from a file\" do\n+        expect_any_instance_of(InspectTask).to receive(:inspect_system) do |_instance, _store,\n+          _host, _name, _user, _scopes, filter, _options|\n+          expect(filter.element_filter_for(\"/unmanaged_files/files/name\").matchers).\n+            to include(\"/foo/bar\", \"/baz\")\n+        end.and_return(description)\n+\n+        FileUtils.mkdir_p(\"/tmp\")\n+        exclude_file = Tempfile.new('exclude_file')","path":"spec/unit/cli_spec.rb","position":90,"original_position":90,"commit_id":"861f113e481a163a4af4a1993db64bb54f74b23e","original_commit_id":"861f113e481a163a4af4a1993db64bb54f74b23e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-03-09T13:32:05Z","updated_at":"2015-03-09T13:32:05Z","html_url":"https://github.com/SUSE/machinery/pull/668#discussion_r26034794","pull_request_url":"https://api.github.com/repos/SUSE/machinery/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments/26034794"},"html":{"href":"https://github.com/SUSE/machinery/pull/668#discussion_r26034794"},"pull_request":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/668","id":30647421,"html_url":"https://github.com/SUSE/machinery/pull/668","diff_url":"https://github.com/SUSE/machinery/pull/668.diff","patch_url":"https://github.com/SUSE/machinery/pull/668.patch","issue_url":"https://api.github.com/repos/SUSE/machinery/issues/668","number":668,"state":"open","locked":false,"title":"[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_150306_store_used_filter_in_description'","user":{"login":"aduffeck","id":203813,"avatar_url":"https://avatars.githubusercontent.com/u/203813?v=3","gravatar_id":"","url":"https://api.github.com/users/aduffeck","html_url":"https://github.com/aduffeck","followers_url":"https://api.github.com/users/aduffeck/followers","following_url":"https://api.github.com/users/aduffeck/following{/other_user}","gists_url":"https://api.github.com/users/aduffeck/gists{/gist_id}","starred_url":"https://api.github.com/users/aduffeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduffeck/subscriptions","organizations_url":"https://api.github.com/users/aduffeck/orgs","repos_url":"https://api.github.com/users/aduffeck/repos","events_url":"https://api.github.com/users/aduffeck/events{/privacy}","received_events_url":"https://api.github.com/users/aduffeck/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\r\n  * e2b1627 Add documentation for the Filter class\r\n  * 0c1861b Add copyright notes\r\n  * df6bed7 Fix filter behavior regarding arrays in the filter definition\r\n  * b00bc21 Do not require quoting of array filters when there's only one filter\r\n  * 3debe88 Improve method name\r\n  * 89bacf1 Fix hound issues\r\n  * cfaf825 Extract filter preparation and handling code into separate methods\r\n  * 8d28733 Adapt schema to allow storing the used filter during inspection\r\n  * 4a49a06 Adapt to new signature of InspectTask#inspect_system\r\n  * 42b59fe Store filter which was used for inspection in the description metadata\r\n  * 42a0f6c Add Filter#to_array which returns an array of element filter definitions\r\n  * 42c76a0 Fix parsing of filter definitions with simple lists\r\n  * 0c93bc5 Add Filter#add_filter_definition which adds new element filters\r\n  * 85a2ec3 Make Filter#parse_filter_definition a class method","created_at":"2015-03-06T14:16:38Z","updated_at":"2015-03-09T13:32:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4342699fdb351757d94b7bf4329c1fa1f5de85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/machinery/pulls/668/commits","review_comments_url":"https://api.github.com/repos/SUSE/machinery/pulls/668/comments","review_comment_url":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/machinery/issues/668/comments","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/861f113e481a163a4af4a1993db64bb54f74b23e","head":{"label":"SUSE:review_150306_store_used_filter_in_description","ref":"review_150306_store_used_filter_in_description","sha":"861f113e481a163a4af4a1993db64bb54f74b23e","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-03-06T10:53:10Z","pushed_at":"2015-03-09T13:31:47Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":14235,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":28,"forks":6,"open_issues":28,"watchers":41,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"c2b22702004a68a33ea28c6c3574ff066bd6d28c","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-03-06T10:53:10Z","pushed_at":"2015-03-09T13:31:47Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":14235,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":28,"forks":6,"open_issues":28,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/668"},"html":{"href":"https://github.com/SUSE/machinery/pull/668"},"issue":{"href":"https://api.github.com/repos/SUSE/machinery/issues/668"},"comments":{"href":"https://api.github.com/repos/SUSE/machinery/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/machinery/statuses/861f113e481a163a4af4a1993db64bb54f74b23e"}}}}