{"action":"opened","number":710,"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/710","id":44004406,"html_url":"https://github.com/mozilla/olympia/pull/710","diff_url":"https://github.com/mozilla/olympia/pull/710.diff","patch_url":"https://github.com/mozilla/olympia/pull/710.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/710","number":710,"state":"open","locked":false,"title":"BUG 1196293 : Remove rating stars from edit review reply.","user":{"login":"crdoconnor","id":6067509,"avatar_url":"https://avatars.githubusercontent.com/u/6067509?v=3","gravatar_id":"","url":"https://api.github.com/users/crdoconnor","html_url":"https://github.com/crdoconnor","followers_url":"https://api.github.com/users/crdoconnor/followers","following_url":"https://api.github.com/users/crdoconnor/following{/other_user}","gists_url":"https://api.github.com/users/crdoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/crdoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdoconnor/subscriptions","organizations_url":"https://api.github.com/users/crdoconnor/orgs","repos_url":"https://api.github.com/users/crdoconnor/repos","events_url":"https://api.github.com/users/crdoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/crdoconnor/received_events","type":"User","site_admin":false},"body":"I interpreted https://bugzilla.mozilla.org/show_bug.cgi?id=1196293 as to mean that the ratings should be removed altogether when editing reviews (i.e. remove line 9 from apps/reviews/templates/reviews/edit_review.html).\r\n\r\nThe test I wrote to verify this fix interacts via HTML ids and classes, so I added some IDs and classes to elements I wanted to interact with.\r\n\r\nThis pull request also includes a test engine to run the test. This new testing framework 'experiment' is confined to the tests/ directory :)\r\n\r\nThe engine's advantages:\r\n\r\n* It automates virtually every step in https://olympia.readthedocs.org/en/latest/topics/install-olympia/installation.html. just sudo pip install hitch, run hitch init in the tests directory and then run hitch test .\r\n* The test cases you can build with it are relatively clean and readable (IMHO).\r\n* It builds and runs all parts of the system together (MySQL, Memcache, Elastic Search, Rabbit, Django, Celery, SMTP server).\r\n* It downloads and builds specific versions of MySQL/Memcache/Elastic/Rabbit so you can match the exact version to what you have running in production.\r\n\r\nThe engine's current shortcomings (which will be fixed):\r\n\r\n* The set_up is currently very slow as it re-runs pip install, runs migrations, installs fixtures and runs generate_addons at the beginning of every test. This means it is entirely self-bootstrapping but individual test runs are slow (about 2 minutes on 2nd run). I'll implement some caching to deal with this which should bring it down to about 15 seconds (or less).\r\n* There should be a way to get it to run the tests with docker as well.\r\n* Celery is not running yet.\r\n* While it should theoretically work on Mac OS and any Linux distribution, the framework is not yet set up to translate the packages required yet - e.g. libxml2-dev on ubuntu -> libxml2 on brew.\r\n* Probably some bugs I don't yet know about.","created_at":"2015-09-02T15:17:07Z","updated_at":"2015-09-02T15:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/710/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/710/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/710/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/37c5aafa2ae9637889168314bd4a2809f0e6a298","head":{"label":"crdoconnor:master","ref":"master","sha":"37c5aafa2ae9637889168314bd4a2809f0e6a298","user":{"login":"crdoconnor","id":6067509,"avatar_url":"https://avatars.githubusercontent.com/u/6067509?v=3","gravatar_id":"","url":"https://api.github.com/users/crdoconnor","html_url":"https://github.com/crdoconnor","followers_url":"https://api.github.com/users/crdoconnor/followers","following_url":"https://api.github.com/users/crdoconnor/following{/other_user}","gists_url":"https://api.github.com/users/crdoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/crdoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdoconnor/subscriptions","organizations_url":"https://api.github.com/users/crdoconnor/orgs","repos_url":"https://api.github.com/users/crdoconnor/repos","events_url":"https://api.github.com/users/crdoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/crdoconnor/received_events","type":"User","site_admin":false},"repo":{"id":41404922,"name":"olympia","full_name":"crdoconnor/olympia","owner":{"login":"crdoconnor","id":6067509,"avatar_url":"https://avatars.githubusercontent.com/u/6067509?v=3","gravatar_id":"","url":"https://api.github.com/users/crdoconnor","html_url":"https://github.com/crdoconnor","followers_url":"https://api.github.com/users/crdoconnor/followers","following_url":"https://api.github.com/users/crdoconnor/following{/other_user}","gists_url":"https://api.github.com/users/crdoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/crdoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdoconnor/subscriptions","organizations_url":"https://api.github.com/users/crdoconnor/orgs","repos_url":"https://api.github.com/users/crdoconnor/repos","events_url":"https://api.github.com/users/crdoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/crdoconnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crdoconnor/olympia","description":"addons.mozilla.org, reloaded.","fork":true,"url":"https://api.github.com/repos/crdoconnor/olympia","forks_url":"https://api.github.com/repos/crdoconnor/olympia/forks","keys_url":"https://api.github.com/repos/crdoconnor/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crdoconnor/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crdoconnor/olympia/teams","hooks_url":"https://api.github.com/repos/crdoconnor/olympia/hooks","issue_events_url":"https://api.github.com/repos/crdoconnor/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/crdoconnor/olympia/events","assignees_url":"https://api.github.com/repos/crdoconnor/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/crdoconnor/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/crdoconnor/olympia/tags","blobs_url":"https://api.github.com/repos/crdoconnor/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crdoconnor/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crdoconnor/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/crdoconnor/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crdoconnor/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/crdoconnor/olympia/languages","stargazers_url":"https://api.github.com/repos/crdoconnor/olympia/stargazers","contributors_url":"https://api.github.com/repos/crdoconnor/olympia/contributors","subscribers_url":"https://api.github.com/repos/crdoconnor/olympia/subscribers","subscription_url":"https://api.github.com/repos/crdoconnor/olympia/subscription","commits_url":"https://api.github.com/repos/crdoconnor/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/crdoconnor/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/crdoconnor/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/crdoconnor/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/crdoconnor/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/crdoconnor/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crdoconnor/olympia/merges","archive_url":"https://api.github.com/repos/crdoconnor/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crdoconnor/olympia/downloads","issues_url":"https://api.github.com/repos/crdoconnor/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/crdoconnor/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/crdoconnor/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/crdoconnor/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crdoconnor/olympia/labels{/name}","releases_url":"https://api.github.com/repos/crdoconnor/olympia/releases{/id}","created_at":"2015-08-26T04:47:25Z","updated_at":"2015-08-26T04:47:31Z","pushed_at":"2015-09-02T14:27:41Z","git_url":"git://github.com/crdoconnor/olympia.git","ssh_url":"git@github.com:crdoconnor/olympia.git","clone_url":"https://github.com/crdoconnor/olympia.git","svn_url":"https://github.com/crdoconnor/olympia","homepage":"https://addons.mozilla.org/","size":406597,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"5bdfd54723ee13fccc452d95de7eeeeb6e2f1cce","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-09-01T17:12:45Z","pushed_at":"2015-09-02T13:40:07Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":465204,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":16,"forks":98,"open_issues":16,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/710"},"html":{"href":"https://github.com/mozilla/olympia/pull/710"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/710"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/37c5aafa2ae9637889168314bd4a2809f0e6a298"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":379,"deletions":9,"changed_files":14}}