{"action":"created","comment":{"url":"https://api.github.com/repos/change/i18n_routable/pulls/comments/32582911","id":32582911,"diff_hunk":"@@ -4,26 +4,25 @@ module LocalizableUrlHelper\n \n       # we override this, but it really only removes positional_keys that are\n       # locale or i18n_*\n-      def define_url_helper_with_localize(route, name, kind, options)","path":"lib/i18n_routable/generating/localizable_url_helper.rb","position":4,"original_position":4,"commit_id":"b0bf3c1eea6aca72a2b1af521bc826d4c830d0c6","original_commit_id":"b0bf3c1eea6aca72a2b1af521bc826d4c830d0c6","user":{"login":"mdimas","id":279556,"avatar_url":"https://avatars.githubusercontent.com/u/279556?v=3","gravatar_id":"","url":"https://api.github.com/users/mdimas","html_url":"https://github.com/mdimas","followers_url":"https://api.github.com/users/mdimas/followers","following_url":"https://api.github.com/users/mdimas/following{/other_user}","gists_url":"https://api.github.com/users/mdimas/gists{/gist_id}","starred_url":"https://api.github.com/users/mdimas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdimas/subscriptions","organizations_url":"https://api.github.com/users/mdimas/orgs","repos_url":"https://api.github.com/users/mdimas/repos","events_url":"https://api.github.com/users/mdimas/events{/privacy}","received_events_url":"https://api.github.com/users/mdimas/received_events","type":"User","site_admin":false},"body":"I was playing around with this and removed this entire file and the tests still passed. All the extension was supposed to do is remove `:locale` and `:i18n_` segments, and it looks like `ActionDispatch::Routing::RouteSet::NamedRouteCollection::UrlHelper` might do that now already.","created_at":"2015-06-16T23:29:39Z","updated_at":"2015-06-16T23:29:39Z","html_url":"https://github.com/change/i18n_routable/pull/3#discussion_r32582911","pull_request_url":"https://api.github.com/repos/change/i18n_routable/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/comments/32582911"},"html":{"href":"https://github.com/change/i18n_routable/pull/3#discussion_r32582911"},"pull_request":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/change/i18n_routable/pulls/3","id":37748541,"html_url":"https://github.com/change/i18n_routable/pull/3","diff_url":"https://github.com/change/i18n_routable/pull/3.diff","patch_url":"https://github.com/change/i18n_routable/pull/3.patch","issue_url":"https://api.github.com/repos/change/i18n_routable/issues/3","number":3,"state":"open","locked":false,"title":"[WiP] CHANGE-20414 Remove Journey","user":{"login":"RyanMcDonald","id":2695365,"avatar_url":"https://avatars.githubusercontent.com/u/2695365?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanMcDonald","html_url":"https://github.com/RyanMcDonald","followers_url":"https://api.github.com/users/RyanMcDonald/followers","following_url":"https://api.github.com/users/RyanMcDonald/following{/other_user}","gists_url":"https://api.github.com/users/RyanMcDonald/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanMcDonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanMcDonald/subscriptions","organizations_url":"https://api.github.com/users/RyanMcDonald/orgs","repos_url":"https://api.github.com/users/RyanMcDonald/repos","events_url":"https://api.github.com/users/RyanMcDonald/events{/privacy}","received_events_url":"https://api.github.com/users/RyanMcDonald/received_events","type":"User","site_admin":false},"body":"Removed the Journey gem which is now included in the ActionDispatch module in Rails 4.2. The 4.2 upgrade also brought a bunch of other code changes in ActionDispatch, so some refactoring was necessary.","created_at":"2015-06-16T00:11:06Z","updated_at":"2015-06-16T23:29:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef68b8a3e82b105756d712d7a54b51b444d67ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/change/i18n_routable/pulls/3/commits","review_comments_url":"https://api.github.com/repos/change/i18n_routable/pulls/3/comments","review_comment_url":"https://api.github.com/repos/change/i18n_routable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/change/i18n_routable/issues/3/comments","statuses_url":"https://api.github.com/repos/change/i18n_routable/statuses/b0bf3c1eea6aca72a2b1af521bc826d4c830d0c6","head":{"label":"change:CHANGE-20414-remove-journey","ref":"CHANGE-20414-remove-journey","sha":"b0bf3c1eea6aca72a2b1af521bc826d4c830d0c6","user":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"repo":{"id":3243353,"name":"i18n_routable","full_name":"change/i18n_routable","owner":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/change/i18n_routable","description":"Localized routes","fork":false,"url":"https://api.github.com/repos/change/i18n_routable","forks_url":"https://api.github.com/repos/change/i18n_routable/forks","keys_url":"https://api.github.com/repos/change/i18n_routable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/change/i18n_routable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/change/i18n_routable/teams","hooks_url":"https://api.github.com/repos/change/i18n_routable/hooks","issue_events_url":"https://api.github.com/repos/change/i18n_routable/issues/events{/number}","events_url":"https://api.github.com/repos/change/i18n_routable/events","assignees_url":"https://api.github.com/repos/change/i18n_routable/assignees{/user}","branches_url":"https://api.github.com/repos/change/i18n_routable/branches{/branch}","tags_url":"https://api.github.com/repos/change/i18n_routable/tags","blobs_url":"https://api.github.com/repos/change/i18n_routable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/change/i18n_routable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/change/i18n_routable/git/refs{/sha}","trees_url":"https://api.github.com/repos/change/i18n_routable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/change/i18n_routable/statuses/{sha}","languages_url":"https://api.github.com/repos/change/i18n_routable/languages","stargazers_url":"https://api.github.com/repos/change/i18n_routable/stargazers","contributors_url":"https://api.github.com/repos/change/i18n_routable/contributors","subscribers_url":"https://api.github.com/repos/change/i18n_routable/subscribers","subscription_url":"https://api.github.com/repos/change/i18n_routable/subscription","commits_url":"https://api.github.com/repos/change/i18n_routable/commits{/sha}","git_commits_url":"https://api.github.com/repos/change/i18n_routable/git/commits{/sha}","comments_url":"https://api.github.com/repos/change/i18n_routable/comments{/number}","issue_comment_url":"https://api.github.com/repos/change/i18n_routable/issues/comments{/number}","contents_url":"https://api.github.com/repos/change/i18n_routable/contents/{+path}","compare_url":"https://api.github.com/repos/change/i18n_routable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/change/i18n_routable/merges","archive_url":"https://api.github.com/repos/change/i18n_routable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/change/i18n_routable/downloads","issues_url":"https://api.github.com/repos/change/i18n_routable/issues{/number}","pulls_url":"https://api.github.com/repos/change/i18n_routable/pulls{/number}","milestones_url":"https://api.github.com/repos/change/i18n_routable/milestones{/number}","notifications_url":"https://api.github.com/repos/change/i18n_routable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/change/i18n_routable/labels{/name}","releases_url":"https://api.github.com/repos/change/i18n_routable/releases{/id}","created_at":"2012-01-23T01:09:21Z","updated_at":"2015-05-29T22:14:46Z","pushed_at":"2015-06-16T00:46:52Z","git_url":"git://github.com/change/i18n_routable.git","ssh_url":"git@github.com:change/i18n_routable.git","clone_url":"https://github.com/change/i18n_routable.git","svn_url":"https://github.com/change/i18n_routable","homepage":"","size":488,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"change:master","ref":"master","sha":"110819fdf74427342ce223a4dea29e94c1c8fbbe","user":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"repo":{"id":3243353,"name":"i18n_routable","full_name":"change/i18n_routable","owner":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/change/i18n_routable","description":"Localized routes","fork":false,"url":"https://api.github.com/repos/change/i18n_routable","forks_url":"https://api.github.com/repos/change/i18n_routable/forks","keys_url":"https://api.github.com/repos/change/i18n_routable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/change/i18n_routable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/change/i18n_routable/teams","hooks_url":"https://api.github.com/repos/change/i18n_routable/hooks","issue_events_url":"https://api.github.com/repos/change/i18n_routable/issues/events{/number}","events_url":"https://api.github.com/repos/change/i18n_routable/events","assignees_url":"https://api.github.com/repos/change/i18n_routable/assignees{/user}","branches_url":"https://api.github.com/repos/change/i18n_routable/branches{/branch}","tags_url":"https://api.github.com/repos/change/i18n_routable/tags","blobs_url":"https://api.github.com/repos/change/i18n_routable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/change/i18n_routable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/change/i18n_routable/git/refs{/sha}","trees_url":"https://api.github.com/repos/change/i18n_routable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/change/i18n_routable/statuses/{sha}","languages_url":"https://api.github.com/repos/change/i18n_routable/languages","stargazers_url":"https://api.github.com/repos/change/i18n_routable/stargazers","contributors_url":"https://api.github.com/repos/change/i18n_routable/contributors","subscribers_url":"https://api.github.com/repos/change/i18n_routable/subscribers","subscription_url":"https://api.github.com/repos/change/i18n_routable/subscription","commits_url":"https://api.github.com/repos/change/i18n_routable/commits{/sha}","git_commits_url":"https://api.github.com/repos/change/i18n_routable/git/commits{/sha}","comments_url":"https://api.github.com/repos/change/i18n_routable/comments{/number}","issue_comment_url":"https://api.github.com/repos/change/i18n_routable/issues/comments{/number}","contents_url":"https://api.github.com/repos/change/i18n_routable/contents/{+path}","compare_url":"https://api.github.com/repos/change/i18n_routable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/change/i18n_routable/merges","archive_url":"https://api.github.com/repos/change/i18n_routable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/change/i18n_routable/downloads","issues_url":"https://api.github.com/repos/change/i18n_routable/issues{/number}","pulls_url":"https://api.github.com/repos/change/i18n_routable/pulls{/number}","milestones_url":"https://api.github.com/repos/change/i18n_routable/milestones{/number}","notifications_url":"https://api.github.com/repos/change/i18n_routable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/change/i18n_routable/labels{/name}","releases_url":"https://api.github.com/repos/change/i18n_routable/releases{/id}","created_at":"2012-01-23T01:09:21Z","updated_at":"2015-05-29T22:14:46Z","pushed_at":"2015-06-16T00:46:52Z","git_url":"git://github.com/change/i18n_routable.git","ssh_url":"git@github.com:change/i18n_routable.git","clone_url":"https://github.com/change/i18n_routable.git","svn_url":"https://github.com/change/i18n_routable","homepage":"","size":488,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/3"},"html":{"href":"https://github.com/change/i18n_routable/pull/3"},"issue":{"href":"https://api.github.com/repos/change/i18n_routable/issues/3"},"comments":{"href":"https://api.github.com/repos/change/i18n_routable/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/change/i18n_routable/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/change/i18n_routable/statuses/b0bf3c1eea6aca72a2b1af521bc826d4c830d0c6"}}}}