{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/29800643","id":29800643,"diff_hunk":"@@ -5,36 +5,41 @@\n \n 'use strict';\n \n+var $ = require( 'jquery' );\n require( 'slick' );\n \n-var ContentSlider = require( '../../../modules/content-slider' ).contentSlider;\n+var ContentSlider = require( '../../../modules/content-slider' ).ContentSlider;\n var BreakpointHandler = require( '../../../modules/breakpoint-handler' ).BreakpointHandler;\n \n-$('document').ready(function () {\n-  var slider, handler;\n-  if (!$( 'html' ).hasClass( 'lt-ie9' )) {\n-    handler = new BreakpointHandler( {\n-      breakpoint: 599,\n-      type:       'max',\n-      enter:      function() {\n-        // close any open expandables\n-        $( '.org-chart' ).find( '.expandable__expanded .expandable_target' ).click();\n-        // hide org chart branches\n-        $( '.org-chart_branches' ).hide();\n-        // show content slider & mobile nav links\n-        $( '#content-slider, .content-hide' ).show();\n-        // init slider\n-        slider = new ContentSlider( '#content-slider', 1);\n-      },\n-      leave:      function() {\n-        // destroy slider\n-        slider && slider.destroy();\n-        slider = null;\n-        // hide content slider & mobile nav links\n-        $( '#content-slider, .content-hide' ).hide();\n-        // show org chart branches\n-        $( '.org-chart_branches' ).show();\n-      }\n-    });\n-  }\n-});\n+if (!$( 'html' ).hasClass( 'lt-ie9' )) {","path":"src/static/js/routes/the-bureau/bureau-structure/index.js","position":null,"original_position":39,"commit_id":"ecb0d7cb53da13fb7d0a1b1e9cae490297860749","original_commit_id":"0713e338cece1a6fd2e146390a68d360879c7759","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"https://github.com/cfpb/cfgov-refresh/commit/ecb0d7cb53da13fb7d0a1b1e9cae490297860749","created_at":"2015-05-06T20:50:59Z","updated_at":"2015-05-06T20:50:59Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/516#discussion_r29800643","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/29800643"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/516#discussion_r29800643"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516","id":34847661,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/516","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/516.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/516.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/516","number":516,"state":"open","locked":false,"title":"Df 1882 update eslint","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"Updates ESLint to latest version (0.20.0) and fixes many offenses.\r\n\r\n## Additions\r\n- Adds ESLint config to show JS parser used.\r\n- Adds additional global settings available and sets `amd`, `mocha`, and `phantomjs` to `true` (in addition to the existing `true` settings for `browser` and `node`). \r\n- Adds new ESLint rules: `no-dupe-args`, `no-duplicate-case`, `newline-after-var`, `no-continue`, `operator-linebreak`, and `object-shorthand`.\r\n- Adds new options for `one-var` and `space-infix-ops`.\r\n- Adds `@todo` for `no-warning-comments` to allow for JSDoc to-do code comment syntax (http://usejsdoc.org/tags-todo.html).\r\n- Adds missing jQuery variable declarations to modules.\r\n\r\n## Removals\r\n- Removes jQuery and $ variables as defined ESLint globals. We shouldn't encourage global jQuery initialization and this can mask issues around when jQuery is initialized.\r\n- Removes nested `$( 'document' ).ready( function () {` statements.\r\n\r\n## Changes\r\n\r\n- Re-adds `lintjs` as subtask of `jsdev` task.\r\n- Updates `ecmaFeatures` config from deprecated `ecmaFeatures: 6` setting to include specific config flags for ES6 usage. Turned all off till we need them, except for `for of` loops and `jsx` (to support React used elsewhere in the bureau.\r\n- Updates `grunt-eslint` to `12.0.0.`\r\n- Refactors JS to fix ESLint errors, with the exception of line 149 in cf_inputSplit.js, which is set to be ignored for now till it can be refactored and tested. \r\n- Cap-cases `ContentSlider` since it's a constructor.\r\n\r\n## Testing\r\n\r\n- Run `grunt jsdev`, there should be no ESLint errors and a reduced number of warnings.\r\n\r\n## Review\r\n\r\n- @KimberlyMunoz  \r\n- @jimmynotjim \r\n- @sebworks \r\n\r\n## Notes\r\n\r\n- `newline-after-var` was added but I turned this off after testing because this rule doesn't provide edge-case options that would be valuable to have. For instance, having both a space after defining top-scope vars for module imports, but no space within a compact function scope that defines one var.","created_at":"2015-05-06T18:50:37Z","updated_at":"2015-05-06T20:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f7d93e9b03b7366b6285cae90f551fa5bab8e83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/516/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/ecb0d7cb53da13fb7d0a1b1e9cae490297860749","head":{"label":"cfpb:DF-1882-update-eslint","ref":"DF-1882-update-eslint","sha":"ecb0d7cb53da13fb7d0a1b1e9cae490297860749","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-05-06T19:15:19Z","pushed_at":"2015-05-06T20:50:49Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":90742,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":69,"forks":14,"open_issues":69,"watchers":7,"default_branch":"flapjack"}},"base":{"label":"cfpb:flapjack","ref":"flapjack","sha":"81233d885109da78ea3f46c788e8a129a02deaa2","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-05-06T19:15:19Z","pushed_at":"2015-05-06T20:50:49Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":90742,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":69,"forks":14,"open_issues":69,"watchers":7,"default_branch":"flapjack"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/516"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/516"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/ecb0d7cb53da13fb7d0a1b1e9cae490297860749"}}}}