{"action":"created","comment":{"url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/comments/28588281","id":28588281,"diff_hunk":"@@ -72,11 +88,15 @@ var Grid = function(table, options) {\n     model: Column\n   });\n \n+  this.$height = options.height;","path":"src/grid.js","position":36,"original_position":36,"commit_id":"9cd461642ace5ff0f07c0292c456702d552ef39b","original_commit_id":"9cd461642ace5ff0f07c0292c456702d552ef39b","user":{"login":"mjeanroy","id":1067361,"avatar_url":"https://avatars.githubusercontent.com/u/1067361?v=3","gravatar_id":"","url":"https://api.github.com/users/mjeanroy","html_url":"https://github.com/mjeanroy","followers_url":"https://api.github.com/users/mjeanroy/followers","following_url":"https://api.github.com/users/mjeanroy/following{/other_user}","gists_url":"https://api.github.com/users/mjeanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mjeanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjeanroy/subscriptions","organizations_url":"https://api.github.com/users/mjeanroy/orgs","repos_url":"https://api.github.com/users/mjeanroy/repos","events_url":"https://api.github.com/users/mjeanroy/events{/privacy}","received_events_url":"https://api.github.com/users/mjeanroy/received_events","type":"User","site_admin":false},"body":"I prefer a \"size\" attribute instead of two different attributes for width and height.","created_at":"2015-04-17T12:10:17Z","updated_at":"2015-04-17T12:10:17Z","html_url":"https://github.com/mjeanroy/wafflejs/pull/19#discussion_r28588281","pull_request_url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/comments/28588281"},"html":{"href":"https://github.com/mjeanroy/wafflejs/pull/19#discussion_r28588281"},"pull_request":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19","id":31174797,"html_url":"https://github.com/mjeanroy/wafflejs/pull/19","diff_url":"https://github.com/mjeanroy/wafflejs/pull/19.diff","patch_url":"https://github.com/mjeanroy/wafflejs/pull/19.patch","issue_url":"https://api.github.com/repos/mjeanroy/wafflejs/issues/19","number":19,"state":"open","locked":false,"title":"feat(scroll): maxHeight option enables scroll","user":{"login":"Dayde","id":1503452,"avatar_url":"https://avatars.githubusercontent.com/u/1503452?v=3","gravatar_id":"","url":"https://api.github.com/users/Dayde","html_url":"https://github.com/Dayde","followers_url":"https://api.github.com/users/Dayde/followers","following_url":"https://api.github.com/users/Dayde/following{/other_user}","gists_url":"https://api.github.com/users/Dayde/gists{/gist_id}","starred_url":"https://api.github.com/users/Dayde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dayde/subscriptions","organizations_url":"https://api.github.com/users/Dayde/orgs","repos_url":"https://api.github.com/users/Dayde/repos","events_url":"https://api.github.com/users/Dayde/events{/privacy}","received_events_url":"https://api.github.com/users/Dayde/received_events","type":"User","site_admin":false},"body":"add maxHeight option in px\r\nif specified enables scroll on tbody\r\ncolumn width requires to be calculated to allow scrolling\r\n\r\nIf column width is not specified, row width is basically divided by column count.\r\nElse takes into account constrained width and apply preceding logic if column without width are remaining.\r\nHandle scrollbar width if enabled.","created_at":"2015-03-14T00:40:18Z","updated_at":"2015-04-17T12:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a9e614be5f61a4b3236cace8a332ba05e373cac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjeanroy/wafflejs/issues/19/comments","statuses_url":"https://api.github.com/repos/mjeanroy/wafflejs/statuses/9cd461642ace5ff0f07c0292c456702d552ef39b","head":{"label":"Dayde:scroll","ref":"scroll","sha":"9cd461642ace5ff0f07c0292c456702d552ef39b","user":{"login":"Dayde","id":1503452,"avatar_url":"https://avatars.githubusercontent.com/u/1503452?v=3","gravatar_id":"","url":"https://api.github.com/users/Dayde","html_url":"https://github.com/Dayde","followers_url":"https://api.github.com/users/Dayde/followers","following_url":"https://api.github.com/users/Dayde/following{/other_user}","gists_url":"https://api.github.com/users/Dayde/gists{/gist_id}","starred_url":"https://api.github.com/users/Dayde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dayde/subscriptions","organizations_url":"https://api.github.com/users/Dayde/orgs","repos_url":"https://api.github.com/users/Dayde/repos","events_url":"https://api.github.com/users/Dayde/events{/privacy}","received_events_url":"https://api.github.com/users/Dayde/received_events","type":"User","site_admin":false},"repo":{"id":30243275,"name":"wafflejs","full_name":"Dayde/wafflejs","owner":{"login":"Dayde","id":1503452,"avatar_url":"https://avatars.githubusercontent.com/u/1503452?v=3","gravatar_id":"","url":"https://api.github.com/users/Dayde","html_url":"https://github.com/Dayde","followers_url":"https://api.github.com/users/Dayde/followers","following_url":"https://api.github.com/users/Dayde/following{/other_user}","gists_url":"https://api.github.com/users/Dayde/gists{/gist_id}","starred_url":"https://api.github.com/users/Dayde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dayde/subscriptions","organizations_url":"https://api.github.com/users/Dayde/orgs","repos_url":"https://api.github.com/users/Dayde/repos","events_url":"https://api.github.com/users/Dayde/events{/privacy}","received_events_url":"https://api.github.com/users/Dayde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dayde/wafflejs","description":"","fork":true,"url":"https://api.github.com/repos/Dayde/wafflejs","forks_url":"https://api.github.com/repos/Dayde/wafflejs/forks","keys_url":"https://api.github.com/repos/Dayde/wafflejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dayde/wafflejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dayde/wafflejs/teams","hooks_url":"https://api.github.com/repos/Dayde/wafflejs/hooks","issue_events_url":"https://api.github.com/repos/Dayde/wafflejs/issues/events{/number}","events_url":"https://api.github.com/repos/Dayde/wafflejs/events","assignees_url":"https://api.github.com/repos/Dayde/wafflejs/assignees{/user}","branches_url":"https://api.github.com/repos/Dayde/wafflejs/branches{/branch}","tags_url":"https://api.github.com/repos/Dayde/wafflejs/tags","blobs_url":"https://api.github.com/repos/Dayde/wafflejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dayde/wafflejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dayde/wafflejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dayde/wafflejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dayde/wafflejs/statuses/{sha}","languages_url":"https://api.github.com/repos/Dayde/wafflejs/languages","stargazers_url":"https://api.github.com/repos/Dayde/wafflejs/stargazers","contributors_url":"https://api.github.com/repos/Dayde/wafflejs/contributors","subscribers_url":"https://api.github.com/repos/Dayde/wafflejs/subscribers","subscription_url":"https://api.github.com/repos/Dayde/wafflejs/subscription","commits_url":"https://api.github.com/repos/Dayde/wafflejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dayde/wafflejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dayde/wafflejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dayde/wafflejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dayde/wafflejs/contents/{+path}","compare_url":"https://api.github.com/repos/Dayde/wafflejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dayde/wafflejs/merges","archive_url":"https://api.github.com/repos/Dayde/wafflejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dayde/wafflejs/downloads","issues_url":"https://api.github.com/repos/Dayde/wafflejs/issues{/number}","pulls_url":"https://api.github.com/repos/Dayde/wafflejs/pulls{/number}","milestones_url":"https://api.github.com/repos/Dayde/wafflejs/milestones{/number}","notifications_url":"https://api.github.com/repos/Dayde/wafflejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dayde/wafflejs/labels{/name}","releases_url":"https://api.github.com/repos/Dayde/wafflejs/releases{/id}","created_at":"2015-02-03T13:12:33Z","updated_at":"2015-03-18T20:06:05Z","pushed_at":"2015-03-18T20:06:04Z","git_url":"git://github.com/Dayde/wafflejs.git","ssh_url":"git@github.com:Dayde/wafflejs.git","clone_url":"https://github.com/Dayde/wafflejs.git","svn_url":"https://github.com/Dayde/wafflejs","homepage":null,"size":519,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjeanroy:master","ref":"master","sha":"fd5fe9434b2e8e05ea93b19d3ccc558ee15bae91","user":{"login":"mjeanroy","id":1067361,"avatar_url":"https://avatars.githubusercontent.com/u/1067361?v=3","gravatar_id":"","url":"https://api.github.com/users/mjeanroy","html_url":"https://github.com/mjeanroy","followers_url":"https://api.github.com/users/mjeanroy/followers","following_url":"https://api.github.com/users/mjeanroy/following{/other_user}","gists_url":"https://api.github.com/users/mjeanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mjeanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjeanroy/subscriptions","organizations_url":"https://api.github.com/users/mjeanroy/orgs","repos_url":"https://api.github.com/users/mjeanroy/repos","events_url":"https://api.github.com/users/mjeanroy/events{/privacy}","received_events_url":"https://api.github.com/users/mjeanroy/received_events","type":"User","site_admin":false},"repo":{"id":30241635,"name":"wafflejs","full_name":"mjeanroy/wafflejs","owner":{"login":"mjeanroy","id":1067361,"avatar_url":"https://avatars.githubusercontent.com/u/1067361?v=3","gravatar_id":"","url":"https://api.github.com/users/mjeanroy","html_url":"https://github.com/mjeanroy","followers_url":"https://api.github.com/users/mjeanroy/followers","following_url":"https://api.github.com/users/mjeanroy/following{/other_user}","gists_url":"https://api.github.com/users/mjeanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mjeanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjeanroy/subscriptions","organizations_url":"https://api.github.com/users/mjeanroy/orgs","repos_url":"https://api.github.com/users/mjeanroy/repos","events_url":"https://api.github.com/users/mjeanroy/events{/privacy}","received_events_url":"https://api.github.com/users/mjeanroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjeanroy/wafflejs","description":"","fork":false,"url":"https://api.github.com/repos/mjeanroy/wafflejs","forks_url":"https://api.github.com/repos/mjeanroy/wafflejs/forks","keys_url":"https://api.github.com/repos/mjeanroy/wafflejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjeanroy/wafflejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjeanroy/wafflejs/teams","hooks_url":"https://api.github.com/repos/mjeanroy/wafflejs/hooks","issue_events_url":"https://api.github.com/repos/mjeanroy/wafflejs/issues/events{/number}","events_url":"https://api.github.com/repos/mjeanroy/wafflejs/events","assignees_url":"https://api.github.com/repos/mjeanroy/wafflejs/assignees{/user}","branches_url":"https://api.github.com/repos/mjeanroy/wafflejs/branches{/branch}","tags_url":"https://api.github.com/repos/mjeanroy/wafflejs/tags","blobs_url":"https://api.github.com/repos/mjeanroy/wafflejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjeanroy/wafflejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjeanroy/wafflejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjeanroy/wafflejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjeanroy/wafflejs/statuses/{sha}","languages_url":"https://api.github.com/repos/mjeanroy/wafflejs/languages","stargazers_url":"https://api.github.com/repos/mjeanroy/wafflejs/stargazers","contributors_url":"https://api.github.com/repos/mjeanroy/wafflejs/contributors","subscribers_url":"https://api.github.com/repos/mjeanroy/wafflejs/subscribers","subscription_url":"https://api.github.com/repos/mjeanroy/wafflejs/subscription","commits_url":"https://api.github.com/repos/mjeanroy/wafflejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjeanroy/wafflejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjeanroy/wafflejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjeanroy/wafflejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjeanroy/wafflejs/contents/{+path}","compare_url":"https://api.github.com/repos/mjeanroy/wafflejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjeanroy/wafflejs/merges","archive_url":"https://api.github.com/repos/mjeanroy/wafflejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjeanroy/wafflejs/downloads","issues_url":"https://api.github.com/repos/mjeanroy/wafflejs/issues{/number}","pulls_url":"https://api.github.com/repos/mjeanroy/wafflejs/pulls{/number}","milestones_url":"https://api.github.com/repos/mjeanroy/wafflejs/milestones{/number}","notifications_url":"https://api.github.com/repos/mjeanroy/wafflejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjeanroy/wafflejs/labels{/name}","releases_url":"https://api.github.com/repos/mjeanroy/wafflejs/releases{/id}","created_at":"2015-02-03T12:30:17Z","updated_at":"2015-04-15T21:17:52Z","pushed_at":"2015-03-24T07:28:04Z","git_url":"git://github.com/mjeanroy/wafflejs.git","ssh_url":"git@github.com:mjeanroy/wafflejs.git","clone_url":"https://github.com/mjeanroy/wafflejs.git","svn_url":"https://github.com/mjeanroy/wafflejs","homepage":null,"size":758,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19"},"html":{"href":"https://github.com/mjeanroy/wafflejs/pull/19"},"issue":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/issues/19"},"comments":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mjeanroy/wafflejs/statuses/9cd461642ace5ff0f07c0292c456702d552ef39b"}}}}