{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/33912017","id":33912017,"diff_hunk":"@@ -519,6 +519,17 @@ void UserDefault::flush()\n {\n }\n \n+bool UserDefault::deleteValueForKey(const char* key)\n+{\n+    // check the params\n+    if (!key)","path":"cocos/base/CCUserDefault-android.cpp","position":7,"original_position":7,"commit_id":"7d56617cc6082bd712f6e9156d4604f00381c947","original_commit_id":"7d56617cc6082bd712f6e9156d4604f00381c947","user":{"login":"andyque","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/andyque","html_url":"https://github.com/andyque","followers_url":"https://api.github.com/users/andyque/followers","following_url":"https://api.github.com/users/andyque/following{/other_user}","gists_url":"https://api.github.com/users/andyque/gists{/gist_id}","starred_url":"https://api.github.com/users/andyque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyque/subscriptions","organizations_url":"https://api.github.com/users/andyque/orgs","repos_url":"https://api.github.com/users/andyque/repos","events_url":"https://api.github.com/users/andyque/events{/privacy}","received_events_url":"https://api.github.com/users/andyque/received_events","type":"User","site_admin":false},"body":"It's better to output some debug info to tell why it fails.\r\nLike `CCLOG(\"key can't be nullptr!\")`.","created_at":"2015-07-06T07:51:42Z","updated_at":"2015-07-06T07:51:42Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/12643#discussion_r33912017","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/33912017"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/12643#discussion_r33912017"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643","id":39052729,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/12643","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/12643.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/12643.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12643","number":12643,"state":"open","locked":false,"title":"Add userdefaut UserDefault::deleteValueForKey","user":{"login":"jianglong0156","id":3940568,"avatar_url":"https://avatars.githubusercontent.com/u/3940568?v=3","gravatar_id":"","url":"https://api.github.com/users/jianglong0156","html_url":"https://github.com/jianglong0156","followers_url":"https://api.github.com/users/jianglong0156/followers","following_url":"https://api.github.com/users/jianglong0156/following{/other_user}","gists_url":"https://api.github.com/users/jianglong0156/gists{/gist_id}","starred_url":"https://api.github.com/users/jianglong0156/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianglong0156/subscriptions","organizations_url":"https://api.github.com/users/jianglong0156/orgs","repos_url":"https://api.github.com/users/jianglong0156/repos","events_url":"https://api.github.com/users/jianglong0156/events{/privacy}","received_events_url":"https://api.github.com/users/jianglong0156/received_events","type":"User","site_admin":false},"body":"Add userdefaut UserDefault::deleteValueForKey\r\n\r\nalready test in android, win32, ios, mac, winrt","created_at":"2015-07-02T06:49:26Z","updated_at":"2015-07-06T07:51:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a98bff35a61090788c157e8b4710275622e42735","assignee":{"login":"andyque","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/andyque","html_url":"https://github.com/andyque","followers_url":"https://api.github.com/users/andyque/followers","following_url":"https://api.github.com/users/andyque/following{/other_user}","gists_url":"https://api.github.com/users/andyque/gists{/gist_id}","starred_url":"https://api.github.com/users/andyque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyque/subscriptions","organizations_url":"https://api.github.com/users/andyque/orgs","repos_url":"https://api.github.com/users/andyque/repos","events_url":"https://api.github.com/users/andyque/events{/privacy}","received_events_url":"https://api.github.com/users/andyque/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12643/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/7d56617cc6082bd712f6e9156d4604f00381c947","head":{"label":"jianglong0156:addUserDefautRemove","ref":"addUserDefautRemove","sha":"7d56617cc6082bd712f6e9156d4604f00381c947","user":{"login":"jianglong0156","id":3940568,"avatar_url":"https://avatars.githubusercontent.com/u/3940568?v=3","gravatar_id":"","url":"https://api.github.com/users/jianglong0156","html_url":"https://github.com/jianglong0156","followers_url":"https://api.github.com/users/jianglong0156/followers","following_url":"https://api.github.com/users/jianglong0156/following{/other_user}","gists_url":"https://api.github.com/users/jianglong0156/gists{/gist_id}","starred_url":"https://api.github.com/users/jianglong0156/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianglong0156/subscriptions","organizations_url":"https://api.github.com/users/jianglong0156/orgs","repos_url":"https://api.github.com/users/jianglong0156/repos","events_url":"https://api.github.com/users/jianglong0156/events{/privacy}","received_events_url":"https://api.github.com/users/jianglong0156/received_events","type":"User","site_admin":false},"repo":{"id":24360166,"name":"cocos2d-x","full_name":"jianglong0156/cocos2d-x","owner":{"login":"jianglong0156","id":3940568,"avatar_url":"https://avatars.githubusercontent.com/u/3940568?v=3","gravatar_id":"","url":"https://api.github.com/users/jianglong0156","html_url":"https://github.com/jianglong0156","followers_url":"https://api.github.com/users/jianglong0156/followers","following_url":"https://api.github.com/users/jianglong0156/following{/other_user}","gists_url":"https://api.github.com/users/jianglong0156/gists{/gist_id}","starred_url":"https://api.github.com/users/jianglong0156/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianglong0156/subscriptions","organizations_url":"https://api.github.com/users/jianglong0156/orgs","repos_url":"https://api.github.com/users/jianglong0156/repos","events_url":"https://api.github.com/users/jianglong0156/events{/privacy}","received_events_url":"https://api.github.com/users/jianglong0156/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jianglong0156/cocos2d-x","description":"cocos2d for iOS, Android, Win32 and OS X. Built using C++","fork":true,"url":"https://api.github.com/repos/jianglong0156/cocos2d-x","forks_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/forks","keys_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/events","assignees_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/merges","archive_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/jianglong0156/cocos2d-x/releases{/id}","created_at":"2014-09-23T06:53:35Z","updated_at":"2015-05-06T02:11:39Z","pushed_at":"2015-07-06T07:39:37Z","git_url":"git://github.com/jianglong0156/cocos2d-x.git","ssh_url":"git@github.com:jianglong0156/cocos2d-x.git","clone_url":"https://github.com/jianglong0156/cocos2d-x.git","svn_url":"https://github.com/jianglong0156/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1044976,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"2d-xv3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"d155d42c0ec8efab2fb7a70c1a4fca6b36bb57eb","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-07-06T06:44:32Z","pushed_at":"2015-07-06T07:42:19Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1509435,"stargazers_count":6173,"watchers_count":6173,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4427,"mirror_url":null,"open_issues_count":745,"forks":4427,"open_issues":745,"watchers":6173,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/12643"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12643"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12643/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12643/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/7d56617cc6082bd712f6e9156d4604f00381c947"}}}}