{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/48623907","id":48623907,"diff_hunk":"@@ -14,12 +14,15 @@ <h3 us-spinner=\"{radius:30, width:8, length: 16}\"></h3>\n           <input type=\"text\"\n                  autofocus\n                  name=\"name\"\n-                 ng-pattern=\"/^[a-zA-z_0-9.]*$/\"\n                  class=\"form-control input-sm\"\n                  data-purpose=\"application-name\"\n                  ng-model=\"newAppModal.application.name\"\n                  placeholder=\"Enter an application name\"\n                  validate-unique=\"newAppModal.data.appNameList\"\n+                 ng-pattern=\"/^[a-zA-z_0-9.]*$/\"","path":"app/scripts/modules/netflix/application/createApplication.modal.html","position":10,"original_position":10,"commit_id":"34b4d32db1365bc68e2061ede3aa874df62a02e3","original_commit_id":"34b4d32db1365bc68e2061ede3aa874df62a02e3","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Same comment here.","created_at":"2015-12-30T19:05:05Z","updated_at":"2015-12-30T19:05:05Z","html_url":"https://github.com/spinnaker/deck/pull/1830#discussion_r48623907","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/1830","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/48623907"},"html":{"href":"https://github.com/spinnaker/deck/pull/1830#discussion_r48623907"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1830"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/1830","id":54697108,"html_url":"https://github.com/spinnaker/deck/pull/1830","diff_url":"https://github.com/spinnaker/deck/pull/1830.diff","patch_url":"https://github.com/spinnaker/deck/pull/1830.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/1830","number":1830,"state":"open","locked":false,"title":"implement provider-specific validation mechanism for application name","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"Provides a mechanism for any provider to specify warning and error conditions for application names.\r\n\r\nFor example: due to AWS's kinda severe restrictions on load balancer names, we warn users about very long names. That should not be a concern for users who are not using AWS.\r\n\r\nI've left the character restrictions in place (`ng-pattern` - alphanumeric + dot + underscore) because we use the application name everywhere and don't want to have to URL-encode the names of components.\r\n\r\n@zanthrash @duftler please review when you have time","created_at":"2015-12-29T01:50:35Z","updated_at":"2015-12-30T19:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51448335cd20360d5b9450c7e360de48e90c9f54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/1830/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/1830/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/1830/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/34b4d32db1365bc68e2061ede3aa874df62a02e3","head":{"label":"anotherchrisberry:validate-app-name","ref":"validate-app-name","sha":"34b4d32db1365bc68e2061ede3aa874df62a02e3","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"repo":{"id":46325253,"name":"deck","full_name":"anotherchrisberry/deck","owner":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anotherchrisberry/deck","description":"New and improved management UI","fork":true,"url":"https://api.github.com/repos/anotherchrisberry/deck","forks_url":"https://api.github.com/repos/anotherchrisberry/deck/forks","keys_url":"https://api.github.com/repos/anotherchrisberry/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anotherchrisberry/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anotherchrisberry/deck/teams","hooks_url":"https://api.github.com/repos/anotherchrisberry/deck/hooks","issue_events_url":"https://api.github.com/repos/anotherchrisberry/deck/issues/events{/number}","events_url":"https://api.github.com/repos/anotherchrisberry/deck/events","assignees_url":"https://api.github.com/repos/anotherchrisberry/deck/assignees{/user}","branches_url":"https://api.github.com/repos/anotherchrisberry/deck/branches{/branch}","tags_url":"https://api.github.com/repos/anotherchrisberry/deck/tags","blobs_url":"https://api.github.com/repos/anotherchrisberry/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anotherchrisberry/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anotherchrisberry/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/anotherchrisberry/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anotherchrisberry/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/anotherchrisberry/deck/languages","stargazers_url":"https://api.github.com/repos/anotherchrisberry/deck/stargazers","contributors_url":"https://api.github.com/repos/anotherchrisberry/deck/contributors","subscribers_url":"https://api.github.com/repos/anotherchrisberry/deck/subscribers","subscription_url":"https://api.github.com/repos/anotherchrisberry/deck/subscription","commits_url":"https://api.github.com/repos/anotherchrisberry/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/anotherchrisberry/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/anotherchrisberry/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/anotherchrisberry/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/anotherchrisberry/deck/contents/{+path}","compare_url":"https://api.github.com/repos/anotherchrisberry/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anotherchrisberry/deck/merges","archive_url":"https://api.github.com/repos/anotherchrisberry/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anotherchrisberry/deck/downloads","issues_url":"https://api.github.com/repos/anotherchrisberry/deck/issues{/number}","pulls_url":"https://api.github.com/repos/anotherchrisberry/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/anotherchrisberry/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/anotherchrisberry/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anotherchrisberry/deck/labels{/name}","releases_url":"https://api.github.com/repos/anotherchrisberry/deck/releases{/id}","created_at":"2015-11-17T05:27:30Z","updated_at":"2015-11-17T05:27:35Z","pushed_at":"2015-12-29T23:19:38Z","git_url":"git://github.com/anotherchrisberry/deck.git","ssh_url":"git@github.com:anotherchrisberry/deck.git","clone_url":"https://github.com/anotherchrisberry/deck.git","svn_url":"https://github.com/anotherchrisberry/deck","homepage":null,"size":21296,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"7a1084dab14adef861444ac90ce8b34087075e90","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","created_at":"2014-07-17T18:51:00Z","updated_at":"2015-12-30T11:20:32Z","pushed_at":"2015-12-30T18:25:40Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":22434,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":5,"forks":32,"open_issues":5,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1830"},"html":{"href":"https://github.com/spinnaker/deck/pull/1830"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/1830"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/1830/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1830/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/1830/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/34b4d32db1365bc68e2061ede3aa874df62a02e3"}}}}