{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/28461048","id":28461048,"diff_hunk":"@@ -29,16 +31,39 @@ public VisualStudioWorkspaceDiagnosticAnalyzerProviderService(VisualStudioWorksp\n             // Get the analyzer assets for installed VSIX extensions through the VSIX extension manager.\n             var extensionManager = workspace.GetVsService<SVsExtensionManager, IVsExtensionManager>();\n \n-            var builder = ImmutableArray.CreateBuilder<HostDiagnosticAnalyzerPackage>();\n-            foreach (var extension in extensionManager.GetEnabledExtensions(AnalyzerContentTypeName))\n+            // get rootfolder and shellfolder location\n+            string rootFolder;\n+            string shellFolder;\n+            if (TryGetRootAndShellFolder(extensionManager, out shellFolder, out rootFolder))\n             {\n-                var name = extension.Header.LocalizedName;\n-                var assemblies = extension.Content.Where(ShouldInclude).Select(c => Path.Combine(extension.InstallPath, c.RelativePath));\n+                var builder = ImmutableArray.CreateBuilder<HostDiagnosticAnalyzerPackage>();\n+                foreach (var extension in extensionManager.GetEnabledExtensions(AnalyzerContentTypeName))\n+                {\n+                    var name = extension.Header.LocalizedName;\n+                    var assemblies = extension.Content.Where(ShouldInclude)\n+                                                      .Select(c => GetContentLocation(shellFolder, rootFolder, extension.InstallPath, c.RelativePath))\n+                                                      .WhereNotNull();\n \n-                builder.Add(new HostDiagnosticAnalyzerPackage(name, assemblies.ToImmutableArray()));\n+                    builder.Add(new HostDiagnosticAnalyzerPackage(name, assemblies.ToImmutableArray()));\n+                }\n+\n+                _hostDiagnosticAnalyzerInfo = builder.ToImmutable();\n+                return;\n+            }\n+\n+            // if we can't get package name, use old style.","path":"src/VisualStudio/Core/Def/Implementation/Diagnostics/VisualStudioWorkspaceDiagnosticAnalyzerProviderService.cs","position":41,"original_position":41,"commit_id":"cbe6b108dbb036fa31de44341de5ace36c734084","original_commit_id":"cbe6b108dbb036fa31de44341de5ace36c734084","user":{"login":"shyamnamboodiripad","id":10579684,"avatar_url":"https://avatars.githubusercontent.com/u/10579684?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamnamboodiripad","html_url":"https://github.com/shyamnamboodiripad","followers_url":"https://api.github.com/users/shyamnamboodiripad/followers","following_url":"https://api.github.com/users/shyamnamboodiripad/following{/other_user}","gists_url":"https://api.github.com/users/shyamnamboodiripad/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamnamboodiripad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamnamboodiripad/subscriptions","organizations_url":"https://api.github.com/users/shyamnamboodiripad/orgs","repos_url":"https://api.github.com/users/shyamnamboodiripad/repos","events_url":"https://api.github.com/users/shyamnamboodiripad/events{/privacy}","received_events_url":"https://api.github.com/users/shyamnamboodiripad/received_events","type":"User","site_admin":false},"body":"Should this be 'if we can't get rootFolder and shellFolder'?","created_at":"2015-04-15T20:46:31Z","updated_at":"2015-04-15T20:46:31Z","html_url":"https://github.com/dotnet/roslyn/pull/2001#discussion_r28461048","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2001","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/28461048"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2001#discussion_r28461048"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2001"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2001","id":33326383,"html_url":"https://github.com/dotnet/roslyn/pull/2001","diff_url":"https://github.com/dotnet/roslyn/pull/2001.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2001.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2001","number":2001,"state":"closed","locked":false,"title":"fixed issue where $RootFolder$ and $ShellFolder$ wasn't resolved correct...","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"body":"...ly","created_at":"2015-04-15T06:38:46Z","updated_at":"2015-04-15T20:46:31Z","closed_at":"2015-04-15T20:22:51Z","merged_at":"2015-04-15T20:22:51Z","merge_commit_sha":"b0a5067c8838304280be54e4386ce4b583f96b55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2001/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/cbe6b108dbb036fa31de44341de5ace36c734084","head":{"label":"heejaechang:extensionRootFolder","ref":"extensionRootFolder","sha":"cbe6b108dbb036fa31de44341de5ace36c734084","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"repo":{"id":30170221,"name":"roslyn","full_name":"heejaechang/roslyn","owner":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heejaechang/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/heejaechang/roslyn","forks_url":"https://api.github.com/repos/heejaechang/roslyn/forks","keys_url":"https://api.github.com/repos/heejaechang/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heejaechang/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heejaechang/roslyn/teams","hooks_url":"https://api.github.com/repos/heejaechang/roslyn/hooks","issue_events_url":"https://api.github.com/repos/heejaechang/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/heejaechang/roslyn/events","assignees_url":"https://api.github.com/repos/heejaechang/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/heejaechang/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/heejaechang/roslyn/tags","blobs_url":"https://api.github.com/repos/heejaechang/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heejaechang/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heejaechang/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/heejaechang/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heejaechang/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/heejaechang/roslyn/languages","stargazers_url":"https://api.github.com/repos/heejaechang/roslyn/stargazers","contributors_url":"https://api.github.com/repos/heejaechang/roslyn/contributors","subscribers_url":"https://api.github.com/repos/heejaechang/roslyn/subscribers","subscription_url":"https://api.github.com/repos/heejaechang/roslyn/subscription","commits_url":"https://api.github.com/repos/heejaechang/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/heejaechang/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/heejaechang/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/heejaechang/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/heejaechang/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/heejaechang/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heejaechang/roslyn/merges","archive_url":"https://api.github.com/repos/heejaechang/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heejaechang/roslyn/downloads","issues_url":"https://api.github.com/repos/heejaechang/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/heejaechang/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/heejaechang/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/heejaechang/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heejaechang/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/heejaechang/roslyn/releases{/id}","created_at":"2015-02-02T03:54:43Z","updated_at":"2015-02-10T18:06:10Z","pushed_at":"2015-04-15T19:49:57Z","git_url":"git://github.com/heejaechang/roslyn.git","ssh_url":"git@github.com:heejaechang/roslyn.git","clone_url":"https://github.com/heejaechang/roslyn.git","svn_url":"https://github.com/heejaechang/roslyn","homepage":"","size":66276,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c8e8ad3682cd04b4159abdb9197b70bb06d4e82e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-04-15T20:42:33Z","pushed_at":"2015-04-15T20:42:33Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":108961,"stargazers_count":1799,"watchers_count":1799,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":402,"mirror_url":null,"open_issues_count":709,"forks":402,"open_issues":709,"watchers":1799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2001"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2001"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2001"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/cbe6b108dbb036fa31de44341de5ace36c734084"}}}}