{"action":"created","issue":{"url":"https://api.github.com/repos/woothemes/woocommerce/issues/8356","labels_url":"https://api.github.com/repos/woothemes/woocommerce/issues/8356/labels{/name}","comments_url":"https://api.github.com/repos/woothemes/woocommerce/issues/8356/comments","events_url":"https://api.github.com/repos/woothemes/woocommerce/issues/8356/events","html_url":"https://github.com/woothemes/woocommerce/pull/8356","id":87242482,"number":8356,"title":"Improve the color picker preview visibility by moving the preview to its own element (#8355)","user":{"login":"justinshreve","id":689165,"avatar_url":"https://avatars.githubusercontent.com/u/689165?v=3","gravatar_id":"","url":"https://api.github.com/users/justinshreve","html_url":"https://github.com/justinshreve","followers_url":"https://api.github.com/users/justinshreve/followers","following_url":"https://api.github.com/users/justinshreve/following{/other_user}","gists_url":"https://api.github.com/users/justinshreve/gists{/gist_id}","starred_url":"https://api.github.com/users/justinshreve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinshreve/subscriptions","organizations_url":"https://api.github.com/users/justinshreve/orgs","repos_url":"https://api.github.com/users/justinshreve/repos","events_url":"https://api.github.com/users/justinshreve/events{/privacy}","received_events_url":"https://api.github.com/users/justinshreve/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/woothemes/woocommerce/labels/Enhancement","name":"Enhancement","color":"444444"},{"url":"https://api.github.com/repos/woothemes/woocommerce/labels/Needs%20Dev%20Feedback","name":"Needs Dev Feedback","color":"a46497"}],"state":"closed","locked":false,"assignee":{"login":"justinshreve","id":689165,"avatar_url":"https://avatars.githubusercontent.com/u/689165?v=3","gravatar_id":"","url":"https://api.github.com/users/justinshreve","html_url":"https://github.com/justinshreve","followers_url":"https://api.github.com/users/justinshreve/followers","following_url":"https://api.github.com/users/justinshreve/following{/other_user}","gists_url":"https://api.github.com/users/justinshreve/gists{/gist_id}","starred_url":"https://api.github.com/users/justinshreve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinshreve/subscriptions","organizations_url":"https://api.github.com/users/justinshreve/orgs","repos_url":"https://api.github.com/users/justinshreve/repos","events_url":"https://api.github.com/users/justinshreve/events{/privacy}","received_events_url":"https://api.github.com/users/justinshreve/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-06-11T07:24:42Z","updated_at":"2015-06-11T14:03:26Z","closed_at":"2015-06-11T09:29:59Z","pull_request":{"url":"https://api.github.com/repos/woothemes/woocommerce/pulls/8356","html_url":"https://github.com/woothemes/woocommerce/pull/8356","diff_url":"https://github.com/woothemes/woocommerce/pull/8356.diff","patch_url":"https://github.com/woothemes/woocommerce/pull/8356.patch"},"body":"Fixes #8355.\r\n\r\nThis PR goes from\r\n\r\n![Current WooCommerce color settings](https://cldup.com/ngQ8eduUh5-3000x3000.png)\r\n\r\nto\r\n\r\n![Proposed WooCommerce color settings](https://cldup.com/twR98eAHV9-3000x3000.png)\r\n\r\nMoving the preview out of the input and into its own preview box makes it easier to see and change the current hex code since the background of the input box won't be changing."},"comment":{"url":"https://api.github.com/repos/woothemes/woocommerce/issues/comments/111146310","html_url":"https://github.com/woothemes/woocommerce/pull/8356#issuecomment-111146310","issue_url":"https://api.github.com/repos/woothemes/woocommerce/issues/8356","id":111146310,"user":{"login":"shivapoudel","id":3774827,"avatar_url":"https://avatars.githubusercontent.com/u/3774827?v=3","gravatar_id":"","url":"https://api.github.com/users/shivapoudel","html_url":"https://github.com/shivapoudel","followers_url":"https://api.github.com/users/shivapoudel/followers","following_url":"https://api.github.com/users/shivapoudel/following{/other_user}","gists_url":"https://api.github.com/users/shivapoudel/gists{/gist_id}","starred_url":"https://api.github.com/users/shivapoudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivapoudel/subscriptions","organizations_url":"https://api.github.com/users/shivapoudel/orgs","repos_url":"https://api.github.com/users/shivapoudel/repos","events_url":"https://api.github.com/users/shivapoudel/events{/privacy}","received_events_url":"https://api.github.com/users/shivapoudel/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T14:03:26Z","updated_at":"2015-06-11T14:03:26Z","body":"@justinshreve I got the bug again at integration. Iris picker is different for integration. Means we need to modify this for `generate_color_html`: https://github.com/woothemes/woocommerce/blob/master/includes/abstracts/abstract-wc-settings-api.php#L463-L500\r\n\r\n@mikejolley can't there exist a single class to handle settings. There are two class one is `AC_Admin_Settings` and another is `AC_Settings_API`. IMO this need should be minified :) "}}