{"action":"created","comment":{"url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/comments/30187930","id":30187930,"diff_hunk":"@@ -13,22 +13,35 @@\n \n namespace dqn {\n \n-constexpr auto kStateDataSize = 58;\n-constexpr auto kInputCount = 2;\n-constexpr auto kInputDataSize = kStateDataSize * kInputCount;\n+constexpr auto kInputFrameCount = 2;\n constexpr auto kMinibatchSize = 32;\n-constexpr auto kMinibatchDataSize = kInputDataSize * kMinibatchSize;\n-constexpr auto kOutputCount = 9;\n \n-using StateData = std::array<float, kStateDataSize>;\n-using StateDataSp = std::shared_ptr<StateData>;\n-using InputStates = std::array<StateDataSp, kInputCount>;\n-using Transition = std::tuple<InputStates, int,\n-                              float, boost::optional<StateDataSp>>;\n+constexpr auto kActorStateDataSize = 58;\n+constexpr auto kActorInputDataSize = kActorStateDataSize * kInputFrameCount;\n+constexpr auto kActorMinibatchDataSize = kActorInputDataSize * kMinibatchSize;\n+constexpr auto kActorOutputCount = 1;\n \n-using StateLayerInputData = std::array<float, kMinibatchDataSize>;\n-using TargetLayerInputData = std::array<float, kMinibatchSize * kOutputCount>;\n-using FilterLayerInputData = std::array<float, kMinibatchSize * kOutputCount>;\n+using ActorStateData = std::array<float, kActorStateDataSize>;\n+using ActorStateDataSp = std::shared_ptr<ActorStateData>;\n+using ActorInputStates = std::array<ActorStateDataSp, kInputFrameCount>;\n+using Transition = std::tuple<ActorInputStates, int,\n+                              float, boost::optional<ActorStateDataSp>>;\n+\n+using StateLayerInputData = std::array<float, kActorMinibatchDataSize>;\n+using TargetLayerInputData = std::array<float, kMinibatchSize * kActorOutputCount>;\n+using FilterLayerInputData = std::array<float, kMinibatchSize * kActorOutputCount>;\n+\n+constexpr auto kCriticStateDataSize = kActorStateDataSize + 1;","path":"dqn.hpp","position":35,"original_position":35,"commit_id":"a0fa94f1d993b584156e5d8e5c0c553246ae17b8","original_commit_id":"a0fa94f1d993b584156e5d8e5c0c553246ae17b8","user":{"login":"mhauskn","id":19769,"avatar_url":"https://avatars.githubusercontent.com/u/19769?v=3","gravatar_id":"","url":"https://api.github.com/users/mhauskn","html_url":"https://github.com/mhauskn","followers_url":"https://api.github.com/users/mhauskn/followers","following_url":"https://api.github.com/users/mhauskn/following{/other_user}","gists_url":"https://api.github.com/users/mhauskn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhauskn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhauskn/subscriptions","organizations_url":"https://api.github.com/users/mhauskn/orgs","repos_url":"https://api.github.com/users/mhauskn/repos","events_url":"https://api.github.com/users/mhauskn/events{/privacy}","received_events_url":"https://api.github.com/users/mhauskn/received_events","type":"User","site_admin":false},"body":"Should be + kActorOutputCount;","created_at":"2015-05-12T22:35:51Z","updated_at":"2015-05-12T22:35:51Z","html_url":"https://github.com/mhauskn/dqn-hfo/pull/5#discussion_r30187930","pull_request_url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/comments/30187930"},"html":{"href":"https://github.com/mhauskn/dqn-hfo/pull/5#discussion_r30187930"},"pull_request":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5","id":35276504,"html_url":"https://github.com/mhauskn/dqn-hfo/pull/5","diff_url":"https://github.com/mhauskn/dqn-hfo/pull/5.diff","patch_url":"https://github.com/mhauskn/dqn-hfo/pull/5.patch","issue_url":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/5","number":5,"state":"open","locked":false,"title":"halfway in loading actor+critic networks","user":{"login":"chasewind007","id":8969578,"avatar_url":"https://avatars.githubusercontent.com/u/8969578?v=3","gravatar_id":"","url":"https://api.github.com/users/chasewind007","html_url":"https://github.com/chasewind007","followers_url":"https://api.github.com/users/chasewind007/followers","following_url":"https://api.github.com/users/chasewind007/following{/other_user}","gists_url":"https://api.github.com/users/chasewind007/gists{/gist_id}","starred_url":"https://api.github.com/users/chasewind007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasewind007/subscriptions","organizations_url":"https://api.github.com/users/chasewind007/orgs","repos_url":"https://api.github.com/users/chasewind007/repos","events_url":"https://api.github.com/users/chasewind007/events{/privacy}","received_events_url":"https://api.github.com/users/chasewind007/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-12T22:13:38Z","updated_at":"2015-05-12T22:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67ced72be3bf91276f8a166b9af6f59c4ca05b78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/5/comments","statuses_url":"https://api.github.com/repos/mhauskn/dqn-hfo/statuses/a0fa94f1d993b584156e5d8e5c0c553246ae17b8","head":{"label":"chasewind007:master","ref":"master","sha":"a0fa94f1d993b584156e5d8e5c0c553246ae17b8","user":{"login":"chasewind007","id":8969578,"avatar_url":"https://avatars.githubusercontent.com/u/8969578?v=3","gravatar_id":"","url":"https://api.github.com/users/chasewind007","html_url":"https://github.com/chasewind007","followers_url":"https://api.github.com/users/chasewind007/followers","following_url":"https://api.github.com/users/chasewind007/following{/other_user}","gists_url":"https://api.github.com/users/chasewind007/gists{/gist_id}","starred_url":"https://api.github.com/users/chasewind007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasewind007/subscriptions","organizations_url":"https://api.github.com/users/chasewind007/orgs","repos_url":"https://api.github.com/users/chasewind007/repos","events_url":"https://api.github.com/users/chasewind007/events{/privacy}","received_events_url":"https://api.github.com/users/chasewind007/received_events","type":"User","site_admin":false},"repo":{"id":34463776,"name":"dqn-hfo","full_name":"chasewind007/dqn-hfo","owner":{"login":"chasewind007","id":8969578,"avatar_url":"https://avatars.githubusercontent.com/u/8969578?v=3","gravatar_id":"","url":"https://api.github.com/users/chasewind007","html_url":"https://github.com/chasewind007","followers_url":"https://api.github.com/users/chasewind007/followers","following_url":"https://api.github.com/users/chasewind007/following{/other_user}","gists_url":"https://api.github.com/users/chasewind007/gists{/gist_id}","starred_url":"https://api.github.com/users/chasewind007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasewind007/subscriptions","organizations_url":"https://api.github.com/users/chasewind007/orgs","repos_url":"https://api.github.com/users/chasewind007/repos","events_url":"https://api.github.com/users/chasewind007/events{/privacy}","received_events_url":"https://api.github.com/users/chasewind007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chasewind007/dqn-hfo","description":"","fork":true,"url":"https://api.github.com/repos/chasewind007/dqn-hfo","forks_url":"https://api.github.com/repos/chasewind007/dqn-hfo/forks","keys_url":"https://api.github.com/repos/chasewind007/dqn-hfo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chasewind007/dqn-hfo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chasewind007/dqn-hfo/teams","hooks_url":"https://api.github.com/repos/chasewind007/dqn-hfo/hooks","issue_events_url":"https://api.github.com/repos/chasewind007/dqn-hfo/issues/events{/number}","events_url":"https://api.github.com/repos/chasewind007/dqn-hfo/events","assignees_url":"https://api.github.com/repos/chasewind007/dqn-hfo/assignees{/user}","branches_url":"https://api.github.com/repos/chasewind007/dqn-hfo/branches{/branch}","tags_url":"https://api.github.com/repos/chasewind007/dqn-hfo/tags","blobs_url":"https://api.github.com/repos/chasewind007/dqn-hfo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chasewind007/dqn-hfo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chasewind007/dqn-hfo/git/refs{/sha}","trees_url":"https://api.github.com/repos/chasewind007/dqn-hfo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chasewind007/dqn-hfo/statuses/{sha}","languages_url":"https://api.github.com/repos/chasewind007/dqn-hfo/languages","stargazers_url":"https://api.github.com/repos/chasewind007/dqn-hfo/stargazers","contributors_url":"https://api.github.com/repos/chasewind007/dqn-hfo/contributors","subscribers_url":"https://api.github.com/repos/chasewind007/dqn-hfo/subscribers","subscription_url":"https://api.github.com/repos/chasewind007/dqn-hfo/subscription","commits_url":"https://api.github.com/repos/chasewind007/dqn-hfo/commits{/sha}","git_commits_url":"https://api.github.com/repos/chasewind007/dqn-hfo/git/commits{/sha}","comments_url":"https://api.github.com/repos/chasewind007/dqn-hfo/comments{/number}","issue_comment_url":"https://api.github.com/repos/chasewind007/dqn-hfo/issues/comments{/number}","contents_url":"https://api.github.com/repos/chasewind007/dqn-hfo/contents/{+path}","compare_url":"https://api.github.com/repos/chasewind007/dqn-hfo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chasewind007/dqn-hfo/merges","archive_url":"https://api.github.com/repos/chasewind007/dqn-hfo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chasewind007/dqn-hfo/downloads","issues_url":"https://api.github.com/repos/chasewind007/dqn-hfo/issues{/number}","pulls_url":"https://api.github.com/repos/chasewind007/dqn-hfo/pulls{/number}","milestones_url":"https://api.github.com/repos/chasewind007/dqn-hfo/milestones{/number}","notifications_url":"https://api.github.com/repos/chasewind007/dqn-hfo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chasewind007/dqn-hfo/labels{/name}","releases_url":"https://api.github.com/repos/chasewind007/dqn-hfo/releases{/id}","created_at":"2015-04-23T15:11:38Z","updated_at":"2015-05-08T20:00:18Z","pushed_at":"2015-05-12T22:13:12Z","git_url":"git://github.com/chasewind007/dqn-hfo.git","ssh_url":"git@github.com:chasewind007/dqn-hfo.git","clone_url":"https://github.com/chasewind007/dqn-hfo.git","svn_url":"https://github.com/chasewind007/dqn-hfo","homepage":"","size":136,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mhauskn:master","ref":"master","sha":"9123afcbed01e741e3ef74f50a1fc0856b288a29","user":{"login":"mhauskn","id":19769,"avatar_url":"https://avatars.githubusercontent.com/u/19769?v=3","gravatar_id":"","url":"https://api.github.com/users/mhauskn","html_url":"https://github.com/mhauskn","followers_url":"https://api.github.com/users/mhauskn/followers","following_url":"https://api.github.com/users/mhauskn/following{/other_user}","gists_url":"https://api.github.com/users/mhauskn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhauskn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhauskn/subscriptions","organizations_url":"https://api.github.com/users/mhauskn/orgs","repos_url":"https://api.github.com/users/mhauskn/repos","events_url":"https://api.github.com/users/mhauskn/events{/privacy}","received_events_url":"https://api.github.com/users/mhauskn/received_events","type":"User","site_admin":false},"repo":{"id":34285851,"name":"dqn-hfo","full_name":"mhauskn/dqn-hfo","owner":{"login":"mhauskn","id":19769,"avatar_url":"https://avatars.githubusercontent.com/u/19769?v=3","gravatar_id":"","url":"https://api.github.com/users/mhauskn","html_url":"https://github.com/mhauskn","followers_url":"https://api.github.com/users/mhauskn/followers","following_url":"https://api.github.com/users/mhauskn/following{/other_user}","gists_url":"https://api.github.com/users/mhauskn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhauskn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhauskn/subscriptions","organizations_url":"https://api.github.com/users/mhauskn/orgs","repos_url":"https://api.github.com/users/mhauskn/repos","events_url":"https://api.github.com/users/mhauskn/events{/privacy}","received_events_url":"https://api.github.com/users/mhauskn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhauskn/dqn-hfo","description":"","fork":false,"url":"https://api.github.com/repos/mhauskn/dqn-hfo","forks_url":"https://api.github.com/repos/mhauskn/dqn-hfo/forks","keys_url":"https://api.github.com/repos/mhauskn/dqn-hfo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhauskn/dqn-hfo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhauskn/dqn-hfo/teams","hooks_url":"https://api.github.com/repos/mhauskn/dqn-hfo/hooks","issue_events_url":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/events{/number}","events_url":"https://api.github.com/repos/mhauskn/dqn-hfo/events","assignees_url":"https://api.github.com/repos/mhauskn/dqn-hfo/assignees{/user}","branches_url":"https://api.github.com/repos/mhauskn/dqn-hfo/branches{/branch}","tags_url":"https://api.github.com/repos/mhauskn/dqn-hfo/tags","blobs_url":"https://api.github.com/repos/mhauskn/dqn-hfo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhauskn/dqn-hfo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhauskn/dqn-hfo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhauskn/dqn-hfo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhauskn/dqn-hfo/statuses/{sha}","languages_url":"https://api.github.com/repos/mhauskn/dqn-hfo/languages","stargazers_url":"https://api.github.com/repos/mhauskn/dqn-hfo/stargazers","contributors_url":"https://api.github.com/repos/mhauskn/dqn-hfo/contributors","subscribers_url":"https://api.github.com/repos/mhauskn/dqn-hfo/subscribers","subscription_url":"https://api.github.com/repos/mhauskn/dqn-hfo/subscription","commits_url":"https://api.github.com/repos/mhauskn/dqn-hfo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhauskn/dqn-hfo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhauskn/dqn-hfo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhauskn/dqn-hfo/contents/{+path}","compare_url":"https://api.github.com/repos/mhauskn/dqn-hfo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhauskn/dqn-hfo/merges","archive_url":"https://api.github.com/repos/mhauskn/dqn-hfo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhauskn/dqn-hfo/downloads","issues_url":"https://api.github.com/repos/mhauskn/dqn-hfo/issues{/number}","pulls_url":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls{/number}","milestones_url":"https://api.github.com/repos/mhauskn/dqn-hfo/milestones{/number}","notifications_url":"https://api.github.com/repos/mhauskn/dqn-hfo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhauskn/dqn-hfo/labels{/name}","releases_url":"https://api.github.com/repos/mhauskn/dqn-hfo/releases{/id}","created_at":"2015-04-20T20:53:10Z","updated_at":"2015-05-06T16:29:13Z","pushed_at":"2015-05-12T22:13:39Z","git_url":"git://github.com/mhauskn/dqn-hfo.git","ssh_url":"git@github.com:mhauskn/dqn-hfo.git","clone_url":"https://github.com/mhauskn/dqn-hfo.git","svn_url":"https://github.com/mhauskn/dqn-hfo","homepage":null,"size":198,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5"},"html":{"href":"https://github.com/mhauskn/dqn-hfo/pull/5"},"issue":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/5"},"comments":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mhauskn/dqn-hfo/statuses/a0fa94f1d993b584156e5d8e5c0c553246ae17b8"}}}}