{"action":"created","comment":{"url":"https://api.github.com/repos/openregister/presentation/pulls/comments/40108214","id":40108214,"diff_hunk":"@@ -4,13 +4,15 @@\n import javax.ws.rs.BadRequestException;\n import java.util.Optional;\n \n-class Pagination {\n+public class Pagination {\n \n     private final long pageIndex;\n+    private final String resourcePath;\n     private final long totalEntries;\n     private final long pageSize;\n \n-    Pagination(Optional<Long> pageIndex, Optional<Long> pageSize, long totalEntries) {\n+    Pagination(String resourcePath, Optional<Long> pageIndex, Optional<Long> pageSize, long totalEntries) {","path":"src/main/java/uk/gov/register/presentation/resource/Pagination.java","position":13,"original_position":13,"commit_id":"f222faa152003b34825827ee2226916314798908","original_commit_id":"baf06ed3f3daf0fac484d65fe86d2c4a9bf68d4f","user":{"login":"philandstuff","id":581269,"avatar_url":"https://avatars.githubusercontent.com/u/581269?v=3","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"body":"discussed IRL. we have a strategy to use fast, exact queries so we don't need to estimate after all","created_at":"2015-09-22T16:26:24Z","updated_at":"2015-09-22T16:26:24Z","html_url":"https://github.com/openregister/presentation/pull/77#discussion_r40108214","pull_request_url":"https://api.github.com/repos/openregister/presentation/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/openregister/presentation/pulls/comments/40108214"},"html":{"href":"https://github.com/openregister/presentation/pull/77#discussion_r40108214"},"pull_request":{"href":"https://api.github.com/repos/openregister/presentation/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/openregister/presentation/pulls/77","id":45538381,"html_url":"https://github.com/openregister/presentation/pull/77","diff_url":"https://github.com/openregister/presentation/pull/77.diff","patch_url":"https://github.com/openregister/presentation/pull/77.patch","issue_url":"https://api.github.com/repos/openregister/presentation/issues/77","number":77,"state":"open","locked":false,"title":"Extracted next and previous page link in Pagination class.","user":{"login":"om-sharma","id":8011952,"avatar_url":"https://avatars.githubusercontent.com/u/8011952?v=3","gravatar_id":"","url":"https://api.github.com/users/om-sharma","html_url":"https://github.com/om-sharma","followers_url":"https://api.github.com/users/om-sharma/followers","following_url":"https://api.github.com/users/om-sharma/following{/other_user}","gists_url":"https://api.github.com/users/om-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/om-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/om-sharma/subscriptions","organizations_url":"https://api.github.com/users/om-sharma/orgs","repos_url":"https://api.github.com/users/om-sharma/repos","events_url":"https://api.github.com/users/om-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/om-sharma/received_events","type":"User","site_admin":false},"body":"Extracted next and previous page link in Pagination class. Also rendering more details in pagination link","created_at":"2015-09-21T11:37:23Z","updated_at":"2015-09-22T16:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b72928ebef3b8b7ff6c6a09ba90866070e29e93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openregister/presentation/pulls/77/commits","review_comments_url":"https://api.github.com/repos/openregister/presentation/pulls/77/comments","review_comment_url":"https://api.github.com/repos/openregister/presentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/presentation/issues/77/comments","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/f222faa152003b34825827ee2226916314798908","head":{"label":"openregister:pagination-refactoring","ref":"pagination-refactoring","sha":"f222faa152003b34825827ee2226916314798908","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":38381661,"name":"presentation","full_name":"openregister/presentation","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/presentation","description":"Read-only register application","fork":false,"url":"https://api.github.com/repos/openregister/presentation","forks_url":"https://api.github.com/repos/openregister/presentation/forks","keys_url":"https://api.github.com/repos/openregister/presentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/presentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/presentation/teams","hooks_url":"https://api.github.com/repos/openregister/presentation/hooks","issue_events_url":"https://api.github.com/repos/openregister/presentation/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/presentation/events","assignees_url":"https://api.github.com/repos/openregister/presentation/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/presentation/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/presentation/tags","blobs_url":"https://api.github.com/repos/openregister/presentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/presentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/presentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/presentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/presentation/languages","stargazers_url":"https://api.github.com/repos/openregister/presentation/stargazers","contributors_url":"https://api.github.com/repos/openregister/presentation/contributors","subscribers_url":"https://api.github.com/repos/openregister/presentation/subscribers","subscription_url":"https://api.github.com/repos/openregister/presentation/subscription","commits_url":"https://api.github.com/repos/openregister/presentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/presentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/presentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/presentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/presentation/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/presentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/presentation/merges","archive_url":"https://api.github.com/repos/openregister/presentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/presentation/downloads","issues_url":"https://api.github.com/repos/openregister/presentation/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/presentation/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/presentation/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/presentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/presentation/labels{/name}","releases_url":"https://api.github.com/repos/openregister/presentation/releases{/id}","created_at":"2015-07-01T16:17:58Z","updated_at":"2015-09-22T11:24:37Z","pushed_at":"2015-09-22T12:11:10Z","git_url":"git://github.com/openregister/presentation.git","ssh_url":"git@github.com:openregister/presentation.git","clone_url":"https://github.com/openregister/presentation.git","svn_url":"https://github.com/openregister/presentation","homepage":"","size":3072,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openregister:master","ref":"master","sha":"b2dd5a99eaff0faee384fc546089608c6ffea770","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":38381661,"name":"presentation","full_name":"openregister/presentation","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/presentation","description":"Read-only register application","fork":false,"url":"https://api.github.com/repos/openregister/presentation","forks_url":"https://api.github.com/repos/openregister/presentation/forks","keys_url":"https://api.github.com/repos/openregister/presentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/presentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/presentation/teams","hooks_url":"https://api.github.com/repos/openregister/presentation/hooks","issue_events_url":"https://api.github.com/repos/openregister/presentation/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/presentation/events","assignees_url":"https://api.github.com/repos/openregister/presentation/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/presentation/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/presentation/tags","blobs_url":"https://api.github.com/repos/openregister/presentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/presentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/presentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/presentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/presentation/languages","stargazers_url":"https://api.github.com/repos/openregister/presentation/stargazers","contributors_url":"https://api.github.com/repos/openregister/presentation/contributors","subscribers_url":"https://api.github.com/repos/openregister/presentation/subscribers","subscription_url":"https://api.github.com/repos/openregister/presentation/subscription","commits_url":"https://api.github.com/repos/openregister/presentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/presentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/presentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/presentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/presentation/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/presentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/presentation/merges","archive_url":"https://api.github.com/repos/openregister/presentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/presentation/downloads","issues_url":"https://api.github.com/repos/openregister/presentation/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/presentation/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/presentation/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/presentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/presentation/labels{/name}","releases_url":"https://api.github.com/repos/openregister/presentation/releases{/id}","created_at":"2015-07-01T16:17:58Z","updated_at":"2015-09-22T11:24:37Z","pushed_at":"2015-09-22T12:11:10Z","git_url":"git://github.com/openregister/presentation.git","ssh_url":"git@github.com:openregister/presentation.git","clone_url":"https://github.com/openregister/presentation.git","svn_url":"https://github.com/openregister/presentation","homepage":"","size":3072,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/presentation/pulls/77"},"html":{"href":"https://github.com/openregister/presentation/pull/77"},"issue":{"href":"https://api.github.com/repos/openregister/presentation/issues/77"},"comments":{"href":"https://api.github.com/repos/openregister/presentation/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/presentation/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/presentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/presentation/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/presentation/statuses/f222faa152003b34825827ee2226916314798908"}}}}