{"action":"created","issue":{"url":"https://api.github.com/repos/joakimk/toniq/issues/7","labels_url":"https://api.github.com/repos/joakimk/toniq/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/joakimk/toniq/issues/7/comments","events_url":"https://api.github.com/repos/joakimk/toniq/issues/7/events","html_url":"https://github.com/joakimk/toniq/issues/7","id":120871824,"number":7,"title":"Minor quibble with Readme","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars.githubusercontent.com/u/247817?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-07T21:27:59Z","updated_at":"2015-12-09T15:35:43Z","closed_at":null,"body":"Hey!\r\n\r\nLooks like a cool library. As a minor quibble though about your readme example, you have\r\n\r\n```\r\n  def perform(to: to, subject: subject, body: body) do\r\n    # do work\r\n  end\r\n```\r\n\r\nIt is generally considered to not be a good idea to pattern match on keyword lists as they're order dependent. \r\n\r\nWhile `Toniq.enqueue(SendEmailWorker, to: \"info@example.com\", subject: \"Hello\", body: \"Hello, there!\")` would work `Toniq.enqueue(SendEmailWorker, subject: \"Hello\", to: \"info@example.com\", body: \"Hello, there!\")` would not, and that's generally confusing.\r\n\r\nAm I correct in reading that perform takes just one argument?"},"comment":{"url":"https://api.github.com/repos/joakimk/toniq/issues/comments/163294690","html_url":"https://github.com/joakimk/toniq/issues/7#issuecomment-163294690","issue_url":"https://api.github.com/repos/joakimk/toniq/issues/7","id":163294690,"user":{"login":"joakimk","id":13256,"avatar_url":"https://avatars.githubusercontent.com/u/13256?v=3","gravatar_id":"","url":"https://api.github.com/users/joakimk","html_url":"https://github.com/joakimk","followers_url":"https://api.github.com/users/joakimk/followers","following_url":"https://api.github.com/users/joakimk/following{/other_user}","gists_url":"https://api.github.com/users/joakimk/gists{/gist_id}","starred_url":"https://api.github.com/users/joakimk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakimk/subscriptions","organizations_url":"https://api.github.com/users/joakimk/orgs","repos_url":"https://api.github.com/users/joakimk/repos","events_url":"https://api.github.com/users/joakimk/events{/privacy}","received_events_url":"https://api.github.com/users/joakimk/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T15:35:43Z","updated_at":"2015-12-09T15:35:43Z","body":"Yeah, I've noticed that problem and the readme could certainly be improved. Contributions welcome :)\r\n\r\nThe enqueue takes a list of arguments, and because of that perform does too. So you can probably pass in just about anything there (as long as it can be serialized, so no Pids, etc)."}}