{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/41457184","id":41457184,"diff_hunk":"@@ -40,44 +42,44 @@ pub fn parse_logging_spec(spec: &str) -> (Vec<LogDirective>, Option<String>) {\n     let mods = parts.next();\n     let filter = parts.next();\n     if parts.next().is_some() {\n-        println!(\"warning: invalid logging spec '{}', \\\n-                 ignoring it (too many '/'s)\", spec);\n+        println!(\"warning: invalid logging spec '{}', ignoring it (too many '/'s)\", spec);\n         return (dirs, None);\n     }\n-    mods.map(|m| { for s in m.split(',') {\n-        if s.is_empty() { continue }\n-        let mut parts = s.split('=');\n-        let (log_level, name) = match (parts.next(), parts.next().map(|s| s.trim()), parts.next()) {\n-            (Some(part0), None, None) => {\n+    mods.map(|m| {\n+        for s in m.split(',') {\n+            if s.is_empty() {\n+                continue\n+            }","path":"src/liblog/directive.rs","position":42,"original_position":42,"commit_id":"a1a102c1c9077192e20fa58e030c0ffe8dbfa550","original_commit_id":"a1a102c1c9077192e20fa58e030c0ffe8dbfa550","user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"body":"I think that there's a bug to leave this one alone, can't remember exactly though.","created_at":"2015-10-07T22:39:08Z","updated_at":"2015-10-07T22:39:08Z","html_url":"https://github.com/rust-lang/rust/pull/28898#discussion_r41457184","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/28898","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/41457184"},"html":{"href":"https://github.com/rust-lang/rust/pull/28898#discussion_r41457184"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28898"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/28898","id":47091237,"html_url":"https://github.com/rust-lang/rust/pull/28898","diff_url":"https://github.com/rust-lang/rust/pull/28898.diff","patch_url":"https://github.com/rust-lang/rust/pull/28898.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/28898","number":28898,"state":"open","locked":false,"title":"Rustfmt-ing liblog.","user":{"login":"goyox86","id":9576,"avatar_url":"https://avatars.githubusercontent.com/u/9576?v=3","gravatar_id":"","url":"https://api.github.com/users/goyox86","html_url":"https://github.com/goyox86","followers_url":"https://api.github.com/users/goyox86/followers","following_url":"https://api.github.com/users/goyox86/following{/other_user}","gists_url":"https://api.github.com/users/goyox86/gists{/gist_id}","starred_url":"https://api.github.com/users/goyox86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goyox86/subscriptions","organizations_url":"https://api.github.com/users/goyox86/orgs","repos_url":"https://api.github.com/users/goyox86/repos","events_url":"https://api.github.com/users/goyox86/events{/privacy}","received_events_url":"https://api.github.com/users/goyox86/received_events","type":"User","site_admin":false},"body":"Hi Rustaceans!\r\n\r\nI'm not Rust coder, I just ran rustfmt on liblog following @nrc's blog post and this is the result (Along some fixes I've done to rustfmt's work). As other PR's I think we should run rustfmt again on this crate in the future and see if we accept more of it's changes.\r\n\r\n//cc @nrc ","created_at":"2015-10-07T22:33:28Z","updated_at":"2015-10-07T22:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"178fa089673943b435ea98ce8cd749771b910428","assignee":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/28898/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/28898/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/28898/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/a1a102c1c9077192e20fa58e030c0ffe8dbfa550","head":{"label":"goyox86:goyox86/rustfmting-liblog","ref":"goyox86/rustfmting-liblog","sha":"a1a102c1c9077192e20fa58e030c0ffe8dbfa550","user":{"login":"goyox86","id":9576,"avatar_url":"https://avatars.githubusercontent.com/u/9576?v=3","gravatar_id":"","url":"https://api.github.com/users/goyox86","html_url":"https://github.com/goyox86","followers_url":"https://api.github.com/users/goyox86/followers","following_url":"https://api.github.com/users/goyox86/following{/other_user}","gists_url":"https://api.github.com/users/goyox86/gists{/gist_id}","starred_url":"https://api.github.com/users/goyox86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goyox86/subscriptions","organizations_url":"https://api.github.com/users/goyox86/orgs","repos_url":"https://api.github.com/users/goyox86/repos","events_url":"https://api.github.com/users/goyox86/events{/privacy}","received_events_url":"https://api.github.com/users/goyox86/received_events","type":"User","site_admin":false},"repo":{"id":43846750,"name":"rust","full_name":"goyox86/rust","owner":{"login":"goyox86","id":9576,"avatar_url":"https://avatars.githubusercontent.com/u/9576?v=3","gravatar_id":"","url":"https://api.github.com/users/goyox86","html_url":"https://github.com/goyox86","followers_url":"https://api.github.com/users/goyox86/followers","following_url":"https://api.github.com/users/goyox86/following{/other_user}","gists_url":"https://api.github.com/users/goyox86/gists{/gist_id}","starred_url":"https://api.github.com/users/goyox86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goyox86/subscriptions","organizations_url":"https://api.github.com/users/goyox86/orgs","repos_url":"https://api.github.com/users/goyox86/repos","events_url":"https://api.github.com/users/goyox86/events{/privacy}","received_events_url":"https://api.github.com/users/goyox86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goyox86/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/goyox86/rust","forks_url":"https://api.github.com/repos/goyox86/rust/forks","keys_url":"https://api.github.com/repos/goyox86/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goyox86/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goyox86/rust/teams","hooks_url":"https://api.github.com/repos/goyox86/rust/hooks","issue_events_url":"https://api.github.com/repos/goyox86/rust/issues/events{/number}","events_url":"https://api.github.com/repos/goyox86/rust/events","assignees_url":"https://api.github.com/repos/goyox86/rust/assignees{/user}","branches_url":"https://api.github.com/repos/goyox86/rust/branches{/branch}","tags_url":"https://api.github.com/repos/goyox86/rust/tags","blobs_url":"https://api.github.com/repos/goyox86/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goyox86/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goyox86/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/goyox86/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goyox86/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/goyox86/rust/languages","stargazers_url":"https://api.github.com/repos/goyox86/rust/stargazers","contributors_url":"https://api.github.com/repos/goyox86/rust/contributors","subscribers_url":"https://api.github.com/repos/goyox86/rust/subscribers","subscription_url":"https://api.github.com/repos/goyox86/rust/subscription","commits_url":"https://api.github.com/repos/goyox86/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/goyox86/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/goyox86/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/goyox86/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/goyox86/rust/contents/{+path}","compare_url":"https://api.github.com/repos/goyox86/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goyox86/rust/merges","archive_url":"https://api.github.com/repos/goyox86/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goyox86/rust/downloads","issues_url":"https://api.github.com/repos/goyox86/rust/issues{/number}","pulls_url":"https://api.github.com/repos/goyox86/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/goyox86/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/goyox86/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goyox86/rust/labels{/name}","releases_url":"https://api.github.com/repos/goyox86/rust/releases{/id}","created_at":"2015-10-07T21:49:58Z","updated_at":"2015-10-07T21:50:52Z","pushed_at":"2015-10-07T22:26:02Z","git_url":"git://github.com/goyox86/rust.git","ssh_url":"git@github.com:goyox86/rust.git","clone_url":"https://github.com/goyox86/rust.git","svn_url":"https://github.com/goyox86/rust","homepage":"http://www.rust-lang.org","size":689985,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"babe953e69798741d1a96f6b687742434b180def","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-10-07T21:14:35Z","pushed_at":"2015-10-07T22:33:29Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":689985,"stargazers_count":13700,"watchers_count":13700,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2656,"mirror_url":null,"open_issues_count":2251,"forks":2656,"open_issues":2251,"watchers":13700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28898"},"html":{"href":"https://github.com/rust-lang/rust/pull/28898"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28898"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28898/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28898/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28898/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/a1a102c1c9077192e20fa58e030c0ffe8dbfa550"}}}}