{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/finagle/issues/346","labels_url":"https://api.github.com/repos/twitter/finagle/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/346/comments","events_url":"https://api.github.com/repos/twitter/finagle/issues/346/events","html_url":"https://github.com/twitter/finagle/pull/346","id":59101702,"number":346,"title":"finagle-core: Set finite SSL handshake timeout. Fixes #345","user":{"login":"sirmax","id":868418,"avatar_url":"https://avatars.githubusercontent.com/u/868418?v=3","gravatar_id":"","url":"https://api.github.com/users/sirmax","html_url":"https://github.com/sirmax","followers_url":"https://api.github.com/users/sirmax/followers","following_url":"https://api.github.com/users/sirmax/following{/other_user}","gists_url":"https://api.github.com/users/sirmax/gists{/gist_id}","starred_url":"https://api.github.com/users/sirmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirmax/subscriptions","organizations_url":"https://api.github.com/users/sirmax/orgs","repos_url":"https://api.github.com/users/sirmax/repos","events_url":"https://api.github.com/users/sirmax/events{/privacy}","received_events_url":"https://api.github.com/users/sirmax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-02-26T16:52:02Z","updated_at":"2015-03-03T21:45:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/346","html_url":"https://github.com/twitter/finagle/pull/346","diff_url":"https://github.com/twitter/finagle/pull/346.diff","patch_url":"https://github.com/twitter/finagle/pull/346.patch"},"body":"Problem\r\n\r\nNetty3Transporter does not set explicit handshake timeout on SslHandler.\r\n\r\nIf a channel configured this way establishes TCP connection with a\r\nremote that does not respond to a handshake, the channel would get stuck\r\nin \"connecting\" state indefinitely.\r\n\r\nSolution\r\n\r\nAdd Transporter.SSLHandshakeTimeout stack param. Set its value to\r\n10 seconds by default. Use this param to configure SslHandler.\r\n\r\nResult\r\n\r\nConnections do not get stuck in SSL handshake.\r\nFixes #345"},"comment":{"url":"https://api.github.com/repos/twitter/finagle/issues/comments/77042848","html_url":"https://github.com/twitter/finagle/pull/346#issuecomment-77042848","issue_url":"https://api.github.com/repos/twitter/finagle/issues/346","id":77042848,"user":{"login":"dschobel","id":58369,"avatar_url":"https://avatars.githubusercontent.com/u/58369?v=3","gravatar_id":"","url":"https://api.github.com/users/dschobel","html_url":"https://github.com/dschobel","followers_url":"https://api.github.com/users/dschobel/followers","following_url":"https://api.github.com/users/dschobel/following{/other_user}","gists_url":"https://api.github.com/users/dschobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dschobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschobel/subscriptions","organizations_url":"https://api.github.com/users/dschobel/orgs","repos_url":"https://api.github.com/users/dschobel/repos","events_url":"https://api.github.com/users/dschobel/events{/privacy}","received_events_url":"https://api.github.com/users/dschobel/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T21:45:22Z","updated_at":"2015-03-03T21:45:22Z","body":"I think if we had no existing clients it would be the right thing to do but expanding the scope of Transporter.ConnectTimeout to cover those additional twelve packet transmissions of ssl handshake would likely break clients applying tight timeouts tuned against the existing narrower scope. I think it’s better to keep this as an expert knob that maps directly to the netty param, as written."}}