{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef-provisioning/issues/254","labels_url":"https://api.github.com/repos/chef/chef-provisioning/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef-provisioning/issues/254/comments","events_url":"https://api.github.com/repos/chef/chef-provisioning/issues/254/events","html_url":"https://github.com/chef/chef-provisioning/pull/254","id":52772331,"number":254,"title":"Fix ssh_gateway values without a username in them","user":{"login":"mivok","id":60603,"avatar_url":"https://avatars.githubusercontent.com/u/60603?v=3","gravatar_id":"","url":"https://api.github.com/users/mivok","html_url":"https://github.com/mivok","followers_url":"https://api.github.com/users/mivok/followers","following_url":"https://api.github.com/users/mivok/following{/other_user}","gists_url":"https://api.github.com/users/mivok/gists{/gist_id}","starred_url":"https://api.github.com/users/mivok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mivok/subscriptions","organizations_url":"https://api.github.com/users/mivok/orgs","repos_url":"https://api.github.com/users/mivok/repos","events_url":"https://api.github.com/users/mivok/events{/privacy}","received_events_url":"https://api.github.com/users/mivok/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/chef-provisioning/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/chef/chef-provisioning/milestones/1","labels_url":"https://api.github.com/repos/chef/chef-provisioning/milestones/1/labels","id":759255,"number":1,"title":"1.0","description":"The initial public release of Chef Metal.  Must:\r\n\r\n1. Be stable (all drivers work, and succeed 100 times in a row)\r\n2. Be extremely usable (very low bar for entry, integration with other tool configuration, easy ways to specify keys)\r\n3. Allow users to create and destroy machines\r\n4. Have drivers for bare metal, containers, VMs and clouds.\r\n5. Client works on Windows and Unices.\r\n6. Can provision Windows and Unices.\r\n\r\nAll that is not strictly covered by this list is NOT 1.0.  That includes, for example, images (which exist, but will not receive the same sort of priority attention).","creator":{"login":"jkeiser","id":654882,"avatar_url":"https://avatars.githubusercontent.com/u/654882?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeiser","html_url":"https://github.com/jkeiser","followers_url":"https://api.github.com/users/jkeiser/followers","following_url":"https://api.github.com/users/jkeiser/following{/other_user}","gists_url":"https://api.github.com/users/jkeiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeiser/subscriptions","organizations_url":"https://api.github.com/users/jkeiser/orgs","repos_url":"https://api.github.com/users/jkeiser/repos","events_url":"https://api.github.com/users/jkeiser/events{/privacy}","received_events_url":"https://api.github.com/users/jkeiser/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":27,"state":"open","created_at":"2014-08-19T21:02:28Z","updated_at":"2015-01-27T16:08:49Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2014-12-23T20:29:18Z","updated_at":"2015-01-27T16:08:49Z","closed_at":"2015-01-27T16:08:49Z","pull_request":{"url":"https://api.github.com/repos/chef/chef-provisioning/pulls/254","html_url":"https://github.com/chef/chef-provisioning/pull/254","diff_url":"https://github.com/chef/chef-provisioning/pull/254.diff","patch_url":"https://github.com/chef/chef-provisioning/pull/254.patch"},"body":"This change fixes the behavior when an ssh_gateway is given that is simply a\r\nhostname and doesn't include a username.\r\n\r\nPreviously, ssh_gateway values without an @ in them would result in the\r\nhostname value being stored in gw_user and gw_host being nil, causing an\r\nexception on the next line.\r\n\r\nIn addition, the line that sets a default username for the gateway to the same\r\nas for the machine itself has been removed. This code never took effect anyway\r\ndue to the previous bug and it makes an incorrect assumption that the username\r\non the new machine is the same as the username on the gateway machine, which\r\nis almost never the case given that the username on the new machine is\r\nsomething like root, ec2user or ubuntu when creating a machine."},"comment":{"url":"https://api.github.com/repos/chef/chef-provisioning/issues/comments/71674002","html_url":"https://github.com/chef/chef-provisioning/pull/254#issuecomment-71674002","issue_url":"https://api.github.com/repos/chef/chef-provisioning/issues/254","id":71674002,"user":{"login":"jkeiser","id":654882,"avatar_url":"https://avatars.githubusercontent.com/u/654882?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeiser","html_url":"https://github.com/jkeiser","followers_url":"https://api.github.com/users/jkeiser/followers","following_url":"https://api.github.com/users/jkeiser/following{/other_user}","gists_url":"https://api.github.com/users/jkeiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeiser/subscriptions","organizations_url":"https://api.github.com/users/jkeiser/orgs","repos_url":"https://api.github.com/users/jkeiser/repos","events_url":"https://api.github.com/users/jkeiser/events{/privacy}","received_events_url":"https://api.github.com/users/jkeiser/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T16:08:49Z","updated_at":"2015-01-27T16:08:49Z","body":"Merged as 82cae87.  Thanks!"}}