{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14271","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14271/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14271/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14271/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14271","id":107508954,"number":14271,"title":"WIP/MESOS: fix flaky TestPlugin_LifeCycle","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/mesosphere","name":"team/mesosphere","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2015-09-21T13:15:30Z","updated_at":"2015-09-22T20:03:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14271","html_url":"https://github.com/kubernetes/kubernetes/pull/14271","diff_url":"https://github.com/kubernetes/kubernetes/pull/14271.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14271.patch"},"body":"This PR is supposed to fix #11901 and https://github.com/mesosphere/kubernetes-mesos/issues/441 by increasing timeouts from a few seconds to one minute. Additionally this PR catches up with the most recent changes in the scheduler. Finally it introduces a simple lifecycle test setup inspired by @sttts (https://github.com/sttts/kubernetes/commit/27c80bcaf7752983bc2809b476b72fa4da3e2327)."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/142403040","html_url":"https://github.com/kubernetes/kubernetes/pull/14271#issuecomment-142403040","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14271","id":142403040,"user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T20:03:27Z","updated_at":"2015-09-22T20:03:27Z","body":"packages can also be named with a _test suffix to force the linker's hand.\nso if the folder is a/b/c, you can create a file a/b/c/c_test.go that\ndeclares a package of \"c_test\"\n\nOn Tue, Sep 22, 2015 at 12:32 PM, Sergiusz Urbaniak <\nnotifications@github.com> wrote:\n\n> @karlkfi <https://github.com/karlkfi> thanks for your comments. I\n> suggested test (as in\n> https://github.com/camlistore/camlistore/tree/master/pkg/test) but @jdef\n> <https://github.com/jdef> preferred schedulertest. I prefer test or mock\n> too.\n>\n> Everything you see in schedulertest and schedulertest/driver used to be\n> embedded in one big plugin_test.go file. The changes exposed here are\n> quite mechanical.\n>\n> I'll recheck whether the linker really embeds the schedulertest pkg in\n> the final binary. It shouldn't (imho) as long as there is no reference from\n> non-test code. Additionally all structs and construction methods are\n> private.\n>\n> The schedulertest/driver package was necessary to resolve a circular\n> package dependency because scheduler_test.go also uses the mock driver. I\n> am happy to move all this jazz in different pkgs, i.e. mock/driver,\n> mock/listwatch, mock/server, etc.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/kubernetes/kubernetes/pull/14271#issuecomment-142341802>\n> .\n>\n"}}