{"action":"created","comment":{"url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/comments/30734056","id":30734056,"diff_hunk":"@@ -71,10 +75,14 @@ getResults = function(reg, ids, part = NA_character_, missing.ok = FALSE) {\n \n   fns = getResultFilePath(reg, ids, part)\n   miss = !file.exists(fns)\n+\n   if (any(miss)) {\n     if (!missing.ok)\n       stopf(\"Some job result files do not exist, showing up to first 10:\\n%s\", collapse(head(fns[miss], 10L), \"\\n\"))\n-    return(replace(vector(\"list\", length(ids)), !miss, lapply(fns[!miss], load2, \"result\")))\n+    ret = lapply(seq(along = ids), function(i) missing.value)","path":"R/loadResults.R","position":null,"original_position":43,"commit_id":"5daf845f6efaa36b200cb564a6a56d03c0a7162b","original_commit_id":"3f4b5d4df72d5549fedee03760916f71116c46f4","user":{"login":"mllg","id":1260920,"avatar_url":"https://avatars.githubusercontent.com/u/1260920?v=3","gravatar_id":"","url":"https://api.github.com/users/mllg","html_url":"https://github.com/mllg","followers_url":"https://api.github.com/users/mllg/followers","following_url":"https://api.github.com/users/mllg/following{/other_user}","gists_url":"https://api.github.com/users/mllg/gists{/gist_id}","starred_url":"https://api.github.com/users/mllg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mllg/subscriptions","organizations_url":"https://api.github.com/users/mllg/orgs","repos_url":"https://api.github.com/users/mllg/repos","events_url":"https://api.github.com/users/mllg/events{/privacy}","received_events_url":"https://api.github.com/users/mllg/received_events","type":"User","site_admin":false},"body":"Great! I'll wait for Travis and AppVeyor , then merge.","created_at":"2015-05-20T18:33:49Z","updated_at":"2015-05-20T18:33:49Z","html_url":"https://github.com/tudo-r/BatchJobs/pull/88#discussion_r30734056","pull_request_url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/comments/30734056"},"html":{"href":"https://github.com/tudo-r/BatchJobs/pull/88#discussion_r30734056"},"pull_request":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88","id":35842449,"html_url":"https://github.com/tudo-r/BatchJobs/pull/88","diff_url":"https://github.com/tudo-r/BatchJobs/pull/88.diff","patch_url":"https://github.com/tudo-r/BatchJobs/pull/88.patch","issue_url":"https://api.github.com/repos/tudo-r/BatchJobs/issues/88","number":88,"state":"open","locked":false,"title":"add missing.value argument to loadResults. For PR","user":{"login":"gmbecker","id":908721,"avatar_url":"https://avatars.githubusercontent.com/u/908721?v=3","gravatar_id":"","url":"https://api.github.com/users/gmbecker","html_url":"https://github.com/gmbecker","followers_url":"https://api.github.com/users/gmbecker/followers","following_url":"https://api.github.com/users/gmbecker/following{/other_user}","gists_url":"https://api.github.com/users/gmbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbecker/subscriptions","organizations_url":"https://api.github.com/users/gmbecker/orgs","repos_url":"https://api.github.com/users/gmbecker/repos","events_url":"https://api.github.com/users/gmbecker/events{/privacy}","received_events_url":"https://api.github.com/users/gmbecker/received_events","type":"User","site_admin":false},"body":"I am working on adding asychronous parallelism support to BiocParallel, but I need to be able to distinguish between jobs which have finished but returned NULL, and those that haven't completed yet. \r\n\r\nI propose to allow this, while retaining full backwards compatability, by having a configurable sentinel value that is returned if the results are missing (usually because the jobs are not done), but having it default to NULL which retains the existing behavior.\r\n\r\nThis PR implements the above scheme, and updates the roxygen documentation to reflect the new argument","created_at":"2015-05-20T15:13:51Z","updated_at":"2015-05-20T18:33:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba6319ace234e4e4fed52f5a89475aad7872e28c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88/commits","review_comments_url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88/comments","review_comment_url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tudo-r/BatchJobs/issues/88/comments","statuses_url":"https://api.github.com/repos/tudo-r/BatchJobs/statuses/5daf845f6efaa36b200cb564a6a56d03c0a7162b","head":{"label":"gmbecker:master","ref":"master","sha":"5daf845f6efaa36b200cb564a6a56d03c0a7162b","user":{"login":"gmbecker","id":908721,"avatar_url":"https://avatars.githubusercontent.com/u/908721?v=3","gravatar_id":"","url":"https://api.github.com/users/gmbecker","html_url":"https://github.com/gmbecker","followers_url":"https://api.github.com/users/gmbecker/followers","following_url":"https://api.github.com/users/gmbecker/following{/other_user}","gists_url":"https://api.github.com/users/gmbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbecker/subscriptions","organizations_url":"https://api.github.com/users/gmbecker/orgs","repos_url":"https://api.github.com/users/gmbecker/repos","events_url":"https://api.github.com/users/gmbecker/events{/privacy}","received_events_url":"https://api.github.com/users/gmbecker/received_events","type":"User","site_admin":false},"repo":{"id":35955233,"name":"BatchJobs","full_name":"gmbecker/BatchJobs","owner":{"login":"gmbecker","id":908721,"avatar_url":"https://avatars.githubusercontent.com/u/908721?v=3","gravatar_id":"","url":"https://api.github.com/users/gmbecker","html_url":"https://github.com/gmbecker","followers_url":"https://api.github.com/users/gmbecker/followers","following_url":"https://api.github.com/users/gmbecker/following{/other_user}","gists_url":"https://api.github.com/users/gmbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbecker/subscriptions","organizations_url":"https://api.github.com/users/gmbecker/orgs","repos_url":"https://api.github.com/users/gmbecker/repos","events_url":"https://api.github.com/users/gmbecker/events{/privacy}","received_events_url":"https://api.github.com/users/gmbecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmbecker/BatchJobs","description":"BatchJobs: Batch computing with R","fork":true,"url":"https://api.github.com/repos/gmbecker/BatchJobs","forks_url":"https://api.github.com/repos/gmbecker/BatchJobs/forks","keys_url":"https://api.github.com/repos/gmbecker/BatchJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmbecker/BatchJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmbecker/BatchJobs/teams","hooks_url":"https://api.github.com/repos/gmbecker/BatchJobs/hooks","issue_events_url":"https://api.github.com/repos/gmbecker/BatchJobs/issues/events{/number}","events_url":"https://api.github.com/repos/gmbecker/BatchJobs/events","assignees_url":"https://api.github.com/repos/gmbecker/BatchJobs/assignees{/user}","branches_url":"https://api.github.com/repos/gmbecker/BatchJobs/branches{/branch}","tags_url":"https://api.github.com/repos/gmbecker/BatchJobs/tags","blobs_url":"https://api.github.com/repos/gmbecker/BatchJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmbecker/BatchJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmbecker/BatchJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmbecker/BatchJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmbecker/BatchJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/gmbecker/BatchJobs/languages","stargazers_url":"https://api.github.com/repos/gmbecker/BatchJobs/stargazers","contributors_url":"https://api.github.com/repos/gmbecker/BatchJobs/contributors","subscribers_url":"https://api.github.com/repos/gmbecker/BatchJobs/subscribers","subscription_url":"https://api.github.com/repos/gmbecker/BatchJobs/subscription","commits_url":"https://api.github.com/repos/gmbecker/BatchJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmbecker/BatchJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmbecker/BatchJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmbecker/BatchJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmbecker/BatchJobs/contents/{+path}","compare_url":"https://api.github.com/repos/gmbecker/BatchJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmbecker/BatchJobs/merges","archive_url":"https://api.github.com/repos/gmbecker/BatchJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmbecker/BatchJobs/downloads","issues_url":"https://api.github.com/repos/gmbecker/BatchJobs/issues{/number}","pulls_url":"https://api.github.com/repos/gmbecker/BatchJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/gmbecker/BatchJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/gmbecker/BatchJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmbecker/BatchJobs/labels{/name}","releases_url":"https://api.github.com/repos/gmbecker/BatchJobs/releases{/id}","created_at":"2015-05-20T15:03:27Z","updated_at":"2015-05-20T15:03:28Z","pushed_at":"2015-05-20T18:29:29Z","git_url":"git://github.com/gmbecker/BatchJobs.git","ssh_url":"git@github.com:gmbecker/BatchJobs.git","clone_url":"https://github.com/gmbecker/BatchJobs.git","svn_url":"https://github.com/gmbecker/BatchJobs","homepage":"","size":3887,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tudo-r:master","ref":"master","sha":"b784e866d88a8e37c2eb831aff49ef3e81c5762f","user":{"login":"tudo-r","id":5833285,"avatar_url":"https://avatars.githubusercontent.com/u/5833285?v=3","gravatar_id":"","url":"https://api.github.com/users/tudo-r","html_url":"https://github.com/tudo-r","followers_url":"https://api.github.com/users/tudo-r/followers","following_url":"https://api.github.com/users/tudo-r/following{/other_user}","gists_url":"https://api.github.com/users/tudo-r/gists{/gist_id}","starred_url":"https://api.github.com/users/tudo-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudo-r/subscriptions","organizations_url":"https://api.github.com/users/tudo-r/orgs","repos_url":"https://api.github.com/users/tudo-r/repos","events_url":"https://api.github.com/users/tudo-r/events{/privacy}","received_events_url":"https://api.github.com/users/tudo-r/received_events","type":"Organization","site_admin":false},"repo":{"id":14144345,"name":"BatchJobs","full_name":"tudo-r/BatchJobs","owner":{"login":"tudo-r","id":5833285,"avatar_url":"https://avatars.githubusercontent.com/u/5833285?v=3","gravatar_id":"","url":"https://api.github.com/users/tudo-r","html_url":"https://github.com/tudo-r","followers_url":"https://api.github.com/users/tudo-r/followers","following_url":"https://api.github.com/users/tudo-r/following{/other_user}","gists_url":"https://api.github.com/users/tudo-r/gists{/gist_id}","starred_url":"https://api.github.com/users/tudo-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudo-r/subscriptions","organizations_url":"https://api.github.com/users/tudo-r/orgs","repos_url":"https://api.github.com/users/tudo-r/repos","events_url":"https://api.github.com/users/tudo-r/events{/privacy}","received_events_url":"https://api.github.com/users/tudo-r/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tudo-r/BatchJobs","description":"BatchJobs: Batch computing with R","fork":false,"url":"https://api.github.com/repos/tudo-r/BatchJobs","forks_url":"https://api.github.com/repos/tudo-r/BatchJobs/forks","keys_url":"https://api.github.com/repos/tudo-r/BatchJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tudo-r/BatchJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tudo-r/BatchJobs/teams","hooks_url":"https://api.github.com/repos/tudo-r/BatchJobs/hooks","issue_events_url":"https://api.github.com/repos/tudo-r/BatchJobs/issues/events{/number}","events_url":"https://api.github.com/repos/tudo-r/BatchJobs/events","assignees_url":"https://api.github.com/repos/tudo-r/BatchJobs/assignees{/user}","branches_url":"https://api.github.com/repos/tudo-r/BatchJobs/branches{/branch}","tags_url":"https://api.github.com/repos/tudo-r/BatchJobs/tags","blobs_url":"https://api.github.com/repos/tudo-r/BatchJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tudo-r/BatchJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tudo-r/BatchJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tudo-r/BatchJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tudo-r/BatchJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/tudo-r/BatchJobs/languages","stargazers_url":"https://api.github.com/repos/tudo-r/BatchJobs/stargazers","contributors_url":"https://api.github.com/repos/tudo-r/BatchJobs/contributors","subscribers_url":"https://api.github.com/repos/tudo-r/BatchJobs/subscribers","subscription_url":"https://api.github.com/repos/tudo-r/BatchJobs/subscription","commits_url":"https://api.github.com/repos/tudo-r/BatchJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tudo-r/BatchJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tudo-r/BatchJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tudo-r/BatchJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tudo-r/BatchJobs/contents/{+path}","compare_url":"https://api.github.com/repos/tudo-r/BatchJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tudo-r/BatchJobs/merges","archive_url":"https://api.github.com/repos/tudo-r/BatchJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tudo-r/BatchJobs/downloads","issues_url":"https://api.github.com/repos/tudo-r/BatchJobs/issues{/number}","pulls_url":"https://api.github.com/repos/tudo-r/BatchJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/tudo-r/BatchJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/tudo-r/BatchJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tudo-r/BatchJobs/labels{/name}","releases_url":"https://api.github.com/repos/tudo-r/BatchJobs/releases{/id}","created_at":"2013-11-05T14:58:33Z","updated_at":"2015-05-13T21:15:43Z","pushed_at":"2015-05-20T18:29:29Z","git_url":"git://github.com/tudo-r/BatchJobs.git","ssh_url":"git@github.com:tudo-r/BatchJobs.git","clone_url":"https://github.com/tudo-r/BatchJobs.git","svn_url":"https://github.com/tudo-r/BatchJobs","homepage":"","size":3887,"stargazers_count":38,"watchers_count":38,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":28,"forks":12,"open_issues":28,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88"},"html":{"href":"https://github.com/tudo-r/BatchJobs/pull/88"},"issue":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/issues/88"},"comments":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/tudo-r/BatchJobs/statuses/5daf845f6efaa36b200cb564a6a56d03c0a7162b"}}}}