{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/32523126","id":32523126,"diff_hunk":"@@ -101,7 +101,7 @@\n # If PX4_BASE wasn't set previously, work out what it should be\n # and set it here now.\n #\n-MK_DIR\t\t\t?= $(dir $(lastword $(MAKEFILE_LIST)))\n+MK_DIR\t\t\t:= $(dir $(lastword $(MAKEFILE_LIST)))","path":"makefiles/firmware.mk","position":5,"original_position":5,"commit_id":"38fec795eff582e7830f4119ba5e0bd1bca2bff0","original_commit_id":"38fec795eff582e7830f4119ba5e0bd1bca2bff0","user":{"login":"mcharleb","id":848323,"avatar_url":"https://avatars.githubusercontent.com/u/848323?v=3","gravatar_id":"","url":"https://api.github.com/users/mcharleb","html_url":"https://github.com/mcharleb","followers_url":"https://api.github.com/users/mcharleb/followers","following_url":"https://api.github.com/users/mcharleb/following{/other_user}","gists_url":"https://api.github.com/users/mcharleb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharleb/subscriptions","organizations_url":"https://api.github.com/users/mcharleb/orgs","repos_url":"https://api.github.com/users/mcharleb/repos","events_url":"https://api.github.com/users/mcharleb/events{/privacy}","received_events_url":"https://api.github.com/users/mcharleb/received_events","type":"User","site_admin":false},"body":"It doesn't behave correctly for makefiles in target subdirs\n(Firmware/makefiles/nuttx) when the value is not set immediately.\n\nOn Mon, Jun 15, 2015 at 11:37 PM, Lorenz Meier <notifications@github.com>\nwrote:\n\n> In makefiles/firmware.mk\n> <https://github.com/PX4/Firmware/pull/2388#discussion_r32494409>:\n>\n> > @@ -101,7 +101,7 @@\n> >  # If PX4_BASE wasn't set previously, work out what it should be\n> >  # and set it here now.\n> >  #\n> > -MK_DIR\t\t\t?= $(dir $(lastword $(MAKEFILE_LIST)))\n> > +MK_DIR\t\t\t:= $(dir $(lastword $(MAKEFILE_LIST)))\n>\n> I think APM uses the override in its build, so this needs to stay ?=\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/PX4/Firmware/pull/2388/files#r32494409>.\n>\n","created_at":"2015-06-16T14:00:46Z","updated_at":"2015-06-16T14:00:46Z","html_url":"https://github.com/PX4/Firmware/pull/2388#discussion_r32523126","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/2388","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/32523126"},"html":{"href":"https://github.com/PX4/Firmware/pull/2388#discussion_r32523126"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/2388"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/2388","id":37749417,"html_url":"https://github.com/PX4/Firmware/pull/2388","diff_url":"https://github.com/PX4/Firmware/pull/2388.diff","patch_url":"https://github.com/PX4/Firmware/pull/2388.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/2388","number":2388,"state":"open","locked":false,"title":"Makefile cleanup","user":{"login":"mcharleb","id":848323,"avatar_url":"https://avatars.githubusercontent.com/u/848323?v=3","gravatar_id":"","url":"https://api.github.com/users/mcharleb","html_url":"https://github.com/mcharleb","followers_url":"https://api.github.com/users/mcharleb/followers","following_url":"https://api.github.com/users/mcharleb/following{/other_user}","gists_url":"https://api.github.com/users/mcharleb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharleb/subscriptions","organizations_url":"https://api.github.com/users/mcharleb/orgs","repos_url":"https://api.github.com/users/mcharleb/repos","events_url":"https://api.github.com/users/mcharleb/events{/privacy}","received_events_url":"https://api.github.com/users/mcharleb/received_events","type":"User","site_admin":false},"body":"Refactored makefiles so target specific rules are under the target sub-directories.\r\n\r\nUpdated SITL documentation.","created_at":"2015-06-16T00:29:52Z","updated_at":"2015-06-16T14:00:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e243f6b0c355f18cda1343bb53e32a3954d327a","assignee":null,"milestone":{"url":"https://api.github.com/repos/PX4/Firmware/milestones/7","html_url":"https://github.com/PX4/Firmware/milestones/Linux%20Port","labels_url":"https://api.github.com/repos/PX4/Firmware/milestones/7/labels","id":1060119,"number":7,"title":"Linux Port","description":"First bench-operational version of Linux port on RPI2 + NavIO+ and Qualcomm drone board.","creator":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2015-04-09T10:51:55Z","updated_at":"2015-06-16T06:38:18Z","due_on":"2015-05-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/2388/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/2388/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/2388/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/38fec795eff582e7830f4119ba5e0bd1bca2bff0","head":{"label":"mcharleb:makefile-cleanup","ref":"makefile-cleanup","sha":"38fec795eff582e7830f4119ba5e0bd1bca2bff0","user":{"login":"mcharleb","id":848323,"avatar_url":"https://avatars.githubusercontent.com/u/848323?v=3","gravatar_id":"","url":"https://api.github.com/users/mcharleb","html_url":"https://github.com/mcharleb","followers_url":"https://api.github.com/users/mcharleb/followers","following_url":"https://api.github.com/users/mcharleb/following{/other_user}","gists_url":"https://api.github.com/users/mcharleb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharleb/subscriptions","organizations_url":"https://api.github.com/users/mcharleb/orgs","repos_url":"https://api.github.com/users/mcharleb/repos","events_url":"https://api.github.com/users/mcharleb/events{/privacy}","received_events_url":"https://api.github.com/users/mcharleb/received_events","type":"User","site_admin":false},"repo":{"id":32031269,"name":"Firmware","full_name":"mcharleb/Firmware","owner":{"login":"mcharleb","id":848323,"avatar_url":"https://avatars.githubusercontent.com/u/848323?v=3","gravatar_id":"","url":"https://api.github.com/users/mcharleb","html_url":"https://github.com/mcharleb","followers_url":"https://api.github.com/users/mcharleb/followers","following_url":"https://api.github.com/users/mcharleb/following{/other_user}","gists_url":"https://api.github.com/users/mcharleb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharleb/subscriptions","organizations_url":"https://api.github.com/users/mcharleb/orgs","repos_url":"https://api.github.com/users/mcharleb/repos","events_url":"https://api.github.com/users/mcharleb/events{/privacy}","received_events_url":"https://api.github.com/users/mcharleb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcharleb/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":true,"url":"https://api.github.com/repos/mcharleb/Firmware","forks_url":"https://api.github.com/repos/mcharleb/Firmware/forks","keys_url":"https://api.github.com/repos/mcharleb/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcharleb/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcharleb/Firmware/teams","hooks_url":"https://api.github.com/repos/mcharleb/Firmware/hooks","issue_events_url":"https://api.github.com/repos/mcharleb/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/mcharleb/Firmware/events","assignees_url":"https://api.github.com/repos/mcharleb/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/mcharleb/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/mcharleb/Firmware/tags","blobs_url":"https://api.github.com/repos/mcharleb/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcharleb/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcharleb/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcharleb/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcharleb/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/mcharleb/Firmware/languages","stargazers_url":"https://api.github.com/repos/mcharleb/Firmware/stargazers","contributors_url":"https://api.github.com/repos/mcharleb/Firmware/contributors","subscribers_url":"https://api.github.com/repos/mcharleb/Firmware/subscribers","subscription_url":"https://api.github.com/repos/mcharleb/Firmware/subscription","commits_url":"https://api.github.com/repos/mcharleb/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcharleb/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcharleb/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcharleb/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcharleb/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/mcharleb/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcharleb/Firmware/merges","archive_url":"https://api.github.com/repos/mcharleb/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcharleb/Firmware/downloads","issues_url":"https://api.github.com/repos/mcharleb/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/mcharleb/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/mcharleb/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/mcharleb/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcharleb/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/mcharleb/Firmware/releases{/id}","created_at":"2015-03-11T17:25:11Z","updated_at":"2015-05-11T12:46:25Z","pushed_at":"2015-06-16T01:24:49Z","git_url":"git://github.com/mcharleb/Firmware.git","ssh_url":"git@github.com:mcharleb/Firmware.git","clone_url":"https://github.com/mcharleb/Firmware.git","svn_url":"https://github.com/mcharleb/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":73282,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"bringup-m4"}},"base":{"label":"PX4:master","ref":"master","sha":"2e5d2c1cbe8130c916cdc9250dc7805f313c6a32","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","created_at":"2012-08-04T21:19:36Z","updated_at":"2015-06-15T17:38:24Z","pushed_at":"2015-06-16T10:48:05Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":153985,"stargazers_count":328,"watchers_count":328,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1215,"mirror_url":null,"open_issues_count":147,"forks":1215,"open_issues":147,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/2388"},"html":{"href":"https://github.com/PX4/Firmware/pull/2388"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/2388"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/2388/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/2388/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/2388/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/38fec795eff582e7830f4119ba5e0bd1bca2bff0"}}}}