{"action":"closed","number":1106,"pull_request":{"url":"https://api.github.com/repos/riot/riot/pulls/1106","id":41941745,"html_url":"https://github.com/riot/riot/pull/1106","diff_url":"https://github.com/riot/riot/pull/1106.diff","patch_url":"https://github.com/riot/riot/pull/1106.patch","issue_url":"https://api.github.com/repos/riot/riot/issues/1106","number":1106,"state":"closed","locked":false,"title":"Changed yieldReplace regex guards to be more specific","user":{"login":"davidtai","id":8346495,"avatar_url":"https://avatars.githubusercontent.com/u/8346495?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtai","html_url":"https://github.com/davidtai","followers_url":"https://api.github.com/users/davidtai/followers","following_url":"https://api.github.com/users/davidtai/following{/other_user}","gists_url":"https://api.github.com/users/davidtai/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtai/subscriptions","organizations_url":"https://api.github.com/users/davidtai/orgs","repos_url":"https://api.github.com/users/davidtai/repos","events_url":"https://api.github.com/users/davidtai/events{/privacy}","received_events_url":"https://api.github.com/users/davidtai/received_events","type":"User","site_admin":false},"body":"We are an e-commerce platform rebuilding our UI.  We integrate with stripe.  Since stripe contains the substring 'tr', your overly permissive regex expressions prevents use from naming any tags with the word 'stripe' in it.\r\n\r\nI added first and last character checks in your regex for the ignored tagNames to fix this.","created_at":"2015-08-07T23:15:56Z","updated_at":"2015-08-08T23:18:50Z","closed_at":"2015-08-08T23:18:49Z","merged_at":null,"merge_commit_sha":"84527fb5730d6126e2063b6fa1f29b0304755b1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/riot/riot/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/riot/riot/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/riot/riot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riot/riot/issues/1106/comments","statuses_url":"https://api.github.com/repos/riot/riot/statuses/ff3c9ae91e76f7010af4bceaacb4b0d324eb60fe","head":{"label":"crowdstart:master","ref":"master","sha":"ff3c9ae91e76f7010af4bceaacb4b0d324eb60fe","user":{"login":"crowdstart","id":10950175,"avatar_url":"https://avatars.githubusercontent.com/u/10950175?v=3","gravatar_id":"","url":"https://api.github.com/users/crowdstart","html_url":"https://github.com/crowdstart","followers_url":"https://api.github.com/users/crowdstart/followers","following_url":"https://api.github.com/users/crowdstart/following{/other_user}","gists_url":"https://api.github.com/users/crowdstart/gists{/gist_id}","starred_url":"https://api.github.com/users/crowdstart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowdstart/subscriptions","organizations_url":"https://api.github.com/users/crowdstart/orgs","repos_url":"https://api.github.com/users/crowdstart/repos","events_url":"https://api.github.com/users/crowdstart/events{/privacy}","received_events_url":"https://api.github.com/users/crowdstart/received_events","type":"Organization","site_admin":false},"repo":{"id":40382265,"name":"riot","full_name":"crowdstart/riot","owner":{"login":"crowdstart","id":10950175,"avatar_url":"https://avatars.githubusercontent.com/u/10950175?v=3","gravatar_id":"","url":"https://api.github.com/users/crowdstart","html_url":"https://github.com/crowdstart","followers_url":"https://api.github.com/users/crowdstart/followers","following_url":"https://api.github.com/users/crowdstart/following{/other_user}","gists_url":"https://api.github.com/users/crowdstart/gists{/gist_id}","starred_url":"https://api.github.com/users/crowdstart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowdstart/subscriptions","organizations_url":"https://api.github.com/users/crowdstart/orgs","repos_url":"https://api.github.com/users/crowdstart/repos","events_url":"https://api.github.com/users/crowdstart/events{/privacy}","received_events_url":"https://api.github.com/users/crowdstart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowdstart/riot","description":"A React-like, user interface library","fork":true,"url":"https://api.github.com/repos/crowdstart/riot","forks_url":"https://api.github.com/repos/crowdstart/riot/forks","keys_url":"https://api.github.com/repos/crowdstart/riot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowdstart/riot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowdstart/riot/teams","hooks_url":"https://api.github.com/repos/crowdstart/riot/hooks","issue_events_url":"https://api.github.com/repos/crowdstart/riot/issues/events{/number}","events_url":"https://api.github.com/repos/crowdstart/riot/events","assignees_url":"https://api.github.com/repos/crowdstart/riot/assignees{/user}","branches_url":"https://api.github.com/repos/crowdstart/riot/branches{/branch}","tags_url":"https://api.github.com/repos/crowdstart/riot/tags","blobs_url":"https://api.github.com/repos/crowdstart/riot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowdstart/riot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowdstart/riot/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowdstart/riot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowdstart/riot/statuses/{sha}","languages_url":"https://api.github.com/repos/crowdstart/riot/languages","stargazers_url":"https://api.github.com/repos/crowdstart/riot/stargazers","contributors_url":"https://api.github.com/repos/crowdstart/riot/contributors","subscribers_url":"https://api.github.com/repos/crowdstart/riot/subscribers","subscription_url":"https://api.github.com/repos/crowdstart/riot/subscription","commits_url":"https://api.github.com/repos/crowdstart/riot/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowdstart/riot/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowdstart/riot/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowdstart/riot/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowdstart/riot/contents/{+path}","compare_url":"https://api.github.com/repos/crowdstart/riot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowdstart/riot/merges","archive_url":"https://api.github.com/repos/crowdstart/riot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowdstart/riot/downloads","issues_url":"https://api.github.com/repos/crowdstart/riot/issues{/number}","pulls_url":"https://api.github.com/repos/crowdstart/riot/pulls{/number}","milestones_url":"https://api.github.com/repos/crowdstart/riot/milestones{/number}","notifications_url":"https://api.github.com/repos/crowdstart/riot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowdstart/riot/labels{/name}","releases_url":"https://api.github.com/repos/crowdstart/riot/releases{/id}","created_at":"2015-08-07T21:49:26Z","updated_at":"2015-08-07T21:49:28Z","pushed_at":"2015-08-07T22:38:44Z","git_url":"git://github.com/crowdstart/riot.git","ssh_url":"git@github.com:crowdstart/riot.git","clone_url":"https://github.com/crowdstart/riot.git","svn_url":"https://github.com/crowdstart/riot","homepage":"https://muut.com/riotjs/","size":7095,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riot:master","ref":"master","sha":"c6e05fca13ff9ba83f4762568328ffb91d29a81e","user":{"login":"riot","id":12729373,"avatar_url":"https://avatars.githubusercontent.com/u/12729373?v=3","gravatar_id":"","url":"https://api.github.com/users/riot","html_url":"https://github.com/riot","followers_url":"https://api.github.com/users/riot/followers","following_url":"https://api.github.com/users/riot/following{/other_user}","gists_url":"https://api.github.com/users/riot/gists{/gist_id}","starred_url":"https://api.github.com/users/riot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot/subscriptions","organizations_url":"https://api.github.com/users/riot/orgs","repos_url":"https://api.github.com/users/riot/repos","events_url":"https://api.github.com/users/riot/events{/privacy}","received_events_url":"https://api.github.com/users/riot/received_events","type":"Organization","site_admin":false},"repo":{"id":13142126,"name":"riot","full_name":"riot/riot","owner":{"login":"riot","id":12729373,"avatar_url":"https://avatars.githubusercontent.com/u/12729373?v=3","gravatar_id":"","url":"https://api.github.com/users/riot","html_url":"https://github.com/riot","followers_url":"https://api.github.com/users/riot/followers","following_url":"https://api.github.com/users/riot/following{/other_user}","gists_url":"https://api.github.com/users/riot/gists{/gist_id}","starred_url":"https://api.github.com/users/riot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot/subscriptions","organizations_url":"https://api.github.com/users/riot/orgs","repos_url":"https://api.github.com/users/riot/repos","events_url":"https://api.github.com/users/riot/events{/privacy}","received_events_url":"https://api.github.com/users/riot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riot/riot","description":"A React-like, user interface library","fork":false,"url":"https://api.github.com/repos/riot/riot","forks_url":"https://api.github.com/repos/riot/riot/forks","keys_url":"https://api.github.com/repos/riot/riot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riot/riot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riot/riot/teams","hooks_url":"https://api.github.com/repos/riot/riot/hooks","issue_events_url":"https://api.github.com/repos/riot/riot/issues/events{/number}","events_url":"https://api.github.com/repos/riot/riot/events","assignees_url":"https://api.github.com/repos/riot/riot/assignees{/user}","branches_url":"https://api.github.com/repos/riot/riot/branches{/branch}","tags_url":"https://api.github.com/repos/riot/riot/tags","blobs_url":"https://api.github.com/repos/riot/riot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riot/riot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riot/riot/git/refs{/sha}","trees_url":"https://api.github.com/repos/riot/riot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riot/riot/statuses/{sha}","languages_url":"https://api.github.com/repos/riot/riot/languages","stargazers_url":"https://api.github.com/repos/riot/riot/stargazers","contributors_url":"https://api.github.com/repos/riot/riot/contributors","subscribers_url":"https://api.github.com/repos/riot/riot/subscribers","subscription_url":"https://api.github.com/repos/riot/riot/subscription","commits_url":"https://api.github.com/repos/riot/riot/commits{/sha}","git_commits_url":"https://api.github.com/repos/riot/riot/git/commits{/sha}","comments_url":"https://api.github.com/repos/riot/riot/comments{/number}","issue_comment_url":"https://api.github.com/repos/riot/riot/issues/comments{/number}","contents_url":"https://api.github.com/repos/riot/riot/contents/{+path}","compare_url":"https://api.github.com/repos/riot/riot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riot/riot/merges","archive_url":"https://api.github.com/repos/riot/riot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riot/riot/downloads","issues_url":"https://api.github.com/repos/riot/riot/issues{/number}","pulls_url":"https://api.github.com/repos/riot/riot/pulls{/number}","milestones_url":"https://api.github.com/repos/riot/riot/milestones{/number}","notifications_url":"https://api.github.com/repos/riot/riot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riot/riot/labels{/name}","releases_url":"https://api.github.com/repos/riot/riot/releases{/id}","created_at":"2013-09-27T05:21:01Z","updated_at":"2015-08-08T20:18:17Z","pushed_at":"2015-08-08T20:05:14Z","git_url":"git://github.com/riot/riot.git","ssh_url":"git@github.com:riot/riot.git","clone_url":"https://github.com/riot/riot.git","svn_url":"https://github.com/riot/riot","homepage":"https://muut.com/riotjs/","size":7095,"stargazers_count":6999,"watchers_count":6999,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":596,"mirror_url":null,"open_issues_count":107,"forks":596,"open_issues":107,"watchers":6999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riot/riot/pulls/1106"},"html":{"href":"https://github.com/riot/riot/pull/1106"},"issue":{"href":"https://api.github.com/repos/riot/riot/issues/1106"},"comments":{"href":"https://api.github.com/repos/riot/riot/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/riot/riot/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/riot/riot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riot/riot/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/riot/riot/statuses/ff3c9ae91e76f7010af4bceaacb4b0d324eb60fe"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":2}}