{"action":"created","issue":{"url":"https://api.github.com/repos/valhalla/mjolnir/issues/287","labels_url":"https://api.github.com/repos/valhalla/mjolnir/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/valhalla/mjolnir/issues/287/comments","events_url":"https://api.github.com/repos/valhalla/mjolnir/issues/287/events","html_url":"https://github.com/valhalla/mjolnir/pull/287","id":98237384,"number":287,"title":"Add Elevation Factor to Edges","user":{"login":"kevinkreiser","id":697548,"avatar_url":"https://avatars.githubusercontent.com/u/697548?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkreiser","html_url":"https://github.com/kevinkreiser","followers_url":"https://api.github.com/users/kevinkreiser/followers","following_url":"https://api.github.com/users/kevinkreiser/following{/other_user}","gists_url":"https://api.github.com/users/kevinkreiser/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkreiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkreiser/subscriptions","organizations_url":"https://api.github.com/users/kevinkreiser/orgs","repos_url":"https://api.github.com/users/kevinkreiser/repos","events_url":"https://api.github.com/users/kevinkreiser/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkreiser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-30T18:53:20Z","updated_at":"2015-08-20T19:41:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/valhalla/mjolnir/pulls/287","html_url":"https://github.com/valhalla/mjolnir/pull/287","diff_url":"https://github.com/valhalla/mjolnir/pull/287.diff","patch_url":"https://github.com/valhalla/mjolnir/pull/287.patch"},"body":"~10-15% speed up with less shape access\r\n\r\nthe speed up is just for the initial tile writing phase. the rest of the process is unchanged in terms of performance (since i didnt touch it)\r\n\r\nthis is part 1 of a 2 part pr series to enable elevation querying at tile building time. the first step involves making sure we only ever look at shape when we absolutely need too. it turned out we were looking at the shape every time to get things like length (elevation and curvature to come) and the tiles that the shape cross (for connectivity map purposes). at any rate we now cache this information so that when we encounter the other directed_edge we look it up in a hash map.\r\n\r\nin addition to all this i added the skadi dep to mjolnir so it can use it to get at elevation data\r\n\r\nsince it hasnt been merge we now have part 2. which actually adds the elevation querying. i'll do some testing to see how much this adds back to building initial tiles.\r\n\r\nNOTE: this also contains a bunch of log clean up because i couldnt take it anymore"},"comment":{"url":"https://api.github.com/repos/valhalla/mjolnir/issues/comments/133149299","html_url":"https://github.com/valhalla/mjolnir/pull/287#issuecomment-133149299","issue_url":"https://api.github.com/repos/valhalla/mjolnir/issues/287","id":133149299,"user":{"login":"dnesbitt61","id":1838768,"avatar_url":"https://avatars.githubusercontent.com/u/1838768?v=3","gravatar_id":"","url":"https://api.github.com/users/dnesbitt61","html_url":"https://github.com/dnesbitt61","followers_url":"https://api.github.com/users/dnesbitt61/followers","following_url":"https://api.github.com/users/dnesbitt61/following{/other_user}","gists_url":"https://api.github.com/users/dnesbitt61/gists{/gist_id}","starred_url":"https://api.github.com/users/dnesbitt61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnesbitt61/subscriptions","organizations_url":"https://api.github.com/users/dnesbitt61/orgs","repos_url":"https://api.github.com/users/dnesbitt61/repos","events_url":"https://api.github.com/users/dnesbitt61/events{/privacy}","received_events_url":"https://api.github.com/users/dnesbitt61/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T19:41:05Z","updated_at":"2015-08-20T19:41:05Z","body":":shipit: "}}