{"action":"created","comment":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments/33014146","id":33014146,"diff_hunk":"@@ -54,23 +55,25 @@ export default Ember.Mixin.create({\n     @private\n   */\n   beforeModel(transition) {\n-    this._super(transition);\n-    if (!this.get('_authEventListenersAssigned')) {\n-      this.set('_authEventListenersAssigned', true);\n-      Ember.A([\n-        'sessionAuthenticationSucceeded',\n-        'sessionAuthenticationFailed',\n-        'sessionInvalidationSucceeded',\n-        'sessionInvalidationFailed',\n-        'authorizationFailed'\n-      ]).forEach((event) => {\n-        this.get(Configuration.base.sessionPropertyName).on(event, Ember.run.bind(this, function() {\n-          Array.prototype.unshift.call(arguments, event);\n-          let target = routeEntryComplete ? this : transition;\n-          target.send.apply(target, arguments);\n-        }));\n-      });\n-    }\n+    setup(this.container).finally(() => {\n+      this._super(transition);\n+      if (!this.get('_authEventListenersAssigned')) {","path":"addon/mixins/application-route-mixin.js","position":30,"original_position":30,"commit_id":"9bf272f51469d5bdefdfc51f4ce2355ec2fa84eb","original_commit_id":"9bf272f51469d5bdefdfc51f4ce2355ec2fa84eb","user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"body":"Is this still necessary then?","created_at":"2015-06-23T06:55:18Z","updated_at":"2015-06-23T06:55:18Z","html_url":"https://github.com/simplabs/ember-simple-auth/pull/564#discussion_r33014146","pull_request_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564","_links":{"self":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments/33014146"},"html":{"href":"https://github.com/simplabs/ember-simple-auth/pull/564#discussion_r33014146"},"pull_request":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564"}}},"pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564","id":38275329,"html_url":"https://github.com/simplabs/ember-simple-auth/pull/564","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/564.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/564.patch","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/564","number":564,"state":"open","locked":false,"title":"ember-cli-addon - split initializer","user":{"login":"Jakeii","id":1731150,"avatar_url":"https://avatars.githubusercontent.com/u/1731150?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakeii","html_url":"https://github.com/Jakeii","followers_url":"https://api.github.com/users/Jakeii/followers","following_url":"https://api.github.com/users/Jakeii/following{/other_user}","gists_url":"https://api.github.com/users/Jakeii/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakeii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakeii/subscriptions","organizations_url":"https://api.github.com/users/Jakeii/orgs","repos_url":"https://api.github.com/users/Jakeii/repos","events_url":"https://api.github.com/users/Jakeii/events{/privacy}","received_events_url":"https://api.github.com/users/Jakeii/received_events","type":"User","site_admin":false},"body":"Hopefully this should be the last of the initializer pulls! Targets the ember-cli-addon branch.\r\n\r\nAs per https://github.com/emberjs/ember.js/pull/10256#issuecomment-113846021, it no longer relies on `deferRediness`, and incorporates most of the setup into the `ApplicationRouteMixin.beforeModel` method.\r\n\r\nThe `initializer` now only registers the stores/session, and `instanceInitializer` now only injects `session` into components, controllers, routes.","created_at":"2015-06-22T20:54:07Z","updated_at":"2015-06-23T06:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"650e40aa68ddd3ffebd5899df6c887d92496a547","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564/commits","review_comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564/comments","review_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/564/comments","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/9bf272f51469d5bdefdfc51f4ce2355ec2fa84eb","head":{"label":"Jakeii:ember-cli-addon-initializer-rework","ref":"ember-cli-addon-initializer-rework","sha":"9bf272f51469d5bdefdfc51f4ce2355ec2fa84eb","user":{"login":"Jakeii","id":1731150,"avatar_url":"https://avatars.githubusercontent.com/u/1731150?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakeii","html_url":"https://github.com/Jakeii","followers_url":"https://api.github.com/users/Jakeii/followers","following_url":"https://api.github.com/users/Jakeii/following{/other_user}","gists_url":"https://api.github.com/users/Jakeii/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakeii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakeii/subscriptions","organizations_url":"https://api.github.com/users/Jakeii/orgs","repos_url":"https://api.github.com/users/Jakeii/repos","events_url":"https://api.github.com/users/Jakeii/events{/privacy}","received_events_url":"https://api.github.com/users/Jakeii/received_events","type":"User","site_admin":false},"repo":{"id":36087491,"name":"ember-simple-auth","full_name":"Jakeii/ember-simple-auth","owner":{"login":"Jakeii","id":1731150,"avatar_url":"https://avatars.githubusercontent.com/u/1731150?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakeii","html_url":"https://github.com/Jakeii","followers_url":"https://api.github.com/users/Jakeii/followers","following_url":"https://api.github.com/users/Jakeii/following{/other_user}","gists_url":"https://api.github.com/users/Jakeii/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakeii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakeii/subscriptions","organizations_url":"https://api.github.com/users/Jakeii/orgs","repos_url":"https://api.github.com/users/Jakeii/repos","events_url":"https://api.github.com/users/Jakeii/events{/privacy}","received_events_url":"https://api.github.com/users/Jakeii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jakeii/ember-simple-auth","description":"A lightweight library for implementing authentication/authorization in Ember.js applications.","fork":true,"url":"https://api.github.com/repos/Jakeii/ember-simple-auth","forks_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/Jakeii/ember-simple-auth/releases{/id}","created_at":"2015-05-22T18:01:43Z","updated_at":"2015-05-22T18:01:44Z","pushed_at":"2015-06-22T19:59:59Z","git_url":"git://github.com/Jakeii/ember-simple-auth.git","ssh_url":"git@github.com:Jakeii/ember-simple-auth.git","clone_url":"https://github.com/Jakeii/ember-simple-auth.git","svn_url":"https://github.com/Jakeii/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":5534,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simplabs:ember-cli-addon","ref":"ember-cli-addon","sha":"9897ceecce2f6df8076a960fbb3b1d489ad42509","user":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12570984,"name":"ember-simple-auth","full_name":"simplabs/ember-simple-auth","owner":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplabs/ember-simple-auth","description":"A lightweight library for implementing authentication/authorization in Ember.js applications.","fork":false,"url":"https://api.github.com/repos/simplabs/ember-simple-auth","forks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/simplabs/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplabs/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplabs/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/simplabs/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/simplabs/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/simplabs/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplabs/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/simplabs/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplabs/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/simplabs/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/simplabs/ember-simple-auth/releases{/id}","created_at":"2013-09-03T18:03:26Z","updated_at":"2015-06-22T14:59:09Z","pushed_at":"2015-06-22T20:54:08Z","git_url":"git://github.com/simplabs/ember-simple-auth.git","ssh_url":"git@github.com:simplabs/ember-simple-auth.git","clone_url":"https://github.com/simplabs/ember-simple-auth.git","svn_url":"https://github.com/simplabs/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":8498,"stargazers_count":1003,"watchers_count":1003,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":206,"mirror_url":null,"open_issues_count":23,"forks":206,"open_issues":23,"watchers":1003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564"},"html":{"href":"https://github.com/simplabs/ember-simple-auth/pull/564"},"issue":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/564"},"comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/9bf272f51469d5bdefdfc51f4ce2355ec2fa84eb"}}}}