{"action":"created","issue":{"url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/39","labels_url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/39/comments","events_url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/39/events","html_url":"https://github.com/bitpay/bitcore-mnemonic/pull/39","id":108650260,"number":39,"title":"[BUGFIX] Fix major utf8 bug","user":{"login":"dabura667","id":6586275,"avatar_url":"https://avatars.githubusercontent.com/u/6586275?v=3","gravatar_id":"","url":"https://api.github.com/users/dabura667","html_url":"https://github.com/dabura667","followers_url":"https://api.github.com/users/dabura667/followers","following_url":"https://api.github.com/users/dabura667/following{/other_user}","gists_url":"https://api.github.com/users/dabura667/gists{/gist_id}","starred_url":"https://api.github.com/users/dabura667/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabura667/subscriptions","organizations_url":"https://api.github.com/users/dabura667/orgs","repos_url":"https://api.github.com/users/dabura667/repos","events_url":"https://api.github.com/users/dabura667/events{/privacy}","received_events_url":"https://api.github.com/users/dabura667/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-09-28T12:44:18Z","updated_at":"2015-10-04T01:03:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/pulls/39","html_url":"https://github.com/bitpay/bitcore-mnemonic/pull/39","diff_url":"https://github.com/bitpay/bitcore-mnemonic/pull/39.diff","patch_url":"https://github.com/bitpay/bitcore-mnemonic/pull/39.patch"},"body":"The bug currently causes all non-ascii mnemonic/salts to deviate from other libraries (as seen in my Add jp tests pull request)\r\n\r\nThis is dependent on the environment of the user, which is why Copay is working but my node client is not.\r\n\r\nCopay interprets the Japanese as UTF8 bytes after normalization.\r\nHowever, my system is using codepage 932 (shift-jis) so even after running through unorm, my system generates shift-jis bytes of the normalized string instead of utf8...\r\n\r\nusing Buffer to convert to utf8 bytes will guarantee that it is used in the pbkdf as utf8 bytes."},"comment":{"url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/comments/145303843","html_url":"https://github.com/bitpay/bitcore-mnemonic/pull/39#issuecomment-145303843","issue_url":"https://api.github.com/repos/bitpay/bitcore-mnemonic/issues/39","id":145303843,"user":{"login":"dabura667","id":6586275,"avatar_url":"https://avatars.githubusercontent.com/u/6586275?v=3","gravatar_id":"","url":"https://api.github.com/users/dabura667","html_url":"https://github.com/dabura667","followers_url":"https://api.github.com/users/dabura667/followers","following_url":"https://api.github.com/users/dabura667/following{/other_user}","gists_url":"https://api.github.com/users/dabura667/gists{/gist_id}","starred_url":"https://api.github.com/users/dabura667/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabura667/subscriptions","organizations_url":"https://api.github.com/users/dabura667/orgs","repos_url":"https://api.github.com/users/dabura667/repos","events_url":"https://api.github.com/users/dabura667/events{/privacy}","received_events_url":"https://api.github.com/users/dabura667/received_events","type":"User","site_admin":false},"created_at":"2015-10-04T01:02:59Z","updated_at":"2015-10-04T01:02:59Z","body":"Ping @matiu @braydonf \r\n\r\nIs this ok for merging?"}}