{"action":"created","issue":{"url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/2","labels_url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/2/comments","events_url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/2/events","html_url":"https://github.com/haskell-infra/phab-ghc-builder/pull/2","id":92901881,"number":2,"title":"Allow arc patch to update submodules","user":{"login":"adamse","id":75746,"avatar_url":"https://avatars.githubusercontent.com/u/75746?v=3","gravatar_id":"","url":"https://api.github.com/users/adamse","html_url":"https://github.com/adamse","followers_url":"https://api.github.com/users/adamse/followers","following_url":"https://api.github.com/users/adamse/following{/other_user}","gists_url":"https://api.github.com/users/adamse/gists{/gist_id}","starred_url":"https://api.github.com/users/adamse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamse/subscriptions","organizations_url":"https://api.github.com/users/adamse/orgs","repos_url":"https://api.github.com/users/adamse/repos","events_url":"https://api.github.com/users/adamse/events{/privacy}","received_events_url":"https://api.github.com/users/adamse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-03T16:03:58Z","updated_at":"2015-07-18T21:09:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/pulls/2","html_url":"https://github.com/haskell-infra/phab-ghc-builder/pull/2","diff_url":"https://github.com/haskell-infra/phab-ghc-builder/pull/2.diff","patch_url":"https://github.com/haskell-infra/phab-ghc-builder/pull/2.patch"},"body":"By not init'ing and update'ing submodules arc patch does the work and\r\nthus updates to submodules, including changes to submodule urls, will\r\nwork smoothely.\r\n\r\n---\r\n\r\nTested by applying https://phabricator.haskell.org/D1033 in two different ways: (since I have no local phab install)\r\n\r\nAs the run.sh script currently does\r\n~~~\r\ngit clone GHC\r\ngit submodule init\r\ngit submodule update\r\narch patch D1033\r\n~~~\r\n\r\nWhich fails with\r\n~~~\r\n...\r\nApplied patch .gitmodules cleanly.\r\nfatal: reference is not a tree: b18d17fc2bbafc6e8576764df8cf299b26fb1835\r\nUnable to checkout 'b18d17fc2bbafc6e8576764df8cf299b26fb1835' in submodule path 'utils/haddock'\r\n~~~\r\n\r\nAnd the updated way:\r\n\r\n~~~\r\ngit clone GHC\r\narc patch D1033\r\n~~~\r\n\r\nHere `arc patch` applies the patch, and then init's and update's the submodules, which makes everything work out OK."},"comment":{"url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/comments/122597231","html_url":"https://github.com/haskell-infra/phab-ghc-builder/pull/2#issuecomment-122597231","issue_url":"https://api.github.com/repos/haskell-infra/phab-ghc-builder/issues/2","id":122597231,"user":{"login":"thoughtpolice","id":3416,"avatar_url":"https://avatars.githubusercontent.com/u/3416?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtpolice","html_url":"https://github.com/thoughtpolice","followers_url":"https://api.github.com/users/thoughtpolice/followers","following_url":"https://api.github.com/users/thoughtpolice/following{/other_user}","gists_url":"https://api.github.com/users/thoughtpolice/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtpolice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtpolice/subscriptions","organizations_url":"https://api.github.com/users/thoughtpolice/orgs","repos_url":"https://api.github.com/users/thoughtpolice/repos","events_url":"https://api.github.com/users/thoughtpolice/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtpolice/received_events","type":"User","site_admin":false},"created_at":"2015-07-18T21:09:46Z","updated_at":"2015-07-18T21:09:46Z","body":"LGTM."}}