{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/24649058","id":24649058,"diff_hunk":"@@ -202,10 +203,37 @@\n       command \"ovs-vsctl add-br #{name}; ip link set #{name} up\"\n       not_if \"ovs-vsctl list-br |grep -q #{name}\"\n     end\n-    execute \"Neutron: add #{bound_if} to #{name}\" do\n-      command \"ovs-vsctl del-port #{name} #{bound_if} ; ovs-vsctl add-port #{name} #{bound_if}\"\n-      not_if \"ovs-dpctl show system@#{name} | grep -q #{bound_if}\"\n+\n+    # If:\n+    #   * this network is on the same physical interface as the admin network\n+    #   * we're running in HA mode\n+    #   * corosync is configured to use multicast networking\n+    # We need to stop openais/corosync before moving the network interface\n+    # into the openvswitch. Otherwise we'll break corosync's multicast\n+    # communication and cause fencing.\n+    # For details: https://bugzilla.suse.com/show_bug.cgi?id=915176\n+    if (node[:crowbar_wall][:network][:nets][\"admin\"].last == bound_if &&\n+        neutron_l3_ha && node[:corosync][:transport] == \"udp\" )\n+\n+      # Put the whole cluster into maintenance mode before shutting down\n+      # corosync. As this operation affects all cluster nodes only do it on\n+      # the founder.\n+      if (CrowbarPacemakerHelper.is_cluster_founder?(node))\n+        execute \"enable maintenance mode\" do\n+          command \"crm --wait configure property maintenance-mode=true\"","path":"chef/cookbooks/neutron/recipes/common_agent.rb","position":32,"original_position":32,"commit_id":"5688fded86588b90e3160c80ec907f56749402f9","original_commit_id":"5688fded86588b90e3160c80ec907f56749402f9","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"Ah, ok, thanks!","created_at":"2015-02-13T07:58:11Z","updated_at":"2015-02-13T07:58:11Z","html_url":"https://github.com/crowbar/barclamp-neutron/pull/194#discussion_r24649058","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/24649058"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/194#discussion_r24649058"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194","id":29190154,"html_url":"https://github.com/crowbar/barclamp-neutron/pull/194","diff_url":"https://github.com/crowbar/barclamp-neutron/pull/194.diff","patch_url":"https://github.com/crowbar/barclamp-neutron/pull/194.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/194","number":194,"state":"open","locked":false,"title":"[WIP] Restart pacemaker when needed on the l3-node (bnc#915176)","user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"body":"When the admin network and the \"public\" or \"nova_fixed\" networks are using the\r\nsame physical interface, we need to take care to stop the pacemaker services\r\nbefore enslaving the interface into the newly created openvswitch bridge and to\r\ncleanly restarted afterwards.\r\n\r\nhttps://bugzilla.suse.com/show_bug.cgi?id=915176","created_at":"2015-02-12T15:54:30Z","updated_at":"2015-02-13T07:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3acfd166c3a70b05fd5bf19329b262dd8315dfdb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/194/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/5688fded86588b90e3160c80ec907f56749402f9","head":{"label":"rhafer:corosync-restart","ref":"corosync-restart","sha":"5688fded86588b90e3160c80ec907f56749402f9","user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"repo":{"id":13743611,"name":"barclamp-neutron","full_name":"rhafer/barclamp-neutron","owner":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhafer/barclamp-neutron","description":"Neutron ","fork":true,"url":"https://api.github.com/repos/rhafer/barclamp-neutron","forks_url":"https://api.github.com/repos/rhafer/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/rhafer/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhafer/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhafer/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/rhafer/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/rhafer/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/rhafer/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/rhafer/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/rhafer/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhafer/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/rhafer/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/rhafer/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/rhafer/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/rhafer/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/rhafer/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/rhafer/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhafer/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhafer/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/rhafer/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhafer/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/rhafer/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhafer/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/rhafer/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/rhafer/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhafer/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/rhafer/barclamp-neutron/releases{/id}","created_at":"2013-10-21T13:44:12Z","updated_at":"2014-06-25T09:31:34Z","pushed_at":"2015-02-12T15:53:50Z","git_url":"git://github.com/rhafer/barclamp-neutron.git","ssh_url":"git@github.com:rhafer/barclamp-neutron.git","clone_url":"https://github.com/rhafer/barclamp-neutron.git","svn_url":"https://github.com/rhafer/barclamp-neutron","homepage":null,"size":1475,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"d06a3a163a21e1cbd970469d6d78449dea8a573c","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":13688641,"name":"barclamp-neutron","full_name":"crowbar/barclamp-neutron","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-neutron","description":"OpenStack Neutron: Networking component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-neutron","forks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-neutron/releases{/id}","created_at":"2013-10-18T20:39:52Z","updated_at":"2015-02-12T21:01:42Z","pushed_at":"2015-02-12T21:01:41Z","git_url":"git://github.com/crowbar/barclamp-neutron.git","ssh_url":"git@github.com:crowbar/barclamp-neutron.git","clone_url":"https://github.com/crowbar/barclamp-neutron.git","svn_url":"https://github.com/crowbar/barclamp-neutron","homepage":"https://github.com/crowbar/crowbar","size":2990,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":7,"forks":69,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/194"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/194"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/5688fded86588b90e3160c80ec907f56749402f9"}}}}