{"action":"opened","number":125,"pull_request":{"url":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125","id":36124112,"html_url":"https://github.com/ray-di/Ray.Di/pull/125","diff_url":"https://github.com/ray-di/Ray.Di/pull/125.diff","patch_url":"https://github.com/ray-di/Ray.Di/pull/125.patch","issue_url":"https://api.github.com/repos/ray-di/Ray.Di/issues/125","number":125,"state":"open","locked":false,"title":"fix concrete class binding issue","user":{"login":"koriym","id":529021,"avatar_url":"https://avatars.githubusercontent.com/u/529021?v=3","gravatar_id":"","url":"https://api.github.com/users/koriym","html_url":"https://github.com/koriym","followers_url":"https://api.github.com/users/koriym/followers","following_url":"https://api.github.com/users/koriym/following{/other_user}","gists_url":"https://api.github.com/users/koriym/gists{/gist_id}","starred_url":"https://api.github.com/users/koriym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriym/subscriptions","organizations_url":"https://api.github.com/users/koriym/orgs","repos_url":"https://api.github.com/users/koriym/repos","events_url":"https://api.github.com/users/koriym/events{/privacy}","received_events_url":"https://api.github.com/users/koriym/received_events","type":"User","site_admin":false},"body":"This binding can be problematic when concrete `Untarget` class can't resolve dependencies without `UntargetProvider`.\r\n\r\n```\r\n$thi->bind(Untarget::class)->toProvider(UntargetProvider::class);\r\n```\r\n\r\nBecause `Untarget::class` is registered to `Container` even it has it has `toProvider` later. (This is because `Ray.Di` DSL does not have termination method.)\r\n\r\nThis PR change to `untarget binding` at `Bind::__destruct()`. It worked like as terminate method.\r\n\r\nGreat cooperation with Toshinai san, Arigato gozaimasu !","created_at":"2015-05-25T08:13:43Z","updated_at":"2015-05-25T08:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125/commits","review_comments_url":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125/comments","review_comment_url":"https://api.github.com/repos/ray-di/Ray.Di/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-di/Ray.Di/issues/125/comments","statuses_url":"https://api.github.com/repos/ray-di/Ray.Di/statuses/1fe616c4f53fe2b60bbf762f2927127826d05e21","head":{"label":"koriym:untarget","ref":"untarget","sha":"1fe616c4f53fe2b60bbf762f2927127826d05e21","user":{"login":"koriym","id":529021,"avatar_url":"https://avatars.githubusercontent.com/u/529021?v=3","gravatar_id":"","url":"https://api.github.com/users/koriym","html_url":"https://github.com/koriym","followers_url":"https://api.github.com/users/koriym/followers","following_url":"https://api.github.com/users/koriym/following{/other_user}","gists_url":"https://api.github.com/users/koriym/gists{/gist_id}","starred_url":"https://api.github.com/users/koriym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriym/subscriptions","organizations_url":"https://api.github.com/users/koriym/orgs","repos_url":"https://api.github.com/users/koriym/repos","events_url":"https://api.github.com/users/koriym/events{/privacy}","received_events_url":"https://api.github.com/users/koriym/received_events","type":"User","site_admin":false},"repo":{"id":33782434,"name":"Ray.Di","full_name":"koriym/Ray.Di","owner":{"login":"koriym","id":529021,"avatar_url":"https://avatars.githubusercontent.com/u/529021?v=3","gravatar_id":"","url":"https://api.github.com/users/koriym","html_url":"https://github.com/koriym","followers_url":"https://api.github.com/users/koriym/followers","following_url":"https://api.github.com/users/koriym/following{/other_user}","gists_url":"https://api.github.com/users/koriym/gists{/gist_id}","starred_url":"https://api.github.com/users/koriym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriym/subscriptions","organizations_url":"https://api.github.com/users/koriym/orgs","repos_url":"https://api.github.com/users/koriym/repos","events_url":"https://api.github.com/users/koriym/events{/privacy}","received_events_url":"https://api.github.com/users/koriym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koriym/Ray.Di","description":"Guice style dependency injection framework for PHP","fork":true,"url":"https://api.github.com/repos/koriym/Ray.Di","forks_url":"https://api.github.com/repos/koriym/Ray.Di/forks","keys_url":"https://api.github.com/repos/koriym/Ray.Di/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koriym/Ray.Di/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koriym/Ray.Di/teams","hooks_url":"https://api.github.com/repos/koriym/Ray.Di/hooks","issue_events_url":"https://api.github.com/repos/koriym/Ray.Di/issues/events{/number}","events_url":"https://api.github.com/repos/koriym/Ray.Di/events","assignees_url":"https://api.github.com/repos/koriym/Ray.Di/assignees{/user}","branches_url":"https://api.github.com/repos/koriym/Ray.Di/branches{/branch}","tags_url":"https://api.github.com/repos/koriym/Ray.Di/tags","blobs_url":"https://api.github.com/repos/koriym/Ray.Di/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koriym/Ray.Di/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koriym/Ray.Di/git/refs{/sha}","trees_url":"https://api.github.com/repos/koriym/Ray.Di/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koriym/Ray.Di/statuses/{sha}","languages_url":"https://api.github.com/repos/koriym/Ray.Di/languages","stargazers_url":"https://api.github.com/repos/koriym/Ray.Di/stargazers","contributors_url":"https://api.github.com/repos/koriym/Ray.Di/contributors","subscribers_url":"https://api.github.com/repos/koriym/Ray.Di/subscribers","subscription_url":"https://api.github.com/repos/koriym/Ray.Di/subscription","commits_url":"https://api.github.com/repos/koriym/Ray.Di/commits{/sha}","git_commits_url":"https://api.github.com/repos/koriym/Ray.Di/git/commits{/sha}","comments_url":"https://api.github.com/repos/koriym/Ray.Di/comments{/number}","issue_comment_url":"https://api.github.com/repos/koriym/Ray.Di/issues/comments{/number}","contents_url":"https://api.github.com/repos/koriym/Ray.Di/contents/{+path}","compare_url":"https://api.github.com/repos/koriym/Ray.Di/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koriym/Ray.Di/merges","archive_url":"https://api.github.com/repos/koriym/Ray.Di/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koriym/Ray.Di/downloads","issues_url":"https://api.github.com/repos/koriym/Ray.Di/issues{/number}","pulls_url":"https://api.github.com/repos/koriym/Ray.Di/pulls{/number}","milestones_url":"https://api.github.com/repos/koriym/Ray.Di/milestones{/number}","notifications_url":"https://api.github.com/repos/koriym/Ray.Di/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koriym/Ray.Di/labels{/name}","releases_url":"https://api.github.com/repos/koriym/Ray.Di/releases{/id}","created_at":"2015-04-11T16:09:02Z","updated_at":"2015-05-01T10:27:53Z","pushed_at":"2015-05-25T08:02:23Z","git_url":"git://github.com/koriym/Ray.Di.git","ssh_url":"git@github.com:koriym/Ray.Di.git","clone_url":"https://github.com/koriym/Ray.Di.git","svn_url":"https://github.com/koriym/Ray.Di","homepage":"","size":1664,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"2.x"}},"base":{"label":"ray-di:2.x","ref":"2.x","sha":"588ba0c241dee0bcce17e0be17d773bbf8f2fe45","user":{"login":"ray-di","id":10275660,"avatar_url":"https://avatars.githubusercontent.com/u/10275660?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-di","html_url":"https://github.com/ray-di","followers_url":"https://api.github.com/users/ray-di/followers","following_url":"https://api.github.com/users/ray-di/following{/other_user}","gists_url":"https://api.github.com/users/ray-di/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-di/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-di/subscriptions","organizations_url":"https://api.github.com/users/ray-di/orgs","repos_url":"https://api.github.com/users/ray-di/repos","events_url":"https://api.github.com/users/ray-di/events{/privacy}","received_events_url":"https://api.github.com/users/ray-di/received_events","type":"Organization","site_admin":false},"repo":{"id":2129984,"name":"Ray.Di","full_name":"ray-di/Ray.Di","owner":{"login":"ray-di","id":10275660,"avatar_url":"https://avatars.githubusercontent.com/u/10275660?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-di","html_url":"https://github.com/ray-di","followers_url":"https://api.github.com/users/ray-di/followers","following_url":"https://api.github.com/users/ray-di/following{/other_user}","gists_url":"https://api.github.com/users/ray-di/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-di/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-di/subscriptions","organizations_url":"https://api.github.com/users/ray-di/orgs","repos_url":"https://api.github.com/users/ray-di/repos","events_url":"https://api.github.com/users/ray-di/events{/privacy}","received_events_url":"https://api.github.com/users/ray-di/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-di/Ray.Di","description":"Guice style dependency injection framework for PHP","fork":false,"url":"https://api.github.com/repos/ray-di/Ray.Di","forks_url":"https://api.github.com/repos/ray-di/Ray.Di/forks","keys_url":"https://api.github.com/repos/ray-di/Ray.Di/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-di/Ray.Di/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-di/Ray.Di/teams","hooks_url":"https://api.github.com/repos/ray-di/Ray.Di/hooks","issue_events_url":"https://api.github.com/repos/ray-di/Ray.Di/issues/events{/number}","events_url":"https://api.github.com/repos/ray-di/Ray.Di/events","assignees_url":"https://api.github.com/repos/ray-di/Ray.Di/assignees{/user}","branches_url":"https://api.github.com/repos/ray-di/Ray.Di/branches{/branch}","tags_url":"https://api.github.com/repos/ray-di/Ray.Di/tags","blobs_url":"https://api.github.com/repos/ray-di/Ray.Di/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-di/Ray.Di/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-di/Ray.Di/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-di/Ray.Di/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-di/Ray.Di/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-di/Ray.Di/languages","stargazers_url":"https://api.github.com/repos/ray-di/Ray.Di/stargazers","contributors_url":"https://api.github.com/repos/ray-di/Ray.Di/contributors","subscribers_url":"https://api.github.com/repos/ray-di/Ray.Di/subscribers","subscription_url":"https://api.github.com/repos/ray-di/Ray.Di/subscription","commits_url":"https://api.github.com/repos/ray-di/Ray.Di/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-di/Ray.Di/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-di/Ray.Di/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-di/Ray.Di/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-di/Ray.Di/contents/{+path}","compare_url":"https://api.github.com/repos/ray-di/Ray.Di/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-di/Ray.Di/merges","archive_url":"https://api.github.com/repos/ray-di/Ray.Di/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-di/Ray.Di/downloads","issues_url":"https://api.github.com/repos/ray-di/Ray.Di/issues{/number}","pulls_url":"https://api.github.com/repos/ray-di/Ray.Di/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-di/Ray.Di/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-di/Ray.Di/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-di/Ray.Di/labels{/name}","releases_url":"https://api.github.com/repos/ray-di/Ray.Di/releases{/id}","created_at":"2011-07-30T20:01:13Z","updated_at":"2015-05-22T11:05:28Z","pushed_at":"2015-05-24T02:35:00Z","git_url":"git://github.com/ray-di/Ray.Di.git","ssh_url":"git@github.com:ray-di/Ray.Di.git","clone_url":"https://github.com/ray-di/Ray.Di.git","svn_url":"https://github.com/ray-di/Ray.Di","homepage":"","size":3477,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":1,"forks":27,"open_issues":1,"watchers":86,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125"},"html":{"href":"https://github.com/ray-di/Ray.Di/pull/125"},"issue":{"href":"https://api.github.com/repos/ray-di/Ray.Di/issues/125"},"comments":{"href":"https://api.github.com/repos/ray-di/Ray.Di/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-di/Ray.Di/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-di/Ray.Di/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/ray-di/Ray.Di/statuses/1fe616c4f53fe2b60bbf762f2927127826d05e21"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":167,"deletions":35,"changed_files":11}}