{"action":"closed","number":376,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/376","id":48565165,"html_url":"https://github.com/maidsafe/crust/pull/376","diff_url":"https://github.com/maidsafe/crust/pull/376.diff","patch_url":"https://github.com/maidsafe/crust/pull/376.patch","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/376","number":376,"state":"closed","locked":false,"title":"Join threads, release bound sockets on Service::stop ","user":{"login":"madadam","id":5271,"avatar_url":"https://avatars.githubusercontent.com/u/5271?v=3","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"body":"1. Adds join of the `State` thread on `Service::stop`\r\n2. Simplifies acceptor logic (both TCP and UTP) by removing unnecessary threads. This also fixes #361 .\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/376)\n<!-- Reviewable:end -->\n","created_at":"2015-10-23T10:39:06Z","updated_at":"2015-10-23T17:06:40Z","closed_at":"2015-10-23T17:06:40Z","merged_at":"2015-10-23T17:06:40Z","merge_commit_sha":"0b1290459e3295f3e69a6c72802f4a6e85195ede","assignee":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/crust/pulls/376/commits","review_comments_url":"https://api.github.com/repos/maidsafe/crust/pulls/376/comments","review_comment_url":"https://api.github.com/repos/maidsafe/crust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/376/comments","statuses_url":"https://api.github.com/repos/maidsafe/crust/statuses/af272a451f5c090cb50867f5833e3b5e7acfb597","head":{"label":"madadam:issue-361-release-resources-on-stop","ref":"issue-361-release-resources-on-stop","sha":"af272a451f5c090cb50867f5833e3b5e7acfb597","user":{"login":"madadam","id":5271,"avatar_url":"https://avatars.githubusercontent.com/u/5271?v=3","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"repo":{"id":44176004,"name":"crust","full_name":"madadam/crust","owner":{"login":"madadam","id":5271,"avatar_url":"https://avatars.githubusercontent.com/u/5271?v=3","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madadam/crust","description":"Reliable p2p network connections in Rust with NAT traversal. One of the most needed libraries for any server-less / decentralised projects","fork":true,"url":"https://api.github.com/repos/madadam/crust","forks_url":"https://api.github.com/repos/madadam/crust/forks","keys_url":"https://api.github.com/repos/madadam/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madadam/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madadam/crust/teams","hooks_url":"https://api.github.com/repos/madadam/crust/hooks","issue_events_url":"https://api.github.com/repos/madadam/crust/issues/events{/number}","events_url":"https://api.github.com/repos/madadam/crust/events","assignees_url":"https://api.github.com/repos/madadam/crust/assignees{/user}","branches_url":"https://api.github.com/repos/madadam/crust/branches{/branch}","tags_url":"https://api.github.com/repos/madadam/crust/tags","blobs_url":"https://api.github.com/repos/madadam/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madadam/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madadam/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/madadam/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madadam/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/madadam/crust/languages","stargazers_url":"https://api.github.com/repos/madadam/crust/stargazers","contributors_url":"https://api.github.com/repos/madadam/crust/contributors","subscribers_url":"https://api.github.com/repos/madadam/crust/subscribers","subscription_url":"https://api.github.com/repos/madadam/crust/subscription","commits_url":"https://api.github.com/repos/madadam/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/madadam/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/madadam/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/madadam/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/madadam/crust/contents/{+path}","compare_url":"https://api.github.com/repos/madadam/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madadam/crust/merges","archive_url":"https://api.github.com/repos/madadam/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madadam/crust/downloads","issues_url":"https://api.github.com/repos/madadam/crust/issues{/number}","pulls_url":"https://api.github.com/repos/madadam/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/madadam/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/madadam/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madadam/crust/labels{/name}","releases_url":"https://api.github.com/repos/madadam/crust/releases{/id}","created_at":"2015-10-13T12:52:42Z","updated_at":"2015-10-13T12:52:47Z","pushed_at":"2015-10-23T14:37:36Z","git_url":"git://github.com/madadam/crust.git","ssh_url":"git@github.com:madadam/crust.git","clone_url":"https://github.com/madadam/crust.git","svn_url":"https://github.com/madadam/crust","homepage":null,"size":24274,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"cbe5578f4a78e4abc5ca8252bd6d2a8aaac26ae1","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":33324427,"name":"crust","full_name":"maidsafe/crust","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/crust","description":"Reliable p2p network connections in Rust with NAT traversal. One of the most needed libraries for any server-less / decentralised projects","fork":false,"url":"https://api.github.com/repos/maidsafe/crust","forks_url":"https://api.github.com/repos/maidsafe/crust/forks","keys_url":"https://api.github.com/repos/maidsafe/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/crust/teams","hooks_url":"https://api.github.com/repos/maidsafe/crust/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/crust/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/crust/events","assignees_url":"https://api.github.com/repos/maidsafe/crust/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/crust/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/crust/tags","blobs_url":"https://api.github.com/repos/maidsafe/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/crust/languages","stargazers_url":"https://api.github.com/repos/maidsafe/crust/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/crust/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/crust/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/crust/subscription","commits_url":"https://api.github.com/repos/maidsafe/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/crust/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/crust/merges","archive_url":"https://api.github.com/repos/maidsafe/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/crust/downloads","issues_url":"https://api.github.com/repos/maidsafe/crust/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/crust/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/crust/releases{/id}","created_at":"2015-04-02T18:16:59Z","updated_at":"2015-10-22T17:25:56Z","pushed_at":"2015-10-23T17:06:41Z","git_url":"git://github.com/maidsafe/crust.git","ssh_url":"git@github.com:maidsafe/crust.git","clone_url":"https://github.com/maidsafe/crust.git","svn_url":"https://github.com/maidsafe/crust","homepage":null,"size":27772,"stargazers_count":201,"watchers_count":201,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":35,"forks":42,"open_issues":35,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/376"},"html":{"href":"https://github.com/maidsafe/crust/pull/376"},"issue":{"href":"https://api.github.com/repos/maidsafe/crust/issues/376"},"comments":{"href":"https://api.github.com/repos/maidsafe/crust/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/crust/statuses/af272a451f5c090cb50867f5833e3b5e7acfb597"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":115,"deletions":122,"changed_files":5}}