{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/46849081","id":46849081,"diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Copyright 2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.springframework.cloud.stream.config;\n+\n+import java.util.Properties;\n+\n+/**\n+ * Contains the properties of a binder.\n+ *\n+ * @author Marius Bogoevici\n+ */\n+public class BinderProperties {","path":"spring-cloud-stream/src/main/java/org/springframework/cloud/stream/config/BinderProperties.java","position":25,"original_position":25,"commit_id":"259c87f342b638f7a41fb56e5feb9d72c1b0a827","original_commit_id":"259c87f342b638f7a41fb56e5feb9d72c1b0a827","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"we might want to reconsider the name... for one thing it conflicts with an existing class of the same name (as evidenced by the need for a fully qualified name in this PR), but also it seems odd to have a `BinderProperties` class that is itself primarily used via its `getProperties()` method.","created_at":"2015-12-07T17:23:34Z","updated_at":"2015-12-07T17:23:34Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/221#discussion_r46849081","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/46849081"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/221#discussion_r46849081"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221","id":52798788,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/221","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/221.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/221.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/221","number":221,"state":"open","locked":false,"title":"Initial implementation of multibinder support","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"- Addresses #138,#172,#173 with support for multiple binders in an application\r\n- Binders can be of multiple types (e.g. Rabbit or Kafka), as well as multiple binders of the same type connecting to different system (e.g. multiple Rabbit binders connecting to different Rabbit clusters)\r\n- Binders are now created in a separate context, allowing for multiple configurations\r\n- Adds the `spring.cloud.spring.binders` namespace that allows for creating configuration properties for multiple binders\r\n\r\n- Add support for default binder, modify Kafka tests to use multiple brokers when running embedded\r\n\r\nThis resolves spring-cloud/spring-cloud-stream#138,\r\nThis resolves spring-cloud/spring-cloud-stream#172,\r\nThis resolves spring-cloud/spring-cloud-stream#173,\r\nThis resolves spring-cloud/spring-cloud-stream#140 ","created_at":"2015-12-07T02:02:04Z","updated_at":"2015-12-07T17:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f72abe020c0c6b70c893c71e6ddce3e5cf46bd93","assignee":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/221/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/259c87f342b638f7a41fb56e5feb9d72c1b0a827","head":{"label":"mbogoevici:multibinder-rebased","ref":"multibinder-rebased","sha":"259c87f342b638f7a41fb56e5feb9d72c1b0a827","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"repo":{"id":38768510,"name":"spring-cloud-stream","full_name":"mbogoevici/spring-cloud-stream","owner":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbogoevici/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream","forks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/releases{/id}","created_at":"2015-07-08T17:15:48Z","updated_at":"2015-07-17T11:12:02Z","pushed_at":"2015-12-07T01:55:20Z","git_url":"git://github.com/mbogoevici/spring-cloud-stream.git","ssh_url":"git@github.com:mbogoevici/spring-cloud-stream.git","clone_url":"https://github.com/mbogoevici/spring-cloud-stream.git","svn_url":"https://github.com/mbogoevici/spring-cloud-stream","homepage":null,"size":1258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"d8c1971c431c20e2f4f128dfda903b59c5f58c26","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","created_at":"2015-07-08T15:51:38Z","updated_at":"2015-12-04T11:09:28Z","pushed_at":"2015-12-07T17:19:14Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":2388,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":41,"forks":26,"open_issues":41,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/221"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/221"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/259c87f342b638f7a41fb56e5feb9d72c1b0a827"}}}}