{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/844","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/844/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/844/comments","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/844/events","html_url":"https://github.com/apache/incubator-brooklyn/pull/844","id":101758802,"number":844,"title":"completes the org.apache-fication","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?v=3","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-18T21:59:56Z","updated_at":"2015-08-19T07:44:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/844","html_url":"https://github.com/apache/incubator-brooklyn/pull/844","diff_url":"https://github.com/apache/incubator-brooklyn/pull/844.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/844.patch"},"body":"and tries to give nicer package structure esp in core in the process\r\n\r\nworth opening in the IDE and looking around, to see if you like where things are.  it's hard to make it perfect (and not worth a huge amount of time), so i made some pragmatic compromises in places, though i'm open to it being improved.\r\n\r\nthe main compromise was for packages we expect to be subpackaged a lot, i moved the project name afterwards (except for api) or sometimes dropped it if there's a clear primary home and the project name would be cumbersome, so we have\r\n\r\n    api/ - o.a.b.api.entity\r\n    core/ - o.a.b.entity.core\r\n    software/base/ - o.a.b.entity.java\r\n\r\nanything else makes it really awkward to avoid split packages imho.  btw i think this goes pretty far to fixing the split packages.\r\n\r\npersonally i like the feel of it when moving around the IDE.  how liberating to be able to do this!"},"comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments/132479942","html_url":"https://github.com/apache/incubator-brooklyn/pull/844#issuecomment-132479942","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/844","id":132479942,"user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars.githubusercontent.com/u/496540?v=3","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T07:44:20Z","updated_at":"2015-08-19T07:44:20Z","body":"let's continue discussion of the osgi test bundles at https://github.com/apache/incubator-brooklyn/pull/810\r\n\r\n`*.internal.*` classes in my view are internal to brooklyn; where possible this should be internal to the module (project) but if they need to cut across internal modules i'm okay with that.  we can use `x-friends` to restrict this.  i'm not sure if this is what is meant by \"osgi semantics\".  no strong feelings though."}}