{"action":"closed","number":541,"pull_request":{"url":"https://api.github.com/repos/stepmania/stepmania/pulls/541","id":32614106,"html_url":"https://github.com/stepmania/stepmania/pull/541","diff_url":"https://github.com/stepmania/stepmania/pull/541.diff","patch_url":"https://github.com/stepmania/stepmania/pull/541.patch","issue_url":"https://api.github.com/repos/stepmania/stepmania/issues/541","number":541,"state":"closed","locked":false,"title":"Board under everything","user":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"body":"This puts the NoteField board underneath everything on ScreenGameplay except for the song background.\r\nThis required some arcane structural changes to ScreenGameplay, NoteField, and Player so that Player could do its positioning and matrix setup stuff twice (once to render the board, once to render all other Player stuff), which I have tried to explain in comments in the code.\r\nWith this, the screen filter can be placed inside the board, which removes the complexity of figuring out where the field is positioned on the screen.\r\n\r\nAlso, ArrowEffects::Update was being called by NoteField::Draw, which meant it updated twice with two players.  That just seemed like a waste.","created_at":"2015-04-03T20:26:14Z","updated_at":"2015-04-07T05:35:04Z","closed_at":"2015-04-07T05:35:04Z","merged_at":"2015-04-07T05:35:04Z","merge_commit_sha":"152754207d0a8fb49e2b638540353aed74a3736c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stepmania/stepmania/pulls/541/commits","review_comments_url":"https://api.github.com/repos/stepmania/stepmania/pulls/541/comments","review_comment_url":"https://api.github.com/repos/stepmania/stepmania/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stepmania/stepmania/issues/541/comments","statuses_url":"https://api.github.com/repos/stepmania/stepmania/statuses/6bedfcaf740e4e240fc39238200f6c36634a128b","head":{"label":"kyzentun:board_under_everything","ref":"board_under_everything","sha":"6bedfcaf740e4e240fc39238200f6c36634a128b","user":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"repo":{"id":16755813,"name":"stepmania","full_name":"kyzentun/stepmania","owner":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyzentun/stepmania","description":"Advanced rhythm game for Windows, Linux and OS X. Designed for both home and arcade use.","fork":true,"url":"https://api.github.com/repos/kyzentun/stepmania","forks_url":"https://api.github.com/repos/kyzentun/stepmania/forks","keys_url":"https://api.github.com/repos/kyzentun/stepmania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyzentun/stepmania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyzentun/stepmania/teams","hooks_url":"https://api.github.com/repos/kyzentun/stepmania/hooks","issue_events_url":"https://api.github.com/repos/kyzentun/stepmania/issues/events{/number}","events_url":"https://api.github.com/repos/kyzentun/stepmania/events","assignees_url":"https://api.github.com/repos/kyzentun/stepmania/assignees{/user}","branches_url":"https://api.github.com/repos/kyzentun/stepmania/branches{/branch}","tags_url":"https://api.github.com/repos/kyzentun/stepmania/tags","blobs_url":"https://api.github.com/repos/kyzentun/stepmania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyzentun/stepmania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyzentun/stepmania/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyzentun/stepmania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyzentun/stepmania/statuses/{sha}","languages_url":"https://api.github.com/repos/kyzentun/stepmania/languages","stargazers_url":"https://api.github.com/repos/kyzentun/stepmania/stargazers","contributors_url":"https://api.github.com/repos/kyzentun/stepmania/contributors","subscribers_url":"https://api.github.com/repos/kyzentun/stepmania/subscribers","subscription_url":"https://api.github.com/repos/kyzentun/stepmania/subscription","commits_url":"https://api.github.com/repos/kyzentun/stepmania/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyzentun/stepmania/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyzentun/stepmania/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyzentun/stepmania/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyzentun/stepmania/contents/{+path}","compare_url":"https://api.github.com/repos/kyzentun/stepmania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyzentun/stepmania/merges","archive_url":"https://api.github.com/repos/kyzentun/stepmania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyzentun/stepmania/downloads","issues_url":"https://api.github.com/repos/kyzentun/stepmania/issues{/number}","pulls_url":"https://api.github.com/repos/kyzentun/stepmania/pulls{/number}","milestones_url":"https://api.github.com/repos/kyzentun/stepmania/milestones{/number}","notifications_url":"https://api.github.com/repos/kyzentun/stepmania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyzentun/stepmania/labels{/name}","releases_url":"https://api.github.com/repos/kyzentun/stepmania/releases{/id}","created_at":"2014-02-12T04:21:50Z","updated_at":"2014-06-23T19:53:24Z","pushed_at":"2015-04-07T03:50:22Z","git_url":"git://github.com/kyzentun/stepmania.git","ssh_url":"git@github.com:kyzentun/stepmania.git","clone_url":"https://github.com/kyzentun/stepmania.git","svn_url":"https://github.com/kyzentun/stepmania","homepage":"http://www.stepmania.com/","size":480036,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stepmania:master","ref":"master","sha":"6b4c4e298f18bf01eed794a872b7a8dbd42bc616","user":{"login":"stepmania","id":4809468,"avatar_url":"https://avatars.githubusercontent.com/u/4809468?v=3","gravatar_id":"","url":"https://api.github.com/users/stepmania","html_url":"https://github.com/stepmania","followers_url":"https://api.github.com/users/stepmania/followers","following_url":"https://api.github.com/users/stepmania/following{/other_user}","gists_url":"https://api.github.com/users/stepmania/gists{/gist_id}","starred_url":"https://api.github.com/users/stepmania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepmania/subscriptions","organizations_url":"https://api.github.com/users/stepmania/orgs","repos_url":"https://api.github.com/users/stepmania/repos","events_url":"https://api.github.com/users/stepmania/events{/privacy}","received_events_url":"https://api.github.com/users/stepmania/received_events","type":"Organization","site_admin":false},"repo":{"id":10923187,"name":"stepmania","full_name":"stepmania/stepmania","owner":{"login":"stepmania","id":4809468,"avatar_url":"https://avatars.githubusercontent.com/u/4809468?v=3","gravatar_id":"","url":"https://api.github.com/users/stepmania","html_url":"https://github.com/stepmania","followers_url":"https://api.github.com/users/stepmania/followers","following_url":"https://api.github.com/users/stepmania/following{/other_user}","gists_url":"https://api.github.com/users/stepmania/gists{/gist_id}","starred_url":"https://api.github.com/users/stepmania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepmania/subscriptions","organizations_url":"https://api.github.com/users/stepmania/orgs","repos_url":"https://api.github.com/users/stepmania/repos","events_url":"https://api.github.com/users/stepmania/events{/privacy}","received_events_url":"https://api.github.com/users/stepmania/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stepmania/stepmania","description":"Advanced rhythm game for Windows, Linux and OS X. Designed for both home and arcade use.","fork":false,"url":"https://api.github.com/repos/stepmania/stepmania","forks_url":"https://api.github.com/repos/stepmania/stepmania/forks","keys_url":"https://api.github.com/repos/stepmania/stepmania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stepmania/stepmania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stepmania/stepmania/teams","hooks_url":"https://api.github.com/repos/stepmania/stepmania/hooks","issue_events_url":"https://api.github.com/repos/stepmania/stepmania/issues/events{/number}","events_url":"https://api.github.com/repos/stepmania/stepmania/events","assignees_url":"https://api.github.com/repos/stepmania/stepmania/assignees{/user}","branches_url":"https://api.github.com/repos/stepmania/stepmania/branches{/branch}","tags_url":"https://api.github.com/repos/stepmania/stepmania/tags","blobs_url":"https://api.github.com/repos/stepmania/stepmania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stepmania/stepmania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stepmania/stepmania/git/refs{/sha}","trees_url":"https://api.github.com/repos/stepmania/stepmania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stepmania/stepmania/statuses/{sha}","languages_url":"https://api.github.com/repos/stepmania/stepmania/languages","stargazers_url":"https://api.github.com/repos/stepmania/stepmania/stargazers","contributors_url":"https://api.github.com/repos/stepmania/stepmania/contributors","subscribers_url":"https://api.github.com/repos/stepmania/stepmania/subscribers","subscription_url":"https://api.github.com/repos/stepmania/stepmania/subscription","commits_url":"https://api.github.com/repos/stepmania/stepmania/commits{/sha}","git_commits_url":"https://api.github.com/repos/stepmania/stepmania/git/commits{/sha}","comments_url":"https://api.github.com/repos/stepmania/stepmania/comments{/number}","issue_comment_url":"https://api.github.com/repos/stepmania/stepmania/issues/comments{/number}","contents_url":"https://api.github.com/repos/stepmania/stepmania/contents/{+path}","compare_url":"https://api.github.com/repos/stepmania/stepmania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stepmania/stepmania/merges","archive_url":"https://api.github.com/repos/stepmania/stepmania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stepmania/stepmania/downloads","issues_url":"https://api.github.com/repos/stepmania/stepmania/issues{/number}","pulls_url":"https://api.github.com/repos/stepmania/stepmania/pulls{/number}","milestones_url":"https://api.github.com/repos/stepmania/stepmania/milestones{/number}","notifications_url":"https://api.github.com/repos/stepmania/stepmania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stepmania/stepmania/labels{/name}","releases_url":"https://api.github.com/repos/stepmania/stepmania/releases{/id}","created_at":"2013-06-24T23:40:10Z","updated_at":"2015-04-07T05:34:14Z","pushed_at":"2015-04-07T05:35:04Z","git_url":"git://github.com/stepmania/stepmania.git","ssh_url":"git@github.com:stepmania/stepmania.git","clone_url":"https://github.com/stepmania/stepmania.git","svn_url":"https://github.com/stepmania/stepmania","homepage":"http://www.stepmania.com/","size":527295,"stargazers_count":198,"watchers_count":198,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":131,"forks":77,"open_issues":131,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/541"},"html":{"href":"https://github.com/stepmania/stepmania/pull/541"},"issue":{"href":"https://api.github.com/repos/stepmania/stepmania/issues/541"},"comments":{"href":"https://api.github.com/repos/stepmania/stepmania/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/stepmania/stepmania/statuses/6bedfcaf740e4e240fc39238200f6c36634a128b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":244,"deletions":175,"changed_files":14}}