{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-server/issues/908","labels_url":"https://api.github.com/repos/zanata/zanata-server/issues/908/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-server/issues/908/comments","events_url":"https://api.github.com/repos/zanata/zanata-server/issues/908/events","html_url":"https://github.com/zanata/zanata-server/pull/908","id":94850870,"number":908,"title":"Replace Seam Security","user":{"login":"huangp","id":1005842,"avatar_url":"https://avatars.githubusercontent.com/u/1005842?v=3","gravatar_id":"","url":"https://api.github.com/users/huangp","html_url":"https://github.com/huangp","followers_url":"https://api.github.com/users/huangp/followers","following_url":"https://api.github.com/users/huangp/following{/other_user}","gists_url":"https://api.github.com/users/huangp/gists{/gist_id}","starred_url":"https://api.github.com/users/huangp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangp/subscriptions","organizations_url":"https://api.github.com/users/huangp/orgs","repos_url":"https://api.github.com/users/huangp/repos","events_url":"https://api.github.com/users/huangp/events{/privacy}","received_events_url":"https://api.github.com/users/huangp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zanata/zanata-server/labels/Awaiting%20review","name":"Awaiting review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-07-14T02:02:44Z","updated_at":"2015-08-04T06:10:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-server/pulls/908","html_url":"https://github.com/zanata/zanata-server/pull/908","diff_url":"https://github.com/zanata/zanata-server/pull/908.diff","patch_url":"https://github.com/zanata/zanata-server/pull/908.patch"},"body":"- replace all ```@Restrict``` to use our own annotations and write up our own security interceptor\r\n- replace all ```#{s:hasRole``` and ```#{s:hasPermission``` to use ```identity``` instead\r\n- remove ```<restrict>``` and ```require-login``` from pages.xml\r\n- replace seam IdentityManager and JpaIdentityStore \r\n\r\nSome TODOs:\r\n- [x] javadoc on CheckPermission.value\r\n- [x] check permission('seam.user', 'read') in UserSearch.loadUsers\r\n- [x] UserSearch.loadUsers should use ZanataIdentityManager, not JpaIdentityStore directly"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-server/issues/comments/127490161","html_url":"https://github.com/zanata/zanata-server/pull/908#issuecomment-127490161","issue_url":"https://api.github.com/repos/zanata/zanata-server/issues/908","id":127490161,"user":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T06:10:31Z","updated_at":"2015-08-04T06:10:31Z","body":"@huangp looks like you forgot to delete the empty test `ordinaryUserDoNotHaveAdminPermission`"}}