{"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/29832718","id":29832718,"diff_hunk":"@@ -0,0 +1,48 @@\n+package java.util\n+\n+import scala.annotation.tailrec\n+\n+abstract class AbstractSet[E]() extends java.util.AbstractCollection[E] with java.util.Set[E] {\n+\n+  override def equals(o: Any): Boolean = {\n+    def _equals =\n+      o match {\n+        case s: java.util.Collection[E] =>\n+          if (s.size == this.size) containsAll(s)\n+          else false\n+        case _ => false\n+      }\n+\n+    o match {\n+      case ar: AnyRef =>","path":"javalib/src/main/scala/java/util/AbstractSet.scala","position":17,"original_position":17,"commit_id":"f554bd615373e649bb0bb9c99b05d179e59f74ce","original_commit_id":"f554bd615373e649bb0bb9c99b05d179e59f74ce","user":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2015-05-07T08:24:11Z","updated_at":"2015-05-07T08:24:11Z","html_url":"https://github.com/scala-js/scala-js/pull/1636#discussion_r29832718","pull_request_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/29832718"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1636#discussion_r29832718"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636","id":34717020,"html_url":"https://github.com/scala-js/scala-js/pull/1636","diff_url":"https://github.com/scala-js/scala-js/pull/1636.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1636.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1636","number":1636,"state":"open","locked":false,"title":"Issue: #1487 Added ConcurrentHashMap implementation","user":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"body":"This is an implementation of ConcurrentHashMap in java.util.concurrent.\r\nTo keep it working nicely I had to stub a bit of the java.util.Collection related interfaces, please consider them just a stub to let scala.collection.JavaConversions works, I will ask for some discussion and/or review about the actual implementation.\r\n\r\nAnother issue is about the keySet method, unfortunately, the signature of this method changed in Java 8, I wait for suggestions on how to manage that.","created_at":"2015-05-05T11:55:06Z","updated_at":"2015-05-07T08:24:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95c0f649af847aaf5d278459f255e20c935301ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1636/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/f554bd615373e649bb0bb9c99b05d179e59f74ce","head":{"label":"andreaTP:master","ref":"master","sha":"f554bd615373e649bb0bb9c99b05d179e59f74ce","user":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"repo":{"id":34802802,"name":"scala-js","full_name":"andreaTP/scala-js","owner":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreaTP/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":true,"url":"https://api.github.com/repos/andreaTP/scala-js","forks_url":"https://api.github.com/repos/andreaTP/scala-js/forks","keys_url":"https://api.github.com/repos/andreaTP/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreaTP/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreaTP/scala-js/teams","hooks_url":"https://api.github.com/repos/andreaTP/scala-js/hooks","issue_events_url":"https://api.github.com/repos/andreaTP/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/andreaTP/scala-js/events","assignees_url":"https://api.github.com/repos/andreaTP/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/andreaTP/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/andreaTP/scala-js/tags","blobs_url":"https://api.github.com/repos/andreaTP/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreaTP/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreaTP/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreaTP/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreaTP/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/andreaTP/scala-js/languages","stargazers_url":"https://api.github.com/repos/andreaTP/scala-js/stargazers","contributors_url":"https://api.github.com/repos/andreaTP/scala-js/contributors","subscribers_url":"https://api.github.com/repos/andreaTP/scala-js/subscribers","subscription_url":"https://api.github.com/repos/andreaTP/scala-js/subscription","commits_url":"https://api.github.com/repos/andreaTP/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreaTP/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreaTP/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreaTP/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreaTP/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/andreaTP/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreaTP/scala-js/merges","archive_url":"https://api.github.com/repos/andreaTP/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreaTP/scala-js/downloads","issues_url":"https://api.github.com/repos/andreaTP/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/andreaTP/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/andreaTP/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/andreaTP/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreaTP/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/andreaTP/scala-js/releases{/id}","created_at":"2015-04-29T15:44:28Z","updated_at":"2015-05-06T08:45:37Z","pushed_at":"2015-05-06T08:52:24Z","git_url":"git://github.com/andreaTP/scala-js.git","ssh_url":"git@github.com:andreaTP/scala-js.git","clone_url":"https://github.com/andreaTP/scala-js.git","svn_url":"https://github.com/andreaTP/scala-js","homepage":"http://www.scala-js.org/","size":7925,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"6dbab2c3ebb665efe0c1eee2af33202d6edc42e2","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":8272315,"name":"scala-js","full_name":"scala-js/scala-js","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js","forks_url":"https://api.github.com/repos/scala-js/scala-js/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-js/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js/releases{/id}","created_at":"2013-02-18T16:33:55Z","updated_at":"2015-05-07T00:54:36Z","pushed_at":"2015-05-06T16:34:02Z","git_url":"git://github.com/scala-js/scala-js.git","ssh_url":"git@github.com:scala-js/scala-js.git","clone_url":"https://github.com/scala-js/scala-js.git","svn_url":"https://github.com/scala-js/scala-js","homepage":"http://www.scala-js.org/","size":16103,"stargazers_count":1651,"watchers_count":1651,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":48,"forks":137,"open_issues":48,"watchers":1651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1636"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1636"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1636/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js/statuses/f554bd615373e649bb0bb9c99b05d179e59f74ce"}}}}