{"action":"created","issue":{"url":"https://api.github.com/repos/gligli/p600fw/issues/72","labels_url":"https://api.github.com/repos/gligli/p600fw/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/gligli/p600fw/issues/72/comments","events_url":"https://api.github.com/repos/gligli/p600fw/issues/72/events","html_url":"https://github.com/gligli/p600fw/pull/72","id":71110443,"number":72,"title":"UI for live retuning notes/scale","user":{"login":"snickell","id":223277,"avatar_url":"https://avatars.githubusercontent.com/u/223277?v=3","gravatar_id":"","url":"https://api.github.com/users/snickell","html_url":"https://github.com/snickell","followers_url":"https://api.github.com/users/snickell/followers","following_url":"https://api.github.com/users/snickell/following{/other_user}","gists_url":"https://api.github.com/users/snickell/gists{/gist_id}","starred_url":"https://api.github.com/users/snickell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snickell/subscriptions","organizations_url":"https://api.github.com/users/snickell/orgs","repos_url":"https://api.github.com/users/snickell/repos","events_url":"https://api.github.com/users/snickell/events{/privacy}","received_events_url":"https://api.github.com/users/snickell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-26T19:38:26Z","updated_at":"2015-05-02T10:22:58Z","closed_at":"2015-05-02T10:22:10Z","pull_request":{"url":"https://api.github.com/repos/gligli/p600fw/pulls/72","html_url":"https://github.com/gligli/p600fw/pull/72","diff_url":"https://github.com/gligli/p600fw/pull/72.diff","patch_url":"https://github.com/gligli/p600fw/pull/72.patch"},"body":"Not redy to merge yet, but wanted to get @gligli thoughts on my UI approach early.\r\n\r\nI'd love to chat if you have time in the next few days. My skype is sethnickell, also __going to hang out on efnet as sethn in #p600__ . Most likely to be around your evening (paris time).\r\n\r\n1) I'm using the Record + Tune button combo to toggle 'live retuning ui mode'. I think it stays out of the way of other UI features well, reuses the existing 'blink record on press to indicate further input needed' code, makes UI sense, and requires no extra UI state. That UI make sense to you?\r\n\r\n2) Now having live control of retuning, I realized that preset.perNoteTuningInCents is too coarse (can hear stepping, can't tune in resonances). I want to update the storage/preset to redefine perNoteTuning to allow greater precision (e.g. millisemitones instead of centisemitones). Do you want me to bump the version number to v8 and write code for updating between v7 and v8? Or do you feel comfortable that probably nobody except you and me used v7 in the past few days?\r\n"},"comment":{"url":"https://api.github.com/repos/gligli/p600fw/issues/comments/98346349","html_url":"https://github.com/gligli/p600fw/pull/72#issuecomment-98346349","issue_url":"https://api.github.com/repos/gligli/p600fw/issues/72","id":98346349,"user":{"login":"gligli","id":524324,"avatar_url":"https://avatars.githubusercontent.com/u/524324?v=3","gravatar_id":"","url":"https://api.github.com/users/gligli","html_url":"https://github.com/gligli","followers_url":"https://api.github.com/users/gligli/followers","following_url":"https://api.github.com/users/gligli/following{/other_user}","gists_url":"https://api.github.com/users/gligli/gists{/gist_id}","starred_url":"https://api.github.com/users/gligli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gligli/subscriptions","organizations_url":"https://api.github.com/users/gligli/orgs","repos_url":"https://api.github.com/users/gligli/repos","events_url":"https://api.github.com/users/gligli/events{/privacy}","received_events_url":"https://api.github.com/users/gligli/received_events","type":"User","site_admin":false},"created_at":"2015-05-02T10:22:58Z","updated_at":"2015-05-02T10:22:58Z","body":"Ok, thanks!"}}