{"action":"closed","issue":{"url":"https://api.github.com/repos/gawel/panoramisk/issues/6","labels_url":"https://api.github.com/repos/gawel/panoramisk/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/gawel/panoramisk/issues/6/comments","events_url":"https://api.github.com/repos/gawel/panoramisk/issues/6/events","html_url":"https://github.com/gawel/panoramisk/issues/6","id":46906683,"number":6,"title":"Allow recurring ping  + interval in config ?","user":{"login":"otaf","id":1745999,"avatar_url":"https://avatars.githubusercontent.com/u/1745999?v=3","gravatar_id":"","url":"https://api.github.com/users/otaf","html_url":"https://github.com/otaf","followers_url":"https://api.github.com/users/otaf/followers","following_url":"https://api.github.com/users/otaf/following{/other_user}","gists_url":"https://api.github.com/users/otaf/gists{/gist_id}","starred_url":"https://api.github.com/users/otaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaf/subscriptions","organizations_url":"https://api.github.com/users/otaf/orgs","repos_url":"https://api.github.com/users/otaf/repos","events_url":"https://api.github.com/users/otaf/events{/privacy}","received_events_url":"https://api.github.com/users/otaf/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gawel/panoramisk/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"GMLudo","id":243823,"avatar_url":"https://avatars.githubusercontent.com/u/243823?v=3","gravatar_id":"","url":"https://api.github.com/users/GMLudo","html_url":"https://github.com/GMLudo","followers_url":"https://api.github.com/users/GMLudo/followers","following_url":"https://api.github.com/users/GMLudo/following{/other_user}","gists_url":"https://api.github.com/users/GMLudo/gists{/gist_id}","starred_url":"https://api.github.com/users/GMLudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMLudo/subscriptions","organizations_url":"https://api.github.com/users/GMLudo/orgs","repos_url":"https://api.github.com/users/GMLudo/repos","events_url":"https://api.github.com/users/GMLudo/events{/privacy}","received_events_url":"https://api.github.com/users/GMLudo/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gawel/panoramisk/milestones/1","html_url":"https://github.com/gawel/panoramisk/milestones/0.7","labels_url":"https://api.github.com/repos/gawel/panoramisk/milestones/1/labels","id":1046843,"number":1,"title":"0.7","description":"","creator":{"login":"GMLudo","id":243823,"avatar_url":"https://avatars.githubusercontent.com/u/243823?v=3","gravatar_id":"","url":"https://api.github.com/users/GMLudo","html_url":"https://github.com/GMLudo","followers_url":"https://api.github.com/users/GMLudo/followers","following_url":"https://api.github.com/users/GMLudo/following{/other_user}","gists_url":"https://api.github.com/users/GMLudo/gists{/gist_id}","starred_url":"https://api.github.com/users/GMLudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMLudo/subscriptions","organizations_url":"https://api.github.com/users/GMLudo/orgs","repos_url":"https://api.github.com/users/GMLudo/repos","events_url":"https://api.github.com/users/GMLudo/events{/privacy}","received_events_url":"https://api.github.com/users/GMLudo/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2015-03-31T12:59:04Z","updated_at":"2015-07-25T14:58:10Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2014-10-27T13:50:39Z","updated_at":"2015-07-25T14:58:10Z","closed_at":"2015-07-25T14:58:10Z","body":"The code uses a ping method for the Manager Object, but does not check that the connection is really alive from the Manager point of view.\r\n\r\nMaybe there is a risk that the connection dies silently, without a recurring ping from the Panoramisk App.\r\n\r\nMy 2c€ : \r\n* Either warn the lib user to check regularly that the connection is alive : the case in which this happens is especially when listening to events and not sending new Actions.\r\n* or integrate a ping in the Manager code and config, with a specified interval, and forcing reconnects from the manager when the ping is KO.\r\n\r\n\r\n"}}