{"action":"created","issue":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1460","labels_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1460/labels{/name}","comments_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1460/comments","events_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1460/events","html_url":"https://github.com/lisa-lab/pylearn2/pull/1460","id":64770413,"number":1460,"title":"Implementing test unit for learning rates","user":{"login":"XavierAudier","id":10462621,"avatar_url":"https://avatars.githubusercontent.com/u/10462621?v=3","gravatar_id":"","url":"https://api.github.com/users/XavierAudier","html_url":"https://github.com/XavierAudier","followers_url":"https://api.github.com/users/XavierAudier/followers","following_url":"https://api.github.com/users/XavierAudier/following{/other_user}","gists_url":"https://api.github.com/users/XavierAudier/gists{/gist_id}","starred_url":"https://api.github.com/users/XavierAudier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XavierAudier/subscriptions","organizations_url":"https://api.github.com/users/XavierAudier/orgs","repos_url":"https://api.github.com/users/XavierAudier/repos","events_url":"https://api.github.com/users/XavierAudier/events{/privacy}","received_events_url":"https://api.github.com/users/XavierAudier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-27T14:15:31Z","updated_at":"2015-03-27T20:59:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/pulls/1460","html_url":"https://github.com/lisa-lab/pylearn2/pull/1460","diff_url":"https://github.com/lisa-lab/pylearn2/pull/1460.diff","patch_url":"https://github.com/lisa-lab/pylearn2/pull/1460.patch"},"body":"Implementing a test for commit #1456"},"comment":{"url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/comments/87090480","html_url":"https://github.com/lisa-lab/pylearn2/pull/1460#issuecomment-87090480","issue_url":"https://api.github.com/repos/lisa-lab/pylearn2/issues/1460","id":87090480,"user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T20:59:14Z","updated_at":"2015-03-27T20:59:14Z","body":"A unit test should check things automatically (and raise an Exception if there is a problem), not simply print things for manual inspection.\r\nIf you expect all values to be equal to 1./100, you could for instance call `assert_allclose(..., 1e-2)` on the values, instead of printing them.\r\nAlso, you can add the unit test in a different commit of the same pull request, it can make things easier to review."}}