{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/47669769","id":47669769,"diff_hunk":"@@ -194,7 +194,7 @@ AnimationPointer ModelEntityItem::getAnimation(const QString& url) {\n \n void ModelEntityItem::mapJoints(const QStringList& modelJointNames) {\n     // if we don't have animation, or we're already joint mapped then bail early\n-    if (!hasAnimation() || _jointMappingCompleted) {\n+    if (!hasAnimation() || jointsMapped()) {\n         return;\n     }","path":"libraries/entities/src/ModelEntityItem.cpp","position":7,"original_position":7,"commit_id":"617fda783242cf3592090b3b4403aab00d9b6059","original_commit_id":"617fda783242cf3592090b3b4403aab00d9b6059","user":{"login":"AndrewMeadows","id":2186405,"avatar_url":"https://avatars.githubusercontent.com/u/2186405?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewMeadows","html_url":"https://github.com/AndrewMeadows","followers_url":"https://api.github.com/users/AndrewMeadows/followers","following_url":"https://api.github.com/users/AndrewMeadows/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMeadows/subscriptions","organizations_url":"https://api.github.com/users/AndrewMeadows/orgs","repos_url":"https://api.github.com/users/AndrewMeadows/repos","events_url":"https://api.github.com/users/AndrewMeadows/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMeadows/received_events","type":"User","site_admin":false},"body":"There is a very similar line to this one in **ModelEntityItem::getAnimationFrame()**.  Should that one also be changed?","created_at":"2015-12-15T17:34:51Z","updated_at":"2015-12-15T17:34:51Z","html_url":"https://github.com/highfidelity/hifi/pull/6653#discussion_r47669769","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6653","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/47669769"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6653#discussion_r47669769"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6653"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6653","id":53647015,"html_url":"https://github.com/highfidelity/hifi/pull/6653","diff_url":"https://github.com/highfidelity/hifi/pull/6653.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6653.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6653","number":6653,"state":"open","locked":false,"title":"ModelEntityItem: fix for incorrect joint mapping","user":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"body":"This could happen when switching the animation url between two fbx files with different joint mappings.  Only the first one would take effect.\r\n\r\nThis should fix the issue in the demo domain, with the contorted doll model.","created_at":"2015-12-15T01:11:20Z","updated_at":"2015-12-15T17:34:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eba37cb0da3983140c1f90ac8d4f6748b9517444","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6653/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6653/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6653/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/617fda783242cf3592090b3b4403aab00d9b6059","head":{"label":"hyperlogic:tony/model-entity-animation-fix","ref":"tony/model-entity-animation-fix","sha":"617fda783242cf3592090b3b4403aab00d9b6059","user":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"repo":{"id":34955357,"name":"hifi","full_name":"hyperlogic/hifi","owner":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyperlogic/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/hyperlogic/hifi","forks_url":"https://api.github.com/repos/hyperlogic/hifi/forks","keys_url":"https://api.github.com/repos/hyperlogic/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperlogic/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperlogic/hifi/teams","hooks_url":"https://api.github.com/repos/hyperlogic/hifi/hooks","issue_events_url":"https://api.github.com/repos/hyperlogic/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/hyperlogic/hifi/events","assignees_url":"https://api.github.com/repos/hyperlogic/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/hyperlogic/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/hyperlogic/hifi/tags","blobs_url":"https://api.github.com/repos/hyperlogic/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperlogic/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperlogic/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperlogic/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperlogic/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperlogic/hifi/languages","stargazers_url":"https://api.github.com/repos/hyperlogic/hifi/stargazers","contributors_url":"https://api.github.com/repos/hyperlogic/hifi/contributors","subscribers_url":"https://api.github.com/repos/hyperlogic/hifi/subscribers","subscription_url":"https://api.github.com/repos/hyperlogic/hifi/subscription","commits_url":"https://api.github.com/repos/hyperlogic/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperlogic/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperlogic/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperlogic/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperlogic/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/hyperlogic/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperlogic/hifi/merges","archive_url":"https://api.github.com/repos/hyperlogic/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperlogic/hifi/downloads","issues_url":"https://api.github.com/repos/hyperlogic/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/hyperlogic/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperlogic/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperlogic/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperlogic/hifi/labels{/name}","releases_url":"https://api.github.com/repos/hyperlogic/hifi/releases{/id}","created_at":"2015-05-02T16:40:40Z","updated_at":"2015-05-02T16:47:44Z","pushed_at":"2015-12-15T16:46:19Z","git_url":"git://github.com/hyperlogic/hifi.git","ssh_url":"git@github.com:hyperlogic/hifi.git","clone_url":"https://github.com/hyperlogic/hifi.git","svn_url":"https://github.com/hyperlogic/hifi","homepage":"","size":176841,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"205bc1b790ba542dcbe5f838f2fe2b7457194df9","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-12-14T04:28:36Z","pushed_at":"2015-12-15T17:13:38Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":218431,"stargazers_count":333,"watchers_count":333,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":55,"forks":197,"open_issues":55,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6653"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6653"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6653"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6653/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6653/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6653/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/617fda783242cf3592090b3b4403aab00d9b6059"}}}}