{"action":"created","issue":{"url":"https://api.github.com/repos/arenanet/api-cdi/issues/112","labels_url":"https://api.github.com/repos/arenanet/api-cdi/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/arenanet/api-cdi/issues/112/comments","events_url":"https://api.github.com/repos/arenanet/api-cdi/issues/112/events","html_url":"https://github.com/arenanet/api-cdi/issues/112","id":114853410,"number":112,"title":"Attribute names in /v2/items","user":{"login":"dr-ishmael","id":1929447,"avatar_url":"https://avatars.githubusercontent.com/u/1929447?v=3","gravatar_id":"","url":"https://api.github.com/users/dr-ishmael","html_url":"https://github.com/dr-ishmael","followers_url":"https://api.github.com/users/dr-ishmael/followers","following_url":"https://api.github.com/users/dr-ishmael/following{/other_user}","gists_url":"https://api.github.com/users/dr-ishmael/gists{/gist_id}","starred_url":"https://api.github.com/users/dr-ishmael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr-ishmael/subscriptions","organizations_url":"https://api.github.com/users/dr-ishmael/orgs","repos_url":"https://api.github.com/users/dr-ishmael/repos","events_url":"https://api.github.com/users/dr-ishmael/events{/privacy}","received_events_url":"https://api.github.com/users/dr-ishmael/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-03T16:24:11Z","updated_at":"2015-12-07T15:50:27Z","closed_at":null,"body":"The new attributes Concentration and Expertise are being returned on the items endpoint `attributes` and `buff` as `BoonDuration` and `ConditionDuration`, the same as actual Boon Duration and Condition Duration. Luckily, on equipment (weapons/armor/trinkets/back) they can be distinguished because Concentration/Expertise actually show up in `attributes`, whereas Boon/Condition Duration only show up in `buff`.\r\n\r\n* Boon Duration on equipment: https://api.guildwars2.com/v2/items/38168\r\n* Concentration on equipment: https://api.guildwars2.com/v2/items/72391\r\n\r\nHowever, upgrade components only have a `buff`, so we have to look to see if the number has a percent sign or not before we can translate `Boon/ConditionDuration` to Concentration/Expertise.\r\n\r\n* Boon Duration on upgrade: https://api.guildwars2.com/v2/items/38143\r\n* Concentration on upgrade: https://api.guildwars2.com/v2/items/73386\r\n\r\nIs there any way these attribute names can be updated?\r\n\r\nPS: the attribute Ferocity is still being returned as `CritDamage`, although this isn't a major problem because it doesn't create any conflicts."},"comment":{"url":"https://api.github.com/repos/arenanet/api-cdi/issues/comments/162564029","html_url":"https://github.com/arenanet/api-cdi/issues/112#issuecomment-162564029","issue_url":"https://api.github.com/repos/arenanet/api-cdi/issues/112","id":162564029,"user":{"login":"lye","id":921652,"avatar_url":"https://avatars.githubusercontent.com/u/921652?v=3","gravatar_id":"","url":"https://api.github.com/users/lye","html_url":"https://github.com/lye","followers_url":"https://api.github.com/users/lye/followers","following_url":"https://api.github.com/users/lye/following{/other_user}","gists_url":"https://api.github.com/users/lye/gists{/gist_id}","starred_url":"https://api.github.com/users/lye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lye/subscriptions","organizations_url":"https://api.github.com/users/lye/orgs","repos_url":"https://api.github.com/users/lye/repos","events_url":"https://api.github.com/users/lye/events{/privacy}","received_events_url":"https://api.github.com/users/lye/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T15:50:27Z","updated_at":"2015-12-07T15:50:27Z","body":"I think what I want to do is add an additional field to the `details` object that contains the machine-readable jewel stats. I don't want to mess with the existing fields for fear of application breakage. I'll have to write a PR later."}}