{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/keen/explorer/pulls/46","id":50275056,"html_url":"https://github.com/keen/explorer/pull/46","diff_url":"https://github.com/keen/explorer/pull/46.diff","patch_url":"https://github.com/keen/explorer/pull/46.patch","issue_url":"https://api.github.com/repos/keen/explorer/issues/46","number":46,"state":"open","locked":false,"title":"QueryBuilder should place step parameters on the active step","user":{"login":"josephwegner","id":657707,"avatar_url":"https://avatars.githubusercontent.com/u/657707?v=3","gravatar_id":"","url":"https://api.github.com/users/josephwegner","html_url":"https://github.com/josephwegner","followers_url":"https://api.github.com/users/josephwegner/followers","following_url":"https://api.github.com/users/josephwegner/following{/other_user}","gists_url":"https://api.github.com/users/josephwegner/gists{/gist_id}","starred_url":"https://api.github.com/users/josephwegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephwegner/subscriptions","organizations_url":"https://api.github.com/users/josephwegner/orgs","repos_url":"https://api.github.com/users/josephwegner/repos","events_url":"https://api.github.com/users/josephwegner/events{/privacy}","received_events_url":"https://api.github.com/users/josephwegner/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThis adds a bit of logic to the `QueryBuilder` component to know how/where to place parameters when updating the query. If it's a funnel, a certain set of properties need to be placed on the active step, while other properties can continue to be placed on the root query.\r\n\r\nFor the record, this is gonna get real messy if we ever start allowing timeframes on both the step and the root query. I'm gonna try not the think about that yet :)\r\n\r\n### How should this be tested (feature switches, URLs, special user permissions)?\r\n\r\nAgain, this doesn't affect the actual experience at all yet, because we don't have a funnel analysis type. The best way to test this is to give a thorough read of the unit tests I added, make sure they seem sane, and trust that the CI ran them.\r\n\r\n### What makes you uneasy about this PR?\r\n\r\nThe function `placeUpdatedProperty` just feels... weird. Like, not the logic, but the fact that it exists, and _where_ it exists. I don't think there's a better place, and I think it's better to have that logic separated from `handleChanges`... it just still feels a tiny bit out of place.","created_at":"2015-11-10T16:23:04Z","updated_at":"2015-11-10T16:23:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keen/explorer/pulls/46/commits","review_comments_url":"https://api.github.com/repos/keen/explorer/pulls/46/comments","review_comment_url":"https://api.github.com/repos/keen/explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keen/explorer/issues/46/comments","statuses_url":"https://api.github.com/repos/keen/explorer/statuses/cee8c785bafb292b984eba78c8c831670d416ea2","head":{"label":"keen:funnel-query-builder-updates","ref":"funnel-query-builder-updates","sha":"cee8c785bafb292b984eba78c8c831670d416ea2","user":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"repo":{"id":37276906,"name":"explorer","full_name":"keen/explorer","owner":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keen/explorer","description":"Data Explorer by Keen IO","fork":false,"url":"https://api.github.com/repos/keen/explorer","forks_url":"https://api.github.com/repos/keen/explorer/forks","keys_url":"https://api.github.com/repos/keen/explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keen/explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keen/explorer/teams","hooks_url":"https://api.github.com/repos/keen/explorer/hooks","issue_events_url":"https://api.github.com/repos/keen/explorer/issues/events{/number}","events_url":"https://api.github.com/repos/keen/explorer/events","assignees_url":"https://api.github.com/repos/keen/explorer/assignees{/user}","branches_url":"https://api.github.com/repos/keen/explorer/branches{/branch}","tags_url":"https://api.github.com/repos/keen/explorer/tags","blobs_url":"https://api.github.com/repos/keen/explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keen/explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keen/explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/keen/explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keen/explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/keen/explorer/languages","stargazers_url":"https://api.github.com/repos/keen/explorer/stargazers","contributors_url":"https://api.github.com/repos/keen/explorer/contributors","subscribers_url":"https://api.github.com/repos/keen/explorer/subscribers","subscription_url":"https://api.github.com/repos/keen/explorer/subscription","commits_url":"https://api.github.com/repos/keen/explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/keen/explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/keen/explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/keen/explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/keen/explorer/contents/{+path}","compare_url":"https://api.github.com/repos/keen/explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keen/explorer/merges","archive_url":"https://api.github.com/repos/keen/explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keen/explorer/downloads","issues_url":"https://api.github.com/repos/keen/explorer/issues{/number}","pulls_url":"https://api.github.com/repos/keen/explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/keen/explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/keen/explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keen/explorer/labels{/name}","releases_url":"https://api.github.com/repos/keen/explorer/releases{/id}","created_at":"2015-06-11T17:56:40Z","updated_at":"2015-11-09T20:37:46Z","pushed_at":"2015-11-10T16:18:13Z","git_url":"git://github.com/keen/explorer.git","ssh_url":"git@github.com:keen/explorer.git","clone_url":"https://github.com/keen/explorer.git","svn_url":"https://github.com/keen/explorer","homepage":"https://keen.github.io/explorer","size":14882,"stargazers_count":559,"watchers_count":559,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":3,"forks":38,"open_issues":3,"watchers":559,"default_branch":"master"}},"base":{"label":"keen:master","ref":"master","sha":"f7990a62d8435c5eee6f468f83276e270865c4b3","user":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"repo":{"id":37276906,"name":"explorer","full_name":"keen/explorer","owner":{"login":"keen","id":8461781,"avatar_url":"https://avatars.githubusercontent.com/u/8461781?v=3","gravatar_id":"","url":"https://api.github.com/users/keen","html_url":"https://github.com/keen","followers_url":"https://api.github.com/users/keen/followers","following_url":"https://api.github.com/users/keen/following{/other_user}","gists_url":"https://api.github.com/users/keen/gists{/gist_id}","starred_url":"https://api.github.com/users/keen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keen/subscriptions","organizations_url":"https://api.github.com/users/keen/orgs","repos_url":"https://api.github.com/users/keen/repos","events_url":"https://api.github.com/users/keen/events{/privacy}","received_events_url":"https://api.github.com/users/keen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keen/explorer","description":"Data Explorer by Keen IO","fork":false,"url":"https://api.github.com/repos/keen/explorer","forks_url":"https://api.github.com/repos/keen/explorer/forks","keys_url":"https://api.github.com/repos/keen/explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keen/explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keen/explorer/teams","hooks_url":"https://api.github.com/repos/keen/explorer/hooks","issue_events_url":"https://api.github.com/repos/keen/explorer/issues/events{/number}","events_url":"https://api.github.com/repos/keen/explorer/events","assignees_url":"https://api.github.com/repos/keen/explorer/assignees{/user}","branches_url":"https://api.github.com/repos/keen/explorer/branches{/branch}","tags_url":"https://api.github.com/repos/keen/explorer/tags","blobs_url":"https://api.github.com/repos/keen/explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keen/explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keen/explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/keen/explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keen/explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/keen/explorer/languages","stargazers_url":"https://api.github.com/repos/keen/explorer/stargazers","contributors_url":"https://api.github.com/repos/keen/explorer/contributors","subscribers_url":"https://api.github.com/repos/keen/explorer/subscribers","subscription_url":"https://api.github.com/repos/keen/explorer/subscription","commits_url":"https://api.github.com/repos/keen/explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/keen/explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/keen/explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/keen/explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/keen/explorer/contents/{+path}","compare_url":"https://api.github.com/repos/keen/explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keen/explorer/merges","archive_url":"https://api.github.com/repos/keen/explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keen/explorer/downloads","issues_url":"https://api.github.com/repos/keen/explorer/issues{/number}","pulls_url":"https://api.github.com/repos/keen/explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/keen/explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/keen/explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keen/explorer/labels{/name}","releases_url":"https://api.github.com/repos/keen/explorer/releases{/id}","created_at":"2015-06-11T17:56:40Z","updated_at":"2015-11-09T20:37:46Z","pushed_at":"2015-11-10T16:18:13Z","git_url":"git://github.com/keen/explorer.git","ssh_url":"git@github.com:keen/explorer.git","clone_url":"https://github.com/keen/explorer.git","svn_url":"https://github.com/keen/explorer","homepage":"https://keen.github.io/explorer","size":14882,"stargazers_count":559,"watchers_count":559,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":3,"forks":38,"open_issues":3,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keen/explorer/pulls/46"},"html":{"href":"https://github.com/keen/explorer/pull/46"},"issue":{"href":"https://api.github.com/repos/keen/explorer/issues/46"},"comments":{"href":"https://api.github.com/repos/keen/explorer/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/keen/explorer/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/keen/explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keen/explorer/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/keen/explorer/statuses/cee8c785bafb292b984eba78c8c831670d416ea2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":322,"deletions":289,"changed_files":3}}