{"action":"opened","number":293,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293","id":36966145,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/293","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/293.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/293.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/293","number":293,"state":"open","locked":false,"title":"Ensure the _KillProcess task is always cancelled.","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"body":"Errors raised in [`subprocess.Popen.communicate`](https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/651c7558321db1d5dc6b641453a376467cc1b2a1/perfkitbenchmarker/vm_util.py#L394) (e.g. `KeyboardInterrupt`) cause the process to hang without exiting, since the `Timer` thread does not exit.\n\nWhen a timeout is set, this will exit after the timer elapses. Without a timeout, the process hangs indefinitely.\n\nNewly-added test hangs prior to making this change.","created_at":"2015-06-04T18:54:12Z","updated_at":"2015-06-04T18:54:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/293/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/8aed174bbd6b1d9c98755282dda84d14e531df88","head":{"label":"cmccoy:fix-timer","ref":"fix-timer","sha":"8aed174bbd6b1d9c98755282dda84d14e531df88","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"repo":{"id":34029803,"name":"PerfKitBenchmarker","full_name":"cmccoy/PerfKitBenchmarker","owner":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmccoy/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/cmccoy/PerfKitBenchmarker/releases{/id}","created_at":"2015-04-16T02:24:48Z","updated_at":"2015-04-18T13:31:32Z","pushed_at":"2015-06-04T18:53:36Z","git_url":"git://github.com/cmccoy/PerfKitBenchmarker.git","ssh_url":"git@github.com:cmccoy/PerfKitBenchmarker.git","clone_url":"https://github.com/cmccoy/PerfKitBenchmarker.git","svn_url":"https://github.com/cmccoy/PerfKitBenchmarker","homepage":"","size":2101,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:dev","ref":"dev","sha":"e14e24571b5b2f959293a1fc8bd547b7de5eca76","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-06-02T15:15:00Z","pushed_at":"2015-06-04T16:49:40Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":153011,"stargazers_count":447,"watchers_count":447,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":70,"forks":52,"open_issues":70,"watchers":447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/293"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/293"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/8aed174bbd6b1d9c98755282dda84d14e531df88"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":3,"changed_files":2}}