{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/26757823","id":26757823,"diff_hunk":"@@ -66,9 +66,9 @@ bool TizenMetaDataHandler::Parse(scoped_refptr<ApplicationData> application,\n   const Manifest* manifest = application->GetManifest();\n   DCHECK(manifest);\n \n-  base::Value* metadata_value = NULL;\n+  base::Value* metadata_value = nullptr;\n   if (!manifest->Get(keys::kTizenMetaDataKey, &metadata_value)) {\n-    *error = base::ASCIIToUTF16(\"Failed to get value of tizen metaData\");\n+    return true;","path":"application/common/manifest_handlers/tizen_metadata_handler.cc","position":8,"original_position":8,"commit_id":"384711c6c634eca51827a81e42a79d2e54794436","original_commit_id":"384711c6c634eca51827a81e42a79d2e54794436","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"body":"Methods Get() and HasPath() calls CanAccessPath() internally so I made choise just to call one.\r\nSetting error is not needed.","created_at":"2015-03-19T14:19:59Z","updated_at":"2015-03-19T14:19:59Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/2911#discussion_r26757823","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/26757823"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2911#discussion_r26757823"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911","id":31514419,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/2911","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/2911.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/2911.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2911","number":2911,"state":"open","locked":false,"title":"[Tizen] Fix parser handlers","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"body":"In current execution flow, there is call of Parse() function\r\nfor each handler. Handler should be prepared for situation that\r\nthere is no value it expects.\r\n\r\nFollowing handlers are broken:\r\n - AppControl,\r\n - Category,\r\n - Ime,\r\n - Metadata.\r\n\r\nBUG=XWALK-3774","created_at":"2015-03-19T11:23:47Z","updated_at":"2015-03-19T14:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b53b3acc7ea0a8bd91ab58966da27e34211ded3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2911/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/384711c6c634eca51827a81e42a79d2e54794436","head":{"label":"tiwanek:XWALK-3774","ref":"XWALK-3774","sha":"384711c6c634eca51827a81e42a79d2e54794436","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"repo":{"id":19305661,"name":"crosswalk","full_name":"tiwanek/crosswalk","owner":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiwanek/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/tiwanek/crosswalk","forks_url":"https://api.github.com/repos/tiwanek/crosswalk/forks","keys_url":"https://api.github.com/repos/tiwanek/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiwanek/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiwanek/crosswalk/teams","hooks_url":"https://api.github.com/repos/tiwanek/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/tiwanek/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/tiwanek/crosswalk/events","assignees_url":"https://api.github.com/repos/tiwanek/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/tiwanek/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/tiwanek/crosswalk/tags","blobs_url":"https://api.github.com/repos/tiwanek/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiwanek/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiwanek/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiwanek/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiwanek/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/tiwanek/crosswalk/languages","stargazers_url":"https://api.github.com/repos/tiwanek/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/tiwanek/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/tiwanek/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/tiwanek/crosswalk/subscription","commits_url":"https://api.github.com/repos/tiwanek/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiwanek/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiwanek/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiwanek/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiwanek/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/tiwanek/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiwanek/crosswalk/merges","archive_url":"https://api.github.com/repos/tiwanek/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiwanek/crosswalk/downloads","issues_url":"https://api.github.com/repos/tiwanek/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/tiwanek/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/tiwanek/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/tiwanek/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiwanek/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/tiwanek/crosswalk/releases{/id}","created_at":"2014-04-30T07:54:30Z","updated_at":"2014-09-01T13:20:14Z","pushed_at":"2015-03-19T11:23:22Z","git_url":"git://github.com/tiwanek/crosswalk.git","ssh_url":"git@github.com:tiwanek/crosswalk.git","clone_url":"https://github.com/tiwanek/crosswalk.git","svn_url":"https://github.com/tiwanek/crosswalk","homepage":"","size":12467,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"4ec25307702a4b811f0e0dec331a4a4d2e99dae8","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2015-03-19T01:39:23Z","pushed_at":"2015-03-18T17:33:45Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":135882,"stargazers_count":696,"watchers_count":696,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":116,"forks":218,"open_issues":116,"watchers":696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2911"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2911"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2911/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2911/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/384711c6c634eca51827a81e42a79d2e54794436"}}}}