{"action":"created","comment":{"url":"https://api.github.com/repos/lookout/zipkin/pulls/comments/22695081","id":22695081,"diff_hunk":"@@ -1,28 +1,29 @@\n package com.twitter.zipkin.receiver.kafka\n \n import com.twitter.logging.Logger\n-import kafka.consumer.KafkaStream\n-import com.twitter.zipkin.thriftscala.{Span => ThriftSpan}\n import com.twitter.util.{Await, Future}\n+import com.twitter.zipkin.thriftscala.{Span => ThriftSpan}\n+import kafka.consumer.KafkaStream\n \n-case class KafkaStreamProcessor(\n-  stream: KafkaStream[Option[List[ThriftSpan]], Option[List[ThriftSpan]]],\n+case class KafkaStreamProcessor[T](\n+  stream: KafkaStream[T, Option[List[ThriftSpan]]],","path":"zipkin-receiver-kafka/src/main/scala/com/twitter/zipkin/receiver/kafka/KafkaStreamProcessor.scala","position":13,"original_position":13,"commit_id":"cdebc7f932a97731e4859502877c24f988aec5ff","original_commit_id":"5e383f7338e1b417faf06026f49a5906b810cf02","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"body":"its almost like its digging down too deep getting the contents of the Seq instead of the Seq.  Its not obvious where in the KafkaStream or ConsumerIterator its doing this","created_at":"2015-01-09T00:39:45Z","updated_at":"2015-01-09T00:39:45Z","html_url":"https://github.com/lookout/zipkin/pull/8#discussion_r22695081","pull_request_url":"https://api.github.com/repos/lookout/zipkin/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/comments/22695081"},"html":{"href":"https://github.com/lookout/zipkin/pull/8#discussion_r22695081"},"pull_request":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/lookout/zipkin/pulls/8","id":27062961,"html_url":"https://github.com/lookout/zipkin/pull/8","diff_url":"https://github.com/lookout/zipkin/pull/8.diff","patch_url":"https://github.com/lookout/zipkin/pull/8.patch","issue_url":"https://api.github.com/repos/lookout/zipkin/issues/8","number":8,"state":"open","locked":false,"title":"Merge upstream","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"body":"* merge upstream\r\n* refactor span decoder","created_at":"2015-01-08T21:54:07Z","updated_at":"2015-01-09T00:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"351c2ed79a970415df9de7d2d84bbdde2f8db616","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lookout/zipkin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/lookout/zipkin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/lookout/zipkin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lookout/zipkin/issues/8/comments","statuses_url":"https://api.github.com/repos/lookout/zipkin/statuses/cdebc7f932a97731e4859502877c24f988aec5ff","head":{"label":"jamescway:add_upstream","ref":"add_upstream","sha":"cdebc7f932a97731e4859502877c24f988aec5ff","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"repo":{"id":27607951,"name":"zipkin","full_name":"jamescway/zipkin","owner":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamescway/zipkin","description":"Zipkin is a distributed tracing system","fork":true,"url":"https://api.github.com/repos/jamescway/zipkin","forks_url":"https://api.github.com/repos/jamescway/zipkin/forks","keys_url":"https://api.github.com/repos/jamescway/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamescway/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamescway/zipkin/teams","hooks_url":"https://api.github.com/repos/jamescway/zipkin/hooks","issue_events_url":"https://api.github.com/repos/jamescway/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/jamescway/zipkin/events","assignees_url":"https://api.github.com/repos/jamescway/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/jamescway/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/jamescway/zipkin/tags","blobs_url":"https://api.github.com/repos/jamescway/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamescway/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamescway/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamescway/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamescway/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/jamescway/zipkin/languages","stargazers_url":"https://api.github.com/repos/jamescway/zipkin/stargazers","contributors_url":"https://api.github.com/repos/jamescway/zipkin/contributors","subscribers_url":"https://api.github.com/repos/jamescway/zipkin/subscribers","subscription_url":"https://api.github.com/repos/jamescway/zipkin/subscription","commits_url":"https://api.github.com/repos/jamescway/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamescway/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamescway/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamescway/zipkin/issues/comments/{number}","contents_url":"https://api.github.com/repos/jamescway/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/jamescway/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamescway/zipkin/merges","archive_url":"https://api.github.com/repos/jamescway/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamescway/zipkin/downloads","issues_url":"https://api.github.com/repos/jamescway/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/jamescway/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/jamescway/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/jamescway/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamescway/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/jamescway/zipkin/releases{/id}","created_at":"2014-12-05T20:04:30Z","updated_at":"2014-12-18T21:10:20Z","pushed_at":"2015-01-09T00:38:21Z","git_url":"git://github.com/jamescway/zipkin.git","ssh_url":"git@github.com:jamescway/zipkin.git","clone_url":"https://github.com/jamescway/zipkin.git","svn_url":"https://github.com/jamescway/zipkin","homepage":"http://twitter.github.io/zipkin","size":3460,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lookout:lookout","ref":"lookout","sha":"aefec1bd0f5f98c16aeb1074c991b02fbfe1a89c","user":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"repo":{"id":22450363,"name":"zipkin","full_name":"lookout/zipkin","owner":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lookout/zipkin","description":"Zipkin is a distributed tracing system","fork":true,"url":"https://api.github.com/repos/lookout/zipkin","forks_url":"https://api.github.com/repos/lookout/zipkin/forks","keys_url":"https://api.github.com/repos/lookout/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookout/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookout/zipkin/teams","hooks_url":"https://api.github.com/repos/lookout/zipkin/hooks","issue_events_url":"https://api.github.com/repos/lookout/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/lookout/zipkin/events","assignees_url":"https://api.github.com/repos/lookout/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/lookout/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/lookout/zipkin/tags","blobs_url":"https://api.github.com/repos/lookout/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookout/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookout/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookout/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookout/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/lookout/zipkin/languages","stargazers_url":"https://api.github.com/repos/lookout/zipkin/stargazers","contributors_url":"https://api.github.com/repos/lookout/zipkin/contributors","subscribers_url":"https://api.github.com/repos/lookout/zipkin/subscribers","subscription_url":"https://api.github.com/repos/lookout/zipkin/subscription","commits_url":"https://api.github.com/repos/lookout/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookout/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookout/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookout/zipkin/issues/comments/{number}","contents_url":"https://api.github.com/repos/lookout/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/lookout/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookout/zipkin/merges","archive_url":"https://api.github.com/repos/lookout/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookout/zipkin/downloads","issues_url":"https://api.github.com/repos/lookout/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/lookout/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/lookout/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/lookout/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookout/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/lookout/zipkin/releases{/id}","created_at":"2014-07-31T00:41:34Z","updated_at":"2015-01-07T18:54:30Z","pushed_at":"2015-01-08T00:49:12Z","git_url":"git://github.com/lookout/zipkin.git","ssh_url":"git@github.com:lookout/zipkin.git","clone_url":"https://github.com/lookout/zipkin.git","svn_url":"https://github.com/lookout/zipkin","homepage":"http://twitter.github.io/zipkin","size":3527,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"lookout"}},"_links":{"self":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/8"},"html":{"href":"https://github.com/lookout/zipkin/pull/8"},"issue":{"href":"https://api.github.com/repos/lookout/zipkin/issues/8"},"comments":{"href":"https://api.github.com/repos/lookout/zipkin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lookout/zipkin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/lookout/zipkin/statuses/cdebc7f932a97731e4859502877c24f988aec5ff"}}}}