{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/csvw/issues/362","labels_url":"https://api.github.com/repos/w3c/csvw/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/w3c/csvw/issues/362/comments","events_url":"https://api.github.com/repos/w3c/csvw/issues/362/events","html_url":"https://github.com/w3c/csvw/pull/362","id":61651389,"number":362,"title":"Tried to simplify the JSON generation","user":{"login":"iherman","id":520723,"avatar_url":"https://avatars.githubusercontent.com/u/520723?v=3","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-14T17:11:20Z","updated_at":"2015-03-14T19:25:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/csvw/pulls/362","html_url":"https://github.com/w3c/csvw/pull/362","diff_url":"https://github.com/w3c/csvw/pull/362.diff","patch_url":"https://github.com/w3c/csvw/pull/362.patch"},"body":"Did this by:\r\n\r\n* separating the minimal and standard modes into separate sections\r\n* calling out to the (common) algorithms for the generation of objects for a row and for nesting\r\n\r\nThis approach came from the discussion in #299\r\n\r\n/Cc @gkellogg @6a6d74 "},"comment":{"url":"https://api.github.com/repos/w3c/csvw/issues/comments/80686059","html_url":"https://github.com/w3c/csvw/pull/362#issuecomment-80686059","issue_url":"https://api.github.com/repos/w3c/csvw/issues/362","id":80686059,"user":{"login":"gkellogg","id":46296,"avatar_url":"https://avatars.githubusercontent.com/u/46296?v=3","gravatar_id":"","url":"https://api.github.com/users/gkellogg","html_url":"https://github.com/gkellogg","followers_url":"https://api.github.com/users/gkellogg/followers","following_url":"https://api.github.com/users/gkellogg/following{/other_user}","gists_url":"https://api.github.com/users/gkellogg/gists{/gist_id}","starred_url":"https://api.github.com/users/gkellogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkellogg/subscriptions","organizations_url":"https://api.github.com/users/gkellogg/orgs","repos_url":"https://api.github.com/users/gkellogg/repos","events_url":"https://api.github.com/users/gkellogg/events{/privacy}","received_events_url":"https://api.github.com/users/gkellogg/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T19:25:08Z","updated_at":"2015-03-14T19:25:08Z","body":"A couple if issues here, some of which relate to the original algorithm:\r\n\r\n* [ ] \"Generating of Objects\" => \"Generating Objects\"\r\n* [ ] Step 3.1 of Generating the Objects; `propertyUrl` is expanded in the metadata definition of [URI Template Properties](http://w3c.github.io/csvw/metadata/#uri-template-properties). These should be re-compacted to terms or prefixed names to be used as property names.\r\n* [ ] Step 3.2-3.4 of Generating the Objects say to _insert_ the value; some provision must be made if such a value already exists due to a previous cell using the same property.\r\n* [ ] In Generating Nested Objects, there is the following statement: \"referred to once and only once by another object Sk through a reference originating from an `aboutUrl` value\". Should that be `valueUrl`?\r\n* [ ] In Generating Nested Objects, when looking for values to substitute, these should be values generated from `valueUrl` rather than a cell value which was a literal."}}