{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/1603","labels_url":"https://api.github.com/repos/openshift/origin/issues/1603/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1603/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/1603/events","html_url":"https://github.com/openshift/origin/pull/1603","id":66643508,"number":1603,"title":"perform an initial commit and add a probe delay","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-06T16:24:55Z","updated_at":"2015-04-08T03:44:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1603","html_url":"https://github.com/openshift/origin/pull/1603","diff_url":"https://github.com/openshift/origin/pull/1603.diff","patch_url":"https://github.com/openshift/origin/pull/1603.patch"},"body":"These changes address the following:\r\n\r\n1.  The router does not start automatically.  A commit was only happen when a watch event was processed.  If the watch configuration was wrong then a config is never written and haproxy is never started.  A new commit is added to the plugin to write an empty state config file after creating a new router\r\n2.  Delay probes for 60 seconds to allow the router time to write the config file (with the new initial commit) and be started before failing containers.  \r\n\r\n@pmorie PTAL at the plugin changes\r\n@deads2k - this is the PR that I was mentioning in IRC that should help with e2e transient failures\r\n@jimmidyson @sdodson - as discussed on https://github.com/openshift/origin/pull/1575 and https://github.com/openshift/origin/issues/1504#issuecomment-88945808"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/90795213","html_url":"https://github.com/openshift/origin/pull/1603#issuecomment-90795213","issue_url":"https://api.github.com/repos/openshift/origin/issues/1603","id":90795213,"user":{"login":"jimmidyson","id":464659,"avatar_url":"https://avatars.githubusercontent.com/u/464659?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T03:44:07Z","updated_at":"2015-04-08T03:44:07Z","body":"The 60 seconds came from when we weren't writing the config file out until first watch event received - it was a safe number to prevent pod being killed as liveness probe failed. Now this pr writes config before first watch event we should probably be safe to reduce or even remove this delay."}}