{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8","id":54412689,"html_url":"https://github.com/BasFaggingerAuer/tiny-game-engine/pull/8","diff_url":"https://github.com/BasFaggingerAuer/tiny-game-engine/pull/8.diff","patch_url":"https://github.com/BasFaggingerAuer/tiny-game-engine/pull/8.patch","issue_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/8","number":8,"state":"closed","locked":false,"title":"Move function bodies of TextBox class to .cpp","user":{"login":"takenu","id":11860163,"avatar_url":"https://avatars.githubusercontent.com/u/11860163?v=3","gravatar_id":"","url":"https://api.github.com/users/takenu","html_url":"https://github.com/takenu","followers_url":"https://api.github.com/users/takenu/followers","following_url":"https://api.github.com/users/takenu/following{/other_user}","gists_url":"https://api.github.com/users/takenu/gists{/gist_id}","starred_url":"https://api.github.com/users/takenu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takenu/subscriptions","organizations_url":"https://api.github.com/users/takenu/orgs","repos_url":"https://api.github.com/users/takenu/repos","events_url":"https://api.github.com/users/takenu/events{/privacy}","received_events_url":"https://api.github.com/users/takenu/received_events","type":"User","site_admin":false},"body":"As requested in the initial pull request #7, I moved all function code to a source file, except for empty functions (which probably should not delay the compiler) and the functions of /tiny/draw/colour.hpp (which are extremely simple and not really worth making yet another .cpp). This is expected to help making compilation faster.\r\n\r\nAlso, I made a slight functional adjustment through adding a ScreenIconHorde::eraseText() function to erase the current contents of the ScreenIconHorde. This should allow cleaning up its contents, which could be useful in the case that the text to be displayed changes to something with fewer characters than the initial text string.","created_at":"2015-12-22T20:41:35Z","updated_at":"2015-12-23T11:18:24Z","closed_at":"2015-12-23T11:18:24Z","merged_at":"2015-12-23T11:18:24Z","merge_commit_sha":"757839a8a66b580f187c314a1f81fe5c8f948453","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8/commits","review_comments_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8/comments","review_comment_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/8/comments","statuses_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/statuses/bb4a926f93801aedc3b5d96f3e542f136b98bab0","head":{"label":"takenu:font","ref":"font","sha":"bb4a926f93801aedc3b5d96f3e542f136b98bab0","user":{"login":"takenu","id":11860163,"avatar_url":"https://avatars.githubusercontent.com/u/11860163?v=3","gravatar_id":"","url":"https://api.github.com/users/takenu","html_url":"https://github.com/takenu","followers_url":"https://api.github.com/users/takenu/followers","following_url":"https://api.github.com/users/takenu/following{/other_user}","gists_url":"https://api.github.com/users/takenu/gists{/gist_id}","starred_url":"https://api.github.com/users/takenu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takenu/subscriptions","organizations_url":"https://api.github.com/users/takenu/orgs","repos_url":"https://api.github.com/users/takenu/repos","events_url":"https://api.github.com/users/takenu/events{/privacy}","received_events_url":"https://api.github.com/users/takenu/received_events","type":"User","site_admin":false},"repo":{"id":34975503,"name":"tiny-game-engine","full_name":"takenu/tiny-game-engine","owner":{"login":"takenu","id":11860163,"avatar_url":"https://avatars.githubusercontent.com/u/11860163?v=3","gravatar_id":"","url":"https://api.github.com/users/takenu","html_url":"https://github.com/takenu","followers_url":"https://api.github.com/users/takenu/followers","following_url":"https://api.github.com/users/takenu/following{/other_user}","gists_url":"https://api.github.com/users/takenu/gists{/gist_id}","starred_url":"https://api.github.com/users/takenu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takenu/subscriptions","organizations_url":"https://api.github.com/users/takenu/orgs","repos_url":"https://api.github.com/users/takenu/repos","events_url":"https://api.github.com/users/takenu/events{/privacy}","received_events_url":"https://api.github.com/users/takenu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takenu/tiny-game-engine","description":"A small OpenGL game engine.","fork":true,"url":"https://api.github.com/repos/takenu/tiny-game-engine","forks_url":"https://api.github.com/repos/takenu/tiny-game-engine/forks","keys_url":"https://api.github.com/repos/takenu/tiny-game-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takenu/tiny-game-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takenu/tiny-game-engine/teams","hooks_url":"https://api.github.com/repos/takenu/tiny-game-engine/hooks","issue_events_url":"https://api.github.com/repos/takenu/tiny-game-engine/issues/events{/number}","events_url":"https://api.github.com/repos/takenu/tiny-game-engine/events","assignees_url":"https://api.github.com/repos/takenu/tiny-game-engine/assignees{/user}","branches_url":"https://api.github.com/repos/takenu/tiny-game-engine/branches{/branch}","tags_url":"https://api.github.com/repos/takenu/tiny-game-engine/tags","blobs_url":"https://api.github.com/repos/takenu/tiny-game-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takenu/tiny-game-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takenu/tiny-game-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/takenu/tiny-game-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takenu/tiny-game-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/takenu/tiny-game-engine/languages","stargazers_url":"https://api.github.com/repos/takenu/tiny-game-engine/stargazers","contributors_url":"https://api.github.com/repos/takenu/tiny-game-engine/contributors","subscribers_url":"https://api.github.com/repos/takenu/tiny-game-engine/subscribers","subscription_url":"https://api.github.com/repos/takenu/tiny-game-engine/subscription","commits_url":"https://api.github.com/repos/takenu/tiny-game-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/takenu/tiny-game-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/takenu/tiny-game-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/takenu/tiny-game-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/takenu/tiny-game-engine/contents/{+path}","compare_url":"https://api.github.com/repos/takenu/tiny-game-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takenu/tiny-game-engine/merges","archive_url":"https://api.github.com/repos/takenu/tiny-game-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takenu/tiny-game-engine/downloads","issues_url":"https://api.github.com/repos/takenu/tiny-game-engine/issues{/number}","pulls_url":"https://api.github.com/repos/takenu/tiny-game-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/takenu/tiny-game-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/takenu/tiny-game-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takenu/tiny-game-engine/labels{/name}","releases_url":"https://api.github.com/repos/takenu/tiny-game-engine/releases{/id}","created_at":"2015-05-03T05:57:49Z","updated_at":"2015-05-03T06:01:44Z","pushed_at":"2015-12-22T21:19:47Z","git_url":"git://github.com/takenu/tiny-game-engine.git","ssh_url":"git@github.com:takenu/tiny-game-engine.git","clone_url":"https://github.com/takenu/tiny-game-engine.git","svn_url":"https://github.com/takenu/tiny-game-engine","homepage":null,"size":26316,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BasFaggingerAuer:master","ref":"master","sha":"5aa0aedae6a3dbcd1e1346cdaf0ac7bd236802c5","user":{"login":"BasFaggingerAuer","id":1456958,"avatar_url":"https://avatars.githubusercontent.com/u/1456958?v=3","gravatar_id":"","url":"https://api.github.com/users/BasFaggingerAuer","html_url":"https://github.com/BasFaggingerAuer","followers_url":"https://api.github.com/users/BasFaggingerAuer/followers","following_url":"https://api.github.com/users/BasFaggingerAuer/following{/other_user}","gists_url":"https://api.github.com/users/BasFaggingerAuer/gists{/gist_id}","starred_url":"https://api.github.com/users/BasFaggingerAuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasFaggingerAuer/subscriptions","organizations_url":"https://api.github.com/users/BasFaggingerAuer/orgs","repos_url":"https://api.github.com/users/BasFaggingerAuer/repos","events_url":"https://api.github.com/users/BasFaggingerAuer/events{/privacy}","received_events_url":"https://api.github.com/users/BasFaggingerAuer/received_events","type":"User","site_admin":false},"repo":{"id":6428407,"name":"tiny-game-engine","full_name":"BasFaggingerAuer/tiny-game-engine","owner":{"login":"BasFaggingerAuer","id":1456958,"avatar_url":"https://avatars.githubusercontent.com/u/1456958?v=3","gravatar_id":"","url":"https://api.github.com/users/BasFaggingerAuer","html_url":"https://github.com/BasFaggingerAuer","followers_url":"https://api.github.com/users/BasFaggingerAuer/followers","following_url":"https://api.github.com/users/BasFaggingerAuer/following{/other_user}","gists_url":"https://api.github.com/users/BasFaggingerAuer/gists{/gist_id}","starred_url":"https://api.github.com/users/BasFaggingerAuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasFaggingerAuer/subscriptions","organizations_url":"https://api.github.com/users/BasFaggingerAuer/orgs","repos_url":"https://api.github.com/users/BasFaggingerAuer/repos","events_url":"https://api.github.com/users/BasFaggingerAuer/events{/privacy}","received_events_url":"https://api.github.com/users/BasFaggingerAuer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BasFaggingerAuer/tiny-game-engine","description":"A small OpenGL game engine.","fork":false,"url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine","forks_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/forks","keys_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/teams","hooks_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/hooks","issue_events_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/events{/number}","events_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/events","assignees_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/assignees{/user}","branches_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/branches{/branch}","tags_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/tags","blobs_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/languages","stargazers_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/stargazers","contributors_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/contributors","subscribers_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/subscribers","subscription_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/subscription","commits_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/contents/{+path}","compare_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/merges","archive_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/downloads","issues_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues{/number}","pulls_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/labels{/name}","releases_url":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/releases{/id}","created_at":"2012-10-28T14:44:28Z","updated_at":"2015-10-09T11:39:10Z","pushed_at":"2015-12-23T11:18:24Z","git_url":"git://github.com/BasFaggingerAuer/tiny-game-engine.git","ssh_url":"git@github.com:BasFaggingerAuer/tiny-game-engine.git","clone_url":"https://github.com/BasFaggingerAuer/tiny-game-engine.git","svn_url":"https://github.com/BasFaggingerAuer/tiny-game-engine","homepage":null,"size":26307,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8"},"html":{"href":"https://github.com/BasFaggingerAuer/tiny-game-engine/pull/8"},"issue":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/8"},"comments":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/BasFaggingerAuer/tiny-game-engine/statuses/bb4a926f93801aedc3b5d96f3e542f136b98bab0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"BasFaggingerAuer","id":1456958,"avatar_url":"https://avatars.githubusercontent.com/u/1456958?v=3","gravatar_id":"","url":"https://api.github.com/users/BasFaggingerAuer","html_url":"https://github.com/BasFaggingerAuer","followers_url":"https://api.github.com/users/BasFaggingerAuer/followers","following_url":"https://api.github.com/users/BasFaggingerAuer/following{/other_user}","gists_url":"https://api.github.com/users/BasFaggingerAuer/gists{/gist_id}","starred_url":"https://api.github.com/users/BasFaggingerAuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasFaggingerAuer/subscriptions","organizations_url":"https://api.github.com/users/BasFaggingerAuer/orgs","repos_url":"https://api.github.com/users/BasFaggingerAuer/repos","events_url":"https://api.github.com/users/BasFaggingerAuer/events{/privacy}","received_events_url":"https://api.github.com/users/BasFaggingerAuer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":119,"deletions":58,"changed_files":5}}