{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/48175591","id":48175591,"diff_hunk":"@@ -194,6 +195,14 @@ angular\n         templateUrl: 'views/browse/service.html',\n         controller: 'ServiceController'\n       })\n+      .when('/project/:project/browse/storage', {\n+        templateUrl: 'views/storage.html',\n+        controller: 'StorageController'\n+      })\n+      .when('/project/:project/browse/persistentvolumeclaims/:pvc', {","path":"assets/app/scripts/app.js","position":16,"original_position":16,"commit_id":"e30644b71db82254ece74f1a716d9bd89160f948","original_commit_id":"c941e1ab2411eb567a32e53a36282c05811e5b1b","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"I do actually prefer that option @fabianofranz ...cleaner, and seems like it will help us continue to add urls in an organized way in the future. ","created_at":"2015-12-21T18:38:53Z","updated_at":"2015-12-21T18:38:53Z","html_url":"https://github.com/openshift/origin/pull/6358#discussion_r48175591","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6358","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/48175591"},"html":{"href":"https://github.com/openshift/origin/pull/6358#discussion_r48175591"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6358"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6358","id":53928605,"html_url":"https://github.com/openshift/origin/pull/6358","diff_url":"https://github.com/openshift/origin/pull/6358.diff","patch_url":"https://github.com/openshift/origin/pull/6358.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6358","number":6358,"state":"open","locked":false,"title":"[WIP] [DO-NOT-MERGE] Web console: display and attach persistent volume claims","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"Code is **not yet ready for review** but I'm opening this for design feedback. PTAL @jwforres @ajacobs21e @spadgett @benjaminapetersen \r\n\r\nList all existing persistent volume claims, this is under *Browse/Storage*. The \"Status\" column represents the fulfilment of a claim against actual volumes in the cluster. You can click a claim to see the detail page with a little more information.\r\n\r\n![pvcs](https://cloud.githubusercontent.com/assets/158611/11859716/eefae26c-a454-11e5-83e0-072ce7021c14.png)\r\n\r\nNow how do we attach an existing persistent volume claim to pods? Volumes allow you to attach a pvc to *any resource that declares a pod spec*, so deployment configs, deployments (replication controllers in practice), etc. It does not seem possible to attach to a pod directly, and attaching to a deployment does not seem to make much sense (will not cause a new deployment so I think the pods would only be affected if a redeployment occurs). So I'm only supporting attaching to deployment configs at the moment, but other kinds can be added easily. \r\n\r\nI'm doing this in the deployment config details page using the *Attach persistent volume claim* link (similar to how it's done in *Create route*). Volumes were not yet present in the deployment config details page, so I added it mostly with the same design it's displayed in pod details, but together with the \"Template\" section (since it's not volumes *of the deployment config*, but of the template that will result in the dc's pods).\r\n\r\n![dc-attach-pvc](https://cloud.githubusercontent.com/assets/158611/11859720/f73ae314-a454-11e5-9d83-2a7474163430.png)\r\n\r\nHere is where you attach an existing persistent volume claim to a deployment config. I'm not particularly happy with the dropdown for the pvcs, it would be interesting to have more information (probably capacity, status and access modes) instead of just the name, so that it's more clear to users what's the pvc they are attaching to. What would you suggest, maybe radios? Also, it's still missing a few simple inputs (mount path, volume name, etc).\r\n\r\n~~[deprecated screenshot](https://cloud.githubusercontent.com/assets/158611/11859721/fcc58bf4-a454-11e5-92b4-11e1b4eb155b.png)~~\r\n","created_at":"2015-12-17T02:51:08Z","updated_at":"2015-12-21T18:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f363e9458493aa3b17d3ecfe993354a5c13a77a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6358/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6358/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6358/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/e30644b71db82254ece74f1a716d9bd89160f948","head":{"label":"fabianofranz:500_pvc_on_console","ref":"500_pvc_on_console","sha":"e30644b71db82254ece74f1a716d9bd89160f948","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"repo":{"id":23366851,"name":"origin","full_name":"fabianofranz/origin","owner":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabianofranz/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/fabianofranz/origin","forks_url":"https://api.github.com/repos/fabianofranz/origin/forks","keys_url":"https://api.github.com/repos/fabianofranz/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabianofranz/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabianofranz/origin/teams","hooks_url":"https://api.github.com/repos/fabianofranz/origin/hooks","issue_events_url":"https://api.github.com/repos/fabianofranz/origin/issues/events{/number}","events_url":"https://api.github.com/repos/fabianofranz/origin/events","assignees_url":"https://api.github.com/repos/fabianofranz/origin/assignees{/user}","branches_url":"https://api.github.com/repos/fabianofranz/origin/branches{/branch}","tags_url":"https://api.github.com/repos/fabianofranz/origin/tags","blobs_url":"https://api.github.com/repos/fabianofranz/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabianofranz/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabianofranz/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabianofranz/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabianofranz/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabianofranz/origin/languages","stargazers_url":"https://api.github.com/repos/fabianofranz/origin/stargazers","contributors_url":"https://api.github.com/repos/fabianofranz/origin/contributors","subscribers_url":"https://api.github.com/repos/fabianofranz/origin/subscribers","subscription_url":"https://api.github.com/repos/fabianofranz/origin/subscription","commits_url":"https://api.github.com/repos/fabianofranz/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabianofranz/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabianofranz/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabianofranz/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabianofranz/origin/contents/{+path}","compare_url":"https://api.github.com/repos/fabianofranz/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabianofranz/origin/merges","archive_url":"https://api.github.com/repos/fabianofranz/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabianofranz/origin/downloads","issues_url":"https://api.github.com/repos/fabianofranz/origin/issues{/number}","pulls_url":"https://api.github.com/repos/fabianofranz/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabianofranz/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabianofranz/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabianofranz/origin/labels{/name}","releases_url":"https://api.github.com/repos/fabianofranz/origin/releases{/id}","created_at":"2014-08-26T21:06:40Z","updated_at":"2015-04-24T16:39:47Z","pushed_at":"2015-12-19T03:18:46Z","git_url":"git://github.com/fabianofranz/origin.git","ssh_url":"git@github.com:fabianofranz/origin.git","clone_url":"https://github.com/fabianofranz/origin.git","svn_url":"https://github.com/fabianofranz/origin","homepage":"https://openshift.github.io","size":183550,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b2568bad78ad0e5e925688fd2ff156d530a7bf7e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-12-21T00:50:41Z","pushed_at":"2015-12-21T18:03:37Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":249392,"stargazers_count":878,"watchers_count":878,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":561,"mirror_url":null,"open_issues_count":752,"forks":561,"open_issues":752,"watchers":878,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6358"},"html":{"href":"https://github.com/openshift/origin/pull/6358"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6358"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6358/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6358/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6358/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/e30644b71db82254ece74f1a716d9bd89160f948"}}}}