{"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/33241172","id":33241172,"diff_hunk":"@@ -127,16 +130,26 @@ public NovaComputeServiceAdapter(NovaApi novaApi, @Region Supplier<Set<String>>\n          }\n       }\n \n-      String regionId = template.getLocation().getId();\n+      final String regionId = template.getLocation().getId();\n       String imageId = template.getImage().getProviderId();\n       String flavorId = template.getHardware().getProviderId();\n \n       logger.debug(\">> creating new server region(%s) name(%s) image(%s) flavor(%s) options(%s)\", regionId, name, imageId, flavorId, options);\n-      ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);\n-      Server server = novaApi.getServerApi(regionId).get(lightweightServer.getId());\n-\n-      logger.trace(\"<< server(%s)\", server.getId());\n+      final ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);\n+      if (!retry(new Predicate<String>() {\n+         @Override\n+         public boolean apply(String serverId) {\n+            Server server = novaApi.getServerApi(regionId).get(serverId);\n+            return server != null && server.getAddresses() != null && !server.getAddresses().isEmpty();\n+         }\n+      }, 30 * 60, 1, SECONDS).apply(lightweightServer.getId())) {\n+         final String message = format(\"Server %s was not created within %sms so it will be destroyed.\", name, \"30 * 60\");","path":"apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapter.java","position":33,"original_position":33,"commit_id":"e1eb0cb10e4c8fab0dc8e40282bff3bf37f27ff4","original_commit_id":"c0fb682ed5a2bc46c5dec7947c4fe66758b36e6a","user":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"body":"ops, you're right! adding it now","created_at":"2015-06-25T10:30:16Z","updated_at":"2015-06-25T10:30:16Z","html_url":"https://github.com/jclouds/jclouds/pull/783#discussion_r33241172","pull_request_url":"https://api.github.com/repos/jclouds/jclouds/pulls/783","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/33241172"},"html":{"href":"https://github.com/jclouds/jclouds/pull/783#discussion_r33241172"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/783"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/783","id":38528383,"html_url":"https://github.com/jclouds/jclouds/pull/783","diff_url":"https://github.com/jclouds/jclouds/pull/783.diff","patch_url":"https://github.com/jclouds/jclouds/pull/783.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds/issues/783","number":783,"state":"open","locked":false,"title":"Minor changes to openstack-nova and openstack-keystone","user":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"body":"- change some access modifiers to simplify the downstream provider impl\r\n- modify the BasicAuthenticator in Keystone\r\n\r\n@zack-shoylev, @jdaggett as openstack experts, could you give it a quick look please?\r\n\r\nThanks!","created_at":"2015-06-25T09:34:40Z","updated_at":"2015-06-25T10:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b94cc11fd37a4c4e71ae11757f8e94d5ab83403d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds/pulls/783/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds/pulls/783/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds/issues/783/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/e1eb0cb10e4c8fab0dc8e40282bff3bf37f27ff4","head":{"label":"andreaturli:fix/openstack-nova","ref":"fix/openstack-nova","sha":"e1eb0cb10e4c8fab0dc8e40282bff3bf37f27ff4","user":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"repo":{"id":11770834,"name":"jclouds","full_name":"andreaturli/jclouds","owner":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreaturli/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":true,"url":"https://api.github.com/repos/andreaturli/jclouds","forks_url":"https://api.github.com/repos/andreaturli/jclouds/forks","keys_url":"https://api.github.com/repos/andreaturli/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreaturli/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreaturli/jclouds/teams","hooks_url":"https://api.github.com/repos/andreaturli/jclouds/hooks","issue_events_url":"https://api.github.com/repos/andreaturli/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/andreaturli/jclouds/events","assignees_url":"https://api.github.com/repos/andreaturli/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/andreaturli/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/andreaturli/jclouds/tags","blobs_url":"https://api.github.com/repos/andreaturli/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreaturli/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreaturli/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreaturli/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreaturli/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/andreaturli/jclouds/languages","stargazers_url":"https://api.github.com/repos/andreaturli/jclouds/stargazers","contributors_url":"https://api.github.com/repos/andreaturli/jclouds/contributors","subscribers_url":"https://api.github.com/repos/andreaturli/jclouds/subscribers","subscription_url":"https://api.github.com/repos/andreaturli/jclouds/subscription","commits_url":"https://api.github.com/repos/andreaturli/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreaturli/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreaturli/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreaturli/jclouds/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreaturli/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/andreaturli/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreaturli/jclouds/merges","archive_url":"https://api.github.com/repos/andreaturli/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreaturli/jclouds/downloads","issues_url":"https://api.github.com/repos/andreaturli/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/andreaturli/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/andreaturli/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/andreaturli/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreaturli/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/andreaturli/jclouds/releases{/id}","created_at":"2013-07-30T17:20:40Z","updated_at":"2015-01-29T11:50:19Z","pushed_at":"2015-06-25T10:29:41Z","git_url":"git://github.com/andreaturli/jclouds.git","ssh_url":"git@github.com:andreaturli/jclouds.git","clone_url":"https://github.com/andreaturli/jclouds.git","svn_url":"https://github.com/andreaturli/jclouds","homepage":null,"size":76134,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"b7f27e7f7623f87d9f72bd0e4df0523b2ae93dfa","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040960,"name":"jclouds","full_name":"jclouds/jclouds","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds","forks_url":"https://api.github.com/repos/jclouds/jclouds/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds/releases{/id}","created_at":"2013-05-13T20:47:29Z","updated_at":"2015-06-21T08:59:47Z","pushed_at":"2015-06-25T10:29:43Z","git_url":"git://github.com/jclouds/jclouds.git","ssh_url":"git@github.com:jclouds/jclouds.git","clone_url":"https://github.com/jclouds/jclouds.git","svn_url":"https://github.com/jclouds/jclouds","homepage":"http://jclouds.apache.org/","size":186201,"stargazers_count":182,"watchers_count":182,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":18,"forks":279,"open_issues":18,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/783"},"html":{"href":"https://github.com/jclouds/jclouds/pull/783"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/783"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds/statuses/e1eb0cb10e4c8fab0dc8e40282bff3bf37f27ff4"}}}}