{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/6918","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6918/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6918/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6918/events","html_url":"https://github.com/joomla/joomla-cms/pull/6918","id":74969144,"number":6918,"title":"Remove bootstrap.modal call in multilang status module","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-05-10T18:09:11Z","updated_at":"2015-05-10T19:32:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/6918","html_url":"https://github.com/joomla/joomla-cms/pull/6918","diff_url":"https://github.com/joomla/joomla-cms/pull/6918.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/6918.patch"},"body":"There is a condition where the multilingual status module and patch tester conflict for reasons I've not been able to debug (see https://github.com/joomla-extensions/patchtester/issues/92 for more info), but the solution for this issue seems to be in the status module.\r\n\r\nJHtmlBootstrap::modal is documented as broken [since 3.4.0](https://github.com/joomla/joomla-cms/blob/3.4.0/libraries/cms/html/bootstrap.php#L261) yet is still used in the module.  Removing the call to the broken method seems to fix the conflict I'm hitting without breaking the module.\r\n\r\n### Testing Instructions\r\n1. Install the latest [com_patchtester build](https://github.com/joomla-extensions/patchtester/releases/tag/2.0.0.beta3)\r\n2. Enable the Multilanguage status module for the admin side\r\n3. With your browser's debug console enabled, navigate to the patch tester\r\n4. Notice there's a `Uncaught TypeError: Cannot read property 'options' of null` message  The component's \"Fetch Data\" modal nor the modal for the module will work correctly either.\r\n5. Apply the patch and repeat, there should be no JavaScript issues and both modals should work correctly.\r\n\r\n### Added Bonus\r\nCodestyle fixes in the module's layout and correctly calling the JHtmlBootstrap::renderModal() method through the JHtml::_ loader."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/100685588","html_url":"https://github.com/joomla/joomla-cms/pull/6918#issuecomment-100685588","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6918","id":100685588,"user":{"login":"smz","id":552475,"avatar_url":"https://avatars.githubusercontent.com/u/552475?v=3","gravatar_id":"","url":"https://api.github.com/users/smz","html_url":"https://github.com/smz","followers_url":"https://api.github.com/users/smz/followers","following_url":"https://api.github.com/users/smz/following{/other_user}","gists_url":"https://api.github.com/users/smz/gists{/gist_id}","starred_url":"https://api.github.com/users/smz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smz/subscriptions","organizations_url":"https://api.github.com/users/smz/orgs","repos_url":"https://api.github.com/users/smz/repos","events_url":"https://api.github.com/users/smz/events{/privacy}","received_events_url":"https://api.github.com/users/smz/received_events","type":"User","site_admin":false},"created_at":"2015-05-10T19:32:10Z","updated_at":"2015-05-10T19:32:10Z","body":"AFAIK, it was meant as a support method for the \"old\" `JHtmlBootstrap::renderModal()` but it is unneed in that role right now.\r\n\r\nThe rationale for keeping it as it was that is that somewone *could* have used it for other reasons and removing or modifying it could have been a breach of B/C. Personally I don't worship to the B/C god that far, but  I think that removing it is a decision that should be taken by the PLT."}}