{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/30601326","id":30601326,"diff_hunk":"@@ -0,0 +1,121 @@\n+/*\n+ * SonarQube Java\n+ * Copyright (C) 2012 SonarSource\n+ * dev@sonar.codehaus.org\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 3 of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02\n+ */\n+package org.sonar.java.checks;\n+\n+import com.google.common.collect.Lists;\n+import org.sonar.api.server.rule.RulesDefinition;\n+import org.sonar.check.Priority;\n+import org.sonar.check.Rule;\n+import org.sonar.java.checks.methods.MethodInvocationMatcher;\n+import org.sonar.java.checks.methods.NameCriteria;\n+import org.sonar.java.checks.methods.TypeCriteria;\n+import org.sonar.plugins.java.api.JavaFileScanner;\n+import org.sonar.plugins.java.api.JavaFileScannerContext;\n+import org.sonar.plugins.java.api.semantic.Symbol;\n+import org.sonar.plugins.java.api.tree.AnnotationTree;\n+import org.sonar.plugins.java.api.tree.BaseTreeVisitor;\n+import org.sonar.plugins.java.api.tree.MethodInvocationTree;\n+import org.sonar.plugins.java.api.tree.MethodTree;\n+import org.sonar.squidbridge.annotations.SqaleConstantRemediation;\n+import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;\n+\n+import java.util.ArrayDeque;\n+import java.util.ArrayList;\n+import java.util.Deque;\n+\n+@Rule(\n+  key = \"S2699\",\n+  name = \"Tests should include assertions\",\n+  tags = {\"junit\"},\n+  priority = Priority.CRITICAL)\n+@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.UNIT_TESTABILITY)\n+@SqaleConstantRemediation(\"10min\")\n+public class AssertionsInTestsCheck extends BaseTreeVisitor implements JavaFileScanner {\n+\n+  private static final String GENERIC_ASSERT = \"org.fest.assertions.GenericAssert\";\n+  private static final MethodInvocationMatcher FEST_AS_METHOD = MethodInvocationMatcher.create()\n+    .typeDefinition(GENERIC_ASSERT).name(\"as\").withNoParameterConstraint();\n+  private static final MethodInvocationMatcher FEST_DESCRIBED_AS_METHOD = MethodInvocationMatcher.create()\n+    .typeDefinition(GENERIC_ASSERT).name(\"describedAs\").withNoParameterConstraint();\n+  private static final MethodInvocationMatcher FEST_OVERRIDE_ERROR_METHOD = MethodInvocationMatcher.create()\n+    .typeDefinition(GENERIC_ASSERT).name(\"overridingErrorMessage\").withNoParameterConstraint();\n+  private static final ArrayList<MethodInvocationMatcher> ASSERTION_INVOCATION_MATCHERS = Lists.newArrayList(\n+    MethodInvocationMatcher.create().typeDefinition(\"org.junit.Assert\").name(NameCriteria.startsWith(\"assert\")).withNoParameterConstraint(),\n+    MethodInvocationMatcher.create().typeDefinition(\"org.junit.Assert\").name(\"fail\").withNoParameterConstraint(),\n+    MethodInvocationMatcher.create().typeDefinition(\"junit.framework.Assert\").name(NameCriteria.startsWith(\"assert\")).withNoParameterConstraint(),\n+    MethodInvocationMatcher.create().typeDefinition(\"junit.framework.Assert\").name(NameCriteria.startsWith(\"fail\")).withNoParameterConstraint(),\n+    MethodInvocationMatcher.create().typeDefinition(\"org.fest.assertions.Fail\").name(NameCriteria.startsWith(\"fail\")).withNoParameterConstraint(),\n+    MethodInvocationMatcher.create().typeDefinition(TypeCriteria.subtypeOf(GENERIC_ASSERT)).name(NameCriteria.any()).withNoParameterConstraint()\n+  );\n+\n+  private Deque<Boolean> methodContainsAssertion = new ArrayDeque<>();\n+  private Deque<Boolean> inUnitTest = new ArrayDeque<>();\n+  private JavaFileScannerContext context;\n+\n+  @Override\n+  public void scanFile(final JavaFileScannerContext context) {\n+    this.context = context;\n+    scan(context.getTree());\n+  }\n+\n+  @Override\n+  public void visitMethod(MethodTree tree) {\n+    boolean isUnitTest = isUnitTest(tree);\n+    inUnitTest.push(isUnitTest);\n+    methodContainsAssertion.push(Boolean.FALSE);\n+    super.visitMethod(tree);\n+    inUnitTest.pop();\n+    if (isUnitTest && !methodContainsAssertion.pop()) {\n+      context.addIssue(tree, this, \"Add at least one assertion to this test case.\");\n+    }\n+  }\n+\n+  @Override\n+  public void visitMethodInvocation(MethodInvocationTree tree) {\n+    super.visitMethodInvocation(tree);\n+    if (inUnitTest.peek() && !methodContainsAssertion.peek() && isAssertion(tree)) {\n+      methodContainsAssertion.pop();\n+      methodContainsAssertion.push(Boolean.TRUE);\n+    }\n+  }\n+\n+  private boolean isAssertion(MethodInvocationTree mit) {\n+    for (MethodInvocationMatcher methodInvocationMatcher : ASSERTION_INVOCATION_MATCHERS) {\n+      if (methodInvocationMatcher.matches(mit) &&\n+          !FEST_AS_METHOD.matches(mit) &&\n+          !FEST_OVERRIDE_ERROR_METHOD.matches(mit) &&\n+          !FEST_DESCRIBED_AS_METHOD.matches(mit)) {\n+        return true;\n+      }\n+    }\n+    return false;\n+  }\n+\n+  private boolean isUnitTest(MethodTree tree) {\n+    for (AnnotationTree annotationTree : tree.modifiers().annotations()) {","path":"java-checks/src/main/java/org/sonar/java/checks/AssertionsInTestsCheck.java","position":112,"original_position":112,"commit_id":"ac56f27dc665f8641319cbbd57d6092c5fab165c","original_commit_id":"ac56f27dc665f8641319cbbd57d6092c5fab165c","user":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"body":"It is fine to do it via syntax but (so you know) you can also directly rely on semantic and use the metadata of the method symbol to check annotation. (you might end up with less code). ","created_at":"2015-05-19T14:00:55Z","updated_at":"2015-05-19T14:00:55Z","html_url":"https://github.com/SonarSource/sonar-java/pull/222#discussion_r30601326","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/30601326"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/222#discussion_r30601326"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222","id":35732470,"html_url":"https://github.com/SonarSource/sonar-java/pull/222","diff_url":"https://github.com/SonarSource/sonar-java/pull/222.diff","patch_url":"https://github.com/SonarSource/sonar-java/pull/222.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/222","number":222,"state":"open","locked":false,"title":"SONARJAVA-1010 Rule: S2699 Tests should include assertions","user":{"login":"mpaladin","id":456050,"avatar_url":"https://avatars.githubusercontent.com/u/456050?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaladin","html_url":"https://github.com/mpaladin","followers_url":"https://api.github.com/users/mpaladin/followers","following_url":"https://api.github.com/users/mpaladin/following{/other_user}","gists_url":"https://api.github.com/users/mpaladin/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaladin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaladin/subscriptions","organizations_url":"https://api.github.com/users/mpaladin/orgs","repos_url":"https://api.github.com/users/mpaladin/repos","events_url":"https://api.github.com/users/mpaladin/events{/privacy}","received_events_url":"https://api.github.com/users/mpaladin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-19T13:55:42Z","updated_at":"2015-05-19T14:00:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfc19938ca5534e72cec3a00bc729b23869e6593","assignee":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/222/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ac56f27dc665f8641319cbbd57d6092c5fab165c","head":{"label":"mpaladin:SONARJAVA-1010","ref":"SONARJAVA-1010","sha":"ac56f27dc665f8641319cbbd57d6092c5fab165c","user":{"login":"mpaladin","id":456050,"avatar_url":"https://avatars.githubusercontent.com/u/456050?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaladin","html_url":"https://github.com/mpaladin","followers_url":"https://api.github.com/users/mpaladin/followers","following_url":"https://api.github.com/users/mpaladin/following{/other_user}","gists_url":"https://api.github.com/users/mpaladin/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaladin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaladin/subscriptions","organizations_url":"https://api.github.com/users/mpaladin/orgs","repos_url":"https://api.github.com/users/mpaladin/repos","events_url":"https://api.github.com/users/mpaladin/events{/privacy}","received_events_url":"https://api.github.com/users/mpaladin/received_events","type":"User","site_admin":false},"repo":{"id":35816943,"name":"sonar-java","full_name":"mpaladin/sonar-java","owner":{"login":"mpaladin","id":456050,"avatar_url":"https://avatars.githubusercontent.com/u/456050?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaladin","html_url":"https://github.com/mpaladin","followers_url":"https://api.github.com/users/mpaladin/followers","following_url":"https://api.github.com/users/mpaladin/following{/other_user}","gists_url":"https://api.github.com/users/mpaladin/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaladin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaladin/subscriptions","organizations_url":"https://api.github.com/users/mpaladin/orgs","repos_url":"https://api.github.com/users/mpaladin/repos","events_url":"https://api.github.com/users/mpaladin/events{/privacy}","received_events_url":"https://api.github.com/users/mpaladin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpaladin/sonar-java","description":"","fork":true,"url":"https://api.github.com/repos/mpaladin/sonar-java","forks_url":"https://api.github.com/repos/mpaladin/sonar-java/forks","keys_url":"https://api.github.com/repos/mpaladin/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpaladin/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpaladin/sonar-java/teams","hooks_url":"https://api.github.com/repos/mpaladin/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/mpaladin/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/mpaladin/sonar-java/events","assignees_url":"https://api.github.com/repos/mpaladin/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/mpaladin/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/mpaladin/sonar-java/tags","blobs_url":"https://api.github.com/repos/mpaladin/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpaladin/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpaladin/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpaladin/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpaladin/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/mpaladin/sonar-java/languages","stargazers_url":"https://api.github.com/repos/mpaladin/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/mpaladin/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/mpaladin/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/mpaladin/sonar-java/subscription","commits_url":"https://api.github.com/repos/mpaladin/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpaladin/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpaladin/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpaladin/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpaladin/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/mpaladin/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpaladin/sonar-java/merges","archive_url":"https://api.github.com/repos/mpaladin/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpaladin/sonar-java/downloads","issues_url":"https://api.github.com/repos/mpaladin/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/mpaladin/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/mpaladin/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/mpaladin/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpaladin/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/mpaladin/sonar-java/releases{/id}","created_at":"2015-05-18T12:35:21Z","updated_at":"2015-05-18T12:35:25Z","pushed_at":"2015-05-19T13:46:45Z","git_url":"git://github.com/mpaladin/sonar-java.git","ssh_url":"git@github.com:mpaladin/sonar-java.git","clone_url":"https://github.com/mpaladin/sonar-java.git","svn_url":"https://github.com/mpaladin/sonar-java","homepage":"","size":32217,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"59719d5be5f6ddf418de2018b68a8fe244aa0e06","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5674787,"name":"sonar-java","full_name":"SonarSource/sonar-java","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-java","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-java","forks_url":"https://api.github.com/repos/SonarSource/sonar-java/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-java/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-java/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-java/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-java/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-java/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-java/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-java/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-java/releases{/id}","created_at":"2012-09-04T15:53:13Z","updated_at":"2015-05-08T14:00:43Z","pushed_at":"2015-05-19T13:59:49Z","git_url":"git://github.com/SonarSource/sonar-java.git","ssh_url":"git@github.com:SonarSource/sonar-java.git","clone_url":"https://github.com/SonarSource/sonar-java.git","svn_url":"https://github.com/SonarSource/sonar-java","homepage":"","size":32217,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":6,"forks":79,"open_issues":6,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/222"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/222"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ac56f27dc665f8641319cbbd57d6092c5fab165c"}}}}