{"push_id":745176408,"size":11,"distinct_size":11,"ref":"refs/heads/update-rubocop","head":"6761718712da8c688aab792465fccf2895749948","before":"02daf44439156e20eb22d02e2599e50e9d9016e6","commits":[{"sha":"56cbe6995e8e685ed403e35a4584ee589a72812b","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Update Rubocop to latest version.\n\nThis also updates the travis setup to use the latest bundler. Travis\ncurrently defaults to Bundler version 1.7.4, however, this bundler\nversion does not support the `platform: :ruby_22` configuration setting.\nSo we need to tell travis to install a more recent bundler.\n\nAlso, `platform: :ruby_19` applies to **both** 1.9.2 and 1.9.3. But\nRubocop stopped supporting 1.9.2. Thus we need to check the\n`RUBY_VERSION` in our `Gemfile` and not attempt to install Rubocop\nspecifically for 1.9.2.\n\nUnfortunately, this bundler does not work with JRuby (2.0 mode), but\ndoes work with JRuby 1.8 mode. So we need to update the config to ignore\nJRuby 2.0. However, the current config incorrectly assumes we can do\nthat by checking the `JRUBY_OPTS` environment variable. Travis actually\nsets this be default on _all_ systems:\nhttp://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables\n\nHowever, we can check the Ruby version we pass into the travis matrix by\nusing the `TRAVIS_RUBY_VERSION` and seeing if it equals \"jruby\".","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/56cbe6995e8e685ed403e35a4584ee589a72812b"},{"sha":"9f3459a1b8414db2bc4f7d30fa666349a5e42a96","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Outdent access modifiers like module_function.\n\nlib/rspec/support/ruby_features.rb:9:7: C: Outdent access modifiers like module_function.\n      module_function\n      ^^^^^^^^^^^^^^^\nlib/rspec/support/ruby_features.rb:24:7: C: Outdent access modifiers like module_function.\n      module_function\n      ^^^^^^^^^^^^^^^\nlib/rspec/support/ruby_features.rb:48:7: C: Outdent access modifiers like module_function.\n      module_function\n      ^^^^^^^^^^^^^^^","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/9f3459a1b8414db2bc4f7d30fa666349a5e42a96"},{"sha":"9f5407a91a60626e1a941d651a83fd42f75b5bd0","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Fix extra empty line at block body beginning.\n\nlib/rspec/support/spec/string_matcher.rb:7:1: C: Extra empty line detected at block body beginning.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/9f5407a91a60626e1a941d651a83fd42f75b5bd0"},{"sha":"25e72e7780614321a92edcf2a5ceea2a990e28ee","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Turn off the parallel assignment Rubocop.\n\nIt is not faster to use sequential assignment. For small assignment sets\nprefer parallel, but optimize for readability first.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/25e72e7780614321a92edcf2a5ceea2a990e28ee"},{"sha":"189f73cd644a387de412a78158f0f2c79169065a","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Disable non-local exist check.\n\nThe check name is a little misleading. The check really is more:\n\"`returned` called from inside a block\". Given RSpec's DSL syntax and\nour heavy block usage, from which calling `return` is valid, this is\nbeing turned off.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/189f73cd644a387de412a78158f0f2c79169065a"},{"sha":"54d277f360ff828fdd5a31738a0ac775534b9148","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Disable another single vs double quote cop.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/54d277f360ff828fdd5a31738a0ac775534b9148"},{"sha":"eeb9c84c0ca23b1312f044f59dd7255b59814648","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Fix extra whitespace noticed by the cop\n\nlib/rspec/support/caller_filter.rb:72:23: C: Operator *= should be surrounded with a single space.\n          increment   *= 2 # The choice of two here is arbitrary.\n                      ^^\nlib/rspec/support/method_signature_verifier.rb:98:48: C: Operator + should be surrounded with a single space.\n          @max_non_kw_args = @min_non_kw_args  + optional_non_kw_args\n                                                 ^","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/eeb9c84c0ca23b1312f044f59dd7255b59814648"},{"sha":"0b08e3117f94d0fd7a9b60a79c7f2691db2cef9a","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Increase code metric thresholds for now.\n\nThis raises the code metric thresholds for perceived complexity and\nassignment branch conditionals. These are only meant to be temporary\nsettings to ignore the existing offenses. We fully intend to reduce\nthese over time.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/0b08e3117f94d0fd7a9b60a79c7f2691db2cef9a"},{"sha":"ae5137f58f8d784f1920ad7964e73e6adcc35cde","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Temporarily disable symbol to proc.\n\nWe have not decided how we are going to handle the symbol to proc vs\nblock implementations. This is because the block is faster on Ruby\n1.8.7, REE, and JRuby but slower on Ruby 1.9.2 through 2.2.2.","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/ae5137f58f8d784f1920ad7964e73e6adcc35cde"},{"sha":"0317b50c46659bc320d5fbc915055fca161cac77","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"Tmp - benchmarks on ruby","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/0317b50c46659bc320d5fbc915055fca161cac77"},{"sha":"6761718712da8c688aab792465fccf2895749948","author":{"email":"3ecc393db156ccf0ca3ef278b6788254f9dce139@gmail.com","name":"Aaron Kromer"},"message":"WIP: Parallel assignment benchmark updates","distinct":true,"url":"https://api.github.com/repos/rspec/rspec-support/commits/6761718712da8c688aab792465fccf2895749948"}]}