{"action":"created","issue":{"url":"https://api.github.com/repos/jordansissel/fpm/issues/931","labels_url":"https://api.github.com/repos/jordansissel/fpm/issues/931/labels{/name}","comments_url":"https://api.github.com/repos/jordansissel/fpm/issues/931/comments","events_url":"https://api.github.com/repos/jordansissel/fpm/issues/931/events","html_url":"https://github.com/jordansissel/fpm/pull/931","id":85447682,"number":931,"title":"Feature/755 Take prefix path into account when searching for config files","user":{"login":"djhaskin987","id":1186534,"avatar_url":"https://avatars.githubusercontent.com/u/1186534?v=3","gravatar_id":"","url":"https://api.github.com/users/djhaskin987","html_url":"https://github.com/djhaskin987","followers_url":"https://api.github.com/users/djhaskin987/followers","following_url":"https://api.github.com/users/djhaskin987/following{/other_user}","gists_url":"https://api.github.com/users/djhaskin987/gists{/gist_id}","starred_url":"https://api.github.com/users/djhaskin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhaskin987/subscriptions","organizations_url":"https://api.github.com/users/djhaskin987/orgs","repos_url":"https://api.github.com/users/djhaskin987/repos","events_url":"https://api.github.com/users/djhaskin987/events{/privacy}","received_events_url":"https://api.github.com/users/djhaskin987/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-05T06:19:09Z","updated_at":"2015-06-05T06:22:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jordansissel/fpm/pulls/931","html_url":"https://github.com/jordansissel/fpm/pull/931","diff_url":"https://github.com/jordansissel/fpm/pull/931.diff","patch_url":"https://github.com/jordansissel/fpm/pull/931.patch"},"body":"I am not done with this pull request; I still need to test it and add specs. However, I wanted to start the discussion first to make sure I am going down the right path.\r\n\r\nThe PR #755 by @michaeltchapman is a good piece of code.\r\n\r\nAfter reading it, I noticed two things:\r\n\r\n  1. The `staging_path` function might be used to greater effect in the code added by the PR\r\n  2. Way more importantly, @michaeltchapman is solving a much more generic problem here than just RPM packaging.\r\n\r\nIn this PR, I move his logic into the `convert()` function, which is called right before `output()`. `output()` is where the piece of code in PR #755 worked. I think this is better done in convert, where common variables are copied over and where, therefore, the configuration files could be straightened out in the generic way that Michael used.\r\n\r\nI merge that logic for finding the right config file and taking into account the prefix path with another snippet of code in the `deb` output class that seems to do the exact same thing.\r\n\r\nI then removed the generic 'find the config files' code from the `output` functions in both the `deb` and `rpm` classes.\r\n\r\nThis is great, because this logic makes sense in any output context, not just RPM or DEB.\r\n\r\n@jordansissel, if you think this looks good, let me know. Then, I'll test it and add specs. I'll post here when I do, and then you can merge it in if you like :) I'm just too tired to do that tonight, it's after midnight here. Cheers from Utah!"},"comment":{"url":"https://api.github.com/repos/jordansissel/fpm/issues/comments/109174141","html_url":"https://github.com/jordansissel/fpm/pull/931#issuecomment-109174141","issue_url":"https://api.github.com/repos/jordansissel/fpm/issues/931","id":109174141,"user":{"login":"djhaskin987","id":1186534,"avatar_url":"https://avatars.githubusercontent.com/u/1186534?v=3","gravatar_id":"","url":"https://api.github.com/users/djhaskin987","html_url":"https://github.com/djhaskin987","followers_url":"https://api.github.com/users/djhaskin987/followers","following_url":"https://api.github.com/users/djhaskin987/following{/other_user}","gists_url":"https://api.github.com/users/djhaskin987/gists{/gist_id}","starred_url":"https://api.github.com/users/djhaskin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhaskin987/subscriptions","organizations_url":"https://api.github.com/users/djhaskin987/orgs","repos_url":"https://api.github.com/users/djhaskin987/repos","events_url":"https://api.github.com/users/djhaskin987/events{/privacy}","received_events_url":"https://api.github.com/users/djhaskin987/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T06:22:37Z","updated_at":"2015-06-05T06:22:37Z","body":"Ping @ronkorving @adrianlzt @hatt @dustinbrown @jeffgeiger #584 #730 "}}