{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-identity/pulls/comments/40645527","id":40645527,"diff_hunk":"@@ -305,12 +306,14 @@\n                     </td>\n                     <td>\n                         <% if(dto.getValue() != null) {%>\n-                            <input type=\"<%=inputType%>\" name=\"<%=dto.getId()%>\" id=\"<%=dto.getId()%>\"\n-                                                                        value=\"<%=dto.getValue()%>\" <% if(\"subscriberId\".equals(dto.getId())){ %> readonly='readonly' <% } %> />\n+                            <input type=\"<%=Encode.forHtmlAttribute(inputType)%>\" name=\"<%=Encode.forHtmlAttribute(dto.getId())%>\"","path":"components/entitlement/org.wso2.carbon.identity.entitlement.ui/src/main/resources/web/entitlement/add-subscriber.jsp","position":48,"original_position":48,"commit_id":"988fc7c754796080617d4824f3cff7977ea4355a","original_commit_id":"988fc7c754796080617d4824f3cff7977ea4355a","user":{"login":"malithie","id":4951983,"avatar_url":"https://avatars.githubusercontent.com/u/4951983?v=3","gravatar_id":"","url":"https://api.github.com/users/malithie","html_url":"https://github.com/malithie","followers_url":"https://api.github.com/users/malithie/followers","following_url":"https://api.github.com/users/malithie/following{/other_user}","gists_url":"https://api.github.com/users/malithie/gists{/gist_id}","starred_url":"https://api.github.com/users/malithie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malithie/subscriptions","organizations_url":"https://api.github.com/users/malithie/orgs","repos_url":"https://api.github.com/users/malithie/repos","events_url":"https://api.github.com/users/malithie/events{/privacy}","received_events_url":"https://api.github.com/users/malithie/received_events","type":"User","site_admin":false},"body":"Here inputType has hardcoded values which does not include special characters and trusted. Thus, it's not necessary to encode this variable","created_at":"2015-09-29T08:23:56Z","updated_at":"2015-09-29T08:23:56Z","html_url":"https://github.com/wso2/carbon-identity/pull/1018#discussion_r40645527","pull_request_url":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/comments/40645527"},"html":{"href":"https://github.com/wso2/carbon-identity/pull/1018#discussion_r40645527"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018","id":45988415,"html_url":"https://github.com/wso2/carbon-identity/pull/1018","diff_url":"https://github.com/wso2/carbon-identity/pull/1018.diff","patch_url":"https://github.com/wso2/carbon-identity/pull/1018.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity/issues/1018","number":1018,"state":"open","locked":false,"title":"Entitlement xss fixes part-1","user":{"login":"isharak","id":7835405,"avatar_url":"https://avatars.githubusercontent.com/u/7835405?v=3","gravatar_id":"","url":"https://api.github.com/users/isharak","html_url":"https://github.com/isharak","followers_url":"https://api.github.com/users/isharak/followers","following_url":"https://api.github.com/users/isharak/following{/other_user}","gists_url":"https://api.github.com/users/isharak/gists{/gist_id}","starred_url":"https://api.github.com/users/isharak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isharak/subscriptions","organizations_url":"https://api.github.com/users/isharak/orgs","repos_url":"https://api.github.com/users/isharak/repos","events_url":"https://api.github.com/users/isharak/events{/privacy}","received_events_url":"https://api.github.com/users/isharak/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-25T08:36:16Z","updated_at":"2015-09-29T08:23:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbcd971293b31ba336f4dccff48bcb0e51a7bf5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity/issues/1018/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity/statuses/988fc7c754796080617d4824f3cff7977ea4355a","head":{"label":"isharak:XSS_Hackathon_Entitlement","ref":"XSS_Hackathon_Entitlement","sha":"988fc7c754796080617d4824f3cff7977ea4355a","user":{"login":"isharak","id":7835405,"avatar_url":"https://avatars.githubusercontent.com/u/7835405?v=3","gravatar_id":"","url":"https://api.github.com/users/isharak","html_url":"https://github.com/isharak","followers_url":"https://api.github.com/users/isharak/followers","following_url":"https://api.github.com/users/isharak/following{/other_user}","gists_url":"https://api.github.com/users/isharak/gists{/gist_id}","starred_url":"https://api.github.com/users/isharak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isharak/subscriptions","organizations_url":"https://api.github.com/users/isharak/orgs","repos_url":"https://api.github.com/users/isharak/repos","events_url":"https://api.github.com/users/isharak/events{/privacy}","received_events_url":"https://api.github.com/users/isharak/received_events","type":"User","site_admin":false},"repo":{"id":32844719,"name":"carbon-identity","full_name":"isharak/carbon-identity","owner":{"login":"isharak","id":7835405,"avatar_url":"https://avatars.githubusercontent.com/u/7835405?v=3","gravatar_id":"","url":"https://api.github.com/users/isharak","html_url":"https://github.com/isharak","followers_url":"https://api.github.com/users/isharak/followers","following_url":"https://api.github.com/users/isharak/following{/other_user}","gists_url":"https://api.github.com/users/isharak/gists{/gist_id}","starred_url":"https://api.github.com/users/isharak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isharak/subscriptions","organizations_url":"https://api.github.com/users/isharak/orgs","repos_url":"https://api.github.com/users/isharak/repos","events_url":"https://api.github.com/users/isharak/events{/privacy}","received_events_url":"https://api.github.com/users/isharak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isharak/carbon-identity","description":"","fork":true,"url":"https://api.github.com/repos/isharak/carbon-identity","forks_url":"https://api.github.com/repos/isharak/carbon-identity/forks","keys_url":"https://api.github.com/repos/isharak/carbon-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isharak/carbon-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isharak/carbon-identity/teams","hooks_url":"https://api.github.com/repos/isharak/carbon-identity/hooks","issue_events_url":"https://api.github.com/repos/isharak/carbon-identity/issues/events{/number}","events_url":"https://api.github.com/repos/isharak/carbon-identity/events","assignees_url":"https://api.github.com/repos/isharak/carbon-identity/assignees{/user}","branches_url":"https://api.github.com/repos/isharak/carbon-identity/branches{/branch}","tags_url":"https://api.github.com/repos/isharak/carbon-identity/tags","blobs_url":"https://api.github.com/repos/isharak/carbon-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isharak/carbon-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isharak/carbon-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/isharak/carbon-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isharak/carbon-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/isharak/carbon-identity/languages","stargazers_url":"https://api.github.com/repos/isharak/carbon-identity/stargazers","contributors_url":"https://api.github.com/repos/isharak/carbon-identity/contributors","subscribers_url":"https://api.github.com/repos/isharak/carbon-identity/subscribers","subscription_url":"https://api.github.com/repos/isharak/carbon-identity/subscription","commits_url":"https://api.github.com/repos/isharak/carbon-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/isharak/carbon-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/isharak/carbon-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/isharak/carbon-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/isharak/carbon-identity/contents/{+path}","compare_url":"https://api.github.com/repos/isharak/carbon-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isharak/carbon-identity/merges","archive_url":"https://api.github.com/repos/isharak/carbon-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isharak/carbon-identity/downloads","issues_url":"https://api.github.com/repos/isharak/carbon-identity/issues{/number}","pulls_url":"https://api.github.com/repos/isharak/carbon-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/isharak/carbon-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/isharak/carbon-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isharak/carbon-identity/labels{/name}","releases_url":"https://api.github.com/repos/isharak/carbon-identity/releases{/id}","created_at":"2015-03-25T05:36:01Z","updated_at":"2015-04-29T12:53:36Z","pushed_at":"2015-09-29T06:43:02Z","git_url":"git://github.com/isharak/carbon-identity.git","ssh_url":"git@github.com:isharak/carbon-identity.git","clone_url":"https://github.com/isharak/carbon-identity.git","svn_url":"https://github.com/isharak/carbon-identity","homepage":null,"size":40829,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"7e132fc7f2f5787d9facf5da0221a70e316794ba","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16588204,"name":"carbon-identity","full_name":"wso2/carbon-identity","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity","forks_url":"https://api.github.com/repos/wso2/carbon-identity/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity/releases{/id}","created_at":"2014-02-06T17:58:23Z","updated_at":"2015-09-17T15:00:40Z","pushed_at":"2015-09-29T08:19:42Z","git_url":"git://github.com/wso2/carbon-identity.git","ssh_url":"git@github.com:wso2/carbon-identity.git","clone_url":"https://github.com/wso2/carbon-identity.git","svn_url":"https://github.com/wso2/carbon-identity","homepage":null,"size":114721,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":75,"forks":132,"open_issues":75,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018"},"html":{"href":"https://github.com/wso2/carbon-identity/pull/1018"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity/issues/1018"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity/statuses/988fc7c754796080617d4824f3cff7977ea4355a"}}}}