{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/3267","labels_url":"https://api.github.com/repos/chef/chef/issues/3267/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/3267/comments","events_url":"https://api.github.com/repos/chef/chef/issues/3267/events","html_url":"https://github.com/chef/chef/pull/3267","id":70338745,"number":3267,"title":"#3266 Fix bad Windows securable_resource functional spec assumptions for default file owners/groups","user":{"login":"dbjorge","id":376284,"avatar_url":"https://avatars.githubusercontent.com/u/376284?v=3","gravatar_id":"","url":"https://api.github.com/users/dbjorge","html_url":"https://github.com/dbjorge","followers_url":"https://api.github.com/users/dbjorge/followers","following_url":"https://api.github.com/users/dbjorge/following{/other_user}","gists_url":"https://api.github.com/users/dbjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dbjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbjorge/subscriptions","organizations_url":"https://api.github.com/users/dbjorge/orgs","repos_url":"https://api.github.com/users/dbjorge/repos","events_url":"https://api.github.com/users/dbjorge/events{/privacy}","received_events_url":"https://api.github.com/users/dbjorge/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/chef/labels/Pending%20Maintainer%20Review","name":"Pending Maintainer Review","color":"0052cc"},{"url":"https://api.github.com/repos/chef/chef/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"},{"url":"https://api.github.com/repos/chef/chef/labels/Tech%20Cleanup","name":"Tech Cleanup","color":"009800"},{"url":"https://api.github.com/repos/chef/chef/labels/Windows","name":"Windows","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-23T07:51:16Z","updated_at":"2015-05-19T18:42:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/3267","html_url":"https://github.com/chef/chef/pull/3267","diff_url":"https://github.com/chef/chef/pull/3267.diff","patch_url":"https://github.com/chef/chef/pull/3267.patch"},"body":"See also issue #3106.\r\n\r\nIt wasn't 100% clear what the most correct fix path was here. The options I considered were:\r\n\r\n1) Update the Windows file providers to explicitly set newly created files with no user-specified group to use the None group SID.\r\n2) Update the spec to always assume the group should be SID.current_user\r\n3) Update the spec to query for the actual defaults and check against them\r\n\r\nI avoided 1 because there didn't seem to be any compelling reason to prefer the None-group behavior - there isn't backwards compatibility concern (because the implementation doesn't do it today) and it would be confusing for Chef to make up its own default behavior on top of the OS's already-confusing default behavior.\r\n\r\nI avoided 2 because I was concerned about execution cases that I'm apparently not seeing - presumably this test passes in a test kitchen in its current form, which makes me suspect perhaps current_user isn't as accurate as MSDN suggests if, say, a non-interactive service is creating the resource.\r\n\r\nThis PR implements option 3. It was a little bit more code, but I'm happier with how it turned out. And it does fix about 1/3 of the functional spec failures #3106 mentions (of those I repro on my desktop, at least)."},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/103627583","html_url":"https://github.com/chef/chef/pull/3267#issuecomment-103627583","issue_url":"https://api.github.com/repos/chef/chef/issues/3267","id":103627583,"user":{"login":"ksubrama","id":9382254,"avatar_url":"https://avatars.githubusercontent.com/u/9382254?v=3","gravatar_id":"","url":"https://api.github.com/users/ksubrama","html_url":"https://github.com/ksubrama","followers_url":"https://api.github.com/users/ksubrama/followers","following_url":"https://api.github.com/users/ksubrama/following{/other_user}","gists_url":"https://api.github.com/users/ksubrama/gists{/gist_id}","starred_url":"https://api.github.com/users/ksubrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksubrama/subscriptions","organizations_url":"https://api.github.com/users/ksubrama/orgs","repos_url":"https://api.github.com/users/ksubrama/repos","events_url":"https://api.github.com/users/ksubrama/events{/privacy}","received_events_url":"https://api.github.com/users/ksubrama/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T18:42:37Z","updated_at":"2015-05-19T18:42:37Z","body":":+1:  I read the MSDN specs for the function calls made and this pull request makes sense to me.\r\n\r\nThanks for the work!"}}