{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22587605","id":22587605,"diff_hunk":"@@ -790,9 +790,19 @@ suite('dialer/call_log', function() {\n       sinon.assert.notCalled(CallLog.renderEmptyCallLog);\n     });\n \n-    test('renderEmptyCallLog should be called when there is no missedgroup',\n+    test('renderEmptyCallLog should be called when there is no missedgroup ' +\n+         'and it is in missed view',\n     function() {\n       this.sinon.spy(CallLog, 'renderEmptyCallLog');\n+      CallLog.appendGroup(missedGroup);\n+      CallLog.filter();\n+      var container = CallLog.callLogContainer;\n+      var checkboxes =\n+        container.querySelectorAll('.missed-call input[type=\"checkbox\"]');\n+      for (var i = 0; i < checkboxes.length; i++) {\n+        var checkbox = checkboxes[i];\n+        checkbox.checked = true;\n+      }\n       CallLog.deleteLogGroups();\n       ConfirmDialog.executeYes();\n       sinon.assert.calledOnce(CallLog.renderEmptyCallLog);","path":"apps/communications/dialer/test/unit/call_log_test.js","position":20,"original_position":20,"commit_id":"bc20503129a061d23806f4f381607e8b16765ddf","original_commit_id":"bc20503129a061d23806f4f381607e8b16765ddf","user":{"login":"tamarahills","id":7558944,"avatar_url":"https://avatars.githubusercontent.com/u/7558944?v=3","gravatar_id":"","url":"https://api.github.com/users/tamarahills","html_url":"https://github.com/tamarahills","followers_url":"https://api.github.com/users/tamarahills/followers","following_url":"https://api.github.com/users/tamarahills/following{/other_user}","gists_url":"https://api.github.com/users/tamarahills/gists{/gist_id}","starred_url":"https://api.github.com/users/tamarahills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamarahills/subscriptions","organizations_url":"https://api.github.com/users/tamarahills/orgs","repos_url":"https://api.github.com/users/tamarahills/repos","events_url":"https://api.github.com/users/tamarahills/events{/privacy}","received_events_url":"https://api.github.com/users/tamarahills/received_events","type":"User","site_admin":false},"body":"Would it be possible to change this test a bit so that it verifies that in addition to just the renderEmptyCallLog being called that the correct message for the noMissedCallsMsg is displayed in the right filter tab?  Otherwise, I think the test passes both with and without the change to call_log.js.","created_at":"2015-01-07T14:20:12Z","updated_at":"2015-01-07T14:20:12Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27111#discussion_r22587605","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22587605"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27111#discussion_r22587605"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111","id":26810435,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27111","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27111.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27111.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27111","number":27111,"state":"open","locked":false,"title":"Bug 1108984 - [Woodduck][Dialer]The \"No missed message\" info will be dis...","user":{"login":"begeeben","id":2361829,"avatar_url":"https://avatars.githubusercontent.com/u/2361829?v=3","gravatar_id":"","url":"https://api.github.com/users/begeeben","html_url":"https://github.com/begeeben","followers_url":"https://api.github.com/users/begeeben/followers","following_url":"https://api.github.com/users/begeeben/following{/other_user}","gists_url":"https://api.github.com/users/begeeben/gists{/gist_id}","starred_url":"https://api.github.com/users/begeeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begeeben/subscriptions","organizations_url":"https://api.github.com/users/begeeben/orgs","repos_url":"https://api.github.com/users/begeeben/repos","events_url":"https://api.github.com/users/begeeben/events{/privacy}","received_events_url":"https://api.github.com/users/begeeben/received_events","type":"User","site_admin":false},"body":"...played in \"All\" lab after deleting the missed call log in \"All\".\r\n\r\n* Check if the call log is filtered before showing empty call log.","created_at":"2015-01-05T07:56:57Z","updated_at":"2015-01-07T14:20:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2e33f89204c3cc197f9265f17d9aa636cdf4f13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27111/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/bc20503129a061d23806f4f381607e8b16765ddf","head":{"label":"begeeben:1108984_the_no_missed_message","ref":"1108984_the_no_missed_message","sha":"bc20503129a061d23806f4f381607e8b16765ddf","user":{"login":"begeeben","id":2361829,"avatar_url":"https://avatars.githubusercontent.com/u/2361829?v=3","gravatar_id":"","url":"https://api.github.com/users/begeeben","html_url":"https://github.com/begeeben","followers_url":"https://api.github.com/users/begeeben/followers","following_url":"https://api.github.com/users/begeeben/following{/other_user}","gists_url":"https://api.github.com/users/begeeben/gists{/gist_id}","starred_url":"https://api.github.com/users/begeeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begeeben/subscriptions","organizations_url":"https://api.github.com/users/begeeben/orgs","repos_url":"https://api.github.com/users/begeeben/repos","events_url":"https://api.github.com/users/begeeben/events{/privacy}","received_events_url":"https://api.github.com/users/begeeben/received_events","type":"User","site_admin":false},"repo":{"id":19827136,"name":"gaia","full_name":"begeeben/gaia","owner":{"login":"begeeben","id":2361829,"avatar_url":"https://avatars.githubusercontent.com/u/2361829?v=3","gravatar_id":"","url":"https://api.github.com/users/begeeben","html_url":"https://github.com/begeeben","followers_url":"https://api.github.com/users/begeeben/followers","following_url":"https://api.github.com/users/begeeben/following{/other_user}","gists_url":"https://api.github.com/users/begeeben/gists{/gist_id}","starred_url":"https://api.github.com/users/begeeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begeeben/subscriptions","organizations_url":"https://api.github.com/users/begeeben/orgs","repos_url":"https://api.github.com/users/begeeben/repos","events_url":"https://api.github.com/users/begeeben/events{/privacy}","received_events_url":"https://api.github.com/users/begeeben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/begeeben/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/begeeben/gaia","forks_url":"https://api.github.com/repos/begeeben/gaia/forks","keys_url":"https://api.github.com/repos/begeeben/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/begeeben/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/begeeben/gaia/teams","hooks_url":"https://api.github.com/repos/begeeben/gaia/hooks","issue_events_url":"https://api.github.com/repos/begeeben/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/begeeben/gaia/events","assignees_url":"https://api.github.com/repos/begeeben/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/begeeben/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/begeeben/gaia/tags","blobs_url":"https://api.github.com/repos/begeeben/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/begeeben/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/begeeben/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/begeeben/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/begeeben/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/begeeben/gaia/languages","stargazers_url":"https://api.github.com/repos/begeeben/gaia/stargazers","contributors_url":"https://api.github.com/repos/begeeben/gaia/contributors","subscribers_url":"https://api.github.com/repos/begeeben/gaia/subscribers","subscription_url":"https://api.github.com/repos/begeeben/gaia/subscription","commits_url":"https://api.github.com/repos/begeeben/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/begeeben/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/begeeben/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/begeeben/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/begeeben/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/begeeben/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/begeeben/gaia/merges","archive_url":"https://api.github.com/repos/begeeben/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/begeeben/gaia/downloads","issues_url":"https://api.github.com/repos/begeeben/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/begeeben/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/begeeben/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/begeeben/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/begeeben/gaia/labels{/name}","releases_url":"https://api.github.com/repos/begeeben/gaia/releases{/id}","created_at":"2014-05-15T16:38:01Z","updated_at":"2014-11-24T09:26:54Z","pushed_at":"2015-01-06T03:21:02Z","git_url":"git://github.com/begeeben/gaia.git","ssh_url":"git@github.com:begeeben/gaia.git","clone_url":"https://github.com/begeeben/gaia.git","svn_url":"https://github.com/begeeben/gaia","homepage":"https://wiki.mozilla.org/B2G","size":876368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:v2.0m","ref":"v2.0m","sha":"f90d229f9a6fc0b595272378b50f8a69c159cf3b","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-01-07T13:26:38Z","pushed_at":"2015-01-07T13:26:38Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1368243,"stargazers_count":1844,"watchers_count":1844,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2151,"mirror_url":null,"open_issues_count":794,"forks":2151,"open_issues":794,"watchers":1844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27111"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27111"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27111/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27111/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/bc20503129a061d23806f4f381607e8b16765ddf"}}}}