{"action":"created","issue":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/1915","labels_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/1915/labels{/name}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/1915/comments","events_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/1915/events","html_url":"https://github.com/DarkstarProject/darkstar/pull/1915","id":100459029,"number":1915,"title":"Partially cleanup some Dynamis nonsense.","user":{"login":"TeoTwawki","id":6871475,"avatar_url":"https://avatars.githubusercontent.com/u/6871475?v=3","gravatar_id":"","url":"https://api.github.com/users/TeoTwawki","html_url":"https://github.com/TeoTwawki","followers_url":"https://api.github.com/users/TeoTwawki/followers","following_url":"https://api.github.com/users/TeoTwawki/following{/other_user}","gists_url":"https://api.github.com/users/TeoTwawki/gists{/gist_id}","starred_url":"https://api.github.com/users/TeoTwawki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeoTwawki/subscriptions","organizations_url":"https://api.github.com/users/TeoTwawki/orgs","repos_url":"https://api.github.com/users/TeoTwawki/repos","events_url":"https://api.github.com/users/TeoTwawki/events{/privacy}","received_events_url":"https://api.github.com/users/TeoTwawki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-12T03:51:13Z","updated_at":"2015-08-12T12:00:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/1915","html_url":"https://github.com/DarkstarProject/darkstar/pull/1915","diff_url":"https://github.com/DarkstarProject/darkstar/pull/1915.diff","patch_url":"https://github.com/DarkstarProject/darkstar/pull/1915.patch"},"body":"Only thing I really corrected was Dynamis Lord's instant self depop and the timing on Ying and Yang repopping each other. Its 30 seconds, not 21. I killed the timer on Dynamis Lord because it : \r\n\r\n**A)** wasn't actually working as you can't setLocalVar on a mob that is not even up yet resulting on comparing os.time() with zero meaning always depop Dynamis Lord every tick of onMobFight... \r\n\r\nand **B)** I couldn't even find any source for it (only time I ever saw a Dyna lord fight, it was over well before this timer would have been up). I almost corrected his spawn requirements but decided I just don't care about *non* Neo Dynamis.\r\n\r\nI didn't correct his spawn conditions but I commented in [Dynamis_Lord.lua](https://github.com/DarkstarProject/darkstar/commit/7a78eaa4f6598aa8e99f40e4fc40f2785f9c6d3f#diff-6f1961dac1835fbfc64de0a537dba6cdR5) if anyone else wants to. I just can't bring myself to care enough to do all that for *non* Neo Dynamis.\r\n\r\nIf someone else wants to re-implement the timer and or correct the spawn conditions, have at it!"},"comment":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/comments/130272868","html_url":"https://github.com/DarkstarProject/darkstar/pull/1915#issuecomment-130272868","issue_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/1915","id":130272868,"user":{"login":"gedads","id":5845173,"avatar_url":"https://avatars.githubusercontent.com/u/5845173?v=3","gravatar_id":"","url":"https://api.github.com/users/gedads","html_url":"https://github.com/gedads","followers_url":"https://api.github.com/users/gedads/followers","following_url":"https://api.github.com/users/gedads/following{/other_user}","gists_url":"https://api.github.com/users/gedads/gists{/gist_id}","starred_url":"https://api.github.com/users/gedads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedads/subscriptions","organizations_url":"https://api.github.com/users/gedads/orgs","repos_url":"https://api.github.com/users/gedads/repos","events_url":"https://api.github.com/users/gedads/events{/privacy}","received_events_url":"https://api.github.com/users/gedads/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T12:00:07Z","updated_at":"2015-08-12T12:00:07Z","body":"neo dynamis branch is outdated , db is 1 year old at least now. i updated it locally 1 month ago but i need to check it again since i messed groups with august update. (replaced neo dynamis groups by escha ruaun groups)"}}