{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/22634066","id":22634066,"diff_hunk":"@@ -602,22 +587,10 @@ bool RippleAddress::accountPrivateSign (uint256 const& uHash, Blob& vucSig) cons\n Blob RippleAddress::accountPrivateEncrypt (\n     RippleAddress const& naPublicTo, Blob const& vucPlainText) const\n {\n-    openssl::ec_key secretKey = ECDSAPrivateKey (getAccountPrivate());\n-    openssl::ec_key publicKey = ECDSAPublicKey (naPublicTo.getAccountPublic());\n-    \n-    Blob vucCipherText;\n+    uint256 secretKey = getAccountPrivate();\n+    Blob    publicKey = naPublicTo.getAccountPublic();","path":"src/ripple/protocol/impl/RippleAddress.cpp","position":100,"original_position":100,"commit_id":"34b5c5b840f6d0cfe931f3c57c0094ee1ed7df69","original_commit_id":"34b5c5b840f6d0cfe931f3c57c0094ee1ed7df69","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"body":"Does it makes sense to have a \"secret key type\" and a \"public key type\" instead of uint256 and Blob? (I'm sure this code change would ripple through the codebase, so I'm not seriously proposing you change).","created_at":"2015-01-08T03:33:02Z","updated_at":"2015-01-08T03:33:02Z","html_url":"https://github.com/ripple/rippled/pull/792#discussion_r22634066","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/792","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/22634066"},"html":{"href":"https://github.com/ripple/rippled/pull/792#discussion_r22634066"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/792"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/792","id":27002591,"html_url":"https://github.com/ripple/rippled/pull/792","diff_url":"https://github.com/ripple/rippled/pull/792.diff","patch_url":"https://github.com/ripple/rippled/pull/792.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/792","number":792,"state":"open","locked":false,"title":"Don't pass ECDSA key arguments as openssl::ec_key","user":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"body":"This is a step toward removing RippleAddress's dependency on OpenSSL structures and simplifying ed25519 implementation.","created_at":"2015-01-08T01:54:28Z","updated_at":"2015-01-08T03:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"955fd9a54a5e0f637d16af7fa788f544f02a9097","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/792/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/792/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/792/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/34b5c5b840f6d0cfe931f3c57c0094ee1ed7df69","head":{"label":"josh-ripple:ECDSA-key-arguments","ref":"ECDSA-key-arguments","sha":"34b5c5b840f6d0cfe931f3c57c0094ee1ed7df69","user":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"repo":{"id":25010049,"name":"rippled","full_name":"josh-ripple/rippled","owner":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josh-ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/josh-ripple/rippled","forks_url":"https://api.github.com/repos/josh-ripple/rippled/forks","keys_url":"https://api.github.com/repos/josh-ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josh-ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josh-ripple/rippled/teams","hooks_url":"https://api.github.com/repos/josh-ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/josh-ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/josh-ripple/rippled/events","assignees_url":"https://api.github.com/repos/josh-ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/josh-ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/josh-ripple/rippled/tags","blobs_url":"https://api.github.com/repos/josh-ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josh-ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josh-ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/josh-ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josh-ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/josh-ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/josh-ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/josh-ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/josh-ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/josh-ripple/rippled/subscription","commits_url":"https://api.github.com/repos/josh-ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/josh-ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/josh-ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/josh-ripple/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/josh-ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/josh-ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josh-ripple/rippled/merges","archive_url":"https://api.github.com/repos/josh-ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josh-ripple/rippled/downloads","issues_url":"https://api.github.com/repos/josh-ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/josh-ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/josh-ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/josh-ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josh-ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/josh-ripple/rippled/releases{/id}","created_at":"2014-10-09T21:50:27Z","updated_at":"2015-01-08T01:21:26Z","pushed_at":"2015-01-08T02:32:01Z","git_url":"git://github.com/josh-ripple/rippled.git","ssh_url":"git@github.com:josh-ripple/rippled.git","clone_url":"https://github.com/josh-ripple/rippled.git","svn_url":"https://github.com/josh-ripple/rippled","homepage":"https://ripple.com","size":47335,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"df966a9ac6dd986585ecccb206aff24452e41a30","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments/{number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-01-06T03:05:02Z","pushed_at":"2015-01-06T03:05:00Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":97101,"stargazers_count":895,"watchers_count":895,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":142,"forks":246,"open_issues":142,"watchers":895,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/792"},"html":{"href":"https://github.com/ripple/rippled/pull/792"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/792"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/792/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/792/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/792/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/34b5c5b840f6d0cfe931f3c57c0094ee1ed7df69"}}}}