{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/32757413","id":32757413,"diff_hunk":"@@ -7,11 +7,8 @@ import View from 'ember-views/views/view';\n import Controller from 'ember-runtime/controllers/controller';\n import Route from 'ember-routing/system/route';\n import RSVP from 'ember-runtime/ext/rsvp';\n-import keys from 'ember-metal/keys';\n import compile from 'ember-template-compiler/system/compile';\n \n-import 'ember-routing';","path":"packages/ember-application/tests/system/logging_test.js","position":7,"original_position":7,"commit_id":"62f1748912b587a0120bc194b859940722e83931","original_commit_id":"62f1748912b587a0120bc194b859940722e83931","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"I believe that this is needed for side-effects.  Specifically, the run loop queues that are created come to mind (though I could be wrong).","created_at":"2015-06-18T17:47:27Z","updated_at":"2015-06-18T17:47:27Z","html_url":"https://github.com/emberjs/ember.js/pull/11459#discussion_r32757413","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11459","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/32757413"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11459#discussion_r32757413"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11459"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/11459","id":37658326,"html_url":"https://github.com/emberjs/ember.js/pull/11459","diff_url":"https://github.com/emberjs/ember.js/pull/11459.diff","patch_url":"https://github.com/emberjs/ember.js/pull/11459.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/11459","number":11459,"state":"open","locked":false,"title":"[CLEANUP Beta] Remove EmberKeys (internally) continue to expose Ember…","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"….keys but as 1:1 with Object.keys [ES5-only]\r\n\r\n(╯°□°）╯︵ sʎǝʞ¬","created_at":"2015-06-15T04:53:11Z","updated_at":"2015-06-18T17:47:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"204180677d1e073205fd4737c84c552f4c5ff8b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11459/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11459/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/11459/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/62f1748912b587a0120bc194b859940722e83931","head":{"label":"stefanpenner:remove-object-keys","ref":"remove-object-keys","sha":"62f1748912b587a0120bc194b859940722e83931","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":6246321,"name":"ember.js","full_name":"stefanpenner/ember.js","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/stefanpenner/ember.js","forks_url":"https://api.github.com/repos/stefanpenner/ember.js/forks","keys_url":"https://api.github.com/repos/stefanpenner/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/ember.js/teams","hooks_url":"https://api.github.com/repos/stefanpenner/ember.js/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/ember.js/events","assignees_url":"https://api.github.com/repos/stefanpenner/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/ember.js/tags","blobs_url":"https://api.github.com/repos/stefanpenner/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/ember.js/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/ember.js/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/ember.js/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/ember.js/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/ember.js/subscription","commits_url":"https://api.github.com/repos/stefanpenner/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanpenner/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/ember.js/merges","archive_url":"https://api.github.com/repos/stefanpenner/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/ember.js/downloads","issues_url":"https://api.github.com/repos/stefanpenner/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/ember.js/releases{/id}","created_at":"2012-10-16T15:08:40Z","updated_at":"2014-08-26T18:20:24Z","pushed_at":"2015-06-18T17:43:59Z","git_url":"git://github.com/stefanpenner/ember.js.git","ssh_url":"git@github.com:stefanpenner/ember.js.git","clone_url":"https://github.com/stefanpenner/ember.js.git","svn_url":"https://github.com/stefanpenner/ember.js","homepage":"http://www.emberjs.com","size":27839,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"e2355a6c7a4a1f64f50b8e00d8df326f9660c605","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-06-18T16:04:47Z","pushed_at":"2015-06-18T17:44:05Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":81903,"stargazers_count":14067,"watchers_count":14067,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3005,"mirror_url":null,"open_issues_count":517,"forks":3005,"open_issues":517,"watchers":14067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11459"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11459"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11459"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11459/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11459/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11459/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/62f1748912b587a0120bc194b859940722e83931"}}}}