{"action":"created","comment":{"url":"https://api.github.com/repos/Vestorly/torii/pulls/comments/42013696","id":42013696,"diff_hunk":"@@ -1,16 +1,18 @@\n var get = Ember.get;\n \n-var configuration       = get(window, 'ENV.torii') || {};\n-configuration.providers = configuration.providers || {};\n+const NAMESPACE = 'providers';\n+let configuration = {};\n \n function configurable(configKey, defaultValue){\n   return Ember.computed(function configurableComputed(){\n     // Trigger super wrapping in Ember 2.1.\n     // See: https://github.com/emberjs/ember.js/pull/12359\n     this._super = this._super || (function(){ throw new Error('should always have _super'); })();\n-    var namespace = this.get('configNamespace'),\n-        fullKey   = namespace ? [namespace, configKey].join('.') : configKey,\n-        value     = get(configuration, fullKey);\n+    var configNamespace = NAMESPACE + '.' + this.get('name');\n+    var propertyPath = configNamespace + '.' + configKey;\n+    let configuration = getConfiguration();","path":"addon/configuration.js","position":18,"original_position":18,"commit_id":"62d06943dd35956484fe9eda33aec52bceaf7c0f","original_commit_id":"6e42a1b6ec94c9d4a41bacd6c69f0fd23bf49983","user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars.githubusercontent.com/u/8752?v=3","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"body":"> Part of me trying to minimize diff noise was not changing existing var declarations.\r\n\r\n:100: ","created_at":"2015-10-14T16:02:34Z","updated_at":"2015-10-14T16:02:34Z","html_url":"https://github.com/Vestorly/torii/pull/244#discussion_r42013696","pull_request_url":"https://api.github.com/repos/Vestorly/torii/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/comments/42013696"},"html":{"href":"https://github.com/Vestorly/torii/pull/244#discussion_r42013696"},"pull_request":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/Vestorly/torii/pulls/244","id":47462765,"html_url":"https://github.com/Vestorly/torii/pull/244","diff_url":"https://github.com/Vestorly/torii/pull/244.diff","patch_url":"https://github.com/Vestorly/torii/pull/244.patch","issue_url":"https://api.github.com/repos/Vestorly/torii/issues/244","number":244,"state":"open","locked":false,"title":"convert to ember-cli","user":{"login":"bantic","id":2023,"avatar_url":"https://avatars.githubusercontent.com/u/2023?v=3","gravatar_id":"","url":"https://api.github.com/users/bantic","html_url":"https://github.com/bantic","followers_url":"https://api.github.com/users/bantic/followers","following_url":"https://api.github.com/users/bantic/following{/other_user}","gists_url":"https://api.github.com/users/bantic/gists{/gist_id}","starred_url":"https://api.github.com/users/bantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantic/subscriptions","organizations_url":"https://api.github.com/users/bantic/orgs","repos_url":"https://api.github.com/users/bantic/repos","events_url":"https://api.github.com/users/bantic/events{/privacy}","received_events_url":"https://api.github.com/users/bantic/received_events","type":"User","site_admin":false},"body":"This converts Torii to use ember-cli as its build system.\r\nMost of the change is fairly mechanical: moving files to be in the places ember-cli expects them to be. The initializers and services move into `app/` and most of the other files move to `addon/`.\r\n\r\nSome of the test setup is different in an ember-cli environment, though. The most impactful change is to the way configuration is handled. Previously, configuration was read off a window.ENV.torii global. Now it is read from the `config/environment` export that ember-cli provides. The `torii/configuration.js` file is changed to now export `getConfiguration` and `configure`, in addition to `configurable` which it already exported. Its default export is no longer used (it previously default-exported the torii configuration).\r\nThe main \"torii\" initializer uses `configure` to set the torii configuration from `config/environment`.\r\nMany of the tests have been changed to use `configure` rather than modifying a configuration global directly.\r\n\r\nSince this is a large changeset, I attempted to minimize some of the more minor changes by modifying the jshintrc files to add some globals (`window`, `screen`, `localStorage`) as well as to set `\"unused\": false`. In a later PR I intend to revert those settings and fix the associated jshint failures that crop up. I probably should have done more with the test jshintrc also; there's a little bit of a noise in the test changes due to additions of `assert`.\r\n\r\nTo do:\r\n  * [ ] update this or make a separate PR to remove the old grunt build system\r\n  * [ ] real-world testing\r\n  * [x] use ember-try to test different ember versions\r\n  * [ ] update documentation to point out that globals-mode Torii will no longer be supported when this is an ember-cli addon\r\n\r\n\r\n","created_at":"2015-10-12T20:48:06Z","updated_at":"2015-10-14T16:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fe0d1350172d646d7321abf5b4d2ab3a7191e28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vestorly/torii/pulls/244/commits","review_comments_url":"https://api.github.com/repos/Vestorly/torii/pulls/244/comments","review_comment_url":"https://api.github.com/repos/Vestorly/torii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vestorly/torii/issues/244/comments","statuses_url":"https://api.github.com/repos/Vestorly/torii/statuses/62d06943dd35956484fe9eda33aec52bceaf7c0f","head":{"label":"bantic:ember-cli","ref":"ember-cli","sha":"62d06943dd35956484fe9eda33aec52bceaf7c0f","user":{"login":"bantic","id":2023,"avatar_url":"https://avatars.githubusercontent.com/u/2023?v=3","gravatar_id":"","url":"https://api.github.com/users/bantic","html_url":"https://github.com/bantic","followers_url":"https://api.github.com/users/bantic/followers","following_url":"https://api.github.com/users/bantic/following{/other_user}","gists_url":"https://api.github.com/users/bantic/gists{/gist_id}","starred_url":"https://api.github.com/users/bantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantic/subscriptions","organizations_url":"https://api.github.com/users/bantic/orgs","repos_url":"https://api.github.com/users/bantic/repos","events_url":"https://api.github.com/users/bantic/events{/privacy}","received_events_url":"https://api.github.com/users/bantic/received_events","type":"User","site_admin":false},"repo":{"id":21105199,"name":"torii","full_name":"bantic/torii","owner":{"login":"bantic","id":2023,"avatar_url":"https://avatars.githubusercontent.com/u/2023?v=3","gravatar_id":"","url":"https://api.github.com/users/bantic","html_url":"https://github.com/bantic","followers_url":"https://api.github.com/users/bantic/followers","following_url":"https://api.github.com/users/bantic/following{/other_user}","gists_url":"https://api.github.com/users/bantic/gists{/gist_id}","starred_url":"https://api.github.com/users/bantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantic/subscriptions","organizations_url":"https://api.github.com/users/bantic/orgs","repos_url":"https://api.github.com/users/bantic/repos","events_url":"https://api.github.com/users/bantic/events{/privacy}","received_events_url":"https://api.github.com/users/bantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bantic/torii","description":"A set of clean abstractions for authentication in Ember.js","fork":true,"url":"https://api.github.com/repos/bantic/torii","forks_url":"https://api.github.com/repos/bantic/torii/forks","keys_url":"https://api.github.com/repos/bantic/torii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bantic/torii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bantic/torii/teams","hooks_url":"https://api.github.com/repos/bantic/torii/hooks","issue_events_url":"https://api.github.com/repos/bantic/torii/issues/events{/number}","events_url":"https://api.github.com/repos/bantic/torii/events","assignees_url":"https://api.github.com/repos/bantic/torii/assignees{/user}","branches_url":"https://api.github.com/repos/bantic/torii/branches{/branch}","tags_url":"https://api.github.com/repos/bantic/torii/tags","blobs_url":"https://api.github.com/repos/bantic/torii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bantic/torii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bantic/torii/git/refs{/sha}","trees_url":"https://api.github.com/repos/bantic/torii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bantic/torii/statuses/{sha}","languages_url":"https://api.github.com/repos/bantic/torii/languages","stargazers_url":"https://api.github.com/repos/bantic/torii/stargazers","contributors_url":"https://api.github.com/repos/bantic/torii/contributors","subscribers_url":"https://api.github.com/repos/bantic/torii/subscribers","subscription_url":"https://api.github.com/repos/bantic/torii/subscription","commits_url":"https://api.github.com/repos/bantic/torii/commits{/sha}","git_commits_url":"https://api.github.com/repos/bantic/torii/git/commits{/sha}","comments_url":"https://api.github.com/repos/bantic/torii/comments{/number}","issue_comment_url":"https://api.github.com/repos/bantic/torii/issues/comments{/number}","contents_url":"https://api.github.com/repos/bantic/torii/contents/{+path}","compare_url":"https://api.github.com/repos/bantic/torii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bantic/torii/merges","archive_url":"https://api.github.com/repos/bantic/torii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bantic/torii/downloads","issues_url":"https://api.github.com/repos/bantic/torii/issues{/number}","pulls_url":"https://api.github.com/repos/bantic/torii/pulls{/number}","milestones_url":"https://api.github.com/repos/bantic/torii/milestones{/number}","notifications_url":"https://api.github.com/repos/bantic/torii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bantic/torii/labels{/name}","releases_url":"https://api.github.com/repos/bantic/torii/releases{/id}","created_at":"2014-06-22T20:53:36Z","updated_at":"2015-10-09T16:58:17Z","pushed_at":"2015-10-14T15:45:29Z","git_url":"git://github.com/bantic/torii.git","ssh_url":"git@github.com:bantic/torii.git","clone_url":"https://github.com/bantic/torii.git","svn_url":"https://github.com/bantic/torii","homepage":"vestorly.github.io/torii","size":2575,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vestorly:master","ref":"master","sha":"be9e03dafbb0ef212de55a321ac7077a9222565e","user":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"repo":{"id":18303148,"name":"torii","full_name":"Vestorly/torii","owner":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vestorly/torii","description":"A set of clean abstractions for authentication in Ember.js","fork":false,"url":"https://api.github.com/repos/Vestorly/torii","forks_url":"https://api.github.com/repos/Vestorly/torii/forks","keys_url":"https://api.github.com/repos/Vestorly/torii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vestorly/torii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vestorly/torii/teams","hooks_url":"https://api.github.com/repos/Vestorly/torii/hooks","issue_events_url":"https://api.github.com/repos/Vestorly/torii/issues/events{/number}","events_url":"https://api.github.com/repos/Vestorly/torii/events","assignees_url":"https://api.github.com/repos/Vestorly/torii/assignees{/user}","branches_url":"https://api.github.com/repos/Vestorly/torii/branches{/branch}","tags_url":"https://api.github.com/repos/Vestorly/torii/tags","blobs_url":"https://api.github.com/repos/Vestorly/torii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vestorly/torii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vestorly/torii/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vestorly/torii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vestorly/torii/statuses/{sha}","languages_url":"https://api.github.com/repos/Vestorly/torii/languages","stargazers_url":"https://api.github.com/repos/Vestorly/torii/stargazers","contributors_url":"https://api.github.com/repos/Vestorly/torii/contributors","subscribers_url":"https://api.github.com/repos/Vestorly/torii/subscribers","subscription_url":"https://api.github.com/repos/Vestorly/torii/subscription","commits_url":"https://api.github.com/repos/Vestorly/torii/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vestorly/torii/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vestorly/torii/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vestorly/torii/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vestorly/torii/contents/{+path}","compare_url":"https://api.github.com/repos/Vestorly/torii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vestorly/torii/merges","archive_url":"https://api.github.com/repos/Vestorly/torii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vestorly/torii/downloads","issues_url":"https://api.github.com/repos/Vestorly/torii/issues{/number}","pulls_url":"https://api.github.com/repos/Vestorly/torii/pulls{/number}","milestones_url":"https://api.github.com/repos/Vestorly/torii/milestones{/number}","notifications_url":"https://api.github.com/repos/Vestorly/torii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vestorly/torii/labels{/name}","releases_url":"https://api.github.com/repos/Vestorly/torii/releases{/id}","created_at":"2014-03-31T18:16:42Z","updated_at":"2015-10-09T16:58:19Z","pushed_at":"2015-10-14T15:45:30Z","git_url":"git://github.com/Vestorly/torii.git","ssh_url":"git@github.com:Vestorly/torii.git","clone_url":"https://github.com/Vestorly/torii.git","svn_url":"https://github.com/Vestorly/torii","homepage":"vestorly.github.io/torii","size":3861,"stargazers_count":560,"watchers_count":560,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":32,"forks":90,"open_issues":32,"watchers":560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/244"},"html":{"href":"https://github.com/Vestorly/torii/pull/244"},"issue":{"href":"https://api.github.com/repos/Vestorly/torii/issues/244"},"comments":{"href":"https://api.github.com/repos/Vestorly/torii/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/Vestorly/torii/statuses/62d06943dd35956484fe9eda33aec52bceaf7c0f"}}}}