{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/45525626","id":45525626,"diff_hunk":"@@ -0,0 +1,23 @@\n+---\n+- name: Set nfs facts\n+  hosts: oo_nfs_to_config\n+  roles:\n+  - role: openshift_facts\n+  post_tasks:\n+  - openshift_facts:\n+      role: nfs\n+      local_facts:\n+        exports_dir: \"{{ openshift_nfs_exports_dir | default(None) }}\"\n+        export_options: \"{{ openshift_nfs_export_options | default(None) }}\"\n+        registry_storage: \"{{ openshift_nfs_registry_storage | default(None) }}\"\n+        registry_volume: \"{{ openshift_nfs_registry_volume | default(None) }}\"\n+\n+- name: Configure nfs hosts\n+  hosts: oo_nfs_to_config\n+  vars:\n+    exports_dir: \"{{ openshift.nfs.exports_dir }}\"\n+    export_options: \"{{ openshift.nfs.export_options }}\"\n+    registry_storage: \"{{ openshift.nfs.registry_storage }}\"\n+    registry_volume: \"{{ openshift.nfs.registry_volume }}\"\n+  roles:\n+  - role: openshift_storage_nfs","path":"playbooks/common/openshift-nfs/config.yml","position":23,"original_position":23,"commit_id":"5f6540acb717a71ee7d24419a000c2dedcf88b32","original_commit_id":"5f6540acb717a71ee7d24419a000c2dedcf88b32","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"We should be pulling those values out of the facts we set, instead of relying on the playbook level variables. That way we don't start creating artificial dependencies on different playbooks.","created_at":"2015-11-20T22:12:30Z","updated_at":"2015-11-20T22:12:30Z","html_url":"https://github.com/openshift/openshift-ansible/pull/951#discussion_r45525626","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/45525626"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/951#discussion_r45525626"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951","id":51412421,"html_url":"https://github.com/openshift/openshift-ansible/pull/951","diff_url":"https://github.com/openshift/openshift-ansible/pull/951.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/951.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/951","number":951,"state":"open","locked":false,"title":"WIP: NFS for registry storage","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"Rough start but opening so we can talk shop @detiber \r\n\r\n* Adds an `[nfs]` host group (this should probably be limited to one by some condition?)\r\n* Creates registry export on `[nfs]` host - paths can be overridden. \r\n* Creates docker-registry if infra nodes are present.\r\n* If the `[nfs]` host group contains members, attaches a PV (with a currently arbitrary size) to the docker-registry.\r\n","created_at":"2015-11-20T21:46:10Z","updated_at":"2015-11-20T22:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9e07d2d0ab66aee450a5c84053defdcf7d84b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/951/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/5f6540acb717a71ee7d24419a000c2dedcf88b32","head":{"label":"abutcher:nfs","ref":"nfs","sha":"5f6540acb717a71ee7d24419a000c2dedcf88b32","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"repo":{"id":40020725,"name":"openshift-ansible","full_name":"abutcher/openshift-ansible","owner":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abutcher/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/abutcher/openshift-ansible","forks_url":"https://api.github.com/repos/abutcher/openshift-ansible/forks","keys_url":"https://api.github.com/repos/abutcher/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abutcher/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abutcher/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/abutcher/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abutcher/openshift-ansible/events","assignees_url":"https://api.github.com/repos/abutcher/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abutcher/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abutcher/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abutcher/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/abutcher/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/abutcher/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abutcher/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abutcher/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abutcher/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abutcher/openshift-ansible/merges","archive_url":"https://api.github.com/repos/abutcher/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abutcher/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abutcher/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abutcher/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abutcher/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abutcher/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/abutcher/openshift-ansible/releases{/id}","created_at":"2015-07-31T19:07:31Z","updated_at":"2015-07-31T19:07:33Z","pushed_at":"2015-11-20T21:36:22Z","git_url":"git://github.com/abutcher/openshift-ansible.git","ssh_url":"git@github.com:abutcher/openshift-ansible.git","clone_url":"https://github.com/abutcher/openshift-ansible.git","svn_url":"https://github.com/abutcher/openshift-ansible","homepage":"","size":2111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8e979def0a56b40ab8a3acbd2e1a146457a5aaa6","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-11-19T21:46:26Z","pushed_at":"2015-11-20T21:46:10Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":2894,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":138,"forks":164,"open_issues":138,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/951"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/951"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/5f6540acb717a71ee7d24419a000c2dedcf88b32"}}}}