{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/48111465","id":48111465,"diff_hunk":"@@ -555,80 +559,69 @@ private File makeIndexFiles(\n       dimConversions.add(Maps.<String, IntBuffer>newHashMap());\n     }\n \n+    final Timer timer = new Timer(2);\n     for (String dimension : mergedDimensions) {\n       final GenericIndexedWriter<String> writer = new GenericIndexedWriter<String>(\n           ioPeon, dimension, GenericIndexed.STRING_STRATEGY\n       );\n       writer.open();\n \n-      List<Indexed<String>> dimValueLookups = Lists.newArrayListWithCapacity(indexes.size());\n-      DimValueConverter[] converters = new DimValueConverter[indexes.size()];\n+      int counter = 0;","path":"processing/src/main/java/io/druid/segment/IndexMerger.java","position":50,"original_position":50,"commit_id":"82bab152749a95d11cdf2a08ea2063c418a4971e","original_commit_id":"82bab152749a95d11cdf2a08ea2063c418a4971e","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"renamed to `numMergeIndex`","created_at":"2015-12-21T01:06:21Z","updated_at":"2015-12-21T01:06:21Z","html_url":"https://github.com/druid-io/druid/pull/2094#discussion_r48111465","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/2094","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/48111465"},"html":{"href":"https://github.com/druid-io/druid/pull/2094#discussion_r48111465"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2094"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2094","id":53680017,"html_url":"https://github.com/druid-io/druid/pull/2094","diff_url":"https://github.com/druid-io/druid/pull/2094.diff","patch_url":"https://github.com/druid-io/druid/pull/2094.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2094","number":2094,"state":"open","locked":false,"title":"Simplifying dimension merging","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"Currently, dimension merging is processed by two stages. One for dictionary, one for index. If this can be processed by  single stage, total processing time could be deceased.","created_at":"2015-12-15T09:43:23Z","updated_at":"2015-12-21T01:06:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad1c2799d0c776630d38524a9c5213fc6b389c54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/2094/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/2094/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2094/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/82bab152749a95d11cdf2a08ea2063c418a4971e","head":{"label":"navis:simplify-index-merge","ref":"simplify-index-merge","sha":"82bab152749a95d11cdf2a08ea2063c418a4971e","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"repo":{"id":45149930,"name":"druid","full_name":"navis/druid","owner":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/navis/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/navis/druid","forks_url":"https://api.github.com/repos/navis/druid/forks","keys_url":"https://api.github.com/repos/navis/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navis/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navis/druid/teams","hooks_url":"https://api.github.com/repos/navis/druid/hooks","issue_events_url":"https://api.github.com/repos/navis/druid/issues/events{/number}","events_url":"https://api.github.com/repos/navis/druid/events","assignees_url":"https://api.github.com/repos/navis/druid/assignees{/user}","branches_url":"https://api.github.com/repos/navis/druid/branches{/branch}","tags_url":"https://api.github.com/repos/navis/druid/tags","blobs_url":"https://api.github.com/repos/navis/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navis/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navis/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/navis/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navis/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/navis/druid/languages","stargazers_url":"https://api.github.com/repos/navis/druid/stargazers","contributors_url":"https://api.github.com/repos/navis/druid/contributors","subscribers_url":"https://api.github.com/repos/navis/druid/subscribers","subscription_url":"https://api.github.com/repos/navis/druid/subscription","commits_url":"https://api.github.com/repos/navis/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/navis/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/navis/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/navis/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/navis/druid/contents/{+path}","compare_url":"https://api.github.com/repos/navis/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navis/druid/merges","archive_url":"https://api.github.com/repos/navis/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navis/druid/downloads","issues_url":"https://api.github.com/repos/navis/druid/issues{/number}","pulls_url":"https://api.github.com/repos/navis/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/navis/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/navis/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navis/druid/labels{/name}","releases_url":"https://api.github.com/repos/navis/druid/releases{/id}","created_at":"2015-10-29T00:22:35Z","updated_at":"2015-10-29T00:22:47Z","pushed_at":"2015-12-21T00:58:57Z","git_url":"git://github.com/navis/druid.git","ssh_url":"git@github.com:navis/druid.git","clone_url":"https://github.com/navis/druid.git","svn_url":"https://github.com/navis/druid","homepage":"http://druid.io","size":98970,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"628643d80e41cb8d6687b4d13692afe7bfa674a1","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-12-20T15:20:46Z","pushed_at":"2015-12-21T00:58:57Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":118030,"stargazers_count":2287,"watchers_count":2287,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"open_issues_count":272,"forks":537,"open_issues":272,"watchers":2287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2094"},"html":{"href":"https://github.com/druid-io/druid/pull/2094"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/2094"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/2094/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2094/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2094/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/82bab152749a95d11cdf2a08ea2063c418a4971e"}}}}