{"action":"created","issue":{"url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/221","labels_url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/221/comments","events_url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/221/events","html_url":"https://github.com/monarch-initiative/phenogrid/issues/221","id":119507464,"number":221,"title":"Design considerations about adjusted columns/rows after inverting axis","user":{"login":"yuanzhou","id":195873,"avatar_url":"https://avatars.githubusercontent.com/u/195873?v=3","gravatar_id":"","url":"https://api.github.com/users/yuanzhou","html_url":"https://github.com/yuanzhou","followers_url":"https://api.github.com/users/yuanzhou/followers","following_url":"https://api.github.com/users/yuanzhou/following{/other_user}","gists_url":"https://api.github.com/users/yuanzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/yuanzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuanzhou/subscriptions","organizations_url":"https://api.github.com/users/yuanzhou/orgs","repos_url":"https://api.github.com/users/yuanzhou/repos","events_url":"https://api.github.com/users/yuanzhou/events{/privacy}","received_events_url":"https://api.github.com/users/yuanzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-30T14:50:36Z","updated_at":"2015-12-03T17:04:12Z","closed_at":"2015-12-03T17:04:12Z","body":"This issue is related to #137 but needs some different discussions.\r\n\r\nWhen we dynamically adjust the number of columns/rows based on the containing div's width/height, we could use more display space to show more grids. It comes to the question when we need to invert the axis. Say we are displaying 60 visible columns (100 total) and only 30 visible rows (100 total) within the current containing div. When inverting, the containing div's width and height won't change, so the best way is to still display 60 columns and 30 rows. But when we only have 30 total rows and 100 columns, after inverting, we'll just show 30 rows and 30 columns. It should be very common that we have more than 100 target columns and far less source phenotypes. If the containing div stays the same size, we'll end up only showing \"the number of original rows\" columns after inverting and may have a huge whitespace on the right for a wider screen.\r\n\r\nThis seems like a situation that we haven't captured in the current design, since in most cases, we show the same number of columns/rows, and inverting flips the whole grid without taking into the consideration that the containing div stays the same. Especially when we run phenogrid inside monarch, there's nothing below the grid, so the containing div's height changes accordingly. But in a more realistic world, phenogrid can be embedded into any section of the webpages within a fixed size of containing div. We won't be able to adjust the height of containing div after inverting. \r\n\r\n@harryhoch @nlwashington any insights? "},"comment":{"url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/comments/161717176","html_url":"https://github.com/monarch-initiative/phenogrid/issues/221#issuecomment-161717176","issue_url":"https://api.github.com/repos/monarch-initiative/phenogrid/issues/221","id":161717176,"user":{"login":"yuanzhou","id":195873,"avatar_url":"https://avatars.githubusercontent.com/u/195873?v=3","gravatar_id":"","url":"https://api.github.com/users/yuanzhou","html_url":"https://github.com/yuanzhou","followers_url":"https://api.github.com/users/yuanzhou/followers","following_url":"https://api.github.com/users/yuanzhou/following{/other_user}","gists_url":"https://api.github.com/users/yuanzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/yuanzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuanzhou/subscriptions","organizations_url":"https://api.github.com/users/yuanzhou/orgs","repos_url":"https://api.github.com/users/yuanzhou/repos","events_url":"https://api.github.com/users/yuanzhou/events{/privacy}","received_events_url":"https://api.github.com/users/yuanzhou/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T17:04:12Z","updated_at":"2015-12-03T17:04:12Z","body":"This issue is relatively minor in the current development goals after discussion. So I'll close it. Will re-open it if it's needs to be addressed in the future."}}