{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/nota/issues/7","labels_url":"https://api.github.com/repos/dankelley/nota/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/nota/issues/7/comments","events_url":"https://api.github.com/repos/dankelley/nota/issues/7/events","html_url":"https://github.com/dankelley/nota/issues/7","id":59588957,"number":7,"title":"Should trashed notes be returned in searches?","user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/nota/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-03-03T03:14:25Z","updated_at":"2015-03-07T15:39:54Z","closed_at":null,"body":"Currently a note search done either by not typing a complete hash, or by keyword, will return notes that are in the trash. I'm not sure if this is desired or not.\r\n\r\nI would make the argument that trashed notes shouldn't be seen, unless one specifically *asks* to see them (e.g. `nota --trash`).\r\n\r\nAnother option could be to tie verbosity into the search results, e.g. to make notes that match the search terms but that are in the trash be labelled as such. Maybe something like:\r\n```\r\n$ nota -k foo\r\na1: Note 1 [foo, bar, foobar]\r\nb2: Note 2 [foo, oof]\r\n2 Trashed notes match search (c3, d4)\r\n```\r\nbut with `--verbosity 0` you would see\r\n```\r\n$ nota -k foo\r\na1: Note 1 [foo, bar, foobar]\r\nb2: Note 2 [foo, oof]\r\n```"},"comment":{"url":"https://api.github.com/repos/dankelley/nota/issues/comments/77694226","html_url":"https://github.com/dankelley/nota/issues/7#issuecomment-77694226","issue_url":"https://api.github.com/repos/dankelley/nota/issues/7","id":77694226,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2015-03-07T15:39:54Z","updated_at":"2015-03-07T15:39:54Z","body":"I think this is working ok now in ``master`` and ``develop``, but I plan to use it for a couple of days to see if any new problems have arisen, because the code modifications were significant."}}