{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/comments/40068670","id":40068670,"diff_hunk":"@@ -12,9 +12,42 @@ window.addEventListener('load', trigger.bind(null, 'load'));\n window.addEventListener('load', trigger.bind(null, 'DOMContentLoaded'));\n document.addEventListener('DOMContentLoaded', trigger.bind(null, 'DOMContentLoaded'));\n \n+document.onreadystatechange = function () {\n+\tif (document.readyState === 'complete') {\n+\t\ttrigger('DOMContentLoaded');\n+\t\ttrigger('load');\n+\t}\n+};\n+\n if (document.readyState === 'complete') {\n-\ttrigger('load');\n-\ttrigger('DOMContentLoaded');\n-} else if (document.readyState === 'interactive') {","path":"main.js","position":14,"original_position":14,"commit_id":"0a60554c9fa12539367455fd143ddb259d5408c2","original_commit_id":"0a60554c9fa12539367455fd143ddb259d5408c2","user":{"login":"triblondon","id":1735391,"avatar_url":"https://avatars.githubusercontent.com/u/1735391?v=3","gravatar_id":"","url":"https://api.github.com/users/triblondon","html_url":"https://github.com/triblondon","followers_url":"https://api.github.com/users/triblondon/followers","following_url":"https://api.github.com/users/triblondon/following{/other_user}","gists_url":"https://api.github.com/users/triblondon/gists{/gist_id}","starred_url":"https://api.github.com/users/triblondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triblondon/subscriptions","organizations_url":"https://api.github.com/users/triblondon/orgs","repos_url":"https://api.github.com/users/triblondon/repos","events_url":"https://api.github.com/users/triblondon/events{/privacy}","received_events_url":"https://api.github.com/users/triblondon/received_events","type":"User","site_admin":false},"body":"OK, in that case can we do the attachevent check so we can still fire domcontentloaded earlier for modern browsers, and otherwise, ship it. +1","created_at":"2015-09-22T09:50:26Z","updated_at":"2015-09-22T09:50:26Z","html_url":"https://github.com/Financial-Times/o-autoinit/pull/2#discussion_r40068670","pull_request_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/comments/40068670"},"html":{"href":"https://github.com/Financial-Times/o-autoinit/pull/2#discussion_r40068670"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2","id":45381253,"html_url":"https://github.com/Financial-Times/o-autoinit/pull/2","diff_url":"https://github.com/Financial-Times/o-autoinit/pull/2.diff","patch_url":"https://github.com/Financial-Times/o-autoinit/pull/2.patch","issue_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/2","number":2,"state":"open","locked":false,"title":"Fix IE issue with document.readyState in interactive","user":{"login":"roland-vachter","id":4048999,"avatar_url":"https://avatars.githubusercontent.com/u/4048999?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-vachter","html_url":"https://github.com/roland-vachter","followers_url":"https://api.github.com/users/roland-vachter/followers","following_url":"https://api.github.com/users/roland-vachter/following{/other_user}","gists_url":"https://api.github.com/users/roland-vachter/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-vachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-vachter/subscriptions","organizations_url":"https://api.github.com/users/roland-vachter/orgs","repos_url":"https://api.github.com/users/roland-vachter/repos","events_url":"https://api.github.com/users/roland-vachter/events{/privacy}","received_events_url":"https://api.github.com/users/roland-vachter/received_events","type":"User","site_admin":false},"body":"The IE part is an inspiration from jQuery 1.9.1","created_at":"2015-09-18T08:33:15Z","updated_at":"2015-09-22T09:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a60361d17cc4e2626f337bc3b38f7e8865e61e4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/2/comments","statuses_url":"https://api.github.com/repos/Financial-Times/o-autoinit/statuses/0a60554c9fa12539367455fd143ddb259d5408c2","head":{"label":"Financial-Times:fix_ie_issue_interactive","ref":"fix_ie_issue_interactive","sha":"0a60554c9fa12539367455fd143ddb259d5408c2","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":39503570,"name":"o-autoinit","full_name":"Financial-Times/o-autoinit","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-autoinit","description":"Auto-initalisation event emitter","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-autoinit","forks_url":"https://api.github.com/repos/Financial-Times/o-autoinit/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-autoinit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-autoinit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-autoinit/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-autoinit/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-autoinit/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-autoinit/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-autoinit/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-autoinit/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-autoinit/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-autoinit/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-autoinit/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-autoinit/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-autoinit/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-autoinit/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-autoinit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-autoinit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/o-autoinit/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-autoinit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-autoinit/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-autoinit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-autoinit/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-autoinit/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-autoinit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-autoinit/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-autoinit/releases{/id}","created_at":"2015-07-22T11:57:40Z","updated_at":"2015-07-22T12:05:47Z","pushed_at":"2015-09-18T08:33:15Z","git_url":"git://github.com/Financial-Times/o-autoinit.git","ssh_url":"git@github.com:Financial-Times/o-autoinit.git","clone_url":"https://github.com/Financial-Times/o-autoinit.git","svn_url":"https://github.com/Financial-Times/o-autoinit","homepage":"http://registry.origami.ft.com/components/o-autoinit","size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"676102b25213e3ecada485a0b35cbb5cb6d65d90","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":39503570,"name":"o-autoinit","full_name":"Financial-Times/o-autoinit","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-autoinit","description":"Auto-initalisation event emitter","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-autoinit","forks_url":"https://api.github.com/repos/Financial-Times/o-autoinit/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-autoinit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-autoinit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-autoinit/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-autoinit/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-autoinit/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-autoinit/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-autoinit/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-autoinit/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-autoinit/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-autoinit/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-autoinit/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-autoinit/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-autoinit/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-autoinit/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-autoinit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-autoinit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-autoinit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/o-autoinit/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-autoinit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-autoinit/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-autoinit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-autoinit/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-autoinit/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-autoinit/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-autoinit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-autoinit/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-autoinit/releases{/id}","created_at":"2015-07-22T11:57:40Z","updated_at":"2015-07-22T12:05:47Z","pushed_at":"2015-09-18T08:33:15Z","git_url":"git://github.com/Financial-Times/o-autoinit.git","ssh_url":"git@github.com:Financial-Times/o-autoinit.git","clone_url":"https://github.com/Financial-Times/o-autoinit.git","svn_url":"https://github.com/Financial-Times/o-autoinit","homepage":"http://registry.origami.ft.com/components/o-autoinit","size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2"},"html":{"href":"https://github.com/Financial-Times/o-autoinit/pull/2"},"issue":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/2"},"comments":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/o-autoinit/statuses/0a60554c9fa12539367455fd143ddb259d5408c2"}}}}