{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/31840478","id":31840478,"diff_hunk":"@@ -172,13 +172,31 @@\n \n /obj/item/stack/proc/use(var/amount)\n \tASSERT(isnum(src.amount))\n+\n \tif(src.amount>=amount)\n \t\tsrc.amount-=amount\n \telse\n \t\treturn 0\n \t. = 1\n-\tif (src.amount<=0)\n+\tif (src.amount<=0) //If the stack is empty after removing the required amount of items!\n \t\tif(usr)\n+\t\t\tif(istype(usr,/mob/living/silicon/robot))\n+\t\t\t\tvar/mob/living/silicon/robot/R=usr\n+\t\t\t\tif(R.module)\n+\t\t\t\t\tR.module.modules -= src\n+\t\t\t\tif(R.module_active == src) R.module_active = null\n+\t\t\t\tif(R.module_state_1 == src)","path":"code/game/objects/items/stacks/stack.dm","position":27,"original_position":27,"commit_id":"f6eac00887697f059f532b66705812df600ec43f","original_commit_id":"ca8ecaecf782622aa7430db42c3251ba53b67220","user":{"login":"Unfit","id":9512290,"avatar_url":"https://avatars.githubusercontent.com/u/9512290?v=3","gravatar_id":"","url":"https://api.github.com/users/Unfit","html_url":"https://github.com/Unfit","followers_url":"https://api.github.com/users/Unfit/followers","following_url":"https://api.github.com/users/Unfit/following{/other_user}","gists_url":"https://api.github.com/users/Unfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Unfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unfit/subscriptions","organizations_url":"https://api.github.com/users/Unfit/orgs","repos_url":"https://api.github.com/users/Unfit/repos","events_url":"https://api.github.com/users/Unfit/events{/privacy}","received_events_url":"https://api.github.com/users/Unfit/received_events","type":"User","site_admin":false},"body":"yes it's sad but there are actually 3 different variables for the item slots\r\nI'd try to change that but it will take some time (and this PR wants to be merged asap, since engiborgs are horribly bugged and potentially unplayable right now)","created_at":"2015-06-05T18:49:12Z","updated_at":"2015-06-05T18:49:12Z","html_url":"https://github.com/d3athrow/vgstation13/pull/4844#discussion_r31840478","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/31840478"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4844#discussion_r31840478"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844","id":37054740,"html_url":"https://github.com/d3athrow/vgstation13/pull/4844","diff_url":"https://github.com/d3athrow/vgstation13/pull/4844.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/4844.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4844","number":4844,"state":"open","locked":false,"title":"Fixes stack behaviour with silicons","user":{"login":"Unfit","id":9512290,"avatar_url":"https://avatars.githubusercontent.com/u/9512290?v=3","gravatar_id":"","url":"https://api.github.com/users/Unfit","html_url":"https://github.com/Unfit","followers_url":"https://api.github.com/users/Unfit/followers","following_url":"https://api.github.com/users/Unfit/following{/other_user}","gists_url":"https://api.github.com/users/Unfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Unfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unfit/subscriptions","organizations_url":"https://api.github.com/users/Unfit/orgs","repos_url":"https://api.github.com/users/Unfit/repos","events_url":"https://api.github.com/users/Unfit/events{/privacy}","received_events_url":"https://api.github.com/users/Unfit/received_events","type":"User","site_admin":false},"body":"[Hotfix] [No longer loose]\r\nFixes #3239\r\nFixes #4163\r\nFixes #4010\r\nFixes #2931\r\n\r\n1) (most important) stacks no longer get stuck in a borg's interface when used up, allowing creating infinite 1-cost items (chairs, stools etc) or using a single floor tile on 50 plating turfs\r\n2) the status bar now lists ALL stacks a robot has, from metal to reinforced plasma glass\r\n\r\ngod bless the US\r\nshoutout to the guy who copypasted the use() proc into metal and floor tile code (without even changing it). I wasted plenty of time trying to think why my changes to stack/proc/use() had absolutely no effect","created_at":"2015-06-05T17:56:33Z","updated_at":"2015-06-05T18:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea4b8136735f44c1b17e98d5007f23230064e09f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4844/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/f6eac00887697f059f532b66705812df600ec43f","head":{"label":"Unfit:hlhjlklk","ref":"hlhjlklk","sha":"f6eac00887697f059f532b66705812df600ec43f","user":{"login":"Unfit","id":9512290,"avatar_url":"https://avatars.githubusercontent.com/u/9512290?v=3","gravatar_id":"","url":"https://api.github.com/users/Unfit","html_url":"https://github.com/Unfit","followers_url":"https://api.github.com/users/Unfit/followers","following_url":"https://api.github.com/users/Unfit/following{/other_user}","gists_url":"https://api.github.com/users/Unfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Unfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unfit/subscriptions","organizations_url":"https://api.github.com/users/Unfit/orgs","repos_url":"https://api.github.com/users/Unfit/repos","events_url":"https://api.github.com/users/Unfit/events{/privacy}","received_events_url":"https://api.github.com/users/Unfit/received_events","type":"User","site_admin":false},"repo":{"id":26714964,"name":"vgstation13","full_name":"Unfit/vgstation13","owner":{"login":"Unfit","id":9512290,"avatar_url":"https://avatars.githubusercontent.com/u/9512290?v=3","gravatar_id":"","url":"https://api.github.com/users/Unfit","html_url":"https://github.com/Unfit","followers_url":"https://api.github.com/users/Unfit/followers","following_url":"https://api.github.com/users/Unfit/following{/other_user}","gists_url":"https://api.github.com/users/Unfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Unfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unfit/subscriptions","organizations_url":"https://api.github.com/users/Unfit/orgs","repos_url":"https://api.github.com/users/Unfit/repos","events_url":"https://api.github.com/users/Unfit/events{/privacy}","received_events_url":"https://api.github.com/users/Unfit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Unfit/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/Unfit/vgstation13","forks_url":"https://api.github.com/repos/Unfit/vgstation13/forks","keys_url":"https://api.github.com/repos/Unfit/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unfit/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unfit/vgstation13/teams","hooks_url":"https://api.github.com/repos/Unfit/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/Unfit/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/Unfit/vgstation13/events","assignees_url":"https://api.github.com/repos/Unfit/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/Unfit/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/Unfit/vgstation13/tags","blobs_url":"https://api.github.com/repos/Unfit/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unfit/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unfit/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unfit/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unfit/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/Unfit/vgstation13/languages","stargazers_url":"https://api.github.com/repos/Unfit/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/Unfit/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/Unfit/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/Unfit/vgstation13/subscription","commits_url":"https://api.github.com/repos/Unfit/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unfit/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unfit/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unfit/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unfit/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/Unfit/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unfit/vgstation13/merges","archive_url":"https://api.github.com/repos/Unfit/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unfit/vgstation13/downloads","issues_url":"https://api.github.com/repos/Unfit/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/Unfit/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/Unfit/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/Unfit/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unfit/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/Unfit/vgstation13/releases{/id}","created_at":"2014-11-16T13:31:27Z","updated_at":"2015-05-08T15:36:31Z","pushed_at":"2015-06-05T18:45:43Z","git_url":"git://github.com/Unfit/vgstation13.git","ssh_url":"git@github.com:Unfit/vgstation13.git","clone_url":"https://github.com/Unfit/vgstation13.git","svn_url":"https://github.com/Unfit/vgstation13","homepage":"","size":914061,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"44583610ea9b7ef84d6678fc464e21134c5f95fb","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2015-06-01T07:14:25Z","pushed_at":"2015-06-05T18:45:44Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1093289,"stargazers_count":59,"watchers_count":59,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":611,"forks":170,"open_issues":611,"watchers":59,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4844"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4844"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4844/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4844/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/f6eac00887697f059f532b66705812df600ec43f"}}}}