{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/comments/44712646","id":44712646,"diff_hunk":"@@ -1,36 +1,35 @@\n {\n   \"name\": \"generator-videojs-plugin\",\n-  \"version\": \"0.1.2\",\n-  \"description\": \"Yeoman generator for video.js plugins\",\n-  \"license\": \"MIT\",\n-  \"main\": \"app/index.js\",\n-  \"repository\": \"dmlap/generator-videojs-plugin\",\n+  \"version\": \"0.0.0\",\n+  \"description\": \"A Yeoman generator for VideoJS plugins\",\n+  \"license\": \"Apache 2.0\",","path":"package.json","position":10,"original_position":10,"commit_id":"7f8410e94a579c30211b55d8a09f916310813a85","original_commit_id":"7f8410e94a579c30211b55d8a09f916310813a85","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"Should be `Apache-2.0`","created_at":"2015-11-12T20:51:41Z","updated_at":"2015-11-12T20:51:41Z","html_url":"https://github.com/videojs/generator-videojs-plugin/pull/5#discussion_r44712646","pull_request_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/comments/44712646"},"html":{"href":"https://github.com/videojs/generator-videojs-plugin/pull/5#discussion_r44712646"},"pull_request":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5","id":49457037,"html_url":"https://github.com/videojs/generator-videojs-plugin/pull/5","diff_url":"https://github.com/videojs/generator-videojs-plugin/pull/5.diff","patch_url":"https://github.com/videojs/generator-videojs-plugin/pull/5.patch","issue_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/5","number":5,"state":"open","locked":false,"title":"Rewrite","user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"body":"This project has been languishing for a while, but with our new effort to standardize plugin authoring practices, it's a good time to bring it back to life.\r\n\r\nThis PR represents a complete rewrite of the generator to generate video.js 5.0-compatible plugins, which use ES6, Browserify, and more modern goodies by default.\r\n\r\n### TODOs\r\n\r\nHere are some things I'd like to have in place before merging:\r\n\r\n- [x] npm-based banner comments.\r\n- [x] npm-based static server.\r\n- [x] Tests.\r\n- [x] `npm test` / Karma\r\n- [x] `npm watch-test`\r\n- [x] Write versioning scripts to enforce Bower-friendly tagging process.\r\n- [x] ~~Make sure we deal with various configurations of Browserify and video.js 5.0. We ran into a few weird edge-cases internally at BCOV.~~ Will deal with this on the video.js side.\r\n- [x] Implement a documentation generator, we can generate nice docs for any plugin.\r\n- [x] ~~Define the publishing process beyond `npm publish` - if any... there may not be a need.~~ I think `npm publish` is sufficient for open-source plugins. Closed-source plugins will have to fend for themselves!\r\n- [x] `build` should not necessarily `test` as well.\r\n- [x] Use npm-run-all where possible.\r\n- [x] Watch JS via Browserify instead of grunt-contrib-watch.\r\n- [x] Look up default author from `git config` (as in old generator).","created_at":"2015-11-02T17:00:36Z","updated_at":"2015-11-12T20:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7d3fbfa169c01c2dfe6225d6bf81829165c376","assignee":null,"milestone":{"url":"https://api.github.com/repos/videojs/generator-videojs-plugin/milestones/1","html_url":"https://github.com/videojs/generator-videojs-plugin/milestones/v1.0.0","labels_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/milestones/1/labels","id":1392663,"number":1,"title":"v1.0.0","description":"","creator":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-11-04T01:12:14Z","updated_at":"2015-11-04T01:12:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5/commits","review_comments_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5/comments","review_comment_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/5/comments","statuses_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/statuses/7f8410e94a579c30211b55d8a09f916310813a85","head":{"label":"videojs:rewrite","ref":"rewrite","sha":"7f8410e94a579c30211b55d8a09f916310813a85","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":19191187,"name":"generator-videojs-plugin","full_name":"videojs/generator-videojs-plugin","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/generator-videojs-plugin","description":"Yeoman generator for video.js plugins.","fork":false,"url":"https://api.github.com/repos/videojs/generator-videojs-plugin","forks_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/forks","keys_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/teams","hooks_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/hooks","issue_events_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/events","assignees_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/tags","blobs_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/languages","stargazers_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/stargazers","contributors_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/contributors","subscribers_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/subscribers","subscription_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/subscription","commits_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/merges","archive_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/downloads","issues_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/labels{/name}","releases_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/releases{/id}","created_at":"2014-04-26T23:35:48Z","updated_at":"2015-11-02T16:24:01Z","pushed_at":"2015-11-12T18:32:59Z","git_url":"git://github.com/videojs/generator-videojs-plugin.git","ssh_url":"git@github.com:videojs/generator-videojs-plugin.git","clone_url":"https://github.com/videojs/generator-videojs-plugin.git","svn_url":"https://github.com/videojs/generator-videojs-plugin","homepage":null,"size":299,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"976cb42b0b15008e3017adbf09552489f7bc55cf","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":19191187,"name":"generator-videojs-plugin","full_name":"videojs/generator-videojs-plugin","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/generator-videojs-plugin","description":"Yeoman generator for video.js plugins.","fork":false,"url":"https://api.github.com/repos/videojs/generator-videojs-plugin","forks_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/forks","keys_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/teams","hooks_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/hooks","issue_events_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/events","assignees_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/tags","blobs_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/languages","stargazers_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/stargazers","contributors_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/contributors","subscribers_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/subscribers","subscription_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/subscription","commits_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/merges","archive_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/downloads","issues_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/labels{/name}","releases_url":"https://api.github.com/repos/videojs/generator-videojs-plugin/releases{/id}","created_at":"2014-04-26T23:35:48Z","updated_at":"2015-11-02T16:24:01Z","pushed_at":"2015-11-12T18:32:59Z","git_url":"git://github.com/videojs/generator-videojs-plugin.git","ssh_url":"git@github.com:videojs/generator-videojs-plugin.git","clone_url":"https://github.com/videojs/generator-videojs-plugin.git","svn_url":"https://github.com/videojs/generator-videojs-plugin","homepage":null,"size":299,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5"},"html":{"href":"https://github.com/videojs/generator-videojs-plugin/pull/5"},"issue":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/5"},"comments":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/generator-videojs-plugin/statuses/7f8410e94a579c30211b55d8a09f916310813a85"}}}}