{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/7544","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/7544/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/7544/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/7544/events","html_url":"https://github.com/dotnet/roslyn/pull/7544","id":122617884,"number":7544,"title":"Call ICompletionSession.Commit() when committing intellisense","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-16T22:26:53Z","updated_at":"2015-12-17T00:54:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/7544","html_url":"https://github.com/dotnet/roslyn/pull/7544","diff_url":"https://github.com/dotnet/roslyn/pull/7544.diff","patch_url":"https://github.com/dotnet/roslyn/pull/7544.patch"},"body":"When committing completion, we dismiss the editor popup (if visible) and then make edits to the buffer. We don't call the Commit method on the editor popup, but it turns out that third party extensions listen for that event. To call it, we split up the actions of stopping our internal model computation and dismissing the editor session when we're done. This allows us to stop computing, make buffer edits, and then call the commit method when we're done.\r\n\r\nNB: The VS ShimCompletionController raises the commit event after the text edit; that behavior is preserved in this change.\r\n\r\nTagging @dotnet/roslyn-ide for review"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/165303589","html_url":"https://github.com/dotnet/roslyn/pull/7544#issuecomment-165303589","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/7544","id":165303589,"user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T00:54:53Z","updated_at":"2015-12-17T00:54:53Z","body":"@dotnet-bot retest prtest/mac/dbg/unit32 please\r\n// Previous failure: http://dotnet-ci.cloudapp.net/job/roslyn_prtest_mac_dbg_unit32/2070/\r\n// Retest reason: https://github.com/dotnet/roslyn/issues/7548"}}