{"action":"closed","number":84,"pull_request":{"url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84","id":27964634,"html_url":"https://github.com/jirikavi/AngularJS-Toaster/pull/84","diff_url":"https://github.com/jirikavi/AngularJS-Toaster/pull/84.diff","patch_url":"https://github.com/jirikavi/AngularJS-Toaster/pull/84.patch","issue_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/84","number":84,"state":"closed","locked":false,"title":"Fix to reset state when directive is destroyed","user":{"login":"bretongoers","id":2029683,"avatar_url":"https://avatars.githubusercontent.com/u/2029683?v=3","gravatar_id":"","url":"https://api.github.com/users/bretongoers","html_url":"https://github.com/bretongoers","followers_url":"https://api.github.com/users/bretongoers/followers","following_url":"https://api.github.com/users/bretongoers/following{/other_user}","gists_url":"https://api.github.com/users/bretongoers/gists{/gist_id}","starred_url":"https://api.github.com/users/bretongoers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretongoers/subscriptions","organizations_url":"https://api.github.com/users/bretongoers/orgs","repos_url":"https://api.github.com/users/bretongoers/repos","events_url":"https://api.github.com/users/bretongoers/events{/privacy}","received_events_url":"https://api.github.com/users/bretongoers/received_events","type":"User","site_admin":false},"body":"When (for example) the toaster directive is destroyed by switching out `ui-view`s using `ui-router`, the internal variables for the `toasterRegisterEvents` are not reset. The next time the directive is created (by coming back to the first view), the state of the factory object prevents watchers from being created. \r\n\r\nThis fixes that by resetting the state of the variables for the `toasterRegisterEvents` factory, which allows the link function to properly function and recreate state.","created_at":"2015-01-23T23:35:24Z","updated_at":"2015-01-24T11:34:11Z","closed_at":"2015-01-24T11:34:11Z","merged_at":"2015-01-24T11:34:11Z","merge_commit_sha":"de6c30a05c0cbb39345590a4bf254943ffcce4e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84/commits","review_comments_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84/comments","review_comment_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/84/comments","statuses_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/statuses/d7354e45102307edc34924db3fe05d99affcd83e","head":{"label":"bretongoers:master","ref":"master","sha":"d7354e45102307edc34924db3fe05d99affcd83e","user":{"login":"bretongoers","id":2029683,"avatar_url":"https://avatars.githubusercontent.com/u/2029683?v=3","gravatar_id":"","url":"https://api.github.com/users/bretongoers","html_url":"https://github.com/bretongoers","followers_url":"https://api.github.com/users/bretongoers/followers","following_url":"https://api.github.com/users/bretongoers/following{/other_user}","gists_url":"https://api.github.com/users/bretongoers/gists{/gist_id}","starred_url":"https://api.github.com/users/bretongoers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretongoers/subscriptions","organizations_url":"https://api.github.com/users/bretongoers/orgs","repos_url":"https://api.github.com/users/bretongoers/repos","events_url":"https://api.github.com/users/bretongoers/events{/privacy}","received_events_url":"https://api.github.com/users/bretongoers/received_events","type":"User","site_admin":false},"repo":{"id":29758042,"name":"AngularJS-Toaster","full_name":"bretongoers/AngularJS-Toaster","owner":{"login":"bretongoers","id":2029683,"avatar_url":"https://avatars.githubusercontent.com/u/2029683?v=3","gravatar_id":"","url":"https://api.github.com/users/bretongoers","html_url":"https://github.com/bretongoers","followers_url":"https://api.github.com/users/bretongoers/followers","following_url":"https://api.github.com/users/bretongoers/following{/other_user}","gists_url":"https://api.github.com/users/bretongoers/gists{/gist_id}","starred_url":"https://api.github.com/users/bretongoers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretongoers/subscriptions","organizations_url":"https://api.github.com/users/bretongoers/orgs","repos_url":"https://api.github.com/users/bretongoers/repos","events_url":"https://api.github.com/users/bretongoers/events{/privacy}","received_events_url":"https://api.github.com/users/bretongoers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bretongoers/AngularJS-Toaster","description":"AngularJS Toaster is a customized version of \"toastr\" non-blocking notification javascript library.","fork":true,"url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster","forks_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/forks","keys_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/teams","hooks_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/hooks","issue_events_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/issues/events{/number}","events_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/events","assignees_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/assignees{/user}","branches_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/branches{/branch}","tags_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/tags","blobs_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/statuses/{sha}","languages_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/languages","stargazers_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/stargazers","contributors_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/contributors","subscribers_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/subscribers","subscription_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/subscription","commits_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/issues/comments/{number}","contents_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/contents/{+path}","compare_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/merges","archive_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/downloads","issues_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/issues{/number}","pulls_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/pulls{/number}","milestones_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/milestones{/number}","notifications_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/labels{/name}","releases_url":"https://api.github.com/repos/bretongoers/AngularJS-Toaster/releases{/id}","created_at":"2015-01-23T23:22:10Z","updated_at":"2015-01-23T23:57:05Z","pushed_at":"2015-01-23T23:57:05Z","git_url":"git://github.com/bretongoers/AngularJS-Toaster.git","ssh_url":"git@github.com:bretongoers/AngularJS-Toaster.git","clone_url":"https://github.com/bretongoers/AngularJS-Toaster.git","svn_url":"https://github.com/bretongoers/AngularJS-Toaster","homepage":null,"size":698,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jirikavi:master","ref":"master","sha":"9deedc8d084d39fc1a77feafa42028989d064d7c","user":{"login":"jirikavi","id":5136908,"avatar_url":"https://avatars.githubusercontent.com/u/5136908?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikavi","html_url":"https://github.com/jirikavi","followers_url":"https://api.github.com/users/jirikavi/followers","following_url":"https://api.github.com/users/jirikavi/following{/other_user}","gists_url":"https://api.github.com/users/jirikavi/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikavi/subscriptions","organizations_url":"https://api.github.com/users/jirikavi/orgs","repos_url":"https://api.github.com/users/jirikavi/repos","events_url":"https://api.github.com/users/jirikavi/events{/privacy}","received_events_url":"https://api.github.com/users/jirikavi/received_events","type":"User","site_admin":false},"repo":{"id":12219348,"name":"AngularJS-Toaster","full_name":"jirikavi/AngularJS-Toaster","owner":{"login":"jirikavi","id":5136908,"avatar_url":"https://avatars.githubusercontent.com/u/5136908?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikavi","html_url":"https://github.com/jirikavi","followers_url":"https://api.github.com/users/jirikavi/followers","following_url":"https://api.github.com/users/jirikavi/following{/other_user}","gists_url":"https://api.github.com/users/jirikavi/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikavi/subscriptions","organizations_url":"https://api.github.com/users/jirikavi/orgs","repos_url":"https://api.github.com/users/jirikavi/repos","events_url":"https://api.github.com/users/jirikavi/events{/privacy}","received_events_url":"https://api.github.com/users/jirikavi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jirikavi/AngularJS-Toaster","description":"AngularJS Toaster is a customized version of \"toastr\" non-blocking notification javascript library.","fork":false,"url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster","forks_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/forks","keys_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/teams","hooks_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/hooks","issue_events_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/events{/number}","events_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/events","assignees_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/assignees{/user}","branches_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/branches{/branch}","tags_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/tags","blobs_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/statuses/{sha}","languages_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/languages","stargazers_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/stargazers","contributors_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/contributors","subscribers_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/subscribers","subscription_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/subscription","commits_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/comments/{number}","contents_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/contents/{+path}","compare_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/merges","archive_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/downloads","issues_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues{/number}","pulls_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls{/number}","milestones_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/milestones{/number}","notifications_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/labels{/name}","releases_url":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/releases{/id}","created_at":"2013-08-19T14:52:47Z","updated_at":"2015-01-23T01:57:27Z","pushed_at":"2015-01-24T11:34:11Z","git_url":"git://github.com/jirikavi/AngularJS-Toaster.git","ssh_url":"git@github.com:jirikavi/AngularJS-Toaster.git","clone_url":"https://github.com/jirikavi/AngularJS-Toaster.git","svn_url":"https://github.com/jirikavi/AngularJS-Toaster","homepage":null,"size":698,"stargazers_count":491,"watchers_count":491,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":11,"forks":119,"open_issues":11,"watchers":491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84"},"html":{"href":"https://github.com/jirikavi/AngularJS-Toaster/pull/84"},"issue":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/84"},"comments":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/jirikavi/AngularJS-Toaster/statuses/d7354e45102307edc34924db3fe05d99affcd83e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jirikavi","id":5136908,"avatar_url":"https://avatars.githubusercontent.com/u/5136908?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikavi","html_url":"https://github.com/jirikavi","followers_url":"https://api.github.com/users/jirikavi/followers","following_url":"https://api.github.com/users/jirikavi/following{/other_user}","gists_url":"https://api.github.com/users/jirikavi/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikavi/subscriptions","organizations_url":"https://api.github.com/users/jirikavi/orgs","repos_url":"https://api.github.com/users/jirikavi/repos","events_url":"https://api.github.com/users/jirikavi/events{/privacy}","received_events_url":"https://api.github.com/users/jirikavi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":11,"deletions":2,"changed_files":2}}