{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/1982","labels_url":"https://api.github.com/repos/request/request/issues/1982/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/1982/comments","events_url":"https://api.github.com/repos/request/request/issues/1982/events","html_url":"https://github.com/request/request/issues/1982","id":123858340,"number":1982,"title":"Request Next","user":{"login":"simov","id":1694112,"avatar_url":"https://avatars.githubusercontent.com/u/1694112?v=3","gravatar_id":"","url":"https://api.github.com/users/simov","html_url":"https://github.com/simov","followers_url":"https://api.github.com/users/simov/followers","following_url":"https://api.github.com/users/simov/following{/other_user}","gists_url":"https://api.github.com/users/simov/gists{/gist_id}","starred_url":"https://api.github.com/users/simov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simov/subscriptions","organizations_url":"https://api.github.com/users/simov/orgs","repos_url":"https://api.github.com/users/simov/repos","events_url":"https://api.github.com/users/simov/events{/privacy}","received_events_url":"https://api.github.com/users/simov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-25T06:43:37Z","updated_at":"2015-12-26T19:22:41Z","closed_at":null,"body":"![dayum](https://cloud.githubusercontent.com/assets/1694112/12000504/b1fb1c32-aae0-11e5-80fe-87dd05188fcc.gif)\r\n\r\n### :christmas_tree: :sparkles: [IT IS HAPPENING](https://gist.github.com/simov/552bee6ce6001205393e) :gift: :tada: \r\n"},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/167355546","html_url":"https://github.com/request/request/issues/1982#issuecomment-167355546","issue_url":"https://api.github.com/repos/request/request/issues/1982","id":167355546,"user":{"login":"simov","id":1694112,"avatar_url":"https://avatars.githubusercontent.com/u/1694112?v=3","gravatar_id":"","url":"https://api.github.com/users/simov","html_url":"https://github.com/simov","followers_url":"https://api.github.com/users/simov/followers","following_url":"https://api.github.com/users/simov/following{/other_user}","gists_url":"https://api.github.com/users/simov/gists{/gist_id}","starred_url":"https://api.github.com/users/simov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simov/subscriptions","organizations_url":"https://api.github.com/users/simov/orgs","repos_url":"https://api.github.com/users/simov/repos","events_url":"https://api.github.com/users/simov/events{/privacy}","received_events_url":"https://api.github.com/users/simov/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T19:22:41Z","updated_at":"2015-12-26T19:22:41Z","body":"@froatsnook @noway421 I share your excitement!\r\n\r\n@ahmadnassri probably the Har implementation should be moved out of @request/legacy because someone may want to create its own HTTP client based on core, that have a Har support, minus all of the bloat in @request/legacy. In that case I should create a new repo, let me know what do you think.\r\n\r\nre testing: Mocha+Should is just a tool, and a good one IMO. I knew that there is a reason behind choosing tape, but over the time using both of them I couldn't figure out why tape is considered better that mocha/should.\r\n\r\nAs for actually refactoring the entire test suite, that would require moving all of the relevant tests to @request/core. Things to avoid are: huge test servers, creating test cases in a loop, dependence between separate unit tests, and generally things that are hard to debug, maintain, and reason about after their initial implementation.\r\n\r\nAfter that when a change is made in this module's tests, that change should be synced (implemented) in core as well."}}