{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6996","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6996/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6996/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6996/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6996","id":69197928,"number":6996,"title":"Add cleanup policy to RollingUpdater","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20no","name":"cla: no","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-04-17T19:04:22Z","updated_at":"2015-04-17T20:04:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6996","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6996","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6996.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6996.patch"},"body":"* Support configurable cleanup policies in RollingUpdater. Downstream\r\nlibrary consumers don't necessarily have the same rules for post\r\ndeployment cleanup; making the behavior policy driven is more flexible.\r\n\r\n* Refactor RollingUpdater to accept a config object during Update instead\r\nof a long argument list.\r\n\r\n* Add test coverage for cleanup policy."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/94063798","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6996#issuecomment-94063798","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6996","id":94063798,"user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T20:04:38Z","updated_at":"2015-04-17T20:04:38Z","body":"@bgrant0607 \r\n>I'll definitely take a look. I totally agree the parameters shouldn't come directly from flags. Ideally, I'd like the parameter block be suitable for inclusion in an API object (Deployment).\r\n\r\nThere will inevitably be such an API in OpenShift to represent many of the fields on the `RollingUpdaterConfig` described in this PR. It would definitely make sense to keep that as close to a proposed future upstream API as possible."}}