{"action":"created","issue":{"url":"https://api.github.com/repos/thephpleague/flysystem/issues/306","labels_url":"https://api.github.com/repos/thephpleague/flysystem/issues/306/labels{/name}","comments_url":"https://api.github.com/repos/thephpleague/flysystem/issues/306/comments","events_url":"https://api.github.com/repos/thephpleague/flysystem/issues/306/events","html_url":"https://github.com/thephpleague/flysystem/pull/306","id":47551022,"number":306,"title":"Updates to the FTP deleteDir function","user":{"login":"kristianedlund","id":1947488,"avatar_url":"https://avatars.githubusercontent.com/u/1947488?v=3","gravatar_id":"","url":"https://api.github.com/users/kristianedlund","html_url":"https://github.com/kristianedlund","followers_url":"https://api.github.com/users/kristianedlund/followers","following_url":"https://api.github.com/users/kristianedlund/following{/other_user}","gists_url":"https://api.github.com/users/kristianedlund/gists{/gist_id}","starred_url":"https://api.github.com/users/kristianedlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristianedlund/subscriptions","organizations_url":"https://api.github.com/users/kristianedlund/orgs","repos_url":"https://api.github.com/users/kristianedlund/repos","events_url":"https://api.github.com/users/kristianedlund/events{/privacy}","received_events_url":"https://api.github.com/users/kristianedlund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-11-02T22:18:15Z","updated_at":"2015-02-05T07:00:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thephpleague/flysystem/pulls/306","html_url":"https://github.com/thephpleague/flysystem/pull/306","diff_url":"https://github.com/thephpleague/flysystem/pull/306.diff","patch_url":"https://github.com/thephpleague/flysystem/pull/306.patch"},"body":"Hi\r\n\r\nCurrently the implementation of deleteDir assumes that the ftp_rawlist returns with an array with all files at the end. However, that seems not to be the case for all FTP servers. I have tested both on a synology FTP and pureftp server. \r\n\r\nI have changed the function to be recursive instead of relaying on the server to return the array correctly. \r\n\r\nAlso the ftp_rmdir throws an exception when the file it tries to delete does not exist. I have changed the code to return false instead, to be aligned with the other specification.\r\n\r\nPS: I am sorry if I mess something up, this is my very first pull request. "},"comment":{"url":"https://api.github.com/repos/thephpleague/flysystem/issues/comments/73003035","html_url":"https://github.com/thephpleague/flysystem/pull/306#issuecomment-73003035","issue_url":"https://api.github.com/repos/thephpleague/flysystem/issues/306","id":73003035,"user":{"login":"kristianedlund","id":1947488,"avatar_url":"https://avatars.githubusercontent.com/u/1947488?v=3","gravatar_id":"","url":"https://api.github.com/users/kristianedlund","html_url":"https://github.com/kristianedlund","followers_url":"https://api.github.com/users/kristianedlund/followers","following_url":"https://api.github.com/users/kristianedlund/following{/other_user}","gists_url":"https://api.github.com/users/kristianedlund/gists{/gist_id}","starred_url":"https://api.github.com/users/kristianedlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristianedlund/subscriptions","organizations_url":"https://api.github.com/users/kristianedlund/orgs","repos_url":"https://api.github.com/users/kristianedlund/repos","events_url":"https://api.github.com/users/kristianedlund/events{/privacy}","received_events_url":"https://api.github.com/users/kristianedlund/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T07:00:16Z","updated_at":"2015-02-05T07:00:16Z","body":"Updated the PR to be mergable with the current master"}}