{"action":"created","issue":{"url":"https://api.github.com/repos/kanaka/noVNC/issues/473","labels_url":"https://api.github.com/repos/kanaka/noVNC/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/kanaka/noVNC/issues/473/comments","events_url":"https://api.github.com/repos/kanaka/noVNC/issues/473/events","html_url":"https://github.com/kanaka/noVNC/pull/473","id":64075962,"number":473,"title":"Create RFB object on connect","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-24T19:10:08Z","updated_at":"2015-03-25T21:13:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kanaka/noVNC/pulls/473","html_url":"https://github.com/kanaka/noVNC/pull/473","diff_url":"https://github.com/kanaka/noVNC/pull/473.diff","patch_url":"https://github.com/kanaka/noVNC/pull/473.patch"},"body":"In e543525faa9cf0d683f41e183e89cd909f3dd229, we switched to creating\r\na new RFB object on disconnect.  This caused issues, however, since\r\nany errors were only displayed briefly before the new \"loaded\" text\r\nwas displayed instead.\r\n\r\nNow, we create the RFB object on connect.  This essentially removes\r\nthe usefulness of the \"loaded\" state, but prevents the aforementioned\r\nproblem.\r\n\r\nTo facilitate this, the code which does detection of cursor URI support\r\nwas moved from this Display constructor (which now calls the new\r\nfunction) into its own function, `Util.browserSupportsCursorURIs()`.\r\n\r\nFixes #467"},"comment":{"url":"https://api.github.com/repos/kanaka/noVNC/issues/comments/86220180","html_url":"https://github.com/kanaka/noVNC/pull/473#issuecomment-86220180","issue_url":"https://api.github.com/repos/kanaka/noVNC/issues/473","id":86220180,"user":{"login":"samhed","id":4117162,"avatar_url":"https://avatars.githubusercontent.com/u/4117162?v=3","gravatar_id":"","url":"https://api.github.com/users/samhed","html_url":"https://github.com/samhed","followers_url":"https://api.github.com/users/samhed/followers","following_url":"https://api.github.com/users/samhed/following{/other_user}","gists_url":"https://api.github.com/users/samhed/gists{/gist_id}","starred_url":"https://api.github.com/users/samhed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhed/subscriptions","organizations_url":"https://api.github.com/users/samhed/orgs","repos_url":"https://api.github.com/users/samhed/repos","events_url":"https://api.github.com/users/samhed/events{/privacy}","received_events_url":"https://api.github.com/users/samhed/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T21:13:35Z","updated_at":"2015-03-25T21:13:35Z","body":"> so I left it empty ;-)\r\n\r\nI think it looks good like that!\r\n\r\nHowever, explicitly specifying the class of the control bar in the HTML conflict with the way we set the style in updateState in ui.js. With this patch the class is never changed, i.e we don't get the warning/error gradient colors."}}