{"action":"closed","number":9376,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9376","id":38251791,"html_url":"https://github.com/laravel/framework/pull/9376","diff_url":"https://github.com/laravel/framework/pull/9376.diff","patch_url":"https://github.com/laravel/framework/pull/9376.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9376","number":9376,"state":"closed","locked":false,"title":"[5.1] Fix sending headers in test HTTP calls","user":{"login":"max-me","id":467159,"avatar_url":"https://avatars.githubusercontent.com/u/467159?v=3","gravatar_id":"","url":"https://api.github.com/users/max-me","html_url":"https://github.com/max-me","followers_url":"https://api.github.com/users/max-me/followers","following_url":"https://api.github.com/users/max-me/following{/other_user}","gists_url":"https://api.github.com/users/max-me/gists{/gist_id}","starred_url":"https://api.github.com/users/max-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-me/subscriptions","organizations_url":"https://api.github.com/users/max-me/orgs","repos_url":"https://api.github.com/users/max-me/repos","events_url":"https://api.github.com/users/max-me/events{/privacy}","received_events_url":"https://api.github.com/users/max-me/received_events","type":"User","site_admin":false},"body":"Fixing https://github.com/laravel/framework/issues/9368\r\n\r\nProblem is that Symphony `Request::create` method expects sixth parameter as a prepared `$_SERVER` array, but we are sending there an array of headers. That's why if you are trying to test http call with headers they won't come.\r\n\r\nAlso I renamed all params from `$server` to `$headers` as it is more readable, because we are not sending `$_SERVER` variables, we are sending headers.","created_at":"2015-06-22T16:46:09Z","updated_at":"2015-06-22T16:50:43Z","closed_at":"2015-06-22T16:50:43Z","merged_at":null,"merge_commit_sha":"3bd407eee3eb55042f77de77aa9e6096da9280ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9376/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9376/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9376/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/423dd6f3b817b44fa9c96a1eb030155ce36c9dbe","head":{"label":"max-me:bugfix/headers-in-tests","ref":"bugfix/headers-in-tests","sha":"423dd6f3b817b44fa9c96a1eb030155ce36c9dbe","user":{"login":"max-me","id":467159,"avatar_url":"https://avatars.githubusercontent.com/u/467159?v=3","gravatar_id":"","url":"https://api.github.com/users/max-me","html_url":"https://github.com/max-me","followers_url":"https://api.github.com/users/max-me/followers","following_url":"https://api.github.com/users/max-me/following{/other_user}","gists_url":"https://api.github.com/users/max-me/gists{/gist_id}","starred_url":"https://api.github.com/users/max-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-me/subscriptions","organizations_url":"https://api.github.com/users/max-me/orgs","repos_url":"https://api.github.com/users/max-me/repos","events_url":"https://api.github.com/users/max-me/events{/privacy}","received_events_url":"https://api.github.com/users/max-me/received_events","type":"User","site_admin":false},"repo":{"id":37865252,"name":"framework","full_name":"max-me/framework","owner":{"login":"max-me","id":467159,"avatar_url":"https://avatars.githubusercontent.com/u/467159?v=3","gravatar_id":"","url":"https://api.github.com/users/max-me","html_url":"https://github.com/max-me","followers_url":"https://api.github.com/users/max-me/followers","following_url":"https://api.github.com/users/max-me/following{/other_user}","gists_url":"https://api.github.com/users/max-me/gists{/gist_id}","starred_url":"https://api.github.com/users/max-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-me/subscriptions","organizations_url":"https://api.github.com/users/max-me/orgs","repos_url":"https://api.github.com/users/max-me/repos","events_url":"https://api.github.com/users/max-me/events{/privacy}","received_events_url":"https://api.github.com/users/max-me/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/max-me/framework","description":"","fork":true,"url":"https://api.github.com/repos/max-me/framework","forks_url":"https://api.github.com/repos/max-me/framework/forks","keys_url":"https://api.github.com/repos/max-me/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/max-me/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/max-me/framework/teams","hooks_url":"https://api.github.com/repos/max-me/framework/hooks","issue_events_url":"https://api.github.com/repos/max-me/framework/issues/events{/number}","events_url":"https://api.github.com/repos/max-me/framework/events","assignees_url":"https://api.github.com/repos/max-me/framework/assignees{/user}","branches_url":"https://api.github.com/repos/max-me/framework/branches{/branch}","tags_url":"https://api.github.com/repos/max-me/framework/tags","blobs_url":"https://api.github.com/repos/max-me/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/max-me/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/max-me/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/max-me/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/max-me/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/max-me/framework/languages","stargazers_url":"https://api.github.com/repos/max-me/framework/stargazers","contributors_url":"https://api.github.com/repos/max-me/framework/contributors","subscribers_url":"https://api.github.com/repos/max-me/framework/subscribers","subscription_url":"https://api.github.com/repos/max-me/framework/subscription","commits_url":"https://api.github.com/repos/max-me/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/max-me/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/max-me/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/max-me/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/max-me/framework/contents/{+path}","compare_url":"https://api.github.com/repos/max-me/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/max-me/framework/merges","archive_url":"https://api.github.com/repos/max-me/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/max-me/framework/downloads","issues_url":"https://api.github.com/repos/max-me/framework/issues{/number}","pulls_url":"https://api.github.com/repos/max-me/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/max-me/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/max-me/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/max-me/framework/labels{/name}","releases_url":"https://api.github.com/repos/max-me/framework/releases{/id}","created_at":"2015-06-22T16:00:26Z","updated_at":"2015-06-22T16:00:29Z","pushed_at":"2015-06-22T16:37:39Z","git_url":"git://github.com/max-me/framework.git","ssh_url":"git@github.com:max-me/framework.git","clone_url":"https://github.com/max-me/framework.git","svn_url":"https://github.com/max-me/framework","homepage":"http://laravel.com","size":63821,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"aa811a1bd80f75e03cca3c470674f66617358ed4","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-21T21:12:25Z","pushed_at":"2015-06-22T16:46:09Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":63821,"stargazers_count":3751,"watchers_count":3751,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2091,"mirror_url":null,"open_issues_count":90,"forks":2091,"open_issues":90,"watchers":3751,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9376"},"html":{"href":"https://github.com/laravel/framework/pull/9376"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9376"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9376/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9376/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9376/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/423dd6f3b817b44fa9c96a1eb030155ce36c9dbe"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":12,"changed_files":1}}