{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/37428343","id":37428343,"diff_hunk":"@@ -294,6 +298,16 @@ if __name__ == '__main__':\n     update_parser = action_parser.add_parser('update',\n                                              help='Update OpenShift across cluster',\n                                              parents=[meta_parser])\n+    update_parser.add_argument('-m', '--masters', default=1, type=int,\n+                               help='number of masters to create in cluster')\n+    update_parser.add_argument('-n', '--nodes', default=2, type=int,\n+                               help='number of nodes to create in cluster')","path":"bin/cluster","position":18,"original_position":18,"commit_id":"24ea3b99dd1ac82426e6ef9906982790870861b6","original_commit_id":"24ea3b99dd1ac82426e6ef9906982790870861b6","user":{"login":"twiest","id":732867,"avatar_url":"https://avatars.githubusercontent.com/u/732867?v=3","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"body":"Update shouldn't be \"creating\" instances.","created_at":"2015-08-19T15:28:47Z","updated_at":"2015-08-19T15:28:47Z","html_url":"https://github.com/openshift/openshift-ansible/pull/453#discussion_r37428343","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/37428343"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/453#discussion_r37428343"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453","id":42260070,"html_url":"https://github.com/openshift/openshift-ansible/pull/453","diff_url":"https://github.com/openshift/openshift-ansible/pull/453.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/453.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/453","number":453,"state":"open","locked":false,"title":"Manages cluster update on OpenStack","user":{"login":"akram","id":654449,"avatar_url":"https://avatars.githubusercontent.com/u/654449?v=3","gravatar_id":"","url":"https://api.github.com/users/akram","html_url":"https://github.com/akram","followers_url":"https://api.github.com/users/akram/followers","following_url":"https://api.github.com/users/akram/following{/other_user}","gists_url":"https://api.github.com/users/akram/gists{/gist_id}","starred_url":"https://api.github.com/users/akram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akram/subscriptions","organizations_url":"https://api.github.com/users/akram/orgs","repos_url":"https://api.github.com/users/akram/repos","events_url":"https://api.github.com/users/akram/events{/privacy}","received_events_url":"https://api.github.com/users/akram/received_events","type":"User","site_admin":false},"body":"Adds the support of the update command on OpenStack clusters:\r\n- allow adding or removal of nodes and masters\r\n- Adds a change in the heat template to support update of network configuration and floating IP\r\n","created_at":"2015-08-12T16:31:05Z","updated_at":"2015-08-19T15:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f61822476f296385eb5029732d698a47d7c4982","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/453/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/24ea3b99dd1ac82426e6ef9906982790870861b6","head":{"label":"akram:openstack_update","ref":"openstack_update","sha":"24ea3b99dd1ac82426e6ef9906982790870861b6","user":{"login":"akram","id":654449,"avatar_url":"https://avatars.githubusercontent.com/u/654449?v=3","gravatar_id":"","url":"https://api.github.com/users/akram","html_url":"https://github.com/akram","followers_url":"https://api.github.com/users/akram/followers","following_url":"https://api.github.com/users/akram/following{/other_user}","gists_url":"https://api.github.com/users/akram/gists{/gist_id}","starred_url":"https://api.github.com/users/akram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akram/subscriptions","organizations_url":"https://api.github.com/users/akram/orgs","repos_url":"https://api.github.com/users/akram/repos","events_url":"https://api.github.com/users/akram/events{/privacy}","received_events_url":"https://api.github.com/users/akram/received_events","type":"User","site_admin":false},"repo":{"id":29018054,"name":"openshift-ansible","full_name":"akram/openshift-ansible","owner":{"login":"akram","id":654449,"avatar_url":"https://avatars.githubusercontent.com/u/654449?v=3","gravatar_id":"","url":"https://api.github.com/users/akram","html_url":"https://github.com/akram","followers_url":"https://api.github.com/users/akram/followers","following_url":"https://api.github.com/users/akram/following{/other_user}","gists_url":"https://api.github.com/users/akram/gists{/gist_id}","starred_url":"https://api.github.com/users/akram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akram/subscriptions","organizations_url":"https://api.github.com/users/akram/orgs","repos_url":"https://api.github.com/users/akram/repos","events_url":"https://api.github.com/users/akram/events{/privacy}","received_events_url":"https://api.github.com/users/akram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akram/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/akram/openshift-ansible","forks_url":"https://api.github.com/repos/akram/openshift-ansible/forks","keys_url":"https://api.github.com/repos/akram/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akram/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akram/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/akram/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/akram/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/akram/openshift-ansible/events","assignees_url":"https://api.github.com/repos/akram/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/akram/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/akram/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/akram/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akram/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akram/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/akram/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akram/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/akram/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/akram/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/akram/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/akram/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/akram/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/akram/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/akram/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/akram/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/akram/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/akram/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/akram/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akram/openshift-ansible/merges","archive_url":"https://api.github.com/repos/akram/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akram/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/akram/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/akram/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/akram/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/akram/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akram/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/akram/openshift-ansible/releases{/id}","created_at":"2015-01-09T13:44:51Z","updated_at":"2015-03-12T18:07:47Z","pushed_at":"2015-08-19T13:11:47Z","git_url":"git://github.com/akram/openshift-ansible.git","ssh_url":"git@github.com:akram/openshift-ansible.git","clone_url":"https://github.com/akram/openshift-ansible.git","svn_url":"https://github.com/akram/openshift-ansible","homepage":"","size":2588,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3efe322c2621e1ba19a5bfc1e7b13bb8bd1177ef","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-08-18T20:12:09Z","pushed_at":"2015-08-19T14:23:26Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"","size":4341,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":75,"forks":99,"open_issues":75,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/453"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/453"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/24ea3b99dd1ac82426e6ef9906982790870861b6"}}}}