{"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/comments/13640412","html_url":"https://github.com/magnumripper/JohnTheRipper/commit/e5ee13e6633725a56fbb45ccc8bc959de3319d46#commitcomment-13640412","id":13640412,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"e5ee13e6633725a56fbb45ccc8bc959de3319d46","created_at":"2015-10-07T14:45:31Z","updated_at":"2015-10-07T14:45:31Z","body":"This should be it.  test type 4 is 'generic'. It simply looks for hex strings in the input hash that are 'known' sizes. So if there is a 24 byte (or 32, 48, 64, etc), that is pure hex, and ALL of a single case and not pure digits, then that buffer is case mangled, and the bug is searched for.  So ALL formats should now work.\r\n\r\nThere are a couple of white lists currently. The bcrypt has some hashes with the salts 'looking' like hex, such as CCCCCCCCCCCCCCC (etc).  But the format does not have the bug, it is just a FP that needs a white list.   I also have ```@dynmaic=``` hash white listed now. It does have the bug, but it will NOT be trivial to get it 100% correct, so I have just postponed it."}}