{"action":"created","comment":{"url":"https://api.github.com/repos/praekelt/vumi/pulls/comments/38898607","id":38898607,"diff_hunk":"@@ -37,6 +37,11 @@ class SmppTransportConfig(Transport.CONFIG_CLASS):\n         'for matching submit_sm_resp and delivery report messages. Defaults '\n         'to 1 week.',\n         default=(60 * 60 * 24 * 7), static=True)\n+    completed_multipart_info_expiry = ConfigInt(\n+        'How long (in seconds) to keep multipart message info for completed '\n+        'multipart messages around to avoid pending operations accidentally '\n+        'recreating them without an expiry time. Defaults to 1 hour.',","path":"vumi/transports/smpp/config.py","position":7,"original_position":7,"commit_id":"aea4d08b61298011d72e6e3d3de6e2d144e854ef","original_commit_id":"aea4d08b61298011d72e6e3d3de6e2d144e854ef","user":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?v=3","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":"Those are operations like \"update this key in the hash\", which we can't add expiration to in a single operation. We aren't expecting any of those after the message processing completes, but we can't guarantee that we won't get any. In the common case, adding an extra Redis call to every multipart `submit_sm_resp` we process doesn't seem worth it.","created_at":"2015-09-08T07:59:12Z","updated_at":"2015-09-08T07:59:12Z","html_url":"https://github.com/praekelt/vumi/pull/968#discussion_r38898607","pull_request_url":"https://api.github.com/repos/praekelt/vumi/pulls/968","_links":{"self":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/comments/38898607"},"html":{"href":"https://github.com/praekelt/vumi/pull/968#discussion_r38898607"},"pull_request":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/968"}}},"pull_request":{"url":"https://api.github.com/repos/praekelt/vumi/pulls/968","id":44376283,"html_url":"https://github.com/praekelt/vumi/pull/968","diff_url":"https://github.com/praekelt/vumi/pull/968.diff","patch_url":"https://github.com/praekelt/vumi/pull/968.patch","issue_url":"https://api.github.com/repos/praekelt/vumi/issues/968","number":968,"state":"open","locked":false,"title":"Better SMPP multipart_info handling","user":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?v=3","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":"At the moment, this uses the week-long `third_party_id_expiry` and is never cleared. Instead it should use the day-log `submit_sm_expiry` and be cleared after all parts of a message have been acknowledged.\r\n\r\n(There may be some overlap with #965, but running out of memory in Redis is a worse problem than potential extra acks.)","created_at":"2015-09-07T19:28:12Z","updated_at":"2015-09-08T07:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"400741f575c15699e47b896c4eead38e6b5de42e","assignee":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?v=3","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/praekelt/vumi/pulls/968/commits","review_comments_url":"https://api.github.com/repos/praekelt/vumi/pulls/968/comments","review_comment_url":"https://api.github.com/repos/praekelt/vumi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekelt/vumi/issues/968/comments","statuses_url":"https://api.github.com/repos/praekelt/vumi/statuses/aea4d08b61298011d72e6e3d3de6e2d144e854ef","head":{"label":"praekelt:feature/issue-968-fix-multipart-info-handling","ref":"feature/issue-968-fix-multipart-info-handling","sha":"aea4d08b61298011d72e6e3d3de6e2d144e854ef","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":1081665,"name":"vumi","full_name":"praekelt/vumi","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/vumi","description":"Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.","fork":false,"url":"https://api.github.com/repos/praekelt/vumi","forks_url":"https://api.github.com/repos/praekelt/vumi/forks","keys_url":"https://api.github.com/repos/praekelt/vumi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/vumi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/vumi/teams","hooks_url":"https://api.github.com/repos/praekelt/vumi/hooks","issue_events_url":"https://api.github.com/repos/praekelt/vumi/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/vumi/events","assignees_url":"https://api.github.com/repos/praekelt/vumi/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/vumi/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/vumi/tags","blobs_url":"https://api.github.com/repos/praekelt/vumi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/vumi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/vumi/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/vumi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/vumi/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/vumi/languages","stargazers_url":"https://api.github.com/repos/praekelt/vumi/stargazers","contributors_url":"https://api.github.com/repos/praekelt/vumi/contributors","subscribers_url":"https://api.github.com/repos/praekelt/vumi/subscribers","subscription_url":"https://api.github.com/repos/praekelt/vumi/subscription","commits_url":"https://api.github.com/repos/praekelt/vumi/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/vumi/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/vumi/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/vumi/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/vumi/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/vumi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/vumi/merges","archive_url":"https://api.github.com/repos/praekelt/vumi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/vumi/downloads","issues_url":"https://api.github.com/repos/praekelt/vumi/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/vumi/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/vumi/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/vumi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/vumi/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/vumi/releases{/id}","created_at":"2010-11-15T11:34:03Z","updated_at":"2015-09-07T09:41:49Z","pushed_at":"2015-09-07T20:46:49Z","git_url":"git://github.com/praekelt/vumi.git","ssh_url":"git@github.com:praekelt/vumi.git","clone_url":"https://github.com/praekelt/vumi.git","svn_url":"https://github.com/praekelt/vumi","homepage":"","size":21936,"stargazers_count":228,"watchers_count":228,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":93,"forks":84,"open_issues":93,"watchers":228,"default_branch":"develop"}},"base":{"label":"praekelt:develop","ref":"develop","sha":"a931623b022efe714792a627c8a43bfe3815b473","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":1081665,"name":"vumi","full_name":"praekelt/vumi","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/vumi","description":"Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.","fork":false,"url":"https://api.github.com/repos/praekelt/vumi","forks_url":"https://api.github.com/repos/praekelt/vumi/forks","keys_url":"https://api.github.com/repos/praekelt/vumi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/vumi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/vumi/teams","hooks_url":"https://api.github.com/repos/praekelt/vumi/hooks","issue_events_url":"https://api.github.com/repos/praekelt/vumi/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/vumi/events","assignees_url":"https://api.github.com/repos/praekelt/vumi/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/vumi/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/vumi/tags","blobs_url":"https://api.github.com/repos/praekelt/vumi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/vumi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/vumi/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/vumi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/vumi/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/vumi/languages","stargazers_url":"https://api.github.com/repos/praekelt/vumi/stargazers","contributors_url":"https://api.github.com/repos/praekelt/vumi/contributors","subscribers_url":"https://api.github.com/repos/praekelt/vumi/subscribers","subscription_url":"https://api.github.com/repos/praekelt/vumi/subscription","commits_url":"https://api.github.com/repos/praekelt/vumi/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/vumi/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/vumi/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/vumi/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/vumi/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/vumi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/vumi/merges","archive_url":"https://api.github.com/repos/praekelt/vumi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/vumi/downloads","issues_url":"https://api.github.com/repos/praekelt/vumi/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/vumi/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/vumi/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/vumi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/vumi/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/vumi/releases{/id}","created_at":"2010-11-15T11:34:03Z","updated_at":"2015-09-07T09:41:49Z","pushed_at":"2015-09-07T20:46:49Z","git_url":"git://github.com/praekelt/vumi.git","ssh_url":"git@github.com:praekelt/vumi.git","clone_url":"https://github.com/praekelt/vumi.git","svn_url":"https://github.com/praekelt/vumi","homepage":"","size":21936,"stargazers_count":228,"watchers_count":228,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":93,"forks":84,"open_issues":93,"watchers":228,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/968"},"html":{"href":"https://github.com/praekelt/vumi/pull/968"},"issue":{"href":"https://api.github.com/repos/praekelt/vumi/issues/968"},"comments":{"href":"https://api.github.com/repos/praekelt/vumi/issues/968/comments"},"review_comments":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/968/comments"},"review_comment":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekelt/vumi/pulls/968/commits"},"statuses":{"href":"https://api.github.com/repos/praekelt/vumi/statuses/aea4d08b61298011d72e6e3d3de6e2d144e854ef"}}}}