{"action":"created","issue":{"url":"https://api.github.com/repos/senchalabs/jsduck/issues/616","labels_url":"https://api.github.com/repos/senchalabs/jsduck/issues/616/labels{/name}","comments_url":"https://api.github.com/repos/senchalabs/jsduck/issues/616/comments","events_url":"https://api.github.com/repos/senchalabs/jsduck/issues/616/events","html_url":"https://github.com/senchalabs/jsduck/pull/616","id":89463139,"number":616,"title":"Fix for, Parsing *.jsx files #592","user":{"login":"mrfr0g","id":177652,"avatar_url":"https://avatars.githubusercontent.com/u/177652?v=3","gravatar_id":"","url":"https://api.github.com/users/mrfr0g","html_url":"https://github.com/mrfr0g","followers_url":"https://api.github.com/users/mrfr0g/followers","following_url":"https://api.github.com/users/mrfr0g/following{/other_user}","gists_url":"https://api.github.com/users/mrfr0g/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfr0g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfr0g/subscriptions","organizations_url":"https://api.github.com/users/mrfr0g/orgs","repos_url":"https://api.github.com/users/mrfr0g/repos","events_url":"https://api.github.com/users/mrfr0g/events{/privacy}","received_events_url":"https://api.github.com/users/mrfr0g/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-19T04:29:50Z","updated_at":"2015-06-21T17:12:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/senchalabs/jsduck/pulls/616","html_url":"https://github.com/senchalabs/jsduck/pull/616","diff_url":"https://github.com/senchalabs/jsduck/pull/616.diff","patch_url":"https://github.com/senchalabs/jsduck/pull/616.patch"},"body":"Utilizes https://github.com/rmosolgo/jsx-ruby for transform, added a simple test for jsx files, transform and parse as normal"},"comment":{"url":"https://api.github.com/repos/senchalabs/jsduck/issues/comments/113932281","html_url":"https://github.com/senchalabs/jsduck/pull/616#issuecomment-113932281","issue_url":"https://api.github.com/repos/senchalabs/jsduck/issues/616","id":113932281,"user":{"login":"nene","id":118201,"avatar_url":"https://avatars.githubusercontent.com/u/118201?v=3","gravatar_id":"","url":"https://api.github.com/users/nene","html_url":"https://github.com/nene","followers_url":"https://api.github.com/users/nene/followers","following_url":"https://api.github.com/users/nene/following{/other_user}","gists_url":"https://api.github.com/users/nene/gists{/gist_id}","starred_url":"https://api.github.com/users/nene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nene/subscriptions","organizations_url":"https://api.github.com/users/nene/orgs","repos_url":"https://api.github.com/users/nene/repos","events_url":"https://api.github.com/users/nene/events{/privacy}","received_events_url":"https://api.github.com/users/nene/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T17:12:16Z","updated_at":"2015-06-21T17:12:16Z","body":"Hi, thanks for the implementation.\r\n\r\nNot really suitable in its current form though. First off `jsduck.gemspec` should list the new dependency. We could though treat it as an optional dependency though - it's a sizable chunk as a dependency which most people won't be needing.\r\n\r\nAnother problem is relates to `.jsx` and `.rjsx` extensions. When passing input files as a directory, JSDuck will scan it only for `.js` and `.scss` files (see `options/input_files.rb`). Besides this, some people will place JSX code directly in `.js` files. So I think it's better handled with a switch like `--jsx` (which could optionally take arguments to specify the file extensions `--jsx=js,jsx,rjsx`). I'm not entirely sure about the default behaviour, a few variants come to mind:\r\n\r\n- Transforms all `.js` files with JSX.\r\n- Transforms all `.jsx` files with JSX (this seems the best pick for me).\r\n- Transforms all `.jsx` and `.js` files with JSX.\r\n\r\nI haven't personally seen the `.rjsx` extension used before. I suppose it stands for \"React JSX\"."}}