{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/express-react-views/pulls/comments/22635240","id":22635240,"diff_hunk":"@@ -0,0 +1,5 @@\n+\n+public/main.js: views/*\n+\tmkdir -p tmp\n+\t./node_modules/.bin/jsx -x jsx views tmp\n+\t./node_modules/.bin/browserify tmp/main.js -o public/main.js","path":"examples/dynamic/Makefile","position":null,"original_position":5,"commit_id":"a8780d623add18839076b3e19540862cb33d37aa","original_commit_id":"93cb833c43e3500ab3247585f597a5dbe22ad78d","user":{"login":"tenorviol","id":157127,"avatar_url":"https://avatars.githubusercontent.com/u/157127?v=3","gravatar_id":"","url":"https://api.github.com/users/tenorviol","html_url":"https://github.com/tenorviol","followers_url":"https://api.github.com/users/tenorviol/followers","following_url":"https://api.github.com/users/tenorviol/following{/other_user}","gists_url":"https://api.github.com/users/tenorviol/gists{/gist_id}","starred_url":"https://api.github.com/users/tenorviol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenorviol/subscriptions","organizations_url":"https://api.github.com/users/tenorviol/orgs","repos_url":"https://api.github.com/users/tenorviol/repos","events_url":"https://api.github.com/users/tenorviol/events{/privacy}","received_events_url":"https://api.github.com/users/tenorviol/received_events","type":"User","site_admin":false},"body":"Good call on the `reactify` transform for Windows support. It has some strange properties, mainly that I either had to change all the template requires to include the extension, e.g. `require('./SomeTemplate.jsx')`; or I could change all extensions to `.js`. Going with the latter.\r\n\r\nThe browserify `--standalone` option was something I'd been missing. Thanks for pointing it out.\r\n\r\nAs for browserify-middleware, it looks really cool. Unfortunately, I couldn't get it to work due to some cryptic error about stream encoding. I have little patience to debug this right now.","created_at":"2015-01-08T04:33:49Z","updated_at":"2015-01-08T04:33:49Z","html_url":"https://github.com/reactjs/express-react-views/pull/17#discussion_r22635240","pull_request_url":"https://api.github.com/repos/reactjs/express-react-views/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/comments/22635240"},"html":{"href":"https://github.com/reactjs/express-react-views/pull/17#discussion_r22635240"},"pull_request":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/express-react-views/pulls/17","id":26776074,"html_url":"https://github.com/reactjs/express-react-views/pull/17","diff_url":"https://github.com/reactjs/express-react-views/pull/17.diff","patch_url":"https://github.com/reactjs/express-react-views/pull/17.patch","issue_url":"https://api.github.com/repos/reactjs/express-react-views/issues/17","number":17,"state":"open","locked":false,"title":"Sample application: dynamic client-side app using express-react-views","user":{"login":"tenorviol","id":157127,"avatar_url":"https://avatars.githubusercontent.com/u/157127?v=3","gravatar_id":"","url":"https://api.github.com/users/tenorviol","html_url":"https://github.com/tenorviol","followers_url":"https://api.github.com/users/tenorviol/followers","following_url":"https://api.github.com/users/tenorviol/following{/other_user}","gists_url":"https://api.github.com/users/tenorviol/gists{/gist_id}","starred_url":"https://api.github.com/users/tenorviol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenorviol/subscriptions","organizations_url":"https://api.github.com/users/tenorviol/orgs","repos_url":"https://api.github.com/users/tenorviol/repos","events_url":"https://api.github.com/users/tenorviol/events{/privacy}","received_events_url":"https://api.github.com/users/tenorviol/received_events","type":"User","site_admin":false},"body":"Here is a 2nd sample application illustrating how to create a dynamic client-side application using this template middleware without modification. It works by using `dangerouslySetInnerHTML` inside of a static container template. There are a couple of outstanding pull requests with alternate solutions to this problem. Hopefully this one helps.","created_at":"2015-01-02T23:57:13Z","updated_at":"2015-01-08T04:33:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f031b94b12c1c5c38e2989861938b6c254bbd7eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/express-react-views/pulls/17/commits","review_comments_url":"https://api.github.com/repos/reactjs/express-react-views/pulls/17/comments","review_comment_url":"https://api.github.com/repos/reactjs/express-react-views/pulls/comments/{number}","comments_url":"https://api.github.com/repos/reactjs/express-react-views/issues/17/comments","statuses_url":"https://api.github.com/repos/reactjs/express-react-views/statuses/a8780d623add18839076b3e19540862cb33d37aa","head":{"label":"tenorviol:master","ref":"master","sha":"a8780d623add18839076b3e19540862cb33d37aa","user":{"login":"tenorviol","id":157127,"avatar_url":"https://avatars.githubusercontent.com/u/157127?v=3","gravatar_id":"","url":"https://api.github.com/users/tenorviol","html_url":"https://github.com/tenorviol","followers_url":"https://api.github.com/users/tenorviol/followers","following_url":"https://api.github.com/users/tenorviol/following{/other_user}","gists_url":"https://api.github.com/users/tenorviol/gists{/gist_id}","starred_url":"https://api.github.com/users/tenorviol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenorviol/subscriptions","organizations_url":"https://api.github.com/users/tenorviol/orgs","repos_url":"https://api.github.com/users/tenorviol/repos","events_url":"https://api.github.com/users/tenorviol/events{/privacy}","received_events_url":"https://api.github.com/users/tenorviol/received_events","type":"User","site_admin":false},"repo":{"id":28729463,"name":"express-react-views","full_name":"tenorviol/express-react-views","owner":{"login":"tenorviol","id":157127,"avatar_url":"https://avatars.githubusercontent.com/u/157127?v=3","gravatar_id":"","url":"https://api.github.com/users/tenorviol","html_url":"https://github.com/tenorviol","followers_url":"https://api.github.com/users/tenorviol/followers","following_url":"https://api.github.com/users/tenorviol/following{/other_user}","gists_url":"https://api.github.com/users/tenorviol/gists{/gist_id}","starred_url":"https://api.github.com/users/tenorviol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenorviol/subscriptions","organizations_url":"https://api.github.com/users/tenorviol/orgs","repos_url":"https://api.github.com/users/tenorviol/repos","events_url":"https://api.github.com/users/tenorviol/events{/privacy}","received_events_url":"https://api.github.com/users/tenorviol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tenorviol/express-react-views","description":"This is an Express view engine which renders React components on server. It renders static markup and *does not* support mounting those views on the client.","fork":true,"url":"https://api.github.com/repos/tenorviol/express-react-views","forks_url":"https://api.github.com/repos/tenorviol/express-react-views/forks","keys_url":"https://api.github.com/repos/tenorviol/express-react-views/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tenorviol/express-react-views/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tenorviol/express-react-views/teams","hooks_url":"https://api.github.com/repos/tenorviol/express-react-views/hooks","issue_events_url":"https://api.github.com/repos/tenorviol/express-react-views/issues/events{/number}","events_url":"https://api.github.com/repos/tenorviol/express-react-views/events","assignees_url":"https://api.github.com/repos/tenorviol/express-react-views/assignees{/user}","branches_url":"https://api.github.com/repos/tenorviol/express-react-views/branches{/branch}","tags_url":"https://api.github.com/repos/tenorviol/express-react-views/tags","blobs_url":"https://api.github.com/repos/tenorviol/express-react-views/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tenorviol/express-react-views/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tenorviol/express-react-views/git/refs{/sha}","trees_url":"https://api.github.com/repos/tenorviol/express-react-views/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tenorviol/express-react-views/statuses/{sha}","languages_url":"https://api.github.com/repos/tenorviol/express-react-views/languages","stargazers_url":"https://api.github.com/repos/tenorviol/express-react-views/stargazers","contributors_url":"https://api.github.com/repos/tenorviol/express-react-views/contributors","subscribers_url":"https://api.github.com/repos/tenorviol/express-react-views/subscribers","subscription_url":"https://api.github.com/repos/tenorviol/express-react-views/subscription","commits_url":"https://api.github.com/repos/tenorviol/express-react-views/commits{/sha}","git_commits_url":"https://api.github.com/repos/tenorviol/express-react-views/git/commits{/sha}","comments_url":"https://api.github.com/repos/tenorviol/express-react-views/comments{/number}","issue_comment_url":"https://api.github.com/repos/tenorviol/express-react-views/issues/comments/{number}","contents_url":"https://api.github.com/repos/tenorviol/express-react-views/contents/{+path}","compare_url":"https://api.github.com/repos/tenorviol/express-react-views/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tenorviol/express-react-views/merges","archive_url":"https://api.github.com/repos/tenorviol/express-react-views/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tenorviol/express-react-views/downloads","issues_url":"https://api.github.com/repos/tenorviol/express-react-views/issues{/number}","pulls_url":"https://api.github.com/repos/tenorviol/express-react-views/pulls{/number}","milestones_url":"https://api.github.com/repos/tenorviol/express-react-views/milestones{/number}","notifications_url":"https://api.github.com/repos/tenorviol/express-react-views/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tenorviol/express-react-views/labels{/name}","releases_url":"https://api.github.com/repos/tenorviol/express-react-views/releases{/id}","created_at":"2015-01-02T23:25:30Z","updated_at":"2015-01-08T04:26:22Z","pushed_at":"2015-01-08T04:26:21Z","git_url":"git://github.com/tenorviol/express-react-views.git","ssh_url":"git@github.com:tenorviol/express-react-views.git","clone_url":"https://github.com/tenorviol/express-react-views.git","svn_url":"https://github.com/tenorviol/express-react-views","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"83084b8b0f38e689f7959d7bd7f6952e37c13fff","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18308864,"name":"express-react-views","full_name":"reactjs/express-react-views","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/express-react-views","description":"This is an Express view engine which renders React components on server. It renders static markup and *does not* support mounting those views on the client.","fork":false,"url":"https://api.github.com/repos/reactjs/express-react-views","forks_url":"https://api.github.com/repos/reactjs/express-react-views/forks","keys_url":"https://api.github.com/repos/reactjs/express-react-views/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/express-react-views/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/express-react-views/teams","hooks_url":"https://api.github.com/repos/reactjs/express-react-views/hooks","issue_events_url":"https://api.github.com/repos/reactjs/express-react-views/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/express-react-views/events","assignees_url":"https://api.github.com/repos/reactjs/express-react-views/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/express-react-views/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/express-react-views/tags","blobs_url":"https://api.github.com/repos/reactjs/express-react-views/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/express-react-views/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/express-react-views/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/express-react-views/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/express-react-views/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/express-react-views/languages","stargazers_url":"https://api.github.com/repos/reactjs/express-react-views/stargazers","contributors_url":"https://api.github.com/repos/reactjs/express-react-views/contributors","subscribers_url":"https://api.github.com/repos/reactjs/express-react-views/subscribers","subscription_url":"https://api.github.com/repos/reactjs/express-react-views/subscription","commits_url":"https://api.github.com/repos/reactjs/express-react-views/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/express-react-views/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/express-react-views/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/express-react-views/issues/comments/{number}","contents_url":"https://api.github.com/repos/reactjs/express-react-views/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/express-react-views/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/express-react-views/merges","archive_url":"https://api.github.com/repos/reactjs/express-react-views/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/express-react-views/downloads","issues_url":"https://api.github.com/repos/reactjs/express-react-views/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/express-react-views/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/express-react-views/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/express-react-views/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/express-react-views/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/express-react-views/releases{/id}","created_at":"2014-03-31T21:35:14Z","updated_at":"2015-01-07T22:00:54Z","pushed_at":"2015-01-07T22:00:54Z","git_url":"git://github.com/reactjs/express-react-views.git","ssh_url":"git@github.com:reactjs/express-react-views.git","clone_url":"https://github.com/reactjs/express-react-views.git","svn_url":"https://github.com/reactjs/express-react-views","homepage":null,"size":373,"stargazers_count":123,"watchers_count":123,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":3,"forks":22,"open_issues":3,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/17"},"html":{"href":"https://github.com/reactjs/express-react-views/pull/17"},"issue":{"href":"https://api.github.com/repos/reactjs/express-react-views/issues/17"},"comments":{"href":"https://api.github.com/repos/reactjs/express-react-views/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/reactjs/express-react-views/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/express-react-views/statuses/a8780d623add18839076b3e19540862cb33d37aa"}}}}