{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39452493","id":39452493,"diff_hunk":"@@ -0,0 +1,101 @@\n+/*\n+Copyright 2015 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package exec\n+\n+import (\n+\t\"fmt\"\n+\t\"io\"\n+\n+\t\"k8s.io/kubernetes/pkg/admission\"\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/api/errors\"\n+\t\"k8s.io/kubernetes/pkg/api/rest\"\n+\tclient \"k8s.io/kubernetes/pkg/client/unversioned\"\n+)\n+\n+func init() {\n+\tadmission.RegisterPlugin(\"DenyExec\", func(client client.Interface, config io.Reader) (admission.Interface, error) {","path":"plugin/pkg/admission/exec/admission.go","position":31,"original_position":31,"commit_id":"cd6673fb1159e758b9940efde8a202459cb1d992","original_commit_id":"cd6673fb1159e758b9940efde8a202459cb1d992","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"I'd also like to see the existing deny privileged exec controller go away and register a construction of this one under the old name with the correct flags to get the old behavior","created_at":"2015-09-14T21:55:09Z","updated_at":"2015-09-14T21:55:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13447#discussion_r39452493","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39452493"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13447#discussion_r39452493"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447","id":43891343,"html_url":"https://github.com/kubernetes/kubernetes/pull/13447","diff_url":"https://github.com/kubernetes/kubernetes/pull/13447.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13447.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13447","number":13447,"state":"open","locked":false,"title":"Allow sharing the host PID namespace","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"In the same vein as https://github.com/kubernetes/kubernetes/pull/12470 this allows super privileged containers to share the host's PID namespace by adding\r\n\r\n1.  A knob on the PodSpec to request enabling the feature\r\n1.  A sources list flag in the kubelet for allowable sources with checks in `canRunPod`\r\n1.  Docker support for setting the config and a TODO in rkt\r\n1.  An admission controller to prevent exec into a container with HostPID enabled\r\n\r\n@bgrant0607 - requested API change\r\n@liggitt @smarterclayton @erictune @simon3z @pmorie - PTAL\r\n@derekwaynecarr - admission addition\r\n\r\n","created_at":"2015-09-01T15:40:50Z","updated_at":"2015-09-14T21:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f51416dcbd97b6e24334711bbb2c1efcad8066c3","assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13447/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/cd6673fb1159e758b9940efde8a202459cb1d992","head":{"label":"pweil-:pid-mode","ref":"pid-mode","sha":"cd6673fb1159e758b9940efde8a202459cb1d992","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":24119325,"name":"kubernetes","full_name":"pweil-/kubernetes","owner":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/pweil-/kubernetes","forks_url":"https://api.github.com/repos/pweil-/kubernetes/forks","keys_url":"https://api.github.com/repos/pweil-/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/kubernetes/teams","hooks_url":"https://api.github.com/repos/pweil-/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pweil-/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/kubernetes/events","assignees_url":"https://api.github.com/repos/pweil-/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/kubernetes/tags","blobs_url":"https://api.github.com/repos/pweil-/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pweil-/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pweil-/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pweil-/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pweil-/kubernetes/subscription","commits_url":"https://api.github.com/repos/pweil-/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/kubernetes/merges","archive_url":"https://api.github.com/repos/pweil-/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/kubernetes/downloads","issues_url":"https://api.github.com/repos/pweil-/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/kubernetes/releases{/id}","created_at":"2014-09-16T21:53:37Z","updated_at":"2015-05-01T00:12:38Z","pushed_at":"2015-09-14T20:34:16Z","git_url":"git://github.com/pweil-/kubernetes.git","ssh_url":"git@github.com:pweil-/kubernetes.git","clone_url":"https://github.com/pweil-/kubernetes.git","svn_url":"https://github.com/pweil-/kubernetes","homepage":null,"size":106119,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c9dd648a887ee72a3222deff3e20cf7df74a5ebe","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-14T21:38:37Z","pushed_at":"2015-09-14T21:48:26Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":408346,"stargazers_count":10226,"watchers_count":10226,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2525,"mirror_url":null,"open_issues_count":1765,"forks":2525,"open_issues":1765,"watchers":10226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13447"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13447"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13447/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13447/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/cd6673fb1159e758b9940efde8a202459cb1d992"}}}}