{"action":"created","comment":{"url":"https://api.github.com/repos/sumocoders/Framework/pulls/comments/26201345","id":26201345,"diff_hunk":"@@ -49,6 +48,8 @@ protected function handleRequestStack()\n      */\n     public function __toString()\n     {\n+        $this->handleRequestStack();","path":"src/SumoCoders/FrameworkCoreBundle/Service/JsData.php","position":12,"original_position":12,"commit_id":"9d68f08b07ac6486d80b330123bab6a03c21e700","original_commit_id":"9d68f08b07ac6486d80b330123bab6a03c21e700","user":{"login":"turanct","id":1728360,"avatar_url":"https://avatars.githubusercontent.com/u/1728360?v=3","gravatar_id":"","url":"https://api.github.com/users/turanct","html_url":"https://github.com/turanct","followers_url":"https://api.github.com/users/turanct/followers","following_url":"https://api.github.com/users/turanct/following{/other_user}","gists_url":"https://api.github.com/users/turanct/gists{/gist_id}","starred_url":"https://api.github.com/users/turanct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turanct/subscriptions","organizations_url":"https://api.github.com/users/turanct/orgs","repos_url":"https://api.github.com/users/turanct/repos","events_url":"https://api.github.com/users/turanct/events{/privacy}","received_events_url":"https://api.github.com/users/turanct/received_events","type":"User","site_admin":false},"body":"Ik vind het onlogisch dat `__toString()` side effects heeft...\r\n\r\nAlso, aangezien `$this->requestStack` via een setter kan gezet worden moet je in `handleRequestStack()` toch even checken of het niet `null` is vooraleer je er methods op gaat roepen. (is dit geen teken dat er eigenlijk constructor injection moet zijn?)","created_at":"2015-03-11T10:27:32Z","updated_at":"2015-03-11T10:27:32Z","html_url":"https://github.com/sumocoders/Framework/pull/38#discussion_r26201345","pull_request_url":"https://api.github.com/repos/sumocoders/Framework/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/comments/26201345"},"html":{"href":"https://github.com/sumocoders/Framework/pull/38#discussion_r26201345"},"pull_request":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/sumocoders/Framework/pulls/38","id":30930044,"html_url":"https://github.com/sumocoders/Framework/pull/38","diff_url":"https://github.com/sumocoders/Framework/pull/38.diff","patch_url":"https://github.com/sumocoders/Framework/pull/38.patch","issue_url":"https://api.github.com/repos/sumocoders/Framework/issues/38","number":38,"state":"open","locked":false,"title":"Get jsdata from the request when parsing into the template.","user":{"login":"WouterSioen","id":1398405,"avatar_url":"https://avatars.githubusercontent.com/u/1398405?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterSioen","html_url":"https://github.com/WouterSioen","followers_url":"https://api.github.com/users/WouterSioen/followers","following_url":"https://api.github.com/users/WouterSioen/following{/other_user}","gists_url":"https://api.github.com/users/WouterSioen/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterSioen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterSioen/subscriptions","organizations_url":"https://api.github.com/users/WouterSioen/orgs","repos_url":"https://api.github.com/users/WouterSioen/repos","events_url":"https://api.github.com/users/WouterSioen/events{/privacy}","received_events_url":"https://api.github.com/users/WouterSioen/received_events","type":"User","site_admin":false},"body":"This makes sure we are fetching data from the latest request, so all\r\nneeded data (like the locale) is filled in.\r\nIt also makes sure the code isn't executed when jsData isn't parsed into\r\nthe template.","created_at":"2015-03-11T10:22:10Z","updated_at":"2015-03-11T10:27:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dce7ca8743563fd905f021b8241e811b838566d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sumocoders/Framework/pulls/38/commits","review_comments_url":"https://api.github.com/repos/sumocoders/Framework/pulls/38/comments","review_comment_url":"https://api.github.com/repos/sumocoders/Framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sumocoders/Framework/issues/38/comments","statuses_url":"https://api.github.com/repos/sumocoders/Framework/statuses/9d68f08b07ac6486d80b330123bab6a03c21e700","head":{"label":"sumocoders:fix-jsdata","ref":"fix-jsdata","sha":"9d68f08b07ac6486d80b330123bab6a03c21e700","user":{"login":"sumocoders","id":359178,"avatar_url":"https://avatars.githubusercontent.com/u/359178?v=3","gravatar_id":"","url":"https://api.github.com/users/sumocoders","html_url":"https://github.com/sumocoders","followers_url":"https://api.github.com/users/sumocoders/followers","following_url":"https://api.github.com/users/sumocoders/following{/other_user}","gists_url":"https://api.github.com/users/sumocoders/gists{/gist_id}","starred_url":"https://api.github.com/users/sumocoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumocoders/subscriptions","organizations_url":"https://api.github.com/users/sumocoders/orgs","repos_url":"https://api.github.com/users/sumocoders/repos","events_url":"https://api.github.com/users/sumocoders/events{/privacy}","received_events_url":"https://api.github.com/users/sumocoders/received_events","type":"Organization","site_admin":false},"repo":{"id":29462085,"name":"Framework","full_name":"sumocoders/Framework","owner":{"login":"sumocoders","id":359178,"avatar_url":"https://avatars.githubusercontent.com/u/359178?v=3","gravatar_id":"","url":"https://api.github.com/users/sumocoders","html_url":"https://github.com/sumocoders","followers_url":"https://api.github.com/users/sumocoders/followers","following_url":"https://api.github.com/users/sumocoders/following{/other_user}","gists_url":"https://api.github.com/users/sumocoders/gists{/gist_id}","starred_url":"https://api.github.com/users/sumocoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumocoders/subscriptions","organizations_url":"https://api.github.com/users/sumocoders/orgs","repos_url":"https://api.github.com/users/sumocoders/repos","events_url":"https://api.github.com/users/sumocoders/events{/privacy}","received_events_url":"https://api.github.com/users/sumocoders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumocoders/Framework","description":"The Symfony version of the SumoCoders framework.","fork":false,"url":"https://api.github.com/repos/sumocoders/Framework","forks_url":"https://api.github.com/repos/sumocoders/Framework/forks","keys_url":"https://api.github.com/repos/sumocoders/Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumocoders/Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumocoders/Framework/teams","hooks_url":"https://api.github.com/repos/sumocoders/Framework/hooks","issue_events_url":"https://api.github.com/repos/sumocoders/Framework/issues/events{/number}","events_url":"https://api.github.com/repos/sumocoders/Framework/events","assignees_url":"https://api.github.com/repos/sumocoders/Framework/assignees{/user}","branches_url":"https://api.github.com/repos/sumocoders/Framework/branches{/branch}","tags_url":"https://api.github.com/repos/sumocoders/Framework/tags","blobs_url":"https://api.github.com/repos/sumocoders/Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumocoders/Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumocoders/Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumocoders/Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumocoders/Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/sumocoders/Framework/languages","stargazers_url":"https://api.github.com/repos/sumocoders/Framework/stargazers","contributors_url":"https://api.github.com/repos/sumocoders/Framework/contributors","subscribers_url":"https://api.github.com/repos/sumocoders/Framework/subscribers","subscription_url":"https://api.github.com/repos/sumocoders/Framework/subscription","commits_url":"https://api.github.com/repos/sumocoders/Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumocoders/Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumocoders/Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumocoders/Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumocoders/Framework/contents/{+path}","compare_url":"https://api.github.com/repos/sumocoders/Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumocoders/Framework/merges","archive_url":"https://api.github.com/repos/sumocoders/Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumocoders/Framework/downloads","issues_url":"https://api.github.com/repos/sumocoders/Framework/issues{/number}","pulls_url":"https://api.github.com/repos/sumocoders/Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/sumocoders/Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/sumocoders/Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumocoders/Framework/labels{/name}","releases_url":"https://api.github.com/repos/sumocoders/Framework/releases{/id}","created_at":"2015-01-19T08:57:15Z","updated_at":"2015-03-10T10:21:49Z","pushed_at":"2015-03-11T10:21:39Z","git_url":"git://github.com/sumocoders/Framework.git","ssh_url":"git@github.com:sumocoders/Framework.git","clone_url":"https://github.com/sumocoders/Framework.git","svn_url":"https://github.com/sumocoders/Framework","homepage":null,"size":2168,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"sumocoders:master","ref":"master","sha":"a04f7fb62bdcd1e8d968cfc462dee8ac2e9a6870","user":{"login":"sumocoders","id":359178,"avatar_url":"https://avatars.githubusercontent.com/u/359178?v=3","gravatar_id":"","url":"https://api.github.com/users/sumocoders","html_url":"https://github.com/sumocoders","followers_url":"https://api.github.com/users/sumocoders/followers","following_url":"https://api.github.com/users/sumocoders/following{/other_user}","gists_url":"https://api.github.com/users/sumocoders/gists{/gist_id}","starred_url":"https://api.github.com/users/sumocoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumocoders/subscriptions","organizations_url":"https://api.github.com/users/sumocoders/orgs","repos_url":"https://api.github.com/users/sumocoders/repos","events_url":"https://api.github.com/users/sumocoders/events{/privacy}","received_events_url":"https://api.github.com/users/sumocoders/received_events","type":"Organization","site_admin":false},"repo":{"id":29462085,"name":"Framework","full_name":"sumocoders/Framework","owner":{"login":"sumocoders","id":359178,"avatar_url":"https://avatars.githubusercontent.com/u/359178?v=3","gravatar_id":"","url":"https://api.github.com/users/sumocoders","html_url":"https://github.com/sumocoders","followers_url":"https://api.github.com/users/sumocoders/followers","following_url":"https://api.github.com/users/sumocoders/following{/other_user}","gists_url":"https://api.github.com/users/sumocoders/gists{/gist_id}","starred_url":"https://api.github.com/users/sumocoders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumocoders/subscriptions","organizations_url":"https://api.github.com/users/sumocoders/orgs","repos_url":"https://api.github.com/users/sumocoders/repos","events_url":"https://api.github.com/users/sumocoders/events{/privacy}","received_events_url":"https://api.github.com/users/sumocoders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumocoders/Framework","description":"The Symfony version of the SumoCoders framework.","fork":false,"url":"https://api.github.com/repos/sumocoders/Framework","forks_url":"https://api.github.com/repos/sumocoders/Framework/forks","keys_url":"https://api.github.com/repos/sumocoders/Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumocoders/Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumocoders/Framework/teams","hooks_url":"https://api.github.com/repos/sumocoders/Framework/hooks","issue_events_url":"https://api.github.com/repos/sumocoders/Framework/issues/events{/number}","events_url":"https://api.github.com/repos/sumocoders/Framework/events","assignees_url":"https://api.github.com/repos/sumocoders/Framework/assignees{/user}","branches_url":"https://api.github.com/repos/sumocoders/Framework/branches{/branch}","tags_url":"https://api.github.com/repos/sumocoders/Framework/tags","blobs_url":"https://api.github.com/repos/sumocoders/Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumocoders/Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumocoders/Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumocoders/Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumocoders/Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/sumocoders/Framework/languages","stargazers_url":"https://api.github.com/repos/sumocoders/Framework/stargazers","contributors_url":"https://api.github.com/repos/sumocoders/Framework/contributors","subscribers_url":"https://api.github.com/repos/sumocoders/Framework/subscribers","subscription_url":"https://api.github.com/repos/sumocoders/Framework/subscription","commits_url":"https://api.github.com/repos/sumocoders/Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumocoders/Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumocoders/Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumocoders/Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumocoders/Framework/contents/{+path}","compare_url":"https://api.github.com/repos/sumocoders/Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumocoders/Framework/merges","archive_url":"https://api.github.com/repos/sumocoders/Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumocoders/Framework/downloads","issues_url":"https://api.github.com/repos/sumocoders/Framework/issues{/number}","pulls_url":"https://api.github.com/repos/sumocoders/Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/sumocoders/Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/sumocoders/Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumocoders/Framework/labels{/name}","releases_url":"https://api.github.com/repos/sumocoders/Framework/releases{/id}","created_at":"2015-01-19T08:57:15Z","updated_at":"2015-03-10T10:21:49Z","pushed_at":"2015-03-11T10:21:39Z","git_url":"git://github.com/sumocoders/Framework.git","ssh_url":"git@github.com:sumocoders/Framework.git","clone_url":"https://github.com/sumocoders/Framework.git","svn_url":"https://github.com/sumocoders/Framework","homepage":null,"size":2168,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/38"},"html":{"href":"https://github.com/sumocoders/Framework/pull/38"},"issue":{"href":"https://api.github.com/repos/sumocoders/Framework/issues/38"},"comments":{"href":"https://api.github.com/repos/sumocoders/Framework/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sumocoders/Framework/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/sumocoders/Framework/statuses/9d68f08b07ac6486d80b330123bab6a03c21e700"}}}}