{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/3923","labels_url":"https://api.github.com/repos/facebook/react/issues/3923/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/3923/comments","events_url":"https://api.github.com/repos/facebook/react/issues/3923/events","html_url":"https://github.com/facebook/react/pull/3923","id":78778267,"number":3923,"title":"Fixed failing unit tests in browsers that don't support WebComponents","user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-21T01:46:42Z","updated_at":"2015-05-21T23:01:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/3923","html_url":"https://github.com/facebook/react/pull/3923","diff_url":"https://github.com/facebook/react/pull/3923.diff","patch_url":"https://github.com/facebook/react/pull/3923.patch"},"body":"As per https://github.com/facebook/react/issues/3919, our tests currently only pass in the browser when running in Chrome because when webcomponents.js is actually loaded, it's currently getting packaged into react-test because we're requiring it. It creates a new Node which is resulting in nodes we create with createNodeFromMarkup to have a different prototype than what is expected in WebComponents. WebComponents's new Node prototype has a different implementation of insertBefore which does an instanceof Node check which our nodes are failing.\r\n\r\nThis PR explicitly checks for PhantomJS (probably not strictly necessary, since we had the try-catch there before, but Paul asked for a check).  Also loads webcomponents.js for tests before any of the other javascript.\r\n\r\nThere are still a couple of tests failing in my Firefox, but presumably that's unrelated.  We can investigate those tests further tomorrow.  In the mean time, this diff should be ready to land.\r\n\r\ncc @zpao \r\n\r\nFixes #3919"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/104445041","html_url":"https://github.com/facebook/react/pull/3923#issuecomment-104445041","issue_url":"https://api.github.com/repos/facebook/react/issues/3923","id":104445041,"user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T23:01:41Z","updated_at":"2015-05-21T23:01:41Z","body":"@zpao updated."}}