{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/28365271","id":28365271,"diff_hunk":"@@ -17,13 +25,15 @@ trait Get : ::std::marker::MarkerTrait {\n \n trait Other {\n     fn uhoh<U:Get>(&self, foo: U, bar: <Self as Get>::Value) {}\n-    //~^ ERROR the trait `Get` is not implemented for the type `Self`\n+    // (note that we no longer catch the error here, since the\n+    //  error below aborts compilation.\n+    //  See also associated-types-no-suitable-supertrait-2.rs\n+    //  which checks that this error would be caught eventually.)\n }\n \n impl<T:Get> Other for T {\n     fn uhoh<U:Get>(&self, foo: U, bar: <(T, U) as Get>::Value) {}\n     //~^ ERROR the trait `Get` is not implemented for the type `(T, U)`\n-    //~| ERROR the trait `Get` is not implemented for the type `(T, U)`","path":"src/test/compile-fail/associated-types-no-suitable-supertrait.rs","position":29,"original_position":29,"commit_id":"d82f9123b25ac9cf1b4b634f5b60358517d8998d","original_commit_id":"d82f9123b25ac9cf1b4b634f5b60358517d8998d","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":":+1: this commit just for this.","created_at":"2015-04-14T20:10:13Z","updated_at":"2015-04-14T20:10:13Z","html_url":"https://github.com/rust-lang/rust/pull/24422#discussion_r28365271","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/24422","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/28365271"},"html":{"href":"https://github.com/rust-lang/rust/pull/24422#discussion_r28365271"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24422"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/24422","id":33277253,"html_url":"https://github.com/rust-lang/rust/pull/24422","diff_url":"https://github.com/rust-lang/rust/pull/24422.diff","patch_url":"https://github.com/rust-lang/rust/pull/24422.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/24422","number":24422,"state":"open","locked":false,"title":"Typeck highlevel before bodies","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"body":"typeck: Do high-level structural/signature checks before function body checks.\r\n\r\nThis avoids various ICEs, e.g. premature calls to cat_expr that yield the dreaded \"cat_expr Errd\" ICE.\r\n\r\nHowever, it also means that some early error feedback is now not provided.  In some cases this is for the best, because the error feedback were were providing in those cases were false positives -- it was spurious feedback and a distraction from the real problem.\r\n\r\nSo it is not 100% clear whether we actually want to put this change in or not.  I think its a net win, but others might disagree.\r\n\r\n(Kudos to @arielb1 for suggesting this modification.)","created_at":"2015-04-14T16:53:03Z","updated_at":"2015-04-14T20:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0964de4bbeb1bb649e59bf638fc493d89b491ba3","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/24422/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/24422/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/24422/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d82f9123b25ac9cf1b4b634f5b60358517d8998d","head":{"label":"pnkfelix:typeck-highlevel-before-bodies","ref":"typeck-highlevel-before-bodies","sha":"d82f9123b25ac9cf1b4b634f5b60358517d8998d","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"repo":{"id":7822507,"name":"rust","full_name":"pnkfelix/rust","owner":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnkfelix/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/pnkfelix/rust","forks_url":"https://api.github.com/repos/pnkfelix/rust/forks","keys_url":"https://api.github.com/repos/pnkfelix/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnkfelix/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnkfelix/rust/teams","hooks_url":"https://api.github.com/repos/pnkfelix/rust/hooks","issue_events_url":"https://api.github.com/repos/pnkfelix/rust/issues/events{/number}","events_url":"https://api.github.com/repos/pnkfelix/rust/events","assignees_url":"https://api.github.com/repos/pnkfelix/rust/assignees{/user}","branches_url":"https://api.github.com/repos/pnkfelix/rust/branches{/branch}","tags_url":"https://api.github.com/repos/pnkfelix/rust/tags","blobs_url":"https://api.github.com/repos/pnkfelix/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnkfelix/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnkfelix/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnkfelix/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnkfelix/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/pnkfelix/rust/languages","stargazers_url":"https://api.github.com/repos/pnkfelix/rust/stargazers","contributors_url":"https://api.github.com/repos/pnkfelix/rust/contributors","subscribers_url":"https://api.github.com/repos/pnkfelix/rust/subscribers","subscription_url":"https://api.github.com/repos/pnkfelix/rust/subscription","commits_url":"https://api.github.com/repos/pnkfelix/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnkfelix/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnkfelix/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnkfelix/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnkfelix/rust/contents/{+path}","compare_url":"https://api.github.com/repos/pnkfelix/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnkfelix/rust/merges","archive_url":"https://api.github.com/repos/pnkfelix/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnkfelix/rust/downloads","issues_url":"https://api.github.com/repos/pnkfelix/rust/issues{/number}","pulls_url":"https://api.github.com/repos/pnkfelix/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/pnkfelix/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/pnkfelix/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnkfelix/rust/labels{/name}","releases_url":"https://api.github.com/repos/pnkfelix/rust/releases{/id}","created_at":"2013-01-25T15:18:32Z","updated_at":"2014-06-24T13:41:54Z","pushed_at":"2015-04-14T16:51:03Z","git_url":"git://github.com/pnkfelix/rust.git","ssh_url":"git@github.com:pnkfelix/rust.git","clone_url":"https://github.com/pnkfelix/rust.git","svn_url":"https://github.com/pnkfelix/rust","homepage":"http://www.rust-lang.org","size":292762,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"47551b57456c108c69f698b114606a275fb01643","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-04-14T18:06:57Z","pushed_at":"2015-04-14T20:05:55Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":552501,"stargazers_count":10304,"watchers_count":10304,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1983,"mirror_url":null,"open_issues_count":2041,"forks":1983,"open_issues":2041,"watchers":10304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24422"},"html":{"href":"https://github.com/rust-lang/rust/pull/24422"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24422"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24422/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24422/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24422/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d82f9123b25ac9cf1b4b634f5b60358517d8998d"}}}}