{"action":"created","issue":{"url":"https://api.github.com/repos/SassDoc/sassdoc/issues/345","labels_url":"https://api.github.com/repos/SassDoc/sassdoc/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/SassDoc/sassdoc/issues/345/comments","events_url":"https://api.github.com/repos/SassDoc/sassdoc/issues/345/events","html_url":"https://github.com/SassDoc/sassdoc/issues/345","id":55824717,"number":345,"title":"Environment issues/questions","user":{"login":"pascalduez","id":335467,"avatar_url":"https://avatars.githubusercontent.com/u/335467?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalduez","html_url":"https://github.com/pascalduez","followers_url":"https://api.github.com/users/pascalduez/followers","following_url":"https://api.github.com/users/pascalduez/following{/other_user}","gists_url":"https://api.github.com/users/pascalduez/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalduez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalduez/subscriptions","organizations_url":"https://api.github.com/users/pascalduez/orgs","repos_url":"https://api.github.com/users/pascalduez/repos","events_url":"https://api.github.com/users/pascalduez/events{/privacy}","received_events_url":"https://api.github.com/users/pascalduez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/SassDoc/sassdoc/milestones/3","labels_url":"https://api.github.com/repos/SassDoc/sassdoc/milestones/3/labels","id":711031,"number":3,"title":"2.0","description":"Breaking changes only, no new feature.","creator":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars.githubusercontent.com/u/1889710?v=3","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":35,"state":"open","created_at":"2014-07-05T17:26:36Z","updated_at":"2015-01-30T11:56:44Z","due_on":"2015-01-30T23:00:00Z","closed_at":null},"comments":4,"created_at":"2015-01-28T22:20:36Z","updated_at":"2015-01-30T11:56:50Z","closed_at":null,"body":"**[draft][wip]**\r\n\r\nWhile working on unit tests for Environment, a number of questions raised.\r\n\r\n###### 1 \r\nWhen Environment fail to find a custom theme, and thus falling back to default theme, shouldn't `env.themeName` be changed to `'default'` then ?\r\nRight now it stays with the failing theme name.\r\n*It's no big deal since that key does not seem used afterward, but just for consistency/logic*\r\n\r\n###### 2\r\nWhen there is no `package` key in a config, or **no config at all**, shouldn't Environment try to load the `package.json` from current project/cwd ?\r\nRight now: `{}`\r\nIf a passed in `package` key is failing, the fallback happens successfully though.\r\n\r\n###### 3\r\n`Environment.load` accepts three types of config: String, Object or undefined.\r\nThe object check is `typeof config === 'object'`. \r\nThus `Environment.load([`:trollface:`]);` boom.\r\n\r\n###### 4\r\n`strict` can't be set from config. \r\nIt is part of the Environment Object when [loadObject](https://github.com/SassDoc/sassdoc/blob/develop/src/environment.js#L78-L83) checks are done. \r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/SassDoc/sassdoc/issues/comments/72190735","html_url":"https://github.com/SassDoc/sassdoc/issues/345#issuecomment-72190735","issue_url":"https://api.github.com/repos/SassDoc/sassdoc/issues/345","id":72190735,"user":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars.githubusercontent.com/u/1889710?v=3","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"created_at":"2015-01-30T11:56:50Z","updated_at":"2015-01-30T11:56:50Z","body":"Can we close?"}}