{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3","id":47325187,"html_url":"https://github.com/chef-partners/kitchen-vra/pull/3","diff_url":"https://github.com/chef-partners/kitchen-vra/pull/3.diff","patch_url":"https://github.com/chef-partners/kitchen-vra/pull/3.patch","issue_url":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/3","number":3,"state":"open","locked":false,"title":"optional use_dns","user":{"login":"stevehedrick","id":6125967,"avatar_url":"https://avatars.githubusercontent.com/u/6125967?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehedrick","html_url":"https://github.com/stevehedrick","followers_url":"https://api.github.com/users/stevehedrick/followers","following_url":"https://api.github.com/users/stevehedrick/following{/other_user}","gists_url":"https://api.github.com/users/stevehedrick/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehedrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehedrick/subscriptions","organizations_url":"https://api.github.com/users/stevehedrick/orgs","repos_url":"https://api.github.com/users/stevehedrick/repos","events_url":"https://api.github.com/users/stevehedrick/events{/privacy}","received_events_url":"https://api.github.com/users/stevehedrick/received_events","type":"User","site_admin":false},"body":"As per the discussion with @adamleff in #2 here's a PR with the use_dns functionality.  This solves the use case I had, where my corporate vRA does not manage the IP addresses of vm's, but the `server.name` value was being pushed to DNS.\r\n\r\n`use_dns` has been added with a default value of `false`.  When `false` kitchen-vra will stop if vRA does not supply an ip address.  When `true` kitchen-vra will insert the `server.name` value as the `state[:hostname]` only if an ip address is not returned by vRA.  If an ip address is returned, and `use_dns` is `true` the ip address will still be passed to `state[:hostname]`.\r\n\r\nspec/vra_spec.rb has been updated with new tests which (I believe) should cover these changes.  I've also updated the description on the existing tests around ip to clarify that they are with `use_dns` set to the default of `false`.\r\n","created_at":"2015-10-09T22:06:35Z","updated_at":"2015-10-09T22:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3/commits","review_comments_url":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3/comments","review_comment_url":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/3/comments","statuses_url":"https://api.github.com/repos/chef-partners/kitchen-vra/statuses/b443846e546629d10f70766f6a73da7dfcf64b9f","head":{"label":"stevehedrick:use_dns","ref":"use_dns","sha":"b443846e546629d10f70766f6a73da7dfcf64b9f","user":{"login":"stevehedrick","id":6125967,"avatar_url":"https://avatars.githubusercontent.com/u/6125967?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehedrick","html_url":"https://github.com/stevehedrick","followers_url":"https://api.github.com/users/stevehedrick/followers","following_url":"https://api.github.com/users/stevehedrick/following{/other_user}","gists_url":"https://api.github.com/users/stevehedrick/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehedrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehedrick/subscriptions","organizations_url":"https://api.github.com/users/stevehedrick/orgs","repos_url":"https://api.github.com/users/stevehedrick/repos","events_url":"https://api.github.com/users/stevehedrick/events{/privacy}","received_events_url":"https://api.github.com/users/stevehedrick/received_events","type":"User","site_admin":false},"repo":{"id":42727831,"name":"kitchen-vra","full_name":"stevehedrick/kitchen-vra","owner":{"login":"stevehedrick","id":6125967,"avatar_url":"https://avatars.githubusercontent.com/u/6125967?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehedrick","html_url":"https://github.com/stevehedrick","followers_url":"https://api.github.com/users/stevehedrick/followers","following_url":"https://api.github.com/users/stevehedrick/following{/other_user}","gists_url":"https://api.github.com/users/stevehedrick/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehedrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehedrick/subscriptions","organizations_url":"https://api.github.com/users/stevehedrick/orgs","repos_url":"https://api.github.com/users/stevehedrick/repos","events_url":"https://api.github.com/users/stevehedrick/events{/privacy}","received_events_url":"https://api.github.com/users/stevehedrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevehedrick/kitchen-vra","description":"Test Kitchen driver for VMware vRealize Automation","fork":true,"url":"https://api.github.com/repos/stevehedrick/kitchen-vra","forks_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/forks","keys_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/teams","hooks_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/hooks","issue_events_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/issues/events{/number}","events_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/events","assignees_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/assignees{/user}","branches_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/branches{/branch}","tags_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/tags","blobs_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/statuses/{sha}","languages_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/languages","stargazers_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/stargazers","contributors_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/contributors","subscribers_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/subscribers","subscription_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/subscription","commits_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/contents/{+path}","compare_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/merges","archive_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/downloads","issues_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/issues{/number}","pulls_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/pulls{/number}","milestones_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/milestones{/number}","notifications_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/labels{/name}","releases_url":"https://api.github.com/repos/stevehedrick/kitchen-vra/releases{/id}","created_at":"2015-09-18T14:39:09Z","updated_at":"2015-09-18T14:39:10Z","pushed_at":"2015-10-09T21:53:58Z","git_url":"git://github.com/stevehedrick/kitchen-vra.git","ssh_url":"git@github.com:stevehedrick/kitchen-vra.git","clone_url":"https://github.com/stevehedrick/kitchen-vra.git","svn_url":"https://github.com/stevehedrick/kitchen-vra","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-partners:master","ref":"master","sha":"6d3d88e57738eb1b2513ea0af655e89d5d3f6522","user":{"login":"chef-partners","id":6988876,"avatar_url":"https://avatars.githubusercontent.com/u/6988876?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"repo":{"id":40262490,"name":"kitchen-vra","full_name":"chef-partners/kitchen-vra","owner":{"login":"chef-partners","id":6988876,"avatar_url":"https://avatars.githubusercontent.com/u/6988876?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-partners/kitchen-vra","description":"Test Kitchen driver for VMware vRealize Automation","fork":false,"url":"https://api.github.com/repos/chef-partners/kitchen-vra","forks_url":"https://api.github.com/repos/chef-partners/kitchen-vra/forks","keys_url":"https://api.github.com/repos/chef-partners/kitchen-vra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-partners/kitchen-vra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-partners/kitchen-vra/teams","hooks_url":"https://api.github.com/repos/chef-partners/kitchen-vra/hooks","issue_events_url":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/events{/number}","events_url":"https://api.github.com/repos/chef-partners/kitchen-vra/events","assignees_url":"https://api.github.com/repos/chef-partners/kitchen-vra/assignees{/user}","branches_url":"https://api.github.com/repos/chef-partners/kitchen-vra/branches{/branch}","tags_url":"https://api.github.com/repos/chef-partners/kitchen-vra/tags","blobs_url":"https://api.github.com/repos/chef-partners/kitchen-vra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-partners/kitchen-vra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-partners/kitchen-vra/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-partners/kitchen-vra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-partners/kitchen-vra/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-partners/kitchen-vra/languages","stargazers_url":"https://api.github.com/repos/chef-partners/kitchen-vra/stargazers","contributors_url":"https://api.github.com/repos/chef-partners/kitchen-vra/contributors","subscribers_url":"https://api.github.com/repos/chef-partners/kitchen-vra/subscribers","subscription_url":"https://api.github.com/repos/chef-partners/kitchen-vra/subscription","commits_url":"https://api.github.com/repos/chef-partners/kitchen-vra/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-partners/kitchen-vra/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-partners/kitchen-vra/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-partners/kitchen-vra/contents/{+path}","compare_url":"https://api.github.com/repos/chef-partners/kitchen-vra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-partners/kitchen-vra/merges","archive_url":"https://api.github.com/repos/chef-partners/kitchen-vra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-partners/kitchen-vra/downloads","issues_url":"https://api.github.com/repos/chef-partners/kitchen-vra/issues{/number}","pulls_url":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-partners/kitchen-vra/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-partners/kitchen-vra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-partners/kitchen-vra/labels{/name}","releases_url":"https://api.github.com/repos/chef-partners/kitchen-vra/releases{/id}","created_at":"2015-08-05T18:34:50Z","updated_at":"2015-09-25T06:06:20Z","pushed_at":"2015-08-12T13:18:37Z","git_url":"git://github.com/chef-partners/kitchen-vra.git","ssh_url":"git@github.com:chef-partners/kitchen-vra.git","clone_url":"https://github.com/chef-partners/kitchen-vra.git","svn_url":"https://github.com/chef-partners/kitchen-vra","homepage":null,"size":176,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3"},"html":{"href":"https://github.com/chef-partners/kitchen-vra/pull/3"},"issue":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/3"},"comments":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/chef-partners/kitchen-vra/statuses/b443846e546629d10f70766f6a73da7dfcf64b9f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":7,"changed_files":2}}