{"action":"created","issue":{"url":"https://api.github.com/repos/libopencm3/libopencm3/issues/346","labels_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/346/comments","events_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/346/events","html_url":"https://github.com/libopencm3/libopencm3/pull/346","id":42431910,"number":346,"title":"stm32: usb otg_fs and otg_hs register definitions","user":{"login":"amirhammad","id":8723410,"avatar_url":"https://avatars.githubusercontent.com/u/8723410?v=3","gravatar_id":"","url":"https://api.github.com/users/amirhammad","html_url":"https://github.com/amirhammad","followers_url":"https://api.github.com/users/amirhammad/followers","following_url":"https://api.github.com/users/amirhammad/following{/other_user}","gists_url":"https://api.github.com/users/amirhammad/gists{/gist_id}","starred_url":"https://api.github.com/users/amirhammad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirhammad/subscriptions","organizations_url":"https://api.github.com/users/amirhammad/orgs","repos_url":"https://api.github.com/users/amirhammad/repos","events_url":"https://api.github.com/users/amirhammad/events{/privacy}","received_events_url":"https://api.github.com/users/amirhammad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2014-09-10T16:25:56Z","updated_at":"2015-02-03T22:54:13Z","closed_at":"2015-02-03T22:53:49Z","pull_request":{"url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/346","html_url":"https://github.com/libopencm3/libopencm3/pull/346","diff_url":"https://github.com/libopencm3/libopencm3/pull/346.diff","patch_url":"https://github.com/libopencm3/libopencm3/pull/346.patch"},"body":"Most of the usb-host-related definitions were missing, so were added.\r\n\r\nFile otg_fs.h were not in the same style of definitions in otg_hs.h. This change should not affect previous functionality.\r\nExample: \r\nChanged from this style:\r\n#######\r\n#define MMIO32(USB_OTG_FS_BASE + 0x000)\r\n#######\r\nto this style:\r\n#######\r\n#define OTG_GOTGCTL 0x000\r\n...\r\n#define OTG_FS_GOTGCTL MMIO32(USB_OTG_FS_BASE + OTG_GOTGCTL)\r\n#######\r\n\r\nIn OTG_HS were bug at line 28: \r\n\"OTG_GOTGIN\" instead of \"OTG_GOTGINT\". \r\nIt is then referenced (not really) in line 90.\r\n#define OTG_HS_GOTGINT MMIO32(USB_OTG_HS_BASE + OTG_GOTGINT)\r\n\r\nUPDATE 1: \r\nCreated new file otg_common.h that contains common register definitions from files:\r\notg_hs.h and otg_fs.h"},"comment":{"url":"https://api.github.com/repos/libopencm3/libopencm3/issues/comments/72753796","html_url":"https://github.com/libopencm3/libopencm3/pull/346#issuecomment-72753796","issue_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/346","id":72753796,"user":{"login":"amirhammad","id":8723410,"avatar_url":"https://avatars.githubusercontent.com/u/8723410?v=3","gravatar_id":"","url":"https://api.github.com/users/amirhammad","html_url":"https://github.com/amirhammad","followers_url":"https://api.github.com/users/amirhammad/followers","following_url":"https://api.github.com/users/amirhammad/following{/other_user}","gists_url":"https://api.github.com/users/amirhammad/gists{/gist_id}","starred_url":"https://api.github.com/users/amirhammad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirhammad/subscriptions","organizations_url":"https://api.github.com/users/amirhammad/orgs","repos_url":"https://api.github.com/users/amirhammad/repos","events_url":"https://api.github.com/users/amirhammad/events{/privacy}","received_events_url":"https://api.github.com/users/amirhammad/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T22:54:13Z","updated_at":"2015-02-03T22:54:13Z","body":"Opened new pull request: https://github.com/libopencm3/libopencm3/pull/405"}}