{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/39756820","id":39756820,"diff_hunk":"@@ -53,6 +53,34 @@ module.exports = function(HALAPIResource, $http, PathHelper){\n       return activity.links.update.fetch(options).then(function(activity){\n         return activity;\n       });\n+    },\n+\n+    isInitialActivity: function(activities, activity, activityNo, activitiesSortedInDescendingOrder) {\n+      var type = activity.props._type;\n+\n+\n+      // Type must be Activity\n+      if (type.indexOf('Activity') !== 0) {","path":"frontend/app/services/activity-service.js","position":11,"original_position":11,"commit_id":"46f38db8acc985b22a9e5bb8c0dccffc83436156","original_commit_id":"46f38db8acc985b22a9e5bb8c0dccffc83436156","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Mixed double and single quotes.","created_at":"2015-09-17T15:08:28Z","updated_at":"2015-09-17T15:08:28Z","html_url":"https://github.com/opf/openproject/pull/3513#discussion_r39756820","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3513","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/39756820"},"html":{"href":"https://github.com/opf/openproject/pull/3513#discussion_r39756820"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3513"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3513","id":45301838,"html_url":"https://github.com/opf/openproject/pull/3513","diff_url":"https://github.com/opf/openproject/pull/3513.diff","patch_url":"https://github.com/opf/openproject/pull/3513.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3513","number":3513,"state":"open","locked":false,"title":"[16364] Work package fullscreen view","user":{"login":"basiszwo","id":24071,"avatar_url":"https://avatars.githubusercontent.com/u/24071?v=3","gravatar_id":"","url":"https://api.github.com/users/basiszwo","html_url":"https://github.com/basiszwo","followers_url":"https://api.github.com/users/basiszwo/followers","following_url":"https://api.github.com/users/basiszwo/following{/other_user}","gists_url":"https://api.github.com/users/basiszwo/gists{/gist_id}","starred_url":"https://api.github.com/users/basiszwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basiszwo/subscriptions","organizations_url":"https://api.github.com/users/basiszwo/orgs","repos_url":"https://api.github.com/users/basiszwo/repos","events_url":"https://api.github.com/users/basiszwo/events{/privacy}","received_events_url":"https://api.github.com/users/basiszwo/received_events","type":"User","site_admin":false},"body":"This PR superseeds https://github.com/opf/openproject/pull/3366\r\n\r\nSee https://community.openproject.org/work_packages/16364 for general task description (though it does not fully apply).\r\n\r\n#### Tasks\r\n\r\n- [ ] [Request-loop for non-existing work packages](https://github.com/opf/openproject/pull/3366#issuecomment-140998345)\r\n- [ ] lots of js errors when visiting work package logged out\r\n- [ ] create work package button does not work on full screen view\r\n- [ ] fullscreen button does not load first or selected work package when in list view\r\n- [ ] work package links are url escaped. this breaks opening them in new tab / window\r\n- [ ] [breadcrumb does not show project](https://github.com/opf/openproject/pull/3366#issuecomment-140994275) => project scope missing\r\n- [ ] changing the type needs to update the available fields / statuses / options\r\n* [ ] [toolbar line-breaking](https://github.com/opf/openproject/pull/3366#issuecomment-141000902) (@mk84)\r\n* [ ] [rendering of anchors](https://github.com/opf/openproject/pull/3366#issuecomment-141015332)(@mk84)\r\n* [x] [Can't change view on small resolutions](https://github.com/opf/openproject/pull/3366#issuecomment-140995420)","created_at":"2015-09-17T15:07:50Z","updated_at":"2015-09-17T15:08:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b2a9fbd61ef2d91f19461693b1f8e3f0609cd4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3513/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3513/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3513/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/46f38db8acc985b22a9e5bb8c0dccffc83436156","head":{"label":"opf:16364-fullscreen","ref":"16364-fullscreen","sha":"46f38db8acc985b22a9e5bb8c0dccffc83436156","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-09-17T06:16:40Z","pushed_at":"2015-09-17T15:08:06Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":213781,"stargazers_count":746,"watchers_count":746,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":20,"forks":304,"open_issues":20,"watchers":746,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"3907c3ae114207bee2388d77db6ecb615d4a318f","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-09-17T06:16:40Z","pushed_at":"2015-09-17T15:08:06Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":213781,"stargazers_count":746,"watchers_count":746,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":20,"forks":304,"open_issues":20,"watchers":746,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3513"},"html":{"href":"https://github.com/opf/openproject/pull/3513"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3513"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3513/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3513/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3513/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/46f38db8acc985b22a9e5bb8c0dccffc83436156"}}}}