{"action":"created","comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/37602184","id":37602184,"diff_hunk":"@@ -1,4 +1,10 @@\n source 'https://rubygems.org'\n+#\n+# Add a Gemfile.local to locally bundle gems outside of version control\n+local_gemfile = File.join(File.expand_path(\"..\", __FILE__), \"Gemfile.local\")\n+if File.readable?(local_gemfile)\n+  eval_gemfile local_gemfile\n+end","path":"Gemfile","position":7,"original_position":7,"commit_id":"0d617cdf8aa89c1d56fcb06e064964bcb5c284cf","original_commit_id":"0d617cdf8aa89c1d56fcb06e064964bcb5c284cf","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"I like using pry-byebug. This let's me do it without interfering with the project","created_at":"2015-08-21T02:43:33Z","updated_at":"2015-08-21T02:43:33Z","html_url":"https://github.com/rails-api/active_model_serializers/pull/1017#discussion_r37602184","pull_request_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/37602184"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1017#discussion_r37602184"},"pull_request":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017","id":40265764,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1017","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1017.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1017.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1017","number":1017,"state":"open","locked":false,"title":"Make Adapters registerable so they are not namespace-constrained","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n- Introduce Adapter::get for use by Serializer.adapter\r\n- Move Adapter-finding logic from Adapter::adapter_class into Adapter::get\r\n\r\nIntroduced interfaces:\r\n\r\n- non-inherited methods\r\n```ruby\r\nActiveModel::Serializer::Adapter.adapter_map  # a Hash<adapter_name, adapter_class>\r\nActiveModel::Serializer::Adapter.adapters     # an Array<adapter_name>\r\nActiveModel::Serializer::Adapter.register(name, klass) # adds an adapter to the adapter_map\r\nActiveModel::Serializer::Adapter.get(name_or_klass)    # raises Argument error when adapter not found\r\n```\r\n\r\n- Automatically register adapters when subclassing\r\n\r\n```ruby\r\n     def self.inherited(subclass)\r\n       ActiveModel::Serializer::Adapter.register(subclass.to_s.demodulize,\r\nsubclass)\r\n     end\r\n```\r\n\r\n- Preserves subclass method `::adapter_class(adapter)`\r\n\r\n```ruby\r\n     def self.adapter_class(adapter)\r\n       ActiveModel::Serializer::Adapter.get(adapter)\r\n     end\r\n```\r\n\r\n- Serializer.adapter now uses `Adapter.get(config.adapter)` rather than have\r\nduplicate logic\r\n\r\nTODO\r\n\r\nTest\r\n- [x] ActiveModel::Serializer::Adapter.adapter_map\r\n- [x] ActiveModel::Serializer::Adapter.adapters\r\n- [x] ActiveModel::Serializer::Adapter.register(name, klass)\r\n- [x] ActiveModel::Serializer::Adapter.get(name_or_klass)\r\n- [x] ActiveModel::Serializer::Adapter::inherited\r\n- [x] ActiveModel::Serializer.adapter\r\n\r\nTO CONSIDER\r\n\r\n- [x] wrap 'finding adapter by name' logic outside of 'get' method\r\n- [x] Change exception from ArgumentError to UnknownAdapter","created_at":"2015-07-17T19:54:57Z","updated_at":"2015-08-21T02:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a05dc19c9ff0f6c94d94811cd6d05a5a9f02513","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1017/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/0d617cdf8aa89c1d56fcb06e064964bcb5c284cf","head":{"label":"bf4:registerable_adapters","ref":"registerable_adapters","sha":"0d617cdf8aa89c1d56fcb06e064964bcb5c284cf","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"repo":{"id":31333715,"name":"active_model_serializers","full_name":"bf4/active_model_serializers","owner":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bf4/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/bf4/active_model_serializers","forks_url":"https://api.github.com/repos/bf4/active_model_serializers/forks","keys_url":"https://api.github.com/repos/bf4/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bf4/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bf4/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/bf4/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/bf4/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/bf4/active_model_serializers/events","assignees_url":"https://api.github.com/repos/bf4/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/bf4/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/bf4/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/bf4/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bf4/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bf4/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/bf4/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bf4/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/bf4/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/bf4/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/bf4/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/bf4/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/bf4/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/bf4/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/bf4/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/bf4/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/bf4/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/bf4/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/bf4/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bf4/active_model_serializers/merges","archive_url":"https://api.github.com/repos/bf4/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bf4/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/bf4/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/bf4/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/bf4/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/bf4/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bf4/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/bf4/active_model_serializers/releases{/id}","created_at":"2015-02-25T20:15:49Z","updated_at":"2015-02-25T20:15:50Z","pushed_at":"2015-08-21T02:36:56Z","git_url":"git://github.com/bf4/active_model_serializers.git","ssh_url":"git@github.com:bf4/active_model_serializers.git","clone_url":"https://github.com/bf4/active_model_serializers.git","svn_url":"https://github.com/bf4/active_model_serializers","homepage":"","size":1634,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"fc7b9c3c14b961564c9121bdf2553e3a2a93a320","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","created_at":"2011-12-01T06:39:26Z","updated_at":"2015-08-21T00:55:24Z","pushed_at":"2015-08-21T02:36:57Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":5676,"stargazers_count":2913,"watchers_count":2913,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"open_issues_count":145,"forks":665,"open_issues":145,"watchers":2913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1017"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1017"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/0d617cdf8aa89c1d56fcb06e064964bcb5c284cf"}}}}