{"action":"created","issue":{"url":"https://api.github.com/repos/csingley/ofxtools/issues/5","labels_url":"https://api.github.com/repos/csingley/ofxtools/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/csingley/ofxtools/issues/5/comments","events_url":"https://api.github.com/repos/csingley/ofxtools/issues/5/events","html_url":"https://github.com/csingley/ofxtools/pull/5","id":108509288,"number":5,"title":"Enhancement/automated tests","user":{"login":"turicas","id":186126,"avatar_url":"https://avatars.githubusercontent.com/u/186126?v=3","gravatar_id":"","url":"https://api.github.com/users/turicas","html_url":"https://github.com/turicas","followers_url":"https://api.github.com/users/turicas/followers","following_url":"https://api.github.com/users/turicas/following{/other_user}","gists_url":"https://api.github.com/users/turicas/gists{/gist_id}","starred_url":"https://api.github.com/users/turicas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turicas/subscriptions","organizations_url":"https://api.github.com/users/turicas/orgs","repos_url":"https://api.github.com/users/turicas/repos","events_url":"https://api.github.com/users/turicas/events{/privacy}","received_events_url":"https://api.github.com/users/turicas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-27T02:42:10Z","updated_at":"2015-09-27T05:47:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/csingley/ofxtools/pulls/5","html_url":"https://github.com/csingley/ofxtools/pull/5","diff_url":"https://github.com/csingley/ofxtools/pull/5.diff","patch_url":"https://github.com/csingley/ofxtools/pull/5.patch"},"body":"Hello, Christopher,\r\n\r\nThis pull request move old tests to an automated version, using `unittest` to describe them and `nosetests` to run (with test coverage support). Note that these tests are superficial since they don't assert many things -- they still need to be improved and automating the test running process is the first step, in my opinion. It also fixes a little bug in parsing \"investment\" OFX type (`yield` not being converted to `yld`).\r\n\r\nNote: due to the number of leading spaces on many files, I suggest you to configure your `vim` with:\r\n\r\n```vim\r\n\" Show trailing characters and undesirable spaces\r\nset list\r\nset listchars=tab:▸\\ ,trail:·,nbsp:~\r\n\r\n\" Remove trailing spaces when save buffer\r\nautocmd BufWritePre * :%s/\\s\\+$//e\r\n```"},"comment":{"url":"https://api.github.com/repos/csingley/ofxtools/issues/comments/143521982","html_url":"https://github.com/csingley/ofxtools/pull/5#issuecomment-143521982","issue_url":"https://api.github.com/repos/csingley/ofxtools/issues/5","id":143521982,"user":{"login":"turicas","id":186126,"avatar_url":"https://avatars.githubusercontent.com/u/186126?v=3","gravatar_id":"","url":"https://api.github.com/users/turicas","html_url":"https://github.com/turicas","followers_url":"https://api.github.com/users/turicas/followers","following_url":"https://api.github.com/users/turicas/following{/other_user}","gists_url":"https://api.github.com/users/turicas/gists{/gist_id}","starred_url":"https://api.github.com/users/turicas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turicas/subscriptions","organizations_url":"https://api.github.com/users/turicas/orgs","repos_url":"https://api.github.com/users/turicas/repos","events_url":"https://api.github.com/users/turicas/events{/privacy}","received_events_url":"https://api.github.com/users/turicas/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T05:47:33Z","updated_at":"2015-09-27T05:47:33Z","body":"@csingley, thanks for your response. :)\r\n\r\n- I'd like you to commit these changes about `yield` since I'm not well familiar with `ofxtools` source code. Could you please add a commit on top of my branch?\r\n- Sorry for deleting your facilities for testing with real data -- I thought it were just something like \"not automated unit tests\" and then turned them into automated ones. I can work here to create a `scripts` directory with everything we had before at `ofxtools/tests` - what do you think? I think it's a better name IMHO. ;)"}}