{"action":"created","issue":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1373","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1373/labels{/name}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1373/comments","events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1373/events","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1373","id":98588248,"number":1373,"title":"Robust Module Version Comparisons ~ Redux","user":{"login":"leycec","id":217028,"avatar_url":"https://avatars.githubusercontent.com/u/217028?v=3","gravatar_id":"","url":"https://api.github.com/users/leycec","html_url":"https://github.com/leycec","followers_url":"https://api.github.com/users/leycec/followers","following_url":"https://api.github.com/users/leycec/following{/other_user}","gists_url":"https://api.github.com/users/leycec/gists{/gist_id}","starred_url":"https://api.github.com/users/leycec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leycec/subscriptions","organizations_url":"https://api.github.com/users/leycec/orgs","repos_url":"https://api.github.com/users/leycec/repos","events_url":"https://api.github.com/users/leycec/events{/privacy}","received_events_url":"https://api.github.com/users/leycec/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels/more%20work","name":"more work","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"htgoebel","id":784161,"avatar_url":"https://avatars.githubusercontent.com/u/784161?v=3","gravatar_id":"","url":"https://api.github.com/users/htgoebel","html_url":"https://github.com/htgoebel","followers_url":"https://api.github.com/users/htgoebel/followers","following_url":"https://api.github.com/users/htgoebel/following{/other_user}","gists_url":"https://api.github.com/users/htgoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/htgoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htgoebel/subscriptions","organizations_url":"https://api.github.com/users/htgoebel/orgs","repos_url":"https://api.github.com/users/htgoebel/repos","events_url":"https://api.github.com/users/htgoebel/events{/privacy}","received_events_url":"https://api.github.com/users/htgoebel/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones/9","html_url":"https://github.com/pyinstaller/pyinstaller/milestones/PyInstaller%203.0","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones/9/labels","id":831132,"number":9,"title":"PyInstaller 3.0","description":" * Add Python 3 support\r\n * Use modulegraph library for dependency analysis.","creator":{"login":"pyinstaller-tickets-migration","id":5377465,"avatar_url":"https://avatars.githubusercontent.com/u/5377465?v=3","gravatar_id":"","url":"https://api.github.com/users/pyinstaller-tickets-migration","html_url":"https://github.com/pyinstaller-tickets-migration","followers_url":"https://api.github.com/users/pyinstaller-tickets-migration/followers","following_url":"https://api.github.com/users/pyinstaller-tickets-migration/following{/other_user}","gists_url":"https://api.github.com/users/pyinstaller-tickets-migration/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinstaller-tickets-migration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinstaller-tickets-migration/subscriptions","organizations_url":"https://api.github.com/users/pyinstaller-tickets-migration/orgs","repos_url":"https://api.github.com/users/pyinstaller-tickets-migration/repos","events_url":"https://api.github.com/users/pyinstaller-tickets-migration/events{/privacy}","received_events_url":"https://api.github.com/users/pyinstaller-tickets-migration/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":219,"state":"open","created_at":"2014-10-18T13:32:07Z","updated_at":"2015-09-27T22:28:47Z","due_on":"2015-09-29T22:00:00Z","closed_at":null},"comments":15,"created_at":"2015-08-02T06:14:58Z","updated_at":"2015-09-28T05:53:06Z","closed_at":"2015-09-27T13:41:47Z","pull_request":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1373","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1373","diff_url":"https://github.com/pyinstaller/pyinstaller/pull/1373.diff","patch_url":"https://github.com/pyinstaller/pyinstaller/pull/1373.patch"},"body":"I'm all out of bubblegum. *Again.*\r\n\r\n@htgoebels [astutely noted](https://github.com/pyinstaller/pyinstaller/pull/1368#discussion_r36033479) that the current implementation of `is_module_version()` ignores the existence of the standard `operator` module and is thus bonkers. He's right. He's Hartmut!\r\n\r\nThis pull request refactors `is_module_version()` to accept a comparison function (e.g., `operator.ge`) rather than a string merely _describing_ a comparison function (e.g., `\">=\"`). Wut wuz I thinking? Only [Gyango](http://ultra.wikia.com/wiki/Gango) knows.\r\n\r\n![image](http://vignette4.wikia.nocookie.net/ultra/images/a/a2/Gango.png/revision/latest?cb=20130924111611)\r\n\r\n# That All You Got?\r\n\r\n**Nope.**\r\n\r\nThe Sphinx hook unnecessarily added the `alabaster` and `sphinx_rtd_theme` modules to the `hiddenimports` list. Since this hook already adds the `sphinx.builders.changes` module, which imports from the `sphinx.themes` module via `import()` rather than `__import__()`, which unconditionally imports the `alabaster` and `sphinx_rtd_theme` modules again via `import()` rather than `__import__()`, the latter two modules need _not_ be listed as hidden imports.\r\n\r\nSo, we don't.\r\n\r\nI've also cleaned up inline commentary in the Sphinx hook. Just... *because*.\r\n\r\n# That Had Better Be It.\r\n\r\nIt is! You may celebrate by rewatching \"Ultraman: Season One,\" everyone."},"comment":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/comments/143645998","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1373#issuecomment-143645998","issue_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1373","id":143645998,"user":{"login":"leycec","id":217028,"avatar_url":"https://avatars.githubusercontent.com/u/217028?v=3","gravatar_id":"","url":"https://api.github.com/users/leycec","html_url":"https://github.com/leycec","followers_url":"https://api.github.com/users/leycec/followers","following_url":"https://api.github.com/users/leycec/following{/other_user}","gists_url":"https://api.github.com/users/leycec/gists{/gist_id}","starred_url":"https://api.github.com/users/leycec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leycec/subscriptions","organizations_url":"https://api.github.com/users/leycec/orgs","repos_url":"https://api.github.com/users/leycec/repos","events_url":"https://api.github.com/users/leycec/events{/privacy}","received_events_url":"https://api.github.com/users/leycec/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T05:53:05Z","updated_at":"2015-09-28T05:53:05Z","body":"Ah, right. No worries! This pull request fell by the wayside, thanks to #1367 (A.K.A., the Pit of Doom). After implementing consensus, I'll repackage this for the one true `develop` branch.\r\n\r\nHere's lookin' at you, 3.1 milestone. :moyai: "}}