{"action":"created","issue":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7049","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7049/labels{/name}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7049/comments","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7049/events","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7049","id":59249421,"number":7049,"title":"HPCC-11917 Full keyed joins fail or worse unless key was remote","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-27T15:20:21Z","updated_at":"2015-02-27T15:24:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7049","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7049","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7049.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7049.patch"},"body":"If the key file was remote (not part of cluster the query is\r\nrunning on), then instead of sending the key fetch request to\r\nthe node in the local cluster which has the fetch part locally,\r\nit should access the fetch directly from the requesting slaves.\r\nHowever, for that to work, each slave had to have the full set\r\nof fetch parts and correctly map the fpos to the correct part.\r\n\r\nThat logic was misisng, this PR detects if fetch file is remote\r\nand ensures all slaves have access to all parts.\r\n\r\nAlso, unless the master happened to be on the same IP as slave 1,\r\nit incorrectly thought the key was remote and failed for the\r\nreasons above.\r\n\r\nThe upshot of above, was that Full Keyed Joins were essentially\r\nbroken unless running on a thor cluster with slaves on same IP\r\nas master.\r\n\r\nSigned-off-by: Jake Smith <jake.smith@lexisnexis.com>"},"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/76411269","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7049#issuecomment-76411269","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7049","id":76411269,"user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T15:24:36Z","updated_at":"2015-02-27T15:24:36Z","body":"Not sure that I feel this is appropriate for 5.0.6 - it's a relatively large change, it's not a regression (has been broken forever) in a feature that no-one uses... I think I'd be happier with 5.2.0 at this juncture"}}