{"action":"created","issue":{"url":"https://api.github.com/repos/agnwinds/python/issues/176","labels_url":"https://api.github.com/repos/agnwinds/python/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/agnwinds/python/issues/176/comments","events_url":"https://api.github.com/repos/agnwinds/python/issues/176/events","html_url":"https://github.com/agnwinds/python/issues/176","id":108122589,"number":176,"title":"large number of sane_check errors in pop_kappa_ff_array","user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/agnwinds/python/labels/admin","name":"admin","color":"f7c6c7"},{"url":"https://api.github.com/repos/agnwinds/python/labels/bug","name":"bug","color":"207de5"},{"url":"https://api.github.com/repos/agnwinds/python/labels/high","name":"high","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/agnwinds/python/milestones/4","html_url":"https://github.com/agnwinds/python/milestones/Next%20AGN%20paper","labels_url":"https://api.github.com/repos/agnwinds/python/milestones/4/labels","id":967261,"number":4,"title":"Next AGN paper","description":"","creator":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2015-02-05T15:47:02Z","updated_at":"2015-09-24T12:42:49Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-09-24T12:42:49Z","updated_at":"2015-11-27T11:58:28Z","closed_at":null,"body":"When running QSO models with Helium macro-atoms turned on, I get large numbers of the following error\r\n\r\n```\r\npop_kappa_ff_array:sane_check sum is -nan this is a problem, possible in gaunt %3\r\n```\r\n\r\nThis function calculates a prefactor for free-free heating/cooling calculations in advance, as the prefactor depends only on ion densityies temperature and physical constants.\r\n\r\nI think there are a few issues here:\r\n\r\n* first, something fairly drastic is clearly going wrong in the Helium matom runs, possibly related to having low photon numbers and trying to solve all those level populations. My bet is the reason this particular happens is a knock on effect from something else, rather than a direct problem with the pop_kappa_ff_array() function.\r\n\r\n* which makes me think that there is probably somewhere earlier in the code where really a fatal error should have been caught. I will debug at some point to figure out where.\r\n\r\n* thirdly, it reminds me that there are many places in the code where Error messages might tell *us* what is going on, but wouldn't tell a *user*. If we want to public release this code, then this is a pretty major thing to sort in my opinion. Errors should probably be informative enough so a user knows what they have done wrong or need to change/report- I think we are probably all guilty of making our Error messages a little specialised."},"comment":{"url":"https://api.github.com/repos/agnwinds/python/issues/comments/160123694","html_url":"https://github.com/agnwinds/python/issues/176#issuecomment-160123694","issue_url":"https://api.github.com/repos/agnwinds/python/issues/176","id":160123694,"user":{"login":"lazygun37","id":4816000,"avatar_url":"https://avatars.githubusercontent.com/u/4816000?v=3","gravatar_id":"","url":"https://api.github.com/users/lazygun37","html_url":"https://github.com/lazygun37","followers_url":"https://api.github.com/users/lazygun37/followers","following_url":"https://api.github.com/users/lazygun37/following{/other_user}","gists_url":"https://api.github.com/users/lazygun37/gists{/gist_id}","starred_url":"https://api.github.com/users/lazygun37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazygun37/subscriptions","organizations_url":"https://api.github.com/users/lazygun37/orgs","repos_url":"https://api.github.com/users/lazygun37/repos","events_url":"https://api.github.com/users/lazygun37/events{/privacy}","received_events_url":"https://api.github.com/users/lazygun37/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T11:58:28Z","updated_at":"2015-11-27T11:58:28Z","body":"Just two quick points:\r\n\r\n1) It seems to me that your final question may be the first one we should sort out, because I just can't see how that's anything other than a bug. Orders of magnitude changes in density across cell boundaries just shouldn't occur if our gridding is resolving the wind reasonably well.The fact that these crazy low densities only occur in \"partial\" cells -- correct? -- also suggests this is a bug. In particular, it suggests that we are somehow not correctly setting up the conditions in these cells, i.e. our interpolation/extrapolation/weighting is going wrong.\r\n\r\n2) Is it possible that the error itself is \"physical\", in the sense that there are physical processes that we have not implemented, but that would dominate in the (weird) regime that's occurring in these cells?"}}