{"comment":{"url":"https://api.github.com/repos/FransUrbo/zfs/comments/11391309","html_url":"https://github.com/FransUrbo/zfs/commit/87c30f261b02f902916d23b166699a07c124b7e0#commitcomment-11391309","id":11391309,"user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"position":41,"line":41,"path":"etc/init.d/common.init.in","commit_id":"87c30f261b02f902916d23b166699a07c124b7e0","created_at":"2015-05-27T17:54:28Z","updated_at":"2015-05-27T17:54:28Z","body":"Your right, it does work.  What happened in my testing is `/etc/zfs/common.init` wasn't replaced with the latest version because it's marked with `%config(noreplace)` in the spec file.  This is definitely a redhat packing issue.  It's my understanding the init scripts themselves should be replaced, but config files like `/etc/defaults/zfs` should not.\r\n\r\nWhat do you think about renaming `/etc/zfs/common.init` to `/etc/init.d/zfs-functions`.  On CentOS systems there already exists an  `/etc/init.d/functions` with support functions so this might be more appropriate."}}