{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/9652","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/9652/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/9652/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/9652/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/9652","id":13178808,"number":9652,"title":"[3.3.5a] Abilities/talents based on stats don't update when stats do","user":{"login":"Loginisalreadytaken","id":829395,"avatar_url":"https://avatars.githubusercontent.com/u/829395?v=3","gravatar_id":"","url":"https://api.github.com/users/Loginisalreadytaken","html_url":"https://github.com/Loginisalreadytaken","followers_url":"https://api.github.com/users/Loginisalreadytaken/followers","following_url":"https://api.github.com/users/Loginisalreadytaken/following{/other_user}","gists_url":"https://api.github.com/users/Loginisalreadytaken/gists{/gist_id}","starred_url":"https://api.github.com/users/Loginisalreadytaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Loginisalreadytaken/subscriptions","organizations_url":"https://api.github.com/users/Loginisalreadytaken/orgs","repos_url":"https://api.github.com/users/Loginisalreadytaken/repos","events_url":"https://api.github.com/users/Loginisalreadytaken/events{/privacy}","received_events_url":"https://api.github.com/users/Loginisalreadytaken/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Branch-3.3.5a","name":"Branch-3.3.5a","color":"188846"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Legacy","name":"Legacy","color":"663300"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Spells","name":"Sub-Spells","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2013-04-14T21:03:02Z","updated_at":"2015-05-13T23:24:17Z","closed_at":null,"body":"http://old.wowhead.com/spell=35693 (Demonic Knowledge)\r\nhttp://old.wowhead.com/spell=30482 (Molten Armor)\r\n\r\nI had suspected this for a while but did some testing now and it looks like an issue to me.\r\nWith demonology talents and a felguard:\r\n- No timer buffs on either of us, the warlock's bonus spell damage is at __3382__ (demon's stamina/intellect at 1627/738) - using Metamorphosis and Immolation Aura, all the ticks are at __1670__.\r\n- With Runescroll of Fortitude (165 stamina on both), Drums of the Wild (37/37 on both), Drums of Forgotten Kings (8% on both), Scroll of Intellect VII (32 int on demon), the warlock's bonus spell damage is at __3382__ (demon's stamina/intellect at 2187/895) - using Metamorphosis and Immolation Aura, all the ticks are at __1670__.\r\n- Mount, dismount, the warlock's bonus spell damage is at __3468__ - using Metamorphosis and Immolation Aura, all the ticks are at __1696__.\r\n\r\nNow, resummoning is very difficult in raids (no mounting) but in some cases it's possible to send the demon so far away that it despawns. If I dismiss, it loses all buffs.\r\nI also suspect (not sure, though) that when the demon already has a buff and people reapply that buff, the spell damage bonus is lost.. or who knows? Maybe it's not lost when the demon loses a buff for any reason (other than dying because then Demonic Knowledge goes as well).\r\n\r\nAt first, I thought that maybe it was only a display error, but after the test and damage done, I'm sure it's not.\r\n\r\nFor mages, I did no testing but I know that the Molten Armor effect does not update the critical strike rating when people buff - this is easily fixable by casting Molten Armor after all buffs are applied.\r\n\r\nIt wouldn't surprise me if there are a bunch of set bonuses, glyphs, talents for other classes that also don't update (up or down) when stats change.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/244961-3-3-5a-abilities-talents-based-on-stats-don-t-update-when-stats-do?utm_campaign=plugin&utm_content=tracker%2F1310&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1310&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/101847113","html_url":"https://github.com/TrinityCore/TrinityCore/issues/9652#issuecomment-101847113","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/9652","id":101847113,"user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T23:24:17Z","updated_at":"2015-05-13T23:24:17Z","body":"> I will test it as soon as possible! Thank you for your work! :)\r\n\r\nDon't thank me too soon. Nothing is ready yet, unless you complete it yourself.\r\nIf you try using code from the sample above, you will not be able to compile it."}}