{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/29819107","id":29819107,"diff_hunk":"@@ -316,28 +338,131 @@ public void run() {\n                 final Bitmap capturedBitmap = generateBitmap(byteArray, width,\n                         height);\n                 callback.onScreenCaptured(capturedBitmap);\n+                capturedBitmap.recycle();","path":"GVRf/Framework/src/org/gearvrf/GVRViewManager.java","position":61,"original_position":61,"commit_id":"8d781e21a2c5a7bb0733110995d8e9b3409781e8","original_commit_id":"8d781e21a2c5a7bb0733110995d8e9b3409781e8","user":{"login":"JonShemitz","id":11304782,"avatar_url":"https://avatars.githubusercontent.com/u/11304782?v=3","gravatar_id":"","url":"https://api.github.com/users/JonShemitz","html_url":"https://github.com/JonShemitz","followers_url":"https://api.github.com/users/JonShemitz/followers","following_url":"https://api.github.com/users/JonShemitz/following{/other_user}","gists_url":"https://api.github.com/users/JonShemitz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonShemitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonShemitz/subscriptions","organizations_url":"https://api.github.com/users/JonShemitz/orgs","repos_url":"https://api.github.com/users/JonShemitz/repos","events_url":"https://api.github.com/users/JonShemitz/events{/privacy}","received_events_url":"https://api.github.com/users/JonShemitz/received_events","type":"User","site_admin":false},"body":"Oh, please don't do this! It's harmless (though not necessary) if (and only if) the app does not use the `Bitmap` after the callback returns - but you have no way of knowing that this is the case! The app may do _anything_ besides save-to-disk-during-the-callback - imagine the app uploads the screenshot to a queue of images to be sent to a server somewhere,which is being consumed by Yet Another thread.","created_at":"2015-05-07T01:48:00Z","updated_at":"2015-05-07T01:48:00Z","html_url":"https://github.com/Samsung/GearVRf/pull/34#discussion_r29819107","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/29819107"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/34#discussion_r29819107"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/34","id":34383007,"html_url":"https://github.com/Samsung/GearVRf/pull/34","diff_url":"https://github.com/Samsung/GearVRf/pull/34.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/34.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/34","number":34,"state":"open","locked":false,"title":"Add 3D screenshot API.","user":{"login":"rongguodong","id":11858549,"avatar_url":"https://avatars.githubusercontent.com/u/11858549?v=3","gravatar_id":"","url":"https://api.github.com/users/rongguodong","html_url":"https://github.com/rongguodong","followers_url":"https://api.github.com/users/rongguodong/followers","following_url":"https://api.github.com/users/rongguodong/following{/other_user}","gists_url":"https://api.github.com/users/rongguodong/gists{/gist_id}","starred_url":"https://api.github.com/users/rongguodong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongguodong/subscriptions","organizations_url":"https://api.github.com/users/rongguodong/orgs","repos_url":"https://api.github.com/users/rongguodong/repos","events_url":"https://api.github.com/users/rongguodong/events{/privacy}","received_events_url":"https://api.github.com/users/rongguodong/received_events","type":"User","site_admin":false},"body":"Also added a new GVRF sample to test the result of 3D screenshot (by using 6 2D textures).\r\n\r\ngvr-sample shows how to use the new API to capture 3D screenshot and save it as six images.\r\ngvr-test-screenshot3Dresult tests the screenshot result by mapping the six images to a cube.","created_at":"2015-04-29T16:51:50Z","updated_at":"2015-05-07T01:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"018597ca5e5377eb4efdac129e2a3c29f28fd43f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/34/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/8d781e21a2c5a7bb0733110995d8e9b3409781e8","head":{"label":"rongguodong:sreenshot3D","ref":"sreenshot3D","sha":"8d781e21a2c5a7bb0733110995d8e9b3409781e8","user":{"login":"rongguodong","id":11858549,"avatar_url":"https://avatars.githubusercontent.com/u/11858549?v=3","gravatar_id":"","url":"https://api.github.com/users/rongguodong","html_url":"https://github.com/rongguodong","followers_url":"https://api.github.com/users/rongguodong/followers","following_url":"https://api.github.com/users/rongguodong/following{/other_user}","gists_url":"https://api.github.com/users/rongguodong/gists{/gist_id}","starred_url":"https://api.github.com/users/rongguodong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongguodong/subscriptions","organizations_url":"https://api.github.com/users/rongguodong/orgs","repos_url":"https://api.github.com/users/rongguodong/repos","events_url":"https://api.github.com/users/rongguodong/events{/privacy}","received_events_url":"https://api.github.com/users/rongguodong/received_events","type":"User","site_admin":false},"repo":{"id":33624314,"name":"GearVRf","full_name":"rongguodong/GearVRf","owner":{"login":"rongguodong","id":11858549,"avatar_url":"https://avatars.githubusercontent.com/u/11858549?v=3","gravatar_id":"","url":"https://api.github.com/users/rongguodong","html_url":"https://github.com/rongguodong","followers_url":"https://api.github.com/users/rongguodong/followers","following_url":"https://api.github.com/users/rongguodong/following{/other_user}","gists_url":"https://api.github.com/users/rongguodong/gists{/gist_id}","starred_url":"https://api.github.com/users/rongguodong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongguodong/subscriptions","organizations_url":"https://api.github.com/users/rongguodong/orgs","repos_url":"https://api.github.com/users/rongguodong/repos","events_url":"https://api.github.com/users/rongguodong/events{/privacy}","received_events_url":"https://api.github.com/users/rongguodong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rongguodong/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/rongguodong/GearVRf","forks_url":"https://api.github.com/repos/rongguodong/GearVRf/forks","keys_url":"https://api.github.com/repos/rongguodong/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rongguodong/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rongguodong/GearVRf/teams","hooks_url":"https://api.github.com/repos/rongguodong/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/rongguodong/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/rongguodong/GearVRf/events","assignees_url":"https://api.github.com/repos/rongguodong/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/rongguodong/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/rongguodong/GearVRf/tags","blobs_url":"https://api.github.com/repos/rongguodong/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rongguodong/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rongguodong/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rongguodong/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rongguodong/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/rongguodong/GearVRf/languages","stargazers_url":"https://api.github.com/repos/rongguodong/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/rongguodong/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/rongguodong/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/rongguodong/GearVRf/subscription","commits_url":"https://api.github.com/repos/rongguodong/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rongguodong/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rongguodong/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rongguodong/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rongguodong/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/rongguodong/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rongguodong/GearVRf/merges","archive_url":"https://api.github.com/repos/rongguodong/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rongguodong/GearVRf/downloads","issues_url":"https://api.github.com/repos/rongguodong/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/rongguodong/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/rongguodong/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/rongguodong/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rongguodong/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/rongguodong/GearVRf/releases{/id}","created_at":"2015-04-08T18:22:41Z","updated_at":"2015-04-29T16:46:35Z","pushed_at":"2015-05-06T23:57:19Z","git_url":"git://github.com/rongguodong/GearVRf.git","ssh_url":"git@github.com:rongguodong/GearVRf.git","clone_url":"https://github.com/rongguodong/GearVRf.git","svn_url":"https://github.com/rongguodong/GearVRf","homepage":"http://www.gearvrf.org","size":195443,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"615c23f7cbde75f6156a8437a1140324b1cc5df8","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","created_at":"2015-03-25T02:02:18Z","updated_at":"2015-05-04T11:15:55Z","pushed_at":"2015-05-06T23:57:20Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":198589,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":13,"forks":18,"open_issues":13,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/34"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/34"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/34"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/8d781e21a2c5a7bb0733110995d8e9b3409781e8"}}}}