{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/34423648","id":34423648,"diff_hunk":"@@ -341,15 +341,15 @@ ResultStatus AppLoader_ELF::Load() {\n     if (is_loaded)\n         return ResultStatus::ErrorAlreadyLoaded;\n \n-    if (!file->IsOpen())\n+    if (!file.IsOpen())\n         return ResultStatus::Error;\n \n     // Reset read pointer in case this file has been read before.\n-    file->Seek(0, SEEK_SET);\n+    file.Seek(0, SEEK_SET);\n \n-    u32 size = static_cast<u32>(file->GetSize());\n+    u32 size = static_cast<u32>(file.GetSize());","path":"src/core/loader/elf.cpp","position":13,"original_position":13,"commit_id":"b589ec44cf61289ddc7305f1f5482068a9b86736","original_commit_id":"b589ec44cf61289ddc7305f1f5482068a9b86736","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2015-07-12T17:37:01Z","updated_at":"2015-07-12T17:37:01Z","html_url":"https://github.com/citra-emu/citra/pull/918#discussion_r34423648","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/918","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/34423648"},"html":{"href":"https://github.com/citra-emu/citra/pull/918#discussion_r34423648"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/918","id":39753262,"html_url":"https://github.com/citra-emu/citra/pull/918","diff_url":"https://github.com/citra-emu/citra/pull/918.diff","patch_url":"https://github.com/citra-emu/citra/pull/918.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/918","number":918,"state":"open","locked":false,"title":"Do not load entire RomFS to memory, read from the file as needed instead (rebased)","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"body":"This is a rebase of #911.\r\n\r\nI also added an unrelated extra cleanup to related parts of the code.","created_at":"2015-07-11T22:22:16Z","updated_at":"2015-07-12T17:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d28a737c632304c3eca8571409019e2b4f1e2fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/918/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/918/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/918/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/b589ec44cf61289ddc7305f1f5482068a9b86736","head":{"label":"yuriks:romfs","ref":"romfs","sha":"b589ec44cf61289ddc7305f1f5482068a9b86736","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"repo":{"id":22018631,"name":"citra","full_name":"yuriks/citra","owner":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuriks/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/yuriks/citra","forks_url":"https://api.github.com/repos/yuriks/citra/forks","keys_url":"https://api.github.com/repos/yuriks/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuriks/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuriks/citra/teams","hooks_url":"https://api.github.com/repos/yuriks/citra/hooks","issue_events_url":"https://api.github.com/repos/yuriks/citra/issues/events{/number}","events_url":"https://api.github.com/repos/yuriks/citra/events","assignees_url":"https://api.github.com/repos/yuriks/citra/assignees{/user}","branches_url":"https://api.github.com/repos/yuriks/citra/branches{/branch}","tags_url":"https://api.github.com/repos/yuriks/citra/tags","blobs_url":"https://api.github.com/repos/yuriks/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuriks/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuriks/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuriks/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuriks/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/yuriks/citra/languages","stargazers_url":"https://api.github.com/repos/yuriks/citra/stargazers","contributors_url":"https://api.github.com/repos/yuriks/citra/contributors","subscribers_url":"https://api.github.com/repos/yuriks/citra/subscribers","subscription_url":"https://api.github.com/repos/yuriks/citra/subscription","commits_url":"https://api.github.com/repos/yuriks/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuriks/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuriks/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuriks/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuriks/citra/contents/{+path}","compare_url":"https://api.github.com/repos/yuriks/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuriks/citra/merges","archive_url":"https://api.github.com/repos/yuriks/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuriks/citra/downloads","issues_url":"https://api.github.com/repos/yuriks/citra/issues{/number}","pulls_url":"https://api.github.com/repos/yuriks/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/yuriks/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/yuriks/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuriks/citra/labels{/name}","releases_url":"https://api.github.com/repos/yuriks/citra/releases{/id}","created_at":"2014-07-19T20:23:37Z","updated_at":"2015-02-28T02:10:18Z","pushed_at":"2015-07-12T03:07:51Z","git_url":"git://github.com/yuriks/citra.git","ssh_url":"git@github.com:yuriks/citra.git","clone_url":"https://github.com/yuriks/citra.git","svn_url":"https://github.com/yuriks/citra","homepage":null,"size":10036,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"a81991aa68658cc74a0f11203f4a23a5afea3d17","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-07-12T01:12:00Z","pushed_at":"2015-07-12T16:09:30Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":21026,"stargazers_count":965,"watchers_count":965,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":82,"forks":244,"open_issues":82,"watchers":965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/918"},"html":{"href":"https://github.com/citra-emu/citra/pull/918"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/918"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/b589ec44cf61289ddc7305f1f5482068a9b86736"}}}}