{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/36674041","id":36674041,"diff_hunk":"@@ -519,6 +519,11 @@ class SparseMatrix(\n       rowIndices: Array[Int],\n       values: Array[Double]) = this(numRows, numCols, colPtrs, rowIndices, values, false)\n \n+  override def equals(o: Any): Boolean = o match {\n+    case m: SparseMatrix => toBreeze == m.toBreeze","path":"mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala","position":5,"original_position":5,"commit_id":"78f942662cf01a60d52b3fa6fb7b9e5aaae194d2","original_commit_id":"78f942662cf01a60d52b3fa6fb7b9e5aaae194d2","user":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"body":"This case should be for Matrix, not just SparseMatrix.","created_at":"2015-08-10T19:32:59Z","updated_at":"2015-08-10T19:32:59Z","html_url":"https://github.com/apache/spark/pull/8042#discussion_r36674041","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8042","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/36674041"},"html":{"href":"https://github.com/apache/spark/pull/8042#discussion_r36674041"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8042"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8042","id":41938167,"html_url":"https://github.com/apache/spark/pull/8042","diff_url":"https://github.com/apache/spark/pull/8042.diff","patch_url":"https://github.com/apache/spark/pull/8042.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8042","number":8042,"state":"open","locked":false,"title":"[SPARK-9750][MLlib] Add equals to SparseMatrix","user":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"body":"Adds unit test for `equals` on `mllib.linalg.Matrix` class and `equals` to `SparseMatrix` which compares the `toBreeze` representation.\r\n\r\n@mengxr ","created_at":"2015-08-07T22:11:05Z","updated_at":"2015-08-10T19:32:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dc3519d9a7a777c24fea596c258f50fb1290c7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8042/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8042/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8042/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/78f942662cf01a60d52b3fa6fb7b9e5aaae194d2","head":{"label":"feynmanliang:SPARK-9750","ref":"SPARK-9750","sha":"78f942662cf01a60d52b3fa6fb7b9e5aaae194d2","user":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"repo":{"id":31143142,"name":"spark","full_name":"feynmanliang/spark","owner":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feynmanliang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/feynmanliang/spark","forks_url":"https://api.github.com/repos/feynmanliang/spark/forks","keys_url":"https://api.github.com/repos/feynmanliang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feynmanliang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feynmanliang/spark/teams","hooks_url":"https://api.github.com/repos/feynmanliang/spark/hooks","issue_events_url":"https://api.github.com/repos/feynmanliang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/feynmanliang/spark/events","assignees_url":"https://api.github.com/repos/feynmanliang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/feynmanliang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/feynmanliang/spark/tags","blobs_url":"https://api.github.com/repos/feynmanliang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feynmanliang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feynmanliang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/feynmanliang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feynmanliang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/feynmanliang/spark/languages","stargazers_url":"https://api.github.com/repos/feynmanliang/spark/stargazers","contributors_url":"https://api.github.com/repos/feynmanliang/spark/contributors","subscribers_url":"https://api.github.com/repos/feynmanliang/spark/subscribers","subscription_url":"https://api.github.com/repos/feynmanliang/spark/subscription","commits_url":"https://api.github.com/repos/feynmanliang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/feynmanliang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/feynmanliang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/feynmanliang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/feynmanliang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/feynmanliang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feynmanliang/spark/merges","archive_url":"https://api.github.com/repos/feynmanliang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feynmanliang/spark/downloads","issues_url":"https://api.github.com/repos/feynmanliang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/feynmanliang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/feynmanliang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/feynmanliang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feynmanliang/spark/labels{/name}","releases_url":"https://api.github.com/repos/feynmanliang/spark/releases{/id}","created_at":"2015-02-21T22:13:57Z","updated_at":"2015-02-21T22:14:17Z","pushed_at":"2015-08-10T17:18:49Z","git_url":"git://github.com/feynmanliang/spark.git","ssh_url":"git@github.com:feynmanliang/spark.git","clone_url":"https://github.com/feynmanliang/spark.git","svn_url":"https://github.com/feynmanliang/spark","homepage":null,"size":116013,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e2fbbe73111d4624390f596a19a1799c86a05f6c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-08-10T19:07:34Z","pushed_at":"2015-08-10T19:32:55Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1598122,"stargazers_count":5031,"watchers_count":5031,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4583,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":329,"forks":4583,"open_issues":329,"watchers":5031,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8042"},"html":{"href":"https://github.com/apache/spark/pull/8042"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8042"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8042/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8042/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8042/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/78f942662cf01a60d52b3fa6fb7b9e5aaae194d2"}}}}