{"action":"created","comment":{"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments/37478549","id":37478549,"diff_hunk":"@@ -189,17 +279,106 @@ def set_isolation_level(self, connection, level):\n \n         connection.set_isolation_level(level)\n \n-    def _get_column_info(self, *args, **kwargs):\n+    def _get_column_info(self, col, domains):","path":"redshift_sqlalchemy/dialect.py","position":194,"original_position":170,"commit_id":"56f6474b3c94fd8b48516f0b749b84a3db278d40","original_commit_id":"8bafbf43d814af8f2a3d50d3bb5a83be3b5b81e1","user":{"login":"thisfred","id":32273,"avatar_url":"https://avatars.githubusercontent.com/u/32273?v=3","gravatar_id":"","url":"https://api.github.com/users/thisfred","html_url":"https://github.com/thisfred","followers_url":"https://api.github.com/users/thisfred/followers","following_url":"https://api.github.com/users/thisfred/following{/other_user}","gists_url":"https://api.github.com/users/thisfred/gists{/gist_id}","starred_url":"https://api.github.com/users/thisfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisfred/subscriptions","organizations_url":"https://api.github.com/users/thisfred/orgs","repos_url":"https://api.github.com/users/thisfred/repos","events_url":"https://api.github.com/users/thisfred/events{/privacy}","received_events_url":"https://api.github.com/users/thisfred/received_events","type":"User","site_admin":false},"body":"I intensely dislike *args and **kwargs. They can't always be avoided, but if they can I think it improves code readability and debugability.","created_at":"2015-08-19T22:52:30Z","updated_at":"2015-08-19T22:52:30Z","html_url":"https://github.com/graingert/redshift_sqlalchemy/pull/17#discussion_r37478549","pull_request_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments/37478549"},"html":{"href":"https://github.com/graingert/redshift_sqlalchemy/pull/17#discussion_r37478549"},"pull_request":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17","id":42850177,"html_url":"https://github.com/graingert/redshift_sqlalchemy/pull/17","diff_url":"https://github.com/graingert/redshift_sqlalchemy/pull/17.diff","patch_url":"https://github.com/graingert/redshift_sqlalchemy/pull/17.patch","issue_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/17","number":17,"state":"open","locked":false,"title":"WIP: Introspection support","user":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"Also adds support for interleaved keys and improvements for `identity` columns.","created_at":"2015-08-19T18:51:46Z","updated_at":"2015-08-19T22:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03f107b47c59489963642383ed74f3d793a95a75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17/commits","review_comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17/comments","review_comment_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/17/comments","statuses_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/56f6474b3c94fd8b48516f0b749b84a3db278d40","head":{"label":"jklukas:master","ref":"master","sha":"56f6474b3c94fd8b48516f0b749b84a3db278d40","user":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"repo":{"id":41047665,"name":"redshift_sqlalchemy","full_name":"jklukas/redshift_sqlalchemy","owner":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklukas/redshift_sqlalchemy","description":"Amazon Redshift SQLAlchemy Dialect","fork":true,"url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy","forks_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/forks","keys_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/teams","hooks_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/events","assignees_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/tags","blobs_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/subscription","commits_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/merges","archive_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/downloads","issues_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/jklukas/redshift_sqlalchemy/releases{/id}","created_at":"2015-08-19T16:59:31Z","updated_at":"2015-08-19T16:59:32Z","pushed_at":"2015-08-19T21:36:48Z","git_url":"git://github.com/jklukas/redshift_sqlalchemy.git","ssh_url":"git@github.com:jklukas/redshift_sqlalchemy.git","clone_url":"https://github.com/jklukas/redshift_sqlalchemy.git","svn_url":"https://github.com/jklukas/redshift_sqlalchemy","homepage":null,"size":483,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graingert:master","ref":"master","sha":"232ea93bc995b0432d2df4abe2f592654653389d","user":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"repo":{"id":35280897,"name":"redshift_sqlalchemy","full_name":"graingert/redshift_sqlalchemy","owner":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graingert/redshift_sqlalchemy","description":"Amazon Redshift SQLAlchemy Dialect","fork":true,"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy","forks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/forks","keys_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/teams","hooks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/events","assignees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/tags","blobs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscription","commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/merges","archive_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/downloads","issues_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/releases{/id}","created_at":"2015-05-08T13:29:24Z","updated_at":"2015-08-10T22:14:18Z","pushed_at":"2015-08-19T21:36:48Z","git_url":"git://github.com/graingert/redshift_sqlalchemy.git","ssh_url":"git@github.com:graingert/redshift_sqlalchemy.git","clone_url":"https://github.com/graingert/redshift_sqlalchemy.git","svn_url":"https://github.com/graingert/redshift_sqlalchemy","homepage":null,"size":312,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17"},"html":{"href":"https://github.com/graingert/redshift_sqlalchemy/pull/17"},"issue":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/17"},"comments":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/56f6474b3c94fd8b48516f0b749b84a3db278d40"}}}}