{"action":"created","issue":{"url":"https://api.github.com/repos/unbit/uwsgi/issues/1087","labels_url":"https://api.github.com/repos/unbit/uwsgi/issues/1087/labels{/name}","comments_url":"https://api.github.com/repos/unbit/uwsgi/issues/1087/comments","events_url":"https://api.github.com/repos/unbit/uwsgi/issues/1087/events","html_url":"https://github.com/unbit/uwsgi/pull/1087","id":113717742,"number":1087,"title":"Eliminate blind excepts","user":{"login":"jstasiak","id":36209,"avatar_url":"https://avatars.githubusercontent.com/u/36209?v=3","gravatar_id":"","url":"https://api.github.com/users/jstasiak","html_url":"https://github.com/jstasiak","followers_url":"https://api.github.com/users/jstasiak/followers","following_url":"https://api.github.com/users/jstasiak/following{/other_user}","gists_url":"https://api.github.com/users/jstasiak/gists{/gist_id}","starred_url":"https://api.github.com/users/jstasiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstasiak/subscriptions","organizations_url":"https://api.github.com/users/jstasiak/orgs","repos_url":"https://api.github.com/users/jstasiak/repos","events_url":"https://api.github.com/users/jstasiak/events{/privacy}","received_events_url":"https://api.github.com/users/jstasiak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-28T00:30:59Z","updated_at":"2015-11-03T09:35:52Z","closed_at":"2015-11-03T09:35:41Z","pull_request":{"url":"https://api.github.com/repos/unbit/uwsgi/pulls/1087","html_url":"https://github.com/unbit/uwsgi/pull/1087","diff_url":"https://github.com/unbit/uwsgi/pull/1087.diff","patch_url":"https://github.com/unbit/uwsgi/pull/1087.patch"},"body":"I don't think any of the blind excepts in this code matters as far as\r\nreliability is concerned but I believe it's worth making the code more\r\nexplicit even if it's only for the educational value or in case someone\r\nuses the code as an example.\r\n\r\n* Where I was fairly certain what exception is expected I replaced\r\n  \"except:\" with \"except SomeConcreteClass:\" (or otherwise simplified\r\n  the code)\r\n* Where I wasn't sure what exaclty is being expected I just put\r\n  \"except Exception:\" to at least skip the \"special\" exceptions\r\n* Two remaining cases I replaced with \"except BaseException:\" which I\r\n  believe makes the code tiny bit more explicit."},"comment":{"url":"https://api.github.com/repos/unbit/uwsgi/issues/comments/153298425","html_url":"https://github.com/unbit/uwsgi/pull/1087#issuecomment-153298425","issue_url":"https://api.github.com/repos/unbit/uwsgi/issues/1087","id":153298425,"user":{"login":"xrmx","id":12932,"avatar_url":"https://avatars.githubusercontent.com/u/12932?v=3","gravatar_id":"","url":"https://api.github.com/users/xrmx","html_url":"https://github.com/xrmx","followers_url":"https://api.github.com/users/xrmx/followers","following_url":"https://api.github.com/users/xrmx/following{/other_user}","gists_url":"https://api.github.com/users/xrmx/gists{/gist_id}","starred_url":"https://api.github.com/users/xrmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrmx/subscriptions","organizations_url":"https://api.github.com/users/xrmx/orgs","repos_url":"https://api.github.com/users/xrmx/repos","events_url":"https://api.github.com/users/xrmx/events{/privacy}","received_events_url":"https://api.github.com/users/xrmx/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T09:35:52Z","updated_at":"2015-11-03T09:35:52Z","body":"Merged, thanks!"}}