{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59","id":49424816,"html_url":"https://github.com/CindyJS/CindyJS/pull/59","diff_url":"https://github.com/CindyJS/CindyJS/pull/59.diff","patch_url":"https://github.com/CindyJS/CindyJS/pull/59.patch","issue_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/59","number":59,"state":"closed","locked":false,"title":"Shift default origin by half a pixel","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"body":"By shifting the default position of the origin, integer user coordinates have a higher chance of ending up at the center of a pixel, as opposed to the corner of a pixel.\r\n\r\nThis will affect constructions which use the default coordinate system, as well as those which apply relative transformations to that default, like `scale` and `translate`.  Absolute transformations like `scaleAndOrigin` and `visibleRect` are not affected.\r\n\r\nThis addresses #31.\r\n\r\nSince this is an *incompatible* change, I'd like an OK from Jürgen @richter-gebert on this. Can we just change the default, adjusting any existing content which relies on pixel-exact positioning using the old defaults?","created_at":"2015-11-02T12:14:33Z","updated_at":"2015-11-27T21:25:24Z","closed_at":"2015-11-27T21:25:24Z","merged_at":"2015-11-27T21:25:24Z","merge_commit_sha":"e62d59cbb80f3ef780d636b4572246438fc08304","assignee":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/CindyJS/CindyJS/milestones/1","html_url":"https://github.com/CindyJS/CindyJS/milestones/v1.0.0","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/milestones/1/labels","id":1383222,"number":1,"title":"v1.0.0","description":"Version 1.0.0 would be the first official release. CindyJS should from then on follow [semantic versioning](http://semver.org/).","creator":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":13,"state":"open","created_at":"2015-10-29T11:06:50Z","updated_at":"2015-11-27T21:25:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59/commits","review_comments_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59/comments","review_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/59/comments","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/901cc34d8d0ac17f75e33cfe0ce1f73d1f9a8f5d","head":{"label":"gagern:shiftOrigin","ref":"shiftOrigin","sha":"901cc34d8d0ac17f75e33cfe0ce1f73d1f9a8f5d","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"repo":{"id":42124777,"name":"CindyJS","full_name":"gagern/CindyJS","owner":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gagern/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":true,"url":"https://api.github.com/repos/gagern/CindyJS","forks_url":"https://api.github.com/repos/gagern/CindyJS/forks","keys_url":"https://api.github.com/repos/gagern/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gagern/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gagern/CindyJS/teams","hooks_url":"https://api.github.com/repos/gagern/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/gagern/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/gagern/CindyJS/events","assignees_url":"https://api.github.com/repos/gagern/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/gagern/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/gagern/CindyJS/tags","blobs_url":"https://api.github.com/repos/gagern/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gagern/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gagern/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/gagern/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gagern/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/gagern/CindyJS/languages","stargazers_url":"https://api.github.com/repos/gagern/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/gagern/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/gagern/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/gagern/CindyJS/subscription","commits_url":"https://api.github.com/repos/gagern/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/gagern/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/gagern/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/gagern/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/gagern/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/gagern/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gagern/CindyJS/merges","archive_url":"https://api.github.com/repos/gagern/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gagern/CindyJS/downloads","issues_url":"https://api.github.com/repos/gagern/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/gagern/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/gagern/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/gagern/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gagern/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/gagern/CindyJS/releases{/id}","created_at":"2015-09-08T16:29:07Z","updated_at":"2015-09-08T16:29:08Z","pushed_at":"2015-11-27T08:43:16Z","git_url":"git://github.com/gagern/CindyJS.git","ssh_url":"git@github.com:gagern/CindyJS.git","clone_url":"https://github.com/gagern/CindyJS.git","svn_url":"https://github.com/gagern/CindyJS","homepage":null,"size":11215,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CindyJS:master","ref":"master","sha":"33416e4f7f809f35cbbf5ac095fffd6f2fecc81c","user":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"repo":{"id":42122684,"name":"CindyJS","full_name":"CindyJS/CindyJS","owner":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CindyJS/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":false,"url":"https://api.github.com/repos/CindyJS/CindyJS","forks_url":"https://api.github.com/repos/CindyJS/CindyJS/forks","keys_url":"https://api.github.com/repos/CindyJS/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CindyJS/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CindyJS/CindyJS/teams","hooks_url":"https://api.github.com/repos/CindyJS/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/CindyJS/CindyJS/events","assignees_url":"https://api.github.com/repos/CindyJS/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/CindyJS/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/CindyJS/CindyJS/tags","blobs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CindyJS/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/CindyJS/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/CindyJS/CindyJS/languages","stargazers_url":"https://api.github.com/repos/CindyJS/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/CindyJS/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/CindyJS/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/CindyJS/CindyJS/subscription","commits_url":"https://api.github.com/repos/CindyJS/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/CindyJS/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/CindyJS/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/CindyJS/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CindyJS/CindyJS/merges","archive_url":"https://api.github.com/repos/CindyJS/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CindyJS/CindyJS/downloads","issues_url":"https://api.github.com/repos/CindyJS/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/CindyJS/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/CindyJS/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/CindyJS/CindyJS/releases{/id}","created_at":"2015-09-08T15:51:32Z","updated_at":"2015-11-23T16:38:48Z","pushed_at":"2015-11-27T21:25:24Z","git_url":"git://github.com/CindyJS/CindyJS.git","ssh_url":"git@github.com:CindyJS/CindyJS.git","clone_url":"https://github.com/CindyJS/CindyJS.git","svn_url":"https://github.com/CindyJS/CindyJS","homepage":null,"size":11242,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":40,"forks":8,"open_issues":40,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59"},"html":{"href":"https://github.com/CindyJS/CindyJS/pull/59"},"issue":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/59"},"comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/CindyJS/CindyJS/statuses/901cc34d8d0ac17f75e33cfe0ce1f73d1f9a8f5d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":34,"deletions":32,"changed_files":4}}