{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/37929107","id":37929107,"diff_hunk":"@@ -695,6 +695,126 @@ class DAGSchedulerSuite\n     assertDataStructuresEmpty()\n   }\n \n+\n+  // Helper function to validate state when creating tests for task failures\n+  def checkStageId(stageId: Int, attempt: Int, stageAttempt: TaskSet) {\n+    assert(stageAttempt.stageId === stageId,\n+      s\": expected stage $stageId, got ${stageAttempt.stageId}\")\n+    assert(stageAttempt.stageAttemptId == attempt,\n+      s\": expected stage attempt $attempt, got ${stageAttempt.stageAttemptId}\")\n+  }\n+\n+  def makeCompletions(stageAttempt: TaskSet, reduceParts: Int): Seq[(Success.type, MapStatus)] = {\n+    stageAttempt.tasks.zipWithIndex.map { case (task, idx) =>\n+      (Success, makeMapStatus(\"host\" + ('A' + idx).toChar, reduceParts))\n+    }.toSeq\n+  }\n+","path":"core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala","position":18,"original_position":18,"commit_id":"f768beff063da3b14aa10a5d082f24933a62cf18","original_commit_id":"f768beff063da3b14aa10a5d082f24933a62cf18","user":{"login":"squito","id":71240,"avatar_url":"https://avatars.githubusercontent.com/u/71240?v=3","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"body":"thanks Mark -- these are the utils I'm stealing from https://github.com/apache/spark/pull/5636 (where these reduce a *lot* of noise), might be best to move this discussion there?  Then again this pr is probably the easiest to merge, so maybe we can do this here first?\r\n\r\nI don't particularly care either way, just want to avoid a fractured discussion (which would be my fault for doing this ...)","created_at":"2015-08-25T22:48:33Z","updated_at":"2015-08-25T22:48:33Z","html_url":"https://github.com/apache/spark/pull/8402#discussion_r37929107","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8402","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/37929107"},"html":{"href":"https://github.com/apache/spark/pull/8402#discussion_r37929107"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8402"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8402","id":43225253,"html_url":"https://github.com/apache/spark/pull/8402","diff_url":"https://github.com/apache/spark/pull/8402.diff","patch_url":"https://github.com/apache/spark/pull/8402.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8402","number":8402,"state":"open","locked":false,"title":"[SPARK-10192] [core] simple test w/ failure involving a shared dependency","user":{"login":"squito","id":71240,"avatar_url":"https://avatars.githubusercontent.com/u/71240?v=3","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"body":"just trying to increase test coverage in the scheduler, this already works.\r\n\r\ncopied some test utils from https://github.com/apache/spark/pull/5636, we can wait till that is merged first","created_at":"2015-08-24T21:39:54Z","updated_at":"2015-08-25T22:48:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fec0fa523374a12c4242659698a437a2dabc27e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8402/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8402/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8402/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/f768beff063da3b14aa10a5d082f24933a62cf18","head":{"label":"squito:test_retry_in_shared_shuffle_dep","ref":"test_retry_in_shared_shuffle_dep","sha":"f768beff063da3b14aa10a5d082f24933a62cf18","user":{"login":"squito","id":71240,"avatar_url":"https://avatars.githubusercontent.com/u/71240?v=3","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"repo":{"id":29212749,"name":"spark","full_name":"squito/spark","owner":{"login":"squito","id":71240,"avatar_url":"https://avatars.githubusercontent.com/u/71240?v=3","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squito/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/squito/spark","forks_url":"https://api.github.com/repos/squito/spark/forks","keys_url":"https://api.github.com/repos/squito/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squito/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squito/spark/teams","hooks_url":"https://api.github.com/repos/squito/spark/hooks","issue_events_url":"https://api.github.com/repos/squito/spark/issues/events{/number}","events_url":"https://api.github.com/repos/squito/spark/events","assignees_url":"https://api.github.com/repos/squito/spark/assignees{/user}","branches_url":"https://api.github.com/repos/squito/spark/branches{/branch}","tags_url":"https://api.github.com/repos/squito/spark/tags","blobs_url":"https://api.github.com/repos/squito/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squito/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squito/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/squito/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squito/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/squito/spark/languages","stargazers_url":"https://api.github.com/repos/squito/spark/stargazers","contributors_url":"https://api.github.com/repos/squito/spark/contributors","subscribers_url":"https://api.github.com/repos/squito/spark/subscribers","subscription_url":"https://api.github.com/repos/squito/spark/subscription","commits_url":"https://api.github.com/repos/squito/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/squito/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/squito/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/squito/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/squito/spark/contents/{+path}","compare_url":"https://api.github.com/repos/squito/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squito/spark/merges","archive_url":"https://api.github.com/repos/squito/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squito/spark/downloads","issues_url":"https://api.github.com/repos/squito/spark/issues{/number}","pulls_url":"https://api.github.com/repos/squito/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/squito/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/squito/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squito/spark/labels{/name}","releases_url":"https://api.github.com/repos/squito/spark/releases{/id}","created_at":"2015-01-13T21:43:10Z","updated_at":"2015-05-06T03:00:35Z","pushed_at":"2015-08-25T22:25:30Z","git_url":"git://github.com/squito/spark.git","ssh_url":"git@github.com:squito/spark.git","clone_url":"https://github.com/squito/spark.git","svn_url":"https://github.com/squito/spark","homepage":null,"size":118564,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cb2d2e15844d7ae34b5dd7028b55e11586ed93fa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-08-25T20:09:12Z","pushed_at":"2015-08-25T22:38:14Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1657412,"stargazers_count":5185,"watchers_count":5185,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4765,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":352,"forks":4765,"open_issues":352,"watchers":5185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8402"},"html":{"href":"https://github.com/apache/spark/pull/8402"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8402"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8402/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8402/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8402/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/f768beff063da3b14aa10a5d082f24933a62cf18"}}}}