{"action":"created","issue":{"url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/28","labels_url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/28/comments","events_url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/28/events","html_url":"https://github.com/RusticiSoftware/TinCanPHP/pull/28","id":71670624,"number":28,"title":"Functions from TinBadges.php prototype","user":{"login":"garemoko","id":1363163,"avatar_url":"https://avatars.githubusercontent.com/u/1363163?v=3","gravatar_id":"","url":"https://api.github.com/users/garemoko","html_url":"https://github.com/garemoko","followers_url":"https://api.github.com/users/garemoko/followers","following_url":"https://api.github.com/users/garemoko/following{/other_user}","gists_url":"https://api.github.com/users/garemoko/gists{/gist_id}","starred_url":"https://api.github.com/users/garemoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garemoko/subscriptions","organizations_url":"https://api.github.com/users/garemoko/orgs","repos_url":"https://api.github.com/users/garemoko/repos","events_url":"https://api.github.com/users/garemoko/events{/privacy}","received_events_url":"https://api.github.com/users/garemoko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"brianjmiller","id":95960,"avatar_url":"https://avatars.githubusercontent.com/u/95960?v=3","gravatar_id":"","url":"https://api.github.com/users/brianjmiller","html_url":"https://github.com/brianjmiller","followers_url":"https://api.github.com/users/brianjmiller/followers","following_url":"https://api.github.com/users/brianjmiller/following{/other_user}","gists_url":"https://api.github.com/users/brianjmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjmiller/subscriptions","organizations_url":"https://api.github.com/users/brianjmiller/orgs","repos_url":"https://api.github.com/users/brianjmiller/repos","events_url":"https://api.github.com/users/brianjmiller/events{/privacy}","received_events_url":"https://api.github.com/users/brianjmiller/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-04-28T18:46:21Z","updated_at":"2015-04-29T15:12:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/pulls/28","html_url":"https://github.com/RusticiSoftware/TinCanPHP/pull/28","diff_url":"https://github.com/RusticiSoftware/TinCanPHP/pull/28.diff","patch_url":"https://github.com/RusticiSoftware/TinCanPHP/pull/28.patch"},"body":"This PR contains the generic functions written for TinBadgesPHP that could be useful to other adopters. "},"comment":{"url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/comments/97460848","html_url":"https://github.com/RusticiSoftware/TinCanPHP/pull/28#issuecomment-97460848","issue_url":"https://api.github.com/repos/RusticiSoftware/TinCanPHP/issues/28","id":97460848,"user":{"login":"brianjmiller","id":95960,"avatar_url":"https://avatars.githubusercontent.com/u/95960?v=3","gravatar_id":"","url":"https://api.github.com/users/brianjmiller","html_url":"https://github.com/brianjmiller","followers_url":"https://api.github.com/users/brianjmiller/followers","following_url":"https://api.github.com/users/brianjmiller/following{/other_user}","gists_url":"https://api.github.com/users/brianjmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjmiller/subscriptions","organizations_url":"https://api.github.com/users/brianjmiller/orgs","repos_url":"https://api.github.com/users/brianjmiller/repos","events_url":"https://api.github.com/users/brianjmiller/events{/privacy}","received_events_url":"https://api.github.com/users/brianjmiller/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T15:12:32Z","updated_at":"2015-04-29T15:12:32Z","body":"* It would be good to roll in `retrieveAgent` at the same time to keep parallel APIs the same and it should be nearly identical. Though I guess that would involve introducing a `Person` class, which if that is too much to do now we can skip it.\r\n* Need to add `retrieveActivity` (and `retrieveAgent` if it gets done) to the `LRSInterface` interface.\r\n* I'd like to see at least minimal unit test coverage for both methods in place, our coverage hasn't been great and we can up the level of assertion in RemoteLRS for sure, but we at least AFAIK hit all the methods at least once.\r\n* `else`s shouldn't be cuddled :-)."}}