{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/44990451","id":44990451,"diff_hunk":"@@ -1163,6 +1167,49 @@ def init_local_facts(self, facts=None):\n         self.changed = changed\n         return new_local_facts\n \n+    def init_in_docker_facts(self, facts):","path":"roles/openshift_facts/library/openshift_facts.py","position":33,"original_position":33,"commit_id":"7604053cf5d54a3ba537ed12d7c2a69ce4aac721","original_commit_id":"7604053cf5d54a3ba537ed12d7c2a69ce4aac721","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"Everything here should be set only if it isn't already set, otherwise we do not give the user a way to override the settings we are giving them.","created_at":"2015-11-16T22:00:53Z","updated_at":"2015-11-16T22:00:53Z","html_url":"https://github.com/openshift/openshift-ansible/pull/808#discussion_r44990451","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/44990451"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/808#discussion_r44990451"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808","id":49710479,"html_url":"https://github.com/openshift/openshift-ansible/pull/808","diff_url":"https://github.com/openshift/openshift-ansible/pull/808.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/808.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/808","number":808,"state":"open","locked":false,"title":"Containerized install with SDN support","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"Supersedes #620 includes SDN support based on https://github.com/openshift/origin/pull/5442\r\n\r\nThis work adds containerized installation support including OpenvSwitch SDN enabled nodes. Suitable for use on Atomic Host and tested on RHEL Atomic Host 7.1.6 or later. I imagine it works on Fedora Atomic Host as well but I haven't personally tested there.\r\n\r\nImages used\r\n - Origin \r\n  - openshift/origin\r\n  - openshift/node (node + openshift-sdn)\r\n  - openshift/openvswitch (ovsdb ovsctl processes)\r\n  - registry.access.redhat.com/rhel7/etcd\r\n - OpenShift Enterprise\r\n  - openshift3/ose\r\n  - openshift3/node\r\n  - openshift3/openvswitch\r\n  - registry.access.redhat.com/rhel7/etcd\r\n - Atomic Enterprise Platform\r\n  - aep3/aep\r\n  - aep3/node\r\n  - aep3/openvswitch\r\n  - registry.access.redhat.com/rhel7/etcd\r\n\r\nThis work should be considered a 'Technical Preview'. Whenever possible we have attempted to minimize the differences between containerized and RPM based installation methods. One point where things differ is in the installation of etcd. Currently etcd is installed in atomic ostree however there are plans to remove it in the next 3-6 months so I have disabled etcd in atomic-host and installed the containerized version of etcd as `etcd_container`. Another point where things differ is that RPM installs commonly write to /usr/lib which is read-only on atomic hosts so equivalent paths have been found in /etc.\r\n\r\nOutstanding work to be completed before merging this PR\r\n- [ ] Add master HA services\r\n- [ ] Add check to ensure we're on atomic-host 7.1.6 or later which includes iptables (Fedora equivalent?)\r\n\r\nFollowup items for future PRs\r\n- [ ] Allow overriding master, node, openvswitch, and etcd image names.\r\n- [ ] Allow overriding versions of images, currently latest tag is hard-coded.\r\n- [ ] Consider what to do about deploying HA master load balancer in containerized environments.","created_at":"2015-11-04T16:24:55Z","updated_at":"2015-11-16T22:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f2fae1a12dae8142a23b0c3d89eec9667373747","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/808/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7604053cf5d54a3ba537ed12d7c2a69ce4aac721","head":{"label":"sdodson:containers","ref":"containers","sha":"7604053cf5d54a3ba537ed12d7c2a69ce4aac721","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"repo":{"id":32589211,"name":"openshift-ansible","full_name":"sdodson/openshift-ansible","owner":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdodson/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/sdodson/openshift-ansible","forks_url":"https://api.github.com/repos/sdodson/openshift-ansible/forks","keys_url":"https://api.github.com/repos/sdodson/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdodson/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdodson/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/sdodson/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sdodson/openshift-ansible/events","assignees_url":"https://api.github.com/repos/sdodson/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sdodson/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdodson/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sdodson/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/sdodson/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/sdodson/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdodson/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdodson/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sdodson/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdodson/openshift-ansible/merges","archive_url":"https://api.github.com/repos/sdodson/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdodson/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sdodson/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sdodson/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sdodson/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdodson/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/sdodson/openshift-ansible/releases{/id}","created_at":"2015-03-20T14:44:06Z","updated_at":"2015-05-01T15:04:21Z","pushed_at":"2015-11-13T22:17:22Z","git_url":"git://github.com/sdodson/openshift-ansible.git","ssh_url":"git@github.com:sdodson/openshift-ansible.git","clone_url":"https://github.com/sdodson/openshift-ansible.git","svn_url":"https://github.com/sdodson/openshift-ansible","homepage":"","size":2660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"204089c95b8fb784f7d936ed98ed73011da4b6b3","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-11-09T06:29:03Z","pushed_at":"2015-11-16T21:54:48Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"","size":2803,"stargazers_count":90,"watchers_count":90,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":133,"forks":157,"open_issues":133,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/808"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/808"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7604053cf5d54a3ba537ed12d7c2a69ce4aac721"}}}}