{"action":"created","comment":{"url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/comments/24738825","id":24738825,"diff_hunk":"@@ -29,10 +29,12 @@ interface_driver = <%= @interface_driver %>\n # interface_driver = neutron.agent.linux.interface.BridgeInterfaceDriver\n \n <% if @ib_use_dhcp_relay -%>\n-interface_dev_name_len = 10\n-ddi_proxy_bridge = br-public\n-dhclient_path = /sbin/dhclient\n-dhcrelay_path = /usr/sbin/dhcrelay\n+interface_dev_name_len = 9\n+root_helper = sudo neutron-rootwrap /etc/neutron/rootwrap.conf\n+dhcp_agent_manager = neutron.agent.dhcp_agent.DhcpAgentWithStateReport\n+dhcp_relay_bridge = <%= @dhcp_relay_bridge %>\n+dhclient_path = /usr/local/dhcp-4.3.0/sbin/dhclient\n+dhcrelay_path = /usr/local/dhcp-4.3.0/sbin/dhcrelay","path":"chef/cookbooks/neutron/templates/default/dhcp_agent.ini.erb","position":13,"original_position":13,"commit_id":"89b4f713c002e64a1b3b8a5369a26defa5053188","original_commit_id":"89b4f713c002e64a1b3b8a5369a26defa5053188","user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"body":"Please make ```dhclient_path``` and ```dhcrelay_path``` configurable via attributes in the barclamp proposal (chef/data_bags/crowbar/bc-template-neutron.json) and default them to ```/usr/sbin/dhcrelay``` and ```/sbin/dhclient``` as this is where they get installed by default on SUSE.\r\n","created_at":"2015-02-16T09:11:33Z","updated_at":"2015-02-16T09:11:33Z","html_url":"https://github.com/rhafer/barclamp-neutron/pull/2#discussion_r24738825","pull_request_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/comments/24738825"},"html":{"href":"https://github.com/rhafer/barclamp-neutron/pull/2#discussion_r24738825"},"pull_request":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2","id":29297364,"html_url":"https://github.com/rhafer/barclamp-neutron/pull/2","diff_url":"https://github.com/rhafer/barclamp-neutron/pull/2.diff","patch_url":"https://github.com/rhafer/barclamp-neutron/pull/2.patch","issue_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/2","number":2,"state":"open","locked":false,"title":"Added configurations required to support DHCP relay.","user":{"login":"yuewko","id":9220407,"avatar_url":"https://avatars.githubusercontent.com/u/9220407?v=3","gravatar_id":"","url":"https://api.github.com/users/yuewko","html_url":"https://github.com/yuewko","followers_url":"https://api.github.com/users/yuewko/followers","following_url":"https://api.github.com/users/yuewko/following{/other_user}","gists_url":"https://api.github.com/users/yuewko/gists{/gist_id}","starred_url":"https://api.github.com/users/yuewko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuewko/subscriptions","organizations_url":"https://api.github.com/users/yuewko/orgs","repos_url":"https://api.github.com/users/yuewko/repos","events_url":"https://api.github.com/users/yuewko/events{/privacy}","received_events_url":"https://api.github.com/users/yuewko/received_events","type":"User","site_admin":false},"body":"Configuration files affected include:\r\n/etc/neutron/neutron.conf\r\n/etc/neutron/dhcp_agent.ini\r\n/etc/neutron/l3_agent.ini\r\n/etc/neutron/infoblox_conditional.conf","created_at":"2015-02-13T20:42:03Z","updated_at":"2015-02-16T09:11:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8520d733ab00c0e6e2ff14336f67861a8bb04c9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2/commits","review_comments_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2/comments","review_comment_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/2/comments","statuses_url":"https://api.github.com/repos/rhafer/barclamp-neutron/statuses/89b4f713c002e64a1b3b8a5369a26defa5053188","head":{"label":"yuewko:infoblox-ipam","ref":"infoblox-ipam","sha":"89b4f713c002e64a1b3b8a5369a26defa5053188","user":{"login":"yuewko","id":9220407,"avatar_url":"https://avatars.githubusercontent.com/u/9220407?v=3","gravatar_id":"","url":"https://api.github.com/users/yuewko","html_url":"https://github.com/yuewko","followers_url":"https://api.github.com/users/yuewko/followers","following_url":"https://api.github.com/users/yuewko/following{/other_user}","gists_url":"https://api.github.com/users/yuewko/gists{/gist_id}","starred_url":"https://api.github.com/users/yuewko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuewko/subscriptions","organizations_url":"https://api.github.com/users/yuewko/orgs","repos_url":"https://api.github.com/users/yuewko/repos","events_url":"https://api.github.com/users/yuewko/events{/privacy}","received_events_url":"https://api.github.com/users/yuewko/received_events","type":"User","site_admin":false},"repo":{"id":30560810,"name":"barclamp-neutron","full_name":"yuewko/barclamp-neutron","owner":{"login":"yuewko","id":9220407,"avatar_url":"https://avatars.githubusercontent.com/u/9220407?v=3","gravatar_id":"","url":"https://api.github.com/users/yuewko","html_url":"https://github.com/yuewko","followers_url":"https://api.github.com/users/yuewko/followers","following_url":"https://api.github.com/users/yuewko/following{/other_user}","gists_url":"https://api.github.com/users/yuewko/gists{/gist_id}","starred_url":"https://api.github.com/users/yuewko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuewko/subscriptions","organizations_url":"https://api.github.com/users/yuewko/orgs","repos_url":"https://api.github.com/users/yuewko/repos","events_url":"https://api.github.com/users/yuewko/events{/privacy}","received_events_url":"https://api.github.com/users/yuewko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuewko/barclamp-neutron","description":"OpenStack Neutron: Networking component","fork":true,"url":"https://api.github.com/repos/yuewko/barclamp-neutron","forks_url":"https://api.github.com/repos/yuewko/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/yuewko/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuewko/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuewko/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/yuewko/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/yuewko/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/yuewko/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/yuewko/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/yuewko/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/yuewko/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/yuewko/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuewko/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuewko/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuewko/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuewko/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/yuewko/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/yuewko/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/yuewko/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/yuewko/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/yuewko/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/yuewko/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuewko/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuewko/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuewko/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/yuewko/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/yuewko/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuewko/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/yuewko/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuewko/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/yuewko/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/yuewko/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/yuewko/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/yuewko/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuewko/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/yuewko/barclamp-neutron/releases{/id}","created_at":"2015-02-09T21:58:24Z","updated_at":"2015-02-09T21:58:24Z","pushed_at":"2015-02-13T20:38:17Z","git_url":"git://github.com/yuewko/barclamp-neutron.git","ssh_url":"git@github.com:yuewko/barclamp-neutron.git","clone_url":"https://github.com/yuewko/barclamp-neutron.git","svn_url":"https://github.com/yuewko/barclamp-neutron","homepage":"https://github.com/crowbar/crowbar","size":1019,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhafer:infoblox","ref":"infoblox","sha":"fed61ff76d32db2df6094e7cb350e2d6fa3c4acb","user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"repo":{"id":13743611,"name":"barclamp-neutron","full_name":"rhafer/barclamp-neutron","owner":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhafer/barclamp-neutron","description":"Neutron ","fork":true,"url":"https://api.github.com/repos/rhafer/barclamp-neutron","forks_url":"https://api.github.com/repos/rhafer/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/rhafer/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhafer/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhafer/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/rhafer/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/rhafer/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/rhafer/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/rhafer/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/rhafer/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhafer/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/rhafer/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/rhafer/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/rhafer/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/rhafer/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/rhafer/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/rhafer/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhafer/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhafer/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhafer/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/rhafer/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhafer/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/rhafer/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhafer/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/rhafer/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/rhafer/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/rhafer/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhafer/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/rhafer/barclamp-neutron/releases{/id}","created_at":"2013-10-21T13:44:12Z","updated_at":"2014-06-25T09:31:34Z","pushed_at":"2015-02-13T15:56:29Z","git_url":"git://github.com/rhafer/barclamp-neutron.git","ssh_url":"git@github.com:rhafer/barclamp-neutron.git","clone_url":"https://github.com/rhafer/barclamp-neutron.git","svn_url":"https://github.com/rhafer/barclamp-neutron","homepage":null,"size":1475,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2"},"html":{"href":"https://github.com/rhafer/barclamp-neutron/pull/2"},"issue":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/2"},"comments":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/rhafer/barclamp-neutron/statuses/89b4f713c002e64a1b3b8a5369a26defa5053188"}}}}