{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1559","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1559/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1559/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1559/events","html_url":"https://github.com/buildbot/buildbot/pull/1559","id":58778288,"number":1559,"title":"fix status_gerrit","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20more%20review","name":"needs more review","color":"bfe5bf"},{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20work","name":"needs work","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-02-24T18:04:27Z","updated_at":"2015-03-01T16:02:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1559","html_url":"https://github.com/buildbot/buildbot/pull/1559","diff_url":"https://github.com/buildbot/buildbot/pull/1559.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1559.patch"},"body":"default buildsummary behaviour works\r\n\r\nbuildstarted, buildfinished behaviour does not because it needs more work in the status framework\r\n\r\nStill needs a doc update.\r\n\r\nWe are changing the API here!\r\nSupporting legacy status api if for me far too expensive, I think we should drop it, and document a data api based status handlers.\r\n\r\nhttp://trac.buildbot.net/ticket/3185\r\n"},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/76604192","html_url":"https://github.com/buildbot/buildbot/pull/1559#issuecomment-76604192","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1559","id":76604192,"user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"created_at":"2015-03-01T16:02:55Z","updated_at":"2015-03-01T16:02:55Z","body":"I'm not sure I see any advantages in writing status plugins in Go or JS.\r\n\r\nFor me, a good api should make simple things trivial, and complex things possible.\r\n\r\nTrivial would means callback to implement with all data populated\r\nPossible would mean use the data api to get the data that is not pre populated.\r\nSee #1567 for my proposal, lets continue the discussion there.\r\n\r\nThen for the list of mistakes history, I think they are very valuable, thank you for listing them!"}}