{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/27945932","id":27945932,"diff_hunk":"@@ -580,24 +595,25 @@ function ($compile, $parse, $document, $position, dateFilter, dateParser, datepi\n         }\n       }\n \n-      ngModel.$validators.date = validator;\n-      ngModel.$parsers.unshift(parseDate);\n-\n-      ngModel.$formatters.push(function (value) {\n-        scope.date = value;\n-         return ngModel.$isEmpty(value) ? value : dateFilter(value, dateFormat);\n-      });\n+      if (!isHtml5DateInput) {\n+        // Internal API to maintain the correct ng-invalid-[key] class\n+        ngModel.$$parserName = 'date';\n+        ngModel.$validators.date = validator;\n+        ngModel.$parsers.unshift(parseDate);\n+        ngModel.$formatters.push(function (value) {\n+          scope.date = value;\n+           return ngModel.$isEmpty(value) ? value : dateFilter(value, dateFormat);\n+        });\n+      }\n \n       // Inner change\n       scope.dateSelection = function(dt) {\n         if (angular.isDefined(dt)) {\n           scope.date = dt;\n         }\n-        if (dateFormat) {","path":"src/datepicker/datepicker.js","position":96,"original_position":96,"commit_id":"3b2d158c55ecbe43b73858a9eadfbef80c70a6a3","original_commit_id":"3b2d158c55ecbe43b73858a9eadfbef80c70a6a3","user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"body":"Hm.. Good point, the directive should throw immediately if dateFormat is falsey. It's undefined behavior and definitely an error in the use of this directive.","created_at":"2015-04-08T06:32:19Z","updated_at":"2015-04-08T06:32:19Z","html_url":"https://github.com/angular-ui/bootstrap/pull/3499#discussion_r27945932","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/27945932"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3499#discussion_r27945932"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499","id":32665255,"html_url":"https://github.com/angular-ui/bootstrap/pull/3499","diff_url":"https://github.com/angular-ui/bootstrap/pull/3499.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3499.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3499","number":3499,"state":"open","locked":false,"title":"WIP feat(datepicker): support HTML5 date input type","user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"body":"- [ ] Add support for other HTML5 input types such as month and datetime-local\r\n\r\nFixes #3312\r\n\r\nDemo of this:\r\nhttp://plnkr.co/edit/eBtCPhNa7S1MnPbUY70a?p=preview","created_at":"2015-04-06T07:14:29Z","updated_at":"2015-04-08T06:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92d2209bd1069ba74e1b1420fe64fd5fb9207afc","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/16","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.13.0","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/16/labels","id":868464,"number":16,"title":"0.13.0","description":"Milestone for minimal Angular 1.3.x support (Anything that's a genuine blocker for 1.3.x support)","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":200,"state":"open","created_at":"2014-11-16T20:41:18Z","updated_at":"2015-04-08T06:07:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3499/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/3b2d158c55ecbe43b73858a9eadfbef80c70a6a3","head":{"label":"chrisirhc:feature/datepicker-type-date","ref":"feature/datepicker-type-date","sha":"3b2d158c55ecbe43b73858a9eadfbef80c70a6a3","user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"repo":{"id":12170713,"name":"angular-ui-bootstrap","full_name":"chrisirhc/angular-ui-bootstrap","owner":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisirhc/angular-ui-bootstrap","description":"Native AngularJS (Angular) directives for Twitter's Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap","forks_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/forks","keys_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/teams","hooks_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/events","assignees_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/tags","blobs_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/languages","stargazers_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/subscription","commits_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/merges","archive_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/downloads","issues_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/chrisirhc/angular-ui-bootstrap/releases{/id}","created_at":"2013-08-17T00:01:03Z","updated_at":"2015-03-23T17:48:27Z","pushed_at":"2015-04-08T06:26:06Z","git_url":"git://github.com/chrisirhc/angular-ui-bootstrap.git","ssh_url":"git@github.com:chrisirhc/angular-ui-bootstrap.git","clone_url":"https://github.com/chrisirhc/angular-ui-bootstrap.git","svn_url":"https://github.com/chrisirhc/angular-ui-bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":5154,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"d0cc72841b9641b768cc5eb184de2dbbaa804e2d","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-04-08T03:51:30Z","pushed_at":"2015-04-08T06:10:24Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":20101,"stargazers_count":8394,"watchers_count":8394,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4450,"mirror_url":null,"open_issues_count":600,"forks":4450,"open_issues":600,"watchers":8394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3499"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3499"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3499/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3499/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/3b2d158c55ecbe43b73858a9eadfbef80c70a6a3"}}}}