{"action":"created","comment":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/comments/35413987","id":35413987,"diff_hunk":"@@ -1207,16 +1207,16 @@ public void testExportGrants() throws IOException {\n                 } else {\n                     assertThat(site.get(\"whitelistedSiteId\").getAsLong(), equalTo(compare.getWhitelistedSite().getId()));\n                 }\n-                if (site.get(\"approvedAccessTokens\").isJsonNull() || site.getAsJsonArray(\"approvedAccessTokens\") == null) {\n-                    assertTrue(compare.getApprovedAccessTokens() == null || compare.getApprovedAccessTokens().isEmpty());\n-                } else {\n-                    assertNotNull(compare.getApprovedAccessTokens());\n-                    Set<String> tokenIds = new HashSet<String>();\n-                    for(OAuth2AccessTokenEntity entity : compare.getApprovedAccessTokens()) {\n-                        tokenIds.add(entity.getId().toString());\n-                    }\n-                    assertThat(jsonArrayToStringSet(site.getAsJsonArray(\"approvedAccessTokens\")), equalTo(tokenIds));\n-                }\n+//                if (site.get(\"approvedAccessTokens\").isJsonNull() || site.getAsJsonArray(\"approvedAccessTokens\") == null) {","path":"openid-connect-server/src/test/java/org/mitre/openid/connect/service/impl/TestMITREidDataService_1_1.java","position":23,"original_position":23,"commit_id":"f935990e779536136ad089a10e82371d5a7534c9","original_commit_id":"f935990e779536136ad089a10e82371d5a7534c9","user":{"login":"httpants","id":3162497,"avatar_url":"https://avatars.githubusercontent.com/u/3162497?v=3","gravatar_id":"","url":"https://api.github.com/users/httpants","html_url":"https://github.com/httpants","followers_url":"https://api.github.com/users/httpants/followers","following_url":"https://api.github.com/users/httpants/following{/other_user}","gists_url":"https://api.github.com/users/httpants/gists{/gist_id}","starred_url":"https://api.github.com/users/httpants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/httpants/subscriptions","organizations_url":"https://api.github.com/users/httpants/orgs","repos_url":"https://api.github.com/users/httpants/repos","events_url":"https://api.github.com/users/httpants/events{/privacy}","received_events_url":"https://api.github.com/users/httpants/received_events","type":"User","site_admin":false},"body":"Ok this is actually the first pull request/patch i've submitted so may have assumed that i could submit something that was almost but not quite complete.  With the issues you've raised, what's the process to get them resolved?  Do i need to submit another pull request?","created_at":"2015-07-24T11:16:49Z","updated_at":"2015-07-24T11:16:49Z","html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874#discussion_r35413987","pull_request_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874","_links":{"self":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/comments/35413987"},"html":{"href":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874#discussion_r35413987"},"pull_request":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874"}}},"pull_request":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874","id":40746911,"html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874","diff_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874.diff","patch_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874.patch","issue_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/874","number":874,"state":"open","locked":false,"title":"Fixed up ApprovedSite AccessToken OneToMany performance issue.","user":{"login":"httpants","id":3162497,"avatar_url":"https://avatars.githubusercontent.com/u/3162497?v=3","gravatar_id":"","url":"https://api.github.com/users/httpants","html_url":"https://github.com/httpants","followers_url":"https://api.github.com/users/httpants/followers","following_url":"https://api.github.com/users/httpants/following{/other_user}","gists_url":"https://api.github.com/users/httpants/gists{/gist_id}","starred_url":"https://api.github.com/users/httpants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/httpants/subscriptions","organizations_url":"https://api.github.com/users/httpants/orgs","repos_url":"https://api.github.com/users/httpants/repos","events_url":"https://api.github.com/users/httpants/events{/privacy}","received_events_url":"https://api.github.com/users/httpants/received_events","type":"User","site_admin":false},"body":"This patch significantly improves performance and I also believe it fixes the duplicate token defect that can happen if the cleanup task runs and has work to do (ie. there are expired tokens) at the same time as other threads are attempting to create a token for the same site.","created_at":"2015-07-24T06:45:30Z","updated_at":"2015-07-24T11:16:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9340b8d9e550c2a1bc8cc2555d3e38fd5b8080a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874/commits","review_comments_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874/comments","review_comment_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/874/comments","statuses_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/statuses/f935990e779536136ad089a10e82371d5a7534c9","head":{"label":"httpants:1.1.x","ref":"1.1.x","sha":"f935990e779536136ad089a10e82371d5a7534c9","user":{"login":"httpants","id":3162497,"avatar_url":"https://avatars.githubusercontent.com/u/3162497?v=3","gravatar_id":"","url":"https://api.github.com/users/httpants","html_url":"https://github.com/httpants","followers_url":"https://api.github.com/users/httpants/followers","following_url":"https://api.github.com/users/httpants/following{/other_user}","gists_url":"https://api.github.com/users/httpants/gists{/gist_id}","starred_url":"https://api.github.com/users/httpants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/httpants/subscriptions","organizations_url":"https://api.github.com/users/httpants/orgs","repos_url":"https://api.github.com/users/httpants/repos","events_url":"https://api.github.com/users/httpants/events{/privacy}","received_events_url":"https://api.github.com/users/httpants/received_events","type":"User","site_admin":false},"repo":{"id":39609321,"name":"OpenID-Connect-Java-Spring-Server","full_name":"httpants/OpenID-Connect-Java-Spring-Server","owner":{"login":"httpants","id":3162497,"avatar_url":"https://avatars.githubusercontent.com/u/3162497?v=3","gravatar_id":"","url":"https://api.github.com/users/httpants","html_url":"https://github.com/httpants","followers_url":"https://api.github.com/users/httpants/followers","following_url":"https://api.github.com/users/httpants/following{/other_user}","gists_url":"https://api.github.com/users/httpants/gists{/gist_id}","starred_url":"https://api.github.com/users/httpants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/httpants/subscriptions","organizations_url":"https://api.github.com/users/httpants/orgs","repos_url":"https://api.github.com/users/httpants/repos","events_url":"https://api.github.com/users/httpants/events{/privacy}","received_events_url":"https://api.github.com/users/httpants/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/httpants/OpenID-Connect-Java-Spring-Server","description":"An OpenID Connect reference implementation in Java on the Spring platform.","fork":true,"url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server","forks_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/forks","keys_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/teams","hooks_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/hooks","issue_events_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/issues/events{/number}","events_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/events","assignees_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/assignees{/user}","branches_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/branches{/branch}","tags_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/tags","blobs_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/languages","stargazers_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/stargazers","contributors_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/contributors","subscribers_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/subscribers","subscription_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/subscription","commits_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/contents/{+path}","compare_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/merges","archive_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/downloads","issues_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/issues{/number}","pulls_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/labels{/name}","releases_url":"https://api.github.com/repos/httpants/OpenID-Connect-Java-Spring-Server/releases{/id}","created_at":"2015-07-24T03:16:03Z","updated_at":"2015-07-24T03:16:04Z","pushed_at":"2015-07-24T06:42:04Z","git_url":"git://github.com/httpants/OpenID-Connect-Java-Spring-Server.git","ssh_url":"git@github.com:httpants/OpenID-Connect-Java-Spring-Server.git","clone_url":"https://github.com/httpants/OpenID-Connect-Java-Spring-Server.git","svn_url":"https://github.com/httpants/OpenID-Connect-Java-Spring-Server","homepage":"https://mitreid.org/","size":79322,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitreid-connect:1.1.x","ref":"1.1.x","sha":"4e83b173f4f42ead5dae5450f99a2c73299ab82e","user":{"login":"mitreid-connect","id":1649591,"avatar_url":"https://avatars.githubusercontent.com/u/1649591?v=3","gravatar_id":"","url":"https://api.github.com/users/mitreid-connect","html_url":"https://github.com/mitreid-connect","followers_url":"https://api.github.com/users/mitreid-connect/followers","following_url":"https://api.github.com/users/mitreid-connect/following{/other_user}","gists_url":"https://api.github.com/users/mitreid-connect/gists{/gist_id}","starred_url":"https://api.github.com/users/mitreid-connect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitreid-connect/subscriptions","organizations_url":"https://api.github.com/users/mitreid-connect/orgs","repos_url":"https://api.github.com/users/mitreid-connect/repos","events_url":"https://api.github.com/users/mitreid-connect/events{/privacy}","received_events_url":"https://api.github.com/users/mitreid-connect/received_events","type":"Organization","site_admin":false},"repo":{"id":2681994,"name":"OpenID-Connect-Java-Spring-Server","full_name":"mitreid-connect/OpenID-Connect-Java-Spring-Server","owner":{"login":"mitreid-connect","id":1649591,"avatar_url":"https://avatars.githubusercontent.com/u/1649591?v=3","gravatar_id":"","url":"https://api.github.com/users/mitreid-connect","html_url":"https://github.com/mitreid-connect","followers_url":"https://api.github.com/users/mitreid-connect/followers","following_url":"https://api.github.com/users/mitreid-connect/following{/other_user}","gists_url":"https://api.github.com/users/mitreid-connect/gists{/gist_id}","starred_url":"https://api.github.com/users/mitreid-connect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitreid-connect/subscriptions","organizations_url":"https://api.github.com/users/mitreid-connect/orgs","repos_url":"https://api.github.com/users/mitreid-connect/repos","events_url":"https://api.github.com/users/mitreid-connect/events{/privacy}","received_events_url":"https://api.github.com/users/mitreid-connect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server","description":"An OpenID Connect reference implementation in Java on the Spring platform.","fork":false,"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server","forks_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/forks","keys_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/teams","hooks_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/hooks","issue_events_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/events{/number}","events_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/events","assignees_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/assignees{/user}","branches_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/branches{/branch}","tags_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/tags","blobs_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/languages","stargazers_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/stargazers","contributors_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/contributors","subscribers_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/subscribers","subscription_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/subscription","commits_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/contents/{+path}","compare_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/merges","archive_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/downloads","issues_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues{/number}","pulls_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/labels{/name}","releases_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/releases{/id}","created_at":"2011-10-31T16:39:24Z","updated_at":"2015-07-22T14:25:38Z","pushed_at":"2015-07-24T06:45:30Z","git_url":"git://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server.git","ssh_url":"git@github.com:mitreid-connect/OpenID-Connect-Java-Spring-Server.git","clone_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server.git","svn_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server","homepage":"https://mitreid.org/","size":79322,"stargazers_count":193,"watchers_count":193,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":86,"forks":141,"open_issues":86,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874"},"html":{"href":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/pull/874"},"issue":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/874"},"comments":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/statuses/f935990e779536136ad089a10e82371d5a7534c9"}}}}