{"action":"closed","number":146,"pull_request":{"url":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146","id":9006734,"html_url":"https://github.com/joshua-decoder/joshua/pull/146","diff_url":"https://github.com/joshua-decoder/joshua/pull/146.diff","patch_url":"https://github.com/joshua-decoder/joshua/pull/146.patch","issue_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/146","number":146,"state":"closed","locked":false,"title":"Fixed the names of the feature function that are added: they must be con...","user":{"login":"gwenniger","id":2011597,"avatar_url":"https://avatars.githubusercontent.com/u/2011597?v=3","gravatar_id":"","url":"https://api.github.com/users/gwenniger","html_url":"https://github.com/gwenniger","followers_url":"https://api.github.com/users/gwenniger/followers","following_url":"https://api.github.com/users/gwenniger/following{/other_user}","gists_url":"https://api.github.com/users/gwenniger/gists{/gist_id}","starred_url":"https://api.github.com/users/gwenniger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwenniger/subscriptions","organizations_url":"https://api.github.com/users/gwenniger/orgs","repos_url":"https://api.github.com/users/gwenniger/repos","events_url":"https://api.github.com/users/gwenniger/events{/privacy}","received_events_url":"https://api.github.com/users/gwenniger/received_events","type":"User","site_admin":false},"body":"...sistently lowercased for consistency\r\n\r\nwith the FeatureVector class and its weights table.\r\n\r\nLowercasing the feature fucntion names in the method  initializeFeatureFunctions()\r\nin the Decoder.java class, but then still using uppercased feature names in the feature classes themselves\r\nlead to inconsistency and nasty bugs were setting the weight of certain features like OOV and WordPenalty\r\nhad no effect. By also using the lowercased version in the constructors of these classes, this bug\r\nis now fixed.\r\n\r\n   modified:   src/joshua/decoder/ff/ArityPhrasePenaltyFF.java\r\n   modified:   src/joshua/decoder/ff/OOVFF.java\r\n   modified:   src/joshua/decoder/ff/SourcePathFF.java\r\n   modified:   src/joshua/decoder/ff/WordPenaltyFF.java","created_at":"2013-10-10T21:34:28Z","updated_at":"2015-01-27T16:16:18Z","closed_at":"2015-01-27T16:16:18Z","merged_at":null,"merge_commit_sha":"150a42808e5ccf8e095ccfa2bdcbe7e07d01fabc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146/commits","review_comments_url":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146/comments","review_comment_url":"https://api.github.com/repos/joshua-decoder/joshua/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/146/comments","statuses_url":"https://api.github.com/repos/joshua-decoder/joshua/statuses/aff43cf5d289d981a6288e7f32a7978a557358b8","head":{"label":"gwenniger:gideon/casingFixes","ref":"gideon/casingFixes","sha":"aff43cf5d289d981a6288e7f32a7978a557358b8","user":{"login":"gwenniger","id":2011597,"avatar_url":"https://avatars.githubusercontent.com/u/2011597?v=3","gravatar_id":"","url":"https://api.github.com/users/gwenniger","html_url":"https://github.com/gwenniger","followers_url":"https://api.github.com/users/gwenniger/followers","following_url":"https://api.github.com/users/gwenniger/following{/other_user}","gists_url":"https://api.github.com/users/gwenniger/gists{/gist_id}","starred_url":"https://api.github.com/users/gwenniger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwenniger/subscriptions","organizations_url":"https://api.github.com/users/gwenniger/orgs","repos_url":"https://api.github.com/users/gwenniger/repos","events_url":"https://api.github.com/users/gwenniger/events{/privacy}","received_events_url":"https://api.github.com/users/gwenniger/received_events","type":"User","site_admin":false},"repo":{"id":12761034,"name":"joshua","full_name":"gwenniger/joshua","owner":{"login":"gwenniger","id":2011597,"avatar_url":"https://avatars.githubusercontent.com/u/2011597?v=3","gravatar_id":"","url":"https://api.github.com/users/gwenniger","html_url":"https://github.com/gwenniger","followers_url":"https://api.github.com/users/gwenniger/followers","following_url":"https://api.github.com/users/gwenniger/following{/other_user}","gists_url":"https://api.github.com/users/gwenniger/gists{/gist_id}","starred_url":"https://api.github.com/users/gwenniger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwenniger/subscriptions","organizations_url":"https://api.github.com/users/gwenniger/orgs","repos_url":"https://api.github.com/users/gwenniger/repos","events_url":"https://api.github.com/users/gwenniger/events{/privacy}","received_events_url":"https://api.github.com/users/gwenniger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwenniger/joshua","description":"Joshua Decoder","fork":true,"url":"https://api.github.com/repos/gwenniger/joshua","forks_url":"https://api.github.com/repos/gwenniger/joshua/forks","keys_url":"https://api.github.com/repos/gwenniger/joshua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwenniger/joshua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwenniger/joshua/teams","hooks_url":"https://api.github.com/repos/gwenniger/joshua/hooks","issue_events_url":"https://api.github.com/repos/gwenniger/joshua/issues/events{/number}","events_url":"https://api.github.com/repos/gwenniger/joshua/events","assignees_url":"https://api.github.com/repos/gwenniger/joshua/assignees{/user}","branches_url":"https://api.github.com/repos/gwenniger/joshua/branches{/branch}","tags_url":"https://api.github.com/repos/gwenniger/joshua/tags","blobs_url":"https://api.github.com/repos/gwenniger/joshua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwenniger/joshua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwenniger/joshua/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwenniger/joshua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwenniger/joshua/statuses/{sha}","languages_url":"https://api.github.com/repos/gwenniger/joshua/languages","stargazers_url":"https://api.github.com/repos/gwenniger/joshua/stargazers","contributors_url":"https://api.github.com/repos/gwenniger/joshua/contributors","subscribers_url":"https://api.github.com/repos/gwenniger/joshua/subscribers","subscription_url":"https://api.github.com/repos/gwenniger/joshua/subscription","commits_url":"https://api.github.com/repos/gwenniger/joshua/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwenniger/joshua/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwenniger/joshua/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwenniger/joshua/issues/comments/{number}","contents_url":"https://api.github.com/repos/gwenniger/joshua/contents/{+path}","compare_url":"https://api.github.com/repos/gwenniger/joshua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwenniger/joshua/merges","archive_url":"https://api.github.com/repos/gwenniger/joshua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwenniger/joshua/downloads","issues_url":"https://api.github.com/repos/gwenniger/joshua/issues{/number}","pulls_url":"https://api.github.com/repos/gwenniger/joshua/pulls{/number}","milestones_url":"https://api.github.com/repos/gwenniger/joshua/milestones{/number}","notifications_url":"https://api.github.com/repos/gwenniger/joshua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwenniger/joshua/labels{/name}","releases_url":"https://api.github.com/repos/gwenniger/joshua/releases{/id}","created_at":"2013-09-11T16:13:23Z","updated_at":"2014-05-12T15:40:22Z","pushed_at":"2014-05-12T15:40:22Z","git_url":"git://github.com/gwenniger/joshua.git","ssh_url":"git@github.com:gwenniger/joshua.git","clone_url":"https://github.com/gwenniger/joshua.git","svn_url":"https://github.com/gwenniger/joshua","homepage":"http://joshua-decoder.org/","size":305732,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joshua-decoder:master","ref":"master","sha":"c96250933e4f4ab9919704f9c8d7436e05bf2c3e","user":{"login":"joshua-decoder","id":796721,"avatar_url":"https://avatars.githubusercontent.com/u/796721?v=3","gravatar_id":"","url":"https://api.github.com/users/joshua-decoder","html_url":"https://github.com/joshua-decoder","followers_url":"https://api.github.com/users/joshua-decoder/followers","following_url":"https://api.github.com/users/joshua-decoder/following{/other_user}","gists_url":"https://api.github.com/users/joshua-decoder/gists{/gist_id}","starred_url":"https://api.github.com/users/joshua-decoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshua-decoder/subscriptions","organizations_url":"https://api.github.com/users/joshua-decoder/orgs","repos_url":"https://api.github.com/users/joshua-decoder/repos","events_url":"https://api.github.com/users/joshua-decoder/events{/privacy}","received_events_url":"https://api.github.com/users/joshua-decoder/received_events","type":"Organization","site_admin":false},"repo":{"id":1777378,"name":"joshua","full_name":"joshua-decoder/joshua","owner":{"login":"joshua-decoder","id":796721,"avatar_url":"https://avatars.githubusercontent.com/u/796721?v=3","gravatar_id":"","url":"https://api.github.com/users/joshua-decoder","html_url":"https://github.com/joshua-decoder","followers_url":"https://api.github.com/users/joshua-decoder/followers","following_url":"https://api.github.com/users/joshua-decoder/following{/other_user}","gists_url":"https://api.github.com/users/joshua-decoder/gists{/gist_id}","starred_url":"https://api.github.com/users/joshua-decoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshua-decoder/subscriptions","organizations_url":"https://api.github.com/users/joshua-decoder/orgs","repos_url":"https://api.github.com/users/joshua-decoder/repos","events_url":"https://api.github.com/users/joshua-decoder/events{/privacy}","received_events_url":"https://api.github.com/users/joshua-decoder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joshua-decoder/joshua","description":"Joshua Statistical Machine Translation Toolkit","fork":false,"url":"https://api.github.com/repos/joshua-decoder/joshua","forks_url":"https://api.github.com/repos/joshua-decoder/joshua/forks","keys_url":"https://api.github.com/repos/joshua-decoder/joshua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshua-decoder/joshua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshua-decoder/joshua/teams","hooks_url":"https://api.github.com/repos/joshua-decoder/joshua/hooks","issue_events_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/events{/number}","events_url":"https://api.github.com/repos/joshua-decoder/joshua/events","assignees_url":"https://api.github.com/repos/joshua-decoder/joshua/assignees{/user}","branches_url":"https://api.github.com/repos/joshua-decoder/joshua/branches{/branch}","tags_url":"https://api.github.com/repos/joshua-decoder/joshua/tags","blobs_url":"https://api.github.com/repos/joshua-decoder/joshua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshua-decoder/joshua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshua-decoder/joshua/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshua-decoder/joshua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshua-decoder/joshua/statuses/{sha}","languages_url":"https://api.github.com/repos/joshua-decoder/joshua/languages","stargazers_url":"https://api.github.com/repos/joshua-decoder/joshua/stargazers","contributors_url":"https://api.github.com/repos/joshua-decoder/joshua/contributors","subscribers_url":"https://api.github.com/repos/joshua-decoder/joshua/subscribers","subscription_url":"https://api.github.com/repos/joshua-decoder/joshua/subscription","commits_url":"https://api.github.com/repos/joshua-decoder/joshua/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshua-decoder/joshua/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshua-decoder/joshua/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/comments/{number}","contents_url":"https://api.github.com/repos/joshua-decoder/joshua/contents/{+path}","compare_url":"https://api.github.com/repos/joshua-decoder/joshua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshua-decoder/joshua/merges","archive_url":"https://api.github.com/repos/joshua-decoder/joshua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshua-decoder/joshua/downloads","issues_url":"https://api.github.com/repos/joshua-decoder/joshua/issues{/number}","pulls_url":"https://api.github.com/repos/joshua-decoder/joshua/pulls{/number}","milestones_url":"https://api.github.com/repos/joshua-decoder/joshua/milestones{/number}","notifications_url":"https://api.github.com/repos/joshua-decoder/joshua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshua-decoder/joshua/labels{/name}","releases_url":"https://api.github.com/repos/joshua-decoder/joshua/releases{/id}","created_at":"2011-05-20T16:42:21Z","updated_at":"2015-01-26T16:12:41Z","pushed_at":"2015-01-26T16:12:41Z","git_url":"git://github.com/joshua-decoder/joshua.git","ssh_url":"git@github.com:joshua-decoder/joshua.git","clone_url":"https://github.com/joshua-decoder/joshua.git","svn_url":"https://github.com/joshua-decoder/joshua","homepage":"http://joshua-decoder.org/","size":354526,"stargazers_count":69,"watchers_count":69,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":40,"forks":42,"open_issues":40,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146"},"html":{"href":"https://github.com/joshua-decoder/joshua/pull/146"},"issue":{"href":"https://api.github.com/repos/joshua-decoder/joshua/issues/146"},"comments":{"href":"https://api.github.com/repos/joshua-decoder/joshua/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/joshua-decoder/joshua/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joshua-decoder/joshua/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/joshua-decoder/joshua/statuses/aff43cf5d289d981a6288e7f32a7978a557358b8"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":27,"deletions":4,"changed_files":4}}