{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/41762005","id":41762005,"diff_hunk":"@@ -99,7 +99,7 @@ private[http] class HttpRequestRendererFactory(userAgentHeader: Option[headers.`\n       }\n \n     def renderContentLength(contentLength: Long) =\n-      if (method.isEntityAccepted) r ~~ `Content-Length` ~~ contentLength ~~ CrLf else r\n+      if (method.isEntityAccepted && (contentLength > 0 || !method.isSafe)) r ~~ `Content-Length` ~~ contentLength ~~ CrLf else r","path":"akka-http-core/src/main/scala/akka/http/impl/engine/rendering/HttpRequestRendererFactory.scala","position":5,"original_position":5,"commit_id":"d069d8d70818713b2a9c7c67194ae6e0957ec31f","original_commit_id":"6ea325ef3625cba6a7af097ac5e657e1c0425c5e","user":{"login":"sirthias","id":135347,"avatar_url":"https://avatars.githubusercontent.com/u/135347?v=3","gravatar_id":"","url":"https://api.github.com/users/sirthias","html_url":"https://github.com/sirthias","followers_url":"https://api.github.com/users/sirthias/followers","following_url":"https://api.github.com/users/sirthias/following{/other_user}","gists_url":"https://api.github.com/users/sirthias/gists{/gist_id}","starred_url":"https://api.github.com/users/sirthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirthias/subscriptions","organizations_url":"https://api.github.com/users/sirthias/orgs","repos_url":"https://api.github.com/users/sirthias/repos","events_url":"https://api.github.com/users/sirthias/events{/privacy}","received_events_url":"https://api.github.com/users/sirthias/received_events","type":"User","site_admin":false},"body":"Yup, `Expected` is better.","created_at":"2015-10-12T14:31:16Z","updated_at":"2015-10-12T14:31:16Z","html_url":"https://github.com/akka/akka/pull/18667#discussion_r41762005","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/18667","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/41762005"},"html":{"href":"https://github.com/akka/akka/pull/18667#discussion_r41762005"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/18667"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/18667","id":47043838,"html_url":"https://github.com/akka/akka/pull/18667","diff_url":"https://github.com/akka/akka/pull/18667.diff","patch_url":"https://github.com/akka/akka/pull/18667.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/18667","number":18667,"state":"open","locked":false,"title":"=htc accept entity for DELETE and GET methods","user":{"login":"analytically","id":254434,"avatar_url":"https://avatars.githubusercontent.com/u/254434?v=3","gravatar_id":"","url":"https://api.github.com/users/analytically","html_url":"https://github.com/analytically","followers_url":"https://api.github.com/users/analytically/followers","following_url":"https://api.github.com/users/analytically/following{/other_user}","gists_url":"https://api.github.com/users/analytically/gists{/gist_id}","starred_url":"https://api.github.com/users/analytically/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analytically/subscriptions","organizations_url":"https://api.github.com/users/analytically/orgs","repos_url":"https://api.github.com/users/analytically/repos","events_url":"https://api.github.com/users/analytically/events{/privacy}","received_events_url":"https://api.github.com/users/analytically/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-07T15:38:01Z","updated_at":"2015-10-12T14:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae48b52a6133022e90b10cac760df96034d930ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/18667/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/18667/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/18667/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/d069d8d70818713b2a9c7c67194ae6e0957ec31f","head":{"label":"analytically:release-2.3-dev","ref":"release-2.3-dev","sha":"d069d8d70818713b2a9c7c67194ae6e0957ec31f","user":{"login":"analytically","id":254434,"avatar_url":"https://avatars.githubusercontent.com/u/254434?v=3","gravatar_id":"","url":"https://api.github.com/users/analytically","html_url":"https://github.com/analytically","followers_url":"https://api.github.com/users/analytically/followers","following_url":"https://api.github.com/users/analytically/following{/other_user}","gists_url":"https://api.github.com/users/analytically/gists{/gist_id}","starred_url":"https://api.github.com/users/analytically/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analytically/subscriptions","organizations_url":"https://api.github.com/users/analytically/orgs","repos_url":"https://api.github.com/users/analytically/repos","events_url":"https://api.github.com/users/analytically/events{/privacy}","received_events_url":"https://api.github.com/users/analytically/received_events","type":"User","site_admin":false},"repo":{"id":42238543,"name":"akka","full_name":"analytically/akka","owner":{"login":"analytically","id":254434,"avatar_url":"https://avatars.githubusercontent.com/u/254434?v=3","gravatar_id":"","url":"https://api.github.com/users/analytically","html_url":"https://github.com/analytically","followers_url":"https://api.github.com/users/analytically/followers","following_url":"https://api.github.com/users/analytically/following{/other_user}","gists_url":"https://api.github.com/users/analytically/gists{/gist_id}","starred_url":"https://api.github.com/users/analytically/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analytically/subscriptions","organizations_url":"https://api.github.com/users/analytically/orgs","repos_url":"https://api.github.com/users/analytically/repos","events_url":"https://api.github.com/users/analytically/events{/privacy}","received_events_url":"https://api.github.com/users/analytically/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/analytically/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/analytically/akka","forks_url":"https://api.github.com/repos/analytically/akka/forks","keys_url":"https://api.github.com/repos/analytically/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analytically/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analytically/akka/teams","hooks_url":"https://api.github.com/repos/analytically/akka/hooks","issue_events_url":"https://api.github.com/repos/analytically/akka/issues/events{/number}","events_url":"https://api.github.com/repos/analytically/akka/events","assignees_url":"https://api.github.com/repos/analytically/akka/assignees{/user}","branches_url":"https://api.github.com/repos/analytically/akka/branches{/branch}","tags_url":"https://api.github.com/repos/analytically/akka/tags","blobs_url":"https://api.github.com/repos/analytically/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analytically/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analytically/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/analytically/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analytically/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/analytically/akka/languages","stargazers_url":"https://api.github.com/repos/analytically/akka/stargazers","contributors_url":"https://api.github.com/repos/analytically/akka/contributors","subscribers_url":"https://api.github.com/repos/analytically/akka/subscribers","subscription_url":"https://api.github.com/repos/analytically/akka/subscription","commits_url":"https://api.github.com/repos/analytically/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/analytically/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/analytically/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/analytically/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/analytically/akka/contents/{+path}","compare_url":"https://api.github.com/repos/analytically/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analytically/akka/merges","archive_url":"https://api.github.com/repos/analytically/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analytically/akka/downloads","issues_url":"https://api.github.com/repos/analytically/akka/issues{/number}","pulls_url":"https://api.github.com/repos/analytically/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/analytically/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/analytically/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analytically/akka/labels{/name}","releases_url":"https://api.github.com/repos/analytically/akka/releases{/id}","created_at":"2015-09-10T10:40:49Z","updated_at":"2015-09-10T10:40:56Z","pushed_at":"2015-10-12T11:33:16Z","git_url":"git://github.com/analytically/akka.git","ssh_url":"git@github.com:analytically/akka.git","clone_url":"https://github.com/analytically/akka.git","svn_url":"https://github.com/analytically/akka","homepage":"http://akka.io","size":167814,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"97622c22b151eeb230302aff6479780690b42b8d","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-10-12T13:41:17Z","pushed_at":"2015-10-12T14:11:54Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":271458,"stargazers_count":4561,"watchers_count":4561,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1353,"mirror_url":null,"open_issues_count":779,"forks":1353,"open_issues":779,"watchers":4561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/18667"},"html":{"href":"https://github.com/akka/akka/pull/18667"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/18667"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/18667/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/18667/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/18667/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/d069d8d70818713b2a9c7c67194ae6e0957ec31f"}}}}