{"push_id":594920362,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"2132b05840f5210f828f11a443fd24ef78d102b3","before":"e2c10a1c750a8bec33a0625510f0f0c6b03bd7b2","commits":[{"sha":"4123976870000a453edf02e0a4587bc949eb44f9","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Improved the way we inspect the getters/setters of properties","distinct":false,"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/commits/4123976870000a453edf02e0a4587bc949eb44f9"},{"sha":"2132b05840f5210f828f11a443fd24ef78d102b3","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"minor #159 Improved the way we inspect the getters/setters of properties (javiereguiluz)\n\nThis PR was merged into the master branch.\n\nDiscussion\n----------\n\nImproved the way we inspect the getters/setters of properties\n\nIn several places of the application we need to inspect which is the getter/setter for the property. This is non-trivial because the getters can be `getXXX()`, `isXXX()`, `xxx()`, `hasXXX()`, etc. Sometimes, the getter even doesn't exist, but the entity property is public, so it's possible to access the property. The same goes for the setter.\n\nThis PR centralizes all this logic in a new simple class called `ClassPropertyReflector`. This way we can simplify a lot the Twig extension and the controller. In addition, this introspection is done only once during the application execution and previously we did this each time we displayed the value of a property in the application. Using Blackfire profiler, I got a small performance bump (around 2%) and hundreds of less function calls (between 200 and 300 depending on the entity).\n\nCommits\n-------\n\n4123976 Improved the way we inspect the getters/setters of properties","distinct":true,"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/commits/2132b05840f5210f828f11a443fd24ef78d102b3"}]}