{"action":"closed","number":5398,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/5398","id":50704691,"html_url":"https://github.com/elastic/kibana/pull/5398","diff_url":"https://github.com/elastic/kibana/pull/5398.diff","patch_url":"https://github.com/elastic/kibana/pull/5398.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/5398","number":5398,"state":"closed","locked":false,"title":"[pointSeries/addToSiri] use Map() so that numeric keys are not sorted","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/elastic/kibana/issues/3734#issuecomment-155385344\r\n\r\nThe `getSeries` and `addToSiri` functions in the `pointSeries` module currently use a plain object to map values to series ids. This generally keeps things in the right order but causes numeric keys to be sorted at the top of the key list. This is one of the reasons `Map` exists.\r\n\r\n```js\r\nObject.keys({ z: 0, a: 0}) // ['z', 'a']\r\nObject.keys({ z: 0, a: 0, 1: 0 }) // ['1', 'z', 'a']\r\n```","created_at":"2015-11-13T23:20:14Z","updated_at":"2015-11-17T19:43:46Z","closed_at":"2015-11-17T19:43:46Z","merged_at":"2015-11-17T19:43:46Z","merge_commit_sha":"921278777ffd14561748c65ee87d7c8713a47166","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/5398/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/5398/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/5398/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/0bc71c2ff42c25f7a8be8b0eaf20313b1962c08e","head":{"label":"spalger:fix/segmentOrder","ref":"fix/segmentOrder","sha":"0bc71c2ff42c25f7a8be8b0eaf20313b1962c08e","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"repo":{"id":12307386,"name":"kibana","full_name":"spalger/kibana","owner":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spalger/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/spalger/kibana","forks_url":"https://api.github.com/repos/spalger/kibana/forks","keys_url":"https://api.github.com/repos/spalger/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spalger/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spalger/kibana/teams","hooks_url":"https://api.github.com/repos/spalger/kibana/hooks","issue_events_url":"https://api.github.com/repos/spalger/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/spalger/kibana/events","assignees_url":"https://api.github.com/repos/spalger/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/spalger/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/spalger/kibana/tags","blobs_url":"https://api.github.com/repos/spalger/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spalger/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spalger/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/spalger/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spalger/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/spalger/kibana/languages","stargazers_url":"https://api.github.com/repos/spalger/kibana/stargazers","contributors_url":"https://api.github.com/repos/spalger/kibana/contributors","subscribers_url":"https://api.github.com/repos/spalger/kibana/subscribers","subscription_url":"https://api.github.com/repos/spalger/kibana/subscription","commits_url":"https://api.github.com/repos/spalger/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/spalger/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/spalger/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/spalger/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/spalger/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/spalger/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spalger/kibana/merges","archive_url":"https://api.github.com/repos/spalger/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spalger/kibana/downloads","issues_url":"https://api.github.com/repos/spalger/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/spalger/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/spalger/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/spalger/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spalger/kibana/labels{/name}","releases_url":"https://api.github.com/repos/spalger/kibana/releases{/id}","created_at":"2013-08-22T20:39:03Z","updated_at":"2015-05-08T18:10:59Z","pushed_at":"2015-11-17T18:43:21Z","git_url":"git://github.com/spalger/kibana.git","ssh_url":"git@github.com:spalger/kibana.git","clone_url":"https://github.com/spalger/kibana.git","svn_url":"https://github.com/spalger/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":79663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7858d4c5535c28bde2a92152e08d1909edb87bbc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","created_at":"2013-01-26T04:00:59Z","updated_at":"2015-11-17T18:30:54Z","pushed_at":"2015-11-17T19:43:46Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":85279,"stargazers_count":4451,"watchers_count":4451,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1640,"mirror_url":null,"open_issues_count":709,"forks":1640,"open_issues":709,"watchers":4451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5398"},"html":{"href":"https://github.com/elastic/kibana/pull/5398"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/5398"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/5398/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5398/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5398/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/0bc71c2ff42c25f7a8be8b0eaf20313b1962c08e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":25,"deletions":25,"changed_files":3}}