{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104","id":27406142,"html_url":"https://github.com/chessmasterhong/WaterEmblem/pull/104","diff_url":"https://github.com/chessmasterhong/WaterEmblem/pull/104.diff","patch_url":"https://github.com/chessmasterhong/WaterEmblem/pull/104.patch","issue_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/104","number":104,"state":"closed","locked":false,"title":"Implemented issue #102","user":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"body":"This pull request implements issue #102. \r\n\r\nCurrently, there is one bug. If the active unit has a full inventory and gets an item drop and then discards an item, the terrain bonuses will not stick. For example, consider the following scenario:\r\n\r\n1. Main player has full inventory, and attacks an enemy, kills it, and gets an item (this all happens while being on a forest tile). It is clear in battle that the bonuses are indeed being applied, as they should.\r\n2. After dropping an item, and checking stats, the terrain bonuses will revert. I do know that this occurs due to the `discard` button, which calls recomputeStats (which apparently clashes with the `applyTerrainBonuses` method). I have yet to fix this one, but everything else works.\r\n\r\nEnding your turn on a tile will compute terrain bonuses, and I've prevented them from repeatedly stacking. I just have not figured out (2) yet. ","created_at":"2015-01-15T04:50:27Z","updated_at":"2015-01-15T16:47:06Z","closed_at":"2015-01-15T16:47:06Z","merged_at":"2015-01-15T16:47:06Z","merge_commit_sha":"190844a69b7fd945c687269fd1ead4fc1b326dd7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104/commits","review_comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104/comments","review_comment_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/104/comments","statuses_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/64d6554da8301128673630d401636fb31fd851c8","head":{"label":"DrkSephy:dev","ref":"dev","sha":"64d6554da8301128673630d401636fb31fd851c8","user":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"repo":{"id":28790920,"name":"WaterEmblem","full_name":"DrkSephy/WaterEmblem","owner":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrkSephy/WaterEmblem","description":"","fork":true,"url":"https://api.github.com/repos/DrkSephy/WaterEmblem","forks_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/forks","keys_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/teams","hooks_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/hooks","issue_events_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues/events{/number}","events_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/events","assignees_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/assignees{/user}","branches_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/branches{/branch}","tags_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/tags","blobs_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/statuses/{sha}","languages_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/languages","stargazers_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/stargazers","contributors_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/contributors","subscribers_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/subscribers","subscription_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/subscription","commits_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues/comments/{number}","contents_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/contents/{+path}","compare_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/merges","archive_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/downloads","issues_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues{/number}","pulls_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/pulls{/number}","milestones_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/milestones{/number}","notifications_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/labels{/name}","releases_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/releases{/id}","created_at":"2015-01-05T00:38:39Z","updated_at":"2015-01-14T23:58:23Z","pushed_at":"2015-01-15T04:44:28Z","git_url":"git://github.com/DrkSephy/WaterEmblem.git","ssh_url":"git@github.com:DrkSephy/WaterEmblem.git","clone_url":"https://github.com/DrkSephy/WaterEmblem.git","svn_url":"https://github.com/DrkSephy/WaterEmblem","homepage":null,"size":2332,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chessmasterhong:dev","ref":"dev","sha":"5d4cacc7e03eb5ffe9bd47d5e2553f4a421180eb","user":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"repo":{"id":16974706,"name":"WaterEmblem","full_name":"chessmasterhong/WaterEmblem","owner":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chessmasterhong/WaterEmblem","description":"","fork":false,"url":"https://api.github.com/repos/chessmasterhong/WaterEmblem","forks_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/forks","keys_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/teams","hooks_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/hooks","issue_events_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/events{/number}","events_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/events","assignees_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/assignees{/user}","branches_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/branches{/branch}","tags_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/tags","blobs_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/refs{/sha}","trees_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/{sha}","languages_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/languages","stargazers_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/stargazers","contributors_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/contributors","subscribers_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/subscribers","subscription_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/subscription","commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/commits{/sha}","git_commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/commits{/sha}","comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/comments{/number}","issue_comment_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/comments/{number}","contents_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/contents/{+path}","compare_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/merges","archive_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/downloads","issues_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues{/number}","pulls_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls{/number}","milestones_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/milestones{/number}","notifications_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/labels{/name}","releases_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/releases{/id}","created_at":"2014-02-19T05:29:13Z","updated_at":"2015-01-14T04:15:59Z","pushed_at":"2015-01-15T16:47:06Z","git_url":"git://github.com/chessmasterhong/WaterEmblem.git","ssh_url":"git@github.com:chessmasterhong/WaterEmblem.git","clone_url":"https://github.com/chessmasterhong/WaterEmblem.git","svn_url":"https://github.com/chessmasterhong/WaterEmblem","homepage":null,"size":57987,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104"},"html":{"href":"https://github.com/chessmasterhong/WaterEmblem/pull/104"},"issue":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/104"},"comments":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/64d6554da8301128673630d401636fb31fd851c8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":8,"additions":63,"deletions":7,"changed_files":7}}