{"action":"created","comment":{"url":"https://api.github.com/repos/Adslot/alexandria/pulls/comments/47049345","id":47049345,"diff_hunk":"@@ -1,7 +1,40 @@\n @import '../color';\n @import '../border';\n+@import '../fontWeight';\n \n .grid-component-row {\n-  border-bottom: $border-lighter;\n+  border-bottom: 1px solid transparent;\n   display: flex;\n+\n+  &-header {\n+    color: $color-text-light;\n+  }\n+\n+  &-subfooter {\n+    background-color: $color-gray-white;\n+    color: $color-text-light;\n+  }\n+\n+  &-footer {\n+    font-weight: $font-weight-bold;\n+  }\n+\n+  &-short {\n+    .grid-component-cell {\n+      padding-bottom: 3px;\n+      padding-top: 3px;","path":"src/styles/alexandria/GridRow.scss","position":26,"original_position":26,"commit_id":"1e990a1cdf04b3288acaf966a2167c72f64b8658","original_commit_id":"1e990a1cdf04b3288acaf966a2167c72f64b8658","user":{"login":"omgaz","id":908155,"avatar_url":"https://avatars.githubusercontent.com/u/908155?v=3","gravatar_id":"","url":"https://api.github.com/users/omgaz","html_url":"https://github.com/omgaz","followers_url":"https://api.github.com/users/omgaz/followers","following_url":"https://api.github.com/users/omgaz/following{/other_user}","gists_url":"https://api.github.com/users/omgaz/gists{/gist_id}","starred_url":"https://api.github.com/users/omgaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgaz/subscriptions","organizations_url":"https://api.github.com/users/omgaz/orgs","repos_url":"https://api.github.com/users/omgaz/repos","events_url":"https://api.github.com/users/omgaz/events{/privacy}","received_events_url":"https://api.github.com/users/omgaz/received_events","type":"User","site_admin":false},"body":"Does scss not have a @padding-top?","created_at":"2015-12-09T04:05:18Z","updated_at":"2015-12-09T04:05:18Z","html_url":"https://github.com/Adslot/alexandria/pull/30#discussion_r47049345","pull_request_url":"https://api.github.com/repos/Adslot/alexandria/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/comments/47049345"},"html":{"href":"https://github.com/Adslot/alexandria/pull/30#discussion_r47049345"},"pull_request":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/Adslot/alexandria/pulls/30","id":53068776,"html_url":"https://github.com/Adslot/alexandria/pull/30","diff_url":"https://github.com/Adslot/alexandria/pull/30.diff","patch_url":"https://github.com/Adslot/alexandria/pull/30.patch","issue_url":"https://api.github.com/repos/Adslot/alexandria/issues/30","number":30,"state":"open","locked":false,"title":"Add functionality to the grid","user":{"login":"camjc","id":4197647,"avatar_url":"https://avatars.githubusercontent.com/u/4197647?v=3","gravatar_id":"","url":"https://api.github.com/users/camjc","html_url":"https://github.com/camjc","followers_url":"https://api.github.com/users/camjc/followers","following_url":"https://api.github.com/users/camjc/following{/other_user}","gists_url":"https://api.github.com/users/camjc/gists{/gist_id}","starred_url":"https://api.github.com/users/camjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camjc/subscriptions","organizations_url":"https://api.github.com/users/camjc/orgs","repos_url":"https://api.github.com/users/camjc/repos","events_url":"https://api.github.com/users/camjc/events{/privacy}","received_events_url":"https://api.github.com/users/camjc/received_events","type":"User","site_admin":false},"body":"#### What does this PR accomplish?\r\nGridCell:\r\n\r\n- grow property makes the cell grow to use up all available space.\r\n- classSuffixes can be passed to add custom classes for styling\r\n\r\nGridHeader removed in favour of passing type='header' to a normal row.\r\n\r\nGridRow:\r\n\r\n- Now takes a type (defaulting to 'body') out of\r\n  body, header, subtotal, total.\r\n- Can turn off the horizontal border.\r\n- Can compress the row vertically, decreasing the padding.\r\n\r\nRemoved extraneous row from the example grid.\r\n\r\nGrid:\r\n- Changed to border-box.\r\n- Remove border-top when two grids are direct siblings.\r\n\r\n#### How should this be manually tested?\r\n- [x] Test in IE and a sane browser.\r\n\r\n#### Any background context you want to provide?\r\nThese additions are to support required functionality for future components (immediately for the upcoming treepicker).\r\n\r\n#### What are the relevant trello cards?\r\nhttps://trello.com/c/qmGY6bxB/4756-alexandria-increase-grid-functionality-to-support-requirements-of-treepicker\r\n\r\n#### Screenshots (if appropriate)\r\n![screen shot 2015-12-09 at 1 34 59 pm](https://cloud.githubusercontent.com/assets/4197647/11674953/b2d67ebc-9e79-11e5-8266-af160e11e04d.png)\r\n(Future component using these features of the grid)","created_at":"2015-12-09T02:24:49Z","updated_at":"2015-12-09T04:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e726b3692375a2e4908d86de321852e9267e95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Adslot/alexandria/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Adslot/alexandria/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Adslot/alexandria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adslot/alexandria/issues/30/comments","statuses_url":"https://api.github.com/repos/Adslot/alexandria/statuses/1e990a1cdf04b3288acaf966a2167c72f64b8658","head":{"label":"Adslot:add-grid-features","ref":"add-grid-features","sha":"1e990a1cdf04b3288acaf966a2167c72f64b8658","user":{"login":"Adslot","id":767098,"avatar_url":"https://avatars.githubusercontent.com/u/767098?v=3","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":44502479,"name":"alexandria","full_name":"Adslot/alexandria","owner":{"login":"Adslot","id":767098,"avatar_url":"https://avatars.githubusercontent.com/u/767098?v=3","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/alexandria","description":"","fork":false,"url":"https://api.github.com/repos/Adslot/alexandria","forks_url":"https://api.github.com/repos/Adslot/alexandria/forks","keys_url":"https://api.github.com/repos/Adslot/alexandria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/alexandria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/alexandria/teams","hooks_url":"https://api.github.com/repos/Adslot/alexandria/hooks","issue_events_url":"https://api.github.com/repos/Adslot/alexandria/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/alexandria/events","assignees_url":"https://api.github.com/repos/Adslot/alexandria/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/alexandria/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/alexandria/tags","blobs_url":"https://api.github.com/repos/Adslot/alexandria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/alexandria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/alexandria/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/alexandria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/alexandria/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/alexandria/languages","stargazers_url":"https://api.github.com/repos/Adslot/alexandria/stargazers","contributors_url":"https://api.github.com/repos/Adslot/alexandria/contributors","subscribers_url":"https://api.github.com/repos/Adslot/alexandria/subscribers","subscription_url":"https://api.github.com/repos/Adslot/alexandria/subscription","commits_url":"https://api.github.com/repos/Adslot/alexandria/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/alexandria/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/alexandria/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/alexandria/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/alexandria/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/alexandria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/alexandria/merges","archive_url":"https://api.github.com/repos/Adslot/alexandria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/alexandria/downloads","issues_url":"https://api.github.com/repos/Adslot/alexandria/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/alexandria/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/alexandria/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/alexandria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/alexandria/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/alexandria/releases{/id}","created_at":"2015-10-19T00:27:13Z","updated_at":"2015-10-26T04:04:35Z","pushed_at":"2015-12-09T03:37:50Z","git_url":"git://github.com/Adslot/alexandria.git","ssh_url":"git@github.com:Adslot/alexandria.git","clone_url":"https://github.com/Adslot/alexandria.git","svn_url":"https://github.com/Adslot/alexandria","homepage":null,"size":94,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"Adslot:master","ref":"master","sha":"f3ab6b9972120a1e0f47ffaa7d9920e405cd0791","user":{"login":"Adslot","id":767098,"avatar_url":"https://avatars.githubusercontent.com/u/767098?v=3","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":44502479,"name":"alexandria","full_name":"Adslot/alexandria","owner":{"login":"Adslot","id":767098,"avatar_url":"https://avatars.githubusercontent.com/u/767098?v=3","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/alexandria","description":"","fork":false,"url":"https://api.github.com/repos/Adslot/alexandria","forks_url":"https://api.github.com/repos/Adslot/alexandria/forks","keys_url":"https://api.github.com/repos/Adslot/alexandria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/alexandria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/alexandria/teams","hooks_url":"https://api.github.com/repos/Adslot/alexandria/hooks","issue_events_url":"https://api.github.com/repos/Adslot/alexandria/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/alexandria/events","assignees_url":"https://api.github.com/repos/Adslot/alexandria/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/alexandria/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/alexandria/tags","blobs_url":"https://api.github.com/repos/Adslot/alexandria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/alexandria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/alexandria/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/alexandria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/alexandria/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/alexandria/languages","stargazers_url":"https://api.github.com/repos/Adslot/alexandria/stargazers","contributors_url":"https://api.github.com/repos/Adslot/alexandria/contributors","subscribers_url":"https://api.github.com/repos/Adslot/alexandria/subscribers","subscription_url":"https://api.github.com/repos/Adslot/alexandria/subscription","commits_url":"https://api.github.com/repos/Adslot/alexandria/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/alexandria/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/alexandria/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/alexandria/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/alexandria/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/alexandria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/alexandria/merges","archive_url":"https://api.github.com/repos/Adslot/alexandria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/alexandria/downloads","issues_url":"https://api.github.com/repos/Adslot/alexandria/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/alexandria/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/alexandria/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/alexandria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/alexandria/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/alexandria/releases{/id}","created_at":"2015-10-19T00:27:13Z","updated_at":"2015-10-26T04:04:35Z","pushed_at":"2015-12-09T03:37:50Z","git_url":"git://github.com/Adslot/alexandria.git","ssh_url":"git@github.com:Adslot/alexandria.git","clone_url":"https://github.com/Adslot/alexandria.git","svn_url":"https://github.com/Adslot/alexandria","homepage":null,"size":94,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/30"},"html":{"href":"https://github.com/Adslot/alexandria/pull/30"},"issue":{"href":"https://api.github.com/repos/Adslot/alexandria/issues/30"},"comments":{"href":"https://api.github.com/repos/Adslot/alexandria/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adslot/alexandria/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Adslot/alexandria/statuses/1e990a1cdf04b3288acaf966a2167c72f64b8658"}}}}