{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/26064022","id":26064022,"diff_hunk":"@@ -0,0 +1,55 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Reflection;\n+using System.Text;\n+using NUnit.Framework;\n+\n+namespace Dynamo.PackageManager\n+{\n+    \n+    class PackageTests\n+    {\n+        private readonly AssemblyName assemName =\n+            new AssemblyName(\"Rhynamo, Version=2013.3.6.0, Culture=neutral, PublicKeyToken=null\");","path":"test/DynamoCoreTests/PackageManager/PackageTests.cs","position":14,"original_position":14,"commit_id":"6fb569f24b1850604031c6b74c29453a64584e0e","original_commit_id":"6fb569f24b1850604031c6b74c29453a64584e0e","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"I would change this name out for something generic just in case @archinate ever decides to trademark the name. ","created_at":"2015-03-09T18:55:11Z","updated_at":"2015-03-09T18:55:11Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/3929#discussion_r26064022","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/26064022"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/3929#discussion_r26064022"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929","id":30784725,"html_url":"https://github.com/DynamoDS/Dynamo/pull/3929","diff_url":"https://github.com/DynamoDS/Dynamo/pull/3929.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/3929.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3929","number":3929,"state":"open","locked":false,"title":"Relax node library recognition for packages","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"body":"### Issue\r\n\r\nWhen package authors modify their node assemblies in a package, when they reload the package, the assembly is not present.  This is because node libraries are recognized by the `Assembly.FullName` property, rather than just the assembly name.\r\n\r\n### Fix\r\n\r\nIn order to fix this, I relax the recognition algorithm to allow changing assembly versions.  This is a small modification to the loading algorithm, but makes it more robust for cases like this.\r\n\r\n### Tests\r\n\r\nThis PR includes multiple tests validating the new behavior.\r\n\r\n### Reviewer\r\n\r\n- [ ] @ikeough ","created_at":"2015-03-09T18:04:19Z","updated_at":"2015-03-09T18:55:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f704d800b940daf4ec7c156fa4d8710c484fd9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3929/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/6fb569f24b1850604031c6b74c29453a64584e0e","head":{"label":"pboyer:pkgfiles","ref":"pkgfiles","sha":"6fb569f24b1850604031c6b74c29453a64584e0e","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"repo":{"id":20731728,"name":"Dynamo","full_name":"pboyer/Dynamo","owner":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboyer/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/pboyer/Dynamo","forks_url":"https://api.github.com/repos/pboyer/Dynamo/forks","keys_url":"https://api.github.com/repos/pboyer/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboyer/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboyer/Dynamo/teams","hooks_url":"https://api.github.com/repos/pboyer/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/pboyer/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/pboyer/Dynamo/events","assignees_url":"https://api.github.com/repos/pboyer/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/pboyer/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/pboyer/Dynamo/tags","blobs_url":"https://api.github.com/repos/pboyer/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboyer/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboyer/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboyer/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboyer/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/pboyer/Dynamo/languages","stargazers_url":"https://api.github.com/repos/pboyer/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/pboyer/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/pboyer/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/pboyer/Dynamo/subscription","commits_url":"https://api.github.com/repos/pboyer/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboyer/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboyer/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboyer/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pboyer/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/pboyer/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboyer/Dynamo/merges","archive_url":"https://api.github.com/repos/pboyer/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboyer/Dynamo/downloads","issues_url":"https://api.github.com/repos/pboyer/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/pboyer/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/pboyer/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/pboyer/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboyer/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/pboyer/Dynamo/releases{/id}","created_at":"2014-06-11T16:06:09Z","updated_at":"2015-03-05T20:39:21Z","pushed_at":"2015-03-09T18:00:54Z","git_url":"git://github.com/pboyer/Dynamo.git","ssh_url":"git@github.com:pboyer/Dynamo.git","clone_url":"https://github.com/pboyer/Dynamo.git","svn_url":"https://github.com/pboyer/Dynamo","homepage":"http://dynamobim.org","size":717468,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"afbcc6fe931fd8c1a6d8a452af72224cbd850bb1","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-03-09T15:58:25Z","pushed_at":"2015-03-09T18:48:16Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":883863,"stargazers_count":203,"watchers_count":203,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":547,"forks":142,"open_issues":547,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/3929"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3929"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3929/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3929/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/6fb569f24b1850604031c6b74c29453a64584e0e"}}}}