{"action":"closed","number":2380,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2380","id":35330379,"html_url":"https://github.com/theforeman/foreman/pull/2380","diff_url":"https://github.com/theforeman/foreman/pull/2380.diff","patch_url":"https://github.com/theforeman/foreman/pull/2380.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2380","number":2380,"state":"closed","locked":false,"title":"Fixes #10248 - cloning volume information for virtual machines","user":{"login":"tstrachota","id":1186631,"avatar_url":"https://avatars.githubusercontent.com/u/1186631?v=3","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"body":"`vm.attributes` (Fog) returns volumes and nics info as objects under keys `:volumes` and `:interfaces`. This PR places the volume attributes into `:volumes_attributes` where the Rails' form helper can find it.\r\n\r\nNICs are no longer a problem since we save the original compute attributes with them now.\r\n\r\nTested providers checklist:\r\n* [x] libvirt\r\n* [x] oVirt\r\n* [x] VMWare","created_at":"2015-05-13T14:10:09Z","updated_at":"2015-08-11T08:14:31Z","closed_at":"2015-08-11T08:14:31Z","merged_at":null,"merge_commit_sha":"8136830d7c8d09a2042fa71641175d8c4b4892f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2380/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/e17063c7db63849c0ce7a67ca9319458a25352f0","head":{"label":"tstrachota:vmware_clone","ref":"vmware_clone","sha":"e17063c7db63849c0ce7a67ca9319458a25352f0","user":{"login":"tstrachota","id":1186631,"avatar_url":"https://avatars.githubusercontent.com/u/1186631?v=3","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"repo":{"id":4674201,"name":"foreman","full_name":"tstrachota/foreman","owner":{"login":"tstrachota","id":1186631,"avatar_url":"https://avatars.githubusercontent.com/u/1186631?v=3","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tstrachota/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/tstrachota/foreman","forks_url":"https://api.github.com/repos/tstrachota/foreman/forks","keys_url":"https://api.github.com/repos/tstrachota/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tstrachota/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tstrachota/foreman/teams","hooks_url":"https://api.github.com/repos/tstrachota/foreman/hooks","issue_events_url":"https://api.github.com/repos/tstrachota/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/tstrachota/foreman/events","assignees_url":"https://api.github.com/repos/tstrachota/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/tstrachota/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/tstrachota/foreman/tags","blobs_url":"https://api.github.com/repos/tstrachota/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tstrachota/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tstrachota/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/tstrachota/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tstrachota/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/tstrachota/foreman/languages","stargazers_url":"https://api.github.com/repos/tstrachota/foreman/stargazers","contributors_url":"https://api.github.com/repos/tstrachota/foreman/contributors","subscribers_url":"https://api.github.com/repos/tstrachota/foreman/subscribers","subscription_url":"https://api.github.com/repos/tstrachota/foreman/subscription","commits_url":"https://api.github.com/repos/tstrachota/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/tstrachota/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/tstrachota/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/tstrachota/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/tstrachota/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/tstrachota/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tstrachota/foreman/merges","archive_url":"https://api.github.com/repos/tstrachota/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tstrachota/foreman/downloads","issues_url":"https://api.github.com/repos/tstrachota/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/tstrachota/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/tstrachota/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/tstrachota/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tstrachota/foreman/labels{/name}","releases_url":"https://api.github.com/repos/tstrachota/foreman/releases{/id}","created_at":"2012-06-15T11:11:21Z","updated_at":"2015-03-12T13:49:32Z","pushed_at":"2015-08-10T14:50:26Z","git_url":"git://github.com/tstrachota/foreman.git","ssh_url":"git@github.com:tstrachota/foreman.git","clone_url":"https://github.com/tstrachota/foreman.git","svn_url":"https://github.com/tstrachota/foreman","homepage":"http://theforeman.org","size":25389,"stargazers_count":2,"watchers_count":2,"language":"Gettext Catalog","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"3bd9a898a0a31ca87066c0a8967444523fb0e88c","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-08-09T13:47:40Z","pushed_at":"2015-08-11T08:14:06Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":84005,"stargazers_count":822,"watchers_count":822,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":420,"mirror_url":null,"open_issues_count":83,"forks":420,"open_issues":83,"watchers":822,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2380"},"html":{"href":"https://github.com/theforeman/foreman/pull/2380"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2380"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/e17063c7db63849c0ce7a67ca9319458a25352f0"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":29,"review_comments":12,"commits":6,"additions":253,"deletions":10,"changed_files":15}}