{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/43552033","id":43552033,"diff_hunk":"@@ -76,20 +84,30 @@ public void schedule(Topologies topologies, Cluster cluster) {\n                             if (!nodesUsed.contains(targetNode.getId())) {\n                                 nodesUsed.add(targetNode.getId());\n                             }\n+                            assignedMemOnHeap += targetSlot.getAllocatedMemOnHeap();\n+                            assignedMemOffHeap += targetSlot.getAllocatedMemOffHeap();\n+                            assignedCpu += targetSlot.getAllocatedCpu();\n                         }\n-                        LOG.debug(\"Topology: {} assigned to {} nodes on {} workers\", td.getId(), nodesUsed.size(), schedulerAssignmentMap.keySet().size());\n-                        cluster.setStatus(td.getId(), td.getId() + \" Fully Scheduled\");\n+                        LOG.debug(\"Topology: {} assigned to {} nodes on {} workers\", td.getId(), nodesUsed.size(), assignedWorkers);\n+                        cluster.setStatus(td.getId(), \"Fully Scheduled\");\n                     } catch (IllegalStateException ex) {\n                         LOG.error(ex.toString());\n-                        LOG.error(\"Unsuccessfull in scheduling {}\", td.getId());\n-                        cluster.setStatus(td.getId(), \"Unsuccessfull in scheduling \" + td.getId());\n+                        LOG.error(\"Unsuccessful in scheduling\", td.getId());","path":"storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java","position":40,"original_position":40,"commit_id":"9b9efc46d5e4fc538f59df88e5614d811f0d1e63","original_commit_id":"f6149c87763d431dcfca4a3a0abdccc534c8d180","user":{"login":"d2r","id":905298,"avatar_url":"https://avatars.githubusercontent.com/u/905298?v=3","gravatar_id":"","url":"https://api.github.com/users/d2r","html_url":"https://github.com/d2r","followers_url":"https://api.github.com/users/d2r/followers","following_url":"https://api.github.com/users/d2r/following{/other_user}","gists_url":"https://api.github.com/users/d2r/gists{/gist_id}","starred_url":"https://api.github.com/users/d2r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d2r/subscriptions","organizations_url":"https://api.github.com/users/d2r/orgs","repos_url":"https://api.github.com/users/d2r/repos","events_url":"https://api.github.com/users/d2r/events{/privacy}","received_events_url":"https://api.github.com/users/d2r/received_events","type":"User","site_admin":false},"body":"Thanks for fixing the typo, too.","created_at":"2015-10-30T21:03:26Z","updated_at":"2015-10-30T21:03:26Z","html_url":"https://github.com/apache/storm/pull/829#discussion_r43552033","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/829","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/43552033"},"html":{"href":"https://github.com/apache/storm/pull/829#discussion_r43552033"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/829"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/829","id":49185284,"html_url":"https://github.com/apache/storm/pull/829","diff_url":"https://github.com/apache/storm/pull/829.diff","patch_url":"https://github.com/apache/storm/pull/829.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/829","number":829,"state":"open","locked":false,"title":"[STORM-1144] Provide resource (mem/cpu) assign feedback for schedulers in UI","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"body":"1. Calculate the requested and assigned onheap memory, offheap memory and CPU.\r\n2. Add data structures and REST api to support these resources in topo-info, topo-summary, topo-page-info, cluster, core, nimbus.\r\n3. Display assigned cpu/mem at the index page, and show more details about the requested and assigned resources at each topology page.\r\n4. Adjust the items shown on UI (delete topoId item, exclude topoId from schedulerInfo)\r\n\r\nSnapshots of index page and two topology pages on UI:\r\n\r\n![image](https://issues.apache.org/jira/secure/attachment/12769624/index-page-0.png)\r\n![image](https://issues.apache.org/jira/secure/attachment/12769615/topo-page-1.png)\r\n\r\n![image](https://issues.apache.org/jira/secure/attachment/12769613/topo-page-2.png)","created_at":"2015-10-29T19:05:16Z","updated_at":"2015-10-30T21:03:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29c87a158d619a49c06345cce3391724edb9d3b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/829/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/829/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/829/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/9b9efc46d5e4fc538f59df88e5614d811f0d1e63","head":{"label":"zhuoliu:1144","ref":"1144","sha":"9b9efc46d5e4fc538f59df88e5614d811f0d1e63","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"repo":{"id":32997908,"name":"storm","full_name":"zhuoliu/storm","owner":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhuoliu/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/zhuoliu/storm","forks_url":"https://api.github.com/repos/zhuoliu/storm/forks","keys_url":"https://api.github.com/repos/zhuoliu/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuoliu/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuoliu/storm/teams","hooks_url":"https://api.github.com/repos/zhuoliu/storm/hooks","issue_events_url":"https://api.github.com/repos/zhuoliu/storm/issues/events{/number}","events_url":"https://api.github.com/repos/zhuoliu/storm/events","assignees_url":"https://api.github.com/repos/zhuoliu/storm/assignees{/user}","branches_url":"https://api.github.com/repos/zhuoliu/storm/branches{/branch}","tags_url":"https://api.github.com/repos/zhuoliu/storm/tags","blobs_url":"https://api.github.com/repos/zhuoliu/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuoliu/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuoliu/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuoliu/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuoliu/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuoliu/storm/languages","stargazers_url":"https://api.github.com/repos/zhuoliu/storm/stargazers","contributors_url":"https://api.github.com/repos/zhuoliu/storm/contributors","subscribers_url":"https://api.github.com/repos/zhuoliu/storm/subscribers","subscription_url":"https://api.github.com/repos/zhuoliu/storm/subscription","commits_url":"https://api.github.com/repos/zhuoliu/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuoliu/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuoliu/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuoliu/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuoliu/storm/contents/{+path}","compare_url":"https://api.github.com/repos/zhuoliu/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuoliu/storm/merges","archive_url":"https://api.github.com/repos/zhuoliu/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuoliu/storm/downloads","issues_url":"https://api.github.com/repos/zhuoliu/storm/issues{/number}","pulls_url":"https://api.github.com/repos/zhuoliu/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuoliu/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuoliu/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuoliu/storm/labels{/name}","releases_url":"https://api.github.com/repos/zhuoliu/storm/releases{/id}","created_at":"2015-03-27T16:47:03Z","updated_at":"2015-04-27T16:05:23Z","pushed_at":"2015-10-30T21:03:05Z","git_url":"git://github.com/zhuoliu/storm.git","ssh_url":"git@github.com:zhuoliu/storm.git","clone_url":"https://github.com/zhuoliu/storm.git","svn_url":"https://github.com/zhuoliu/storm","homepage":null,"size":22584,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b6615d5b15846ce737a283b71773a6c85f6f1cd7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-10-30T17:00:32Z","pushed_at":"2015-10-30T21:03:07Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":848814,"stargazers_count":2479,"watchers_count":2479,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1824,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":86,"forks":1824,"open_issues":86,"watchers":2479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/829"},"html":{"href":"https://github.com/apache/storm/pull/829"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/829"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/9b9efc46d5e4fc538f59df88e5614d811f0d1e63"}}}}