{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/38354094","id":38354094,"diff_hunk":"@@ -0,0 +1,128 @@\n+//-- copyright\n+// OpenProject is a project management system.\n+// Copyright (C) 2012-2015 the OpenProject Foundation (OPF)\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License version 3.\n+//\n+// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:\n+// Copyright (C) 2006-2013 Jean-Philippe Lang\n+// Copyright (C) 2010-2013 the ChiliProject Team\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License\n+// as published by the Free Software Foundation; either version 2\n+// of the License, or (at your option) any later version.\n+//\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+// GNU General Public License for more details.\n+//\n+// You should have received a copy of the GNU General Public License\n+// along with this program; if not, write to the Free Software\n+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+//\n+// See doc/COPYRIGHT.rdoc for more details.\n+//++\n+\n+.work-packages--show-view {\n+\n+  height: 100%;\n+\n+  h2, .subject-header {\n+    float: left;\n+    line-height: 40px;\n+    padding: 10px 0 0 0;\n+    font-weight: bold;\n+    font-size: 1.5rem;\n+  }\n+\n+  .work-packages--split-view {\n+    border-top: 1px solid #ccc;\n+    height: calc(100% - 62px);\n+    overflow: hidden;\n+    position: relative;\n+\n+    .tabrow {\n+      margin: -16px -20px 0 -10px;\n+    }\n+  }\n+\n+  .work-packages--left-panel {\n+    border-right: 1px solid #ccc;\n+    overflow-y: auto;\n+    overflow-x: auto;\n+    width: 60%;\n+\n+    .work-packages--panel-inner {\n+      padding: 0px 20px 20px 0px;\n+    }\n+  }\n+\n+  .work-packages--right-panel {\n+    .work-packages--panel-inner {\n+      padding: 20px 20px 20px 20px;\n+    }\n+  }\n+\n+  .work-packages--right-panel {\n+    overflow-y: auto;\n+    overflow-x: auto;\n+    width: 40%;\n+  }\n+\n+  ul.subject-header {\n+    float: left !important;\n+    padding-top: 10px !important;\n+    // with sidebar\n+    width: 58%;\n+\n+    li {\n+      display: inline;\n+      float: left;\n+\n+      &.type {\n+        margin-right: 5px;\n+      }\n+\n+      &.inline-edit {\n+        // with sidebar\n+        width: 65%;\n+      }\n+    }\n+\n+    .work-package-field.work-packages--details--subject {\n+      margin-top: -1px;\n+\n+      .inplace-edit {\n+        .inplace-edit--read {\n+          white-space: nowrap;\n+        }\n+\n+        .inplace-edit--read-value {\n+          margin: 0;\n+          padding: 0;\n+        }\n+      }\n+    }\n+  }\n+}\n+\n+.nosidebar {\n+  ul.subject-header {\n+    width: 67%;\n+\n+    li {\n+      &.inline-edit {\n+        width: 75%;\n+      }\n+    }\n+  }\n+}\n+\n+.work-packages--split-view  {","path":"app/assets/stylesheets/_work_packages_show_view_overwrite.scss","position":124,"original_position":124,"commit_id":"f2b0167215a43001a58fb9fcbf5620e9a03f6ae6","original_commit_id":"f2b0167215a43001a58fb9fcbf5620e9a03f6ae6","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Opening curly brace `{` should be preceded by one space","created_at":"2015-08-31T20:14:31Z","updated_at":"2015-08-31T20:14:31Z","html_url":"https://github.com/opf/openproject/pull/3366#discussion_r38354094","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3366","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/38354094"},"html":{"href":"https://github.com/opf/openproject/pull/3366#discussion_r38354094"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3366","id":42540230,"html_url":"https://github.com/opf/openproject/pull/3366","diff_url":"https://github.com/opf/openproject/pull/3366.diff","patch_url":"https://github.com/opf/openproject/pull/3366.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3366","number":3366,"state":"open","locked":false,"title":"[16364] Switch WorkPackage show view over to AngularJS (aka fullscreen view)","user":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"body":"https://community.openproject.org/work_packages/16364\r\n\r\n#### Review Feedback \r\n\r\nFeedback von @lindenthal und @basiszwo\r\n\r\n- [x] Inline editing of WP title missing\r\n- [x] project context is being lost when switching to fullscreen view `/project/seeded_project/work_packages/1` vs `/work_packages/1`\r\n- [x] \"more\" Button with actions in dropdown is missing [1]\r\n- [x] \"Edit\" Button should link to old edit view (same as in split view) [1]\r\n- [x] cog icon on top right does not make sense in fullscreen view as it provides list settings\r\n  * replace with \"more\" Button?\r\n- [x] missing full screen icon (already included in icon set)\r\n- [x] scrollbar should not be visible when there's nothing to scroll (@rebellium)\r\n- [ ] Fix links to WorkPackage#show view (e.g. user's activities)\r\n- [x] Validate/Fix the actions which should still work (e.g. watching a work package); see OpenProject's work package\r\n- [x] Title should be \"Bug #123: WP TITLE\" where \"WP title is editable\" and \"Bug\" is not a link\r\n- [x] carry query path of url to fullscreen view url so we are properly being redirected when switching back to list or split view\r\n- [x] dropdown actions in \"new work package\" button are missing so it is not possible to create work packages from the full screen view. (should redirect to create mode in split view)\r\n\r\n[1] we initially place the buttons in the top right area. Later @rebellium needs to move them to a bottom bar.\r\n\r\n#### Questions\r\n\r\n- [ ] is it possible to provide a full edit view? how much work would this cause? maybe also in split view mode?\r\n- [ ] what happens if someone has no right to view the work package?\r\n\r\n#### Out of scope\r\n\r\nCreate new pull requests for these bugs\r\n\r\n- [x] Confirm when deleting an image (#3437)\r\n- [x] Upload image then try to edit the description => error 'conflicting modifications' (#3436)\r\n\r\n#### Won't apply\r\n\r\n- [x] \"new work package\" Link in sidebar is linked to the old new view. We should relink it to the new create view (see https://github.com/opf/openproject/pull/3366#issuecomment-135332990)","created_at":"2015-08-16T17:54:06Z","updated_at":"2015-08-31T20:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dca889145721bbeb71ce1b893d39444f5a6d3d39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3366/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3366/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3366/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/f2b0167215a43001a58fb9fcbf5620e9a03f6ae6","head":{"label":"timhabermaas:16364-fullscreen-work-package-view","ref":"16364-fullscreen-work-package-view","sha":"f2b0167215a43001a58fb9fcbf5620e9a03f6ae6","user":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"repo":{"id":40676414,"name":"openproject","full_name":"timhabermaas/openproject","owner":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timhabermaas/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/timhabermaas/openproject","forks_url":"https://api.github.com/repos/timhabermaas/openproject/forks","keys_url":"https://api.github.com/repos/timhabermaas/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timhabermaas/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timhabermaas/openproject/teams","hooks_url":"https://api.github.com/repos/timhabermaas/openproject/hooks","issue_events_url":"https://api.github.com/repos/timhabermaas/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/timhabermaas/openproject/events","assignees_url":"https://api.github.com/repos/timhabermaas/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/timhabermaas/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/timhabermaas/openproject/tags","blobs_url":"https://api.github.com/repos/timhabermaas/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timhabermaas/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timhabermaas/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/timhabermaas/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timhabermaas/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/timhabermaas/openproject/languages","stargazers_url":"https://api.github.com/repos/timhabermaas/openproject/stargazers","contributors_url":"https://api.github.com/repos/timhabermaas/openproject/contributors","subscribers_url":"https://api.github.com/repos/timhabermaas/openproject/subscribers","subscription_url":"https://api.github.com/repos/timhabermaas/openproject/subscription","commits_url":"https://api.github.com/repos/timhabermaas/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/timhabermaas/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/timhabermaas/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/timhabermaas/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/timhabermaas/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/timhabermaas/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timhabermaas/openproject/merges","archive_url":"https://api.github.com/repos/timhabermaas/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timhabermaas/openproject/downloads","issues_url":"https://api.github.com/repos/timhabermaas/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/timhabermaas/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/timhabermaas/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/timhabermaas/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timhabermaas/openproject/labels{/name}","releases_url":"https://api.github.com/repos/timhabermaas/openproject/releases{/id}","created_at":"2015-08-13T18:57:09Z","updated_at":"2015-08-13T18:57:19Z","pushed_at":"2015-08-31T20:14:12Z","git_url":"git://github.com/timhabermaas/openproject.git","ssh_url":"git@github.com:timhabermaas/openproject.git","clone_url":"https://github.com/timhabermaas/openproject.git","svn_url":"https://github.com/timhabermaas/openproject","homepage":"https://www.openproject.org","size":68671,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"dfb2de529a1f8652e3d3cec89682fffaa7b7e79d","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-08-31T11:58:21Z","pushed_at":"2015-08-31T20:14:13Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":208955,"stargazers_count":716,"watchers_count":716,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":296,"mirror_url":null,"open_issues_count":19,"forks":296,"open_issues":19,"watchers":716,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366"},"html":{"href":"https://github.com/opf/openproject/pull/3366"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3366"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3366/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/f2b0167215a43001a58fb9fcbf5620e9a03f6ae6"}}}}