{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-java/pulls/comments/42299860","id":42299860,"diff_hunk":"@@ -108,7 +113,7 @@ private TChannel(Builder builder) {\n             Request<U> request,\n             final Class<T> responseType,\n             ArgScheme scheme\n-    ) throws InterruptedException {\n+    ) throws InterruptedException, TChannelError {","path":"tchannel-core/src/main/java/com/uber/tchannel/api/TChannel.java","position":50,"original_position":50,"commit_id":"dcc2f56059705ed059d18801475dd03054cac3a9","original_commit_id":"dcc2f56059705ed059d18801475dd03054cac3a9","user":{"login":"truncs","id":157234,"avatar_url":"https://avatars.githubusercontent.com/u/157234?v=3","gravatar_id":"","url":"https://api.github.com/users/truncs","html_url":"https://github.com/truncs","followers_url":"https://api.github.com/users/truncs/followers","following_url":"https://api.github.com/users/truncs/following{/other_user}","gists_url":"https://api.github.com/users/truncs/gists{/gist_id}","starred_url":"https://api.github.com/users/truncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truncs/subscriptions","organizations_url":"https://api.github.com/users/truncs/orgs","repos_url":"https://api.github.com/users/truncs/repos","events_url":"https://api.github.com/users/truncs/events{/privacy}","received_events_url":"https://api.github.com/users/truncs/received_events","type":"User","site_admin":false},"body":"what does a TChannelError suppose to represent over here ?","created_at":"2015-10-16T23:15:08Z","updated_at":"2015-10-16T23:15:08Z","html_url":"https://github.com/uber/tchannel-java/pull/85#discussion_r42299860","pull_request_url":"https://api.github.com/repos/uber/tchannel-java/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/comments/42299860"},"html":{"href":"https://github.com/uber/tchannel-java/pull/85#discussion_r42299860"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-java/pulls/85","id":47947589,"html_url":"https://github.com/uber/tchannel-java/pull/85","diff_url":"https://github.com/uber/tchannel-java/pull/85.diff","patch_url":"https://github.com/uber/tchannel-java/pull/85.patch","issue_url":"https://api.github.com/repos/uber/tchannel-java/issues/85","number":85,"state":"open","locked":false,"title":"Protocol v2, init handshake, init headers, etc.","user":{"login":"ShanniLi","id":5845092,"avatar_url":"https://avatars.githubusercontent.com/u/5845092?v=3","gravatar_id":"","url":"https://api.github.com/users/ShanniLi","html_url":"https://github.com/ShanniLi","followers_url":"https://api.github.com/users/ShanniLi/followers","following_url":"https://api.github.com/users/ShanniLi/following{/other_user}","gists_url":"https://api.github.com/users/ShanniLi/gists{/gist_id}","starred_url":"https://api.github.com/users/ShanniLi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShanniLi/subscriptions","organizations_url":"https://api.github.com/users/ShanniLi/orgs","repos_url":"https://api.github.com/users/ShanniLi/repos","events_url":"https://api.github.com/users/ShanniLi/events{/privacy}","received_events_url":"https://api.github.com/users/ShanniLi/received_events","type":"User","site_admin":false},"body":"Efforts to make tchannel-java talking to other languages & Hyperbahn:\r\n1. Init req/res handshake should finish before other req/res can start: tchannel v2 protocol\r\n2. Init req/res should have the host_port set when listen. It should use \"0.0.0.0:0\" otherwise for ephemeral ports.\r\n3. Connection pool and peer selection support, e.g., should be able to prefer Hyperbahn affinity connections. \r\n\r\nr: @willsalz @truncs @anson627 \r\n\r\nI feel this is enough for the first step to unblock Hyperbahn client & talking to other languages. The are still many places to improve. E.g., the connection pool can be a bottleneck for multi-threading. It can be relieved by read-write locks. But all for next steps.","created_at":"2015-10-16T19:01:14Z","updated_at":"2015-10-16T23:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5d092cb677f5f23ee09bded607613348468ce8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-java/pulls/85/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-java/pulls/85/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-java/issues/85/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/dcc2f56059705ed059d18801475dd03054cac3a9","head":{"label":"uber:protocol-v2","ref":"protocol-v2","sha":"dcc2f56059705ed059d18801475dd03054cac3a9","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":39764417,"name":"tchannel-java","full_name":"uber/tchannel-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-java","description":"A Java implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-java","forks_url":"https://api.github.com/repos/uber/tchannel-java/forks","keys_url":"https://api.github.com/repos/uber/tchannel-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-java/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-java/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-java/events","assignees_url":"https://api.github.com/repos/uber/tchannel-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-java/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-java/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-java/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-java/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-java/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-java/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-java/merges","archive_url":"https://api.github.com/repos/uber/tchannel-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-java/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-java/releases{/id}","created_at":"2015-07-27T08:49:33Z","updated_at":"2015-10-15T09:01:39Z","pushed_at":"2015-10-16T22:50:22Z","git_url":"git://github.com/uber/tchannel-java.git","ssh_url":"git@github.com:uber/tchannel-java.git","clone_url":"https://github.com/uber/tchannel-java.git","svn_url":"https://github.com/uber/tchannel-java","homepage":"","size":1000,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":31,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"c435190da7cae7a1b42093a2e2ff11caf125a039","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":39764417,"name":"tchannel-java","full_name":"uber/tchannel-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-java","description":"A Java implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-java","forks_url":"https://api.github.com/repos/uber/tchannel-java/forks","keys_url":"https://api.github.com/repos/uber/tchannel-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-java/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-java/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-java/events","assignees_url":"https://api.github.com/repos/uber/tchannel-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-java/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-java/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-java/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-java/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-java/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-java/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-java/merges","archive_url":"https://api.github.com/repos/uber/tchannel-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-java/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-java/releases{/id}","created_at":"2015-07-27T08:49:33Z","updated_at":"2015-10-15T09:01:39Z","pushed_at":"2015-10-16T22:50:22Z","git_url":"git://github.com/uber/tchannel-java.git","ssh_url":"git@github.com:uber/tchannel-java.git","clone_url":"https://github.com/uber/tchannel-java.git","svn_url":"https://github.com/uber/tchannel-java","homepage":"","size":1000,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/85"},"html":{"href":"https://github.com/uber/tchannel-java/pull/85"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-java/issues/85"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-java/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-java/statuses/dcc2f56059705ed059d18801475dd03054cac3a9"}}}}