{"action":"created","comment":{"url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/comments/37899129","id":37899129,"diff_hunk":"@@ -5,27 +5,80 @@ var fs = require(\"fs\");\n var path = require(\"path\");\n var AdmZip = require(\"adm-zip\");\n var events = require(\"events\");\n+var rmdir = require(\"rimraf\"); // I still don't believe this is really a thing\n+var pluginParser = require('./plugin-parser.js');\n \n var fileName = null;\n+var localState = null;","path":"plugin.js","position":8,"original_position":8,"commit_id":"26e546db3681e2c48b8bffed79d1a1b2c52930fc","original_commit_id":"26e546db3681e2c48b8bffed79d1a1b2c52930fc","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"body":"@0xPoly can you help me understand the purpose of `localState` here? I see that it is saved when delete buttons are bound (i.e. if I understand correctly after configure.js populates the plugins grid). I also see that it is used when the plugin is installed. Is this saved because otherwise you cannot access the state from `installPlugin()`? Asking because I find it quite confusing to have this local copy here.","created_at":"2015-08-25T18:13:10Z","updated_at":"2015-08-25T18:13:10Z","html_url":"https://github.com/measurement-kit/network-meter/pull/16#discussion_r37899129","pull_request_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/comments/37899129"},"html":{"href":"https://github.com/measurement-kit/network-meter/pull/16#discussion_r37899129"},"pull_request":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16","id":41906976,"html_url":"https://github.com/measurement-kit/network-meter/pull/16","diff_url":"https://github.com/measurement-kit/network-meter/pull/16.diff","patch_url":"https://github.com/measurement-kit/network-meter/pull/16.patch","issue_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/16","number":16,"state":"open","locked":false,"title":"Plugin manager","user":{"login":"0xPoly","id":2194999,"avatar_url":"https://avatars.githubusercontent.com/u/2194999?v=3","gravatar_id":"","url":"https://api.github.com/users/0xPoly","html_url":"https://github.com/0xPoly","followers_url":"https://api.github.com/users/0xPoly/followers","following_url":"https://api.github.com/users/0xPoly/following{/other_user}","gists_url":"https://api.github.com/users/0xPoly/gists{/gist_id}","starred_url":"https://api.github.com/users/0xPoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xPoly/subscriptions","organizations_url":"https://api.github.com/users/0xPoly/orgs","repos_url":"https://api.github.com/users/0xPoly/repos","events_url":"https://api.github.com/users/0xPoly/events{/privacy}","received_events_url":"https://api.github.com/users/0xPoly/received_events","type":"User","site_admin":false},"body":"Plugin management interface implemented under the \"Install\" submenu. Installation and uninstallation fully supported. Find sample packaged plugin in packaged-plugins/ for installation testing.\r\n\r\nDuplicate handling bug as described in #15 will be solved in subsequent branches.","created_at":"2015-08-07T16:02:09Z","updated_at":"2015-08-25T18:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61f750210b3e16ce50258c60e300d49b783da4a7","assignee":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16/commits","review_comments_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16/comments","review_comment_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/16/comments","statuses_url":"https://api.github.com/repos/measurement-kit/network-meter/statuses/26e546db3681e2c48b8bffed79d1a1b2c52930fc","head":{"label":"measurement-kit:plugin-manager-2","ref":"plugin-manager-2","sha":"26e546db3681e2c48b8bffed79d1a1b2c52930fc","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":35334187,"name":"network-meter","full_name":"measurement-kit/network-meter","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/network-meter","description":"Graphical frontend for various network tests","fork":false,"url":"https://api.github.com/repos/measurement-kit/network-meter","forks_url":"https://api.github.com/repos/measurement-kit/network-meter/forks","keys_url":"https://api.github.com/repos/measurement-kit/network-meter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/network-meter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/network-meter/teams","hooks_url":"https://api.github.com/repos/measurement-kit/network-meter/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/network-meter/events","assignees_url":"https://api.github.com/repos/measurement-kit/network-meter/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/network-meter/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/network-meter/tags","blobs_url":"https://api.github.com/repos/measurement-kit/network-meter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/network-meter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/network-meter/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/network-meter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/network-meter/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/network-meter/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/network-meter/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/network-meter/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/network-meter/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/network-meter/subscription","commits_url":"https://api.github.com/repos/measurement-kit/network-meter/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/network-meter/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/network-meter/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/network-meter/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/network-meter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/network-meter/merges","archive_url":"https://api.github.com/repos/measurement-kit/network-meter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/network-meter/downloads","issues_url":"https://api.github.com/repos/measurement-kit/network-meter/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/network-meter/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/network-meter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/network-meter/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/network-meter/releases{/id}","created_at":"2015-05-09T15:42:30Z","updated_at":"2015-07-06T23:06:53Z","pushed_at":"2015-08-16T18:17:40Z","git_url":"git://github.com/measurement-kit/network-meter.git","ssh_url":"git@github.com:measurement-kit/network-meter.git","clone_url":"https://github.com/measurement-kit/network-meter.git","svn_url":"https://github.com/measurement-kit/network-meter","homepage":"","size":662,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"measurement-kit:master","ref":"master","sha":"d57f282b46ca2f3bf355569eab71b85f1e624355","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":35334187,"name":"network-meter","full_name":"measurement-kit/network-meter","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/network-meter","description":"Graphical frontend for various network tests","fork":false,"url":"https://api.github.com/repos/measurement-kit/network-meter","forks_url":"https://api.github.com/repos/measurement-kit/network-meter/forks","keys_url":"https://api.github.com/repos/measurement-kit/network-meter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/network-meter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/network-meter/teams","hooks_url":"https://api.github.com/repos/measurement-kit/network-meter/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/network-meter/events","assignees_url":"https://api.github.com/repos/measurement-kit/network-meter/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/network-meter/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/network-meter/tags","blobs_url":"https://api.github.com/repos/measurement-kit/network-meter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/network-meter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/network-meter/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/network-meter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/network-meter/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/network-meter/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/network-meter/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/network-meter/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/network-meter/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/network-meter/subscription","commits_url":"https://api.github.com/repos/measurement-kit/network-meter/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/network-meter/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/network-meter/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/network-meter/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/network-meter/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/network-meter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/network-meter/merges","archive_url":"https://api.github.com/repos/measurement-kit/network-meter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/network-meter/downloads","issues_url":"https://api.github.com/repos/measurement-kit/network-meter/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/network-meter/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/network-meter/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/network-meter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/network-meter/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/network-meter/releases{/id}","created_at":"2015-05-09T15:42:30Z","updated_at":"2015-07-06T23:06:53Z","pushed_at":"2015-08-16T18:17:40Z","git_url":"git://github.com/measurement-kit/network-meter.git","ssh_url":"git@github.com:measurement-kit/network-meter.git","clone_url":"https://github.com/measurement-kit/network-meter.git","svn_url":"https://github.com/measurement-kit/network-meter","homepage":"","size":662,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16"},"html":{"href":"https://github.com/measurement-kit/network-meter/pull/16"},"issue":{"href":"https://api.github.com/repos/measurement-kit/network-meter/issues/16"},"comments":{"href":"https://api.github.com/repos/measurement-kit/network-meter/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/measurement-kit/network-meter/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/measurement-kit/network-meter/statuses/26e546db3681e2c48b8bffed79d1a1b2c52930fc"}}}}