{"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/tcollector/pulls/comments/28262887","id":28262887,"diff_hunk":"@@ -107,12 +134,24 @@ def topic_offsets(group, topic):\n \n     @staticmethod\n     def consumer_topic_partition(group, topic, partition):\n-        return KafkaPaths.topic_offsets(group, topic) + '/' + partition\n+        return '%s/%d' % (KafkaPaths.topic_offsets(group, topic), partition)","path":"collectors/30/kafka_offset_collector.py","position":87,"original_position":87,"commit_id":"d7c76a836e1d2f285a3680580bdb42c10dde86d9","original_commit_id":"d7c76a836e1d2f285a3680580bdb42c10dde86d9","user":{"login":"asp2insp","id":1114881,"avatar_url":"https://avatars.githubusercontent.com/u/1114881?v=3","gravatar_id":"","url":"https://api.github.com/users/asp2insp","html_url":"https://github.com/asp2insp","followers_url":"https://api.github.com/users/asp2insp/followers","following_url":"https://api.github.com/users/asp2insp/following{/other_user}","gists_url":"https://api.github.com/users/asp2insp/gists{/gist_id}","starred_url":"https://api.github.com/users/asp2insp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asp2insp/subscriptions","organizations_url":"https://api.github.com/users/asp2insp/orgs","repos_url":"https://api.github.com/users/asp2insp/repos","events_url":"https://api.github.com/users/asp2insp/events{/privacy}","received_events_url":"https://api.github.com/users/asp2insp/received_events","type":"User","site_admin":false},"body":"Yes, also throws a better error message if you mess it up","created_at":"2015-04-13T18:09:54Z","updated_at":"2015-04-13T18:09:54Z","html_url":"https://github.com/optimizely/tcollector/pull/31#discussion_r28262887","pull_request_url":"https://api.github.com/repos/optimizely/tcollector/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/comments/28262887"},"html":{"href":"https://github.com/optimizely/tcollector/pull/31#discussion_r28262887"},"pull_request":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/optimizely/tcollector/pulls/31","id":32895422,"html_url":"https://github.com/optimizely/tcollector/pull/31","diff_url":"https://github.com/optimizely/tcollector/pull/31.diff","patch_url":"https://github.com/optimizely/tcollector/pull/31.patch","issue_url":"https://api.github.com/repos/optimizely/tcollector/issues/31","number":31,"state":"open","locked":false,"title":"Fix Kafka Monitoring collector","user":{"login":"asp2insp","id":1114881,"avatar_url":"https://avatars.githubusercontent.com/u/1114881?v=3","gravatar_id":"","url":"https://api.github.com/users/asp2insp","html_url":"https://github.com/asp2insp","followers_url":"https://api.github.com/users/asp2insp/followers","following_url":"https://api.github.com/users/asp2insp/following{/other_user}","gists_url":"https://api.github.com/users/asp2insp/gists{/gist_id}","starred_url":"https://api.github.com/users/asp2insp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asp2insp/subscriptions","organizations_url":"https://api.github.com/users/asp2insp/orgs","repos_url":"https://api.github.com/users/asp2insp/repos","events_url":"https://api.github.com/users/asp2insp/events{/privacy}","received_events_url":"https://api.github.com/users/asp2insp/received_events","type":"User","site_admin":false},"body":"Kafka offset collector hasn't been working. This change fixes it to catch more errors and to pull configuration from zookeeper rather than hardcoded strings/env variables.\r\n\r\n@mustpax @mikecdavis for review","created_at":"2015-04-08T19:52:06Z","updated_at":"2015-04-13T18:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdd3dc404a97d1c82b1bba128472be1ed4133640","assignee":{"login":"mikecdavis","id":1435444,"avatar_url":"https://avatars.githubusercontent.com/u/1435444?v=3","gravatar_id":"","url":"https://api.github.com/users/mikecdavis","html_url":"https://github.com/mikecdavis","followers_url":"https://api.github.com/users/mikecdavis/followers","following_url":"https://api.github.com/users/mikecdavis/following{/other_user}","gists_url":"https://api.github.com/users/mikecdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikecdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikecdavis/subscriptions","organizations_url":"https://api.github.com/users/mikecdavis/orgs","repos_url":"https://api.github.com/users/mikecdavis/repos","events_url":"https://api.github.com/users/mikecdavis/events{/privacy}","received_events_url":"https://api.github.com/users/mikecdavis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/tcollector/pulls/31/commits","review_comments_url":"https://api.github.com/repos/optimizely/tcollector/pulls/31/comments","review_comment_url":"https://api.github.com/repos/optimizely/tcollector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/tcollector/issues/31/comments","statuses_url":"https://api.github.com/repos/optimizely/tcollector/statuses/d7c76a836e1d2f285a3680580bdb42c10dde86d9","head":{"label":"optimizely:josiah/get_kafka_from_zookeeper","ref":"josiah/get_kafka_from_zookeeper","sha":"d7c76a836e1d2f285a3680580bdb42c10dde86d9","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":13505232,"name":"tcollector","full_name":"optimizely/tcollector","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/tcollector","description":"Data collection framework for OpenTSDB","fork":true,"url":"https://api.github.com/repos/optimizely/tcollector","forks_url":"https://api.github.com/repos/optimizely/tcollector/forks","keys_url":"https://api.github.com/repos/optimizely/tcollector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/tcollector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/tcollector/teams","hooks_url":"https://api.github.com/repos/optimizely/tcollector/hooks","issue_events_url":"https://api.github.com/repos/optimizely/tcollector/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/tcollector/events","assignees_url":"https://api.github.com/repos/optimizely/tcollector/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/tcollector/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/tcollector/tags","blobs_url":"https://api.github.com/repos/optimizely/tcollector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/tcollector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/tcollector/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/tcollector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/tcollector/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/tcollector/languages","stargazers_url":"https://api.github.com/repos/optimizely/tcollector/stargazers","contributors_url":"https://api.github.com/repos/optimizely/tcollector/contributors","subscribers_url":"https://api.github.com/repos/optimizely/tcollector/subscribers","subscription_url":"https://api.github.com/repos/optimizely/tcollector/subscription","commits_url":"https://api.github.com/repos/optimizely/tcollector/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/tcollector/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/tcollector/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/tcollector/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/tcollector/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/tcollector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/tcollector/merges","archive_url":"https://api.github.com/repos/optimizely/tcollector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/tcollector/downloads","issues_url":"https://api.github.com/repos/optimizely/tcollector/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/tcollector/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/tcollector/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/tcollector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/tcollector/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/tcollector/releases{/id}","created_at":"2013-10-11T17:35:33Z","updated_at":"2015-04-02T22:56:10Z","pushed_at":"2015-04-08T23:58:34Z","git_url":"git://github.com/optimizely/tcollector.git","ssh_url":"git@github.com:optimizely/tcollector.git","clone_url":"https://github.com/optimizely/tcollector.git","svn_url":"https://github.com/optimizely/tcollector","homepage":"http://opentsdb.net","size":1218,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"8dd144563c68d30a6b108f1a50c44ef55792e78c","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":13505232,"name":"tcollector","full_name":"optimizely/tcollector","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/tcollector","description":"Data collection framework for OpenTSDB","fork":true,"url":"https://api.github.com/repos/optimizely/tcollector","forks_url":"https://api.github.com/repos/optimizely/tcollector/forks","keys_url":"https://api.github.com/repos/optimizely/tcollector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/tcollector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/tcollector/teams","hooks_url":"https://api.github.com/repos/optimizely/tcollector/hooks","issue_events_url":"https://api.github.com/repos/optimizely/tcollector/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/tcollector/events","assignees_url":"https://api.github.com/repos/optimizely/tcollector/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/tcollector/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/tcollector/tags","blobs_url":"https://api.github.com/repos/optimizely/tcollector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/tcollector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/tcollector/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/tcollector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/tcollector/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/tcollector/languages","stargazers_url":"https://api.github.com/repos/optimizely/tcollector/stargazers","contributors_url":"https://api.github.com/repos/optimizely/tcollector/contributors","subscribers_url":"https://api.github.com/repos/optimizely/tcollector/subscribers","subscription_url":"https://api.github.com/repos/optimizely/tcollector/subscription","commits_url":"https://api.github.com/repos/optimizely/tcollector/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/tcollector/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/tcollector/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/tcollector/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/tcollector/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/tcollector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/tcollector/merges","archive_url":"https://api.github.com/repos/optimizely/tcollector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/tcollector/downloads","issues_url":"https://api.github.com/repos/optimizely/tcollector/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/tcollector/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/tcollector/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/tcollector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/tcollector/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/tcollector/releases{/id}","created_at":"2013-10-11T17:35:33Z","updated_at":"2015-04-02T22:56:10Z","pushed_at":"2015-04-08T23:58:34Z","git_url":"git://github.com/optimizely/tcollector.git","ssh_url":"git@github.com:optimizely/tcollector.git","clone_url":"https://github.com/optimizely/tcollector.git","svn_url":"https://github.com/optimizely/tcollector","homepage":"http://opentsdb.net","size":1218,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/31"},"html":{"href":"https://github.com/optimizely/tcollector/pull/31"},"issue":{"href":"https://api.github.com/repos/optimizely/tcollector/issues/31"},"comments":{"href":"https://api.github.com/repos/optimizely/tcollector/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/tcollector/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/tcollector/statuses/d7c76a836e1d2f285a3680580bdb42c10dde86d9"}}}}