{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4683","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4683/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4683/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4683/events","html_url":"https://github.com/NREL/EnergyPlus/issues/4683","id":54944783,"number":4683,"title":"Wrapped condenser hpwh model","user":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/EnergyPlus","name":"EnergyPlus","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-01-20T21:47:08Z","updated_at":"2015-01-22T18:28:39Z","closed_at":null,"body":"Rename existing `WaterHeater:HeatPump` to `WaterHeater:HeatPumpPumpedCondenser`. Create a new idf object for residential heat pump water heaters called `WaterHeater:HeatPumpWrappedCondenser`. The new object will be different in the following ways:\r\n\r\n - `WaterHeater:HeatPumpWrappedCondenser` will only be compatible with a `WaterHeater:Stratified` tank (and `WaterHeater:HeatPumpPumpedCondenser` will only be compatible with a `WaterHeater:Mixed` tank)\r\n - Inputs relating to condenser water pumping will be removed.\r\n - Add inputs relating to the location of the condenser on the tank and change heat transfer calculation to allow for a distribution of heat to come in across several nodes.\r\n - Include warnings if the timestep is too long for reasonable results. Also, warn if not using subhourly draw profiles."},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/71071559","html_url":"https://github.com/NREL/EnergyPlus/issues/4683#issuecomment-71071559","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4683","id":71071559,"user":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T18:28:39Z","updated_at":"2015-01-22T18:28:39Z","body":"Yes, this is. Good point. Maybe I’ll do this more in pull request form.\r\n\r\nOn Jan 22, 2015, at 11:19 AM, Edwin Lee <notifications@github.com<mailto:notifications@github.com>> wrote:\r\n\r\n\r\n@nmerket<https://github.com/nmerket> This is the HPWH new feature work, right? I don't mind if you make GitHub issues for the work, but I also don't mind if you don't. You can use Pivotal for planning/tracking, and then just create a branch/pull request sooner rather than later to have conversations about specific code. Whatever works best for you is fine.\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/NREL/EnergyPlus/issues/4683#issuecomment-71069792>."}}