{"action":"created","issue":{"url":"https://api.github.com/repos/siacs/Conversations/issues/923","labels_url":"https://api.github.com/repos/siacs/Conversations/issues/923/labels{/name}","comments_url":"https://api.github.com/repos/siacs/Conversations/issues/923/comments","events_url":"https://api.github.com/repos/siacs/Conversations/issues/923/events","html_url":"https://github.com/siacs/Conversations/pull/923","id":55288540,"number":923,"title":"Start experimenting with material design icons","user":{"login":"SamWhited","id":512573,"avatar_url":"https://avatars.githubusercontent.com/u/512573?v=3","gravatar_id":"","url":"https://api.github.com/users/SamWhited","html_url":"https://github.com/SamWhited","followers_url":"https://api.github.com/users/SamWhited/followers","following_url":"https://api.github.com/users/SamWhited/following{/other_user}","gists_url":"https://api.github.com/users/SamWhited/gists{/gist_id}","starred_url":"https://api.github.com/users/SamWhited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamWhited/subscriptions","organizations_url":"https://api.github.com/users/SamWhited/orgs","repos_url":"https://api.github.com/users/SamWhited/repos","events_url":"https://api.github.com/users/SamWhited/events{/privacy}","received_events_url":"https://api.github.com/users/SamWhited/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-23T14:44:09Z","updated_at":"2015-01-29T16:31:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/siacs/Conversations/pulls/923","html_url":"https://github.com/siacs/Conversations/pull/923","diff_url":"https://github.com/siacs/Conversations/pull/923.diff","patch_url":"https://github.com/siacs/Conversations/pull/923.patch"},"body":"@iNPUTmice and I had a few discussions in the conference about using material design icons; so I made a branch that uses them only for Android 5.0.\r\n\r\nThe icons which are set programatically are currently using a simple if statement that checks the API version; the \"correct\" way to do this would be to get the attribute resources as a typed array, extract the drawable ID, and recycle the array, but that doesn't necessarily work everywhere (it requires a context to get the resources), and this just feels lighter weight (even if it's potentially more error prone later as it requires manual updating if we were to change the icons again in another version).\r\n\r\nCurrently there are a lot of extraneous icons in this pull; those can be deleted easily enough after we get the sizes and what not narrowed down a bit.\r\n\r\nI used grey600 for the one place I found that a grey icon was needed; it may be better to do as someone else suggested and use the black icon and then set the opacity to 80%.\r\n\r\nIcons should probably also be renamed (I've got them all as `ic_action_something` right now, but they're not all action icons).\r\n\r\n## TODO:\r\n\r\n - [x] Decide if sizes are correct\r\n - [x] Remove unused sizes\r\n - [x] ~~Add SVG version of icons~~ (will figure this out later; I might have dreamed that Android 5.0 supported SVGs natively)\r\n\r\n## Examples:\r\n\r\n![screenshot_2015-01-21-16-50-12](https://cloud.githubusercontent.com/assets/512573/5876234/b7f8434a-a2e3-11e4-9ed2-270d91b6d387.png)\r\n\r\n ![screenshot_2015-01-21-16-50-28](https://cloud.githubusercontent.com/assets/512573/5876235/b7fd1636-a2e3-11e4-9cc5-0244e5d3bef9.png) ![screenshot_2015-01-23-09-32-20](https://cloud.githubusercontent.com/assets/512573/5876237/b8066bd2-a2e3-11e4-84fc-766a6136c295.png)\r\n![screenshot_2015-01-23-09-32-52](https://cloud.githubusercontent.com/assets/512573/5876236/b8049f32-a2e3-11e4-957b-aa785c57486b.png)\r\n![screenshot_2015-01-23-09-32-58](https://cloud.githubusercontent.com/assets/512573/5876238/b809d8ee-a2e3-11e4-8f75-9d9aabb293d9.png)\r\n![screenshot_2015-01-23-09-33-08](https://cloud.githubusercontent.com/assets/512573/5876239/b8102a82-a2e3-11e4-8cf2-035d9a6215a3.png)\r\n"},"comment":{"url":"https://api.github.com/repos/siacs/Conversations/issues/comments/72055906","html_url":"https://github.com/siacs/Conversations/pull/923#issuecomment-72055906","issue_url":"https://api.github.com/repos/siacs/Conversations/issues/923","id":72055906,"user":{"login":"SamWhited","id":512573,"avatar_url":"https://avatars.githubusercontent.com/u/512573?v=3","gravatar_id":"","url":"https://api.github.com/users/SamWhited","html_url":"https://github.com/SamWhited","followers_url":"https://api.github.com/users/SamWhited/followers","following_url":"https://api.github.com/users/SamWhited/following{/other_user}","gists_url":"https://api.github.com/users/SamWhited/gists{/gist_id}","starred_url":"https://api.github.com/users/SamWhited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamWhited/subscriptions","organizations_url":"https://api.github.com/users/SamWhited/orgs","repos_url":"https://api.github.com/users/SamWhited/repos","events_url":"https://api.github.com/users/SamWhited/events{/privacy}","received_events_url":"https://api.github.com/users/SamWhited/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T16:31:51Z","updated_at":"2015-01-29T16:31:51Z","body":"Oops, good catch. Fixed (I think; I don't have an easy way to test this right now unless I just add the icon to the permanent notification temporarily or something).\r\n\r\nI also shrunk it a bit as I suspect that's another place it would look huge (I had the other notification icons at 36dp)."}}