{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/27949555","id":27949555,"diff_hunk":"@@ -14,11 +14,70 @@\n         this._chartType = \"LineChart\";\n     };\n     Line.prototype = Object.create(CommonND.prototype);\n-    //  TODO:  Publish Line Properties Here\n+    \n+    Line.prototype.publish(\"lineWidth\", 2, \"number\", \"Line Width\");\n+    Line.prototype.publish(\"gloabLineDashStyle\", [], \"array\", \"Line Dash Style\");\n+    Line.prototype.publish(\"lineDashStyle\", [], \"array\", \"Line Dash Style\");\n+    \n+    Line.prototype.publish(\"orientation\", \"horizontal\", \"set\", \"Line Dash Style\", [\"horizontal\",\"vertical\"]);\n \n+    Line.prototype.publish(\"globalPointSize\", null, \"number\", \"Diameter of displayed points in pixels\");\n+    Line.prototype.publish(\"pointSize\", [], \"array\", \"Diameter of displayed points in pixels\");\n+\n+    Line.prototype.publish(\"globalPointShape\", null, \"set\", \"The shape of individual data elements\", [\"circle\",\"triagle\",\"square\",\"diamond\",\"star\",\"polygon\"]);\n+    Line.prototype.publish(\"pointShape\", [], \"array\", \"The shape of individual data elements\"); //ex: [circle,triangle] .... would be nice to work with this like set but no method yet ... can also be an obj but we will look at that later  ... https://developers.google.com/chart/interactive/docs/points#jsonly\n+    \n+    // Line & Area\n+    Line.prototype.publish(\"hAxisAllowContainerBoundaryTextCufoff\", false, \"boolean\", \"Hide outermost labels rather than allow them to be cropped by the chart container.\");\n+    Line.prototype.publish(\"hAxisSlantedText\", null, \"boolean\", \"Draw the horizontal axis text at an angle\");\n+    Line.prototype.publish(\"hAxisSlantedTextAngle\", 30, \"number\", \"The angle of the horizontal axis text\");\n+    Line.prototype.publish(\"hAxisMaxAlternation\", 2, \"number\", \"Maximum number of levels of horizontal axis text\");\n+    Line.prototype.publish(\"hAxisMaxTextLines\", null, \"number\", \"Maximum number of lines allowed for the text labels\");\n+    Line.prototype.publish(\"hAxisMinTextSpacing\", null, \"number\", \"Minimum horizontal spacing, in pixels, allowed between two adjacent text labels\");\n+    \n+    \n+    \n     Line.prototype.getChartOptions = function () {\n         var retVal = CommonND.prototype.getChartOptions.apply(this, arguments);\n         //  TODO:  Add Line Properties Here\n+        retVal.lineWidth = this._lineWidth;\n+        retVal.lineDashStyle = this._gloabLineDashStyle;\n+        retVal.orientation = this._orientation;\n+        retVal.pointShape = this._globalPointShape;\n+        retVal.pointSize = this._globalPointSize;\n+        \n+        retVal.hAxis.hAxisAllowContainerBoundaryTextCufoff = this._hAxisAllowContainerBoundaryTextCufoff;\n+        retVal.hAxis.slantedText = this._hAxisSlantedText;\n+        retVal.hAxis.slantedTextAngle = this._hAxisSlantedTextAngle;\n+        retVal.hAxis.maxAlternation = this._hAxisMaxAlternation;\n+        retVal.hAxis.maxTextLines = this._hAxisMaxTextLines;\n+        retVal.hAxis.minTextSpacing = this._hAxisMinTextSpacing;\n+        \n+        \n+        \n+        // should we loop the series and apply each or loop each param like below?\n+        ","path":"widgets/src/google/Line.js","position":47,"original_position":47,"commit_id":"594a0b9e72095ac75dfef73b9b9916334858daa5","original_commit_id":"594a0b9e72095ac75dfef73b9b9916334858daa5","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"This looks fine - remove blank lines and comment","created_at":"2015-04-08T07:58:04Z","updated_at":"2015-04-08T07:58:04Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/284#discussion_r27949555","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/27949555"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/284#discussion_r27949555"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284","id":32769239,"html_url":"https://github.com/hpcc-systems/Visualization/pull/284","diff_url":"https://github.com/hpcc-systems/Visualization/pull/284.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/284.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/284","number":284,"state":"open","locked":false,"title":"Adds more publish params","user":{"login":"mlzummo","id":1057527,"avatar_url":"https://avatars.githubusercontent.com/u/1057527?v=3","gravatar_id":"","url":"https://api.github.com/users/mlzummo","html_url":"https://github.com/mlzummo","followers_url":"https://api.github.com/users/mlzummo/followers","following_url":"https://api.github.com/users/mlzummo/following{/other_user}","gists_url":"https://api.github.com/users/mlzummo/gists{/gist_id}","starred_url":"https://api.github.com/users/mlzummo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlzummo/subscriptions","organizations_url":"https://api.github.com/users/mlzummo/orgs","repos_url":"https://api.github.com/users/mlzummo/repos","events_url":"https://api.github.com/users/mlzummo/events{/privacy}","received_events_url":"https://api.github.com/users/mlzummo/received_events","type":"User","site_admin":false},"body":"@GordonSmith @jbrundage @gururx \r\n\r\nPlease Review\r\n\r\nSigned-off-by: Mathew Zummo <mzummo@gmail.com>","created_at":"2015-04-07T14:31:13Z","updated_at":"2015-04-08T07:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fd351d38d6408557448c3d7403b79aede58e695","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/284/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/594a0b9e72095ac75dfef73b9b9916334858daa5","head":{"label":"mlzummo:GOOGLE_P_PARAMS","ref":"GOOGLE_P_PARAMS","sha":"594a0b9e72095ac75dfef73b9b9916334858daa5","user":{"login":"mlzummo","id":1057527,"avatar_url":"https://avatars.githubusercontent.com/u/1057527?v=3","gravatar_id":"","url":"https://api.github.com/users/mlzummo","html_url":"https://github.com/mlzummo","followers_url":"https://api.github.com/users/mlzummo/followers","following_url":"https://api.github.com/users/mlzummo/following{/other_user}","gists_url":"https://api.github.com/users/mlzummo/gists{/gist_id}","starred_url":"https://api.github.com/users/mlzummo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlzummo/subscriptions","organizations_url":"https://api.github.com/users/mlzummo/orgs","repos_url":"https://api.github.com/users/mlzummo/repos","events_url":"https://api.github.com/users/mlzummo/events{/privacy}","received_events_url":"https://api.github.com/users/mlzummo/received_events","type":"User","site_admin":false},"repo":{"id":29352569,"name":"Visualization","full_name":"mlzummo/Visualization","owner":{"login":"mlzummo","id":1057527,"avatar_url":"https://avatars.githubusercontent.com/u/1057527?v=3","gravatar_id":"","url":"https://api.github.com/users/mlzummo","html_url":"https://github.com/mlzummo","followers_url":"https://api.github.com/users/mlzummo/followers","following_url":"https://api.github.com/users/mlzummo/following{/other_user}","gists_url":"https://api.github.com/users/mlzummo/gists{/gist_id}","starred_url":"https://api.github.com/users/mlzummo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlzummo/subscriptions","organizations_url":"https://api.github.com/users/mlzummo/orgs","repos_url":"https://api.github.com/users/mlzummo/repos","events_url":"https://api.github.com/users/mlzummo/events{/privacy}","received_events_url":"https://api.github.com/users/mlzummo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlzummo/Visualization","description":"Common Visualization Components","fork":true,"url":"https://api.github.com/repos/mlzummo/Visualization","forks_url":"https://api.github.com/repos/mlzummo/Visualization/forks","keys_url":"https://api.github.com/repos/mlzummo/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlzummo/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlzummo/Visualization/teams","hooks_url":"https://api.github.com/repos/mlzummo/Visualization/hooks","issue_events_url":"https://api.github.com/repos/mlzummo/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/mlzummo/Visualization/events","assignees_url":"https://api.github.com/repos/mlzummo/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/mlzummo/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/mlzummo/Visualization/tags","blobs_url":"https://api.github.com/repos/mlzummo/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlzummo/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlzummo/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlzummo/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlzummo/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/mlzummo/Visualization/languages","stargazers_url":"https://api.github.com/repos/mlzummo/Visualization/stargazers","contributors_url":"https://api.github.com/repos/mlzummo/Visualization/contributors","subscribers_url":"https://api.github.com/repos/mlzummo/Visualization/subscribers","subscription_url":"https://api.github.com/repos/mlzummo/Visualization/subscription","commits_url":"https://api.github.com/repos/mlzummo/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlzummo/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlzummo/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlzummo/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlzummo/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/mlzummo/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlzummo/Visualization/merges","archive_url":"https://api.github.com/repos/mlzummo/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlzummo/Visualization/downloads","issues_url":"https://api.github.com/repos/mlzummo/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/mlzummo/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/mlzummo/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/mlzummo/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlzummo/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/mlzummo/Visualization/releases{/id}","created_at":"2015-01-16T14:49:53Z","updated_at":"2015-04-06T18:41:52Z","pushed_at":"2015-04-07T18:14:57Z","git_url":"git://github.com/mlzummo/Visualization.git","ssh_url":"git@github.com:mlzummo/Visualization.git","clone_url":"https://github.com/mlzummo/Visualization.git","svn_url":"https://github.com/mlzummo/Visualization","homepage":"","size":4506,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"cf3f6fe99641982844f167275ff81eaccc1b40eb","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"Common Visualization Components","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","created_at":"2014-07-22T19:13:04Z","updated_at":"2015-04-07T08:14:51Z","pushed_at":"2015-04-07T18:14:58Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"","size":6217,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":23,"forks":13,"open_issues":23,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/284"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/284"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/594a0b9e72095ac75dfef73b9b9916334858daa5"}}}}