{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/26326030","id":26326030,"diff_hunk":"@@ -71,6 +74,15 @@ func (rs *REST) Create(ctx kapi.Context, obj runtime.Object) (runtime.Object, er\n \t\treturn nil, errors.NewConflict(\"route\", route.Namespace, fmt.Errorf(\"Route.Namespace does not match the provided context\"))\n \t}\n \n+\tshard, allocError := rs.allocator.Allocate(route)","path":"pkg/route/registry/route/rest.go","position":27,"original_position":27,"commit_id":"0df5eb2512f4eeb65006f5b081e841396fc60382","original_commit_id":"0df5eb2512f4eeb65006f5b081e841396fc60382","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"body":"Yeah, the ```err``` and ```errs``` names were already used up in that function.","created_at":"2015-03-12T17:45:49Z","updated_at":"2015-03-12T17:45:49Z","html_url":"https://github.com/openshift/origin/pull/1291#discussion_r26326030","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/1291","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/26326030"},"html":{"href":"https://github.com/openshift/origin/pull/1291#discussion_r26326030"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/1291"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1291","id":31002765,"html_url":"https://github.com/openshift/origin/pull/1291","diff_url":"https://github.com/openshift/origin/pull/1291.diff","patch_url":"https://github.com/openshift/origin/pull/1291.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/1291","number":1291,"state":"open","locked":false,"title":"Autogenerate route names if host is not specified  - second version with plugin based allocator support","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"body":"Autogenerate route names (if none is specified) using allocator plugins (currently defaults to using the simple single/unsharded router allocation scheme).\r\n\r\n@smarterclayton / @pweil-  PTAL  - This is version 2 of the original PR : https://github.com/openshift/origin/pull/1250\r\n\r\nUnit tests pass (make check) and integration tested this with the sample app https://github.com/ramr/origin/tree/master/examples/sample-app - removing the \"host\" defined for the frontend in examples/sample-app/application-template-stibuild.json and getting one to autogenerate based on the service + namespace.\r\n\r\n```     \r\n$ osc get -n test routes     \r\nNAME                HOST/PORT                        PATH                SERVICE             LABELS    \r\nroute-edge          frontend-test.v3.openshift.com                       frontend            template=application-template-stibuild     \r\n```    ","created_at":"2015-03-12T02:06:01Z","updated_at":"2015-03-12T17:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3608a48a56cf2fe8a8832cdb427c51089ce3b1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/1291/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/1291/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1291/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/0df5eb2512f4eeb65006f5b081e841396fc60382","head":{"label":"ramr:hostgen","ref":"hostgen","sha":"0df5eb2512f4eeb65006f5b081e841396fc60382","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"repo":{"id":31566423,"name":"origin","full_name":"ramr/origin","owner":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramr/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/ramr/origin","forks_url":"https://api.github.com/repos/ramr/origin/forks","keys_url":"https://api.github.com/repos/ramr/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramr/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramr/origin/teams","hooks_url":"https://api.github.com/repos/ramr/origin/hooks","issue_events_url":"https://api.github.com/repos/ramr/origin/issues/events{/number}","events_url":"https://api.github.com/repos/ramr/origin/events","assignees_url":"https://api.github.com/repos/ramr/origin/assignees{/user}","branches_url":"https://api.github.com/repos/ramr/origin/branches{/branch}","tags_url":"https://api.github.com/repos/ramr/origin/tags","blobs_url":"https://api.github.com/repos/ramr/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramr/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramr/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramr/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramr/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/ramr/origin/languages","stargazers_url":"https://api.github.com/repos/ramr/origin/stargazers","contributors_url":"https://api.github.com/repos/ramr/origin/contributors","subscribers_url":"https://api.github.com/repos/ramr/origin/subscribers","subscription_url":"https://api.github.com/repos/ramr/origin/subscription","commits_url":"https://api.github.com/repos/ramr/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramr/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramr/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramr/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramr/origin/contents/{+path}","compare_url":"https://api.github.com/repos/ramr/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramr/origin/merges","archive_url":"https://api.github.com/repos/ramr/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramr/origin/downloads","issues_url":"https://api.github.com/repos/ramr/origin/issues{/number}","pulls_url":"https://api.github.com/repos/ramr/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/ramr/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/ramr/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramr/origin/labels{/name}","releases_url":"https://api.github.com/repos/ramr/origin/releases{/id}","created_at":"2015-03-02T22:18:42Z","updated_at":"2015-03-07T00:53:10Z","pushed_at":"2015-03-12T01:01:27Z","git_url":"git://github.com/ramr/origin.git","ssh_url":"git@github.com:ramr/origin.git","clone_url":"https://github.com/ramr/origin.git","svn_url":"https://github.com/ramr/origin","homepage":"https://openshift.github.io","size":48572,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0b417e5eaca2bafd408f1a35af67965bf1ab450e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-03-12T16:05:46Z","pushed_at":"2015-03-12T16:05:45Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":73057,"stargazers_count":307,"watchers_count":307,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":115,"forks":164,"open_issues":115,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/1291"},"html":{"href":"https://github.com/openshift/origin/pull/1291"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/1291"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/1291/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/1291/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/1291/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/0df5eb2512f4eeb65006f5b081e841396fc60382"}}}}