{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/175","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/175/comments","events_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/175/events","html_url":"https://github.com/theforeman/puppet-foreman/pull/175","id":31634168,"number":175,"title":"Refactor node.rb template","user":{"login":"igreg","id":3985,"avatar_url":"https://avatars.githubusercontent.com/u/3985?v=3","gravatar_id":"","url":"https://api.github.com/users/igreg","html_url":"https://github.com/igreg","followers_url":"https://api.github.com/users/igreg/followers","following_url":"https://api.github.com/users/igreg/following{/other_user}","gists_url":"https://api.github.com/users/igreg/gists{/gist_id}","starred_url":"https://api.github.com/users/igreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igreg/subscriptions","organizations_url":"https://api.github.com/users/igreg/orgs","repos_url":"https://api.github.com/users/igreg/repos","events_url":"https://api.github.com/users/igreg/events{/privacy}","received_events_url":"https://api.github.com/users/igreg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-04-16T11:40:59Z","updated_at":"2015-02-03T11:02:55Z","closed_at":"2015-02-03T10:55:58Z","pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/175","html_url":"https://github.com/theforeman/puppet-foreman/pull/175","diff_url":"https://github.com/theforeman/puppet-foreman/pull/175.diff","patch_url":"https://github.com/theforeman/puppet-foreman/pull/175.patch"},"body":"Please provide feedback only.\r\nThis PR just include the new template.\r\n\r\nI spend a couple of days tidying up the code in external_node.rb.\r\nThe aim was to clean up some code that was hard to understand and make the file more maintainable.\r\nSome command line options have been altered although it is still very much backward compatible.\r\nAnd since the file is also linked to from various web pages, I have provided a way to configure it without altering the source code so it's easier to upgrade to a more recent version of the script manually.\r\n\r\n* Refactor / clean up existing code\r\n* Store configuration in `/etc/puppet/foreman.yaml` instead of requiring changes to the template itself\r\n* Add command line help\r\n* Replace `--push-facts-parallel` with `--push-facts --parallel`\r\n* Use the gem `rb-inotify` to watch file changes (simpler to use)"},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/comments/72632180","html_url":"https://github.com/theforeman/puppet-foreman/pull/175#issuecomment-72632180","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/175","id":72632180,"user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T11:02:55Z","updated_at":"2015-02-03T11:02:55Z","body":"Thanks for your effort anyway."}}