{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/26387551","id":26387551,"diff_hunk":"@@ -83,6 +83,12 @@ public function getUrlContent($url) {\n \t\t\t\tcurl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);\n \t\t\t\tcurl_setopt($curl, CURLOPT_MAXREDIRS, $max_redirects);\n \t\t\t\t$data = curl_exec($curl);\n+\t\t\t\t$code = curl_getinfo($curl, CURLINFO_HTTP_CODE);\n+\t\t\t\tif ($code != 200) {","path":"lib/private/httphelper.php","position":5,"original_position":5,"commit_id":"7b1048d13fb979c1754ac4a57d91d350140319a8","original_commit_id":"7b1048d13fb979c1754ac4a57d91d350140319a8","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"body":"As this is a generic helper changing this here is very likely to introduce other problems.\r\n\r\nAt the point where we are it would really make sense to introduce https://github.com/guzzle/guzzle\r\n\r\n@DeepDiver1975 Thoughts?","created_at":"2015-03-13T14:05:01Z","updated_at":"2015-03-13T14:05:01Z","html_url":"https://github.com/owncloud/core/pull/14869#discussion_r26387551","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/14869","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/26387551"},"html":{"href":"https://github.com/owncloud/core/pull/14869#discussion_r26387551"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/14869"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/14869","id":31118820,"html_url":"https://github.com/owncloud/core/pull/14869","diff_url":"https://github.com/owncloud/core/pull/14869.diff","patch_url":"https://github.com/owncloud/core/pull/14869.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/14869","number":14869,"state":"open","locked":false,"title":"Check if app archive is correctly downloaded and unpacked","user":{"login":"R1tschY","id":1450010,"avatar_url":"https://avatars.githubusercontent.com/u/1450010?v=3","gravatar_id":"","url":"https://api.github.com/users/R1tschY","html_url":"https://github.com/R1tschY","followers_url":"https://api.github.com/users/R1tschY/followers","following_url":"https://api.github.com/users/R1tschY/following{/other_user}","gists_url":"https://api.github.com/users/R1tschY/gists{/gist_id}","starred_url":"https://api.github.com/users/R1tschY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R1tschY/subscriptions","organizations_url":"https://api.github.com/users/R1tschY/orgs","repos_url":"https://api.github.com/users/R1tschY/repos","events_url":"https://api.github.com/users/R1tschY/events{/privacy}","received_events_url":"https://api.github.com/users/R1tschY/received_events","type":"User","site_admin":false},"body":"If app archive downloaded with status code other than 200, confusing error message is shown. For example if apps.owncloud.com returns status code 400: #14840 \r\n\r\nIt checks also whether archive is correctly unpacked.","created_at":"2015-03-13T11:39:19Z","updated_at":"2015-03-13T14:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"553bfe4e73f1007b4dee67248a70e2743f531b95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/14869/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/14869/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/14869/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/7b1048d13fb979c1754ac4a57d91d350140319a8","head":{"label":"R1tschY:installer_checks","ref":"installer_checks","sha":"7b1048d13fb979c1754ac4a57d91d350140319a8","user":{"login":"R1tschY","id":1450010,"avatar_url":"https://avatars.githubusercontent.com/u/1450010?v=3","gravatar_id":"","url":"https://api.github.com/users/R1tschY","html_url":"https://github.com/R1tschY","followers_url":"https://api.github.com/users/R1tschY/followers","following_url":"https://api.github.com/users/R1tschY/following{/other_user}","gists_url":"https://api.github.com/users/R1tschY/gists{/gist_id}","starred_url":"https://api.github.com/users/R1tschY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R1tschY/subscriptions","organizations_url":"https://api.github.com/users/R1tschY/orgs","repos_url":"https://api.github.com/users/R1tschY/repos","events_url":"https://api.github.com/users/R1tschY/events{/privacy}","received_events_url":"https://api.github.com/users/R1tschY/received_events","type":"User","site_admin":false},"repo":{"id":32149566,"name":"core","full_name":"R1tschY/core","owner":{"login":"R1tschY","id":1450010,"avatar_url":"https://avatars.githubusercontent.com/u/1450010?v=3","gravatar_id":"","url":"https://api.github.com/users/R1tschY","html_url":"https://github.com/R1tschY","followers_url":"https://api.github.com/users/R1tschY/followers","following_url":"https://api.github.com/users/R1tschY/following{/other_user}","gists_url":"https://api.github.com/users/R1tschY/gists{/gist_id}","starred_url":"https://api.github.com/users/R1tschY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R1tschY/subscriptions","organizations_url":"https://api.github.com/users/R1tschY/orgs","repos_url":"https://api.github.com/users/R1tschY/repos","events_url":"https://api.github.com/users/R1tschY/events{/privacy}","received_events_url":"https://api.github.com/users/R1tschY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/R1tschY/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/R1tschY/core","forks_url":"https://api.github.com/repos/R1tschY/core/forks","keys_url":"https://api.github.com/repos/R1tschY/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/R1tschY/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/R1tschY/core/teams","hooks_url":"https://api.github.com/repos/R1tschY/core/hooks","issue_events_url":"https://api.github.com/repos/R1tschY/core/issues/events{/number}","events_url":"https://api.github.com/repos/R1tschY/core/events","assignees_url":"https://api.github.com/repos/R1tschY/core/assignees{/user}","branches_url":"https://api.github.com/repos/R1tschY/core/branches{/branch}","tags_url":"https://api.github.com/repos/R1tschY/core/tags","blobs_url":"https://api.github.com/repos/R1tschY/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/R1tschY/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/R1tschY/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/R1tschY/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/R1tschY/core/statuses/{sha}","languages_url":"https://api.github.com/repos/R1tschY/core/languages","stargazers_url":"https://api.github.com/repos/R1tschY/core/stargazers","contributors_url":"https://api.github.com/repos/R1tschY/core/contributors","subscribers_url":"https://api.github.com/repos/R1tschY/core/subscribers","subscription_url":"https://api.github.com/repos/R1tschY/core/subscription","commits_url":"https://api.github.com/repos/R1tschY/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/R1tschY/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/R1tschY/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/R1tschY/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/R1tschY/core/contents/{+path}","compare_url":"https://api.github.com/repos/R1tschY/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/R1tschY/core/merges","archive_url":"https://api.github.com/repos/R1tschY/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/R1tschY/core/downloads","issues_url":"https://api.github.com/repos/R1tschY/core/issues{/number}","pulls_url":"https://api.github.com/repos/R1tschY/core/pulls{/number}","milestones_url":"https://api.github.com/repos/R1tschY/core/milestones{/number}","notifications_url":"https://api.github.com/repos/R1tschY/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/R1tschY/core/labels{/name}","releases_url":"https://api.github.com/repos/R1tschY/core/releases{/id}","created_at":"2015-03-13T10:22:19Z","updated_at":"2015-03-13T10:22:31Z","pushed_at":"2015-03-13T12:28:26Z","git_url":"git://github.com/R1tschY/core.git","ssh_url":"git@github.com:R1tschY/core.git","clone_url":"https://github.com/R1tschY/core.git","svn_url":"https://github.com/R1tschY/core","homepage":null,"size":163084,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"c546f0bf46a51dc297be15aa1acbca5ed9a84de9","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-03-13T13:36:02Z","pushed_at":"2015-03-13T13:46:32Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":953607,"stargazers_count":3128,"watchers_count":3128,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1004,"mirror_url":null,"open_issues_count":1826,"forks":1004,"open_issues":1826,"watchers":3128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/14869"},"html":{"href":"https://github.com/owncloud/core/pull/14869"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/14869"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/14869/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/14869/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/14869/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/7b1048d13fb979c1754ac4a57d91d350140319a8"}}}}