{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/35139193","id":35139193,"diff_hunk":"@@ -266,6 +274,7 @@ export class PathRecognizer {\n   generate(params: StringMap<string, any>): string {\n     var paramTokens = new TouchMap(params);\n     var applyLeadingSlash = false;\n+    var allowQS = this.isRoot && this.terminal;","path":"modules/angular2/src/router/path_recognizer.ts","position":77,"original_position":77,"commit_id":"a727a7638d18a3f5d8aaad1297fd81e13428f312","original_commit_id":"a727a7638d18a3f5d8aaad1297fd81e13428f312","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"body":"I used `useQueryString`","created_at":"2015-07-21T18:49:42Z","updated_at":"2015-07-21T18:49:42Z","html_url":"https://github.com/angular/angular/pull/3171#discussion_r35139193","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3171","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/35139193"},"html":{"href":"https://github.com/angular/angular/pull/3171#discussion_r35139193"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3171"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3171","id":40433538,"html_url":"https://github.com/angular/angular/pull/3171","diff_url":"https://github.com/angular/angular/pull/3171.diff","patch_url":"https://github.com/angular/angular/pull/3171.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3171","number":3171,"state":"open","locked":false,"title":"feat(router): use querystring params for top-level routes","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"body":"Closes #3017","created_at":"2015-07-21T08:31:00Z","updated_at":"2015-07-21T18:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93352c44ad7df0eab3afa17e2edd987ce9b24f83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/3171/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3171/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3171/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/a727a7638d18a3f5d8aaad1297fd81e13428f312","head":{"label":"matsko:query_params","ref":"query_params","sha":"a727a7638d18a3f5d8aaad1297fd81e13428f312","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"repo":{"id":33579552,"name":"angular","full_name":"matsko/angular","owner":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matsko/angular","description":"","fork":true,"url":"https://api.github.com/repos/matsko/angular","forks_url":"https://api.github.com/repos/matsko/angular/forks","keys_url":"https://api.github.com/repos/matsko/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsko/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsko/angular/teams","hooks_url":"https://api.github.com/repos/matsko/angular/hooks","issue_events_url":"https://api.github.com/repos/matsko/angular/issues/events{/number}","events_url":"https://api.github.com/repos/matsko/angular/events","assignees_url":"https://api.github.com/repos/matsko/angular/assignees{/user}","branches_url":"https://api.github.com/repos/matsko/angular/branches{/branch}","tags_url":"https://api.github.com/repos/matsko/angular/tags","blobs_url":"https://api.github.com/repos/matsko/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsko/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsko/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsko/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsko/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/matsko/angular/languages","stargazers_url":"https://api.github.com/repos/matsko/angular/stargazers","contributors_url":"https://api.github.com/repos/matsko/angular/contributors","subscribers_url":"https://api.github.com/repos/matsko/angular/subscribers","subscription_url":"https://api.github.com/repos/matsko/angular/subscription","commits_url":"https://api.github.com/repos/matsko/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsko/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsko/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsko/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsko/angular/contents/{+path}","compare_url":"https://api.github.com/repos/matsko/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsko/angular/merges","archive_url":"https://api.github.com/repos/matsko/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsko/angular/downloads","issues_url":"https://api.github.com/repos/matsko/angular/issues{/number}","pulls_url":"https://api.github.com/repos/matsko/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/matsko/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/matsko/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsko/angular/labels{/name}","releases_url":"https://api.github.com/repos/matsko/angular/releases{/id}","created_at":"2015-04-08T02:14:27Z","updated_at":"2015-06-08T18:07:37Z","pushed_at":"2015-07-21T08:43:48Z","git_url":"git://github.com/matsko/angular.git","ssh_url":"git@github.com:matsko/angular.git","clone_url":"https://github.com/matsko/angular.git","svn_url":"https://github.com/matsko/angular","homepage":null,"size":10681,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"b2a0be87e8934e48672d3f97c717fff600b0651b","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-07-21T18:33:31Z","pushed_at":"2015-07-21T18:49:11Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":36087,"stargazers_count":4320,"watchers_count":4320,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1127,"mirror_url":null,"open_issues_count":390,"forks":1127,"open_issues":390,"watchers":4320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3171"},"html":{"href":"https://github.com/angular/angular/pull/3171"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3171"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3171/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3171/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3171/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/a727a7638d18a3f5d8aaad1297fd81e13428f312"}}}}