{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fireplace/issues/1057","labels_url":"https://api.github.com/repos/mozilla/fireplace/issues/1057/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/1057/comments","events_url":"https://api.github.com/repos/mozilla/fireplace/issues/1057/events","html_url":"https://github.com/mozilla/fireplace/pull/1057","id":60027894,"number":1057,"title":"device filtering persist site-wide, don't persist between session (bug 1127080)","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-05T22:36:36Z","updated_at":"2015-03-06T10:26:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/1057","html_url":"https://github.com/mozilla/fireplace/pull/1057","diff_url":"https://github.com/mozilla/fireplace/pull/1057.diff","patch_url":"https://github.com/mozilla/fireplace/pull/1057.patch"},"body":"This was planned for the New Nav Project, but I'm doing this now so I can start UA tracking engagement with the device filter dropdown.\r\n\r\n- Remove the page groups in compatibility filtering\r\n- Strips out storage from compatibility filtering since we don't need to persist between sessions.\r\n- Calculate the dropdown choices in JS rather than template\r\n- Merge compatibility_filtering_select.js into compat_filter.js \r\n- Have compat_filter unit test be more programmatic and shorter\r\n- Some cleaning and refactoring of compat_filter.js\r\n- s/compatibility_filtering/compat_filter/g\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/fireplace/issues/comments/77537616","html_url":"https://github.com/mozilla/fireplace/pull/1057#issuecomment-77537616","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/1057","id":77537616,"user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"created_at":"2015-03-06T10:26:32Z","updated_at":"2015-03-06T10:26:32Z","body":"I *think* we can remove device_override. It was added for discoplace, which no longer exists."}}