{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/24914930","id":24914930,"diff_hunk":"@@ -602,18 +612,32 @@ public function changePassword() {\n \t\t$this->pageHeading = wfMessage('resetpass')->escaped();\n \t\t$this->initializeTemplate();\n \n-\t\t$this->username = $this->request->getVal( 'username', '' );\n-\t\t$this->password = $this->request->getVal( 'password', '' );\n-\t\t$this->newpassword = $this->request->getVal( 'newpassword', '' );\n-\t\t$this->retype = $this->request->getVal( 'retype', '' );\n-\t\t$this->editToken = $this->request->getVal( 'editToken', '' );\n-\t\t$this->loginToken = $this->request->getVal( 'loginToken', '' );\n-\t\t$this->returnto = $this->request->getVal( 'returnto', '' );\n+\t\t$username = $this->request->getVal( 'username', '' );\n+\t\t$password = $this->request->getVal( 'password', '' );\n+\t\t$newPassword = $this->request->getVal( 'newpassword', '' );\n+\t\t$retype = $this->request->getVal( 'retype', '' );\n+\t\t$loginToken = $this->request->getVal( 'loginToken', '' );\n+\t\t$returnto = $this->request->getVal( 'returnto', '' );\n+\n+\t\t// TODO: figure out why we were setting editToken twice, once via request var and once","path":"extensions/wikia/UserLogin/UserLoginSpecialController.class.php","position":70,"original_position":70,"commit_id":"1639d77f9850f25215c01d712e3d487a1be9c634","original_commit_id":"1639d77f9850f25215c01d712e3d487a1be9c634","user":{"login":"Grunny","id":230630,"avatar_url":"https://avatars.githubusercontent.com/u/230630?v=3","gravatar_id":"","url":"https://api.github.com/users/Grunny","html_url":"https://github.com/Grunny","followers_url":"https://api.github.com/users/Grunny/followers","following_url":"https://api.github.com/users/Grunny/following{/other_user}","gists_url":"https://api.github.com/users/Grunny/gists{/gist_id}","starred_url":"https://api.github.com/users/Grunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grunny/subscriptions","organizations_url":"https://api.github.com/users/Grunny/orgs","repos_url":"https://api.github.com/users/Grunny/repos","events_url":"https://api.github.com/users/Grunny/events{/privacy}","received_events_url":"https://api.github.com/users/Grunny/received_events","type":"User","site_admin":false},"body":"This was/is a bug. The one from the request is what should be checked below with the `$this->wg->User->matchEditToken( $this->editToken )`, and then setting the value is used to make sure the form has the right token. Setting it twice as is being done means the check didn't do anything useful. So, it should match the behaviour of SpecialChangePassword.php from core ([1](https://github.com/Wikia/app/blob/58714681833/includes/specials/SpecialChangePassword.php#L69), [2](https://github.com/Wikia/app/blob/58714681833/includes/specials/SpecialChangePassword.php#L163).","created_at":"2015-02-18T16:28:08Z","updated_at":"2015-02-18T16:28:08Z","html_url":"https://github.com/Wikia/app/pull/6294#discussion_r24914930","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/6294","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/24914930"},"html":{"href":"https://github.com/Wikia/app/pull/6294#discussion_r24914930"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/6294"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/6294","id":29225250,"html_url":"https://github.com/Wikia/app/pull/6294","diff_url":"https://github.com/Wikia/app/pull/6294.diff","patch_url":"https://github.com/Wikia/app/pull/6294.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/6294","number":6294,"state":"open","locked":false,"title":"Soc-163 Adding form validation to facebook login and singup forms","user":{"login":"lizlux","id":201367,"avatar_url":"https://avatars.githubusercontent.com/u/201367?v=3","gravatar_id":"","url":"https://api.github.com/users/lizlux","html_url":"https://github.com/lizlux","followers_url":"https://api.github.com/users/lizlux/followers","following_url":"https://api.github.com/users/lizlux/following{/other_user}","gists_url":"https://api.github.com/users/lizlux/gists{/gist_id}","starred_url":"https://api.github.com/users/lizlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizlux/subscriptions","organizations_url":"https://api.github.com/users/lizlux/orgs","repos_url":"https://api.github.com/users/lizlux/repos","events_url":"https://api.github.com/users/lizlux/events{/privacy}","received_events_url":"https://api.github.com/users/lizlux/received_events","type":"User","site_admin":false},"body":"Ticket: https://wikia-inc.atlassian.net/browse/SOC-163\r\n\r\nThis PR attempts to unify the way we do form validation in the UserLogin extension. It involves changing the `name` attribute of the `username` and `password` inputs for a number of forms, so that they can use the same validation mechanisms. \r\n\r\nWhile I was in this code I noticed some bugs with changing a password from the login modal and the facebook modal, each have been ticketed and there's some comments in the code. ","created_at":"2015-02-12T23:01:17Z","updated_at":"2015-02-18T16:28:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/6294/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/6294/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/6294/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/1639d77f9850f25215c01d712e3d487a1be9c634","head":{"label":"Wikia:SOC-163","ref":"SOC-163","sha":"1639d77f9850f25215c01d712e3d487a1be9c634","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-02-18T15:39:29Z","pushed_at":"2015-02-18T16:24:00Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1363550,"stargazers_count":72,"watchers_count":72,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":53,"forks":51,"open_issues":53,"watchers":72,"default_branch":"dev"}},"base":{"label":"Wikia:social-6","ref":"social-6","sha":"c11cdc817e54c632dfb38be70175bb3a23cf72d6","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-02-18T15:39:29Z","pushed_at":"2015-02-18T16:24:00Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1363550,"stargazers_count":72,"watchers_count":72,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":53,"forks":51,"open_issues":53,"watchers":72,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/6294"},"html":{"href":"https://github.com/Wikia/app/pull/6294"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/6294"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/6294/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/6294/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/6294/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/1639d77f9850f25215c01d712e3d487a1be9c634"}}}}