{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/38882334","id":38882334,"diff_hunk":"@@ -114,6 +112,9 @@ UniValue importprivkey(const UniValue& params, bool fHelp)\n     if (params.size() > 2)\n         fRescan = params[2].get_bool();\n \n+    if (fRescan && fPruneMode)\n+        throw JSONRPCError(RPC_WALLET_ERROR, \"Rescan is disabled in pruned mode\");","path":"src/wallet/rpcdump.cpp","position":14,"original_position":14,"commit_id":"77c60724733a98af5248fb95625046a5a3f82dc3","original_commit_id":"77c60724733a98af5248fb95625046a5a3f82dc3","user":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"body":"Technically it is the blockchain that is rescanned.  But these options have a boolean parameter \"rescan\" which defaults, so what its saying is that this option is disabled.\r\n\r\nI think if I were to clarify this further I would say that the rescan option was disabled. Or maybe to be kind to translaters say something like the requested rescan depth was too deep (as I expect we'll further parameterize this in the future).","created_at":"2015-09-07T23:36:57Z","updated_at":"2015-09-07T23:36:57Z","html_url":"https://github.com/bitcoin/bitcoin/pull/6645#discussion_r38882334","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/38882334"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6645#discussion_r38882334"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645","id":44314101,"html_url":"https://github.com/bitcoin/bitcoin/pull/6645","diff_url":"https://github.com/bitcoin/bitcoin/pull/6645.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6645.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6645","number":6645,"state":"open","locked":false,"title":"Enable wallet key imports without rescan in pruned mode.","user":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"body":"Complete rescan is incompatible with pruning, but rescan is optional on\r\n our wallet key import RPCs.  Import on use is very useful in some common\r\n situations in conjunction with pruning, e.g. merchant payment tracking.\r\n\r\nThis reenables importprivkey/importaddress/importpubkey when rescan\r\n is not used.\r\n\r\nIn the future we should consider changing the rescan argument to allow depth\r\n or date to allow limited rescanning when compatible with the retained\r\n block depth.","created_at":"2015-09-07T01:31:17Z","updated_at":"2015-09-07T23:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"336735c68929dd9b5ea64073f3807e57b1fe050c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6645/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/77c60724733a98af5248fb95625046a5a3f82dc3","head":{"label":"gmaxwell:prune_imports","ref":"prune_imports","sha":"77c60724733a98af5248fb95625046a5a3f82dc3","user":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"repo":{"id":1915885,"name":"bitcoin","full_name":"gmaxwell/bitcoin","owner":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmaxwell/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/gmaxwell/bitcoin","forks_url":"https://api.github.com/repos/gmaxwell/bitcoin/forks","keys_url":"https://api.github.com/repos/gmaxwell/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmaxwell/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmaxwell/bitcoin/teams","hooks_url":"https://api.github.com/repos/gmaxwell/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/gmaxwell/bitcoin/events","assignees_url":"https://api.github.com/repos/gmaxwell/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/gmaxwell/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/gmaxwell/bitcoin/tags","blobs_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmaxwell/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/gmaxwell/bitcoin/languages","stargazers_url":"https://api.github.com/repos/gmaxwell/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/gmaxwell/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/gmaxwell/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/gmaxwell/bitcoin/subscription","commits_url":"https://api.github.com/repos/gmaxwell/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmaxwell/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmaxwell/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/gmaxwell/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmaxwell/bitcoin/merges","archive_url":"https://api.github.com/repos/gmaxwell/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmaxwell/bitcoin/downloads","issues_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/gmaxwell/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/gmaxwell/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/gmaxwell/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmaxwell/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/gmaxwell/bitcoin/releases{/id}","created_at":"2011-06-18T14:38:48Z","updated_at":"2015-04-28T23:19:10Z","pushed_at":"2015-09-07T20:39:18Z","git_url":"git://github.com/gmaxwell/bitcoin.git","ssh_url":"git@github.com:gmaxwell/bitcoin.git","clone_url":"https://github.com/gmaxwell/bitcoin.git","svn_url":"https://github.com/gmaxwell/bitcoin","homepage":"http://www.bitcoin.org","size":44676,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"536207f3167daad1fa3d60a1de7d9cb55db28ac9","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-09-07T22:03:24Z","pushed_at":"2015-09-07T23:24:36Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":134495,"stargazers_count":7429,"watchers_count":7429,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5156,"mirror_url":null,"open_issues_count":459,"forks":5156,"open_issues":459,"watchers":7429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6645"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6645"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6645/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6645/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/77c60724733a98af5248fb95625046a5a3f82dc3"}}}}