{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24239053","id":24239053,"diff_hunk":"@@ -753,12 +768,12 @@ class ADIOSWriter : public ILightweightPlugin\n         adiosCountParticles(threadParams, std::string());\n \n         /* allocate buffer in MB according to our current group size */\n-        if (!threadParams->adiosBufferInitialized)\n-        {\n-            ADIOS_CMD(adios_allocate_buffer(ADIOS_BUFFER_ALLOC_NOW,\n-                    1.5 * ceil((double)(threadParams->adiosGroupSize) / (1024.0 * 1024.0))));\n-            threadParams->adiosBufferInitialized = true;\n-        }\n+        /* `1 + mem` minimum 1 MiB that we can write attributes on empty GPUs */","path":"src/picongpu/include/plugins/adios/ADIOSWriter.hpp","position":32,"original_position":32,"commit_id":"e4712c468e24a215a169e9915f0527b1f596459b","original_commit_id":"e4712c468e24a215a169e9915f0527b1f596459b","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"checks look ok, we contacted the devs again to clearify.","created_at":"2015-02-06T13:08:30Z","updated_at":"2015-02-06T13:08:30Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661#discussion_r24239053","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24239053"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661#discussion_r24239053"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661","id":28496988,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/661","number":661,"state":"open","locked":false,"title":"Fix ADIOS: Zero Writes, Collects and Buffers","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"body":"If some of the processes write zero amount of data with\r\nadios they hang.\r\n\r\nChanges:\r\n- take care that all processes call collective adios write methods\r\n- all processes calculate it's adios index table\r\n- set freed memory to `NULL`\r\n- move calculation of domain sizes before `forEachCollectFieldsSizes` and `adiosCountParticles`\r\n\r\nTests:\r\n- [x] dump Bunch (no data verification) \r\n\r\nWhy is this pull request blocked:\r\n- ~~during the third dumps we got a warning: `adios_group_size (data): Not buffering. needs: 314532206 available: 114294784.`~~\r\n- ~~during the third dump the adios plugin hangs ( 2 of 8 processes)~~","created_at":"2015-02-02T19:50:10Z","updated_at":"2015-02-06T13:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e4aba23274e740ce03f1905ffcfba302685d046","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":549,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-02-06T10:07:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/661/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/e4712c468e24a215a169e9915f0527b1f596459b","head":{"label":"psychocoderHPC:fix-adiosZeroWrites","ref":"fix-adiosZeroWrites","sha":"e4712c468e24a215a169e9915f0527b1f596459b","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"repo":{"id":12103789,"name":"picongpu","full_name":"psychocoderHPC/picongpu","owner":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychocoderHPC/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/psychocoderHPC/picongpu","forks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/forks","keys_url":"https://api.github.com/repos/psychocoderHPC/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychocoderHPC/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychocoderHPC/picongpu/teams","hooks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/hooks","issue_events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/events","assignees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/psychocoderHPC/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/tags","blobs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychocoderHPC/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/psychocoderHPC/picongpu/languages","stargazers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/stargazers","contributors_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contributors","subscribers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscribers","subscription_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscription","commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychocoderHPC/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/psychocoderHPC/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychocoderHPC/picongpu/merges","archive_url":"https://api.github.com/repos/psychocoderHPC/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychocoderHPC/picongpu/downloads","issues_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/psychocoderHPC/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/psychocoderHPC/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/psychocoderHPC/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychocoderHPC/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/psychocoderHPC/picongpu/releases{/id}","created_at":"2013-08-14T08:23:46Z","updated_at":"2014-08-12T11:29:52Z","pushed_at":"2015-02-05T15:30:14Z","git_url":"git://github.com/psychocoderHPC/picongpu.git","ssh_url":"git@github.com:psychocoderHPC/picongpu.git","clone_url":"https://github.com/psychocoderHPC/picongpu.git","svn_url":"https://github.com/psychocoderHPC/picongpu","homepage":"http://picongpu.hzdr.de","size":9436,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"5d81eac8218833319efe68b73f4b8d906962571a","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-02-04T14:43:29Z","pushed_at":"2015-02-05T13:39:41Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":13526,"stargazers_count":83,"watchers_count":83,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":100,"forks":45,"open_issues":100,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/661"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/661"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/e4712c468e24a215a169e9915f0527b1f596459b"}}}}