{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/comments/35382956","id":35382956,"diff_hunk":"@@ -3279,6 +3292,102 @@ class ReaderBase {\n \n   static bool rdrIsMethodVirtual(uint32_t MethodAttribs);\n \n+  /// \\brief Return MethodName for non helper and non native Methods.\n+  ///\n+  /// \\param method  Method handle for the target Method.\n+  /// \\param classNamePtr out param, Module name.\n+  /// \\param JitInfo The jit interface for this method\n+  /// \\returns MethodName.\n+  // TODO sandreenko : change cases to LLILC rules or transfer to coreclr.\n+  const char *GetMethodName(CORINFO_METHOD_HANDLE method,\n+                            const char **classNamePtr, ICorJitInfo *JitInfo);\n+\n+\n+  /// \\brief Return true if we process this Class with SIMD intrinsics.\n+  ///\n+  /// \\param Class The class handle for the call target method's class.\n+  /// \\returns IRNode * LLVM::int(1 or 0).\n+  virtual IRNode *generateIsHardwareAccelerated(CORINFO_CLASS_HANDLE Class) = 0;\n+\n+  /// \\brief Return result of binary or unary operation on SIMD Vector Types.\n+  /// \\brief It gets arguments from stack.\n+  ///\n+  /// \\param OperationCode code to be done. // TODO sandreenko : change to enum\n+  /// later.\n+  /// \\param VectorSize Length of our Vector Type ( in floats).\n+  /// \\returns IRNode* !=0 -> Result of Intrinsic call,\n+  ///  IRNode* == 0 -> we can't produce intrinsic.","path":"include/Reader/reader.h","position":71,"original_position":71,"commit_id":"2888923e3688ece1f64c233e60504a55c11dc0f1","original_commit_id":"2888923e3688ece1f64c233e60504a55c11dc0f1","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"Instead of describing the return values as numbers, I'd recommend describing them abstractly:\r\n\r\n```\r\n\\returns an \\p IRNode representing the result of the intrinsic or nullptr if the intrinsic is not supported.\r\n```","created_at":"2015-07-23T23:20:43Z","updated_at":"2015-07-23T23:20:43Z","html_url":"https://github.com/dotnet/llilc/pull/716#discussion_r35382956","pull_request_url":"https://api.github.com/repos/dotnet/llilc/pulls/716","_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments/35382956"},"html":{"href":"https://github.com/dotnet/llilc/pull/716#discussion_r35382956"},"pull_request":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/716"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/716","id":40636706,"html_url":"https://github.com/dotnet/llilc/pull/716","diff_url":"https://github.com/dotnet/llilc/pull/716.diff","patch_url":"https://github.com/dotnet/llilc/pull/716.patch","issue_url":"https://api.github.com/repos/dotnet/llilc/issues/716","number":716,"state":"open","locked":false,"title":"Simd initial pull request","user":{"login":"ANDREENKOS","id":12055320,"avatar_url":"https://avatars.githubusercontent.com/u/12055320?v=3","gravatar_id":"","url":"https://api.github.com/users/ANDREENKOS","html_url":"https://github.com/ANDREENKOS","followers_url":"https://api.github.com/users/ANDREENKOS/followers","following_url":"https://api.github.com/users/ANDREENKOS/following{/other_user}","gists_url":"https://api.github.com/users/ANDREENKOS/gists{/gist_id}","starred_url":"https://api.github.com/users/ANDREENKOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANDREENKOS/subscriptions","organizations_url":"https://api.github.com/users/ANDREENKOS/orgs","repos_url":"https://api.github.com/users/ANDREENKOS/repos","events_url":"https://api.github.com/users/ANDREENKOS/events{/privacy}","received_events_url":"https://api.github.com/users/ANDREENKOS/received_events","type":"User","site_admin":false},"body":"Support System.Numerics.Vector with fixed size.\r\nRepresent Vectors like LLVM::<float * VectorSize>.\r\nChange getfield and storfield behavior to avoid memcopy and use Vector LLVM specific assessors.\r\nSupport binary, unary, ctors operations.","created_at":"2015-07-23T04:44:17Z","updated_at":"2015-07-23T23:20:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dd1e019c91a326fb4d316e878bfb5761a0ff876","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/llilc/pulls/716/commits","review_comments_url":"https://api.github.com/repos/dotnet/llilc/pulls/716/comments","review_comment_url":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/llilc/issues/716/comments","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/2888923e3688ece1f64c233e60504a55c11dc0f1","head":{"label":"ANDREENKOS:SIMD","ref":"SIMD","sha":"2888923e3688ece1f64c233e60504a55c11dc0f1","user":{"login":"ANDREENKOS","id":12055320,"avatar_url":"https://avatars.githubusercontent.com/u/12055320?v=3","gravatar_id":"","url":"https://api.github.com/users/ANDREENKOS","html_url":"https://github.com/ANDREENKOS","followers_url":"https://api.github.com/users/ANDREENKOS/followers","following_url":"https://api.github.com/users/ANDREENKOS/following{/other_user}","gists_url":"https://api.github.com/users/ANDREENKOS/gists{/gist_id}","starred_url":"https://api.github.com/users/ANDREENKOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANDREENKOS/subscriptions","organizations_url":"https://api.github.com/users/ANDREENKOS/orgs","repos_url":"https://api.github.com/users/ANDREENKOS/repos","events_url":"https://api.github.com/users/ANDREENKOS/events{/privacy}","received_events_url":"https://api.github.com/users/ANDREENKOS/received_events","type":"User","site_admin":false},"repo":{"id":38139312,"name":"llilc","full_name":"ANDREENKOS/llilc","owner":{"login":"ANDREENKOS","id":12055320,"avatar_url":"https://avatars.githubusercontent.com/u/12055320?v=3","gravatar_id":"","url":"https://api.github.com/users/ANDREENKOS","html_url":"https://github.com/ANDREENKOS","followers_url":"https://api.github.com/users/ANDREENKOS/followers","following_url":"https://api.github.com/users/ANDREENKOS/following{/other_user}","gists_url":"https://api.github.com/users/ANDREENKOS/gists{/gist_id}","starred_url":"https://api.github.com/users/ANDREENKOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ANDREENKOS/subscriptions","organizations_url":"https://api.github.com/users/ANDREENKOS/orgs","repos_url":"https://api.github.com/users/ANDREENKOS/repos","events_url":"https://api.github.com/users/ANDREENKOS/events{/privacy}","received_events_url":"https://api.github.com/users/ANDREENKOS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ANDREENKOS/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":true,"url":"https://api.github.com/repos/ANDREENKOS/llilc","forks_url":"https://api.github.com/repos/ANDREENKOS/llilc/forks","keys_url":"https://api.github.com/repos/ANDREENKOS/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ANDREENKOS/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ANDREENKOS/llilc/teams","hooks_url":"https://api.github.com/repos/ANDREENKOS/llilc/hooks","issue_events_url":"https://api.github.com/repos/ANDREENKOS/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/ANDREENKOS/llilc/events","assignees_url":"https://api.github.com/repos/ANDREENKOS/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/ANDREENKOS/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/ANDREENKOS/llilc/tags","blobs_url":"https://api.github.com/repos/ANDREENKOS/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ANDREENKOS/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ANDREENKOS/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ANDREENKOS/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ANDREENKOS/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/ANDREENKOS/llilc/languages","stargazers_url":"https://api.github.com/repos/ANDREENKOS/llilc/stargazers","contributors_url":"https://api.github.com/repos/ANDREENKOS/llilc/contributors","subscribers_url":"https://api.github.com/repos/ANDREENKOS/llilc/subscribers","subscription_url":"https://api.github.com/repos/ANDREENKOS/llilc/subscription","commits_url":"https://api.github.com/repos/ANDREENKOS/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ANDREENKOS/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ANDREENKOS/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ANDREENKOS/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ANDREENKOS/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/ANDREENKOS/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ANDREENKOS/llilc/merges","archive_url":"https://api.github.com/repos/ANDREENKOS/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ANDREENKOS/llilc/downloads","issues_url":"https://api.github.com/repos/ANDREENKOS/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/ANDREENKOS/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/ANDREENKOS/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/ANDREENKOS/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ANDREENKOS/llilc/labels{/name}","releases_url":"https://api.github.com/repos/ANDREENKOS/llilc/releases{/id}","created_at":"2015-06-26T23:48:22Z","updated_at":"2015-06-26T23:48:23Z","pushed_at":"2015-07-23T04:41:14Z","git_url":"git://github.com/ANDREENKOS/llilc.git","ssh_url":"git@github.com:ANDREENKOS/llilc.git","clone_url":"https://github.com/ANDREENKOS/llilc.git","svn_url":"https://github.com/ANDREENKOS/llilc","homepage":"","size":6214,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"586be21cf89dfb4b7d48b23d6ccedd97162deed2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30043131,"name":"llilc","full_name":"dotnet/llilc","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":false,"url":"https://api.github.com/repos/dotnet/llilc","forks_url":"https://api.github.com/repos/dotnet/llilc/forks","keys_url":"https://api.github.com/repos/dotnet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/llilc/teams","hooks_url":"https://api.github.com/repos/dotnet/llilc/hooks","issue_events_url":"https://api.github.com/repos/dotnet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/llilc/events","assignees_url":"https://api.github.com/repos/dotnet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/llilc/tags","blobs_url":"https://api.github.com/repos/dotnet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/llilc/languages","stargazers_url":"https://api.github.com/repos/dotnet/llilc/stargazers","contributors_url":"https://api.github.com/repos/dotnet/llilc/contributors","subscribers_url":"https://api.github.com/repos/dotnet/llilc/subscribers","subscription_url":"https://api.github.com/repos/dotnet/llilc/subscription","commits_url":"https://api.github.com/repos/dotnet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/llilc/merges","archive_url":"https://api.github.com/repos/dotnet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/llilc/downloads","issues_url":"https://api.github.com/repos/dotnet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/llilc/releases{/id}","created_at":"2015-01-29T21:52:01Z","updated_at":"2015-07-23T22:31:24Z","pushed_at":"2015-07-23T19:56:43Z","git_url":"git://github.com/dotnet/llilc.git","ssh_url":"git@github.com:dotnet/llilc.git","clone_url":"https://github.com/dotnet/llilc.git","svn_url":"https://github.com/dotnet/llilc","homepage":"","size":11136,"stargazers_count":781,"watchers_count":781,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":160,"forks":67,"open_issues":160,"watchers":781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/716"},"html":{"href":"https://github.com/dotnet/llilc/pull/716"},"issue":{"href":"https://api.github.com/repos/dotnet/llilc/issues/716"},"comments":{"href":"https://api.github.com/repos/dotnet/llilc/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/llilc/statuses/2888923e3688ece1f64c233e60504a55c11dc0f1"}}}}