{"action":"created","issue":{"url":"https://api.github.com/repos/astroplanners/astroplan/issues/34","labels_url":"https://api.github.com/repos/astroplanners/astroplan/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/astroplanners/astroplan/issues/34/comments","events_url":"https://api.github.com/repos/astroplanners/astroplan/issues/34/events","html_url":"https://github.com/astroplanners/astroplan/pull/34","id":96389250,"number":34,"title":"Vectorize calculations for multiple targets where sensible","user":{"login":"bmorris3","id":3497584,"avatar_url":"https://avatars.githubusercontent.com/u/3497584?v=3","gravatar_id":"","url":"https://api.github.com/users/bmorris3","html_url":"https://github.com/bmorris3","followers_url":"https://api.github.com/users/bmorris3/followers","following_url":"https://api.github.com/users/bmorris3/following{/other_user}","gists_url":"https://api.github.com/users/bmorris3/gists{/gist_id}","starred_url":"https://api.github.com/users/bmorris3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmorris3/subscriptions","organizations_url":"https://api.github.com/users/bmorris3/orgs","repos_url":"https://api.github.com/users/bmorris3/repos","events_url":"https://api.github.com/users/bmorris3/events{/privacy}","received_events_url":"https://api.github.com/users/bmorris3/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astroplanners/astroplan/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"ejeschke","id":1305473,"avatar_url":"https://avatars.githubusercontent.com/u/1305473?v=3","gravatar_id":"","url":"https://api.github.com/users/ejeschke","html_url":"https://github.com/ejeschke","followers_url":"https://api.github.com/users/ejeschke/followers","following_url":"https://api.github.com/users/ejeschke/following{/other_user}","gists_url":"https://api.github.com/users/ejeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/ejeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejeschke/subscriptions","organizations_url":"https://api.github.com/users/ejeschke/orgs","repos_url":"https://api.github.com/users/ejeschke/repos","events_url":"https://api.github.com/users/ejeschke/events{/privacy}","received_events_url":"https://api.github.com/users/ejeschke/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/astroplanners/astroplan/milestones/1","html_url":"https://github.com/astroplanners/astroplan/milestones/0.1%20release","labels_url":"https://api.github.com/repos/astroplanners/astroplan/milestones/1/labels","id":1087263,"number":1,"title":"0.1 release","description":"First release","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2015-04-28T11:35:13Z","updated_at":"2015-07-23T17:17:24Z","due_on":"2015-08-09T22:00:00Z","closed_at":null},"comments":2,"created_at":"2015-07-21T18:47:55Z","updated_at":"2015-07-25T11:26:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astroplanners/astroplan/pulls/34","html_url":"https://github.com/astroplanners/astroplan/pull/34","diff_url":"https://github.com/astroplanners/astroplan/pull/34.diff","patch_url":"https://github.com/astroplanners/astroplan/pull/34.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/astroplanners/astroplan/issues/comments/124835876","html_url":"https://github.com/astroplanners/astroplan/pull/34#issuecomment-124835876","issue_url":"https://api.github.com/repos/astroplanners/astroplan/issues/34","id":124835876,"user":{"login":"adrn","id":583379,"avatar_url":"https://avatars.githubusercontent.com/u/583379?v=3","gravatar_id":"","url":"https://api.github.com/users/adrn","html_url":"https://github.com/adrn","followers_url":"https://api.github.com/users/adrn/followers","following_url":"https://api.github.com/users/adrn/following{/other_user}","gists_url":"https://api.github.com/users/adrn/gists{/gist_id}","starred_url":"https://api.github.com/users/adrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrn/subscriptions","organizations_url":"https://api.github.com/users/adrn/orgs","repos_url":"https://api.github.com/users/adrn/repos","events_url":"https://api.github.com/users/adrn/events{/privacy}","received_events_url":"https://api.github.com/users/adrn/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T11:26:31Z","updated_at":"2015-07-25T11:26:31Z","body":"I need to do a more detailed review of the code, but one point that immediately comes to mind is that I don't think we should be referring to \"arrays\" as \"vectors\" -- I understand now what you mean, when I first looked over the code I was confused. Perhaps the trivial change is to just replaced the word `vector` with `array` in the internal functions/methods you use? In some sense, even a single coordinate or target is a \"vector,\" so it just feels a little confusing to refer to collections of targets as vectors. I'm open to other suggestions for naming though..."}}