{"action":"opened","number":22,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22","id":38900540,"html_url":"https://github.com/mozilla/fxa-local-dev/pull/22","diff_url":"https://github.com/mozilla/fxa-local-dev/pull/22.diff","patch_url":"https://github.com/mozilla/fxa-local-dev/pull/22.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/22","number":22,"state":"open","locked":false,"title":"Improve readme for newcomers","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"body":"These  are based on me coming to the readme with a fresh pair of eyes. The information was all there but it was packed quite densely and not always in chronological order, which made things easy to miss.\r\n\r\nTo give you some context, here's my reasoning behind each change:\r\n\r\n* Initially I didn't realise the first bullet was  a separate step. I thought it was just explanation for `npm install`. Hence making them all numbered bullets and then clarifying `Manually install...`.\r\n\r\n* I don't use bash as my shell, so it was a bit annoying not being able to just copy/paste the `&&`ed commands. Hence splitting them across lines so they work for everyone.\r\n\r\n* Added hierarchy to the pm2 bullets so its clear what belongs to what.\r\n\r\n* Gave an explicit heading to the troubleshooting section, so that it's easier to spot when people are trying to figure out what's wrong.\r\n\r\n* Link to the JDK instead of the JRE in the functional tests section. I tried the JRE but Selenium wouldn't work without the JDK for me.\r\n\r\n@vladikoff, are you the person most interested in reviewing this?","created_at":"2015-06-30T16:59:42Z","updated_at":"2015-06-30T16:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c24f2bbe8c18492d67033586f4f89a271832312e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/22/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-local-dev/statuses/8d8733b5d3e5f4b523f40d44dde30c9867754900","head":{"label":"mozilla:readme_changes","ref":"readme_changes","sha":"8d8733b5d3e5f4b523f40d44dde30c9867754900","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26191912,"name":"fxa-local-dev","full_name":"mozilla/fxa-local-dev","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-local-dev","description":"An easy way to contribute to Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-local-dev","forks_url":"https://api.github.com/repos/mozilla/fxa-local-dev/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-local-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-local-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-local-dev/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-local-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-local-dev/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-local-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-local-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-local-dev/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-local-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-local-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-local-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-local-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-local-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-local-dev/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-local-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-local-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-local-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-local-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-local-dev/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-local-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-local-dev/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-local-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-local-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-local-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-local-dev/releases{/id}","created_at":"2014-11-04T22:35:23Z","updated_at":"2015-05-20T21:15:54Z","pushed_at":"2015-06-30T16:59:42Z","git_url":"git://github.com/mozilla/fxa-local-dev.git","ssh_url":"git@github.com:mozilla/fxa-local-dev.git","clone_url":"https://github.com/mozilla/fxa-local-dev.git","svn_url":"https://github.com/mozilla/fxa-local-dev","homepage":null,"size":494,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":10,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"a53857f24f197bdc4352a789cc84fe0c0036295e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26191912,"name":"fxa-local-dev","full_name":"mozilla/fxa-local-dev","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-local-dev","description":"An easy way to contribute to Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-local-dev","forks_url":"https://api.github.com/repos/mozilla/fxa-local-dev/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-local-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-local-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-local-dev/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-local-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-local-dev/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-local-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-local-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-local-dev/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-local-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-local-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-local-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-local-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-local-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-local-dev/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-local-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-local-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-local-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-local-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-local-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-local-dev/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-local-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-local-dev/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-local-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-local-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-local-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-local-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-local-dev/releases{/id}","created_at":"2014-11-04T22:35:23Z","updated_at":"2015-05-20T21:15:54Z","pushed_at":"2015-06-30T16:59:42Z","git_url":"git://github.com/mozilla/fxa-local-dev.git","ssh_url":"git@github.com:mozilla/fxa-local-dev.git","clone_url":"https://github.com/mozilla/fxa-local-dev.git","svn_url":"https://github.com/mozilla/fxa-local-dev","homepage":null,"size":494,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22"},"html":{"href":"https://github.com/mozilla/fxa-local-dev/pull/22"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/22"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-local-dev/statuses/8d8733b5d3e5f4b523f40d44dde30c9867754900"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":76,"deletions":34,"changed_files":1}}