{"action":"created","issue":{"url":"https://api.github.com/repos/processone/ejabberd/issues/874","labels_url":"https://api.github.com/repos/processone/ejabberd/issues/874/labels{/name}","comments_url":"https://api.github.com/repos/processone/ejabberd/issues/874/comments","events_url":"https://api.github.com/repos/processone/ejabberd/issues/874/events","html_url":"https://github.com/processone/ejabberd/pull/874","id":122002949,"number":874,"title":"mod_irc: Disable spurious vCard->WHOIS requests.","user":{"login":"kousu","id":987487,"avatar_url":"https://avatars.githubusercontent.com/u/987487?v=3","gravatar_id":"","url":"https://api.github.com/users/kousu","html_url":"https://github.com/kousu","followers_url":"https://api.github.com/users/kousu/followers","following_url":"https://api.github.com/users/kousu/following{/other_user}","gists_url":"https://api.github.com/users/kousu/gists{/gist_id}","starred_url":"https://api.github.com/users/kousu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kousu/subscriptions","organizations_url":"https://api.github.com/users/kousu/orgs","repos_url":"https://api.github.com/users/kousu/repos","events_url":"https://api.github.com/users/kousu/events{/privacy}","received_events_url":"https://api.github.com/users/kousu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-14T09:19:58Z","updated_at":"2015-12-14T13:10:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/processone/ejabberd/pulls/874","html_url":"https://github.com/processone/ejabberd/pull/874","diff_url":"https://github.com/processone/ejabberd/pull/874.diff","patch_url":"https://github.com/processone/ejabberd/pull/874.patch"},"body":"It makes sense that vCard in XMPP roughly maps to WHOIS in IRC,\r\nbut there is no code that actually handles receiving WHOISes properly:\r\nthey just get passed through as plain messages coming from user!ircserver@irc.xmppserver.tld.\r\nI suppose sometimes you want to manually be able to run a WHOIS and see the results,\r\nso I don't want them banned entirely, but I don't want them on each run.\r\n\r\nSending spurious WHOISes pisses off Xabber, which overenthusiastically sends \"get vCard\"\r\nIQ stanzas on every single presence change (even \"unavailable\"); this has the horrible\r\nside effect of spawning a huge number of private chats with users I have never talked to,\r\nand buzzing my phone uncontrollably for a good minute, whenever I join a channel with more\r\nthan 50 people in it, and the same every time someone's connection drops.\r\n\r\nDisabling this scratches an itch for me and patches over what is arguably Xabber's problem,\r\nbut in fact, this code was already half-disabled: *even though it sends IRC commands* it\r\nreturns ?ERR_FEATURE_NOT_IMPLEMENTED.  Was this an oversight?"},"comment":{"url":"https://api.github.com/repos/processone/ejabberd/issues/comments/164432294","html_url":"https://github.com/processone/ejabberd/pull/874#issuecomment-164432294","issue_url":"https://api.github.com/repos/processone/ejabberd/issues/874","id":164432294,"user":{"login":"kousu","id":987487,"avatar_url":"https://avatars.githubusercontent.com/u/987487?v=3","gravatar_id":"","url":"https://api.github.com/users/kousu","html_url":"https://github.com/kousu","followers_url":"https://api.github.com/users/kousu/followers","following_url":"https://api.github.com/users/kousu/following{/other_user}","gists_url":"https://api.github.com/users/kousu/gists{/gist_id}","starred_url":"https://api.github.com/users/kousu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kousu/subscriptions","organizations_url":"https://api.github.com/users/kousu/orgs","repos_url":"https://api.github.com/users/kousu/repos","events_url":"https://api.github.com/users/kousu/events{/privacy}","received_events_url":"https://api.github.com/users/kousu/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T13:10:35Z","updated_at":"2015-12-14T13:10:35Z","body":"Huh. Why did that fail? The log just says\r\n```\r\nThe log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over).\r\n\r\nThe build has been terminated.\r\n```\r\nbut it isn't the same error over and over, it's just very verbose. I don't understand how commenting out two lines could have made the build log verbose."}}