{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/121","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/121/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/121/events","html_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/121","id":40424895,"number":121,"title":"parameterize configuration defaults in haproxy::params","user":{"login":"hesco","id":1747647,"avatar_url":"https://avatars.githubusercontent.com/u/1747647?v=3","gravatar_id":"","url":"https://api.github.com/users/hesco","html_url":"https://github.com/hesco","followers_url":"https://api.github.com/users/hesco/followers","following_url":"https://api.github.com/users/hesco/following{/other_user}","gists_url":"https://api.github.com/users/hesco/gists{/gist_id}","starred_url":"https://api.github.com/users/hesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesco/subscriptions","organizations_url":"https://api.github.com/users/hesco/orgs","repos_url":"https://api.github.com/users/hesco/repos","events_url":"https://api.github.com/users/hesco/events{/privacy}","received_events_url":"https://api.github.com/users/hesco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/labels/feature","name":"feature","color":"0052cc"},{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/labels/needs-rebase","name":"needs-rebase","color":"207de5"},{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/labels/needs-work","name":"needs-work","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2014-08-17T01:56:08Z","updated_at":"2015-11-15T07:27:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/121","html_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/121","diff_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/121.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/121.patch"},"body":"One should be able to over-ride a single value, I think, without having to reproduce the entire default configuration. \r\n\r\nhttps://gist.github.com/anonymous/0d13f92a1b1355596393  \r\n\r\nThe initial pull request was premature.  ~~You~~do~~not~~want~~to~~merge~~it~~quite~~yet~~.  I'm sorting out the issues and will update this comment again, once it is ready for your consideration.  \r\n\r\nOK, I have now successfully manually tested this, and it again builds the default configuration, while now permitting individual options to be over-ridden like so:\r\n\r\n```\r\n  class { 'haproxy':\r\n    global_log => '127.0.0.1 local0',\r\n  }\r\n\r\n```\r\n\r\nAnd another concern: this code breaks backwards compatibility.  Working to fix that next.  You do not want to merge this until that has been handled.  \r\n"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/comments/156788334","html_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/121#issuecomment-156788334","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/121","id":156788334,"user":{"login":"antaflos","id":1441852,"avatar_url":"https://avatars.githubusercontent.com/u/1441852?v=3","gravatar_id":"","url":"https://api.github.com/users/antaflos","html_url":"https://github.com/antaflos","followers_url":"https://api.github.com/users/antaflos/followers","following_url":"https://api.github.com/users/antaflos/following{/other_user}","gists_url":"https://api.github.com/users/antaflos/gists{/gist_id}","starred_url":"https://api.github.com/users/antaflos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaflos/subscriptions","organizations_url":"https://api.github.com/users/antaflos/orgs","repos_url":"https://api.github.com/users/antaflos/repos","events_url":"https://api.github.com/users/antaflos/events{/privacy}","received_events_url":"https://api.github.com/users/antaflos/received_events","type":"User","site_admin":false},"created_at":"2015-11-15T07:27:26Z","updated_at":"2015-11-15T07:27:26Z","body":"This can be closed now that #202 is merged."}}