{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3073","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3073/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3073/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3073/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3073","id":115996256,"number":3073,"title":"Misc fixes from multi-cpu branch","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-11-10T00:07:08Z","updated_at":"2015-11-10T03:37:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3073","html_url":"https://github.com/cockroachdb/cockroach/pull/3073","diff_url":"https://github.com/cockroachdb/cockroach/pull/3073.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3073.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3073)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/155274455","html_url":"https://github.com/cockroachdb/cockroach/pull/3073#issuecomment-155274455","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3073","id":155274455,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T03:37:52Z","updated_at":"2015-11-10T03:37:52Z","body":"\n\n\n\nReview status: 5 of 7 files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n<sup>**[gossip/infostore.go, line 219 \\[r7\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3073#-K2jNjr9GtgAzlxJx-zy)** ([raw file](https://github.com/cockroachdb/cockroach/blob/5b3749f03ebd3d824841fdd6d85fda99b0ee5b37/gossip/infostore.go#L219)):</sup>\nActually, I'm just going to make this implementation optimal - I don't think we need to preserve order through removals.\n<!-- Reviewable comment -K2jQlYjY33BVgv3vdVY:875220383 -->\n\n---\n\n<sup>**[kv/txn_coord_sender.go, line 644 \\[r6\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3073#-K2jJe6vs0gIlBuyKeSH)** ([raw file](https://github.com/cockroachdb/cockroach/blob/da5fa7d04ed14de149341df4f328c2f73591e7c8/kv/txn_coord_sender.go#L644)):</sup>\nThere was a race on an error's transaction pointer: https://circleci.com/gh/cockroachdb/cockroach/8992\n<!-- Reviewable comment -K2jR99QbyAt-qojw96v:1516503602 -->\n\n---\n\n<sup>**[storage/client_raft_test.go, line 1409 \\[r7\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3073#-K2jOfpGNBIXYbCSc3Mw)** ([raw file](https://github.com/cockroachdb/cockroach/blob/5b3749f03ebd3d824841fdd6d85fda99b0ee5b37/storage/client_raft_test.go#L1409)):</sup>\n2 minutes is chosen so that the test timeout fires and we get a stack trace. I don't think I've tried this after #3070.\n<!-- Reviewable comment -K2jRPikoN6l2oSJS3aq:1522204404 -->\n\n---\n\n<sup>**[storage/client_split_test.go, line 751 \\[r7\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3073#-K2jPRQ953srZBIBal5A)** ([raw file](https://github.com/cockroachdb/cockroach/blob/5b3749f03ebd3d824841fdd6d85fda99b0ee5b37/storage/client_split_test.go#L751)):</sup>\nHere's one: https://circleci.com/gh/cockroachdb/cockroach/8994\n\nI'm not sure if there is, I didn't dig into this very deeply, though I expected that `restartStore` wouldn't return until the store was ready.\n<!-- Reviewable comment -K2jSYCJaW59XJhWKO1i:-422737219 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3073)\n<!-- Sent from Reviewable.io -->\n"}}