{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/samson/pulls/comments/43137716","id":43137716,"diff_hunk":"@@ -13,7 +13,7 @@\n \n   <%= render partial: \"shared/search_bar\", locals: {url: admin_user_path, query: params[:search]} %>\n \n-  <table id=\"users\" class=\"table table-hover table-condensed\">\n+  <table id=\"users\" class=\"table table-hover table-condensed\" ng-controller=\"ProjectRolesCtrl\" ng-init=\"loadProjectRoles()\">","path":"app/views/admin/users/show.html.erb","position":5,"original_position":5,"commit_id":"bc05607e7148ffe44884c95a4237a5a746744dea","original_commit_id":"bc05607e7148ffe44884c95a4237a5a746744dea","user":{"login":"sbrnunes","id":2833020,"avatar_url":"https://avatars.githubusercontent.com/u/2833020?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrnunes","html_url":"https://github.com/sbrnunes","followers_url":"https://api.github.com/users/sbrnunes/followers","following_url":"https://api.github.com/users/sbrnunes/following{/other_user}","gists_url":"https://api.github.com/users/sbrnunes/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrnunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrnunes/subscriptions","organizations_url":"https://api.github.com/users/sbrnunes/orgs","repos_url":"https://api.github.com/users/sbrnunes/repos","events_url":"https://api.github.com/users/sbrnunes/events{/privacy}","received_events_url":"https://api.github.com/users/sbrnunes/received_events","type":"User","site_admin":false},"body":"You're absolutely right, I kept it from what I had previously, but there's no need to do it anymore. I'm going to change it.\r\nThanks for the heads up.","created_at":"2015-10-27T15:28:32Z","updated_at":"2015-10-27T15:28:32Z","html_url":"https://github.com/zendesk/samson/pull/610#discussion_r43137716","pull_request_url":"https://api.github.com/repos/zendesk/samson/pulls/610","_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments/43137716"},"html":{"href":"https://github.com/zendesk/samson/pull/610#discussion_r43137716"},"pull_request":{"href":"https://api.github.com/repos/zendesk/samson/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/samson/pulls/610","id":48457338,"html_url":"https://github.com/zendesk/samson/pull/610","diff_url":"https://github.com/zendesk/samson/pull/610.diff","patch_url":"https://github.com/zendesk/samson/pull/610.patch","issue_url":"https://api.github.com/repos/zendesk/samson/issues/610","number":610,"state":"open","locked":false,"title":"Added caching when loading project roles to prevent delays when rendering the radio buttons","user":{"login":"sbrnunes","id":2833020,"avatar_url":"https://avatars.githubusercontent.com/u/2833020?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrnunes","html_url":"https://github.com/sbrnunes","followers_url":"https://api.github.com/users/sbrnunes/followers","following_url":"https://api.github.com/users/sbrnunes/following{/other_user}","gists_url":"https://api.github.com/users/sbrnunes/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrnunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrnunes/subscriptions","organizations_url":"https://api.github.com/users/sbrnunes/orgs","repos_url":"https://api.github.com/users/sbrnunes/repos","events_url":"https://api.github.com/users/sbrnunes/events{/privacy}","received_events_url":"https://api.github.com/users/sbrnunes/received_events","type":"User","site_admin":false},"body":"Added some caching support when loading the project roles catalog to prevent delays in the UI when showing the radio buttons. Because each row was fetching the project roles from the backend, some annoying delays were visible.\r\n\r\n/cc @zendesk/samson \r\n\r\n### Steps to reproduce\r\nBy clicking on a User after accessing the Admin -> Users page, one could see how long it was taking to show the radio buttons for each project row.\r\n\r\n### Risks\r\n - None","created_at":"2015-10-22T13:31:15Z","updated_at":"2015-10-27T15:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1120287df9a8326cc88503209a965f6d5a96fe6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/samson/pulls/610/commits","review_comments_url":"https://api.github.com/repos/zendesk/samson/pulls/610/comments","review_comment_url":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/samson/issues/610/comments","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/bc05607e7148ffe44884c95a4237a5a746744dea","head":{"label":"zendesk:sbrnunes/add-cache-project-roles","ref":"sbrnunes/add-cache-project-roles","sha":"bc05607e7148ffe44884c95a4237a5a746744dea","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","created_at":"2014-05-27T05:55:57Z","updated_at":"2015-10-26T13:44:03Z","pushed_at":"2015-10-26T08:10:26Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"git@github.com:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":115117,"stargazers_count":519,"watchers_count":519,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":36,"forks":80,"open_issues":36,"watchers":519,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"dc9c1b7c3b711259196c135d2fab53c3b5b731ea","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","created_at":"2014-05-27T05:55:57Z","updated_at":"2015-10-26T13:44:03Z","pushed_at":"2015-10-26T08:10:26Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"git@github.com:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":115117,"stargazers_count":519,"watchers_count":519,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":36,"forks":80,"open_issues":36,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/610"},"html":{"href":"https://github.com/zendesk/samson/pull/610"},"issue":{"href":"https://api.github.com/repos/zendesk/samson/issues/610"},"comments":{"href":"https://api.github.com/repos/zendesk/samson/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/samson/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/samson/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/samson/statuses/bc05607e7148ffe44884c95a4237a5a746744dea"}}}}