{"action":"created","comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/36843650","id":36843650,"diff_hunk":"@@ -47,19 +48,17 @@ private Stream GetResourceContent(Assembly assembly, string resourcePath, string\n         {\r\n             var resourceName = assembly\r\n                 .GetManifestResourceNames()\r\n-                .Where(x => GetFileNameFromResourceName(resourcePath, x).Equals(name, StringComparison.OrdinalIgnoreCase))\r\n-                .Select(x => GetFileNameFromResourceName(resourcePath, x))\r\n-                .FirstOrDefault();\r\n+                .FirstOrDefault(x => GetFileNameFromResourceName(resourcePath, x).Equals(name, StringComparison.OrdinalIgnoreCase));\r\n \r\n-            resourceName =\r\n-                string.Concat(resourcePath, \".\", resourceName);\r","path":"src/Nancy/Responses/EmbeddedFileResponse.cs","position":18,"original_position":18,"commit_id":"d05a3eaf5345829296170e9c827777732f3cf2a3","original_commit_id":"d05a3eaf5345829296170e9c827777732f3cf2a3","user":{"login":"anton-gogolev","id":562650,"avatar_url":"https://avatars.githubusercontent.com/u/562650?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-gogolev","html_url":"https://github.com/anton-gogolev","followers_url":"https://api.github.com/users/anton-gogolev/followers","following_url":"https://api.github.com/users/anton-gogolev/following{/other_user}","gists_url":"https://api.github.com/users/anton-gogolev/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-gogolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-gogolev/subscriptions","organizations_url":"https://api.github.com/users/anton-gogolev/orgs","repos_url":"https://api.github.com/users/anton-gogolev/repos","events_url":"https://api.github.com/users/anton-gogolev/events{/privacy}","received_events_url":"https://api.github.com/users/anton-gogolev/received_events","type":"User","site_admin":false},"body":"@jchannon Nope.\r\n\r\n`Assembly.GetManifestResourceStream()` requires [case-sensitive name](https://msdn.microsoft.com/en-us/library/xc4235zt(v=vs.110).aspx) of the manifest resource, and the `FirstOrDefault()` call on line 51 returns just that: full verbatim name of the matching embedded resource.","created_at":"2015-08-12T10:04:53Z","updated_at":"2015-08-12T10:04:53Z","html_url":"https://github.com/NancyFx/Nancy/pull/2004#discussion_r36843650","pull_request_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004","_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/36843650"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2004#discussion_r36843650"},"pull_request":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004"}}},"pull_request":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004","id":42175551,"html_url":"https://github.com/NancyFx/Nancy/pull/2004","diff_url":"https://github.com/NancyFx/Nancy/pull/2004.diff","patch_url":"https://github.com/NancyFx/Nancy/pull/2004.patch","issue_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2004","number":2004,"state":"open","locked":false,"title":"Perform case-insensitive lookups in EmbeddedFileResource","user":{"login":"anton-gogolev","id":562650,"avatar_url":"https://avatars.githubusercontent.com/u/562650?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-gogolev","html_url":"https://github.com/anton-gogolev","followers_url":"https://api.github.com/users/anton-gogolev/followers","following_url":"https://api.github.com/users/anton-gogolev/following{/other_user}","gists_url":"https://api.github.com/users/anton-gogolev/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-gogolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-gogolev/subscriptions","organizations_url":"https://api.github.com/users/anton-gogolev/orgs","repos_url":"https://api.github.com/users/anton-gogolev/repos","events_url":"https://api.github.com/users/anton-gogolev/events{/privacy}","received_events_url":"https://api.github.com/users/anton-gogolev/received_events","type":"User","site_admin":false},"body":"Perform case-insensitive lookups in EmbeddedFileResource\r\n\r\nPreviously, `EmbeddedFileResource` was overly picky with regards to embedded resource name casing. Particularly, this was causing problems when `AddDirectory()` on `EmbeddedStaticContentConventionBuilder` was given an incorrectly-capitalized `contentPath` argument, i.e.:\r\n\r\n    _.AddDirectory(\"content\", GetType().Assembly, contentPath: \"content\"));\r\n\r\nProvided that embedded resources were under \"Foo.Content\", all requests to `/content/...` would fail.\r\n\r\nWith this PR, `EmbeddedFileResource` becomes much less picky about casing, which it has been all along nevertheless, except for a couple places.","created_at":"2015-08-11T20:44:07Z","updated_at":"2015-08-12T10:04:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bea38a481e48a1b8e1c4035b47cd489149f72e3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004/commits","review_comments_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004/comments","review_comment_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2004/comments","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/d05a3eaf5345829296170e9c827777732f3cf2a3","head":{"label":"anton-gogolev:case-insensitive-embedded-file-response","ref":"case-insensitive-embedded-file-response","sha":"d05a3eaf5345829296170e9c827777732f3cf2a3","user":{"login":"anton-gogolev","id":562650,"avatar_url":"https://avatars.githubusercontent.com/u/562650?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-gogolev","html_url":"https://github.com/anton-gogolev","followers_url":"https://api.github.com/users/anton-gogolev/followers","following_url":"https://api.github.com/users/anton-gogolev/following{/other_user}","gists_url":"https://api.github.com/users/anton-gogolev/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-gogolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-gogolev/subscriptions","organizations_url":"https://api.github.com/users/anton-gogolev/orgs","repos_url":"https://api.github.com/users/anton-gogolev/repos","events_url":"https://api.github.com/users/anton-gogolev/events{/privacy}","received_events_url":"https://api.github.com/users/anton-gogolev/received_events","type":"User","site_admin":false},"repo":{"id":33865376,"name":"Nancy","full_name":"anton-gogolev/Nancy","owner":{"login":"anton-gogolev","id":562650,"avatar_url":"https://avatars.githubusercontent.com/u/562650?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-gogolev","html_url":"https://github.com/anton-gogolev","followers_url":"https://api.github.com/users/anton-gogolev/followers","following_url":"https://api.github.com/users/anton-gogolev/following{/other_user}","gists_url":"https://api.github.com/users/anton-gogolev/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-gogolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-gogolev/subscriptions","organizations_url":"https://api.github.com/users/anton-gogolev/orgs","repos_url":"https://api.github.com/users/anton-gogolev/repos","events_url":"https://api.github.com/users/anton-gogolev/events{/privacy}","received_events_url":"https://api.github.com/users/anton-gogolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anton-gogolev/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":true,"url":"https://api.github.com/repos/anton-gogolev/Nancy","forks_url":"https://api.github.com/repos/anton-gogolev/Nancy/forks","keys_url":"https://api.github.com/repos/anton-gogolev/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anton-gogolev/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anton-gogolev/Nancy/teams","hooks_url":"https://api.github.com/repos/anton-gogolev/Nancy/hooks","issue_events_url":"https://api.github.com/repos/anton-gogolev/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/anton-gogolev/Nancy/events","assignees_url":"https://api.github.com/repos/anton-gogolev/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/anton-gogolev/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/anton-gogolev/Nancy/tags","blobs_url":"https://api.github.com/repos/anton-gogolev/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anton-gogolev/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anton-gogolev/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/anton-gogolev/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anton-gogolev/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/anton-gogolev/Nancy/languages","stargazers_url":"https://api.github.com/repos/anton-gogolev/Nancy/stargazers","contributors_url":"https://api.github.com/repos/anton-gogolev/Nancy/contributors","subscribers_url":"https://api.github.com/repos/anton-gogolev/Nancy/subscribers","subscription_url":"https://api.github.com/repos/anton-gogolev/Nancy/subscription","commits_url":"https://api.github.com/repos/anton-gogolev/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/anton-gogolev/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/anton-gogolev/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/anton-gogolev/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/anton-gogolev/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/anton-gogolev/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anton-gogolev/Nancy/merges","archive_url":"https://api.github.com/repos/anton-gogolev/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anton-gogolev/Nancy/downloads","issues_url":"https://api.github.com/repos/anton-gogolev/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/anton-gogolev/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/anton-gogolev/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/anton-gogolev/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anton-gogolev/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/anton-gogolev/Nancy/releases{/id}","created_at":"2015-04-13T11:47:21Z","updated_at":"2015-04-13T16:04:23Z","pushed_at":"2015-08-11T20:42:23Z","git_url":"git://github.com/anton-gogolev/Nancy.git","ssh_url":"git@github.com:anton-gogolev/Nancy.git","clone_url":"https://github.com/anton-gogolev/Nancy.git","svn_url":"https://github.com/anton-gogolev/Nancy","homepage":"http://nancyfx.org","size":26367,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NancyFx:master","ref":"master","sha":"b67270d029d663dcec83acf57f47f698d68fa6ae","user":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"repo":{"id":738250,"name":"Nancy","full_name":"NancyFx/Nancy","owner":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NancyFx/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":false,"url":"https://api.github.com/repos/NancyFx/Nancy","forks_url":"https://api.github.com/repos/NancyFx/Nancy/forks","keys_url":"https://api.github.com/repos/NancyFx/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NancyFx/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NancyFx/Nancy/teams","hooks_url":"https://api.github.com/repos/NancyFx/Nancy/hooks","issue_events_url":"https://api.github.com/repos/NancyFx/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/NancyFx/Nancy/events","assignees_url":"https://api.github.com/repos/NancyFx/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/NancyFx/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/NancyFx/Nancy/tags","blobs_url":"https://api.github.com/repos/NancyFx/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NancyFx/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NancyFx/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/NancyFx/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/NancyFx/Nancy/languages","stargazers_url":"https://api.github.com/repos/NancyFx/Nancy/stargazers","contributors_url":"https://api.github.com/repos/NancyFx/Nancy/contributors","subscribers_url":"https://api.github.com/repos/NancyFx/Nancy/subscribers","subscription_url":"https://api.github.com/repos/NancyFx/Nancy/subscription","commits_url":"https://api.github.com/repos/NancyFx/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/NancyFx/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/NancyFx/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/NancyFx/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/NancyFx/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NancyFx/Nancy/merges","archive_url":"https://api.github.com/repos/NancyFx/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NancyFx/Nancy/downloads","issues_url":"https://api.github.com/repos/NancyFx/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/NancyFx/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/NancyFx/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/NancyFx/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NancyFx/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/NancyFx/Nancy/releases{/id}","created_at":"2010-06-24T19:35:22Z","updated_at":"2015-08-12T09:29:01Z","pushed_at":"2015-08-11T20:44:08Z","git_url":"git://github.com/NancyFx/Nancy.git","ssh_url":"git@github.com:NancyFx/Nancy.git","clone_url":"https://github.com/NancyFx/Nancy.git","svn_url":"https://github.com/NancyFx/Nancy","homepage":"http://nancyfx.org","size":40310,"stargazers_count":3190,"watchers_count":3190,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":822,"mirror_url":null,"open_issues_count":253,"forks":822,"open_issues":253,"watchers":3190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2004"},"issue":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2004"},"comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2004/comments"},"review_comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004/comments"},"review_comment":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2004/commits"},"statuses":{"href":"https://api.github.com/repos/NancyFx/Nancy/statuses/d05a3eaf5345829296170e9c827777732f3cf2a3"}}}}