{"action":"created","issue":{"url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/3","labels_url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/3/comments","events_url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/3/events","html_url":"https://github.com/ros-drivers/smart_battery_msgs/pull/3","id":98722744,"number":3,"title":"Add charging source to the message format","user":{"login":"stonier","id":687378,"avatar_url":"https://avatars.githubusercontent.com/u/687378?v=3","gravatar_id":"","url":"https://api.github.com/users/stonier","html_url":"https://github.com/stonier","followers_url":"https://api.github.com/users/stonier/followers","following_url":"https://api.github.com/users/stonier/following{/other_user}","gists_url":"https://api.github.com/users/stonier/gists{/gist_id}","starred_url":"https://api.github.com/users/stonier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonier/subscriptions","organizations_url":"https://api.github.com/users/stonier/orgs","repos_url":"https://api.github.com/users/stonier/repos","events_url":"https://api.github.com/users/stonier/events{/privacy}","received_events_url":"https://api.github.com/users/stonier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-03T11:25:28Z","updated_at":"2015-10-24T06:30:55Z","closed_at":"2015-10-24T04:41:36Z","pull_request":{"url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/pulls/3","html_url":"https://github.com/ros-drivers/smart_battery_msgs/pull/3","diff_url":"https://github.com/ros-drivers/smart_battery_msgs/pull/3.diff","patch_url":"https://github.com/ros-drivers/smart_battery_msgs/pull/3.patch"},"body":"Could have added the identifier as a string to allow more flexibility, but can't really foresee a use case where the enum list here is longer than a few items.\r\n\r\nCan change to a string in future if we really need to, but until then, lightweight I think is better."},"comment":{"url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/comments/150767143","html_url":"https://github.com/ros-drivers/smart_battery_msgs/pull/3#issuecomment-150767143","issue_url":"https://api.github.com/repos/ros-drivers/smart_battery_msgs/issues/3","id":150767143,"user":{"login":"tfoote","id":447804,"avatar_url":"https://avatars.githubusercontent.com/u/447804?v=3","gravatar_id":"","url":"https://api.github.com/users/tfoote","html_url":"https://github.com/tfoote","followers_url":"https://api.github.com/users/tfoote/followers","following_url":"https://api.github.com/users/tfoote/following{/other_user}","gists_url":"https://api.github.com/users/tfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoote/subscriptions","organizations_url":"https://api.github.com/users/tfoote/orgs","repos_url":"https://api.github.com/users/tfoote/repos","events_url":"https://api.github.com/users/tfoote/events{/privacy}","received_events_url":"https://api.github.com/users/tfoote/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T06:30:55Z","updated_at":"2015-10-24T06:30:55Z","body":"@stonier Sorry I didn't realize you were looking just for a generic message since this addition isn't reflected in that one. We should get that one moving. With your input it looks like we've converged. "}}