{"action":"closed","number":534,"pull_request":{"url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534","id":51066557,"html_url":"https://github.com/cerebris/jsonapi-resources/pull/534","diff_url":"https://github.com/cerebris/jsonapi-resources/pull/534.diff","patch_url":"https://github.com/cerebris/jsonapi-resources/pull/534.patch","issue_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/534","number":534,"state":"closed","locked":false,"title":"Move fetchable_fields override to class level","user":{"login":"reidab","id":13192,"avatar_url":"https://avatars.githubusercontent.com/u/13192?v=3","gravatar_id":"","url":"https://api.github.com/users/reidab","html_url":"https://github.com/reidab","followers_url":"https://api.github.com/users/reidab/followers","following_url":"https://api.github.com/users/reidab/following{/other_user}","gists_url":"https://api.github.com/users/reidab/gists{/gist_id}","starred_url":"https://api.github.com/users/reidab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidab/subscriptions","organizations_url":"https://api.github.com/users/reidab/orgs","repos_url":"https://api.github.com/users/reidab/repos","events_url":"https://api.github.com/users/reidab/events{/privacy}","received_events_url":"https://api.github.com/users/reidab/received_events","type":"User","site_admin":false},"body":"Just a small proposal to make the `*_fields` overrides more consistent.\r\n\r\nAdds a class-level `self.fetchable_fields(context)` method to Resource and changes the existing `Resource#fetchable_fields` to call the class-level version with the current context. Updates docs to encourage overwriting `self.fetchable_fields` to be parallel with the workflows for `updatable_fields`, `creatable_fields`, and `sortable_fields`.\r\n\r\nThis change should be backwards-compatible with existing instance-level overrides of `fetchable_fields`.","created_at":"2015-11-18T10:29:37Z","updated_at":"2015-11-18T14:21:10Z","closed_at":"2015-11-18T14:21:10Z","merged_at":"2015-11-18T14:21:10Z","merge_commit_sha":"0d5f880fb4a4f8dafb7b4cae8f0b46a96c61f33f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534/commits","review_comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534/comments","review_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/534/comments","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/cdc5ef0ad820adfb4885e3c55b77c9b7631cb41c","head":{"label":"reidab:fetchable-fields-on-class","ref":"fetchable-fields-on-class","sha":"cdc5ef0ad820adfb4885e3c55b77c9b7631cb41c","user":{"login":"reidab","id":13192,"avatar_url":"https://avatars.githubusercontent.com/u/13192?v=3","gravatar_id":"","url":"https://api.github.com/users/reidab","html_url":"https://github.com/reidab","followers_url":"https://api.github.com/users/reidab/followers","following_url":"https://api.github.com/users/reidab/following{/other_user}","gists_url":"https://api.github.com/users/reidab/gists{/gist_id}","starred_url":"https://api.github.com/users/reidab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidab/subscriptions","organizations_url":"https://api.github.com/users/reidab/orgs","repos_url":"https://api.github.com/users/reidab/repos","events_url":"https://api.github.com/users/reidab/events{/privacy}","received_events_url":"https://api.github.com/users/reidab/received_events","type":"User","site_admin":false},"repo":{"id":46276556,"name":"jsonapi-resources","full_name":"reidab/jsonapi-resources","owner":{"login":"reidab","id":13192,"avatar_url":"https://avatars.githubusercontent.com/u/13192?v=3","gravatar_id":"","url":"https://api.github.com/users/reidab","html_url":"https://github.com/reidab","followers_url":"https://api.github.com/users/reidab/followers","following_url":"https://api.github.com/users/reidab/following{/other_user}","gists_url":"https://api.github.com/users/reidab/gists{/gist_id}","starred_url":"https://api.github.com/users/reidab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidab/subscriptions","organizations_url":"https://api.github.com/users/reidab/orgs","repos_url":"https://api.github.com/users/reidab/repos","events_url":"https://api.github.com/users/reidab/events{/privacy}","received_events_url":"https://api.github.com/users/reidab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reidab/jsonapi-resources","description":"","fork":true,"url":"https://api.github.com/repos/reidab/jsonapi-resources","forks_url":"https://api.github.com/repos/reidab/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/reidab/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reidab/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reidab/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/reidab/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/reidab/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/reidab/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/reidab/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/reidab/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/reidab/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/reidab/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reidab/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reidab/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/reidab/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reidab/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/reidab/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/reidab/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/reidab/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/reidab/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/reidab/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/reidab/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/reidab/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/reidab/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/reidab/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/reidab/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/reidab/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reidab/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/reidab/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reidab/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/reidab/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/reidab/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/reidab/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/reidab/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reidab/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/reidab/jsonapi-resources/releases{/id}","created_at":"2015-11-16T13:34:36Z","updated_at":"2015-11-16T13:34:37Z","pushed_at":"2015-11-18T10:27:54Z","git_url":"git://github.com/reidab/jsonapi-resources.git","ssh_url":"git@github.com:reidab/jsonapi-resources.git","clone_url":"https://github.com/reidab/jsonapi-resources.git","svn_url":"https://github.com/reidab/jsonapi-resources","homepage":null,"size":1604,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cerebris:master","ref":"master","sha":"730f751dfaaee5079e876f91f4d07e10d0eac420","user":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"repo":{"id":18248068,"name":"jsonapi-resources","full_name":"cerebris/jsonapi-resources","owner":{"login":"cerebris","id":326811,"avatar_url":"https://avatars.githubusercontent.com/u/326811?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebris","html_url":"https://github.com/cerebris","followers_url":"https://api.github.com/users/cerebris/followers","following_url":"https://api.github.com/users/cerebris/following{/other_user}","gists_url":"https://api.github.com/users/cerebris/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebris/subscriptions","organizations_url":"https://api.github.com/users/cerebris/orgs","repos_url":"https://api.github.com/users/cerebris/repos","events_url":"https://api.github.com/users/cerebris/events{/privacy}","received_events_url":"https://api.github.com/users/cerebris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerebris/jsonapi-resources","description":"","fork":false,"url":"https://api.github.com/repos/cerebris/jsonapi-resources","forks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/forks","keys_url":"https://api.github.com/repos/cerebris/jsonapi-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerebris/jsonapi-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerebris/jsonapi-resources/teams","hooks_url":"https://api.github.com/repos/cerebris/jsonapi-resources/hooks","issue_events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/events{/number}","events_url":"https://api.github.com/repos/cerebris/jsonapi-resources/events","assignees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/assignees{/user}","branches_url":"https://api.github.com/repos/cerebris/jsonapi-resources/branches{/branch}","tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/tags","blobs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/cerebris/jsonapi-resources/languages","stargazers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/stargazers","contributors_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contributors","subscribers_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscribers","subscription_url":"https://api.github.com/repos/cerebris/jsonapi-resources/subscription","commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerebris/jsonapi-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerebris/jsonapi-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerebris/jsonapi-resources/contents/{+path}","compare_url":"https://api.github.com/repos/cerebris/jsonapi-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerebris/jsonapi-resources/merges","archive_url":"https://api.github.com/repos/cerebris/jsonapi-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerebris/jsonapi-resources/downloads","issues_url":"https://api.github.com/repos/cerebris/jsonapi-resources/issues{/number}","pulls_url":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/cerebris/jsonapi-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/cerebris/jsonapi-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerebris/jsonapi-resources/labels{/name}","releases_url":"https://api.github.com/repos/cerebris/jsonapi-resources/releases{/id}","created_at":"2014-03-29T18:45:23Z","updated_at":"2015-11-17T21:19:59Z","pushed_at":"2015-11-18T14:21:10Z","git_url":"git://github.com/cerebris/jsonapi-resources.git","ssh_url":"git@github.com:cerebris/jsonapi-resources.git","clone_url":"https://github.com/cerebris/jsonapi-resources.git","svn_url":"https://github.com/cerebris/jsonapi-resources","homepage":null,"size":1973,"stargazers_count":707,"watchers_count":707,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":118,"forks":144,"open_issues":118,"watchers":707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534"},"html":{"href":"https://github.com/cerebris/jsonapi-resources/pull/534"},"issue":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/534"},"comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/cerebris/jsonapi-resources/statuses/cdc5ef0ad820adfb4885e3c55b77c9b7631cb41c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lgebhardt","id":29154,"avatar_url":"https://avatars.githubusercontent.com/u/29154?v=3","gravatar_id":"","url":"https://api.github.com/users/lgebhardt","html_url":"https://github.com/lgebhardt","followers_url":"https://api.github.com/users/lgebhardt/followers","following_url":"https://api.github.com/users/lgebhardt/following{/other_user}","gists_url":"https://api.github.com/users/lgebhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/lgebhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgebhardt/subscriptions","organizations_url":"https://api.github.com/users/lgebhardt/orgs","repos_url":"https://api.github.com/users/lgebhardt/repos","events_url":"https://api.github.com/users/lgebhardt/events{/privacy}","received_events_url":"https://api.github.com/users/lgebhardt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":2}}