{"action":"created","comment":{"url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments/42234480","id":42234480,"diff_hunk":"@@ -67,6 +67,7 @@ public void accept(Event<TerminateStackRequest> terminateStackRequestEvent) {\n             } else {\n                 result = new TerminateStackResult(request);\n             }\n+            connector.credentials().delete(ac);","path":"cloud-reactor/src/main/java/com/sequenceiq/cloudbreak/cloud/handler/TerminateStackHandler.java","position":4,"original_position":4,"commit_id":"8b3256d1404f6bcab0c55174f89c9319318170d6","original_commit_id":"8b3256d1404f6bcab0c55174f89c9319318170d6","user":{"login":"schfeca75","id":4092731,"avatar_url":"https://avatars.githubusercontent.com/u/4092731?v=3","gravatar_id":"","url":"https://api.github.com/users/schfeca75","html_url":"https://github.com/schfeca75","followers_url":"https://api.github.com/users/schfeca75/followers","following_url":"https://api.github.com/users/schfeca75/following{/other_user}","gists_url":"https://api.github.com/users/schfeca75/gists{/gist_id}","starred_url":"https://api.github.com/users/schfeca75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schfeca75/subscriptions","organizations_url":"https://api.github.com/users/schfeca75/orgs","repos_url":"https://api.github.com/users/schfeca75/repos","events_url":"https://api.github.com/users/schfeca75/events{/privacy}","received_events_url":"https://api.github.com/users/schfeca75/received_events","type":"User","site_admin":false},"body":"Is it not necessary to check the returned CloudCredentialStatus? It can be failed.","created_at":"2015-10-16T11:54:12Z","updated_at":"2015-10-16T11:54:12Z","html_url":"https://github.com/sequenceiq/cloudbreak/pull/1044#discussion_r42234480","pull_request_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044","_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments/42234480"},"html":{"href":"https://github.com/sequenceiq/cloudbreak/pull/1044#discussion_r42234480"},"pull_request":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044"}}},"pull_request":{"url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044","id":47806606,"html_url":"https://github.com/sequenceiq/cloudbreak/pull/1044","diff_url":"https://github.com/sequenceiq/cloudbreak/pull/1044.diff","patch_url":"https://github.com/sequenceiq/cloudbreak/pull/1044.patch","issue_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/1044","number":1044,"state":"open","locked":false,"title":"CLOUD-45712 credential creation on-the-fly","user":{"login":"keyki","id":2330520,"avatar_url":"https://avatars.githubusercontent.com/u/2330520?v=3","gravatar_id":"","url":"https://api.github.com/users/keyki","html_url":"https://github.com/keyki","followers_url":"https://api.github.com/users/keyki/followers","following_url":"https://api.github.com/users/keyki/following{/other_user}","gists_url":"https://api.github.com/users/keyki/gists{/gist_id}","starred_url":"https://api.github.com/users/keyki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyki/subscriptions","organizations_url":"https://api.github.com/users/keyki/orgs","repos_url":"https://api.github.com/users/keyki/repos","events_url":"https://api.github.com/users/keyki/events{/privacy}","received_events_url":"https://api.github.com/users/keyki/received_events","type":"User","site_admin":false},"body":"@schfeca75 @akanto \r\n\r\n* Credentials are created on the fly for AWS and Openstack (no need on AZ and GCP)\r\n* Credentials are deleted along with the cluster\r\n* If you create a new credential a verification will run on it, where it is implemented","created_at":"2015-10-15T16:00:59Z","updated_at":"2015-10-16T11:54:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5c0eba7a5ca3310aefa920fc5f24559a6c3bb9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044/commits","review_comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044/comments","review_comment_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/1044/comments","statuses_url":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/8b3256d1404f6bcab0c55174f89c9319318170d6","head":{"label":"sequenceiq:fly","ref":"fly","sha":"8b3256d1404f6bcab0c55174f89c9319318170d6","user":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"name":"cloudbreak","full_name":"sequenceiq/cloudbreak","owner":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequenceiq/cloudbreak","description":"Cloudbreak is a cloud agnostic Hadoop as a Service API.","fork":false,"url":"https://api.github.com/repos/sequenceiq/cloudbreak","forks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/forks","keys_url":"https://api.github.com/repos/sequenceiq/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequenceiq/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequenceiq/cloudbreak/teams","hooks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/events","assignees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/sequenceiq/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/tags","blobs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/sequenceiq/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscription","commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/sequenceiq/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequenceiq/cloudbreak/merges","archive_url":"https://api.github.com/repos/sequenceiq/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequenceiq/cloudbreak/downloads","issues_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/sequenceiq/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/sequenceiq/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequenceiq/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/sequenceiq/cloudbreak/releases{/id}","created_at":"2014-05-10T10:03:07Z","updated_at":"2015-10-12T07:58:32Z","pushed_at":"2015-10-16T09:44:16Z","git_url":"git://github.com/sequenceiq/cloudbreak.git","ssh_url":"git@github.com:sequenceiq/cloudbreak.git","clone_url":"https://github.com/sequenceiq/cloudbreak.git","svn_url":"https://github.com/sequenceiq/cloudbreak","homepage":"https://cloudbreak.sequenceiq.com/","size":27884,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":11,"forks":23,"open_issues":11,"watchers":118,"default_branch":"master"}},"base":{"label":"sequenceiq:master","ref":"master","sha":"04602cd18775fbc412fd5ec4b415ec135cd12b19","user":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"repo":{"id":19638422,"name":"cloudbreak","full_name":"sequenceiq/cloudbreak","owner":{"login":"sequenceiq","id":6003133,"avatar_url":"https://avatars.githubusercontent.com/u/6003133?v=3","gravatar_id":"","url":"https://api.github.com/users/sequenceiq","html_url":"https://github.com/sequenceiq","followers_url":"https://api.github.com/users/sequenceiq/followers","following_url":"https://api.github.com/users/sequenceiq/following{/other_user}","gists_url":"https://api.github.com/users/sequenceiq/gists{/gist_id}","starred_url":"https://api.github.com/users/sequenceiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequenceiq/subscriptions","organizations_url":"https://api.github.com/users/sequenceiq/orgs","repos_url":"https://api.github.com/users/sequenceiq/repos","events_url":"https://api.github.com/users/sequenceiq/events{/privacy}","received_events_url":"https://api.github.com/users/sequenceiq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequenceiq/cloudbreak","description":"Cloudbreak is a cloud agnostic Hadoop as a Service API.","fork":false,"url":"https://api.github.com/repos/sequenceiq/cloudbreak","forks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/forks","keys_url":"https://api.github.com/repos/sequenceiq/cloudbreak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequenceiq/cloudbreak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequenceiq/cloudbreak/teams","hooks_url":"https://api.github.com/repos/sequenceiq/cloudbreak/hooks","issue_events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/events{/number}","events_url":"https://api.github.com/repos/sequenceiq/cloudbreak/events","assignees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/assignees{/user}","branches_url":"https://api.github.com/repos/sequenceiq/cloudbreak/branches{/branch}","tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/tags","blobs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/{sha}","languages_url":"https://api.github.com/repos/sequenceiq/cloudbreak/languages","stargazers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/stargazers","contributors_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contributors","subscribers_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscribers","subscription_url":"https://api.github.com/repos/sequenceiq/cloudbreak/subscription","commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequenceiq/cloudbreak/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequenceiq/cloudbreak/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequenceiq/cloudbreak/contents/{+path}","compare_url":"https://api.github.com/repos/sequenceiq/cloudbreak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequenceiq/cloudbreak/merges","archive_url":"https://api.github.com/repos/sequenceiq/cloudbreak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequenceiq/cloudbreak/downloads","issues_url":"https://api.github.com/repos/sequenceiq/cloudbreak/issues{/number}","pulls_url":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls{/number}","milestones_url":"https://api.github.com/repos/sequenceiq/cloudbreak/milestones{/number}","notifications_url":"https://api.github.com/repos/sequenceiq/cloudbreak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequenceiq/cloudbreak/labels{/name}","releases_url":"https://api.github.com/repos/sequenceiq/cloudbreak/releases{/id}","created_at":"2014-05-10T10:03:07Z","updated_at":"2015-10-12T07:58:32Z","pushed_at":"2015-10-16T09:44:16Z","git_url":"git://github.com/sequenceiq/cloudbreak.git","ssh_url":"git@github.com:sequenceiq/cloudbreak.git","clone_url":"https://github.com/sequenceiq/cloudbreak.git","svn_url":"https://github.com/sequenceiq/cloudbreak","homepage":"https://cloudbreak.sequenceiq.com/","size":27884,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":11,"forks":23,"open_issues":11,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044"},"html":{"href":"https://github.com/sequenceiq/cloudbreak/pull/1044"},"issue":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/1044"},"comments":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/issues/1044/comments"},"review_comments":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044/comments"},"review_comment":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/pulls/1044/commits"},"statuses":{"href":"https://api.github.com/repos/sequenceiq/cloudbreak/statuses/8b3256d1404f6bcab0c55174f89c9319318170d6"}}}}