{"action":"created","issue":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/11","labels_url":"https://api.github.com/repos/oracle/node-oracledb/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/oracle/node-oracledb/issues/11/comments","events_url":"https://api.github.com/repos/oracle/node-oracledb/issues/11/events","html_url":"https://github.com/oracle/node-oracledb/pull/11","id":55424015,"number":11,"title":"Update webapp.js","user":{"login":"bchr02","id":10158167,"avatar_url":"https://avatars.githubusercontent.com/u/10158167?v=3","gravatar_id":"","url":"https://api.github.com/users/bchr02","html_url":"https://github.com/bchr02","followers_url":"https://api.github.com/users/bchr02/followers","following_url":"https://api.github.com/users/bchr02/following{/other_user}","gists_url":"https://api.github.com/users/bchr02/gists{/gist_id}","starred_url":"https://api.github.com/users/bchr02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchr02/subscriptions","organizations_url":"https://api.github.com/users/bchr02/orgs","repos_url":"https://api.github.com/users/bchr02/repos","events_url":"https://api.github.com/users/bchr02/events{/privacy}","received_events_url":"https://api.github.com/users/bchr02/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oracle/node-oracledb/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-25T18:19:37Z","updated_at":"2015-08-09T03:25:01Z","closed_at":"2015-08-08T23:31:47Z","pull_request":{"url":"https://api.github.com/repos/oracle/node-oracledb/pulls/11","html_url":"https://github.com/oracle/node-oracledb/pull/11","diff_url":"https://github.com/oracle/node-oracledb/pull/11.diff","patch_url":"https://github.com/oracle/node-oracledb/pull/11.patch"},"body":"SIGTERM is not compatible with Windows. As such, the connection pool would never be terminated...\r\n\r\nBy refactoring the code so that the callback function is defined in a variable, we are able to call it under two separate conditions.\r\n1.) when a SIGTERM is received.\r\n2.) when a SIGINT is received on Windows.\r\n\r\nI emailed a signed OC Agreement a few minutes ago.\r\n\r\nSigned-off-by: Bill Christo <billchristo@gmail.com>\r\n\r\n*more info on SIGNTERM and SIGINT can be found here: http://nodejs.org/api/process.html#process_signal_events"},"comment":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/comments/129100215","html_url":"https://github.com/oracle/node-oracledb/pull/11#issuecomment-129100215","issue_url":"https://api.github.com/repos/oracle/node-oracledb/issues/11","id":129100215,"user":{"login":"cjbj","id":200778,"avatar_url":"https://avatars.githubusercontent.com/u/200778?v=3","gravatar_id":"","url":"https://api.github.com/users/cjbj","html_url":"https://github.com/cjbj","followers_url":"https://api.github.com/users/cjbj/followers","following_url":"https://api.github.com/users/cjbj/following{/other_user}","gists_url":"https://api.github.com/users/cjbj/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbj/subscriptions","organizations_url":"https://api.github.com/users/cjbj/orgs","repos_url":"https://api.github.com/users/cjbj/repos","events_url":"https://api.github.com/users/cjbj/events{/privacy}","received_events_url":"https://api.github.com/users/cjbj/received_events","type":"User","site_admin":false},"created_at":"2015-08-09T03:25:01Z","updated_at":"2015-08-09T03:25:01Z","body":"Thanks @bchr02 we should revisit this one day."}}