{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/35188115","id":35188115,"diff_hunk":"@@ -34,7 +33,7 @@\n  */\n public class UpdateEntryProcessor extends AbstractRegionCacheEntryProcessor {\n \n-    private SoftLock lock;\n+    private Object lock;","path":"hazelcast-hibernate/hazelcast-hibernate3/src/main/java/com/hazelcast/hibernate/distributed/UpdateEntryProcessor.java","position":13,"original_position":13,"commit_id":"c8ec54b35af8dbe06348509c15a2002b6814940a","original_commit_id":"c8ec54b35af8dbe06348509c15a2002b6814940a","user":{"login":"jhinch","id":594559,"avatar_url":"https://avatars.githubusercontent.com/u/594559?v=3","gravatar_id":"","url":"https://api.github.com/users/jhinch","html_url":"https://github.com/jhinch","followers_url":"https://api.github.com/users/jhinch/followers","following_url":"https://api.github.com/users/jhinch/following{/other_user}","gists_url":"https://api.github.com/users/jhinch/gists{/gist_id}","starred_url":"https://api.github.com/users/jhinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhinch/subscriptions","organizations_url":"https://api.github.com/users/jhinch/orgs","repos_url":"https://api.github.com/users/jhinch/repos","events_url":"https://api.github.com/users/jhinch/events{/privacy}","received_events_url":"https://api.github.com/users/jhinch/received_events","type":"User","site_admin":false},"body":"I would recommend using `ExpiryMarker` here. ","created_at":"2015-07-22T07:38:37Z","updated_at":"2015-07-22T07:38:37Z","html_url":"https://github.com/hazelcast/hazelcast/pull/5752#discussion_r35188115","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/35188115"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5752#discussion_r35188115"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752","id":40434878,"html_url":"https://github.com/hazelcast/hazelcast/pull/5752","diff_url":"https://github.com/hazelcast/hazelcast/pull/5752.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/5752.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5752","number":5752,"state":"open","locked":false,"title":"Removed unnecessary SoftLock reference in hibernate EntryProcesors","user":{"login":"kobalski","id":3218140,"avatar_url":"https://avatars.githubusercontent.com/u/3218140?v=3","gravatar_id":"","url":"https://api.github.com/users/kobalski","html_url":"https://github.com/kobalski","followers_url":"https://api.github.com/users/kobalski/followers","following_url":"https://api.github.com/users/kobalski/following{/other_user}","gists_url":"https://api.github.com/users/kobalski/gists{/gist_id}","starred_url":"https://api.github.com/users/kobalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobalski/subscriptions","organizations_url":"https://api.github.com/users/kobalski/orgs","repos_url":"https://api.github.com/users/kobalski/repos","events_url":"https://api.github.com/users/kobalski/events{/privacy}","received_events_url":"https://api.github.com/users/kobalski/received_events","type":"User","site_admin":false},"body":"Hibernate EntryProcessor were using SoftLock interface unnecessarily.\r\nBecause of this, when 2nd Level Cache is used with client only mode,\r\nremote cluster should have hibernate-core jars in the class path. With\r\nthis PR, such requirement is not needed any more.","created_at":"2015-07-21T08:48:43Z","updated_at":"2015-07-22T07:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbaf6e6b696b67814e628267d511debf0f4cd793","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5752/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c8ec54b35af8dbe06348509c15a2002b6814940a","head":{"label":"kobalski:fix/master/remove_soft_lock_dependency","ref":"fix/master/remove_soft_lock_dependency","sha":"c8ec54b35af8dbe06348509c15a2002b6814940a","user":{"login":"kobalski","id":3218140,"avatar_url":"https://avatars.githubusercontent.com/u/3218140?v=3","gravatar_id":"","url":"https://api.github.com/users/kobalski","html_url":"https://github.com/kobalski","followers_url":"https://api.github.com/users/kobalski/followers","following_url":"https://api.github.com/users/kobalski/following{/other_user}","gists_url":"https://api.github.com/users/kobalski/gists{/gist_id}","starred_url":"https://api.github.com/users/kobalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobalski/subscriptions","organizations_url":"https://api.github.com/users/kobalski/orgs","repos_url":"https://api.github.com/users/kobalski/repos","events_url":"https://api.github.com/users/kobalski/events{/privacy}","received_events_url":"https://api.github.com/users/kobalski/received_events","type":"User","site_admin":false},"repo":{"id":34377800,"name":"hazelcast","full_name":"kobalski/hazelcast","owner":{"login":"kobalski","id":3218140,"avatar_url":"https://avatars.githubusercontent.com/u/3218140?v=3","gravatar_id":"","url":"https://api.github.com/users/kobalski","html_url":"https://github.com/kobalski","followers_url":"https://api.github.com/users/kobalski/followers","following_url":"https://api.github.com/users/kobalski/following{/other_user}","gists_url":"https://api.github.com/users/kobalski/gists{/gist_id}","starred_url":"https://api.github.com/users/kobalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobalski/subscriptions","organizations_url":"https://api.github.com/users/kobalski/orgs","repos_url":"https://api.github.com/users/kobalski/repos","events_url":"https://api.github.com/users/kobalski/events{/privacy}","received_events_url":"https://api.github.com/users/kobalski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kobalski/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/kobalski/hazelcast","forks_url":"https://api.github.com/repos/kobalski/hazelcast/forks","keys_url":"https://api.github.com/repos/kobalski/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobalski/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobalski/hazelcast/teams","hooks_url":"https://api.github.com/repos/kobalski/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/kobalski/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/kobalski/hazelcast/events","assignees_url":"https://api.github.com/repos/kobalski/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/kobalski/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/kobalski/hazelcast/tags","blobs_url":"https://api.github.com/repos/kobalski/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobalski/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobalski/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobalski/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobalski/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/kobalski/hazelcast/languages","stargazers_url":"https://api.github.com/repos/kobalski/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/kobalski/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/kobalski/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/kobalski/hazelcast/subscription","commits_url":"https://api.github.com/repos/kobalski/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobalski/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobalski/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobalski/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/kobalski/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/kobalski/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobalski/hazelcast/merges","archive_url":"https://api.github.com/repos/kobalski/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobalski/hazelcast/downloads","issues_url":"https://api.github.com/repos/kobalski/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/kobalski/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/kobalski/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/kobalski/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobalski/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/kobalski/hazelcast/releases{/id}","created_at":"2015-04-22T08:14:56Z","updated_at":"2015-05-04T12:54:38Z","pushed_at":"2015-07-22T07:24:31Z","git_url":"git://github.com/kobalski/hazelcast.git","ssh_url":"git@github.com:kobalski/hazelcast.git","clone_url":"https://github.com/kobalski/hazelcast.git","svn_url":"https://github.com/kobalski/hazelcast","homepage":"www.hazelcast.com","size":71709,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"0ec3fd604bb407c6754c9371a7b29f6abfc595f2","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-07-20T19:44:24Z","pushed_at":"2015-07-22T07:24:32Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":143667,"stargazers_count":1184,"watchers_count":1184,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":571,"mirror_url":null,"open_issues_count":458,"forks":571,"open_issues":458,"watchers":1184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5752"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5752"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5752/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5752/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c8ec54b35af8dbe06348509c15a2002b6814940a"}}}}