{"action":"closed","number":1904,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1904","id":45315453,"html_url":"https://github.com/uProxy/uproxy/pull/1904","diff_url":"https://github.com/uProxy/uproxy/pull/1904.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1904.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1904","number":1904,"state":"closed","locked":false,"title":"Tweaks to reconnect behaviour","user":{"login":"jpevarnek","id":902894,"avatar_url":"https://avatars.githubusercontent.com/u/902894?v=3","gravatar_id":"","url":"https://api.github.com/users/jpevarnek","html_url":"https://github.com/jpevarnek","followers_url":"https://api.github.com/users/jpevarnek/followers","following_url":"https://api.github.com/users/jpevarnek/following{/other_user}","gists_url":"https://api.github.com/users/jpevarnek/gists{/gist_id}","starred_url":"https://api.github.com/users/jpevarnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpevarnek/subscriptions","organizations_url":"https://api.github.com/users/jpevarnek/orgs","repos_url":"https://api.github.com/users/jpevarnek/repos","events_url":"https://api.github.com/users/jpevarnek/events{/privacy}","received_events_url":"https://api.github.com/users/jpevarnek/received_events","type":"User","site_admin":false},"body":"This is in two parts: the first makes it so that we will immediately abort an attempt to connect if we lose access (instead of waiting until we time out).  The second part of this makes it so that we will not show the reconnect error in the case where there was no user to reconnect to (i.e. copy+paste).\r\n\r\nI wanted to make changes so that the reconnect dialog would show better contextual information about whether you had access to reconnect, however, that does not seem to be possible without reworking a large amount of code for both Core <-> UI communications and the actual UI state storage.  A project for another day :(\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1904)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-09-17T17:03:18Z","updated_at":"2015-09-25T21:32:21Z","closed_at":"2015-09-25T21:32:21Z","merged_at":"2015-09-25T21:32:21Z","merge_commit_sha":"ffdc5cd9ef30514b787e8455f951a818b02dcff3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/1904/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/1904/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1904/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/04d3899777f348e8f70ea61fa37557938200bb97","head":{"label":"uProxy:stop-reconnect-no-access","ref":"stop-reconnect-no-access","sha":"04d3899777f348e8f70ea61fa37557938200bb97","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","created_at":"2014-04-07T20:34:40Z","updated_at":"2015-09-25T18:22:44Z","pushed_at":"2015-09-25T21:32:21Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":25794,"stargazers_count":257,"watchers_count":257,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":436,"forks":52,"open_issues":436,"watchers":257,"default_branch":"dev"}},"base":{"label":"uProxy:dev","ref":"dev","sha":"0423d12e042e37c09cb970a2229a32a5ac9202aa","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","created_at":"2014-04-07T20:34:40Z","updated_at":"2015-09-25T18:22:44Z","pushed_at":"2015-09-25T21:32:21Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":25794,"stargazers_count":257,"watchers_count":257,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":436,"forks":52,"open_issues":436,"watchers":257,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1904"},"html":{"href":"https://github.com/uProxy/uproxy/pull/1904"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/1904"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/1904/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1904/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1904/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/04d3899777f348e8f70ea61fa37557938200bb97"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jpevarnek","id":902894,"avatar_url":"https://avatars.githubusercontent.com/u/902894?v=3","gravatar_id":"","url":"https://api.github.com/users/jpevarnek","html_url":"https://github.com/jpevarnek","followers_url":"https://api.github.com/users/jpevarnek/followers","following_url":"https://api.github.com/users/jpevarnek/following{/other_user}","gists_url":"https://api.github.com/users/jpevarnek/gists{/gist_id}","starred_url":"https://api.github.com/users/jpevarnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpevarnek/subscriptions","organizations_url":"https://api.github.com/users/jpevarnek/orgs","repos_url":"https://api.github.com/users/jpevarnek/repos","events_url":"https://api.github.com/users/jpevarnek/events{/privacy}","received_events_url":"https://api.github.com/users/jpevarnek/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":9,"deletions":2,"changed_files":2}}