{"action":"closed","number":100,"pull_request":{"url":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100","id":45774188,"html_url":"https://github.com/nickoneill/PermissionScope/pull/100","diff_url":"https://github.com/nickoneill/PermissionScope/pull/100.diff","patch_url":"https://github.com/nickoneill/PermissionScope/pull/100.patch","issue_url":"https://api.github.com/repos/nickoneill/PermissionScope/issues/100","number":100,"state":"closed","locked":false,"title":"callbacks changed to be called on the main thread rather than background","user":{"login":"kylejm","id":3501212,"avatar_url":"https://avatars.githubusercontent.com/u/3501212?v=3","gravatar_id":"","url":"https://api.github.com/users/kylejm","html_url":"https://github.com/kylejm","followers_url":"https://api.github.com/users/kylejm/followers","following_url":"https://api.github.com/users/kylejm/following{/other_user}","gists_url":"https://api.github.com/users/kylejm/gists{/gist_id}","starred_url":"https://api.github.com/users/kylejm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylejm/subscriptions","organizations_url":"https://api.github.com/users/kylejm/orgs","repos_url":"https://api.github.com/users/kylejm/repos","events_url":"https://api.github.com/users/kylejm/events{/privacy}","received_events_url":"https://api.github.com/users/kylejm/received_events","type":"User","site_admin":false},"body":"Unless there is a good reason as to why callbacks are called on a background thread, they should be called on the main thread. It’s *very* likely that most users will be doing UI stuff in these callbacks.","created_at":"2015-09-23T12:43:06Z","updated_at":"2015-09-23T15:39:00Z","closed_at":"2015-09-23T15:39:00Z","merged_at":"2015-09-23T15:39:00Z","merge_commit_sha":"e1626838adbac02dc13b068ac962b5d51ce0db06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100/commits","review_comments_url":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100/comments","review_comment_url":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nickoneill/PermissionScope/issues/100/comments","statuses_url":"https://api.github.com/repos/nickoneill/PermissionScope/statuses/236ba215d9435e4dcd3aebdfa52f704eece144fd","head":{"label":"kylejm:master","ref":"master","sha":"236ba215d9435e4dcd3aebdfa52f704eece144fd","user":{"login":"kylejm","id":3501212,"avatar_url":"https://avatars.githubusercontent.com/u/3501212?v=3","gravatar_id":"","url":"https://api.github.com/users/kylejm","html_url":"https://github.com/kylejm","followers_url":"https://api.github.com/users/kylejm/followers","following_url":"https://api.github.com/users/kylejm/following{/other_user}","gists_url":"https://api.github.com/users/kylejm/gists{/gist_id}","starred_url":"https://api.github.com/users/kylejm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylejm/subscriptions","organizations_url":"https://api.github.com/users/kylejm/orgs","repos_url":"https://api.github.com/users/kylejm/repos","events_url":"https://api.github.com/users/kylejm/events{/privacy}","received_events_url":"https://api.github.com/users/kylejm/received_events","type":"User","site_admin":false},"repo":{"id":38366798,"name":"PermissionScope","full_name":"kylejm/PermissionScope","owner":{"login":"kylejm","id":3501212,"avatar_url":"https://avatars.githubusercontent.com/u/3501212?v=3","gravatar_id":"","url":"https://api.github.com/users/kylejm","html_url":"https://github.com/kylejm","followers_url":"https://api.github.com/users/kylejm/followers","following_url":"https://api.github.com/users/kylejm/following{/other_user}","gists_url":"https://api.github.com/users/kylejm/gists{/gist_id}","starred_url":"https://api.github.com/users/kylejm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylejm/subscriptions","organizations_url":"https://api.github.com/users/kylejm/orgs","repos_url":"https://api.github.com/users/kylejm/repos","events_url":"https://api.github.com/users/kylejm/events{/privacy}","received_events_url":"https://api.github.com/users/kylejm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kylejm/PermissionScope","description":"Intelligent iOS permissions UI and unified API","fork":true,"url":"https://api.github.com/repos/kylejm/PermissionScope","forks_url":"https://api.github.com/repos/kylejm/PermissionScope/forks","keys_url":"https://api.github.com/repos/kylejm/PermissionScope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kylejm/PermissionScope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kylejm/PermissionScope/teams","hooks_url":"https://api.github.com/repos/kylejm/PermissionScope/hooks","issue_events_url":"https://api.github.com/repos/kylejm/PermissionScope/issues/events{/number}","events_url":"https://api.github.com/repos/kylejm/PermissionScope/events","assignees_url":"https://api.github.com/repos/kylejm/PermissionScope/assignees{/user}","branches_url":"https://api.github.com/repos/kylejm/PermissionScope/branches{/branch}","tags_url":"https://api.github.com/repos/kylejm/PermissionScope/tags","blobs_url":"https://api.github.com/repos/kylejm/PermissionScope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kylejm/PermissionScope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kylejm/PermissionScope/git/refs{/sha}","trees_url":"https://api.github.com/repos/kylejm/PermissionScope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kylejm/PermissionScope/statuses/{sha}","languages_url":"https://api.github.com/repos/kylejm/PermissionScope/languages","stargazers_url":"https://api.github.com/repos/kylejm/PermissionScope/stargazers","contributors_url":"https://api.github.com/repos/kylejm/PermissionScope/contributors","subscribers_url":"https://api.github.com/repos/kylejm/PermissionScope/subscribers","subscription_url":"https://api.github.com/repos/kylejm/PermissionScope/subscription","commits_url":"https://api.github.com/repos/kylejm/PermissionScope/commits{/sha}","git_commits_url":"https://api.github.com/repos/kylejm/PermissionScope/git/commits{/sha}","comments_url":"https://api.github.com/repos/kylejm/PermissionScope/comments{/number}","issue_comment_url":"https://api.github.com/repos/kylejm/PermissionScope/issues/comments{/number}","contents_url":"https://api.github.com/repos/kylejm/PermissionScope/contents/{+path}","compare_url":"https://api.github.com/repos/kylejm/PermissionScope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kylejm/PermissionScope/merges","archive_url":"https://api.github.com/repos/kylejm/PermissionScope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kylejm/PermissionScope/downloads","issues_url":"https://api.github.com/repos/kylejm/PermissionScope/issues{/number}","pulls_url":"https://api.github.com/repos/kylejm/PermissionScope/pulls{/number}","milestones_url":"https://api.github.com/repos/kylejm/PermissionScope/milestones{/number}","notifications_url":"https://api.github.com/repos/kylejm/PermissionScope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kylejm/PermissionScope/labels{/name}","releases_url":"https://api.github.com/repos/kylejm/PermissionScope/releases{/id}","created_at":"2015-07-01T11:11:18Z","updated_at":"2015-07-01T11:11:19Z","pushed_at":"2015-09-23T12:43:04Z","git_url":"git://github.com/kylejm/PermissionScope.git","ssh_url":"git@github.com:kylejm/PermissionScope.git","clone_url":"https://github.com/kylejm/PermissionScope.git","svn_url":"https://github.com/kylejm/PermissionScope","homepage":"","size":626,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nickoneill:master","ref":"master","sha":"9738e3691529fbeccecce773d1d0da35440db905","user":{"login":"nickoneill","id":49688,"avatar_url":"https://avatars.githubusercontent.com/u/49688?v=3","gravatar_id":"","url":"https://api.github.com/users/nickoneill","html_url":"https://github.com/nickoneill","followers_url":"https://api.github.com/users/nickoneill/followers","following_url":"https://api.github.com/users/nickoneill/following{/other_user}","gists_url":"https://api.github.com/users/nickoneill/gists{/gist_id}","starred_url":"https://api.github.com/users/nickoneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickoneill/subscriptions","organizations_url":"https://api.github.com/users/nickoneill/orgs","repos_url":"https://api.github.com/users/nickoneill/repos","events_url":"https://api.github.com/users/nickoneill/events{/privacy}","received_events_url":"https://api.github.com/users/nickoneill/received_events","type":"User","site_admin":false},"repo":{"id":33456123,"name":"PermissionScope","full_name":"nickoneill/PermissionScope","owner":{"login":"nickoneill","id":49688,"avatar_url":"https://avatars.githubusercontent.com/u/49688?v=3","gravatar_id":"","url":"https://api.github.com/users/nickoneill","html_url":"https://github.com/nickoneill","followers_url":"https://api.github.com/users/nickoneill/followers","following_url":"https://api.github.com/users/nickoneill/following{/other_user}","gists_url":"https://api.github.com/users/nickoneill/gists{/gist_id}","starred_url":"https://api.github.com/users/nickoneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickoneill/subscriptions","organizations_url":"https://api.github.com/users/nickoneill/orgs","repos_url":"https://api.github.com/users/nickoneill/repos","events_url":"https://api.github.com/users/nickoneill/events{/privacy}","received_events_url":"https://api.github.com/users/nickoneill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickoneill/PermissionScope","description":"Intelligent iOS permissions UI and unified API","fork":false,"url":"https://api.github.com/repos/nickoneill/PermissionScope","forks_url":"https://api.github.com/repos/nickoneill/PermissionScope/forks","keys_url":"https://api.github.com/repos/nickoneill/PermissionScope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickoneill/PermissionScope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickoneill/PermissionScope/teams","hooks_url":"https://api.github.com/repos/nickoneill/PermissionScope/hooks","issue_events_url":"https://api.github.com/repos/nickoneill/PermissionScope/issues/events{/number}","events_url":"https://api.github.com/repos/nickoneill/PermissionScope/events","assignees_url":"https://api.github.com/repos/nickoneill/PermissionScope/assignees{/user}","branches_url":"https://api.github.com/repos/nickoneill/PermissionScope/branches{/branch}","tags_url":"https://api.github.com/repos/nickoneill/PermissionScope/tags","blobs_url":"https://api.github.com/repos/nickoneill/PermissionScope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickoneill/PermissionScope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickoneill/PermissionScope/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickoneill/PermissionScope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickoneill/PermissionScope/statuses/{sha}","languages_url":"https://api.github.com/repos/nickoneill/PermissionScope/languages","stargazers_url":"https://api.github.com/repos/nickoneill/PermissionScope/stargazers","contributors_url":"https://api.github.com/repos/nickoneill/PermissionScope/contributors","subscribers_url":"https://api.github.com/repos/nickoneill/PermissionScope/subscribers","subscription_url":"https://api.github.com/repos/nickoneill/PermissionScope/subscription","commits_url":"https://api.github.com/repos/nickoneill/PermissionScope/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickoneill/PermissionScope/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickoneill/PermissionScope/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickoneill/PermissionScope/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickoneill/PermissionScope/contents/{+path}","compare_url":"https://api.github.com/repos/nickoneill/PermissionScope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickoneill/PermissionScope/merges","archive_url":"https://api.github.com/repos/nickoneill/PermissionScope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickoneill/PermissionScope/downloads","issues_url":"https://api.github.com/repos/nickoneill/PermissionScope/issues{/number}","pulls_url":"https://api.github.com/repos/nickoneill/PermissionScope/pulls{/number}","milestones_url":"https://api.github.com/repos/nickoneill/PermissionScope/milestones{/number}","notifications_url":"https://api.github.com/repos/nickoneill/PermissionScope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickoneill/PermissionScope/labels{/name}","releases_url":"https://api.github.com/repos/nickoneill/PermissionScope/releases{/id}","created_at":"2015-04-05T21:37:27Z","updated_at":"2015-09-23T05:00:21Z","pushed_at":"2015-09-23T15:39:00Z","git_url":"git://github.com/nickoneill/PermissionScope.git","ssh_url":"git@github.com:nickoneill/PermissionScope.git","clone_url":"https://github.com/nickoneill/PermissionScope.git","svn_url":"https://github.com/nickoneill/PermissionScope","homepage":"","size":2033,"stargazers_count":1185,"watchers_count":1185,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":17,"forks":72,"open_issues":17,"watchers":1185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100"},"html":{"href":"https://github.com/nickoneill/PermissionScope/pull/100"},"issue":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/issues/100"},"comments":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/nickoneill/PermissionScope/statuses/236ba215d9435e4dcd3aebdfa52f704eece144fd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nickoneill","id":49688,"avatar_url":"https://avatars.githubusercontent.com/u/49688?v=3","gravatar_id":"","url":"https://api.github.com/users/nickoneill","html_url":"https://github.com/nickoneill","followers_url":"https://api.github.com/users/nickoneill/followers","following_url":"https://api.github.com/users/nickoneill/following{/other_user}","gists_url":"https://api.github.com/users/nickoneill/gists{/gist_id}","starred_url":"https://api.github.com/users/nickoneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickoneill/subscriptions","organizations_url":"https://api.github.com/users/nickoneill/orgs","repos_url":"https://api.github.com/users/nickoneill/repos","events_url":"https://api.github.com/users/nickoneill/events{/privacy}","received_events_url":"https://api.github.com/users/nickoneill/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}