{"action":"closed","number":4716,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/4716","id":27995573,"html_url":"https://github.com/servo/servo/pull/4716","diff_url":"https://github.com/servo/servo/pull/4716.diff","patch_url":"https://github.com/servo/servo/pull/4716.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/4716","number":4716,"state":"closed","locked":false,"title":"AArch64-specific workaround: `int::to_i32()` seems to be flawed","user":{"login":"akiss77","id":9976482,"avatar_url":"https://avatars.githubusercontent.com/u/9976482?v=3","gravatar_id":"","url":"https://api.github.com/users/akiss77","html_url":"https://github.com/akiss77","followers_url":"https://api.github.com/users/akiss77/followers","following_url":"https://api.github.com/users/akiss77/following{/other_user}","gists_url":"https://api.github.com/users/akiss77/gists{/gist_id}","starred_url":"https://api.github.com/users/akiss77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiss77/subscriptions","organizations_url":"https://api.github.com/users/akiss77/orgs","repos_url":"https://api.github.com/users/akiss77/repos","events_url":"https://api.github.com/users/akiss77/events{/privacy}","received_events_url":"https://api.github.com/users/akiss77/received_events","type":"User","site_admin":false},"body":"In the call chain `Au::from_px(int)` -> `Au::from::<int>(int)` -> `int::to_i32()`,\r\nthe last item seems to be flawed and returns `None` for valid arguments as well\r\n(e.g., for 16*60=960). The error seems to stem from Rust, and for now, it can be\r\nfixed in Servo only with a workaround. Casting the argument of `from_px` to from\r\n`int` to `i32` changes the call chain (-> `Au::from::<i32>(i32)` ->\r\n`i32::to_i32()`) so that it works correctly.","created_at":"2015-01-25T18:19:37Z","updated_at":"2015-01-26T22:12:38Z","closed_at":"2015-01-26T22:12:38Z","merged_at":null,"merge_commit_sha":"c7d27249da55a113be6348b492e1dc95188b9050","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/4716/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/4716/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/servo/servo/issues/4716/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/4ba046638b8bdc874a57eda00f66a89f6f8490e1","head":{"label":"akiss77:pr-rustup_20150109-util-au-from_px","ref":"pr-rustup_20150109-util-au-from_px","sha":"4ba046638b8bdc874a57eda00f66a89f6f8490e1","user":{"login":"akiss77","id":9976482,"avatar_url":"https://avatars.githubusercontent.com/u/9976482?v=3","gravatar_id":"","url":"https://api.github.com/users/akiss77","html_url":"https://github.com/akiss77","followers_url":"https://api.github.com/users/akiss77/followers","following_url":"https://api.github.com/users/akiss77/following{/other_user}","gists_url":"https://api.github.com/users/akiss77/gists{/gist_id}","starred_url":"https://api.github.com/users/akiss77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiss77/subscriptions","organizations_url":"https://api.github.com/users/akiss77/orgs","repos_url":"https://api.github.com/users/akiss77/repos","events_url":"https://api.github.com/users/akiss77/events{/privacy}","received_events_url":"https://api.github.com/users/akiss77/received_events","type":"User","site_admin":false},"repo":{"id":29305499,"name":"servo","full_name":"akiss77/servo","owner":{"login":"akiss77","id":9976482,"avatar_url":"https://avatars.githubusercontent.com/u/9976482?v=3","gravatar_id":"","url":"https://api.github.com/users/akiss77","html_url":"https://github.com/akiss77","followers_url":"https://api.github.com/users/akiss77/followers","following_url":"https://api.github.com/users/akiss77/following{/other_user}","gists_url":"https://api.github.com/users/akiss77/gists{/gist_id}","starred_url":"https://api.github.com/users/akiss77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiss77/subscriptions","organizations_url":"https://api.github.com/users/akiss77/orgs","repos_url":"https://api.github.com/users/akiss77/repos","events_url":"https://api.github.com/users/akiss77/events{/privacy}","received_events_url":"https://api.github.com/users/akiss77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akiss77/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/akiss77/servo","forks_url":"https://api.github.com/repos/akiss77/servo/forks","keys_url":"https://api.github.com/repos/akiss77/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akiss77/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akiss77/servo/teams","hooks_url":"https://api.github.com/repos/akiss77/servo/hooks","issue_events_url":"https://api.github.com/repos/akiss77/servo/issues/events{/number}","events_url":"https://api.github.com/repos/akiss77/servo/events","assignees_url":"https://api.github.com/repos/akiss77/servo/assignees{/user}","branches_url":"https://api.github.com/repos/akiss77/servo/branches{/branch}","tags_url":"https://api.github.com/repos/akiss77/servo/tags","blobs_url":"https://api.github.com/repos/akiss77/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akiss77/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akiss77/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/akiss77/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akiss77/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/akiss77/servo/languages","stargazers_url":"https://api.github.com/repos/akiss77/servo/stargazers","contributors_url":"https://api.github.com/repos/akiss77/servo/contributors","subscribers_url":"https://api.github.com/repos/akiss77/servo/subscribers","subscription_url":"https://api.github.com/repos/akiss77/servo/subscription","commits_url":"https://api.github.com/repos/akiss77/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/akiss77/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/akiss77/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/akiss77/servo/issues/comments/{number}","contents_url":"https://api.github.com/repos/akiss77/servo/contents/{+path}","compare_url":"https://api.github.com/repos/akiss77/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akiss77/servo/merges","archive_url":"https://api.github.com/repos/akiss77/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akiss77/servo/downloads","issues_url":"https://api.github.com/repos/akiss77/servo/issues{/number}","pulls_url":"https://api.github.com/repos/akiss77/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/akiss77/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/akiss77/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akiss77/servo/labels{/name}","releases_url":"https://api.github.com/repos/akiss77/servo/releases{/id}","created_at":"2015-01-15T16:09:54Z","updated_at":"2015-01-15T16:09:58Z","pushed_at":"2015-01-25T18:15:31Z","git_url":"git://github.com/akiss77/servo.git","ssh_url":"git@github.com:akiss77/servo.git","clone_url":"https://github.com/akiss77/servo.git","svn_url":"https://github.com/akiss77/servo","homepage":"","size":37393,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:rustup_20150109","ref":"rustup_20150109","sha":"24d614aef0554fbbd0c60b0e367008c332a9961f","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments/{number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-01-26T18:59:18Z","pushed_at":"2015-01-26T21:36:45Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":76921,"stargazers_count":2927,"watchers_count":2927,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":502,"mirror_url":null,"open_issues_count":772,"forks":502,"open_issues":772,"watchers":2927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/4716"},"html":{"href":"https://github.com/servo/servo/pull/4716"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/4716"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/4716/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/4716/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/4716/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/4ba046638b8bdc874a57eda00f66a89f6f8490e1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":10,"additions":3161,"deletions":3017,"changed_files":226}}