{"action":"created","comment":{"url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/comments/24229454","id":24229454,"diff_hunk":"@@ -88,7 +93,19 @@ def get_queryset(self):\n         \"\"\"\n         Inspired by Glen Roberton's django-geojson-tiles view\n         \"\"\"\n-        self.z, self.x, self.y = map(int, self.args[:3])\n+        try:\n+            self.z, self.x, self.y = map(int, self.args[:3])\n+        except AttributeError:\n+            # let's try to get these as kwargs\n+\n+            try:\n+\n+                self.z = int(self.kwargs['z'])\n+                self.x = int(self.kwargs['x'])\n+                self.y = int(self.kwargs['y'])\n+            except (ValueError, TypeError, KeyError):\n+                return HttpResponseBadRequest(u\"View parameters could not be processed.\")","path":"djgeojson/views.py","position":33,"original_position":33,"commit_id":"fd0958f879b175a74146f4ef5fee0b3a71ccca46","original_commit_id":"fd0958f879b175a74146f4ef5fee0b3a71ccca46","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"I just checked, and this is supported in Django 1.7 only.\r\n\r\nWell as you prefer but returning None or raising a exception would be nicer. @gutard @fle what do you think ?","created_at":"2015-02-06T09:14:25Z","updated_at":"2015-02-06T09:14:25Z","html_url":"https://github.com/makinacorpus/django-geojson/pull/52#discussion_r24229454","pull_request_url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/comments/24229454"},"html":{"href":"https://github.com/makinacorpus/django-geojson/pull/52#discussion_r24229454"},"pull_request":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52","id":28490310,"html_url":"https://github.com/makinacorpus/django-geojson/pull/52","diff_url":"https://github.com/makinacorpus/django-geojson/pull/52.diff","patch_url":"https://github.com/makinacorpus/django-geojson/pull/52.patch","issue_url":"https://api.github.com/repos/makinacorpus/django-geojson/issues/52","number":52,"state":"open","locked":false,"title":"Adding support to kwargs URLs in TiledGeoJSONLayerView and support for Django 1.7 tests","user":{"login":"george-silva","id":863039,"avatar_url":"https://avatars.githubusercontent.com/u/863039?v=3","gravatar_id":"","url":"https://api.github.com/users/george-silva","html_url":"https://github.com/george-silva","followers_url":"https://api.github.com/users/george-silva/followers","following_url":"https://api.github.com/users/george-silva/following{/other_user}","gists_url":"https://api.github.com/users/george-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/george-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-silva/subscriptions","organizations_url":"https://api.github.com/users/george-silva/orgs","repos_url":"https://api.github.com/users/george-silva/repos","events_url":"https://api.github.com/users/george-silva/events{/privacy}","received_events_url":"https://api.github.com/users/george-silva/received_events","type":"User","site_admin":false},"body":"This PR addresses two issues:\r\n\r\n* Support for using kwargs in URL's, as noted on bug #42;\r\n* Upgrading quicktest to support Django 1.7 test system, including a call on django.setup();\r\n\r\nThese are simple changes and there is a test for #42. Instead of setting everything up with args, I reused the data provided in other tests and configured kwargs instead of args. It now can handle both args and kwargs, provided that args come up empty or with AttributeError. Do you guys see any other exceptions that might be thrown inside the map call on line 92 (92 on this PR).?","created_at":"2015-02-02T18:20:42Z","updated_at":"2015-02-06T09:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4cbfb9fc27d8c124f70099042726484a2f70f8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52/commits","review_comments_url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52/comments","review_comment_url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/comments/{number}","comments_url":"https://api.github.com/repos/makinacorpus/django-geojson/issues/52/comments","statuses_url":"https://api.github.com/repos/makinacorpus/django-geojson/statuses/fd0958f879b175a74146f4ef5fee0b3a71ccca46","head":{"label":"sigma-geosistemas:master","ref":"master","sha":"fd0958f879b175a74146f4ef5fee0b3a71ccca46","user":{"login":"sigma-geosistemas","id":2894510,"avatar_url":"https://avatars.githubusercontent.com/u/2894510?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-geosistemas","html_url":"https://github.com/sigma-geosistemas","followers_url":"https://api.github.com/users/sigma-geosistemas/followers","following_url":"https://api.github.com/users/sigma-geosistemas/following{/other_user}","gists_url":"https://api.github.com/users/sigma-geosistemas/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-geosistemas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-geosistemas/subscriptions","organizations_url":"https://api.github.com/users/sigma-geosistemas/orgs","repos_url":"https://api.github.com/users/sigma-geosistemas/repos","events_url":"https://api.github.com/users/sigma-geosistemas/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-geosistemas/received_events","type":"Organization","site_admin":false},"repo":{"id":24429763,"name":"django-geojson","full_name":"sigma-geosistemas/django-geojson","owner":{"login":"sigma-geosistemas","id":2894510,"avatar_url":"https://avatars.githubusercontent.com/u/2894510?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-geosistemas","html_url":"https://github.com/sigma-geosistemas","followers_url":"https://api.github.com/users/sigma-geosistemas/followers","following_url":"https://api.github.com/users/sigma-geosistemas/following{/other_user}","gists_url":"https://api.github.com/users/sigma-geosistemas/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-geosistemas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-geosistemas/subscriptions","organizations_url":"https://api.github.com/users/sigma-geosistemas/orgs","repos_url":"https://api.github.com/users/sigma-geosistemas/repos","events_url":"https://api.github.com/users/sigma-geosistemas/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-geosistemas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sigma-geosistemas/django-geojson","description":"django-geojson is a collection of helpers to (de)serialize (Geo)Django objects into GeoJSON.","fork":true,"url":"https://api.github.com/repos/sigma-geosistemas/django-geojson","forks_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/forks","keys_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/teams","hooks_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/hooks","issue_events_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/issues/events{/number}","events_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/events","assignees_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/assignees{/user}","branches_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/branches{/branch}","tags_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/tags","blobs_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/statuses/{sha}","languages_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/languages","stargazers_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/stargazers","contributors_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/contributors","subscribers_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/subscribers","subscription_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/subscription","commits_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/issues/comments/{number}","contents_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/contents/{+path}","compare_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/merges","archive_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/downloads","issues_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/issues{/number}","pulls_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/pulls{/number}","milestones_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/milestones{/number}","notifications_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/labels{/name}","releases_url":"https://api.github.com/repos/sigma-geosistemas/django-geojson/releases{/id}","created_at":"2014-09-24T19:40:35Z","updated_at":"2015-02-05T17:16:22Z","pushed_at":"2015-02-05T17:16:22Z","git_url":"git://github.com/sigma-geosistemas/django-geojson.git","ssh_url":"git@github.com:sigma-geosistemas/django-geojson.git","clone_url":"https://github.com/sigma-geosistemas/django-geojson.git","svn_url":"https://github.com/sigma-geosistemas/django-geojson","homepage":"","size":340,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"makinacorpus:master","ref":"master","sha":"ab713e566f554a82b5e6c6f12c680fe0a884d692","user":{"login":"makinacorpus","id":546696,"avatar_url":"https://avatars.githubusercontent.com/u/546696?v=3","gravatar_id":"","url":"https://api.github.com/users/makinacorpus","html_url":"https://github.com/makinacorpus","followers_url":"https://api.github.com/users/makinacorpus/followers","following_url":"https://api.github.com/users/makinacorpus/following{/other_user}","gists_url":"https://api.github.com/users/makinacorpus/gists{/gist_id}","starred_url":"https://api.github.com/users/makinacorpus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makinacorpus/subscriptions","organizations_url":"https://api.github.com/users/makinacorpus/orgs","repos_url":"https://api.github.com/users/makinacorpus/repos","events_url":"https://api.github.com/users/makinacorpus/events{/privacy}","received_events_url":"https://api.github.com/users/makinacorpus/received_events","type":"Organization","site_admin":false},"repo":{"id":5282808,"name":"django-geojson","full_name":"makinacorpus/django-geojson","owner":{"login":"makinacorpus","id":546696,"avatar_url":"https://avatars.githubusercontent.com/u/546696?v=3","gravatar_id":"","url":"https://api.github.com/users/makinacorpus","html_url":"https://github.com/makinacorpus","followers_url":"https://api.github.com/users/makinacorpus/followers","following_url":"https://api.github.com/users/makinacorpus/following{/other_user}","gists_url":"https://api.github.com/users/makinacorpus/gists{/gist_id}","starred_url":"https://api.github.com/users/makinacorpus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makinacorpus/subscriptions","organizations_url":"https://api.github.com/users/makinacorpus/orgs","repos_url":"https://api.github.com/users/makinacorpus/repos","events_url":"https://api.github.com/users/makinacorpus/events{/privacy}","received_events_url":"https://api.github.com/users/makinacorpus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makinacorpus/django-geojson","description":"django-geojson is a collection of helpers to (de)serialize (Geo)Django objects into GeoJSON.","fork":false,"url":"https://api.github.com/repos/makinacorpus/django-geojson","forks_url":"https://api.github.com/repos/makinacorpus/django-geojson/forks","keys_url":"https://api.github.com/repos/makinacorpus/django-geojson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makinacorpus/django-geojson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makinacorpus/django-geojson/teams","hooks_url":"https://api.github.com/repos/makinacorpus/django-geojson/hooks","issue_events_url":"https://api.github.com/repos/makinacorpus/django-geojson/issues/events{/number}","events_url":"https://api.github.com/repos/makinacorpus/django-geojson/events","assignees_url":"https://api.github.com/repos/makinacorpus/django-geojson/assignees{/user}","branches_url":"https://api.github.com/repos/makinacorpus/django-geojson/branches{/branch}","tags_url":"https://api.github.com/repos/makinacorpus/django-geojson/tags","blobs_url":"https://api.github.com/repos/makinacorpus/django-geojson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makinacorpus/django-geojson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makinacorpus/django-geojson/git/refs{/sha}","trees_url":"https://api.github.com/repos/makinacorpus/django-geojson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makinacorpus/django-geojson/statuses/{sha}","languages_url":"https://api.github.com/repos/makinacorpus/django-geojson/languages","stargazers_url":"https://api.github.com/repos/makinacorpus/django-geojson/stargazers","contributors_url":"https://api.github.com/repos/makinacorpus/django-geojson/contributors","subscribers_url":"https://api.github.com/repos/makinacorpus/django-geojson/subscribers","subscription_url":"https://api.github.com/repos/makinacorpus/django-geojson/subscription","commits_url":"https://api.github.com/repos/makinacorpus/django-geojson/commits{/sha}","git_commits_url":"https://api.github.com/repos/makinacorpus/django-geojson/git/commits{/sha}","comments_url":"https://api.github.com/repos/makinacorpus/django-geojson/comments{/number}","issue_comment_url":"https://api.github.com/repos/makinacorpus/django-geojson/issues/comments/{number}","contents_url":"https://api.github.com/repos/makinacorpus/django-geojson/contents/{+path}","compare_url":"https://api.github.com/repos/makinacorpus/django-geojson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makinacorpus/django-geojson/merges","archive_url":"https://api.github.com/repos/makinacorpus/django-geojson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makinacorpus/django-geojson/downloads","issues_url":"https://api.github.com/repos/makinacorpus/django-geojson/issues{/number}","pulls_url":"https://api.github.com/repos/makinacorpus/django-geojson/pulls{/number}","milestones_url":"https://api.github.com/repos/makinacorpus/django-geojson/milestones{/number}","notifications_url":"https://api.github.com/repos/makinacorpus/django-geojson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makinacorpus/django-geojson/labels{/name}","releases_url":"https://api.github.com/repos/makinacorpus/django-geojson/releases{/id}","created_at":"2012-08-03T08:10:10Z","updated_at":"2015-01-29T06:15:47Z","pushed_at":"2015-01-19T13:18:58Z","git_url":"git://github.com/makinacorpus/django-geojson.git","ssh_url":"git@github.com:makinacorpus/django-geojson.git","clone_url":"https://github.com/makinacorpus/django-geojson.git","svn_url":"https://github.com/makinacorpus/django-geojson","homepage":"","size":779,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":15,"forks":25,"open_issues":15,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52"},"html":{"href":"https://github.com/makinacorpus/django-geojson/pull/52"},"issue":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/issues/52"},"comments":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/makinacorpus/django-geojson/statuses/fd0958f879b175a74146f4ef5fee0b3a71ccca46"}}}}