{"action":"created","issue":{"url":"https://api.github.com/repos/translate/pootle/issues/3753","labels_url":"https://api.github.com/repos/translate/pootle/issues/3753/labels{/name}","comments_url":"https://api.github.com/repos/translate/pootle/issues/3753/comments","events_url":"https://api.github.com/repos/translate/pootle/issues/3753/events","html_url":"https://github.com/translate/pootle/pull/3753","id":78270016,"number":3753,"title":"Drop hardcoded dependence on ENChecker()","user":{"login":"dwaynebailey","id":647438,"avatar_url":"https://avatars.githubusercontent.com/u/647438?v=3","gravatar_id":"","url":"https://api.github.com/users/dwaynebailey","html_url":"https://github.com/dwaynebailey","followers_url":"https://api.github.com/users/dwaynebailey/followers","following_url":"https://api.github.com/users/dwaynebailey/following{/other_user}","gists_url":"https://api.github.com/users/dwaynebailey/gists{/gist_id}","starred_url":"https://api.github.com/users/dwaynebailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwaynebailey/subscriptions","organizations_url":"https://api.github.com/users/dwaynebailey/orgs","repos_url":"https://api.github.com/users/dwaynebailey/repos","events_url":"https://api.github.com/users/dwaynebailey/events{/privacy}","received_events_url":"https://api.github.com/users/dwaynebailey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-19T22:11:43Z","updated_at":"2015-05-21T12:28:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/translate/pootle/pulls/3753","html_url":"https://github.com/translate/pootle/pull/3753","diff_url":"https://github.com/translate/pootle/pull/3753.diff","patch_url":"https://github.com/translate/pootle/pull/3753.patch"},"body":"This PR lands a few things:\r\n\r\n1. A change by @ta2-1 to request check categories instead of lists of checks\r\n2. Correct setup of QUALITY_CHECKER\r\n3. Documentation of the same\r\n4. Dropping other instances of hardcoding ENChecker()\r\n\r\nI haven't looked at Vfolders that also need to drop the use of ``get_qualitychecks_by_category`` as in 57634d50d73c5fa5585e6f7625695d8357839a5c I'll leave that to @unho, see [virtualfolder/models.py](https://github.com/dwaynebailey/pootle/blob/master/pootle/apps/virtualfolder/models.py#L354-L356)\r\n\r\nLikely there are much cleaner ways to excise ``ENChecker()``.  But this gets part of the way there for now and is what I need for a LibreOffice deployment.\r\n\r\n@ta2-1 would appreciate your review as I think you have a better understanding of some of the bit of code I've hacked at."},"comment":{"url":"https://api.github.com/repos/translate/pootle/issues/comments/104254526","html_url":"https://github.com/translate/pootle/pull/3753#issuecomment-104254526","issue_url":"https://api.github.com/repos/translate/pootle/issues/3753","id":104254526,"user":{"login":"dwaynebailey","id":647438,"avatar_url":"https://avatars.githubusercontent.com/u/647438?v=3","gravatar_id":"","url":"https://api.github.com/users/dwaynebailey","html_url":"https://github.com/dwaynebailey","followers_url":"https://api.github.com/users/dwaynebailey/followers","following_url":"https://api.github.com/users/dwaynebailey/following{/other_user}","gists_url":"https://api.github.com/users/dwaynebailey/gists{/gist_id}","starred_url":"https://api.github.com/users/dwaynebailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwaynebailey/subscriptions","organizations_url":"https://api.github.com/users/dwaynebailey/orgs","repos_url":"https://api.github.com/users/dwaynebailey/repos","events_url":"https://api.github.com/users/dwaynebailey/events{/privacy}","received_events_url":"https://api.github.com/users/dwaynebailey/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T12:28:11Z","updated_at":"2015-05-21T12:28:11Z","body":"@iafan the PR mostly cleans up the code to do what QUALITY_CHECKER claims to do, that is allow an override or TTK checks.  Before the PR there are a number of instances that hardcode the dependence on ENChecker.  I'll move this discussion to its own issue once this lands."}}