{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/34487424","id":34487424,"diff_hunk":"@@ -124,4 +124,21 @@ THREE.BoxGeometry = function ( width, height, depth, widthSegments, heightSegmen\n THREE.BoxGeometry.prototype = Object.create( THREE.Geometry.prototype );\n THREE.BoxGeometry.prototype.constructor = THREE.BoxGeometry;\n \n+THREE.BoxGeometry.prototype.clone = function () {\n+\n+\tvar geometry = new THREE.BoxGeometry(\n+\t\tthis.parameters.width,\n+\t\tthis.parameters.height,\n+\t\tthis.parameters.depth,\n+\t\tthis.parameters.widthSegments,\n+\t\tthis.parameters.heightSegments,\n+\t\tthis.parameters.depthSegments\n+\t);\n+\n+\tTHREE.Geometry.prototype.clone.call( this, geometry );","path":"src/extras/geometries/BoxGeometry.js","position":null,"original_position":15,"commit_id":"8ba2a9f24acf9d943e61cb38517af7310c8d1df0","original_commit_id":"eec67c21319338f194ef88816cf8eb76d1ef9dcc","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"body":"> Should this use case be supported?\r\n\r\nI think it shouldn't. I think we should, instead, encourage \"converting\" to \"Geometry\" when modifying vertices. This should keep things simpler.","created_at":"2015-07-13T17:23:13Z","updated_at":"2015-07-13T17:23:13Z","html_url":"https://github.com/mrdoob/three.js/pull/6825#discussion_r34487424","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6825","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/34487424"},"html":{"href":"https://github.com/mrdoob/three.js/pull/6825#discussion_r34487424"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6825"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/6825","id":39756874,"html_url":"https://github.com/mrdoob/three.js/pull/6825","diff_url":"https://github.com/mrdoob/three.js/pull/6825.diff","patch_url":"https://github.com/mrdoob/three.js/pull/6825.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/6825","number":6825,"state":"open","locked":false,"title":"Clone and JSON for geometries","user":{"login":"dubejf","id":8649151,"avatar_url":"https://avatars.githubusercontent.com/u/8649151?v=3","gravatar_id":"","url":"https://api.github.com/users/dubejf","html_url":"https://github.com/dubejf","followers_url":"https://api.github.com/users/dubejf/followers","following_url":"https://api.github.com/users/dubejf/following{/other_user}","gists_url":"https://api.github.com/users/dubejf/gists{/gist_id}","starred_url":"https://api.github.com/users/dubejf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubejf/subscriptions","organizations_url":"https://api.github.com/users/dubejf/orgs","repos_url":"https://api.github.com/users/dubejf/repos","events_url":"https://api.github.com/users/dubejf/events{/privacy}","received_events_url":"https://api.github.com/users/dubejf/received_events","type":"User","site_admin":false},"body":"**Add missing clone()**\r\nProvide a clone method to the specialized geometries in src/extras/geometry, otherwise:\r\n- the `.parameters` are not copied\r\n- the `.type` of the clone is \"Geometry\" or \"BufferGeometry\"\r\n- the cloned object is not an instance of the initial type. It loses its specialization and becomes a plain `Geometry` or `BufferGeometry`.\r\n\r\n**ObjectLoader improvement**\r\n\r\nAdd more geometries to ObjectLoader.js and pass down missing parameters to constructors for `CircleGeometry` and `CylinderGeometry`.\r\n\r\n**Miscellaneous**\r\nClass deriving from `PolyhedronGeometry` defined  `this.parameters` all over the place. Standardize to defining the `.type` and `.parameters` after the `PolyhedronGeometry` constructor is called.\r\n\r\nAlso fix prototype inheritance chain for classes deriving from `PolyhedronGeometry`.\r\n\r\nAdd unit tests for it all.\r\n","created_at":"2015-07-12T04:52:57Z","updated_at":"2015-07-13T17:23:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975a18671a925d1ea89b8615468ba19f6f00801c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6825/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6825/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/6825/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/8ba2a9f24acf9d943e61cb38517af7310c8d1df0","head":{"label":"dubejf:geo-clone","ref":"geo-clone","sha":"8ba2a9f24acf9d943e61cb38517af7310c8d1df0","user":{"login":"dubejf","id":8649151,"avatar_url":"https://avatars.githubusercontent.com/u/8649151?v=3","gravatar_id":"","url":"https://api.github.com/users/dubejf","html_url":"https://github.com/dubejf","followers_url":"https://api.github.com/users/dubejf/followers","following_url":"https://api.github.com/users/dubejf/following{/other_user}","gists_url":"https://api.github.com/users/dubejf/gists{/gist_id}","starred_url":"https://api.github.com/users/dubejf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubejf/subscriptions","organizations_url":"https://api.github.com/users/dubejf/orgs","repos_url":"https://api.github.com/users/dubejf/repos","events_url":"https://api.github.com/users/dubejf/events{/privacy}","received_events_url":"https://api.github.com/users/dubejf/received_events","type":"User","site_admin":false},"repo":{"id":33676798,"name":"three.js","full_name":"dubejf/three.js","owner":{"login":"dubejf","id":8649151,"avatar_url":"https://avatars.githubusercontent.com/u/8649151?v=3","gravatar_id":"","url":"https://api.github.com/users/dubejf","html_url":"https://github.com/dubejf","followers_url":"https://api.github.com/users/dubejf/followers","following_url":"https://api.github.com/users/dubejf/following{/other_user}","gists_url":"https://api.github.com/users/dubejf/gists{/gist_id}","starred_url":"https://api.github.com/users/dubejf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubejf/subscriptions","organizations_url":"https://api.github.com/users/dubejf/orgs","repos_url":"https://api.github.com/users/dubejf/repos","events_url":"https://api.github.com/users/dubejf/events{/privacy}","received_events_url":"https://api.github.com/users/dubejf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dubejf/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/dubejf/three.js","forks_url":"https://api.github.com/repos/dubejf/three.js/forks","keys_url":"https://api.github.com/repos/dubejf/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubejf/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubejf/three.js/teams","hooks_url":"https://api.github.com/repos/dubejf/three.js/hooks","issue_events_url":"https://api.github.com/repos/dubejf/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/dubejf/three.js/events","assignees_url":"https://api.github.com/repos/dubejf/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/dubejf/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/dubejf/three.js/tags","blobs_url":"https://api.github.com/repos/dubejf/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubejf/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubejf/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubejf/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubejf/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dubejf/three.js/languages","stargazers_url":"https://api.github.com/repos/dubejf/three.js/stargazers","contributors_url":"https://api.github.com/repos/dubejf/three.js/contributors","subscribers_url":"https://api.github.com/repos/dubejf/three.js/subscribers","subscription_url":"https://api.github.com/repos/dubejf/three.js/subscription","commits_url":"https://api.github.com/repos/dubejf/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubejf/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubejf/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubejf/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubejf/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/dubejf/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubejf/three.js/merges","archive_url":"https://api.github.com/repos/dubejf/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubejf/three.js/downloads","issues_url":"https://api.github.com/repos/dubejf/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/dubejf/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dubejf/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dubejf/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubejf/three.js/labels{/name}","releases_url":"https://api.github.com/repos/dubejf/three.js/releases{/id}","created_at":"2015-04-09T15:26:44Z","updated_at":"2015-04-09T15:26:52Z","pushed_at":"2015-07-13T03:17:20Z","git_url":"git://github.com/dubejf/three.js.git","ssh_url":"git@github.com:dubejf/three.js.git","clone_url":"https://github.com/dubejf/three.js.git","svn_url":"https://github.com/dubejf/three.js","homepage":"http://threejs.org/","size":314514,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"17658cdf7418ccb591d83e0dc5830b2d482fd05a","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","created_at":"2010-03-23T18:58:01Z","updated_at":"2015-07-13T15:47:50Z","pushed_at":"2015-07-13T15:59:16Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":382194,"stargazers_count":20293,"watchers_count":20293,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":6133,"mirror_url":null,"open_issues_count":803,"forks":6133,"open_issues":803,"watchers":20293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6825"},"html":{"href":"https://github.com/mrdoob/three.js/pull/6825"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6825"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6825/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6825/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6825/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/8ba2a9f24acf9d943e61cb38517af7310c8d1df0"}}}}