{"action":"created","issue":{"url":"https://api.github.com/repos/botify-labs/simpleflow/issues/48","labels_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/48/comments","events_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/48/events","html_url":"https://github.com/botify-labs/simpleflow/pull/48","id":101885683,"number":48,"title":"Make execute.python more resilient.","user":{"login":"ybastide","id":2929444,"avatar_url":"https://avatars.githubusercontent.com/u/2929444?v=3","gravatar_id":"","url":"https://api.github.com/users/ybastide","html_url":"https://github.com/ybastide","followers_url":"https://api.github.com/users/ybastide/followers","following_url":"https://api.github.com/users/ybastide/following{/other_user}","gists_url":"https://api.github.com/users/ybastide/gists{/gist_id}","starred_url":"https://api.github.com/users/ybastide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybastide/subscriptions","organizations_url":"https://api.github.com/users/ybastide/orgs","repos_url":"https://api.github.com/users/ybastide/repos","events_url":"https://api.github.com/users/ybastide/events{/privacy}","received_events_url":"https://api.github.com/users/ybastide/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-19T12:51:28Z","updated_at":"2015-08-21T16:25:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/botify-labs/simpleflow/pulls/48","html_url":"https://github.com/botify-labs/simpleflow/pull/48","diff_url":"https://github.com/botify-labs/simpleflow/pull/48.diff","patch_url":"https://github.com/botify-labs/simpleflow/pull/48.patch"},"body":"This patch adds two robustness features to `execute.python`:\r\n\r\n1. In case of error (non-zero interpreter return value), don't blindly try to\r\n   `eval` the returned string.\r\n\r\n   It may be e.g. `/usr/bin/python: Import by filename is not supported.`\r\n   (simpleflow not installed in this Python environment).\r\n\r\n   This code can be simplified; it's trying to lower the possibility of a\r\n   malicious string eval'ed.\r\n\r\n2. On a successful execution, we `json.loads` the function's stdout plus its\r\n   return value. This is likely to fail if it prints anything (what to do here?)\r\n"},"comment":{"url":"https://api.github.com/repos/botify-labs/simpleflow/issues/comments/133481506","html_url":"https://github.com/botify-labs/simpleflow/pull/48#issuecomment-133481506","issue_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/48","id":133481506,"user":{"login":"ggreg","id":190738,"avatar_url":"https://avatars.githubusercontent.com/u/190738?v=3","gravatar_id":"","url":"https://api.github.com/users/ggreg","html_url":"https://github.com/ggreg","followers_url":"https://api.github.com/users/ggreg/followers","following_url":"https://api.github.com/users/ggreg/following{/other_user}","gists_url":"https://api.github.com/users/ggreg/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreg/subscriptions","organizations_url":"https://api.github.com/users/ggreg/orgs","repos_url":"https://api.github.com/users/ggreg/repos","events_url":"https://api.github.com/users/ggreg/events{/privacy}","received_events_url":"https://api.github.com/users/ggreg/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T16:25:59Z","updated_at":"2015-08-21T16:25:59Z","body":":+1: :+1:\r\n"}}