{"action":"created","comment":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/32857722","id":32857722,"diff_hunk":"@@ -110,6 +111,12 @@\n #define CC_INLINE\n #endif /* CC_CONF_INLINE */\n \n+#ifdef CC_CONF_ALIGN_ATTR\n+#define CC_ALIGN_ATTR CC_CONF_ALIGN_ATTR\n+#else /* CC_CONF_INLINE */\n+#define CC_ALIGN_ATTR","path":"core/sys/cc.h","position":15,"original_position":15,"commit_id":"3dfb74b0aa38b81107bf3ec107891e9bf4dc9e54","original_commit_id":"3dfb74b0aa38b81107bf3ec107891e9bf4dc9e54","user":{"login":"bthebaudeau","id":5755442,"avatar_url":"https://avatars.githubusercontent.com/u/5755442?v=3","gravatar_id":"","url":"https://api.github.com/users/bthebaudeau","html_url":"https://github.com/bthebaudeau","followers_url":"https://api.github.com/users/bthebaudeau/followers","following_url":"https://api.github.com/users/bthebaudeau/following{/other_user}","gists_url":"https://api.github.com/users/bthebaudeau/gists{/gist_id}","starred_url":"https://api.github.com/users/bthebaudeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bthebaudeau/subscriptions","organizations_url":"https://api.github.com/users/bthebaudeau/orgs","repos_url":"https://api.github.com/users/bthebaudeau/repos","events_url":"https://api.github.com/users/bthebaudeau/events{/privacy}","received_events_url":"https://api.github.com/users/bthebaudeau/received_events","type":"User","site_admin":false},"body":"If the requested alignment is a requirement and not a simple performance hint, this will silently generate a runtime bug.","created_at":"2015-06-19T18:46:08Z","updated_at":"2015-06-19T18:46:08Z","html_url":"https://github.com/contiki-os/contiki/pull/1133#discussion_r32857722","pull_request_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1133","_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/32857722"},"html":{"href":"https://github.com/contiki-os/contiki/pull/1133#discussion_r32857722"},"pull_request":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1133"}}},"pull_request":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/1133","id":38123632,"html_url":"https://github.com/contiki-os/contiki/pull/1133","diff_url":"https://github.com/contiki-os/contiki/pull/1133.diff","patch_url":"https://github.com/contiki-os/contiki/pull/1133.patch","issue_url":"https://api.github.com/repos/contiki-os/contiki/issues/1133","number":1133,"state":"open","locked":false,"title":"put gcc specific stuff into seperate .h","user":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"body":"I think that it does not make sense to define functionality specific to compilers in platform headers or as needed in C files. I'd like to propose that we have specific header files for compiler specific functionality and have created such a header for gcc.\r\n\r\nIn addition to the above, this will also have the tangible effect of defining CC_CONF_INLINE on platforms that build with gcc and which do not already define it (such as CC2538 and CC2650) without having to add more to the platform specific header files.\r\n\r\n","created_at":"2015-06-19T16:18:15Z","updated_at":"2015-06-19T18:46:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc7bfa5ad46aad53b98ea865f1f89d0fe413c0a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1133/commits","review_comments_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1133/comments","review_comment_url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiki-os/contiki/issues/1133/comments","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/3dfb74b0aa38b81107bf3ec107891e9bf4dc9e54","head":{"label":"bkozak-scanimetrics:cc-gcc","ref":"cc-gcc","sha":"3dfb74b0aa38b81107bf3ec107891e9bf4dc9e54","user":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"repo":{"id":37210139,"name":"contiki","full_name":"bkozak-scanimetrics/contiki","owner":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkozak-scanimetrics/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/bkozak-scanimetrics/contiki","forks_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/forks","keys_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/teams","hooks_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/hooks","issue_events_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/events","assignees_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/tags","blobs_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/languages","stargazers_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/stargazers","contributors_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/contributors","subscribers_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/subscribers","subscription_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/subscription","commits_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/merges","archive_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/downloads","issues_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/labels{/name}","releases_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/releases{/id}","created_at":"2015-06-10T16:55:37Z","updated_at":"2015-06-10T16:55:49Z","pushed_at":"2015-06-19T16:04:06Z","git_url":"git://github.com/bkozak-scanimetrics/contiki.git","ssh_url":"git@github.com:bkozak-scanimetrics/contiki.git","clone_url":"https://github.com/bkozak-scanimetrics/contiki.git","svn_url":"https://github.com/bkozak-scanimetrics/contiki","homepage":"http://www.contiki-os.org/","size":62486,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiki-os:master","ref":"master","sha":"0b1a0d2bd98ef49e24583d5297e0a9bfb9795fc7","user":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"repo":{"id":6365284,"name":"contiki","full_name":"contiki-os/contiki","owner":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiki-os/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":false,"url":"https://api.github.com/repos/contiki-os/contiki","forks_url":"https://api.github.com/repos/contiki-os/contiki/forks","keys_url":"https://api.github.com/repos/contiki-os/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiki-os/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiki-os/contiki/teams","hooks_url":"https://api.github.com/repos/contiki-os/contiki/hooks","issue_events_url":"https://api.github.com/repos/contiki-os/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/contiki-os/contiki/events","assignees_url":"https://api.github.com/repos/contiki-os/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/contiki-os/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/contiki-os/contiki/tags","blobs_url":"https://api.github.com/repos/contiki-os/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiki-os/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiki-os/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiki-os/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/contiki-os/contiki/languages","stargazers_url":"https://api.github.com/repos/contiki-os/contiki/stargazers","contributors_url":"https://api.github.com/repos/contiki-os/contiki/contributors","subscribers_url":"https://api.github.com/repos/contiki-os/contiki/subscribers","subscription_url":"https://api.github.com/repos/contiki-os/contiki/subscription","commits_url":"https://api.github.com/repos/contiki-os/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiki-os/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiki-os/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiki-os/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiki-os/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/contiki-os/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiki-os/contiki/merges","archive_url":"https://api.github.com/repos/contiki-os/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiki-os/contiki/downloads","issues_url":"https://api.github.com/repos/contiki-os/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/contiki-os/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/contiki-os/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/contiki-os/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiki-os/contiki/labels{/name}","releases_url":"https://api.github.com/repos/contiki-os/contiki/releases{/id}","created_at":"2012-10-24T05:59:36Z","updated_at":"2015-06-19T08:02:43Z","pushed_at":"2015-06-19T16:18:16Z","git_url":"git://github.com/contiki-os/contiki.git","ssh_url":"git@github.com:contiki-os/contiki.git","clone_url":"https://github.com/contiki-os/contiki.git","svn_url":"https://github.com/contiki-os/contiki","homepage":"http://www.contiki-os.org/","size":87818,"stargazers_count":1386,"watchers_count":1386,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":981,"mirror_url":null,"open_issues_count":172,"forks":981,"open_issues":172,"watchers":1386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1133"},"html":{"href":"https://github.com/contiki-os/contiki/pull/1133"},"issue":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/1133"},"comments":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/1133/comments"},"review_comments":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1133/comments"},"review_comment":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1133/commits"},"statuses":{"href":"https://api.github.com/repos/contiki-os/contiki/statuses/3dfb74b0aa38b81107bf3ec107891e9bf4dc9e54"}}}}