{"action":"opened","issue":{"url":"https://api.github.com/repos/CindyJS/CindyJS/issues/50","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/50/comments","events_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/50/events","html_url":"https://github.com/CindyJS/CindyJS/issues/50","id":114033087,"number":50,"title":"Inconsistent default line widths","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CindyJS/CindyJS/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/CindyJS/CindyJS/milestones/1","html_url":"https://github.com/CindyJS/CindyJS/milestones/v1.0.0","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/milestones/1/labels","id":1383222,"number":1,"title":"v1.0.0","description":"Version 1.0.0 would be the first official release. CindyJS should from then on follow [semantic versioning](http://semver.org/).","creator":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-10-29T11:06:50Z","updated_at":"2015-10-29T11:46:13Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2015-10-29T11:46:13Z","updated_at":"2015-10-29T11:46:13Z","closed_at":null,"body":"We have two different default line widths.\r\n\r\nOne is defined using `csport.drawingstate.linesize` and [defaults to 1.0](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libgeo/GeoState.js#L13). It ends up in the [`Render2D.lsize`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/Render2D.js#L46) setting. This is used for segment drawing. Other pieces of code set `csctx.lineWidth` directly, namely\r\n\r\n* [drawarc defaults to `4/2.5`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L170-L175),\r\n* [drawcircle defaults to `4/2.5`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L318-L321),\r\n* [drawconic defaults to `4/2.5`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L405-L410) ([reused](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L594) in nested function),\r\n* [polygon defaults to `4/2.5`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L819-L822),\r\n* [plot uses `Render2D.lsize`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L1058) so it's consistent with segments,\r\n* [plotX hardcoded to 1](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#L1265).\r\n\r\nI'm not sure about `plotX` (perhaps this should even be removed?), but the difference between `1` and `4/2.5=1.6` is confusing, as is the fact that the latter isn't affected by the [`defaultAppearance`](https://github.com/CindyJS/CindyJS/blob/57a564d89124df6d86f605272bc91740fb2c2348/src/js/libcs/OpDrawing.js#user-content-defaultappearance) option to the `createCindy` call. This should be unified."}}