{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/emitter/pulls/comments/25045474","id":25045474,"diff_hunk":"@@ -1,5 +1,5 @@\n /**\n- * Copyright 2013 Facebook, Inc.\n+ * Copyright 2004-present Facebook. All Rights Reserved.","path":"src/__tests__/EventHolder-test.js","position":3,"original_position":3,"commit_id":"53d9d0ec2ad3c43b732467ec19040f8e4956d1ec","original_commit_id":"53d9d0ec2ad3c43b732467ec19040f8e4956d1ec","user":{"login":"zpao","id":8445,"avatar_url":"https://avatars.githubusercontent.com/u/8445?v=3","gravatar_id":"","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"body":"Let's not lose these bits (in all the files). The header should stay how it was (and then we'll update to BSD)","created_at":"2015-02-20T02:20:45Z","updated_at":"2015-02-20T02:20:45Z","html_url":"https://github.com/facebook/emitter/pull/8#discussion_r25045474","pull_request_url":"https://api.github.com/repos/facebook/emitter/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/facebook/emitter/pulls/comments/25045474"},"html":{"href":"https://github.com/facebook/emitter/pull/8#discussion_r25045474"},"pull_request":{"href":"https://api.github.com/repos/facebook/emitter/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/emitter/pulls/8","id":29503655,"html_url":"https://github.com/facebook/emitter/pull/8","diff_url":"https://github.com/facebook/emitter/pull/8.diff","patch_url":"https://github.com/facebook/emitter/pull/8.patch","issue_url":"https://api.github.com/repos/facebook/emitter/issues/8","number":8,"state":"open","locked":false,"title":"Sync src files with Facebook internal code","user":{"login":"fisherwebdev","id":169760,"avatar_url":"https://avatars.githubusercontent.com/u/169760?v=3","gravatar_id":"","url":"https://api.github.com/users/fisherwebdev","html_url":"https://github.com/fisherwebdev","followers_url":"https://api.github.com/users/fisherwebdev/followers","following_url":"https://api.github.com/users/fisherwebdev/following{/other_user}","gists_url":"https://api.github.com/users/fisherwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/fisherwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisherwebdev/subscriptions","organizations_url":"https://api.github.com/users/fisherwebdev/orgs","repos_url":"https://api.github.com/users/fisherwebdev/repos","events_url":"https://api.github.com/users/fisherwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/fisherwebdev/received_events","type":"User","site_admin":false},"body":"Sync with FB internal code.\r\n\r\nNote:\r\n  no Stopwatch, \r\n  no ErrorUtils.applyWithGuard (needs update),\r\n  no LogBuffer\r\n major version bumped in package.json \r\n    incompatible API changes: \r\n      removed removeSubscription() from EventEmitter\r\n      EventValidator became EventEmitterWithValidation\r\n\r\nNext steps:\r\nAudit documentation -- In particular, EventValidator vs. EventEmitterWithValidation is a breaking change, and needs documentation\r\nNeed to update bin/jsx to use constants.js (from the React repo) instead of woodchipper.js.\r\nBSD license\r\nPush to npm\r\nError handling without applyWithGuard (or create dependency on appyWithGuard)\r\nJest testing\r\nFlow typechecking\r\nES6-ify as much as possible\r\nAudit code\r\n  Should \"listener\" become \"callback\" or \"onEvent\" ?  I think \"listener\" is a confusing name for this event-handling callback function.\r\n\r\nSee also issue tracker.\r\n","created_at":"2015-02-18T06:13:44Z","updated_at":"2015-02-20T02:20:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a413964caa769db1bd2df34720c0ee56237eeac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/emitter/pulls/8/commits","review_comments_url":"https://api.github.com/repos/facebook/emitter/pulls/8/comments","review_comment_url":"https://api.github.com/repos/facebook/emitter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/emitter/issues/8/comments","statuses_url":"https://api.github.com/repos/facebook/emitter/statuses/53d9d0ec2ad3c43b732467ec19040f8e4956d1ec","head":{"label":"fisherwebdev:sync_with_fb","ref":"sync_with_fb","sha":"53d9d0ec2ad3c43b732467ec19040f8e4956d1ec","user":{"login":"fisherwebdev","id":169760,"avatar_url":"https://avatars.githubusercontent.com/u/169760?v=3","gravatar_id":"","url":"https://api.github.com/users/fisherwebdev","html_url":"https://github.com/fisherwebdev","followers_url":"https://api.github.com/users/fisherwebdev/followers","following_url":"https://api.github.com/users/fisherwebdev/following{/other_user}","gists_url":"https://api.github.com/users/fisherwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/fisherwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisherwebdev/subscriptions","organizations_url":"https://api.github.com/users/fisherwebdev/orgs","repos_url":"https://api.github.com/users/fisherwebdev/repos","events_url":"https://api.github.com/users/fisherwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/fisherwebdev/received_events","type":"User","site_admin":false},"repo":{"id":30945671,"name":"emitter","full_name":"fisherwebdev/emitter","owner":{"login":"fisherwebdev","id":169760,"avatar_url":"https://avatars.githubusercontent.com/u/169760?v=3","gravatar_id":"","url":"https://api.github.com/users/fisherwebdev","html_url":"https://github.com/fisherwebdev","followers_url":"https://api.github.com/users/fisherwebdev/followers","following_url":"https://api.github.com/users/fisherwebdev/following{/other_user}","gists_url":"https://api.github.com/users/fisherwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/fisherwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisherwebdev/subscriptions","organizations_url":"https://api.github.com/users/fisherwebdev/orgs","repos_url":"https://api.github.com/users/fisherwebdev/repos","events_url":"https://api.github.com/users/fisherwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/fisherwebdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fisherwebdev/emitter","description":"A JS EventEmitter foundation for evented code","fork":true,"url":"https://api.github.com/repos/fisherwebdev/emitter","forks_url":"https://api.github.com/repos/fisherwebdev/emitter/forks","keys_url":"https://api.github.com/repos/fisherwebdev/emitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fisherwebdev/emitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fisherwebdev/emitter/teams","hooks_url":"https://api.github.com/repos/fisherwebdev/emitter/hooks","issue_events_url":"https://api.github.com/repos/fisherwebdev/emitter/issues/events{/number}","events_url":"https://api.github.com/repos/fisherwebdev/emitter/events","assignees_url":"https://api.github.com/repos/fisherwebdev/emitter/assignees{/user}","branches_url":"https://api.github.com/repos/fisherwebdev/emitter/branches{/branch}","tags_url":"https://api.github.com/repos/fisherwebdev/emitter/tags","blobs_url":"https://api.github.com/repos/fisherwebdev/emitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fisherwebdev/emitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fisherwebdev/emitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/fisherwebdev/emitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fisherwebdev/emitter/statuses/{sha}","languages_url":"https://api.github.com/repos/fisherwebdev/emitter/languages","stargazers_url":"https://api.github.com/repos/fisherwebdev/emitter/stargazers","contributors_url":"https://api.github.com/repos/fisherwebdev/emitter/contributors","subscribers_url":"https://api.github.com/repos/fisherwebdev/emitter/subscribers","subscription_url":"https://api.github.com/repos/fisherwebdev/emitter/subscription","commits_url":"https://api.github.com/repos/fisherwebdev/emitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/fisherwebdev/emitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/fisherwebdev/emitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/fisherwebdev/emitter/issues/comments/{number}","contents_url":"https://api.github.com/repos/fisherwebdev/emitter/contents/{+path}","compare_url":"https://api.github.com/repos/fisherwebdev/emitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fisherwebdev/emitter/merges","archive_url":"https://api.github.com/repos/fisherwebdev/emitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fisherwebdev/emitter/downloads","issues_url":"https://api.github.com/repos/fisherwebdev/emitter/issues{/number}","pulls_url":"https://api.github.com/repos/fisherwebdev/emitter/pulls{/number}","milestones_url":"https://api.github.com/repos/fisherwebdev/emitter/milestones{/number}","notifications_url":"https://api.github.com/repos/fisherwebdev/emitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fisherwebdev/emitter/labels{/name}","releases_url":"https://api.github.com/repos/fisherwebdev/emitter/releases{/id}","created_at":"2015-02-18T00:37:49Z","updated_at":"2015-02-18T00:37:50Z","pushed_at":"2015-02-19T06:10:35Z","git_url":"git://github.com/fisherwebdev/emitter.git","ssh_url":"git@github.com:fisherwebdev/emitter.git","clone_url":"https://github.com/fisherwebdev/emitter.git","svn_url":"https://github.com/fisherwebdev/emitter","homepage":null,"size":285,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c39b1fcd605f89856bbec9c195fe44c02054c231","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9826792,"name":"emitter","full_name":"facebook/emitter","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/emitter","description":"A JS EventEmitter foundation for evented code","fork":false,"url":"https://api.github.com/repos/facebook/emitter","forks_url":"https://api.github.com/repos/facebook/emitter/forks","keys_url":"https://api.github.com/repos/facebook/emitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/emitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/emitter/teams","hooks_url":"https://api.github.com/repos/facebook/emitter/hooks","issue_events_url":"https://api.github.com/repos/facebook/emitter/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/emitter/events","assignees_url":"https://api.github.com/repos/facebook/emitter/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/emitter/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/emitter/tags","blobs_url":"https://api.github.com/repos/facebook/emitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/emitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/emitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/emitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/emitter/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/emitter/languages","stargazers_url":"https://api.github.com/repos/facebook/emitter/stargazers","contributors_url":"https://api.github.com/repos/facebook/emitter/contributors","subscribers_url":"https://api.github.com/repos/facebook/emitter/subscribers","subscription_url":"https://api.github.com/repos/facebook/emitter/subscription","commits_url":"https://api.github.com/repos/facebook/emitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/emitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/emitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/emitter/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/emitter/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/emitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/emitter/merges","archive_url":"https://api.github.com/repos/facebook/emitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/emitter/downloads","issues_url":"https://api.github.com/repos/facebook/emitter/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/emitter/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/emitter/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/emitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/emitter/labels{/name}","releases_url":"https://api.github.com/repos/facebook/emitter/releases{/id}","created_at":"2013-05-03T02:08:56Z","updated_at":"2015-02-19T13:36:47Z","pushed_at":"2015-02-17T22:48:33Z","git_url":"git://github.com/facebook/emitter.git","ssh_url":"git@github.com:facebook/emitter.git","clone_url":"https://github.com/facebook/emitter.git","svn_url":"https://github.com/facebook/emitter","homepage":null,"size":285,"stargazers_count":107,"watchers_count":107,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":5,"forks":18,"open_issues":5,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/emitter/pulls/8"},"html":{"href":"https://github.com/facebook/emitter/pull/8"},"issue":{"href":"https://api.github.com/repos/facebook/emitter/issues/8"},"comments":{"href":"https://api.github.com/repos/facebook/emitter/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/emitter/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/emitter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/emitter/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/emitter/statuses/53d9d0ec2ad3c43b732467ec19040f8e4956d1ec"}}}}