{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/47338293","id":47338293,"diff_hunk":"@@ -168,12 +168,31 @@ write_auth_begin (int result_code)\n    * JSON objects do not parse.\n    *\n    * In addition this is not a cross platform message. We are sending\n-   * to cockpit-ws running on the same machine. PAM codes will be\n-   * identical and should all be understood by cockpit-ws.\n+   * to cockpit-ws running on the same machine.\n    */\n \n   fprintf (authf, \"{ \\\"result-code\\\": %d\", result_code);","path":"src/ws/session.c","position":9,"original_position":9,"commit_id":"6d4f60f4c11590e3cbaeb80823faa258756ab798","original_commit_id":"6d4f60f4c11590e3cbaeb80823faa258756ab798","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"It seems like nothing uses this line. Can we remove it?","created_at":"2015-12-11T10:02:33Z","updated_at":"2015-12-11T10:02:33Z","html_url":"https://github.com/cockpit-project/cockpit/pull/3304#discussion_r47338293","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/47338293"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/3304#discussion_r47338293"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304","id":53086122,"html_url":"https://github.com/cockpit-project/cockpit/pull/3304","diff_url":"https://github.com/cockpit-project/cockpit/pull/3304.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/3304.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/3304","number":3304,"state":"open","locked":false,"title":"ws: Configurable command for local logins","user":{"login":"petervo","id":10439156,"avatar_url":"https://avatars.githubusercontent.com/u/10439156?v=3","gravatar_id":"","url":"https://api.github.com/users/petervo","html_url":"https://github.com/petervo","followers_url":"https://api.github.com/users/petervo/followers","following_url":"https://api.github.com/users/petervo/following{/other_user}","gists_url":"https://api.github.com/users/petervo/gists{/gist_id}","starred_url":"https://api.github.com/users/petervo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petervo/subscriptions","organizations_url":"https://api.github.com/users/petervo/orgs","repos_url":"https://api.github.com/users/petervo/repos","events_url":"https://api.github.com/users/petervo/events{/privacy}","received_events_url":"https://api.github.com/users/petervo/received_events","type":"User","site_admin":false},"body":"Allow configuration to drive the command that is responsible for verifying user credentials and launching a bridge when logging in locally.\r\n\r\nThis allows us to use something other than cockpit-session in special situations such as verifying an oauth token","created_at":"2015-12-09T07:42:34Z","updated_at":"2015-12-11T10:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be446cacfc63e4211e67360d3c8a1d316869d1c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/3304/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/6d4f60f4c11590e3cbaeb80823faa258756ab798","head":{"label":"petervo:configurable-local-login","ref":"configurable-local-login","sha":"6d4f60f4c11590e3cbaeb80823faa258756ab798","user":{"login":"petervo","id":10439156,"avatar_url":"https://avatars.githubusercontent.com/u/10439156?v=3","gravatar_id":"","url":"https://api.github.com/users/petervo","html_url":"https://github.com/petervo","followers_url":"https://api.github.com/users/petervo/followers","following_url":"https://api.github.com/users/petervo/following{/other_user}","gists_url":"https://api.github.com/users/petervo/gists{/gist_id}","starred_url":"https://api.github.com/users/petervo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petervo/subscriptions","organizations_url":"https://api.github.com/users/petervo/orgs","repos_url":"https://api.github.com/users/petervo/repos","events_url":"https://api.github.com/users/petervo/events{/privacy}","received_events_url":"https://api.github.com/users/petervo/received_events","type":"User","site_admin":false},"repo":{"id":28927963,"name":"cockpit","full_name":"petervo/cockpit","owner":{"login":"petervo","id":10439156,"avatar_url":"https://avatars.githubusercontent.com/u/10439156?v=3","gravatar_id":"","url":"https://api.github.com/users/petervo","html_url":"https://github.com/petervo","followers_url":"https://api.github.com/users/petervo/followers","following_url":"https://api.github.com/users/petervo/following{/other_user}","gists_url":"https://api.github.com/users/petervo/gists{/gist_id}","starred_url":"https://api.github.com/users/petervo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petervo/subscriptions","organizations_url":"https://api.github.com/users/petervo/orgs","repos_url":"https://api.github.com/users/petervo/repos","events_url":"https://api.github.com/users/petervo/events{/privacy}","received_events_url":"https://api.github.com/users/petervo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petervo/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":true,"url":"https://api.github.com/repos/petervo/cockpit","forks_url":"https://api.github.com/repos/petervo/cockpit/forks","keys_url":"https://api.github.com/repos/petervo/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petervo/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petervo/cockpit/teams","hooks_url":"https://api.github.com/repos/petervo/cockpit/hooks","issue_events_url":"https://api.github.com/repos/petervo/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/petervo/cockpit/events","assignees_url":"https://api.github.com/repos/petervo/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/petervo/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/petervo/cockpit/tags","blobs_url":"https://api.github.com/repos/petervo/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petervo/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petervo/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/petervo/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petervo/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/petervo/cockpit/languages","stargazers_url":"https://api.github.com/repos/petervo/cockpit/stargazers","contributors_url":"https://api.github.com/repos/petervo/cockpit/contributors","subscribers_url":"https://api.github.com/repos/petervo/cockpit/subscribers","subscription_url":"https://api.github.com/repos/petervo/cockpit/subscription","commits_url":"https://api.github.com/repos/petervo/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/petervo/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/petervo/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/petervo/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/petervo/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/petervo/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petervo/cockpit/merges","archive_url":"https://api.github.com/repos/petervo/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petervo/cockpit/downloads","issues_url":"https://api.github.com/repos/petervo/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/petervo/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/petervo/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/petervo/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petervo/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/petervo/cockpit/releases{/id}","created_at":"2015-01-07T18:36:59Z","updated_at":"2015-10-29T21:24:39Z","pushed_at":"2015-12-11T05:38:33Z","git_url":"git://github.com/petervo/cockpit.git","ssh_url":"git@github.com:petervo/cockpit.git","clone_url":"https://github.com/petervo/cockpit.git","svn_url":"https://github.com/petervo/cockpit","homepage":"http://www.cockpit-project.org/","size":20801,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"ac2c91c88cd02b657d5a115238aa29f0e3648a10","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","created_at":"2013-11-01T17:36:46Z","updated_at":"2015-12-10T20:57:41Z","pushed_at":"2015-12-11T05:38:34Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":30383,"stargazers_count":1344,"watchers_count":1344,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":291,"forks":153,"open_issues":291,"watchers":1344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/3304"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/3304"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/3304/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/3304/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/6d4f60f4c11590e3cbaeb80823faa258756ab798"}}}}