{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2038","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2038/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2038/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2038/events","html_url":"https://github.com/hypothesis/h/pull/2038","id":61247252,"number":2038,"title":"AnnotionUISync: export show/hide frame","user":{"login":"csillag","id":2093792,"avatar_url":"https://avatars.githubusercontent.com/u/2093792?v=3","gravatar_id":"","url":"https://api.github.com/users/csillag","html_url":"https://github.com/csillag","followers_url":"https://api.github.com/users/csillag/followers","following_url":"https://api.github.com/users/csillag/following{/other_user}","gists_url":"https://api.github.com/users/csillag/gists{/gist_id}","starred_url":"https://api.github.com/users/csillag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csillag/subscriptions","organizations_url":"https://api.github.com/users/csillag/orgs","repos_url":"https://api.github.com/users/csillag/repos","events_url":"https://api.github.com/users/csillag/events{/privacy}","received_events_url":"https://api.github.com/users/csillag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-03-13T21:19:19Z","updated_at":"2015-03-14T02:03:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2038","html_url":"https://github.com/hypothesis/h/pull/2038","diff_url":"https://github.com/hypothesis/h/pull/2038.diff","patch_url":"https://github.com/hypothesis/h/pull/2038.patch"},"body":"Currently, the show/hide frame functionality is not directly\r\navailable for the sidebar code.\r\n\r\nHowever, internally, then annotation-ui-sync service implements\r\nthe necessary features.\r\n\r\nThis commit exposes those implementations as methods on the AnnotationUI\r\nservice, which is the top-level entry point for all similar APIs for\r\ncontrolling the state of the UI.\r\n\r\n   * * *\r\n\r\nThe changes are minimal. 2 lines of code. \r\nThis will make the direct linking code cleaner.\r\n"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/79692657","html_url":"https://github.com/hypothesis/h/pull/2038#issuecomment-79692657","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2038","id":79692657,"user":{"login":"csillag","id":2093792,"avatar_url":"https://avatars.githubusercontent.com/u/2093792?v=3","gravatar_id":"","url":"https://api.github.com/users/csillag","html_url":"https://github.com/csillag","followers_url":"https://api.github.com/users/csillag/followers","following_url":"https://api.github.com/users/csillag/following{/other_user}","gists_url":"https://api.github.com/users/csillag/gists{/gist_id}","starred_url":"https://api.github.com/users/csillag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csillag/subscriptions","organizations_url":"https://api.github.com/users/csillag/orgs","repos_url":"https://api.github.com/users/csillag/repos","events_url":"https://api.github.com/users/csillag/events{/privacy}","received_events_url":"https://api.github.com/users/csillag/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T02:03:13Z","updated_at":"2015-03-14T02:03:13Z","body":"> The host service should be injecting the bridge and adding its callbacks. The annotation ui sync should not be injecting the host. The whole purpose of this exercise was to take the host concerns out of annotation ui sync, [...]\r\n\r\nOK, AnnotationUISync and HostService have been completely separated now.\r\n(Along the way, I have also eliminated a useless cross-frame message - showEditor)"}}