{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/41780598","id":41780598,"diff_hunk":"@@ -569,8 +569,6 @@ def start(debug=False, watch=False, daemonize=True, args=[], skip_job_scheduler=\n     except KeyboardInterrupt:\n         # Handled in cherrypy by waiting for all threads to join\n         pass\n-    except SystemExit:","path":"kalitectl.py","position":4,"original_position":4,"commit_id":"03b6df07999cde07651c02832b45aa0a17c1c601","original_commit_id":"03b6df07999cde07651c02832b45aa0a17c1c601","user":{"login":"MCGallaspy","id":8888020,"avatar_url":"https://avatars.githubusercontent.com/u/8888020?v=3","gravatar_id":"","url":"https://api.github.com/users/MCGallaspy","html_url":"https://github.com/MCGallaspy","followers_url":"https://api.github.com/users/MCGallaspy/followers","following_url":"https://api.github.com/users/MCGallaspy/following{/other_user}","gists_url":"https://api.github.com/users/MCGallaspy/gists{/gist_id}","starred_url":"https://api.github.com/users/MCGallaspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MCGallaspy/subscriptions","organizations_url":"https://api.github.com/users/MCGallaspy/orgs","repos_url":"https://api.github.com/users/MCGallaspy/repos","events_url":"https://api.github.com/users/MCGallaspy/events{/privacy}","received_events_url":"https://api.github.com/users/MCGallaspy/received_events","type":"User","site_admin":false},"body":"Could this also be a regression?","created_at":"2015-10-12T17:34:34Z","updated_at":"2015-10-12T17:34:34Z","html_url":"https://github.com/learningequality/ka-lite/pull/4565#discussion_r41780598","pull_request_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565","_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/41780598"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/4565#discussion_r41780598"},"pull_request":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565","id":46688792,"html_url":"https://github.com/learningequality/ka-lite/pull/4565","diff_url":"https://github.com/learningequality/ka-lite/pull/4565.diff","patch_url":"https://github.com/learningequality/ka-lite/pull/4565.patch","issue_url":"https://api.github.com/repos/learningequality/ka-lite/issues/4565","number":4565,"state":"open","locked":false,"title":"Include docs in sdist and add Makefile for common build, dev, test","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"Taking over from #4526\r\n\r\n# Change affecting 0.15 release\r\n\r\nDocs are included in the sdist and built automatically by running `make sdist`.\r\n\r\nPR for #4348 (partly) and #4375\r\n\r\n# Change affecting build process\r\n\r\nThe PyPi and .deb for 0.15 will be released by using a new Makefile. Yay!\r\n\r\n#4459 \r\n\r\nMakefile does this:\r\n\r\n```\r\n➜  ka-lite git:(makefile-dist-docs) make help\r\nclean - remove all build, test, coverage and Python artifacts\r\nclean-build - remove build artifacts\r\nclean-pyc - remove Python file artifacts\r\nclean-test - remove test and coverage artifacts\r\nlint - check style with pep8\r\ntest - run tests the default Python\r\ntest-bdd - run BDD tests only\r\ntest-nobdd - run non-BDD tests only\r\nassets - build all JS/CSS assets\r\ncoverage - check code coverage quickly with the default Python\r\ndocs - generate Sphinx HTML documentation, including API docs\r\nrelease - package and upload a release\r\ndist - package locally\r\ninstall - install the package to the active Python's site-packages\r\n\r\n```","created_at":"2015-10-02T22:24:10Z","updated_at":"2015-10-12T17:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"741020ba922ed4075aca1f3ad1c6a481694a468c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565/commits","review_comments_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565/comments","review_comment_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/issues/4565/comments","statuses_url":"https://api.github.com/repos/learningequality/ka-lite/statuses/03b6df07999cde07651c02832b45aa0a17c1c601","head":{"label":"benjaoming:makefile-dist-docs","ref":"makefile-dist-docs","sha":"03b6df07999cde07651c02832b45aa0a17c1c601","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"repo":{"id":29163611,"name":"ka-lite","full_name":"benjaoming/ka-lite","owner":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaoming/ka-lite","description":"KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity","fork":true,"url":"https://api.github.com/repos/benjaoming/ka-lite","forks_url":"https://api.github.com/repos/benjaoming/ka-lite/forks","keys_url":"https://api.github.com/repos/benjaoming/ka-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaoming/ka-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaoming/ka-lite/teams","hooks_url":"https://api.github.com/repos/benjaoming/ka-lite/hooks","issue_events_url":"https://api.github.com/repos/benjaoming/ka-lite/issues/events{/number}","events_url":"https://api.github.com/repos/benjaoming/ka-lite/events","assignees_url":"https://api.github.com/repos/benjaoming/ka-lite/assignees{/user}","branches_url":"https://api.github.com/repos/benjaoming/ka-lite/branches{/branch}","tags_url":"https://api.github.com/repos/benjaoming/ka-lite/tags","blobs_url":"https://api.github.com/repos/benjaoming/ka-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaoming/ka-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaoming/ka-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaoming/ka-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaoming/ka-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaoming/ka-lite/languages","stargazers_url":"https://api.github.com/repos/benjaoming/ka-lite/stargazers","contributors_url":"https://api.github.com/repos/benjaoming/ka-lite/contributors","subscribers_url":"https://api.github.com/repos/benjaoming/ka-lite/subscribers","subscription_url":"https://api.github.com/repos/benjaoming/ka-lite/subscription","commits_url":"https://api.github.com/repos/benjaoming/ka-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaoming/ka-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaoming/ka-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaoming/ka-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaoming/ka-lite/contents/{+path}","compare_url":"https://api.github.com/repos/benjaoming/ka-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaoming/ka-lite/merges","archive_url":"https://api.github.com/repos/benjaoming/ka-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaoming/ka-lite/downloads","issues_url":"https://api.github.com/repos/benjaoming/ka-lite/issues{/number}","pulls_url":"https://api.github.com/repos/benjaoming/ka-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaoming/ka-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaoming/ka-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaoming/ka-lite/labels{/name}","releases_url":"https://api.github.com/repos/benjaoming/ka-lite/releases{/id}","created_at":"2015-01-13T00:04:53Z","updated_at":"2015-04-05T18:11:24Z","pushed_at":"2015-10-11T15:58:32Z","git_url":"git://github.com/benjaoming/ka-lite.git","ssh_url":"git@github.com:benjaoming/ka-lite.git","clone_url":"https://github.com/benjaoming/ka-lite.git","svn_url":"https://github.com/benjaoming/ka-lite","homepage":"https://learningequality.org/ka-lite/","size":170787,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"learningequality:0.15.x","ref":"0.15.x","sha":"bd8df62c41edee0504fd5e8cbd28e1958f023a30","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":5741125,"name":"ka-lite","full_name":"learningequality/ka-lite","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/ka-lite","description":"KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity","fork":false,"url":"https://api.github.com/repos/learningequality/ka-lite","forks_url":"https://api.github.com/repos/learningequality/ka-lite/forks","keys_url":"https://api.github.com/repos/learningequality/ka-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/ka-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/ka-lite/teams","hooks_url":"https://api.github.com/repos/learningequality/ka-lite/hooks","issue_events_url":"https://api.github.com/repos/learningequality/ka-lite/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/ka-lite/events","assignees_url":"https://api.github.com/repos/learningequality/ka-lite/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/ka-lite/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/ka-lite/tags","blobs_url":"https://api.github.com/repos/learningequality/ka-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/ka-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/ka-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/ka-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/ka-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/ka-lite/languages","stargazers_url":"https://api.github.com/repos/learningequality/ka-lite/stargazers","contributors_url":"https://api.github.com/repos/learningequality/ka-lite/contributors","subscribers_url":"https://api.github.com/repos/learningequality/ka-lite/subscribers","subscription_url":"https://api.github.com/repos/learningequality/ka-lite/subscription","commits_url":"https://api.github.com/repos/learningequality/ka-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/ka-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/ka-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/ka-lite/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/ka-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/ka-lite/merges","archive_url":"https://api.github.com/repos/learningequality/ka-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/ka-lite/downloads","issues_url":"https://api.github.com/repos/learningequality/ka-lite/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/ka-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/ka-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/ka-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/ka-lite/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/ka-lite/releases{/id}","created_at":"2012-09-09T20:01:40Z","updated_at":"2015-10-06T02:20:22Z","pushed_at":"2015-10-11T15:58:33Z","git_url":"git://github.com/learningequality/ka-lite.git","ssh_url":"git@github.com:learningequality/ka-lite.git","clone_url":"https://github.com/learningequality/ka-lite.git","svn_url":"https://github.com/learningequality/ka-lite","homepage":"https://learningequality.org/ka-lite/","size":250202,"stargazers_count":239,"watchers_count":239,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"open_issues_count":258,"forks":260,"open_issues":258,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/4565"},"issue":{"href":"https://api.github.com/repos/learningequality/ka-lite/issues/4565"},"comments":{"href":"https://api.github.com/repos/learningequality/ka-lite/issues/4565/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/4565/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/ka-lite/statuses/03b6df07999cde07651c02832b45aa0a17c1c601"}}}}