{"action":"created","issue":{"url":"https://api.github.com/repos/tarm/serial/issues/37","labels_url":"https://api.github.com/repos/tarm/serial/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/tarm/serial/issues/37/comments","events_url":"https://api.github.com/repos/tarm/serial/issues/37/events","html_url":"https://github.com/tarm/serial/pull/37","id":122074560,"number":37,"title":"Added port list functionality and increased range of baud rates available via serial_posix.go","user":{"login":"cormacc","id":3781515,"avatar_url":"https://avatars.githubusercontent.com/u/3781515?v=3","gravatar_id":"","url":"https://api.github.com/users/cormacc","html_url":"https://github.com/cormacc","followers_url":"https://api.github.com/users/cormacc/followers","following_url":"https://api.github.com/users/cormacc/following{/other_user}","gists_url":"https://api.github.com/users/cormacc/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacc/subscriptions","organizations_url":"https://api.github.com/users/cormacc/orgs","repos_url":"https://api.github.com/users/cormacc/repos","events_url":"https://api.github.com/users/cormacc/events{/privacy}","received_events_url":"https://api.github.com/users/cormacc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-14T16:12:04Z","updated_at":"2015-12-16T07:39:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tarm/serial/pulls/37","html_url":"https://github.com/tarm/serial/pull/37","diff_url":"https://github.com/tarm/serial/pull/37.diff","patch_url":"https://github.com/tarm/serial/pull/37.patch"},"body":"Added GetPortsList method to all implementations, shamelessly lifted \r\nfrom the gobug.st/serial package and subject to the conditions of its\r\nBSD-like license (which has been reproduced in source as per terms of said\r\nlicense). Experienced stability issues with gobug.st ages back, which is\r\nwhy I switched and stole.\r\n\r\nUpdated serial_posix to support full list of termios baud rates (as per\r\nexisting serial_linux implementation).\r\n\r\nMoved posixTimeoutValues method from top level serial.go to new\r\nserial_x.go source file, as only required for linux and posix\r\nimplementations.\r\n\r\nA major disclaimer -- not retested on windows and OSX since some refactoring and merging upstream changes over the last day or two, as moved office and only have Linux machines to hand."},"comment":{"url":"https://api.github.com/repos/tarm/serial/issues/comments/165023721","html_url":"https://github.com/tarm/serial/pull/37#issuecomment-165023721","issue_url":"https://api.github.com/repos/tarm/serial/issues/37","id":165023721,"user":{"login":"tarm","id":476641,"avatar_url":"https://avatars.githubusercontent.com/u/476641?v=3","gravatar_id":"","url":"https://api.github.com/users/tarm","html_url":"https://github.com/tarm","followers_url":"https://api.github.com/users/tarm/followers","following_url":"https://api.github.com/users/tarm/following{/other_user}","gists_url":"https://api.github.com/users/tarm/gists{/gist_id}","starred_url":"https://api.github.com/users/tarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarm/subscriptions","organizations_url":"https://api.github.com/users/tarm/orgs","repos_url":"https://api.github.com/users/tarm/repos","events_url":"https://api.github.com/users/tarm/events{/privacy}","received_events_url":"https://api.github.com/users/tarm/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T07:39:51Z","updated_at":"2015-12-16T07:39:51Z","body":"Thanks for the explanation.\r\n\r\nFrom your description, I think it could be OK to include that functionality.\r\n\r\nJust as OpenPort() has single common implementation with a godoc comment with platform specific openPort()'s, I think it makes sense to have that pattern for ListPorts().  The comment for ListPorts should be very explicit about it being precise on windows, but only a heuristic convenience function on unix platforms.\r\n\r\nAlso please split out the baud rate changes into a separate PR."}}