{"action":"closed","issue":{"url":"https://api.github.com/repos/unbit/uwsgi/issues/785","labels_url":"https://api.github.com/repos/unbit/uwsgi/issues/785/labels{/name}","comments_url":"https://api.github.com/repos/unbit/uwsgi/issues/785/comments","events_url":"https://api.github.com/repos/unbit/uwsgi/issues/785/events","html_url":"https://github.com/unbit/uwsgi/issues/785","id":50872408,"number":785,"title":"Carbon integration seems to break when reloading via `touch`","user":{"login":"danhartfiction","id":5641563,"avatar_url":"https://avatars.githubusercontent.com/u/5641563?v=3","gravatar_id":"","url":"https://api.github.com/users/danhartfiction","html_url":"https://github.com/danhartfiction","followers_url":"https://api.github.com/users/danhartfiction/followers","following_url":"https://api.github.com/users/danhartfiction/following{/other_user}","gists_url":"https://api.github.com/users/danhartfiction/gists{/gist_id}","starred_url":"https://api.github.com/users/danhartfiction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhartfiction/subscriptions","organizations_url":"https://api.github.com/users/danhartfiction/orgs","repos_url":"https://api.github.com/users/danhartfiction/repos","events_url":"https://api.github.com/users/danhartfiction/events{/privacy}","received_events_url":"https://api.github.com/users/danhartfiction/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-03T18:16:57Z","updated_at":"2015-01-07T05:53:45Z","closed_at":"2015-01-07T05:53:45Z","body":"When we reload via `touch` the wsgi file, the application successfully reloads.  However, all of our metrics logging via Carbon breaks.  We see the following in the log:\r\n\r\n```\r\n/var/log/uwsgi/xxxxx.stage.evxxxxote.com.log:[carbon] invalid carbon server address (10.6.8.60)\r\n```\r\n\r\nRestarting manually fixes this:\r\n```\r\n/var/log/uwsgi/xxxx.stage.evxxxote.com.log:[carbon] added server 10.6.8.60:2013\r\n```\r\n\r\nThis seems to be where this error is hit;\r\nhttps://github.com/unbit/uwsgi/blob/master/plugins/carbon/carbon.c\r\n```\r\n\t\tif (!u_server->hostname || !u_server->port) {\r\n\t\t\tuwsgi_log(\"[carbon] invalid carbon server address (%s)\\n\", usl->value);\r\n\t\t\tusl = usl->next;\r\n\r\n\t\t\tif (u_server->hostname) free(u_server->hostname);\r\n\t\t\tif (u_server->port) free(u_server->port);\r\n\t\t\tfree(u_server);\r\n\t\t\tcontinue;\r\n\t\t}\r\n```\r\n\r\nI suspect that for whatever reason, on reload, u_server is undefined.  I wonder if usl->value when reloading via touch is somehow missing the port, so the split fails? \r\n\r\nThank you for any advice you can provide on this!\r\nDan."}}