{"action":"created","comment":{"url":"https://api.github.com/repos/gonum/matrix/pulls/comments/22403767","id":22403767,"diff_hunk":"@@ -379,6 +379,27 @@ func (m *Dense) TCopy(a Matrix) {\n \t*m = w\n }\n \n+func (m *Dense) T() {\n+\t// TODO(jonlawlor): use a fully in-place transpose, without\n+\t// creating another slice with the same size.\n+\t// create a new slice\n+\td := make([]float64, len(m.mat.Data))\n+\n+\t// copy values into the appropriate location\n+\tcycle := m.mat.Rows*m.mat.Cols - 1","path":"mat64/dense.go","position":20,"original_position":20,"commit_id":"2dc8a1f92ea5f6b3c843246ed4a8973f42fba3e6","original_commit_id":"2dc8a1f92ea5f6b3c843246ed4a8973f42fba3e6","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=3","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"body":"This assumes Cols == Stride - see above.","created_at":"2015-01-02T02:44:52Z","updated_at":"2015-01-02T02:44:52Z","html_url":"https://github.com/gonum/matrix/pull/65#discussion_r22403767","pull_request_url":"https://api.github.com/repos/gonum/matrix/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/gonum/matrix/pulls/comments/22403767"},"html":{"href":"https://github.com/gonum/matrix/pull/65#discussion_r22403767"},"pull_request":{"href":"https://api.github.com/repos/gonum/matrix/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/gonum/matrix/pulls/65","id":26748190,"html_url":"https://github.com/gonum/matrix/pull/65","diff_url":"https://github.com/gonum/matrix/pull/65.diff","patch_url":"https://github.com/gonum/matrix/pull/65.patch","issue_url":"https://api.github.com/repos/gonum/matrix/issues/65","number":65,"state":"open","locked":false,"title":"Change Transposer to be a side effect","user":{"login":"jonlawlor","id":4468162,"avatar_url":"https://avatars.githubusercontent.com/u/4468162?v=3","gravatar_id":"","url":"https://api.github.com/users/jonlawlor","html_url":"https://github.com/jonlawlor","followers_url":"https://api.github.com/users/jonlawlor/followers","following_url":"https://api.github.com/users/jonlawlor/following{/other_user}","gists_url":"https://api.github.com/users/jonlawlor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlawlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlawlor/subscriptions","organizations_url":"https://api.github.com/users/jonlawlor/orgs","repos_url":"https://api.github.com/users/jonlawlor/repos","events_url":"https://api.github.com/users/jonlawlor/events{/privacy}","received_events_url":"https://api.github.com/users/jonlawlor/received_events","type":"User","site_admin":false},"body":"as per #37","created_at":"2015-01-02T01:01:18Z","updated_at":"2015-01-02T02:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"998e19d923bcac467f8af6f99cd9261ac79dcd46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gonum/matrix/pulls/65/commits","review_comments_url":"https://api.github.com/repos/gonum/matrix/pulls/65/comments","review_comment_url":"https://api.github.com/repos/gonum/matrix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gonum/matrix/issues/65/comments","statuses_url":"https://api.github.com/repos/gonum/matrix/statuses/2dc8a1f92ea5f6b3c843246ed4a8973f42fba3e6","head":{"label":"gonum:transposer-inplace","ref":"transposer-inplace","sha":"2dc8a1f92ea5f6b3c843246ed4a8973f42fba3e6","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=3","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":8569918,"name":"matrix","full_name":"gonum/matrix","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=3","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/matrix","description":"Scientific math package for the Go language.","fork":false,"url":"https://api.github.com/repos/gonum/matrix","forks_url":"https://api.github.com/repos/gonum/matrix/forks","keys_url":"https://api.github.com/repos/gonum/matrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/matrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/matrix/teams","hooks_url":"https://api.github.com/repos/gonum/matrix/hooks","issue_events_url":"https://api.github.com/repos/gonum/matrix/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/matrix/events","assignees_url":"https://api.github.com/repos/gonum/matrix/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/matrix/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/matrix/tags","blobs_url":"https://api.github.com/repos/gonum/matrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/matrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/matrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/matrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/matrix/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/matrix/languages","stargazers_url":"https://api.github.com/repos/gonum/matrix/stargazers","contributors_url":"https://api.github.com/repos/gonum/matrix/contributors","subscribers_url":"https://api.github.com/repos/gonum/matrix/subscribers","subscription_url":"https://api.github.com/repos/gonum/matrix/subscription","commits_url":"https://api.github.com/repos/gonum/matrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/matrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/matrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/matrix/issues/comments/{number}","contents_url":"https://api.github.com/repos/gonum/matrix/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/matrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/matrix/merges","archive_url":"https://api.github.com/repos/gonum/matrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/matrix/downloads","issues_url":"https://api.github.com/repos/gonum/matrix/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/matrix/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/matrix/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/matrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/matrix/labels{/name}","releases_url":"https://api.github.com/repos/gonum/matrix/releases{/id}","created_at":"2013-03-05T01:59:12Z","updated_at":"2015-01-01T23:51:10Z","pushed_at":"2015-01-02T02:20:20Z","git_url":"git://github.com/gonum/matrix.git","ssh_url":"git@github.com:gonum/matrix.git","clone_url":"https://github.com/gonum/matrix.git","svn_url":"https://github.com/gonum/matrix","homepage":null,"size":1550,"stargazers_count":76,"watchers_count":76,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":76,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"b6222f5f3ce81238a9bfe0d351beb96b099ef7b4","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=3","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":8569918,"name":"matrix","full_name":"gonum/matrix","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=3","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/matrix","description":"Scientific math package for the Go language.","fork":false,"url":"https://api.github.com/repos/gonum/matrix","forks_url":"https://api.github.com/repos/gonum/matrix/forks","keys_url":"https://api.github.com/repos/gonum/matrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/matrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/matrix/teams","hooks_url":"https://api.github.com/repos/gonum/matrix/hooks","issue_events_url":"https://api.github.com/repos/gonum/matrix/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/matrix/events","assignees_url":"https://api.github.com/repos/gonum/matrix/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/matrix/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/matrix/tags","blobs_url":"https://api.github.com/repos/gonum/matrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/matrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/matrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/matrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/matrix/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/matrix/languages","stargazers_url":"https://api.github.com/repos/gonum/matrix/stargazers","contributors_url":"https://api.github.com/repos/gonum/matrix/contributors","subscribers_url":"https://api.github.com/repos/gonum/matrix/subscribers","subscription_url":"https://api.github.com/repos/gonum/matrix/subscription","commits_url":"https://api.github.com/repos/gonum/matrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/matrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/matrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/matrix/issues/comments/{number}","contents_url":"https://api.github.com/repos/gonum/matrix/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/matrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/matrix/merges","archive_url":"https://api.github.com/repos/gonum/matrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/matrix/downloads","issues_url":"https://api.github.com/repos/gonum/matrix/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/matrix/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/matrix/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/matrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/matrix/labels{/name}","releases_url":"https://api.github.com/repos/gonum/matrix/releases{/id}","created_at":"2013-03-05T01:59:12Z","updated_at":"2015-01-01T23:51:10Z","pushed_at":"2015-01-02T02:20:20Z","git_url":"git://github.com/gonum/matrix.git","ssh_url":"git@github.com:gonum/matrix.git","clone_url":"https://github.com/gonum/matrix.git","svn_url":"https://github.com/gonum/matrix","homepage":null,"size":1550,"stargazers_count":76,"watchers_count":76,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/matrix/pulls/65"},"html":{"href":"https://github.com/gonum/matrix/pull/65"},"issue":{"href":"https://api.github.com/repos/gonum/matrix/issues/65"},"comments":{"href":"https://api.github.com/repos/gonum/matrix/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/matrix/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/matrix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gonum/matrix/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/matrix/statuses/2dc8a1f92ea5f6b3c843246ed4a8973f42fba3e6"}}}}