{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48","labels_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48/comments","events_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48/events","html_url":"https://github.com/wikimedia/service-template-node/pull/48","id":111814597,"number":48,"title":"Logging: header whitelisting","user":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-16T11:44:10Z","updated_at":"2015-10-16T12:12:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48","html_url":"https://github.com/wikimedia/service-template-node/pull/48","diff_url":"https://github.com/wikimedia/service-template-node/pull/48.diff","patch_url":"https://github.com/wikimedia/service-template-node/pull/48.patch"},"body":"Headers can and often do contain sensitive user information (IP, cookies, etc.) which should not be kept around and stored. Here we set up configuration-based header whitelisting. By default, the following headers are whitelisted:\r\n- `cache-control`\r\n- `content-type`\r\n- `content-length`\r\n- `if-match`\r\n- `user-agent`\r\n- `x-request-id`\r\n\r\nBug: [T112072](https://phabricator.wikimedia.org/T112072)"},"comment":{"url":"https://api.github.com/repos/wikimedia/service-template-node/issues/comments/148700789","html_url":"https://github.com/wikimedia/service-template-node/pull/48#issuecomment-148700789","issue_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48","id":148700789,"user":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T12:12:42Z","updated_at":"2015-10-16T12:12:42Z","body":"> In RESTBase we also log x-client-ip header, may be worths adding it here too or removing from RB, so that these were in line with each other?\r\n\r\nI think we should do the latter, `x-client-ip` contains the client's IP which shouldn't actually be stored."}}