{"action":"created","comment":{"url":"https://api.github.com/repos/ambiata/notion/pulls/comments/36057331","id":36057331,"diff_hunk":"@@ -43,7 +43,8 @@ object DistCopyJob {\n       job.getConfiguration.setInt(ReadLimit, conf.readLimit.toBytes.value.toInt)\n       job.getConfiguration.setLong(MultipartUploadThreshold, conf.multipartUploadThreshold.toBytes.value)\n     })\n-    _   <- DistCopyInputFormat.setMappings(job, ctx, conf.client, mappings, conf.mappersNumber)\n+    n   = Math.min(mappings.mappings.length, conf.mappersNumber)","path":"notion-distcopy/src/main/scala/com/ambiata/notion/distcopy/DistCopyJob.scala","position":5,"original_position":5,"commit_id":"4f792a122e85ab4d5742512c28d9bed5a2a4e111","original_commit_id":"4f792a122e85ab4d5742512c28d9bed5a2a4e111","user":{"login":"markhibberd","id":22832,"avatar_url":"https://avatars.githubusercontent.com/u/22832?v=3","gravatar_id":"","url":"https://api.github.com/users/markhibberd","html_url":"https://github.com/markhibberd","followers_url":"https://api.github.com/users/markhibberd/followers","following_url":"https://api.github.com/users/markhibberd/following{/other_user}","gists_url":"https://api.github.com/users/markhibberd/gists{/gist_id}","starred_url":"https://api.github.com/users/markhibberd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhibberd/subscriptions","organizations_url":"https://api.github.com/users/markhibberd/orgs","repos_url":"https://api.github.com/users/markhibberd/repos","events_url":"https://api.github.com/users/markhibberd/events{/privacy}","received_events_url":"https://api.github.com/users/markhibberd/received_events","type":"User","site_admin":false},"body":"Need to guard against zero length mappings.","created_at":"2015-08-03T05:40:26Z","updated_at":"2015-08-03T05:40:26Z","html_url":"https://github.com/ambiata/notion/pull/84#discussion_r36057331","pull_request_url":"https://api.github.com/repos/ambiata/notion/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/ambiata/notion/pulls/comments/36057331"},"html":{"href":"https://github.com/ambiata/notion/pull/84#discussion_r36057331"},"pull_request":{"href":"https://api.github.com/repos/ambiata/notion/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/ambiata/notion/pulls/84","id":41434461,"html_url":"https://github.com/ambiata/notion/pull/84","diff_url":"https://github.com/ambiata/notion/pull/84.diff","patch_url":"https://github.com/ambiata/notion/pull/84.patch","issue_url":"https://api.github.com/repos/ambiata/notion/issues/84","number":84,"state":"open","locked":false,"title":"Set number of mappers to either the specified or the number of files","user":{"login":"nhibberd","id":447873,"avatar_url":"https://avatars.githubusercontent.com/u/447873?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibberd","html_url":"https://github.com/nhibberd","followers_url":"https://api.github.com/users/nhibberd/followers","following_url":"https://api.github.com/users/nhibberd/following{/other_user}","gists_url":"https://api.github.com/users/nhibberd/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibberd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibberd/subscriptions","organizations_url":"https://api.github.com/users/nhibberd/orgs","repos_url":"https://api.github.com/users/nhibberd/repos","events_url":"https://api.github.com/users/nhibberd/events{/privacy}","received_events_url":"https://api.github.com/users/nhibberd/received_events","type":"User","site_admin":false},"body":"Fixes #83","created_at":"2015-08-03T04:38:42Z","updated_at":"2015-08-03T05:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e4e9f163ef5e2e039c806ab5e63cd2d92622c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ambiata/notion/pulls/84/commits","review_comments_url":"https://api.github.com/repos/ambiata/notion/pulls/84/comments","review_comment_url":"https://api.github.com/repos/ambiata/notion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ambiata/notion/issues/84/comments","statuses_url":"https://api.github.com/repos/ambiata/notion/statuses/4f792a122e85ab4d5742512c28d9bed5a2a4e111","head":{"label":"ambiata:topic/mappers","ref":"topic/mappers","sha":"4f792a122e85ab4d5742512c28d9bed5a2a4e111","user":{"login":"ambiata","id":1691023,"avatar_url":"https://avatars.githubusercontent.com/u/1691023?v=3","gravatar_id":"","url":"https://api.github.com/users/ambiata","html_url":"https://github.com/ambiata","followers_url":"https://api.github.com/users/ambiata/followers","following_url":"https://api.github.com/users/ambiata/following{/other_user}","gists_url":"https://api.github.com/users/ambiata/gists{/gist_id}","starred_url":"https://api.github.com/users/ambiata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambiata/subscriptions","organizations_url":"https://api.github.com/users/ambiata/orgs","repos_url":"https://api.github.com/users/ambiata/repos","events_url":"https://api.github.com/users/ambiata/events{/privacy}","received_events_url":"https://api.github.com/users/ambiata/received_events","type":"Organization","site_admin":false},"repo":{"id":25012772,"name":"notion","full_name":"ambiata/notion","owner":{"login":"ambiata","id":1691023,"avatar_url":"https://avatars.githubusercontent.com/u/1691023?v=3","gravatar_id":"","url":"https://api.github.com/users/ambiata","html_url":"https://github.com/ambiata","followers_url":"https://api.github.com/users/ambiata/followers","following_url":"https://api.github.com/users/ambiata/following{/other_user}","gists_url":"https://api.github.com/users/ambiata/gists{/gist_id}","starred_url":"https://api.github.com/users/ambiata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambiata/subscriptions","organizations_url":"https://api.github.com/users/ambiata/orgs","repos_url":"https://api.github.com/users/ambiata/repos","events_url":"https://api.github.com/users/ambiata/events{/privacy}","received_events_url":"https://api.github.com/users/ambiata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ambiata/notion","description":"A general understanding; vague or imperfect conception or idea of something - in this case of file system like data storage abstractions","fork":false,"url":"https://api.github.com/repos/ambiata/notion","forks_url":"https://api.github.com/repos/ambiata/notion/forks","keys_url":"https://api.github.com/repos/ambiata/notion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambiata/notion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambiata/notion/teams","hooks_url":"https://api.github.com/repos/ambiata/notion/hooks","issue_events_url":"https://api.github.com/repos/ambiata/notion/issues/events{/number}","events_url":"https://api.github.com/repos/ambiata/notion/events","assignees_url":"https://api.github.com/repos/ambiata/notion/assignees{/user}","branches_url":"https://api.github.com/repos/ambiata/notion/branches{/branch}","tags_url":"https://api.github.com/repos/ambiata/notion/tags","blobs_url":"https://api.github.com/repos/ambiata/notion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambiata/notion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambiata/notion/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambiata/notion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambiata/notion/statuses/{sha}","languages_url":"https://api.github.com/repos/ambiata/notion/languages","stargazers_url":"https://api.github.com/repos/ambiata/notion/stargazers","contributors_url":"https://api.github.com/repos/ambiata/notion/contributors","subscribers_url":"https://api.github.com/repos/ambiata/notion/subscribers","subscription_url":"https://api.github.com/repos/ambiata/notion/subscription","commits_url":"https://api.github.com/repos/ambiata/notion/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambiata/notion/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambiata/notion/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambiata/notion/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambiata/notion/contents/{+path}","compare_url":"https://api.github.com/repos/ambiata/notion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambiata/notion/merges","archive_url":"https://api.github.com/repos/ambiata/notion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambiata/notion/downloads","issues_url":"https://api.github.com/repos/ambiata/notion/issues{/number}","pulls_url":"https://api.github.com/repos/ambiata/notion/pulls{/number}","milestones_url":"https://api.github.com/repos/ambiata/notion/milestones{/number}","notifications_url":"https://api.github.com/repos/ambiata/notion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambiata/notion/labels{/name}","releases_url":"https://api.github.com/repos/ambiata/notion/releases{/id}","created_at":"2014-10-09T23:32:38Z","updated_at":"2015-07-29T22:35:08Z","pushed_at":"2015-08-03T04:42:24Z","git_url":"git://github.com/ambiata/notion.git","ssh_url":"git@github.com:ambiata/notion.git","clone_url":"https://github.com/ambiata/notion.git","svn_url":"https://github.com/ambiata/notion","homepage":"","size":1499,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"ambiata:master","ref":"master","sha":"e8c5a19b62b6ca003271be04c7b758504c62941e","user":{"login":"ambiata","id":1691023,"avatar_url":"https://avatars.githubusercontent.com/u/1691023?v=3","gravatar_id":"","url":"https://api.github.com/users/ambiata","html_url":"https://github.com/ambiata","followers_url":"https://api.github.com/users/ambiata/followers","following_url":"https://api.github.com/users/ambiata/following{/other_user}","gists_url":"https://api.github.com/users/ambiata/gists{/gist_id}","starred_url":"https://api.github.com/users/ambiata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambiata/subscriptions","organizations_url":"https://api.github.com/users/ambiata/orgs","repos_url":"https://api.github.com/users/ambiata/repos","events_url":"https://api.github.com/users/ambiata/events{/privacy}","received_events_url":"https://api.github.com/users/ambiata/received_events","type":"Organization","site_admin":false},"repo":{"id":25012772,"name":"notion","full_name":"ambiata/notion","owner":{"login":"ambiata","id":1691023,"avatar_url":"https://avatars.githubusercontent.com/u/1691023?v=3","gravatar_id":"","url":"https://api.github.com/users/ambiata","html_url":"https://github.com/ambiata","followers_url":"https://api.github.com/users/ambiata/followers","following_url":"https://api.github.com/users/ambiata/following{/other_user}","gists_url":"https://api.github.com/users/ambiata/gists{/gist_id}","starred_url":"https://api.github.com/users/ambiata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambiata/subscriptions","organizations_url":"https://api.github.com/users/ambiata/orgs","repos_url":"https://api.github.com/users/ambiata/repos","events_url":"https://api.github.com/users/ambiata/events{/privacy}","received_events_url":"https://api.github.com/users/ambiata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ambiata/notion","description":"A general understanding; vague or imperfect conception or idea of something - in this case of file system like data storage abstractions","fork":false,"url":"https://api.github.com/repos/ambiata/notion","forks_url":"https://api.github.com/repos/ambiata/notion/forks","keys_url":"https://api.github.com/repos/ambiata/notion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambiata/notion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambiata/notion/teams","hooks_url":"https://api.github.com/repos/ambiata/notion/hooks","issue_events_url":"https://api.github.com/repos/ambiata/notion/issues/events{/number}","events_url":"https://api.github.com/repos/ambiata/notion/events","assignees_url":"https://api.github.com/repos/ambiata/notion/assignees{/user}","branches_url":"https://api.github.com/repos/ambiata/notion/branches{/branch}","tags_url":"https://api.github.com/repos/ambiata/notion/tags","blobs_url":"https://api.github.com/repos/ambiata/notion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambiata/notion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambiata/notion/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambiata/notion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambiata/notion/statuses/{sha}","languages_url":"https://api.github.com/repos/ambiata/notion/languages","stargazers_url":"https://api.github.com/repos/ambiata/notion/stargazers","contributors_url":"https://api.github.com/repos/ambiata/notion/contributors","subscribers_url":"https://api.github.com/repos/ambiata/notion/subscribers","subscription_url":"https://api.github.com/repos/ambiata/notion/subscription","commits_url":"https://api.github.com/repos/ambiata/notion/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambiata/notion/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambiata/notion/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambiata/notion/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambiata/notion/contents/{+path}","compare_url":"https://api.github.com/repos/ambiata/notion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambiata/notion/merges","archive_url":"https://api.github.com/repos/ambiata/notion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambiata/notion/downloads","issues_url":"https://api.github.com/repos/ambiata/notion/issues{/number}","pulls_url":"https://api.github.com/repos/ambiata/notion/pulls{/number}","milestones_url":"https://api.github.com/repos/ambiata/notion/milestones{/number}","notifications_url":"https://api.github.com/repos/ambiata/notion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambiata/notion/labels{/name}","releases_url":"https://api.github.com/repos/ambiata/notion/releases{/id}","created_at":"2014-10-09T23:32:38Z","updated_at":"2015-07-29T22:35:08Z","pushed_at":"2015-08-03T04:42:24Z","git_url":"git://github.com/ambiata/notion.git","ssh_url":"git@github.com:ambiata/notion.git","clone_url":"https://github.com/ambiata/notion.git","svn_url":"https://github.com/ambiata/notion","homepage":"","size":1499,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ambiata/notion/pulls/84"},"html":{"href":"https://github.com/ambiata/notion/pull/84"},"issue":{"href":"https://api.github.com/repos/ambiata/notion/issues/84"},"comments":{"href":"https://api.github.com/repos/ambiata/notion/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/ambiata/notion/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/ambiata/notion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ambiata/notion/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/ambiata/notion/statuses/4f792a122e85ab4d5742512c28d9bed5a2a4e111"}}}}