{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/39742568","id":39742568,"diff_hunk":"@@ -198,6 +198,15 @@ def delete_item(self, location, user_id, revision=None, **kwargs):\n                 branches_to_delete = [ModuleStoreEnum.BranchName.published, ModuleStoreEnum.BranchName.draft]\n             elif revision is None:\n                 branches_to_delete = [ModuleStoreEnum.BranchName.draft]\n+                draft_location = location.for_branch(ModuleStoreEnum.BranchName.draft)\n+                try:\n+                    item = self.get_item(draft_location)\n+                    if getattr(item, 'has_children', False):\n+                        # If item have has_published_version then delete published children also.\n+                        if self.has_published_version(item):\n+                            branches_to_delete.insert(0, ModuleStoreEnum.BranchName.published)\n+                except ItemNotFoundError:","path":"common/lib/xmodule/xmodule/modulestore/split_mongo/split_draft.py","position":11,"original_position":11,"commit_id":"504703e8adf0dce679ad91b31010db53182d4a21","original_commit_id":"504703e8adf0dce679ad91b31010db53182d4a21","user":{"login":"adampalay","id":2748698,"avatar_url":"https://avatars.githubusercontent.com/u/2748698?v=3","gravatar_id":"","url":"https://api.github.com/users/adampalay","html_url":"https://github.com/adampalay","followers_url":"https://api.github.com/users/adampalay/followers","following_url":"https://api.github.com/users/adampalay/following{/other_user}","gists_url":"https://api.github.com/users/adampalay/gists{/gist_id}","starred_url":"https://api.github.com/users/adampalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampalay/subscriptions","organizations_url":"https://api.github.com/users/adampalay/orgs","repos_url":"https://api.github.com/users/adampalay/repos","events_url":"https://api.github.com/users/adampalay/events{/privacy}","received_events_url":"https://api.github.com/users/adampalay/received_events","type":"User","site_admin":false},"body":"when do you run into this `ItemNotFoundError`?","created_at":"2015-09-17T13:11:01Z","updated_at":"2015-09-17T13:11:01Z","html_url":"https://github.com/edx/edx-platform/pull/9432#discussion_r39742568","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9432","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/39742568"},"html":{"href":"https://github.com/edx/edx-platform/pull/9432#discussion_r39742568"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9432"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9432","id":43066748,"html_url":"https://github.com/edx/edx-platform/pull/9432","diff_url":"https://github.com/edx/edx-platform/pull/9432.diff","patch_url":"https://github.com/edx/edx-platform/pull/9432.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9432","number":9432,"state":"open","locked":false,"title":"Prevent publish orphans","user":{"login":"Shrhawk","id":7054417,"avatar_url":"https://avatars.githubusercontent.com/u/7054417?v=3","gravatar_id":"","url":"https://api.github.com/users/Shrhawk","html_url":"https://github.com/Shrhawk","followers_url":"https://api.github.com/users/Shrhawk/followers","following_url":"https://api.github.com/users/Shrhawk/following{/other_user}","gists_url":"https://api.github.com/users/Shrhawk/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrhawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrhawk/subscriptions","organizations_url":"https://api.github.com/users/Shrhawk/orgs","repos_url":"https://api.github.com/users/Shrhawk/repos","events_url":"https://api.github.com/users/Shrhawk/events{/privacy}","received_events_url":"https://api.github.com/users/Shrhawk/received_events","type":"User","site_admin":false},"body":"[PLAT-799](https://openedx.atlassian.net/browse/PLAT-799)\r\n\r\n**Problem**:\r\nWhen we delete an item which is in published state then only draft children delete but not published ones  and producing published orphans.\r\n\r\n**Solution**:\r\nWhen delete an item call is send with ```revision=None```  it deletes only ```draft``` children, now we check that if item have ```published``` version then delete the ```published ``` children also.","created_at":"2015-08-21T18:29:09Z","updated_at":"2015-09-17T13:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e087c718aefa8dc595730ecaaa8788ad3ba155ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9432/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9432/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9432/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/504703e8adf0dce679ad91b31010db53182d4a21","head":{"label":"edx:shr/bug/PLAT-799-prevent-published-orphan-creation","ref":"shr/bug/PLAT-799-prevent-published-orphan-creation","sha":"504703e8adf0dce679ad91b31010db53182d4a21","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-17T09:11:01Z","pushed_at":"2015-09-17T12:51:11Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2113204,"stargazers_count":2123,"watchers_count":2123,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1268,"mirror_url":null,"open_issues_count":168,"forks":1268,"open_issues":168,"watchers":2123,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"70866104bf9349c552fb50288575a73b79d40dd2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-17T09:11:01Z","pushed_at":"2015-09-17T12:51:11Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2113204,"stargazers_count":2123,"watchers_count":2123,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1268,"mirror_url":null,"open_issues_count":168,"forks":1268,"open_issues":168,"watchers":2123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9432"},"html":{"href":"https://github.com/edx/edx-platform/pull/9432"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9432"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9432/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9432/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9432/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/504703e8adf0dce679ad91b31010db53182d4a21"}}}}