{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/sarama/issues/368","labels_url":"https://api.github.com/repos/Shopify/sarama/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/sarama/issues/368/comments","events_url":"https://api.github.com/repos/Shopify/sarama/issues/368/events","html_url":"https://github.com/Shopify/sarama/pull/368","id":62890379,"number":368,"title":"producer: bugfix for aggregators getting stuck","user":{"login":"eapache","id":1706826,"avatar_url":"https://avatars.githubusercontent.com/u/1706826?v=3","gravatar_id":"","url":"https://api.github.com/users/eapache","html_url":"https://github.com/eapache","followers_url":"https://api.github.com/users/eapache/followers","following_url":"https://api.github.com/users/eapache/following{/other_user}","gists_url":"https://api.github.com/users/eapache/gists{/gist_id}","starred_url":"https://api.github.com/users/eapache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eapache/subscriptions","organizations_url":"https://api.github.com/users/eapache/orgs","repos_url":"https://api.github.com/users/eapache/repos","events_url":"https://api.github.com/users/eapache/events{/privacy}","received_events_url":"https://api.github.com/users/eapache/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-19T06:12:31Z","updated_at":"2015-03-19T06:15:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/sarama/pulls/368","html_url":"https://github.com/Shopify/sarama/pull/368","diff_url":"https://github.com/Shopify/sarama/pull/368.diff","patch_url":"https://github.com/Shopify/sarama/pull/368.patch"},"body":"In circumstances where Flush.Messages and/or Flush.Bytes were set but\r\nFlush.Frequency was not, the producer's aggregator could get stuck on a retry\r\nbecause a metadata-only chaser message would not be enough on its own to trigger\r\na flush, and so it would sit in limbo forever.\r\n\r\nAlways trigger a flush in the aggregator when the message is a chaser. This has\r\nthe additional benefit of reducing retry latency when Flush.Frequency *is* set.\r\n\r\nAdd a test for this case.\r\n\r\n@Shopify/kafka "},"comment":{"url":"https://api.github.com/repos/Shopify/sarama/issues/comments/83357434","html_url":"https://github.com/Shopify/sarama/pull/368#issuecomment-83357434","issue_url":"https://api.github.com/repos/Shopify/sarama/issues/368","id":83357434,"user":{"login":"eapache","id":1706826,"avatar_url":"https://avatars.githubusercontent.com/u/1706826?v=3","gravatar_id":"","url":"https://api.github.com/users/eapache","html_url":"https://github.com/eapache","followers_url":"https://api.github.com/users/eapache/followers","following_url":"https://api.github.com/users/eapache/following{/other_user}","gists_url":"https://api.github.com/users/eapache/gists{/gist_id}","starred_url":"https://api.github.com/users/eapache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eapache/subscriptions","organizations_url":"https://api.github.com/users/eapache/orgs","repos_url":"https://api.github.com/users/eapache/repos","events_url":"https://api.github.com/users/eapache/events{/privacy}","received_events_url":"https://api.github.com/users/eapache/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T06:15:30Z","updated_at":"2015-03-19T06:15:30Z","body":"This PR also DRYs up a pattern in the tests that was annoying me"}}