{"action":"created","comment":{"url":"https://api.github.com/repos/AtomLinter/Linter/pulls/comments/33413023","id":33413023,"diff_hunk":"@@ -0,0 +1,21 @@\n+class MessageLine extends HTMLElement","path":"lib/views/multiline.coffee","position":1,"original_position":1,"commit_id":"1410241e2b132a061bd34f350d1e74a533c86c25","original_commit_id":"1410241e2b132a061bd34f350d1e74a533c86c25","user":{"login":"lierdakil","id":7275622,"avatar_url":"https://avatars.githubusercontent.com/u/7275622?v=3","gravatar_id":"","url":"https://api.github.com/users/lierdakil","html_url":"https://github.com/lierdakil","followers_url":"https://api.github.com/users/lierdakil/followers","following_url":"https://api.github.com/users/lierdakil/following{/other_user}","gists_url":"https://api.github.com/users/lierdakil/gists{/gist_id}","starred_url":"https://api.github.com/users/lierdakil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lierdakil/subscriptions","organizations_url":"https://api.github.com/users/lierdakil/orgs","repos_url":"https://api.github.com/users/lierdakil/repos","events_url":"https://api.github.com/users/lierdakil/events{/privacy}","received_events_url":"https://api.github.com/users/lierdakil/received_events","type":"User","site_admin":false},"body":"Because I prefer to use `new MessageLine.setText text` instead of fumbling around with `document.createElement 'div'; ...`. I could use a `div.message-line`, but that seems like more code with no apparent benefit.","created_at":"2015-06-27T14:36:27Z","updated_at":"2015-06-27T14:36:27Z","html_url":"https://github.com/AtomLinter/Linter/pull/645#discussion_r33413023","pull_request_url":"https://api.github.com/repos/AtomLinter/Linter/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/comments/33413023"},"html":{"href":"https://github.com/AtomLinter/Linter/pull/645#discussion_r33413023"},"pull_request":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/AtomLinter/Linter/pulls/645","id":38707434,"html_url":"https://github.com/AtomLinter/Linter/pull/645","diff_url":"https://github.com/AtomLinter/Linter/pull/645.diff","patch_url":"https://github.com/AtomLinter/Linter/pull/645.patch","issue_url":"https://api.github.com/repos/AtomLinter/Linter/issues/645","number":645,"state":"open","locked":false,"title":"Multiline messages","user":{"login":"lierdakil","id":7275622,"avatar_url":"https://avatars.githubusercontent.com/u/7275622?v=3","gravatar_id":"","url":"https://api.github.com/users/lierdakil","html_url":"https://github.com/lierdakil","followers_url":"https://api.github.com/users/lierdakil/followers","following_url":"https://api.github.com/users/lierdakil/following{/other_user}","gists_url":"https://api.github.com/users/lierdakil/gists{/gist_id}","starred_url":"https://api.github.com/users/lierdakil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lierdakil/subscriptions","organizations_url":"https://api.github.com/users/lierdakil/orgs","repos_url":"https://api.github.com/users/lierdakil/repos","events_url":"https://api.github.com/users/lierdakil/events{/privacy}","received_events_url":"https://api.github.com/users/lierdakil/received_events","type":"User","site_admin":false},"body":"Support for multiline messages\r\n\r\nFor reasons of backwards-compatibility, multiline messages need to have `multiline: true` field set. With `multiline: true`, `text` argument will be treated with `white-space: pre`. If `html` is set, it takes precedence over both (since I'm not entirely convinced if \"multiline html\" even makes sense).\r\n\r\nMultiline messages are collapsed to show only first line by default. It is possible to expand those individually with mouse click (at any given moment, only one message can be expanded this way), or all with `linter:expand-multiline-messages` command, preferably bound to a key (`ctrl` or `shift`, for example).\r\n\r\nFor styling, there are two options I could think of. Current implementation looks something like this:\r\n\r\n![Collapsed](https://cloud.githubusercontent.com/assets/7275622/8391392/512d10ca-1ccb-11e5-93fb-2764c778922c.png)\r\nCollapsed\r\n\r\n![Panel message expanded](https://cloud.githubusercontent.com/assets/7275622/8391397/72d07e24-1ccb-11e5-9301-938df8932245.png)\r\nPanel message expanded\r\n\r\n![Tooltip message expanded](https://cloud.githubusercontent.com/assets/7275622/8391402/92dc2dda-1ccb-11e5-882f-7b0f73141db0.png)\r\nTooltip message expanded\r\n\r\n![All messages expanded](https://cloud.githubusercontent.com/assets/7275622/8391406/a8960696-1ccb-11e5-8657-3e2a97617865.png)\r\nAll messages expanded\r\n\r\nI've also considered an option to put marker of \"expandability\" at the end of first line, e.g.\r\n![Tooltip message expanded (alternative)](https://cloud.githubusercontent.com/assets/7275622/8391418/114eb886-1ccc-11e5-8190-fb25959b1262.png)\r\nTooltip message expanded (alternative)\r\n\r\nI think first version is less ambiguous, but I'd like to hear other opinions on the subject.\r\n\r\nIf you want to test this, currently this is used by `linter` branch on https://github.com/atom-haskell/haskell-ghc-mod (bear in mind one also needs `language-haskell` and `ide-haskell` installed, and `ghc-mod` executable available on `PATH`)","created_at":"2015-06-27T10:11:20Z","updated_at":"2015-06-27T14:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4ba3e76dcdb45c6c670ba5720dd8e943670a5a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/Linter/pulls/645/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/Linter/pulls/645/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/Linter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/Linter/issues/645/comments","statuses_url":"https://api.github.com/repos/AtomLinter/Linter/statuses/1410241e2b132a061bd34f350d1e74a533c86c25","head":{"label":"lierdakil:multiline-messages","ref":"multiline-messages","sha":"1410241e2b132a061bd34f350d1e74a533c86c25","user":{"login":"lierdakil","id":7275622,"avatar_url":"https://avatars.githubusercontent.com/u/7275622?v=3","gravatar_id":"","url":"https://api.github.com/users/lierdakil","html_url":"https://github.com/lierdakil","followers_url":"https://api.github.com/users/lierdakil/followers","following_url":"https://api.github.com/users/lierdakil/following{/other_user}","gists_url":"https://api.github.com/users/lierdakil/gists{/gist_id}","starred_url":"https://api.github.com/users/lierdakil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lierdakil/subscriptions","organizations_url":"https://api.github.com/users/lierdakil/orgs","repos_url":"https://api.github.com/users/lierdakil/repos","events_url":"https://api.github.com/users/lierdakil/events{/privacy}","received_events_url":"https://api.github.com/users/lierdakil/received_events","type":"User","site_admin":false},"repo":{"id":38124062,"name":"Linter","full_name":"lierdakil/Linter","owner":{"login":"lierdakil","id":7275622,"avatar_url":"https://avatars.githubusercontent.com/u/7275622?v=3","gravatar_id":"","url":"https://api.github.com/users/lierdakil","html_url":"https://github.com/lierdakil","followers_url":"https://api.github.com/users/lierdakil/followers","following_url":"https://api.github.com/users/lierdakil/following{/other_user}","gists_url":"https://api.github.com/users/lierdakil/gists{/gist_id}","starred_url":"https://api.github.com/users/lierdakil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lierdakil/subscriptions","organizations_url":"https://api.github.com/users/lierdakil/orgs","repos_url":"https://api.github.com/users/lierdakil/repos","events_url":"https://api.github.com/users/lierdakil/events{/privacy}","received_events_url":"https://api.github.com/users/lierdakil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lierdakil/Linter","description":"Inline code linting for Atom","fork":true,"url":"https://api.github.com/repos/lierdakil/Linter","forks_url":"https://api.github.com/repos/lierdakil/Linter/forks","keys_url":"https://api.github.com/repos/lierdakil/Linter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lierdakil/Linter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lierdakil/Linter/teams","hooks_url":"https://api.github.com/repos/lierdakil/Linter/hooks","issue_events_url":"https://api.github.com/repos/lierdakil/Linter/issues/events{/number}","events_url":"https://api.github.com/repos/lierdakil/Linter/events","assignees_url":"https://api.github.com/repos/lierdakil/Linter/assignees{/user}","branches_url":"https://api.github.com/repos/lierdakil/Linter/branches{/branch}","tags_url":"https://api.github.com/repos/lierdakil/Linter/tags","blobs_url":"https://api.github.com/repos/lierdakil/Linter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lierdakil/Linter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lierdakil/Linter/git/refs{/sha}","trees_url":"https://api.github.com/repos/lierdakil/Linter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lierdakil/Linter/statuses/{sha}","languages_url":"https://api.github.com/repos/lierdakil/Linter/languages","stargazers_url":"https://api.github.com/repos/lierdakil/Linter/stargazers","contributors_url":"https://api.github.com/repos/lierdakil/Linter/contributors","subscribers_url":"https://api.github.com/repos/lierdakil/Linter/subscribers","subscription_url":"https://api.github.com/repos/lierdakil/Linter/subscription","commits_url":"https://api.github.com/repos/lierdakil/Linter/commits{/sha}","git_commits_url":"https://api.github.com/repos/lierdakil/Linter/git/commits{/sha}","comments_url":"https://api.github.com/repos/lierdakil/Linter/comments{/number}","issue_comment_url":"https://api.github.com/repos/lierdakil/Linter/issues/comments{/number}","contents_url":"https://api.github.com/repos/lierdakil/Linter/contents/{+path}","compare_url":"https://api.github.com/repos/lierdakil/Linter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lierdakil/Linter/merges","archive_url":"https://api.github.com/repos/lierdakil/Linter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lierdakil/Linter/downloads","issues_url":"https://api.github.com/repos/lierdakil/Linter/issues{/number}","pulls_url":"https://api.github.com/repos/lierdakil/Linter/pulls{/number}","milestones_url":"https://api.github.com/repos/lierdakil/Linter/milestones{/number}","notifications_url":"https://api.github.com/repos/lierdakil/Linter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lierdakil/Linter/labels{/name}","releases_url":"https://api.github.com/repos/lierdakil/Linter/releases{/id}","created_at":"2015-06-26T17:20:58Z","updated_at":"2015-06-26T17:20:59Z","pushed_at":"2015-06-27T09:39:34Z","git_url":"git://github.com/lierdakil/Linter.git","ssh_url":"git@github.com:lierdakil/Linter.git","clone_url":"https://github.com/lierdakil/Linter.git","svn_url":"https://github.com/lierdakil/Linter","homepage":"","size":1017,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"a1c866b2ae3598434ac368b7b68ea908aab7d293","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":18612437,"name":"Linter","full_name":"AtomLinter/Linter","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/Linter","description":"A Base Linter with Cow Powers","fork":false,"url":"https://api.github.com/repos/AtomLinter/Linter","forks_url":"https://api.github.com/repos/AtomLinter/Linter/forks","keys_url":"https://api.github.com/repos/AtomLinter/Linter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/Linter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/Linter/teams","hooks_url":"https://api.github.com/repos/AtomLinter/Linter/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/Linter/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/Linter/events","assignees_url":"https://api.github.com/repos/AtomLinter/Linter/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/Linter/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/Linter/tags","blobs_url":"https://api.github.com/repos/AtomLinter/Linter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/Linter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/Linter/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/Linter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/Linter/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/Linter/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/Linter/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/Linter/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/Linter/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/Linter/subscription","commits_url":"https://api.github.com/repos/AtomLinter/Linter/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/Linter/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/Linter/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/Linter/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/Linter/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/Linter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/Linter/merges","archive_url":"https://api.github.com/repos/AtomLinter/Linter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/Linter/downloads","issues_url":"https://api.github.com/repos/AtomLinter/Linter/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/Linter/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/Linter/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/Linter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/Linter/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/Linter/releases{/id}","created_at":"2014-04-09T20:39:52Z","updated_at":"2015-06-27T09:34:58Z","pushed_at":"2015-06-27T10:11:21Z","git_url":"git://github.com/AtomLinter/Linter.git","ssh_url":"git@github.com:AtomLinter/Linter.git","clone_url":"https://github.com/AtomLinter/Linter.git","svn_url":"https://github.com/AtomLinter/Linter","homepage":"","size":3937,"stargazers_count":277,"watchers_count":277,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"open_issues_count":8,"forks":83,"open_issues":8,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/645"},"html":{"href":"https://github.com/AtomLinter/Linter/pull/645"},"issue":{"href":"https://api.github.com/repos/AtomLinter/Linter/issues/645"},"comments":{"href":"https://api.github.com/repos/AtomLinter/Linter/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/Linter/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/Linter/statuses/1410241e2b132a061bd34f350d1e74a533c86c25"}}}}