{"action":"closed","number":1822,"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/1822","id":36558227,"html_url":"https://github.com/atom/electron/pull/1822","diff_url":"https://github.com/atom/electron/pull/1822.diff","patch_url":"https://github.com/atom/electron/pull/1822.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/1822","number":1822,"state":"closed","locked":false,"title":"Crashpad!","user":{"login":"hokein","id":2557445,"avatar_url":"https://avatars.githubusercontent.com/u/2557445?v=3","gravatar_id":"","url":"https://api.github.com/users/hokein","html_url":"https://github.com/hokein","followers_url":"https://api.github.com/users/hokein/followers","following_url":"https://api.github.com/users/hokein/following{/other_user}","gists_url":"https://api.github.com/users/hokein/gists{/gist_id}","starred_url":"https://api.github.com/users/hokein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hokein/subscriptions","organizations_url":"https://api.github.com/users/hokein/orgs","repos_url":"https://api.github.com/users/hokein/repos","events_url":"https://api.github.com/users/hokein/events{/privacy}","received_events_url":"https://api.github.com/users/hokein/received_events","type":"User","site_admin":false},"body":"Replace the current breakpad on OS X, fixes #1638 . Crash spec test is passed on OS X 10.9.4.\r\n\r\nThere are some follow-ups:\r\n* We need a mirror `crashpad` repo, currently it's under my account.\r\n*  The new `crashpad` client is a new out-process architecture. To enable crash feature, we need to launch a new process from Browser process to run [`crashpad_handler`](http://docs.crashpad.googlecode.com/git/man/crashpad_handler.html). We might need to custom the `crash-reporter` API to make it more clearer(I keep it the same now). ","created_at":"2015-05-30T02:13:56Z","updated_at":"2015-06-04T14:11:14Z","closed_at":"2015-06-04T14:11:14Z","merged_at":"2015-06-04T14:11:14Z","merge_commit_sha":"69d6bcf2de9374782ac46c421910386e743929ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/1822/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/1822/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/1822/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/d5b47d1059bfee5f53790740fd56524093253fdc","head":{"label":"hokein:crashpad-mac","ref":"crashpad-mac","sha":"d5b47d1059bfee5f53790740fd56524093253fdc","user":{"login":"hokein","id":2557445,"avatar_url":"https://avatars.githubusercontent.com/u/2557445?v=3","gravatar_id":"","url":"https://api.github.com/users/hokein","html_url":"https://github.com/hokein","followers_url":"https://api.github.com/users/hokein/followers","following_url":"https://api.github.com/users/hokein/following{/other_user}","gists_url":"https://api.github.com/users/hokein/gists{/gist_id}","starred_url":"https://api.github.com/users/hokein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hokein/subscriptions","organizations_url":"https://api.github.com/users/hokein/orgs","repos_url":"https://api.github.com/users/hokein/repos","events_url":"https://api.github.com/users/hokein/events{/privacy}","received_events_url":"https://api.github.com/users/hokein/received_events","type":"User","site_admin":false},"repo":{"id":21982125,"name":"atom-shell","full_name":"hokein/atom-shell","owner":{"login":"hokein","id":2557445,"avatar_url":"https://avatars.githubusercontent.com/u/2557445?v=3","gravatar_id":"","url":"https://api.github.com/users/hokein","html_url":"https://github.com/hokein","followers_url":"https://api.github.com/users/hokein/followers","following_url":"https://api.github.com/users/hokein/following{/other_user}","gists_url":"https://api.github.com/users/hokein/gists{/gist_id}","starred_url":"https://api.github.com/users/hokein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hokein/subscriptions","organizations_url":"https://api.github.com/users/hokein/orgs","repos_url":"https://api.github.com/users/hokein/repos","events_url":"https://api.github.com/users/hokein/events{/privacy}","received_events_url":"https://api.github.com/users/hokein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hokein/atom-shell","description":"Cross-platform desktop application shell","fork":true,"url":"https://api.github.com/repos/hokein/atom-shell","forks_url":"https://api.github.com/repos/hokein/atom-shell/forks","keys_url":"https://api.github.com/repos/hokein/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hokein/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hokein/atom-shell/teams","hooks_url":"https://api.github.com/repos/hokein/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/hokein/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/hokein/atom-shell/events","assignees_url":"https://api.github.com/repos/hokein/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/hokein/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/hokein/atom-shell/tags","blobs_url":"https://api.github.com/repos/hokein/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hokein/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hokein/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/hokein/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hokein/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/hokein/atom-shell/languages","stargazers_url":"https://api.github.com/repos/hokein/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/hokein/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/hokein/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/hokein/atom-shell/subscription","commits_url":"https://api.github.com/repos/hokein/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/hokein/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/hokein/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/hokein/atom-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/hokein/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/hokein/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hokein/atom-shell/merges","archive_url":"https://api.github.com/repos/hokein/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hokein/atom-shell/downloads","issues_url":"https://api.github.com/repos/hokein/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/hokein/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/hokein/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/hokein/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hokein/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/hokein/atom-shell/releases{/id}","created_at":"2014-07-18T13:59:17Z","updated_at":"2015-04-28T09:47:06Z","pushed_at":"2015-06-04T07:57:09Z","git_url":"git://github.com/hokein/atom-shell.git","ssh_url":"git@github.com:hokein/atom-shell.git","clone_url":"https://github.com/hokein/atom-shell.git","svn_url":"https://github.com/hokein/atom-shell","homepage":"","size":8979,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"02bdace366f38271b5c186412f42810ecb06e99e","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-06-04T14:04:19Z","pushed_at":"2015-06-04T14:11:14Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":23997,"stargazers_count":12066,"watchers_count":12066,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":884,"mirror_url":null,"open_issues_count":191,"forks":884,"open_issues":191,"watchers":12066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/1822"},"html":{"href":"https://github.com/atom/electron/pull/1822"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/1822"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/1822/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/1822/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/1822/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/d5b47d1059bfee5f53790740fd56524093253fdc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"comments":1,"review_comments":39,"commits":11,"additions":153,"deletions":59,"changed_files":12}}