{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/12626","labels_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12626/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12626/comments","events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12626/events","html_url":"https://github.com/tgstation/-tg-station/pull/12626","id":113130290,"number":12626,"title":"Remove tags from some maps","user":{"login":"MrPerson","id":1389934,"avatar_url":"https://avatars.githubusercontent.com/u/1389934?v=3","gravatar_id":"","url":"https://api.github.com/users/MrPerson","html_url":"https://github.com/MrPerson","followers_url":"https://api.github.com/users/MrPerson/followers","following_url":"https://api.github.com/users/MrPerson/following{/other_user}","gists_url":"https://api.github.com/users/MrPerson/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPerson/subscriptions","organizations_url":"https://api.github.com/users/MrPerson/orgs","repos_url":"https://api.github.com/users/MrPerson/repos","events_url":"https://api.github.com/users/MrPerson/events{/privacy}","received_events_url":"https://api.github.com/users/MrPerson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-24T02:44:38Z","updated_at":"2015-10-25T08:24:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/12626","html_url":"https://github.com/tgstation/-tg-station/pull/12626","diff_url":"https://github.com/tgstation/-tg-station/pull/12626.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/12626.patch"},"body":"~~Did not touch Bird, Disc, Dream, or Meta out of fear of conflicts.~~\r\nDisc was left completely untouched. Dream was given only a single edit to keep the syndiebomb working. All map-specific custom z's, other main maps not listed above, and all the away missions were cleaned too.\r\n\r\nSource of these tags is DM being stupid. When you use the \"Generate instances based on icon states\" option, for some ungodly reason it gives those instances a tag. Which is retarded, tags are supposed to be unique to each object.\r\n\r\nI tried searching for legit uses of tag in code and found only a few landmarks and giving mobs a tag. In any event, setting tags on map objects is probably a really bad idea anyway. EDIT: Also the syndicate nuke uses a tag, so I hardcoded a syndicate bomb type. All the maps except asteroid and disk were fixed to use it. Those two both still use the old spawners.\r\n\r\nExact regex used to find these so you guys can check my work\r\n\r\n; tag = \"[^\"]*\"\r\n#end/middle\r\n\r\n(?<=\\{)tag = \"[^\"]*\";\r\n#begin\r\n\r\n\\{tag = \"[^\"]*\"\\}\r\n#solo"},"comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments/150900302","html_url":"https://github.com/tgstation/-tg-station/pull/12626#issuecomment-150900302","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12626","id":150900302,"user":{"login":"MrPerson","id":1389934,"avatar_url":"https://avatars.githubusercontent.com/u/1389934?v=3","gravatar_id":"","url":"https://api.github.com/users/MrPerson","html_url":"https://github.com/MrPerson","followers_url":"https://api.github.com/users/MrPerson/followers","following_url":"https://api.github.com/users/MrPerson/following{/other_user}","gists_url":"https://api.github.com/users/MrPerson/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPerson/subscriptions","organizations_url":"https://api.github.com/users/MrPerson/orgs","repos_url":"https://api.github.com/users/MrPerson/repos","events_url":"https://api.github.com/users/MrPerson/events{/privacy}","received_events_url":"https://api.github.com/users/MrPerson/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T08:24:47Z","updated_at":"2015-10-25T08:24:47Z","body":"I replaced it with a different type that has the tag built in."}}