{"action":"created","comment":{"url":"https://api.github.com/repos/ipython/ipython/pulls/comments/31590092","id":31590092,"diff_hunk":"@@ -64,20 +56,42 @@ def find_module(name, path=None):\n         Return full path of module or None if module is missing or does not have\n         .py or .pyw extension\n     \"\"\"\n-    if name is None:\n-        return None\n-    try:\n-        file, filename, _ = imp.find_module(name, path)\n-    except ImportError:\n-        return None\n-    if file is None:\n-        return filename\n-    else:\n-        file.close()\n-    if os.path.splitext(filename)[1] in [\".py\", \".pyc\"]:\n-        return filename\n-    else:\n-        return None\n+    return _find_module(name, path)\n+\n+\n+if sys.version_info >= (3,4):\n+    import importlib.util\n+    def _find_module(name, path):\n+        if path is not None:\n+            warnings.warn( \"`path=` argument deprecated on python 3.5 and above\", DeprecationWarning, stacklevel=2)","path":"IPython/utils/module_paths.py","position":63,"original_position":63,"commit_id":"2fb422220aff6b60f63d5adab981442fe3bea270","original_commit_id":"2fb422220aff6b60f63d5adab981442fe3bea270","user":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?v=3","gravatar_id":"","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"body":"souldn't be  \"on python 3.4 and above\"??","created_at":"2015-06-03T02:38:25Z","updated_at":"2015-06-03T02:38:25Z","html_url":"https://github.com/ipython/ipython/pull/8371#discussion_r31590092","pull_request_url":"https://api.github.com/repos/ipython/ipython/pulls/8371","_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/31590092"},"html":{"href":"https://github.com/ipython/ipython/pull/8371#discussion_r31590092"},"pull_request":{"href":"https://api.github.com/repos/ipython/ipython/pulls/8371"}}},"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/8371","id":34010299,"html_url":"https://github.com/ipython/ipython/pull/8371","diff_url":"https://github.com/ipython/ipython/pull/8371.diff","patch_url":"https://github.com/ipython/ipython/pull/8371.patch","issue_url":"https://api.github.com/repos/ipython/ipython/issues/8371","number":8371,"state":"open","locked":false,"title":"More removing of import imp on 3.4+","user":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-24T00:42:11Z","updated_at":"2015-06-03T02:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17b48f81383d373e4cf89233253872596d36591a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipython/ipython/pulls/8371/commits","review_comments_url":"https://api.github.com/repos/ipython/ipython/pulls/8371/comments","review_comment_url":"https://api.github.com/repos/ipython/ipython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/8371/comments","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/2fb422220aff6b60f63d5adab981442fe3bea270","head":{"label":"Carreau:remove-imp","ref":"remove-imp","sha":"2fb422220aff6b60f63d5adab981442fe3bea270","user":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"repo":{"id":2344073,"name":"ipython","full_name":"Carreau/ipython","owner":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Carreau/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, python3 support, etc.","fork":true,"url":"https://api.github.com/repos/Carreau/ipython","forks_url":"https://api.github.com/repos/Carreau/ipython/forks","keys_url":"https://api.github.com/repos/Carreau/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carreau/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carreau/ipython/teams","hooks_url":"https://api.github.com/repos/Carreau/ipython/hooks","issue_events_url":"https://api.github.com/repos/Carreau/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/Carreau/ipython/events","assignees_url":"https://api.github.com/repos/Carreau/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/Carreau/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/Carreau/ipython/tags","blobs_url":"https://api.github.com/repos/Carreau/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carreau/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carreau/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carreau/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carreau/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/Carreau/ipython/languages","stargazers_url":"https://api.github.com/repos/Carreau/ipython/stargazers","contributors_url":"https://api.github.com/repos/Carreau/ipython/contributors","subscribers_url":"https://api.github.com/repos/Carreau/ipython/subscribers","subscription_url":"https://api.github.com/repos/Carreau/ipython/subscription","commits_url":"https://api.github.com/repos/Carreau/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carreau/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carreau/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carreau/ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carreau/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/Carreau/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carreau/ipython/merges","archive_url":"https://api.github.com/repos/Carreau/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carreau/ipython/downloads","issues_url":"https://api.github.com/repos/Carreau/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/Carreau/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/Carreau/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/Carreau/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carreau/ipython/labels{/name}","releases_url":"https://api.github.com/repos/Carreau/ipython/releases{/id}","created_at":"2011-09-07T19:50:06Z","updated_at":"2015-02-24T04:03:55Z","pushed_at":"2015-06-02T18:17:46Z","git_url":"git://github.com/Carreau/ipython.git","ssh_url":"git@github.com:Carreau/ipython.git","clone_url":"https://github.com/Carreau/ipython.git","svn_url":"https://github.com/Carreau/ipython","homepage":"http://ipython.org","size":72199,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"ipython:master","ref":"master","sha":"e51e50d36f2d05061ef7bdcea56531f5fca08f4c","user":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"repo":{"id":658518,"name":"ipython","full_name":"ipython/ipython","owner":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":false,"url":"https://api.github.com/repos/ipython/ipython","forks_url":"https://api.github.com/repos/ipython/ipython/forks","keys_url":"https://api.github.com/repos/ipython/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython/ipython/teams","hooks_url":"https://api.github.com/repos/ipython/ipython/hooks","issue_events_url":"https://api.github.com/repos/ipython/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/ipython/ipython/events","assignees_url":"https://api.github.com/repos/ipython/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/ipython/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/ipython/ipython/tags","blobs_url":"https://api.github.com/repos/ipython/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython/ipython/languages","stargazers_url":"https://api.github.com/repos/ipython/ipython/stargazers","contributors_url":"https://api.github.com/repos/ipython/ipython/contributors","subscribers_url":"https://api.github.com/repos/ipython/ipython/subscribers","subscription_url":"https://api.github.com/repos/ipython/ipython/subscription","commits_url":"https://api.github.com/repos/ipython/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython/ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipython/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/ipython/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython/ipython/merges","archive_url":"https://api.github.com/repos/ipython/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython/ipython/downloads","issues_url":"https://api.github.com/repos/ipython/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/ipython/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython/ipython/labels{/name}","releases_url":"https://api.github.com/repos/ipython/ipython/releases{/id}","created_at":"2010-05-10T04:46:06Z","updated_at":"2015-06-02T21:37:19Z","pushed_at":"2015-06-02T18:37:33Z","git_url":"git://github.com/ipython/ipython.git","ssh_url":"git@github.com:ipython/ipython.git","clone_url":"https://github.com/ipython/ipython.git","svn_url":"https://github.com/ipython/ipython","homepage":"http://ipython.org","size":117920,"stargazers_count":6654,"watchers_count":6654,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1966,"mirror_url":null,"open_issues_count":935,"forks":1966,"open_issues":935,"watchers":6654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/8371"},"html":{"href":"https://github.com/ipython/ipython/pull/8371"},"issue":{"href":"https://api.github.com/repos/ipython/ipython/issues/8371"},"comments":{"href":"https://api.github.com/repos/ipython/ipython/issues/8371/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython/ipython/pulls/8371/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipython/ipython/pulls/8371/commits"},"statuses":{"href":"https://api.github.com/repos/ipython/ipython/statuses/2fb422220aff6b60f63d5adab981442fe3bea270"}}}}