{"action":"created","comment":{"url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/comments/26286591","id":26286591,"diff_hunk":"@@ -47,12 +55,20 @@ public function __construct(KeyLoader $keyLoader)\n      */\n     public function hasValidSignature(AuthnRequest $request, ServiceProvider $serviceProvider)\n     {\n+        $this->logger->debug(sprintf('Extracting public keys for ServiceProvider \"%s\"', $serviceProvider->getEntityId()));\n+\n         $keys = $this->keyLoader->extractPublicKeys($serviceProvider);\n \n+        $this->logger->debug(sprintf('Found \"%d\" keys, filtering the keys to get X509 keys', $keys->count()));\n         $x509Keys = $keys->filter(function (SAML2_Certificate_Key $key) {\n             return $key instanceof SAML2_Certificate_X509;\n         });\n \n+        $this->logger->debug(sprintf(\n+            'Found \"%d\" X509 keys, attempting to use each for signature verification',\n+            $x509Keys->count()\n+        ));\n+\n         foreach ($x509Keys as $key) {\n             if ($this->isSignedWith($request, $key)) {\n                 return true;","path":"src/Signing/SignatureVerifier.php","position":48,"original_position":48,"commit_id":"0a758e706841924ba5f938081dac27c1c13c7a1a","original_commit_id":"0a758e706841924ba5f938081dac27c1c13c7a1a","user":{"login":"rjkip","id":1734555,"avatar_url":"https://avatars.githubusercontent.com/u/1734555?v=3","gravatar_id":"","url":"https://api.github.com/users/rjkip","html_url":"https://github.com/rjkip","followers_url":"https://api.github.com/users/rjkip/followers","following_url":"https://api.github.com/users/rjkip/following{/other_user}","gists_url":"https://api.github.com/users/rjkip/gists{/gist_id}","starred_url":"https://api.github.com/users/rjkip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjkip/subscriptions","organizations_url":"https://api.github.com/users/rjkip/orgs","repos_url":"https://api.github.com/users/rjkip/repos","events_url":"https://api.github.com/users/rjkip/events{/privacy}","received_events_url":"https://api.github.com/users/rjkip/received_events","type":"User","site_admin":false},"body":"I'd say a debug message informing the signature was (not) properly signed with one of the keys is useful and completes the log messages. The consumer can still log its process on INFO or whatever (we're throwing if signature validation fails) at its discretion.","created_at":"2015-03-12T09:10:52Z","updated_at":"2015-03-12T09:10:52Z","html_url":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15#discussion_r26286591","pull_request_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/comments/26286591"},"html":{"href":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15#discussion_r26286591"},"pull_request":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15","id":30920495,"html_url":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15","diff_url":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15.diff","patch_url":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15.patch","issue_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/15","number":15,"state":"open","locked":false,"title":"Enable debug logging of signature verification","user":{"login":"DRvanR","id":1422284,"avatar_url":"https://avatars.githubusercontent.com/u/1422284?v=3","gravatar_id":"","url":"https://api.github.com/users/DRvanR","html_url":"https://github.com/DRvanR","followers_url":"https://api.github.com/users/DRvanR/followers","following_url":"https://api.github.com/users/DRvanR/following{/other_user}","gists_url":"https://api.github.com/users/DRvanR/gists{/gist_id}","starred_url":"https://api.github.com/users/DRvanR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DRvanR/subscriptions","organizations_url":"https://api.github.com/users/DRvanR/orgs","repos_url":"https://api.github.com/users/DRvanR/repos","events_url":"https://api.github.com/users/DRvanR/events{/privacy}","received_events_url":"https://api.github.com/users/DRvanR/received_events","type":"User","site_admin":false},"body":"This is a request from @pmeulen so that debugging is easier when Response signature verfication fails.\r\n\r\n- [ ] Inject the logger rather than pass in method call.","created_at":"2015-03-11T07:25:21Z","updated_at":"2015-03-12T09:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee2bfc90a3dc2af3c3a999784d3c2b87b09f59d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15/commits","review_comments_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15/comments","review_comment_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/15/comments","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/statuses/0a758e706841924ba5f938081dac27c1c13c7a1a","head":{"label":"SURFnet:feature/log-debug-signature-verification","ref":"feature/log-debug-signature-verification","sha":"0a758e706841924ba5f938081dac27c1c13c7a1a","user":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"repo":{"id":25961674,"name":"Stepup-saml-bundle","full_name":"SURFnet/Stepup-saml-bundle","owner":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SURFnet/Stepup-saml-bundle","description":"SAML bundle for gateway, self-service, and ra","fork":false,"url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle","forks_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/forks","keys_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/teams","hooks_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/hooks","issue_events_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/events","assignees_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/tags","blobs_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/languages","stargazers_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/stargazers","contributors_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/contributors","subscribers_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/subscribers","subscription_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/subscription","commits_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/merges","archive_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/downloads","issues_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/labels{/name}","releases_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/releases{/id}","created_at":"2014-10-30T08:35:54Z","updated_at":"2015-02-27T08:08:40Z","pushed_at":"2015-03-11T15:00:19Z","git_url":"git://github.com/SURFnet/Stepup-saml-bundle.git","ssh_url":"git@github.com:SURFnet/Stepup-saml-bundle.git","clone_url":"https://github.com/SURFnet/Stepup-saml-bundle.git","svn_url":"https://github.com/SURFnet/Stepup-saml-bundle","homepage":null,"size":600,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"SURFnet:develop","ref":"develop","sha":"b62b06fdde54086ffd68cbe056dd25e32ee88c67","user":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"repo":{"id":25961674,"name":"Stepup-saml-bundle","full_name":"SURFnet/Stepup-saml-bundle","owner":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SURFnet/Stepup-saml-bundle","description":"SAML bundle for gateway, self-service, and ra","fork":false,"url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle","forks_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/forks","keys_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/teams","hooks_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/hooks","issue_events_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/events","assignees_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/tags","blobs_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/languages","stargazers_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/stargazers","contributors_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/contributors","subscribers_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/subscribers","subscription_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/subscription","commits_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/merges","archive_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/downloads","issues_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/labels{/name}","releases_url":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/releases{/id}","created_at":"2014-10-30T08:35:54Z","updated_at":"2015-02-27T08:08:40Z","pushed_at":"2015-03-11T15:00:19Z","git_url":"git://github.com/SURFnet/Stepup-saml-bundle.git","ssh_url":"git@github.com:SURFnet/Stepup-saml-bundle.git","clone_url":"https://github.com/SURFnet/Stepup-saml-bundle.git","svn_url":"https://github.com/SURFnet/Stepup-saml-bundle","homepage":null,"size":600,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15"},"html":{"href":"https://github.com/SURFnet/Stepup-saml-bundle/pull/15"},"issue":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/15"},"comments":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/SURFnet/Stepup-saml-bundle/statuses/0a758e706841924ba5f938081dac27c1c13c7a1a"}}}}