{"action":"created","comment":{"url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/comments/43056371","id":43056371,"diff_hunk":"@@ -29,15 +31,16 @@ public static class SeqPortableLoggerConfigurationExtensions\n             LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,\n             int batchPostingLimit = PortableSeqSink.DefaultBatchPostingLimit,\n             TimeSpan? period = null,\n-            string apiKey = null)\n+            string apiKey = null, IHttpClientFactory httpClientFactory = null)","path":"Seq.Client.Portable/LoggerSinkConfigurationExtensions.cs","position":19,"original_position":19,"commit_id":"1df07cdc5f407538383636779a799806ad2c5fb2","original_commit_id":"1df07cdc5f407538383636779a799806ad2c5fb2","user":{"login":"dazinator","id":3176632,"avatar_url":"https://avatars.githubusercontent.com/u/3176632?v=3","gravatar_id":"","url":"https://api.github.com/users/dazinator","html_url":"https://github.com/dazinator","followers_url":"https://api.github.com/users/dazinator/followers","following_url":"https://api.github.com/users/dazinator/following{/other_user}","gists_url":"https://api.github.com/users/dazinator/gists{/gist_id}","starred_url":"https://api.github.com/users/dazinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazinator/subscriptions","organizations_url":"https://api.github.com/users/dazinator/orgs","repos_url":"https://api.github.com/users/dazinator/repos","events_url":"https://api.github.com/users/dazinator/events{/privacy}","received_events_url":"https://api.github.com/users/dazinator/received_events","type":"User","site_admin":false},"body":"Ah yes - will correct","created_at":"2015-10-26T21:32:50Z","updated_at":"2015-10-26T21:32:50Z","html_url":"https://github.com/continuousit/seq-client-portable/pull/1#discussion_r43056371","pull_request_url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/comments/43056371"},"html":{"href":"https://github.com/continuousit/seq-client-portable/pull/1#discussion_r43056371"},"pull_request":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1","id":48766398,"html_url":"https://github.com/continuousit/seq-client-portable/pull/1","diff_url":"https://github.com/continuousit/seq-client-portable/pull/1.diff","patch_url":"https://github.com/continuousit/seq-client-portable/pull/1.patch","issue_url":"https://api.github.com/repos/continuousit/seq-client-portable/issues/1","number":1,"state":"open","locked":false,"title":"HttpClientFactory","user":{"login":"dazinator","id":3176632,"avatar_url":"https://avatars.githubusercontent.com/u/3176632?v=3","gravatar_id":"","url":"https://api.github.com/users/dazinator","html_url":"https://github.com/dazinator","followers_url":"https://api.github.com/users/dazinator/followers","following_url":"https://api.github.com/users/dazinator/following{/other_user}","gists_url":"https://api.github.com/users/dazinator/gists{/gist_id}","starred_url":"https://api.github.com/users/dazinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazinator/subscriptions","organizations_url":"https://api.github.com/users/dazinator/orgs","repos_url":"https://api.github.com/users/dazinator/repos","events_url":"https://api.github.com/users/dazinator/events{/privacy}","received_events_url":"https://api.github.com/users/dazinator/received_events","type":"User","site_admin":false},"body":"This allows people to plug in their own HttpClient instance.\r\n\r\nThe main use case I can see is it will allow people to use ModernHttpClient if they want - which apparently performs better on devices.\r\n\r\nThere also appears to be a bug with the default HttpClient - in that it doesn't appear to honour the Android system proxy settings. Switching to ModernHttpClient fixes this issue: continuousit/seq-releases#348","created_at":"2015-10-26T16:56:30Z","updated_at":"2015-10-26T21:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2665e21732d1518e316e09f7646e849cb9051a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1/commits","review_comments_url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1/comments","review_comment_url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/continuousit/seq-client-portable/issues/1/comments","statuses_url":"https://api.github.com/repos/continuousit/seq-client-portable/statuses/1df07cdc5f407538383636779a799806ad2c5fb2","head":{"label":"ReachContact:httpclientfactory","ref":"httpclientfactory","sha":"1df07cdc5f407538383636779a799806ad2c5fb2","user":{"login":"ReachContact","id":12695215,"avatar_url":"https://avatars.githubusercontent.com/u/12695215?v=3","gravatar_id":"","url":"https://api.github.com/users/ReachContact","html_url":"https://github.com/ReachContact","followers_url":"https://api.github.com/users/ReachContact/followers","following_url":"https://api.github.com/users/ReachContact/following{/other_user}","gists_url":"https://api.github.com/users/ReachContact/gists{/gist_id}","starred_url":"https://api.github.com/users/ReachContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReachContact/subscriptions","organizations_url":"https://api.github.com/users/ReachContact/orgs","repos_url":"https://api.github.com/users/ReachContact/repos","events_url":"https://api.github.com/users/ReachContact/events{/privacy}","received_events_url":"https://api.github.com/users/ReachContact/received_events","type":"Organization","site_admin":false},"repo":{"id":44981815,"name":"seq-client-portable","full_name":"ReachContact/seq-client-portable","owner":{"login":"ReachContact","id":12695215,"avatar_url":"https://avatars.githubusercontent.com/u/12695215?v=3","gravatar_id":"","url":"https://api.github.com/users/ReachContact","html_url":"https://github.com/ReachContact","followers_url":"https://api.github.com/users/ReachContact/followers","following_url":"https://api.github.com/users/ReachContact/following{/other_user}","gists_url":"https://api.github.com/users/ReachContact/gists{/gist_id}","starred_url":"https://api.github.com/users/ReachContact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReachContact/subscriptions","organizations_url":"https://api.github.com/users/ReachContact/orgs","repos_url":"https://api.github.com/users/ReachContact/repos","events_url":"https://api.github.com/users/ReachContact/events{/privacy}","received_events_url":"https://api.github.com/users/ReachContact/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReachContact/seq-client-portable","description":"A portable (WP/iOS/Android) sink for Serilog that writes events over HTTP/S to Seq","fork":true,"url":"https://api.github.com/repos/ReachContact/seq-client-portable","forks_url":"https://api.github.com/repos/ReachContact/seq-client-portable/forks","keys_url":"https://api.github.com/repos/ReachContact/seq-client-portable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReachContact/seq-client-portable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReachContact/seq-client-portable/teams","hooks_url":"https://api.github.com/repos/ReachContact/seq-client-portable/hooks","issue_events_url":"https://api.github.com/repos/ReachContact/seq-client-portable/issues/events{/number}","events_url":"https://api.github.com/repos/ReachContact/seq-client-portable/events","assignees_url":"https://api.github.com/repos/ReachContact/seq-client-portable/assignees{/user}","branches_url":"https://api.github.com/repos/ReachContact/seq-client-portable/branches{/branch}","tags_url":"https://api.github.com/repos/ReachContact/seq-client-portable/tags","blobs_url":"https://api.github.com/repos/ReachContact/seq-client-portable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReachContact/seq-client-portable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReachContact/seq-client-portable/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReachContact/seq-client-portable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReachContact/seq-client-portable/statuses/{sha}","languages_url":"https://api.github.com/repos/ReachContact/seq-client-portable/languages","stargazers_url":"https://api.github.com/repos/ReachContact/seq-client-portable/stargazers","contributors_url":"https://api.github.com/repos/ReachContact/seq-client-portable/contributors","subscribers_url":"https://api.github.com/repos/ReachContact/seq-client-portable/subscribers","subscription_url":"https://api.github.com/repos/ReachContact/seq-client-portable/subscription","commits_url":"https://api.github.com/repos/ReachContact/seq-client-portable/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReachContact/seq-client-portable/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReachContact/seq-client-portable/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReachContact/seq-client-portable/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReachContact/seq-client-portable/contents/{+path}","compare_url":"https://api.github.com/repos/ReachContact/seq-client-portable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReachContact/seq-client-portable/merges","archive_url":"https://api.github.com/repos/ReachContact/seq-client-portable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReachContact/seq-client-portable/downloads","issues_url":"https://api.github.com/repos/ReachContact/seq-client-portable/issues{/number}","pulls_url":"https://api.github.com/repos/ReachContact/seq-client-portable/pulls{/number}","milestones_url":"https://api.github.com/repos/ReachContact/seq-client-portable/milestones{/number}","notifications_url":"https://api.github.com/repos/ReachContact/seq-client-portable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReachContact/seq-client-portable/labels{/name}","releases_url":"https://api.github.com/repos/ReachContact/seq-client-portable/releases{/id}","created_at":"2015-10-26T16:29:59Z","updated_at":"2015-10-26T16:30:00Z","pushed_at":"2015-10-26T16:52:11Z","git_url":"git://github.com/ReachContact/seq-client-portable.git","ssh_url":"git@github.com:ReachContact/seq-client-portable.git","clone_url":"https://github.com/ReachContact/seq-client-portable.git","svn_url":"https://github.com/ReachContact/seq-client-portable","homepage":"","size":97,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"continuousit:master","ref":"master","sha":"8201323a991f5475b126547af60df9f044622d7a","user":{"login":"continuousit","id":5898109,"avatar_url":"https://avatars.githubusercontent.com/u/5898109?v=3","gravatar_id":"","url":"https://api.github.com/users/continuousit","html_url":"https://github.com/continuousit","followers_url":"https://api.github.com/users/continuousit/followers","following_url":"https://api.github.com/users/continuousit/following{/other_user}","gists_url":"https://api.github.com/users/continuousit/gists{/gist_id}","starred_url":"https://api.github.com/users/continuousit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/continuousit/subscriptions","organizations_url":"https://api.github.com/users/continuousit/orgs","repos_url":"https://api.github.com/users/continuousit/repos","events_url":"https://api.github.com/users/continuousit/events{/privacy}","received_events_url":"https://api.github.com/users/continuousit/received_events","type":"Organization","site_admin":false},"repo":{"id":27811494,"name":"seq-client-portable","full_name":"continuousit/seq-client-portable","owner":{"login":"continuousit","id":5898109,"avatar_url":"https://avatars.githubusercontent.com/u/5898109?v=3","gravatar_id":"","url":"https://api.github.com/users/continuousit","html_url":"https://github.com/continuousit","followers_url":"https://api.github.com/users/continuousit/followers","following_url":"https://api.github.com/users/continuousit/following{/other_user}","gists_url":"https://api.github.com/users/continuousit/gists{/gist_id}","starred_url":"https://api.github.com/users/continuousit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/continuousit/subscriptions","organizations_url":"https://api.github.com/users/continuousit/orgs","repos_url":"https://api.github.com/users/continuousit/repos","events_url":"https://api.github.com/users/continuousit/events{/privacy}","received_events_url":"https://api.github.com/users/continuousit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/continuousit/seq-client-portable","description":"A portable (WP/iOS/Android) sink for Serilog that writes events over HTTP/S to Seq","fork":false,"url":"https://api.github.com/repos/continuousit/seq-client-portable","forks_url":"https://api.github.com/repos/continuousit/seq-client-portable/forks","keys_url":"https://api.github.com/repos/continuousit/seq-client-portable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/continuousit/seq-client-portable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/continuousit/seq-client-portable/teams","hooks_url":"https://api.github.com/repos/continuousit/seq-client-portable/hooks","issue_events_url":"https://api.github.com/repos/continuousit/seq-client-portable/issues/events{/number}","events_url":"https://api.github.com/repos/continuousit/seq-client-portable/events","assignees_url":"https://api.github.com/repos/continuousit/seq-client-portable/assignees{/user}","branches_url":"https://api.github.com/repos/continuousit/seq-client-portable/branches{/branch}","tags_url":"https://api.github.com/repos/continuousit/seq-client-portable/tags","blobs_url":"https://api.github.com/repos/continuousit/seq-client-portable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/continuousit/seq-client-portable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/continuousit/seq-client-portable/git/refs{/sha}","trees_url":"https://api.github.com/repos/continuousit/seq-client-portable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/continuousit/seq-client-portable/statuses/{sha}","languages_url":"https://api.github.com/repos/continuousit/seq-client-portable/languages","stargazers_url":"https://api.github.com/repos/continuousit/seq-client-portable/stargazers","contributors_url":"https://api.github.com/repos/continuousit/seq-client-portable/contributors","subscribers_url":"https://api.github.com/repos/continuousit/seq-client-portable/subscribers","subscription_url":"https://api.github.com/repos/continuousit/seq-client-portable/subscription","commits_url":"https://api.github.com/repos/continuousit/seq-client-portable/commits{/sha}","git_commits_url":"https://api.github.com/repos/continuousit/seq-client-portable/git/commits{/sha}","comments_url":"https://api.github.com/repos/continuousit/seq-client-portable/comments{/number}","issue_comment_url":"https://api.github.com/repos/continuousit/seq-client-portable/issues/comments{/number}","contents_url":"https://api.github.com/repos/continuousit/seq-client-portable/contents/{+path}","compare_url":"https://api.github.com/repos/continuousit/seq-client-portable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/continuousit/seq-client-portable/merges","archive_url":"https://api.github.com/repos/continuousit/seq-client-portable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/continuousit/seq-client-portable/downloads","issues_url":"https://api.github.com/repos/continuousit/seq-client-portable/issues{/number}","pulls_url":"https://api.github.com/repos/continuousit/seq-client-portable/pulls{/number}","milestones_url":"https://api.github.com/repos/continuousit/seq-client-portable/milestones{/number}","notifications_url":"https://api.github.com/repos/continuousit/seq-client-portable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/continuousit/seq-client-portable/labels{/name}","releases_url":"https://api.github.com/repos/continuousit/seq-client-portable/releases{/id}","created_at":"2014-12-10T09:16:56Z","updated_at":"2015-04-30T11:06:14Z","pushed_at":"2015-10-26T16:56:30Z","git_url":"git://github.com/continuousit/seq-client-portable.git","ssh_url":"git@github.com:continuousit/seq-client-portable.git","clone_url":"https://github.com/continuousit/seq-client-portable.git","svn_url":"https://github.com/continuousit/seq-client-portable","homepage":"","size":156,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1"},"html":{"href":"https://github.com/continuousit/seq-client-portable/pull/1"},"issue":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/issues/1"},"comments":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/continuousit/seq-client-portable/statuses/1df07cdc5f407538383636779a799806ad2c5fb2"}}}}