{"action":"closed","issue":{"url":"https://api.github.com/repos/atom/electron/issues/182","labels_url":"https://api.github.com/repos/atom/electron/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/atom/electron/issues/182/comments","events_url":"https://api.github.com/repos/atom/electron/issues/182/events","html_url":"https://github.com/atom/electron/issues/182","id":28389907,"number":182,"title":"Remove locks used by protocol module","user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"labels":[{"url":"https://api.github.com/repos/atom/electron/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/atom/electron/labels/protocol","name":"protocol","color":"f7c6c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2014-02-27T02:49:29Z","updated_at":"2015-07-10T04:16:17Z","closed_at":"2015-07-10T04:16:17Z","body":"The protocol module is calling networking related functions on the UI thread, and we had used locks to make sure no race condition happens. This is dangerous and error-prone (and had caused a crash), we would throw all networking jobs to the IO thread and get rid of the locks."}}