{"action":"created","issue":{"url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/2","labels_url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/2/comments","events_url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/2/events","html_url":"https://github.com/davidavdav/HClust.jl/pull/2","id":90488365,"number":2,"title":"Added unit tests","user":{"login":"slundberg","id":3740613,"avatar_url":"https://avatars.githubusercontent.com/u/3740613?v=3","gravatar_id":"","url":"https://api.github.com/users/slundberg","html_url":"https://github.com/slundberg","followers_url":"https://api.github.com/users/slundberg/followers","following_url":"https://api.github.com/users/slundberg/following{/other_user}","gists_url":"https://api.github.com/users/slundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/slundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slundberg/subscriptions","organizations_url":"https://api.github.com/users/slundberg/orgs","repos_url":"https://api.github.com/users/slundberg/repos","events_url":"https://api.github.com/users/slundberg/events{/privacy}","received_events_url":"https://api.github.com/users/slundberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-23T20:53:16Z","updated_at":"2015-06-29T21:44:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davidavdav/HClust.jl/pulls/2","html_url":"https://github.com/davidavdav/HClust.jl/pull/2","diff_url":"https://github.com/davidavdav/HClust.jl/pull/2.diff","patch_url":"https://github.com/davidavdav/HClust.jl/pull/2.patch"},"body":"I noticed that hclust() on a 3x3 matrix failed intermittently, so I added some unit tests that checked everything >= 4x4. These tests run the methods against R output for :complete, :average, and :single, and also use a default Julia TravisCI setup.\r\n\r\nI also added an `@assert` for small matrices, if failing on small matrices is not intended that needs to be removed once the code is updated."},"comment":{"url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/comments/116856447","html_url":"https://github.com/davidavdav/HClust.jl/pull/2#issuecomment-116856447","issue_url":"https://api.github.com/repos/davidavdav/HClust.jl/issues/2","id":116856447,"user":{"login":"slundberg","id":3740613,"avatar_url":"https://avatars.githubusercontent.com/u/3740613?v=3","gravatar_id":"","url":"https://api.github.com/users/slundberg","html_url":"https://github.com/slundberg","followers_url":"https://api.github.com/users/slundberg/followers","following_url":"https://api.github.com/users/slundberg/following{/other_user}","gists_url":"https://api.github.com/users/slundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/slundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slundberg/subscriptions","organizations_url":"https://api.github.com/users/slundberg/orgs","repos_url":"https://api.github.com/users/slundberg/repos","events_url":"https://api.github.com/users/slundberg/events{/privacy}","received_events_url":"https://api.github.com/users/slundberg/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T21:44:30Z","updated_at":"2015-06-29T21:44:30Z","body":"I noticed that you got HClust merged into Clustering, and also saw that merge had some unit test related files. What do you think I should do with this? I think it is important to have unit tests that can be run by travis, and also add this assert. Perhaps I should do a PR on Clustering?"}}