{"action":"closed","issue":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/5","labels_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/5/comments","events_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/5/events","html_url":"https://github.com/wrye-bash/wrye-bash/issues/5","id":27127137,"number":5,"title":"Abstract base classes should have docs and raise Abstract errors & other patchers TODOs","user":{"login":"Utumno","id":1365079,"avatar_url":"https://avatars.githubusercontent.com/u/1365079?v=3","gravatar_id":"","url":"https://api.github.com/users/Utumno","html_url":"https://github.com/Utumno","followers_url":"https://api.github.com/users/Utumno/followers","following_url":"https://api.github.com/users/Utumno/following{/other_user}","gists_url":"https://api.github.com/users/Utumno/gists{/gist_id}","starred_url":"https://api.github.com/users/Utumno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utumno/subscriptions","organizations_url":"https://api.github.com/users/Utumno/orgs","repos_url":"https://api.github.com/users/Utumno/repos","events_url":"https://api.github.com/users/Utumno/events{/privacy}","received_events_url":"https://api.github.com/users/Utumno/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/labels/backburner","name":"backburner","color":"d4c5f9"},{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/labels/TODO","name":"TODO","color":"0099f5"}],"state":"closed","locked":false,"assignee":{"login":"Utumno","id":1365079,"avatar_url":"https://avatars.githubusercontent.com/u/1365079?v=3","gravatar_id":"","url":"https://api.github.com/users/Utumno","html_url":"https://github.com/Utumno","followers_url":"https://api.github.com/users/Utumno/followers","following_url":"https://api.github.com/users/Utumno/following{/other_user}","gists_url":"https://api.github.com/users/Utumno/gists{/gist_id}","starred_url":"https://api.github.com/users/Utumno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utumno/subscriptions","organizations_url":"https://api.github.com/users/Utumno/orgs","repos_url":"https://api.github.com/users/Utumno/repos","events_url":"https://api.github.com/users/Utumno/events{/privacy}","received_events_url":"https://api.github.com/users/Utumno/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/milestones/11","labels_url":"https://api.github.com/repos/wrye-bash/wrye-bash/milestones/11/labels","id":735584,"number":11,"title":"308","description":null,"creator":{"login":"Utumno","id":1365079,"avatar_url":"https://avatars.githubusercontent.com/u/1365079?v=3","gravatar_id":"","url":"https://api.github.com/users/Utumno","html_url":"https://github.com/Utumno","followers_url":"https://api.github.com/users/Utumno/followers","following_url":"https://api.github.com/users/Utumno/following{/other_user}","gists_url":"https://api.github.com/users/Utumno/gists{/gist_id}","starred_url":"https://api.github.com/users/Utumno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utumno/subscriptions","organizations_url":"https://api.github.com/users/Utumno/orgs","repos_url":"https://api.github.com/users/Utumno/repos","events_url":"https://api.github.com/users/Utumno/events{/privacy}","received_events_url":"https://api.github.com/users/Utumno/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2014-07-29T13:26:14Z","updated_at":"2015-01-16T23:04:15Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2014-02-07T10:58:14Z","updated_at":"2015-01-16T23:04:15Z","closed_at":"2015-01-16T23:04:15Z","body":"See:\r\n- https://github.com/wrye-bash/wrye-bash/commit/9c73530eb2bedf25f2ff4967a71b8e0d20664fd9: Abstract base classes should have docs and raise Abstract errors - ofc AbstractError serves as docs. Especially the Abstract_Patcher and Patcher/CBash_Patcher should have extensive docs and be sure they raise the error if their methods are meant to be overridden. I have some TODOs there for easy search\r\n- https://github.com/wrye-bash/wrye-bash/commit/cc656f439b807c22409fa7ba8cbc459a81b6da58 (\"\"\"docs - what's this about ?\"\"\" # TODO)\r\n- https://github.com/wrye-bash/wrye-bash/commit/730eff02c9af16f1c88443d25b2cef89b39993ee (why if record.flags.notPlayable: return False ?)\r\n- https://github.com/wrye-bash/wrye-bash/commit/3e8abf35403e507333bbc31ca6c4c95115cd6370 (TODO: is this suposed to be used ?)\r\n- https://github.com/wrye-bash/wrye-bash/commit/03b702c3440a6abe438503824e08f43bef316dc7 (TODO : translate ?)\r\n- https://github.com/wrye-bash/wrye-bash/commit/4c21c3e518389c876732b7bd7b031927d74c4e19 (TODO: move up ? down ?)\r\n- https://github.com/wrye-bash/wrye-bash/commit/cd389f37e793f71a197ee0048920b748b09276df (TODO:weight)\r\n- https://github.com/wrye-bash/wrye-bash/commit/dbff21087ec326330f06a682bbadb664bf3fdf55\r\n- https://github.com/wrye-bash/wrye-bash/commit/b717214b862cd77bda3ec9c157f1e2527a9d9db2\r\n"}}