{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/639","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/639/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/639/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/639/events","html_url":"https://github.com/catapult-project/catapult/issues/639","id":98581117,"number":639,"title":"Group/sort netlog async slices by category instead of title","user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-02T03:18:31Z","updated_at":"2015-08-02T03:18:57Z","closed_at":"2015-08-02T03:18:36Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [natduca](https://github.com/natduca)**\n_Tuesday Oct 21, 2014 at 01:44 GMT_\n_Originally opened as https://github.com/google/trace-viewer/issues/639_\n\n----\n\nWe want netlog slices to get put together in one group instead of several. To do this, I want to make thread_track use asyncSliceGroup.viewGroups instead of the existing titleGroups.\r\n\r\nViewGroups would be created by asking each async slice for its property \"viewGroupTitle\", which in the base AsyncSlice class is just a property that returns the async slice's title.\r\n\r\nThen, we take the ObjectInstance and ObjectSnapshot.register functions and make a AsyncSlice.register so that custom async slice subclasses can be registered.\r\n\r\nFinally, we make a net/net_slice.html that registers AsyncNetSlice that overrides viewGroupTitle property.\r\n\r\nThis may seem verbose but it lays down good infrastructure for other stuff we've needed to build out for a while, now.\n"},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/126985037","html_url":"https://github.com/catapult-project/catapult/issues/639#issuecomment-126985037","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/639","id":126985037,"user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"created_at":"2015-08-02T03:18:57Z","updated_at":"2015-08-02T03:18:57Z","body":"<a href=\"https://github.com/xunjieli\"><img src=\"https://avatars.githubusercontent.com/u/1412855?v=3\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [xunjieli](https://github.com/xunjieli)**\n_Tuesday Oct 21, 2014 at 12:43 GMT_\n\n----\n\nThanks for the fix! #640 is due to a bug in my code. I will work on it now. \n"}}