{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11468","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11468/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11468/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11468/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11468","id":59954550,"number":11468,"title":"Add support for musical instruments (scale off perception)","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-05T13:56:32Z","updated_at":"2015-03-05T15:45:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11468","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11468","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11468.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11468.patch"},"body":"Support for modable instruments.\r\n\r\nInstruments are active items that produce sound and morale effect. This morale effect maxes out at (configurable) `fun + fun_bonus * player->per_cur`. Perception, because it's a bad stat, no other stat/skill makes sense here (plus grinding skills just by playing music would be horrid design) and because musical skill has a lot to do with hearing.\r\n\r\nAt low morale this can be a penalty - this is handled too.\r\n\r\nInstruments consume some move points, so that they aren't totally free to use. If the player is too slow to play the instrument, it \"turns off\" to prevent players getting soft-locked and starving to death. They also turn off when the player goes to sleep, gets under water or drops the item.\r\n\r\nConfigurable stats are: sound volume, moves_cost, fun, fun_bonus, description_frequency and descriptions. Descriptions are strings that will be randomly picked from to describe the sound. description_frequency is the number of turns to wait between printing descriptions.\r\n\r\nInstruments need to be wielded or worn to be played.\r\n\r\nI added only one instrument (mostly for testing): harmonica with holder.\r\n\r\nI had to add charges to the instrument, because otherwise it would disappear as soon as it got processed. Any better solution that doesn't involve having `(1)` in item name?"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/77387280","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11468#issuecomment-77387280","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11468","id":77387280,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T15:45:15Z","updated_at":"2015-03-05T15:45:15Z","body":"Would effects be suited to adding slowdown? I'd add a \"occupied\" effect every turn with duration 1 or 2 and intensity dependent on some parameter. It would reduce speed based on intensity."}}