{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/5823","labels_url":"https://api.github.com/repos/odoo/odoo/issues/5823/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/5823/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/5823/events","html_url":"https://github.com/odoo/odoo/pull/5823","id":62713431,"number":5823,"title":"[FIX] email_template: remove the button to save email as new template","user":{"login":"nim-odoo","id":11041725,"avatar_url":"https://avatars.githubusercontent.com/u/11041725?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-odoo","html_url":"https://github.com/nim-odoo","followers_url":"https://api.github.com/users/nim-odoo/followers","following_url":"https://api.github.com/users/nim-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nim-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-odoo/subscriptions","organizations_url":"https://api.github.com/users/nim-odoo/orgs","repos_url":"https://api.github.com/users/nim-odoo/repos","events_url":"https://api.github.com/users/nim-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nim-odoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dmo-odoo","id":8427726,"avatar_url":"https://avatars.githubusercontent.com/u/8427726?v=3","gravatar_id":"","url":"https://api.github.com/users/dmo-odoo","html_url":"https://github.com/dmo-odoo","followers_url":"https://api.github.com/users/dmo-odoo/followers","following_url":"https://api.github.com/users/dmo-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dmo-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dmo-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmo-odoo/subscriptions","organizations_url":"https://api.github.com/users/dmo-odoo/orgs","repos_url":"https://api.github.com/users/dmo-odoo/repos","events_url":"https://api.github.com/users/dmo-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dmo-odoo/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-03-18T14:53:26Z","updated_at":"2015-03-27T13:39:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/5823","html_url":"https://github.com/odoo/odoo/pull/5823","diff_url":"https://github.com/odoo/odoo/pull/5823.diff","patch_url":"https://github.com/odoo/odoo/pull/5823.patch"},"body":"The template saved with this method contains the rendered content. This is a security issue,\r\nsince it contains for example the registration links of the customer. The commit only removes the\r\nbutton, since the method is used for the Survey module as of Odoo 8.0.\r\n\r\nopw: 630553"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/86942836","html_url":"https://github.com/odoo/odoo/pull/5823#issuecomment-86942836","issue_url":"https://api.github.com/repos/odoo/odoo/issues/5823","id":86942836,"user":{"login":"sve-odoo","id":7520862,"avatar_url":"https://avatars.githubusercontent.com/u/7520862?v=3","gravatar_id":"","url":"https://api.github.com/users/sve-odoo","html_url":"https://github.com/sve-odoo","followers_url":"https://api.github.com/users/sve-odoo/followers","following_url":"https://api.github.com/users/sve-odoo/following{/other_user}","gists_url":"https://api.github.com/users/sve-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sve-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sve-odoo/subscriptions","organizations_url":"https://api.github.com/users/sve-odoo/orgs","repos_url":"https://api.github.com/users/sve-odoo/repos","events_url":"https://api.github.com/users/sve-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/sve-odoo/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T13:39:56Z","updated_at":"2015-03-27T13:39:56Z","body":"This PR is exactly what I expected, as this will simply remove the current security risk.\r\n\r\nDisplaying the raw template would make sense but would be less user-friendly because:\r\n- The end-user shouldn't see code\r\n- The end-user should be able to edit anything in the mail before sending it.\r\n- The end-user should have an overview as accurate as possible of what the recipient will see.\r\n\r\nThank you for your work and your input."}}