{"action":"created","comment":{"url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/comments/36645823","id":36645823,"diff_hunk":"@@ -44,10 +44,11 @@ angular.module( 'oscmodulatorApp' ).directive 'dropdownList', ->\n \n     $scope.$watchCollection 'items', (newValue) ->\n       found = false\n-      for item in $scope.items\n-        if item.name == $scope.selectedItem.name\n-          found = true\n-          break\n+      if $scope.items\n+        for item in $scope.items\n+          if item.name == $scope.selectedItem.name\n+            found = true\n+            break","path":"app/scripts/directives/dropdown-list.coffee","position":12,"original_position":12,"commit_id":"fec722296aab6326763a85df1199522c442dbb20","original_commit_id":"fec722296aab6326763a85df1199522c442dbb20","user":{"login":"dansomething","id":92310,"avatar_url":"https://avatars.githubusercontent.com/u/92310?v=3","gravatar_id":"","url":"https://api.github.com/users/dansomething","html_url":"https://github.com/dansomething","followers_url":"https://api.github.com/users/dansomething/followers","following_url":"https://api.github.com/users/dansomething/following{/other_user}","gists_url":"https://api.github.com/users/dansomething/gists{/gist_id}","starred_url":"https://api.github.com/users/dansomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansomething/subscriptions","organizations_url":"https://api.github.com/users/dansomething/orgs","repos_url":"https://api.github.com/users/dansomething/repos","events_url":"https://api.github.com/users/dansomething/events{/privacy}","received_events_url":"https://api.github.com/users/dansomething/received_events","type":"User","site_admin":false},"body":"or just\r\n\r\n```\r\nfor item in $scope?.items\r\n```","created_at":"2015-08-10T15:40:15Z","updated_at":"2015-08-10T15:40:15Z","html_url":"https://github.com/OSCModulator/oscmodulator/pull/67#discussion_r36645823","pull_request_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/comments/36645823"},"html":{"href":"https://github.com/OSCModulator/oscmodulator/pull/67#discussion_r36645823"},"pull_request":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67","id":41974369,"html_url":"https://github.com/OSCModulator/oscmodulator/pull/67","diff_url":"https://github.com/OSCModulator/oscmodulator/pull/67.diff","patch_url":"https://github.com/OSCModulator/oscmodulator/pull/67.patch","issue_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/67","number":67,"state":"open","locked":false,"title":"Send Midi out (take 2)","user":{"login":"soulfresh","id":3633031,"avatar_url":"https://avatars.githubusercontent.com/u/3633031?v=3","gravatar_id":"","url":"https://api.github.com/users/soulfresh","html_url":"https://github.com/soulfresh","followers_url":"https://api.github.com/users/soulfresh/followers","following_url":"https://api.github.com/users/soulfresh/following{/other_user}","gists_url":"https://api.github.com/users/soulfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/soulfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulfresh/subscriptions","organizations_url":"https://api.github.com/users/soulfresh/orgs","repos_url":"https://api.github.com/users/soulfresh/repos","events_url":"https://api.github.com/users/soulfresh/events{/privacy}","received_events_url":"https://api.github.com/users/soulfresh/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to send midi as an output format. Ignore my last PR because I compared it to the wrong branch. This version should be a little lighter.\r\n\r\nThis is going to be a pretty giant PR unfortunately because I had to do some major refactoring in order to accomplish this. I don't actually expect you to go through this PR on your own unless you want to. We could either do a review together at lunch sometime or we could do some pairing sessions over lunch (if you have time for either of those).\r\n\r\nThe major changes in this PR are:\r\n\r\n1. Broke apart the input/output functionality from the midi/osc functionality (they used to be combined as midi-input and osc-output). Input and output directives are now unaware of the type of message format they deal with. The midi and osc directives are generic enough to be used as either inputs or outputs. \r\n\r\n2. The APIs for `MessageMiddleware` and `InputList` were changed to be more generic. Originally we wanted the API between `InputList` and `MessageMiddleware` to be very specific with calls like `createMidiInput` and `updateOSCOutput`. However, this was going to make these APIs very verbose and adding new message formats would require changes in a lot of places. Instead of this, I've made the APIs generic enough that you always call methods like `createInput` and `updateOutput` and you pass a type parameter and configuration object. This way adding a new message format requires setting up the directive and then creating methods for handling that format inside of `MessageMiddleware` (ie. no more adding methods to the `InputList` and `MessageMiddleware` APIs.\r\n\r\n3. Removed Protractor tests. These were just too much of a headache to maintain and debug so I've moved to integration testing with Jasmine.\r\n\r\nPhew...that's a lot of stuff. I'll add line notes for more detailed info.","created_at":"2015-08-09T18:07:05Z","updated_at":"2015-08-10T15:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"320d1a7ca6c08d7ce817f1c215c374b8214a526f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67/commits","review_comments_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67/comments","review_comment_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/67/comments","statuses_url":"https://api.github.com/repos/OSCModulator/oscmodulator/statuses/fec722296aab6326763a85df1199522c442dbb20","head":{"label":"OSCModulator:feature/outputs-can-send-midi","ref":"feature/outputs-can-send-midi","sha":"fec722296aab6326763a85df1199522c442dbb20","user":{"login":"OSCModulator","id":3834508,"avatar_url":"https://avatars.githubusercontent.com/u/3834508?v=3","gravatar_id":"","url":"https://api.github.com/users/OSCModulator","html_url":"https://github.com/OSCModulator","followers_url":"https://api.github.com/users/OSCModulator/followers","following_url":"https://api.github.com/users/OSCModulator/following{/other_user}","gists_url":"https://api.github.com/users/OSCModulator/gists{/gist_id}","starred_url":"https://api.github.com/users/OSCModulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSCModulator/subscriptions","organizations_url":"https://api.github.com/users/OSCModulator/orgs","repos_url":"https://api.github.com/users/OSCModulator/repos","events_url":"https://api.github.com/users/OSCModulator/events{/privacy}","received_events_url":"https://api.github.com/users/OSCModulator/received_events","type":"Organization","site_admin":false},"repo":{"id":8709893,"name":"oscmodulator","full_name":"OSCModulator/oscmodulator","owner":{"login":"OSCModulator","id":3834508,"avatar_url":"https://avatars.githubusercontent.com/u/3834508?v=3","gravatar_id":"","url":"https://api.github.com/users/OSCModulator","html_url":"https://github.com/OSCModulator","followers_url":"https://api.github.com/users/OSCModulator/followers","following_url":"https://api.github.com/users/OSCModulator/following{/other_user}","gists_url":"https://api.github.com/users/OSCModulator/gists{/gist_id}","starred_url":"https://api.github.com/users/OSCModulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSCModulator/subscriptions","organizations_url":"https://api.github.com/users/OSCModulator/orgs","repos_url":"https://api.github.com/users/OSCModulator/repos","events_url":"https://api.github.com/users/OSCModulator/events{/privacy}","received_events_url":"https://api.github.com/users/OSCModulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSCModulator/oscmodulator","description":"Modulate Anything!","fork":false,"url":"https://api.github.com/repos/OSCModulator/oscmodulator","forks_url":"https://api.github.com/repos/OSCModulator/oscmodulator/forks","keys_url":"https://api.github.com/repos/OSCModulator/oscmodulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSCModulator/oscmodulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSCModulator/oscmodulator/teams","hooks_url":"https://api.github.com/repos/OSCModulator/oscmodulator/hooks","issue_events_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/events{/number}","events_url":"https://api.github.com/repos/OSCModulator/oscmodulator/events","assignees_url":"https://api.github.com/repos/OSCModulator/oscmodulator/assignees{/user}","branches_url":"https://api.github.com/repos/OSCModulator/oscmodulator/branches{/branch}","tags_url":"https://api.github.com/repos/OSCModulator/oscmodulator/tags","blobs_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSCModulator/oscmodulator/statuses/{sha}","languages_url":"https://api.github.com/repos/OSCModulator/oscmodulator/languages","stargazers_url":"https://api.github.com/repos/OSCModulator/oscmodulator/stargazers","contributors_url":"https://api.github.com/repos/OSCModulator/oscmodulator/contributors","subscribers_url":"https://api.github.com/repos/OSCModulator/oscmodulator/subscribers","subscription_url":"https://api.github.com/repos/OSCModulator/oscmodulator/subscription","commits_url":"https://api.github.com/repos/OSCModulator/oscmodulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSCModulator/oscmodulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSCModulator/oscmodulator/contents/{+path}","compare_url":"https://api.github.com/repos/OSCModulator/oscmodulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSCModulator/oscmodulator/merges","archive_url":"https://api.github.com/repos/OSCModulator/oscmodulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSCModulator/oscmodulator/downloads","issues_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues{/number}","pulls_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls{/number}","milestones_url":"https://api.github.com/repos/OSCModulator/oscmodulator/milestones{/number}","notifications_url":"https://api.github.com/repos/OSCModulator/oscmodulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSCModulator/oscmodulator/labels{/name}","releases_url":"https://api.github.com/repos/OSCModulator/oscmodulator/releases{/id}","created_at":"2013-03-11T18:13:02Z","updated_at":"2015-06-03T17:52:59Z","pushed_at":"2015-08-09T18:07:05Z","git_url":"git://github.com/OSCModulator/oscmodulator.git","ssh_url":"git@github.com:OSCModulator/oscmodulator.git","clone_url":"https://github.com/OSCModulator/oscmodulator.git","svn_url":"https://github.com/OSCModulator/oscmodulator","homepage":null,"size":112896,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":4,"default_branch":"develop"}},"base":{"label":"OSCModulator:feature/midi-output","ref":"feature/midi-output","sha":"78c1d2f85ae7e39bb562c80e0bb805f78993313c","user":{"login":"OSCModulator","id":3834508,"avatar_url":"https://avatars.githubusercontent.com/u/3834508?v=3","gravatar_id":"","url":"https://api.github.com/users/OSCModulator","html_url":"https://github.com/OSCModulator","followers_url":"https://api.github.com/users/OSCModulator/followers","following_url":"https://api.github.com/users/OSCModulator/following{/other_user}","gists_url":"https://api.github.com/users/OSCModulator/gists{/gist_id}","starred_url":"https://api.github.com/users/OSCModulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSCModulator/subscriptions","organizations_url":"https://api.github.com/users/OSCModulator/orgs","repos_url":"https://api.github.com/users/OSCModulator/repos","events_url":"https://api.github.com/users/OSCModulator/events{/privacy}","received_events_url":"https://api.github.com/users/OSCModulator/received_events","type":"Organization","site_admin":false},"repo":{"id":8709893,"name":"oscmodulator","full_name":"OSCModulator/oscmodulator","owner":{"login":"OSCModulator","id":3834508,"avatar_url":"https://avatars.githubusercontent.com/u/3834508?v=3","gravatar_id":"","url":"https://api.github.com/users/OSCModulator","html_url":"https://github.com/OSCModulator","followers_url":"https://api.github.com/users/OSCModulator/followers","following_url":"https://api.github.com/users/OSCModulator/following{/other_user}","gists_url":"https://api.github.com/users/OSCModulator/gists{/gist_id}","starred_url":"https://api.github.com/users/OSCModulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSCModulator/subscriptions","organizations_url":"https://api.github.com/users/OSCModulator/orgs","repos_url":"https://api.github.com/users/OSCModulator/repos","events_url":"https://api.github.com/users/OSCModulator/events{/privacy}","received_events_url":"https://api.github.com/users/OSCModulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSCModulator/oscmodulator","description":"Modulate Anything!","fork":false,"url":"https://api.github.com/repos/OSCModulator/oscmodulator","forks_url":"https://api.github.com/repos/OSCModulator/oscmodulator/forks","keys_url":"https://api.github.com/repos/OSCModulator/oscmodulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSCModulator/oscmodulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSCModulator/oscmodulator/teams","hooks_url":"https://api.github.com/repos/OSCModulator/oscmodulator/hooks","issue_events_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/events{/number}","events_url":"https://api.github.com/repos/OSCModulator/oscmodulator/events","assignees_url":"https://api.github.com/repos/OSCModulator/oscmodulator/assignees{/user}","branches_url":"https://api.github.com/repos/OSCModulator/oscmodulator/branches{/branch}","tags_url":"https://api.github.com/repos/OSCModulator/oscmodulator/tags","blobs_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSCModulator/oscmodulator/statuses/{sha}","languages_url":"https://api.github.com/repos/OSCModulator/oscmodulator/languages","stargazers_url":"https://api.github.com/repos/OSCModulator/oscmodulator/stargazers","contributors_url":"https://api.github.com/repos/OSCModulator/oscmodulator/contributors","subscribers_url":"https://api.github.com/repos/OSCModulator/oscmodulator/subscribers","subscription_url":"https://api.github.com/repos/OSCModulator/oscmodulator/subscription","commits_url":"https://api.github.com/repos/OSCModulator/oscmodulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSCModulator/oscmodulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSCModulator/oscmodulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSCModulator/oscmodulator/contents/{+path}","compare_url":"https://api.github.com/repos/OSCModulator/oscmodulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSCModulator/oscmodulator/merges","archive_url":"https://api.github.com/repos/OSCModulator/oscmodulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSCModulator/oscmodulator/downloads","issues_url":"https://api.github.com/repos/OSCModulator/oscmodulator/issues{/number}","pulls_url":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls{/number}","milestones_url":"https://api.github.com/repos/OSCModulator/oscmodulator/milestones{/number}","notifications_url":"https://api.github.com/repos/OSCModulator/oscmodulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSCModulator/oscmodulator/labels{/name}","releases_url":"https://api.github.com/repos/OSCModulator/oscmodulator/releases{/id}","created_at":"2013-03-11T18:13:02Z","updated_at":"2015-06-03T17:52:59Z","pushed_at":"2015-08-09T18:07:05Z","git_url":"git://github.com/OSCModulator/oscmodulator.git","ssh_url":"git@github.com:OSCModulator/oscmodulator.git","clone_url":"https://github.com/OSCModulator/oscmodulator.git","svn_url":"https://github.com/OSCModulator/oscmodulator","homepage":null,"size":112896,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67"},"html":{"href":"https://github.com/OSCModulator/oscmodulator/pull/67"},"issue":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/67"},"comments":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/OSCModulator/oscmodulator/statuses/fec722296aab6326763a85df1199522c442dbb20"}}}}