{"action":"closed","number":388,"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388","id":46775923,"html_url":"https://github.com/hawkular/hawkular-metrics/pull/388","diff_url":"https://github.com/hawkular/hawkular-metrics/pull/388.diff","patch_url":"https://github.com/hawkular/hawkular-metrics/pull/388.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/388","number":388,"state":"closed","locked":false,"title":"Change percentile95th -> percentile and add percentile query parameter","user":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"body":"This allows requesting different percentile than 95th to be calculated when requesting buckets. The REST API changes from `percentile95th` -> `percentile` parameter and the new query parameter is called `percentile` (with a default value of 95.00 for old use-cases).\r\n\r\nThis is necessary for the Initial Resources implementation (it needs configurable percentile), although I'd almost want to see following:\r\n\r\n`?buckets=1&percentiles=90,99,99.9` returning:\r\n\r\n```javascript\r\n\"percentiles\": {\r\n  \"90\": 0.0\r\n  \"99\": 0.0\r\n  \"99.9\": 0.0\r\n}\r\n```","created_at":"2015-10-05T12:45:13Z","updated_at":"2015-10-08T02:30:21Z","closed_at":"2015-10-08T02:30:21Z","merged_at":"2015-10-08T02:30:21Z","merge_commit_sha":"0ee3a7c39f4e36135db23853d12be5c31930790f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/388/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/ab342a009470b03cc57eabf6eb8517d9b05f4dd3","head":{"label":"burmanm:hwkmetrics-296","ref":"hwkmetrics-296","sha":"ab342a009470b03cc57eabf6eb8517d9b05f4dd3","user":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"repo":{"id":30840822,"name":"hawkular-metrics","full_name":"burmanm/hawkular-metrics","owner":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burmanm/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":true,"url":"https://api.github.com/repos/burmanm/hawkular-metrics","forks_url":"https://api.github.com/repos/burmanm/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/burmanm/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burmanm/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burmanm/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/burmanm/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/burmanm/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/burmanm/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/burmanm/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/burmanm/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/burmanm/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/burmanm/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burmanm/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burmanm/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/burmanm/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burmanm/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/burmanm/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/burmanm/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/burmanm/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/burmanm/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/burmanm/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/burmanm/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/burmanm/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/burmanm/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/burmanm/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/burmanm/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/burmanm/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burmanm/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/burmanm/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burmanm/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/burmanm/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/burmanm/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/burmanm/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/burmanm/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burmanm/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/burmanm/hawkular-metrics/releases{/id}","created_at":"2015-02-15T20:26:56Z","updated_at":"2015-05-06T07:02:24Z","pushed_at":"2015-10-07T12:21:17Z","git_url":"git://github.com/burmanm/hawkular-metrics.git","ssh_url":"git@github.com:burmanm/hawkular-metrics.git","clone_url":"https://github.com/burmanm/hawkular-metrics.git","svn_url":"https://github.com/burmanm/hawkular-metrics","homepage":"","size":12764,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"262e3481d4f67829b52238faded7575ac9f4f6af","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":17705626,"name":"hawkular-metrics","full_name":"hawkular/hawkular-metrics","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-metrics","forks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-metrics/releases{/id}","created_at":"2014-03-13T10:07:30Z","updated_at":"2015-10-06T22:02:51Z","pushed_at":"2015-10-08T02:30:21Z","git_url":"git://github.com/hawkular/hawkular-metrics.git","ssh_url":"git@github.com:hawkular/hawkular-metrics.git","clone_url":"https://github.com/hawkular/hawkular-metrics.git","svn_url":"https://github.com/hawkular/hawkular-metrics","homepage":"","size":19685,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":14,"forks":35,"open_issues":14,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/388"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/388"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/ab342a009470b03cc57eabf6eb8517d9b05f4dd3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jsanda","id":168121,"avatar_url":"https://avatars.githubusercontent.com/u/168121?v=3","gravatar_id":"","url":"https://api.github.com/users/jsanda","html_url":"https://github.com/jsanda","followers_url":"https://api.github.com/users/jsanda/followers","following_url":"https://api.github.com/users/jsanda/following{/other_user}","gists_url":"https://api.github.com/users/jsanda/gists{/gist_id}","starred_url":"https://api.github.com/users/jsanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsanda/subscriptions","organizations_url":"https://api.github.com/users/jsanda/orgs","repos_url":"https://api.github.com/users/jsanda/repos","events_url":"https://api.github.com/users/jsanda/events{/privacy}","received_events_url":"https://api.github.com/users/jsanda/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":449,"deletions":82,"changed_files":19}}