{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/plottable/issues/2579","labels_url":"https://api.github.com/repos/palantir/plottable/issues/2579/labels{/name}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/2579/comments","events_url":"https://api.github.com/repos/palantir/plottable/issues/2579/events","html_url":"https://github.com/palantir/plottable/pull/2579","id":99706869,"number":2579,"title":"Fixed General and siSuffix formatters precision ","user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-07T18:50:33Z","updated_at":"2015-08-07T18:55:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/2579","html_url":"https://github.com/palantir/plottable/pull/2579","diff_url":"https://github.com/palantir/plottable/pull/2579.diff","patch_url":"https://github.com/palantir/plottable/pull/2579.patch"},"body":"Closes #2527\r\n\r\nPreviously setting a non-integer precision to `Formatters.general` or `Formatters.siSuffix` was silently failing. Now it is silently truncating the value.\r\n\r\nThe reason this PR exists is because the behavior was inconsistent across formatters, in particular, the `Formatters.fixed` was truncating the precision behind the scenes. \r\n"},"comment":{"url":"https://api.github.com/repos/palantir/plottable/issues/comments/128794927","html_url":"https://github.com/palantir/plottable/pull/2579#issuecomment-128794927","issue_url":"https://api.github.com/repos/palantir/plottable/issues/2579","id":128794927,"user":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T18:55:33Z","updated_at":"2015-08-07T18:55:33Z","body":"Related to the topic of input sanitization and verification, I remember that the stance we took ultimately is to error if the user were to put in a bad input.  Do we want to take that stance here (would require a change on all the formatters)?  Or do we want to just seek consistency here?"}}