{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/NativeScript/issues/445","labels_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/445/comments","events_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/445/events","html_url":"https://github.com/NativeScript/NativeScript/pull/445","id":95309791,"number":445,"title":"Implemented native layouts for android","user":{"login":"hshristov","id":5966717,"avatar_url":"https://avatars.githubusercontent.com/u/5966717?v=3","gravatar_id":"","url":"https://api.github.com/users/hshristov","html_url":"https://github.com/hshristov","followers_url":"https://api.github.com/users/hshristov/followers","following_url":"https://api.github.com/users/hshristov/following{/other_user}","gists_url":"https://api.github.com/users/hshristov/gists{/gist_id}","starred_url":"https://api.github.com/users/hshristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshristov/subscriptions","organizations_url":"https://api.github.com/users/hshristov/orgs","repos_url":"https://api.github.com/users/hshristov/repos","events_url":"https://api.github.com/users/hshristov/events{/privacy}","received_events_url":"https://api.github.com/users/hshristov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NativeScript/NativeScript/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-07-15T23:13:11Z","updated_at":"2015-08-04T06:03:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/445","html_url":"https://github.com/NativeScript/NativeScript/pull/445","diff_url":"https://github.com/NativeScript/NativeScript/pull/445.diff","patch_url":"https://github.com/NativeScript/NativeScript/pull/445.patch"},"body":"content-view: Added comments on methods that won't be called anymore in android\r\n\r\nview.d.ts - removed all padding properties. They were not supposed to be exposed on View. The are implemented only on LayoutBase\r\n\r\nview-common:\r\n - removed paddings\r\n - fixed getMeasureWidth and getMeasuredHeight to return only size component\r\n \r\nview.android - CustomLayoutView default native view is now org.nativescript.widgets.ContentView (it was JS NativeViewGroup)\r\n\r\nview.ios - added small layout optimization\r\n\r\nframe.android - default native view is now org.nativescript.widgets.ContentView (it was JS NativeViewGroup)\r\n\r\nimage.android - default native view is now org.nativescript.widgets.ImageView (it was JS NativeViewGroup)\r\n\r\nAll layout classes:\r\n - changed base class from Layout to LayoutBase (Layout should be used if we want to implement cross-platform layouts in JavaScript)\r\n - code refactoring\r\n - splitted into three files\r\n - on android we use widgets from org.nativescript.widgets jar\r\n - measure and arrange logic moved into ios files\r\n - wrap-layout: itemWidth and itemHeight default value changed to 0 (was Number.NaN). Zero is now considered auto instead of Number.NaN\r\n\r\n scroll-view.android - both scrollviews layouts are now implemented in Java. Scroll position is also preserved in all API levels again done in Java\r\n \r\nstyle.ts:\r\n - implemented batch set of margins, paddings, horizontal & vertical alignments\r\n - changed PropertyMetadataSettings to None for android to skip unnecessary native call to requestLayout (android will request it anyway)\r\n\r\n style.android:\r\n - added method that translate JS layout properties into native layout properties\r\n - added LayoutBase styler to allow setting paddings from CSS\r\n \r\nnumber-utils - removed isFiniteNumber method. There is a runtime method that do the same - isFinite.\r\n\r\nutils - added MEASURED_SIZE_MASK flag into layout module\r\n\r\ndependency-observable - improved null check "},"comment":{"url":"https://api.github.com/repos/NativeScript/NativeScript/issues/comments/127488410","html_url":"https://github.com/NativeScript/NativeScript/pull/445#issuecomment-127488410","issue_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/445","id":127488410,"user":{"login":"dtopuzov","id":6651651,"avatar_url":"https://avatars.githubusercontent.com/u/6651651?v=3","gravatar_id":"","url":"https://api.github.com/users/dtopuzov","html_url":"https://github.com/dtopuzov","followers_url":"https://api.github.com/users/dtopuzov/followers","following_url":"https://api.github.com/users/dtopuzov/following{/other_user}","gists_url":"https://api.github.com/users/dtopuzov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtopuzov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtopuzov/subscriptions","organizations_url":"https://api.github.com/users/dtopuzov/orgs","repos_url":"https://api.github.com/users/dtopuzov/repos","events_url":"https://api.github.com/users/dtopuzov/events{/privacy}","received_events_url":"https://api.github.com/users/dtopuzov/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T06:03:16Z","updated_at":"2015-08-04T06:03:16Z","body":"run ci"}}