{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments/28179797","id":28179797,"diff_hunk":"@@ -135,15 +110,58 @@ typedef enum _sai_port_internal_loopback_mode_t\n */\n typedef enum _sai_port_fdb_learning_mode_t \n {\n+    /* Drop unknown Source MAC. Do not learn */\n+    SAI_PORT_LEARN_MODE_DROP,","path":"sai/inc/saiport.h","position":37,"original_position":37,"commit_id":"2116c3c782171eb5e542704b0d7fc7949543e6fc","original_commit_id":"2116c3c782171eb5e542704b0d7fc7949543e6fc","user":{"login":"lguohan","id":2293967,"avatar_url":"https://avatars.githubusercontent.com/u/2293967?v=3","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"body":"the mental model here is that l2 forwarding has two stages, one is learning for the src mac, the second is forwarding based on the dest mac. This sai_port_fdb_learning_mode_t controls the first stage behavior, 1) whether to learn the mac or not, 2) for unknown mac, whether to proceed to the second stage or not.\r\n\r\nThen the second stage controls the behavior whether the dest mac can be found or not. We'd like to separate these two stages. \r\n\r\nDoes this model make sense to you?","created_at":"2015-04-10T20:56:52Z","updated_at":"2015-04-10T20:56:52Z","html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45#discussion_r28179797","pull_request_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments/28179797"},"html":{"href":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45#discussion_r28179797"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45","id":32958669,"html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45","diff_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45.diff","patch_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45.patch","issue_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/45","number":45,"state":"open","locked":false,"title":"New Header files - LAG/Hash, STP, Mirror, Sample Packet","user":{"login":"arunsubash","id":10690948,"avatar_url":"https://avatars.githubusercontent.com/u/10690948?v=3","gravatar_id":"","url":"https://api.github.com/users/arunsubash","html_url":"https://github.com/arunsubash","followers_url":"https://api.github.com/users/arunsubash/followers","following_url":"https://api.github.com/users/arunsubash/following{/other_user}","gists_url":"https://api.github.com/users/arunsubash/gists{/gist_id}","starred_url":"https://api.github.com/users/arunsubash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunsubash/subscriptions","organizations_url":"https://api.github.com/users/arunsubash/orgs","repos_url":"https://api.github.com/users/arunsubash/repos","events_url":"https://api.github.com/users/arunsubash/events{/privacy}","received_events_url":"https://api.github.com/users/arunsubash/received_events","type":"User","site_admin":false},"body":"New Header files - LAG/Hash, STP, Mirror, Sample Packet\r\nPort Numbering Change\r\nCompile fixes\r\nMerge changes\r\n","created_at":"2015-04-09T14:07:37Z","updated_at":"2015-04-10T20:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f901bbd0ad72ad7bdcd578b9a1dda8f8e920ca8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/45/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/2116c3c782171eb5e542704b0d7fc7949543e6fc","head":{"label":"arunsubash:v0.9.2","ref":"v0.9.2","sha":"2116c3c782171eb5e542704b0d7fc7949543e6fc","user":{"login":"arunsubash","id":10690948,"avatar_url":"https://avatars.githubusercontent.com/u/10690948?v=3","gravatar_id":"","url":"https://api.github.com/users/arunsubash","html_url":"https://github.com/arunsubash","followers_url":"https://api.github.com/users/arunsubash/followers","following_url":"https://api.github.com/users/arunsubash/following{/other_user}","gists_url":"https://api.github.com/users/arunsubash/gists{/gist_id}","starred_url":"https://api.github.com/users/arunsubash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunsubash/subscriptions","organizations_url":"https://api.github.com/users/arunsubash/orgs","repos_url":"https://api.github.com/users/arunsubash/repos","events_url":"https://api.github.com/users/arunsubash/events{/privacy}","received_events_url":"https://api.github.com/users/arunsubash/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"opencomputeproject:v0.9.2","ref":"v0.9.2","sha":"d58d2f934af1ca848add364728c7e20496df2cc3","user":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"repo":{"id":27199774,"name":"OCP-Networking-Project-Community-Contributions","full_name":"opencomputeproject/OCP-Networking-Project-Community-Contributions","owner":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions","description":"WARNING: This repository will hold software contributions that are being worked on collaboratively by the OCP Networking Community. Code in this repository has not yet been approved and accepted by the OCP Incubation Committee.  Software in this repository should be not be used on production machines and should be treated as you would any Alpha/Beta release or any software that is in development.","fork":false,"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions","forks_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/forks","keys_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/events","assignees_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/merges","archive_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/releases{/id}","created_at":"2014-11-26T22:53:43Z","updated_at":"2015-04-10T19:45:44Z","pushed_at":"2015-04-10T20:46:17Z","git_url":"git://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions.git","ssh_url":"git@github.com:opencomputeproject/OCP-Networking-Project-Community-Contributions.git","clone_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions.git","svn_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions","homepage":"","size":4015,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45"},"html":{"href":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/45"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/45"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/2116c3c782171eb5e542704b0d7fc7949543e6fc"}}}}