{"action":"created","comment":{"url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/comments/36388704","id":36388704,"diff_hunk":"@@ -19,6 +27,12 @@ module.exports = {\n     // require method and property shorthand syntax for object literals\n     \"object-shorthand\": 2,\n     // suggest using of const declaration for variables that are never modified after declared\n-    \"prefer-const\": 2\n+    \"prefer-const\": 2,\n+    // suggest using the spread operator instead of .apply()\n+    \"prefer-spread\": 0,\n+    // suggest using Reflect methods where applicable\n+    \"prefer-reflect\": 0,\n+    // disallow generator functions that do not have yield\n+    \"require-yield\": 0","path":"rules/eslint/es6/walmart.js","position":30,"original_position":30,"commit_id":"8b90843ab3a5203c46612216169b25bd0d6eb73d","original_commit_id":"8b90843ab3a5203c46612216169b25bd0d6eb73d","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"body":"I'd give this at least a `1`.  It is technically correct, and there may be cases where you'd want to do it, but you should have a good reason (which probably means an eslint line exclude).","created_at":"2015-08-06T07:45:32Z","updated_at":"2015-08-06T07:45:32Z","html_url":"https://github.com/walmartlabs/eslint-config-defaults/pull/21#discussion_r36388704","pull_request_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/comments/36388704"},"html":{"href":"https://github.com/walmartlabs/eslint-config-defaults/pull/21#discussion_r36388704"},"pull_request":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21","id":41741045,"html_url":"https://github.com/walmartlabs/eslint-config-defaults/pull/21","diff_url":"https://github.com/walmartlabs/eslint-config-defaults/pull/21.diff","patch_url":"https://github.com/walmartlabs/eslint-config-defaults/pull/21.patch","issue_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/21","number":21,"state":"open","locked":false,"title":"Feature/bring up to 1.0","user":{"login":"baer","id":940667,"avatar_url":"https://avatars.githubusercontent.com/u/940667?v=3","gravatar_id":"","url":"https://api.github.com/users/baer","html_url":"https://github.com/baer","followers_url":"https://api.github.com/users/baer/followers","following_url":"https://api.github.com/users/baer/following{/other_user}","gists_url":"https://api.github.com/users/baer/gists{/gist_id}","starred_url":"https://api.github.com/users/baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baer/subscriptions","organizations_url":"https://api.github.com/users/baer/orgs","repos_url":"https://api.github.com/users/baer/repos","events_url":"https://api.github.com/users/baer/events{/privacy}","received_events_url":"https://api.github.com/users/baer/received_events","type":"User","site_admin":false},"body":"@ryan-roemer - There are a bunch of new ES6 rules in 1.0 that we should look at turning on.","created_at":"2015-08-06T00:24:01Z","updated_at":"2015-08-06T07:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f948a6e94e01b40422aad06a00371fd224b0e184","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21/commits","review_comments_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21/comments","review_comment_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/comments{/number}","comments_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/21/comments","statuses_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/statuses/8b90843ab3a5203c46612216169b25bd0d6eb73d","head":{"label":"walmartlabs:feature/bring-up-to-1.0","ref":"feature/bring-up-to-1.0","sha":"8b90843ab3a5203c46612216169b25bd0d6eb73d","user":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37560269,"name":"eslint-config-defaults","full_name":"walmartlabs/eslint-config-defaults","owner":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/walmartlabs/eslint-config-defaults","description":"A composable set of ESLint defaults","fork":false,"url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults","forks_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/forks","keys_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/teams","hooks_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/hooks","issue_events_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/events{/number}","events_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/events","assignees_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/assignees{/user}","branches_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/branches{/branch}","tags_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/tags","blobs_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/refs{/sha}","trees_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/statuses/{sha}","languages_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/languages","stargazers_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/stargazers","contributors_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/contributors","subscribers_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/subscribers","subscription_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/subscription","commits_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/commits{/sha}","git_commits_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/commits{/sha}","comments_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/comments{/number}","issue_comment_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/comments{/number}","contents_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/contents/{+path}","compare_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/merges","archive_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/downloads","issues_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues{/number}","pulls_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls{/number}","milestones_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/milestones{/number}","notifications_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/labels{/name}","releases_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/releases{/id}","created_at":"2015-06-16T22:53:56Z","updated_at":"2015-08-05T11:42:31Z","pushed_at":"2015-08-06T00:24:01Z","git_url":"git://github.com/walmartlabs/eslint-config-defaults.git","ssh_url":"git@github.com:walmartlabs/eslint-config-defaults.git","clone_url":"https://github.com/walmartlabs/eslint-config-defaults.git","svn_url":"https://github.com/walmartlabs/eslint-config-defaults","homepage":"","size":407,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":21,"default_branch":"master"}},"base":{"label":"walmartlabs:master","ref":"master","sha":"95eb4d612c748a2a503873a41bd3bef81810856b","user":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37560269,"name":"eslint-config-defaults","full_name":"walmartlabs/eslint-config-defaults","owner":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/walmartlabs/eslint-config-defaults","description":"A composable set of ESLint defaults","fork":false,"url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults","forks_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/forks","keys_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/teams","hooks_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/hooks","issue_events_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/events{/number}","events_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/events","assignees_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/assignees{/user}","branches_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/branches{/branch}","tags_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/tags","blobs_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/refs{/sha}","trees_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/statuses/{sha}","languages_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/languages","stargazers_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/stargazers","contributors_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/contributors","subscribers_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/subscribers","subscription_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/subscription","commits_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/commits{/sha}","git_commits_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/git/commits{/sha}","comments_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/comments{/number}","issue_comment_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/comments{/number}","contents_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/contents/{+path}","compare_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/merges","archive_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/downloads","issues_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues{/number}","pulls_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls{/number}","milestones_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/milestones{/number}","notifications_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/labels{/name}","releases_url":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/releases{/id}","created_at":"2015-06-16T22:53:56Z","updated_at":"2015-08-05T11:42:31Z","pushed_at":"2015-08-06T00:24:01Z","git_url":"git://github.com/walmartlabs/eslint-config-defaults.git","ssh_url":"git@github.com:walmartlabs/eslint-config-defaults.git","clone_url":"https://github.com/walmartlabs/eslint-config-defaults.git","svn_url":"https://github.com/walmartlabs/eslint-config-defaults","homepage":"","size":407,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21"},"html":{"href":"https://github.com/walmartlabs/eslint-config-defaults/pull/21"},"issue":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/21"},"comments":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/walmartlabs/eslint-config-defaults/statuses/8b90843ab3a5203c46612216169b25bd0d6eb73d"}}}}