{"action":"created","issue":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/595","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/595/labels{/name}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/595/comments","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/595/events","html_url":"https://github.com/rcbops/rpc-openstack/issues/595","id":117379053,"number":595,"title":"linting.sh buries flake8 failures","user":{"login":"mancdaz","id":562262,"avatar_url":"https://avatars.githubusercontent.com/u/562262?v=3","gravatar_id":"","url":"https://api.github.com/users/mancdaz","html_url":"https://github.com/mancdaz","followers_url":"https://api.github.com/users/mancdaz/followers","following_url":"https://api.github.com/users/mancdaz/following{/other_user}","gists_url":"https://api.github.com/users/mancdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mancdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mancdaz/subscriptions","organizations_url":"https://api.github.com/users/mancdaz/orgs","repos_url":"https://api.github.com/users/mancdaz/repos","events_url":"https://api.github.com/users/mancdaz/events{/privacy}","received_events_url":"https://api.github.com/users/mancdaz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/prio-2","name":"prio-2","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-17T15:30:25Z","updated_at":"2015-12-02T18:58:02Z","closed_at":null,"body":"For example, there was a failing flake8 line in the PR, but the output from the travis run just says 'failed linting'. eg:\r\n\r\nhttps://travis-ci.org/rcbops/rpc-openstack/builds/91598278#L1980\r\n\r\nWhen running the relevant flake8 line manually locally, I saw the actual failure:\r\n\r\n```\r\n# flake8 $(grep -rln -e '^#!/usr/bin/env python' -e '^#!/bin/python' -e '^#!/usr/bin/python' * ) || failed=1\r\nmaas/plugins/nova_cloud_stats.py:103:80: E501 line too long (83 > 79 characters)\r\n```\r\n\r\nWe should probably fix the linting script to output those errors properly"},"comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments/161398216","html_url":"https://github.com/rcbops/rpc-openstack/issues/595#issuecomment-161398216","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/595","id":161398216,"user":{"login":"nrb","id":321387,"avatar_url":"https://avatars.githubusercontent.com/u/321387?v=3","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T18:58:02Z","updated_at":"2015-12-02T18:58:02Z","body":"That's a good point, @sigmavirus24. So I take it you're suggesting we split flake8 and ansible linting?"}}