{"action":"created","comment":{"url":"https://api.github.com/repos/yeoman/html-wiring/pulls/comments/35522813","id":35522813,"diff_hunk":"@@ -29,7 +30,9 @@ var wiring = module.exports;\n  */\n \n wiring.domUpdate = function domUpdate(html, tagName, content, mode) {\n-  var $ = cheerio.load(html, { decodeEntities: false });\n+  var $ = cheerio.load(html, {\n+    decodeEntities: false\n+  });","path":"index.js","position":15,"original_position":15,"commit_id":"9870a79fd89a345e7c756d36f15bf37b20eb5c25","original_commit_id":"9870a79fd89a345e7c756d36f15bf37b20eb5c25","user":{"login":"arthurvr","id":6025224,"avatar_url":"https://avatars.githubusercontent.com/u/6025224?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurvr","html_url":"https://github.com/arthurvr","followers_url":"https://api.github.com/users/arthurvr/followers","following_url":"https://api.github.com/users/arthurvr/following{/other_user}","gists_url":"https://api.github.com/users/arthurvr/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurvr/subscriptions","organizations_url":"https://api.github.com/users/arthurvr/orgs","repos_url":"https://api.github.com/users/arthurvr/repos","events_url":"https://api.github.com/users/arthurvr/events{/privacy}","received_events_url":"https://api.github.com/users/arthurvr/received_events","type":"User","site_admin":false},"body":"In this repo, none. Even if it was automated let's not do random changes in unrelated commits ;) ","created_at":"2015-07-27T10:25:53Z","updated_at":"2015-07-27T10:25:53Z","html_url":"https://github.com/yeoman/html-wiring/pull/3#discussion_r35522813","pull_request_url":"https://api.github.com/repos/yeoman/html-wiring/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/comments/35522813"},"html":{"href":"https://github.com/yeoman/html-wiring/pull/3#discussion_r35522813"},"pull_request":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/yeoman/html-wiring/pulls/3","id":40489478,"html_url":"https://github.com/yeoman/html-wiring/pull/3","diff_url":"https://github.com/yeoman/html-wiring/pull/3.diff","patch_url":"https://github.com/yeoman/html-wiring/pull/3.patch","issue_url":"https://api.github.com/repos/yeoman/html-wiring/issues/3","number":3,"state":"open","locked":false,"title":"Fixed inserting Unix EOL","user":{"login":"aecz","id":7781120,"avatar_url":"https://avatars.githubusercontent.com/u/7781120?v=3","gravatar_id":"","url":"https://api.github.com/users/aecz","html_url":"https://github.com/aecz","followers_url":"https://api.github.com/users/aecz/followers","following_url":"https://api.github.com/users/aecz/following{/other_user}","gists_url":"https://api.github.com/users/aecz/gists{/gist_id}","starred_url":"https://api.github.com/users/aecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aecz/subscriptions","organizations_url":"https://api.github.com/users/aecz/orgs","repos_url":"https://api.github.com/users/aecz/repos","events_url":"https://api.github.com/users/aecz/events{/privacy}","received_events_url":"https://api.github.com/users/aecz/received_events","type":"User","site_admin":false},"body":"- Added eolChar parameter to wiring.generateBlock function\r\n- Replaced fixed Unix EOL with eolChar variable\r\n- Assigned eolChar value depending on HTML string\r\n- Added Unix EOL to tests using generateBlock function\r\n- Added tests with an HTML string using Windows and Unix EOL\r\n- Added test using a real HTML file as input\r\n\r\nBased on NodeJS code, there is only 2 possible EOL:\r\nhttps://github.com/joyent/node/blob/master/lib/os.js#L66\r\n\r\nI also noticed that tests using fixtures uses **textEqual** instead of **equal**.\r\nThis could be changed if the file **basic_html.html** is used as input instead of a string. Also **trim** function could be removed.","created_at":"2015-07-21T18:33:16Z","updated_at":"2015-07-27T10:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"445a2de50409fb3b186d01ff18497af5f1064539","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yeoman/html-wiring/pulls/3/commits","review_comments_url":"https://api.github.com/repos/yeoman/html-wiring/pulls/3/comments","review_comment_url":"https://api.github.com/repos/yeoman/html-wiring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeoman/html-wiring/issues/3/comments","statuses_url":"https://api.github.com/repos/yeoman/html-wiring/statuses/9870a79fd89a345e7c756d36f15bf37b20eb5c25","head":{"label":"aecz:master","ref":"master","sha":"9870a79fd89a345e7c756d36f15bf37b20eb5c25","user":{"login":"aecz","id":7781120,"avatar_url":"https://avatars.githubusercontent.com/u/7781120?v=3","gravatar_id":"","url":"https://api.github.com/users/aecz","html_url":"https://github.com/aecz","followers_url":"https://api.github.com/users/aecz/followers","following_url":"https://api.github.com/users/aecz/following{/other_user}","gists_url":"https://api.github.com/users/aecz/gists{/gist_id}","starred_url":"https://api.github.com/users/aecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aecz/subscriptions","organizations_url":"https://api.github.com/users/aecz/orgs","repos_url":"https://api.github.com/users/aecz/repos","events_url":"https://api.github.com/users/aecz/events{/privacy}","received_events_url":"https://api.github.com/users/aecz/received_events","type":"User","site_admin":false},"repo":{"id":39451892,"name":"html-wiring","full_name":"aecz/html-wiring","owner":{"login":"aecz","id":7781120,"avatar_url":"https://avatars.githubusercontent.com/u/7781120?v=3","gravatar_id":"","url":"https://api.github.com/users/aecz","html_url":"https://github.com/aecz","followers_url":"https://api.github.com/users/aecz/followers","following_url":"https://api.github.com/users/aecz/following{/other_user}","gists_url":"https://api.github.com/users/aecz/gists{/gist_id}","starred_url":"https://api.github.com/users/aecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aecz/subscriptions","organizations_url":"https://api.github.com/users/aecz/orgs","repos_url":"https://api.github.com/users/aecz/repos","events_url":"https://api.github.com/users/aecz/events{/privacy}","received_events_url":"https://api.github.com/users/aecz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aecz/html-wiring","description":"Set of utilities to update HTML files","fork":true,"url":"https://api.github.com/repos/aecz/html-wiring","forks_url":"https://api.github.com/repos/aecz/html-wiring/forks","keys_url":"https://api.github.com/repos/aecz/html-wiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aecz/html-wiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aecz/html-wiring/teams","hooks_url":"https://api.github.com/repos/aecz/html-wiring/hooks","issue_events_url":"https://api.github.com/repos/aecz/html-wiring/issues/events{/number}","events_url":"https://api.github.com/repos/aecz/html-wiring/events","assignees_url":"https://api.github.com/repos/aecz/html-wiring/assignees{/user}","branches_url":"https://api.github.com/repos/aecz/html-wiring/branches{/branch}","tags_url":"https://api.github.com/repos/aecz/html-wiring/tags","blobs_url":"https://api.github.com/repos/aecz/html-wiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aecz/html-wiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aecz/html-wiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/aecz/html-wiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aecz/html-wiring/statuses/{sha}","languages_url":"https://api.github.com/repos/aecz/html-wiring/languages","stargazers_url":"https://api.github.com/repos/aecz/html-wiring/stargazers","contributors_url":"https://api.github.com/repos/aecz/html-wiring/contributors","subscribers_url":"https://api.github.com/repos/aecz/html-wiring/subscribers","subscription_url":"https://api.github.com/repos/aecz/html-wiring/subscription","commits_url":"https://api.github.com/repos/aecz/html-wiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/aecz/html-wiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/aecz/html-wiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/aecz/html-wiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/aecz/html-wiring/contents/{+path}","compare_url":"https://api.github.com/repos/aecz/html-wiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aecz/html-wiring/merges","archive_url":"https://api.github.com/repos/aecz/html-wiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aecz/html-wiring/downloads","issues_url":"https://api.github.com/repos/aecz/html-wiring/issues{/number}","pulls_url":"https://api.github.com/repos/aecz/html-wiring/pulls{/number}","milestones_url":"https://api.github.com/repos/aecz/html-wiring/milestones{/number}","notifications_url":"https://api.github.com/repos/aecz/html-wiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aecz/html-wiring/labels{/name}","releases_url":"https://api.github.com/repos/aecz/html-wiring/releases{/id}","created_at":"2015-07-21T14:55:48Z","updated_at":"2015-07-21T14:55:49Z","pushed_at":"2015-07-23T16:35:37Z","git_url":"git://github.com/aecz/html-wiring.git","ssh_url":"git@github.com:aecz/html-wiring.git","clone_url":"https://github.com/aecz/html-wiring.git","svn_url":"https://github.com/aecz/html-wiring","homepage":null,"size":90,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeoman:master","ref":"master","sha":"03d54553c9f7eb06935c0a61c643619f68540b2c","user":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"repo":{"id":33095597,"name":"html-wiring","full_name":"yeoman/html-wiring","owner":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yeoman/html-wiring","description":"Set of utilities to update HTML files","fork":false,"url":"https://api.github.com/repos/yeoman/html-wiring","forks_url":"https://api.github.com/repos/yeoman/html-wiring/forks","keys_url":"https://api.github.com/repos/yeoman/html-wiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeoman/html-wiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeoman/html-wiring/teams","hooks_url":"https://api.github.com/repos/yeoman/html-wiring/hooks","issue_events_url":"https://api.github.com/repos/yeoman/html-wiring/issues/events{/number}","events_url":"https://api.github.com/repos/yeoman/html-wiring/events","assignees_url":"https://api.github.com/repos/yeoman/html-wiring/assignees{/user}","branches_url":"https://api.github.com/repos/yeoman/html-wiring/branches{/branch}","tags_url":"https://api.github.com/repos/yeoman/html-wiring/tags","blobs_url":"https://api.github.com/repos/yeoman/html-wiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeoman/html-wiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeoman/html-wiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeoman/html-wiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeoman/html-wiring/statuses/{sha}","languages_url":"https://api.github.com/repos/yeoman/html-wiring/languages","stargazers_url":"https://api.github.com/repos/yeoman/html-wiring/stargazers","contributors_url":"https://api.github.com/repos/yeoman/html-wiring/contributors","subscribers_url":"https://api.github.com/repos/yeoman/html-wiring/subscribers","subscription_url":"https://api.github.com/repos/yeoman/html-wiring/subscription","commits_url":"https://api.github.com/repos/yeoman/html-wiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeoman/html-wiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeoman/html-wiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeoman/html-wiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeoman/html-wiring/contents/{+path}","compare_url":"https://api.github.com/repos/yeoman/html-wiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeoman/html-wiring/merges","archive_url":"https://api.github.com/repos/yeoman/html-wiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeoman/html-wiring/downloads","issues_url":"https://api.github.com/repos/yeoman/html-wiring/issues{/number}","pulls_url":"https://api.github.com/repos/yeoman/html-wiring/pulls{/number}","milestones_url":"https://api.github.com/repos/yeoman/html-wiring/milestones{/number}","notifications_url":"https://api.github.com/repos/yeoman/html-wiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeoman/html-wiring/labels{/name}","releases_url":"https://api.github.com/repos/yeoman/html-wiring/releases{/id}","created_at":"2015-03-30T00:40:33Z","updated_at":"2015-06-30T21:11:46Z","pushed_at":"2015-07-23T16:35:37Z","git_url":"git://github.com/yeoman/html-wiring.git","ssh_url":"git@github.com:yeoman/html-wiring.git","clone_url":"https://github.com/yeoman/html-wiring.git","svn_url":"https://github.com/yeoman/html-wiring","homepage":null,"size":180,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/3"},"html":{"href":"https://github.com/yeoman/html-wiring/pull/3"},"issue":{"href":"https://api.github.com/repos/yeoman/html-wiring/issues/3"},"comments":{"href":"https://api.github.com/repos/yeoman/html-wiring/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeoman/html-wiring/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/yeoman/html-wiring/statuses/9870a79fd89a345e7c756d36f15bf37b20eb5c25"}}}}