{"action":"created","issue":{"url":"https://api.github.com/repos/plone/plone.rest/issues/21","labels_url":"https://api.github.com/repos/plone/plone.rest/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/plone/plone.rest/issues/21/comments","events_url":"https://api.github.com/repos/plone/plone.rest/issues/21/events","html_url":"https://github.com/plone/plone.rest/pull/21","id":119355381,"number":21,"title":"Cleanup patch of DynamicType pre-traversal hook and add tests.","user":{"login":"buchi","id":270502,"avatar_url":"https://avatars.githubusercontent.com/u/270502?v=3","gravatar_id":"","url":"https://api.github.com/users/buchi","html_url":"https://github.com/buchi","followers_url":"https://api.github.com/users/buchi/followers","following_url":"https://api.github.com/users/buchi/following{/other_user}","gists_url":"https://api.github.com/users/buchi/gists{/gist_id}","starred_url":"https://api.github.com/users/buchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchi/subscriptions","organizations_url":"https://api.github.com/users/buchi/orgs","repos_url":"https://api.github.com/users/buchi/repos","events_url":"https://api.github.com/users/buchi/events{/privacy}","received_events_url":"https://api.github.com/users/buchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lukasgraf","id":405124,"avatar_url":"https://avatars.githubusercontent.com/u/405124?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasgraf","html_url":"https://github.com/lukasgraf","followers_url":"https://api.github.com/users/lukasgraf/followers","following_url":"https://api.github.com/users/lukasgraf/following{/other_user}","gists_url":"https://api.github.com/users/lukasgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasgraf/subscriptions","organizations_url":"https://api.github.com/users/lukasgraf/orgs","repos_url":"https://api.github.com/users/lukasgraf/repos","events_url":"https://api.github.com/users/lukasgraf/events{/privacy}","received_events_url":"https://api.github.com/users/lukasgraf/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-11-29T11:43:34Z","updated_at":"2015-12-01T13:06:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/plone/plone.rest/pulls/21","html_url":"https://github.com/plone/plone.rest/pull/21","diff_url":"https://github.com/plone/plone.rest/pull/21.diff","patch_url":"https://github.com/plone/plone.rest/pull/21.patch"},"body":"Before cleanup there were 3 patches doing the same for the portal root, Dexterity content and Archetypes content. Patching was done in the wrong place by adding additional pre-traversal hooks on these classes.\r\nNow we patch the pre-traversal hook of `Products.CMFCore.DynamicType.DynamicType` directly which greatly simplifies the patch as the involved content classes all inherit from the `DynamicType` mixin.\r\n\r\nThe patch prevents appending the default view during traversal as this would break REST requests.\r\n\r\n@lukasgraf \r\n/cc @tisto @bloodbare "},"comment":{"url":"https://api.github.com/repos/plone/plone.rest/issues/comments/160964447","html_url":"https://github.com/plone/plone.rest/pull/21#issuecomment-160964447","issue_url":"https://api.github.com/repos/plone/plone.rest/issues/21","id":160964447,"user":{"login":"lukasgraf","id":405124,"avatar_url":"https://avatars.githubusercontent.com/u/405124?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasgraf","html_url":"https://github.com/lukasgraf","followers_url":"https://api.github.com/users/lukasgraf/followers","following_url":"https://api.github.com/users/lukasgraf/following{/other_user}","gists_url":"https://api.github.com/users/lukasgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasgraf/subscriptions","organizations_url":"https://api.github.com/users/lukasgraf/orgs","repos_url":"https://api.github.com/users/lukasgraf/repos","events_url":"https://api.github.com/users/lukasgraf/events{/privacy}","received_events_url":"https://api.github.com/users/lukasgraf/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T13:06:23Z","updated_at":"2015-12-01T13:06:23Z","body":"@buchi could you please add a changelog entry? Then I'll go ahead and merge this."}}