{"action":"closed","number":4417,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/4417","id":44286922,"html_url":"https://github.com/deis/deis/pull/4417","diff_url":"https://github.com/deis/deis/pull/4417.diff","patch_url":"https://github.com/deis/deis/pull/4417.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/4417","number":4417,"state":"closed","locked":false,"title":"[WIP] feat(builder): pull submodules if detected","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"body":"Why is this WIP?\r\n- The builder uses the bare repo format, which is just the `.git` folder of a normal git repository. At the moment, builder uses `git archive` to get the files out of the bare repo, but you need to have the git repository in order to checkout submodules. The only way to get a working directory of a bare git repo is to clone it. I can clone the bare repository with the command in this script when sshing into the builder, but whenever the command runs in the gitrecieve script, I get a warning that I am cloning into a empty repository and checking out the revision fails. I'm not sure what is up with this. Is this some sort of anti-race condition that you cannot checkout a revision still being pushed to the repository? If so, are there any other ways to checkout submodules? Heroku seems like they might parse the gitmodules file themselves and pull the submodules themselves, but that doesn't seem like a great option if there are any alternatives. I'd love any ideas for other ways to checkout the repository that won't hit that strange error.\r\n- We should probably add tests for this, maybe an example app with a submodule in the integration tests?","created_at":"2015-09-05T17:24:27Z","updated_at":"2015-12-02T00:46:37Z","closed_at":"2015-12-02T00:46:37Z","merged_at":null,"merge_commit_sha":"825f847d303d36056440bc11c1c54d60185b8020","assignee":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/4417/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/4417/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/deis/issues/4417/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/8fa109db86382894e19e7a287bb60e1fcb26bcd2","head":{"label":"Joshua-Anderson:submodules","ref":"submodules","sha":"8fa109db86382894e19e7a287bb60e1fcb26bcd2","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"repo":{"id":24777458,"name":"deis","full_name":"Joshua-Anderson/deis","owner":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Joshua-Anderson/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/Joshua-Anderson/deis","forks_url":"https://api.github.com/repos/Joshua-Anderson/deis/forks","keys_url":"https://api.github.com/repos/Joshua-Anderson/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Joshua-Anderson/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Joshua-Anderson/deis/teams","hooks_url":"https://api.github.com/repos/Joshua-Anderson/deis/hooks","issue_events_url":"https://api.github.com/repos/Joshua-Anderson/deis/issues/events{/number}","events_url":"https://api.github.com/repos/Joshua-Anderson/deis/events","assignees_url":"https://api.github.com/repos/Joshua-Anderson/deis/assignees{/user}","branches_url":"https://api.github.com/repos/Joshua-Anderson/deis/branches{/branch}","tags_url":"https://api.github.com/repos/Joshua-Anderson/deis/tags","blobs_url":"https://api.github.com/repos/Joshua-Anderson/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Joshua-Anderson/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Joshua-Anderson/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Joshua-Anderson/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Joshua-Anderson/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/Joshua-Anderson/deis/languages","stargazers_url":"https://api.github.com/repos/Joshua-Anderson/deis/stargazers","contributors_url":"https://api.github.com/repos/Joshua-Anderson/deis/contributors","subscribers_url":"https://api.github.com/repos/Joshua-Anderson/deis/subscribers","subscription_url":"https://api.github.com/repos/Joshua-Anderson/deis/subscription","commits_url":"https://api.github.com/repos/Joshua-Anderson/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Joshua-Anderson/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Joshua-Anderson/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Joshua-Anderson/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Joshua-Anderson/deis/contents/{+path}","compare_url":"https://api.github.com/repos/Joshua-Anderson/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Joshua-Anderson/deis/merges","archive_url":"https://api.github.com/repos/Joshua-Anderson/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Joshua-Anderson/deis/downloads","issues_url":"https://api.github.com/repos/Joshua-Anderson/deis/issues{/number}","pulls_url":"https://api.github.com/repos/Joshua-Anderson/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/Joshua-Anderson/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/Joshua-Anderson/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Joshua-Anderson/deis/labels{/name}","releases_url":"https://api.github.com/repos/Joshua-Anderson/deis/releases{/id}","created_at":"2014-10-03T23:58:44Z","updated_at":"2015-05-07T01:32:09Z","pushed_at":"2015-11-11T03:40:15Z","git_url":"git://github.com/Joshua-Anderson/deis.git","ssh_url":"git@github.com:Joshua-Anderson/deis.git","clone_url":"https://github.com/Joshua-Anderson/deis.git","svn_url":"https://github.com/Joshua-Anderson/deis","homepage":"http://deis.io","size":20059,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"1330404b3f84206c71294ac2d65c050e01b043b0","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2015-12-01T22:03:36Z","pushed_at":"2015-12-02T00:01:47Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"https://deis.com/","size":25093,"stargazers_count":5052,"watchers_count":5052,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":814,"mirror_url":null,"open_issues_count":325,"forks":814,"open_issues":325,"watchers":5052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/4417"},"html":{"href":"https://github.com/deis/deis/pull/4417"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/4417"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/4417/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/4417/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/4417/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/8fa109db86382894e19e7a287bb60e1fcb26bcd2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":8,"review_comments":1,"commits":1,"additions":25,"deletions":3,"changed_files":2}}