{"action":"created","comment":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/27371099","id":27371099,"diff_hunk":"@@ -103,7 +103,18 @@\n     error_log_file  => 'cinder.log',\n     access_log_file => 'cinder.log',\n     proxy_pass      => [ { path => '/', url => \"http://${localbind_host}:${localbind_port}/\"  } ],\n-    headers         => [ 'set Access-Control-Allow-Origin \"*\"' ],\n+    rewrites        => [ {\n+      comment => 'Return 200 for OPTIONS request',","path":"manifests/cinder.pp","position":6,"original_position":6,"commit_id":"20fb70d717afcbd8164f7ab7075effea4d068d7a","original_commit_id":"20fb70d717afcbd8164f7ab7075effea4d068d7a","user":{"login":"rohit-k","id":1021232,"avatar_url":"https://avatars.githubusercontent.com/u/1021232?v=3","gravatar_id":"","url":"https://api.github.com/users/rohit-k","html_url":"https://github.com/rohit-k","followers_url":"https://api.github.com/users/rohit-k/followers","following_url":"https://api.github.com/users/rohit-k/following{/other_user}","gists_url":"https://api.github.com/users/rohit-k/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-k/subscriptions","organizations_url":"https://api.github.com/users/rohit-k/orgs","repos_url":"https://api.github.com/users/rohit-k/repos","events_url":"https://api.github.com/users/rohit-k/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-k/received_events","type":"User","site_admin":false},"body":"puppet-lint did not throw any errors for this indentation. Can you please specify where's the inconsistenct? I've followed puppet docs themselves to have this style of indentation. The two soft-tab rule requires this kind of indentation.","created_at":"2015-03-30T07:40:38Z","updated_at":"2015-03-30T07:40:38Z","html_url":"https://github.com/JioCloud/puppet-rjil/pull/497#discussion_r27371099","pull_request_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497","_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/27371099"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/497#discussion_r27371099"},"pull_request":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497","id":31896662,"html_url":"https://github.com/JioCloud/puppet-rjil/pull/497","diff_url":"https://github.com/JioCloud/puppet-rjil/pull/497.diff","patch_url":"https://github.com/JioCloud/puppet-rjil/pull/497.patch","issue_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/497","number":497,"state":"open","locked":false,"title":"Update CORS headers in API service apache configs","user":{"login":"rohit-k","id":1021232,"avatar_url":"https://avatars.githubusercontent.com/u/1021232?v=3","gravatar_id":"","url":"https://api.github.com/users/rohit-k","html_url":"https://github.com/rohit-k","followers_url":"https://api.github.com/users/rohit-k/followers","following_url":"https://api.github.com/users/rohit-k/following{/other_user}","gists_url":"https://api.github.com/users/rohit-k/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-k/subscriptions","organizations_url":"https://api.github.com/users/rohit-k/orgs","repos_url":"https://api.github.com/users/rohit-k/repos","events_url":"https://api.github.com/users/rohit-k/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-k/received_events","type":"User","site_admin":false},"body":"This change corrects the CORS header to 'always set'\r\nIt adds another header to allow 'Content-Type' in the\r\nrequest headers.\r\nAn explicit rewrite rule to return 200 for the OPTIONS\r\nrequest has also been added because OpenStack services\r\n(like Keystone) yield 404 for OPTIONS requests.","created_at":"2015-03-25T06:35:40Z","updated_at":"2015-03-30T07:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8565482512cefac3d9b47bf28345c7424ed1452a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497/commits","review_comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497/comments","review_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/497/comments","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/20fb70d717afcbd8164f7ab7075effea4d068d7a","head":{"label":"rohit-k:add-cors-rewrite","ref":"add-cors-rewrite","sha":"20fb70d717afcbd8164f7ab7075effea4d068d7a","user":{"login":"rohit-k","id":1021232,"avatar_url":"https://avatars.githubusercontent.com/u/1021232?v=3","gravatar_id":"","url":"https://api.github.com/users/rohit-k","html_url":"https://github.com/rohit-k","followers_url":"https://api.github.com/users/rohit-k/followers","following_url":"https://api.github.com/users/rohit-k/following{/other_user}","gists_url":"https://api.github.com/users/rohit-k/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-k/subscriptions","organizations_url":"https://api.github.com/users/rohit-k/orgs","repos_url":"https://api.github.com/users/rohit-k/repos","events_url":"https://api.github.com/users/rohit-k/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-k/received_events","type":"User","site_admin":false},"repo":{"id":29001408,"name":"puppet-rjil","full_name":"rohit-k/puppet-rjil","owner":{"login":"rohit-k","id":1021232,"avatar_url":"https://avatars.githubusercontent.com/u/1021232?v=3","gravatar_id":"","url":"https://api.github.com/users/rohit-k","html_url":"https://github.com/rohit-k","followers_url":"https://api.github.com/users/rohit-k/followers","following_url":"https://api.github.com/users/rohit-k/following{/other_user}","gists_url":"https://api.github.com/users/rohit-k/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-k/subscriptions","organizations_url":"https://api.github.com/users/rohit-k/orgs","repos_url":"https://api.github.com/users/rohit-k/repos","events_url":"https://api.github.com/users/rohit-k/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohit-k/puppet-rjil","description":"","fork":true,"url":"https://api.github.com/repos/rohit-k/puppet-rjil","forks_url":"https://api.github.com/repos/rohit-k/puppet-rjil/forks","keys_url":"https://api.github.com/repos/rohit-k/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohit-k/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohit-k/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/rohit-k/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/rohit-k/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/rohit-k/puppet-rjil/events","assignees_url":"https://api.github.com/repos/rohit-k/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/rohit-k/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/rohit-k/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/rohit-k/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohit-k/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohit-k/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohit-k/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohit-k/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/rohit-k/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/rohit-k/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/rohit-k/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/rohit-k/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/rohit-k/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/rohit-k/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohit-k/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohit-k/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohit-k/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohit-k/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/rohit-k/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohit-k/puppet-rjil/merges","archive_url":"https://api.github.com/repos/rohit-k/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohit-k/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/rohit-k/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/rohit-k/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/rohit-k/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/rohit-k/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohit-k/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/rohit-k/puppet-rjil/releases{/id}","created_at":"2015-01-09T04:55:44Z","updated_at":"2015-03-30T05:03:12Z","pushed_at":"2015-03-30T05:05:09Z","git_url":"git://github.com/rohit-k/puppet-rjil.git","ssh_url":"git@github.com:rohit-k/puppet-rjil.git","clone_url":"https://github.com/rohit-k/puppet-rjil.git","svn_url":"https://github.com/rohit-k/puppet-rjil","homepage":null,"size":1040,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JioCloud:master","ref":"master","sha":"26486ff73239c8c2b055c342a5f342caa6a98b49","user":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16161513,"name":"puppet-rjil","full_name":"JioCloud/puppet-rjil","owner":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JioCloud/puppet-rjil","description":"Puppet scripts for managing JioCloud","fork":false,"url":"https://api.github.com/repos/JioCloud/puppet-rjil","forks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/forks","keys_url":"https://api.github.com/repos/JioCloud/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JioCloud/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JioCloud/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/events","assignees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/JioCloud/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/JioCloud/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/JioCloud/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JioCloud/puppet-rjil/merges","archive_url":"https://api.github.com/repos/JioCloud/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JioCloud/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/JioCloud/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/JioCloud/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JioCloud/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/JioCloud/puppet-rjil/releases{/id}","created_at":"2014-01-23T03:45:55Z","updated_at":"2015-03-29T05:50:33Z","pushed_at":"2015-03-30T06:45:48Z","git_url":"git://github.com/JioCloud/puppet-rjil.git","ssh_url":"git@github.com:JioCloud/puppet-rjil.git","clone_url":"https://github.com/JioCloud/puppet-rjil.git","svn_url":"https://github.com/JioCloud/puppet-rjil","homepage":"","size":6261,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":94,"forks":29,"open_issues":94,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/497"},"issue":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/497"},"comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/20fb70d717afcbd8164f7ab7075effea4d068d7a"}}}}