{"action":"closed","number":3514,"pull_request":{"url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514","id":44459757,"html_url":"https://github.com/codemirror/CodeMirror/pull/3514","diff_url":"https://github.com/codemirror/CodeMirror/pull/3514.diff","patch_url":"https://github.com/codemirror/CodeMirror/pull/3514.patch","issue_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/3514","number":3514,"state":"closed","locked":false,"title":"fixes #3513","user":{"login":"increpare","id":465632,"avatar_url":"https://avatars.githubusercontent.com/u/465632?v=3","gravatar_id":"","url":"https://api.github.com/users/increpare","html_url":"https://github.com/increpare","followers_url":"https://api.github.com/users/increpare/followers","following_url":"https://api.github.com/users/increpare/following{/other_user}","gists_url":"https://api.github.com/users/increpare/gists{/gist_id}","starred_url":"https://api.github.com/users/increpare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/increpare/subscriptions","organizations_url":"https://api.github.com/users/increpare/orgs","repos_url":"https://api.github.com/users/increpare/repos","events_url":"https://api.github.com/users/increpare/events{/privacy}","received_events_url":"https://api.github.com/users/increpare/received_events","type":"User","site_admin":false},"body":"Not 100% sure that this is the best way to deal with this, but pretty sure - \r\n\r\nIf you're in an expression, and encounter what you think is a type, it's probably better to change your assumption and treat it as you would a variable/constant (Because that's what it probably is) rather than to forget everything.\r\n\r\nI ran the test suite, and it didn't break anything, and the linter, which was quiet.","created_at":"2015-09-08T17:26:56Z","updated_at":"2015-09-09T09:57:31Z","closed_at":"2015-09-09T09:57:31Z","merged_at":null,"merge_commit_sha":"1a59d88c5fec26b9365a887297f422dce0dd2300","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514/commits","review_comments_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514/comments","review_comment_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/3514/comments","statuses_url":"https://api.github.com/repos/codemirror/CodeMirror/statuses/7e59da3c94a062a7f94c043cf78cdd67b3dd815a","head":{"label":"increpare:patch-5","ref":"patch-5","sha":"7e59da3c94a062a7f94c043cf78cdd67b3dd815a","user":{"login":"increpare","id":465632,"avatar_url":"https://avatars.githubusercontent.com/u/465632?v=3","gravatar_id":"","url":"https://api.github.com/users/increpare","html_url":"https://github.com/increpare","followers_url":"https://api.github.com/users/increpare/followers","following_url":"https://api.github.com/users/increpare/following{/other_user}","gists_url":"https://api.github.com/users/increpare/gists{/gist_id}","starred_url":"https://api.github.com/users/increpare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/increpare/subscriptions","organizations_url":"https://api.github.com/users/increpare/orgs","repos_url":"https://api.github.com/users/increpare/repos","events_url":"https://api.github.com/users/increpare/events{/privacy}","received_events_url":"https://api.github.com/users/increpare/received_events","type":"User","site_admin":false},"repo":{"id":41736000,"name":"CodeMirror","full_name":"increpare/CodeMirror","owner":{"login":"increpare","id":465632,"avatar_url":"https://avatars.githubusercontent.com/u/465632?v=3","gravatar_id":"","url":"https://api.github.com/users/increpare","html_url":"https://github.com/increpare","followers_url":"https://api.github.com/users/increpare/followers","following_url":"https://api.github.com/users/increpare/following{/other_user}","gists_url":"https://api.github.com/users/increpare/gists{/gist_id}","starred_url":"https://api.github.com/users/increpare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/increpare/subscriptions","organizations_url":"https://api.github.com/users/increpare/orgs","repos_url":"https://api.github.com/users/increpare/repos","events_url":"https://api.github.com/users/increpare/events{/privacy}","received_events_url":"https://api.github.com/users/increpare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/increpare/CodeMirror","description":"In-browser code editor","fork":true,"url":"https://api.github.com/repos/increpare/CodeMirror","forks_url":"https://api.github.com/repos/increpare/CodeMirror/forks","keys_url":"https://api.github.com/repos/increpare/CodeMirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/increpare/CodeMirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/increpare/CodeMirror/teams","hooks_url":"https://api.github.com/repos/increpare/CodeMirror/hooks","issue_events_url":"https://api.github.com/repos/increpare/CodeMirror/issues/events{/number}","events_url":"https://api.github.com/repos/increpare/CodeMirror/events","assignees_url":"https://api.github.com/repos/increpare/CodeMirror/assignees{/user}","branches_url":"https://api.github.com/repos/increpare/CodeMirror/branches{/branch}","tags_url":"https://api.github.com/repos/increpare/CodeMirror/tags","blobs_url":"https://api.github.com/repos/increpare/CodeMirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/increpare/CodeMirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/increpare/CodeMirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/increpare/CodeMirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/increpare/CodeMirror/statuses/{sha}","languages_url":"https://api.github.com/repos/increpare/CodeMirror/languages","stargazers_url":"https://api.github.com/repos/increpare/CodeMirror/stargazers","contributors_url":"https://api.github.com/repos/increpare/CodeMirror/contributors","subscribers_url":"https://api.github.com/repos/increpare/CodeMirror/subscribers","subscription_url":"https://api.github.com/repos/increpare/CodeMirror/subscription","commits_url":"https://api.github.com/repos/increpare/CodeMirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/increpare/CodeMirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/increpare/CodeMirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/increpare/CodeMirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/increpare/CodeMirror/contents/{+path}","compare_url":"https://api.github.com/repos/increpare/CodeMirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/increpare/CodeMirror/merges","archive_url":"https://api.github.com/repos/increpare/CodeMirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/increpare/CodeMirror/downloads","issues_url":"https://api.github.com/repos/increpare/CodeMirror/issues{/number}","pulls_url":"https://api.github.com/repos/increpare/CodeMirror/pulls{/number}","milestones_url":"https://api.github.com/repos/increpare/CodeMirror/milestones{/number}","notifications_url":"https://api.github.com/repos/increpare/CodeMirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/increpare/CodeMirror/labels{/name}","releases_url":"https://api.github.com/repos/increpare/CodeMirror/releases{/id}","created_at":"2015-09-01T12:00:03Z","updated_at":"2015-09-01T12:00:05Z","pushed_at":"2015-09-08T17:26:13Z","git_url":"git://github.com/increpare/CodeMirror.git","ssh_url":"git@github.com:increpare/CodeMirror.git","clone_url":"https://github.com/increpare/CodeMirror.git","svn_url":"https://github.com/increpare/CodeMirror","homepage":"http://codemirror.net/","size":15068,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codemirror:master","ref":"master","sha":"c9fb71cfec45314dfea8bfc4c0e78741cb9bcec6","user":{"login":"codemirror","id":8876537,"avatar_url":"https://avatars.githubusercontent.com/u/8876537?v=3","gravatar_id":"","url":"https://api.github.com/users/codemirror","html_url":"https://github.com/codemirror","followers_url":"https://api.github.com/users/codemirror/followers","following_url":"https://api.github.com/users/codemirror/following{/other_user}","gists_url":"https://api.github.com/users/codemirror/gists{/gist_id}","starred_url":"https://api.github.com/users/codemirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemirror/subscriptions","organizations_url":"https://api.github.com/users/codemirror/orgs","repos_url":"https://api.github.com/users/codemirror/repos","events_url":"https://api.github.com/users/codemirror/events{/privacy}","received_events_url":"https://api.github.com/users/codemirror/received_events","type":"Organization","site_admin":false},"repo":{"id":1254497,"name":"CodeMirror","full_name":"codemirror/CodeMirror","owner":{"login":"codemirror","id":8876537,"avatar_url":"https://avatars.githubusercontent.com/u/8876537?v=3","gravatar_id":"","url":"https://api.github.com/users/codemirror","html_url":"https://github.com/codemirror","followers_url":"https://api.github.com/users/codemirror/followers","following_url":"https://api.github.com/users/codemirror/following{/other_user}","gists_url":"https://api.github.com/users/codemirror/gists{/gist_id}","starred_url":"https://api.github.com/users/codemirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemirror/subscriptions","organizations_url":"https://api.github.com/users/codemirror/orgs","repos_url":"https://api.github.com/users/codemirror/repos","events_url":"https://api.github.com/users/codemirror/events{/privacy}","received_events_url":"https://api.github.com/users/codemirror/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codemirror/CodeMirror","description":"In-browser code editor","fork":false,"url":"https://api.github.com/repos/codemirror/CodeMirror","forks_url":"https://api.github.com/repos/codemirror/CodeMirror/forks","keys_url":"https://api.github.com/repos/codemirror/CodeMirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemirror/CodeMirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemirror/CodeMirror/teams","hooks_url":"https://api.github.com/repos/codemirror/CodeMirror/hooks","issue_events_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/events{/number}","events_url":"https://api.github.com/repos/codemirror/CodeMirror/events","assignees_url":"https://api.github.com/repos/codemirror/CodeMirror/assignees{/user}","branches_url":"https://api.github.com/repos/codemirror/CodeMirror/branches{/branch}","tags_url":"https://api.github.com/repos/codemirror/CodeMirror/tags","blobs_url":"https://api.github.com/repos/codemirror/CodeMirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemirror/CodeMirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemirror/CodeMirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemirror/CodeMirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemirror/CodeMirror/statuses/{sha}","languages_url":"https://api.github.com/repos/codemirror/CodeMirror/languages","stargazers_url":"https://api.github.com/repos/codemirror/CodeMirror/stargazers","contributors_url":"https://api.github.com/repos/codemirror/CodeMirror/contributors","subscribers_url":"https://api.github.com/repos/codemirror/CodeMirror/subscribers","subscription_url":"https://api.github.com/repos/codemirror/CodeMirror/subscription","commits_url":"https://api.github.com/repos/codemirror/CodeMirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemirror/CodeMirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemirror/CodeMirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemirror/CodeMirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemirror/CodeMirror/contents/{+path}","compare_url":"https://api.github.com/repos/codemirror/CodeMirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemirror/CodeMirror/merges","archive_url":"https://api.github.com/repos/codemirror/CodeMirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemirror/CodeMirror/downloads","issues_url":"https://api.github.com/repos/codemirror/CodeMirror/issues{/number}","pulls_url":"https://api.github.com/repos/codemirror/CodeMirror/pulls{/number}","milestones_url":"https://api.github.com/repos/codemirror/CodeMirror/milestones{/number}","notifications_url":"https://api.github.com/repos/codemirror/CodeMirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemirror/CodeMirror/labels{/name}","releases_url":"https://api.github.com/repos/codemirror/CodeMirror/releases{/id}","created_at":"2011-01-14T13:44:03Z","updated_at":"2015-09-09T04:48:28Z","pushed_at":"2015-09-09T09:57:18Z","git_url":"git://github.com/codemirror/CodeMirror.git","ssh_url":"git@github.com:codemirror/CodeMirror.git","clone_url":"https://github.com/codemirror/CodeMirror.git","svn_url":"https://github.com/codemirror/CodeMirror","homepage":"http://codemirror.net/","size":34207,"stargazers_count":7433,"watchers_count":7433,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1900,"mirror_url":null,"open_issues_count":64,"forks":1900,"open_issues":64,"watchers":7433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514"},"html":{"href":"https://github.com/codemirror/CodeMirror/pull/3514"},"issue":{"href":"https://api.github.com/repos/codemirror/CodeMirror/issues/3514"},"comments":{"href":"https://api.github.com/repos/codemirror/CodeMirror/issues/3514/comments"},"review_comments":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514/comments"},"review_comment":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codemirror/CodeMirror/pulls/3514/commits"},"statuses":{"href":"https://api.github.com/repos/codemirror/CodeMirror/statuses/7e59da3c94a062a7f94c043cf78cdd67b3dd815a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}