{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/45337175","id":45337175,"diff_hunk":"@@ -829,10 +829,10 @@ max_block_generate_distance (Max block generate distance) int 6\n map_generation_limit (Map generation limit) int 31000 0 31000\n \n #    Global map generation attributes.\n-#    The 'trees' flag only has effect in mgv6.\n+#    In Mapgen v6 'decorations' controls non-tree decorations.","path":"builtin/settingtypes.txt","position":5,"original_position":5,"commit_id":"4640fba2ea1a3a9bf2255979636edd53c5efaf4a","original_commit_id":"4640fba2ea1a3a9bf2255979636edd53c5efaf4a","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"It is a little sloppy, i'll improve it, thanks.","created_at":"2015-11-19T13:02:50Z","updated_at":"2015-11-19T13:02:50Z","html_url":"https://github.com/minetest/minetest/pull/3379#discussion_r45337175","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3379","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/45337175"},"html":{"href":"https://github.com/minetest/minetest/pull/3379#discussion_r45337175"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3379"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3379","id":50745416,"html_url":"https://github.com/minetest/minetest/pull/3379","diff_url":"https://github.com/minetest/minetest/pull/3379.diff","patch_url":"https://github.com/minetest/minetest/pull/3379.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3379","number":3379,"state":"open","locked":false,"title":"Mapgen: Add global 'decorations' flag","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"Flag is set by default in MapgenParams\r\nThe global 'trees' flag remains but is now\r\nundocumented and unset by default in MapgenParams\r\nAdd mgv6_spflag 'trees' set by default in\r\ndefaultsettings.cpp to affect new worlds only\r\nThis is automatically backwards\r\ncompatible for existing worlds\r\n\r\nEasily switchable decorations is needed for mgflat but is useful for all mapgens.\r\nIn mgv6 trees and non-tree decorations are independently switchable.\r\nThe plans for flags were briefly discussed here https://github.com/minetest/minetest/pull/3313#issuecomment-152686605\r\nTest worlds were used to confirm this does not break existing worlds.","created_at":"2015-11-15T12:16:45Z","updated_at":"2015-11-19T13:02:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b0cbf0a6e32c67fdcb2fe4e91297bdf4872eee0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3379/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3379/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3379/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/4640fba2ea1a3a9bf2255979636edd53c5efaf4a","head":{"label":"paramat:mgflagdeco","ref":"mgflagdeco","sha":"4640fba2ea1a3a9bf2255979636edd53c5efaf4a","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"repo":{"id":25287736,"name":"minetest","full_name":"paramat/minetest","owner":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paramat/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/paramat/minetest","forks_url":"https://api.github.com/repos/paramat/minetest/forks","keys_url":"https://api.github.com/repos/paramat/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paramat/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paramat/minetest/teams","hooks_url":"https://api.github.com/repos/paramat/minetest/hooks","issue_events_url":"https://api.github.com/repos/paramat/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/paramat/minetest/events","assignees_url":"https://api.github.com/repos/paramat/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/paramat/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/paramat/minetest/tags","blobs_url":"https://api.github.com/repos/paramat/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paramat/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paramat/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/paramat/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paramat/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/paramat/minetest/languages","stargazers_url":"https://api.github.com/repos/paramat/minetest/stargazers","contributors_url":"https://api.github.com/repos/paramat/minetest/contributors","subscribers_url":"https://api.github.com/repos/paramat/minetest/subscribers","subscription_url":"https://api.github.com/repos/paramat/minetest/subscription","commits_url":"https://api.github.com/repos/paramat/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/paramat/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/paramat/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/paramat/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/paramat/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/paramat/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paramat/minetest/merges","archive_url":"https://api.github.com/repos/paramat/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paramat/minetest/downloads","issues_url":"https://api.github.com/repos/paramat/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/paramat/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/paramat/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/paramat/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paramat/minetest/labels{/name}","releases_url":"https://api.github.com/repos/paramat/minetest/releases{/id}","created_at":"2014-10-16T05:25:29Z","updated_at":"2015-05-07T23:23:03Z","pushed_at":"2015-11-19T11:19:35Z","git_url":"git://github.com/paramat/minetest.git","ssh_url":"git@github.com:paramat/minetest.git","clone_url":"https://github.com/paramat/minetest.git","svn_url":"https://github.com/paramat/minetest","homepage":"http://minetest.net/","size":40633,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"2f58e4d9624b4f31c5064dc640e0ad40d8adb9ea","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-11-19T00:58:29Z","pushed_at":"2015-11-18T22:15:35Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":110372,"stargazers_count":1685,"watchers_count":1685,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"open_issues_count":633,"forks":564,"open_issues":633,"watchers":1685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3379"},"html":{"href":"https://github.com/minetest/minetest/pull/3379"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3379"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3379/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3379/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3379/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/4640fba2ea1a3a9bf2255979636edd53c5efaf4a"}}}}