{"action":"created","issue":{"url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/723","labels_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/723/comments","events_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/723/events","html_url":"https://github.com/KSP-RO/RealismOverhaul/pull/723","id":119311729,"number":723,"title":"RO LR-87 LH2 update","user":{"login":"PhineasFreak","id":14848060,"avatar_url":"https://avatars.githubusercontent.com/u/14848060?v=3","gravatar_id":"","url":"https://api.github.com/users/PhineasFreak","html_url":"https://github.com/PhineasFreak","followers_url":"https://api.github.com/users/PhineasFreak/followers","following_url":"https://api.github.com/users/PhineasFreak/following{/other_user}","gists_url":"https://api.github.com/users/PhineasFreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PhineasFreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhineasFreak/subscriptions","organizations_url":"https://api.github.com/users/PhineasFreak/orgs","repos_url":"https://api.github.com/users/PhineasFreak/repos","events_url":"https://api.github.com/users/PhineasFreak/events{/privacy}","received_events_url":"https://api.github.com/users/PhineasFreak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-28T18:29:32Z","updated_at":"2015-11-28T22:58:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/pulls/723","html_url":"https://github.com/KSP-RO/RealismOverhaul/pull/723","diff_url":"https://github.com/KSP-RO/RealismOverhaul/pull/723.diff","patch_url":"https://github.com/KSP-RO/RealismOverhaul/pull/723.patch"},"body":"* Remove redundant FX (already taken care by the RealPlume\r\nconfiguration) and duplicated EFFECTS definitions.\r\n* Add support for the KSP 1.0.5 engine thermal changes.\r\n* Fix a null reference exception caused by a wrong default engine config name.\r\n* Replace the deprecated EngineIgnitor modules with the RealFuels fuel & ullage functionality.\r\n* Remove the leftover engine alternator module and ElectricCharge\r\nresource."},"comment":{"url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/comments/160344007","html_url":"https://github.com/KSP-RO/RealismOverhaul/pull/723#issuecomment-160344007","issue_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/723","id":160344007,"user":{"login":"PhineasFreak","id":14848060,"avatar_url":"https://avatars.githubusercontent.com/u/14848060?v=3","gravatar_id":"","url":"https://api.github.com/users/PhineasFreak","html_url":"https://github.com/PhineasFreak","followers_url":"https://api.github.com/users/PhineasFreak/followers","following_url":"https://api.github.com/users/PhineasFreak/following{/other_user}","gists_url":"https://api.github.com/users/PhineasFreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PhineasFreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhineasFreak/subscriptions","organizations_url":"https://api.github.com/users/PhineasFreak/orgs","repos_url":"https://api.github.com/users/PhineasFreak/repos","events_url":"https://api.github.com/users/PhineasFreak/events{/privacy}","received_events_url":"https://api.github.com/users/PhineasFreak/received_events","type":"User","site_admin":false},"created_at":"2015-11-28T22:58:17Z","updated_at":"2015-11-28T22:58:17Z","body":"Yes, RealPlume already has a patch to delete all FX and EFFECTS{} nodes from any engine that it finds. You may return these lines there, i removed them because of the above reason.\r\n\r\nThe %powerEffectName was already defined as such (exactly the same line) in the RealPlume config for that engine, so it added two different effect names. The \"name\" was deleted accidentally (ugh!) and thank you for bringing that into my attention! Also, i made another mistake withe the \"EngineType\": it should be \"LiquidFuel\" and not \"LiquidEngine\"...\r\n\r\nFor the engine thermal changes: it increases a bit the overall thermal radiation capability of the engine (cools faster after shutdown) and lowers the thermal conduction (reduces a bit the heat conducted to the tank that is mounted). Maybe @NathanKell could provide some info of how these values further affect the parts that include them. For now, these values are taken from the stock engine configs."}}