{"action":"created","comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/31231435","id":31231435,"diff_hunk":"@@ -28,20 +35,32 @@ public static ContactsActor getDefault() {\n \tprivate static final String RETRIEVE_CONTACTS = \"retrieveContacts\";\n \tprivate static final String REMOVE_CONTACTS = \"removeContacts\";\n \n+\t/**\n+\t * Creates a new ContactActor with given contacts. Uses the default EventEmitter.\n+\t * @param contacts Contacts to use in ContactActor\n+\t */\n \tpublic ContactsActor (Contacts contacts) {","path":"src/main/java/de/qabel/core/config/ContactsActor.java","position":43,"original_position":43,"commit_id":"884553c8e9b406b2e04155ee407210a57a37f6e5","original_commit_id":"884553c8e9b406b2e04155ee407210a57a37f6e5","user":{"login":"thechauffeur","id":150507,"avatar_url":"https://avatars.githubusercontent.com/u/150507?v=3","gravatar_id":"","url":"https://api.github.com/users/thechauffeur","html_url":"https://github.com/thechauffeur","followers_url":"https://api.github.com/users/thechauffeur/followers","following_url":"https://api.github.com/users/thechauffeur/following{/other_user}","gists_url":"https://api.github.com/users/thechauffeur/gists{/gist_id}","starred_url":"https://api.github.com/users/thechauffeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechauffeur/subscriptions","organizations_url":"https://api.github.com/users/thechauffeur/orgs","repos_url":"https://api.github.com/users/thechauffeur/repos","events_url":"https://api.github.com/users/thechauffeur/events{/privacy}","received_events_url":"https://api.github.com/users/thechauffeur/received_events","type":"User","site_admin":false},"body":"Is this constructor ever needed solely? Or will it just be called from the other constructors? If so please do not provide this constructor.","created_at":"2015-05-28T13:18:37Z","updated_at":"2015-05-28T13:18:37Z","html_url":"https://github.com/Qabel/qabel-core/pull/329#discussion_r31231435","pull_request_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/31231435"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/329#discussion_r31231435"},"pull_request":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/329","id":35313400,"html_url":"https://github.com/Qabel/qabel-core/pull/329","diff_url":"https://github.com/Qabel/qabel-core/pull/329.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/329.patch","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329","number":329,"state":"open","locked":false,"title":"Refactored DropActor","user":{"login":"L-Henke","id":7975219,"avatar_url":"https://avatars.githubusercontent.com/u/7975219?v=3","gravatar_id":"","url":"https://api.github.com/users/L-Henke","html_url":"https://github.com/L-Henke","followers_url":"https://api.github.com/users/L-Henke/followers","following_url":"https://api.github.com/users/L-Henke/following{/other_user}","gists_url":"https://api.github.com/users/L-Henke/gists{/gist_id}","starred_url":"https://api.github.com/users/L-Henke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-Henke/subscriptions","organizations_url":"https://api.github.com/users/L-Henke/orgs","repos_url":"https://api.github.com/users/L-Henke/repos","events_url":"https://api.github.com/users/L-Henke/events{/privacy}","received_events_url":"https://api.github.com/users/L-Henke/received_events","type":"User","site_admin":false},"body":"Refactored DropActor to get resources via events. ~~The ContactActorTest has some concurrency issues, because modifying contacts is done in a different thread, which cannot be joined anymore. This might be avoided with a simple sleep, but maybe there is a cleaner solution.~~ EDIT: ContactActorTest now listens to contact added and removed events to wait until events has been processed.\r\n\r\n- [X] Get Contacts via event\r\n- [x] Get Identities via event\r\n- [x] Get DropServers via event\r\n- [x] Eliminated concurrency problems with ContactActorTest\r\n\r\n~~This is related to #327, but does not closes it in the current state.~~\r\nThe unregister method from https://github.com/Qabel/ackack/pull/7 is required for this PR.\r\n\r\nSynchronization may get further optimized.\r\n\r\nRequires #334 \r\n- [ ] Fix timeout with large persistence file\r\n- [ ] Default LocalSettings\r\n- [ ] Define when to emit config changes\r\n- [ ] Check synchronization in Config and ContactActor\r\n\r\nFixes #336 \r\nCloses #327 ","created_at":"2015-05-13T10:30:41Z","updated_at":"2015-05-28T13:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7bc59e2fedc0dfc3df979b7bc1697e7ccf1843e","assignee":{"login":"L-Henke","id":7975219,"avatar_url":"https://avatars.githubusercontent.com/u/7975219?v=3","gravatar_id":"","url":"https://api.github.com/users/L-Henke","html_url":"https://github.com/L-Henke","followers_url":"https://api.github.com/users/L-Henke/followers","following_url":"https://api.github.com/users/L-Henke/following{/other_user}","gists_url":"https://api.github.com/users/L-Henke/gists{/gist_id}","starred_url":"https://api.github.com/users/L-Henke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-Henke/subscriptions","organizations_url":"https://api.github.com/users/L-Henke/orgs","repos_url":"https://api.github.com/users/L-Henke/repos","events_url":"https://api.github.com/users/L-Henke/events{/privacy}","received_events_url":"https://api.github.com/users/L-Henke/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/329/commits","review_comments_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/329/comments","review_comment_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329/comments","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/884553c8e9b406b2e04155ee407210a57a37f6e5","head":{"label":"L-Henke:dropRefactor","ref":"dropRefactor","sha":"884553c8e9b406b2e04155ee407210a57a37f6e5","user":{"login":"L-Henke","id":7975219,"avatar_url":"https://avatars.githubusercontent.com/u/7975219?v=3","gravatar_id":"","url":"https://api.github.com/users/L-Henke","html_url":"https://github.com/L-Henke","followers_url":"https://api.github.com/users/L-Henke/followers","following_url":"https://api.github.com/users/L-Henke/following{/other_user}","gists_url":"https://api.github.com/users/L-Henke/gists{/gist_id}","starred_url":"https://api.github.com/users/L-Henke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-Henke/subscriptions","organizations_url":"https://api.github.com/users/L-Henke/orgs","repos_url":"https://api.github.com/users/L-Henke/repos","events_url":"https://api.github.com/users/L-Henke/events{/privacy}","received_events_url":"https://api.github.com/users/L-Henke/received_events","type":"User","site_admin":false},"repo":{"id":24596150,"name":"qabel-core","full_name":"L-Henke/qabel-core","owner":{"login":"L-Henke","id":7975219,"avatar_url":"https://avatars.githubusercontent.com/u/7975219?v=3","gravatar_id":"","url":"https://api.github.com/users/L-Henke","html_url":"https://github.com/L-Henke","followers_url":"https://api.github.com/users/L-Henke/followers","following_url":"https://api.github.com/users/L-Henke/following{/other_user}","gists_url":"https://api.github.com/users/L-Henke/gists{/gist_id}","starred_url":"https://api.github.com/users/L-Henke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-Henke/subscriptions","organizations_url":"https://api.github.com/users/L-Henke/orgs","repos_url":"https://api.github.com/users/L-Henke/repos","events_url":"https://api.github.com/users/L-Henke/events{/privacy}","received_events_url":"https://api.github.com/users/L-Henke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/L-Henke/qabel-core","description":"Implementation of Qabel-Core in Java","fork":true,"url":"https://api.github.com/repos/L-Henke/qabel-core","forks_url":"https://api.github.com/repos/L-Henke/qabel-core/forks","keys_url":"https://api.github.com/repos/L-Henke/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/L-Henke/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/L-Henke/qabel-core/teams","hooks_url":"https://api.github.com/repos/L-Henke/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/L-Henke/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/L-Henke/qabel-core/events","assignees_url":"https://api.github.com/repos/L-Henke/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/L-Henke/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/L-Henke/qabel-core/tags","blobs_url":"https://api.github.com/repos/L-Henke/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/L-Henke/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/L-Henke/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/L-Henke/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/L-Henke/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/L-Henke/qabel-core/languages","stargazers_url":"https://api.github.com/repos/L-Henke/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/L-Henke/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/L-Henke/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/L-Henke/qabel-core/subscription","commits_url":"https://api.github.com/repos/L-Henke/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/L-Henke/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/L-Henke/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/L-Henke/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/L-Henke/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/L-Henke/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/L-Henke/qabel-core/merges","archive_url":"https://api.github.com/repos/L-Henke/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/L-Henke/qabel-core/downloads","issues_url":"https://api.github.com/repos/L-Henke/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/L-Henke/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/L-Henke/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/L-Henke/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/L-Henke/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/L-Henke/qabel-core/releases{/id}","created_at":"2014-09-29T13:24:27Z","updated_at":"2015-04-02T10:57:28Z","pushed_at":"2015-05-21T15:45:04Z","git_url":"git://github.com/L-Henke/qabel-core.git","ssh_url":"git@github.com:L-Henke/qabel-core.git","clone_url":"https://github.com/L-Henke/qabel-core.git","svn_url":"https://github.com/L-Henke/qabel-core","homepage":null,"size":4149,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qabel:master","ref":"master","sha":"c97c856a2e9a614747c950973a3d73f109bc6bb5","user":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"repo":{"id":22873447,"name":"qabel-core","full_name":"Qabel/qabel-core","owner":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qabel/qabel-core","description":"Implementation of Qabel-Core in Java","fork":false,"url":"https://api.github.com/repos/Qabel/qabel-core","forks_url":"https://api.github.com/repos/Qabel/qabel-core/forks","keys_url":"https://api.github.com/repos/Qabel/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qabel/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qabel/qabel-core/teams","hooks_url":"https://api.github.com/repos/Qabel/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/Qabel/qabel-core/events","assignees_url":"https://api.github.com/repos/Qabel/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/Qabel/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/Qabel/qabel-core/tags","blobs_url":"https://api.github.com/repos/Qabel/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qabel/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qabel/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qabel/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Qabel/qabel-core/languages","stargazers_url":"https://api.github.com/repos/Qabel/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/Qabel/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/Qabel/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/Qabel/qabel-core/subscription","commits_url":"https://api.github.com/repos/Qabel/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qabel/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qabel/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/Qabel/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qabel/qabel-core/merges","archive_url":"https://api.github.com/repos/Qabel/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qabel/qabel-core/downloads","issues_url":"https://api.github.com/repos/Qabel/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/Qabel/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Qabel/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Qabel/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qabel/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/Qabel/qabel-core/releases{/id}","created_at":"2014-08-12T10:25:10Z","updated_at":"2015-04-28T15:26:19Z","pushed_at":"2015-05-27T16:17:34Z","git_url":"git://github.com/Qabel/qabel-core.git","ssh_url":"git@github.com:Qabel/qabel-core.git","clone_url":"https://github.com/Qabel/qabel-core.git","svn_url":"https://github.com/Qabel/qabel-core","homepage":null,"size":7155,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":27,"forks":12,"open_issues":27,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/329"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/329"},"issue":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/329"},"comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/Qabel/qabel-core/statuses/884553c8e9b406b2e04155ee407210a57a37f6e5"}}}}