{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom/pulls/comments/33981253","id":33981253,"diff_hunk":"@@ -286,6 +290,34 @@ describe \"PackageManager\", ->\n             expect(addErrorHandler.callCount).toBe 1\n             expect(addErrorHandler.argsForCall[0][0].message).toContain(\"Failed to load the package-with-invalid-settings package settings\")\n \n+    describe \"when the package metadata includes `activationHooks`\", ->\n+      [mainModule, promise] = []\n+\n+      beforeEach ->\n+        jasmine.attachToDOM(workspaceElement)","path":"spec/package-manager-spec.coffee","position":33,"original_position":33,"commit_id":"ca385dfc8bdedce842f11d326af2064b2216ff20","original_commit_id":"ca385dfc8bdedce842f11d326af2064b2216ff20","user":{"login":"nathansobo","id":1789,"avatar_url":"https://avatars.githubusercontent.com/u/1789?v=3","gravatar_id":"","url":"https://api.github.com/users/nathansobo","html_url":"https://github.com/nathansobo","followers_url":"https://api.github.com/users/nathansobo/followers","following_url":"https://api.github.com/users/nathansobo/following{/other_user}","gists_url":"https://api.github.com/users/nathansobo/gists{/gist_id}","starred_url":"https://api.github.com/users/nathansobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathansobo/subscriptions","organizations_url":"https://api.github.com/users/nathansobo/orgs","repos_url":"https://api.github.com/users/nathansobo/repos","events_url":"https://api.github.com/users/nathansobo/events{/privacy}","received_events_url":"https://api.github.com/users/nathansobo/received_events","type":"User","site_admin":true},"body":"Seems like we shouldn't need the workspace element to be on the DOM here. Is this a leftover?","created_at":"2015-07-06T20:55:52Z","updated_at":"2015-07-06T20:55:52Z","html_url":"https://github.com/atom/atom/pull/7638#discussion_r33981253","pull_request_url":"https://api.github.com/repos/atom/atom/pulls/7638","_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/comments/33981253"},"html":{"href":"https://github.com/atom/atom/pull/7638#discussion_r33981253"},"pull_request":{"href":"https://api.github.com/repos/atom/atom/pulls/7638"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/7638","id":39021303,"html_url":"https://github.com/atom/atom/pull/7638","diff_url":"https://github.com/atom/atom/pull/7638.diff","patch_url":"https://github.com/atom/atom/pull/7638.patch","issue_url":"https://api.github.com/repos/atom/atom/issues/7638","number":7638,"state":"open","locked":false,"title":"Add activationHooks + Trigger `{grammar-package-name}:grammar-used` Hook When A text-editor-element's Grammar Is Set","user":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?v=3","gravatar_id":"","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"body":"This PR:\r\n\r\n* Adds `activationHooks` to package.json\r\n* Triggers the `{grammar-package-name}:grammar-used` hook when a text-editor-element's grammar is set\r\n\r\nThis allows package authors to defer package activation for language-specific packages until the first use of the grammar(s) their package serves. It also leaves open the possibility to trigger other activation hooks in the future with minimal code.\r\n\r\n- Fixes #6629\r\n\r\n/cc @kevinsawicki","created_at":"2015-07-01T20:22:21Z","updated_at":"2015-07-06T20:55:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a87ccde1ac16e5da78c1bf432c8509eec323ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom/pulls/7638/commits","review_comments_url":"https://api.github.com/repos/atom/atom/pulls/7638/comments","review_comment_url":"https://api.github.com/repos/atom/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom/issues/7638/comments","statuses_url":"https://api.github.com/repos/atom/atom/statuses/ca385dfc8bdedce842f11d326af2064b2216ff20","head":{"label":"atom-community:jf-dispatch-grammar-used","ref":"jf-dispatch-grammar-used","sha":"ca385dfc8bdedce842f11d326af2064b2216ff20","user":{"login":"atom-community","id":9948688,"avatar_url":"https://avatars.githubusercontent.com/u/9948688?v=3","gravatar_id":"","url":"https://api.github.com/users/atom-community","html_url":"https://github.com/atom-community","followers_url":"https://api.github.com/users/atom-community/followers","following_url":"https://api.github.com/users/atom-community/following{/other_user}","gists_url":"https://api.github.com/users/atom-community/gists{/gist_id}","starred_url":"https://api.github.com/users/atom-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom-community/subscriptions","organizations_url":"https://api.github.com/users/atom-community/orgs","repos_url":"https://api.github.com/users/atom-community/repos","events_url":"https://api.github.com/users/atom-community/events{/privacy}","received_events_url":"https://api.github.com/users/atom-community/received_events","type":"Organization","site_admin":false},"repo":{"id":30045191,"name":"atom","full_name":"atom-community/atom","owner":{"login":"atom-community","id":9948688,"avatar_url":"https://avatars.githubusercontent.com/u/9948688?v=3","gravatar_id":"","url":"https://api.github.com/users/atom-community","html_url":"https://github.com/atom-community","followers_url":"https://api.github.com/users/atom-community/followers","following_url":"https://api.github.com/users/atom-community/following{/other_user}","gists_url":"https://api.github.com/users/atom-community/gists{/gist_id}","starred_url":"https://api.github.com/users/atom-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom-community/subscriptions","organizations_url":"https://api.github.com/users/atom-community/orgs","repos_url":"https://api.github.com/users/atom-community/repos","events_url":"https://api.github.com/users/atom-community/events{/privacy}","received_events_url":"https://api.github.com/users/atom-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom-community/atom","description":"The hackable editor","fork":true,"url":"https://api.github.com/repos/atom-community/atom","forks_url":"https://api.github.com/repos/atom-community/atom/forks","keys_url":"https://api.github.com/repos/atom-community/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom-community/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom-community/atom/teams","hooks_url":"https://api.github.com/repos/atom-community/atom/hooks","issue_events_url":"https://api.github.com/repos/atom-community/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom-community/atom/events","assignees_url":"https://api.github.com/repos/atom-community/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom-community/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom-community/atom/tags","blobs_url":"https://api.github.com/repos/atom-community/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom-community/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom-community/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom-community/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom-community/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom-community/atom/languages","stargazers_url":"https://api.github.com/repos/atom-community/atom/stargazers","contributors_url":"https://api.github.com/repos/atom-community/atom/contributors","subscribers_url":"https://api.github.com/repos/atom-community/atom/subscribers","subscription_url":"https://api.github.com/repos/atom-community/atom/subscription","commits_url":"https://api.github.com/repos/atom-community/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom-community/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom-community/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom-community/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom-community/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom-community/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom-community/atom/merges","archive_url":"https://api.github.com/repos/atom-community/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom-community/atom/downloads","issues_url":"https://api.github.com/repos/atom-community/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom-community/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom-community/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom-community/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom-community/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom-community/atom/releases{/id}","created_at":"2015-01-29T22:48:37Z","updated_at":"2015-03-06T17:01:09Z","pushed_at":"2015-07-02T23:21:16Z","git_url":"git://github.com/atom-community/atom.git","ssh_url":"git@github.com:atom-community/atom.git","clone_url":"https://github.com/atom-community/atom.git","svn_url":"https://github.com/atom-community/atom","homepage":"https://atom.io/","size":268454,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"15150a80ee3f8433391b3e733470d4c6981b4872","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":"The hackable text editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","created_at":"2012-01-20T18:18:21Z","updated_at":"2015-07-06T20:27:11Z","pushed_at":"2015-07-06T18:18:44Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io","size":350558,"stargazers_count":18232,"watchers_count":18232,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3177,"mirror_url":null,"open_issues_count":1262,"forks":3177,"open_issues":1262,"watchers":18232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/7638"},"html":{"href":"https://github.com/atom/atom/pull/7638"},"issue":{"href":"https://api.github.com/repos/atom/atom/issues/7638"},"comments":{"href":"https://api.github.com/repos/atom/atom/issues/7638/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom/pulls/7638/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom/pulls/7638/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom/statuses/ca385dfc8bdedce842f11d326af2064b2216ff20"}}}}