{"action":"created","comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/41087083","id":41087083,"diff_hunk":"@@ -0,0 +1,43 @@\n+//\n+//package appeng.core.sync.packets;\n+//\n+//\n+//import io.netty.buffer.ByteBuf;\n+//\n+//import appeng.core.sync.AppEngPacket;\n+//\n+//\n+///**\n+// * An abstract packet providing basic information about an {@link AppEngPacket}.\n+// *\n+// */\n+//public abstract class AbstractPacket implements AppEngPacket\n+//{","path":"src/main/java/appeng/core/sync/packets/AbstractPacket.java","position":15,"original_position":15,"commit_id":"e1ca63e4b0fdcb27655a567c743c720ccaf70b58","original_commit_id":"e1ca63e4b0fdcb27655a567c743c720ccaf70b58","user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars.githubusercontent.com/u/14347709?v=3","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) This block of commented-out lines of code should be removed. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n","created_at":"2015-10-03T13:21:10Z","updated_at":"2015-10-03T13:21:10Z","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780#discussion_r41087083","pull_request_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780","_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/41087083"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780#discussion_r41087083"},"pull_request":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780"}}},"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780","id":41952702,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780.patch","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1780","number":1780,"state":"open","locked":false,"title":"Replaced custom network handling with SimpleNetworkWrapper","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"body":"This aims to replace the custom packet handling of AE2 through the one provided by Forge itself.\r\nAlso in preparation of 1.8 and its threaded packet handling.\r\n\r\nCurrently it is not ready to merge, but as preview to find potentially bugs.\r\n\r\nEverything should still work as previous, but some features are currently missing.\r\nThese are\r\n* Splitting the Packet and PacketHandler into their own classes\r\n* Packet Logging\r\n* Compression (especially for the network inventory)\r\n\r\nSplitting the packet and handler should be pretty straightforward, but it should also split the few packets used on client and server side to have a clear seperation and not branch based on the current context\r\n\r\nThe current compression feels really hacky and should be replaced with something else. The best option would be really to use the netty pipeline to compress it transparent and do not need to handle it in the packets at all. As most packets are actually pretty small, compressing them might not be ideal, so we might need two or more channels. One for uncompressed and one for compressed data. Maybe this also requires different channels for client->server and server->client communication.\r\n\r\nNo idea currently about the logging. This could also be done via the netty pipeline, but currently seems not to work.","created_at":"2015-08-08T11:21:31Z","updated_at":"2015-10-03T13:21:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53b765b292fc3875c961c8f108808316755b63de","assignee":null,"milestone":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones/4","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/milestones/rv3%20-%201.7.10","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones/4/labels","id":879928,"number":4,"title":"rv3 - 1.7.10","description":"","creator":{"login":"thatsIch","id":2210496,"avatar_url":"https://avatars.githubusercontent.com/u/2210496?v=3","gravatar_id":"","url":"https://api.github.com/users/thatsIch","html_url":"https://github.com/thatsIch","followers_url":"https://api.github.com/users/thatsIch/followers","following_url":"https://api.github.com/users/thatsIch/following{/other_user}","gists_url":"https://api.github.com/users/thatsIch/gists{/gist_id}","starred_url":"https://api.github.com/users/thatsIch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatsIch/subscriptions","organizations_url":"https://api.github.com/users/thatsIch/orgs","repos_url":"https://api.github.com/users/thatsIch/repos","events_url":"https://api.github.com/users/thatsIch/events{/privacy}","received_events_url":"https://api.github.com/users/thatsIch/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":83,"state":"open","created_at":"2014-11-25T14:30:36Z","updated_at":"2015-09-26T09:40:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780/commits","review_comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780/comments","review_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1780/comments","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/e1ca63e4b0fdcb27655a567c743c720ccaf70b58","head":{"label":"yueh:feature-network-refactoring","ref":"feature-network-refactoring","sha":"e1ca63e4b0fdcb27655a567c743c720ccaf70b58","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"repo":{"id":24421290,"name":"Applied-Energistics-2","full_name":"yueh/Applied-Energistics-2","owner":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yueh/Applied-Energistics-2","description":"A Mod about Matter, Energy and using them to conquer the world..","fork":true,"url":"https://api.github.com/repos/yueh/Applied-Energistics-2","forks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T15:45:12Z","updated_at":"2015-04-28T16:29:30Z","pushed_at":"2015-10-03T13:18:27Z","git_url":"git://github.com/yueh/Applied-Energistics-2.git","ssh_url":"git@github.com:yueh/Applied-Energistics-2.git","clone_url":"https://github.com/yueh/Applied-Energistics-2.git","svn_url":"https://github.com/yueh/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":12927,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AppliedEnergistics:master","ref":"master","sha":"d52efa8f7881def1529565ce62121265ab83c1bc","user":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"repo":{"id":24395109,"name":"Applied-Energistics-2","full_name":"AppliedEnergistics/Applied-Energistics-2","owner":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":false,"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","forks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T00:48:40Z","updated_at":"2015-10-03T03:21:31Z","pushed_at":"2015-10-03T13:18:28Z","git_url":"git://github.com/AppliedEnergistics/Applied-Energistics-2.git","ssh_url":"git@github.com:AppliedEnergistics/Applied-Energistics-2.git","clone_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2.git","svn_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":24420,"stargazers_count":281,"watchers_count":281,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":122,"mirror_url":null,"open_issues_count":236,"forks":122,"open_issues":236,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1780"},"issue":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1780"},"comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1780/comments"},"review_comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780/comments"},"review_comment":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1780/commits"},"statuses":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/e1ca63e4b0fdcb27655a567c743c720ccaf70b58"}}}}