{"action":"created","comment":{"url":"https://api.github.com/repos/ifwe/api-client-js/pulls/comments/36658373","id":36658373,"diff_hunk":"@@ -8,8 +8,13 @@\n     function AngularAdapter($http, $window) {\n         this._$http = $http;\n         this._$window = $window;\n+        this._timeout = 10000;\n     }\n \n+    AngularAdapter.prototype.setTimeout = function(timeout) {","path":"lib/http_adapter/angular.js","position":7,"original_position":7,"commit_id":"349cd39a56dead76928def16ff4b5e8a5a17af22","original_commit_id":"349cd39a56dead76928def16ff4b5e8a5a17af22","user":{"login":"djvirgen","id":308786,"avatar_url":"https://avatars.githubusercontent.com/u/308786?v=3","gravatar_id":"","url":"https://api.github.com/users/djvirgen","html_url":"https://github.com/djvirgen","followers_url":"https://api.github.com/users/djvirgen/followers","following_url":"https://api.github.com/users/djvirgen/following{/other_user}","gists_url":"https://api.github.com/users/djvirgen/gists{/gist_id}","starred_url":"https://api.github.com/users/djvirgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djvirgen/subscriptions","organizations_url":"https://api.github.com/users/djvirgen/orgs","repos_url":"https://api.github.com/users/djvirgen/repos","events_url":"https://api.github.com/users/djvirgen/events{/privacy}","received_events_url":"https://api.github.com/users/djvirgen/received_events","type":"User","site_admin":false},"body":"I agree, I could probably generalize this a bit more to allow for arbitrary HTTP options. Something like:\r\n\r\n    AngularAdapter.prototype.setHttpOptions({\r\n        timeout: 30000\r\n    });","created_at":"2015-08-10T17:24:21Z","updated_at":"2015-08-10T17:24:21Z","html_url":"https://github.com/ifwe/api-client-js/pull/20#discussion_r36658373","pull_request_url":"https://api.github.com/repos/ifwe/api-client-js/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/comments/36658373"},"html":{"href":"https://github.com/ifwe/api-client-js/pull/20#discussion_r36658373"},"pull_request":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/ifwe/api-client-js/pulls/20","id":41944630,"html_url":"https://github.com/ifwe/api-client-js/pull/20","diff_url":"https://github.com/ifwe/api-client-js/pull/20.diff","patch_url":"https://github.com/ifwe/api-client-js/pull/20.patch","issue_url":"https://api.github.com/repos/ifwe/api-client-js/issues/20","number":20,"state":"open","locked":false,"title":"Allows HTTP timeout to be configured.","user":{"login":"djvirgen","id":308786,"avatar_url":"https://avatars.githubusercontent.com/u/308786?v=3","gravatar_id":"","url":"https://api.github.com/users/djvirgen","html_url":"https://github.com/djvirgen","followers_url":"https://api.github.com/users/djvirgen/followers","following_url":"https://api.github.com/users/djvirgen/following{/other_user}","gists_url":"https://api.github.com/users/djvirgen/gists{/gist_id}","starred_url":"https://api.github.com/users/djvirgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djvirgen/subscriptions","organizations_url":"https://api.github.com/users/djvirgen/orgs","repos_url":"https://api.github.com/users/djvirgen/repos","events_url":"https://api.github.com/users/djvirgen/events{/privacy}","received_events_url":"https://api.github.com/users/djvirgen/received_events","type":"User","site_admin":false},"body":"    // In node:\r\n    app.use(TaggedApi.middleware(host, {\r\n      timeout: 30000 // 30 seconds\r\n    });\r\n\r\n    // In Angular\r\n    app.config(function(taggedApiProvider) {\r\n      taggedApiProvider.timeout = 30000; // 30 seconds\r\n    });","created_at":"2015-08-08T00:31:18Z","updated_at":"2015-08-10T17:24:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"389954b521a2b90a871e34e01ff2e28b653b454e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ifwe/api-client-js/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ifwe/api-client-js/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ifwe/api-client-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ifwe/api-client-js/issues/20/comments","statuses_url":"https://api.github.com/repos/ifwe/api-client-js/statuses/349cd39a56dead76928def16ff4b5e8a5a17af22","head":{"label":"ifwe:configurable-timeout","ref":"configurable-timeout","sha":"349cd39a56dead76928def16ff4b5e8a5a17af22","user":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"repo":{"id":21753480,"name":"api-client-js","full_name":"ifwe/api-client-js","owner":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ifwe/api-client-js","description":"Tagged API client for Node and the Browser","fork":false,"url":"https://api.github.com/repos/ifwe/api-client-js","forks_url":"https://api.github.com/repos/ifwe/api-client-js/forks","keys_url":"https://api.github.com/repos/ifwe/api-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifwe/api-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifwe/api-client-js/teams","hooks_url":"https://api.github.com/repos/ifwe/api-client-js/hooks","issue_events_url":"https://api.github.com/repos/ifwe/api-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/ifwe/api-client-js/events","assignees_url":"https://api.github.com/repos/ifwe/api-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/ifwe/api-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/ifwe/api-client-js/tags","blobs_url":"https://api.github.com/repos/ifwe/api-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifwe/api-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifwe/api-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifwe/api-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifwe/api-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ifwe/api-client-js/languages","stargazers_url":"https://api.github.com/repos/ifwe/api-client-js/stargazers","contributors_url":"https://api.github.com/repos/ifwe/api-client-js/contributors","subscribers_url":"https://api.github.com/repos/ifwe/api-client-js/subscribers","subscription_url":"https://api.github.com/repos/ifwe/api-client-js/subscription","commits_url":"https://api.github.com/repos/ifwe/api-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifwe/api-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifwe/api-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifwe/api-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifwe/api-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/ifwe/api-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifwe/api-client-js/merges","archive_url":"https://api.github.com/repos/ifwe/api-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifwe/api-client-js/downloads","issues_url":"https://api.github.com/repos/ifwe/api-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/ifwe/api-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ifwe/api-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ifwe/api-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifwe/api-client-js/labels{/name}","releases_url":"https://api.github.com/repos/ifwe/api-client-js/releases{/id}","created_at":"2014-07-11T22:30:09Z","updated_at":"2015-04-17T20:23:42Z","pushed_at":"2015-08-08T00:31:18Z","git_url":"git://github.com/ifwe/api-client-js.git","ssh_url":"git@github.com:ifwe/api-client-js.git","clone_url":"https://github.com/ifwe/api-client-js.git","svn_url":"https://github.com/ifwe/api-client-js","homepage":null,"size":3918,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ifwe:master","ref":"master","sha":"21d581e10bcf10600e8bc153b90234ae09e324b9","user":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"repo":{"id":21753480,"name":"api-client-js","full_name":"ifwe/api-client-js","owner":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ifwe/api-client-js","description":"Tagged API client for Node and the Browser","fork":false,"url":"https://api.github.com/repos/ifwe/api-client-js","forks_url":"https://api.github.com/repos/ifwe/api-client-js/forks","keys_url":"https://api.github.com/repos/ifwe/api-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifwe/api-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifwe/api-client-js/teams","hooks_url":"https://api.github.com/repos/ifwe/api-client-js/hooks","issue_events_url":"https://api.github.com/repos/ifwe/api-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/ifwe/api-client-js/events","assignees_url":"https://api.github.com/repos/ifwe/api-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/ifwe/api-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/ifwe/api-client-js/tags","blobs_url":"https://api.github.com/repos/ifwe/api-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifwe/api-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifwe/api-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifwe/api-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifwe/api-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ifwe/api-client-js/languages","stargazers_url":"https://api.github.com/repos/ifwe/api-client-js/stargazers","contributors_url":"https://api.github.com/repos/ifwe/api-client-js/contributors","subscribers_url":"https://api.github.com/repos/ifwe/api-client-js/subscribers","subscription_url":"https://api.github.com/repos/ifwe/api-client-js/subscription","commits_url":"https://api.github.com/repos/ifwe/api-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifwe/api-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifwe/api-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifwe/api-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifwe/api-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/ifwe/api-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifwe/api-client-js/merges","archive_url":"https://api.github.com/repos/ifwe/api-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifwe/api-client-js/downloads","issues_url":"https://api.github.com/repos/ifwe/api-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/ifwe/api-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ifwe/api-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ifwe/api-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifwe/api-client-js/labels{/name}","releases_url":"https://api.github.com/repos/ifwe/api-client-js/releases{/id}","created_at":"2014-07-11T22:30:09Z","updated_at":"2015-04-17T20:23:42Z","pushed_at":"2015-08-08T00:31:18Z","git_url":"git://github.com/ifwe/api-client-js.git","ssh_url":"git@github.com:ifwe/api-client-js.git","clone_url":"https://github.com/ifwe/api-client-js.git","svn_url":"https://github.com/ifwe/api-client-js","homepage":null,"size":3918,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/20"},"html":{"href":"https://github.com/ifwe/api-client-js/pull/20"},"issue":{"href":"https://api.github.com/repos/ifwe/api-client-js/issues/20"},"comments":{"href":"https://api.github.com/repos/ifwe/api-client-js/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ifwe/api-client-js/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ifwe/api-client-js/statuses/349cd39a56dead76928def16ff4b5e8a5a17af22"}}}}