{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26","id":33208747,"html_url":"https://github.com/mozilla/web-platform-compat/pull/26","diff_url":"https://github.com/mozilla/web-platform-compat/pull/26.diff","patch_url":"https://github.com/mozilla/web-platform-compat/pull/26.patch","issue_url":"https://api.github.com/repos/mozilla/web-platform-compat/issues/26","number":26,"state":"open","locked":false,"title":"Fix bug 1146430 - Update to DRF 3.1","user":{"login":"jwhitlock","id":286017,"avatar_url":"https://avatars.githubusercontent.com/u/286017?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"body":"This code upgrades Django REST Framework (DRF) from 2.4 to 3.1, with as little changes to tests as possible.  It is done as a series of 2.4-compatible changes, followed by a final commit with the 2.4 to 3.1 changes.  It will probably be easier to review by commit rather than by branch diff, except for the final commit, which is difficult no matter what you do. \r\n\r\nBased on the upgrade experience, using DRF's `ModelSerializer` with our complex models and rendering with [drf-json-api](https://github.com/kevin-brown/drf-json-api) require overriding methods in ways that make little sense.  Re-implenting the serializers and renderer is planned in [bug 1153288](https://bugzilla.mozilla.org/show_bug.cgi?id=1153288).\r\n\r\nDespite the ugliness, it's a good idea to get off of DRF 2.4, which the DRF maintainers are slow to update, even for security fixes.","created_at":"2015-04-13T22:09:26Z","updated_at":"2015-04-13T22:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26/commits","review_comments_url":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26/comments","review_comment_url":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/web-platform-compat/issues/26/comments","statuses_url":"https://api.github.com/repos/mozilla/web-platform-compat/statuses/cfb190d0b700ce4a549c92d3fac21e1b9abec45c","head":{"label":"jwhitlock:1146430_drf3","ref":"1146430_drf3","sha":"cfb190d0b700ce4a549c92d3fac21e1b9abec45c","user":{"login":"jwhitlock","id":286017,"avatar_url":"https://avatars.githubusercontent.com/u/286017?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"repo":{"id":21751920,"name":"web-platform-compat","full_name":"jwhitlock/web-platform-compat","owner":{"login":"jwhitlock","id":286017,"avatar_url":"https://avatars.githubusercontent.com/u/286017?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwhitlock/web-platform-compat","description":"API for browser compatibility data on developers.mozilla.org","fork":false,"url":"https://api.github.com/repos/jwhitlock/web-platform-compat","forks_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/forks","keys_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/teams","hooks_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/hooks","issue_events_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/events{/number}","events_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/events","assignees_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/assignees{/user}","branches_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/branches{/branch}","tags_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/tags","blobs_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/statuses/{sha}","languages_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/languages","stargazers_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/stargazers","contributors_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/contributors","subscribers_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/subscribers","subscription_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/subscription","commits_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/contents/{+path}","compare_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/merges","archive_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/downloads","issues_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues{/number}","pulls_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/pulls{/number}","milestones_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/milestones{/number}","notifications_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/labels{/name}","releases_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/releases{/id}","created_at":"2014-07-11T21:25:57Z","updated_at":"2015-04-13T20:20:06Z","pushed_at":"2015-04-13T22:08:20Z","git_url":"git://github.com/jwhitlock/web-platform-compat.git","ssh_url":"git@github.com:jwhitlock/web-platform-compat.git","clone_url":"https://github.com/jwhitlock/web-platform-compat.git","svn_url":"https://github.com/jwhitlock/web-platform-compat","homepage":null,"size":3120,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2abbb6f6d1405c3b115b3c756b3aed80960b411b","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":22151474,"name":"web-platform-compat","full_name":"mozilla/web-platform-compat","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/web-platform-compat","description":"Holding pen for future web-platform-compat. See:","fork":true,"url":"https://api.github.com/repos/mozilla/web-platform-compat","forks_url":"https://api.github.com/repos/mozilla/web-platform-compat/forks","keys_url":"https://api.github.com/repos/mozilla/web-platform-compat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/web-platform-compat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/web-platform-compat/teams","hooks_url":"https://api.github.com/repos/mozilla/web-platform-compat/hooks","issue_events_url":"https://api.github.com/repos/mozilla/web-platform-compat/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/web-platform-compat/events","assignees_url":"https://api.github.com/repos/mozilla/web-platform-compat/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/web-platform-compat/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/web-platform-compat/tags","blobs_url":"https://api.github.com/repos/mozilla/web-platform-compat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/web-platform-compat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/web-platform-compat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/web-platform-compat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/web-platform-compat/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/web-platform-compat/languages","stargazers_url":"https://api.github.com/repos/mozilla/web-platform-compat/stargazers","contributors_url":"https://api.github.com/repos/mozilla/web-platform-compat/contributors","subscribers_url":"https://api.github.com/repos/mozilla/web-platform-compat/subscribers","subscription_url":"https://api.github.com/repos/mozilla/web-platform-compat/subscription","commits_url":"https://api.github.com/repos/mozilla/web-platform-compat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/web-platform-compat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/web-platform-compat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/web-platform-compat/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/web-platform-compat/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/web-platform-compat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/web-platform-compat/merges","archive_url":"https://api.github.com/repos/mozilla/web-platform-compat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/web-platform-compat/downloads","issues_url":"https://api.github.com/repos/mozilla/web-platform-compat/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/web-platform-compat/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/web-platform-compat/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/web-platform-compat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/web-platform-compat/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/web-platform-compat/releases{/id}","created_at":"2014-07-23T14:00:22Z","updated_at":"2015-04-13T20:05:44Z","pushed_at":"2015-04-13T20:05:44Z","git_url":"git://github.com/mozilla/web-platform-compat.git","ssh_url":"git@github.com:mozilla/web-platform-compat.git","clone_url":"https://github.com/mozilla/web-platform-compat.git","svn_url":"https://github.com/mozilla/web-platform-compat","homepage":"https://github.com/jwhitlock/web-platform-compat","size":2380,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26"},"html":{"href":"https://github.com/mozilla/web-platform-compat/pull/26"},"issue":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/issues/26"},"comments":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/web-platform-compat/statuses/cfb190d0b700ce4a549c92d3fac21e1b9abec45c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":1241,"deletions":1125,"changed_files":26}}