{"action":"created","issue":{"url":"https://api.github.com/repos/subuser-security/subuser/issues/225","labels_url":"https://api.github.com/repos/subuser-security/subuser/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/subuser-security/subuser/issues/225/comments","events_url":"https://api.github.com/repos/subuser-security/subuser/issues/225/events","html_url":"https://github.com/subuser-security/subuser/pull/225","id":109693563,"number":225,"title":"Wait for Xpra server to write 'xpra is ready' to stderr before continuing","user":{"login":"ruipgpinheiro","id":11169970,"avatar_url":"https://avatars.githubusercontent.com/u/11169970?v=3","gravatar_id":"","url":"https://api.github.com/users/ruipgpinheiro","html_url":"https://github.com/ruipgpinheiro","followers_url":"https://api.github.com/users/ruipgpinheiro/followers","following_url":"https://api.github.com/users/ruipgpinheiro/following{/other_user}","gists_url":"https://api.github.com/users/ruipgpinheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ruipgpinheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruipgpinheiro/subscriptions","organizations_url":"https://api.github.com/users/ruipgpinheiro/orgs","repos_url":"https://api.github.com/users/ruipgpinheiro/repos","events_url":"https://api.github.com/users/ruipgpinheiro/events{/privacy}","received_events_url":"https://api.github.com/users/ruipgpinheiro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-04T17:48:29Z","updated_at":"2015-10-05T03:15:59Z","closed_at":"2015-10-04T20:41:03Z","pull_request":{"url":"https://api.github.com/repos/subuser-security/subuser/pulls/225","html_url":"https://github.com/subuser-security/subuser/pull/225","diff_url":"https://github.com/subuser-security/subuser/pull/225.diff","patch_url":"https://github.com/subuser-security/subuser/pull/225.patch"},"body":"Added a \"collectOutput\" parameter to the subprocessExtras.callBackground function, which pipes stdout/stderr. Using this functionality, the x11Bridge.py waitForServerContainerToLaunch method can now listen and wait until the Xpra server outputs 'xpra is ready' to stderr, before continuing normally.\r\n\r\nAfter these changes, I am unable to reproduce issue #224, and everything else seems to work fine.\r\n\r\nNote: I am new at this open-source contribution thing, so feel free to give advice if I did anything wrong :)"},"comment":{"url":"https://api.github.com/repos/subuser-security/subuser/issues/comments/145419343","html_url":"https://github.com/subuser-security/subuser/pull/225#issuecomment-145419343","issue_url":"https://api.github.com/repos/subuser-security/subuser/issues/225","id":145419343,"user":{"login":"ruipgpinheiro","id":11169970,"avatar_url":"https://avatars.githubusercontent.com/u/11169970?v=3","gravatar_id":"","url":"https://api.github.com/users/ruipgpinheiro","html_url":"https://github.com/ruipgpinheiro","followers_url":"https://api.github.com/users/ruipgpinheiro/followers","following_url":"https://api.github.com/users/ruipgpinheiro/following{/other_user}","gists_url":"https://api.github.com/users/ruipgpinheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ruipgpinheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruipgpinheiro/subscriptions","organizations_url":"https://api.github.com/users/ruipgpinheiro/orgs","repos_url":"https://api.github.com/users/ruipgpinheiro/repos","events_url":"https://api.github.com/users/ruipgpinheiro/events{/privacy}","received_events_url":"https://api.github.com/users/ruipgpinheiro/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T03:15:59Z","updated_at":"2015-10-05T03:15:59Z","body":"Just a small information: I left the \"debug\" outputs there because on first boot, the Xpra server takes something like 10 seconds on my VM to launch, and if I have Xpra debug turned off the application just seems to have frozen. I think it makes complete sense to keep the user up-to-date of what is happening. Maybe print something like \"Starting <runtime name>...\"?\r\n\r\nAlso, regarding your last point, I agree, it would make sense to remove supressOutput completely. I didn't do it because I didn't want to change *too* much for a single issue like this. Does Docker support logging to a file *in addition* to stdout/err?"}}