{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/1986","labels_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1986/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1986/comments","events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1986/events","html_url":"https://github.com/alphagov/smart-answers/pull/1986","id":109336083,"number":1986,"title":"Add regression tests for pay leave for parents","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-01T16:27:33Z","updated_at":"2015-10-01T16:27:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/1986","html_url":"https://github.com/alphagov/smart-answers/pull/1986","diff_url":"https://github.com/alphagov/smart-answers/pull/1986.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/1986.patch"},"body":"Now that pay-leave-for-parents has been converted to single-question-per-page we're able to generate regression tests. These tests should give us confidence that we haven't broken anything when we convert from Smartdown to Ruby Smart Answers.\r\n\r\nI'm particularly interested in feedback on the first (currently marked as \"TEMP\") commit. We need to preload the Smartdown flow to avoid the regression tests taking about 20 seconds each. However, we don't always want to preload as that causes the non-Smartdown tests to take longer than necessary. I'm kinda happy with the hacky approach but I think the bit that's missing is resetting the `preload_flows` option in some kind of teardown hook. I haven't looked at whether that might be possible yet.\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments/144779560","html_url":"https://github.com/alphagov/smart-answers/pull/1986#issuecomment-144779560","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1986","id":144779560,"user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T16:27:52Z","updated_at":"2015-10-01T16:27:52Z","body":"This is mainly for discussion at the moment so I'm going to add the \"Don't merge\" label."}}