{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/29377283","id":29377283,"diff_hunk":"@@ -0,0 +1,10 @@\n+/*\n+Package fsnode is a high-level interface for filesystem nodes.\n+\n+Simple wrappers to:\n+\n+* create file and directory nodes from paths and readers,\n+* extract file and directory nodes to your local filesytem, and\n+* print file contents to writers.\n+*/\n+package fsnode","path":"shell/fsnode/fsnode.go","position":10,"original_position":10,"commit_id":"37095593885eb91daff440eed1ee060afc08662f","original_commit_id":"37095593885eb91daff440eed1ee060afc08662f","user":{"login":"jbenet","id":138401,"avatar_url":"https://avatars.githubusercontent.com/u/138401?v=3","gravatar_id":"","url":"https://api.github.com/users/jbenet","html_url":"https://github.com/jbenet","followers_url":"https://api.github.com/users/jbenet/followers","following_url":"https://api.github.com/users/jbenet/following{/other_user}","gists_url":"https://api.github.com/users/jbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenet/subscriptions","organizations_url":"https://api.github.com/users/jbenet/orgs","repos_url":"https://api.github.com/users/jbenet/repos","events_url":"https://api.github.com/users/jbenet/events{/privacy}","received_events_url":"https://api.github.com/users/jbenet/received_events","type":"User","site_admin":false},"body":"i think this package should be called `unixfs` as that's the abstraction that this is calling to.","created_at":"2015-04-29T20:30:04Z","updated_at":"2015-04-29T20:30:04Z","html_url":"https://github.com/ipfs/go-ipfs/pull/1136#discussion_r29377283","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/29377283"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1136#discussion_r29377283"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136","id":34100395,"html_url":"https://github.com/ipfs/go-ipfs/pull/1136","diff_url":"https://github.com/ipfs/go-ipfs/pull/1136.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1136.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136","number":1136,"state":"open","locked":false,"title":"Replace coreunix.Add with shell/fsnode's AddFromReader","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"coreunix.Add is basically a wrapper around BuildDagFromReader that\nreturns a string-ified key instead of a DAG node.  Since we'll need\nthe DAG node to add to the directory, converting to a key and then\nlooking that key back up in dirbuilder.AddChild is just extra work.\n\nIn #1127, @whyrusleeping mentioned that the file- and\ndirectory-addition API needed some polishing, and this WIP PR is my\nattempt to grind things down to a more compact API.  I'll probably\njust work up to removing coreunix.Add completely, and then start a new\nPR for whatever function we want to cull next.","created_at":"2015-04-25T04:18:03Z","updated_at":"2015-04-29T20:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e83c464da72a415932261feb1dcc0a9e0f44361","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/37095593885eb91daff440eed1ee060afc08662f","head":{"label":"wking:add-refactor","ref":"add-refactor","sha":"37095593885eb91daff440eed1ee060afc08662f","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":34468987,"name":"go-ipfs","full_name":"wking/go-ipfs","owner":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wking/go-ipfs","description":"ipfs implementation in go","fork":true,"url":"https://api.github.com/repos/wking/go-ipfs","forks_url":"https://api.github.com/repos/wking/go-ipfs/forks","keys_url":"https://api.github.com/repos/wking/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/go-ipfs/teams","hooks_url":"https://api.github.com/repos/wking/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/wking/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/wking/go-ipfs/events","assignees_url":"https://api.github.com/repos/wking/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/wking/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/wking/go-ipfs/tags","blobs_url":"https://api.github.com/repos/wking/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/wking/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/wking/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/wking/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/wking/go-ipfs/subscription","commits_url":"https://api.github.com/repos/wking/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/wking/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/go-ipfs/merges","archive_url":"https://api.github.com/repos/wking/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/go-ipfs/downloads","issues_url":"https://api.github.com/repos/wking/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/wking/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/wking/go-ipfs/releases{/id}","created_at":"2015-04-23T16:46:12Z","updated_at":"2015-04-27T15:38:17Z","pushed_at":"2015-04-29T16:12:18Z","git_url":"git://github.com/wking/go-ipfs.git","ssh_url":"git@github.com:wking/go-ipfs.git","clone_url":"https://github.com/wking/go-ipfs.git","svn_url":"https://github.com/wking/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":16136,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"d047fe4fcb2e62365be6f9f41a8a1ddb553f0dae","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"ipfs implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","created_at":"2014-06-26T08:14:34Z","updated_at":"2015-04-29T19:28:04Z","pushed_at":"2015-04-29T19:28:06Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":36058,"stargazers_count":511,"watchers_count":511,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":223,"forks":83,"open_issues":223,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1136"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/37095593885eb91daff440eed1ee060afc08662f"}}}}