{"action":"opened","number":33,"pull_request":{"url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33","id":38271166,"html_url":"https://github.com/coredump-ch/spaceapi/pull/33","diff_url":"https://github.com/coredump-ch/spaceapi/pull/33.diff","patch_url":"https://github.com/coredump-ch/spaceapi/pull/33.patch","issue_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/33","number":33,"state":"open","locked":false,"title":"datastore: Clenup DataStoreError","user":{"login":"rnestler","id":1435346,"avatar_url":"https://avatars.githubusercontent.com/u/1435346?v=3","gravatar_id":"","url":"https://api.github.com/users/rnestler","html_url":"https://github.com/rnestler","followers_url":"https://api.github.com/users/rnestler/followers","following_url":"https://api.github.com/users/rnestler/following{/other_user}","gists_url":"https://api.github.com/users/rnestler/gists{/gist_id}","starred_url":"https://api.github.com/users/rnestler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnestler/subscriptions","organizations_url":"https://api.github.com/users/rnestler/orgs","repos_url":"https://api.github.com/users/rnestler/repos","events_url":"https://api.github.com/users/rnestler/events{/privacy}","received_events_url":"https://api.github.com/users/rnestler/received_events","type":"User","site_admin":false},"body":"No need to redirect through a struct. The error type can be an enum.\r\n\r\nWhat I still not like is that while the ``DataStore`` trait enables\r\nout-of-crate implementations, one still has to edit the enum to be able to\r\nreturn custom errors.\r\n\r\nMaybe we should make ``DataStore`` (and all users of it) error type generic.\r\n\r\n@dbrgn @schmijos ","created_at":"2015-06-22T20:13:41Z","updated_at":"2015-06-22T20:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d2da045c4c9c3f15f2729678c3624d6c25f7bcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33/commits","review_comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33/comments","review_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/33/comments","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/766b140fb887280ebe57ae824e5b08f601e59299","head":{"label":"coredump-ch:rnestler/cleanup_datastore","ref":"rnestler/cleanup_datastore","sha":"766b140fb887280ebe57ae824e5b08f601e59299","user":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":16317444,"name":"spaceapi","full_name":"coredump-ch/spaceapi","owner":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coredump-ch/spaceapi","description":"Implementation of the Space API.","fork":false,"url":"https://api.github.com/repos/coredump-ch/spaceapi","forks_url":"https://api.github.com/repos/coredump-ch/spaceapi/forks","keys_url":"https://api.github.com/repos/coredump-ch/spaceapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coredump-ch/spaceapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coredump-ch/spaceapi/teams","hooks_url":"https://api.github.com/repos/coredump-ch/spaceapi/hooks","issue_events_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/events{/number}","events_url":"https://api.github.com/repos/coredump-ch/spaceapi/events","assignees_url":"https://api.github.com/repos/coredump-ch/spaceapi/assignees{/user}","branches_url":"https://api.github.com/repos/coredump-ch/spaceapi/branches{/branch}","tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/tags","blobs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/{sha}","languages_url":"https://api.github.com/repos/coredump-ch/spaceapi/languages","stargazers_url":"https://api.github.com/repos/coredump-ch/spaceapi/stargazers","contributors_url":"https://api.github.com/repos/coredump-ch/spaceapi/contributors","subscribers_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscribers","subscription_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscription","commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/coredump-ch/spaceapi/contents/{+path}","compare_url":"https://api.github.com/repos/coredump-ch/spaceapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coredump-ch/spaceapi/merges","archive_url":"https://api.github.com/repos/coredump-ch/spaceapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coredump-ch/spaceapi/downloads","issues_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues{/number}","pulls_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls{/number}","milestones_url":"https://api.github.com/repos/coredump-ch/spaceapi/milestones{/number}","notifications_url":"https://api.github.com/repos/coredump-ch/spaceapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coredump-ch/spaceapi/labels{/name}","releases_url":"https://api.github.com/repos/coredump-ch/spaceapi/releases{/id}","created_at":"2014-01-28T16:23:32Z","updated_at":"2015-06-03T06:45:20Z","pushed_at":"2015-06-22T20:13:42Z","git_url":"git://github.com/coredump-ch/spaceapi.git","ssh_url":"git@github.com:coredump-ch/spaceapi.git","clone_url":"https://github.com/coredump-ch/spaceapi.git","svn_url":"https://github.com/coredump-ch/spaceapi","homepage":null,"size":516,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":3,"default_branch":"rust"}},"base":{"label":"coredump-ch:rust","ref":"rust","sha":"703ba138635a7ad561e2f0a0039060fd2224e059","user":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":16317444,"name":"spaceapi","full_name":"coredump-ch/spaceapi","owner":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coredump-ch/spaceapi","description":"Implementation of the Space API.","fork":false,"url":"https://api.github.com/repos/coredump-ch/spaceapi","forks_url":"https://api.github.com/repos/coredump-ch/spaceapi/forks","keys_url":"https://api.github.com/repos/coredump-ch/spaceapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coredump-ch/spaceapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coredump-ch/spaceapi/teams","hooks_url":"https://api.github.com/repos/coredump-ch/spaceapi/hooks","issue_events_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/events{/number}","events_url":"https://api.github.com/repos/coredump-ch/spaceapi/events","assignees_url":"https://api.github.com/repos/coredump-ch/spaceapi/assignees{/user}","branches_url":"https://api.github.com/repos/coredump-ch/spaceapi/branches{/branch}","tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/tags","blobs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/{sha}","languages_url":"https://api.github.com/repos/coredump-ch/spaceapi/languages","stargazers_url":"https://api.github.com/repos/coredump-ch/spaceapi/stargazers","contributors_url":"https://api.github.com/repos/coredump-ch/spaceapi/contributors","subscribers_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscribers","subscription_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscription","commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/coredump-ch/spaceapi/contents/{+path}","compare_url":"https://api.github.com/repos/coredump-ch/spaceapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coredump-ch/spaceapi/merges","archive_url":"https://api.github.com/repos/coredump-ch/spaceapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coredump-ch/spaceapi/downloads","issues_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues{/number}","pulls_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls{/number}","milestones_url":"https://api.github.com/repos/coredump-ch/spaceapi/milestones{/number}","notifications_url":"https://api.github.com/repos/coredump-ch/spaceapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coredump-ch/spaceapi/labels{/name}","releases_url":"https://api.github.com/repos/coredump-ch/spaceapi/releases{/id}","created_at":"2014-01-28T16:23:32Z","updated_at":"2015-06-03T06:45:20Z","pushed_at":"2015-06-22T20:13:42Z","git_url":"git://github.com/coredump-ch/spaceapi.git","ssh_url":"git@github.com:coredump-ch/spaceapi.git","clone_url":"https://github.com/coredump-ch/spaceapi.git","svn_url":"https://github.com/coredump-ch/spaceapi","homepage":null,"size":516,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":3,"default_branch":"rust"}},"_links":{"self":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33"},"html":{"href":"https://github.com/coredump-ch/spaceapi/pull/33"},"issue":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/issues/33"},"comments":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/766b140fb887280ebe57ae824e5b08f601e59299"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":9,"changed_files":1}}