{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/22248","labels_url":"https://api.github.com/repos/rails/rails/issues/22248/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/22248/comments","events_url":"https://api.github.com/repos/rails/rails/issues/22248/events","html_url":"https://github.com/rails/rails/pull/22248","id":116104080,"number":22248,"title":"Fix #22232: rake test tasks exit status code","user":{"login":"arekf","id":367484,"avatar_url":"https://avatars.githubusercontent.com/u/367484?v=3","gravatar_id":"","url":"https://api.github.com/users/arekf","html_url":"https://github.com/arekf","followers_url":"https://api.github.com/users/arekf/followers","following_url":"https://api.github.com/users/arekf/following{/other_user}","gists_url":"https://api.github.com/users/arekf/gists{/gist_id}","starred_url":"https://api.github.com/users/arekf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekf/subscriptions","organizations_url":"https://api.github.com/users/arekf/orgs","repos_url":"https://api.github.com/users/arekf/repos","events_url":"https://api.github.com/users/arekf/events{/privacy}","received_events_url":"https://api.github.com/users/arekf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars.githubusercontent.com/u/1080678?v=3","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rails/rails/milestones/34","html_url":"https://github.com/rails/rails/milestones/5.0.0","labels_url":"https://api.github.com/repos/rails/rails/milestones/34/labels","id":665192,"number":34,"title":"5.0.0","description":null,"creator":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"open_issues":87,"closed_issues":169,"state":"open","created_at":"2014-05-21T00:58:22Z","updated_at":"2015-12-06T20:18:15Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-11-10T13:15:41Z","updated_at":"2015-12-07T09:51:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22248","html_url":"https://github.com/rails/rails/pull/22248","diff_url":"https://github.com/rails/rails/pull/22248.diff","patch_url":"https://github.com/rails/rails/pull/22248.patch"},"body":"Rake test task sets exit status code, so the behavior\r\nis matching rails test command."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/162466767","html_url":"https://github.com/rails/rails/pull/22248#issuecomment-162466767","issue_url":"https://api.github.com/repos/rails/rails/issues/22248","id":162466767,"user":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?v=3","gravatar_id":"","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T09:51:24Z","updated_at":"2015-12-07T09:51:24Z","body":"I think the `Rake::TestTask` we were using previous to the new runner also exited with a non-zero status. See https://github.com/ruby/rake/blob/master/lib/rake/testtask.rb#L109\r\n\r\n@sgrif is right tough. We should not exit for `0` status codes. Otherwise chaining tasks won't work anymore.\r\n"}}