{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/repose/issues/1398","labels_url":"https://api.github.com/repos/rackerlabs/repose/issues/1398/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/repose/issues/1398/comments","events_url":"https://api.github.com/repos/rackerlabs/repose/issues/1398/events","html_url":"https://github.com/rackerlabs/repose/pull/1398","id":112262767,"number":1398,"title":"Rep 2233 fix","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=3","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":44,"created_at":"2015-10-20T01:03:44Z","updated_at":"2015-10-26T20:02:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/repose/pulls/1398","html_url":"https://github.com/rackerlabs/repose/pull/1398","diff_url":"https://github.com/rackerlabs/repose/pull/1398.diff","patch_url":"https://github.com/rackerlabs/repose/pull/1398.patch"},"body":"This fixes REP-2233 by enforcing via XSD validation that all limit IDs across all limit-groups are unique.\r\n\r\nEDIT: I think this is only a partial fix. I'm going to write another test to verify. I think the bug will resurface if multiple `rate-limiting-filter`s are used, there could be conflicting IDs in those files (since the logic happens in the RateLimitingService, not the filter.\r\n\r\nEDIT: It's not a partial fix, I added another test to it to prove that it behaves well. Yay."},"comment":{"url":"https://api.github.com/repos/rackerlabs/repose/issues/comments/151266704","html_url":"https://github.com/rackerlabs/repose/pull/1398#issuecomment-151266704","issue_url":"https://api.github.com/repos/rackerlabs/repose/issues/1398","id":151266704,"user":{"login":"repose-bot","id":7064007,"avatar_url":"https://avatars.githubusercontent.com/u/7064007?v=3","gravatar_id":"","url":"https://api.github.com/users/repose-bot","html_url":"https://github.com/repose-bot","followers_url":"https://api.github.com/users/repose-bot/followers","following_url":"https://api.github.com/users/repose-bot/following{/other_user}","gists_url":"https://api.github.com/users/repose-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/repose-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repose-bot/subscriptions","organizations_url":"https://api.github.com/users/repose-bot/orgs","repos_url":"https://api.github.com/users/repose-bot/repos","events_url":"https://api.github.com/users/repose-bot/events{/privacy}","received_events_url":"https://api.github.com/users/repose-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T20:02:16Z","updated_at":"2015-10-26T20:02:16Z","body":"\nRefer to this link for build results (access rights to CI server needed): \nhttps://jenkins.openrepose.org//job/repose-pull_requests/537/\n"}}