{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/34507293","id":34507293,"diff_hunk":"@@ -33,17 +33,28 @@ export class AppViewContainer {\n  * Cost of making objects: http://jsperf.com/instantiate-size-of-object\n  *\n  */\n-export class AppView implements ChangeDispatcher, EventDispatcher {\n-  render: renderApi.RenderViewRef = null;\n+export class AppView implements ChangeDispatcher, RenderEventDispatcher {\n   /// This list matches the _nodes list. It is sparse, since only Elements have ElementInjector\n   rootElementInjectors: List<ElementInjector>;\n+  // Note: this list is shared between all nestedChildViews. Use this.elementOffset to get the local\n+  // entries.\n   elementInjectors: List<ElementInjector> = null;\n   changeDetector: ChangeDetector = null;\n-  componentChildViews: List<AppView> = null;\n-  viewContainers: List<AppViewContainer>;\n+  // Note: this list is shared between all nestedChildViews. Use this.elementOffset to get the local\n+  // entries.\n+  nestedChildViews: List<AppView> = null;\n+  // Note: this list is shared between all nestedChildViews. Use this.elementOffset to get the local\n+  // entries.\n+  viewContainers: List<AppViewContainer> = null;\n+  // Note: this list is shared between all nestedChildViews. Use this.elementOffset to get the local\n+  // entries.\n   preBuiltObjects: List<PreBuiltObjects> = null;\n+  // Note: this list is shared between all nestedChildViews. Use this.elementOffset to get the local\n+  // entries.\n   elementRefs: List<ElementRef>;\n   ref: ViewRef;\n+  mergedParentView: AppView;","path":"modules/angular2/src/core/compiler/view.ts","position":39,"original_position":39,"commit_id":"fac8545a16890ebafc7e5b201f39895a74c23339","original_commit_id":"fac8545a16890ebafc7e5b201f39895a74c23339","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"Remove this!","created_at":"2015-07-13T20:26:01Z","updated_at":"2015-07-13T20:26:01Z","html_url":"https://github.com/angular/angular/pull/2839#discussion_r34507293","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/2839","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/34507293"},"html":{"href":"https://github.com/angular/angular/pull/2839#discussion_r34507293"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/2839"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/2839","id":39036374,"html_url":"https://github.com/angular/angular/pull/2839","diff_url":"https://github.com/angular/angular/pull/2839.diff","patch_url":"https://github.com/angular/angular/pull/2839.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/2839","number":2839,"state":"open","locked":false,"title":"feat(compiler): content projection during compile","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"Closes #2529\r\n\r\nBREAKING CHANGES:\r\n- shadow dom emulation no longer\r\n  supports the `<content>` tag. Use the new `<ng-content>` instead\r\n  (works with all shadow dom strategies).\r\n- removed `DomRenderer.setViewRootNodes` and `AppViewManager.getComponentView`\r\n  -> use `DomRenderer.getNativeElementSync(elementRef)` and change shadow dom directly\r\n- the `Renderer` interface has changed:\r\n  * `createView` now also has to support sub views\r\n  * the notion of a container has been removed. Instead, the renderer has\r\n    to implement methods to attach views next to elements or other views.\r\n  * a RenderView now contains multiple RenderFragments. Fragments\r\n    are used to move DOM nodes around.\r\n\r\nInternal changes:\r\n- ProtoViews always have a `<template>` element as root\r\n  * needed for storing subviews\r\n  * we have less chunks of DOM to clone now\r\n- eemove fake ElementBinder / Bound element for root text bindings\r\n  and model them explicitly. This removes a lot of special cases we had!\r\n- some methods in AppViewManager (create, hydrate, dehydrate) are iterative now\r\n  * now possible as we have all child AppViews / ElementRefs already in an array!","created_at":"2015-07-01T23:46:03Z","updated_at":"2015-07-13T20:26:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d83aab4dbb2b584c98b5f4e64abfd96b282bb0f","assignee":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=3","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/2839/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/fac8545a16890ebafc7e5b201f39895a74c23339","head":{"label":"tbosch:render-project","ref":"render-project","sha":"fac8545a16890ebafc7e5b201f39895a74c23339","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"repo":{"id":24733374,"name":"angular","full_name":"tbosch/angular","owner":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbosch/angular","description":"","fork":true,"url":"https://api.github.com/repos/tbosch/angular","forks_url":"https://api.github.com/repos/tbosch/angular/forks","keys_url":"https://api.github.com/repos/tbosch/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbosch/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbosch/angular/teams","hooks_url":"https://api.github.com/repos/tbosch/angular/hooks","issue_events_url":"https://api.github.com/repos/tbosch/angular/issues/events{/number}","events_url":"https://api.github.com/repos/tbosch/angular/events","assignees_url":"https://api.github.com/repos/tbosch/angular/assignees{/user}","branches_url":"https://api.github.com/repos/tbosch/angular/branches{/branch}","tags_url":"https://api.github.com/repos/tbosch/angular/tags","blobs_url":"https://api.github.com/repos/tbosch/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbosch/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbosch/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbosch/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbosch/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/tbosch/angular/languages","stargazers_url":"https://api.github.com/repos/tbosch/angular/stargazers","contributors_url":"https://api.github.com/repos/tbosch/angular/contributors","subscribers_url":"https://api.github.com/repos/tbosch/angular/subscribers","subscription_url":"https://api.github.com/repos/tbosch/angular/subscription","commits_url":"https://api.github.com/repos/tbosch/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbosch/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbosch/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbosch/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbosch/angular/contents/{+path}","compare_url":"https://api.github.com/repos/tbosch/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbosch/angular/merges","archive_url":"https://api.github.com/repos/tbosch/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbosch/angular/downloads","issues_url":"https://api.github.com/repos/tbosch/angular/issues{/number}","pulls_url":"https://api.github.com/repos/tbosch/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/tbosch/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/tbosch/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbosch/angular/labels{/name}","releases_url":"https://api.github.com/repos/tbosch/angular/releases{/id}","created_at":"2014-10-02T19:30:59Z","updated_at":"2015-06-02T21:15:59Z","pushed_at":"2015-07-13T18:44:10Z","git_url":"git://github.com/tbosch/angular.git","ssh_url":"git@github.com:tbosch/angular.git","clone_url":"https://github.com/tbosch/angular.git","svn_url":"https://github.com/tbosch/angular","homepage":null,"size":11174,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"a9a552c112da1397a0122acdbecbd52bc88e1906","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-07-13T18:22:03Z","pushed_at":"2015-07-13T19:59:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":34434,"stargazers_count":4179,"watchers_count":4179,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1084,"mirror_url":null,"open_issues_count":377,"forks":1084,"open_issues":377,"watchers":4179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/2839"},"html":{"href":"https://github.com/angular/angular/pull/2839"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/2839"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/fac8545a16890ebafc7e5b201f39895a74c23339"}}}}