{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/10549","labels_url":"https://api.github.com/repos/docker/docker/issues/10549/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/10549/comments","events_url":"https://api.github.com/repos/docker/docker/issues/10549/events","html_url":"https://github.com/docker/docker/pull/10549","id":56492881,"number":10549,"title":"Docs: add some docs for docker start option Fix #10514","user":{"login":"coolljt0725","id":8232360,"avatar_url":"https://avatars.githubusercontent.com/u/8232360?v=3","gravatar_id":"","url":"https://api.github.com/users/coolljt0725","html_url":"https://github.com/coolljt0725","followers_url":"https://api.github.com/users/coolljt0725/followers","following_url":"https://api.github.com/users/coolljt0725/following{/other_user}","gists_url":"https://api.github.com/users/coolljt0725/gists{/gist_id}","starred_url":"https://api.github.com/users/coolljt0725/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolljt0725/subscriptions","organizations_url":"https://api.github.com/users/coolljt0725/orgs","repos_url":"https://api.github.com/users/coolljt0725/repos","events_url":"https://api.github.com/users/coolljt0725/events{/privacy}","received_events_url":"https://api.github.com/users/coolljt0725/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels//project/doc","name":"/project/doc","color":"207de5"},{"url":"https://api.github.com/repos/docker/docker/labels/question","name":"question","color":"d8cdc6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-04T08:06:34Z","updated_at":"2015-02-04T17:20:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10549","html_url":"https://github.com/docker/docker/pull/10549","diff_url":"https://github.com/docker/docker/pull/10549.diff","patch_url":"https://github.com/docker/docker/pull/10549.patch"},"body":"Signed-off-by: Lei Jitang <leijitang@huawei.com>\r\n\r\nAdd some docs for docker start option `-i`,the `-i` option is only worked when the container\r\nis created by set the `-i`.This patch make it more clear of the usage of  `-i` option in `docker start`\r\n\r\nsee https://github.com/docker/docker/blob/master/api/client/commands.go#L717\r\n\r\nFixes #10514 "},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/72897005","html_url":"https://github.com/docker/docker/pull/10549#issuecomment-72897005","issue_url":"https://api.github.com/repos/docker/docker/issues/10549","id":72897005,"user":{"login":"WhisperingChaos","id":6739813,"avatar_url":"https://avatars.githubusercontent.com/u/6739813?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperingChaos","html_url":"https://github.com/WhisperingChaos","followers_url":"https://api.github.com/users/WhisperingChaos/followers","following_url":"https://api.github.com/users/WhisperingChaos/following{/other_user}","gists_url":"https://api.github.com/users/WhisperingChaos/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperingChaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperingChaos/subscriptions","organizations_url":"https://api.github.com/users/WhisperingChaos/orgs","repos_url":"https://api.github.com/users/WhisperingChaos/repos","events_url":"https://api.github.com/users/WhisperingChaos/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperingChaos/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T17:20:03Z","updated_at":"2015-02-04T17:20:03Z","body":"@coolljt0725 thanks for quickly assembling this PR!  It's a welcome alert that helps individuals understand dependencies between certain docker commands.  However, I suggest it can be improved.  See below.\r\n\r\n@SvenDowideit the current handling of -i & -a options by ```docker start``` conforms to the container's 'behavioral policy' as established by ```docker create/run```.  A behavioral policy determines the features (interface) that are made available to the consumer(s) of a container which potentially contrasts/differs from the capabilities intrinsic to the image forged by its author.  This notion of a behavioral policy, although not called that by the individuals who wrote/designed docker, continues to be an explicit feature of ```docker create/run```.  I also appreciate the distinction between an image's capabilities and its derivative container(s) abilities and can envision a number of scenarios, such as initially disabling a debugging interface/capability but when warranted,  exposing this ability, in a controlled manner, through executing a ```docker create/run```. Therefore, I would preserve the current behavior of ```docker start``` and avoid changing it to subvert the behavioral policy established by ```docker create/run```.\r\n\r\nNow to address the PRs implementation:\r\n  *  If ```docker start``` option and option values remain fully dependent on/determined by ```docker create/run``` then instead of adding a notation of this dependency to every option, such as '-i', I would strongly recommend updating start's \"Usage:\" statement to at least mention this dependency, as this static solution dynamically adapts to include additional options when made available by ```docker start```.  Here's some example text:\r\n    * Instead of \"Restart a stopped container\"\r\n    * To: \"Restart a stopped container.  The option values below are restricted those made available by ```docker create/run```. \"\r\n  * Although I haven't verified, I imagine the values for the '-a' option are also fully determined by the Config.AttachStderr, Config.AttachStdin, and Config.AttachStdout metadata tags.  If so, this PR doesn't extend the help text for this option.  This omission may promote the idea that '-a' option is fully 'over-ride'able and not restricted by ```docker create/run```.  I would resolve this omission by implementing the recommendation above.\r\n  * The PR limits its changes to the CLI help text produced by the ```docker start``` module.  Although, this help text is reflected by the web documentation available on the docker.com website, the web document generation process is not well understood by me, therefore, if necessary, some other action should be triggered to ensure the update of the web documentation.\r\n  * Other documentation issues discussed by #10514 are not addressed by this PR, therefore, this PR should not currently be considered a 'complete' solution that, if accepted, would necessarily close #10514."}}