{"action":"opened","number":9205,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9205","id":48382440,"html_url":"https://github.com/apache/spark/pull/9205","diff_url":"https://github.com/apache/spark/pull/9205.diff","patch_url":"https://github.com/apache/spark/pull/9205.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/9205","number":9205,"state":"open","locked":false,"title":"[SPARK-11244][SPARKR] sparkR.stop() should remove SQLContext","user":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"body":"SparkR should remove `.sparkRSQLsc` and `.sparkRHivesc` when `sparkR.stop()` is called. Otherwise even when SparkContext is reinitialized, `sparkRSQL.init` returns the stale copy of the object and complains:\r\n\r\n```r\r\nsc <- sparkR.init(\"local\")\r\nsqlContext <- sparkRSQL.init(sc)\r\nsparkR.stop()\r\nsc <- sparkR.init(\"local\")\r\nsqlContext <- sparkRSQL.init(sc)\r\nsqlContext\r\n```\r\nproducing\r\n```r\r\nError in callJMethod(x, \"getClass\") : \r\n  Invalid jobj 1. If SparkR was restarted, Spark operations need to be re-executed.\r\n```\r\n\r\nI have added the check and removal only when SparkContext itself is initialized. I have also added corresponding test for this fix. Let me know if you want me to move the test to SQL test suite instead.\r\n\r\np.s. I tried lint-r but ended up a lots of errors on existing code.","created_at":"2015-10-21T20:21:34Z","updated_at":"2015-10-21T20:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/9205/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/9205/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/9205/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/7f5154907ad45811722019f275b90cd12cff1134","head":{"label":"saurfang:sparkR.stop","ref":"sparkR.stop","sha":"7f5154907ad45811722019f275b90cd12cff1134","user":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"repo":{"id":34929698,"name":"spark","full_name":"saurfang/spark","owner":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saurfang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/saurfang/spark","forks_url":"https://api.github.com/repos/saurfang/spark/forks","keys_url":"https://api.github.com/repos/saurfang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saurfang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saurfang/spark/teams","hooks_url":"https://api.github.com/repos/saurfang/spark/hooks","issue_events_url":"https://api.github.com/repos/saurfang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/saurfang/spark/events","assignees_url":"https://api.github.com/repos/saurfang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/saurfang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/saurfang/spark/tags","blobs_url":"https://api.github.com/repos/saurfang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saurfang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saurfang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/saurfang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saurfang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/saurfang/spark/languages","stargazers_url":"https://api.github.com/repos/saurfang/spark/stargazers","contributors_url":"https://api.github.com/repos/saurfang/spark/contributors","subscribers_url":"https://api.github.com/repos/saurfang/spark/subscribers","subscription_url":"https://api.github.com/repos/saurfang/spark/subscription","commits_url":"https://api.github.com/repos/saurfang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/saurfang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/saurfang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/saurfang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/saurfang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/saurfang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saurfang/spark/merges","archive_url":"https://api.github.com/repos/saurfang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saurfang/spark/downloads","issues_url":"https://api.github.com/repos/saurfang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/saurfang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/saurfang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/saurfang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saurfang/spark/labels{/name}","releases_url":"https://api.github.com/repos/saurfang/spark/releases{/id}","created_at":"2015-05-02T00:07:13Z","updated_at":"2015-05-02T00:07:32Z","pushed_at":"2015-10-21T19:49:05Z","git_url":"git://github.com/saurfang/spark.git","ssh_url":"git@github.com:saurfang/spark.git","clone_url":"https://github.com/saurfang/spark.git","svn_url":"https://github.com/saurfang/spark","homepage":null,"size":120999,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"49ea0e9d7ce805d312d94a5b2936eec2053bc052","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-21T19:43:37Z","pushed_at":"2015-10-21T20:21:21Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1641549,"stargazers_count":5826,"watchers_count":5826,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5441,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":327,"forks":5441,"open_issues":327,"watchers":5826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/9205"},"html":{"href":"https://github.com/apache/spark/pull/9205"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/9205"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/9205/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/9205/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/9205/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/7f5154907ad45811722019f275b90cd12cff1134"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":0,"changed_files":2}}