{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/comments/26151769","id":26151769,"diff_hunk":"@@ -1887,39 +1907,25 @@ root.\"\n     (cljr--setup-find-symbol-buffer (or symbol-name symbol))\n     (cljr--find-symbol (or symbol-name symbol) ns 'cljr--format-and-insert-symbol-occurrence)))\n \n-(defun cljr--read-symbol-metadata (occurrences)\n-  (->> occurrences\n-       (-partition 7)\n-       (-map (lambda (symbol-meta)\n-               (apply (lambda (line-start line-end col-start col-end name file match)\n-                        (list :line-start line-start\n-                              :line-end line-end\n-                              :col-start col-start\n-                              :col-end col-end\n-                              :name (first (last (s-split \"/\" name)))\n-                              :file file\n-                              :match match))\n-                      symbol-meta)))))\n-\n-(defun cljr--rename-symbol (ns occurrences new-name)\n+(defun cljr--rename-occurrences (ns occurrences new-name)\n   (save-excursion\n     (dolist (symbol-meta occurrences)\n       (with-current-buffer\n           (find-file-noselect (plist-get symbol-meta :file))\n         (goto-char (point-min))\n-        (let* ((line-start (plist-get symbol-meta :line-start))\n-               (line-e (or (plist-get symbol-meta :line-end) line-start))\n-               (line-end line-start)\n-               (column-start (1- (or (plist-get symbol-meta :col-start) 1)))\n-               (start (progn (forward-line (1- line-start))\n-                             (move-to-column column-start)\n+        (let* ((line-beg (plist-get symbol-meta :line-beg))\n+               (line-e (or (plist-get symbol-meta :line-end) line-beg))\n+               (line-end line-beg)\n+               (col-beg (1- (or (plist-get symbol-meta :col-beg) 1)))\n+               (start (progn (forward-line (1- line-beg))\n+                             (move-to-column col-beg)\n                              (point)))\n-               (column-end (if (= line-start line-e)\n-                               (line-end-position)\n-                             (or (plist-get symbol-meta :col-end) (line-end-position))))\n+               (col-end (if (= line-beg line-e)\n+                            (line-end-position)\n+                          (or (plist-get symbol-meta :col-end) (line-end-position))))\n                (end (progn (goto-char (point-min))\n                            (forward-line (1- line-e))\n-                           (move-to-column column-end)\n+                           (move-to-column col-end)\n                            (point)))\n                (orig-name (plist-get symbol-meta :name))","path":"clj-refactor.el","position":226,"original_position":226,"commit_id":"66aff991af0540026aabf8fe6c6676ab379f870c","original_commit_id":"66aff991af0540026aabf8fe6c6676ab379f870c","user":{"login":"expez","id":1006557,"avatar_url":"https://avatars.githubusercontent.com/u/1006557?v=3","gravatar_id":"","url":"https://api.github.com/users/expez","html_url":"https://github.com/expez","followers_url":"https://api.github.com/users/expez/followers","following_url":"https://api.github.com/users/expez/following{/other_user}","gists_url":"https://api.github.com/users/expez/gists{/gist_id}","starred_url":"https://api.github.com/users/expez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expez/subscriptions","organizations_url":"https://api.github.com/users/expez/orgs","repos_url":"https://api.github.com/users/expez/repos","events_url":"https://api.github.com/users/expez/events{/privacy}","received_events_url":"https://api.github.com/users/expez/received_events","type":"User","site_admin":false},"body":"I just tried running this branch (can't get a repl going on the computer at work with this branch due to what looks like `mranderson` problems) and `orig-name` here is fully qualified so the renaming fails.  I haven't touched the code in the middleware creating the name, was it always like this @benedekfazekas?","created_at":"2015-03-10T18:36:02Z","updated_at":"2015-03-10T18:36:02Z","html_url":"https://github.com/clojure-emacs/clj-refactor.el/pull/121#discussion_r26151769","pull_request_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/comments/26151769"},"html":{"href":"https://github.com/clojure-emacs/clj-refactor.el/pull/121#discussion_r26151769"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121","id":30833153,"html_url":"https://github.com/clojure-emacs/clj-refactor.el/pull/121","diff_url":"https://github.com/clojure-emacs/clj-refactor.el/pull/121.diff","patch_url":"https://github.com/clojure-emacs/clj-refactor.el/pull/121.patch","issue_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/121","number":121,"state":"open","locked":false,"title":"Refactor to reflect api changes in refactor-nrepl","user":{"login":"expez","id":1006557,"avatar_url":"https://avatars.githubusercontent.com/u/1006557?v=3","gravatar_id":"","url":"https://api.github.com/users/expez","html_url":"https://github.com/expez","followers_url":"https://api.github.com/users/expez/followers","following_url":"https://api.github.com/users/expez/following{/other_user}","gists_url":"https://api.github.com/users/expez/gists{/gist_id}","starred_url":"https://api.github.com/users/expez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expez/subscriptions","organizations_url":"https://api.github.com/users/expez/orgs","repos_url":"https://api.github.com/users/expez/repos","events_url":"https://api.github.com/users/expez/events{/privacy}","received_events_url":"https://api.github.com/users/expez/received_events","type":"User","site_admin":false},"body":"- find-debug-fns and find-symbol are now toplevel ops\r\n- The return value of find-usages has changed","created_at":"2015-03-10T09:16:48Z","updated_at":"2015-03-10T18:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43afab649e9d59e66d17f1b0570b986bdd352b00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/121/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/statuses/66aff991af0540026aabf8fe6c6676ab379f870c","head":{"label":"clojure-emacs:refactor","ref":"refactor","sha":"66aff991af0540026aabf8fe6c6676ab379f870c","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":7909342,"name":"clj-refactor.el","full_name":"clojure-emacs/clj-refactor.el","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/clj-refactor.el","description":"A collection of simple Clojure refactoring functions for Emacs","fork":false,"url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el","forks_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/forks","keys_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/events","assignees_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/merges","archive_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/releases{/id}","created_at":"2013-01-30T06:44:10Z","updated_at":"2015-03-09T19:23:26Z","pushed_at":"2015-03-10T18:31:28Z","git_url":"git://github.com/clojure-emacs/clj-refactor.el.git","ssh_url":"git@github.com:clojure-emacs/clj-refactor.el.git","clone_url":"https://github.com/clojure-emacs/clj-refactor.el.git","svn_url":"https://github.com/clojure-emacs/clj-refactor.el","homepage":"","size":2070,"stargazers_count":226,"watchers_count":226,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":9,"forks":18,"open_issues":9,"watchers":226,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"6b760d91780630ccaac074f7df5f72e650aad0dc","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":7909342,"name":"clj-refactor.el","full_name":"clojure-emacs/clj-refactor.el","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/clj-refactor.el","description":"A collection of simple Clojure refactoring functions for Emacs","fork":false,"url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el","forks_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/forks","keys_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/events","assignees_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/merges","archive_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/releases{/id}","created_at":"2013-01-30T06:44:10Z","updated_at":"2015-03-09T19:23:26Z","pushed_at":"2015-03-10T18:31:28Z","git_url":"git://github.com/clojure-emacs/clj-refactor.el.git","ssh_url":"git@github.com:clojure-emacs/clj-refactor.el.git","clone_url":"https://github.com/clojure-emacs/clj-refactor.el.git","svn_url":"https://github.com/clojure-emacs/clj-refactor.el","homepage":"","size":2070,"stargazers_count":226,"watchers_count":226,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":9,"forks":18,"open_issues":9,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121"},"html":{"href":"https://github.com/clojure-emacs/clj-refactor.el/pull/121"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/121"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/clj-refactor.el/statuses/66aff991af0540026aabf8fe6c6676ab379f870c"}}}}