{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/45024106","id":45024106,"diff_hunk":"@@ -438,6 +438,9 @@ func createCgroupConfig(name string, spec *specs.LinuxRuntimeSpec, devices []*co\n \tif err != nil {\n \t\treturn nil, err\n \t}\n+\tif spec.Linux.CgroupsPath != \"\" {\n+\t\tname = spec.Linux.CgroupsPath\n+\t}","path":"spec.go","position":6,"original_position":6,"commit_id":"2363d453c567bb7080002a19303f3753fa7f3199","original_commit_id":"33344e9e4df259cc4a6a4682964f7c2156520504","user":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"body":"@hqhq  Cgroups path is expected to be a path relative to the cgroups mount: https://github.com/opencontainers/specs/blob/master/runtime_config_linux.go#L29","created_at":"2015-11-17T05:40:26Z","updated_at":"2015-11-17T05:40:26Z","html_url":"https://github.com/opencontainers/runc/pull/399#discussion_r45024106","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/45024106"},"html":{"href":"https://github.com/opencontainers/runc/pull/399#discussion_r45024106"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/399","id":50608825,"html_url":"https://github.com/opencontainers/runc/pull/399","diff_url":"https://github.com/opencontainers/runc/pull/399.diff","patch_url":"https://github.com/opencontainers/runc/pull/399.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/399","number":399,"state":"open","locked":false,"title":"CgroupsPath in runC","user":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"body":"This sets up the cgroupsPath. If cgroupsPath is passed in, runC will\r\ncheck if the cgroup exists. If it exists, runC will just join the\r\ncgroup, and will not make any modifications to the cgroups.\r\nIf it does not exist, runC will create the cgroup and join it.\r\nSigned-off-by: Abin Shahab <ashahab@altiscale.com>","created_at":"2015-11-13T06:29:50Z","updated_at":"2015-11-17T05:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7caf2f6b39a4f7cf9c4625886db51fc021955604","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/399/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/399/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/399/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/2363d453c567bb7080002a19303f3753fa7f3199","head":{"label":"ashahab-altiscale:396-cgroupsPath","ref":"396-cgroupsPath","sha":"2363d453c567bb7080002a19303f3753fa7f3199","user":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"repo":{"id":43943806,"name":"runc","full_name":"ashahab-altiscale/runc","owner":{"login":"ashahab-altiscale","id":5115017,"avatar_url":"https://avatars.githubusercontent.com/u/5115017?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahab-altiscale","html_url":"https://github.com/ashahab-altiscale","followers_url":"https://api.github.com/users/ashahab-altiscale/followers","following_url":"https://api.github.com/users/ashahab-altiscale/following{/other_user}","gists_url":"https://api.github.com/users/ashahab-altiscale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahab-altiscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahab-altiscale/subscriptions","organizations_url":"https://api.github.com/users/ashahab-altiscale/orgs","repos_url":"https://api.github.com/users/ashahab-altiscale/repos","events_url":"https://api.github.com/users/ashahab-altiscale/events{/privacy}","received_events_url":"https://api.github.com/users/ashahab-altiscale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashahab-altiscale/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/ashahab-altiscale/runc","forks_url":"https://api.github.com/repos/ashahab-altiscale/runc/forks","keys_url":"https://api.github.com/repos/ashahab-altiscale/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashahab-altiscale/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashahab-altiscale/runc/teams","hooks_url":"https://api.github.com/repos/ashahab-altiscale/runc/hooks","issue_events_url":"https://api.github.com/repos/ashahab-altiscale/runc/issues/events{/number}","events_url":"https://api.github.com/repos/ashahab-altiscale/runc/events","assignees_url":"https://api.github.com/repos/ashahab-altiscale/runc/assignees{/user}","branches_url":"https://api.github.com/repos/ashahab-altiscale/runc/branches{/branch}","tags_url":"https://api.github.com/repos/ashahab-altiscale/runc/tags","blobs_url":"https://api.github.com/repos/ashahab-altiscale/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashahab-altiscale/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashahab-altiscale/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashahab-altiscale/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashahab-altiscale/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/ashahab-altiscale/runc/languages","stargazers_url":"https://api.github.com/repos/ashahab-altiscale/runc/stargazers","contributors_url":"https://api.github.com/repos/ashahab-altiscale/runc/contributors","subscribers_url":"https://api.github.com/repos/ashahab-altiscale/runc/subscribers","subscription_url":"https://api.github.com/repos/ashahab-altiscale/runc/subscription","commits_url":"https://api.github.com/repos/ashahab-altiscale/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashahab-altiscale/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashahab-altiscale/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashahab-altiscale/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashahab-altiscale/runc/contents/{+path}","compare_url":"https://api.github.com/repos/ashahab-altiscale/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashahab-altiscale/runc/merges","archive_url":"https://api.github.com/repos/ashahab-altiscale/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashahab-altiscale/runc/downloads","issues_url":"https://api.github.com/repos/ashahab-altiscale/runc/issues{/number}","pulls_url":"https://api.github.com/repos/ashahab-altiscale/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/ashahab-altiscale/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/ashahab-altiscale/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashahab-altiscale/runc/labels{/name}","releases_url":"https://api.github.com/repos/ashahab-altiscale/runc/releases{/id}","created_at":"2015-10-09T08:49:51Z","updated_at":"2015-10-09T08:49:53Z","pushed_at":"2015-11-17T05:34:21Z","git_url":"git://github.com/ashahab-altiscale/runc.git","ssh_url":"git@github.com:ashahab-altiscale/runc.git","clone_url":"https://github.com/ashahab-altiscale/runc.git","svn_url":"https://github.com/ashahab-altiscale/runc","homepage":"","size":2136,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"776791463d2c6ef5a59931c89d5ac8527bb0e46a","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","created_at":"2015-06-05T23:30:45Z","updated_at":"2015-11-17T02:35:59Z","pushed_at":"2015-11-17T05:34:21Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"","size":3591,"stargazers_count":2244,"watchers_count":2244,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":57,"forks":259,"open_issues":57,"watchers":2244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/399"},"html":{"href":"https://github.com/opencontainers/runc/pull/399"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/399"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/2363d453c567bb7080002a19303f3753fa7f3199"}}}}