{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/71","labels_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/71/comments","events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/71/events","html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/71","id":80929150,"number":71,"title":"Fix logout to actually perform a POST request","user":{"login":"renner","id":729454,"avatar_url":"https://avatars.githubusercontent.com/u/729454?v=3","gravatar_id":"","url":"https://api.github.com/users/renner","html_url":"https://github.com/renner","followers_url":"https://api.github.com/users/renner/followers","following_url":"https://api.github.com/users/renner/following{/other_user}","gists_url":"https://api.github.com/users/renner/gists{/gist_id}","starred_url":"https://api.github.com/users/renner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renner/subscriptions","organizations_url":"https://api.github.com/users/renner/orgs","repos_url":"https://api.github.com/users/renner/repos","events_url":"https://api.github.com/users/renner/events{/privacy}","received_events_url":"https://api.github.com/users/renner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-26T11:54:14Z","updated_at":"2015-05-26T18:07:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/71","html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/71","diff_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/71.diff","patch_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/71.patch"},"body":"This patch should fix the `logout()` and `logoutAsync()` methods to actually perform a POST request. Recently we accidentally sent a GET request here since the `data` passed in to `create()` was `null`. The proposed patch is just a quick fix, we might want to reconsider the behaviour of the `create()` method that does actually create a GET request whenever the given data is `null`.\r\n\r\nFurther this pull request adds missing unit tests for `logout()` and `logoutAsync()` and the example response (`logout_response.json`) has been fixed.\r\n\r\nThis fixes issue #64."},"comment":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/comments/105621118","html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/71#issuecomment-105621118","issue_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/71","id":105621118,"user":{"login":"lucidd","id":688888,"avatar_url":"https://avatars.githubusercontent.com/u/688888?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidd","html_url":"https://github.com/lucidd","followers_url":"https://api.github.com/users/lucidd/followers","following_url":"https://api.github.com/users/lucidd/following{/other_user}","gists_url":"https://api.github.com/users/lucidd/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidd/subscriptions","organizations_url":"https://api.github.com/users/lucidd/orgs","repos_url":"https://api.github.com/users/lucidd/repos","events_url":"https://api.github.com/users/lucidd/events{/privacy}","received_events_url":"https://api.github.com/users/lucidd/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T18:07:11Z","updated_at":"2015-05-26T18:07:11Z","body":"LGTM"}}