{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/31825788","id":31825788,"diff_hunk":"@@ -0,0 +1,59 @@\n+module(\"admin.core\");\n+\n+test('Date.getTwelveHours', function(assert) {\n+  assert.equal(new Date(2011, 0, 1, 0, 0).getTwelveHours(), 12, '0:00');\n+  assert.equal(new Date(2011, 0, 1, 11, 0).getTwelveHours(), 11, '11:00');\n+  assert.equal(new Date(2011, 0, 1, 16, 0).getTwelveHours(), 4, '16:00');\n+});\n+\n+test('Date.getTwoDigitMonth', function(assert) {\n+  equal(new Date(2011, 0, 1).getTwoDigitMonth(), '01', 'jan 1');","path":"js_tests/admin/core.test.js","position":10,"original_position":10,"commit_id":"a9be6d0ac52818cafb0f9fe79b1feb335c7edd0a","original_commit_id":"a9be6d0ac52818cafb0f9fe79b1feb335c7edd0a","user":{"login":"oinopion","id":38861,"avatar_url":"https://avatars.githubusercontent.com/u/38861?v=3","gravatar_id":"","url":"https://api.github.com/users/oinopion","html_url":"https://github.com/oinopion","followers_url":"https://api.github.com/users/oinopion/followers","following_url":"https://api.github.com/users/oinopion/following{/other_user}","gists_url":"https://api.github.com/users/oinopion/gists{/gist_id}","starred_url":"https://api.github.com/users/oinopion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oinopion/subscriptions","organizations_url":"https://api.github.com/users/oinopion/orgs","repos_url":"https://api.github.com/users/oinopion/repos","events_url":"https://api.github.com/users/oinopion/events{/privacy}","received_events_url":"https://api.github.com/users/oinopion/received_events","type":"User","site_admin":false},"body":"Let's use `assert.equal` to be more consistent.","created_at":"2015-06-05T16:03:06Z","updated_at":"2015-06-05T16:03:06Z","html_url":"https://github.com/django/django/pull/4573#discussion_r31825788","pull_request_url":"https://api.github.com/repos/django/django/pulls/4573","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/31825788"},"html":{"href":"https://github.com/django/django/pull/4573#discussion_r31825788"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/4573"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/4573","id":34220565,"html_url":"https://github.com/django/django/pull/4573","diff_url":"https://github.com/django/django/pull/4573.diff","patch_url":"https://github.com/django/django/pull/4573.patch","issue_url":"https://api.github.com/repos/django/django/issues/4573","number":4573,"state":"open","locked":false,"title":"[WIP] Implements DEP 0003: Add JavaScript unit tests","user":{"login":"treyhunner","id":285352,"avatar_url":"https://avatars.githubusercontent.com/u/285352?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhunner","html_url":"https://github.com/treyhunner","followers_url":"https://api.github.com/users/treyhunner/followers","following_url":"https://api.github.com/users/treyhunner/following{/other_user}","gists_url":"https://api.github.com/users/treyhunner/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhunner/subscriptions","organizations_url":"https://api.github.com/users/treyhunner/orgs","repos_url":"https://api.github.com/users/treyhunner/repos","events_url":"https://api.github.com/users/treyhunner/events{/privacy}","received_events_url":"https://api.github.com/users/treyhunner/received_events","type":"User","site_admin":false},"body":"As detailed in [DEP 3][].  Uses QUnit with Blanket for code coverage and requires Node *only when running from the command-line*.  All tests run in the browser wiithout any external dependencies.\r\n\r\nBrowser Usage\r\n---------------------\r\n\r\nWithout measuring code coverage:\r\n\r\n- Open `./js_tests/tests.html` in your web browser and read the results\r\n\r\nWith measured code coverage:\r\n\r\n1. Execute `python -m SimpleHTTPServer`\r\n2. Open `http://localhost:8000/js_tests/tests.html?coverage` in your web browser and read the results\r\n\r\nNote that Node.js **is NOT required** to run the JavaScript tests in a web browser.\r\n\r\nCommand-line Usage\r\n-----------------------------\r\n\r\n1. Install Node.js\r\n2. Run `npm install` to install all local Node dependencies\r\n3. Run `npm test` to run the tests and read the results\r\n\r\nNote that Grunt **does NOT need to be installed** globally.\r\n\r\nThe minimum code coverage threshold can be set with the `globalThreshold` variable in `Gruntfile.js`.\r\n\r\n[dep 3]: https://github.com/django/deps/blob/master/draft/0003-javascript-tests.rst","created_at":"2015-04-27T23:25:44Z","updated_at":"2015-06-05T16:03:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"945320e337076bfc1a45c7bcf0d1c6601a2813f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/4573/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/4573/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/4573/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/a9be6d0ac52818cafb0f9fe79b1feb335c7edd0a","head":{"label":"treyhunner:js-tests","ref":"js-tests","sha":"a9be6d0ac52818cafb0f9fe79b1feb335c7edd0a","user":{"login":"treyhunner","id":285352,"avatar_url":"https://avatars.githubusercontent.com/u/285352?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhunner","html_url":"https://github.com/treyhunner","followers_url":"https://api.github.com/users/treyhunner/followers","following_url":"https://api.github.com/users/treyhunner/following{/other_user}","gists_url":"https://api.github.com/users/treyhunner/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhunner/subscriptions","organizations_url":"https://api.github.com/users/treyhunner/orgs","repos_url":"https://api.github.com/users/treyhunner/repos","events_url":"https://api.github.com/users/treyhunner/events{/privacy}","received_events_url":"https://api.github.com/users/treyhunner/received_events","type":"User","site_admin":false},"repo":{"id":10974211,"name":"django","full_name":"treyhunner/django","owner":{"login":"treyhunner","id":285352,"avatar_url":"https://avatars.githubusercontent.com/u/285352?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhunner","html_url":"https://github.com/treyhunner","followers_url":"https://api.github.com/users/treyhunner/followers","following_url":"https://api.github.com/users/treyhunner/following{/other_user}","gists_url":"https://api.github.com/users/treyhunner/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhunner/subscriptions","organizations_url":"https://api.github.com/users/treyhunner/orgs","repos_url":"https://api.github.com/users/treyhunner/repos","events_url":"https://api.github.com/users/treyhunner/events{/privacy}","received_events_url":"https://api.github.com/users/treyhunner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/treyhunner/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/treyhunner/django","forks_url":"https://api.github.com/repos/treyhunner/django/forks","keys_url":"https://api.github.com/repos/treyhunner/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/treyhunner/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/treyhunner/django/teams","hooks_url":"https://api.github.com/repos/treyhunner/django/hooks","issue_events_url":"https://api.github.com/repos/treyhunner/django/issues/events{/number}","events_url":"https://api.github.com/repos/treyhunner/django/events","assignees_url":"https://api.github.com/repos/treyhunner/django/assignees{/user}","branches_url":"https://api.github.com/repos/treyhunner/django/branches{/branch}","tags_url":"https://api.github.com/repos/treyhunner/django/tags","blobs_url":"https://api.github.com/repos/treyhunner/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/treyhunner/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/treyhunner/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/treyhunner/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/treyhunner/django/statuses/{sha}","languages_url":"https://api.github.com/repos/treyhunner/django/languages","stargazers_url":"https://api.github.com/repos/treyhunner/django/stargazers","contributors_url":"https://api.github.com/repos/treyhunner/django/contributors","subscribers_url":"https://api.github.com/repos/treyhunner/django/subscribers","subscription_url":"https://api.github.com/repos/treyhunner/django/subscription","commits_url":"https://api.github.com/repos/treyhunner/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/treyhunner/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/treyhunner/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/treyhunner/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/treyhunner/django/contents/{+path}","compare_url":"https://api.github.com/repos/treyhunner/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/treyhunner/django/merges","archive_url":"https://api.github.com/repos/treyhunner/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/treyhunner/django/downloads","issues_url":"https://api.github.com/repos/treyhunner/django/issues{/number}","pulls_url":"https://api.github.com/repos/treyhunner/django/pulls{/number}","milestones_url":"https://api.github.com/repos/treyhunner/django/milestones{/number}","notifications_url":"https://api.github.com/repos/treyhunner/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/treyhunner/django/labels{/name}","releases_url":"https://api.github.com/repos/treyhunner/django/releases{/id}","created_at":"2013-06-26T17:23:08Z","updated_at":"2015-03-10T00:44:58Z","pushed_at":"2015-05-10T23:15:22Z","git_url":"git://github.com/treyhunner/django.git","ssh_url":"git@github.com:treyhunner/django.git","clone_url":"https://github.com/treyhunner/django.git","svn_url":"https://github.com/treyhunner/django","homepage":"http://www.djangoproject.com/","size":116491,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"25b52d04f6eace3b702adf7c6ab68daf1867c7e3","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-06-05T15:10:35Z","pushed_at":"2015-06-05T16:01:35Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":291841,"stargazers_count":14517,"watchers_count":14517,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5804,"mirror_url":null,"open_issues_count":99,"forks":5804,"open_issues":99,"watchers":14517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/4573"},"html":{"href":"https://github.com/django/django/pull/4573"},"issue":{"href":"https://api.github.com/repos/django/django/issues/4573"},"comments":{"href":"https://api.github.com/repos/django/django/issues/4573/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/4573/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/4573/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/a9be6d0ac52818cafb0f9fe79b1feb335c7edd0a"}}}}