{"action":"created","issue":{"url":"https://api.github.com/repos/takari/maven-wrapper/issues/3","labels_url":"https://api.github.com/repos/takari/maven-wrapper/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/takari/maven-wrapper/issues/3/comments","events_url":"https://api.github.com/repos/takari/maven-wrapper/issues/3/events","html_url":"https://github.com/takari/maven-wrapper/issues/3","id":95200727,"number":3,"title":"Apparent inconsistencies regarding command line options","user":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-15T14:00:27Z","updated_at":"2015-07-15T16:51:10Z","closed_at":null,"body":"The Un*X script has this:\r\n\r\n```\r\nMAVEN_CMD_LINE_ARGS=\"$MAVEN_CONFIG $@\"\r\nexport MAVEN_CMD_LINE_ARGS\r\n...\r\nexec \"$JAVACMD\"  ... \"$@\"\r\n```\r\n\r\nI.e. `MAVEN_CONFIG` are added to the env var but not used in the actual command line.\r\n\r\nThe windows one has this:\r\n\r\n```\r\nset MAVEN_CMD_LINE_ARGS=%*\r\n\r\n...\r\n%MAVEN_JAVA_EXE% ... %MAVEN_CMD_LINE_ARGS%\r\n```\r\n\r\nI.e. `MAVEN_CONFIG` is ignored, but the env var is used on the command line.\r\n\r\nI'm happy to fix it and send a PR if you can provide some guidance on what the actual intent was.\r\n\r\nAlso, what I ultimately want, which could be more of a discussion, I don't know, is to be able to change the maven command line arguments from a file that I can put in source control. I see that might be dangerous if the user wants to override it, but this is my current best hope to get a build that works for everyone out of the box, and yet doesn't have repositories (and distribution management) hard-coded in poms."},"comment":{"url":"https://api.github.com/repos/takari/maven-wrapper/issues/comments/121677074","html_url":"https://github.com/takari/maven-wrapper/issues/3#issuecomment-121677074","issue_url":"https://api.github.com/repos/takari/maven-wrapper/issues/3","id":121677074,"user":{"login":"spencergibb","id":594085,"avatar_url":"https://avatars.githubusercontent.com/u/594085?v=3","gravatar_id":"","url":"https://api.github.com/users/spencergibb","html_url":"https://github.com/spencergibb","followers_url":"https://api.github.com/users/spencergibb/followers","following_url":"https://api.github.com/users/spencergibb/following{/other_user}","gists_url":"https://api.github.com/users/spencergibb/gists{/gist_id}","starred_url":"https://api.github.com/users/spencergibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencergibb/subscriptions","organizations_url":"https://api.github.com/users/spencergibb/orgs","repos_url":"https://api.github.com/users/spencergibb/repos","events_url":"https://api.github.com/users/spencergibb/events{/privacy}","received_events_url":"https://api.github.com/users/spencergibb/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T16:51:10Z","updated_at":"2015-07-15T16:51:10Z","body":"@dsyer maybe we could add something like this to the already existing block\r\n```\r\nif [ -z \"$MAVEN_SKIP_RC\" ] ; then\r\n\r\n  if [ -f /etc/mavenrc ] ; then\r\n    . /etc/mavenrc\r\n  fi\r\n\r\n  if [ -f \"$HOME/.mavenrc\" ] ; then\r\n    . \"$HOME/.mavenrc\"\r\n  fi\r\n#new current dir check\r\n  if [ -f \"./.mavenrc\" ] ; then\r\n    . \"./.mavenrc\"\r\n  fi\r\n\r\nfi\r\n```\r\nThat way they can opt out if they set `MAVEN_SKIP_RC` and we can check `./.mavenrc` into src control.\r\nAn alternative to `./.mavenrc` could be `./.mvn/mavenrc` (since `.mvn` is already checked in to src control."}}