{"action":"created","issue":{"url":"https://api.github.com/repos/Attnam/ivan/issues/67","labels_url":"https://api.github.com/repos/Attnam/ivan/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/Attnam/ivan/issues/67/comments","events_url":"https://api.github.com/repos/Attnam/ivan/issues/67/events","html_url":"https://github.com/Attnam/ivan/pull/67","id":101106215,"number":67,"title":"C++11 migration, part 1","user":{"login":"emlai","id":7543552,"avatar_url":"https://avatars.githubusercontent.com/u/7543552?v=3","gravatar_id":"","url":"https://api.github.com/users/emlai","html_url":"https://github.com/emlai","followers_url":"https://api.github.com/users/emlai/followers","following_url":"https://api.github.com/users/emlai/following{/other_user}","gists_url":"https://api.github.com/users/emlai/gists{/gist_id}","starred_url":"https://api.github.com/users/emlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlai/subscriptions","organizations_url":"https://api.github.com/users/emlai/orgs","repos_url":"https://api.github.com/users/emlai/repos","events_url":"https://api.github.com/users/emlai/events{/privacy}","received_events_url":"https://api.github.com/users/emlai/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-14T21:30:15Z","updated_at":"2015-08-15T22:50:49Z","closed_at":"2015-08-15T08:11:48Z","pull_request":{"url":"https://api.github.com/repos/Attnam/ivan/pulls/67","html_url":"https://github.com/Attnam/ivan/pull/67","diff_url":"https://github.com/Attnam/ivan/pull/67.diff","patch_url":"https://github.com/Attnam/ivan/pull/67.patch"},"body":"These commits slightly improve readability (especially in the case of range-`for`), maybe efficiency in some areas, and of course, make the source code more \"modern\" and slightly more attractive to C++ developers.\r\n\r\nWhen I have more time I will do some more (drastic) changes, e.g. smart pointers (nobody wants raw `new`/`delete` in their C++ anymore), move semantics, auto, lambdas, etc.\r\n\r\nBtw was there some specific reason why `truth` was typedefed to `long`? I can't think of any, and changing it to `bool` made save/bone files incompatible. We could of course still read/write bools as longs from/to files to stay compatible with saves/bones, but is it worth it, what do you think?"},"comment":{"url":"https://api.github.com/repos/Attnam/ivan/issues/comments/131462408","html_url":"https://github.com/Attnam/ivan/pull/67#issuecomment-131462408","issue_url":"https://api.github.com/repos/Attnam/ivan/issues/67","id":131462408,"user":{"login":"rvanherel","id":6005108,"avatar_url":"https://avatars.githubusercontent.com/u/6005108?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanherel","html_url":"https://github.com/rvanherel","followers_url":"https://api.github.com/users/rvanherel/followers","following_url":"https://api.github.com/users/rvanherel/following{/other_user}","gists_url":"https://api.github.com/users/rvanherel/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanherel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanherel/subscriptions","organizations_url":"https://api.github.com/users/rvanherel/orgs","repos_url":"https://api.github.com/users/rvanherel/repos","events_url":"https://api.github.com/users/rvanherel/events{/privacy}","received_events_url":"https://api.github.com/users/rvanherel/received_events","type":"User","site_admin":false},"created_at":"2015-08-15T22:50:49Z","updated_at":"2015-08-15T22:50:49Z","body":"I have to set -DWIN32 :(\r\nBut it compiles with gcc4.8.1 !! "}}