{"action":"created","comment":{"url":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments/29284982","id":29284982,"diff_hunk":"@@ -0,0 +1,76 @@\n+(function (window) {\n+\n+// imports\n+var Event = window.ghs.content.app.events.Event;\n+var PopupManager = window.ghs.content.app.ui.PopupManager;\n+var GotoLinePopup = window.ghs.content.app.ui.popups.GotoLinePopup;\n+\n+/**\n+ * GotoLineCommand constructor.\n+ * TODO: should inherit AbstractCommand.\n+ */\n+var GotoLineCommand = function () {\n+\tthis._popup = null;\n+\tthis._onSubmitHandler = this._onSubmit.bind(this);\n+\tthis._onCloseHandler = this._onClose.bind(this);\n+};\n+\n+/**\n+ * Override. Run command.\n+ */\n+GotoLineCommand.prototype.run = function () {\n+\tthis._popup = new GotoLinePopup();\n+\n+\tthis._popup.on(Event.SUBMIT, this._onSubmitHandler);\n+\tthis._popup.on(Event.CLOSE, this._onCloseHandler);\n+\n+\tPopupManager.global().show(this._popup);","path":"content/app/commands/goto-line-command.js","position":27,"original_position":27,"commit_id":"c95be1746ad5d6e30fdc80467a976af6409168ec","original_commit_id":"c95be1746ad5d6e30fdc80467a976af6409168ec","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"body":"Is it a good idea to use global references?","created_at":"2015-04-28T20:31:00Z","updated_at":"2015-04-28T20:31:00Z","html_url":"https://github.com/zikicm/github-sublime/pull/5#discussion_r29284982","pull_request_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments/29284982"},"html":{"href":"https://github.com/zikicm/github-sublime/pull/5#discussion_r29284982"},"pull_request":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/zikicm/github-sublime/pulls/5","id":34130458,"html_url":"https://github.com/zikicm/github-sublime/pull/5","diff_url":"https://github.com/zikicm/github-sublime/pull/5.diff","patch_url":"https://github.com/zikicm/github-sublime/pull/5.patch","issue_url":"https://api.github.com/repos/zikicm/github-sublime/issues/5","number":5,"state":"open","locked":false,"title":"Content script commands architecture and initial goto-line command code.","user":{"login":"comanjoni","id":3792083,"avatar_url":"https://avatars.githubusercontent.com/u/3792083?v=3","gravatar_id":"","url":"https://api.github.com/users/comanjoni","html_url":"https://github.com/comanjoni","followers_url":"https://api.github.com/users/comanjoni/followers","following_url":"https://api.github.com/users/comanjoni/following{/other_user}","gists_url":"https://api.github.com/users/comanjoni/gists{/gist_id}","starred_url":"https://api.github.com/users/comanjoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comanjoni/subscriptions","organizations_url":"https://api.github.com/users/comanjoni/orgs","repos_url":"https://api.github.com/users/comanjoni/repos","events_url":"https://api.github.com/users/comanjoni/events{/privacy}","received_events_url":"https://api.github.com/users/comanjoni/received_events","type":"User","site_admin":false},"body":"@zikicm please take a look at changes\r\n- updated version and added new fields in manifest\r\n- content script commands architecture\r\n  - event management\r\n  - popup management\r\n  - command management\r\n- goto-line command basics (note: functionality is not completed)","created_at":"2015-04-26T21:31:42Z","updated_at":"2015-04-28T20:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7368a2fd10a3174034d87025f4d7b88a6f854615","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/5/commits","review_comments_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/5/comments","review_comment_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/issues/5/comments","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/c95be1746ad5d6e30fdc80467a976af6409168ec","head":{"label":"zikicm:commands-initil","ref":"commands-initil","sha":"c95be1746ad5d6e30fdc80467a976af6409168ec","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"repo":{"id":33692628,"name":"github-sublime","full_name":"zikicm/github-sublime","owner":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zikicm/github-sublime","description":"Chrome plug in which adds Sublime most used features to GitHub browsing.","fork":false,"url":"https://api.github.com/repos/zikicm/github-sublime","forks_url":"https://api.github.com/repos/zikicm/github-sublime/forks","keys_url":"https://api.github.com/repos/zikicm/github-sublime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikicm/github-sublime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikicm/github-sublime/teams","hooks_url":"https://api.github.com/repos/zikicm/github-sublime/hooks","issue_events_url":"https://api.github.com/repos/zikicm/github-sublime/issues/events{/number}","events_url":"https://api.github.com/repos/zikicm/github-sublime/events","assignees_url":"https://api.github.com/repos/zikicm/github-sublime/assignees{/user}","branches_url":"https://api.github.com/repos/zikicm/github-sublime/branches{/branch}","tags_url":"https://api.github.com/repos/zikicm/github-sublime/tags","blobs_url":"https://api.github.com/repos/zikicm/github-sublime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikicm/github-sublime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikicm/github-sublime/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikicm/github-sublime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/{sha}","languages_url":"https://api.github.com/repos/zikicm/github-sublime/languages","stargazers_url":"https://api.github.com/repos/zikicm/github-sublime/stargazers","contributors_url":"https://api.github.com/repos/zikicm/github-sublime/contributors","subscribers_url":"https://api.github.com/repos/zikicm/github-sublime/subscribers","subscription_url":"https://api.github.com/repos/zikicm/github-sublime/subscription","commits_url":"https://api.github.com/repos/zikicm/github-sublime/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikicm/github-sublime/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikicm/github-sublime/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikicm/github-sublime/contents/{+path}","compare_url":"https://api.github.com/repos/zikicm/github-sublime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikicm/github-sublime/merges","archive_url":"https://api.github.com/repos/zikicm/github-sublime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikicm/github-sublime/downloads","issues_url":"https://api.github.com/repos/zikicm/github-sublime/issues{/number}","pulls_url":"https://api.github.com/repos/zikicm/github-sublime/pulls{/number}","milestones_url":"https://api.github.com/repos/zikicm/github-sublime/milestones{/number}","notifications_url":"https://api.github.com/repos/zikicm/github-sublime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikicm/github-sublime/labels{/name}","releases_url":"https://api.github.com/repos/zikicm/github-sublime/releases{/id}","created_at":"2015-04-09T21:02:01Z","updated_at":"2015-04-26T21:20:09Z","pushed_at":"2015-04-26T21:31:43Z","git_url":"git://github.com/zikicm/github-sublime.git","ssh_url":"git@github.com:zikicm/github-sublime.git","clone_url":"https://github.com/zikicm/github-sublime.git","svn_url":"https://github.com/zikicm/github-sublime","homepage":null,"size":196,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"zikicm:master","ref":"master","sha":"eb9eb52815db452fac0296ecc61ff9fa781c5a77","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"repo":{"id":33692628,"name":"github-sublime","full_name":"zikicm/github-sublime","owner":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zikicm/github-sublime","description":"Chrome plug in which adds Sublime most used features to GitHub browsing.","fork":false,"url":"https://api.github.com/repos/zikicm/github-sublime","forks_url":"https://api.github.com/repos/zikicm/github-sublime/forks","keys_url":"https://api.github.com/repos/zikicm/github-sublime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikicm/github-sublime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikicm/github-sublime/teams","hooks_url":"https://api.github.com/repos/zikicm/github-sublime/hooks","issue_events_url":"https://api.github.com/repos/zikicm/github-sublime/issues/events{/number}","events_url":"https://api.github.com/repos/zikicm/github-sublime/events","assignees_url":"https://api.github.com/repos/zikicm/github-sublime/assignees{/user}","branches_url":"https://api.github.com/repos/zikicm/github-sublime/branches{/branch}","tags_url":"https://api.github.com/repos/zikicm/github-sublime/tags","blobs_url":"https://api.github.com/repos/zikicm/github-sublime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikicm/github-sublime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikicm/github-sublime/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikicm/github-sublime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/{sha}","languages_url":"https://api.github.com/repos/zikicm/github-sublime/languages","stargazers_url":"https://api.github.com/repos/zikicm/github-sublime/stargazers","contributors_url":"https://api.github.com/repos/zikicm/github-sublime/contributors","subscribers_url":"https://api.github.com/repos/zikicm/github-sublime/subscribers","subscription_url":"https://api.github.com/repos/zikicm/github-sublime/subscription","commits_url":"https://api.github.com/repos/zikicm/github-sublime/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikicm/github-sublime/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikicm/github-sublime/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikicm/github-sublime/contents/{+path}","compare_url":"https://api.github.com/repos/zikicm/github-sublime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikicm/github-sublime/merges","archive_url":"https://api.github.com/repos/zikicm/github-sublime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikicm/github-sublime/downloads","issues_url":"https://api.github.com/repos/zikicm/github-sublime/issues{/number}","pulls_url":"https://api.github.com/repos/zikicm/github-sublime/pulls{/number}","milestones_url":"https://api.github.com/repos/zikicm/github-sublime/milestones{/number}","notifications_url":"https://api.github.com/repos/zikicm/github-sublime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikicm/github-sublime/labels{/name}","releases_url":"https://api.github.com/repos/zikicm/github-sublime/releases{/id}","created_at":"2015-04-09T21:02:01Z","updated_at":"2015-04-26T21:20:09Z","pushed_at":"2015-04-26T21:31:43Z","git_url":"git://github.com/zikicm/github-sublime.git","ssh_url":"git@github.com:zikicm/github-sublime.git","clone_url":"https://github.com/zikicm/github-sublime.git","svn_url":"https://github.com/zikicm/github-sublime","homepage":null,"size":196,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/5"},"html":{"href":"https://github.com/zikicm/github-sublime/pull/5"},"issue":{"href":"https://api.github.com/repos/zikicm/github-sublime/issues/5"},"comments":{"href":"https://api.github.com/repos/zikicm/github-sublime/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/zikicm/github-sublime/statuses/c95be1746ad5d6e30fdc80467a976af6409168ec"}}}}