{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2116","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2116/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2116/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2116/events","html_url":"https://github.com/LMMS/lmms/pull/2116","id":89188039,"number":2116,"title":"Removed legacy friend declarations","user":{"login":"Wallacoloo","id":1210751,"avatar_url":"https://avatars.githubusercontent.com/u/1210751?v=3","gravatar_id":"","url":"https://api.github.com/users/Wallacoloo","html_url":"https://github.com/Wallacoloo","followers_url":"https://api.github.com/users/Wallacoloo/followers","following_url":"https://api.github.com/users/Wallacoloo/following{/other_user}","gists_url":"https://api.github.com/users/Wallacoloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallacoloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallacoloo/subscriptions","organizations_url":"https://api.github.com/users/Wallacoloo/orgs","repos_url":"https://api.github.com/users/Wallacoloo/repos","events_url":"https://api.github.com/users/Wallacoloo/events{/privacy}","received_events_url":"https://api.github.com/users/Wallacoloo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-18T03:30:07Z","updated_at":"2015-06-18T08:00:48Z","closed_at":"2015-06-18T08:00:27Z","pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2116","html_url":"https://github.com/LMMS/lmms/pull/2116","diff_url":"https://github.com/LMMS/lmms/pull/2116.diff","patch_url":"https://github.com/LMMS/lmms/pull/2116.patch"},"body":"There was an unnecessary \"friend\" declaration in both the AutomationEditor and PianoRoll classes giving the Engine class access to private members. I'm guessing this may have been a remnant from some point where the gui was even more intertwined with the core. But LMMS compiles fine without these classes being friends, so I say we remove these declarations."},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/113068066","html_url":"https://github.com/LMMS/lmms/pull/2116#issuecomment-113068066","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2116","id":113068066,"user":{"login":"Lukas-W","id":2879917,"avatar_url":"https://avatars.githubusercontent.com/u/2879917?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukas-W","html_url":"https://github.com/Lukas-W","followers_url":"https://api.github.com/users/Lukas-W/followers","following_url":"https://api.github.com/users/Lukas-W/following{/other_user}","gists_url":"https://api.github.com/users/Lukas-W/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukas-W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukas-W/subscriptions","organizations_url":"https://api.github.com/users/Lukas-W/orgs","repos_url":"https://api.github.com/users/Lukas-W/repos","events_url":"https://api.github.com/users/Lukas-W/events{/privacy}","received_events_url":"https://api.github.com/users/Lukas-W/received_events","type":"User","site_admin":false},"created_at":"2015-06-18T08:00:48Z","updated_at":"2015-06-18T08:00:48Z","body":":+1: "}}