{"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/23454499","id":23454499,"diff_hunk":"@@ -0,0 +1,6 @@\n+require \"logstash/devutils/rspec/spec_helper\"\n+require 'logstash/devutils/rspec/logstash_helpers'\n+\n+require \"logstash/filters/base\"\n+require \"logstash/outputs/base\"\n+require \"logstash/namespace\"","path":"spec/spec_helper.rb","position":6,"original_position":6,"commit_id":"ede3c73db5c5ff8a194b8a0810ef7af2de13c6b1","original_commit_id":"ede3c73db5c5ff8a194b8a0810ef7af2de13c6b1","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"+1 for removing them ? ;)","created_at":"2015-01-23T15:05:42Z","updated_at":"2015-01-23T15:05:42Z","html_url":"https://github.com/elasticsearch/logstash/pull/2412#discussion_r23454499","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/23454499"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/2412#discussion_r23454499"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412","id":27928106,"html_url":"https://github.com/elasticsearch/logstash/pull/2412","diff_url":"https://github.com/elasticsearch/logstash/pull/2412.diff","patch_url":"https://github.com/elasticsearch/logstash/pull/2412.patch","issue_url":"https://api.github.com/repos/elasticsearch/logstash/issues/2412","number":2412,"state":"open","locked":false,"title":"Test Coverage reenabled","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"The motivation of this PR is basically to enable the opportunity to get a coverage report from Logstash. This basically enable developers to get a coverage report when the ENV variable COVERAGE evaluate to true, so for example:\r\n\r\n```COVERAGE=true ./bin/logstash rspec``` or ```COVERAGE=true rake test``` will create a coverage report.\r\n\r\nIf within a CI, Coveralls will get the report, fixing #2113.\r\n\r\n### Note\r\n\r\ncoverage related gems are only installed when the user execute ```rake test:prep``` also used to install plugins used while testing.\r\n","created_at":"2015-01-23T14:45:31Z","updated_at":"2015-01-23T15:05:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d2319ee162bf765e94ae6b7ce52058802263464","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/issues/2412/comments","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/ede3c73db5c5ff8a194b8a0810ef7af2de13c6b1","head":{"label":"purbon:fix/coverage_report","ref":"fix/coverage_report","sha":"ede3c73db5c5ff8a194b8a0810ef7af2de13c6b1","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"repo":{"id":26748658,"name":"logstash","full_name":"purbon/logstash","owner":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purbon/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/purbon/logstash","forks_url":"https://api.github.com/repos/purbon/logstash/forks","keys_url":"https://api.github.com/repos/purbon/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purbon/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purbon/logstash/teams","hooks_url":"https://api.github.com/repos/purbon/logstash/hooks","issue_events_url":"https://api.github.com/repos/purbon/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/purbon/logstash/events","assignees_url":"https://api.github.com/repos/purbon/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/purbon/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/purbon/logstash/tags","blobs_url":"https://api.github.com/repos/purbon/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purbon/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purbon/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/purbon/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purbon/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/purbon/logstash/languages","stargazers_url":"https://api.github.com/repos/purbon/logstash/stargazers","contributors_url":"https://api.github.com/repos/purbon/logstash/contributors","subscribers_url":"https://api.github.com/repos/purbon/logstash/subscribers","subscription_url":"https://api.github.com/repos/purbon/logstash/subscription","commits_url":"https://api.github.com/repos/purbon/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/purbon/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/purbon/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/purbon/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/purbon/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/purbon/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purbon/logstash/merges","archive_url":"https://api.github.com/repos/purbon/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purbon/logstash/downloads","issues_url":"https://api.github.com/repos/purbon/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/purbon/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/purbon/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/purbon/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purbon/logstash/labels{/name}","releases_url":"https://api.github.com/repos/purbon/logstash/releases{/id}","created_at":"2014-11-17T09:01:27Z","updated_at":"2015-01-23T12:34:02Z","pushed_at":"2015-01-23T14:36:32Z","git_url":"git://github.com/purbon/logstash.git","ssh_url":"git@github.com:purbon/logstash.git","clone_url":"https://github.com/purbon/logstash.git","svn_url":"https://github.com/purbon/logstash","homepage":"http://logstash.net/","size":71125,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"46e96fb0a2a16a44a7d5980f81d0b76c201c705a","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elasticsearch/logstash","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":false,"url":"https://api.github.com/repos/elasticsearch/logstash","forks_url":"https://api.github.com/repos/elasticsearch/logstash/forks","keys_url":"https://api.github.com/repos/elasticsearch/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/logstash/teams","hooks_url":"https://api.github.com/repos/elasticsearch/logstash/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/logstash/events","assignees_url":"https://api.github.com/repos/elasticsearch/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/logstash/tags","blobs_url":"https://api.github.com/repos/elasticsearch/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/logstash/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/logstash/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/logstash/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/logstash/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/logstash/subscription","commits_url":"https://api.github.com/repos/elasticsearch/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/logstash/merges","archive_url":"https://api.github.com/repos/elasticsearch/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/logstash/downloads","issues_url":"https://api.github.com/repos/elasticsearch/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-01-23T13:42:24Z","pushed_at":"2015-01-23T06:33:21Z","git_url":"git://github.com/elasticsearch/logstash.git","ssh_url":"git@github.com:elasticsearch/logstash.git","clone_url":"https://github.com/elasticsearch/logstash.git","svn_url":"https://github.com/elasticsearch/logstash","homepage":"http://logstash.net/","size":86172,"stargazers_count":3579,"watchers_count":3579,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1323,"mirror_url":null,"open_issues_count":544,"forks":1323,"open_issues":544,"watchers":3579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/2412"},"issue":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/2412"},"comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/2412/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/2412/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/logstash/statuses/ede3c73db5c5ff8a194b8a0810ef7af2de13c6b1"}}}}