{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4295","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4295/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4295/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4295/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/4295","id":69841882,"number":4295,"title":"DUI: icons for custom nodes","user":{"login":"aosyatnik","id":8158404,"avatar_url":"https://avatars.githubusercontent.com/u/8158404?v=3","gravatar_id":"","url":"https://api.github.com/users/aosyatnik","html_url":"https://github.com/aosyatnik","followers_url":"https://api.github.com/users/aosyatnik/followers","following_url":"https://api.github.com/users/aosyatnik/following{/other_user}","gists_url":"https://api.github.com/users/aosyatnik/gists{/gist_id}","starred_url":"https://api.github.com/users/aosyatnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aosyatnik/subscriptions","organizations_url":"https://api.github.com/users/aosyatnik/orgs","repos_url":"https://api.github.com/users/aosyatnik/repos","events_url":"https://api.github.com/users/aosyatnik/events{/privacy}","received_events_url":"https://api.github.com/users/aosyatnik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-04-21T13:11:26Z","updated_at":"2015-04-30T08:13:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4295","html_url":"https://github.com/DynamoDS/Dynamo/pull/4295","diff_url":"https://github.com/DynamoDS/Dynamo/pull/4295.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/4295.patch"},"body":"This PR implements icons for custom nodes.\r\nPlaces, that need your attention:\r\n1. Custom node icon has the same name as custom node ID.\r\n2. Dynamo should search for customization dll just in bin folder of Package. (`useAdditionalPaths`  is used to limit places, where it should look for `Package.customization.dll`)\r\n3. If customization dll is found, but icon name is not found - Dynamo loads deafult icon from FOUND customization dll. If there is no default icon/customization dll not found Dynamo loads default icon from its' core.\r\n\r\nResults:\r\nPackage with custom dll. Package.customization.dll has default icon(look at pic. \"D\")\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8158404/7252733/5e4ddbe6-e840-11e4-9680-812c4c4d6739.png)\r\n\r\nPackage without custom dll.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8158404/7252759/83c9fb3e-e840-11e4-95a2-6f2348b72161.png)\r\n\r\nReviewers\r\n@Benglin , please take a look.\r\n\r\nLink to YouTrack:\r\n[MAGN-6311](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-6311) Add icons support for Custom Nodes"},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/97702472","html_url":"https://github.com/DynamoDS/Dynamo/pull/4295#issuecomment-97702472","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4295","id":97702472,"user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"created_at":"2015-04-30T08:13:43Z","updated_at":"2015-04-30T08:13:43Z","body":"Thanks @aosyatnik, this is a great enhancement, can't wait to see it in action! @elayabharath, it's about time we took this for a spin and document the necessary steps to make icons for custom nodes."}}