{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20","id":42727943,"html_url":"https://github.com/segmentio/integration-mailchimp/pull/20","diff_url":"https://github.com/segmentio/integration-mailchimp/pull/20.diff","patch_url":"https://github.com/segmentio/integration-mailchimp/pull/20.patch","issue_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/20","number":20,"state":"closed","locked":false,"title":"add more tests and better trait mapping","user":{"login":"hankim813","id":5907121,"avatar_url":"https://avatars.githubusercontent.com/u/5907121?v=3","gravatar_id":"","url":"https://api.github.com/users/hankim813","html_url":"https://github.com/hankim813","followers_url":"https://api.github.com/users/hankim813/followers","following_url":"https://api.github.com/users/hankim813/following{/other_user}","gists_url":"https://api.github.com/users/hankim813/gists{/gist_id}","starred_url":"https://api.github.com/users/hankim813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankim813/subscriptions","organizations_url":"https://api.github.com/users/hankim813/orgs","repos_url":"https://api.github.com/users/hankim813/repos","events_url":"https://api.github.com/users/hankim813/events{/privacy}","received_events_url":"https://api.github.com/users/hankim813/received_events","type":"User","site_admin":false},"body":"@ndhoule \r\n\r\nI added more tests and modified how we map the traits. We were originally appending `userId` as a merge trait but reading their docs, it sounds like they have a semantic read only `unique_email_id` that should be mapped to the `userId` if users pass that in.\r\n\r\nadded some minor refractoring to make code cleaner. \r\n\r\nalso realized that `status` is required field when updating profiles so added that as well.\r\n\r\nsorry for changing up the fixtures, had to do it to test if new implementation was creating new profiles.\r\n\r\nalso tested for backward compatibility after implementing all the new changes. existing emails can still properly update.","created_at":"2015-08-18T17:51:41Z","updated_at":"2015-08-18T18:17:33Z","closed_at":"2015-08-18T18:17:32Z","merged_at":"2015-08-18T18:17:32Z","merge_commit_sha":"5932620c34b54422f35aa070a3eca82705f4e30e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20/commits","review_comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20/comments","review_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/20/comments","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/4a2224993345437b72bfa4269832635a421d70d6","head":{"label":"segmentio:fix/bugs","ref":"fix/bugs","sha":"4a2224993345437b72bfa4269832635a421d70d6","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":26639850,"name":"integration-mailchimp","full_name":"segmentio/integration-mailchimp","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/integration-mailchimp","description":"MailChimp server-side integration","fork":false,"url":"https://api.github.com/repos/segmentio/integration-mailchimp","forks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/forks","keys_url":"https://api.github.com/repos/segmentio/integration-mailchimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/integration-mailchimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/integration-mailchimp/teams","hooks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/hooks","issue_events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/events","assignees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/integration-mailchimp/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/tags","blobs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/integration-mailchimp/languages","stargazers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/stargazers","contributors_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contributors","subscribers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscribers","subscription_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscription","commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/integration-mailchimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/integration-mailchimp/merges","archive_url":"https://api.github.com/repos/segmentio/integration-mailchimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/integration-mailchimp/downloads","issues_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/integration-mailchimp/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/integration-mailchimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/integration-mailchimp/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/integration-mailchimp/releases{/id}","created_at":"2014-11-14T13:31:38Z","updated_at":"2015-04-09T05:22:44Z","pushed_at":"2015-08-18T18:17:33Z","git_url":"git://github.com/segmentio/integration-mailchimp.git","ssh_url":"git@github.com:segmentio/integration-mailchimp.git","clone_url":"https://github.com/segmentio/integration-mailchimp.git","svn_url":"https://github.com/segmentio/integration-mailchimp","homepage":"segment.com","size":383,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"segmentio:master","ref":"master","sha":"55523afd7a16d494cd470f32d4fa3327130e5dae","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":26639850,"name":"integration-mailchimp","full_name":"segmentio/integration-mailchimp","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/integration-mailchimp","description":"MailChimp server-side integration","fork":false,"url":"https://api.github.com/repos/segmentio/integration-mailchimp","forks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/forks","keys_url":"https://api.github.com/repos/segmentio/integration-mailchimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/integration-mailchimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/integration-mailchimp/teams","hooks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/hooks","issue_events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/events","assignees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/integration-mailchimp/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/tags","blobs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/integration-mailchimp/languages","stargazers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/stargazers","contributors_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contributors","subscribers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscribers","subscription_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscription","commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/integration-mailchimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/integration-mailchimp/merges","archive_url":"https://api.github.com/repos/segmentio/integration-mailchimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/integration-mailchimp/downloads","issues_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/integration-mailchimp/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/integration-mailchimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/integration-mailchimp/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/integration-mailchimp/releases{/id}","created_at":"2014-11-14T13:31:38Z","updated_at":"2015-04-09T05:22:44Z","pushed_at":"2015-08-18T18:17:33Z","git_url":"git://github.com/segmentio/integration-mailchimp.git","ssh_url":"git@github.com:segmentio/integration-mailchimp.git","clone_url":"https://github.com/segmentio/integration-mailchimp.git","svn_url":"https://github.com/segmentio/integration-mailchimp","homepage":"segment.com","size":383,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20"},"html":{"href":"https://github.com/segmentio/integration-mailchimp/pull/20"},"issue":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/20"},"comments":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/4a2224993345437b72bfa4269832635a421d70d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dominicbarnes","id":160197,"avatar_url":"https://avatars.githubusercontent.com/u/160197?v=3","gravatar_id":"","url":"https://api.github.com/users/dominicbarnes","html_url":"https://github.com/dominicbarnes","followers_url":"https://api.github.com/users/dominicbarnes/followers","following_url":"https://api.github.com/users/dominicbarnes/following{/other_user}","gists_url":"https://api.github.com/users/dominicbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicbarnes/subscriptions","organizations_url":"https://api.github.com/users/dominicbarnes/orgs","repos_url":"https://api.github.com/users/dominicbarnes/repos","events_url":"https://api.github.com/users/dominicbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/dominicbarnes/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":111,"deletions":42,"changed_files":7}}