{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2920","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2920/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2920/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2920/events","html_url":"https://github.com/ManageIQ/manageiq/pull/2920","id":76398994,"number":2920,"title":"Dont allow reserving more memory than allocated","user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/provisioning","name":"provisioning","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-05-14T15:40:42Z","updated_at":"2015-05-20T21:22:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2920","html_url":"https://github.com/ManageIQ/manageiq/pull/2920","diff_url":"https://github.com/ManageIQ/manageiq/pull/2920.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2920.patch"},"body":"When provisioning a VM, users are allowed to set a memory reservation.  Reserving more memory than the total memory associated with the VM doesn't make sense.  Some providers return an error when you try to do this, we should not allow the request to be created in such a way.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1216889"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/104043205","html_url":"https://github.com/ManageIQ/manageiq/pull/2920#issuecomment-104043205","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2920","id":104043205,"user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T21:22:46Z","updated_at":"2015-05-20T21:22:46Z","body":"@gmcculloug I added tests for ```#validate_memory_reservation``` and ```#validate - validation_method```.\r\n\r\nAlso, shouldn't the tests added on miq_provision_vmware_workflow_spec.rb live in miq_request_workflow_spec.rb since the base class defines the method?"}}