{"action":"created","comment":{"url":"https://api.github.com/repos/FAForever/fa/pulls/comments/23137323","id":23137323,"diff_hunk":"@@ -1711,6 +1710,12 @@ end\n \n local function UpdateGame()\n     LOGX('>> UpdateGame', 'UpdateGame')\n+    -- This allows us to assume the existence of UI elements throughout.\n+    if not GUI.uiCreated then\n+        WARN(\"UpdateGame() pointlessly called before UI creation!\")","path":"lua/ui/lobby/lobby.lua","position":68,"original_position":68,"commit_id":"6d0121e1fda1f1bceaf25c8e555d8a72568f09e0","original_commit_id":"6d0121e1fda1f1bceaf25c8e555d8a72568f09e0","user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"body":"We could, or we could just call MAKE_SNAFUCATED().","created_at":"2015-01-18T21:45:39Z","updated_at":"2015-01-18T21:45:39Z","html_url":"https://github.com/FAForever/fa/pull/379#discussion_r23137323","pull_request_url":"https://api.github.com/repos/FAForever/fa/pulls/379","_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments/23137323"},"html":{"href":"https://github.com/FAForever/fa/pull/379#discussion_r23137323"},"pull_request":{"href":"https://api.github.com/repos/FAForever/fa/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/379","id":27558202,"html_url":"https://github.com/FAForever/fa/pull/379","diff_url":"https://github.com/FAForever/fa/pull/379.diff","patch_url":"https://github.com/FAForever/fa/pull/379.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/379","number":379,"state":"open","locked":false,"title":"Show resources in map previews","user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"body":"This commit introduces a new class to represent map previews, with the capability to show resource points as well.\nThis allows us to remove a lot of duplicated logic for handling the large map, as well as adding resource previewing to the map previews in the map select screen and main lobby essentially for free.\nTo make the performance of the rendering of the resource icons acceptable, a mechanism for object-pooling sets of identical bitmaps is introduced (Avoiding the expensive operation of creating and destroying many Bitmaps whenever the map view tries to update, which would otherwise introduce considerable \"jank\" to the map selection screen).\n\nThis also makes the in-lobby map preview square.","created_at":"2015-01-17T15:50:13Z","updated_at":"2015-01-18T21:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af9ddc9ad834a544600ac56b7ef605c990705f2","assignee":null,"milestone":{"url":"https://api.github.com/repos/FAForever/fa/milestones/5","labels_url":"https://api.github.com/repos/FAForever/fa/milestones/5/labels","id":922928,"number":5,"title":"Lobby 2.6.1","description":"A bugfix release for adressing issues with the ingame lobby.","creator":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":7,"state":"open","created_at":"2015-01-05T22:48:52Z","updated_at":"2015-01-18T12:58:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/379/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/379/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/379/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/6d0121e1fda1f1bceaf25c8e555d8a72568f09e0","head":{"label":"ChrisKitching:mapstash","ref":"mapstash","sha":"6d0121e1fda1f1bceaf25c8e555d8a72568f09e0","user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"repo":{"id":28066125,"name":"fa","full_name":"ChrisKitching/fa","owner":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisKitching/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/ChrisKitching/fa","forks_url":"https://api.github.com/repos/ChrisKitching/fa/forks","keys_url":"https://api.github.com/repos/ChrisKitching/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisKitching/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisKitching/fa/teams","hooks_url":"https://api.github.com/repos/ChrisKitching/fa/hooks","issue_events_url":"https://api.github.com/repos/ChrisKitching/fa/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisKitching/fa/events","assignees_url":"https://api.github.com/repos/ChrisKitching/fa/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisKitching/fa/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisKitching/fa/tags","blobs_url":"https://api.github.com/repos/ChrisKitching/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisKitching/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisKitching/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisKitching/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisKitching/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisKitching/fa/languages","stargazers_url":"https://api.github.com/repos/ChrisKitching/fa/stargazers","contributors_url":"https://api.github.com/repos/ChrisKitching/fa/contributors","subscribers_url":"https://api.github.com/repos/ChrisKitching/fa/subscribers","subscription_url":"https://api.github.com/repos/ChrisKitching/fa/subscription","commits_url":"https://api.github.com/repos/ChrisKitching/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisKitching/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisKitching/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisKitching/fa/issues/comments/{number}","contents_url":"https://api.github.com/repos/ChrisKitching/fa/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisKitching/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisKitching/fa/merges","archive_url":"https://api.github.com/repos/ChrisKitching/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisKitching/fa/downloads","issues_url":"https://api.github.com/repos/ChrisKitching/fa/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisKitching/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisKitching/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisKitching/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisKitching/fa/labels{/name}","releases_url":"https://api.github.com/repos/ChrisKitching/fa/releases{/id}","created_at":"2014-12-16T02:13:08Z","updated_at":"2015-01-03T10:55:49Z","pushed_at":"2015-01-18T20:47:57Z","git_url":"git://github.com/ChrisKitching/fa.git","ssh_url":"git@github.com:ChrisKitching/fa.git","clone_url":"https://github.com/ChrisKitching/fa.git","svn_url":"https://github.com/ChrisKitching/fa","homepage":"","size":101635,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:develop","ref":"develop","sha":"500821fa10bc2938f1fe3295d8e5fc5dbfabd98e","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments/{number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","created_at":"2014-09-24T06:34:12Z","updated_at":"2015-01-18T13:06:35Z","pushed_at":"2015-01-18T13:06:35Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":108442,"stargazers_count":13,"watchers_count":13,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":103,"forks":13,"open_issues":103,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/379"},"html":{"href":"https://github.com/FAForever/fa/pull/379"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/379"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/6d0121e1fda1f1bceaf25c8e555d8a72568f09e0"}}}}