{"action":"created","issue":{"url":"https://api.github.com/repos/nilmtk/nilmtk/issues/441","labels_url":"https://api.github.com/repos/nilmtk/nilmtk/issues/441/labels{/name}","comments_url":"https://api.github.com/repos/nilmtk/nilmtk/issues/441/comments","events_url":"https://api.github.com/repos/nilmtk/nilmtk/issues/441/events","html_url":"https://github.com/nilmtk/nilmtk/issues/441","id":110189486,"number":441,"title":"set_window doesn't effect plot, should it?","user":{"login":"gjwo","id":12109990,"avatar_url":"https://avatars.githubusercontent.com/u/12109990?v=3","gravatar_id":"","url":"https://api.github.com/users/gjwo","html_url":"https://github.com/gjwo","followers_url":"https://api.github.com/users/gjwo/followers","following_url":"https://api.github.com/users/gjwo/following{/other_user}","gists_url":"https://api.github.com/users/gjwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gjwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjwo/subscriptions","organizations_url":"https://api.github.com/users/gjwo/orgs","repos_url":"https://api.github.com/users/gjwo/repos","events_url":"https://api.github.com/users/gjwo/events{/privacy}","received_events_url":"https://api.github.com/users/gjwo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-07T09:55:12Z","updated_at":"2015-10-07T10:03:02Z","closed_at":null,"body":"I was using set_window to limit the range for disaggregation (I had trained on two months of data), before running disaggregation I though I would check that the correct window was set by plotting the graph but the range of the plot wasn't changed. Should it have been? Is set window the right function to set a disaggregation period of interest? I thought testing should generally be done out of sample to training (although this example is actually in sample).\r\n\r\n```python\r\nSet two days for Disaggregation period of interest\r\nInspect the data during a quiet period when we were on holiday, should only be autonomous appliances such as fridge, freeze and water heating + any standby devices not unplugged.\r\nIn [14]:\r\n\r\ngjw.set_window = TimeFrame(start='2015-07-13 00:00:00+01:00', end='2015-07-14 00:00:00+01:00')\r\nelec = gjw.buildings[building_number].elec\r\nmains = elec.mains()\r\nmains.plot()\r\n​\r\nOut[14]:\r\n<matplotlib.axes._subplots.AxesSubplot at 0x2d25d5c0>\r\n```\r\nGraph produced covered the two months rather than the two days specified above"},"comment":{"url":"https://api.github.com/repos/nilmtk/nilmtk/issues/comments/146138192","html_url":"https://github.com/nilmtk/nilmtk/issues/441#issuecomment-146138192","issue_url":"https://api.github.com/repos/nilmtk/nilmtk/issues/441","id":146138192,"user":{"login":"gjwo","id":12109990,"avatar_url":"https://avatars.githubusercontent.com/u/12109990?v=3","gravatar_id":"","url":"https://api.github.com/users/gjwo","html_url":"https://github.com/gjwo","followers_url":"https://api.github.com/users/gjwo/followers","following_url":"https://api.github.com/users/gjwo/following{/other_user}","gists_url":"https://api.github.com/users/gjwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gjwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjwo/subscriptions","organizations_url":"https://api.github.com/users/gjwo/orgs","repos_url":"https://api.github.com/users/gjwo/repos","events_url":"https://api.github.com/users/gjwo/events{/privacy}","received_events_url":"https://api.github.com/users/gjwo/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T10:03:02Z","updated_at":"2015-10-07T10:03:02Z","body":"It also looks like it's not limiting the disaggregate step, as it has been running for a while now!"}}