{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-commons/pulls/comments/26202343","id":26202343,"diff_hunk":"@@ -16,96 +16,139 @@\n \n package org.wso2.carbon.event.core;\n \n-import org.wso2.carbon.event.core.exception.EventBrokerConfigurationException;\n-import org.wso2.carbon.event.core.subscription.Subscription;\n-import org.wso2.carbon.event.core.subscription.EventDispatcher;\n import org.wso2.carbon.event.core.exception.EventBrokerException;\n+import org.wso2.carbon.event.core.subscription.EventDispatcher;\n+import org.wso2.carbon.event.core.subscription.Subscription;\n import org.wso2.carbon.event.core.topic.TopicManager;\n+import org.wso2.carbon.user.api.UserStoreException;\n \n import java.util.List;\n \n /**\n- * the main eventing interface for the other components. this interface supports two kinds of\n+ * The main eventing interface for the other components. this interface supports two kinds of\n  * subscriptions.\n- * 1. subscritions with EventDispatcher\n+ * 1. Subscriptions with event dispatcher.\n  *      Event broker does not persists these subscriptions and call the on message method upon\n  *      receiving an event.\n- * 2. subscriptions with EventDispatcherName\n+ * 2. Subscriptions with event dispatcher's name.\n  *      Event broker persists these subscriptions. It is responsibility of the user who calls this\n- *      method to register the eventDispatcher with the given name. In a server restart again\n- *      caller has to register the Event dispatcher.\n+ *      method to register the {@link org.wso2.carbon.event.core.subscription.EventDispatcher} with\n+ *      the given name. In a server restart again caller has to register the\n+ *      {@link org.wso2.carbon.event.core.subscription.EventDispatcher}.\n  */\n public interface EventBroker {\n \n     /**\n-     * subscribe using the gvien subscription details.\n-     * @param subscription\n-     * @return\n+     * Subscribe using the given subscription details.\n+     *\n+     * @param subscription the subscription\n+     * @return subscription ID\n      * @throws org.wso2.carbon.event.core.exception.EventBrokerException\n      */\n     public String subscribe(Subscription subscription) throws EventBrokerException;\n \n-    public void unsubscribe(String id) throws EventBrokerException;\n+    /**\n+     * UnSubscribe a subscription\n+     *\n+     * @param id subscription ID\n+     * @throws EventBrokerException\n+     */\n+    public void unSubscribe(String id) throws EventBrokerException;\n \n+    /**\n+     * Get subscription from subscription ID\n+     *\n+     * @param id subscription ID\n+     * @return the subscription\n+     * @throws EventBrokerException\n+     */\n     public Subscription getSubscription(String id) throws EventBrokerException;\n \n+    /**\n+     * Renews a subscription. Updates expiry time, removal and resetting of the properties\n+     *\n+     * @param subscription the subscription to renew\n+     * @throws EventBrokerException\n+     */\n     public void renewSubscription(Subscription subscription) throws EventBrokerException;\n \n+    /**\n+     * Get all subscriptions\n+     *\n+     * @param filter filter value. use * for all\n+     * @return a list of subscriptions\n+     * @throws EventBrokerException\n+     */\n     public List<Subscription> getAllSubscriptions(String filter) throws EventBrokerException;\n \n     /**\n-     * publish an event to the given topic asynchornously. i.e it starts a new thread to send\n-     * the message.\n-     * @param message - message to publish. this contains the OMElement of the message and\n-     * any properties.\n-     * @param topicName\n+     * Publish an event to the given topic asynchronously. i.e it starts a new thread to send the\n+     * message.\n+     *\n+     * @param message   - message to publish. this contains the OMElement of the message and any","path":"components/event/org.wso2.carbon.event.core/src/main/java/org/wso2/carbon/event/core/EventBroker.java","position":90,"original_position":90,"commit_id":"98097aa505b485fbc8767989a4af70d1b33a1ef6","original_commit_id":"98097aa505b485fbc8767989a4af70d1b33a1ef6","user":{"login":"hemikak","id":4398820,"avatar_url":"https://avatars.githubusercontent.com/u/4398820?v=3","gravatar_id":"","url":"https://api.github.com/users/hemikak","html_url":"https://github.com/hemikak","followers_url":"https://api.github.com/users/hemikak/followers","following_url":"https://api.github.com/users/hemikak/following{/other_user}","gists_url":"https://api.github.com/users/hemikak/gists{/gist_id}","starred_url":"https://api.github.com/users/hemikak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemikak/subscriptions","organizations_url":"https://api.github.com/users/hemikak/orgs","repos_url":"https://api.github.com/users/hemikak/repos","events_url":"https://api.github.com/users/hemikak/events{/privacy}","received_events_url":"https://api.github.com/users/hemikak/received_events","type":"User","site_admin":false},"body":"Fixed in https://github.com/wso2/carbon-commons/pull/66.","created_at":"2015-03-11T10:45:28Z","updated_at":"2015-03-11T10:45:28Z","html_url":"https://github.com/wso2/carbon-commons/pull/56#discussion_r26202343","pull_request_url":"https://api.github.com/repos/wso2/carbon-commons/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/comments/26202343"},"html":{"href":"https://github.com/wso2/carbon-commons/pull/56#discussion_r26202343"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-commons/pulls/56","id":29687707,"html_url":"https://github.com/wso2/carbon-commons/pull/56","diff_url":"https://github.com/wso2/carbon-commons/pull/56.diff","patch_url":"https://github.com/wso2/carbon-commons/pull/56.patch","issue_url":"https://api.github.com/repos/wso2/carbon-commons/issues/56","number":56,"state":"closed","locked":false,"title":"[MB-624] Event component patching user authorization from support branch. Added UI fixes. Java docs added.","user":{"login":"hemikak","id":4398820,"avatar_url":"https://avatars.githubusercontent.com/u/4398820?v=3","gravatar_id":"","url":"https://api.github.com/users/hemikak","html_url":"https://github.com/hemikak","followers_url":"https://api.github.com/users/hemikak/followers","following_url":"https://api.github.com/users/hemikak/following{/other_user}","gists_url":"https://api.github.com/users/hemikak/gists{/gist_id}","starred_url":"https://api.github.com/users/hemikak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemikak/subscriptions","organizations_url":"https://api.github.com/users/hemikak/orgs","repos_url":"https://api.github.com/users/hemikak/repos","events_url":"https://api.github.com/users/hemikak/events{/privacy}","received_events_url":"https://api.github.com/users/hemikak/received_events","type":"User","site_admin":false},"body":"1. Topic related permissions are added.\r\n2. Patches from https://wso2.org/jira/browse/MB-624?filter=-1 added.\r\n3. Java docs added for classes.\r\n4. UI fixes.","created_at":"2015-02-20T11:06:56Z","updated_at":"2015-03-11T10:45:28Z","closed_at":"2015-03-02T13:09:39Z","merged_at":"2015-03-02T13:09:39Z","merge_commit_sha":"1456cce0d3ea66f76db0fb143e622e4dd28ca80c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-commons/pulls/56/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-commons/pulls/56/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-commons/issues/56/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-commons/statuses/98097aa505b485fbc8767989a4af70d1b33a1ef6","head":{"label":"hemikak:user-auth","ref":"user-auth","sha":"98097aa505b485fbc8767989a4af70d1b33a1ef6","user":{"login":"hemikak","id":4398820,"avatar_url":"https://avatars.githubusercontent.com/u/4398820?v=3","gravatar_id":"","url":"https://api.github.com/users/hemikak","html_url":"https://github.com/hemikak","followers_url":"https://api.github.com/users/hemikak/followers","following_url":"https://api.github.com/users/hemikak/following{/other_user}","gists_url":"https://api.github.com/users/hemikak/gists{/gist_id}","starred_url":"https://api.github.com/users/hemikak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemikak/subscriptions","organizations_url":"https://api.github.com/users/hemikak/orgs","repos_url":"https://api.github.com/users/hemikak/repos","events_url":"https://api.github.com/users/hemikak/events{/privacy}","received_events_url":"https://api.github.com/users/hemikak/received_events","type":"User","site_admin":false},"repo":{"id":30518789,"name":"carbon-commons","full_name":"hemikak/carbon-commons","owner":{"login":"hemikak","id":4398820,"avatar_url":"https://avatars.githubusercontent.com/u/4398820?v=3","gravatar_id":"","url":"https://api.github.com/users/hemikak","html_url":"https://github.com/hemikak","followers_url":"https://api.github.com/users/hemikak/followers","following_url":"https://api.github.com/users/hemikak/following{/other_user}","gists_url":"https://api.github.com/users/hemikak/gists{/gist_id}","starred_url":"https://api.github.com/users/hemikak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemikak/subscriptions","organizations_url":"https://api.github.com/users/hemikak/orgs","repos_url":"https://api.github.com/users/hemikak/repos","events_url":"https://api.github.com/users/hemikak/events{/privacy}","received_events_url":"https://api.github.com/users/hemikak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hemikak/carbon-commons","description":"","fork":true,"url":"https://api.github.com/repos/hemikak/carbon-commons","forks_url":"https://api.github.com/repos/hemikak/carbon-commons/forks","keys_url":"https://api.github.com/repos/hemikak/carbon-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hemikak/carbon-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hemikak/carbon-commons/teams","hooks_url":"https://api.github.com/repos/hemikak/carbon-commons/hooks","issue_events_url":"https://api.github.com/repos/hemikak/carbon-commons/issues/events{/number}","events_url":"https://api.github.com/repos/hemikak/carbon-commons/events","assignees_url":"https://api.github.com/repos/hemikak/carbon-commons/assignees{/user}","branches_url":"https://api.github.com/repos/hemikak/carbon-commons/branches{/branch}","tags_url":"https://api.github.com/repos/hemikak/carbon-commons/tags","blobs_url":"https://api.github.com/repos/hemikak/carbon-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hemikak/carbon-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hemikak/carbon-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/hemikak/carbon-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hemikak/carbon-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/hemikak/carbon-commons/languages","stargazers_url":"https://api.github.com/repos/hemikak/carbon-commons/stargazers","contributors_url":"https://api.github.com/repos/hemikak/carbon-commons/contributors","subscribers_url":"https://api.github.com/repos/hemikak/carbon-commons/subscribers","subscription_url":"https://api.github.com/repos/hemikak/carbon-commons/subscription","commits_url":"https://api.github.com/repos/hemikak/carbon-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/hemikak/carbon-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/hemikak/carbon-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/hemikak/carbon-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/hemikak/carbon-commons/contents/{+path}","compare_url":"https://api.github.com/repos/hemikak/carbon-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hemikak/carbon-commons/merges","archive_url":"https://api.github.com/repos/hemikak/carbon-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hemikak/carbon-commons/downloads","issues_url":"https://api.github.com/repos/hemikak/carbon-commons/issues{/number}","pulls_url":"https://api.github.com/repos/hemikak/carbon-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/hemikak/carbon-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/hemikak/carbon-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hemikak/carbon-commons/labels{/name}","releases_url":"https://api.github.com/repos/hemikak/carbon-commons/releases{/id}","created_at":"2015-02-09T04:36:23Z","updated_at":"2015-02-09T04:36:29Z","pushed_at":"2015-03-11T10:38:48Z","git_url":"git://github.com/hemikak/carbon-commons.git","ssh_url":"git@github.com:hemikak/carbon-commons.git","clone_url":"https://github.com/hemikak/carbon-commons.git","svn_url":"https://github.com/hemikak/carbon-commons","homepage":null,"size":11618,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"470820c1127a4de82af9e85e13bae60043999a03","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16501680,"name":"carbon-commons","full_name":"wso2/carbon-commons","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-commons","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-commons","forks_url":"https://api.github.com/repos/wso2/carbon-commons/forks","keys_url":"https://api.github.com/repos/wso2/carbon-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-commons/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-commons/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-commons/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-commons/events","assignees_url":"https://api.github.com/repos/wso2/carbon-commons/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-commons/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-commons/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-commons/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-commons/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-commons/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-commons/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-commons/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-commons/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-commons/merges","archive_url":"https://api.github.com/repos/wso2/carbon-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-commons/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-commons/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-commons/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-commons/releases{/id}","created_at":"2014-02-04T03:53:48Z","updated_at":"2015-03-09T07:44:47Z","pushed_at":"2015-03-09T07:44:40Z","git_url":"git://github.com/wso2/carbon-commons.git","ssh_url":"git@github.com:wso2/carbon-commons.git","clone_url":"https://github.com/wso2/carbon-commons.git","svn_url":"https://github.com/wso2/carbon-commons","homepage":null,"size":14128,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":3,"forks":59,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/56"},"html":{"href":"https://github.com/wso2/carbon-commons/pull/56"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-commons/issues/56"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-commons/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-commons/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-commons/statuses/98097aa505b485fbc8767989a4af70d1b33a1ef6"}}}}