{"action":"closed","issue":{"url":"https://api.github.com/repos/gorhill/PHP-FineDiff/issues/15","labels_url":"https://api.github.com/repos/gorhill/PHP-FineDiff/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/gorhill/PHP-FineDiff/issues/15/comments","events_url":"https://api.github.com/repos/gorhill/PHP-FineDiff/issues/15/events","html_url":"https://github.com/gorhill/PHP-FineDiff/issues/15","id":30544096,"number":15,"title":"renderFromOpcodes should return Text","user":{"login":"asnyder","id":199062,"avatar_url":"https://avatars.githubusercontent.com/u/199062?v=3","gravatar_id":"","url":"https://api.github.com/users/asnyder","html_url":"https://github.com/asnyder","followers_url":"https://api.github.com/users/asnyder/followers","following_url":"https://api.github.com/users/asnyder/following{/other_user}","gists_url":"https://api.github.com/users/asnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/asnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asnyder/subscriptions","organizations_url":"https://api.github.com/users/asnyder/orgs","repos_url":"https://api.github.com/users/asnyder/repos","events_url":"https://api.github.com/users/asnyder/events{/privacy}","received_events_url":"https://api.github.com/users/asnyder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-03-31T20:01:00Z","updated_at":"2015-04-02T10:12:11Z","closed_at":"2015-04-02T10:12:11Z","body":"For whatever reason renderFromOpcodes takes in a callback which we're supposed to handle, however you don't process any return from the callback making it such that the function will always return NULL. As such one needs to create a global shared variable, set it to blank beforehand, call renderFromOpCodes with callback, modify global string in callback and then use global string afterwards. Wouldn't it be more in line with modern development practices and the rest of the library to have the renderFromOpcodes allow the callback to return a string which renderFromOpcodes concats and returns?"}}