{"action":"created","issue":{"url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/260","labels_url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/260/comments","events_url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/260/events","html_url":"https://github.com/jeremylong/DependencyCheck/pull/260","id":89908642,"number":260,"title":"[WIP] Reporting plugin version numbers","user":{"login":"hansjoachim","id":3002493,"avatar_url":"https://avatars.githubusercontent.com/u/3002493?v=3","gravatar_id":"","url":"https://api.github.com/users/hansjoachim","html_url":"https://github.com/hansjoachim","followers_url":"https://api.github.com/users/hansjoachim/followers","following_url":"https://api.github.com/users/hansjoachim/following{/other_user}","gists_url":"https://api.github.com/users/hansjoachim/gists{/gist_id}","starred_url":"https://api.github.com/users/hansjoachim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansjoachim/subscriptions","organizations_url":"https://api.github.com/users/hansjoachim/orgs","repos_url":"https://api.github.com/users/hansjoachim/repos","events_url":"https://api.github.com/users/hansjoachim/events{/privacy}","received_events_url":"https://api.github.com/users/hansjoachim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-21T12:58:10Z","updated_at":"2015-06-21T17:13:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeremylong/DependencyCheck/pulls/260","html_url":"https://github.com/jeremylong/DependencyCheck/pull/260","diff_url":"https://github.com/jeremylong/DependencyCheck/pull/260.diff","patch_url":"https://github.com/jeremylong/DependencyCheck/pull/260.patch"},"body":"As mentioned earlier (in #252) I've fought a bit with the reporting plugins and tried to place their version numbers under pluginManagement like the others. Unfortunately, this doesn't seem to work in practice. The alternative solution I've landed on is to place the version numbers in global properties in the root pom and then make sure these are assigned each place the plugins are used. Perhaps not ideal, but makes things consistent at least.\r\n\r\nNote that this is work in progress, i.e. not intended for merging yet. Feel free to review and comment though. I'll remove the WIP tag when I consider it fit for inclusion, probably once I've dealt with all the modules.\r\n\r\nSeveral of the plugins have newer versions available, but I wish to land this first so that all modules are synced using the same version before attempting to upgrade any. I have noticed that some plugins (notably maven-project-info-reports-plugin, and I believe findbugs) have different versions in different modules. I've assumed they've simply become out of sync for some reason, but please let me know if this was somehow intentional.\r\n\r\nI've also marked at least one place with TODO(code review) which should probably be addressed before this is closed."},"comment":{"url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/comments/113932443","html_url":"https://github.com/jeremylong/DependencyCheck/pull/260#issuecomment-113932443","issue_url":"https://api.github.com/repos/jeremylong/DependencyCheck/issues/260","id":113932443,"user":{"login":"hansjoachim","id":3002493,"avatar_url":"https://avatars.githubusercontent.com/u/3002493?v=3","gravatar_id":"","url":"https://api.github.com/users/hansjoachim","html_url":"https://github.com/hansjoachim","followers_url":"https://api.github.com/users/hansjoachim/followers","following_url":"https://api.github.com/users/hansjoachim/following{/other_user}","gists_url":"https://api.github.com/users/hansjoachim/gists{/gist_id}","starred_url":"https://api.github.com/users/hansjoachim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansjoachim/subscriptions","organizations_url":"https://api.github.com/users/hansjoachim/orgs","repos_url":"https://api.github.com/users/hansjoachim/repos","events_url":"https://api.github.com/users/hansjoachim/events{/privacy}","received_events_url":"https://api.github.com/users/hansjoachim/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T17:13:33Z","updated_at":"2015-06-21T17:13:33Z","body":"It should be noted that I have some slight problems verifying that `mvn site` still works as expected. I get some weird stacktraces when generating the findbugs report. I believe this is due to [a bug in the findbugs-plugin](https://github.com/gleclaire/findbugs-maven-plugin/issues/9), and I also get it with latest master so it doesn't seem like something I've introduced. I'll experiment with openjdk7 and see whether that works better."}}