{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/twentysixteen/issues/382","labels_url":"https://api.github.com/repos/WordPress/twentysixteen/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/twentysixteen/issues/382/comments","events_url":"https://api.github.com/repos/WordPress/twentysixteen/issues/382/events","html_url":"https://github.com/WordPress/twentysixteen/pull/382","id":117796457,"number":382,"title":"Remove singular.php and Add single.php and page.php","user":{"login":"iamtakashi","id":908665,"avatar_url":"https://avatars.githubusercontent.com/u/908665?v=3","gravatar_id":"","url":"https://api.github.com/users/iamtakashi","html_url":"https://github.com/iamtakashi","followers_url":"https://api.github.com/users/iamtakashi/followers","following_url":"https://api.github.com/users/iamtakashi/following{/other_user}","gists_url":"https://api.github.com/users/iamtakashi/gists{/gist_id}","starred_url":"https://api.github.com/users/iamtakashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamtakashi/subscriptions","organizations_url":"https://api.github.com/users/iamtakashi/orgs","repos_url":"https://api.github.com/users/iamtakashi/repos","events_url":"https://api.github.com/users/iamtakashi/events{/privacy}","received_events_url":"https://api.github.com/users/iamtakashi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-19T11:44:08Z","updated_at":"2015-11-24T07:55:46Z","closed_at":"2015-11-19T19:54:42Z","pull_request":{"url":"https://api.github.com/repos/WordPress/twentysixteen/pulls/382","html_url":"https://github.com/WordPress/twentysixteen/pull/382","diff_url":"https://github.com/WordPress/twentysixteen/pull/382.diff","patch_url":"https://github.com/WordPress/twentysixteen/pull/382.patch"},"body":"We've added `singular.php` in #206 but I have a second thought and I think this is not the right thing to do with Twenty Sixteen.\r\n\r\nI saw <a href=\"https://github.com/Automattic/_s/pull/827\">this thread in Underscores</a> and <a href=\"https://github.com/Automattic/_s/pull/827#issuecomment-142302778\">what @obenland said</a> there struck to me. \r\n\r\nEspecially this:\r\n\r\n<blockquote>As a matter of fact, I think the only time it does make sense is when content, regardless of type, will always be displayed in the same way.</blockquote>\r\n\r\nIn Twenty Sixteen, pages and posts are displayed differently but posts and non-image attachments are the same. Hence this absolutely makes sense.\r\n\r\nWith this change, there will be one more template file and less \"DRY\" but having a`singular.php` with three content type checks doesn't seem to be the right thing to do for this theme."},"comment":{"url":"https://api.github.com/repos/WordPress/twentysixteen/issues/comments/159188313","html_url":"https://github.com/WordPress/twentysixteen/pull/382#issuecomment-159188313","issue_url":"https://api.github.com/repos/WordPress/twentysixteen/issues/382","id":159188313,"user":{"login":"iamtakashi","id":908665,"avatar_url":"https://avatars.githubusercontent.com/u/908665?v=3","gravatar_id":"","url":"https://api.github.com/users/iamtakashi","html_url":"https://github.com/iamtakashi","followers_url":"https://api.github.com/users/iamtakashi/followers","following_url":"https://api.github.com/users/iamtakashi/following{/other_user}","gists_url":"https://api.github.com/users/iamtakashi/gists{/gist_id}","starred_url":"https://api.github.com/users/iamtakashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamtakashi/subscriptions","organizations_url":"https://api.github.com/users/iamtakashi/orgs","repos_url":"https://api.github.com/users/iamtakashi/repos","events_url":"https://api.github.com/users/iamtakashi/events{/privacy}","received_events_url":"https://api.github.com/users/iamtakashi/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T07:55:46Z","updated_at":"2015-11-24T07:55:46Z","body":"> In some ways this sounds more like a decision of preference rather than performance or best practice. \r\n\r\nNo, this change was based on how I see as best practice. Using `singular.php` in this theme contradicted the concept of a template hierarchy because pages and posts are displayed differently with different elements. And performance difference with this change is nearly zero.\r\n\r\n> But I don't see the actual \"cons\" of using conditionals in a template file.\r\n\r\nIf I borrow what @obenland said, do you put everything in `index.php` with numerous conditions? You don't."}}