{"action":"created","comment":{"url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/comments/25786146","id":25786146,"diff_hunk":"@@ -105,24 +104,56 @@\n       describe 'rpc' do\n         describe '#echo' do\n           let(:request) { Elementary::Rspec::String.new(:data => 'rspec') }\n-          subject(:response) { connection.rpc.echo(request) }\n-\n-          before :each do\n-            Elementary.use Elementary::Middleware::Dummy, :rspec => true\n-            expect_any_instance_of(Elementary::Middleware::Dummy).to \\\n-                    receive(:call).and_call_original\n+          context 'with http connection failure due haproxy resolving service to wrong host or port' do\n+            let(:opts) { { 'hosts' => [{'host' => 'localhost', 'port' => '8080'}] } }\n+            subject(:response) { connection.rpc.echo(request) }\n+\n+            before :each do\n+              response.value","path":"spec/connection_spec.rb","position":23,"original_position":23,"commit_id":"9f4b0af16e331cde6e9149c726f6d28fdf5c37e6","original_commit_id":"faaa2498613d771a8ac5dd3064d42e71382edf56","user":{"login":"rtyler","id":26594,"avatar_url":"https://avatars.githubusercontent.com/u/26594?v=3","gravatar_id":"","url":"https://api.github.com/users/rtyler","html_url":"https://github.com/rtyler","followers_url":"https://api.github.com/users/rtyler/followers","following_url":"https://api.github.com/users/rtyler/following{/other_user}","gists_url":"https://api.github.com/users/rtyler/gists{/gist_id}","starred_url":"https://api.github.com/users/rtyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtyler/subscriptions","organizations_url":"https://api.github.com/users/rtyler/orgs","repos_url":"https://api.github.com/users/rtyler/repos","events_url":"https://api.github.com/users/rtyler/events{/privacy}","received_events_url":"https://api.github.com/users/rtyler/received_events","type":"User","site_admin":false},"body":"Gak, you're right I was misreading this. Forget I said anything about the subject, I still think the example block needs to be broken out into the granular tests though, e.g.:\r\n\r\n```ruby\r\nit { should be_rejected }\r\nit { should be_instance_of Elementary::Future }\r\nits(:reason) { should_not be_nil }\r\n```\r\n\r\n","created_at":"2015-03-04T16:05:13Z","updated_at":"2015-03-04T16:05:13Z","html_url":"https://github.com/lookout/elementary-rpc/pull/23#discussion_r25786146","pull_request_url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/comments/25786146"},"html":{"href":"https://github.com/lookout/elementary-rpc/pull/23#discussion_r25786146"},"pull_request":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23","id":30333566,"html_url":"https://github.com/lookout/elementary-rpc/pull/23","diff_url":"https://github.com/lookout/elementary-rpc/pull/23.diff","patch_url":"https://github.com/lookout/elementary-rpc/pull/23.patch","issue_url":"https://api.github.com/repos/lookout/elementary-rpc/issues/23","number":23,"state":"open","locked":false,"title":"Rescue NotImplementedError thrown by protobuffy due to haproxy misconfig...","user":{"login":"pmatpadi","id":11234015,"avatar_url":"https://avatars.githubusercontent.com/u/11234015?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatpadi","html_url":"https://github.com/pmatpadi","followers_url":"https://api.github.com/users/pmatpadi/followers","following_url":"https://api.github.com/users/pmatpadi/following{/other_user}","gists_url":"https://api.github.com/users/pmatpadi/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatpadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatpadi/subscriptions","organizations_url":"https://api.github.com/users/pmatpadi/orgs","repos_url":"https://api.github.com/users/pmatpadi/repos","events_url":"https://api.github.com/users/pmatpadi/events{/privacy}","received_events_url":"https://api.github.com/users/pmatpadi/received_events","type":"User","site_admin":false},"body":"...uration\r\n\r\nJIRA: LB-5187","created_at":"2015-03-02T23:53:01Z","updated_at":"2015-03-04T16:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c5b5316437b954afa431fffed656b1c1f0d7915","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23/commits","review_comments_url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23/comments","review_comment_url":"https://api.github.com/repos/lookout/elementary-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lookout/elementary-rpc/issues/23/comments","statuses_url":"https://api.github.com/repos/lookout/elementary-rpc/statuses/9f4b0af16e331cde6e9149c726f6d28fdf5c37e6","head":{"label":"pmatpadi:handle-broken-connections","ref":"handle-broken-connections","sha":"9f4b0af16e331cde6e9149c726f6d28fdf5c37e6","user":{"login":"pmatpadi","id":11234015,"avatar_url":"https://avatars.githubusercontent.com/u/11234015?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatpadi","html_url":"https://github.com/pmatpadi","followers_url":"https://api.github.com/users/pmatpadi/followers","following_url":"https://api.github.com/users/pmatpadi/following{/other_user}","gists_url":"https://api.github.com/users/pmatpadi/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatpadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatpadi/subscriptions","organizations_url":"https://api.github.com/users/pmatpadi/orgs","repos_url":"https://api.github.com/users/pmatpadi/repos","events_url":"https://api.github.com/users/pmatpadi/events{/privacy}","received_events_url":"https://api.github.com/users/pmatpadi/received_events","type":"User","site_admin":false},"repo":{"id":31432810,"name":"elementary-rpc","full_name":"pmatpadi/elementary-rpc","owner":{"login":"pmatpadi","id":11234015,"avatar_url":"https://avatars.githubusercontent.com/u/11234015?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatpadi","html_url":"https://github.com/pmatpadi","followers_url":"https://api.github.com/users/pmatpadi/followers","following_url":"https://api.github.com/users/pmatpadi/following{/other_user}","gists_url":"https://api.github.com/users/pmatpadi/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatpadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatpadi/subscriptions","organizations_url":"https://api.github.com/users/pmatpadi/orgs","repos_url":"https://api.github.com/users/pmatpadi/repos","events_url":"https://api.github.com/users/pmatpadi/events{/privacy}","received_events_url":"https://api.github.com/users/pmatpadi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmatpadi/elementary-rpc","description":"Elementary RPC is a simple, async client library for interacting with Protobuf RPC servers","fork":true,"url":"https://api.github.com/repos/pmatpadi/elementary-rpc","forks_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/forks","keys_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/teams","hooks_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/hooks","issue_events_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/events","assignees_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/tags","blobs_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/languages","stargazers_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/stargazers","contributors_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/contributors","subscribers_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/subscribers","subscription_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/subscription","commits_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/merges","archive_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/downloads","issues_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/labels{/name}","releases_url":"https://api.github.com/repos/pmatpadi/elementary-rpc/releases{/id}","created_at":"2015-02-27T18:20:44Z","updated_at":"2015-03-02T23:32:01Z","pushed_at":"2015-03-03T22:14:07Z","git_url":"git://github.com/pmatpadi/elementary-rpc.git","ssh_url":"git@github.com:pmatpadi/elementary-rpc.git","clone_url":"https://github.com/pmatpadi/elementary-rpc.git","svn_url":"https://github.com/pmatpadi/elementary-rpc","homepage":null,"size":421,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lookout:master","ref":"master","sha":"0ae0d23ab4cc07a77f37ae35f18ccd22eba01d47","user":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"repo":{"id":20469665,"name":"elementary-rpc","full_name":"lookout/elementary-rpc","owner":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lookout/elementary-rpc","description":"Elementary RPC is a simple, async client library for interacting with Protobuf RPC servers","fork":false,"url":"https://api.github.com/repos/lookout/elementary-rpc","forks_url":"https://api.github.com/repos/lookout/elementary-rpc/forks","keys_url":"https://api.github.com/repos/lookout/elementary-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookout/elementary-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookout/elementary-rpc/teams","hooks_url":"https://api.github.com/repos/lookout/elementary-rpc/hooks","issue_events_url":"https://api.github.com/repos/lookout/elementary-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/lookout/elementary-rpc/events","assignees_url":"https://api.github.com/repos/lookout/elementary-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/lookout/elementary-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/lookout/elementary-rpc/tags","blobs_url":"https://api.github.com/repos/lookout/elementary-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookout/elementary-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookout/elementary-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookout/elementary-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookout/elementary-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/lookout/elementary-rpc/languages","stargazers_url":"https://api.github.com/repos/lookout/elementary-rpc/stargazers","contributors_url":"https://api.github.com/repos/lookout/elementary-rpc/contributors","subscribers_url":"https://api.github.com/repos/lookout/elementary-rpc/subscribers","subscription_url":"https://api.github.com/repos/lookout/elementary-rpc/subscription","commits_url":"https://api.github.com/repos/lookout/elementary-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookout/elementary-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookout/elementary-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookout/elementary-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lookout/elementary-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/lookout/elementary-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookout/elementary-rpc/merges","archive_url":"https://api.github.com/repos/lookout/elementary-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookout/elementary-rpc/downloads","issues_url":"https://api.github.com/repos/lookout/elementary-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/lookout/elementary-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/lookout/elementary-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/lookout/elementary-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookout/elementary-rpc/labels{/name}","releases_url":"https://api.github.com/repos/lookout/elementary-rpc/releases{/id}","created_at":"2014-06-04T04:04:04Z","updated_at":"2015-02-27T18:29:11Z","pushed_at":"2015-02-27T18:29:11Z","git_url":"git://github.com/lookout/elementary-rpc.git","ssh_url":"git@github.com:lookout/elementary-rpc.git","clone_url":"https://github.com/lookout/elementary-rpc.git","svn_url":"https://github.com/lookout/elementary-rpc","homepage":null,"size":272,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23"},"html":{"href":"https://github.com/lookout/elementary-rpc/pull/23"},"issue":{"href":"https://api.github.com/repos/lookout/elementary-rpc/issues/23"},"comments":{"href":"https://api.github.com/repos/lookout/elementary-rpc/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lookout/elementary-rpc/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/lookout/elementary-rpc/statuses/9f4b0af16e331cde6e9149c726f6d28fdf5c37e6"}}}}