{"action":"created","issue":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/277","labels_url":"https://api.github.com/repos/sakaiproject/sakai/issues/277/labels{/name}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/277/comments","events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/277/events","html_url":"https://github.com/sakaiproject/sakai/pull/277","id":60716343,"number":277,"title":"KNL-1333 - Adding support for hikaricp","user":{"login":"jonespm","id":27447,"avatar_url":"https://avatars.githubusercontent.com/u/27447?v=3","gravatar_id":"","url":"https://api.github.com/users/jonespm","html_url":"https://github.com/jonespm","followers_url":"https://api.github.com/users/jonespm/followers","following_url":"https://api.github.com/users/jonespm/following{/other_user}","gists_url":"https://api.github.com/users/jonespm/gists{/gist_id}","starred_url":"https://api.github.com/users/jonespm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonespm/subscriptions","organizations_url":"https://api.github.com/users/jonespm/orgs","repos_url":"https://api.github.com/users/jonespm/repos","events_url":"https://api.github.com/users/jonespm/events{/privacy}","received_events_url":"https://api.github.com/users/jonespm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sakaiproject/sakai/labels/needs%20review","name":"needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"jonespm","id":27447,"avatar_url":"https://avatars.githubusercontent.com/u/27447?v=3","gravatar_id":"","url":"https://api.github.com/users/jonespm","html_url":"https://github.com/jonespm","followers_url":"https://api.github.com/users/jonespm/followers","following_url":"https://api.github.com/users/jonespm/following{/other_user}","gists_url":"https://api.github.com/users/jonespm/gists{/gist_id}","starred_url":"https://api.github.com/users/jonespm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonespm/subscriptions","organizations_url":"https://api.github.com/users/jonespm/orgs","repos_url":"https://api.github.com/users/jonespm/repos","events_url":"https://api.github.com/users/jonespm/events{/privacy}","received_events_url":"https://api.github.com/users/jonespm/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-03-11T19:34:20Z","updated_at":"2015-03-19T14:51:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/277","html_url":"https://github.com/sakaiproject/sakai/pull/277","diff_url":"https://github.com/sakaiproject/sakai/pull/277.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/277.patch"},"body":"This PR adds support for HikariCP. This could for sure use some testing, but it starts up without any warnings. There is some cleanup still but it's seems to be a great first (or in my case about sixth) pass\r\n\r\nSome notes\r\n\r\n* I had to turn off autocommit as that default to on and there's warnings if that is on. I think I'll just move that property into the XML since it's identical to Hikari so a slight re-factor.\r\n* I believe that just setting registerMBeans has Hikari register them, previously on the tomcat driver we had to explicitly do that. I have not tested the mbeans\r\n* It has compatibility with all of the old properties (url@ driverClassName@ etc), but I think to set the hikariCP properties we'll need to add them with defaults to the bean here.\r\n* I only tested this with MySQL, same driver as the tomcat and dbcp ones\r\n\r\nJava 7/8 note\r\nThey have two versions of the jar, one for Java 7 (which is currently the default in this patch) and one for Java 8. I'd anticipate making Java 8 the minimum requirement for Sakai 11, but for now this would (probably) not be compatible with java 8 without changing that dependency."},"comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments/83614323","html_url":"https://github.com/sakaiproject/sakai/pull/277#issuecomment-83614323","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/277","id":83614323,"user":{"login":"jonespm","id":27447,"avatar_url":"https://avatars.githubusercontent.com/u/27447?v=3","gravatar_id":"","url":"https://api.github.com/users/jonespm","html_url":"https://github.com/jonespm","followers_url":"https://api.github.com/users/jonespm/followers","following_url":"https://api.github.com/users/jonespm/following{/other_user}","gists_url":"https://api.github.com/users/jonespm/gists{/gist_id}","starred_url":"https://api.github.com/users/jonespm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonespm/subscriptions","organizations_url":"https://api.github.com/users/jonespm/orgs","repos_url":"https://api.github.com/users/jonespm/repos","events_url":"https://api.github.com/users/jonespm/events{/privacy}","received_events_url":"https://api.github.com/users/jonespm/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T14:50:59Z","updated_at":"2015-03-19T14:50:59Z","body":"I'll fix up the indentation, has anyone else tested this? Earle was saying he couldn't get it started. Sam was about to start it up."}}