{"action":"opened","number":1229,"pull_request":{"url":"https://api.github.com/repos/slick/slick/pulls/1229","id":42112636,"html_url":"https://github.com/slick/slick/pull/1229","diff_url":"https://github.com/slick/slick/pull/1229.diff","patch_url":"https://github.com/slick/slick/pull/1229.patch","issue_url":"https://api.github.com/repos/slick/slick/issues/1229","number":1229,"state":"open","locked":false,"title":"Database.forConfig uses provided config params `numThreads` and `queueSize`","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"The existing implementation of Database.forConfig was ignoring the `path`\r\npassed to it when looking up the value of `numThreads` and `queueSize` in\r\nthe config.\r\n\r\nI would have loved to provide a test together with the fix, but I would have\r\nto resort to reflection to retrieve the values used to set up the thread pool,\r\nand that seems fragile. Therefore, there is no test with this fix.","created_at":"2015-08-11T10:09:59Z","updated_at":"2015-08-11T10:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slick/slick/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/slick/slick/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/slick/slick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slick/slick/issues/1229/comments","statuses_url":"https://api.github.com/repos/slick/slick/statuses/75146666627f26b796a36df75f2e03fb421b8a85","head":{"label":"dotta:issue/fix-database-for-config","ref":"issue/fix-database-for-config","sha":"75146666627f26b796a36df75f2e03fb421b8a85","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"repo":{"id":40492928,"name":"slick","full_name":"dotta/slick","owner":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotta/slick","description":"Scala Language Integrated Connection Kit","fork":true,"url":"https://api.github.com/repos/dotta/slick","forks_url":"https://api.github.com/repos/dotta/slick/forks","keys_url":"https://api.github.com/repos/dotta/slick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotta/slick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotta/slick/teams","hooks_url":"https://api.github.com/repos/dotta/slick/hooks","issue_events_url":"https://api.github.com/repos/dotta/slick/issues/events{/number}","events_url":"https://api.github.com/repos/dotta/slick/events","assignees_url":"https://api.github.com/repos/dotta/slick/assignees{/user}","branches_url":"https://api.github.com/repos/dotta/slick/branches{/branch}","tags_url":"https://api.github.com/repos/dotta/slick/tags","blobs_url":"https://api.github.com/repos/dotta/slick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotta/slick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotta/slick/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotta/slick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotta/slick/statuses/{sha}","languages_url":"https://api.github.com/repos/dotta/slick/languages","stargazers_url":"https://api.github.com/repos/dotta/slick/stargazers","contributors_url":"https://api.github.com/repos/dotta/slick/contributors","subscribers_url":"https://api.github.com/repos/dotta/slick/subscribers","subscription_url":"https://api.github.com/repos/dotta/slick/subscription","commits_url":"https://api.github.com/repos/dotta/slick/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotta/slick/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotta/slick/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotta/slick/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotta/slick/contents/{+path}","compare_url":"https://api.github.com/repos/dotta/slick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotta/slick/merges","archive_url":"https://api.github.com/repos/dotta/slick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotta/slick/downloads","issues_url":"https://api.github.com/repos/dotta/slick/issues{/number}","pulls_url":"https://api.github.com/repos/dotta/slick/pulls{/number}","milestones_url":"https://api.github.com/repos/dotta/slick/milestones{/number}","notifications_url":"https://api.github.com/repos/dotta/slick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotta/slick/labels{/name}","releases_url":"https://api.github.com/repos/dotta/slick/releases{/id}","created_at":"2015-08-10T16:23:35Z","updated_at":"2015-08-10T16:23:39Z","pushed_at":"2015-08-11T10:09:14Z","git_url":"git://github.com/dotta/slick.git","ssh_url":"git@github.com:dotta/slick.git","clone_url":"https://github.com/dotta/slick.git","svn_url":"https://github.com/dotta/slick","homepage":"http://slick.typesafe.com","size":17567,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slick:master","ref":"master","sha":"9e28dec74b6d3d42e617c771112cef7e0e34dd2a","user":{"login":"slick","id":1752624,"avatar_url":"https://avatars.githubusercontent.com/u/1752624?v=3","gravatar_id":"","url":"https://api.github.com/users/slick","html_url":"https://github.com/slick","followers_url":"https://api.github.com/users/slick/followers","following_url":"https://api.github.com/users/slick/following{/other_user}","gists_url":"https://api.github.com/users/slick/gists{/gist_id}","starred_url":"https://api.github.com/users/slick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slick/subscriptions","organizations_url":"https://api.github.com/users/slick/orgs","repos_url":"https://api.github.com/users/slick/repos","events_url":"https://api.github.com/users/slick/events{/privacy}","received_events_url":"https://api.github.com/users/slick/received_events","type":"Organization","site_admin":false},"repo":{"id":133684,"name":"slick","full_name":"slick/slick","owner":{"login":"slick","id":1752624,"avatar_url":"https://avatars.githubusercontent.com/u/1752624?v=3","gravatar_id":"","url":"https://api.github.com/users/slick","html_url":"https://github.com/slick","followers_url":"https://api.github.com/users/slick/followers","following_url":"https://api.github.com/users/slick/following{/other_user}","gists_url":"https://api.github.com/users/slick/gists{/gist_id}","starred_url":"https://api.github.com/users/slick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slick/subscriptions","organizations_url":"https://api.github.com/users/slick/orgs","repos_url":"https://api.github.com/users/slick/repos","events_url":"https://api.github.com/users/slick/events{/privacy}","received_events_url":"https://api.github.com/users/slick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slick/slick","description":"Scala Language Integrated Connection Kit","fork":false,"url":"https://api.github.com/repos/slick/slick","forks_url":"https://api.github.com/repos/slick/slick/forks","keys_url":"https://api.github.com/repos/slick/slick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slick/slick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slick/slick/teams","hooks_url":"https://api.github.com/repos/slick/slick/hooks","issue_events_url":"https://api.github.com/repos/slick/slick/issues/events{/number}","events_url":"https://api.github.com/repos/slick/slick/events","assignees_url":"https://api.github.com/repos/slick/slick/assignees{/user}","branches_url":"https://api.github.com/repos/slick/slick/branches{/branch}","tags_url":"https://api.github.com/repos/slick/slick/tags","blobs_url":"https://api.github.com/repos/slick/slick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slick/slick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slick/slick/git/refs{/sha}","trees_url":"https://api.github.com/repos/slick/slick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slick/slick/statuses/{sha}","languages_url":"https://api.github.com/repos/slick/slick/languages","stargazers_url":"https://api.github.com/repos/slick/slick/stargazers","contributors_url":"https://api.github.com/repos/slick/slick/contributors","subscribers_url":"https://api.github.com/repos/slick/slick/subscribers","subscription_url":"https://api.github.com/repos/slick/slick/subscription","commits_url":"https://api.github.com/repos/slick/slick/commits{/sha}","git_commits_url":"https://api.github.com/repos/slick/slick/git/commits{/sha}","comments_url":"https://api.github.com/repos/slick/slick/comments{/number}","issue_comment_url":"https://api.github.com/repos/slick/slick/issues/comments{/number}","contents_url":"https://api.github.com/repos/slick/slick/contents/{+path}","compare_url":"https://api.github.com/repos/slick/slick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slick/slick/merges","archive_url":"https://api.github.com/repos/slick/slick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slick/slick/downloads","issues_url":"https://api.github.com/repos/slick/slick/issues{/number}","pulls_url":"https://api.github.com/repos/slick/slick/pulls{/number}","milestones_url":"https://api.github.com/repos/slick/slick/milestones{/number}","notifications_url":"https://api.github.com/repos/slick/slick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slick/slick/labels{/name}","releases_url":"https://api.github.com/repos/slick/slick/releases{/id}","created_at":"2009-02-20T22:51:53Z","updated_at":"2015-08-11T05:53:10Z","pushed_at":"2015-08-10T15:42:30Z","git_url":"git://github.com/slick/slick.git","ssh_url":"git@github.com:slick/slick.git","clone_url":"https://github.com/slick/slick.git","svn_url":"https://github.com/slick/slick","homepage":"http://slick.typesafe.com","size":17567,"stargazers_count":1275,"watchers_count":1275,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":312,"forks":254,"open_issues":312,"watchers":1275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slick/slick/pulls/1229"},"html":{"href":"https://github.com/slick/slick/pull/1229"},"issue":{"href":"https://api.github.com/repos/slick/slick/issues/1229"},"comments":{"href":"https://api.github.com/repos/slick/slick/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/slick/slick/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/slick/slick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slick/slick/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/slick/slick/statuses/75146666627f26b796a36df75f2e03fb421b8a85"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}