{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/41340593","id":41340593,"diff_hunk":"@@ -25,6 +25,11 @@\n #    Name of player, on a server this is the main admin\n #name =\n \n+#    Network address to bind to when making outgoing connections.\n+#    If you're running a server and have anouncing enabled the","path":"minetest.conf.example","position":5,"original_position":5,"commit_id":"2905f70a5323d14a8e93334d883cff0b12521f4b","original_commit_id":"2905f70a5323d14a8e93334d883cff0b12521f4b","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"announcing*","created_at":"2015-10-07T00:40:08Z","updated_at":"2015-10-07T00:40:08Z","html_url":"https://github.com/minetest/minetest/pull/2604#discussion_r41340593","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2604","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/41340593"},"html":{"href":"https://github.com/minetest/minetest/pull/2604#discussion_r41340593"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2604"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2604","id":32644064,"html_url":"https://github.com/minetest/minetest/pull/2604","diff_url":"https://github.com/minetest/minetest/pull/2604.diff","patch_url":"https://github.com/minetest/minetest/pull/2604.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2604","number":2604,"state":"open","locked":false,"title":"Add support for multiple listen addesses","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"body":"  * Ask the OS to assign an unused port instead of:\r\n    - Using a static one (in tests, specifically `30001` and `30003`)\r\n    - Trying a random one that might be used (client outgoing connections)\r\n  * **^** Fixes a few reported issues, but I only found #2344  with a cursory look.\r\n  * Make banning normalize IPv6-mapped IPv4 addresses (so you can't try `1.2.3.4` and then `::ffff:1.2.3.4`).\r\n  * Fix some horrible main menu code (multiple lookups, no popping, using `luaL_check*` for table fields).\r\n  * Move `socket.cpp` into `network` folder.\r\n  * Some style fixes.\r\n  * Lots of stuff that I don't remember right now.\r\n\r\nTo do:\r\n  * [ ] Maybe figure out a nicer format for the `--listen` argument (eg `--listen [::1]:0 --listen [::2]:0` instead of `--listen '[::1]:0 [::2]:0'`)\r\n\r\nTo do later:\r\n  * Fix how `gamedata.port` is stored as a string until just before it's used.\r\n","created_at":"2015-04-05T04:38:51Z","updated_at":"2015-10-07T00:40:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5d90903888fb0f4f886f223643d86b8dad8aa37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2604/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2604/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2604/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/2905f70a5323d14a8e93334d883cff0b12521f4b","head":{"label":"ShadowNinja:multi-socket","ref":"multi-socket","sha":"2905f70a5323d14a8e93334d883cff0b12521f4b","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"repo":{"id":8000011,"name":"minetest","full_name":"ShadowNinja/minetest","owner":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShadowNinja/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. This is a private fork, the official repo is @minetest/minetest","fork":true,"url":"https://api.github.com/repos/ShadowNinja/minetest","forks_url":"https://api.github.com/repos/ShadowNinja/minetest/forks","keys_url":"https://api.github.com/repos/ShadowNinja/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShadowNinja/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShadowNinja/minetest/teams","hooks_url":"https://api.github.com/repos/ShadowNinja/minetest/hooks","issue_events_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/ShadowNinja/minetest/events","assignees_url":"https://api.github.com/repos/ShadowNinja/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/ShadowNinja/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/ShadowNinja/minetest/tags","blobs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShadowNinja/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShadowNinja/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShadowNinja/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/ShadowNinja/minetest/languages","stargazers_url":"https://api.github.com/repos/ShadowNinja/minetest/stargazers","contributors_url":"https://api.github.com/repos/ShadowNinja/minetest/contributors","subscribers_url":"https://api.github.com/repos/ShadowNinja/minetest/subscribers","subscription_url":"https://api.github.com/repos/ShadowNinja/minetest/subscription","commits_url":"https://api.github.com/repos/ShadowNinja/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShadowNinja/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShadowNinja/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShadowNinja/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/ShadowNinja/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShadowNinja/minetest/merges","archive_url":"https://api.github.com/repos/ShadowNinja/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShadowNinja/minetest/downloads","issues_url":"https://api.github.com/repos/ShadowNinja/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/ShadowNinja/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/ShadowNinja/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/ShadowNinja/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShadowNinja/minetest/labels{/name}","releases_url":"https://api.github.com/repos/ShadowNinja/minetest/releases{/id}","created_at":"2013-02-04T02:44:10Z","updated_at":"2015-02-21T18:17:05Z","pushed_at":"2015-09-21T14:46:19Z","git_url":"git://github.com/ShadowNinja/minetest.git","ssh_url":"git@github.com:ShadowNinja/minetest.git","clone_url":"https://github.com/ShadowNinja/minetest.git","svn_url":"https://github.com/ShadowNinja/minetest","homepage":"http://minetest.net/","size":38601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"f0cd5da687ca216b4bdd9abe7bc8038a679d3763","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-10-06T18:43:09Z","pushed_at":"2015-10-06T23:32:20Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":105584,"stargazers_count":1657,"watchers_count":1657,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":551,"mirror_url":null,"open_issues_count":634,"forks":551,"open_issues":634,"watchers":1657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2604"},"html":{"href":"https://github.com/minetest/minetest/pull/2604"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2604"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2604/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2604/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2604/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/2905f70a5323d14a8e93334d883cff0b12521f4b"}}}}