{"action":"created","comment":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/40989561","id":40989561,"diff_hunk":"@@ -56,61 +60,36 @@\n  */\n public class CharacterSheetPanel extends HtmlPanel implements CharacterSelectionListener\n {\n-\n-\tprivate static final String COLOR_TAG = \"preview_color.css\";\n-\n \tprivate enum CssColor\n \t{\n-\n-\t\tBLUE,\n-\t\tLIGHTBLUE,\n-\t\tGREEN,\n-\t\tLIGHTGREEN,\n-\t\tRED,\n-\t\tLIGHTRED,\n-\t\tYELLOW,\n-\t\tLIGHTYELLOW,\n-\t\tGREY,\n-\t\tLIGHTGREY;\n-\n-\t\tpublic String getCssText()\n-\t\t{\n-\t\t\tswitch (this)\n-\t\t\t{\n-\t\t\t\tcase BLUE:\n-\t\t\t\t\treturn \"preview_color_blue.css\";\n-\t\t\t\tcase LIGHTBLUE:\n-\t\t\t\t\treturn \"preview_color_light_blue.css\";\n-\t\t\t\tcase GREEN:\n-\t\t\t\t\treturn \"preview_color_green.css\";\n-\t\t\t\tcase LIGHTGREEN:\n-\t\t\t\t\treturn \"preview_color_light_green.css\";\n-\t\t\t\tcase RED:\n-\t\t\t\t\treturn \"preview_color_red.css\";\n-\t\t\t\tcase LIGHTRED:\n-\t\t\t\t\treturn \"preview_color_light_red.css\";\n-\t\t\t\tcase YELLOW:\n-\t\t\t\t\treturn \"preview_color_yellow.css\";\n-\t\t\t\tcase LIGHTYELLOW:\n-\t\t\t\t\treturn \"preview_color_light_yellow.css\";\n-\t\t\t\tcase GREY:\n-\t\t\t\t\treturn \"preview_color_grey.css\";\n-\t\t\t\tcase LIGHTGREY:\n-\t\t\t\t\treturn \"preview_color_light_grey.css\";\n-\t\t\t\tdefault:\n-\t\t\t\t\tthrow new InternalError();\n-\t\t\t}\n+\t\tBLUE(\"preview_color_blue.css\"),\n+\t\tLIGHTBLUE(\"preview_color_light_blue.css\"),\n+\t\tGREEN(\"preview_color_green.css\"),\n+\t\tLIGHTGREEN(\"preview_color_light_green.css\"),\n+\t\tRED(\"preview_color_red.css\"),\n+\t\tLIGHTRED(\"preview_color_light_red.css\"),\n+\t\tYELLOW(\"preview_color_yellow.css\"),\n+\t\tLIGHTYELLOW(\"preview_color_light_yellow.css\"),\n+\t\tGREY(\"preview_color_grey.css\"),\n+\t\tLIGHTGREY(\"preview_color_light_grey.css\");\n+\n+\t\tpublic String cssfile;","path":"code/src/java/pcgen/gui2/csheet/CharacterSheetPanel.java","position":85,"original_position":85,"commit_id":"14374123cb0059bfe31fd899311e8a33153dd4a4","original_commit_id":"14374123cb0059bfe31fd899311e8a33153dd4a4","user":{"login":"LegacyKing","id":2759875,"avatar_url":"https://avatars.githubusercontent.com/u/2759875?v=3","gravatar_id":"","url":"https://api.github.com/users/LegacyKing","html_url":"https://github.com/LegacyKing","followers_url":"https://api.github.com/users/LegacyKing/followers","following_url":"https://api.github.com/users/LegacyKing/following{/other_user}","gists_url":"https://api.github.com/users/LegacyKing/gists{/gist_id}","starred_url":"https://api.github.com/users/LegacyKing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LegacyKing/subscriptions","organizations_url":"https://api.github.com/users/LegacyKing/orgs","repos_url":"https://api.github.com/users/LegacyKing/repos","events_url":"https://api.github.com/users/LegacyKing/events{/privacy}","received_events_url":"https://api.github.com/users/LegacyKing/received_events","type":"User","site_admin":false},"body":"p.s. email didn't send me the message that you flagged me on, so I did not see that till I was looking at the posts. Only saw this \"I much prefer using final public. Using getters / setters is a violation of abstraction and can make code harder to reason about. that said, I'll go with whatever the project style dictates\"\r\n\r\nCheers,","created_at":"2015-10-02T03:38:02Z","updated_at":"2015-10-02T03:38:02Z","html_url":"https://github.com/PCGen/pcgen/pull/639#discussion_r40989561","pull_request_url":"https://api.github.com/repos/PCGen/pcgen/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/40989561"},"html":{"href":"https://github.com/PCGen/pcgen/pull/639#discussion_r40989561"},"pull_request":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/639","id":46223232,"html_url":"https://github.com/PCGen/pcgen/pull/639","diff_url":"https://github.com/PCGen/pcgen/pull/639.diff","patch_url":"https://github.com/PCGen/pcgen/pull/639.patch","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/639","number":639,"state":"open","locked":false,"title":"CODE-2790: Clean up CharacterSheetPanel","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"- change enum to include data attached instead of using a\n  separate switch statement\n- Use resource based try statements\n- Be explicit about caught exceptions\n- Don't explicitly init to null\n- Use final where possible\n- Use string formatting instead of manual concat\n- Cut off lines at consistent 100 char mark","created_at":"2015-09-29T00:06:39Z","updated_at":"2015-10-02T03:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16eec4a4a65cbd9ce37e20fc1bc69f9f814ada71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PCGen/pcgen/pulls/639/commits","review_comments_url":"https://api.github.com/repos/PCGen/pcgen/pulls/639/comments","review_comment_url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/639/comments","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/14374123cb0059bfe31fd899311e8a33153dd4a4","head":{"label":"grimreaper:enum","ref":"enum","sha":"14374123cb0059bfe31fd899311e8a33153dd4a4","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":43053313,"name":"pcgen","full_name":"grimreaper/pcgen","owner":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grimreaper/pcgen","description":"Main code and data development for pcgen program release","fork":true,"url":"https://api.github.com/repos/grimreaper/pcgen","forks_url":"https://api.github.com/repos/grimreaper/pcgen/forks","keys_url":"https://api.github.com/repos/grimreaper/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/pcgen/teams","hooks_url":"https://api.github.com/repos/grimreaper/pcgen/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/pcgen/events","assignees_url":"https://api.github.com/repos/grimreaper/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/pcgen/tags","blobs_url":"https://api.github.com/repos/grimreaper/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/pcgen/languages","stargazers_url":"https://api.github.com/repos/grimreaper/pcgen/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/pcgen/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/pcgen/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/pcgen/subscription","commits_url":"https://api.github.com/repos/grimreaper/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/pcgen/merges","archive_url":"https://api.github.com/repos/grimreaper/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/pcgen/downloads","issues_url":"https://api.github.com/repos/grimreaper/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/pcgen/releases{/id}","created_at":"2015-09-24T08:01:43Z","updated_at":"2015-09-24T08:02:48Z","pushed_at":"2015-09-30T06:05:49Z","git_url":"git://github.com/grimreaper/pcgen.git","ssh_url":"git@github.com:grimreaper/pcgen.git","clone_url":"https://github.com/grimreaper/pcgen.git","svn_url":"https://github.com/grimreaper/pcgen","homepage":"http://pcgen.org","size":161750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCGen:master","ref":"master","sha":"b9984f90e7a6386fb2364f6fbdd7d0eef6ee69b5","user":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"repo":{"id":28585874,"name":"pcgen","full_name":"PCGen/pcgen","owner":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCGen/pcgen","description":"Main code and data development for pcgen program release","fork":false,"url":"https://api.github.com/repos/PCGen/pcgen","forks_url":"https://api.github.com/repos/PCGen/pcgen/forks","keys_url":"https://api.github.com/repos/PCGen/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCGen/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCGen/pcgen/teams","hooks_url":"https://api.github.com/repos/PCGen/pcgen/hooks","issue_events_url":"https://api.github.com/repos/PCGen/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/PCGen/pcgen/events","assignees_url":"https://api.github.com/repos/PCGen/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/PCGen/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/PCGen/pcgen/tags","blobs_url":"https://api.github.com/repos/PCGen/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCGen/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCGen/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCGen/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/PCGen/pcgen/languages","stargazers_url":"https://api.github.com/repos/PCGen/pcgen/stargazers","contributors_url":"https://api.github.com/repos/PCGen/pcgen/contributors","subscribers_url":"https://api.github.com/repos/PCGen/pcgen/subscribers","subscription_url":"https://api.github.com/repos/PCGen/pcgen/subscription","commits_url":"https://api.github.com/repos/PCGen/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCGen/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCGen/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCGen/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCGen/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/PCGen/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCGen/pcgen/merges","archive_url":"https://api.github.com/repos/PCGen/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCGen/pcgen/downloads","issues_url":"https://api.github.com/repos/PCGen/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/PCGen/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/PCGen/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/PCGen/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCGen/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/PCGen/pcgen/releases{/id}","created_at":"2014-12-29T08:41:04Z","updated_at":"2015-09-29T07:33:42Z","pushed_at":"2015-10-02T03:02:53Z","git_url":"git://github.com/PCGen/pcgen.git","ssh_url":"git@github.com:PCGen/pcgen.git","clone_url":"https://github.com/PCGen/pcgen.git","svn_url":"https://github.com/PCGen/pcgen","homepage":"http://pcgen.org","size":184327,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":4,"forks":42,"open_issues":4,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/639"},"html":{"href":"https://github.com/PCGen/pcgen/pull/639"},"issue":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/639"},"comments":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/PCGen/pcgen/statuses/14374123cb0059bfe31fd899311e8a33153dd4a4"}}}}