{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/2192","labels_url":"https://api.github.com/repos/CartoDB/cartodb/issues/2192/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/2192/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/2192/events","html_url":"https://github.com/CartoDB/cartodb/pull/2192","id":57346211,"number":2192,"title":"Organization profiles for new public dashboard","user":{"login":"viddo","id":978461,"avatar_url":"https://avatars.githubusercontent.com/u/978461?v=3","gravatar_id":"","url":"https://api.github.com/users/viddo","html_url":"https://github.com/viddo","followers_url":"https://api.github.com/users/viddo/followers","following_url":"https://api.github.com/users/viddo/following{/other_user}","gists_url":"https://api.github.com/users/viddo/gists{/gist_id}","starred_url":"https://api.github.com/users/viddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viddo/subscriptions","organizations_url":"https://api.github.com/users/viddo/orgs","repos_url":"https://api.github.com/users/viddo/repos","events_url":"https://api.github.com/users/viddo/events{/privacy}","received_events_url":"https://api.github.com/users/viddo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-11T17:13:26Z","updated_at":"2015-02-12T10:19:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/2192","html_url":"https://github.com/CartoDB/cartodb/pull/2192","diff_url":"https://github.com/CartoDB/cartodb/pull/2192.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/2192.patch"},"body":"Fixed #2179 \r\n\r\n![screen shot 2015-02-11 at 18 14 07](https://cloud.githubusercontent.com/assets/978461/6151967/cee5e1e4-b219-11e4-9e46-c6fe6bfd1e8b.png)\r\n\r\n**Rationales for changes:**\r\n\r\n- added new `FeatureFlag.allowed?` method, for conveniently check flag that is not tied to a user instance\r\n- DRY'ed the controller to get rid of the duplicated logic that existed in basically all entry points:\r\n - flow control logic (unrelated to rendering) was extracted to POROs models (placed in `lib/cartodb/controller_flow/public/, I'm happy to rename the concept if you have any suggestions)\r\n - view logic was extracted to private methods in the controller, e.g.:\r\n   - some common parameters used here and there, `current_page` (pagination), `tag_or_nil`\r\n   - setting `@vars` used by the views\r\n - separated new vs. old (current) rendering, so once the current dashboard is deprecated we can simply remove all methods prefixed with (old_*) when that time comes\r\n\r\nNotice that the actual Rails rendering is still left in the controller. Hopefully it should be easier to read & maintain the logic related to this controller from now on."},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments/74047716","html_url":"https://github.com/CartoDB/cartodb/pull/2192#issuecomment-74047716","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/2192","id":74047716,"user":{"login":"viddo","id":978461,"avatar_url":"https://avatars.githubusercontent.com/u/978461?v=3","gravatar_id":"","url":"https://api.github.com/users/viddo","html_url":"https://github.com/viddo","followers_url":"https://api.github.com/users/viddo/followers","following_url":"https://api.github.com/users/viddo/following{/other_user}","gists_url":"https://api.github.com/users/viddo/gists{/gist_id}","starred_url":"https://api.github.com/users/viddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viddo/subscriptions","organizations_url":"https://api.github.com/users/viddo/orgs","repos_url":"https://api.github.com/users/viddo/repos","events_url":"https://api.github.com/users/viddo/events{/privacy}","received_events_url":"https://api.github.com/users/viddo/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T10:19:30Z","updated_at":"2015-02-12T10:19:30Z","body":"@javisantana aha, no there are no changes to the API here, the scope of this issue/PR are only for the visual (i.e. html/css), which page to render is handled by a feature flag.\r\n\r\nFor the next milestone (the logged-in use-cases, i.e. settings dropdown and likes) I've started on there will probably be some minor changes, so I'll ping you then.\r\n\r\nDoes that answer your question or did I miss something?"}}