{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/31880410","id":31880410,"diff_hunk":"@@ -338,10 +340,10 @@ def _fit_dipoles(data, times, rrs, guess_fwd_svd, fwd_data, whitener,\n     return pos, amp, ori, gof, residual\n \n \n-def _fit_dipole(B_orig, t, rrs, guess_fwd_svd, fwd_data, whitener, proj_op,\n+def _fit_dipole(min_dist_to_inner_skull, B_orig, t, rrs,\n+                guess_fwd_svd, fwd_data, whitener, proj_op,\n                 fmin_cobyla):\n     \"\"\"Fit a single bit of data\"\"\"\n-    logger.info('---- Fitting : %7.1f ms' % (1000 * t,))","path":"mne/dipole.py","position":32,"original_position":27,"commit_id":"117c2617655d0b10ef5bed570e02fcb672b56e89","original_commit_id":"85e1dd6b49abe0c13e1f5a7df3c9346f7cda957b","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"ok forget it. It's below. Sorry for the noise.","created_at":"2015-06-07T20:45:45Z","updated_at":"2015-06-07T20:45:45Z","html_url":"https://github.com/mne-tools/mne-python/pull/2155#discussion_r31880410","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/31880410"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2155#discussion_r31880410"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155","id":36331017,"html_url":"https://github.com/mne-tools/mne-python/pull/2155","diff_url":"https://github.com/mne-tools/mne-python/pull/2155.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2155.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2155","number":2155,"state":"open","locked":false,"title":"minimum distance constrain to fit_dipole","user":{"login":"jmontoyam","id":3098532,"avatar_url":"https://avatars.githubusercontent.com/u/3098532?v=3","gravatar_id":"","url":"https://api.github.com/users/jmontoyam","html_url":"https://github.com/jmontoyam","followers_url":"https://api.github.com/users/jmontoyam/followers","following_url":"https://api.github.com/users/jmontoyam/following{/other_user}","gists_url":"https://api.github.com/users/jmontoyam/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontoyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontoyam/subscriptions","organizations_url":"https://api.github.com/users/jmontoyam/orgs","repos_url":"https://api.github.com/users/jmontoyam/repos","events_url":"https://api.github.com/users/jmontoyam/events{/privacy}","received_events_url":"https://api.github.com/users/jmontoyam/received_events","type":"User","site_admin":false},"body":"Added minimum distance constrain to fit_dipole: the distance from each fitted dipole to the inner skull should be greater or equal to some distance define  by the user.","created_at":"2015-05-27T17:59:19Z","updated_at":"2015-06-07T20:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c3420838b902c09ea524d8c8966f37b5a3fcac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2155/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/117c2617655d0b10ef5bed570e02fcb672b56e89","head":{"label":"jmontoyam:min-distance-fit-dipole","ref":"min-distance-fit-dipole","sha":"117c2617655d0b10ef5bed570e02fcb672b56e89","user":{"login":"jmontoyam","id":3098532,"avatar_url":"https://avatars.githubusercontent.com/u/3098532?v=3","gravatar_id":"","url":"https://api.github.com/users/jmontoyam","html_url":"https://github.com/jmontoyam","followers_url":"https://api.github.com/users/jmontoyam/followers","following_url":"https://api.github.com/users/jmontoyam/following{/other_user}","gists_url":"https://api.github.com/users/jmontoyam/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontoyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontoyam/subscriptions","organizations_url":"https://api.github.com/users/jmontoyam/orgs","repos_url":"https://api.github.com/users/jmontoyam/repos","events_url":"https://api.github.com/users/jmontoyam/events{/privacy}","received_events_url":"https://api.github.com/users/jmontoyam/received_events","type":"User","site_admin":false},"repo":{"id":33508715,"name":"mne-python","full_name":"jmontoyam/mne-python","owner":{"login":"jmontoyam","id":3098532,"avatar_url":"https://avatars.githubusercontent.com/u/3098532?v=3","gravatar_id":"","url":"https://api.github.com/users/jmontoyam","html_url":"https://github.com/jmontoyam","followers_url":"https://api.github.com/users/jmontoyam/followers","following_url":"https://api.github.com/users/jmontoyam/following{/other_user}","gists_url":"https://api.github.com/users/jmontoyam/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontoyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontoyam/subscriptions","organizations_url":"https://api.github.com/users/jmontoyam/orgs","repos_url":"https://api.github.com/users/jmontoyam/repos","events_url":"https://api.github.com/users/jmontoyam/events{/privacy}","received_events_url":"https://api.github.com/users/jmontoyam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmontoyam/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/jmontoyam/mne-python","forks_url":"https://api.github.com/repos/jmontoyam/mne-python/forks","keys_url":"https://api.github.com/repos/jmontoyam/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmontoyam/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmontoyam/mne-python/teams","hooks_url":"https://api.github.com/repos/jmontoyam/mne-python/hooks","issue_events_url":"https://api.github.com/repos/jmontoyam/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/jmontoyam/mne-python/events","assignees_url":"https://api.github.com/repos/jmontoyam/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/jmontoyam/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/jmontoyam/mne-python/tags","blobs_url":"https://api.github.com/repos/jmontoyam/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmontoyam/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmontoyam/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmontoyam/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmontoyam/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jmontoyam/mne-python/languages","stargazers_url":"https://api.github.com/repos/jmontoyam/mne-python/stargazers","contributors_url":"https://api.github.com/repos/jmontoyam/mne-python/contributors","subscribers_url":"https://api.github.com/repos/jmontoyam/mne-python/subscribers","subscription_url":"https://api.github.com/repos/jmontoyam/mne-python/subscription","commits_url":"https://api.github.com/repos/jmontoyam/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmontoyam/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmontoyam/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmontoyam/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmontoyam/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/jmontoyam/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmontoyam/mne-python/merges","archive_url":"https://api.github.com/repos/jmontoyam/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmontoyam/mne-python/downloads","issues_url":"https://api.github.com/repos/jmontoyam/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/jmontoyam/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jmontoyam/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jmontoyam/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmontoyam/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/jmontoyam/mne-python/releases{/id}","created_at":"2015-04-06T22:16:01Z","updated_at":"2015-05-03T23:15:16Z","pushed_at":"2015-06-07T20:27:21Z","git_url":"git://github.com/jmontoyam/mne-python.git","ssh_url":"git@github.com:jmontoyam/mne-python.git","clone_url":"https://github.com/jmontoyam/mne-python.git","svn_url":"https://github.com/jmontoyam/mne-python","homepage":"http://martinos.org/mne/","size":78151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"ed811dc83aeeb9c3dbca53b3090f8fad55399691","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-06-03T18:06:57Z","pushed_at":"2015-06-07T20:27:21Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":179892,"stargazers_count":129,"watchers_count":129,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":148,"forks":125,"open_issues":148,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2155"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2155"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2155/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2155/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/117c2617655d0b10ef5bed570e02fcb672b56e89"}}}}