{"action":"closed","number":5771,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/5771","id":40538838,"html_url":"https://github.com/facebook/hhvm/pull/5771","diff_url":"https://github.com/facebook/hhvm/pull/5771.diff","patch_url":"https://github.com/facebook/hhvm/pull/5771.patch","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/5771","number":5771,"state":"closed","locked":false,"title":"Make a few assignment operators in ext_icu not infinitely recurse","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"body":"Because, as MSVC rightfully warns, `hphp\\runtime\\ext\\icu\\ext_icu_collator.h(28): warning C4717: 'HPHP::Intl::Collator::operator=': recursive on all control paths, function will cause runtime stack overflow`\r\nI checked the ubuntu binary, and this is in-fact infinitely recursive in that build as well.","created_at":"2015-07-22T07:54:20Z","updated_at":"2015-08-14T17:44:37Z","closed_at":"2015-08-14T17:44:37Z","merged_at":null,"merge_commit_sha":"afc9e0b1c03754cf2aa53deba14cd9f2b1d2d7fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/hhvm/pulls/5771/commits","review_comments_url":"https://api.github.com/repos/facebook/hhvm/pulls/5771/comments","review_comment_url":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/5771/comments","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/1c258a8f45dd5513dd33af5039545ebf543e7f4f","head":{"label":"Orvid:no-recursive-icu","ref":"no-recursive-icu","sha":"1c258a8f45dd5513dd33af5039545ebf543e7f4f","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"repo":{"id":35520773,"name":"hhvm","full_name":"Orvid/hhvm","owner":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Orvid/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":true,"url":"https://api.github.com/repos/Orvid/hhvm","forks_url":"https://api.github.com/repos/Orvid/hhvm/forks","keys_url":"https://api.github.com/repos/Orvid/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Orvid/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Orvid/hhvm/teams","hooks_url":"https://api.github.com/repos/Orvid/hhvm/hooks","issue_events_url":"https://api.github.com/repos/Orvid/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/Orvid/hhvm/events","assignees_url":"https://api.github.com/repos/Orvid/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/Orvid/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/Orvid/hhvm/tags","blobs_url":"https://api.github.com/repos/Orvid/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Orvid/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Orvid/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Orvid/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Orvid/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/Orvid/hhvm/languages","stargazers_url":"https://api.github.com/repos/Orvid/hhvm/stargazers","contributors_url":"https://api.github.com/repos/Orvid/hhvm/contributors","subscribers_url":"https://api.github.com/repos/Orvid/hhvm/subscribers","subscription_url":"https://api.github.com/repos/Orvid/hhvm/subscription","commits_url":"https://api.github.com/repos/Orvid/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Orvid/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Orvid/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Orvid/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Orvid/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/Orvid/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Orvid/hhvm/merges","archive_url":"https://api.github.com/repos/Orvid/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Orvid/hhvm/downloads","issues_url":"https://api.github.com/repos/Orvid/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/Orvid/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/Orvid/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/Orvid/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Orvid/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/Orvid/hhvm/releases{/id}","created_at":"2015-05-13T01:09:44Z","updated_at":"2015-05-13T01:10:51Z","pushed_at":"2015-08-13T22:27:41Z","git_url":"git://github.com/Orvid/hhvm.git","ssh_url":"git@github.com:Orvid/hhvm.git","clone_url":"https://github.com/Orvid/hhvm.git","svn_url":"https://github.com/Orvid/hhvm","homepage":"http://hhvm.com","size":217543,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b9d353021fabfce518bca3371f3f357437fadbe8","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":455600,"name":"hhvm","full_name":"facebook/hhvm","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":false,"url":"https://api.github.com/repos/facebook/hhvm","forks_url":"https://api.github.com/repos/facebook/hhvm/forks","keys_url":"https://api.github.com/repos/facebook/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/hhvm/teams","hooks_url":"https://api.github.com/repos/facebook/hhvm/hooks","issue_events_url":"https://api.github.com/repos/facebook/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/hhvm/events","assignees_url":"https://api.github.com/repos/facebook/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/hhvm/tags","blobs_url":"https://api.github.com/repos/facebook/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/hhvm/languages","stargazers_url":"https://api.github.com/repos/facebook/hhvm/stargazers","contributors_url":"https://api.github.com/repos/facebook/hhvm/contributors","subscribers_url":"https://api.github.com/repos/facebook/hhvm/subscribers","subscription_url":"https://api.github.com/repos/facebook/hhvm/subscription","commits_url":"https://api.github.com/repos/facebook/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/hhvm/merges","archive_url":"https://api.github.com/repos/facebook/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/hhvm/downloads","issues_url":"https://api.github.com/repos/facebook/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/facebook/hhvm/releases{/id}","created_at":"2010-01-02T01:17:06Z","updated_at":"2015-08-14T11:29:53Z","pushed_at":"2015-08-14T17:44:32Z","git_url":"git://github.com/facebook/hhvm.git","ssh_url":"git@github.com:facebook/hhvm.git","clone_url":"https://github.com/facebook/hhvm.git","svn_url":"https://github.com/facebook/hhvm","homepage":"http://hhvm.com","size":448894,"stargazers_count":12398,"watchers_count":12398,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2234,"mirror_url":null,"open_issues_count":913,"forks":2234,"open_issues":913,"watchers":12398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/5771"},"html":{"href":"https://github.com/facebook/hhvm/pull/5771"},"issue":{"href":"https://api.github.com/repos/facebook/hhvm/issues/5771"},"comments":{"href":"https://api.github.com/repos/facebook/hhvm/issues/5771/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/5771/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/5771/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/hhvm/statuses/1c258a8f45dd5513dd33af5039545ebf543e7f4f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":5,"deletions":4,"changed_files":4}}