{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/97","labels_url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/97/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/97/events","html_url":"https://github.com/rapid7/metasploit-credential/pull/97","id":58267694,"number":97,"title":"metasploit-credential - remove Rails 4 warnings","user":{"login":"sgonzalez-r7","id":10050455,"avatar_url":"https://avatars.githubusercontent.com/u/10050455?v=3","gravatar_id":"","url":"https://api.github.com/users/sgonzalez-r7","html_url":"https://github.com/sgonzalez-r7","followers_url":"https://api.github.com/users/sgonzalez-r7/followers","following_url":"https://api.github.com/users/sgonzalez-r7/following{/other_user}","gists_url":"https://api.github.com/users/sgonzalez-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/sgonzalez-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgonzalez-r7/subscriptions","organizations_url":"https://api.github.com/users/sgonzalez-r7/orgs","repos_url":"https://api.github.com/users/sgonzalez-r7/repos","events_url":"https://api.github.com/users/sgonzalez-r7/events{/privacy}","received_events_url":"https://api.github.com/users/sgonzalez-r7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-19T20:49:52Z","updated_at":"2015-02-25T23:12:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-credential/pulls/97","html_url":"https://github.com/rapid7/metasploit-credential/pull/97","diff_url":"https://github.com/rapid7/metasploit-credential/pull/97.diff","patch_url":"https://github.com/rapid7/metasploit-credential/pull/97.patch"},"body":"### Description\r\n  \r\nThis PR eliminates the following warnings for Rails 4\r\n\r\n* Fix whiny_nils warning\r\n* Fix FactoryGirl #ignore warning\r\n\r\n### Verification Steps\r\n\r\nRails 3\r\n\r\n* [ ] `bundle install`\r\n* [ ] `rake spec`\r\n* [ ] verify no spec failures\r\n\r\nRails 4\r\n\r\n* [ ] switch to Rails 4 env\r\n* [ ] `bundle install`\r\n* [ ] `rake spec`\r\n* [ ] verify no whiny_nils deprecation warnings\r\n\r\n  ```\r\n  DEPRECATION WARNING: config.whiny_nils option is deprecated and no longer\r\n  works. (called from block in <top (required)> at /Users/sgonzalez/Projects/rapid7-\r\n  other/metasploit-model/spec/dummy/config/environments/test.rb:15)\r\n  ```\r\n* [ ] verify no FactoryGirl #ignore warnings\r\n\r\n  ```\r\n  DEPRECATION WARNING: `#ignore` is deprecated and will be removed in 5.0. Please use\r\n  `#transient` instead. (called from block (2 levels) in <top (required)> at\r\n  /Users/sgonzalez/rapid7/metasploit-credential/spec/factories/metasploit/credential/cores.rb:4)\r\n  ```\r\n\r\n### Post-merge Steps\r\n\r\nPerform these steps prior to pushing to master or the build will be broke on master.\r\n\r\n### Version\r\n* [ ] Edit `lib/metasploit-credential/version.rb`\r\n* [ ] Remove `PRERELEASE` and its comment as `PRERELEASE` is not defined on master.\r\n\r\n### Gem build\r\n* [ ] gem build *.gemspec\r\n* [ ] VERIFY the gem has no '.pre' version suffix.\r\n\r\n### RSpec\r\n* [ ] `rake spec`\r\n* [ ] VERIFY version examples pass without failures\r\n\r\n### Commit & Push\r\n* [ ] `git commit -a`\r\n* [ ] `git push origin master`\r\n\r\n## Release\r\n### JRuby\r\n* [ ] `rvm use jruby@metasploit-credential`\r\n* [ ] `rm Gemfile.lock`\r\n* [ ] `bundle install`\r\n* [ ] `rake release`\r\n\r\n### MRI Ruby\r\n* [ ] `rvm use ruby-2.1.5@metasploit-credential`\r\n* [ ] `rm Gemfile.lock`\r\n* [ ] `bundle install`\r\n* [ ] `rake release`\r\n"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/comments/76082219","html_url":"https://github.com/rapid7/metasploit-credential/pull/97#issuecomment-76082219","issue_url":"https://api.github.com/repos/rapid7/metasploit-credential/issues/97","id":76082219,"user":{"login":"mbuck-r7","id":1170730,"avatar_url":"https://avatars.githubusercontent.com/u/1170730?v=3","gravatar_id":"","url":"https://api.github.com/users/mbuck-r7","html_url":"https://github.com/mbuck-r7","followers_url":"https://api.github.com/users/mbuck-r7/followers","following_url":"https://api.github.com/users/mbuck-r7/following{/other_user}","gists_url":"https://api.github.com/users/mbuck-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/mbuck-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbuck-r7/subscriptions","organizations_url":"https://api.github.com/users/mbuck-r7/orgs","repos_url":"https://api.github.com/users/mbuck-r7/repos","events_url":"https://api.github.com/users/mbuck-r7/events{/privacy}","received_events_url":"https://api.github.com/users/mbuck-r7/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T23:12:49Z","updated_at":"2015-02-25T23:12:49Z","body":"Going to skip the release on this since we don't **need** it in master, and holding on the merge while Travis completes its maintenance."}}