{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/vellum/pulls/comments/31282550","id":31282550,"diff_hunk":"@@ -1,173 +1,112 @@\n // Variables\n // ===\n //\n-// Variables are formatted using the following rules:\n-//\n-// * Names must be lowercase and dash-separated (kebab-case).\n-//\n-// * Names should represent properties or applications as closely as possible\n-//\n-// * Modifiers, qualifiers, or applications should be prepended to the variable\n-//   name. e.g. $form-family (bad) vs. $form-font-family (better)\n-//\n-// * Variables without a qualifier are considered “base” variables,\n-//   i.e. the default value for that type, e.g. $font-size, $brand-color,\n-//   $neutral-50.\n-//\n-// * Variables with qualifiers at the beginning are considered “variations” on a\n-//   base variable, e.g. $small-font-size, $light-brand-color.\n-//\n-// * Neutral variables use a scale defined in multiples of 10\n-//   from $neutral-30 (lightest) to $neutral-70 (darkest). Their value can be changed\n-//   according to the project needs but variable names should remain the same.\n-//   This provides room to adjust values without changing variable names,\n-//   but allows users to use more neutral variables. Additional variables can be\n-//   inserted between, below or above these values depending on the colour intensity\n-//   and be named $neutral-55, $neutral-25, etc.\n+// - Names should be lowercase and dash-separated;\n+// - Qualifiers should be added to the beginning of related variables: use\n+//   `$small-font-size`, not `$font-size-small`;\n+// - Numeric scales should use increments of 10; these numbers are arbitrary and\n+//   should not map to actual values. If really necessary, additional values can\n+//   be added in between, e.g. $neutral-15 between 10 and 20.\n \n \n-// Typography\n+// Layout\n // ---\n \n-$sans-serif: \"Helvetica Neue\", Helvetica, Arial, sans-serif;\n-$serif: Georgia, Times, \"Times New Roman\", serif;\n+// Basic unit for spacing and alignment; 6 to 12px recommended. Apply in whole\n+// or half multiples.\n+$unit: 10px !default;\n+\n+// Standard tap-target size\n+$tap-size: 45px !default;\n \n-$font-family: $sans-serif;\n-$header-font-family: $font-family;\n \n+// Typography\n+// ---\n+\n+$font-family: 'Helvetica Neue', 'Roboto', sans-serif;\n+$header-font-family: $font-family;","path":"dist/vellum/_variables.scss","position":55,"original_position":55,"commit_id":"52fd2ac0ce346b376b46ac78ba3691ac1b370da2","original_commit_id":"52fd2ac0ce346b376b46ac78ba3691ac1b370da2","user":{"login":"jeffkamo","id":734535,"avatar_url":"https://avatars.githubusercontent.com/u/734535?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffkamo","html_url":"https://github.com/jeffkamo","followers_url":"https://api.github.com/users/jeffkamo/followers","following_url":"https://api.github.com/users/jeffkamo/following{/other_user}","gists_url":"https://api.github.com/users/jeffkamo/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkamo/subscriptions","organizations_url":"https://api.github.com/users/jeffkamo/orgs","repos_url":"https://api.github.com/users/jeffkamo/repos","events_url":"https://api.github.com/users/jeffkamo/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkamo/received_events","type":"User","site_admin":false},"body":"Is variable necessary? Is it common enough to warrent us keeping it?","created_at":"2015-05-28T22:01:24Z","updated_at":"2015-05-28T22:01:24Z","html_url":"https://github.com/mobify/vellum/pull/88#discussion_r31282550","pull_request_url":"https://api.github.com/repos/mobify/vellum/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/mobify/vellum/pulls/comments/31282550"},"html":{"href":"https://github.com/mobify/vellum/pull/88#discussion_r31282550"},"pull_request":{"href":"https://api.github.com/repos/mobify/vellum/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/vellum/pulls/88","id":36160925,"html_url":"https://github.com/mobify/vellum/pull/88","diff_url":"https://github.com/mobify/vellum/pull/88.diff","patch_url":"https://github.com/mobify/vellum/pull/88.patch","issue_url":"https://api.github.com/repos/mobify/vellum/issues/88","number":88,"state":"open","locked":false,"title":"Prepare vellum to work with Stencil","user":{"login":"ry5n","id":804014,"avatar_url":"https://avatars.githubusercontent.com/u/804014?v=3","gravatar_id":"","url":"https://api.github.com/users/ry5n","html_url":"https://github.com/ry5n","followers_url":"https://api.github.com/users/ry5n/followers","following_url":"https://api.github.com/users/ry5n/following{/other_user}","gists_url":"https://api.github.com/users/ry5n/gists{/gist_id}","starred_url":"https://api.github.com/users/ry5n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry5n/subscriptions","organizations_url":"https://api.github.com/users/ry5n/orgs","repos_url":"https://api.github.com/users/ry5n/repos","events_url":"https://api.github.com/users/ry5n/events{/privacy}","received_events_url":"https://api.github.com/users/ry5n/received_events","type":"User","site_admin":false},"body":"For consistency Stencil components will all depend on a [minimal set of shared variables](http://github.com/mobify/stencil-variables). This PR ensures that Vellum plays nice with this set, and removes some unnecessary complexity from the existing variables file.\r\n\r\nStatus: **Opened for visibility**\r\n\r\nReviewers: @tedtate @jeffkamo @fractaltheory \r\nTicket: RTM-128/CSOPS-1256\r\nLinked PRs: compare with https://github.com/mobify/stencil-variables/blob/master/variables.scss \r\n\r\n## Changes\r\n\r\nMade variable naming guidelines at the top of the file **way** more concise.\r\n\r\nRemoved or renamed:\r\n- `$sans-serif`: removed; use `$font-family`\r\n- `$serif`: removed\r\n- `$leading-ratio`: removed; use `$line-height` or calculate `($line-height/$font-size)` inline\r\n- `$disabled-color`: removed\r\n- `$background-color`: removed\r\n- `$v-space` and `$-space`: removed, were deprecated; use `$unit` by default\r\n- `$forms-border-color`: removed; use `$border-color` by default\r\n- `$forms-input-color`: renamed → `$input-background-color`\r\n- `$forms-active-border-color`: removed\r\n- `$forms-focus-border-color`: renamed → `$focus-color`\r\n- `$forms-border-radius`: removed; use `$border-radius` by default\r\n- `$forms-font-size`: removed; use `$font-size` by default\r\n- `$forms-font-family`: removed; use `$font-family` by default\r\n- `$forms-checked-background`: removed\r\n- `$forms-disabled-color`: renamed → `$disabled-input-color`\r\n- `$forms-disabled-background`: renamed → `$disabled-input-background-color`\r\n- `$forms-placeholder-color`: removed\r\n\r\nAdded:\r\n- `$tap-size`: the standard tap-target size; useful for consistent sizing of tappable elements\r\n- `$horizontal-input-padding`, `$vertical-input-padding`: for consistent padding among buttons, inputs and other controls\r\n- `$input-padding`: shorthand value for setting all input padding\r\n\r\n## How to test-drive this PR\r\n- Clone the repo and run `npm install && bower install`\r\n- Run the default grunt task (just `grunt` on the command line)\r\n- Open `test/index.html` in a browser\r\n- Check out branch `stencil-sync` and run `grunt again`\r\n- Open a new tab to `text/index.html`\r\n- Ensure things compile; compare the before/after output. Some things will be subtly different, but the after state should be more consistent (e.g. before, some buttons/selects were not consistent heights)","created_at":"2015-05-25T23:06:22Z","updated_at":"2015-05-28T22:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee39d3fe44fa2884e96029c31e014405e2929268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobify/vellum/pulls/88/commits","review_comments_url":"https://api.github.com/repos/mobify/vellum/pulls/88/comments","review_comment_url":"https://api.github.com/repos/mobify/vellum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/vellum/issues/88/comments","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/52fd2ac0ce346b376b46ac78ba3691ac1b370da2","head":{"label":"mobify:stencil-sync","ref":"stencil-sync","sha":"52fd2ac0ce346b376b46ac78ba3691ac1b370da2","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":18122172,"name":"vellum","full_name":"mobify/vellum","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/vellum","description":"Default project styles for a mobile-first AdaptiveJS build.","fork":false,"url":"https://api.github.com/repos/mobify/vellum","forks_url":"https://api.github.com/repos/mobify/vellum/forks","keys_url":"https://api.github.com/repos/mobify/vellum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/vellum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/vellum/teams","hooks_url":"https://api.github.com/repos/mobify/vellum/hooks","issue_events_url":"https://api.github.com/repos/mobify/vellum/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/vellum/events","assignees_url":"https://api.github.com/repos/mobify/vellum/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/vellum/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/vellum/tags","blobs_url":"https://api.github.com/repos/mobify/vellum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/vellum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/vellum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/vellum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/vellum/languages","stargazers_url":"https://api.github.com/repos/mobify/vellum/stargazers","contributors_url":"https://api.github.com/repos/mobify/vellum/contributors","subscribers_url":"https://api.github.com/repos/mobify/vellum/subscribers","subscription_url":"https://api.github.com/repos/mobify/vellum/subscription","commits_url":"https://api.github.com/repos/mobify/vellum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/vellum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/vellum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/vellum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/vellum/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/vellum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/vellum/merges","archive_url":"https://api.github.com/repos/mobify/vellum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/vellum/downloads","issues_url":"https://api.github.com/repos/mobify/vellum/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/vellum/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/vellum/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/vellum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/vellum/labels{/name}","releases_url":"https://api.github.com/repos/mobify/vellum/releases{/id}","created_at":"2014-03-26T00:52:38Z","updated_at":"2015-05-21T23:03:32Z","pushed_at":"2015-05-25T23:06:22Z","git_url":"git://github.com/mobify/vellum.git","ssh_url":"git@github.com:mobify/vellum.git","clone_url":"https://github.com/mobify/vellum.git","svn_url":"https://github.com/mobify/vellum","homepage":null,"size":1240,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"mobify:master","ref":"master","sha":"88737e72bab28dcf43a63b55b0317392554b945a","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":18122172,"name":"vellum","full_name":"mobify/vellum","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/vellum","description":"Default project styles for a mobile-first AdaptiveJS build.","fork":false,"url":"https://api.github.com/repos/mobify/vellum","forks_url":"https://api.github.com/repos/mobify/vellum/forks","keys_url":"https://api.github.com/repos/mobify/vellum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/vellum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/vellum/teams","hooks_url":"https://api.github.com/repos/mobify/vellum/hooks","issue_events_url":"https://api.github.com/repos/mobify/vellum/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/vellum/events","assignees_url":"https://api.github.com/repos/mobify/vellum/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/vellum/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/vellum/tags","blobs_url":"https://api.github.com/repos/mobify/vellum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/vellum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/vellum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/vellum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/vellum/languages","stargazers_url":"https://api.github.com/repos/mobify/vellum/stargazers","contributors_url":"https://api.github.com/repos/mobify/vellum/contributors","subscribers_url":"https://api.github.com/repos/mobify/vellum/subscribers","subscription_url":"https://api.github.com/repos/mobify/vellum/subscription","commits_url":"https://api.github.com/repos/mobify/vellum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/vellum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/vellum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/vellum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/vellum/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/vellum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/vellum/merges","archive_url":"https://api.github.com/repos/mobify/vellum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/vellum/downloads","issues_url":"https://api.github.com/repos/mobify/vellum/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/vellum/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/vellum/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/vellum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/vellum/labels{/name}","releases_url":"https://api.github.com/repos/mobify/vellum/releases{/id}","created_at":"2014-03-26T00:52:38Z","updated_at":"2015-05-21T23:03:32Z","pushed_at":"2015-05-25T23:06:22Z","git_url":"git://github.com/mobify/vellum.git","ssh_url":"git@github.com:mobify/vellum.git","clone_url":"https://github.com/mobify/vellum.git","svn_url":"https://github.com/mobify/vellum","homepage":null,"size":1240,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/vellum/pulls/88"},"html":{"href":"https://github.com/mobify/vellum/pull/88"},"issue":{"href":"https://api.github.com/repos/mobify/vellum/issues/88"},"comments":{"href":"https://api.github.com/repos/mobify/vellum/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/vellum/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/vellum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/vellum/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/vellum/statuses/52fd2ac0ce346b376b46ac78ba3691ac1b370da2"}}}}