{"action":"closed","number":2280,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280","id":53734850,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2280","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2280.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2280.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2280","number":2280,"state":"closed","locked":false,"title":"Improved Plants System","user":{"login":"Zaggy1024","id":3149592,"avatar_url":"https://avatars.githubusercontent.com/u/3149592?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaggy1024","html_url":"https://github.com/Zaggy1024","followers_url":"https://api.github.com/users/Zaggy1024/followers","following_url":"https://api.github.com/users/Zaggy1024/following{/other_user}","gists_url":"https://api.github.com/users/Zaggy1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaggy1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaggy1024/subscriptions","organizations_url":"https://api.github.com/users/Zaggy1024/orgs","repos_url":"https://api.github.com/users/Zaggy1024/repos","events_url":"https://api.github.com/users/Zaggy1024/events{/privacy}","received_events_url":"https://api.github.com/users/Zaggy1024/received_events","type":"User","site_admin":false},"body":"Added ISeed to replace IPlantable for items, allowing them to be ItemStack aware.\r\n\r\nMade IPlantable/ISeed return a collection of soil types that the plant can survive on, and have a method to check if a plant can be placed at a position in the world. The methods to check if the plant can be placed can use a static method added in EnumPlantType that defines the default behavior to check that one of the soil types matches with a plant's.\r\n\r\nBlocks will now also return a collection of soil types that they can survive on.\r\n\r\nFixed Forge making it so that farmland doesn't revert to dirt when a non-crop plant is on top of it (such as tall grass).\r\n\r\nRenaming IPlantable to IPlant to be consistent with ISeed (or changing ISeed to something else, perhaps) would probably be nice, as well as maybe renaming EnumPlantType to EnumSoilType, just to make it clearer what it actually represents. However, since this would force modders to figure out what the old classes have been renamed to, it may not be preferable.","created_at":"2015-12-15T17:24:47Z","updated_at":"2015-12-15T17:25:25Z","closed_at":"2015-12-15T17:25:25Z","merged_at":null,"merge_commit_sha":"42e826f28df89e2e5fcd9ce6a0b302918a48a521","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2280/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/327a281c278f5e3fb9c647cba54ed979c8cadf9f","head":{"label":"Zaggy1024:plantsystem","ref":"plantsystem","sha":"327a281c278f5e3fb9c647cba54ed979c8cadf9f","user":{"login":"Zaggy1024","id":3149592,"avatar_url":"https://avatars.githubusercontent.com/u/3149592?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaggy1024","html_url":"https://github.com/Zaggy1024","followers_url":"https://api.github.com/users/Zaggy1024/followers","following_url":"https://api.github.com/users/Zaggy1024/following{/other_user}","gists_url":"https://api.github.com/users/Zaggy1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaggy1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaggy1024/subscriptions","organizations_url":"https://api.github.com/users/Zaggy1024/orgs","repos_url":"https://api.github.com/users/Zaggy1024/repos","events_url":"https://api.github.com/users/Zaggy1024/events{/privacy}","received_events_url":"https://api.github.com/users/Zaggy1024/received_events","type":"User","site_admin":false},"repo":{"id":34411414,"name":"MinecraftForge","full_name":"Zaggy1024/MinecraftForge","owner":{"login":"Zaggy1024","id":3149592,"avatar_url":"https://avatars.githubusercontent.com/u/3149592?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaggy1024","html_url":"https://github.com/Zaggy1024","followers_url":"https://api.github.com/users/Zaggy1024/followers","following_url":"https://api.github.com/users/Zaggy1024/following{/other_user}","gists_url":"https://api.github.com/users/Zaggy1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaggy1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaggy1024/subscriptions","organizations_url":"https://api.github.com/users/Zaggy1024/orgs","repos_url":"https://api.github.com/users/Zaggy1024/repos","events_url":"https://api.github.com/users/Zaggy1024/events{/privacy}","received_events_url":"https://api.github.com/users/Zaggy1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zaggy1024/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/Zaggy1024/MinecraftForge","forks_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/forks","keys_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/events","assignees_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/merges","archive_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/Zaggy1024/MinecraftForge/releases{/id}","created_at":"2015-04-22T19:33:02Z","updated_at":"2015-05-22T20:28:03Z","pushed_at":"2015-12-15T17:15:02Z","git_url":"git://github.com/Zaggy1024/MinecraftForge.git","ssh_url":"git@github.com:Zaggy1024/MinecraftForge.git","clone_url":"https://github.com/Zaggy1024/MinecraftForge.git","svn_url":"https://github.com/Zaggy1024/MinecraftForge","homepage":"","size":82514,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"11d237f5f2817bf08acee1271406763cba256304","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","created_at":"2012-01-30T01:35:01Z","updated_at":"2015-12-15T08:33:18Z","pushed_at":"2015-12-15T17:24:47Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":140706,"stargazers_count":1134,"watchers_count":1134,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":653,"mirror_url":null,"open_issues_count":221,"forks":653,"open_issues":221,"watchers":1134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2280"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2280"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2280/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2280/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/327a281c278f5e3fb9c647cba54ed979c8cadf9f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":131,"additions":2997,"deletions":2213,"changed_files":531}}