{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/qunit/pulls/comments/24258475","id":24258475,"diff_hunk":"@@ -1,82 +1,11 @@\n-(function() {\n-\n-// Deprecated QUnit.init - Ref #530\n-// Re-initialize the configuration options\n-QUnit.init = function() {\n-\tvar tests, banner, result, qunit,\n-\t\tconfig = QUnit.config;\n-\n-\tconfig.stats = { all: 0, bad: 0 };\n-\tconfig.moduleStats = { all: 0, bad: 0 };\n-\tconfig.started = 0;\n-\tconfig.updateRate = 1000;\n-\tconfig.blocking = false;\n-\tconfig.autostart = true;\n-\tconfig.autorun = false;\n-\tconfig.filter = \"\";\n-\tconfig.queue = [];\n-\n-\t// Return on non-browser environments\n-\t// This is necessary to not break on node tests\n-\tif ( typeof window === \"undefined\" ) {\n-\t\treturn;\n-\t}\n-\n-\tqunit = id( \"qunit\" );\n-\tif ( qunit ) {\n-\t\tqunit.innerHTML =\n-\t\t\t\"<h1 id='qunit-header'>\" + escapeText( document.title ) + \"</h1>\" +\n-\t\t\t\"<h2 id='qunit-banner'></h2>\" +\n-\t\t\t\"<div id='qunit-testrunner-toolbar'></div>\" +\n-\t\t\t\"<h2 id='qunit-userAgent'></h2>\" +\n-\t\t\t\"<ol id='qunit-tests'></ol>\";\n-\t}\n-\n-\ttests = id( \"qunit-tests\" );\n-\tbanner = id( \"qunit-banner\" );\n-\tresult = id( \"qunit-testresult\" );\n-\n-\tif ( tests ) {\n-\t\ttests.innerHTML = \"\";\n-\t}\n-\n-\tif ( banner ) {\n-\t\tbanner.className = \"\";\n-\t}\n-\n-\tif ( result ) {\n-\t\tresult.parentNode.removeChild( result );\n-\t}\n-\n-\tif ( tests ) {\n-\t\tresult = document.createElement( \"p\" );\n-\t\tresult.id = \"qunit-testresult\";\n-\t\tresult.className = \"result\";\n-\t\ttests.parentNode.insertBefore( result, tests );\n-\t\tresult.innerHTML = \"Running...<br />&#160;\";\n-\t}\n-};\n+import QUnit, { config, defined, urlParams } from \"../src/core\";","path":"reporter/html.js","position":59,"original_position":59,"commit_id":"f91fe2fcd169d3450d5fe5986a5dc3f8a3860873","original_commit_id":"f91fe2fcd169d3450d5fe5986a5dc3f8a3860873","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"body":"Maybe we shouldn't define the reporter as a ES6 module? Its supposed to use the public/global API exported by QUnit, not the core module itself.","created_at":"2015-02-06T18:00:21Z","updated_at":"2015-02-06T18:00:21Z","html_url":"https://github.com/jquery/qunit/pull/735#discussion_r24258475","pull_request_url":"https://api.github.com/repos/jquery/qunit/pulls/735","_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/24258475"},"html":{"href":"https://github.com/jquery/qunit/pull/735#discussion_r24258475"},"pull_request":{"href":"https://api.github.com/repos/jquery/qunit/pulls/735"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/735","id":27681482,"html_url":"https://github.com/jquery/qunit/pull/735","diff_url":"https://github.com/jquery/qunit/pull/735.diff","patch_url":"https://github.com/jquery/qunit/pull/735.patch","issue_url":"https://api.github.com/repos/jquery/qunit/issues/735","number":735,"state":"open","locked":false,"title":"[WIP]: ES6 Modules","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"This is a WIP.\r\n\r\nI've tried to set everything in ES6 modules, which showed to be more difficult than I thought with all the interdependencies in our code.\r\n\r\nCurrently, we need to make every module true independent, with that we can achieve the desired progress in this PR.\r\n\r\nAlso, the Browserify with 6to5 plugins aren't working as I expected. Bundling things still get then to use a require system, which I'm not aiming. \r\n\r\nI'll follow @jzaefferer's suggestion and try http://jspm.io/\r\n","created_at":"2015-01-20T14:33:40Z","updated_at":"2015-02-06T18:00:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b61baa361fa74e717c0a7b08c978a12efb85e3d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/qunit/pulls/735/commits","review_comments_url":"https://api.github.com/repos/jquery/qunit/pulls/735/comments","review_comment_url":"https://api.github.com/repos/jquery/qunit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/735/comments","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/f91fe2fcd169d3450d5fe5986a5dc3f8a3860873","head":{"label":"leobalter:707-es6-modules","ref":"707-es6-modules","sha":"f91fe2fcd169d3450d5fe5986a5dc3f8a3860873","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"repo":{"id":15093934,"name":"qunit","full_name":"leobalter/qunit","owner":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leobalter/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/leobalter/qunit","forks_url":"https://api.github.com/repos/leobalter/qunit/forks","keys_url":"https://api.github.com/repos/leobalter/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leobalter/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leobalter/qunit/teams","hooks_url":"https://api.github.com/repos/leobalter/qunit/hooks","issue_events_url":"https://api.github.com/repos/leobalter/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/leobalter/qunit/events","assignees_url":"https://api.github.com/repos/leobalter/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/leobalter/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/leobalter/qunit/tags","blobs_url":"https://api.github.com/repos/leobalter/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leobalter/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leobalter/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/leobalter/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leobalter/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/leobalter/qunit/languages","stargazers_url":"https://api.github.com/repos/leobalter/qunit/stargazers","contributors_url":"https://api.github.com/repos/leobalter/qunit/contributors","subscribers_url":"https://api.github.com/repos/leobalter/qunit/subscribers","subscription_url":"https://api.github.com/repos/leobalter/qunit/subscription","commits_url":"https://api.github.com/repos/leobalter/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/leobalter/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/leobalter/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/leobalter/qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/leobalter/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/leobalter/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leobalter/qunit/merges","archive_url":"https://api.github.com/repos/leobalter/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leobalter/qunit/downloads","issues_url":"https://api.github.com/repos/leobalter/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/leobalter/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/leobalter/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/leobalter/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leobalter/qunit/labels{/name}","releases_url":"https://api.github.com/repos/leobalter/qunit/releases{/id}","created_at":"2013-12-11T00:34:30Z","updated_at":"2015-02-02T17:28:19Z","pushed_at":"2015-02-06T17:51:29Z","git_url":"git://github.com/leobalter/qunit.git","ssh_url":"git@github.com:leobalter/qunit.git","clone_url":"https://github.com/leobalter/qunit.git","svn_url":"https://github.com/leobalter/qunit","homepage":"http://qunitjs.com","size":2078,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"6733398db8811fb839e9c81fc8119ba357e1f6b2","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"jquery/qunit","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/jquery/qunit","forks_url":"https://api.github.com/repos/jquery/qunit/forks","keys_url":"https://api.github.com/repos/jquery/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/qunit/teams","hooks_url":"https://api.github.com/repos/jquery/qunit/hooks","issue_events_url":"https://api.github.com/repos/jquery/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/qunit/events","assignees_url":"https://api.github.com/repos/jquery/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/qunit/tags","blobs_url":"https://api.github.com/repos/jquery/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/qunit/languages","stargazers_url":"https://api.github.com/repos/jquery/qunit/stargazers","contributors_url":"https://api.github.com/repos/jquery/qunit/contributors","subscribers_url":"https://api.github.com/repos/jquery/qunit/subscribers","subscription_url":"https://api.github.com/repos/jquery/qunit/subscription","commits_url":"https://api.github.com/repos/jquery/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/qunit/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/qunit/merges","archive_url":"https://api.github.com/repos/jquery/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/qunit/downloads","issues_url":"https://api.github.com/repos/jquery/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/qunit/labels{/name}","releases_url":"https://api.github.com/repos/jquery/qunit/releases{/id}","created_at":"2009-07-24T16:26:23Z","updated_at":"2015-02-06T17:51:24Z","pushed_at":"2015-02-06T17:51:24Z","git_url":"git://github.com/jquery/qunit.git","ssh_url":"git@github.com:jquery/qunit.git","clone_url":"https://github.com/jquery/qunit.git","svn_url":"https://github.com/jquery/qunit","homepage":"http://qunitjs.com","size":4160,"stargazers_count":3098,"watchers_count":3098,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":616,"mirror_url":null,"open_issues_count":50,"forks":616,"open_issues":50,"watchers":3098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/735"},"html":{"href":"https://github.com/jquery/qunit/pull/735"},"issue":{"href":"https://api.github.com/repos/jquery/qunit/issues/735"},"comments":{"href":"https://api.github.com/repos/jquery/qunit/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/qunit/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/qunit/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/qunit/statuses/f91fe2fcd169d3450d5fe5986a5dc3f8a3860873"}}}}