{"action":"created","issue":{"url":"https://api.github.com/repos/lampepfl/dotty/issues/678","labels_url":"https://api.github.com/repos/lampepfl/dotty/issues/678/labels{/name}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/678/comments","events_url":"https://api.github.com/repos/lampepfl/dotty/issues/678/events","html_url":"https://github.com/lampepfl/dotty/pull/678","id":90049553,"number":678,"title":"Avoid junk produced by Constraint#replace.","user":{"login":"odersky","id":795990,"avatar_url":"https://avatars.githubusercontent.com/u/795990?v=3","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-22T09:10:32Z","updated_at":"2015-06-23T02:23:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/678","html_url":"https://github.com/lampepfl/dotty/pull/678","diff_url":"https://github.com/lampepfl/dotty/pull/678.diff","patch_url":"https://github.com/lampepfl/dotty/pull/678.patch"},"body":"There were two instances where a constraint undergoing a replace would still refer\r\nto poly params that are no longer bound after the replace.\r\n\r\n1. In an ordering the replaced parameter was not removed from the bounds of the others.\r\n2. When a parameter refers to the replaced parameter in a type, (not a TypeBounds), the\r\nreplaced parameter was not replaced.\r\n\r\nWe now have checking in place that in globally committable typer states, TypeVars are not instantiated\r\nto PolyParams and (configurable) that constraints of such typer states are always closed.\r\n\r\nFixes #670. Review by @retronym "},"comment":{"url":"https://api.github.com/repos/lampepfl/dotty/issues/comments/114331456","html_url":"https://github.com/lampepfl/dotty/pull/678#issuecomment-114331456","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/678","id":114331456,"user":{"login":"retronym","id":65551,"avatar_url":"https://avatars.githubusercontent.com/u/65551?v=3","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T02:23:41Z","updated_at":"2015-06-23T02:23:41Z","body":"The commit comment has a few lines longer than the git convention, makes it hard to read in the GitHub UI."}}