{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26690580","id":26690580,"diff_hunk":"@@ -0,0 +1,42 @@\n+/*\n+Copyright 2015 Google Inc. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package container\n+\n+import (\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/api\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/volume\"\n+)\n+\n+// Runtime interface defines the interfaces that should be implemented\n+// by a container runtime.\n+type Runtime interface {\n+\t// Version returns a map of version information of the container runtime.\n+\tVersion() (map[string]string, error)\n+\t// ListPods returns a list of Pod. The boolean parameter specifies whether\n+\t// the runtime returns all pods including those already exited and dead pods(used\n+\t// for garbage collection).\n+\tListPods(all bool) ([]*api.Pod, error)","path":"pkg/kubelet/container/runtime.go","position":32,"original_position":32,"commit_id":"26f061d7f7f416c62b3ebe76af904d6ce4643ab0","original_commit_id":"26f061d7f7f416c62b3ebe76af904d6ce4643ab0","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"We also usually need to keep around a dead container for its logs and to find out how it ended (idk how Rocket handles that)","created_at":"2015-03-18T18:09:27Z","updated_at":"2015-03-18T18:09:27Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572#discussion_r26690580","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26690580"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572#discussion_r26690580"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572","id":31387108,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5572","number":5572,"state":"open","locked":false,"title":"Add container runtime","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"Split the PR of #5518.\r\n\r\nThis is an attempt to introduce container runtime interface. \r\n\r\nSome pieces are missing, (image pulling part, which I will try to fill out in the next couple of days)\r\nThe runtime cache is just copy-pasted from the docker cache, (I think we can refactor that piece later).\r\n\r\nThe interface fits rocket's model well, though by now we cannot handle `RunContainerInPod` / `KillContainerInPod` efficiently. But I think there is a plan to get that point soon.\r\n\r\nFor the docker part, I am now trying to hide the `docker.GetKubeletDockerContainers` with `ListPods`. And will try to see if we can hide other docker code in the kubelet with the interface.\r\n\r\nFeedback welcome! Thank you!\r\n\r\n@dchen1107 ","created_at":"2015-03-17T23:08:46Z","updated_at":"2015-03-18T18:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28ebecb912d0cbc6757db885f4d8c1ffe8b61581","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5572/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/26f061d7f7f416c62b3ebe76af904d6ce4643ab0","head":{"label":"yifan-gu:rkt_support","ref":"rkt_support","sha":"26f061d7f7f416c62b3ebe76af904d6ce4643ab0","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"repo":{"id":21830645,"name":"kubernetes","full_name":"yifan-gu/kubernetes","owner":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yifan-gu/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/yifan-gu/kubernetes","forks_url":"https://api.github.com/repos/yifan-gu/kubernetes/forks","keys_url":"https://api.github.com/repos/yifan-gu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yifan-gu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yifan-gu/kubernetes/teams","hooks_url":"https://api.github.com/repos/yifan-gu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/yifan-gu/kubernetes/events","assignees_url":"https://api.github.com/repos/yifan-gu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/yifan-gu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/yifan-gu/kubernetes/tags","blobs_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yifan-gu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/yifan-gu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/yifan-gu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/yifan-gu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/yifan-gu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/yifan-gu/kubernetes/subscription","commits_url":"https://api.github.com/repos/yifan-gu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/yifan-gu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/yifan-gu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/yifan-gu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yifan-gu/kubernetes/merges","archive_url":"https://api.github.com/repos/yifan-gu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yifan-gu/kubernetes/downloads","issues_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/yifan-gu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/yifan-gu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/yifan-gu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yifan-gu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/yifan-gu/kubernetes/releases{/id}","created_at":"2014-07-14T18:29:14Z","updated_at":"2015-02-12T18:54:51Z","pushed_at":"2015-03-18T18:06:13Z","git_url":"git://github.com/yifan-gu/kubernetes.git","ssh_url":"git@github.com:yifan-gu/kubernetes.git","clone_url":"https://github.com/yifan-gu/kubernetes.git","svn_url":"https://github.com/yifan-gu/kubernetes","homepage":null,"size":36578,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"e92067d102cb5764717f16c1793f0dc308e8436a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-18T18:06:45Z","pushed_at":"2015-03-18T18:06:45Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":106220,"stargazers_count":6638,"watchers_count":6638,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1232,"mirror_url":null,"open_issues_count":758,"forks":1232,"open_issues":758,"watchers":6638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5572"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5572"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5572/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5572/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/26f061d7f7f416c62b3ebe76af904d6ce4643ab0"}}}}