{"action":"created","comment":{"url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/comments/48061208","id":48061208,"diff_hunk":"@@ -313,7 +320,7 @@ module.exports = class LiterallyCanvas\n     return unless shapes.length\n     drawShapes = =>\n       for shape in shapes\n-        renderShapeToContext(ctx, shape, {retryCallback})\n+        shape.draw(ctx, { retryCallback })","path":"src/core/LiterallyCanvas.coffee","position":59,"original_position":59,"commit_id":"3d41df0bf1ed0f33b0cb3f8f257d2d38bb211a54","original_commit_id":"3d41df0bf1ed0f33b0cb3f8f257d2d38bb211a54","user":{"login":"MandaBrown","id":1527103,"avatar_url":"https://avatars.githubusercontent.com/u/1527103?v=3","gravatar_id":"","url":"https://api.github.com/users/MandaBrown","html_url":"https://github.com/MandaBrown","followers_url":"https://api.github.com/users/MandaBrown/followers","following_url":"https://api.github.com/users/MandaBrown/following{/other_user}","gists_url":"https://api.github.com/users/MandaBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/MandaBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MandaBrown/subscriptions","organizations_url":"https://api.github.com/users/MandaBrown/orgs","repos_url":"https://api.github.com/users/MandaBrown/repos","events_url":"https://api.github.com/users/MandaBrown/events{/privacy}","received_events_url":"https://api.github.com/users/MandaBrown/received_events","type":"User","site_admin":false},"body":"Yep! That was why I used shape.draw instead of renderShapeToContext! I guess I had the direction of that backwards :)","created_at":"2015-12-18T19:36:42Z","updated_at":"2015-12-18T19:36:42Z","html_url":"https://github.com/literallycanvas/literallycanvas/pull/346#discussion_r48061208","pull_request_url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/comments/48061208"},"html":{"href":"https://github.com/literallycanvas/literallycanvas/pull/346#discussion_r48061208"},"pull_request":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346","id":53923708,"html_url":"https://github.com/literallycanvas/literallycanvas/pull/346","diff_url":"https://github.com/literallycanvas/literallycanvas/pull/346.diff","patch_url":"https://github.com/literallycanvas/literallycanvas/pull/346.patch","issue_url":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/346","number":346,"state":"open","locked":false,"title":"Shape Selection And Move","user":{"login":"MandaBrown","id":1527103,"avatar_url":"https://avatars.githubusercontent.com/u/1527103?v=3","gravatar_id":"","url":"https://api.github.com/users/MandaBrown","html_url":"https://github.com/MandaBrown","followers_url":"https://api.github.com/users/MandaBrown/followers","following_url":"https://api.github.com/users/MandaBrown/following{/other_user}","gists_url":"https://api.github.com/users/MandaBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/MandaBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MandaBrown/subscriptions","organizations_url":"https://api.github.com/users/MandaBrown/orgs","repos_url":"https://api.github.com/users/MandaBrown/repos","events_url":"https://api.github.com/users/MandaBrown/events{/privacy}","received_events_url":"https://api.github.com/users/MandaBrown/received_events","type":"User","site_admin":false},"body":"Connects to #246 \r\n\r\n![core-demo-select](https://cloud.githubusercontent.com/assets/1527103/11858832/2fc62594-a433-11e5-9daa-5194fee913ba.gif)\r\n\r\nThis PR adds the ability to select and move a shape (no ReactGUI for it yet, so I've only added it to the core demo page). \r\n\r\nSome things: \r\n  - This is not currently an undoable action. It would be good to make this an action in the future, but not for every step of the way, just start and end.\r\n  - I'm currently using the bounding rectangle as the 'select area' for each shape. I like this because for the whiteboard application that I'm working on we want something simple and this way you don't have to get fiddly with little bits to select something and move it out of the way. An earlier implementation was closer to shape outlines, so if you had transparent shapes you could select what's underneath them by clicking the visible bits, etc, by having each shape draw itself exactly on the select canvas (but in the proper color). I don't know which way we want the main library to go though, so let me know if the bounding rectangle select area isn't ok for now :)","created_at":"2015-12-17T01:30:43Z","updated_at":"2015-12-18T19:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a012770e2042fe9349706f4d06d3bbc302582c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346/commits","review_comments_url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346/comments","review_comment_url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/346/comments","statuses_url":"https://api.github.com/repos/literallycanvas/literallycanvas/statuses/3d41df0bf1ed0f33b0cb3f8f257d2d38bb211a54","head":{"label":"thinkthroughmath:manda/shape-selection-and-move","ref":"manda/shape-selection-and-move","sha":"3d41df0bf1ed0f33b0cb3f8f257d2d38bb211a54","user":{"login":"thinkthroughmath","id":1226388,"avatar_url":"https://avatars.githubusercontent.com/u/1226388?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkthroughmath","html_url":"https://github.com/thinkthroughmath","followers_url":"https://api.github.com/users/thinkthroughmath/followers","following_url":"https://api.github.com/users/thinkthroughmath/following{/other_user}","gists_url":"https://api.github.com/users/thinkthroughmath/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkthroughmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkthroughmath/subscriptions","organizations_url":"https://api.github.com/users/thinkthroughmath/orgs","repos_url":"https://api.github.com/users/thinkthroughmath/repos","events_url":"https://api.github.com/users/thinkthroughmath/events{/privacy}","received_events_url":"https://api.github.com/users/thinkthroughmath/received_events","type":"Organization","site_admin":false},"repo":{"id":44835331,"name":"literallycanvas","full_name":"thinkthroughmath/literallycanvas","owner":{"login":"thinkthroughmath","id":1226388,"avatar_url":"https://avatars.githubusercontent.com/u/1226388?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkthroughmath","html_url":"https://github.com/thinkthroughmath","followers_url":"https://api.github.com/users/thinkthroughmath/followers","following_url":"https://api.github.com/users/thinkthroughmath/following{/other_user}","gists_url":"https://api.github.com/users/thinkthroughmath/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkthroughmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkthroughmath/subscriptions","organizations_url":"https://api.github.com/users/thinkthroughmath/orgs","repos_url":"https://api.github.com/users/thinkthroughmath/repos","events_url":"https://api.github.com/users/thinkthroughmath/events{/privacy}","received_events_url":"https://api.github.com/users/thinkthroughmath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thinkthroughmath/literallycanvas","description":"A canvas in your browser. Literally.","fork":true,"url":"https://api.github.com/repos/thinkthroughmath/literallycanvas","forks_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/forks","keys_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/teams","hooks_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/hooks","issue_events_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/issues/events{/number}","events_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/events","assignees_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/assignees{/user}","branches_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/branches{/branch}","tags_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/tags","blobs_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/statuses/{sha}","languages_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/languages","stargazers_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/stargazers","contributors_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/contributors","subscribers_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/subscribers","subscription_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/subscription","commits_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/contents/{+path}","compare_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/merges","archive_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/downloads","issues_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/issues{/number}","pulls_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/pulls{/number}","milestones_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/milestones{/number}","notifications_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/labels{/name}","releases_url":"https://api.github.com/repos/thinkthroughmath/literallycanvas/releases{/id}","created_at":"2015-10-23T19:55:56Z","updated_at":"2015-10-23T19:55:58Z","pushed_at":"2015-12-17T01:39:29Z","git_url":"git://github.com/thinkthroughmath/literallycanvas.git","ssh_url":"git@github.com:thinkthroughmath/literallycanvas.git","clone_url":"https://github.com/thinkthroughmath/literallycanvas.git","svn_url":"https://github.com/thinkthroughmath/literallycanvas","homepage":"http://www.literallycanvas.com/","size":2424,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"literallycanvas:master","ref":"master","sha":"f5a6099c34df1c614560b312adcd2019f9267b3a","user":{"login":"literallycanvas","id":2866606,"avatar_url":"https://avatars.githubusercontent.com/u/2866606?v=3","gravatar_id":"","url":"https://api.github.com/users/literallycanvas","html_url":"https://github.com/literallycanvas","followers_url":"https://api.github.com/users/literallycanvas/followers","following_url":"https://api.github.com/users/literallycanvas/following{/other_user}","gists_url":"https://api.github.com/users/literallycanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/literallycanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/literallycanvas/subscriptions","organizations_url":"https://api.github.com/users/literallycanvas/orgs","repos_url":"https://api.github.com/users/literallycanvas/repos","events_url":"https://api.github.com/users/literallycanvas/events{/privacy}","received_events_url":"https://api.github.com/users/literallycanvas/received_events","type":"Organization","site_admin":false},"repo":{"id":6635074,"name":"literallycanvas","full_name":"literallycanvas/literallycanvas","owner":{"login":"literallycanvas","id":2866606,"avatar_url":"https://avatars.githubusercontent.com/u/2866606?v=3","gravatar_id":"","url":"https://api.github.com/users/literallycanvas","html_url":"https://github.com/literallycanvas","followers_url":"https://api.github.com/users/literallycanvas/followers","following_url":"https://api.github.com/users/literallycanvas/following{/other_user}","gists_url":"https://api.github.com/users/literallycanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/literallycanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/literallycanvas/subscriptions","organizations_url":"https://api.github.com/users/literallycanvas/orgs","repos_url":"https://api.github.com/users/literallycanvas/repos","events_url":"https://api.github.com/users/literallycanvas/events{/privacy}","received_events_url":"https://api.github.com/users/literallycanvas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/literallycanvas/literallycanvas","description":"A canvas in your browser. Literally.","fork":false,"url":"https://api.github.com/repos/literallycanvas/literallycanvas","forks_url":"https://api.github.com/repos/literallycanvas/literallycanvas/forks","keys_url":"https://api.github.com/repos/literallycanvas/literallycanvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/literallycanvas/literallycanvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/literallycanvas/literallycanvas/teams","hooks_url":"https://api.github.com/repos/literallycanvas/literallycanvas/hooks","issue_events_url":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/events{/number}","events_url":"https://api.github.com/repos/literallycanvas/literallycanvas/events","assignees_url":"https://api.github.com/repos/literallycanvas/literallycanvas/assignees{/user}","branches_url":"https://api.github.com/repos/literallycanvas/literallycanvas/branches{/branch}","tags_url":"https://api.github.com/repos/literallycanvas/literallycanvas/tags","blobs_url":"https://api.github.com/repos/literallycanvas/literallycanvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/literallycanvas/literallycanvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/literallycanvas/literallycanvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/literallycanvas/literallycanvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/literallycanvas/literallycanvas/statuses/{sha}","languages_url":"https://api.github.com/repos/literallycanvas/literallycanvas/languages","stargazers_url":"https://api.github.com/repos/literallycanvas/literallycanvas/stargazers","contributors_url":"https://api.github.com/repos/literallycanvas/literallycanvas/contributors","subscribers_url":"https://api.github.com/repos/literallycanvas/literallycanvas/subscribers","subscription_url":"https://api.github.com/repos/literallycanvas/literallycanvas/subscription","commits_url":"https://api.github.com/repos/literallycanvas/literallycanvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/literallycanvas/literallycanvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/literallycanvas/literallycanvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/literallycanvas/literallycanvas/contents/{+path}","compare_url":"https://api.github.com/repos/literallycanvas/literallycanvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/literallycanvas/literallycanvas/merges","archive_url":"https://api.github.com/repos/literallycanvas/literallycanvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/literallycanvas/literallycanvas/downloads","issues_url":"https://api.github.com/repos/literallycanvas/literallycanvas/issues{/number}","pulls_url":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls{/number}","milestones_url":"https://api.github.com/repos/literallycanvas/literallycanvas/milestones{/number}","notifications_url":"https://api.github.com/repos/literallycanvas/literallycanvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/literallycanvas/literallycanvas/labels{/name}","releases_url":"https://api.github.com/repos/literallycanvas/literallycanvas/releases{/id}","created_at":"2012-11-11T03:18:21Z","updated_at":"2015-12-15T23:36:07Z","pushed_at":"2015-12-17T01:39:29Z","git_url":"git://github.com/literallycanvas/literallycanvas.git","ssh_url":"git@github.com:literallycanvas/literallycanvas.git","clone_url":"https://github.com/literallycanvas/literallycanvas.git","svn_url":"https://github.com/literallycanvas/literallycanvas","homepage":"http://www.literallycanvas.com/","size":3947,"stargazers_count":393,"watchers_count":393,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":37,"forks":124,"open_issues":37,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346"},"html":{"href":"https://github.com/literallycanvas/literallycanvas/pull/346"},"issue":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/346"},"comments":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/literallycanvas/literallycanvas/statuses/3d41df0bf1ed0f33b0cb3f8f257d2d38bb211a54"}}}}