{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/23362983","id":23362983,"diff_hunk":"@@ -1409,7 +1409,23 @@ instance.web.View = instance.web.Widget.extend({\n     do_search: function(domain, context, group_by) {\n     },\n     on_sidebar_export: function() {\n-        new instance.web.DataExport(this, this.dataset).open();\n+        var selected_ids = this.get_selected_ids();\n+        if (selected_ids.length == 0) {\n+            return this.do_warn(_t(\"Warning\"), _t(\"You must select at least one record.\"));\n+        }\n+        this.do_action({\n+            type: 'ir.actions.client',\n+            tag: 'export',\n+            flags: {new_window: true},\n+            params: {\n+                model: this.dataset.model || \"\",\n+                dataset: this.dataset || [],\n+                domain: this.get_active_domain() || [],\n+                selected_ids: selected_ids || \"\",","path":"addons/web/static/src/js/views.js","position":17,"original_position":17,"commit_id":"c74a06dde1ad16396fc405dedf8676ec7311e181","original_commit_id":"c74a06dde1ad16396fc405dedf8676ec7311e181","user":{"login":"vme-odoo","id":7599826,"avatar_url":"https://avatars.githubusercontent.com/u/7599826?v=3","gravatar_id":"","url":"https://api.github.com/users/vme-odoo","html_url":"https://github.com/vme-odoo","followers_url":"https://api.github.com/users/vme-odoo/followers","following_url":"https://api.github.com/users/vme-odoo/following{/other_user}","gists_url":"https://api.github.com/users/vme-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/vme-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vme-odoo/subscriptions","organizations_url":"https://api.github.com/users/vme-odoo/orgs","repos_url":"https://api.github.com/users/vme-odoo/repos","events_url":"https://api.github.com/users/vme-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/vme-odoo/received_events","type":"User","site_admin":false},"body":"seletected_ids || []","created_at":"2015-01-22T09:16:12Z","updated_at":"2015-01-22T09:16:12Z","html_url":"https://github.com/odoo/odoo/pull/2244#discussion_r23362983","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/2244","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/23362983"},"html":{"href":"https://github.com/odoo/odoo/pull/2244#discussion_r23362983"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/2244"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/2244","id":20876344,"html_url":"https://github.com/odoo/odoo/pull/2244","diff_url":"https://github.com/odoo/odoo/pull/2244.diff","patch_url":"https://github.com/odoo/odoo/pull/2244.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/2244","number":2244,"state":"open","locked":false,"title":"[IMP] Export Wizard New Look","user":{"login":"rba-odoo","id":7599745,"avatar_url":"https://avatars.githubusercontent.com/u/7599745?v=3","gravatar_id":"","url":"https://api.github.com/users/rba-odoo","html_url":"https://github.com/rba-odoo","followers_url":"https://api.github.com/users/rba-odoo/followers","following_url":"https://api.github.com/users/rba-odoo/following{/other_user}","gists_url":"https://api.github.com/users/rba-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/rba-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rba-odoo/subscriptions","organizations_url":"https://api.github.com/users/rba-odoo/orgs","repos_url":"https://api.github.com/users/rba-odoo/repos","events_url":"https://api.github.com/users/rba-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/rba-odoo/received_events","type":"User","site_admin":false},"body":"hello,\r\nI have improved design using bootstrap in export wizard, changed Export Wizard Dialogue box class to Widget class.\r\n\r\nMore Details:\r\nTask: https://www.odoo.com/web#id=8651&view_type=form&model=project.task&menu_id=3942&action=327\r\nPad: https://pad.odoo.com/p/r.mpua9w4G7VMVj4tD\r\n\r\nthanks\r\nrba-odoo","created_at":"2014-09-08T08:40:35Z","updated_at":"2015-01-22T09:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f549beaa639b33b34646fb61a7415eb5ca5c10da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/2244/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/2244/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/2244/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/c74a06dde1ad16396fc405dedf8676ec7311e181","head":{"label":"odoo-dev:master-new_design_export_wizard-rba","ref":"master-new_design_export_wizard-rba","sha":"c74a06dde1ad16396fc405dedf8676ec7311e181","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-01-15T06:11:53Z","pushed_at":"2015-01-22T09:14:10Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":984754,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":38,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"46162bd6a2ade8dcf0480700f8abb9fd4fb33d14","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-01-22T08:37:15Z","pushed_at":"2015-01-21T17:34:25Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1026939,"stargazers_count":1855,"watchers_count":1855,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1510,"mirror_url":null,"open_issues_count":1628,"forks":1510,"open_issues":1628,"watchers":1855,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/2244"},"html":{"href":"https://github.com/odoo/odoo/pull/2244"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/2244"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/2244/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/2244/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/2244/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/c74a06dde1ad16396fc405dedf8676ec7311e181"}}}}