{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/45353947","id":45353947,"diff_hunk":"@@ -162,19 +164,23 @@ namespace feature\n \n       {\n         FileWriter w = m_writer.GetWriter(METADATA_INDEX_FILE_TAG);\n-        for (auto const & v : m_MetadataIndex)\n+        for (auto const & v : m_metadataIndex)\n         {\n           WriteToSink(w, v.key);\n           WriteToSink(w, v.value);\n         }\n       }\n \n-      m_MetadataWriter->Flush();\n-      m_writer.Write(m_MetadataWriter->GetName(), METADATA_FILE_TAG);\n+      m_metadataWriter->Flush();\n+      m_writer.Write(m_metadataWriter->GetName(), METADATA_FILE_TAG);\n+\n+      m_searchTokensWriter->Flush();\n+      m_writer.Write(m_searchTokensWriter->GetName(), SEARCH_TOKENS_FILE_TAG);\n \n       m_writer.Finish();\n \n-      FileWriter::DeleteFileX(m_MetadataWriter->GetName());\n+      FileWriter::DeleteFileX(m_metadataWriter->GetName());","path":"generator/feature_sorter.cpp","position":61,"original_position":51,"commit_id":"63ceada6c173cd47ed7ae6ff907cc4facfd796f5","original_commit_id":"07fa1105e51af2862c3330f948f3cc16d8803fd7","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"body":"Тут не заморачивался с гуардами и прочее ибо помимо этого, прямо в этом деструкторе еще десятки мест где при выбросе исключения много чего останется. Это генератор и если уж что и случится, то все равно мы слетим. А расстановка гуардов только сделает код страшнее обилием новых блоков {}, ибо важна последовательность выполнения.","created_at":"2015-11-19T15:25:43Z","updated_at":"2015-11-19T15:25:43Z","html_url":"https://github.com/mapsme/omim/pull/566#discussion_r45353947","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/566","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/45353947"},"html":{"href":"https://github.com/mapsme/omim/pull/566#discussion_r45353947"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/566","id":50969005,"html_url":"https://github.com/mapsme/omim/pull/566","diff_url":"https://github.com/mapsme/omim/pull/566.diff","patch_url":"https://github.com/mapsme/omim/pull/566.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/566","number":566,"state":"open","locked":false,"title":"[generator] Pass address tokens to the search index generation step.","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"body":"На примере Беларуси поисковый индекс вырос с 8 до 12 Mb.\r\nПока делайте ревью, попробую сделать еще урезку токенов типа \"ул\", \"улица\". Пока же такая статистика не очень радует.\r\nВозможно, где-то в коде есть ошибка и тянется много лишнего.","created_at":"2015-11-17T16:26:47Z","updated_at":"2015-11-19T15:25:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e4cc5a7a0d80275dff4f3c84bbc2e206e9c5ab9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/566/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/566/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/566/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/63ceada6c173cd47ed7ae6ff907cc4facfd796f5","head":{"label":"vng:ns","ref":"ns","sha":"63ceada6c173cd47ed7ae6ff907cc4facfd796f5","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"repo":{"id":43431189,"name":"omim","full_name":"vng/omim","owner":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vng/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/vng/omim","forks_url":"https://api.github.com/repos/vng/omim/forks","keys_url":"https://api.github.com/repos/vng/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vng/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vng/omim/teams","hooks_url":"https://api.github.com/repos/vng/omim/hooks","issue_events_url":"https://api.github.com/repos/vng/omim/issues/events{/number}","events_url":"https://api.github.com/repos/vng/omim/events","assignees_url":"https://api.github.com/repos/vng/omim/assignees{/user}","branches_url":"https://api.github.com/repos/vng/omim/branches{/branch}","tags_url":"https://api.github.com/repos/vng/omim/tags","blobs_url":"https://api.github.com/repos/vng/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vng/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vng/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/vng/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vng/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/vng/omim/languages","stargazers_url":"https://api.github.com/repos/vng/omim/stargazers","contributors_url":"https://api.github.com/repos/vng/omim/contributors","subscribers_url":"https://api.github.com/repos/vng/omim/subscribers","subscription_url":"https://api.github.com/repos/vng/omim/subscription","commits_url":"https://api.github.com/repos/vng/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/vng/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/vng/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/vng/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/vng/omim/contents/{+path}","compare_url":"https://api.github.com/repos/vng/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vng/omim/merges","archive_url":"https://api.github.com/repos/vng/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vng/omim/downloads","issues_url":"https://api.github.com/repos/vng/omim/issues{/number}","pulls_url":"https://api.github.com/repos/vng/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/vng/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/vng/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vng/omim/labels{/name}","releases_url":"https://api.github.com/repos/vng/omim/releases{/id}","created_at":"2015-09-30T12:19:26Z","updated_at":"2015-09-30T12:21:35Z","pushed_at":"2015-11-19T12:56:46Z","git_url":"git://github.com/vng/omim.git","ssh_url":"git@github.com:vng/omim.git","clone_url":"https://github.com/vng/omim.git","svn_url":"https://github.com/vng/omim","homepage":null,"size":1843233,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:new-search","ref":"new-search","sha":"06923c2c29f8769d49685593598b7ca109659a17","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","created_at":"2015-09-20T02:57:13Z","updated_at":"2015-11-19T15:04:04Z","pushed_at":"2015-11-19T15:22:09Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":1876804,"stargazers_count":1485,"watchers_count":1485,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":69,"forks":175,"open_issues":69,"watchers":1485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/566"},"html":{"href":"https://github.com/mapsme/omim/pull/566"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/566"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/63ceada6c173cd47ed7ae6ff907cc4facfd796f5"}}}}