{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/23155279","id":23155279,"diff_hunk":"@@ -46,7 +46,7 @@\n       var subject = callParams.subject;\n       if (subject) {","path":"app/call_screen/js/call_screen_ui_minified.js","position":2,"original_position":2,"commit_id":"cdd74e4c27b3c15a9144d2a49f54dd5a9fad3841","original_commit_id":"cdd74e4c27b3c15a9144d2a49f54dd5a9fad3841","user":{"login":"borjasalguero","id":1785537,"avatar_url":"https://avatars.githubusercontent.com/u/1785537?v=3","gravatar_id":"","url":"https://api.github.com/users/borjasalguero","html_url":"https://github.com/borjasalguero","followers_url":"https://api.github.com/users/borjasalguero/followers","following_url":"https://api.github.com/users/borjasalguero/following{/other_user}","gists_url":"https://api.github.com/users/borjasalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/borjasalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borjasalguero/subscriptions","organizations_url":"https://api.github.com/users/borjasalguero/orgs","repos_url":"https://api.github.com/users/borjasalguero/repos","events_url":"https://api.github.com/users/borjasalguero/events{/privacy}","received_events_url":"https://api.github.com/users/borjasalguero/received_events","type":"User","site_admin":false},"body":"Could you check here if `subject` has any character? As this comes from the URL, it's going to be a String. So here we should check `if (subject && subject.trim().length > 0) {...`. Please add this in order to not adding the subject in every case, just when needed.","created_at":"2015-01-19T11:43:01Z","updated_at":"2015-01-19T11:43:01Z","html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462#discussion_r23155279","pull_request_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/23155279"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462#discussion_r23155279"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462","id":27492641,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462","diff_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462.diff","patch_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/462","number":462,"state":"open","locked":false,"title":"Bug 1122014 - [Loop] \"Undefined\" literal word,  in calls from Desktop. (without subject)","user":{"login":"frsela","id":1516442,"avatar_url":"https://avatars.githubusercontent.com/u/1516442?v=3","gravatar_id":"","url":"https://api.github.com/users/frsela","html_url":"https://github.com/frsela","followers_url":"https://api.github.com/users/frsela/followers","following_url":"https://api.github.com/users/frsela/following{/other_user}","gists_url":"https://api.github.com/users/frsela/gists{/gist_id}","starred_url":"https://api.github.com/users/frsela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frsela/subscriptions","organizations_url":"https://api.github.com/users/frsela/orgs","repos_url":"https://api.github.com/users/frsela/repos","events_url":"https://api.github.com/users/frsela/events{/privacy}","received_events_url":"https://api.github.com/users/frsela/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-16T09:18:37Z","updated_at":"2015-01-19T11:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2ad88b4c6f9f59bfa9d8bbbda8c8de4dbc9c7a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/462/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/cdd74e4c27b3c15a9144d2a49f54dd5a9fad3841","head":{"label":"frsela:Bug1122014","ref":"Bug1122014","sha":"cdd74e4c27b3c15a9144d2a49f54dd5a9fad3841","user":{"login":"frsela","id":1516442,"avatar_url":"https://avatars.githubusercontent.com/u/1516442?v=3","gravatar_id":"","url":"https://api.github.com/users/frsela","html_url":"https://github.com/frsela","followers_url":"https://api.github.com/users/frsela/followers","following_url":"https://api.github.com/users/frsela/following{/other_user}","gists_url":"https://api.github.com/users/frsela/gists{/gist_id}","starred_url":"https://api.github.com/users/frsela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frsela/subscriptions","organizations_url":"https://api.github.com/users/frsela/orgs","repos_url":"https://api.github.com/users/frsela/repos","events_url":"https://api.github.com/users/frsela/events{/privacy}","received_events_url":"https://api.github.com/users/frsela/received_events","type":"User","site_admin":false},"repo":{"id":21121013,"name":"firefoxos-loop-client","full_name":"frsela/firefoxos-loop-client","owner":{"login":"frsela","id":1516442,"avatar_url":"https://avatars.githubusercontent.com/u/1516442?v=3","gravatar_id":"","url":"https://api.github.com/users/frsela","html_url":"https://github.com/frsela","followers_url":"https://api.github.com/users/frsela/followers","following_url":"https://api.github.com/users/frsela/following{/other_user}","gists_url":"https://api.github.com/users/frsela/gists{/gist_id}","starred_url":"https://api.github.com/users/frsela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frsela/subscriptions","organizations_url":"https://api.github.com/users/frsela/orgs","repos_url":"https://api.github.com/users/frsela/repos","events_url":"https://api.github.com/users/frsela/events{/privacy}","received_events_url":"https://api.github.com/users/frsela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frsela/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":true,"url":"https://api.github.com/repos/frsela/firefoxos-loop-client","forks_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/frsela/firefoxos-loop-client/releases{/id}","created_at":"2014-06-23T09:39:23Z","updated_at":"2015-01-16T09:01:53Z","pushed_at":"2015-01-16T10:41:16Z","git_url":"git://github.com/frsela/firefoxos-loop-client.git","ssh_url":"git@github.com:frsela/firefoxos-loop-client.git","clone_url":"https://github.com/frsela/firefoxos-loop-client.git","svn_url":"https://github.com/frsela/firefoxos-loop-client","homepage":null,"size":17973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ccc98abf6519f7c625e23650b51b5a19fa0f075c","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":18225071,"name":"firefoxos-loop-client","full_name":"mozilla-b2g/firefoxos-loop-client","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client","forks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/releases{/id}","created_at":"2014-03-28T20:10:24Z","updated_at":"2015-01-19T11:37:38Z","pushed_at":"2015-01-19T11:37:38Z","git_url":"git://github.com/mozilla-b2g/firefoxos-loop-client.git","ssh_url":"git@github.com:mozilla-b2g/firefoxos-loop-client.git","clone_url":"https://github.com/mozilla-b2g/firefoxos-loop-client.git","svn_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","homepage":null,"size":15974,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":39,"forks":36,"open_issues":39,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/462"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/462"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/cdd74e4c27b3c15a9144d2a49f54dd5a9fad3841"}}}}