{"action":"created","issue":{"url":"https://api.github.com/repos/Qucs/qucs/issues/202","labels_url":"https://api.github.com/repos/Qucs/qucs/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/202/comments","events_url":"https://api.github.com/repos/Qucs/qucs/issues/202/events","html_url":"https://github.com/Qucs/qucs/pull/202","id":56087066,"number":202,"title":"qucsator : avoid taking a time step that will bring too close to a breakpoint.","user":{"login":"in3otd","id":9018179,"avatar_url":"https://avatars.githubusercontent.com/u/9018179?v=3","gravatar_id":"","url":"https://api.github.com/users/in3otd","html_url":"https://github.com/in3otd","followers_url":"https://api.github.com/users/in3otd/followers","following_url":"https://api.github.com/users/in3otd/following{/other_user}","gists_url":"https://api.github.com/users/in3otd/gists{/gist_id}","starred_url":"https://api.github.com/users/in3otd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in3otd/subscriptions","organizations_url":"https://api.github.com/users/in3otd/orgs","repos_url":"https://api.github.com/users/in3otd/repos","events_url":"https://api.github.com/users/in3otd/events{/privacy}","received_events_url":"https://api.github.com/users/in3otd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-30T21:29:07Z","updated_at":"2015-01-31T00:40:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/202","html_url":"https://github.com/Qucs/qucs/pull/202","diff_url":"https://github.com/Qucs/qucs/pull/202.diff","patch_url":"https://github.com/Qucs/qucs/pull/202.patch"},"body":"quick fix for #186 : the issue is related to the fact that for this particular simulation the internal time steps taken should have been submultiples of the user-requested time steps (print steps). In practice after some internal steps the simulator came very close, but not exactly on, to a print time step, probably due to numerical errors and then it attempted to take a very small time step (same order of magnitude as the machine precision) to reach the print step. This very small step likely caused to have companion circuits with extreme values.\r\nNow, in case a step will bring too close to a print step, it will be reduced so that the next step will be larger. Might not work with a lot of corner cases, but is good enough for the #186 circuit.\r\nWhile this passes all the `qucs-test` circuits, with no appreciable changes in the simulation time, it might not be the best solution, feel free to keep it on hold.\r\nAnd unfortunately it does not solve the transient simulation issues of the other known problematic circuits..."},"comment":{"url":"https://api.github.com/repos/Qucs/qucs/issues/comments/72294894","html_url":"https://github.com/Qucs/qucs/pull/202#issuecomment-72294894","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/202","id":72294894,"user":{"login":"guitorri","id":1388949,"avatar_url":"https://avatars.githubusercontent.com/u/1388949?v=3","gravatar_id":"","url":"https://api.github.com/users/guitorri","html_url":"https://github.com/guitorri","followers_url":"https://api.github.com/users/guitorri/followers","following_url":"https://api.github.com/users/guitorri/following{/other_user}","gists_url":"https://api.github.com/users/guitorri/gists{/gist_id}","starred_url":"https://api.github.com/users/guitorri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitorri/subscriptions","organizations_url":"https://api.github.com/users/guitorri/orgs","repos_url":"https://api.github.com/users/guitorri/repos","events_url":"https://api.github.com/users/guitorri/events{/privacy}","received_events_url":"https://api.github.com/users/guitorri/received_events","type":"User","site_admin":false},"created_at":"2015-01-31T00:40:21Z","updated_at":"2015-01-31T00:40:21Z","body":"Did you run also the `make check` locally? It is not clear which test is failing. Maybe the test assertion is too tight? \r\nThe qucs-test suite is passing which means that the results are consisted with previous version of Qucs..."}}