{"action":"closed","issue":{"url":"https://api.github.com/repos/4Com/compose-remoting/issues/18","labels_url":"https://api.github.com/repos/4Com/compose-remoting/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/4Com/compose-remoting/issues/18/comments","events_url":"https://api.github.com/repos/4Com/compose-remoting/issues/18/events","html_url":"https://github.com/4Com/compose-remoting/issues/18","id":89741099,"number":18,"title":"Removal of IF DEF for binary serialization?","user":{"login":"sblackler","id":775191,"avatar_url":"https://avatars.githubusercontent.com/u/775191?v=3","gravatar_id":"","url":"https://api.github.com/users/sblackler","html_url":"https://github.com/sblackler","followers_url":"https://api.github.com/users/sblackler/followers","following_url":"https://api.github.com/users/sblackler/following{/other_user}","gists_url":"https://api.github.com/users/sblackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sblackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sblackler/subscriptions","organizations_url":"https://api.github.com/users/sblackler/orgs","repos_url":"https://api.github.com/users/sblackler/repos","events_url":"https://api.github.com/users/sblackler/events{/privacy}","received_events_url":"https://api.github.com/users/sblackler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-20T08:51:54Z","updated_at":"2015-11-29T20:57:18Z","closed_at":"2015-11-29T20:57:18Z","body":"Currently, the exceptions we have are marked as Serializable to comply with a CA rule. However, this is attribute is not supported on the core frameworks due to the fact Binary serialization itself isnt supported.\r\n\r\nThe code currently looks like this: \r\n\r\n\tusing System;\r\n\tnamespace Compose.Remoting\r\n\t{\r\n\t#if !SerializationUnsupported\r\n\t\tusing System.Runtime.Serialization;\r\n\t\t[Serializable]\r\n\t#endif\r\n\t\tpublic class InvalidMessageException : Exception\r\n\r\nWhich has the `SerializationUnsupported` constant defined for `netcore45` & `dnxcore50`. There are three options: \r\n\r\n1. Leave the code as is - it's fine\r\n2. Suppress the CA rules in the classes affected and remove the constant\r\n3. Remove the code that's not compatible and let the CA throw\r\n\r\nI'm currently leaning towards option 2 as that will leave the code cleaner imo.\r\n\r\nThoughts: @smudge202 @mattridgway @herecydev ?"}}