{"action":"created","issue":{"url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/1063","labels_url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/1063/labels{/name}","comments_url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/1063/comments","events_url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/1063/events","html_url":"https://github.com/AsyncHttpClient/async-http-client/issues/1063","id":123057602,"number":1063,"title":"Grizzly: Value of keepAliveTimeout<=0 disables persistent connections","user":{"login":"dfeist","id":380765,"avatar_url":"https://avatars.githubusercontent.com/u/380765?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeist","html_url":"https://github.com/dfeist","followers_url":"https://api.github.com/users/dfeist/followers","following_url":"https://api.github.com/users/dfeist/following{/other_user}","gists_url":"https://api.github.com/users/dfeist/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeist/subscriptions","organizations_url":"https://api.github.com/users/dfeist/orgs","repos_url":"https://api.github.com/users/dfeist/repos","events_url":"https://api.github.com/users/dfeist/events{/privacy}","received_events_url":"https://api.github.com/users/dfeist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-19T03:06:19Z","updated_at":"2015-12-19T12:46:38Z","closed_at":null,"body":"IMO Instead of disabling persistent connections, this should instead just propagate the negative timeout to grizzly which will disable the KeepAliveCleaner such that connections don't timeout if idle, but not disable persistent connections completely in AHC as seems to be the case currently.\r\n\r\nIs it possible that this was introduced by mistake as part of the fix for https://github.com/AsyncHttpClient/async-http-client/issues/885? \r\n\r\n/cc @oleksiys "},"comment":{"url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/comments/165982114","html_url":"https://github.com/AsyncHttpClient/async-http-client/issues/1063#issuecomment-165982114","issue_url":"https://api.github.com/repos/AsyncHttpClient/async-http-client/issues/1063","id":165982114,"user":{"login":"dfeist","id":380765,"avatar_url":"https://avatars.githubusercontent.com/u/380765?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeist","html_url":"https://github.com/dfeist","followers_url":"https://api.github.com/users/dfeist/followers","following_url":"https://api.github.com/users/dfeist/following{/other_user}","gists_url":"https://api.github.com/users/dfeist/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeist/subscriptions","organizations_url":"https://api.github.com/users/dfeist/orgs","repos_url":"https://api.github.com/users/dfeist/repos","events_url":"https://api.github.com/users/dfeist/events{/privacy}","received_events_url":"https://api.github.com/users/dfeist/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T12:46:38Z","updated_at":"2015-12-19T12:46:38Z","body":"This change makes sense, but got two questions:\r\ni) Is it compatible with whats in org.glassfish.grizzly.connectionpool.SingleEndpointPool#release0?  Here keepAlive is only false if idleTimeout is 0 and pool is larger than coreSize. Might there be a situation where AHC is setting \"Connection: close\" but grizzly doesn't close connection because poolSize is greater than coreSize.\r\nii) Is the tri-state behaviour of attribute compatible with the netty implementation?"}}