{"action":"created","comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/39121932","id":39121932,"diff_hunk":"@@ -689,7 +692,10 @@ path.\"\n               (configuration-layer//get-latest-package-version-string\n                pkg-name)))\n       ;; (message \"%s: %s > %s ?\" pkg-name cur-version new-version)\n-      (version< cur-version new-version))))\n+      (if new-version\n+          (version< cur-version new-version)\n+        (cl-pushnew pkg-name configuration-layer--skipped-packages :test #'eq)","path":"core/core-configuration-layer.el","position":17,"original_position":17,"commit_id":"35ddd0ed64fe28c7514f1bdb6138d729afae93eb","original_commit_id":"35ddd0ed64fe28c7514f1bdb6138d729afae93eb","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"body":"Ok but in this particular case you use `:test ' eq` so I wonder what is the benefit over regular `add-to-list` which does basically this.","created_at":"2015-09-10T03:39:40Z","updated_at":"2015-09-10T03:39:40Z","html_url":"https://github.com/syl20bnr/spacemacs/pull/2819#discussion_r39121932","pull_request_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819","_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/39121932"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/2819#discussion_r39121932"},"pull_request":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819"}}},"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819","id":43690543,"html_url":"https://github.com/syl20bnr/spacemacs/pull/2819","diff_url":"https://github.com/syl20bnr/spacemacs/pull/2819.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/2819.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2819","number":2819,"state":"open","locked":false,"title":"Fix update error when a distant package is unavailable","user":{"login":"bmag","id":4334375,"avatar_url":"https://avatars.githubusercontent.com/u/4334375?v=3","gravatar_id":"","url":"https://api.github.com/users/bmag","html_url":"https://github.com/bmag","followers_url":"https://api.github.com/users/bmag/followers","following_url":"https://api.github.com/users/bmag/following{/other_user}","gists_url":"https://api.github.com/users/bmag/gists{/gist_id}","starred_url":"https://api.github.com/users/bmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmag/subscriptions","organizations_url":"https://api.github.com/users/bmag/orgs","repos_url":"https://api.github.com/users/bmag/repos","events_url":"https://api.github.com/users/bmag/events{/privacy}","received_events_url":"https://api.github.com/users/bmag/received_events","type":"User","site_admin":false},"body":"Instead of error, show a warning that the unavailable package(s) were\r\nskipped. This should handle situations were a package is temporarily\r\nunavailable from MELPA (or other sources).\r\n\r\nNote that it's possible that a package will be updated even if one of its dependencies has been skipped. For example, skipping `helm-core` won't cause `helm` to be skipped. That may be a problem sometimes, but the user can use the rollback mechanism when needed. I couldn't find a way to solve it without significantly messing around with the existing code.\r\n\r\nThis PR (partially?) solves (some of?) the following issues: #839 #2176 #2404 #2557 #2762 #2795\r\n","created_at":"2015-08-29T07:31:46Z","updated_at":"2015-09-10T03:39:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eefef057b6f10303e0ccc4bcf6b4fdfbde22ceae","assignee":null,"milestone":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones/3","html_url":"https://github.com/syl20bnr/spacemacs/milestones/release%200.104","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones/3/labels","id":1270590,"number":3,"title":"release 0.104","description":"","creator":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":20,"state":"open","created_at":"2015-08-25T00:22:26Z","updated_at":"2015-09-09T09:48:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2819/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/35ddd0ed64fe28c7514f1bdb6138d729afae93eb","head":{"label":"bmag:invalid-version-string","ref":"invalid-version-string","sha":"35ddd0ed64fe28c7514f1bdb6138d729afae93eb","user":{"login":"bmag","id":4334375,"avatar_url":"https://avatars.githubusercontent.com/u/4334375?v=3","gravatar_id":"","url":"https://api.github.com/users/bmag","html_url":"https://github.com/bmag","followers_url":"https://api.github.com/users/bmag/followers","following_url":"https://api.github.com/users/bmag/following{/other_user}","gists_url":"https://api.github.com/users/bmag/gists{/gist_id}","starred_url":"https://api.github.com/users/bmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmag/subscriptions","organizations_url":"https://api.github.com/users/bmag/orgs","repos_url":"https://api.github.com/users/bmag/repos","events_url":"https://api.github.com/users/bmag/events{/privacy}","received_events_url":"https://api.github.com/users/bmag/received_events","type":"User","site_admin":false},"repo":{"id":36483845,"name":"spacemacs","full_name":"bmag/spacemacs","owner":{"login":"bmag","id":4334375,"avatar_url":"https://avatars.githubusercontent.com/u/4334375?v=3","gravatar_id":"","url":"https://api.github.com/users/bmag","html_url":"https://github.com/bmag","followers_url":"https://api.github.com/users/bmag/followers","following_url":"https://api.github.com/users/bmag/following{/other_user}","gists_url":"https://api.github.com/users/bmag/gists{/gist_id}","starred_url":"https://api.github.com/users/bmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmag/subscriptions","organizations_url":"https://api.github.com/users/bmag/orgs","repos_url":"https://api.github.com/users/bmag/repos","events_url":"https://api.github.com/users/bmag/events{/privacy}","received_events_url":"https://api.github.com/users/bmag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmag/spacemacs","description":"Emacs advanced Kit focused on Evil: The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/bmag/spacemacs","forks_url":"https://api.github.com/repos/bmag/spacemacs/forks","keys_url":"https://api.github.com/repos/bmag/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmag/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmag/spacemacs/teams","hooks_url":"https://api.github.com/repos/bmag/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/bmag/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/bmag/spacemacs/events","assignees_url":"https://api.github.com/repos/bmag/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/bmag/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/bmag/spacemacs/tags","blobs_url":"https://api.github.com/repos/bmag/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmag/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmag/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmag/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmag/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/bmag/spacemacs/languages","stargazers_url":"https://api.github.com/repos/bmag/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/bmag/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/bmag/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/bmag/spacemacs/subscription","commits_url":"https://api.github.com/repos/bmag/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmag/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmag/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmag/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmag/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/bmag/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmag/spacemacs/merges","archive_url":"https://api.github.com/repos/bmag/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmag/spacemacs/downloads","issues_url":"https://api.github.com/repos/bmag/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/bmag/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/bmag/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/bmag/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmag/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/bmag/spacemacs/releases{/id}","created_at":"2015-05-29T05:18:58Z","updated_at":"2015-05-29T05:19:00Z","pushed_at":"2015-09-07T17:32:49Z","git_url":"git://github.com/bmag/spacemacs.git","ssh_url":"git@github.com:bmag/spacemacs.git","clone_url":"https://github.com/bmag/spacemacs.git","svn_url":"https://github.com/bmag/spacemacs","homepage":"https://twitter.com/spacemacs","size":17823,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"4ed200612ddbc44286be6adad3b902d957626fa6","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"Emacs advanced Kit focused on Evil: The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","created_at":"2012-12-17T21:34:03Z","updated_at":"2015-09-10T02:45:13Z","pushed_at":"2015-09-09T19:33:19Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"https://twitter.com/spacemacs","size":40376,"stargazers_count":3441,"watchers_count":3441,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":803,"mirror_url":null,"open_issues_count":644,"forks":803,"open_issues":644,"watchers":3441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/2819"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2819"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/2819/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/2819/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/35ddd0ed64fe28c7514f1bdb6138d729afae93eb"}}}}