{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/9855","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/9855/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9855/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/9855/events","html_url":"https://github.com/edx/edx-platform/pull/9855","id":107547185,"number":9855,"title":"fix label for check/final check","user":{"login":"sarina","id":1985317,"avatar_url":"https://avatars.githubusercontent.com/u/1985317?v=3","gravatar_id":"","url":"https://api.github.com/users/sarina","html_url":"https://github.com/sarina","followers_url":"https://api.github.com/users/sarina/followers","following_url":"https://api.github.com/users/sarina/following{/other_user}","gists_url":"https://api.github.com/users/sarina/gists{/gist_id}","starred_url":"https://api.github.com/users/sarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarina/subscriptions","organizations_url":"https://api.github.com/users/sarina/orgs","repos_url":"https://api.github.com/users/sarina/repos","events_url":"https://api.github.com/users/sarina/events{/privacy}","received_events_url":"https://api.github.com/users/sarina/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/bug%20(open%20source)","name":"bug (open source)","color":"bfdadc"},{"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-21T16:14:50Z","updated_at":"2015-09-23T04:56:19Z","closed_at":"2015-09-21T17:13:02Z","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9855","html_url":"https://github.com/edx/edx-platform/pull/9855","diff_url":"https://github.com/edx/edx-platform/pull/9855.diff","patch_url":"https://github.com/edx/edx-platform/pull/9855.patch"},"body":"**Description:** This label hadn't been updated to change its message depending on whether students were on their \"final\" submission attempt. Ref #9703 \r\n\r\n*Before PR*\r\n![image](https://cloud.githubusercontent.com/assets/1844496/9791761/b7f8b5ba-57aa-11e5-9b9f-0df853f977b7.png)\r\n\r\n*After PR*\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1844496/9791852/2a4688d6-57ab-11e5-9fb8-1382da1ff1cc.png)\r\n\r\n\r\n**What JIRA ticket does this address (if any)?** None that I know of\r\n\r\n**Who have you talked to at edX about this work?** Nobody yet! Simple PR, so I figured I'd just submit\r\n\r\n**Why do you need this change?** This is a bug that one of the QA testers in my organization found, and the fix was located in the platform rather than within our theme.  It's a usability bug, and certainly is bound to come up for more organizations than just mine.\r\n\r\n**What components are affected?** LMS\r\n\r\n**What users are affected?** All edX students who have the opportunity to take an assessment with multiple possible submissions.\r\n\r\n**Test instructions for manual testing:**\r\n- Log into LMS as a student enrolled in a course that allows multiple submissions for a problem.  \r\n- Fill out the problem, and hit \"save\" to save your answers before submitting\r\n- Currently, when the final submission is sent in, the label at the bottom of the problem will always say \"Your answers have been saved but not graded. Click 'Final Check' to grade them.\"  However, the button on the interface will say \"Check\" until the last submission.  \r\n- Apply the changes from this PR, and confirm that the label changes as expected\r\n\r\n**What are your concerns (the author’s) about the PR?**\r\nIt's possible that this isn't the best way to compose the string for this label, as it somewhat interferes with the _() _translate_ function.  If that's the case, I'll need some guidance."},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/142491088","html_url":"https://github.com/edx/edx-platform/pull/9855#issuecomment-142491088","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9855","id":142491088,"user":{"login":"mbifulco","id":1844496,"avatar_url":"https://avatars.githubusercontent.com/u/1844496?v=3","gravatar_id":"","url":"https://api.github.com/users/mbifulco","html_url":"https://github.com/mbifulco","followers_url":"https://api.github.com/users/mbifulco/followers","following_url":"https://api.github.com/users/mbifulco/following{/other_user}","gists_url":"https://api.github.com/users/mbifulco/gists{/gist_id}","starred_url":"https://api.github.com/users/mbifulco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbifulco/subscriptions","organizations_url":"https://api.github.com/users/mbifulco/orgs","repos_url":"https://api.github.com/users/mbifulco/repos","events_url":"https://api.github.com/users/mbifulco/events{/privacy}","received_events_url":"https://api.github.com/users/mbifulco/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T04:56:19Z","updated_at":"2015-09-23T04:56:19Z","body":"@sarina - glad it got in there! Sorry I didn't follow up, we're in crunch time for a launch of our site, and I wouldn't have had time to get back to this for a couple weeks."}}