{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/39386398","id":39386398,"diff_hunk":"@@ -1128,30 +1130,34 @@ Cert::Status TbsCertificate::DeleteExtension(int extension_nid) {\n \n   // ExtensionIndex returns the first matching index - if the extension\n   // occurs more than once, just give up.\n-  int ignored;\n-  status = ExtensionIndex(extension_nid, &ignored);\n-  if (status == Cert::TRUE) {\n+  const StatusOr<int> ignored_index = ExtensionIndex(extension_nid);\n+  if (ignored_index.ok()) {\n     LOG(WARNING)\n         << \"Failed to delete the extension. Does the certificate have \"\n         << \"duplicate extensions?\";\n-    return Cert::FALSE;\n+    return util::Status(Code::ALREADY_EXISTS, \"Multiple extensions in cert\");;","path":"cpp/log/cert.cc","position":71,"original_position":71,"commit_id":"61039af7ea4ee81c0951932e3e7c2da1b54c09a4","original_commit_id":"61039af7ea4ee81c0951932e3e7c2da1b54c09a4","user":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=3","gravatar_id":"","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"body":"There's two semi-colons here.","created_at":"2015-09-14T12:14:28Z","updated_at":"2015-09-14T12:14:28Z","html_url":"https://github.com/google/certificate-transparency/pull/925#discussion_r39386398","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/925","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/39386398"},"html":{"href":"https://github.com/google/certificate-transparency/pull/925#discussion_r39386398"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/925"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/925","id":44673764,"html_url":"https://github.com/google/certificate-transparency/pull/925","diff_url":"https://github.com/google/certificate-transparency/pull/925.diff","patch_url":"https://github.com/google/certificate-transparency/pull/925.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/925","number":925,"state":"open","locked":false,"title":"Update remaining TBSCertificate methods to util::Status","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"body":"Updates call sites + test, and comments on status returned by the functions.","created_at":"2015-09-10T14:23:06Z","updated_at":"2015-09-14T12:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ffd16e15990e889caa9bfffcb43b8560bde87d8","assignee":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=3","gravatar_id":"","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/925/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/925/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/925/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/61039af7ea4ee81c0951932e3e7c2da1b54c09a4","head":{"label":"Martin2112:unified_status_2","ref":"unified_status_2","sha":"61039af7ea4ee81c0951932e3e7c2da1b54c09a4","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"repo":{"id":39995539,"name":"certificate-transparency","full_name":"Martin2112/certificate-transparency","owner":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Martin2112/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/Martin2112/certificate-transparency","forks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/forks","keys_url":"https://api.github.com/repos/Martin2112/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Martin2112/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Martin2112/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/events","assignees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/Martin2112/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Martin2112/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/Martin2112/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/Martin2112/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/Martin2112/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Martin2112/certificate-transparency/merges","archive_url":"https://api.github.com/repos/Martin2112/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Martin2112/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/Martin2112/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/Martin2112/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/Martin2112/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Martin2112/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/Martin2112/certificate-transparency/releases{/id}","created_at":"2015-07-31T08:37:21Z","updated_at":"2015-07-31T08:37:23Z","pushed_at":"2015-09-14T11:27:36Z","git_url":"git://github.com/Martin2112/certificate-transparency.git","ssh_url":"git@github.com:Martin2112/certificate-transparency.git","clone_url":"https://github.com/Martin2112/certificate-transparency.git","svn_url":"https://github.com/Martin2112/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":19540,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"38ec9ba3156e59a94e55ff4d55ad6d751bf3ff4a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","created_at":"2014-05-20T17:03:47Z","updated_at":"2015-09-11T06:32:30Z","pushed_at":"2015-09-14T11:27:36Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":25225,"stargazers_count":156,"watchers_count":156,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":56,"forks":58,"open_issues":56,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/925"},"html":{"href":"https://github.com/google/certificate-transparency/pull/925"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/925"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/925/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/925/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/925/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/61039af7ea4ee81c0951932e3e7c2da1b54c09a4"}}}}