{"action":"created","comment":{"url":"https://api.github.com/repos/socketstream/socketstream/pulls/comments/27350583","id":27350583,"diff_hunk":"@@ -443,39 +457,62 @@ module.exports = function(ss,options) {\n \n       var _entries = [],\n           bundler = getBundler(client),\n-          includeType;\n+          includeType,\n+          bundle;\n \n       switch(assetType) {\n         case 'css':\n           includeType = 'css';\n+          bundle = 'css';\n           client.paths['css'].forEach(pushMainEntries);\n           break;\n \n         case 'js':\n         case 'worker':\n           // Libs\n-          var libs = [bundler.asset.loader()];\n+          var libs = bundler.module('loader');\n \n           // Modules\n-          var mods = [],\n-            _ref = system.assets.modules;\n-          for (var name in _ref) {\n-            if (_ref.hasOwnProperty(name)) {\n-              mods.push( bundler.asset.systemModule(name) );\n-            }\n-          }\n+          var mods = bundler.module.apply(bundler, Object.keys(system.assets.modules));\n+\n           _entries = _entries.concat(libs).concat(mods);\n           includeType = false;\n+          //TODO worker instead of code ?\n           client.paths['code'].forEach(pushMainEntries);\n           if (options.startInBundle) {\n-            _entries = _entries.concat(bundler.asset.start());\n+            _entries = _entries.concat(bundler.module('start'));\n           }\n+          _entries = _entries.map(function(entry) {\n+            var extension = path.extname(entry.file);\n+            extension = extension && extension.substring(1); // argh!\n+            entry.ext = extension;\n+            entry.assetType = 'js';\n+            entry.bundle = 'js';\n+            return entry;\n+          });\n+          break;\n+\n+        case 'tmpl':\n+          includeType = 'html';\n+          bundle = 'tmpl';\n+          client.paths.tmpl.forEach(function(tmpl) {\n+            if (tmpl.substring(tmpl.length-2) === '/*') {\n+              var matching = magicPath.files(path.join(ss.root,options.dirs.client,tmpl.substring(0,tmpl.length-2)), '*');","path":"lib/client/bundler/index.js","position":130,"original_position":130,"commit_id":"5a020477a9b2b731a8a88ac360d5c4264d8fbb26","original_commit_id":"5a020477a9b2b731a8a88ac360d5c4264d8fbb26","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2015-03-29T01:43:03Z","updated_at":"2015-03-29T01:43:03Z","html_url":"https://github.com/socketstream/socketstream/pull/512#discussion_r27350583","pull_request_url":"https://api.github.com/repos/socketstream/socketstream/pulls/512","_links":{"self":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/comments/27350583"},"html":{"href":"https://github.com/socketstream/socketstream/pull/512#discussion_r27350583"},"pull_request":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/512"}}},"pull_request":{"url":"https://api.github.com/repos/socketstream/socketstream/pulls/512","id":31512408,"html_url":"https://github.com/socketstream/socketstream/pull/512","diff_url":"https://github.com/socketstream/socketstream/pull/512.diff","patch_url":"https://github.com/socketstream/socketstream/pull/512.patch","issue_url":"https://api.github.com/repos/socketstream/socketstream/issues/512","number":512,"state":"open","locked":false,"title":"logging API everywhere. Revised formatters and template_engine","user":{"login":"thepian","id":72638,"avatar_url":"https://avatars.githubusercontent.com/u/72638?v=3","gravatar_id":"","url":"https://api.github.com/users/thepian","html_url":"https://github.com/thepian","followers_url":"https://api.github.com/users/thepian/followers","following_url":"https://api.github.com/users/thepian/following{/other_user}","gists_url":"https://api.github.com/users/thepian/gists{/gist_id}","starred_url":"https://api.github.com/users/thepian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepian/subscriptions","organizations_url":"https://api.github.com/users/thepian/orgs","repos_url":"https://api.github.com/users/thepian/repos","events_url":"https://api.github.com/users/thepian/events{/privacy}","received_events_url":"https://api.github.com/users/thepian/received_events","type":"User","site_admin":false},"body":"Not ready. Using this to monitor coverage.\r\n\r\n- [x] Full coverage formatters\r\n- [x] Full coverage template_engine\r\n- [x] bundler.loadFile = use correct formatter to fetch file for bundling. Used in all cases.\r\n- [x] Test log API\r\n- [x] Engine init with function.\r\n- [x] Callback with Error object to feedback.\r\n- [x] Test custom engines","created_at":"2015-03-19T10:53:55Z","updated_at":"2015-03-29T01:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0091ecb63be9f6044285439bd43870a3e8d8fb1e","assignee":{"login":"thepian","id":72638,"avatar_url":"https://avatars.githubusercontent.com/u/72638?v=3","gravatar_id":"","url":"https://api.github.com/users/thepian","html_url":"https://github.com/thepian","followers_url":"https://api.github.com/users/thepian/followers","following_url":"https://api.github.com/users/thepian/following{/other_user}","gists_url":"https://api.github.com/users/thepian/gists{/gist_id}","starred_url":"https://api.github.com/users/thepian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepian/subscriptions","organizations_url":"https://api.github.com/users/thepian/orgs","repos_url":"https://api.github.com/users/thepian/repos","events_url":"https://api.github.com/users/thepian/events{/privacy}","received_events_url":"https://api.github.com/users/thepian/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/socketstream/socketstream/milestones/4","html_url":"https://github.com/socketstream/socketstream/milestones/0.4","labels_url":"https://api.github.com/repos/socketstream/socketstream/milestones/4/labels","id":960202,"number":4,"title":"0.4","description":"The next major version of SocketStream","creator":{"login":"paulbjensen","id":3840,"avatar_url":"https://avatars.githubusercontent.com/u/3840?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbjensen","html_url":"https://github.com/paulbjensen","followers_url":"https://api.github.com/users/paulbjensen/followers","following_url":"https://api.github.com/users/paulbjensen/following{/other_user}","gists_url":"https://api.github.com/users/paulbjensen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbjensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbjensen/subscriptions","organizations_url":"https://api.github.com/users/paulbjensen/orgs","repos_url":"https://api.github.com/users/paulbjensen/repos","events_url":"https://api.github.com/users/paulbjensen/events{/privacy}","received_events_url":"https://api.github.com/users/paulbjensen/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":11,"state":"open","created_at":"2015-02-01T14:16:16Z","updated_at":"2015-03-26T17:21:19Z","due_on":"2015-04-15T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/socketstream/socketstream/pulls/512/commits","review_comments_url":"https://api.github.com/repos/socketstream/socketstream/pulls/512/comments","review_comment_url":"https://api.github.com/repos/socketstream/socketstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socketstream/socketstream/issues/512/comments","statuses_url":"https://api.github.com/repos/socketstream/socketstream/statuses/5a020477a9b2b731a8a88ac360d5c4264d8fbb26","head":{"label":"socketstream:feature/497-logging","ref":"feature/497-logging","sha":"5a020477a9b2b731a8a88ac360d5c4264d8fbb26","user":{"login":"socketstream","id":5891564,"avatar_url":"https://avatars.githubusercontent.com/u/5891564?v=3","gravatar_id":"","url":"https://api.github.com/users/socketstream","html_url":"https://github.com/socketstream","followers_url":"https://api.github.com/users/socketstream/followers","following_url":"https://api.github.com/users/socketstream/following{/other_user}","gists_url":"https://api.github.com/users/socketstream/gists{/gist_id}","starred_url":"https://api.github.com/users/socketstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketstream/subscriptions","organizations_url":"https://api.github.com/users/socketstream/orgs","repos_url":"https://api.github.com/users/socketstream/repos","events_url":"https://api.github.com/users/socketstream/events{/privacy}","received_events_url":"https://api.github.com/users/socketstream/received_events","type":"Organization","site_admin":false},"repo":{"id":1254218,"name":"socketstream","full_name":"socketstream/socketstream","owner":{"login":"socketstream","id":5891564,"avatar_url":"https://avatars.githubusercontent.com/u/5891564?v=3","gravatar_id":"","url":"https://api.github.com/users/socketstream","html_url":"https://github.com/socketstream","followers_url":"https://api.github.com/users/socketstream/followers","following_url":"https://api.github.com/users/socketstream/following{/other_user}","gists_url":"https://api.github.com/users/socketstream/gists{/gist_id}","starred_url":"https://api.github.com/users/socketstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketstream/subscriptions","organizations_url":"https://api.github.com/users/socketstream/orgs","repos_url":"https://api.github.com/users/socketstream/repos","events_url":"https://api.github.com/users/socketstream/events{/privacy}","received_events_url":"https://api.github.com/users/socketstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketstream/socketstream","description":"A framework for Realtime Web Apps","fork":false,"url":"https://api.github.com/repos/socketstream/socketstream","forks_url":"https://api.github.com/repos/socketstream/socketstream/forks","keys_url":"https://api.github.com/repos/socketstream/socketstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketstream/socketstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketstream/socketstream/teams","hooks_url":"https://api.github.com/repos/socketstream/socketstream/hooks","issue_events_url":"https://api.github.com/repos/socketstream/socketstream/issues/events{/number}","events_url":"https://api.github.com/repos/socketstream/socketstream/events","assignees_url":"https://api.github.com/repos/socketstream/socketstream/assignees{/user}","branches_url":"https://api.github.com/repos/socketstream/socketstream/branches{/branch}","tags_url":"https://api.github.com/repos/socketstream/socketstream/tags","blobs_url":"https://api.github.com/repos/socketstream/socketstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketstream/socketstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketstream/socketstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketstream/socketstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketstream/socketstream/statuses/{sha}","languages_url":"https://api.github.com/repos/socketstream/socketstream/languages","stargazers_url":"https://api.github.com/repos/socketstream/socketstream/stargazers","contributors_url":"https://api.github.com/repos/socketstream/socketstream/contributors","subscribers_url":"https://api.github.com/repos/socketstream/socketstream/subscribers","subscription_url":"https://api.github.com/repos/socketstream/socketstream/subscription","commits_url":"https://api.github.com/repos/socketstream/socketstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketstream/socketstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketstream/socketstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketstream/socketstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketstream/socketstream/contents/{+path}","compare_url":"https://api.github.com/repos/socketstream/socketstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketstream/socketstream/merges","archive_url":"https://api.github.com/repos/socketstream/socketstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketstream/socketstream/downloads","issues_url":"https://api.github.com/repos/socketstream/socketstream/issues{/number}","pulls_url":"https://api.github.com/repos/socketstream/socketstream/pulls{/number}","milestones_url":"https://api.github.com/repos/socketstream/socketstream/milestones{/number}","notifications_url":"https://api.github.com/repos/socketstream/socketstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketstream/socketstream/labels{/name}","releases_url":"https://api.github.com/repos/socketstream/socketstream/releases{/id}","created_at":"2011-01-14T11:47:16Z","updated_at":"2015-03-28T23:26:35Z","pushed_at":"2015-03-29T01:42:41Z","git_url":"git://github.com/socketstream/socketstream.git","ssh_url":"git@github.com:socketstream/socketstream.git","clone_url":"https://github.com/socketstream/socketstream.git","svn_url":"https://github.com/socketstream/socketstream","homepage":"http://socketstream.com","size":8196,"stargazers_count":3205,"watchers_count":3205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":250,"mirror_url":null,"open_issues_count":31,"forks":250,"open_issues":31,"watchers":3205,"default_branch":"master"}},"base":{"label":"socketstream:next","ref":"next","sha":"595fed3c1762dc614dd6a1b7dadbaf5f067e3e35","user":{"login":"socketstream","id":5891564,"avatar_url":"https://avatars.githubusercontent.com/u/5891564?v=3","gravatar_id":"","url":"https://api.github.com/users/socketstream","html_url":"https://github.com/socketstream","followers_url":"https://api.github.com/users/socketstream/followers","following_url":"https://api.github.com/users/socketstream/following{/other_user}","gists_url":"https://api.github.com/users/socketstream/gists{/gist_id}","starred_url":"https://api.github.com/users/socketstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketstream/subscriptions","organizations_url":"https://api.github.com/users/socketstream/orgs","repos_url":"https://api.github.com/users/socketstream/repos","events_url":"https://api.github.com/users/socketstream/events{/privacy}","received_events_url":"https://api.github.com/users/socketstream/received_events","type":"Organization","site_admin":false},"repo":{"id":1254218,"name":"socketstream","full_name":"socketstream/socketstream","owner":{"login":"socketstream","id":5891564,"avatar_url":"https://avatars.githubusercontent.com/u/5891564?v=3","gravatar_id":"","url":"https://api.github.com/users/socketstream","html_url":"https://github.com/socketstream","followers_url":"https://api.github.com/users/socketstream/followers","following_url":"https://api.github.com/users/socketstream/following{/other_user}","gists_url":"https://api.github.com/users/socketstream/gists{/gist_id}","starred_url":"https://api.github.com/users/socketstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketstream/subscriptions","organizations_url":"https://api.github.com/users/socketstream/orgs","repos_url":"https://api.github.com/users/socketstream/repos","events_url":"https://api.github.com/users/socketstream/events{/privacy}","received_events_url":"https://api.github.com/users/socketstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketstream/socketstream","description":"A framework for Realtime Web Apps","fork":false,"url":"https://api.github.com/repos/socketstream/socketstream","forks_url":"https://api.github.com/repos/socketstream/socketstream/forks","keys_url":"https://api.github.com/repos/socketstream/socketstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketstream/socketstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketstream/socketstream/teams","hooks_url":"https://api.github.com/repos/socketstream/socketstream/hooks","issue_events_url":"https://api.github.com/repos/socketstream/socketstream/issues/events{/number}","events_url":"https://api.github.com/repos/socketstream/socketstream/events","assignees_url":"https://api.github.com/repos/socketstream/socketstream/assignees{/user}","branches_url":"https://api.github.com/repos/socketstream/socketstream/branches{/branch}","tags_url":"https://api.github.com/repos/socketstream/socketstream/tags","blobs_url":"https://api.github.com/repos/socketstream/socketstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketstream/socketstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketstream/socketstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketstream/socketstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketstream/socketstream/statuses/{sha}","languages_url":"https://api.github.com/repos/socketstream/socketstream/languages","stargazers_url":"https://api.github.com/repos/socketstream/socketstream/stargazers","contributors_url":"https://api.github.com/repos/socketstream/socketstream/contributors","subscribers_url":"https://api.github.com/repos/socketstream/socketstream/subscribers","subscription_url":"https://api.github.com/repos/socketstream/socketstream/subscription","commits_url":"https://api.github.com/repos/socketstream/socketstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketstream/socketstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketstream/socketstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketstream/socketstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketstream/socketstream/contents/{+path}","compare_url":"https://api.github.com/repos/socketstream/socketstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketstream/socketstream/merges","archive_url":"https://api.github.com/repos/socketstream/socketstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketstream/socketstream/downloads","issues_url":"https://api.github.com/repos/socketstream/socketstream/issues{/number}","pulls_url":"https://api.github.com/repos/socketstream/socketstream/pulls{/number}","milestones_url":"https://api.github.com/repos/socketstream/socketstream/milestones{/number}","notifications_url":"https://api.github.com/repos/socketstream/socketstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketstream/socketstream/labels{/name}","releases_url":"https://api.github.com/repos/socketstream/socketstream/releases{/id}","created_at":"2011-01-14T11:47:16Z","updated_at":"2015-03-28T23:26:35Z","pushed_at":"2015-03-29T01:42:41Z","git_url":"git://github.com/socketstream/socketstream.git","ssh_url":"git@github.com:socketstream/socketstream.git","clone_url":"https://github.com/socketstream/socketstream.git","svn_url":"https://github.com/socketstream/socketstream","homepage":"http://socketstream.com","size":8196,"stargazers_count":3205,"watchers_count":3205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":250,"mirror_url":null,"open_issues_count":31,"forks":250,"open_issues":31,"watchers":3205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/512"},"html":{"href":"https://github.com/socketstream/socketstream/pull/512"},"issue":{"href":"https://api.github.com/repos/socketstream/socketstream/issues/512"},"comments":{"href":"https://api.github.com/repos/socketstream/socketstream/issues/512/comments"},"review_comments":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/512/comments"},"review_comment":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socketstream/socketstream/pulls/512/commits"},"statuses":{"href":"https://api.github.com/repos/socketstream/socketstream/statuses/5a020477a9b2b731a8a88ac360d5c4264d8fbb26"}}}}