{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/368","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/368/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/368/events","html_url":"https://github.com/solidusio/solidus/pull/368","id":106856649,"number":368,"title":"Introduce variant level properties","user":{"login":"richardnuno","id":2223534,"avatar_url":"https://avatars.githubusercontent.com/u/2223534?v=3","gravatar_id":"","url":"https://api.github.com/users/richardnuno","html_url":"https://github.com/richardnuno","followers_url":"https://api.github.com/users/richardnuno/followers","following_url":"https://api.github.com/users/richardnuno/following{/other_user}","gists_url":"https://api.github.com/users/richardnuno/gists{/gist_id}","starred_url":"https://api.github.com/users/richardnuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardnuno/subscriptions","organizations_url":"https://api.github.com/users/richardnuno/orgs","repos_url":"https://api.github.com/users/richardnuno/repos","events_url":"https://api.github.com/users/richardnuno/events{/privacy}","received_events_url":"https://api.github.com/users/richardnuno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-16T20:29:47Z","updated_at":"2015-09-23T17:35:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/368","html_url":"https://github.com/solidusio/solidus/pull/368","diff_url":"https://github.com/solidusio/solidus/pull/368.diff","patch_url":"https://github.com/solidusio/solidus/pull/368.patch"},"body":"Takes the concept of product properties and transfers it over to\r\nvariants.\r\n\r\nThis change allows an admin to specify properties for variants based on\r\na selection of option values. This prevents a lot of duplication since\r\nmany variants are going to share the same properties.\r\n\r\nUnlike product properties which are associated directly to the product,\r\nthe variant properties are not directly associated with their variants.\r\nA variant property rule is created which contains the option values the\r\nrule is targeting.\r\n\r\nThe reason for this choice was due to performance. With products that\r\nhave thousands of variants, associating information for each variant\r\nbecomes a performance concern. An added benefit to this approach is that\r\nvariant properties do not have to be set up for new variant. If the\r\nvariant has the option values targeted by the rule, the properties will\r\nautomatically apply to the variant.\r\n\r\nThe UI displays the variant properties on the same page as the product\r\nproperties. The JavaScript changes were related to fixing some issues\r\nrelated to adding new fields to the property list UI. The changes were\r\nrelated to supporting property lists on the same page.\r\n\r\nScreenshot below illustrates the UI for building the variant property rules:\r\n![screen shot 2015-09-16 at 4 28 05 pm](https://cloud.githubusercontent.com/assets/2223534/9917524/1b8a6a30-5c90-11e5-9e99-fffc88e4fb75.png)\r\n"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/142674227","html_url":"https://github.com/solidusio/solidus/pull/368#issuecomment-142674227","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/368","id":142674227,"user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T17:35:43Z","updated_at":"2015-09-23T17:35:43Z","body":"One question, otherwise looks good to me"}}