{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3912","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3912/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3912/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3912/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3912","id":101637564,"number":3912,"title":"Openstack Env Builder refactoring","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gem%20changes","name":"gem changes","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/openstack","name":"providers/openstack","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-18T11:45:41Z","updated_at":"2015-09-07T14:52:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3912","html_url":"https://github.com/ManageIQ/manageiq/pull/3912","diff_url":"https://github.com/ManageIQ/manageiq/pull/3912.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3912.patch"},"body":"Enhanced enviroment builder. Main part is separating data definition from the\r\nfunctionality. So the data definition can be reused in integration tests.\r\n\r\nE.g. we will not compare number of refreshed vms to 5, but to the Builder's\r\ndata definition for creating Vms\r\n\r\nAlso some preparation for keystone v2/v3 has been done, thi will be tackled\r\nnext.\r\n\r\nAlso tests for grizzly and havana has been unified and we are rather exposing small differences of :neutron vs :nova_network"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/138317643","html_url":"https://github.com/ManageIQ/manageiq/pull/3912#issuecomment-138317643","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3912","id":138317643,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T14:52:17Z","updated_at":"2015-09-07T14:52:17Z","body":"<rubocop />Checked commits https://github.com/Ladas/manageiq/compare/5ecab427d7c6452dab3efe168a4f003197ebc65c~...96edd43ca254b85611df6f57867149684bfa921d with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0\n24 files checked, 29 offenses detected\n\n**spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb**\n- [ ] :large_orange_diamond: - [Line 13](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L13), Col 3 - [Metrics/ModuleLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ModuleLength) - Module has too many lines. [321/100]\n- [ ] :small_blue_diamond: - [Line 22](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L22), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_with_skips is too high. [17/15]\n- [ ] :small_blue_diamond: - [Line 48](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L48), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for volumes_count is too high. [29.43/15]\n- [ ] :small_blue_diamond: - [Line 108](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L108), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_table_counts is too high. [117/15]\n- [ ] :small_blue_diamond: - [Line 142](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L142), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_ems is too high. [58/15]\n- [ ] :small_blue_diamond: - [Line 158](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L158), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_flavor is too high. [27/15]\n- [ ] :small_blue_diamond: - [Line 251](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L251), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_network is too high. [18.03/15]\n- [ ] :small_blue_diamond: - [Line 268](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L268), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_templates is too high. [43.01/15]\n- [ ] :small_blue_diamond: - [Line 268](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L268), Col 5 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [36/25]\n- [ ] :small_blue_diamond: - [Line 329](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L329), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_vm is too high. [129.2/15]\n- [ ] :small_blue_diamond: - [Line 329](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb#L329), Col 5 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [73/25]\n\n**spec/tools/environment_builders/openstack/services/compute/builder.rb**\n- [ ] :small_blue_diamond: - [Line 6](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/builder.rb#L6), Col 7 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [112/100]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/builder.rb#L55), Col 9 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for find_or_create_servers is too high. [33.85/15]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/builder.rb#L55), Col 9 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for find_or_create_servers is too high. [9/6]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/builder.rb#L55), Col 9 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for find_or_create_servers is too high. [9/7]\n- [ ] :small_blue_diamond: - [Line 94](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/builder.rb#L94), Col 9 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for associate_ip is too high. [23.43/15]\n\n**spec/tools/environment_builders/openstack/services/compute/data.rb**\n- [ ] :small_blue_diamond: - [Line 6](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/data.rb#L6), Col 7 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [102/100]\n- [ ] :small_blue_diamond: - [Line 14](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/data.rb#L14), Col 9 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [48/25]\n- [ ] :small_blue_diamond: - [Line 73](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/compute/data.rb#L73), Col 9 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [29/25]\n\n**spec/tools/environment_builders/openstack/services/image/builder.rb**\n- [ ] :small_blue_diamond: - [Line 6](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/image/builder.rb#L6), Col 7 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [104/100]\n\n**spec/tools/environment_builders/openstack/services/network/builder/neutron.rb**\n- [ ] :small_blue_diamond: - [Line 50](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/builder/neutron.rb#L50), Col 11 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for find_or_create_routers is too high. [16.25/15]\n- [ ] :small_blue_diamond: - [Line 74](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/builder/neutron.rb#L74), Col 11 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for find_or_create_floating_ips is too high. [29.77/15]\n- [ ] :small_blue_diamond: - [Line 95](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/builder/neutron.rb#L95), Col 11 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for find_or_create_firewall_rules is too high. [16.16/15]\n\n**spec/tools/environment_builders/openstack/services/network/builder/nova.rb**\n- [ ] :small_blue_diamond: - [Line 43](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/builder/nova.rb#L43), Col 11 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for find_or_create_floating_ips is too high. [18.49/15]\n\n**spec/tools/environment_builders/openstack/services/network/data/neutron.rb**\n- [ ] :large_orange_diamond: - [Line 40](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/data/neutron.rb#L40), Col 15 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :small_blue_diamond: - [Line 7](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/data/neutron.rb#L7), Col 9 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [196/100]\n- [ ] :small_blue_diamond: - [Line 94](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/data/neutron.rb#L94), Col 11 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [122/25]\n\n**spec/tools/environment_builders/openstack/services/network/data/nova.rb**\n- [ ] :small_blue_diamond: - [Line 7](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/data/nova.rb#L7), Col 9 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [103/100]\n- [ ] :small_blue_diamond: - [Line 51](https://github.com/Ladas/manageiq/blob/96edd43ca254b85611df6f57867149684bfa921d/spec/tools/environment_builders/openstack/services/network/data/nova.rb#L51), Col 11 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [67/25]\n"}}