{"action":"created","comment":{"url":"https://api.github.com/repos/real-logic/Aeron/pulls/comments/29496638","id":29496638,"diff_hunk":"@@ -195,6 +209,7 @@ public static MediaDriver launch(final Context ctx)\n     /**\n      * Shutdown the media driver by stopping all threads and freeing resources.\n      */\n+    @Override","path":"aeron-driver/src/main/java/uk/co/real_logic/aeron/driver/MediaDriver.java","position":72,"original_position":72,"commit_id":"7da4480cf7afb219e78d9fcb163d28d126a3da39","original_commit_id":"7da4480cf7afb219e78d9fcb163d28d126a3da39","user":{"login":"mjpt777","id":760524,"avatar_url":"https://avatars.githubusercontent.com/u/760524?v=3","gravatar_id":"","url":"https://api.github.com/users/mjpt777","html_url":"https://github.com/mjpt777","followers_url":"https://api.github.com/users/mjpt777/followers","following_url":"https://api.github.com/users/mjpt777/following{/other_user}","gists_url":"https://api.github.com/users/mjpt777/gists{/gist_id}","starred_url":"https://api.github.com/users/mjpt777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjpt777/subscriptions","organizations_url":"https://api.github.com/users/mjpt777/orgs","repos_url":"https://api.github.com/users/mjpt777/repos","events_url":"https://api.github.com/users/mjpt777/events{/privacy}","received_events_url":"https://api.github.com/users/mjpt777/received_events","type":"User","site_admin":false},"body":"What is the value in adding \"@Override\"? It just clutters up the code and is poorly defined for Java as most uses are implements rather than a true override.","created_at":"2015-05-01T10:36:40Z","updated_at":"2015-05-01T10:36:40Z","html_url":"https://github.com/real-logic/Aeron/pull/108#discussion_r29496638","pull_request_url":"https://api.github.com/repos/real-logic/Aeron/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/comments/29496638"},"html":{"href":"https://github.com/real-logic/Aeron/pull/108#discussion_r29496638"},"pull_request":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/real-logic/Aeron/pulls/108","id":34506965,"html_url":"https://github.com/real-logic/Aeron/pull/108","diff_url":"https://github.com/real-logic/Aeron/pull/108.diff","patch_url":"https://github.com/real-logic/Aeron/pull/108.patch","issue_url":"https://api.github.com/repos/real-logic/Aeron/issues/108","number":108,"state":"open","locked":false,"title":"Doc, packaging, and tools for Aeron","user":{"login":"strangelydim","id":2837339,"avatar_url":"https://avatars.githubusercontent.com/u/2837339?v=3","gravatar_id":"","url":"https://api.github.com/users/strangelydim","html_url":"https://github.com/strangelydim","followers_url":"https://api.github.com/users/strangelydim/followers","following_url":"https://api.github.com/users/strangelydim/following{/other_user}","gists_url":"https://api.github.com/users/strangelydim/gists{/gist_id}","starred_url":"https://api.github.com/users/strangelydim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strangelydim/subscriptions","organizations_url":"https://api.github.com/users/strangelydim/orgs","repos_url":"https://api.github.com/users/strangelydim/repos","events_url":"https://api.github.com/users/strangelydim/events{/privacy}","received_events_url":"https://api.github.com/users/strangelydim/received_events","type":"User","site_admin":false},"body":"This is a big one...  Tools for performance testing and graph generation, for testing Aeron in general with multiple publications/subscriptions and channels and sending/receiving threads, abuse testing, some new and updated sample apps, new doc, and a test plan.\r\n\r\nLet me know if changes need to be made before acceptance.  (Or if you'd like to accept first just to get this all in and make changes later via another pull request.)","created_at":"2015-04-30T22:21:43Z","updated_at":"2015-05-01T10:36:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"580f05f556b455c1ec796c39ea8bd4fef5095275","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/real-logic/Aeron/pulls/108/commits","review_comments_url":"https://api.github.com/repos/real-logic/Aeron/pulls/108/comments","review_comment_url":"https://api.github.com/repos/real-logic/Aeron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/real-logic/Aeron/issues/108/comments","statuses_url":"https://api.github.com/repos/real-logic/Aeron/statuses/7da4480cf7afb219e78d9fcb163d28d126a3da39","head":{"label":"strangelydim:real-logic-pull-request","ref":"real-logic-pull-request","sha":"7da4480cf7afb219e78d9fcb163d28d126a3da39","user":{"login":"strangelydim","id":2837339,"avatar_url":"https://avatars.githubusercontent.com/u/2837339?v=3","gravatar_id":"","url":"https://api.github.com/users/strangelydim","html_url":"https://github.com/strangelydim","followers_url":"https://api.github.com/users/strangelydim/followers","following_url":"https://api.github.com/users/strangelydim/following{/other_user}","gists_url":"https://api.github.com/users/strangelydim/gists{/gist_id}","starred_url":"https://api.github.com/users/strangelydim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strangelydim/subscriptions","organizations_url":"https://api.github.com/users/strangelydim/orgs","repos_url":"https://api.github.com/users/strangelydim/repos","events_url":"https://api.github.com/users/strangelydim/events{/privacy}","received_events_url":"https://api.github.com/users/strangelydim/received_events","type":"User","site_admin":false},"repo":{"id":31387795,"name":"Aeron","full_name":"strangelydim/Aeron","owner":{"login":"strangelydim","id":2837339,"avatar_url":"https://avatars.githubusercontent.com/u/2837339?v=3","gravatar_id":"","url":"https://api.github.com/users/strangelydim","html_url":"https://github.com/strangelydim","followers_url":"https://api.github.com/users/strangelydim/followers","following_url":"https://api.github.com/users/strangelydim/following{/other_user}","gists_url":"https://api.github.com/users/strangelydim/gists{/gist_id}","starred_url":"https://api.github.com/users/strangelydim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strangelydim/subscriptions","organizations_url":"https://api.github.com/users/strangelydim/orgs","repos_url":"https://api.github.com/users/strangelydim/repos","events_url":"https://api.github.com/users/strangelydim/events{/privacy}","received_events_url":"https://api.github.com/users/strangelydim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/strangelydim/Aeron","description":"Efficient reliable unicast and multicast message transport","fork":true,"url":"https://api.github.com/repos/strangelydim/Aeron","forks_url":"https://api.github.com/repos/strangelydim/Aeron/forks","keys_url":"https://api.github.com/repos/strangelydim/Aeron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strangelydim/Aeron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strangelydim/Aeron/teams","hooks_url":"https://api.github.com/repos/strangelydim/Aeron/hooks","issue_events_url":"https://api.github.com/repos/strangelydim/Aeron/issues/events{/number}","events_url":"https://api.github.com/repos/strangelydim/Aeron/events","assignees_url":"https://api.github.com/repos/strangelydim/Aeron/assignees{/user}","branches_url":"https://api.github.com/repos/strangelydim/Aeron/branches{/branch}","tags_url":"https://api.github.com/repos/strangelydim/Aeron/tags","blobs_url":"https://api.github.com/repos/strangelydim/Aeron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strangelydim/Aeron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strangelydim/Aeron/git/refs{/sha}","trees_url":"https://api.github.com/repos/strangelydim/Aeron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strangelydim/Aeron/statuses/{sha}","languages_url":"https://api.github.com/repos/strangelydim/Aeron/languages","stargazers_url":"https://api.github.com/repos/strangelydim/Aeron/stargazers","contributors_url":"https://api.github.com/repos/strangelydim/Aeron/contributors","subscribers_url":"https://api.github.com/repos/strangelydim/Aeron/subscribers","subscription_url":"https://api.github.com/repos/strangelydim/Aeron/subscription","commits_url":"https://api.github.com/repos/strangelydim/Aeron/commits{/sha}","git_commits_url":"https://api.github.com/repos/strangelydim/Aeron/git/commits{/sha}","comments_url":"https://api.github.com/repos/strangelydim/Aeron/comments{/number}","issue_comment_url":"https://api.github.com/repos/strangelydim/Aeron/issues/comments{/number}","contents_url":"https://api.github.com/repos/strangelydim/Aeron/contents/{+path}","compare_url":"https://api.github.com/repos/strangelydim/Aeron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strangelydim/Aeron/merges","archive_url":"https://api.github.com/repos/strangelydim/Aeron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strangelydim/Aeron/downloads","issues_url":"https://api.github.com/repos/strangelydim/Aeron/issues{/number}","pulls_url":"https://api.github.com/repos/strangelydim/Aeron/pulls{/number}","milestones_url":"https://api.github.com/repos/strangelydim/Aeron/milestones{/number}","notifications_url":"https://api.github.com/repos/strangelydim/Aeron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strangelydim/Aeron/labels{/name}","releases_url":"https://api.github.com/repos/strangelydim/Aeron/releases{/id}","created_at":"2015-02-26T20:42:10Z","updated_at":"2015-04-30T21:10:22Z","pushed_at":"2015-04-30T22:04:09Z","git_url":"git://github.com/strangelydim/Aeron.git","ssh_url":"git@github.com:strangelydim/Aeron.git","clone_url":"https://github.com/strangelydim/Aeron.git","svn_url":"https://github.com/strangelydim/Aeron","homepage":"","size":12518,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"real-logic:master","ref":"master","sha":"03bb1177b4ce0da3a93c593c268a503ecb4d89e7","user":{"login":"real-logic","id":5371471,"avatar_url":"https://avatars.githubusercontent.com/u/5371471?v=3","gravatar_id":"","url":"https://api.github.com/users/real-logic","html_url":"https://github.com/real-logic","followers_url":"https://api.github.com/users/real-logic/followers","following_url":"https://api.github.com/users/real-logic/following{/other_user}","gists_url":"https://api.github.com/users/real-logic/gists{/gist_id}","starred_url":"https://api.github.com/users/real-logic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real-logic/subscriptions","organizations_url":"https://api.github.com/users/real-logic/orgs","repos_url":"https://api.github.com/users/real-logic/repos","events_url":"https://api.github.com/users/real-logic/events{/privacy}","received_events_url":"https://api.github.com/users/real-logic/received_events","type":"Organization","site_admin":false},"repo":{"id":16621659,"name":"Aeron","full_name":"real-logic/Aeron","owner":{"login":"real-logic","id":5371471,"avatar_url":"https://avatars.githubusercontent.com/u/5371471?v=3","gravatar_id":"","url":"https://api.github.com/users/real-logic","html_url":"https://github.com/real-logic","followers_url":"https://api.github.com/users/real-logic/followers","following_url":"https://api.github.com/users/real-logic/following{/other_user}","gists_url":"https://api.github.com/users/real-logic/gists{/gist_id}","starred_url":"https://api.github.com/users/real-logic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real-logic/subscriptions","organizations_url":"https://api.github.com/users/real-logic/orgs","repos_url":"https://api.github.com/users/real-logic/repos","events_url":"https://api.github.com/users/real-logic/events{/privacy}","received_events_url":"https://api.github.com/users/real-logic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/real-logic/Aeron","description":"Efficient reliable unicast and multicast message transport","fork":false,"url":"https://api.github.com/repos/real-logic/Aeron","forks_url":"https://api.github.com/repos/real-logic/Aeron/forks","keys_url":"https://api.github.com/repos/real-logic/Aeron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/real-logic/Aeron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/real-logic/Aeron/teams","hooks_url":"https://api.github.com/repos/real-logic/Aeron/hooks","issue_events_url":"https://api.github.com/repos/real-logic/Aeron/issues/events{/number}","events_url":"https://api.github.com/repos/real-logic/Aeron/events","assignees_url":"https://api.github.com/repos/real-logic/Aeron/assignees{/user}","branches_url":"https://api.github.com/repos/real-logic/Aeron/branches{/branch}","tags_url":"https://api.github.com/repos/real-logic/Aeron/tags","blobs_url":"https://api.github.com/repos/real-logic/Aeron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/real-logic/Aeron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/real-logic/Aeron/git/refs{/sha}","trees_url":"https://api.github.com/repos/real-logic/Aeron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/real-logic/Aeron/statuses/{sha}","languages_url":"https://api.github.com/repos/real-logic/Aeron/languages","stargazers_url":"https://api.github.com/repos/real-logic/Aeron/stargazers","contributors_url":"https://api.github.com/repos/real-logic/Aeron/contributors","subscribers_url":"https://api.github.com/repos/real-logic/Aeron/subscribers","subscription_url":"https://api.github.com/repos/real-logic/Aeron/subscription","commits_url":"https://api.github.com/repos/real-logic/Aeron/commits{/sha}","git_commits_url":"https://api.github.com/repos/real-logic/Aeron/git/commits{/sha}","comments_url":"https://api.github.com/repos/real-logic/Aeron/comments{/number}","issue_comment_url":"https://api.github.com/repos/real-logic/Aeron/issues/comments{/number}","contents_url":"https://api.github.com/repos/real-logic/Aeron/contents/{+path}","compare_url":"https://api.github.com/repos/real-logic/Aeron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/real-logic/Aeron/merges","archive_url":"https://api.github.com/repos/real-logic/Aeron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/real-logic/Aeron/downloads","issues_url":"https://api.github.com/repos/real-logic/Aeron/issues{/number}","pulls_url":"https://api.github.com/repos/real-logic/Aeron/pulls{/number}","milestones_url":"https://api.github.com/repos/real-logic/Aeron/milestones{/number}","notifications_url":"https://api.github.com/repos/real-logic/Aeron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/real-logic/Aeron/labels{/name}","releases_url":"https://api.github.com/repos/real-logic/Aeron/releases{/id}","created_at":"2014-02-07T17:16:58Z","updated_at":"2015-05-01T08:20:50Z","pushed_at":"2015-05-01T07:52:56Z","git_url":"git://github.com/real-logic/Aeron.git","ssh_url":"git@github.com:real-logic/Aeron.git","clone_url":"https://github.com/real-logic/Aeron.git","svn_url":"https://github.com/real-logic/Aeron","homepage":"","size":20103,"stargazers_count":1015,"watchers_count":1015,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":24,"forks":121,"open_issues":24,"watchers":1015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/108"},"html":{"href":"https://github.com/real-logic/Aeron/pull/108"},"issue":{"href":"https://api.github.com/repos/real-logic/Aeron/issues/108"},"comments":{"href":"https://api.github.com/repos/real-logic/Aeron/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/real-logic/Aeron/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/real-logic/Aeron/statuses/7da4480cf7afb219e78d9fcb163d28d126a3da39"}}}}