{"action":"created","issue":{"url":"https://api.github.com/repos/jgoppert/Firmware/issues/20","labels_url":"https://api.github.com/repos/jgoppert/Firmware/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/jgoppert/Firmware/issues/20/comments","events_url":"https://api.github.com/repos/jgoppert/Firmware/issues/20/events","html_url":"https://github.com/jgoppert/Firmware/pull/20","id":104545274,"number":20,"title":"Cmake","user":{"login":"jgoppert","id":473772,"avatar_url":"https://avatars.githubusercontent.com/u/473772?v=3","gravatar_id":"","url":"https://api.github.com/users/jgoppert","html_url":"https://github.com/jgoppert","followers_url":"https://api.github.com/users/jgoppert/followers","following_url":"https://api.github.com/users/jgoppert/following{/other_user}","gists_url":"https://api.github.com/users/jgoppert/gists{/gist_id}","starred_url":"https://api.github.com/users/jgoppert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgoppert/subscriptions","organizations_url":"https://api.github.com/users/jgoppert/orgs","repos_url":"https://api.github.com/users/jgoppert/repos","events_url":"https://api.github.com/users/jgoppert/events{/privacy}","received_events_url":"https://api.github.com/users/jgoppert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-09-02T18:35:52Z","updated_at":"2015-09-04T06:13:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jgoppert/Firmware/pulls/20","html_url":"https://github.com/jgoppert/Firmware/pull/20","diff_url":"https://github.com/jgoppert/Firmware/pull/20.diff","patch_url":"https://github.com/jgoppert/Firmware/pull/20.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/jgoppert/Firmware/issues/comments/137656629","html_url":"https://github.com/jgoppert/Firmware/pull/20#issuecomment-137656629","issue_url":"https://api.github.com/repos/jgoppert/Firmware/issues/20","id":137656629,"user":{"login":"mcharleb","id":848323,"avatar_url":"https://avatars.githubusercontent.com/u/848323?v=3","gravatar_id":"","url":"https://api.github.com/users/mcharleb","html_url":"https://github.com/mcharleb","followers_url":"https://api.github.com/users/mcharleb/followers","following_url":"https://api.github.com/users/mcharleb/following{/other_user}","gists_url":"https://api.github.com/users/mcharleb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharleb/subscriptions","organizations_url":"https://api.github.com/users/mcharleb/orgs","repos_url":"https://api.github.com/users/mcharleb/repos","events_url":"https://api.github.com/users/mcharleb/events{/privacy}","received_events_url":"https://api.github.com/users/mcharleb/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T06:13:07Z","updated_at":"2015-09-04T06:13:07Z","body":"I don't like the following syntax for specifying the modules:\n\nset(module_list\nexamples_px4_simple_app\nmodules_uORB\n)\n\nYou can't tell dir names from names with underscores in them.\n\nThe more that I try to follow the requirement that module CMakeLists.txt\ncan't call add_library(), the more I think that is broken.\n\nI am having to specify the full paths to all source files when I call\nadd_library(module ... $(srcs)) from the top CMakeLists.txt file. That\ndefeats the whole scoping behavior of the module directories.\n\n-Mark\n\nOn Thu, Sep 3, 2015 at 10:47 PM, James Goppert <notifications@github.com>\nwrote:\n\n> @mcharleb <https://github.com/mcharleb>\n> OK. I am trying something totally different here, let me know what you\n> think:\n>\n> The basic idea is to add every single CMakeLists.txt file, but only build\n> the ones you want by specifying the module names in the module list.\n> https://github.com/jgoppert/Firmware/blob/cmake-2/CMakeLists.txt\n>\n> This usese a cmake function to basically create a new add_library type\n> command, but specific for px4. I setting the main function, stack etc. as\n> target properties, this allows us to retrieve them later without the\n> directory property hack.\n>\n> https://github.com/jgoppert/Firmware/blob/cmake-2/src/modules/commander/CMakeLists.txt\n>\n> I also improved the px4_utils and added docs:\n> https://github.com/jgoppert/Firmware/blob/cmake-2/cmake/px4_utils.cmake\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/jgoppert/Firmware/pull/20#issuecomment-137654150>.\n>\n"}}