{"action":"created","issue":{"url":"https://api.github.com/repos/itesla/ipsl/issues/52","labels_url":"https://api.github.com/repos/itesla/ipsl/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/itesla/ipsl/issues/52/comments","events_url":"https://api.github.com/repos/itesla/ipsl/issues/52/events","html_url":"https://github.com/itesla/ipsl/issues/52","id":122093472,"number":52,"title":"\"External Variables\" and \"Internal Variables\" in iPSL","user":{"login":"MaximeBaudette","id":15156063,"avatar_url":"https://avatars.githubusercontent.com/u/15156063?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximeBaudette","html_url":"https://github.com/MaximeBaudette","followers_url":"https://api.github.com/users/MaximeBaudette/followers","following_url":"https://api.github.com/users/MaximeBaudette/following{/other_user}","gists_url":"https://api.github.com/users/MaximeBaudette/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximeBaudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximeBaudette/subscriptions","organizations_url":"https://api.github.com/users/MaximeBaudette/orgs","repos_url":"https://api.github.com/users/MaximeBaudette/repos","events_url":"https://api.github.com/users/MaximeBaudette/events{/privacy}","received_events_url":"https://api.github.com/users/MaximeBaudette/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/itesla/ipsl/milestones/1","html_url":"https://github.com/itesla/ipsl/milestones/Release%200.9","labels_url":"https://api.github.com/repos/itesla/ipsl/milestones/1/labels","id":1399641,"number":1,"title":"Release 0.9","description":"","creator":{"login":"MaximeBaudette","id":15156063,"avatar_url":"https://avatars.githubusercontent.com/u/15156063?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximeBaudette","html_url":"https://github.com/MaximeBaudette","followers_url":"https://api.github.com/users/MaximeBaudette/followers","following_url":"https://api.github.com/users/MaximeBaudette/following{/other_user}","gists_url":"https://api.github.com/users/MaximeBaudette/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximeBaudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximeBaudette/subscriptions","organizations_url":"https://api.github.com/users/MaximeBaudette/orgs","repos_url":"https://api.github.com/users/MaximeBaudette/repos","events_url":"https://api.github.com/users/MaximeBaudette/events{/privacy}","received_events_url":"https://api.github.com/users/MaximeBaudette/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2015-11-07T20:32:05Z","updated_at":"2015-12-15T23:15:23Z","due_on":"2016-01-30T23:00:00Z","closed_at":null},"comments":7,"created_at":"2015-12-14T17:44:07Z","updated_at":"2015-12-16T08:34:22Z","closed_at":null,"body":"I stumbled upon a mistake in the PSAT LOADPQ model concerning the equations related to the change of base. \r\n\r\nIn all models of the iPSL the following convention must be respected and correctly implemented:\r\n- Power Flow data should be entered with the following units (from pfComponent)\r\n  - V_0 in pu\r\n  - angle_0 in degrees\r\n  - P_0 in MW\r\n  - Q_0 in MVAr\r\n- Interface variables ( or display variables) (used in the equations involving p.vr, p.vi, p.ir, p.ii)\r\n  - v in pu (using the bus nominal voltage as base)\r\n  - angle_v in degrees\r\n  - P in pu (system base)\r\n  - Q in pu (system base)\r\n- Internal variables (component variables):\r\n  - v in pu (using the voltage rating of the component)\r\n  - angle_v in whatever you want as long as you specify it and do appropriate conversions\r\n  - P in pu (Machine base)\r\n  - Q in pu (Machine base)\r\n\r\nAlso we should find a naming convention to distinguish the \"internal variables\" form the \"interface variables\", so we don't mix them. \r\nI propose the suffix \"_int\", so we have: v_int, angle_v_int, P_int, Q_int (if there is a need for such internal variables, not all component require it)"},"comment":{"url":"https://api.github.com/repos/itesla/ipsl/issues/comments/165032205","html_url":"https://github.com/itesla/ipsl/issues/52#issuecomment-165032205","issue_url":"https://api.github.com/repos/itesla/ipsl/issues/52","id":165032205,"user":{"login":"MaximeBaudette","id":15156063,"avatar_url":"https://avatars.githubusercontent.com/u/15156063?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximeBaudette","html_url":"https://github.com/MaximeBaudette","followers_url":"https://api.github.com/users/MaximeBaudette/followers","following_url":"https://api.github.com/users/MaximeBaudette/following{/other_user}","gists_url":"https://api.github.com/users/MaximeBaudette/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximeBaudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximeBaudette/subscriptions","organizations_url":"https://api.github.com/users/MaximeBaudette/orgs","repos_url":"https://api.github.com/users/MaximeBaudette/repos","events_url":"https://api.github.com/users/MaximeBaudette/events{/privacy}","received_events_url":"https://api.github.com/users/MaximeBaudette/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T08:34:22Z","updated_at":"2015-12-16T08:34:22Z","body":"@petitrenaudseb \r\nWhen I proposed the units, a long time ago, I did with the intention of picking an option that would lead to the least confusion. At that time there was often confusion between the per unit in the system base and machine base, hence the power in physical units. \r\n\r\nI am of course open for discussion. Maybe we could reinstate the power flow data in per unit for everything, but then we need to agree on how to mark the per unit in the system base (for power flow data), and per unit in the machine base . "}}