{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/tj/connect-redis/pulls/95","id":10862151,"html_url":"https://github.com/tj/connect-redis/pull/95","diff_url":"https://github.com/tj/connect-redis/pull/95.diff","patch_url":"https://github.com/tj/connect-redis/pull/95.patch","issue_url":"https://api.github.com/repos/tj/connect-redis/issues/95","number":95,"state":"closed","locked":false,"title":"store: fix silently swallowing redis errors","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"body":"This allows errors to propagate properly.\r\n\r\nHaving connect-redis listen to this prevents the exception from being thrown. However, since we might still want to pass the error down the stack, log what the error was anyways, just in case.\r\n\r\n\r\n@visionmedia I'm guessing it would be better to throw an actual exception, but I'm not sure how to do that with a pre-existing Error object and listeners.","created_at":"2013-12-16T17:03:58Z","updated_at":"2015-01-23T04:40:45Z","closed_at":"2015-01-23T04:40:45Z","merged_at":null,"merge_commit_sha":"d4af825315d87c56e9c9ce57e9533a480da27d54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tj/connect-redis/pulls/95/commits","review_comments_url":"https://api.github.com/repos/tj/connect-redis/pulls/95/comments","review_comment_url":"https://api.github.com/repos/tj/connect-redis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tj/connect-redis/issues/95/comments","statuses_url":"https://api.github.com/repos/tj/connect-redis/statuses/4cc5d09fe07e669120f8f114aa29bc14bd56efca","head":{"label":"Fishrock123:master","ref":"master","sha":"4cc5d09fe07e669120f8f114aa29bc14bd56efca","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"repo":{"id":15231469,"name":"connect-redis","full_name":"Fishrock123/connect-redis","owner":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fishrock123/connect-redis","description":"Redis session store for Connect","fork":true,"url":"https://api.github.com/repos/Fishrock123/connect-redis","forks_url":"https://api.github.com/repos/Fishrock123/connect-redis/forks","keys_url":"https://api.github.com/repos/Fishrock123/connect-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fishrock123/connect-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fishrock123/connect-redis/teams","hooks_url":"https://api.github.com/repos/Fishrock123/connect-redis/hooks","issue_events_url":"https://api.github.com/repos/Fishrock123/connect-redis/issues/events{/number}","events_url":"https://api.github.com/repos/Fishrock123/connect-redis/events","assignees_url":"https://api.github.com/repos/Fishrock123/connect-redis/assignees{/user}","branches_url":"https://api.github.com/repos/Fishrock123/connect-redis/branches{/branch}","tags_url":"https://api.github.com/repos/Fishrock123/connect-redis/tags","blobs_url":"https://api.github.com/repos/Fishrock123/connect-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fishrock123/connect-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fishrock123/connect-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fishrock123/connect-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fishrock123/connect-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/Fishrock123/connect-redis/languages","stargazers_url":"https://api.github.com/repos/Fishrock123/connect-redis/stargazers","contributors_url":"https://api.github.com/repos/Fishrock123/connect-redis/contributors","subscribers_url":"https://api.github.com/repos/Fishrock123/connect-redis/subscribers","subscription_url":"https://api.github.com/repos/Fishrock123/connect-redis/subscription","commits_url":"https://api.github.com/repos/Fishrock123/connect-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fishrock123/connect-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fishrock123/connect-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fishrock123/connect-redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/Fishrock123/connect-redis/contents/{+path}","compare_url":"https://api.github.com/repos/Fishrock123/connect-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fishrock123/connect-redis/merges","archive_url":"https://api.github.com/repos/Fishrock123/connect-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fishrock123/connect-redis/downloads","issues_url":"https://api.github.com/repos/Fishrock123/connect-redis/issues{/number}","pulls_url":"https://api.github.com/repos/Fishrock123/connect-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/Fishrock123/connect-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/Fishrock123/connect-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fishrock123/connect-redis/labels{/name}","releases_url":"https://api.github.com/repos/Fishrock123/connect-redis/releases{/id}","created_at":"2013-12-16T16:53:10Z","updated_at":"2014-08-19T14:32:43Z","pushed_at":"2014-08-19T14:34:10Z","git_url":"git://github.com/Fishrock123/connect-redis.git","ssh_url":"git@github.com:Fishrock123/connect-redis.git","clone_url":"https://github.com/Fishrock123/connect-redis.git","svn_url":"https://github.com/Fishrock123/connect-redis","homepage":"","size":324,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tj:master","ref":"master","sha":"68ad0d05f3b3e88e6e55067cb7e8fbf85300bc21","user":{"login":"tj","id":25254,"avatar_url":"https://avatars.githubusercontent.com/u/25254?v=3","gravatar_id":"","url":"https://api.github.com/users/tj","html_url":"https://github.com/tj","followers_url":"https://api.github.com/users/tj/followers","following_url":"https://api.github.com/users/tj/following{/other_user}","gists_url":"https://api.github.com/users/tj/gists{/gist_id}","starred_url":"https://api.github.com/users/tj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj/subscriptions","organizations_url":"https://api.github.com/users/tj/orgs","repos_url":"https://api.github.com/users/tj/repos","events_url":"https://api.github.com/users/tj/events{/privacy}","received_events_url":"https://api.github.com/users/tj/received_events","type":"User","site_admin":false},"repo":{"id":771088,"name":"connect-redis","full_name":"tj/connect-redis","owner":{"login":"tj","id":25254,"avatar_url":"https://avatars.githubusercontent.com/u/25254?v=3","gravatar_id":"","url":"https://api.github.com/users/tj","html_url":"https://github.com/tj","followers_url":"https://api.github.com/users/tj/followers","following_url":"https://api.github.com/users/tj/following{/other_user}","gists_url":"https://api.github.com/users/tj/gists{/gist_id}","starred_url":"https://api.github.com/users/tj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj/subscriptions","organizations_url":"https://api.github.com/users/tj/orgs","repos_url":"https://api.github.com/users/tj/repos","events_url":"https://api.github.com/users/tj/events{/privacy}","received_events_url":"https://api.github.com/users/tj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tj/connect-redis","description":"Redis session store for Connect","fork":false,"url":"https://api.github.com/repos/tj/connect-redis","forks_url":"https://api.github.com/repos/tj/connect-redis/forks","keys_url":"https://api.github.com/repos/tj/connect-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tj/connect-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tj/connect-redis/teams","hooks_url":"https://api.github.com/repos/tj/connect-redis/hooks","issue_events_url":"https://api.github.com/repos/tj/connect-redis/issues/events{/number}","events_url":"https://api.github.com/repos/tj/connect-redis/events","assignees_url":"https://api.github.com/repos/tj/connect-redis/assignees{/user}","branches_url":"https://api.github.com/repos/tj/connect-redis/branches{/branch}","tags_url":"https://api.github.com/repos/tj/connect-redis/tags","blobs_url":"https://api.github.com/repos/tj/connect-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tj/connect-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tj/connect-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/tj/connect-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tj/connect-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/tj/connect-redis/languages","stargazers_url":"https://api.github.com/repos/tj/connect-redis/stargazers","contributors_url":"https://api.github.com/repos/tj/connect-redis/contributors","subscribers_url":"https://api.github.com/repos/tj/connect-redis/subscribers","subscription_url":"https://api.github.com/repos/tj/connect-redis/subscription","commits_url":"https://api.github.com/repos/tj/connect-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/tj/connect-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/tj/connect-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/tj/connect-redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/tj/connect-redis/contents/{+path}","compare_url":"https://api.github.com/repos/tj/connect-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tj/connect-redis/merges","archive_url":"https://api.github.com/repos/tj/connect-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tj/connect-redis/downloads","issues_url":"https://api.github.com/repos/tj/connect-redis/issues{/number}","pulls_url":"https://api.github.com/repos/tj/connect-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/tj/connect-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/tj/connect-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tj/connect-redis/labels{/name}","releases_url":"https://api.github.com/repos/tj/connect-redis/releases{/id}","created_at":"2010-07-12T19:47:08Z","updated_at":"2015-01-23T04:38:50Z","pushed_at":"2015-01-23T04:38:50Z","git_url":"git://github.com/tj/connect-redis.git","ssh_url":"git@github.com:tj/connect-redis.git","clone_url":"https://github.com/tj/connect-redis.git","svn_url":"https://github.com/tj/connect-redis","homepage":"","size":680,"stargazers_count":759,"watchers_count":759,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":1,"forks":125,"open_issues":1,"watchers":759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tj/connect-redis/pulls/95"},"html":{"href":"https://github.com/tj/connect-redis/pull/95"},"issue":{"href":"https://api.github.com/repos/tj/connect-redis/issues/95"},"comments":{"href":"https://api.github.com/repos/tj/connect-redis/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/tj/connect-redis/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/tj/connect-redis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tj/connect-redis/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/tj/connect-redis/statuses/4cc5d09fe07e669120f8f114aa29bc14bd56efca"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":16,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":1}}