{"action":"created","issue":{"url":"https://api.github.com/repos/jpd002/Play-/issues/289","labels_url":"https://api.github.com/repos/jpd002/Play-/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/jpd002/Play-/issues/289/comments","events_url":"https://api.github.com/repos/jpd002/Play-/issues/289/events","html_url":"https://github.com/jpd002/Play-/pull/289","id":100054241,"number":289,"title":"Android_UI:Theme Selector and related fixes","user":{"login":"Thunder07","id":5013823,"avatar_url":"https://avatars.githubusercontent.com/u/5013823?v=3","gravatar_id":"","url":"https://api.github.com/users/Thunder07","html_url":"https://github.com/Thunder07","followers_url":"https://api.github.com/users/Thunder07/followers","following_url":"https://api.github.com/users/Thunder07/following{/other_user}","gists_url":"https://api.github.com/users/Thunder07/gists{/gist_id}","starred_url":"https://api.github.com/users/Thunder07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thunder07/subscriptions","organizations_url":"https://api.github.com/users/Thunder07/orgs","repos_url":"https://api.github.com/users/Thunder07/repos","events_url":"https://api.github.com/users/Thunder07/events{/privacy}","received_events_url":"https://api.github.com/users/Thunder07/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-10T12:44:20Z","updated_at":"2015-08-11T13:56:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jpd002/Play-/pulls/289","html_url":"https://github.com/jpd002/Play-/pull/289","diff_url":"https://github.com/jpd002/Play-/pull/289.diff","patch_url":"https://github.com/jpd002/Play-/pull/289.patch"},"body":"Android:Set Column Width Needed For autocolumn to work:\r\nif you look at this one, you'd notice I've only set gridview column width for isConfigured\r\nthe reason is, we are using a fixed dp for covers as such i was comfortable using that value.\r\nbut for \"if (){} else {//this}\" I didn't set the size as 'else' would set the column size for the initial file picker... however without setting an actual width, only 2 column would ever appear, irrespective to screen space.\r\nas such, I'd recommend you try and remove the if statement as see if gameGrid.setColumnWidth((int) getResources().getDimension(R.dimen.cover_width)); itself is good enough to be used for the initial file picker as well.\r\n\r\nAndroid:Remove TableLayout, Fxed Padding, Small Clean ups.\r\nAndroid:Fix:Fixed Padding\r\nAndroid:Removed LinerLayout (redundant)\r\nshould be all one commit, but i only realised the mistake after committing and the last one was a result of rebase, since tablelayout was changed, it wasnt removed by the initial commit.\r\nanyways, just so, the padding issue, didn't exits before the merger(that enabled rotation), since screen orientation was fixed, but now everytime the screen is turned, it would cause more padding to be added causing it to build up, as such i'm using the relative_layout_original_right_padding to get the original padding, so i can reset the padding according to orientation each time.\r\nas for removing TableLayout/LinerLayout, now we're using the gridview for both the initial file picker and cover display (game picker), thus it's not needed.\r\n\r\nI know this pull is part fixes and part a new feature, but since they're all ui as such somewhat interconnected, there was little point in splitting them.\r\nagain, you can always cherry-pick things out if you dont want them.\r\n\r\nAndroid:Fixed Padding, fixes cover disappearing before the actionbar and also adds bottom padding, so that bottom covers and not be at the very edge of the screen.\r\n\r\nedit: the last commit's title is self explain\r\n2nd last just moves the settings UI around"},"comment":{"url":"https://api.github.com/repos/jpd002/Play-/issues/comments/129884570","html_url":"https://github.com/jpd002/Play-/pull/289#issuecomment-129884570","issue_url":"https://api.github.com/repos/jpd002/Play-/issues/289","id":129884570,"user":{"login":"Thunder07","id":5013823,"avatar_url":"https://avatars.githubusercontent.com/u/5013823?v=3","gravatar_id":"","url":"https://api.github.com/users/Thunder07","html_url":"https://github.com/Thunder07","followers_url":"https://api.github.com/users/Thunder07/followers","following_url":"https://api.github.com/users/Thunder07/following{/other_user}","gists_url":"https://api.github.com/users/Thunder07/gists{/gist_id}","starred_url":"https://api.github.com/users/Thunder07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thunder07/subscriptions","organizations_url":"https://api.github.com/users/Thunder07/orgs","repos_url":"https://api.github.com/users/Thunder07/repos","events_url":"https://api.github.com/users/Thunder07/events{/privacy}","received_events_url":"https://api.github.com/users/Thunder07/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T13:56:29Z","updated_at":"2015-08-11T13:56:29Z","body":"Ya, turn it around with only 1 or 2 column and you'd see what I mean. I'm not saying it doesn't work, but it can be a bit better (again, this is mostly design preference, so we can go at it all day, I rather not)\r\nBut one last thing, since you posted the screen shot, I didn't consider vertical space as well, but that's solvable by centering the gridview. "}}