{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/34963492","id":34963492,"diff_hunk":"@@ -85,6 +85,10 @@ static String getOsPrincipalClassName() {\n     return principalClassName;\n   }\n \n+  static String getOsPrincipalStr() {","path":"common/src/main/java/tachyon/security/UserInformation.java","position":4,"original_position":4,"commit_id":"a7703404ca902d1035fabdf11a1046c3c9261d33","original_commit_id":"a7703404ca902d1035fabdf11a1046c3c9261d33","user":{"login":"ooq","id":5876435,"avatar_url":"https://avatars.githubusercontent.com/u/5876435?v=3","gravatar_id":"","url":"https://api.github.com/users/ooq","html_url":"https://github.com/ooq","followers_url":"https://api.github.com/users/ooq/followers","following_url":"https://api.github.com/users/ooq/following{/other_user}","gists_url":"https://api.github.com/users/ooq/gists{/gist_id}","starred_url":"https://api.github.com/users/ooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooq/subscriptions","organizations_url":"https://api.github.com/users/ooq/orgs","repos_url":"https://api.github.com/users/ooq/repos","events_url":"https://api.github.com/users/ooq/events{/privacy}","received_events_url":"https://api.github.com/users/ooq/received_events","type":"User","site_admin":false},"body":"The naming is a bit confusing. Maybe something like `getOsPrincipleClassName` ? Now it feels like you are getting a user string.","created_at":"2015-07-19T23:12:42Z","updated_at":"2015-07-19T23:12:42Z","html_url":"https://github.com/amplab/tachyon/pull/1099#discussion_r34963492","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1099","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/34963492"},"html":{"href":"https://github.com/amplab/tachyon/pull/1099#discussion_r34963492"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1099"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1099","id":39780483,"html_url":"https://github.com/amplab/tachyon/pull/1099","diff_url":"https://github.com/amplab/tachyon/pull/1099.diff","patch_url":"https://github.com/amplab/tachyon/pull/1099.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1099","number":1099,"state":"open","locked":false,"title":"[TACHYON-602] Login Mechanism: Add TACHYON_LOGIN_MODULE","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"body":"JIRA: https://tachyon.atlassian.net/browse/TACHYON-602\r\n\r\nThis is the 2nd step to implement login mechanism.\r\nWe add a customized TachyonLoginModule extends LoginModule. This will extract the OS user added in Subject by OS_LOGIN_MODULE, convert to Tachyon user, and add it into Subject.","created_at":"2015-07-13T05:40:54Z","updated_at":"2015-07-19T23:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb1d80cab74558ad91097e6209426ea85a058eca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1099/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1099/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1099/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/a7703404ca902d1035fabdf11a1046c3c9261d33","head":{"label":"dongche:security-602","ref":"security-602","sha":"a7703404ca902d1035fabdf11a1046c3c9261d33","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"repo":{"id":38419009,"name":"tachyon","full_name":"dongche/tachyon","owner":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dongche/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/dongche/tachyon","forks_url":"https://api.github.com/repos/dongche/tachyon/forks","keys_url":"https://api.github.com/repos/dongche/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dongche/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dongche/tachyon/teams","hooks_url":"https://api.github.com/repos/dongche/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dongche/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dongche/tachyon/events","assignees_url":"https://api.github.com/repos/dongche/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dongche/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dongche/tachyon/tags","blobs_url":"https://api.github.com/repos/dongche/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dongche/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dongche/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dongche/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dongche/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dongche/tachyon/languages","stargazers_url":"https://api.github.com/repos/dongche/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dongche/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dongche/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dongche/tachyon/subscription","commits_url":"https://api.github.com/repos/dongche/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dongche/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dongche/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dongche/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dongche/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dongche/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dongche/tachyon/merges","archive_url":"https://api.github.com/repos/dongche/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dongche/tachyon/downloads","issues_url":"https://api.github.com/repos/dongche/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dongche/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dongche/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dongche/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dongche/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dongche/tachyon/releases{/id}","created_at":"2015-07-02T07:53:56Z","updated_at":"2015-07-02T07:53:58Z","pushed_at":"2015-07-15T03:02:15Z","git_url":"git://github.com/dongche/tachyon.git","ssh_url":"git@github.com:dongche/tachyon.git","clone_url":"https://github.com/dongche/tachyon.git","svn_url":"https://github.com/dongche/tachyon","homepage":"http://tachyon-project.org","size":14895,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:security","ref":"security","sha":"683a0072da826b9ffd913f4461adf1c9602c8fe9","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-07-19T08:25:48Z","pushed_at":"2015-07-19T21:09:04Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":35908,"stargazers_count":1479,"watchers_count":1479,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":558,"mirror_url":null,"open_issues_count":21,"forks":558,"open_issues":21,"watchers":1479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1099"},"html":{"href":"https://github.com/amplab/tachyon/pull/1099"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1099"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1099/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1099/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1099/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/a7703404ca902d1035fabdf11a1046c3c9261d33"}}}}