{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/gilt/gfc-guava/pulls/1","id":29832361,"html_url":"https://github.com/gilt/gfc-guava/pull/1","diff_url":"https://github.com/gilt/gfc-guava/pull/1.diff","patch_url":"https://github.com/gilt/gfc-guava/pull/1.patch","issue_url":"https://api.github.com/repos/gilt/gfc-guava/issues/1","number":1,"state":"open","locked":false,"title":"Deprecate RichListenableFuture in favor of converting ListenableFuture to a Scala Future.","user":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"body":"Under the hood RichListenableFuture relies on Guava's transform function without specifying an executor to execute the transformation. From the Guava documentation:\r\n\r\n_Note: If the transformation is slow or heavyweight, consider supplying an executor. If you do not supply an executor, transform will use sameThreadExecutor, which carries some caveats for heavier operations. For example, the call to function.apply may run on an unpredictable or undesirable thread:_\r\n\r\n  * _If the input Future is done at the time transform is called, transform will call function.apply inline._\r\n  * _If the input Future is not yet done, transform will schedule function.apply to be run by the thread that completes the input Future, which may be an internal system thread such as an RPC network thread._\r\n\r\nThis is obviously not terribly safe. Using a Scala Future is a much better option so deprecating RichListenableFuture seems like a good path forward.","created_at":"2015-02-23T18:24:24Z","updated_at":"2015-02-23T18:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gilt/gfc-guava/pulls/1/commits","review_comments_url":"https://api.github.com/repos/gilt/gfc-guava/pulls/1/comments","review_comment_url":"https://api.github.com/repos/gilt/gfc-guava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gilt/gfc-guava/issues/1/comments","statuses_url":"https://api.github.com/repos/gilt/gfc-guava/statuses/6dc9555cd9aa433f81ece79ea25674667eceecc6","head":{"label":"eczarny:eczarny/deprecations","ref":"eczarny/deprecations","sha":"6dc9555cd9aa433f81ece79ea25674667eceecc6","user":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"repo":{"id":31222055,"name":"gfc-guava","full_name":"eczarny/gfc-guava","owner":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eczarny/gfc-guava","description":"A library that contains utility classes and Scala adapters and adaptations for Google Guava","fork":true,"url":"https://api.github.com/repos/eczarny/gfc-guava","forks_url":"https://api.github.com/repos/eczarny/gfc-guava/forks","keys_url":"https://api.github.com/repos/eczarny/gfc-guava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eczarny/gfc-guava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eczarny/gfc-guava/teams","hooks_url":"https://api.github.com/repos/eczarny/gfc-guava/hooks","issue_events_url":"https://api.github.com/repos/eczarny/gfc-guava/issues/events{/number}","events_url":"https://api.github.com/repos/eczarny/gfc-guava/events","assignees_url":"https://api.github.com/repos/eczarny/gfc-guava/assignees{/user}","branches_url":"https://api.github.com/repos/eczarny/gfc-guava/branches{/branch}","tags_url":"https://api.github.com/repos/eczarny/gfc-guava/tags","blobs_url":"https://api.github.com/repos/eczarny/gfc-guava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eczarny/gfc-guava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eczarny/gfc-guava/git/refs{/sha}","trees_url":"https://api.github.com/repos/eczarny/gfc-guava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eczarny/gfc-guava/statuses/{sha}","languages_url":"https://api.github.com/repos/eczarny/gfc-guava/languages","stargazers_url":"https://api.github.com/repos/eczarny/gfc-guava/stargazers","contributors_url":"https://api.github.com/repos/eczarny/gfc-guava/contributors","subscribers_url":"https://api.github.com/repos/eczarny/gfc-guava/subscribers","subscription_url":"https://api.github.com/repos/eczarny/gfc-guava/subscription","commits_url":"https://api.github.com/repos/eczarny/gfc-guava/commits{/sha}","git_commits_url":"https://api.github.com/repos/eczarny/gfc-guava/git/commits{/sha}","comments_url":"https://api.github.com/repos/eczarny/gfc-guava/comments{/number}","issue_comment_url":"https://api.github.com/repos/eczarny/gfc-guava/issues/comments{/number}","contents_url":"https://api.github.com/repos/eczarny/gfc-guava/contents/{+path}","compare_url":"https://api.github.com/repos/eczarny/gfc-guava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eczarny/gfc-guava/merges","archive_url":"https://api.github.com/repos/eczarny/gfc-guava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eczarny/gfc-guava/downloads","issues_url":"https://api.github.com/repos/eczarny/gfc-guava/issues{/number}","pulls_url":"https://api.github.com/repos/eczarny/gfc-guava/pulls{/number}","milestones_url":"https://api.github.com/repos/eczarny/gfc-guava/milestones{/number}","notifications_url":"https://api.github.com/repos/eczarny/gfc-guava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eczarny/gfc-guava/labels{/name}","releases_url":"https://api.github.com/repos/eczarny/gfc-guava/releases{/id}","created_at":"2015-02-23T18:18:26Z","updated_at":"2015-02-23T18:18:27Z","pushed_at":"2015-02-23T18:19:44Z","git_url":"git://github.com/eczarny/gfc-guava.git","ssh_url":"git@github.com:eczarny/gfc-guava.git","clone_url":"https://github.com/eczarny/gfc-guava.git","svn_url":"https://github.com/eczarny/gfc-guava","homepage":"","size":333,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gilt:master","ref":"master","sha":"0467ed341fcf0b15f4aa9a56a466f8fe332ecabf","user":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"repo":{"id":22108438,"name":"gfc-guava","full_name":"gilt/gfc-guava","owner":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gilt/gfc-guava","description":"A library that contains utility classes and Scala adapters and adaptations for Google Guava","fork":false,"url":"https://api.github.com/repos/gilt/gfc-guava","forks_url":"https://api.github.com/repos/gilt/gfc-guava/forks","keys_url":"https://api.github.com/repos/gilt/gfc-guava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilt/gfc-guava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilt/gfc-guava/teams","hooks_url":"https://api.github.com/repos/gilt/gfc-guava/hooks","issue_events_url":"https://api.github.com/repos/gilt/gfc-guava/issues/events{/number}","events_url":"https://api.github.com/repos/gilt/gfc-guava/events","assignees_url":"https://api.github.com/repos/gilt/gfc-guava/assignees{/user}","branches_url":"https://api.github.com/repos/gilt/gfc-guava/branches{/branch}","tags_url":"https://api.github.com/repos/gilt/gfc-guava/tags","blobs_url":"https://api.github.com/repos/gilt/gfc-guava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilt/gfc-guava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilt/gfc-guava/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilt/gfc-guava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilt/gfc-guava/statuses/{sha}","languages_url":"https://api.github.com/repos/gilt/gfc-guava/languages","stargazers_url":"https://api.github.com/repos/gilt/gfc-guava/stargazers","contributors_url":"https://api.github.com/repos/gilt/gfc-guava/contributors","subscribers_url":"https://api.github.com/repos/gilt/gfc-guava/subscribers","subscription_url":"https://api.github.com/repos/gilt/gfc-guava/subscription","commits_url":"https://api.github.com/repos/gilt/gfc-guava/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilt/gfc-guava/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilt/gfc-guava/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilt/gfc-guava/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilt/gfc-guava/contents/{+path}","compare_url":"https://api.github.com/repos/gilt/gfc-guava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilt/gfc-guava/merges","archive_url":"https://api.github.com/repos/gilt/gfc-guava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilt/gfc-guava/downloads","issues_url":"https://api.github.com/repos/gilt/gfc-guava/issues{/number}","pulls_url":"https://api.github.com/repos/gilt/gfc-guava/pulls{/number}","milestones_url":"https://api.github.com/repos/gilt/gfc-guava/milestones{/number}","notifications_url":"https://api.github.com/repos/gilt/gfc-guava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilt/gfc-guava/labels{/name}","releases_url":"https://api.github.com/repos/gilt/gfc-guava/releases{/id}","created_at":"2014-07-22T15:01:23Z","updated_at":"2015-02-11T08:44:59Z","pushed_at":"2015-02-11T08:44:59Z","git_url":"git://github.com/gilt/gfc-guava.git","ssh_url":"git@github.com:gilt/gfc-guava.git","clone_url":"https://github.com/gilt/gfc-guava.git","svn_url":"https://github.com/gilt/gfc-guava","homepage":"","size":333,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gilt/gfc-guava/pulls/1"},"html":{"href":"https://github.com/gilt/gfc-guava/pull/1"},"issue":{"href":"https://api.github.com/repos/gilt/gfc-guava/issues/1"},"comments":{"href":"https://api.github.com/repos/gilt/gfc-guava/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/gilt/gfc-guava/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/gilt/gfc-guava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gilt/gfc-guava/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/gilt/gfc-guava/statuses/6dc9555cd9aa433f81ece79ea25674667eceecc6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}