{"action":"closed","number":1197,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1197","id":31660374,"html_url":"https://github.com/dotnet/corefx/pull/1197","diff_url":"https://github.com/dotnet/corefx/pull/1197.diff","patch_url":"https://github.com/dotnet/corefx/pull/1197.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1197","number":1197,"state":"closed","locked":false,"title":"Enable FileSystemWatcher test to actually validate internal buffer size ...","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"body":"...changes\r\n\r\nThis is regarding issue #1165.\r\n\r\nThis change fixes the test so that it actually behaves as expected and validates a change in internal buffer size. \r\n\r\nThis change does not actually address the issue originally reported.  The issue originally reported is because we don't have control over native handles being released by the OS.  If we believe that is a significant concern, then we may want to move all File System tests out of this testing loop.\r\n\r\nIn issue #1165, I mentioned that this test was not sandboxed well enough.  That was incorrect.  The utility used to create a test file, creates a somewhat unique filename, and then the watcher's filter is set so that we are exclusively monitoring the sandboxed file.  I think this is sufficient in this case.","created_at":"2015-03-20T23:33:18Z","updated_at":"2015-03-24T16:09:37Z","closed_at":"2015-03-24T16:09:37Z","merged_at":"2015-03-24T16:09:37Z","merge_commit_sha":"08e65a32541f6cc1644ce2b247d5b16e10104b62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1197/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1197/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1197/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/5ef10adb860f63673feaf138b0f2dd283fa39133","head":{"label":"chcosta:FSW_InternalBufferSize","ref":"FSW_InternalBufferSize","sha":"5ef10adb860f63673feaf138b0f2dd283fa39133","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"repo":{"id":30564527,"name":"corefx","full_name":"chcosta/corefx","owner":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chcosta/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/chcosta/corefx","forks_url":"https://api.github.com/repos/chcosta/corefx/forks","keys_url":"https://api.github.com/repos/chcosta/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chcosta/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chcosta/corefx/teams","hooks_url":"https://api.github.com/repos/chcosta/corefx/hooks","issue_events_url":"https://api.github.com/repos/chcosta/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/chcosta/corefx/events","assignees_url":"https://api.github.com/repos/chcosta/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/chcosta/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/chcosta/corefx/tags","blobs_url":"https://api.github.com/repos/chcosta/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chcosta/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chcosta/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/chcosta/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chcosta/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/chcosta/corefx/languages","stargazers_url":"https://api.github.com/repos/chcosta/corefx/stargazers","contributors_url":"https://api.github.com/repos/chcosta/corefx/contributors","subscribers_url":"https://api.github.com/repos/chcosta/corefx/subscribers","subscription_url":"https://api.github.com/repos/chcosta/corefx/subscription","commits_url":"https://api.github.com/repos/chcosta/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/chcosta/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/chcosta/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/chcosta/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/chcosta/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/chcosta/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chcosta/corefx/merges","archive_url":"https://api.github.com/repos/chcosta/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chcosta/corefx/downloads","issues_url":"https://api.github.com/repos/chcosta/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/chcosta/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/chcosta/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/chcosta/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chcosta/corefx/labels{/name}","releases_url":"https://api.github.com/repos/chcosta/corefx/releases{/id}","created_at":"2015-02-09T23:28:00Z","updated_at":"2015-03-11T20:25:11Z","pushed_at":"2015-03-24T01:25:27Z","git_url":"git://github.com/chcosta/corefx.git","ssh_url":"git@github.com:chcosta/corefx.git","clone_url":"https://github.com/chcosta/corefx.git","svn_url":"https://github.com/chcosta/corefx","homepage":"","size":13599,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d60696b02076ac7c06915fc311833455d83f16b2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-03-24T15:40:10Z","pushed_at":"2015-03-24T16:09:37Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":28980,"stargazers_count":7302,"watchers_count":7302,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1400,"mirror_url":null,"open_issues_count":311,"forks":1400,"open_issues":311,"watchers":7302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1197"},"html":{"href":"https://github.com/dotnet/corefx/pull/1197"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1197"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1197/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1197/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1197/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/5ef10adb860f63673feaf138b0f2dd283fa39133"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}