{"action":"created","comment":{"url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/comments/47528632","id":47528632,"diff_hunk":"@@ -65,29 +108,56 @@\n         this.status = 'static';\n       }\n     },\n-    needsUpdate : function() {\n-      return this.status !== this.lastStatus;\n+    screenUpdate: function() {\n+      var windowChange = this.isMobile !== this.wasMobile;\n+      if (windowChange) {\n+        console.log('======windowChange=====')\n+        // debugger\n+        this.setOffset();\n+      }\n+    },\n+    needsUpdate: function(mutate) {\n+      var statusChange = this.status !== this.lastStatus;\n+      var sizeChange = this.width !== this.lastWidth;\n+      // this.determineScreen();\n+      // var windowChange = this.isMobile !== this.wasMobile;\n+      // return true;\n+      return statusChange || sizeChange;\n     },\n-    update: function(){\n+    update: function() {\n       if (this.diffTop >= 0){\n         this.elems.sticky.style.position = 'fixed';\n         this.elems.sticky.style.top = 0;\n         this.elems.sticky.classList.remove('js-transparent');\n         this.elems.sticky.classList.add('js-color');\n+        this.elems.sticky.style.width = this.width;\n+\n+        // for bottom\n+        // console.log(this.diffBottom)\n         if (this.diffBottom >= 0){\n           this.elems.sticky.style.position = 'absolute';\n-          this.elems.sticky.style.top = this.mainHeight - this.height - 50 + 'px';\n+          console.log(this.mainHeight, this.height, this.offset, this.mainOffset)\n+\n+      // this.diffBottom = scrollTop + this.height - this.mainHeight - this.mainOffset;","path":"js/components/sticky-nav.js","position":132,"original_position":132,"commit_id":"44a3b36af9d691d49da6e17e1fbac88efd521cc5","original_commit_id":"44a3b36af9d691d49da6e17e1fbac88efd521cc5","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2015-12-14T17:32:30Z","updated_at":"2015-12-14T17:32:30Z","html_url":"https://github.com/18F/doi-extractives-data/pull/1109#discussion_r47528632","pull_request_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109","_links":{"self":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/comments/47528632"},"html":{"href":"https://github.com/18F/doi-extractives-data/pull/1109#discussion_r47528632"},"pull_request":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109"}}},"pull_request":{"url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109","id":53509324,"html_url":"https://github.com/18F/doi-extractives-data/pull/1109","diff_url":"https://github.com/18F/doi-extractives-data/pull/1109.diff","patch_url":"https://github.com/18F/doi-extractives-data/pull/1109.patch","issue_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/1109","number":1109,"state":"open","locked":false,"title":"[WIP] Explore filter bugs","user":{"login":"gemfarmer","id":4803473,"avatar_url":"https://avatars.githubusercontent.com/u/4803473?v=3","gravatar_id":"","url":"https://api.github.com/users/gemfarmer","html_url":"https://github.com/gemfarmer","followers_url":"https://api.github.com/users/gemfarmer/followers","following_url":"https://api.github.com/users/gemfarmer/following{/other_user}","gists_url":"https://api.github.com/users/gemfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gemfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemfarmer/subscriptions","organizations_url":"https://api.github.com/users/gemfarmer/orgs","repos_url":"https://api.github.com/users/gemfarmer/repos","events_url":"https://api.github.com/users/gemfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/gemfarmer/received_events","type":"User","site_admin":false},"body":":warning: WIP – don't merge\r\n\r\nThis PR addresses some of the bugginess with the explore filter\r\n\r\n* [x] Fix issue with filter opening up automatically\r\n* [ ] Fix issue with filter extending into footer when it is opened\r\n* [ ] When filter is open on scroll, it switches to `position: absolute` (correct), but hides the toggle in the process (bad)\r\n* [ ] fine tune scroll on bottom of page\r\n* [ ] filter width off on different screen sizes","created_at":"2015-12-13T20:52:44Z","updated_at":"2015-12-14T17:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8763b9cf590e2a671de435130e0f222fee2a859","assignee":{"login":"gemfarmer","id":4803473,"avatar_url":"https://avatars.githubusercontent.com/u/4803473?v=3","gravatar_id":"","url":"https://api.github.com/users/gemfarmer","html_url":"https://github.com/gemfarmer","followers_url":"https://api.github.com/users/gemfarmer/followers","following_url":"https://api.github.com/users/gemfarmer/following{/other_user}","gists_url":"https://api.github.com/users/gemfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gemfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemfarmer/subscriptions","organizations_url":"https://api.github.com/users/gemfarmer/orgs","repos_url":"https://api.github.com/users/gemfarmer/repos","events_url":"https://api.github.com/users/gemfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/gemfarmer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/18F/doi-extractives-data/milestones/29","html_url":"https://github.com/18F/doi-extractives-data/milestones/Sprint-DapperYeti","labels_url":"https://api.github.com/repos/18F/doi-extractives-data/milestones/29/labels","id":1444582,"number":29,"title":"Sprint-DapperYeti","description":"","creator":{"login":"meiqimichelle","id":4827522,"avatar_url":"https://avatars.githubusercontent.com/u/4827522?v=3","gravatar_id":"","url":"https://api.github.com/users/meiqimichelle","html_url":"https://github.com/meiqimichelle","followers_url":"https://api.github.com/users/meiqimichelle/followers","following_url":"https://api.github.com/users/meiqimichelle/following{/other_user}","gists_url":"https://api.github.com/users/meiqimichelle/gists{/gist_id}","starred_url":"https://api.github.com/users/meiqimichelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meiqimichelle/subscriptions","organizations_url":"https://api.github.com/users/meiqimichelle/orgs","repos_url":"https://api.github.com/users/meiqimichelle/repos","events_url":"https://api.github.com/users/meiqimichelle/events{/privacy}","received_events_url":"https://api.github.com/users/meiqimichelle/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":87,"state":"open","created_at":"2015-12-04T17:13:21Z","updated_at":"2015-12-14T16:15:31Z","due_on":"2015-12-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/1109/comments","statuses_url":"https://api.github.com/repos/18F/doi-extractives-data/statuses/44a3b36af9d691d49da6e17e1fbac88efd521cc5","head":{"label":"18F:filter-bugs","ref":"filter-bugs","sha":"44a3b36af9d691d49da6e17e1fbac88efd521cc5","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":21627244,"name":"doi-extractives-data","full_name":"18F/doi-extractives-data","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/doi-extractives-data","description":"Information on the extractive industries in the U.S. from Federal data.","fork":false,"url":"https://api.github.com/repos/18F/doi-extractives-data","forks_url":"https://api.github.com/repos/18F/doi-extractives-data/forks","keys_url":"https://api.github.com/repos/18F/doi-extractives-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/doi-extractives-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/doi-extractives-data/teams","hooks_url":"https://api.github.com/repos/18F/doi-extractives-data/hooks","issue_events_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/events{/number}","events_url":"https://api.github.com/repos/18F/doi-extractives-data/events","assignees_url":"https://api.github.com/repos/18F/doi-extractives-data/assignees{/user}","branches_url":"https://api.github.com/repos/18F/doi-extractives-data/branches{/branch}","tags_url":"https://api.github.com/repos/18F/doi-extractives-data/tags","blobs_url":"https://api.github.com/repos/18F/doi-extractives-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/doi-extractives-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/doi-extractives-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/doi-extractives-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/doi-extractives-data/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/doi-extractives-data/languages","stargazers_url":"https://api.github.com/repos/18F/doi-extractives-data/stargazers","contributors_url":"https://api.github.com/repos/18F/doi-extractives-data/contributors","subscribers_url":"https://api.github.com/repos/18F/doi-extractives-data/subscribers","subscription_url":"https://api.github.com/repos/18F/doi-extractives-data/subscription","commits_url":"https://api.github.com/repos/18F/doi-extractives-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/doi-extractives-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/doi-extractives-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/doi-extractives-data/contents/{+path}","compare_url":"https://api.github.com/repos/18F/doi-extractives-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/doi-extractives-data/merges","archive_url":"https://api.github.com/repos/18F/doi-extractives-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/doi-extractives-data/downloads","issues_url":"https://api.github.com/repos/18F/doi-extractives-data/issues{/number}","pulls_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/doi-extractives-data/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/doi-extractives-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/doi-extractives-data/labels{/name}","releases_url":"https://api.github.com/repos/18F/doi-extractives-data/releases{/id}","created_at":"2014-07-08T19:44:18Z","updated_at":"2015-11-16T22:37:00Z","pushed_at":"2015-12-14T17:32:09Z","git_url":"git://github.com/18F/doi-extractives-data.git","ssh_url":"git@github.com:18F/doi-extractives-data.git","clone_url":"https://github.com/18F/doi-extractives-data.git","svn_url":"https://github.com/18F/doi-extractives-data","homepage":"https://useiti.doi.gov/","size":221355,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":97,"forks":4,"open_issues":97,"watchers":10,"default_branch":"dev"}},"base":{"label":"18F:dev","ref":"dev","sha":"c8eb9c0af536388ba85d2da74d863ebbc6adae02","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":21627244,"name":"doi-extractives-data","full_name":"18F/doi-extractives-data","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/doi-extractives-data","description":"Information on the extractive industries in the U.S. from Federal data.","fork":false,"url":"https://api.github.com/repos/18F/doi-extractives-data","forks_url":"https://api.github.com/repos/18F/doi-extractives-data/forks","keys_url":"https://api.github.com/repos/18F/doi-extractives-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/doi-extractives-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/doi-extractives-data/teams","hooks_url":"https://api.github.com/repos/18F/doi-extractives-data/hooks","issue_events_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/events{/number}","events_url":"https://api.github.com/repos/18F/doi-extractives-data/events","assignees_url":"https://api.github.com/repos/18F/doi-extractives-data/assignees{/user}","branches_url":"https://api.github.com/repos/18F/doi-extractives-data/branches{/branch}","tags_url":"https://api.github.com/repos/18F/doi-extractives-data/tags","blobs_url":"https://api.github.com/repos/18F/doi-extractives-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/doi-extractives-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/doi-extractives-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/doi-extractives-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/doi-extractives-data/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/doi-extractives-data/languages","stargazers_url":"https://api.github.com/repos/18F/doi-extractives-data/stargazers","contributors_url":"https://api.github.com/repos/18F/doi-extractives-data/contributors","subscribers_url":"https://api.github.com/repos/18F/doi-extractives-data/subscribers","subscription_url":"https://api.github.com/repos/18F/doi-extractives-data/subscription","commits_url":"https://api.github.com/repos/18F/doi-extractives-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/doi-extractives-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/doi-extractives-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/doi-extractives-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/doi-extractives-data/contents/{+path}","compare_url":"https://api.github.com/repos/18F/doi-extractives-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/doi-extractives-data/merges","archive_url":"https://api.github.com/repos/18F/doi-extractives-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/doi-extractives-data/downloads","issues_url":"https://api.github.com/repos/18F/doi-extractives-data/issues{/number}","pulls_url":"https://api.github.com/repos/18F/doi-extractives-data/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/doi-extractives-data/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/doi-extractives-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/doi-extractives-data/labels{/name}","releases_url":"https://api.github.com/repos/18F/doi-extractives-data/releases{/id}","created_at":"2014-07-08T19:44:18Z","updated_at":"2015-11-16T22:37:00Z","pushed_at":"2015-12-14T17:32:09Z","git_url":"git://github.com/18F/doi-extractives-data.git","ssh_url":"git@github.com:18F/doi-extractives-data.git","clone_url":"https://github.com/18F/doi-extractives-data.git","svn_url":"https://github.com/18F/doi-extractives-data","homepage":"https://useiti.doi.gov/","size":221355,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":97,"forks":4,"open_issues":97,"watchers":10,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109"},"html":{"href":"https://github.com/18F/doi-extractives-data/pull/1109"},"issue":{"href":"https://api.github.com/repos/18F/doi-extractives-data/issues/1109"},"comments":{"href":"https://api.github.com/repos/18F/doi-extractives-data/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/doi-extractives-data/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/18F/doi-extractives-data/statuses/44a3b36af9d691d49da6e17e1fbac88efd521cc5"}}}}