{"action":"created","issue":{"url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/230","labels_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/230/comments","events_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/230/events","html_url":"https://github.com/get-iplayer/get_iplayer/pull/230","id":118453115,"number":230,"title":"suggested update update get_iplayer to fix CRLF problem","user":{"login":"DaveFlash","id":12087432,"avatar_url":"https://avatars.githubusercontent.com/u/12087432?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveFlash","html_url":"https://github.com/DaveFlash","followers_url":"https://api.github.com/users/DaveFlash/followers","following_url":"https://api.github.com/users/DaveFlash/following{/other_user}","gists_url":"https://api.github.com/users/DaveFlash/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveFlash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveFlash/subscriptions","organizations_url":"https://api.github.com/users/DaveFlash/orgs","repos_url":"https://api.github.com/users/DaveFlash/repos","events_url":"https://api.github.com/users/DaveFlash/events{/privacy}","received_events_url":"https://api.github.com/users/DaveFlash/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-23T19:24:39Z","updated_at":"2015-11-24T00:43:11Z","closed_at":"2015-11-24T00:43:11Z","pull_request":{"url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/230","html_url":"https://github.com/get-iplayer/get_iplayer/pull/230","diff_url":"https://github.com/get-iplayer/get_iplayer/pull/230.diff","patch_url":"https://github.com/get-iplayer/get_iplayer/pull/230.patch"},"body":" with custom user agent headers when recording iplayer from hls using ffmpeg\r\n\r\nadded an additional user agent header function/variable to command to send to ffmpeg while recording iplayer with hls in script function @cmd at line 10494, under @globals and before ffmpeg -i variable. Of course, the header I used can be changed to use a header from the existing userr agent header-function at line 1576. \r\n\r\nIf this is included in a future update to get_iplayer could I be added as a contributor to this repository?\r\n\r\nWith regards, dave, netherlands/uk"},"comment":{"url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/comments/159115271","html_url":"https://github.com/get-iplayer/get_iplayer/pull/230#issuecomment-159115271","issue_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/230","id":159115271,"user":{"login":"dinkypumpkin","id":243976,"avatar_url":"https://avatars.githubusercontent.com/u/243976?v=3","gravatar_id":"","url":"https://api.github.com/users/dinkypumpkin","html_url":"https://github.com/dinkypumpkin","followers_url":"https://api.github.com/users/dinkypumpkin/followers","following_url":"https://api.github.com/users/dinkypumpkin/following{/other_user}","gists_url":"https://api.github.com/users/dinkypumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/dinkypumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinkypumpkin/subscriptions","organizations_url":"https://api.github.com/users/dinkypumpkin/orgs","repos_url":"https://api.github.com/users/dinkypumpkin/repos","events_url":"https://api.github.com/users/dinkypumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/dinkypumpkin/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T00:43:11Z","updated_at":"2015-11-24T00:43:11Z","body":"Thanks for the PR.  Unfortunately, I am rejecting it.  There are several problems:\r\n\r\n1. Pull requests should be coded against the **develop** branch, not the **master** branch.  See the contribution guidelines in the wiki. I can figure out where to put your changes in the current code, but I shouldn't have to.\r\n\r\n2. Your changes break get_iplayer on OS X.  If you can't test your changes on at least one version each of Linux/Unix, OS X and Windows, you should say so in your pull request description.  get_iplayer must run on all those platforms.\r\n\r\n3. I have no idea what \"CRLF\" problem you are referring to.  You haven't indicated what OS you use or what version of ffmpeg you use.  You haven't explained what the problem is, nor have you provided output demonstrating the problem, nor have you provided a test case to reproduce it.\r\n\r\nIf you decide to have another go, please create a new pull request and provide the required information."}}