{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11497","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11497/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11497/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11497/events","html_url":"https://github.com/cms-sw/cmssw/pull/11497","id":108383928,"number":11497,"title":"merge SLHC updates for CaloTowers","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":96,"closed_issues":933,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-10-17T01:56:07Z","due_on":null,"closed_at":null},"comments":205,"created_at":"2015-09-25T18:33:14Z","updated_at":"2015-10-17T02:55:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11497","html_url":"https://github.com/cms-sw/cmssw/pull/11497","diff_url":"https://github.com/cms-sw/cmssw/pull/11497.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11497.patch"},"body":"This PR updates the CaloTower geometry, topology, and algorithms to be consistent with the new HCAL geometry and topology code (followup on #10353). (Most of these changes are ported from 62XSLHC.)\r\n\r\nA new parameter for calotowermaker is propagated to all the relevant HLT configs.\r\n\r\nA few notes:\r\n1. I already rebased this onto #11423, to avoid a future (small) merge conflict.\r\n2. The matrix tests will crash. This is expected because the new CaloTower geometry record is not in the database yet.\r\n3. I validated this PR using 4.53 with the XML geometry, comparing clean CMSSW_7_6_X_2015-09-23-2300 to the same IB with this PR (using checkdeps). The output is identical, as expected; see plots below:\r\n\r\n![eta](http://kjplanet.com/dqm/eta.png)\r\n![phi](http://kjplanet.com/dqm/phi.png)\r\n![pt](http://kjplanet.com/dqm/pt.png)\r\n\r\nattn: @bsunanda, @ianna "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/148879918","html_url":"https://github.com/cms-sw/cmssw/pull/11497#issuecomment-148879918","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11497","id":148879918,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-10-17T02:55:02Z","updated_at":"2015-10-17T02:55:02Z","body":"-1 \n \nTested at: d05559e58f5a4700e9c0df1d158d6fcfd0c4112b\nI found errors in the following unit tests: \n \n ---> test runtestTqafTopKinFitter had ERRORS\n---> test runtestTqafTopJetCombination had ERRORS\n---> test runtestTqafTopHitFit had ERRORS\n---> test runtestTqafTopTools had ERRORS\n---> test runtestTqafExamples had ERRORS\n---> test runtestTqafTopEventSelection had ERRORS\n---> test runtestTqafTopEventProducers had ERRORS\n---> test runtestPhysicsToolsPatAlgos had ERRORS\n---> test testRecoMETMETProducers had ERRORS\n \n \nyou can see the results of the tests here: \n https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11497/8962/summary.html "}}