{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/35632763","id":35632763,"diff_hunk":"@@ -51,10 +51,7 @@ struct SubgameSpec\n \t\tmenuicon_path(menuicon_path_)\n \t{}\n \n-\tbool isValid() const\n-\t{\n-\t\treturn (id != \"\" && path != \"\");\n-\t}\n+\tbool isValid() const { return !id.empty() && !path.empty(); }","path":"src/subgame.h","position":8,"original_position":8,"commit_id":"518ed45f1ff10c00341afbeaba8516169c3fff76","original_commit_id":"01a1d006f604d551bb1e5182e79a164ddcc1a288","user":{"login":"Zeno-","id":5899883,"avatar_url":"https://avatars.githubusercontent.com/u/5899883?v=3","gravatar_id":"","url":"https://api.github.com/users/Zeno-","html_url":"https://github.com/Zeno-","followers_url":"https://api.github.com/users/Zeno-/followers","following_url":"https://api.github.com/users/Zeno-/following{/other_user}","gists_url":"https://api.github.com/users/Zeno-/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeno-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeno-/subscriptions","organizations_url":"https://api.github.com/users/Zeno-/orgs","repos_url":"https://api.github.com/users/Zeno-/repos","events_url":"https://api.github.com/users/Zeno-/events{/privacy}","received_events_url":"https://api.github.com/users/Zeno-/received_events","type":"User","site_admin":false},"body":"Why is this now on one line?\r\n\r\nAlso, !(id.empty() || path.empty()) might be clearer","created_at":"2015-07-28T10:13:52Z","updated_at":"2015-07-28T10:13:52Z","html_url":"https://github.com/minetest/minetest/pull/2628#discussion_r35632763","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2628","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/35632763"},"html":{"href":"https://github.com/minetest/minetest/pull/2628#discussion_r35632763"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2628"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2628","id":33387257,"html_url":"https://github.com/minetest/minetest/pull/2628","diff_url":"https://github.com/minetest/minetest/pull/2628.diff","patch_url":"https://github.com/minetest/minetest/pull/2628.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2628","number":2628,"state":"open","locked":false,"title":"Clean up logging","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"body":"  * Remove the ugly C-style debug stream system, replacing it with the\r\n    StreamLogOutput and FileLogOutput classes.  dstream becomes just another\r\n    log level, except that it's always printed.  This adds timestamps and\r\n    thread names to `dstream`'d messages, removing the need for the `DTIME` macro.\r\n   `dstream`'s old functionality is replaced by `rawstream`.\r\n  * Move global logging functions into a Logger class and use a global logger.\r\n  * Add (and use) warning log level.\r\n  * Map Irrlicht log event levels to Minetest log event levels and shorten the\r\n    prefix to \"Irrlicht: \".  This adds timestamps, thread names, and filtering\r\n    to the Irrlicht log messages. EDIT: Merged as a93838707a9aab104c20b6a971d8c622184a508f.\r\n  * Don't set the Irrlicht log level to the file log level as this affects\r\n    console output too.  Filter Irrlicht log messages ourselves instead (which we can do because the levels are mapped now).\r\n  * Rename macros with two leading underscores (these names are reserved for\r\n    the compiler/library implementation).\r\n  * Fix some instances where threads didn't de-register themselves from logging.\r\n\r\nTo do:\r\n  * [x] Fix `setLevelSilenced()` so that it works only on the level passed, instead of all levels (this causes `minetest --run-unittests --info` to not print the `Running Test*` lines in `infostream`, because `LL_ERROR` was disabled, but it affected all log levels).  --  (this was NOT introduced by these changes)\r\n  * [ ] Fix Irrlicht not passing the main menu's \"Loaded texture\" messages to the event handler as log events, instead printing them directly to `stdout` with `printf`.\r\n","created_at":"2015-04-15T19:18:45Z","updated_at":"2015-07-28T10:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"792ce9d8e32b853f881dd6330427b3922d7111f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2628/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2628/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2628/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/518ed45f1ff10c00341afbeaba8516169c3fff76","head":{"label":"ShadowNinja:cleanup-logging","ref":"cleanup-logging","sha":"518ed45f1ff10c00341afbeaba8516169c3fff76","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"repo":{"id":8000011,"name":"minetest","full_name":"ShadowNinja/minetest","owner":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShadowNinja/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. This is a private fork, the official repo is @minetest/minetest","fork":true,"url":"https://api.github.com/repos/ShadowNinja/minetest","forks_url":"https://api.github.com/repos/ShadowNinja/minetest/forks","keys_url":"https://api.github.com/repos/ShadowNinja/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShadowNinja/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShadowNinja/minetest/teams","hooks_url":"https://api.github.com/repos/ShadowNinja/minetest/hooks","issue_events_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/ShadowNinja/minetest/events","assignees_url":"https://api.github.com/repos/ShadowNinja/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/ShadowNinja/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/ShadowNinja/minetest/tags","blobs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShadowNinja/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShadowNinja/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShadowNinja/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/ShadowNinja/minetest/languages","stargazers_url":"https://api.github.com/repos/ShadowNinja/minetest/stargazers","contributors_url":"https://api.github.com/repos/ShadowNinja/minetest/contributors","subscribers_url":"https://api.github.com/repos/ShadowNinja/minetest/subscribers","subscription_url":"https://api.github.com/repos/ShadowNinja/minetest/subscription","commits_url":"https://api.github.com/repos/ShadowNinja/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShadowNinja/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShadowNinja/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShadowNinja/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/ShadowNinja/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShadowNinja/minetest/merges","archive_url":"https://api.github.com/repos/ShadowNinja/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShadowNinja/minetest/downloads","issues_url":"https://api.github.com/repos/ShadowNinja/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/ShadowNinja/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/ShadowNinja/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/ShadowNinja/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShadowNinja/minetest/labels{/name}","releases_url":"https://api.github.com/repos/ShadowNinja/minetest/releases{/id}","created_at":"2013-02-04T02:44:10Z","updated_at":"2015-02-21T18:17:05Z","pushed_at":"2015-07-22T16:42:26Z","git_url":"git://github.com/ShadowNinja/minetest.git","ssh_url":"git@github.com:ShadowNinja/minetest.git","clone_url":"https://github.com/ShadowNinja/minetest.git","svn_url":"https://github.com/ShadowNinja/minetest","homepage":"http://minetest.net/","size":37803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"2eb329cc6362958537737c2a82ae593c7ba5d30a","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-07-27T06:45:24Z","pushed_at":"2015-07-27T21:08:10Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":100727,"stargazers_count":1567,"watchers_count":1567,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":513,"mirror_url":null,"open_issues_count":560,"forks":513,"open_issues":560,"watchers":1567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2628"},"html":{"href":"https://github.com/minetest/minetest/pull/2628"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2628"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2628/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2628/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2628/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/518ed45f1ff10c00341afbeaba8516169c3fff76"}}}}