{"action":"opened","number":3890,"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/3890","id":54290187,"html_url":"https://github.com/atom/electron/pull/3890","diff_url":"https://github.com/atom/electron/pull/3890.diff","patch_url":"https://github.com/atom/electron/pull/3890.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/3890","number":3890,"state":"open","locked":false,"title":"Fixes #2810: correct look of hidden-inset windows in full screen.","user":{"login":"jaanus","id":184253,"avatar_url":"https://avatars.githubusercontent.com/u/184253?v=3","gravatar_id":"","url":"https://api.github.com/users/jaanus","html_url":"https://github.com/jaanus","followers_url":"https://api.github.com/users/jaanus/followers","following_url":"https://api.github.com/users/jaanus/following{/other_user}","gists_url":"https://api.github.com/users/jaanus/gists{/gist_id}","starred_url":"https://api.github.com/users/jaanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaanus/subscriptions","organizations_url":"https://api.github.com/users/jaanus/orgs","repos_url":"https://api.github.com/users/jaanus/repos","events_url":"https://api.github.com/users/jaanus/events{/privacy}","received_events_url":"https://api.github.com/users/jaanus/received_events","type":"User","site_admin":false},"body":"`hidden` and `hidden-inset` windows differ only by the hidden-inset window having a toolbar. Yet, the toolbar yields an incorrect look in fullscreen mode. So, we hide and recreate the toolbar for such windows when going to/from fullscreen.\r\n\r\nThere are some visible artifacts during the fullscreen animations, as the toolbar gets created and destroyed. When entering fullscreen, you see a toolbar that then disappears. When going back to normal window, you see the traffic light buttons jump around a little bit. Yet, this is definitely better than the current broken fullscreen look.\r\n\r\nI’m not sure about the style of this code. I introduce a public ivar for `NativeWindowMac`, and only do so because I couldn’t find the window options stored, we need to access the window options (specifically whether it was a `hidden-inset` style window) when going to/from fullscreen. Also, the toolbar creation is now in two places in the window code. But I still wanted to get this PR going to show the gist of the solution.","created_at":"2015-12-21T18:58:11Z","updated_at":"2015-12-21T18:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/3890/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/3890/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/3890/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/64427683dd014384f0452ced1bb36514aa7d75aa","head":{"label":"jaanus:hidden-inset-fullscreen-fix","ref":"hidden-inset-fullscreen-fix","sha":"64427683dd014384f0452ced1bb36514aa7d75aa","user":{"login":"jaanus","id":184253,"avatar_url":"https://avatars.githubusercontent.com/u/184253?v=3","gravatar_id":"","url":"https://api.github.com/users/jaanus","html_url":"https://github.com/jaanus","followers_url":"https://api.github.com/users/jaanus/followers","following_url":"https://api.github.com/users/jaanus/following{/other_user}","gists_url":"https://api.github.com/users/jaanus/gists{/gist_id}","starred_url":"https://api.github.com/users/jaanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaanus/subscriptions","organizations_url":"https://api.github.com/users/jaanus/orgs","repos_url":"https://api.github.com/users/jaanus/repos","events_url":"https://api.github.com/users/jaanus/events{/privacy}","received_events_url":"https://api.github.com/users/jaanus/received_events","type":"User","site_admin":false},"repo":{"id":42411857,"name":"electron","full_name":"jaanus/electron","owner":{"login":"jaanus","id":184253,"avatar_url":"https://avatars.githubusercontent.com/u/184253?v=3","gravatar_id":"","url":"https://api.github.com/users/jaanus","html_url":"https://github.com/jaanus","followers_url":"https://api.github.com/users/jaanus/followers","following_url":"https://api.github.com/users/jaanus/following{/other_user}","gists_url":"https://api.github.com/users/jaanus/gists{/gist_id}","starred_url":"https://api.github.com/users/jaanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaanus/subscriptions","organizations_url":"https://api.github.com/users/jaanus/orgs","repos_url":"https://api.github.com/users/jaanus/repos","events_url":"https://api.github.com/users/jaanus/events{/privacy}","received_events_url":"https://api.github.com/users/jaanus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaanus/electron","description":"Build cross platform desktop apps with web technologies","fork":true,"url":"https://api.github.com/repos/jaanus/electron","forks_url":"https://api.github.com/repos/jaanus/electron/forks","keys_url":"https://api.github.com/repos/jaanus/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaanus/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaanus/electron/teams","hooks_url":"https://api.github.com/repos/jaanus/electron/hooks","issue_events_url":"https://api.github.com/repos/jaanus/electron/issues/events{/number}","events_url":"https://api.github.com/repos/jaanus/electron/events","assignees_url":"https://api.github.com/repos/jaanus/electron/assignees{/user}","branches_url":"https://api.github.com/repos/jaanus/electron/branches{/branch}","tags_url":"https://api.github.com/repos/jaanus/electron/tags","blobs_url":"https://api.github.com/repos/jaanus/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaanus/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaanus/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaanus/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaanus/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/jaanus/electron/languages","stargazers_url":"https://api.github.com/repos/jaanus/electron/stargazers","contributors_url":"https://api.github.com/repos/jaanus/electron/contributors","subscribers_url":"https://api.github.com/repos/jaanus/electron/subscribers","subscription_url":"https://api.github.com/repos/jaanus/electron/subscription","commits_url":"https://api.github.com/repos/jaanus/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaanus/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaanus/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaanus/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaanus/electron/contents/{+path}","compare_url":"https://api.github.com/repos/jaanus/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaanus/electron/merges","archive_url":"https://api.github.com/repos/jaanus/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaanus/electron/downloads","issues_url":"https://api.github.com/repos/jaanus/electron/issues{/number}","pulls_url":"https://api.github.com/repos/jaanus/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/jaanus/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/jaanus/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaanus/electron/labels{/name}","releases_url":"https://api.github.com/repos/jaanus/electron/releases{/id}","created_at":"2015-09-13T20:34:06Z","updated_at":"2015-09-13T20:34:09Z","pushed_at":"2015-12-21T18:55:29Z","git_url":"git://github.com/jaanus/electron.git","ssh_url":"git@github.com:jaanus/electron.git","clone_url":"https://github.com/jaanus/electron.git","svn_url":"https://github.com/jaanus/electron","homepage":"http://electron.atom.io","size":12768,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"c68e38f480f47142265b162fd961a4b9184738ef","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-12-21T17:45:52Z","pushed_at":"2015-12-21T18:33:28Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":16290,"stargazers_count":21242,"watchers_count":21242,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2019,"mirror_url":null,"open_issues_count":285,"forks":2019,"open_issues":285,"watchers":21242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/3890"},"html":{"href":"https://github.com/atom/electron/pull/3890"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/3890"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/3890/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/3890/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/3890/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/64427683dd014384f0452ced1bb36514aa7d75aa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":0,"changed_files":2}}