{"action":"created","issue":{"url":"https://api.github.com/repos/msurguy/Honeypot/issues/35","labels_url":"https://api.github.com/repos/msurguy/Honeypot/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/msurguy/Honeypot/issues/35/comments","events_url":"https://api.github.com/repos/msurguy/Honeypot/issues/35/events","html_url":"https://github.com/msurguy/Honeypot/pull/35","id":76290177,"number":35,"title":"Remove formbuilder macro, use the facade. ","user":{"login":"garygreen","id":1702638,"avatar_url":"https://avatars.githubusercontent.com/u/1702638?v=3","gravatar_id":"","url":"https://api.github.com/users/garygreen","html_url":"https://github.com/garygreen","followers_url":"https://api.github.com/users/garygreen/followers","following_url":"https://api.github.com/users/garygreen/following{/other_user}","gists_url":"https://api.github.com/users/garygreen/gists{/gist_id}","starred_url":"https://api.github.com/users/garygreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garygreen/subscriptions","organizations_url":"https://api.github.com/users/garygreen/orgs","repos_url":"https://api.github.com/users/garygreen/repos","events_url":"https://api.github.com/users/garygreen/events{/privacy}","received_events_url":"https://api.github.com/users/garygreen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-14T08:56:37Z","updated_at":"2015-05-14T16:50:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/msurguy/Honeypot/pulls/35","html_url":"https://github.com/msurguy/Honeypot/pull/35","diff_url":"https://github.com/msurguy/Honeypot/pull/35.diff","patch_url":"https://github.com/msurguy/Honeypot/pull/35.patch"},"body":"@msurguy how do you feel about this one? Of course a breaking change so would need a major version bump but I think currently a lot of issues spawn from usage of the `macro` on FormBuilder. These issues range from supporting legacy Laravel < 4.2, newer Laravel >= 4.2.. and now that `illuminate/html` has been deprecated it's been replaced with another package called Laravel Collective which runs under a different namespace but is essentially the new `illluminate/html`.\r\n\r\nThat's a lot to support and keep up with when all it's doing is just adding a macro which isn't really worth it imo. Doing `Honeypot::getFormHtml(...)` vs `Form::honeypot(...)` isn't really much of a difference.\r\n\r\nAs this is a breaking change, I've also added in this commit a rename of the method `getFormHtml` to simply `generate` -- it's possibly a nice time to make the change as read's nicer in it's usage:\r\n\r\n{{ Honeypot::getFormHtml() }}\r\n{{ Honeypot::generate() }}\r\n\r\nLet me know what you think :smile: "},"comment":{"url":"https://api.github.com/repos/msurguy/Honeypot/issues/comments/102100807","html_url":"https://github.com/msurguy/Honeypot/pull/35#issuecomment-102100807","issue_url":"https://api.github.com/repos/msurguy/Honeypot/issues/35","id":102100807,"user":{"login":"msurguy","id":585833,"avatar_url":"https://avatars.githubusercontent.com/u/585833?v=3","gravatar_id":"","url":"https://api.github.com/users/msurguy","html_url":"https://github.com/msurguy","followers_url":"https://api.github.com/users/msurguy/followers","following_url":"https://api.github.com/users/msurguy/following{/other_user}","gists_url":"https://api.github.com/users/msurguy/gists{/gist_id}","starred_url":"https://api.github.com/users/msurguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msurguy/subscriptions","organizations_url":"https://api.github.com/users/msurguy/orgs","repos_url":"https://api.github.com/users/msurguy/repos","events_url":"https://api.github.com/users/msurguy/events{/privacy}","received_events_url":"https://api.github.com/users/msurguy/received_events","type":"User","site_admin":false},"created_at":"2015-05-14T16:50:32Z","updated_at":"2015-05-14T16:50:32Z","body":"Thanks for the PR @garygreen! I agree that it's time to drop the dependency on Illuminate/html because we're not using it for anything complex here. Have you tested this new version with some of the Laravel versions? I will be able to merge and release if you have!"}}