{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/17428","labels_url":"https://api.github.com/repos/docker/docker/issues/17428/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/17428/comments","events_url":"https://api.github.com/repos/docker/docker/issues/17428/events","html_url":"https://github.com/docker/docker/pull/17428","id":113760537,"number":17428,"title":"Change the quiet flag behavior in the build command [closes #17623]","user":{"login":"ripcurld00d","id":2453279,"avatar_url":"https://avatars.githubusercontent.com/u/2453279?v=3","gravatar_id":"","url":"https://api.github.com/users/ripcurld00d","html_url":"https://github.com/ripcurld00d","followers_url":"https://api.github.com/users/ripcurld00d/followers","following_url":"https://api.github.com/users/ripcurld00d/following{/other_user}","gists_url":"https://api.github.com/users/ripcurld00d/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurld00d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurld00d/subscriptions","organizations_url":"https://api.github.com/users/ripcurld00d/orgs","repos_url":"https://api.github.com/users/ripcurld00d/repos","events_url":"https://api.github.com/users/ripcurld00d/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurld00d/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":55,"created_at":"2015-10-28T07:37:08Z","updated_at":"2015-12-13T20:21:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17428","html_url":"https://github.com/docker/docker/pull/17428","diff_url":"https://github.com/docker/docker/pull/17428.diff","patch_url":"https://github.com/docker/docker/pull/17428.patch"},"body":"This PR answers the requirement in #7727 and closes #17623\r\n\r\nCloses #17623\r\n\r\n>    Right now, the quiet (-q, --quiet) flag ignores the output\r\n>    generated from within the container.\r\n    \r\n>    However, it ought to be a quiet in a way that all kind\r\n>    of diagnostic output should be ignored, unless the build\r\n>    process fails.\r\n>    \r\n>    This patch makes the quiet flag behave in the following way:\r\n>     1. If the build process succeeds, stdout contains the image ID\r\n>           and stderr is empty.\r\n>     2. If the build process fails, stdout is empty and stderr\r\n>           has the error message and the diagnostic output of that process.\r\n>    \r\n>    If the quiet flag is not set, then everything goes to stdout\r\n>    and error messages, if there are any, go to stderr.\r\n\r\nTODO:\r\n* ~~Change the `quiet` part in the `docker build` docs~~\r\n* ~~Write a cli-integration test~~\r\n* ~~Apparently figure out why the tests fail~~"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/164295199","html_url":"https://github.com/docker/docker/pull/17428#issuecomment-164295199","issue_url":"https://api.github.com/repos/docker/docker/issues/17428","id":164295199,"user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T20:21:32Z","updated_at":"2015-12-13T20:21:32Z","body":"Not near a computer so I can't test it, does the Windows msg go to stdout or stderr?\n\n-Doug\n\nSent from my iPhone\n\n> On Dec 13, 2015, at 12:08 PM, bshuster <notifications@github.com> wrote:\n> \n> @thaJeztah not a problem. I'll change it back?\n> \n> In addition, I noticed that my test on Windows failed:\n> \n> Shouldn't we get the \"SECURITY WARNING\" message, when the client and the server are running on different operating systems (not only when the server is windows)?\n> Is it wise to print it, when the -q flag is set to true?\n> Your thoughts?\n> \n> Thanks.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}