{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments/26115630","id":26115630,"diff_hunk":"@@ -10,22 +11,38 @@\n ;;   - Validate schema for GET params. The GetParams schema\n ;;     exists, but needs work before it can be used.\n \n-(defn make-https-client\n-  [^String host {:keys [ssl-ca-cert ssl-cert ssl-key]}]\n+(defn- make-https-client\n+  [^String host {:keys [ssl-ca-cert ssl-cert ssl-key vcr-dir]}]\n   {:pre  [(every? file? [ssl-ca-cert ssl-cert ssl-key])\n           (.startsWith host \"https://\")]\n    :post [(s/validate Client %)]}\n   {:host host\n    :opts {:ssl-ca-cert ssl-ca-cert\n           :ssl-cert    ssl-cert\n-          :ssl-key     ssl-key}})\n+          :ssl-key     ssl-key","path":"src/clj_puppetdb/http.clj","position":23,"original_position":23,"commit_id":"3880b3f6f0e762aa85d19cfe598db851bed51086","original_commit_id":"1fd819d63f0789503ab7eedc65c22497c474e28a","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"body":"Agreed, I will add a task to Jira.","created_at":"2015-03-10T12:03:36Z","updated_at":"2015-03-10T12:03:36Z","html_url":"https://github.com/puppetlabs/clj-puppetdb/pull/4#discussion_r26115630","pull_request_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments/26115630"},"html":{"href":"https://github.com/puppetlabs/clj-puppetdb/pull/4#discussion_r26115630"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4","id":30580565,"html_url":"https://github.com/puppetlabs/clj-puppetdb/pull/4","diff_url":"https://github.com/puppetlabs/clj-puppetdb/pull/4.diff","patch_url":"https://github.com/puppetlabs/clj-puppetdb/pull/4.patch","issue_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/4","number":4,"state":"open","locked":false,"title":"VCR support","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"body":"VCR support to record and replay HTTP responses","created_at":"2015-03-05T18:05:41Z","updated_at":"2015-03-10T12:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8a5b44d3aceb4c5a468da293dc54a4b5922f408","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/4/comments","statuses_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/3880b3f6f0e762aa85d19cfe598db851bed51086","head":{"label":"scottyw:master","ref":"master","sha":"3880b3f6f0e762aa85d19cfe598db851bed51086","user":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"repo":{"id":30601827,"name":"clj-puppetdb","full_name":"scottyw/clj-puppetdb","owner":{"login":"scottyw","id":3063979,"avatar_url":"https://avatars.githubusercontent.com/u/3063979?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyw","html_url":"https://github.com/scottyw","followers_url":"https://api.github.com/users/scottyw/followers","following_url":"https://api.github.com/users/scottyw/following{/other_user}","gists_url":"https://api.github.com/users/scottyw/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyw/subscriptions","organizations_url":"https://api.github.com/users/scottyw/orgs","repos_url":"https://api.github.com/users/scottyw/repos","events_url":"https://api.github.com/users/scottyw/events{/privacy}","received_events_url":"https://api.github.com/users/scottyw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottyw/clj-puppetdb","description":"A Clojure library for querying the PuppetDB REST API","fork":true,"url":"https://api.github.com/repos/scottyw/clj-puppetdb","forks_url":"https://api.github.com/repos/scottyw/clj-puppetdb/forks","keys_url":"https://api.github.com/repos/scottyw/clj-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottyw/clj-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottyw/clj-puppetdb/teams","hooks_url":"https://api.github.com/repos/scottyw/clj-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/scottyw/clj-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/scottyw/clj-puppetdb/events","assignees_url":"https://api.github.com/repos/scottyw/clj-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/scottyw/clj-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/scottyw/clj-puppetdb/tags","blobs_url":"https://api.github.com/repos/scottyw/clj-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottyw/clj-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottyw/clj-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottyw/clj-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottyw/clj-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/scottyw/clj-puppetdb/languages","stargazers_url":"https://api.github.com/repos/scottyw/clj-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/scottyw/clj-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/scottyw/clj-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/scottyw/clj-puppetdb/subscription","commits_url":"https://api.github.com/repos/scottyw/clj-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottyw/clj-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottyw/clj-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottyw/clj-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottyw/clj-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/scottyw/clj-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottyw/clj-puppetdb/merges","archive_url":"https://api.github.com/repos/scottyw/clj-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottyw/clj-puppetdb/downloads","issues_url":"https://api.github.com/repos/scottyw/clj-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/scottyw/clj-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/scottyw/clj-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/scottyw/clj-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottyw/clj-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/scottyw/clj-puppetdb/releases{/id}","created_at":"2015-02-10T16:34:05Z","updated_at":"2015-03-09T12:12:37Z","pushed_at":"2015-03-09T12:12:37Z","git_url":"git://github.com/scottyw/clj-puppetdb.git","ssh_url":"git@github.com:scottyw/clj-puppetdb.git","clone_url":"https://github.com/scottyw/clj-puppetdb.git","svn_url":"https://github.com/scottyw/clj-puppetdb","homepage":"","size":180,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"13567053ef0298d2246ada39b57d20dd5bb0ea63","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":30195532,"name":"clj-puppetdb","full_name":"puppetlabs/clj-puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/clj-puppetdb","description":"A Clojure library for querying the PuppetDB REST API","fork":true,"url":"https://api.github.com/repos/puppetlabs/clj-puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/clj-puppetdb/releases{/id}","created_at":"2015-02-02T16:13:19Z","updated_at":"2015-03-05T17:17:04Z","pushed_at":"2015-03-05T17:10:59Z","git_url":"git://github.com/puppetlabs/clj-puppetdb.git","ssh_url":"git@github.com:puppetlabs/clj-puppetdb.git","clone_url":"https://github.com/puppetlabs/clj-puppetdb.git","svn_url":"https://github.com/puppetlabs/clj-puppetdb","homepage":"","size":187,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4"},"html":{"href":"https://github.com/puppetlabs/clj-puppetdb/pull/4"},"issue":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/4"},"comments":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/clj-puppetdb/statuses/3880b3f6f0e762aa85d19cfe598db851bed51086"}}}}