{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/23316013","id":23316013,"diff_hunk":"@@ -7,6 +7,37 @@\n // TODO add teardown callback to remove dialogs\n module(\"dialog: core\");\n \n+test( \"markup structure\", function() {\n+\texpect( 7 );\n+\tvar element = $(\"<div></div>\").dialog({\n+\t\t\tbuttons: [{\n+\t\t\t\ttext: \"Ok\",\n+\t\t\t\tclick: $.noop\n+\t\t\t}]\n+\t\t}),\n+\t\twidget = element.dialog( \"widget\" ),\n+\t\ttitlebar = widget.find( \".ui-dialog-titlebar\" ),\n+\t\tclose = titlebar.find( \"button\" ),\n+\t\tbuttonpane = widget.find( \".ui-dialog-buttonpane\" );\n+\n+\tok( widget.is( \".ui-dialog.ui-widget.ui-widget-content.ui-corner-all.ui-dialog-buttons\" ),\n+\t\t\"Widget has proper classes\" );\n+\n+\tok( titlebar.is( \".ui-dialog-titlebar.ui-corner-all.ui-widget-header\"),\n+\t\t\"Titlebar has proper classes\");\n+\n+\tok( titlebar.find( \".ui-dialog-title\" ).length, \"Title is .ui-dialog-title\" );\n+\n+\tok( close.hasClass( \"ui-dialog-titlebar-close\" ), \"Close button is .ui-dialog-titlebar-close\" );\n+\n+\tok( element.is( \".ui-dialog-content.ui-widget-content\" ), \"Element is .ui-widget-content\" );\n+\n+\tok( buttonpane.is( \".ui-dialog-buttonpane.ui-widget-content\" ),\n+\t\t\"Buttonpane is .ui-widget-content\" );\n+\tok( buttonpane.find( \".ui-dialog-buttonset\" ).length, \"buttonset is .ui-dialog-buttonset\" );\n+\n+});","path":"tests/unit/dialog/dialog_core.js","position":33,"original_position":33,"commit_id":"8e5932fce369bc917f78cb27e15f104f1e25f662","original_commit_id":"8e5932fce369bc917f78cb27e15f104f1e25f662","user":{"login":"scottgonzalez","id":141167,"avatar_url":"https://avatars.githubusercontent.com/u/141167?v=3","gravatar_id":"","url":"https://api.github.com/users/scottgonzalez","html_url":"https://github.com/scottgonzalez","followers_url":"https://api.github.com/users/scottgonzalez/followers","following_url":"https://api.github.com/users/scottgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/scottgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/scottgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottgonzalez/subscriptions","organizations_url":"https://api.github.com/users/scottgonzalez/orgs","repos_url":"https://api.github.com/users/scottgonzalez/repos","events_url":"https://api.github.com/users/scottgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/scottgonzalez/received_events","type":"User","site_admin":false},"body":"I'm in favor of many `.hasClass()` tests.","created_at":"2015-01-21T17:16:39Z","updated_at":"2015-01-21T17:16:39Z","html_url":"https://github.com/jquery/jquery-ui/pull/1411#discussion_r23316013","pull_request_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/23316013"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1411#discussion_r23316013"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411","id":26746807,"html_url":"https://github.com/jquery/jquery-ui/pull/1411","diff_url":"https://github.com/jquery/jquery-ui/pull/1411.diff","patch_url":"https://github.com/jquery/jquery-ui/pull/1411.patch","issue_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1411","number":1411,"state":"open","locked":false,"title":"Classes","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"body":"This addes a new built in option to the widget factory classes which maps structural classes to theme classes. To make this possible it introduces three new documented widget methods _addClass, _removeClass, and _toggleClass.","created_at":"2015-01-01T21:50:00Z","updated_at":"2015-01-21T17:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"756cea209e0d70b05d661868ecd056fa1e5301f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1411/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/8e5932fce369bc917f78cb27e15f104f1e25f662","head":{"label":"arschmitz:classes","ref":"classes","sha":"8e5932fce369bc917f78cb27e15f104f1e25f662","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"repo":{"id":4218107,"name":"jquery-ui","full_name":"arschmitz/jquery-ui","owner":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschmitz/jquery-ui","description":"The official jQuery user interface library.","fork":true,"url":"https://api.github.com/repos/arschmitz/jquery-ui","forks_url":"https://api.github.com/repos/arschmitz/jquery-ui/forks","keys_url":"https://api.github.com/repos/arschmitz/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschmitz/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschmitz/jquery-ui/teams","hooks_url":"https://api.github.com/repos/arschmitz/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/arschmitz/jquery-ui/events","assignees_url":"https://api.github.com/repos/arschmitz/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/arschmitz/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/arschmitz/jquery-ui/tags","blobs_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschmitz/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/arschmitz/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/arschmitz/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/arschmitz/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/arschmitz/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/arschmitz/jquery-ui/subscription","commits_url":"https://api.github.com/repos/arschmitz/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschmitz/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/arschmitz/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/arschmitz/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschmitz/jquery-ui/merges","archive_url":"https://api.github.com/repos/arschmitz/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschmitz/jquery-ui/downloads","issues_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/arschmitz/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/arschmitz/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/arschmitz/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschmitz/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/arschmitz/jquery-ui/releases{/id}","created_at":"2012-05-03T19:57:50Z","updated_at":"2015-01-15T14:40:40Z","pushed_at":"2015-01-15T14:47:26Z","git_url":"git://github.com/arschmitz/jquery-ui.git","ssh_url":"git@github.com:arschmitz/jquery-ui.git","clone_url":"https://github.com/arschmitz/jquery-ui.git","svn_url":"https://github.com/arschmitz/jquery-ui","homepage":"http://jqueryui.com/","size":24934,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"3ecbe7867abbc350f8ebd52b7036e1b81d8890ae","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":478996,"name":"jquery-ui","full_name":"jquery/jquery-ui","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-ui","description":"The official jQuery user interface library.","fork":false,"url":"https://api.github.com/repos/jquery/jquery-ui","forks_url":"https://api.github.com/repos/jquery/jquery-ui/forks","keys_url":"https://api.github.com/repos/jquery/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-ui/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-ui/events","assignees_url":"https://api.github.com/repos/jquery/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-ui/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-ui/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-ui/merges","archive_url":"https://api.github.com/repos/jquery/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-ui/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-ui/releases{/id}","created_at":"2010-01-19T14:40:34Z","updated_at":"2015-01-21T17:08:36Z","pushed_at":"2015-01-21T17:08:35Z","git_url":"git://github.com/jquery/jquery-ui.git","ssh_url":"git@github.com:jquery/jquery-ui.git","clone_url":"https://github.com/jquery/jquery-ui.git","svn_url":"https://github.com/jquery/jquery-ui","homepage":"http://jqueryui.com/","size":46064,"stargazers_count":8702,"watchers_count":8702,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3316,"mirror_url":null,"open_issues_count":28,"forks":3316,"open_issues":28,"watchers":8702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1411"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1411"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-ui/statuses/8e5932fce369bc917f78cb27e15f104f1e25f662"}}}}