{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel/pulls/comments/36221807","id":36221807,"diff_hunk":"@@ -296,3 +324,8 @@ HyperbahnHandler.prototype.advertise =\n function advertise(service) {\n     throw new Error('not implemented');\n };\n+\n+HyperbahnHandler.prototype.unadvertise =","path":"node/hyperbahn/handler.js","position":107,"original_position":107,"commit_id":"48d56ea630a2a313ac33c57487f09b715c76f0d7","original_commit_id":"48d56ea630a2a313ac33c57487f09b715c76f0d7","user":{"login":"anson627","id":1474346,"avatar_url":"https://avatars.githubusercontent.com/u/1474346?v=3","gravatar_id":"","url":"https://api.github.com/users/anson627","html_url":"https://github.com/anson627","followers_url":"https://api.github.com/users/anson627/followers","following_url":"https://api.github.com/users/anson627/following{/other_user}","gists_url":"https://api.github.com/users/anson627/gists{/gist_id}","starred_url":"https://api.github.com/users/anson627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anson627/subscriptions","organizations_url":"https://api.github.com/users/anson627/orgs","repos_url":"https://api.github.com/users/anson627/repos","events_url":"https://api.github.com/users/anson627/events{/privacy}","received_events_url":"https://api.github.com/users/anson627/received_events","type":"User","site_admin":false},"body":"oh, so you can get top channel from sub channel? let me try.","created_at":"2015-08-04T18:11:34Z","updated_at":"2015-08-04T18:11:34Z","html_url":"https://github.com/uber/tchannel/pull/1106#discussion_r36221807","pull_request_url":"https://api.github.com/repos/uber/tchannel/pulls/1106","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel/pulls/comments/36221807"},"html":{"href":"https://github.com/uber/tchannel/pull/1106#discussion_r36221807"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1106"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel/pulls/1106","id":41537094,"html_url":"https://github.com/uber/tchannel/pull/1106","diff_url":"https://github.com/uber/tchannel/pull/1106.diff","patch_url":"https://github.com/uber/tchannel/pull/1106.patch","issue_url":"https://api.github.com/repos/uber/tchannel/issues/1106","number":1106,"state":"open","locked":false,"title":"Unadvertise now","user":{"login":"anson627","id":1474346,"avatar_url":"https://avatars.githubusercontent.com/u/1474346?v=3","gravatar_id":"","url":"https://api.github.com/users/anson627","html_url":"https://github.com/anson627","followers_url":"https://api.github.com/users/anson627/followers","following_url":"https://api.github.com/users/anson627/following{/other_user}","gists_url":"https://api.github.com/users/anson627/gists{/gist_id}","starred_url":"https://api.github.com/users/anson627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anson627/subscriptions","organizations_url":"https://api.github.com/users/anson627/orgs","repos_url":"https://api.github.com/users/anson627/repos","events_url":"https://api.github.com/users/anson627/events{/privacy}","received_events_url":"https://api.github.com/users/anson627/received_events","type":"User","site_admin":false},"body":"Close peer and delete it from peer heap when unadvertise\r\nNot destroy hyperbahn client so that it can re-advertise\r\n@ShanniLi @Raynos @kriskowal \r\ncc: @davewhat @vipulaneja \r\n","created_at":"2015-08-04T06:04:57Z","updated_at":"2015-08-04T18:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e19c20ccc9bf8ce43aaa02411051308bceb6552a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel/issues/1106/comments","statuses_url":"https://api.github.com/repos/uber/tchannel/statuses/48d56ea630a2a313ac33c57487f09b715c76f0d7","head":{"label":"uber:unadvertise-now","ref":"unadvertise-now","sha":"48d56ea630a2a313ac33c57487f09b715c76f0d7","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":28419663,"name":"tchannel","full_name":"uber/tchannel","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel","description":"network multiplexing and framing protocol for RPC","fork":false,"url":"https://api.github.com/repos/uber/tchannel","forks_url":"https://api.github.com/repos/uber/tchannel/forks","keys_url":"https://api.github.com/repos/uber/tchannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel/teams","hooks_url":"https://api.github.com/repos/uber/tchannel/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel/events","assignees_url":"https://api.github.com/repos/uber/tchannel/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel/tags","blobs_url":"https://api.github.com/repos/uber/tchannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel/subscription","commits_url":"https://api.github.com/repos/uber/tchannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel/merges","archive_url":"https://api.github.com/repos/uber/tchannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel/downloads","issues_url":"https://api.github.com/repos/uber/tchannel/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel/releases{/id}","created_at":"2014-12-23T21:06:57Z","updated_at":"2015-08-04T17:18:21Z","pushed_at":"2015-08-04T17:56:00Z","git_url":"git://github.com/uber/tchannel.git","ssh_url":"git@github.com:uber/tchannel.git","clone_url":"https://github.com/uber/tchannel.git","svn_url":"https://github.com/uber/tchannel","homepage":"","size":21749,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":74,"forks":11,"open_issues":74,"watchers":127,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"c95be5d58c0b72affe037ea15adcc0500e1fe92a","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":28419663,"name":"tchannel","full_name":"uber/tchannel","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel","description":"network multiplexing and framing protocol for RPC","fork":false,"url":"https://api.github.com/repos/uber/tchannel","forks_url":"https://api.github.com/repos/uber/tchannel/forks","keys_url":"https://api.github.com/repos/uber/tchannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel/teams","hooks_url":"https://api.github.com/repos/uber/tchannel/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel/events","assignees_url":"https://api.github.com/repos/uber/tchannel/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel/tags","blobs_url":"https://api.github.com/repos/uber/tchannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel/subscription","commits_url":"https://api.github.com/repos/uber/tchannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel/merges","archive_url":"https://api.github.com/repos/uber/tchannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel/downloads","issues_url":"https://api.github.com/repos/uber/tchannel/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel/releases{/id}","created_at":"2014-12-23T21:06:57Z","updated_at":"2015-08-04T17:18:21Z","pushed_at":"2015-08-04T17:56:00Z","git_url":"git://github.com/uber/tchannel.git","ssh_url":"git@github.com:uber/tchannel.git","clone_url":"https://github.com/uber/tchannel.git","svn_url":"https://github.com/uber/tchannel","homepage":"","size":21749,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":74,"forks":11,"open_issues":74,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1106"},"html":{"href":"https://github.com/uber/tchannel/pull/1106"},"issue":{"href":"https://api.github.com/repos/uber/tchannel/issues/1106"},"comments":{"href":"https://api.github.com/repos/uber/tchannel/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel/statuses/48d56ea630a2a313ac33c57487f09b715c76f0d7"}}}}