{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/6587","labels_url":"https://api.github.com/repos/apache/spark/issues/6587/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/6587/comments","events_url":"https://api.github.com/repos/apache/spark/issues/6587/events","html_url":"https://github.com/apache/spark/pull/6587","id":84049369,"number":6587,"title":"[SPARK-7269] [SQL] [WIP] Refactor the class AttributeReference","user":{"login":"chenghao-intel","id":2367031,"avatar_url":"https://avatars.githubusercontent.com/u/2367031?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghao-intel","html_url":"https://github.com/chenghao-intel","followers_url":"https://api.github.com/users/chenghao-intel/followers","following_url":"https://api.github.com/users/chenghao-intel/following{/other_user}","gists_url":"https://api.github.com/users/chenghao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghao-intel/subscriptions","organizations_url":"https://api.github.com/users/chenghao-intel/orgs","repos_url":"https://api.github.com/users/chenghao-intel/repos","events_url":"https://api.github.com/users/chenghao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/chenghao-intel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-06-02T14:31:01Z","updated_at":"2015-06-03T06:48:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6587","html_url":"https://github.com/apache/spark/pull/6587","diff_url":"https://github.com/apache/spark/pull/6587.diff","patch_url":"https://github.com/apache/spark/pull/6587.patch"},"body":"- The methods of `equals` and `hashCode` in case class `AttributeReference` are quite confusing, as it doesn't work like normal case class. \r\n- Besides, in semantic, `AttributeReference` should not care about the `name`, which supposed to be the hint of binding attribute references.\r\n- Remove the `semanticEquals` for `Expression`, this method is actually redundant and hard to make an accurate definition for `Semantic Equals`. \r\n\r\nI marked it as `WIP` for feedback / discussion.\r\n\r\nStill,\r\n- [ ] Refactor the `Alias` also? `Alias(child, \"id\")` is `semantically` equals `Alias(child, \"iD\")` in a case insensitive system?\r\n- [ ] Remove the `AttributeMap` or `AttributeSet` to simplify the code."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/108213528","html_url":"https://github.com/apache/spark/pull/6587#issuecomment-108213528","issue_url":"https://api.github.com/repos/apache/spark/issues/6587","id":108213528,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T06:48:26Z","updated_at":"2015-06-03T06:48:26Z","body":"Merged build finished. Test FAILed."}}