{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/41395123","id":41395123,"diff_hunk":"@@ -160,8 +176,10 @@ else if (flinkRoot != null) {\n \t\t\t// the overview - how many task managers, slots, free slots, ...\n \t\t\t.GET(\"/overview\", handler(new ClusterOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT)))\n \n-\t\t\t// job manager configuration\n+\t\t\t// job manager configuration, log and stdout\n \t\t\t.GET(\"/jobmanager/config\", handler(new JobManagerConfigHandler(config)))\n+\t\t\t.GET(\"/jobmanager/logfile\", new StaticFileServerHandler(logStdoutDir))","path":"flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java","position":41,"original_position":41,"commit_id":"2939b07e2028391623c6fad8ad727b7b34a6e087","original_commit_id":"2939b07e2028391623c6fad8ad727b7b34a6e087","user":{"login":"uce","id":1756620,"avatar_url":"https://avatars.githubusercontent.com/u/1756620?v=3","gravatar_id":"","url":"https://api.github.com/users/uce","html_url":"https://github.com/uce","followers_url":"https://api.github.com/users/uce/followers","following_url":"https://api.github.com/users/uce/following{/other_user}","gists_url":"https://api.github.com/users/uce/gists{/gist_id}","starred_url":"https://api.github.com/users/uce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uce/subscriptions","organizations_url":"https://api.github.com/users/uce/orgs","repos_url":"https://api.github.com/users/uce/repos","events_url":"https://api.github.com/users/uce/events{/privacy}","received_events_url":"https://api.github.com/users/uce/received_events","type":"User","site_admin":false},"body":"log is fine imo","created_at":"2015-10-07T14:16:05Z","updated_at":"2015-10-07T14:16:05Z","html_url":"https://github.com/apache/flink/pull/1233#discussion_r41395123","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1233","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/41395123"},"html":{"href":"https://github.com/apache/flink/pull/1233#discussion_r41395123"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1233"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1233","id":46929919,"html_url":"https://github.com/apache/flink/pull/1233","diff_url":"https://github.com/apache/flink/pull/1233.diff","patch_url":"https://github.com/apache/flink/pull/1233.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1233","number":1233,"state":"open","locked":false,"title":"[FLINK-2731][web-dashboard] Adds access to Job Manager stdout and log.","user":{"login":"sachingoel0101","id":8874261,"avatar_url":"https://avatars.githubusercontent.com/u/8874261?v=3","gravatar_id":"","url":"https://api.github.com/users/sachingoel0101","html_url":"https://github.com/sachingoel0101","followers_url":"https://api.github.com/users/sachingoel0101/followers","following_url":"https://api.github.com/users/sachingoel0101/following{/other_user}","gists_url":"https://api.github.com/users/sachingoel0101/gists{/gist_id}","starred_url":"https://api.github.com/users/sachingoel0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachingoel0101/subscriptions","organizations_url":"https://api.github.com/users/sachingoel0101/orgs","repos_url":"https://api.github.com/users/sachingoel0101/repos","events_url":"https://api.github.com/users/sachingoel0101/events{/privacy}","received_events_url":"https://api.github.com/users/sachingoel0101/received_events","type":"User","site_admin":false},"body":"This adds minimalist support for accessing Job manager logs and stdout files to the new web frontend.\r\nRight now, to refresh the logs, user needs to explicitly press the refresh button, at which the whole log/stdout file is re-fetched and shown.\r\n\r\nLater on, I plan to implement a better system which doesn't have to fetch the whole file again. That might take some time and not be complete in time for the next release.\r\n@uce , can you take a look at this?\r\nAttaching a few screenshots:\r\nLogs:\r\n\r\n![log](https://cloud.githubusercontent.com/assets/8874261/10315839/35641984-6c7a-11e5-98d7-253e74b3e684.PNG)\r\n\r\nLogs file download:\r\n\r\n![log_download](https://cloud.githubusercontent.com/assets/8874261/10315847/3d379118-6c7a-11e5-8dce-cb53eaf1ef5f.PNG)\r\n\r\nStdout:\r\n\r\n![out](https://cloud.githubusercontent.com/assets/8874261/10315861/54c22370-6c7a-11e5-980d-d87f8f2ce7a8.PNG)\r\n\r\nStdout file download:\r\n\r\n![out_download](https://cloud.githubusercontent.com/assets/8874261/10315870/65b4e488-6c7a-11e5-9d05-9bf0f015f3f2.PNG)\r\n\r\n","created_at":"2015-10-06T17:04:40Z","updated_at":"2015-10-07T14:16:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bda3c66de4ff54c8d6d1b023e619d2b79001dc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1233/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1233/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1233/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/2939b07e2028391623c6fad8ad727b7b34a6e087","head":{"label":"sachingoel0101:jobmanagerlog","ref":"jobmanagerlog","sha":"2939b07e2028391623c6fad8ad727b7b34a6e087","user":{"login":"sachingoel0101","id":8874261,"avatar_url":"https://avatars.githubusercontent.com/u/8874261?v=3","gravatar_id":"","url":"https://api.github.com/users/sachingoel0101","html_url":"https://github.com/sachingoel0101","followers_url":"https://api.github.com/users/sachingoel0101/followers","following_url":"https://api.github.com/users/sachingoel0101/following{/other_user}","gists_url":"https://api.github.com/users/sachingoel0101/gists{/gist_id}","starred_url":"https://api.github.com/users/sachingoel0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachingoel0101/subscriptions","organizations_url":"https://api.github.com/users/sachingoel0101/orgs","repos_url":"https://api.github.com/users/sachingoel0101/repos","events_url":"https://api.github.com/users/sachingoel0101/events{/privacy}","received_events_url":"https://api.github.com/users/sachingoel0101/received_events","type":"User","site_admin":false},"repo":{"id":35545853,"name":"flink","full_name":"sachingoel0101/flink","owner":{"login":"sachingoel0101","id":8874261,"avatar_url":"https://avatars.githubusercontent.com/u/8874261?v=3","gravatar_id":"","url":"https://api.github.com/users/sachingoel0101","html_url":"https://github.com/sachingoel0101","followers_url":"https://api.github.com/users/sachingoel0101/followers","following_url":"https://api.github.com/users/sachingoel0101/following{/other_user}","gists_url":"https://api.github.com/users/sachingoel0101/gists{/gist_id}","starred_url":"https://api.github.com/users/sachingoel0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachingoel0101/subscriptions","organizations_url":"https://api.github.com/users/sachingoel0101/orgs","repos_url":"https://api.github.com/users/sachingoel0101/repos","events_url":"https://api.github.com/users/sachingoel0101/events{/privacy}","received_events_url":"https://api.github.com/users/sachingoel0101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sachingoel0101/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/sachingoel0101/flink","forks_url":"https://api.github.com/repos/sachingoel0101/flink/forks","keys_url":"https://api.github.com/repos/sachingoel0101/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sachingoel0101/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sachingoel0101/flink/teams","hooks_url":"https://api.github.com/repos/sachingoel0101/flink/hooks","issue_events_url":"https://api.github.com/repos/sachingoel0101/flink/issues/events{/number}","events_url":"https://api.github.com/repos/sachingoel0101/flink/events","assignees_url":"https://api.github.com/repos/sachingoel0101/flink/assignees{/user}","branches_url":"https://api.github.com/repos/sachingoel0101/flink/branches{/branch}","tags_url":"https://api.github.com/repos/sachingoel0101/flink/tags","blobs_url":"https://api.github.com/repos/sachingoel0101/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sachingoel0101/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sachingoel0101/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/sachingoel0101/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sachingoel0101/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/sachingoel0101/flink/languages","stargazers_url":"https://api.github.com/repos/sachingoel0101/flink/stargazers","contributors_url":"https://api.github.com/repos/sachingoel0101/flink/contributors","subscribers_url":"https://api.github.com/repos/sachingoel0101/flink/subscribers","subscription_url":"https://api.github.com/repos/sachingoel0101/flink/subscription","commits_url":"https://api.github.com/repos/sachingoel0101/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/sachingoel0101/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/sachingoel0101/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/sachingoel0101/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/sachingoel0101/flink/contents/{+path}","compare_url":"https://api.github.com/repos/sachingoel0101/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sachingoel0101/flink/merges","archive_url":"https://api.github.com/repos/sachingoel0101/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sachingoel0101/flink/downloads","issues_url":"https://api.github.com/repos/sachingoel0101/flink/issues{/number}","pulls_url":"https://api.github.com/repos/sachingoel0101/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/sachingoel0101/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/sachingoel0101/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sachingoel0101/flink/labels{/name}","releases_url":"https://api.github.com/repos/sachingoel0101/flink/releases{/id}","created_at":"2015-05-13T11:44:31Z","updated_at":"2015-05-13T11:44:41Z","pushed_at":"2015-10-07T14:09:24Z","git_url":"git://github.com/sachingoel0101/flink.git","ssh_url":"git@github.com:sachingoel0101/flink.git","clone_url":"https://github.com/sachingoel0101/flink.git","svn_url":"https://github.com/sachingoel0101/flink","homepage":null,"size":65675,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"af1e03e131bbc72baa12b4ffdcde35648a41ad4d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-10-06T22:31:59Z","pushed_at":"2015-10-07T14:11:27Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2660349,"stargazers_count":657,"watchers_count":657,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":451,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":74,"forks":451,"open_issues":74,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1233"},"html":{"href":"https://github.com/apache/flink/pull/1233"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1233"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1233/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1233/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1233/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/2939b07e2028391623c6fad8ad727b7b34a6e087"}}}}