{"action":"created","issue":{"url":"https://api.github.com/repos/rylnd/shpec/issues/87","labels_url":"https://api.github.com/repos/rylnd/shpec/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/rylnd/shpec/issues/87/comments","events_url":"https://api.github.com/repos/rylnd/shpec/issues/87/events","html_url":"https://github.com/rylnd/shpec/issues/87","id":81185711,"number":87,"title":"Install shpec on CI","user":{"login":"rylnd","id":657252,"avatar_url":"https://avatars.githubusercontent.com/u/657252?v=3","gravatar_id":"","url":"https://api.github.com/users/rylnd","html_url":"https://github.com/rylnd","followers_url":"https://api.github.com/users/rylnd/followers","following_url":"https://api.github.com/users/rylnd/following{/other_user}","gists_url":"https://api.github.com/users/rylnd/gists{/gist_id}","starred_url":"https://api.github.com/users/rylnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylnd/subscriptions","organizations_url":"https://api.github.com/users/rylnd/orgs","repos_url":"https://api.github.com/users/rylnd/repos","events_url":"https://api.github.com/users/rylnd/events{/privacy}","received_events_url":"https://api.github.com/users/rylnd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-05-26T23:36:50Z","updated_at":"2015-05-31T00:12:18Z","closed_at":null,"body":"Currently, we're just running shpec directly from the repo. Given the issues addressed in #86, I think it makes sense to actually install shpec on the CI box. \r\n\r\nCurrently, that'll mean simply running `make install` as a setup script. In the case of zsh, we'll additionally source the antigen plugin."},"comment":{"url":"https://api.github.com/repos/rylnd/shpec/issues/comments/107102864","html_url":"https://github.com/rylnd/shpec/issues/87#issuecomment-107102864","issue_url":"https://api.github.com/repos/rylnd/shpec/issues/87","id":107102864,"user":{"login":"locochris","id":2774052,"avatar_url":"https://avatars.githubusercontent.com/u/2774052?v=3","gravatar_id":"","url":"https://api.github.com/users/locochris","html_url":"https://github.com/locochris","followers_url":"https://api.github.com/users/locochris/followers","following_url":"https://api.github.com/users/locochris/following{/other_user}","gists_url":"https://api.github.com/users/locochris/gists{/gist_id}","starred_url":"https://api.github.com/users/locochris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locochris/subscriptions","organizations_url":"https://api.github.com/users/locochris/orgs","repos_url":"https://api.github.com/users/locochris/repos","events_url":"https://api.github.com/users/locochris/events{/privacy}","received_events_url":"https://api.github.com/users/locochris/received_events","type":"User","site_admin":false},"created_at":"2015-05-31T00:12:18Z","updated_at":"2015-05-31T00:12:18Z","body":"@AdrieanKhisbe - besides being confusing to the end user, I'm not sure if we need a `dashpec`, `ksphec`, `zshpec` - aren't we running `shpec` across all shells to prove `shpec`'s posix compliance; ie. that it will work the same in any shell?  (For the rubyists - would you get confused if `rspec` was called `jrspec` when you were running tests in `jruby`?)\r\n\r\n@rylnd - the way I see it our current tests are unit tests:\r\n * they're actually testing across all shells; which is a good thing\r\n * they don't require an installation dependency (on shpec) just to run as unit tests; which is a good thing\r\n * they're not being run in the way we recommend in the README; but that should be OK as they're unit tests\r\n\r\nThat said I think its a good thing (yet rarely done in the wild) if you can test the actual installation (and usage) instructions documented in your README.  So I guess what we're missing here are _installation_ tests.\r\n\r\nPerhaps:\r\n```\r\nshpec/\r\n└── installation\r\n    ├── bash_shpec.sh\r\n    ├── dash_shpec.sh\r\n    ├── ksh_shpec.sh\r\n    └── zsh_shpec.sh\r\n```\r\n\r\nAnd in the `.travis.yml` have the matrix:\r\n```\r\n    - LINT=true\r\n    - UNIT_TEST_SHELL=bash\r\n    - UNIT_TEST_SHELL=dash\r\n    - UNIT_TEST_SHELL=ksh\r\n    - UNIT_TEST_SHELL=zsh\r\n    - INSTALLATION_TEST_SHELL=bash\r\n    - INSTALLATION_TEST_SHELL=dash\r\n    - INSTALLATION_TEST_SHELL=ksh\r\n    - INSTALLATION_TEST_SHELL=zsh\r\n```\r\nAlthough I'd probably only bother testing the installation in `bash` (for a happy path) and `zsh` (for its complicated path).  And keep in mind, we can only get coverage for these installation tests on ubuntu (ie. on travis); we won't have tests to know if the installation works in other OS's.\r\n\r\n@hlangeveld - from more than just a name on the screen, to another name on the screen - some heartfelt thoughts & best wishes.  (BTW \"infracoder\" = \"coding infrastucture\"?,  chef etc?; \"SF association\" = ??)"}}