{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/43134361","id":43134361,"diff_hunk":"@@ -59,13 +34,32 @@ angular.module(\"openshiftConsole\")\n               protocol: parts[1].toUpperCase()\n             });\n         });\n+\n+        // Since the exposed ports in Docker image metadata are not in any\n+        // order, sort the ports from lowest to highest.\n+        ports.sort(function(left, right) {\n+          return left.containerPort - right.containerPort;","path":"assets/app/scripts/services/applicationGenerator.js","position":67,"original_position":45,"commit_id":"fc7640c694fda72df9ba146fc4af30fa0368823b","original_commit_id":"78a12eed5ab503ac0b7fcefd0da0011428f2a466","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Added an `isNaN()` check above after calling `parseInt()`.","created_at":"2015-10-27T15:07:49Z","updated_at":"2015-10-27T15:07:49Z","html_url":"https://github.com/openshift/origin/pull/4956#discussion_r43134361","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4956","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/43134361"},"html":{"href":"https://github.com/openshift/origin/pull/4956#discussion_r43134361"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4956"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4956","id":46827867,"html_url":"https://github.com/openshift/origin/pull/4956","diff_url":"https://github.com/openshift/origin/pull/4956.diff","patch_url":"https://github.com/openshift/origin/pull/4956.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4956","number":4956,"state":"open","locked":false,"title":"Expose all container ports creating from source in the UI","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Fixes #3764\r\n\r\nSee also #4603 and previous PR #3837\r\n\r\n- [x] Add target port to route\r\n- [x] Don't generate route or service if no container ports","created_at":"2015-10-05T20:15:52Z","updated_at":"2015-10-27T15:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf62eb5fafc5ee8a40bb4328ab137a391ebd8362","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4956/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4956/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4956/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/fc7640c694fda72df9ba146fc4af30fa0368823b","head":{"label":"spadgett:service-ports","ref":"service-ports","sha":"fc7640c694fda72df9ba146fc4af30fa0368823b","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":34353535,"name":"origin","full_name":"spadgett/origin","owner":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/spadgett/origin","forks_url":"https://api.github.com/repos/spadgett/origin/forks","keys_url":"https://api.github.com/repos/spadgett/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/origin/teams","hooks_url":"https://api.github.com/repos/spadgett/origin/hooks","issue_events_url":"https://api.github.com/repos/spadgett/origin/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/origin/events","assignees_url":"https://api.github.com/repos/spadgett/origin/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/origin/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/origin/tags","blobs_url":"https://api.github.com/repos/spadgett/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/origin/languages","stargazers_url":"https://api.github.com/repos/spadgett/origin/stargazers","contributors_url":"https://api.github.com/repos/spadgett/origin/contributors","subscribers_url":"https://api.github.com/repos/spadgett/origin/subscribers","subscription_url":"https://api.github.com/repos/spadgett/origin/subscription","commits_url":"https://api.github.com/repos/spadgett/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/origin/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/origin/merges","archive_url":"https://api.github.com/repos/spadgett/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/origin/downloads","issues_url":"https://api.github.com/repos/spadgett/origin/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/origin/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/origin/releases{/id}","created_at":"2015-04-21T21:38:33Z","updated_at":"2015-05-08T19:33:23Z","pushed_at":"2015-10-27T15:06:28Z","git_url":"git://github.com/spadgett/origin.git","ssh_url":"git@github.com:spadgett/origin.git","clone_url":"https://github.com/spadgett/origin.git","svn_url":"https://github.com/spadgett/origin","homepage":"http://www.openshift.org","size":169824,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"814c05e869d16a1252855bab7244b72989e1857c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-10-27T12:01:55Z","pushed_at":"2015-10-27T15:06:29Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":307545,"stargazers_count":768,"watchers_count":768,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":474,"mirror_url":null,"open_issues_count":619,"forks":474,"open_issues":619,"watchers":768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4956"},"html":{"href":"https://github.com/openshift/origin/pull/4956"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4956"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4956/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4956/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4956/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/fc7640c694fda72df9ba146fc4af30fa0368823b"}}}}