{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/48142083","id":48142083,"diff_hunk":"@@ -0,0 +1,60 @@\n+# ***************************************************************************\n+#\n+# Copyright (c) 2015 SUSE LLC\n+# All Rights Reserved.\n+#\n+# This program is free software; you can redistribute it and/or\n+# modify it under the terms of version 2 of the GNU General Public License as\n+# published by the Free Software Foundation.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.   See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program; if not, contact Novell, Inc.\n+#\n+# To contact Novell about this file by physical or electronic mail,\n+# you may find current contact information at www.novell.com\n+#\n+# ***************************************************************************\n+\n+require \"yast\"\n+require \"cheetah\"\n+\n+Yast.import \"Installation\"\n+\n+module Yast2","path":"library/system/src/lib/yast2/execute.rb","position":28,"original_position":28,"commit_id":"f0bae77ea73f9323e66d65545d68ba71c024919b","original_commit_id":"f0bae77ea73f9323e66d65545d68ba71c024919b","user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars.githubusercontent.com/u/102056?v=3","gravatar_id":"","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"I see. Hmm, as soon as we step outside the directory, consistency is gone (13.2) : \r\n```console\r\n$ cd /usr/share/YaST2/lib; grep -rT ^module .| while read F T; do printf '%-50s  %s\\n' \"$F\" \"$T\"; done\r\n./services-manager/ui_elements.rb                  :module UIElements\r\n./services-manager/services_manager_profile.rb     :module Yast\r\n./installation/clone_settings.rb                   :module Installation\r\n./installation/minimal_installation.rb             :module Installation\r\n./installation/prep_shrink.rb                      :module Installation\r\n./installation/cio_ignore.rb                       :module Installation\r\n./installation/remote_finish_client.rb             :module Installation\r\n./ydocker/run_image_dialog.rb                      :module YDocker\r\n./ydocker/commit_dialog.rb                         :module YDocker\r\n./ydocker/changes_dialog.rb                        :module YDocker\r\n./ydocker/inject_shell_dialog.rb                   :module YDocker\r\n./ydocker/main_dialog.rb                           :module YDocker\r\n./fonts/fpl-add-dialog.rb                          :module FontsConfig\r\n./fonts/select-ebl-dialog.rb                       :module FontsConfig\r\n./fonts/fonts-dialog.rb                            :module FontsConfig\r\n./fonts/shell-commands.rb                          :module FontsConfig\r\n./fonts/fonts-config-state.rb                      :module FontsConfig\r\n./fonts/rich-text-dialog.rb                        :module FontsConfig\r\n./bootloader/boot_record_backup.rb                 :module Bootloader\r\n./bootloader/grub2base.rb                          :module Yast\r\n./bootloader/device_mapping.rb                     :module Bootloader\r\n./yast2/systemd_unit.rb                            :module Yast\r\n./yast2/hw_detection.rb                            :module Yast2\r\n./yast2/systemctl.rb                               :module Yast\r\n./network/edit_nic_name.rb                         :module Yast\r\n./network/install_inf_convertor.rb                 :module Yast\r\n./network/confirm_virt_proposal.rb                 :module Yast\r\n./network/network_autoconfiguration.rb             :module Yast\r\n```\r\n\r\nApparently some packages start with the package name at top namespace level while others wrap it in a common `Yast` module, and yast2.rpm uses `Yast2` as the package name.\r\n\r\nI think it would be best to use wrapper `Yast` everywhere, including here.","created_at":"2015-12-21T12:41:58Z","updated_at":"2015-12-21T12:41:58Z","html_url":"https://github.com/yast/yast-yast2/pull/419#discussion_r48142083","pull_request_url":"https://api.github.com/repos/yast/yast-yast2/pulls/419","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/48142083"},"html":{"href":"https://github.com/yast/yast-yast2/pull/419#discussion_r48142083"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/419"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/419","id":54118443,"html_url":"https://github.com/yast/yast-yast2/pull/419","diff_url":"https://github.com/yast/yast-yast2/pull/419.diff","patch_url":"https://github.com/yast/yast-yast2/pull/419.patch","issue_url":"https://api.github.com/repos/yast/yast-yast2/issues/419","number":419,"state":"open","locked":false,"title":"[do not merge] add support for running programs without SCR and also for using confi…","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?v=3","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"…g_files_api gem\r\n\r\ninitial RFC to get feedback. I do not want to introduce dependency on cheetah now, but will happen probably in future when it is accepted to TW.","created_at":"2015-12-18T16:00:58Z","updated_at":"2015-12-21T12:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16e6538d9a9c24389828461114d52dbc6281b079","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-yast2/pulls/419/commits","review_comments_url":"https://api.github.com/repos/yast/yast-yast2/pulls/419/comments","review_comment_url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-yast2/issues/419/comments","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/f0bae77ea73f9323e66d65545d68ba71c024919b","head":{"label":"yast:on_target","ref":"on_target","sha":"f0bae77ea73f9323e66d65545d68ba71c024919b","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","created_at":"2012-05-18T10:27:22Z","updated_at":"2015-09-20T18:17:26Z","pushed_at":"2015-12-18T16:08:45Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":24466,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":4,"forks":24,"open_issues":4,"watchers":10,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"fcc522455ed8ce4de011642be05b9f2084980bcd","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","created_at":"2012-05-18T10:27:22Z","updated_at":"2015-09-20T18:17:26Z","pushed_at":"2015-12-18T16:08:45Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":24466,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":4,"forks":24,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/419"},"html":{"href":"https://github.com/yast/yast-yast2/pull/419"},"issue":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/419"},"comments":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-yast2/statuses/f0bae77ea73f9323e66d65545d68ba71c024919b"}}}}