{"action":"created","comment":{"url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/comments/43003325","id":43003325,"diff_hunk":"@@ -25,17 +25,23 @@ def __init__(self, n_input_vol, n_output_vol, k_w, k_h, k_d, with_bias=True, ini\n \n     def symb_forward(self, symb_input):\n \n-        \"\"\"symb_input shape: (n_input, depth, channels, height, width)\"\"\"\n+        \"\"\"symb_input shape: (n_input, channels, depth, height, width)\"\"\"\n \n         if symb_input.ndim < 5:\n             raise NotImplementedError('3D convolution requires a dimension >= 5')\n \n+        # shuffle bcd01 -> bdc01\n+        symb_input = symb_input.dimshuffle(0,2,1,3,4)\n+\n         conv_output = conv3d2d.conv3d(symb_input,\n                                       self.weight,\n                                       filters_shape=self.w_shape,\n                                       border_mode=self.border_mode)\n \n+        # shuffle bdc01 -> bcd01\n+        conv_output = conv_output.dimshuffle(0,2,1,3,4)","path":"DeepFried2/layers/SpatialConvolution3D.py","position":19,"original_position":19,"commit_id":"34e94805354020b1e800990d0ea56eba7953828e","original_commit_id":"34e94805354020b1e800990d0ea56eba7953828e","user":{"login":"lucasb-eyer","id":1476029,"avatar_url":"https://avatars.githubusercontent.com/u/1476029?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasb-eyer","html_url":"https://github.com/lucasb-eyer","followers_url":"https://api.github.com/users/lucasb-eyer/followers","following_url":"https://api.github.com/users/lucasb-eyer/following{/other_user}","gists_url":"https://api.github.com/users/lucasb-eyer/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasb-eyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasb-eyer/subscriptions","organizations_url":"https://api.github.com/users/lucasb-eyer/orgs","repos_url":"https://api.github.com/users/lucasb-eyer/repos","events_url":"https://api.github.com/users/lucasb-eyer/events{/privacy}","received_events_url":"https://api.github.com/users/lucasb-eyer/received_events","type":"User","site_admin":false},"body":"Maybe `foo.swapaxes(1,2)` would be clearer here and above? But I'm also fine with keeping this as-is, I'll let you decide.","created_at":"2015-10-26T14:56:25Z","updated_at":"2015-10-26T14:56:25Z","html_url":"https://github.com/lucasb-eyer/DeepFried2/pull/34#discussion_r43003325","pull_request_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/comments/43003325"},"html":{"href":"https://github.com/lucasb-eyer/DeepFried2/pull/34#discussion_r43003325"},"pull_request":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34","id":48729313,"html_url":"https://github.com/lucasb-eyer/DeepFried2/pull/34","diff_url":"https://github.com/lucasb-eyer/DeepFried2/pull/34.diff","patch_url":"https://github.com/lucasb-eyer/DeepFried2/pull/34.patch","issue_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/34","number":34,"state":"open","locked":false,"title":"consistent expected ordering of input for 3D related layers","user":{"login":"elPistolero","id":701697,"avatar_url":"https://avatars.githubusercontent.com/u/701697?v=3","gravatar_id":"","url":"https://api.github.com/users/elPistolero","html_url":"https://github.com/elPistolero","followers_url":"https://api.github.com/users/elPistolero/followers","following_url":"https://api.github.com/users/elPistolero/following{/other_user}","gists_url":"https://api.github.com/users/elPistolero/gists{/gist_id}","starred_url":"https://api.github.com/users/elPistolero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elPistolero/subscriptions","organizations_url":"https://api.github.com/users/elPistolero/orgs","repos_url":"https://api.github.com/users/elPistolero/repos","events_url":"https://api.github.com/users/elPistolero/events{/privacy}","received_events_url":"https://api.github.com/users/elPistolero/received_events","type":"User","site_admin":false},"body":"This makes the ordering for the input consistent with the CUDNN format (n_input, channels, depth, height, width)","created_at":"2015-10-26T11:46:04Z","updated_at":"2015-10-26T14:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8908912ff1f100fe99b8a73b1ba015e67f5e6f94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34/commits","review_comments_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34/comments","review_comment_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/34/comments","statuses_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/statuses/34e94805354020b1e800990d0ea56eba7953828e","head":{"label":"elPistolero:ordering","ref":"ordering","sha":"34e94805354020b1e800990d0ea56eba7953828e","user":{"login":"elPistolero","id":701697,"avatar_url":"https://avatars.githubusercontent.com/u/701697?v=3","gravatar_id":"","url":"https://api.github.com/users/elPistolero","html_url":"https://github.com/elPistolero","followers_url":"https://api.github.com/users/elPistolero/followers","following_url":"https://api.github.com/users/elPistolero/following{/other_user}","gists_url":"https://api.github.com/users/elPistolero/gists{/gist_id}","starred_url":"https://api.github.com/users/elPistolero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elPistolero/subscriptions","organizations_url":"https://api.github.com/users/elPistolero/orgs","repos_url":"https://api.github.com/users/elPistolero/repos","events_url":"https://api.github.com/users/elPistolero/events{/privacy}","received_events_url":"https://api.github.com/users/elPistolero/received_events","type":"User","site_admin":false},"repo":{"id":40975386,"name":"DeepFried2","full_name":"elPistolero/DeepFried2","owner":{"login":"elPistolero","id":701697,"avatar_url":"https://avatars.githubusercontent.com/u/701697?v=3","gravatar_id":"","url":"https://api.github.com/users/elPistolero","html_url":"https://github.com/elPistolero","followers_url":"https://api.github.com/users/elPistolero/followers","following_url":"https://api.github.com/users/elPistolero/following{/other_user}","gists_url":"https://api.github.com/users/elPistolero/gists{/gist_id}","starred_url":"https://api.github.com/users/elPistolero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elPistolero/subscriptions","organizations_url":"https://api.github.com/users/elPistolero/orgs","repos_url":"https://api.github.com/users/elPistolero/repos","events_url":"https://api.github.com/users/elPistolero/events{/privacy}","received_events_url":"https://api.github.com/users/elPistolero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elPistolero/DeepFried2","description":"A Torch-inspired library for high-level deep learning with Theano. (ex-Beacon8)","fork":true,"url":"https://api.github.com/repos/elPistolero/DeepFried2","forks_url":"https://api.github.com/repos/elPistolero/DeepFried2/forks","keys_url":"https://api.github.com/repos/elPistolero/DeepFried2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elPistolero/DeepFried2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elPistolero/DeepFried2/teams","hooks_url":"https://api.github.com/repos/elPistolero/DeepFried2/hooks","issue_events_url":"https://api.github.com/repos/elPistolero/DeepFried2/issues/events{/number}","events_url":"https://api.github.com/repos/elPistolero/DeepFried2/events","assignees_url":"https://api.github.com/repos/elPistolero/DeepFried2/assignees{/user}","branches_url":"https://api.github.com/repos/elPistolero/DeepFried2/branches{/branch}","tags_url":"https://api.github.com/repos/elPistolero/DeepFried2/tags","blobs_url":"https://api.github.com/repos/elPistolero/DeepFried2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elPistolero/DeepFried2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elPistolero/DeepFried2/git/refs{/sha}","trees_url":"https://api.github.com/repos/elPistolero/DeepFried2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elPistolero/DeepFried2/statuses/{sha}","languages_url":"https://api.github.com/repos/elPistolero/DeepFried2/languages","stargazers_url":"https://api.github.com/repos/elPistolero/DeepFried2/stargazers","contributors_url":"https://api.github.com/repos/elPistolero/DeepFried2/contributors","subscribers_url":"https://api.github.com/repos/elPistolero/DeepFried2/subscribers","subscription_url":"https://api.github.com/repos/elPistolero/DeepFried2/subscription","commits_url":"https://api.github.com/repos/elPistolero/DeepFried2/commits{/sha}","git_commits_url":"https://api.github.com/repos/elPistolero/DeepFried2/git/commits{/sha}","comments_url":"https://api.github.com/repos/elPistolero/DeepFried2/comments{/number}","issue_comment_url":"https://api.github.com/repos/elPistolero/DeepFried2/issues/comments{/number}","contents_url":"https://api.github.com/repos/elPistolero/DeepFried2/contents/{+path}","compare_url":"https://api.github.com/repos/elPistolero/DeepFried2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elPistolero/DeepFried2/merges","archive_url":"https://api.github.com/repos/elPistolero/DeepFried2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elPistolero/DeepFried2/downloads","issues_url":"https://api.github.com/repos/elPistolero/DeepFried2/issues{/number}","pulls_url":"https://api.github.com/repos/elPistolero/DeepFried2/pulls{/number}","milestones_url":"https://api.github.com/repos/elPistolero/DeepFried2/milestones{/number}","notifications_url":"https://api.github.com/repos/elPistolero/DeepFried2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elPistolero/DeepFried2/labels{/name}","releases_url":"https://api.github.com/repos/elPistolero/DeepFried2/releases{/id}","created_at":"2015-08-18T14:02:45Z","updated_at":"2015-08-18T14:02:46Z","pushed_at":"2015-10-26T11:52:58Z","git_url":"git://github.com/elPistolero/DeepFried2.git","ssh_url":"git@github.com:elPistolero/DeepFried2.git","clone_url":"https://github.com/elPistolero/DeepFried2.git","svn_url":"https://github.com/elPistolero/DeepFried2","homepage":null,"size":297,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lucasb-eyer:master","ref":"master","sha":"913a8fc105e56c05efce631c49aed0176da3b2ed","user":{"login":"lucasb-eyer","id":1476029,"avatar_url":"https://avatars.githubusercontent.com/u/1476029?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasb-eyer","html_url":"https://github.com/lucasb-eyer","followers_url":"https://api.github.com/users/lucasb-eyer/followers","following_url":"https://api.github.com/users/lucasb-eyer/following{/other_user}","gists_url":"https://api.github.com/users/lucasb-eyer/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasb-eyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasb-eyer/subscriptions","organizations_url":"https://api.github.com/users/lucasb-eyer/orgs","repos_url":"https://api.github.com/users/lucasb-eyer/repos","events_url":"https://api.github.com/users/lucasb-eyer/events{/privacy}","received_events_url":"https://api.github.com/users/lucasb-eyer/received_events","type":"User","site_admin":false},"repo":{"id":40254129,"name":"DeepFried2","full_name":"lucasb-eyer/DeepFried2","owner":{"login":"lucasb-eyer","id":1476029,"avatar_url":"https://avatars.githubusercontent.com/u/1476029?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasb-eyer","html_url":"https://github.com/lucasb-eyer","followers_url":"https://api.github.com/users/lucasb-eyer/followers","following_url":"https://api.github.com/users/lucasb-eyer/following{/other_user}","gists_url":"https://api.github.com/users/lucasb-eyer/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasb-eyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasb-eyer/subscriptions","organizations_url":"https://api.github.com/users/lucasb-eyer/orgs","repos_url":"https://api.github.com/users/lucasb-eyer/repos","events_url":"https://api.github.com/users/lucasb-eyer/events{/privacy}","received_events_url":"https://api.github.com/users/lucasb-eyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasb-eyer/DeepFried2","description":"A Torch-inspired library for high-level deep learning with Theano. (ex-Beacon8)","fork":false,"url":"https://api.github.com/repos/lucasb-eyer/DeepFried2","forks_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/forks","keys_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/teams","hooks_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/hooks","issue_events_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/events{/number}","events_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/events","assignees_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/assignees{/user}","branches_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/branches{/branch}","tags_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/tags","blobs_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/languages","stargazers_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/stargazers","contributors_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/contributors","subscribers_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/subscribers","subscription_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/subscription","commits_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/contents/{+path}","compare_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/merges","archive_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/downloads","issues_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues{/number}","pulls_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/labels{/name}","releases_url":"https://api.github.com/repos/lucasb-eyer/DeepFried2/releases{/id}","created_at":"2015-08-05T15:44:55Z","updated_at":"2015-08-05T15:45:43Z","pushed_at":"2015-10-26T11:53:25Z","git_url":"git://github.com/lucasb-eyer/DeepFried2.git","ssh_url":"git@github.com:lucasb-eyer/DeepFried2.git","clone_url":"https://github.com/lucasb-eyer/DeepFried2.git","svn_url":"https://github.com/lucasb-eyer/DeepFried2","homepage":null,"size":615,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34"},"html":{"href":"https://github.com/lucasb-eyer/DeepFried2/pull/34"},"issue":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/34"},"comments":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/lucasb-eyer/DeepFried2/statuses/34e94805354020b1e800990d0ea56eba7953828e"}}}}