{"action":"created","issue":{"url":"https://api.github.com/repos/citra-emu/citra/issues/986","labels_url":"https://api.github.com/repos/citra-emu/citra/issues/986/labels{/name}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/986/comments","events_url":"https://api.github.com/repos/citra-emu/citra/issues/986/events","html_url":"https://github.com/citra-emu/citra/pull/986","id":97215420,"number":986,"title":"citra-qt: Improve pica command list widget","user":{"login":"Lectem","id":6024225,"avatar_url":"https://avatars.githubusercontent.com/u/6024225?v=3","gravatar_id":"","url":"https://api.github.com/users/Lectem","html_url":"https://github.com/Lectem","followers_url":"https://api.github.com/users/Lectem/followers","following_url":"https://api.github.com/users/Lectem/following{/other_user}","gists_url":"https://api.github.com/users/Lectem/gists{/gist_id}","starred_url":"https://api.github.com/users/Lectem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lectem/subscriptions","organizations_url":"https://api.github.com/users/Lectem/orgs","repos_url":"https://api.github.com/users/Lectem/repos","events_url":"https://api.github.com/users/Lectem/events{/privacy}","received_events_url":"https://api.github.com/users/Lectem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-25T10:21:21Z","updated_at":"2015-07-25T15:45:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/986","html_url":"https://github.com/citra-emu/citra/pull/986","diff_url":"https://github.com/citra-emu/citra/pull/986.diff","patch_url":"https://github.com/citra-emu/citra/pull/986.patch"},"body":"I seperated the data column into \"Register\" and \"New Value\" for the sake of clarity.\r\nI also switched to using a QTableView because it is godamn faster, scrolling with a QTreeView with a lot of elements is extremely slow."},"comment":{"url":"https://api.github.com/repos/citra-emu/citra/issues/comments/124854158","html_url":"https://github.com/citra-emu/citra/pull/986#issuecomment-124854158","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/986","id":124854158,"user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T15:45:47Z","updated_at":"2015-07-25T15:45:47Z","body":"```\r\nIs there any actual point in displaying the raw command id? It can be looked up easily in pica.h and hence only makes for one redundant column. Instead, I suggest displaying the raw command id in the first column iff Pica::Regs::GetCommandName(cmd.cmd_id).empty().\r\n```\r\n\r\nI disagree, searching for the command id is not trivial in Pica.h, you have to look for a point of reference at the end of the file then backtrack until you find what you're looking for. Displaying the command id along with the name is better in my opinion."}}