{"action":"closed","number":4100,"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/4100","id":48944385,"html_url":"https://github.com/elastic/logstash/pull/4100","diff_url":"https://github.com/elastic/logstash/pull/4100.diff","patch_url":"https://github.com/elastic/logstash/pull/4100.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/4100","number":4100,"state":"closed","locked":false,"title":"[WIP] logstash-core and logstash-core-event extraction","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"#### Purpose\r\n\r\nThis is the **WIP groundwork** for the proper extraction and separation of the logstash-core and logstash-core-event gems. This is mainly a source tree reorganization to be able to correctly extract the **logstash-core-event** code to enable drop-in replacement or update. \r\n\r\n#### Expectations\r\n\r\nThis is an early WIP PR to gather initial feedback on the idea. Not everything has been tested and some parts (rakelibs) have been duck taped to work with the new structure.\r\n\r\n####  Changes\r\n\r\n- all current **logstash-core gem** code  in now moved in the `logstash-core/` directory. \r\n- all `Event` related code has been extracted from logstash-core and moved into its own **logstash-core-event gem** into the `logstash-core-event/` directory.\r\n\r\n**ALSO**\r\n- all specs have been reorganized into the **standard** spec directory structure & naming for all `spec/`, `logstash-core/spec` and `logstash-core-event/spec` directories.\r\n- all spec files are in the exact same path as the corresponding source file. No more discrepancy between the `lib/`  and `spec/` dir structures.\r\n- all specs are passing using:\r\n```\r\n$ rake test:install-core\r\n$ bin/rspec spec/ logstash-core/spec/ logstash-core-event/spec/\r\n```\r\n","created_at":"2015-10-27T22:57:38Z","updated_at":"2015-10-30T21:23:56Z","closed_at":"2015-10-30T21:23:56Z","merged_at":null,"merge_commit_sha":"01d49fbc927e25dc2b3c4e966a7a51a362106168","assignee":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/4100/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/4100/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/4100/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/364bcf53d054a9c62b993c41e1ee7db0e05bf79c","head":{"label":"colinsurprenant:feature/logstash-core-event","ref":"feature/logstash-core-event","sha":"364bcf53d054a9c62b993c41e1ee7db0e05bf79c","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"repo":{"id":17155108,"name":"logstash","full_name":"colinsurprenant/logstash","owner":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colinsurprenant/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/colinsurprenant/logstash","forks_url":"https://api.github.com/repos/colinsurprenant/logstash/forks","keys_url":"https://api.github.com/repos/colinsurprenant/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinsurprenant/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinsurprenant/logstash/teams","hooks_url":"https://api.github.com/repos/colinsurprenant/logstash/hooks","issue_events_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/colinsurprenant/logstash/events","assignees_url":"https://api.github.com/repos/colinsurprenant/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/colinsurprenant/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/colinsurprenant/logstash/tags","blobs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinsurprenant/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinsurprenant/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinsurprenant/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/colinsurprenant/logstash/languages","stargazers_url":"https://api.github.com/repos/colinsurprenant/logstash/stargazers","contributors_url":"https://api.github.com/repos/colinsurprenant/logstash/contributors","subscribers_url":"https://api.github.com/repos/colinsurprenant/logstash/subscribers","subscription_url":"https://api.github.com/repos/colinsurprenant/logstash/subscription","commits_url":"https://api.github.com/repos/colinsurprenant/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinsurprenant/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinsurprenant/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/colinsurprenant/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/colinsurprenant/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinsurprenant/logstash/merges","archive_url":"https://api.github.com/repos/colinsurprenant/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinsurprenant/logstash/downloads","issues_url":"https://api.github.com/repos/colinsurprenant/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/colinsurprenant/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/colinsurprenant/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/colinsurprenant/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinsurprenant/logstash/labels{/name}","releases_url":"https://api.github.com/repos/colinsurprenant/logstash/releases{/id}","created_at":"2014-02-24T23:52:15Z","updated_at":"2015-04-13T10:39:50Z","pushed_at":"2015-10-30T21:09:00Z","git_url":"git://github.com/colinsurprenant/logstash.git","ssh_url":"git@github.com:colinsurprenant/logstash.git","clone_url":"https://github.com/colinsurprenant/logstash.git","svn_url":"https://github.com/colinsurprenant/logstash","homepage":"http://logstash.net/","size":74354,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"eb8f6387f328cbf3ff64d4c9860a84dafc035d2e","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-10-30T15:37:20Z","pushed_at":"2015-10-30T21:22:51Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":95061,"stargazers_count":4926,"watchers_count":4926,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1592,"mirror_url":null,"open_issues_count":639,"forks":1592,"open_issues":639,"watchers":4926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4100"},"html":{"href":"https://github.com/elastic/logstash/pull/4100"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/4100"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/4100/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4100/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4100/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/364bcf53d054a9c62b993c41e1ee7db0e05bf79c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":55,"deletions":72,"changed_files":96}}