{"action":"created","comment":{"url":"https://api.github.com/repos/micropython/micropython/pulls/comments/36367235","id":36367235,"diff_hunk":"@@ -321,6 +321,16 @@ $(BUILD)/%_$(BOARD).c $(HEADER_BUILD)/%.h $(HEADER_BUILD)/%_af_const.h $(BUILD)/\n $(BUILD)/pins_$(BOARD).o: $(BUILD)/pins_$(BOARD).c\n \t$(call compile_c)\n \n+GEN_STMCONST_HDR = $(BUILD)/modstm_const.gen.h","path":"stmhal/Makefile","position":13,"original_position":13,"commit_id":"56462ae6c9ab10f75cee2b41446621b47e5182ae","original_commit_id":"56462ae6c9ab10f75cee2b41446621b47e5182ae","user":{"login":"dhylands","id":127500,"avatar_url":"https://avatars.githubusercontent.com/u/127500?v=3","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"body":"> It should go in HEADER_BUILD dir (ie genhdr/) and be called modstm_const.h (without .gen, not needed).\r\n\r\nok - It wasn't a standalone header, so that's why I was leaning to having it out.\r\n\r\nWe should probably move pins_qstr.h into genhdr as well to be consistent (I'll do that as a separate PR)","created_at":"2015-08-05T23:29:49Z","updated_at":"2015-08-05T23:29:49Z","html_url":"https://github.com/micropython/micropython/pull/1407#discussion_r36367235","pull_request_url":"https://api.github.com/repos/micropython/micropython/pulls/1407","_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/36367235"},"html":{"href":"https://github.com/micropython/micropython/pull/1407#discussion_r36367235"},"pull_request":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1407"}}},"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1407","id":41434695,"html_url":"https://github.com/micropython/micropython/pull/1407","diff_url":"https://github.com/micropython/micropython/pull/1407.diff","patch_url":"https://github.com/micropython/micropython/pull/1407.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1407","number":1407,"state":"open","locked":false,"title":"stmhal: Generate modstm constants per build","user":{"login":"dhylands","id":127500,"avatar_url":"https://avatars.githubusercontent.com/u/127500?v=3","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"body":"This causes unnecessary constants to no longer be generated.\r\nSome constants (like UART_BRR) are different between the F4 and F7\r\n\r\nFixes #1400 ","created_at":"2015-08-03T04:47:15Z","updated_at":"2015-08-05T23:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"503e83270eb530327ef86eceb45742986330ca1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/1407/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/1407/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1407/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/56462ae6c9ab10f75cee2b41446621b47e5182ae","head":{"label":"dhylands:gen-modstm-const","ref":"gen-modstm-const","sha":"56462ae6c9ab10f75cee2b41446621b47e5182ae","user":{"login":"dhylands","id":127500,"avatar_url":"https://avatars.githubusercontent.com/u/127500?v=3","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"repo":{"id":15645703,"name":"micropython","full_name":"dhylands/micropython","owner":{"login":"dhylands","id":127500,"avatar_url":"https://avatars.githubusercontent.com/u/127500?v=3","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhylands/micropython","description":"The Micro Python project","fork":true,"url":"https://api.github.com/repos/dhylands/micropython","forks_url":"https://api.github.com/repos/dhylands/micropython/forks","keys_url":"https://api.github.com/repos/dhylands/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhylands/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhylands/micropython/teams","hooks_url":"https://api.github.com/repos/dhylands/micropython/hooks","issue_events_url":"https://api.github.com/repos/dhylands/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/dhylands/micropython/events","assignees_url":"https://api.github.com/repos/dhylands/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/dhylands/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/dhylands/micropython/tags","blobs_url":"https://api.github.com/repos/dhylands/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhylands/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhylands/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhylands/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhylands/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/dhylands/micropython/languages","stargazers_url":"https://api.github.com/repos/dhylands/micropython/stargazers","contributors_url":"https://api.github.com/repos/dhylands/micropython/contributors","subscribers_url":"https://api.github.com/repos/dhylands/micropython/subscribers","subscription_url":"https://api.github.com/repos/dhylands/micropython/subscription","commits_url":"https://api.github.com/repos/dhylands/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhylands/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhylands/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhylands/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhylands/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/dhylands/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhylands/micropython/merges","archive_url":"https://api.github.com/repos/dhylands/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhylands/micropython/downloads","issues_url":"https://api.github.com/repos/dhylands/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/dhylands/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/dhylands/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/dhylands/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhylands/micropython/labels{/name}","releases_url":"https://api.github.com/repos/dhylands/micropython/releases{/id}","created_at":"2014-01-05T04:53:16Z","updated_at":"2014-10-21T23:09:28Z","pushed_at":"2015-08-05T06:36:37Z","git_url":"git://github.com/dhylands/micropython.git","ssh_url":"git@github.com:dhylands/micropython.git","clone_url":"https://github.com/dhylands/micropython.git","svn_url":"https://github.com/dhylands/micropython","homepage":null,"size":22381,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"4434e43fa150eee99cc120e97c26ad6b3fa8a15d","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","created_at":"2013-12-20T11:47:07Z","updated_at":"2015-08-05T23:27:32Z","pushed_at":"2015-08-05T23:05:42Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":"","size":47994,"stargazers_count":2074,"watchers_count":2074,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":149,"forks":390,"open_issues":149,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1407"},"html":{"href":"https://github.com/micropython/micropython/pull/1407"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/1407"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/1407/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1407/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1407/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/56462ae6c9ab10f75cee2b41446621b47e5182ae"}}}}