{"action":"opened","number":11371,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/11371","id":35824627,"html_url":"https://github.com/JuliaLang/julia/pull/11371","diff_url":"https://github.com/JuliaLang/julia/pull/11371.diff","patch_url":"https://github.com/JuliaLang/julia/pull/11371.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/11371","number":11371,"state":"open","locked":false,"title":"Improve perormance of issym and ishermitian for sparse matrices","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"body":"This implements what @toivoh mentioned here https://github.com/JuliaLang/julia/issues/11353#issuecomment-103643448\r\n\r\nMy testing shows that it is about 3 times faster for hermitian matrices than the current one and for non hermitian it usually terminates right away so it gains a lot there. It also uses less memory.\r\n\r\nThe logic in this function is of course more complicated than the current one so it is important that it is tested properly. I prodded it with as many different cases I could come up with and it works for all those but maybe there should be more tests in base?\r\n\r\n","created_at":"2015-05-20T12:06:43Z","updated_at":"2015-05-20T12:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11371/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11371/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/11371/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/ed37aa37c8dae9e1291334e0f8ede6617425fc9f","head":{"label":"KristofferC:kc/herm_sym","ref":"kc/herm_sym","sha":"ed37aa37c8dae9e1291334e0f8ede6617425fc9f","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"repo":{"id":33200454,"name":"julia","full_name":"KristofferC/julia","owner":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KristofferC/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/KristofferC/julia","forks_url":"https://api.github.com/repos/KristofferC/julia/forks","keys_url":"https://api.github.com/repos/KristofferC/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KristofferC/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KristofferC/julia/teams","hooks_url":"https://api.github.com/repos/KristofferC/julia/hooks","issue_events_url":"https://api.github.com/repos/KristofferC/julia/issues/events{/number}","events_url":"https://api.github.com/repos/KristofferC/julia/events","assignees_url":"https://api.github.com/repos/KristofferC/julia/assignees{/user}","branches_url":"https://api.github.com/repos/KristofferC/julia/branches{/branch}","tags_url":"https://api.github.com/repos/KristofferC/julia/tags","blobs_url":"https://api.github.com/repos/KristofferC/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KristofferC/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KristofferC/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/KristofferC/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KristofferC/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/KristofferC/julia/languages","stargazers_url":"https://api.github.com/repos/KristofferC/julia/stargazers","contributors_url":"https://api.github.com/repos/KristofferC/julia/contributors","subscribers_url":"https://api.github.com/repos/KristofferC/julia/subscribers","subscription_url":"https://api.github.com/repos/KristofferC/julia/subscription","commits_url":"https://api.github.com/repos/KristofferC/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/KristofferC/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/KristofferC/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/KristofferC/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/KristofferC/julia/contents/{+path}","compare_url":"https://api.github.com/repos/KristofferC/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KristofferC/julia/merges","archive_url":"https://api.github.com/repos/KristofferC/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KristofferC/julia/downloads","issues_url":"https://api.github.com/repos/KristofferC/julia/issues{/number}","pulls_url":"https://api.github.com/repos/KristofferC/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/KristofferC/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/KristofferC/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KristofferC/julia/labels{/name}","releases_url":"https://api.github.com/repos/KristofferC/julia/releases{/id}","created_at":"2015-03-31T17:47:12Z","updated_at":"2015-04-21T17:09:11Z","pushed_at":"2015-05-20T11:59:42Z","git_url":"git://github.com/KristofferC/julia.git","ssh_url":"git@github.com:KristofferC/julia.git","clone_url":"https://github.com/KristofferC/julia.git","svn_url":"https://github.com/KristofferC/julia","homepage":"http://julialang.org/","size":70894,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"8a1508d7fa5bfb1aea338c5065047d1d6a0743d4","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-05-20T10:35:37Z","pushed_at":"2015-05-20T12:06:43Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":209876,"stargazers_count":5543,"watchers_count":5543,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1161,"mirror_url":null,"open_issues_count":1321,"forks":1161,"open_issues":1321,"watchers":5543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11371"},"html":{"href":"https://github.com/JuliaLang/julia/pull/11371"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11371"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11371/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11371/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11371/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/ed37aa37c8dae9e1291334e0f8ede6617425fc9f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":8,"changed_files":3}}