{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/24252814","id":24252814,"diff_hunk":"@@ -2199,13 +2199,13 @@ void Client::sendChangePassword(const std::wstring &oldpassword,\n }\n \n \n-void Client::sendDamage(u8 damage)\n+void Client::sendDamage(s8 damage)\n {\n \tDSTACK(__FUNCTION_NAME);\n \tstd::ostringstream os(std::ios_base::binary);\n \n \twriteU16(os, TOSERVER_DAMAGE);\n-\twriteU8(os, damage);\n+\twriteS8(os, damage);","path":"src/client.cpp","position":21,"original_position":21,"commit_id":"642174c8211c18ecc3612fa4f1a6536eccaec6fb","original_commit_id":"642174c8211c18ecc3612fa4f1a6536eccaec6fb","user":{"login":"JakubVanek","id":6003171,"avatar_url":"https://avatars.githubusercontent.com/u/6003171?v=3","gravatar_id":"","url":"https://api.github.com/users/JakubVanek","html_url":"https://github.com/JakubVanek","followers_url":"https://api.github.com/users/JakubVanek/followers","following_url":"https://api.github.com/users/JakubVanek/following{/other_user}","gists_url":"https://api.github.com/users/JakubVanek/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubVanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubVanek/subscriptions","organizations_url":"https://api.github.com/users/JakubVanek/orgs","repos_url":"https://api.github.com/users/JakubVanek/repos","events_url":"https://api.github.com/users/JakubVanek/events{/privacy}","received_events_url":"https://api.github.com/users/JakubVanek/received_events","type":"User","site_admin":false},"body":"Range of signed 8bit integer should be -128 to 127, so it's true that it is small range. This integer is for sending any damage to server, so if I'm right if somebody damages you >128 HP, he heals you. Protocol compatibility is probably already broken, so I am going to change it to s16, that's -32,768 to 32,767 damage per attack.","created_at":"2015-02-06T16:41:10Z","updated_at":"2015-02-06T16:41:10Z","html_url":"https://github.com/minetest/minetest/pull/2261#discussion_r24252814","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2261","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/24252814"},"html":{"href":"https://github.com/minetest/minetest/pull/2261#discussion_r24252814"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2261"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2261","id":28725361,"html_url":"https://github.com/minetest/minetest/pull/2261","diff_url":"https://github.com/minetest/minetest/pull/2261.diff","patch_url":"https://github.com/minetest/minetest/pull/2261.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2261","number":2261,"state":"open","locked":false,"title":"damage_per_second negative number implementation","user":{"login":"JakubVanek","id":6003171,"avatar_url":"https://avatars.githubusercontent.com/u/6003171?v=3","gravatar_id":"","url":"https://api.github.com/users/JakubVanek","html_url":"https://github.com/JakubVanek","followers_url":"https://api.github.com/users/JakubVanek/followers","following_url":"https://api.github.com/users/JakubVanek/following{/other_user}","gists_url":"https://api.github.com/users/JakubVanek/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubVanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubVanek/subscriptions","organizations_url":"https://api.github.com/users/JakubVanek/orgs","repos_url":"https://api.github.com/users/JakubVanek/repos","events_url":"https://api.github.com/users/JakubVanek/events{/privacy}","received_events_url":"https://api.github.com/users/JakubVanek/received_events","type":"User","site_admin":false},"body":"Fixes #2248 \r\nIn addition, damage / healing is calculated from the blocks that a) contain the player, b) collide with the player (player walks against them/stands on them)\r\nb) could change with #2224 \r\nI think this breaks server-client protocol cross-version compatibility a bit, but at least in singleplayer it works.","created_at":"2015-02-05T13:48:17Z","updated_at":"2015-02-06T16:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a58ac3451e2a3cede2d383a5a73c4aa774ee6dcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2261/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2261/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2261/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/642174c8211c18ecc3612fa4f1a6536eccaec6fb","head":{"label":"JakubVanek:health1","ref":"health1","sha":"642174c8211c18ecc3612fa4f1a6536eccaec6fb","user":{"login":"JakubVanek","id":6003171,"avatar_url":"https://avatars.githubusercontent.com/u/6003171?v=3","gravatar_id":"","url":"https://api.github.com/users/JakubVanek","html_url":"https://github.com/JakubVanek","followers_url":"https://api.github.com/users/JakubVanek/followers","following_url":"https://api.github.com/users/JakubVanek/following{/other_user}","gists_url":"https://api.github.com/users/JakubVanek/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubVanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubVanek/subscriptions","organizations_url":"https://api.github.com/users/JakubVanek/orgs","repos_url":"https://api.github.com/users/JakubVanek/repos","events_url":"https://api.github.com/users/JakubVanek/events{/privacy}","received_events_url":"https://api.github.com/users/JakubVanek/received_events","type":"User","site_admin":false},"repo":{"id":28823624,"name":"minetest","full_name":"JakubVanek/minetest","owner":{"login":"JakubVanek","id":6003171,"avatar_url":"https://avatars.githubusercontent.com/u/6003171?v=3","gravatar_id":"","url":"https://api.github.com/users/JakubVanek","html_url":"https://github.com/JakubVanek","followers_url":"https://api.github.com/users/JakubVanek/followers","following_url":"https://api.github.com/users/JakubVanek/following{/other_user}","gists_url":"https://api.github.com/users/JakubVanek/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubVanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubVanek/subscriptions","organizations_url":"https://api.github.com/users/JakubVanek/orgs","repos_url":"https://api.github.com/users/JakubVanek/repos","events_url":"https://api.github.com/users/JakubVanek/events{/privacy}","received_events_url":"https://api.github.com/users/JakubVanek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JakubVanek/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/JakubVanek/minetest","forks_url":"https://api.github.com/repos/JakubVanek/minetest/forks","keys_url":"https://api.github.com/repos/JakubVanek/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakubVanek/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakubVanek/minetest/teams","hooks_url":"https://api.github.com/repos/JakubVanek/minetest/hooks","issue_events_url":"https://api.github.com/repos/JakubVanek/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/JakubVanek/minetest/events","assignees_url":"https://api.github.com/repos/JakubVanek/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/JakubVanek/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/JakubVanek/minetest/tags","blobs_url":"https://api.github.com/repos/JakubVanek/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakubVanek/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakubVanek/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakubVanek/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakubVanek/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/JakubVanek/minetest/languages","stargazers_url":"https://api.github.com/repos/JakubVanek/minetest/stargazers","contributors_url":"https://api.github.com/repos/JakubVanek/minetest/contributors","subscribers_url":"https://api.github.com/repos/JakubVanek/minetest/subscribers","subscription_url":"https://api.github.com/repos/JakubVanek/minetest/subscription","commits_url":"https://api.github.com/repos/JakubVanek/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakubVanek/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakubVanek/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakubVanek/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/JakubVanek/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/JakubVanek/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakubVanek/minetest/merges","archive_url":"https://api.github.com/repos/JakubVanek/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakubVanek/minetest/downloads","issues_url":"https://api.github.com/repos/JakubVanek/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/JakubVanek/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/JakubVanek/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/JakubVanek/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakubVanek/minetest/labels{/name}","releases_url":"https://api.github.com/repos/JakubVanek/minetest/releases{/id}","created_at":"2015-01-05T17:35:05Z","updated_at":"2015-01-26T17:54:23Z","pushed_at":"2015-02-05T14:11:21Z","git_url":"git://github.com/JakubVanek/minetest.git","ssh_url":"git@github.com:JakubVanek/minetest.git","clone_url":"https://github.com/JakubVanek/minetest.git","svn_url":"https://github.com/JakubVanek/minetest","homepage":"http://minetest.net/","size":31676,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"9e2a9b55e185b92074b32d3df336920f33b29e5a","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-02-06T13:09:53Z","pushed_at":"2015-02-06T13:09:53Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":78967,"stargazers_count":1352,"watchers_count":1352,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":462,"mirror_url":null,"open_issues_count":501,"forks":462,"open_issues":501,"watchers":1352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2261"},"html":{"href":"https://github.com/minetest/minetest/pull/2261"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2261"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2261/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2261/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2261/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/642174c8211c18ecc3612fa4f1a6536eccaec6fb"}}}}