{"action":"opened","number":77,"pull_request":{"url":"https://api.github.com/repos/bram85/topydo/pulls/77","id":50621026,"html_url":"https://github.com/bram85/topydo/pull/77","diff_url":"https://github.com/bram85/topydo/pull/77.diff","patch_url":"https://github.com/bram85/topydo/pull/77.patch","issue_url":"https://api.github.com/repos/bram85/topydo/issues/77","number":77,"state":"open","locked":false,"title":"Move format parsing logic to ListFormatParser","user":{"login":"mruwek","id":500710,"avatar_url":"https://avatars.githubusercontent.com/u/500710?v=3","gravatar_id":"","url":"https://api.github.com/users/mruwek","html_url":"https://github.com/mruwek","followers_url":"https://api.github.com/users/mruwek/followers","following_url":"https://api.github.com/users/mruwek/following{/other_user}","gists_url":"https://api.github.com/users/mruwek/gists{/gist_id}","starred_url":"https://api.github.com/users/mruwek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruwek/subscriptions","organizations_url":"https://api.github.com/users/mruwek/orgs","repos_url":"https://api.github.com/users/mruwek/repos","events_url":"https://api.github.com/users/mruwek/events{/privacy}","received_events_url":"https://api.github.com/users/mruwek/received_events","type":"User","site_admin":false},"body":"Main advantage of having separate parser for list_format is possibility of initializing it and resolving placeholders only once. Previous implementation did that with each Todo object. `ListFormatParser` also resolves placeholders differently - it doesn't iterate through a dictionary with placeholders and look for a match anymore. Now it finds the right placeholder and simply retrieve it from dictionary.\r\n\r\nI'm also thinking about moving `PrettyPrinterAlignFilter` logic into that class.","created_at":"2015-11-13T09:40:52Z","updated_at":"2015-11-13T09:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bram85/topydo/pulls/77/commits","review_comments_url":"https://api.github.com/repos/bram85/topydo/pulls/77/comments","review_comment_url":"https://api.github.com/repos/bram85/topydo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bram85/topydo/issues/77/comments","statuses_url":"https://api.github.com/repos/bram85/topydo/statuses/7a460a6c2697b60b97ad8c2da817e916e3601151","head":{"label":"mruwek:ls-format-parser","ref":"ls-format-parser","sha":"7a460a6c2697b60b97ad8c2da817e916e3601151","user":{"login":"mruwek","id":500710,"avatar_url":"https://avatars.githubusercontent.com/u/500710?v=3","gravatar_id":"","url":"https://api.github.com/users/mruwek","html_url":"https://github.com/mruwek","followers_url":"https://api.github.com/users/mruwek/followers","following_url":"https://api.github.com/users/mruwek/following{/other_user}","gists_url":"https://api.github.com/users/mruwek/gists{/gist_id}","starred_url":"https://api.github.com/users/mruwek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruwek/subscriptions","organizations_url":"https://api.github.com/users/mruwek/orgs","repos_url":"https://api.github.com/users/mruwek/repos","events_url":"https://api.github.com/users/mruwek/events{/privacy}","received_events_url":"https://api.github.com/users/mruwek/received_events","type":"User","site_admin":false},"repo":{"id":28913515,"name":"topydo","full_name":"mruwek/topydo","owner":{"login":"mruwek","id":500710,"avatar_url":"https://avatars.githubusercontent.com/u/500710?v=3","gravatar_id":"","url":"https://api.github.com/users/mruwek","html_url":"https://github.com/mruwek","followers_url":"https://api.github.com/users/mruwek/followers","following_url":"https://api.github.com/users/mruwek/following{/other_user}","gists_url":"https://api.github.com/users/mruwek/gists{/gist_id}","starred_url":"https://api.github.com/users/mruwek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruwek/subscriptions","organizations_url":"https://api.github.com/users/mruwek/orgs","repos_url":"https://api.github.com/users/mruwek/repos","events_url":"https://api.github.com/users/mruwek/events{/privacy}","received_events_url":"https://api.github.com/users/mruwek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mruwek/topydo","description":"A command-line todo list application based on the todo.txt format.","fork":true,"url":"https://api.github.com/repos/mruwek/topydo","forks_url":"https://api.github.com/repos/mruwek/topydo/forks","keys_url":"https://api.github.com/repos/mruwek/topydo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruwek/topydo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruwek/topydo/teams","hooks_url":"https://api.github.com/repos/mruwek/topydo/hooks","issue_events_url":"https://api.github.com/repos/mruwek/topydo/issues/events{/number}","events_url":"https://api.github.com/repos/mruwek/topydo/events","assignees_url":"https://api.github.com/repos/mruwek/topydo/assignees{/user}","branches_url":"https://api.github.com/repos/mruwek/topydo/branches{/branch}","tags_url":"https://api.github.com/repos/mruwek/topydo/tags","blobs_url":"https://api.github.com/repos/mruwek/topydo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruwek/topydo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruwek/topydo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruwek/topydo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruwek/topydo/statuses/{sha}","languages_url":"https://api.github.com/repos/mruwek/topydo/languages","stargazers_url":"https://api.github.com/repos/mruwek/topydo/stargazers","contributors_url":"https://api.github.com/repos/mruwek/topydo/contributors","subscribers_url":"https://api.github.com/repos/mruwek/topydo/subscribers","subscription_url":"https://api.github.com/repos/mruwek/topydo/subscription","commits_url":"https://api.github.com/repos/mruwek/topydo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruwek/topydo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruwek/topydo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruwek/topydo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mruwek/topydo/contents/{+path}","compare_url":"https://api.github.com/repos/mruwek/topydo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruwek/topydo/merges","archive_url":"https://api.github.com/repos/mruwek/topydo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruwek/topydo/downloads","issues_url":"https://api.github.com/repos/mruwek/topydo/issues{/number}","pulls_url":"https://api.github.com/repos/mruwek/topydo/pulls{/number}","milestones_url":"https://api.github.com/repos/mruwek/topydo/milestones{/number}","notifications_url":"https://api.github.com/repos/mruwek/topydo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruwek/topydo/labels{/name}","releases_url":"https://api.github.com/repos/mruwek/topydo/releases{/id}","created_at":"2015-01-07T12:27:57Z","updated_at":"2015-02-07T11:40:50Z","pushed_at":"2015-11-13T09:30:30Z","git_url":"git://github.com/mruwek/topydo.git","ssh_url":"git@github.com:mruwek/topydo.git","clone_url":"https://github.com/mruwek/topydo.git","svn_url":"https://github.com/mruwek/topydo","homepage":"","size":1516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bram85:ls-format","ref":"ls-format","sha":"8cd2a648aca59b9b5cfb19414c8b77643a68eeed","user":{"login":"bram85","id":63248,"avatar_url":"https://avatars.githubusercontent.com/u/63248?v=3","gravatar_id":"","url":"https://api.github.com/users/bram85","html_url":"https://github.com/bram85","followers_url":"https://api.github.com/users/bram85/followers","following_url":"https://api.github.com/users/bram85/following{/other_user}","gists_url":"https://api.github.com/users/bram85/gists{/gist_id}","starred_url":"https://api.github.com/users/bram85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bram85/subscriptions","organizations_url":"https://api.github.com/users/bram85/orgs","repos_url":"https://api.github.com/users/bram85/repos","events_url":"https://api.github.com/users/bram85/events{/privacy}","received_events_url":"https://api.github.com/users/bram85/received_events","type":"User","site_admin":false},"repo":{"id":25428376,"name":"topydo","full_name":"bram85/topydo","owner":{"login":"bram85","id":63248,"avatar_url":"https://avatars.githubusercontent.com/u/63248?v=3","gravatar_id":"","url":"https://api.github.com/users/bram85","html_url":"https://github.com/bram85","followers_url":"https://api.github.com/users/bram85/followers","following_url":"https://api.github.com/users/bram85/following{/other_user}","gists_url":"https://api.github.com/users/bram85/gists{/gist_id}","starred_url":"https://api.github.com/users/bram85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bram85/subscriptions","organizations_url":"https://api.github.com/users/bram85/orgs","repos_url":"https://api.github.com/users/bram85/repos","events_url":"https://api.github.com/users/bram85/events{/privacy}","received_events_url":"https://api.github.com/users/bram85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bram85/topydo","description":"A command-line todo list application using the todo.txt format.","fork":false,"url":"https://api.github.com/repos/bram85/topydo","forks_url":"https://api.github.com/repos/bram85/topydo/forks","keys_url":"https://api.github.com/repos/bram85/topydo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bram85/topydo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bram85/topydo/teams","hooks_url":"https://api.github.com/repos/bram85/topydo/hooks","issue_events_url":"https://api.github.com/repos/bram85/topydo/issues/events{/number}","events_url":"https://api.github.com/repos/bram85/topydo/events","assignees_url":"https://api.github.com/repos/bram85/topydo/assignees{/user}","branches_url":"https://api.github.com/repos/bram85/topydo/branches{/branch}","tags_url":"https://api.github.com/repos/bram85/topydo/tags","blobs_url":"https://api.github.com/repos/bram85/topydo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bram85/topydo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bram85/topydo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bram85/topydo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bram85/topydo/statuses/{sha}","languages_url":"https://api.github.com/repos/bram85/topydo/languages","stargazers_url":"https://api.github.com/repos/bram85/topydo/stargazers","contributors_url":"https://api.github.com/repos/bram85/topydo/contributors","subscribers_url":"https://api.github.com/repos/bram85/topydo/subscribers","subscription_url":"https://api.github.com/repos/bram85/topydo/subscription","commits_url":"https://api.github.com/repos/bram85/topydo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bram85/topydo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bram85/topydo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bram85/topydo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bram85/topydo/contents/{+path}","compare_url":"https://api.github.com/repos/bram85/topydo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bram85/topydo/merges","archive_url":"https://api.github.com/repos/bram85/topydo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bram85/topydo/downloads","issues_url":"https://api.github.com/repos/bram85/topydo/issues{/number}","pulls_url":"https://api.github.com/repos/bram85/topydo/pulls{/number}","milestones_url":"https://api.github.com/repos/bram85/topydo/milestones{/number}","notifications_url":"https://api.github.com/repos/bram85/topydo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bram85/topydo/labels{/name}","releases_url":"https://api.github.com/repos/bram85/topydo/releases{/id}","created_at":"2014-10-19T13:49:43Z","updated_at":"2015-11-10T13:48:35Z","pushed_at":"2015-11-13T09:09:05Z","git_url":"git://github.com/bram85/topydo.git","ssh_url":"git@github.com:bram85/topydo.git","clone_url":"https://github.com/bram85/topydo.git","svn_url":"https://github.com/bram85/topydo","homepage":"","size":2625,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bram85/topydo/pulls/77"},"html":{"href":"https://github.com/bram85/topydo/pull/77"},"issue":{"href":"https://api.github.com/repos/bram85/topydo/issues/77"},"comments":{"href":"https://api.github.com/repos/bram85/topydo/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/bram85/topydo/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/bram85/topydo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bram85/topydo/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/bram85/topydo/statuses/7a460a6c2697b60b97ad8c2da817e916e3601151"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":187,"deletions":117,"changed_files":4}}