{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/17773","labels_url":"https://api.github.com/repos/owncloud/core/issues/17773/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17773/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/17773/events","html_url":"https://github.com/owncloud/core/pull/17773","id":96253468,"number":17773,"title":"Make OC_SubAdmin non static","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c"},{"url":"https://api.github.com/repos/owncloud/core/labels/security","name":"security","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":630,"closed_issues":170,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-07-21T11:30:41Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"comments":5,"created_at":"2015-07-21T07:56:39Z","updated_at":"2015-07-21T12:40:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17773","html_url":"https://github.com/owncloud/core/pull/17773","diff_url":"https://github.com/owncloud/core/pull/17773.diff","patch_url":"https://github.com/owncloud/core/pull/17773.patch"},"body":"While trying to get the core apps more compliant I can across OC_SubAdmin. Which is not only static in its current form (so no proper testing :( ) but also lacks an OCP interface. So no change in passing the tests in its current form.\r\n\r\nFirst commit moves from a static OC_SubAdmin to OC\\SubAdmin.\r\n\r\nLot of files are modified to still pass the unit tests. But even after that grep still showed a lot of occurences of OC_SubAdmin :( (so we have still to much untested code...)\r\n\r\nTODO:\r\n- [ ] DI\r\n- [ ] OCP Interface\r\n- [ ] Add unit tests\r\n- [ ] Still fire original hooks\r\n- [ ] Move out of servercontainer\r\n\r\nCC: @LukasReschke @DeepDiver1975\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/123292299","html_url":"https://github.com/owncloud/core/pull/17773#issuecomment-123292299","issue_url":"https://api.github.com/repos/owncloud/core/issues/17773","id":123292299,"user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T12:40:04Z","updated_at":"2015-07-21T12:40:04Z","body":"Awww… My most favourite feature :speak_no_evil: "}}