{"action":"created","comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/25562420","id":25562420,"diff_hunk":"@@ -1710,6 +1710,29 @@ static u32 sceMpegGetPcmAu(u32 mpeg, int streamUid, u32 auAddr, u32 attrAddr)\n \t\tWARN_LOG(ME, \"UNIMPL sceMpegGetPcmAu(%08x, %i, %08x, %08x): bad mpeg handle\", mpeg, streamUid, auAddr, attrAddr);\n \t\treturn -1;\n \t}\n+\tauto ringbuffer = PSPPointer<SceMpegRingBuffer>::Create(ctx->mpegRingbufferAddr);\n+\tif (!ringbuffer.IsValid()) {\n+\t\t// Would have crashed before, TODO test behavior\n+\t\tWARN_LOG(ME, \"sceMpegGetPcmAu(%08x, %08x, %08x, %08x): invalid ringbuffer address\", mpeg, streamUid, auAddr, attrAddr);\n+\t\treturn -1;\n+\t}\n+\tif (!Memory::IsValidAddress(streamUid)) {\n+\t\tWARN_LOG(ME, \"sceMpegGetPcmAu(%08x, %08x, %08x, %08x):  didn't get a fake stream\", mpeg, streamUid, auAddr, attrAddr);\n+\t\treturn ERROR_MPEG_INVALID_ADDR;\n+\t}\n+\tSceMpegAu atracAu;\n+\tatracAu.read(auAddr);\n+\tauto streamInfo = ctx->streamMap.find(streamUid);\n+\tif (!streamInfo._Ptr) {","path":"Core/HLE/sceMpeg.cpp","position":17,"original_position":17,"commit_id":"cb664129193064637ee2a2a8a5b85047e3a95883","original_commit_id":"cb664129193064637ee2a2a8a5b85047e3a95883","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"body":"    if (streamInfo == ctx->streamMap.end()) {","created_at":"2015-02-28T23:38:16Z","updated_at":"2015-02-28T23:38:16Z","html_url":"https://github.com/hrydgard/ppsspp/pull/7537#discussion_r25562420","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/25562420"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/7537#discussion_r25562420"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537"}}},"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537","id":30232730,"html_url":"https://github.com/hrydgard/ppsspp/pull/7537","diff_url":"https://github.com/hrydgard/ppsspp/pull/7537.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/7537.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/7537","number":7537,"state":"open","locked":false,"title":"Some work in sceMpegGetPcmAu","user":{"login":"sum2012","id":2177532,"avatar_url":"https://avatars.githubusercontent.com/u/2177532?v=3","gravatar_id":"","url":"https://api.github.com/users/sum2012","html_url":"https://github.com/sum2012","followers_url":"https://api.github.com/users/sum2012/followers","following_url":"https://api.github.com/users/sum2012/following{/other_user}","gists_url":"https://api.github.com/users/sum2012/gists{/gist_id}","starred_url":"https://api.github.com/users/sum2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sum2012/subscriptions","organizations_url":"https://api.github.com/users/sum2012/orgs","repos_url":"https://api.github.com/users/sum2012/repos","events_url":"https://api.github.com/users/sum2012/events{/privacy}","received_events_url":"https://api.github.com/users/sum2012/received_events","type":"User","site_admin":false},"body":"Fix #6546\r\nModify log:https://gist.github.com/sum2012/4546ab881836f95181d1\r\nThis fix \"Unknown GetPointer\" of the game\r\n","created_at":"2015-02-28T22:57:20Z","updated_at":"2015-02-28T23:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"305d44c5c14560461ae9b7ae700ec5532dbb8eaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/7537/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/cb664129193064637ee2a2a8a5b85047e3a95883","head":{"label":"sum2012:mpeg","ref":"mpeg","sha":"cb664129193064637ee2a2a8a5b85047e3a95883","user":{"login":"sum2012","id":2177532,"avatar_url":"https://avatars.githubusercontent.com/u/2177532?v=3","gravatar_id":"","url":"https://api.github.com/users/sum2012","html_url":"https://github.com/sum2012","followers_url":"https://api.github.com/users/sum2012/followers","following_url":"https://api.github.com/users/sum2012/following{/other_user}","gists_url":"https://api.github.com/users/sum2012/gists{/gist_id}","starred_url":"https://api.github.com/users/sum2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sum2012/subscriptions","organizations_url":"https://api.github.com/users/sum2012/orgs","repos_url":"https://api.github.com/users/sum2012/repos","events_url":"https://api.github.com/users/sum2012/events{/privacy}","received_events_url":"https://api.github.com/users/sum2012/received_events","type":"User","site_admin":false},"repo":{"id":21997662,"name":"ppsspp","full_name":"sum2012/ppsspp","owner":{"login":"sum2012","id":2177532,"avatar_url":"https://avatars.githubusercontent.com/u/2177532?v=3","gravatar_id":"","url":"https://api.github.com/users/sum2012","html_url":"https://github.com/sum2012","followers_url":"https://api.github.com/users/sum2012/followers","following_url":"https://api.github.com/users/sum2012/following{/other_user}","gists_url":"https://api.github.com/users/sum2012/gists{/gist_id}","starred_url":"https://api.github.com/users/sum2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sum2012/subscriptions","organizations_url":"https://api.github.com/users/sum2012/orgs","repos_url":"https://api.github.com/users/sum2012/repos","events_url":"https://api.github.com/users/sum2012/events{/privacy}","received_events_url":"https://api.github.com/users/sum2012/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sum2012/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":true,"url":"https://api.github.com/repos/sum2012/ppsspp","forks_url":"https://api.github.com/repos/sum2012/ppsspp/forks","keys_url":"https://api.github.com/repos/sum2012/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sum2012/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sum2012/ppsspp/teams","hooks_url":"https://api.github.com/repos/sum2012/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/sum2012/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/sum2012/ppsspp/events","assignees_url":"https://api.github.com/repos/sum2012/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/sum2012/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/sum2012/ppsspp/tags","blobs_url":"https://api.github.com/repos/sum2012/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sum2012/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sum2012/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/sum2012/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sum2012/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/sum2012/ppsspp/languages","stargazers_url":"https://api.github.com/repos/sum2012/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/sum2012/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/sum2012/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/sum2012/ppsspp/subscription","commits_url":"https://api.github.com/repos/sum2012/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/sum2012/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/sum2012/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/sum2012/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/sum2012/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/sum2012/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sum2012/ppsspp/merges","archive_url":"https://api.github.com/repos/sum2012/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sum2012/ppsspp/downloads","issues_url":"https://api.github.com/repos/sum2012/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/sum2012/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/sum2012/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/sum2012/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sum2012/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/sum2012/ppsspp/releases{/id}","created_at":"2014-07-18T23:48:53Z","updated_at":"2015-02-28T23:37:19Z","pushed_at":"2015-02-28T23:37:19Z","git_url":"git://github.com/sum2012/ppsspp.git","ssh_url":"git@github.com:sum2012/ppsspp.git","clone_url":"https://github.com/sum2012/ppsspp.git","svn_url":"https://github.com/sum2012/ppsspp","homepage":"http://www.ppsspp.org","size":137527,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"7d937127f5ee88b146dcd07db0698c14b346e58a","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","created_at":"2012-11-01T08:41:48Z","updated_at":"2015-02-28T23:28:07Z","pushed_at":"2015-02-28T23:28:07Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":213942,"stargazers_count":1547,"watchers_count":1547,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":720,"mirror_url":null,"open_issues_count":555,"forks":720,"open_issues":555,"watchers":1547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/7537"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/7537"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/7537/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/7537/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/cb664129193064637ee2a2a8a5b85047e3a95883"}}}}