{"action":"opened","number":1238,"pull_request":{"url":"https://api.github.com/repos/fsprojects/Paket/pulls/1238","id":51183554,"html_url":"https://github.com/fsprojects/Paket/pull/1238","diff_url":"https://github.com/fsprojects/Paket/pull/1238.diff","patch_url":"https://github.com/fsprojects/Paket/pull/1238.patch","issue_url":"https://api.github.com/repos/fsprojects/Paket/issues/1238","number":1238,"state":"open","locked":false,"title":"PackageSources: do not print feed password to output #1224","user":{"login":"cdrnet","id":47147,"avatar_url":"https://avatars.githubusercontent.com/u/47147?v=3","gravatar_id":"","url":"https://api.github.com/users/cdrnet","html_url":"https://github.com/cdrnet","followers_url":"https://api.github.com/users/cdrnet/followers","following_url":"https://api.github.com/users/cdrnet/following{/other_user}","gists_url":"https://api.github.com/users/cdrnet/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrnet/subscriptions","organizations_url":"https://api.github.com/users/cdrnet/orgs","repos_url":"https://api.github.com/users/cdrnet/repos","events_url":"https://api.github.com/users/cdrnet/events{/privacy}","received_events_url":"https://api.github.com/users/cdrnet/received_events","type":"User","site_admin":false},"body":"In `NuGetV2.GetVersions` use the same approach as in `GetPackageDetails` to just print the feed url instead of the full record including the password, to avoid leaking the password unnecessarily to the console output.\r\n\r\nIt is correct that the password is lying around (at least encrypted) in paket.config, but it's still awkward seeing your personal password floating by on the console when pair-programming ;)","created_at":"2015-11-19T05:59:29Z","updated_at":"2015-11-19T05:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsprojects/Paket/pulls/1238/commits","review_comments_url":"https://api.github.com/repos/fsprojects/Paket/pulls/1238/comments","review_comment_url":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsprojects/Paket/issues/1238/comments","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/a20d35147584382d9ab43760168f472d46551f0b","head":{"label":"cdrnet:dont-leak-password","ref":"dont-leak-password","sha":"a20d35147584382d9ab43760168f472d46551f0b","user":{"login":"cdrnet","id":47147,"avatar_url":"https://avatars.githubusercontent.com/u/47147?v=3","gravatar_id":"","url":"https://api.github.com/users/cdrnet","html_url":"https://github.com/cdrnet","followers_url":"https://api.github.com/users/cdrnet/followers","following_url":"https://api.github.com/users/cdrnet/following{/other_user}","gists_url":"https://api.github.com/users/cdrnet/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrnet/subscriptions","organizations_url":"https://api.github.com/users/cdrnet/orgs","repos_url":"https://api.github.com/users/cdrnet/repos","events_url":"https://api.github.com/users/cdrnet/events{/privacy}","received_events_url":"https://api.github.com/users/cdrnet/received_events","type":"User","site_admin":false},"repo":{"id":24289666,"name":"Paket","full_name":"cdrnet/Paket","owner":{"login":"cdrnet","id":47147,"avatar_url":"https://avatars.githubusercontent.com/u/47147?v=3","gravatar_id":"","url":"https://api.github.com/users/cdrnet","html_url":"https://github.com/cdrnet","followers_url":"https://api.github.com/users/cdrnet/followers","following_url":"https://api.github.com/users/cdrnet/following{/other_user}","gists_url":"https://api.github.com/users/cdrnet/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrnet/subscriptions","organizations_url":"https://api.github.com/users/cdrnet/orgs","repos_url":"https://api.github.com/users/cdrnet/repos","events_url":"https://api.github.com/users/cdrnet/events{/privacy}","received_events_url":"https://api.github.com/users/cdrnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdrnet/Paket","description":"A package dependency manager for .NET with support for NuGet packages and GitHub files.","fork":true,"url":"https://api.github.com/repos/cdrnet/Paket","forks_url":"https://api.github.com/repos/cdrnet/Paket/forks","keys_url":"https://api.github.com/repos/cdrnet/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdrnet/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdrnet/Paket/teams","hooks_url":"https://api.github.com/repos/cdrnet/Paket/hooks","issue_events_url":"https://api.github.com/repos/cdrnet/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/cdrnet/Paket/events","assignees_url":"https://api.github.com/repos/cdrnet/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/cdrnet/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/cdrnet/Paket/tags","blobs_url":"https://api.github.com/repos/cdrnet/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdrnet/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdrnet/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdrnet/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdrnet/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/cdrnet/Paket/languages","stargazers_url":"https://api.github.com/repos/cdrnet/Paket/stargazers","contributors_url":"https://api.github.com/repos/cdrnet/Paket/contributors","subscribers_url":"https://api.github.com/repos/cdrnet/Paket/subscribers","subscription_url":"https://api.github.com/repos/cdrnet/Paket/subscription","commits_url":"https://api.github.com/repos/cdrnet/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdrnet/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdrnet/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdrnet/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdrnet/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/cdrnet/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdrnet/Paket/merges","archive_url":"https://api.github.com/repos/cdrnet/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdrnet/Paket/downloads","issues_url":"https://api.github.com/repos/cdrnet/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/cdrnet/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/cdrnet/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/cdrnet/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdrnet/Paket/labels{/name}","releases_url":"https://api.github.com/repos/cdrnet/Paket/releases{/id}","created_at":"2014-09-21T11:51:52Z","updated_at":"2015-02-13T07:49:37Z","pushed_at":"2015-11-19T05:55:06Z","git_url":"git://github.com/cdrnet/Paket.git","ssh_url":"git@github.com:cdrnet/Paket.git","clone_url":"https://github.com/cdrnet/Paket.git","svn_url":"https://github.com/cdrnet/Paket","homepage":"http://fsprojects.github.io/Paket/","size":12078,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsprojects:master","ref":"master","sha":"c9f9632be3bd8c263cc0c9b5694402095ac08da0","user":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":22755810,"name":"Paket","full_name":"fsprojects/Paket","owner":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsprojects/Paket","description":"A dependency manager for .NET with support for NuGet packages and GitHub repositories.","fork":false,"url":"https://api.github.com/repos/fsprojects/Paket","forks_url":"https://api.github.com/repos/fsprojects/Paket/forks","keys_url":"https://api.github.com/repos/fsprojects/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsprojects/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsprojects/Paket/teams","hooks_url":"https://api.github.com/repos/fsprojects/Paket/hooks","issue_events_url":"https://api.github.com/repos/fsprojects/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/fsprojects/Paket/events","assignees_url":"https://api.github.com/repos/fsprojects/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/fsprojects/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/fsprojects/Paket/tags","blobs_url":"https://api.github.com/repos/fsprojects/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsprojects/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsprojects/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsprojects/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/fsprojects/Paket/languages","stargazers_url":"https://api.github.com/repos/fsprojects/Paket/stargazers","contributors_url":"https://api.github.com/repos/fsprojects/Paket/contributors","subscribers_url":"https://api.github.com/repos/fsprojects/Paket/subscribers","subscription_url":"https://api.github.com/repos/fsprojects/Paket/subscription","commits_url":"https://api.github.com/repos/fsprojects/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsprojects/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsprojects/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsprojects/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsprojects/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/fsprojects/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsprojects/Paket/merges","archive_url":"https://api.github.com/repos/fsprojects/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsprojects/Paket/downloads","issues_url":"https://api.github.com/repos/fsprojects/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/fsprojects/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/fsprojects/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/fsprojects/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsprojects/Paket/labels{/name}","releases_url":"https://api.github.com/repos/fsprojects/Paket/releases{/id}","created_at":"2014-08-08T11:36:13Z","updated_at":"2015-11-19T00:22:41Z","pushed_at":"2015-11-18T20:45:00Z","git_url":"git://github.com/fsprojects/Paket.git","ssh_url":"git@github.com:fsprojects/Paket.git","clone_url":"https://github.com/fsprojects/Paket.git","svn_url":"https://github.com/fsprojects/Paket","homepage":"http://fsprojects.github.io/Paket/","size":25874,"stargazers_count":417,"watchers_count":417,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":141,"mirror_url":null,"open_issues_count":81,"forks":141,"open_issues":81,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/1238"},"html":{"href":"https://github.com/fsprojects/Paket/pull/1238"},"issue":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/1238"},"comments":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/1238/comments"},"review_comments":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/1238/comments"},"review_comment":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/1238/commits"},"statuses":{"href":"https://api.github.com/repos/fsprojects/Paket/statuses/a20d35147584382d9ab43760168f472d46551f0b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}