{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/46071559","id":46071559,"diff_hunk":"@@ -0,0 +1,98 @@\n+<?php\n+/**\n+ * @author Vincent Petry <pvince81@owncloud.com>\n+ *\n+ * @copyright Copyright (c) 2015, ownCloud, Inc.\n+ * @license AGPL-3.0\n+ *\n+ * This code is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License, version 3,\n+ * as published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License, version 3,\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>\n+ *\n+ */\n+\n+namespace OCA\\DAV\\SystemTag;\n+\n+use Sabre\\DAV\\Exception\\NotFound;\n+\n+use \\OCP\\SystemTag\\ISystemTag;\n+use \\OCP\\SystemTag\\ISystemTagManager;\n+use \\OCP\\SystemTag\\TagNotFoundException;\n+\n+class SystemTagNode implements \\Sabre\\DAV\\INode {\n+\n+\t/**\n+\t * @var ISystemTag\n+\t */\n+\tprotected $tag;\n+\n+\t/**\n+\t * @var ISystemTagManager\n+\t */\n+\tprotected $tagManager;\n+\n+\t/**\n+\t * Sets up the node, expects a full path name\n+\t *\n+\t * @param ISystemTag $tag system tag\n+\t */\n+\tpublic function __construct(ISystemTag $tag, ISystemTagManager $tagManager) {\n+\t\t$this->tag = $tag;\n+\t\t$this->tagManager = $tagManager;\n+\t}\n+\n+\t/**\n+\t *  Returns the id of the tag\n+\t *\n+\t * @return string\n+\t */\n+\tpublic function getName() {\n+\t\treturn $this->tag->getId();\n+\t}\n+\n+\t/**\n+\t * Returns the system tag represented by this node\n+\t *\n+\t * @return ISystemTag system tag\n+\t */\n+\tpublic function getSystemTag() {\n+\t\treturn $this->tag;\n+\t}\n+\n+\t/**\n+\t * Renames the node\n+\t *\n+\t * @param string $name The new name\n+\t *\n+\t * @throws \\Sabre\\DAV\\Exception\\Forbidden\n+\t */\n+\tpublic function setName($name) {\n+\t\tthrow new \\Sabre\\DAV\\Exception\\Forbidden();\n+\t}\n+\n+\t/**\n+\t * Returns null, not supported\n+\t *\n+\t */\n+\tpublic function getLastModified() {\n+\t\treturn null;\n+\t}\n+\n+\tpublic function delete() {\n+\t\ttry {\n+\t\t\t$this->tagManager->deleteTags($this->tag->getId());\n+\t\t} catch (TagNotFoundException $e) {\n+\t\t\t// can happen if concurrent deletion occurred\n+\t\t\tthrow new NotFound('Tag with id ' . $this->tag->getId() . ' not found', 0, $e);","path":"apps/dav/lib/systemtag/systemtagnode.php","position":99,"original_position":94,"commit_id":"5f1c02c5ba4f2731d4e29a0f9b38c9bfb598525b","original_commit_id":"b7244b259d8522ee04acc29dc4645a4d40f12c20","user":{"login":"evert","id":178960,"avatar_url":"https://avatars.githubusercontent.com/u/178960?v=3","gravatar_id":"","url":"https://api.github.com/users/evert","html_url":"https://github.com/evert","followers_url":"https://api.github.com/users/evert/followers","following_url":"https://api.github.com/users/evert/following{/other_user}","gists_url":"https://api.github.com/users/evert/gists{/gist_id}","starred_url":"https://api.github.com/users/evert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evert/subscriptions","organizations_url":"https://api.github.com/users/evert/orgs","repos_url":"https://api.github.com/users/evert/repos","events_url":"https://api.github.com/users/evert/events{/privacy}","received_events_url":"https://api.github.com/users/evert/received_events","type":"User","site_admin":false},"body":"This is a misunderstanding of what idepotent means.\r\n\r\nhttp://evertpot.com/idempotence-in-http/","created_at":"2015-11-27T22:06:28Z","updated_at":"2015-11-27T22:06:28Z","html_url":"https://github.com/owncloud/core/pull/20786#discussion_r46071559","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/20786","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/46071559"},"html":{"href":"https://github.com/owncloud/core/pull/20786#discussion_r46071559"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/20786"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/20786","id":51988244,"html_url":"https://github.com/owncloud/core/pull/20786","diff_url":"https://github.com/owncloud/core/pull/20786.diff","patch_url":"https://github.com/owncloud/core/pull/20786.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/20786","number":20786,"state":"open","locked":false,"title":"[WIP] DAV endpoint for system tags","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"body":"- [ ] REQUIRES: https://github.com/owncloud/core/pull/20650\r\n- [ ] TODO: add endpoint to retrieve all files/folders tagged by a specific tag?\r\n- [ ] TODO: PUT doesn't work, needs discussion\r\n- [ ] TODO: allow MOVE for rename in \"by-name\", only if target name doesn't exist\r\n\r\n@DeepDiver1975 @nickvergessen \r\n\r\n- Currently the URLs look like this:\r\n    - http://root:admin@localhost/owncloud/remote.php/dav/systemtags/$userId/by-id/$tagId\r\n    - http://root:admin@localhost/owncloud/remote.php/dav/systemtags/$userId/by-name/$tagName_$userVisible_$userAssignable\r\n- by-id is used to list tags by id for direct access when the id is known\r\n- by-id cannot be used to PUT because we cannot know the id beforehand, so read-only\r\n- by-name is used mostly to create new tags using a known name compound. For example \"tag1\" with user visible true and user assignable false will have the name \"tag1_1_0\". This is needed to have unique names and also because PUT expects us to know the URL beforehand (no generated ids here)\r\n- DELETE works in both endpoints\r\n\r\nQuestions:\r\n- are these endpoints acceptable ?\r\n- regarding creating new tags:\r\n    - body is empty as it's not a file\r\n    - Sabre reports the exception \"PUT only allowed for files\"\r\n    - it is not clear how to pass additional properties to a PUT call, maybe headers (although, not relevant for this task as we don't have any additional properties)\r\n    - should we use POST instead of PUT ? There is a RFC proposal here for POST http://greenbytes.de/tech/webdav/rfc5995.html\r\n\r\n@evert mind helping with the PUT questions ? Are there any examples how to use non-files as sabre resources ?\r\n","created_at":"2015-11-27T12:04:02Z","updated_at":"2015-11-27T22:06:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efcc5e652e2392c9c229a87f7ae35baa75936ec9","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-current","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":567,"closed_issues":489,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2015-11-27T21:57:47Z","due_on":"2016-02-09T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/20786/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/20786/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/20786/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/5f1c02c5ba4f2731d4e29a0f9b38c9bfb598525b","head":{"label":"owncloud:systemtags-dav","ref":"systemtags-dav","sha":"5f1c02c5ba4f2731d4e29a0f9b38c9bfb598525b","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-11-27T09:26:30Z","pushed_at":"2015-11-27T21:57:49Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":280633,"stargazers_count":3886,"watchers_count":3886,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"open_issues_count":1813,"forks":1242,"open_issues":1813,"watchers":3886,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"df4bd322b20009b50b9cdb8897cf5295732147ae","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-11-27T09:26:30Z","pushed_at":"2015-11-27T21:57:49Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":280633,"stargazers_count":3886,"watchers_count":3886,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"open_issues_count":1813,"forks":1242,"open_issues":1813,"watchers":3886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/20786"},"html":{"href":"https://github.com/owncloud/core/pull/20786"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/20786"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/20786/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/20786/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/20786/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/5f1c02c5ba4f2731d4e29a0f9b38c9bfb598525b"}}}}