{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/41503587","id":41503587,"diff_hunk":"@@ -963,6 +963,11 @@ describe('ngMock', function() {\n       expect(typeof hb.whenHEAD).toBe(\"function\");\n     });\n \n+    it('should provide \"route\" shortcuts for expect and when', function() {\n+        expect(typeof hb.whenRoute).toBe(\"function\");\n+        expect(typeof hb.expectRoute).toBe(\"function\");","path":"test/ngMock/angular-mocksSpec.js","position":6,"original_position":6,"commit_id":"3228deff370ad045b297604504e428c9ef57355f","original_commit_id":"3228deff370ad045b297604504e428c9ef57355f","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"Too much indentation.","created_at":"2015-10-08T11:51:15Z","updated_at":"2015-10-08T11:51:15Z","html_url":"https://github.com/angular/angular.js/pull/12406#discussion_r41503587","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/12406","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/41503587"},"html":{"href":"https://github.com/angular/angular.js/pull/12406#discussion_r41503587"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12406"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/12406","id":40601415,"html_url":"https://github.com/angular/angular.js/pull/12406","diff_url":"https://github.com/angular/angular.js/pull/12406.diff","patch_url":"https://github.com/angular/angular.js/pull/12406.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/12406","number":12406,"state":"open","locked":false,"title":"feat(ngMocks): add expectRoute and whenRoute shortcuts with colon param matching","user":{"login":"dmaloneycalu","id":4370520,"avatar_url":"https://avatars.githubusercontent.com/u/4370520?v=3","gravatar_id":"","url":"https://api.github.com/users/dmaloneycalu","html_url":"https://github.com/dmaloneycalu","followers_url":"https://api.github.com/users/dmaloneycalu/followers","following_url":"https://api.github.com/users/dmaloneycalu/following{/other_user}","gists_url":"https://api.github.com/users/dmaloneycalu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaloneycalu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaloneycalu/subscriptions","organizations_url":"https://api.github.com/users/dmaloneycalu/orgs","repos_url":"https://api.github.com/users/dmaloneycalu/repos","events_url":"https://api.github.com/users/dmaloneycalu/events{/privacy}","received_events_url":"https://api.github.com/users/dmaloneycalu/received_events","type":"User","site_admin":false},"body":"Adds a `whenRoute()` and `expectRoute()` function to `$httpBackend` service to make mocking out responses similar to writing API routes on a server. Also includes colon delimited param matching so that expect and when handlers can match requests in the form of `/user/:id`, identical to the way ngRoute matches urls in an Angular application.\r\n\r\nHere's an [example file](https://gist.github.com/dmaloneycalu/cb258e2f3b987fd687b2) that reflects one of the use cases for the feature (paged API responses).\r\n\r\n","created_at":"2015-07-22T19:21:09Z","updated_at":"2015-10-08T11:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4215a2aa9fb841f41c20c5e9f6cfa96b4d71eec5","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/90","html_url":"https://github.com/angular/angular.js/milestones/1.5.x%20-%20migration-facilitation","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/90/labels","id":1025270,"number":90,"title":"1.5.x - migration-facilitation","description":"","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":32,"state":"open","created_at":"2015-03-17T12:15:49Z","updated_at":"2015-10-06T12:54:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/12406/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/12406/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/12406/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/3228deff370ad045b297604504e428c9ef57355f","head":{"label":"dmaloneycalu:feat-ngMocks-whenRoute-respond-params","ref":"feat-ngMocks-whenRoute-respond-params","sha":"3228deff370ad045b297604504e428c9ef57355f","user":{"login":"dmaloneycalu","id":4370520,"avatar_url":"https://avatars.githubusercontent.com/u/4370520?v=3","gravatar_id":"","url":"https://api.github.com/users/dmaloneycalu","html_url":"https://github.com/dmaloneycalu","followers_url":"https://api.github.com/users/dmaloneycalu/followers","following_url":"https://api.github.com/users/dmaloneycalu/following{/other_user}","gists_url":"https://api.github.com/users/dmaloneycalu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaloneycalu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaloneycalu/subscriptions","organizations_url":"https://api.github.com/users/dmaloneycalu/orgs","repos_url":"https://api.github.com/users/dmaloneycalu/repos","events_url":"https://api.github.com/users/dmaloneycalu/events{/privacy}","received_events_url":"https://api.github.com/users/dmaloneycalu/received_events","type":"User","site_admin":false},"repo":{"id":32352822,"name":"angular.js","full_name":"dmaloneycalu/angular.js","owner":{"login":"dmaloneycalu","id":4370520,"avatar_url":"https://avatars.githubusercontent.com/u/4370520?v=3","gravatar_id":"","url":"https://api.github.com/users/dmaloneycalu","html_url":"https://github.com/dmaloneycalu","followers_url":"https://api.github.com/users/dmaloneycalu/followers","following_url":"https://api.github.com/users/dmaloneycalu/following{/other_user}","gists_url":"https://api.github.com/users/dmaloneycalu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaloneycalu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaloneycalu/subscriptions","organizations_url":"https://api.github.com/users/dmaloneycalu/orgs","repos_url":"https://api.github.com/users/dmaloneycalu/repos","events_url":"https://api.github.com/users/dmaloneycalu/events{/privacy}","received_events_url":"https://api.github.com/users/dmaloneycalu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmaloneycalu/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/dmaloneycalu/angular.js","forks_url":"https://api.github.com/repos/dmaloneycalu/angular.js/forks","keys_url":"https://api.github.com/repos/dmaloneycalu/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmaloneycalu/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmaloneycalu/angular.js/teams","hooks_url":"https://api.github.com/repos/dmaloneycalu/angular.js/hooks","issue_events_url":"https://api.github.com/repos/dmaloneycalu/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/dmaloneycalu/angular.js/events","assignees_url":"https://api.github.com/repos/dmaloneycalu/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/dmaloneycalu/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/dmaloneycalu/angular.js/tags","blobs_url":"https://api.github.com/repos/dmaloneycalu/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmaloneycalu/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmaloneycalu/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmaloneycalu/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmaloneycalu/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dmaloneycalu/angular.js/languages","stargazers_url":"https://api.github.com/repos/dmaloneycalu/angular.js/stargazers","contributors_url":"https://api.github.com/repos/dmaloneycalu/angular.js/contributors","subscribers_url":"https://api.github.com/repos/dmaloneycalu/angular.js/subscribers","subscription_url":"https://api.github.com/repos/dmaloneycalu/angular.js/subscription","commits_url":"https://api.github.com/repos/dmaloneycalu/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmaloneycalu/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmaloneycalu/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmaloneycalu/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmaloneycalu/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/dmaloneycalu/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmaloneycalu/angular.js/merges","archive_url":"https://api.github.com/repos/dmaloneycalu/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmaloneycalu/angular.js/downloads","issues_url":"https://api.github.com/repos/dmaloneycalu/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/dmaloneycalu/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dmaloneycalu/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dmaloneycalu/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmaloneycalu/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/dmaloneycalu/angular.js/releases{/id}","created_at":"2015-03-16T21:03:10Z","updated_at":"2015-03-16T21:03:29Z","pushed_at":"2015-10-07T22:15:37Z","git_url":"git://github.com/dmaloneycalu/angular.js.git","ssh_url":"git@github.com:dmaloneycalu/angular.js.git","clone_url":"https://github.com/dmaloneycalu/angular.js.git","svn_url":"https://github.com/dmaloneycalu/angular.js","homepage":"http://angularjs.org","size":71362,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1c75ea613d2a0d8b29ecf864d4bf870eb7beae25","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2015-10-08T10:51:00Z","pushed_at":"2015-10-08T10:14:15Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":269793,"stargazers_count":43096,"watchers_count":43096,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19427,"mirror_url":null,"open_issues_count":1263,"forks":19427,"open_issues":1263,"watchers":43096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12406"},"html":{"href":"https://github.com/angular/angular.js/pull/12406"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/12406"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/12406/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12406/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12406/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/3228deff370ad045b297604504e428c9ef57355f"}}}}