{"action":"created","comment":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/24322589","id":24322589,"diff_hunk":"@@ -263,13 +325,26 @@ class Socket final : public SocketHandle {\n       : SocketHandle(SocketHandle::NewHandle()) {\n     int just_one = 1;\n     if (disable_nagle_algorithm) {\n-      // LCOV_EXCL_START\n-      if (::setsockopt(socket, IPPROTO_TCP, TCP_NODELAY, &just_one, sizeof(int))) {\n+// LCOV_EXCL_START","path":"net/tcp/impl/posix.h","position":161,"original_position":161,"commit_id":"85b2e924627ed96111c0e4beac35b4cb9f6869c9","original_commit_id":"85b2e924627ed96111c0e4beac35b4cb9f6869c9","user":{"login":"sompylasar","id":498274,"avatar_url":"https://avatars.githubusercontent.com/u/498274?v=3","gravatar_id":"","url":"https://api.github.com/users/sompylasar","html_url":"https://github.com/sompylasar","followers_url":"https://api.github.com/users/sompylasar/followers","following_url":"https://api.github.com/users/sompylasar/following{/other_user}","gists_url":"https://api.github.com/users/sompylasar/gists{/gist_id}","starred_url":"https://api.github.com/users/sompylasar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sompylasar/subscriptions","organizations_url":"https://api.github.com/users/sompylasar/orgs","repos_url":"https://api.github.com/users/sompylasar/repos","events_url":"https://api.github.com/users/sompylasar/events{/privacy}","received_events_url":"https://api.github.com/users/sompylasar/received_events","type":"User","site_admin":false},"body":"`// LCOV_EXCL_START` missing indentation.","created_at":"2015-02-09T11:38:03Z","updated_at":"2015-02-09T11:38:03Z","html_url":"https://github.com/KnowSheet/Bricks/pull/61#discussion_r24322589","pull_request_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/24322589"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/61#discussion_r24322589"},"pull_request":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61","id":28899621,"html_url":"https://github.com/KnowSheet/Bricks/pull/61","diff_url":"https://github.com/KnowSheet/Bricks/pull/61.diff","patch_url":"https://github.com/KnowSheet/Bricks/pull/61.patch","issue_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/61","number":61,"state":"open","locked":false,"title":"Work in progress on Windows port.","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"body":"Hi @deathbaba, CC @sompylasar,\r\n\r\nI got a Visual Studio machine and spent a few hours putting the pieces together. This is a work in progress change, but it looks big enough to sync up.\r\n\r\nBig notes to self:\r\n\r\n1. I need to install MSYS or Cygwin and compile within it as well. So far it's Visual Studio only. Chances are, I need to make smarter use of platform-dependent ```#define```-s to support all archs.\r\n\r\nMinor notes to self:\r\n\r\n1. Pipes are an issue (```::popen()```). Have not reached it yet.\r\n2. Surprisingly, SFINAE is an issue (the implementation of ```cerealize::is_cerealizable<>::value```). Investigation in progress.\r\n3. File system needs a touch as well.\r\n4. Above are the blockers for HTTP tests.\r\n5. Sockets were relatively straightforward to port, and (most) TCP tests pass now.\r\n\r\nThanks,\r\nDima","created_at":"2015-02-09T06:49:39Z","updated_at":"2015-02-09T11:38:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"202b314a9285e62efeed3c6c8667b9ae451c5764","assignee":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61/commits","review_comments_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61/comments","review_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/61/comments","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/85b2e924627ed96111c0e4beac35b4cb9f6869c9","head":{"label":"dkorolev:master","ref":"master","sha":"85b2e924627ed96111c0e4beac35b4cb9f6869c9","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"repo":{"id":27625438,"name":"Bricks","full_name":"dkorolev/Bricks","owner":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkorolev/Bricks","description":"Our own core pieces to reuse.","fork":true,"url":"https://api.github.com/repos/dkorolev/Bricks","forks_url":"https://api.github.com/repos/dkorolev/Bricks/forks","keys_url":"https://api.github.com/repos/dkorolev/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkorolev/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkorolev/Bricks/teams","hooks_url":"https://api.github.com/repos/dkorolev/Bricks/hooks","issue_events_url":"https://api.github.com/repos/dkorolev/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/dkorolev/Bricks/events","assignees_url":"https://api.github.com/repos/dkorolev/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/dkorolev/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/dkorolev/Bricks/tags","blobs_url":"https://api.github.com/repos/dkorolev/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkorolev/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkorolev/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkorolev/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkorolev/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/dkorolev/Bricks/languages","stargazers_url":"https://api.github.com/repos/dkorolev/Bricks/stargazers","contributors_url":"https://api.github.com/repos/dkorolev/Bricks/contributors","subscribers_url":"https://api.github.com/repos/dkorolev/Bricks/subscribers","subscription_url":"https://api.github.com/repos/dkorolev/Bricks/subscription","commits_url":"https://api.github.com/repos/dkorolev/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkorolev/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkorolev/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkorolev/Bricks/issues/comments/{number}","contents_url":"https://api.github.com/repos/dkorolev/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/dkorolev/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkorolev/Bricks/merges","archive_url":"https://api.github.com/repos/dkorolev/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkorolev/Bricks/downloads","issues_url":"https://api.github.com/repos/dkorolev/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/dkorolev/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/dkorolev/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/dkorolev/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkorolev/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/dkorolev/Bricks/releases{/id}","created_at":"2014-12-06T06:52:51Z","updated_at":"2015-02-09T06:42:49Z","pushed_at":"2015-02-09T06:42:48Z","git_url":"git://github.com/dkorolev/Bricks.git","ssh_url":"git@github.com:dkorolev/Bricks.git","clone_url":"https://github.com/dkorolev/Bricks.git","svn_url":"https://github.com/dkorolev/Bricks","homepage":null,"size":3408,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KnowSheet:master","ref":"master","sha":"fe60897a0659658612966675f770a0d4d177171c","user":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"repo":{"id":27625425,"name":"Bricks","full_name":"KnowSheet/Bricks","owner":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnowSheet/Bricks","description":"Our own core pieces to reuse.","fork":false,"url":"https://api.github.com/repos/KnowSheet/Bricks","forks_url":"https://api.github.com/repos/KnowSheet/Bricks/forks","keys_url":"https://api.github.com/repos/KnowSheet/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnowSheet/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnowSheet/Bricks/teams","hooks_url":"https://api.github.com/repos/KnowSheet/Bricks/hooks","issue_events_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/KnowSheet/Bricks/events","assignees_url":"https://api.github.com/repos/KnowSheet/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/KnowSheet/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/KnowSheet/Bricks/tags","blobs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnowSheet/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnowSheet/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/KnowSheet/Bricks/languages","stargazers_url":"https://api.github.com/repos/KnowSheet/Bricks/stargazers","contributors_url":"https://api.github.com/repos/KnowSheet/Bricks/contributors","subscribers_url":"https://api.github.com/repos/KnowSheet/Bricks/subscribers","subscription_url":"https://api.github.com/repos/KnowSheet/Bricks/subscription","commits_url":"https://api.github.com/repos/KnowSheet/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnowSheet/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/comments/{number}","contents_url":"https://api.github.com/repos/KnowSheet/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/KnowSheet/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnowSheet/Bricks/merges","archive_url":"https://api.github.com/repos/KnowSheet/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnowSheet/Bricks/downloads","issues_url":"https://api.github.com/repos/KnowSheet/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/KnowSheet/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/KnowSheet/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnowSheet/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/KnowSheet/Bricks/releases{/id}","created_at":"2014-12-06T06:52:23Z","updated_at":"2015-02-08T21:11:39Z","pushed_at":"2015-02-08T21:11:39Z","git_url":"git://github.com/KnowSheet/Bricks.git","ssh_url":"git@github.com:KnowSheet/Bricks.git","clone_url":"https://github.com/KnowSheet/Bricks.git","svn_url":"https://github.com/KnowSheet/Bricks","homepage":null,"size":2886,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/61"},"issue":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/61"},"comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/KnowSheet/Bricks/statuses/85b2e924627ed96111c0e4beac35b4cb9f6869c9"}}}}