{"action":"created","comment":{"url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/comments/42581935","id":42581935,"diff_hunk":"@@ -210,4 +236,8 @@ public ClusterNode getThisNode() {\n   public ClusterStateTracker getStateTracker() {\n     return stateTracker;\n   }\n+\n+  public void stopHeartbeats() {\n+    this.heartbeats.stop();\n+  }","path":"bundle/src/main/java/com/meltmedia/dropwizard/etcd/cluster/ClusterService.java","position":123,"original_position":123,"commit_id":"30c9baf6427b29b95b5417b810f95c0bcb99d828","original_commit_id":"30c9baf6427b29b95b5417b810f95c0bcb99d828","user":{"login":"ctrimble","id":614753,"avatar_url":"https://avatars.githubusercontent.com/u/614753?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrimble","html_url":"https://github.com/ctrimble","followers_url":"https://api.github.com/users/ctrimble/followers","following_url":"https://api.github.com/users/ctrimble/following{/other_user}","gists_url":"https://api.github.com/users/ctrimble/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrimble/subscriptions","organizations_url":"https://api.github.com/users/ctrimble/orgs","repos_url":"https://api.github.com/users/ctrimble/repos","events_url":"https://api.github.com/users/ctrimble/events{/privacy}","received_events_url":"https://api.github.com/users/ctrimble/received_events","type":"User","site_admin":false},"body":"I think this method is leftovers from an experiment.  See if it can be removed.","created_at":"2015-10-21T04:17:07Z","updated_at":"2015-10-21T04:17:07Z","html_url":"https://github.com/meltmedia/dropwizard-etcd/pull/6#discussion_r42581935","pull_request_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/comments/42581935"},"html":{"href":"https://github.com/meltmedia/dropwizard-etcd/pull/6#discussion_r42581935"},"pull_request":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6","id":48285355,"html_url":"https://github.com/meltmedia/dropwizard-etcd/pull/6","diff_url":"https://github.com/meltmedia/dropwizard-etcd/pull/6.diff","patch_url":"https://github.com/meltmedia/dropwizard-etcd/pull/6.patch","issue_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/6","number":6,"state":"open","locked":false,"title":"Feature assignment index tracking","user":{"login":"ctrimble","id":614753,"avatar_url":"https://avatars.githubusercontent.com/u/614753?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrimble","html_url":"https://github.com/ctrimble","followers_url":"https://api.github.com/users/ctrimble/followers","following_url":"https://api.github.com/users/ctrimble/following{/other_user}","gists_url":"https://api.github.com/users/ctrimble/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrimble/subscriptions","organizations_url":"https://api.github.com/users/ctrimble/orgs","repos_url":"https://api.github.com/users/ctrimble/repos","events_url":"https://api.github.com/users/ctrimble/events{/privacy}","received_events_url":"https://api.github.com/users/ctrimble/received_events","type":"User","site_admin":false},"body":"Not waiting for etcd state updates after a decision causes wild state changes while nodes enter or exit the cluster.  This change forces the assignment service to wait for changes to be reflected in etcd before more decisions can be made.  It also adds a new document in etcd for each running processor.  This allows the cluster to detect processors that are shutting down and smoothly reassign their processes.\r\n\r\nThis change adds a new layer of directories when creating processors.  Process documents are no longer stored directly under the process directory, instead a `precesses` subdirectory holds those documents and a `processors` directory holds the documents representing each active processor in the cluster.","created_at":"2015-10-21T03:47:39Z","updated_at":"2015-10-21T04:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35798915bee51fdb0d194121782b5ffa4360e41b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6/commits","review_comments_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6/comments","review_comment_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/6/comments","statuses_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/statuses/30c9baf6427b29b95b5417b810f95c0bcb99d828","head":{"label":"meltmedia:feature_assignment-index-tracking","ref":"feature_assignment-index-tracking","sha":"30c9baf6427b29b95b5417b810f95c0bcb99d828","user":{"login":"meltmedia","id":613769,"avatar_url":"https://avatars.githubusercontent.com/u/613769?v=3","gravatar_id":"","url":"https://api.github.com/users/meltmedia","html_url":"https://github.com/meltmedia","followers_url":"https://api.github.com/users/meltmedia/followers","following_url":"https://api.github.com/users/meltmedia/following{/other_user}","gists_url":"https://api.github.com/users/meltmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/meltmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltmedia/subscriptions","organizations_url":"https://api.github.com/users/meltmedia/orgs","repos_url":"https://api.github.com/users/meltmedia/repos","events_url":"https://api.github.com/users/meltmedia/events{/privacy}","received_events_url":"https://api.github.com/users/meltmedia/received_events","type":"Organization","site_admin":false},"repo":{"id":37560108,"name":"dropwizard-etcd","full_name":"meltmedia/dropwizard-etcd","owner":{"login":"meltmedia","id":613769,"avatar_url":"https://avatars.githubusercontent.com/u/613769?v=3","gravatar_id":"","url":"https://api.github.com/users/meltmedia","html_url":"https://github.com/meltmedia","followers_url":"https://api.github.com/users/meltmedia/followers","following_url":"https://api.github.com/users/meltmedia/following{/other_user}","gists_url":"https://api.github.com/users/meltmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/meltmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltmedia/subscriptions","organizations_url":"https://api.github.com/users/meltmedia/orgs","repos_url":"https://api.github.com/users/meltmedia/repos","events_url":"https://api.github.com/users/meltmedia/events{/privacy}","received_events_url":"https://api.github.com/users/meltmedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meltmedia/dropwizard-etcd","description":"A Dropwizard Bundle for Etcd","fork":false,"url":"https://api.github.com/repos/meltmedia/dropwizard-etcd","forks_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/forks","keys_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/teams","hooks_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/hooks","issue_events_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/events","assignees_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/tags","blobs_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/languages","stargazers_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/stargazers","contributors_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/contributors","subscribers_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/subscribers","subscription_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/subscription","commits_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/merges","archive_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/downloads","issues_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/labels{/name}","releases_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/releases{/id}","created_at":"2015-06-16T22:49:24Z","updated_at":"2015-07-12T17:58:12Z","pushed_at":"2015-10-21T03:47:39Z","git_url":"git://github.com/meltmedia/dropwizard-etcd.git","ssh_url":"git@github.com:meltmedia/dropwizard-etcd.git","clone_url":"https://github.com/meltmedia/dropwizard-etcd.git","svn_url":"https://github.com/meltmedia/dropwizard-etcd","homepage":null,"size":464,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"develop"}},"base":{"label":"meltmedia:develop","ref":"develop","sha":"4251da9ea0e0668611bd670ea9103ef199bfd563","user":{"login":"meltmedia","id":613769,"avatar_url":"https://avatars.githubusercontent.com/u/613769?v=3","gravatar_id":"","url":"https://api.github.com/users/meltmedia","html_url":"https://github.com/meltmedia","followers_url":"https://api.github.com/users/meltmedia/followers","following_url":"https://api.github.com/users/meltmedia/following{/other_user}","gists_url":"https://api.github.com/users/meltmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/meltmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltmedia/subscriptions","organizations_url":"https://api.github.com/users/meltmedia/orgs","repos_url":"https://api.github.com/users/meltmedia/repos","events_url":"https://api.github.com/users/meltmedia/events{/privacy}","received_events_url":"https://api.github.com/users/meltmedia/received_events","type":"Organization","site_admin":false},"repo":{"id":37560108,"name":"dropwizard-etcd","full_name":"meltmedia/dropwizard-etcd","owner":{"login":"meltmedia","id":613769,"avatar_url":"https://avatars.githubusercontent.com/u/613769?v=3","gravatar_id":"","url":"https://api.github.com/users/meltmedia","html_url":"https://github.com/meltmedia","followers_url":"https://api.github.com/users/meltmedia/followers","following_url":"https://api.github.com/users/meltmedia/following{/other_user}","gists_url":"https://api.github.com/users/meltmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/meltmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltmedia/subscriptions","organizations_url":"https://api.github.com/users/meltmedia/orgs","repos_url":"https://api.github.com/users/meltmedia/repos","events_url":"https://api.github.com/users/meltmedia/events{/privacy}","received_events_url":"https://api.github.com/users/meltmedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meltmedia/dropwizard-etcd","description":"A Dropwizard Bundle for Etcd","fork":false,"url":"https://api.github.com/repos/meltmedia/dropwizard-etcd","forks_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/forks","keys_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/teams","hooks_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/hooks","issue_events_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/events","assignees_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/tags","blobs_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/languages","stargazers_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/stargazers","contributors_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/contributors","subscribers_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/subscribers","subscription_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/subscription","commits_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/merges","archive_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/downloads","issues_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/labels{/name}","releases_url":"https://api.github.com/repos/meltmedia/dropwizard-etcd/releases{/id}","created_at":"2015-06-16T22:49:24Z","updated_at":"2015-07-12T17:58:12Z","pushed_at":"2015-10-21T03:47:39Z","git_url":"git://github.com/meltmedia/dropwizard-etcd.git","ssh_url":"git@github.com:meltmedia/dropwizard-etcd.git","clone_url":"https://github.com/meltmedia/dropwizard-etcd.git","svn_url":"https://github.com/meltmedia/dropwizard-etcd","homepage":null,"size":464,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6"},"html":{"href":"https://github.com/meltmedia/dropwizard-etcd/pull/6"},"issue":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/6"},"comments":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/meltmedia/dropwizard-etcd/statuses/30c9baf6427b29b95b5417b810f95c0bcb99d828"}}}}