{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/28121367","id":28121367,"diff_hunk":"@@ -481,7 +481,7 @@ int main(int argc, char **argv)\n \n \thints->ep_attr->type = FI_EP_MSG;\n \thints->caps = FI_MSG;\n-\thints->mode = FI_LOCAL_MR | FI_PROV_MR_ATTR;\n+\thints->mode = FI_LOCAL_MR | FI_PROV_MR_ATTR | FI_RX_CQ_DATA;","path":"simple/cq_data.c","position":14,"original_position":14,"commit_id":"b60215da6e86805b11eef64471e89c9003a853d0","original_commit_id":"b60215da6e86805b11eef64471e89c9003a853d0","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Support for CQ data should be specified using the domain attributes.  The code already does this correctly.  FI_RX_CQ_DATA is not a defined mode or cap.","created_at":"2015-04-10T03:59:54Z","updated_at":"2015-04-10T03:59:54Z","html_url":"https://github.com/ofiwg/fabtests/pull/224#discussion_r28121367","pull_request_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/28121367"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/224#discussion_r28121367"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/224","id":32992497,"html_url":"https://github.com/ofiwg/fabtests/pull/224","diff_url":"https://github.com/ofiwg/fabtests/pull/224.diff","patch_url":"https://github.com/ofiwg/fabtests/pull/224.patch","issue_url":"https://api.github.com/repos/ofiwg/fabtests/issues/224","number":224,"state":"open","locked":false,"title":"simple/cq_data: pass correct modes and use FD wait obj","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"simple/cq_data: Pass correct modes in hints and use FD wait obj for CQ (for using sread).\r\nother fixes: fix typo and use FT_ERR","created_at":"2015-04-09T20:23:08Z","updated_at":"2015-04-10T03:59:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ba3f7315db7ed9d9fa4f781b2d48a03c06f86d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/224/commits","review_comments_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/224/comments","review_comment_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/issues/224/comments","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/b60215da6e86805b11eef64471e89c9003a853d0","head":{"label":"a-ilango:dev","ref":"dev","sha":"b60215da6e86805b11eef64471e89c9003a853d0","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"repo":{"id":23321504,"name":"fabtests","full_name":"a-ilango/fabtests","owner":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-ilango/fabtests","description":"","fork":true,"url":"https://api.github.com/repos/a-ilango/fabtests","forks_url":"https://api.github.com/repos/a-ilango/fabtests/forks","keys_url":"https://api.github.com/repos/a-ilango/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-ilango/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-ilango/fabtests/teams","hooks_url":"https://api.github.com/repos/a-ilango/fabtests/hooks","issue_events_url":"https://api.github.com/repos/a-ilango/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/a-ilango/fabtests/events","assignees_url":"https://api.github.com/repos/a-ilango/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/a-ilango/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/a-ilango/fabtests/tags","blobs_url":"https://api.github.com/repos/a-ilango/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-ilango/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-ilango/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-ilango/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-ilango/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/a-ilango/fabtests/languages","stargazers_url":"https://api.github.com/repos/a-ilango/fabtests/stargazers","contributors_url":"https://api.github.com/repos/a-ilango/fabtests/contributors","subscribers_url":"https://api.github.com/repos/a-ilango/fabtests/subscribers","subscription_url":"https://api.github.com/repos/a-ilango/fabtests/subscription","commits_url":"https://api.github.com/repos/a-ilango/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-ilango/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-ilango/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-ilango/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-ilango/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/a-ilango/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-ilango/fabtests/merges","archive_url":"https://api.github.com/repos/a-ilango/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-ilango/fabtests/downloads","issues_url":"https://api.github.com/repos/a-ilango/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/a-ilango/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/a-ilango/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/a-ilango/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-ilango/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/a-ilango/fabtests/releases{/id}","created_at":"2014-08-25T16:58:44Z","updated_at":"2015-01-29T02:06:26Z","pushed_at":"2015-04-09T20:33:19Z","git_url":"git://github.com/a-ilango/fabtests.git","ssh_url":"git@github.com:a-ilango/fabtests.git","clone_url":"https://github.com/a-ilango/fabtests.git","svn_url":"https://github.com/a-ilango/fabtests","homepage":null,"size":1317,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"edecf9e758db8bae5aafca739d708b1f9d0b6f08","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996869,"name":"fabtests","full_name":"ofiwg/fabtests","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/fabtests","description":"","fork":false,"url":"https://api.github.com/repos/ofiwg/fabtests","forks_url":"https://api.github.com/repos/ofiwg/fabtests/forks","keys_url":"https://api.github.com/repos/ofiwg/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/fabtests/teams","hooks_url":"https://api.github.com/repos/ofiwg/fabtests/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/fabtests/events","assignees_url":"https://api.github.com/repos/ofiwg/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/fabtests/tags","blobs_url":"https://api.github.com/repos/ofiwg/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/fabtests/languages","stargazers_url":"https://api.github.com/repos/ofiwg/fabtests/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/fabtests/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/fabtests/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/fabtests/subscription","commits_url":"https://api.github.com/repos/ofiwg/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/fabtests/merges","archive_url":"https://api.github.com/repos/ofiwg/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/fabtests/downloads","issues_url":"https://api.github.com/repos/ofiwg/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/fabtests/releases{/id}","created_at":"2014-08-15T17:13:04Z","updated_at":"2015-04-08T23:34:03Z","pushed_at":"2015-04-10T03:57:48Z","git_url":"git://github.com/ofiwg/fabtests.git","ssh_url":"git@github.com:ofiwg/fabtests.git","clone_url":"https://github.com/ofiwg/fabtests.git","svn_url":"https://github.com/ofiwg/fabtests","homepage":null,"size":2781,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":16,"forks":24,"open_issues":16,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/224"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/224"},"issue":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/224"},"comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/fabtests/statuses/b60215da6e86805b11eef64471e89c9003a853d0"}}}}