{"action":"created","comment":{"url":"https://api.github.com/repos/karan/joe/pulls/comments/23363275","id":23363275,"diff_hunk":"@@ -88,25 +87,26 @@ def _fetch_gitignore(raw_name, directory=''):\n     '''\n     output = '\\n#####=== %s ===#####\\n' % raw_name\n     if directory:\n-        filepath = os.path.join(DATA_DIR, '%s' % directory + '/' + raw_name + \\\n-                                                 '.gitignore')\n+        filepath = os.path.join(DATA_DIR, '%s/%s.gitignore' %\n+                                (directory, raw_name))\n     else:\n         filepath = os.path.join(DATA_DIR, raw_name + '.gitignore')\n         output += '\\n'\n     try:\n-        with open(filepath) as f:\n-            output += f.read()\n+        with open(filepath) as gitignore:","path":"joe/joe.py","position":82,"original_position":82,"commit_id":"31fdbe7eb236a846c80c1bcfa0bc5703aea4ef96","original_commit_id":"31fdbe7eb236a846c80c1bcfa0bc5703aea4ef96","user":{"login":"lukedmor","id":859306,"avatar_url":"https://avatars.githubusercontent.com/u/859306?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedmor","html_url":"https://github.com/lukedmor","followers_url":"https://api.github.com/users/lukedmor/followers","following_url":"https://api.github.com/users/lukedmor/following{/other_user}","gists_url":"https://api.github.com/users/lukedmor/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedmor/subscriptions","organizations_url":"https://api.github.com/users/lukedmor/orgs","repos_url":"https://api.github.com/users/lukedmor/repos","events_url":"https://api.github.com/users/lukedmor/events{/privacy}","received_events_url":"https://api.github.com/users/lukedmor/received_events","type":"User","site_admin":false},"body":"Pylint is a common standard for a reason. Variables shorter than three characters are generally a bad idea, with the exception of tiny iterators (`for i in foo:` but even then only in certain obvious cases). It's generally better to keep to a styling standard for an open source project rather than every coder to themselves. **Descriptive variables are better than undescriptive variables** (*as long as they aren't as long as many java variables*)","created_at":"2015-01-22T09:22:33Z","updated_at":"2015-01-22T09:22:33Z","html_url":"https://github.com/karan/joe/pull/23#discussion_r23363275","pull_request_url":"https://api.github.com/repos/karan/joe/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/karan/joe/pulls/comments/23363275"},"html":{"href":"https://github.com/karan/joe/pull/23#discussion_r23363275"},"pull_request":{"href":"https://api.github.com/repos/karan/joe/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/karan/joe/pulls/23","id":27730166,"html_url":"https://github.com/karan/joe/pull/23","diff_url":"https://github.com/karan/joe/pull/23.diff","patch_url":"https://github.com/karan/joe/pull/23.patch","issue_url":"https://api.github.com/repos/karan/joe/issues/23","number":23,"state":"open","locked":false,"title":"Styled for PEP8 and Pylint","user":{"login":"lukedmor","id":859306,"avatar_url":"https://avatars.githubusercontent.com/u/859306?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedmor","html_url":"https://github.com/lukedmor","followers_url":"https://api.github.com/users/lukedmor/followers","following_url":"https://api.github.com/users/lukedmor/following{/other_user}","gists_url":"https://api.github.com/users/lukedmor/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedmor/subscriptions","organizations_url":"https://api.github.com/users/lukedmor/orgs","repos_url":"https://api.github.com/users/lukedmor/repos","events_url":"https://api.github.com/users/lukedmor/events{/privacy}","received_events_url":"https://api.github.com/users/lukedmor/received_events","type":"User","site_admin":false},"body":"PEP8:\r\n\r\n    $ pep8 joe/joe.py\r\n    joe/joe.py:36:1: E302 expected 2 blank lines, found 0\r\n    joe/joe.py:45:43: E502 the backslash is redundant between brackets\r\n    joe/joe.py:46:17: E127 continuation line over-indented for visual indent\r\n    joe/joe.py:91:79: E502 the backslash is redundant between brackets\r\n    joe/joe.py:92:50: E127 continuation line over-indented for visual indent\r\n\r\nPylint:\r\n\r\n    $ pylint joe/joe.py\r\n    ************* Module joe.joe\r\n    C:107, 0: Unnecessary parens after 'if' keyword (superfluous-parens)\r\n    C:109, 0: Unnecessary parens after 'elif' keyword (superfluous-parens)\r\n    W:  1, 0: Anomalous backslash in string: '\\ '. String constant might be\r\n    missing an r prefix. (anomalous-backslash-in-string)\r\n    W:  1, 0: Anomalous backslash in string: '\\_'. String constant might be\r\n    missing an r prefix. (anomalous-backslash-in-string)\r\n    W:  1, 0: Anomalous backslash in string: '\\_'. String constant might be\r\n    missing an r prefix. (anomalous-backslash-in-string)\r\n    W:  1, 0: Anomalous backslash in string: '\\_'. String constant might be\r\n    missing an r prefix. (anomalous-backslash-in-string)\r\n    W: 46,20: Redefining name 'f' from outer scope (line 54)\r\n    (redefined-outer-name)\r\n    C: 43, 4: Invalid variable name \"l\" (invalid-name)\r\n    C: 44,14: Invalid variable name \"subFolders\" (invalid-name)\r\n    C: 45, 8: Invalid variable name \"l\" (invalid-name)\r\n    W: 44,14: Unused variable 'subFolders' (unused-variable)\r\n    W: 44, 8: Unused variable 'root' (unused-variable)\r\n    W: 64, 4: Redefining built-in 'exit' (redefined-builtin)\r\n    W: 64, 4: Unused variable 'exit' (unused-variable)\r\n    W: 97,31: Redefining name 'f' from outer scope (line 54)\r\n    (redefined-outer-name)\r\n    C: 97,31: Invalid variable name \"f\" (invalid-name)\r\n    C:104, 0: Missing function docstring (missing-docstring)\r\n    W: 27, 0: Unused import sys (unused-import)","created_at":"2015-01-21T02:10:18Z","updated_at":"2015-01-22T09:22:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdce1fb77fc48ceccdc57a841b2bc08f825a5d79","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/karan/joe/pulls/23/commits","review_comments_url":"https://api.github.com/repos/karan/joe/pulls/23/comments","review_comment_url":"https://api.github.com/repos/karan/joe/pulls/comments/{number}","comments_url":"https://api.github.com/repos/karan/joe/issues/23/comments","statuses_url":"https://api.github.com/repos/karan/joe/statuses/31fdbe7eb236a846c80c1bcfa0bc5703aea4ef96","head":{"label":"lukedmor:lukedmor/pylint-pep8","ref":"lukedmor/pylint-pep8","sha":"31fdbe7eb236a846c80c1bcfa0bc5703aea4ef96","user":{"login":"lukedmor","id":859306,"avatar_url":"https://avatars.githubusercontent.com/u/859306?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedmor","html_url":"https://github.com/lukedmor","followers_url":"https://api.github.com/users/lukedmor/followers","following_url":"https://api.github.com/users/lukedmor/following{/other_user}","gists_url":"https://api.github.com/users/lukedmor/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedmor/subscriptions","organizations_url":"https://api.github.com/users/lukedmor/orgs","repos_url":"https://api.github.com/users/lukedmor/repos","events_url":"https://api.github.com/users/lukedmor/events{/privacy}","received_events_url":"https://api.github.com/users/lukedmor/received_events","type":"User","site_admin":false},"repo":{"id":29562518,"name":"joe","full_name":"lukedmor/joe","owner":{"login":"lukedmor","id":859306,"avatar_url":"https://avatars.githubusercontent.com/u/859306?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedmor","html_url":"https://github.com/lukedmor","followers_url":"https://api.github.com/users/lukedmor/followers","following_url":"https://api.github.com/users/lukedmor/following{/other_user}","gists_url":"https://api.github.com/users/lukedmor/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedmor/subscriptions","organizations_url":"https://api.github.com/users/lukedmor/orgs","repos_url":"https://api.github.com/users/lukedmor/repos","events_url":"https://api.github.com/users/lukedmor/events{/privacy}","received_events_url":"https://api.github.com/users/lukedmor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukedmor/joe","description":":running: A .gitignore magician in your command line","fork":true,"url":"https://api.github.com/repos/lukedmor/joe","forks_url":"https://api.github.com/repos/lukedmor/joe/forks","keys_url":"https://api.github.com/repos/lukedmor/joe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukedmor/joe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukedmor/joe/teams","hooks_url":"https://api.github.com/repos/lukedmor/joe/hooks","issue_events_url":"https://api.github.com/repos/lukedmor/joe/issues/events{/number}","events_url":"https://api.github.com/repos/lukedmor/joe/events","assignees_url":"https://api.github.com/repos/lukedmor/joe/assignees{/user}","branches_url":"https://api.github.com/repos/lukedmor/joe/branches{/branch}","tags_url":"https://api.github.com/repos/lukedmor/joe/tags","blobs_url":"https://api.github.com/repos/lukedmor/joe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukedmor/joe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukedmor/joe/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukedmor/joe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukedmor/joe/statuses/{sha}","languages_url":"https://api.github.com/repos/lukedmor/joe/languages","stargazers_url":"https://api.github.com/repos/lukedmor/joe/stargazers","contributors_url":"https://api.github.com/repos/lukedmor/joe/contributors","subscribers_url":"https://api.github.com/repos/lukedmor/joe/subscribers","subscription_url":"https://api.github.com/repos/lukedmor/joe/subscription","commits_url":"https://api.github.com/repos/lukedmor/joe/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukedmor/joe/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukedmor/joe/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukedmor/joe/issues/comments/{number}","contents_url":"https://api.github.com/repos/lukedmor/joe/contents/{+path}","compare_url":"https://api.github.com/repos/lukedmor/joe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukedmor/joe/merges","archive_url":"https://api.github.com/repos/lukedmor/joe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukedmor/joe/downloads","issues_url":"https://api.github.com/repos/lukedmor/joe/issues{/number}","pulls_url":"https://api.github.com/repos/lukedmor/joe/pulls{/number}","milestones_url":"https://api.github.com/repos/lukedmor/joe/milestones{/number}","notifications_url":"https://api.github.com/repos/lukedmor/joe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukedmor/joe/labels{/name}","releases_url":"https://api.github.com/repos/lukedmor/joe/releases{/id}","created_at":"2015-01-21T00:18:03Z","updated_at":"2015-01-21T04:58:00Z","pushed_at":"2015-01-21T04:58:00Z","git_url":"git://github.com/lukedmor/joe.git","ssh_url":"git@github.com:lukedmor/joe.git","clone_url":"https://github.com/lukedmor/joe.git","svn_url":"https://github.com/lukedmor/joe","homepage":"http://karan.github.io/joe/","size":418,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"karan:master","ref":"master","sha":"849fe830838b81d7524e1589a71786a19cfb7b3b","user":{"login":"karan","id":3261985,"avatar_url":"https://avatars.githubusercontent.com/u/3261985?v=3","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"repo":{"id":29085322,"name":"joe","full_name":"karan/joe","owner":{"login":"karan","id":3261985,"avatar_url":"https://avatars.githubusercontent.com/u/3261985?v=3","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karan/joe","description":":running: A .gitignore magician in your command line","fork":false,"url":"https://api.github.com/repos/karan/joe","forks_url":"https://api.github.com/repos/karan/joe/forks","keys_url":"https://api.github.com/repos/karan/joe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karan/joe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karan/joe/teams","hooks_url":"https://api.github.com/repos/karan/joe/hooks","issue_events_url":"https://api.github.com/repos/karan/joe/issues/events{/number}","events_url":"https://api.github.com/repos/karan/joe/events","assignees_url":"https://api.github.com/repos/karan/joe/assignees{/user}","branches_url":"https://api.github.com/repos/karan/joe/branches{/branch}","tags_url":"https://api.github.com/repos/karan/joe/tags","blobs_url":"https://api.github.com/repos/karan/joe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karan/joe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karan/joe/git/refs{/sha}","trees_url":"https://api.github.com/repos/karan/joe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karan/joe/statuses/{sha}","languages_url":"https://api.github.com/repos/karan/joe/languages","stargazers_url":"https://api.github.com/repos/karan/joe/stargazers","contributors_url":"https://api.github.com/repos/karan/joe/contributors","subscribers_url":"https://api.github.com/repos/karan/joe/subscribers","subscription_url":"https://api.github.com/repos/karan/joe/subscription","commits_url":"https://api.github.com/repos/karan/joe/commits{/sha}","git_commits_url":"https://api.github.com/repos/karan/joe/git/commits{/sha}","comments_url":"https://api.github.com/repos/karan/joe/comments{/number}","issue_comment_url":"https://api.github.com/repos/karan/joe/issues/comments/{number}","contents_url":"https://api.github.com/repos/karan/joe/contents/{+path}","compare_url":"https://api.github.com/repos/karan/joe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karan/joe/merges","archive_url":"https://api.github.com/repos/karan/joe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karan/joe/downloads","issues_url":"https://api.github.com/repos/karan/joe/issues{/number}","pulls_url":"https://api.github.com/repos/karan/joe/pulls{/number}","milestones_url":"https://api.github.com/repos/karan/joe/milestones{/number}","notifications_url":"https://api.github.com/repos/karan/joe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karan/joe/labels{/name}","releases_url":"https://api.github.com/repos/karan/joe/releases{/id}","created_at":"2015-01-11T08:02:17Z","updated_at":"2015-01-22T09:21:16Z","pushed_at":"2015-01-20T15:57:30Z","git_url":"git://github.com/karan/joe.git","ssh_url":"git@github.com:karan/joe.git","clone_url":"https://github.com/karan/joe.git","svn_url":"https://github.com/karan/joe","homepage":"http://karan.github.io/joe/","size":418,"stargazers_count":644,"watchers_count":644,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karan/joe/pulls/23"},"html":{"href":"https://github.com/karan/joe/pull/23"},"issue":{"href":"https://api.github.com/repos/karan/joe/issues/23"},"comments":{"href":"https://api.github.com/repos/karan/joe/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/karan/joe/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/karan/joe/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/karan/joe/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/karan/joe/statuses/31fdbe7eb236a846c80c1bcfa0bc5703aea4ef96"}}}}