{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments/34816379","id":34816379,"diff_hunk":"@@ -32,9 +24,8 @@ def to_wire(spec, value):\n     \"\"\"\n     if value is None or not schema.has_format(spec):\n         return value\n-\n-    to_wire, _, _ = _formatters[schema.get_format(spec)]\n-    return to_wire(value)\n+    formatter = get_format(schema.get_format(spec))","path":"bravado_core/formatter.py","position":37,"original_position":37,"commit_id":"9ba07ca094be64af9cca0daa146ebab4fcd7aba4","original_commit_id":"9ba07ca094be64af9cca0daa146ebab4fcd7aba4","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"Agreed, but the default behavior of warnings will be to send output to `stderr` which i think will just get ignored on stage/prod?","created_at":"2015-07-16T17:48:45Z","updated_at":"2015-07-16T17:48:45Z","html_url":"https://github.com/Yelp/bravado-core/pull/34#discussion_r34816379","pull_request_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments/34816379"},"html":{"href":"https://github.com/Yelp/bravado-core/pull/34#discussion_r34816379"},"pull_request":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/bravado-core/pulls/34","id":40059717,"html_url":"https://github.com/Yelp/bravado-core/pull/34","diff_url":"https://github.com/Yelp/bravado-core/pull/34.diff","patch_url":"https://github.com/Yelp/bravado-core/pull/34.patch","issue_url":"https://api.github.com/repos/Yelp/bravado-core/issues/34","number":34,"state":"open","locked":false,"title":"Support and validation for user defined Swagger formats","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"- add `SwaggerFormat` namedtuple\r\n- add call to `validate` during primitive check\r\n- Fixes #32 ","created_at":"2015-07-15T19:26:05Z","updated_at":"2015-07-16T17:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d14427c98de2b49e006a68b79d2038b22503d3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/bravado-core/issues/34/comments","statuses_url":"https://api.github.com/repos/Yelp/bravado-core/statuses/9ba07ca094be64af9cca0daa146ebab4fcd7aba4","head":{"label":"prat0318:addSwaggerFormatter","ref":"addSwaggerFormatter","sha":"9ba07ca094be64af9cca0daa146ebab4fcd7aba4","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"repo":{"id":38846518,"name":"bravado-core","full_name":"prat0318/bravado-core","owner":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prat0318/bravado-core","description":"","fork":true,"url":"https://api.github.com/repos/prat0318/bravado-core","forks_url":"https://api.github.com/repos/prat0318/bravado-core/forks","keys_url":"https://api.github.com/repos/prat0318/bravado-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prat0318/bravado-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prat0318/bravado-core/teams","hooks_url":"https://api.github.com/repos/prat0318/bravado-core/hooks","issue_events_url":"https://api.github.com/repos/prat0318/bravado-core/issues/events{/number}","events_url":"https://api.github.com/repos/prat0318/bravado-core/events","assignees_url":"https://api.github.com/repos/prat0318/bravado-core/assignees{/user}","branches_url":"https://api.github.com/repos/prat0318/bravado-core/branches{/branch}","tags_url":"https://api.github.com/repos/prat0318/bravado-core/tags","blobs_url":"https://api.github.com/repos/prat0318/bravado-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prat0318/bravado-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prat0318/bravado-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/prat0318/bravado-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prat0318/bravado-core/statuses/{sha}","languages_url":"https://api.github.com/repos/prat0318/bravado-core/languages","stargazers_url":"https://api.github.com/repos/prat0318/bravado-core/stargazers","contributors_url":"https://api.github.com/repos/prat0318/bravado-core/contributors","subscribers_url":"https://api.github.com/repos/prat0318/bravado-core/subscribers","subscription_url":"https://api.github.com/repos/prat0318/bravado-core/subscription","commits_url":"https://api.github.com/repos/prat0318/bravado-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/prat0318/bravado-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/prat0318/bravado-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/prat0318/bravado-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/prat0318/bravado-core/contents/{+path}","compare_url":"https://api.github.com/repos/prat0318/bravado-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prat0318/bravado-core/merges","archive_url":"https://api.github.com/repos/prat0318/bravado-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prat0318/bravado-core/downloads","issues_url":"https://api.github.com/repos/prat0318/bravado-core/issues{/number}","pulls_url":"https://api.github.com/repos/prat0318/bravado-core/pulls{/number}","milestones_url":"https://api.github.com/repos/prat0318/bravado-core/milestones{/number}","notifications_url":"https://api.github.com/repos/prat0318/bravado-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prat0318/bravado-core/labels{/name}","releases_url":"https://api.github.com/repos/prat0318/bravado-core/releases{/id}","created_at":"2015-07-09T21:36:48Z","updated_at":"2015-07-09T21:36:48Z","pushed_at":"2015-07-15T19:24:01Z","git_url":"git://github.com/prat0318/bravado-core.git","ssh_url":"git@github.com:prat0318/bravado-core.git","clone_url":"https://github.com/prat0318/bravado-core.git","svn_url":"https://github.com/prat0318/bravado-core","homepage":null,"size":967,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"ab947a7eb268566d20514732d728873b0de784ff","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":33146014,"name":"bravado-core","full_name":"Yelp/bravado-core","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/bravado-core","description":"","fork":false,"url":"https://api.github.com/repos/Yelp/bravado-core","forks_url":"https://api.github.com/repos/Yelp/bravado-core/forks","keys_url":"https://api.github.com/repos/Yelp/bravado-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/bravado-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/bravado-core/teams","hooks_url":"https://api.github.com/repos/Yelp/bravado-core/hooks","issue_events_url":"https://api.github.com/repos/Yelp/bravado-core/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/bravado-core/events","assignees_url":"https://api.github.com/repos/Yelp/bravado-core/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/bravado-core/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/bravado-core/tags","blobs_url":"https://api.github.com/repos/Yelp/bravado-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/bravado-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/bravado-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/bravado-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/bravado-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/bravado-core/languages","stargazers_url":"https://api.github.com/repos/Yelp/bravado-core/stargazers","contributors_url":"https://api.github.com/repos/Yelp/bravado-core/contributors","subscribers_url":"https://api.github.com/repos/Yelp/bravado-core/subscribers","subscription_url":"https://api.github.com/repos/Yelp/bravado-core/subscription","commits_url":"https://api.github.com/repos/Yelp/bravado-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/bravado-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/bravado-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/bravado-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/bravado-core/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/bravado-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/bravado-core/merges","archive_url":"https://api.github.com/repos/Yelp/bravado-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/bravado-core/downloads","issues_url":"https://api.github.com/repos/Yelp/bravado-core/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/bravado-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/bravado-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/bravado-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/bravado-core/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/bravado-core/releases{/id}","created_at":"2015-03-30T20:23:27Z","updated_at":"2015-07-14T23:06:42Z","pushed_at":"2015-07-15T19:26:05Z","git_url":"git://github.com/Yelp/bravado-core.git","ssh_url":"git@github.com:Yelp/bravado-core.git","clone_url":"https://github.com/Yelp/bravado-core.git","svn_url":"https://github.com/Yelp/bravado-core","homepage":null,"size":1230,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/34"},"html":{"href":"https://github.com/Yelp/bravado-core/pull/34"},"issue":{"href":"https://api.github.com/repos/Yelp/bravado-core/issues/34"},"comments":{"href":"https://api.github.com/repos/Yelp/bravado-core/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/bravado-core/statuses/9ba07ca094be64af9cca0daa146ebab4fcd7aba4"}}}}