{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/31115858","id":31115858,"diff_hunk":"@@ -355,7 +358,7 @@\n                         }\n                       } else {  // This is a listed add-on.\n                         if (automaticValidation && results.beta) {\n-                          if (warnings > 0) {\n+                          if (!passedValidation) {","path":"static/js/common/upload-addon.js","position":21,"original_position":21,"commit_id":"db03aac8b57c5d8461c415e3978d8e723d0abece","original_commit_id":"db03aac8b57c5d8461c415e3978d8e723d0abece","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"Regular warnings that should fail an automatic validation (that is used for unlisted non-sideload addons AND for beta files) have a signing severity level attached. So if a message has a signing severity above `trivial`, it'll fail the auto validation.","created_at":"2015-05-27T09:19:17Z","updated_at":"2015-05-27T09:19:17Z","html_url":"https://github.com/mozilla/olympia/pull/564#discussion_r31115858","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/564","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/31115858"},"html":{"href":"https://github.com/mozilla/olympia/pull/564#discussion_r31115858"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/564"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/564","id":35817384,"html_url":"https://github.com/mozilla/olympia/pull/564","diff_url":"https://github.com/mozilla/olympia/pull/564.diff","patch_url":"https://github.com/mozilla/olympia/pull/564.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/564","number":564,"state":"open","locked":false,"title":"Use the signing_summary from the validator for auto validation (bug 1153231)","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"Fixes [bug 1153231](https://bugzilla.mozilla.org/show_bug.cgi?id=1153231)\n\nThis needs the amo-validation PR https://github.com/mozilla/amo-validator/pull/280/files#diff-5cee0359fb519e94f796b7fb2d007148R315 to land.\n\n@robhudson @kmaglione r?","created_at":"2015-05-20T10:23:28Z","updated_at":"2015-05-27T09:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ac6184af842bb8e62649031ee644d0e2e2ef6fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/564/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/564/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/564/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/db03aac8b57c5d8461c415e3978d8e723d0abece","head":{"label":"magopian:1153231-auto-validation-signing_summary","ref":"1153231-auto-validation-signing_summary","sha":"db03aac8b57c5d8461c415e3978d8e723d0abece","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"repo":{"id":17664164,"name":"olympia","full_name":"magopian/olympia","owner":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magopian/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/magopian/olympia","forks_url":"https://api.github.com/repos/magopian/olympia/forks","keys_url":"https://api.github.com/repos/magopian/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magopian/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magopian/olympia/teams","hooks_url":"https://api.github.com/repos/magopian/olympia/hooks","issue_events_url":"https://api.github.com/repos/magopian/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/magopian/olympia/events","assignees_url":"https://api.github.com/repos/magopian/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/magopian/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/magopian/olympia/tags","blobs_url":"https://api.github.com/repos/magopian/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magopian/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magopian/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/magopian/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magopian/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/magopian/olympia/languages","stargazers_url":"https://api.github.com/repos/magopian/olympia/stargazers","contributors_url":"https://api.github.com/repos/magopian/olympia/contributors","subscribers_url":"https://api.github.com/repos/magopian/olympia/subscribers","subscription_url":"https://api.github.com/repos/magopian/olympia/subscription","commits_url":"https://api.github.com/repos/magopian/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/magopian/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/magopian/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/magopian/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/magopian/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/magopian/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magopian/olympia/merges","archive_url":"https://api.github.com/repos/magopian/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magopian/olympia/downloads","issues_url":"https://api.github.com/repos/magopian/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/magopian/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/magopian/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/magopian/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magopian/olympia/labels{/name}","releases_url":"https://api.github.com/repos/magopian/olympia/releases{/id}","created_at":"2014-03-12T11:05:51Z","updated_at":"2015-04-24T16:05:25Z","pushed_at":"2015-05-26T22:30:33Z","git_url":"git://github.com/magopian/olympia.git","ssh_url":"git@github.com:magopian/olympia.git","clone_url":"https://github.com/magopian/olympia.git","svn_url":"https://github.com/magopian/olympia","homepage":"","size":371054,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8719f327ecfea5c560e8addfba61dfd3092bb20e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-05-21T22:19:00Z","pushed_at":"2015-05-26T22:35:31Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":421427,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":10,"forks":83,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/564"},"html":{"href":"https://github.com/mozilla/olympia/pull/564"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/564"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/db03aac8b57c5d8461c415e3978d8e723d0abece"}}}}