{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/44876409","id":44876409,"diff_hunk":"@@ -286,4 +305,14 @@ def unassign_graders(grader_membership_ids)\n     end\n     Grouping.unassign_tas(grader_membership_ids, grouping_ids, @assignment)\n   end\n+\n+  def find_empty_submissions(grouping_ids)\n+    grouping_ids.each do |grouping_id|\n+      submission = Submission.find_by_grouping_id(grouping_id)\n+      if !submission || !SubmissionFile.where(submission_id: submission.id).exists?\n+        grouping_ids.delete(grouping_id)\n+        @found_empty_submission = true;","path":"app/controllers/graders_controller.rb","position":51,"original_position":51,"commit_id":"c4fdd468466c63dda0a3445d2b9cf5b1497ae003","original_commit_id":"c4fdd468466c63dda0a3445d2b9cf5b1497ae003","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Do not use semicolons to terminate expressions.","created_at":"2015-11-15T19:35:14Z","updated_at":"2015-11-15T19:35:14Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2355#discussion_r44876409","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/44876409"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2355#discussion_r44876409"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355","id":50753804,"html_url":"https://github.com/MarkUsProject/Markus/pull/2355","diff_url":"https://github.com/MarkUsProject/Markus/pull/2355.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2355.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2355","number":2355,"state":"open","locked":false,"title":"Issue 2050","user":{"login":"melneubert","id":3590694,"avatar_url":"https://avatars.githubusercontent.com/u/3590694?v=3","gravatar_id":"","url":"https://api.github.com/users/melneubert","html_url":"https://github.com/melneubert","followers_url":"https://api.github.com/users/melneubert/followers","following_url":"https://api.github.com/users/melneubert/following{/other_user}","gists_url":"https://api.github.com/users/melneubert/gists{/gist_id}","starred_url":"https://api.github.com/users/melneubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melneubert/subscriptions","organizations_url":"https://api.github.com/users/melneubert/orgs","repos_url":"https://api.github.com/users/melneubert/repos","events_url":"https://api.github.com/users/melneubert/events{/privacy}","received_events_url":"https://api.github.com/users/melneubert/received_events","type":"User","site_admin":false},"body":"Closes #2050 \r\n\r\nInstructors can optionally choose to disallow adding graders to groups with no submission. If this is the case, a message will be displayed to them and all other valid grader -> group assignments will go through.\r\n\r\nAfter submissions are collected, those with empty submissions will be flagged with an icon.","created_at":"2015-11-15T19:27:39Z","updated_at":"2015-11-15T19:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f1048ee8db7a5e40121ba0dca5f494ce8360429","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2355/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/c4fdd468466c63dda0a3445d2b9cf5b1497ae003","head":{"label":"melneubert:issue-2050","ref":"issue-2050","sha":"c4fdd468466c63dda0a3445d2b9cf5b1497ae003","user":{"login":"melneubert","id":3590694,"avatar_url":"https://avatars.githubusercontent.com/u/3590694?v=3","gravatar_id":"","url":"https://api.github.com/users/melneubert","html_url":"https://github.com/melneubert","followers_url":"https://api.github.com/users/melneubert/followers","following_url":"https://api.github.com/users/melneubert/following{/other_user}","gists_url":"https://api.github.com/users/melneubert/gists{/gist_id}","starred_url":"https://api.github.com/users/melneubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melneubert/subscriptions","organizations_url":"https://api.github.com/users/melneubert/orgs","repos_url":"https://api.github.com/users/melneubert/repos","events_url":"https://api.github.com/users/melneubert/events{/privacy}","received_events_url":"https://api.github.com/users/melneubert/received_events","type":"User","site_admin":false},"repo":{"id":42267483,"name":"Markus","full_name":"melneubert/Markus","owner":{"login":"melneubert","id":3590694,"avatar_url":"https://avatars.githubusercontent.com/u/3590694?v=3","gravatar_id":"","url":"https://api.github.com/users/melneubert","html_url":"https://github.com/melneubert","followers_url":"https://api.github.com/users/melneubert/followers","following_url":"https://api.github.com/users/melneubert/following{/other_user}","gists_url":"https://api.github.com/users/melneubert/gists{/gist_id}","starred_url":"https://api.github.com/users/melneubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melneubert/subscriptions","organizations_url":"https://api.github.com/users/melneubert/orgs","repos_url":"https://api.github.com/users/melneubert/repos","events_url":"https://api.github.com/users/melneubert/events{/privacy}","received_events_url":"https://api.github.com/users/melneubert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melneubert/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/melneubert/Markus","forks_url":"https://api.github.com/repos/melneubert/Markus/forks","keys_url":"https://api.github.com/repos/melneubert/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melneubert/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melneubert/Markus/teams","hooks_url":"https://api.github.com/repos/melneubert/Markus/hooks","issue_events_url":"https://api.github.com/repos/melneubert/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/melneubert/Markus/events","assignees_url":"https://api.github.com/repos/melneubert/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/melneubert/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/melneubert/Markus/tags","blobs_url":"https://api.github.com/repos/melneubert/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melneubert/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melneubert/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/melneubert/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melneubert/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/melneubert/Markus/languages","stargazers_url":"https://api.github.com/repos/melneubert/Markus/stargazers","contributors_url":"https://api.github.com/repos/melneubert/Markus/contributors","subscribers_url":"https://api.github.com/repos/melneubert/Markus/subscribers","subscription_url":"https://api.github.com/repos/melneubert/Markus/subscription","commits_url":"https://api.github.com/repos/melneubert/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/melneubert/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/melneubert/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/melneubert/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/melneubert/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/melneubert/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melneubert/Markus/merges","archive_url":"https://api.github.com/repos/melneubert/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melneubert/Markus/downloads","issues_url":"https://api.github.com/repos/melneubert/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/melneubert/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/melneubert/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/melneubert/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melneubert/Markus/labels{/name}","releases_url":"https://api.github.com/repos/melneubert/Markus/releases{/id}","created_at":"2015-09-10T19:57:42Z","updated_at":"2015-09-10T19:57:45Z","pushed_at":"2015-11-15T19:35:07Z","git_url":"git://github.com/melneubert/Markus.git","ssh_url":"git@github.com:melneubert/Markus.git","clone_url":"https://github.com/melneubert/Markus.git","svn_url":"https://github.com/melneubert/Markus","homepage":"http://www.markusproject.org","size":23760,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"087f15165fbd11bbccecc69de1beb21f5d7b7fde","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2015-11-11T22:26:37Z","pushed_at":"2015-11-15T19:35:08Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":50414,"stargazers_count":130,"watchers_count":130,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":105,"forks":161,"open_issues":105,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2355"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2355"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2355/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2355/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/c4fdd468466c63dda0a3445d2b9cf5b1497ae003"}}}}