{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/24353559","id":24353559,"diff_hunk":"@@ -1085,8 +1088,14 @@ unittest\n     return u;\n }\n \n+private @trusted\n+ref T unsafeTrustingArrayElementReinterpret(T)(ref ubyte[16] arr, size_t i)\n+{\n+    return *cast(T*)(arr.ptr+i);","path":"std/uuid.d","position":43,"original_position":43,"commit_id":"d6f963da08bf65d5565638493061bc13c1c3e83e","original_commit_id":"d6f963da08bf65d5565638493061bc13c1c3e83e","user":{"login":"quickfur","id":405446,"avatar_url":"https://avatars.githubusercontent.com/u/405446?v=3","gravatar_id":"","url":"https://api.github.com/users/quickfur","html_url":"https://github.com/quickfur","followers_url":"https://api.github.com/users/quickfur/followers","following_url":"https://api.github.com/users/quickfur/following{/other_user}","gists_url":"https://api.github.com/users/quickfur/gists{/gist_id}","starred_url":"https://api.github.com/users/quickfur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quickfur/subscriptions","organizations_url":"https://api.github.com/users/quickfur/orgs","repos_url":"https://api.github.com/users/quickfur/repos","events_url":"https://api.github.com/users/quickfur/events{/privacy}","received_events_url":"https://api.github.com/users/quickfur/received_events","type":"User","site_admin":false},"body":"Unfortunately, that's precisely the usage that Walter and Andrei strongly disagree with. You'll have to take it up with them, since they have made it clear that we are not to merge anything that abuses `@trusted` in this way.","created_at":"2015-02-09T18:51:36Z","updated_at":"2015-02-09T18:51:36Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2971#discussion_r24353559","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/24353559"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2971#discussion_r24353559"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971","id":28917692,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2971","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2971.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2971.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2971","number":2971,"state":"open","locked":false,"title":"Issue 14135 - std.uuid.randomUUID breaks @safety","user":{"login":"monarchdodra","id":1911406,"avatar_url":"https://avatars.githubusercontent.com/u/1911406?v=3","gravatar_id":"","url":"https://api.github.com/users/monarchdodra","html_url":"https://github.com/monarchdodra","followers_url":"https://api.github.com/users/monarchdodra/followers","following_url":"https://api.github.com/users/monarchdodra/following{/other_user}","gists_url":"https://api.github.com/users/monarchdodra/gists{/gist_id}","starred_url":"https://api.github.com/users/monarchdodra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monarchdodra/subscriptions","organizations_url":"https://api.github.com/users/monarchdodra/orgs","repos_url":"https://api.github.com/users/monarchdodra/repos","events_url":"https://api.github.com/users/monarchdodra/events{/privacy}","received_events_url":"https://api.github.com/users/monarchdodra/received_events","type":"User","site_admin":false},"body":"Issue 14135 - std.uuid.randomUUID breaks @safety\r\nhttps://issues.dlang.org/show_bug.cgi?id=14135\r\n\r\nDo note I am committing this completely blind, and do not even know if it compiles. It should. The unit-tests *should* also pass, but if not, the unittests are arguably wrong.\r\n\r\nAlso, this *should* be a faster implementation, as it prefers reinterpret to primitive than assign, over re-interpret to array, then do slice copies.","created_at":"2015-02-09T12:50:21Z","updated_at":"2015-02-09T18:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd868fbe95cbb4f628e37ab1a50f47bf0a613bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2971/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/d6f963da08bf65d5565638493061bc13c1c3e83e","head":{"label":"monarchdodra:14135","ref":"14135","sha":"d6f963da08bf65d5565638493061bc13c1c3e83e","user":{"login":"monarchdodra","id":1911406,"avatar_url":"https://avatars.githubusercontent.com/u/1911406?v=3","gravatar_id":"","url":"https://api.github.com/users/monarchdodra","html_url":"https://github.com/monarchdodra","followers_url":"https://api.github.com/users/monarchdodra/followers","following_url":"https://api.github.com/users/monarchdodra/following{/other_user}","gists_url":"https://api.github.com/users/monarchdodra/gists{/gist_id}","starred_url":"https://api.github.com/users/monarchdodra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monarchdodra/subscriptions","organizations_url":"https://api.github.com/users/monarchdodra/orgs","repos_url":"https://api.github.com/users/monarchdodra/repos","events_url":"https://api.github.com/users/monarchdodra/events{/privacy}","received_events_url":"https://api.github.com/users/monarchdodra/received_events","type":"User","site_admin":false},"repo":{"id":5162519,"name":"phobos","full_name":"monarchdodra/phobos","owner":{"login":"monarchdodra","id":1911406,"avatar_url":"https://avatars.githubusercontent.com/u/1911406?v=3","gravatar_id":"","url":"https://api.github.com/users/monarchdodra","html_url":"https://github.com/monarchdodra","followers_url":"https://api.github.com/users/monarchdodra/followers","following_url":"https://api.github.com/users/monarchdodra/following{/other_user}","gists_url":"https://api.github.com/users/monarchdodra/gists{/gist_id}","starred_url":"https://api.github.com/users/monarchdodra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monarchdodra/subscriptions","organizations_url":"https://api.github.com/users/monarchdodra/orgs","repos_url":"https://api.github.com/users/monarchdodra/repos","events_url":"https://api.github.com/users/monarchdodra/events{/privacy}","received_events_url":"https://api.github.com/users/monarchdodra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monarchdodra/phobos","description":"Runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/monarchdodra/phobos","forks_url":"https://api.github.com/repos/monarchdodra/phobos/forks","keys_url":"https://api.github.com/repos/monarchdodra/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monarchdodra/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monarchdodra/phobos/teams","hooks_url":"https://api.github.com/repos/monarchdodra/phobos/hooks","issue_events_url":"https://api.github.com/repos/monarchdodra/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/monarchdodra/phobos/events","assignees_url":"https://api.github.com/repos/monarchdodra/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/monarchdodra/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/monarchdodra/phobos/tags","blobs_url":"https://api.github.com/repos/monarchdodra/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monarchdodra/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monarchdodra/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/monarchdodra/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monarchdodra/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/monarchdodra/phobos/languages","stargazers_url":"https://api.github.com/repos/monarchdodra/phobos/stargazers","contributors_url":"https://api.github.com/repos/monarchdodra/phobos/contributors","subscribers_url":"https://api.github.com/repos/monarchdodra/phobos/subscribers","subscription_url":"https://api.github.com/repos/monarchdodra/phobos/subscription","commits_url":"https://api.github.com/repos/monarchdodra/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/monarchdodra/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/monarchdodra/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/monarchdodra/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/monarchdodra/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/monarchdodra/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monarchdodra/phobos/merges","archive_url":"https://api.github.com/repos/monarchdodra/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monarchdodra/phobos/downloads","issues_url":"https://api.github.com/repos/monarchdodra/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/monarchdodra/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/monarchdodra/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/monarchdodra/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monarchdodra/phobos/labels{/name}","releases_url":"https://api.github.com/repos/monarchdodra/phobos/releases{/id}","created_at":"2012-07-24T07:32:15Z","updated_at":"2014-06-28T10:31:48Z","pushed_at":"2015-02-09T13:30:33Z","git_url":"git://github.com/monarchdodra/phobos.git","ssh_url":"git@github.com:monarchdodra/phobos.git","clone_url":"https://github.com/monarchdodra/phobos.git","svn_url":"https://github.com/monarchdodra/phobos","homepage":"d-programming-language.org","size":40624,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"3eb366d2590be148959a968446be80c778689d57","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2015-02-09T18:15:35Z","pushed_at":"2015-02-09T18:15:35Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":66118,"stargazers_count":562,"watchers_count":562,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":40,"forks":371,"open_issues":40,"watchers":562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2971"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2971"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2971/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2971/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/d6f963da08bf65d5565638493061bc13c1c3e83e"}}}}