{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/37637402","id":37637402,"diff_hunk":"@@ -37,5 +37,90 @@ angular.module('patternfly.charts').constant('c3ChartDefaults', {\n       color: this.getDefaultDonutColor(),\n       tooltip: this.getDefaultDonutTooltip()\n     };\n+  },\n+\n+  /*\n+   * Sparkline Defaults\n+   */\n+\n+  getDefaultSparklineArea: function () {\n+    return {\n+      zerobased: true\n+    };\n+  },\n+\n+  getDefaultSparklineSize: function () {\n+    return {\n+      height: 60\n+    };\n+  },\n+\n+  getDefaultSparklineAxis: function () {\n+    return {\n+      x: {\n+        show: false\n+      },\n+      y: {\n+        show: false\n+      }\n+    };\n+  },\n+\n+  getDefaultSparklineColor: function () {\n+    return {\n+      pattern: ['#0088ce', '#00659c', '#3f9c35', '#ec7a08', '#cc0000']\n+    };\n+  },\n+\n+  getDefaultSparklineLegend: function () {\n+    return {\n+      show: false\n+    };\n+  },\n+\n+  getDefaultSparklinePoint: function () {\n+    return {\n+      r: 1,\n+      focus: {\n+        expand: {\n+          r: 4\n+        }\n+      }\n+    };\n+  },\n+\n+  getDefaultSparklineTooltip: function () {\n+    return {\n+      // because a sparkline should only contain a single data column, the tooltip will only work for a single data column\n+      contents: function (d) {\n+        return '<span class=\"c3-tooltip-sparkline\">' + d[0].value + ' ' + d[0].name + '</span>';\n+      }\n+    };\n+  },\n+\n+  getDefaultSparklineConfig: function () {\n+    return {\n+      area: this.getDefaultSparklineArea(),\n+      size: this.getDefaultSparklineSize(),\n+      axis: this.getDefaultSparklineAxis(),\n+      color: this.getDefaultSparklineColor(),\n+      legend: this.getDefaultSparklineLegend(),\n+      point: this.getDefaultSparklinePoint(),\n+      tooltip: this.getDefaultSparklineTooltip()\n+    };\n+  },\n+\n+  /*\n+   * Tooltips\n+   */\n+  getTooltipTableHTML: function (tipRows) {\n+    return '<div class=\"module-triangle-bottom\">' +\n+    '  <table class=\"c3-tooltip\">' +\n+    '    <tbody>' +\n+           tipRows +\n+    '    </tbody>' +\n+    '  </table>' +\n+    '</div>';","path":"src/charts/c3/c3-chart-defaults.js","position":87,"original_position":87,"commit_id":"780ba5e354958c87cd797e15dc37a5ea08910c1b","original_commit_id":"780ba5e354958c87cd797e15dc37a5ea08910c1b","user":{"login":"waldenraines","id":4116405,"avatar_url":"https://avatars.githubusercontent.com/u/4116405?v=3","gravatar_id":"","url":"https://api.github.com/users/waldenraines","html_url":"https://github.com/waldenraines","followers_url":"https://api.github.com/users/waldenraines/followers","following_url":"https://api.github.com/users/waldenraines/following{/other_user}","gists_url":"https://api.github.com/users/waldenraines/gists{/gist_id}","starred_url":"https://api.github.com/users/waldenraines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waldenraines/subscriptions","organizations_url":"https://api.github.com/users/waldenraines/orgs","repos_url":"https://api.github.com/users/waldenraines/repos","events_url":"https://api.github.com/users/waldenraines/events{/privacy}","received_events_url":"https://api.github.com/users/waldenraines/received_events","type":"User","site_admin":false},"body":"I personally think this should stay in the directive as that is really the only place you should have HTML (other than .html files) in Angular.","created_at":"2015-08-21T14:10:27Z","updated_at":"2015-08-21T14:10:27Z","html_url":"https://github.com/patternfly/angular-patternfly/pull/38#discussion_r37637402","pull_request_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/37637402"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/38#discussion_r37637402"},"pull_request":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38","id":42961598,"html_url":"https://github.com/patternfly/angular-patternfly/pull/38","diff_url":"https://github.com/patternfly/angular-patternfly/pull/38.diff","patch_url":"https://github.com/patternfly/angular-patternfly/pull/38.patch","issue_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/38","number":38,"state":"open","locked":false,"title":"Add Sparkline Chart Directive","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"body":"Adding directive for sparkline charts. Includes unit tests and ng-docs.","created_at":"2015-08-20T18:25:54Z","updated_at":"2015-08-21T14:10:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a35c144683e9ad80d32dd1f7f607b13f926376e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38/commits","review_comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38/comments","review_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/38/comments","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/780ba5e354958c87cd797e15dc37a5ea08910c1b","head":{"label":"jeff-phillips-18:master","ref":"master","sha":"780ba5e354958c87cd797e15dc37a5ea08910c1b","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"repo":{"id":40719634,"name":"angular-patternfly","full_name":"jeff-phillips-18/angular-patternfly","owner":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff-phillips-18/angular-patternfly","description":"","fork":true,"url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly","forks_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/forks","keys_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/events","assignees_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/merges","archive_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/jeff-phillips-18/angular-patternfly/releases{/id}","created_at":"2015-08-14T14:38:46Z","updated_at":"2015-08-14T14:38:46Z","pushed_at":"2015-08-21T11:07:19Z","git_url":"git://github.com/jeff-phillips-18/angular-patternfly.git","ssh_url":"git@github.com:jeff-phillips-18/angular-patternfly.git","clone_url":"https://github.com/jeff-phillips-18/angular-patternfly.git","svn_url":"https://github.com/jeff-phillips-18/angular-patternfly","homepage":null,"size":462,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"21e21c6ec19f542d2c6d897d026c8b62585fe39c","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":17672427,"name":"angular-patternfly","full_name":"patternfly/angular-patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/angular-patternfly","description":"","fork":false,"url":"https://api.github.com/repos/patternfly/angular-patternfly","forks_url":"https://api.github.com/repos/patternfly/angular-patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/angular-patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/angular-patternfly/releases{/id}","created_at":"2014-03-12T15:43:51Z","updated_at":"2015-08-04T16:35:38Z","pushed_at":"2015-08-21T11:07:20Z","git_url":"git://github.com/patternfly/angular-patternfly.git","ssh_url":"git@github.com:patternfly/angular-patternfly.git","clone_url":"https://github.com/patternfly/angular-patternfly.git","svn_url":"https://github.com/patternfly/angular-patternfly","homepage":null,"size":783,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/38"},"issue":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/38"},"comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/780ba5e354958c87cd797e15dc37a5ea08910c1b"}}}}