{"action":"created","issue":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/48","labels_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/48/comments","events_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/48/events","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/48","id":106187809,"number":48,"title":"Fixing how omf remove work, and omf.remove_package","user":{"login":"jeremiejig","id":3978761,"avatar_url":"https://avatars.githubusercontent.com/u/3978761?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiejig","html_url":"https://github.com/jeremiejig","followers_url":"https://api.github.com/users/jeremiejig/followers","following_url":"https://api.github.com/users/jeremiejig/following{/other_user}","gists_url":"https://api.github.com/users/jeremiejig/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiejig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiejig/subscriptions","organizations_url":"https://api.github.com/users/jeremiejig/orgs","repos_url":"https://api.github.com/users/jeremiejig/repos","events_url":"https://api.github.com/users/jeremiejig/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiejig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-09-12T22:14:04Z","updated_at":"2015-09-21T21:00:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/pulls/48","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/48","diff_url":"https://github.com/oh-my-fish/oh-my-fish/pull/48.diff","patch_url":"https://github.com/oh-my-fish/oh-my-fish/pull/48.patch"},"body":"**omf.destroy** was broken because of a [premature refresh].\r\nAnd with [this code] it was giving the impression that omf was hanging while in fact fish was running without a display.\r\n\r\nWhen fixing the bug I assumed that remove_package do the minimal (handle only one pkg)\r\nAt the time of the PR the indent in [omf.remove_package.fish] might be broken.\r\n\r\nI am now working on [omf.destroy.fish] to find the most recent backup of config.fish (for this PR)\r\n\r\n\r\n[premature refresh]: https://github.com/oh-my-fish/oh-my-fish/blob/4b0dbc270b9ab73d56aa0d07d820243d22479892/pkg/omf/cli/omf.remove_package.fish#L40\r\n[this code]: https://github.com/oh-my-fish/oh-my-fish/blob/4b0dbc270b9ab73d56aa0d07d820243d22479892/pkg/omf/cli/omf.destroy.fish#L4\r\n[omf.remove_package.fish]: https://github.com/jeremiejig/oh-my-fish/blob/d40328974835112fdcb2a6309c44c57b035a88c9/pkg/omf/cli/omf.remove_package.fish\r\n[omf.destroy.fish]: https://github.com/jeremiejig/oh-my-fish/blob/d40328974835112fdcb2a6309c44c57b035a88c9/pkg/omf/cli/omf.destroy.fish#L8"},"comment":{"url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/comments/142106784","html_url":"https://github.com/oh-my-fish/oh-my-fish/pull/48#issuecomment-142106784","issue_url":"https://api.github.com/repos/oh-my-fish/oh-my-fish/issues/48","id":142106784,"user":{"login":"derekstavis","id":1611639,"avatar_url":"https://avatars.githubusercontent.com/u/1611639?v=3","gravatar_id":"","url":"https://api.github.com/users/derekstavis","html_url":"https://github.com/derekstavis","followers_url":"https://api.github.com/users/derekstavis/followers","following_url":"https://api.github.com/users/derekstavis/following{/other_user}","gists_url":"https://api.github.com/users/derekstavis/gists{/gist_id}","starred_url":"https://api.github.com/users/derekstavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekstavis/subscriptions","organizations_url":"https://api.github.com/users/derekstavis/orgs","repos_url":"https://api.github.com/users/derekstavis/repos","events_url":"https://api.github.com/users/derekstavis/events{/privacy}","received_events_url":"https://api.github.com/users/derekstavis/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T21:00:13Z","updated_at":"2015-09-21T21:00:13Z","body":"I still need to try this on both Linux and OS X to be sure it works accordingly."}}