{"action":"created","issue":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1602","labels_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1602/labels{/name}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1602/comments","events_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1602/events","html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602","id":69249734,"number":1602,"title":"SWC-2238","user":{"login":"kimyen","id":4404426,"avatar_url":"https://avatars.githubusercontent.com/u/4404426?v=3","gravatar_id":"","url":"https://api.github.com/users/kimyen","html_url":"https://github.com/kimyen","followers_url":"https://api.github.com/users/kimyen/followers","following_url":"https://api.github.com/users/kimyen/following{/other_user}","gists_url":"https://api.github.com/users/kimyen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimyen/subscriptions","organizations_url":"https://api.github.com/users/kimyen/orgs","repos_url":"https://api.github.com/users/kimyen/repos","events_url":"https://api.github.com/users/kimyen/events{/privacy}","received_events_url":"https://api.github.com/users/kimyen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-18T01:09:22Z","updated_at":"2015-04-18T14:46:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/pulls/1602","html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602","diff_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602.diff","patch_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602.patch"},"body":"Verified that the Sharing dialog is generated dynamically, so there is no \"dataDismiss='MODAL'\". However, the view (SharingAndDataUseConditionWidgetViewImpl) is handling the logic by itself. So we may want to add it to the list of need-to-be-refactored views. "},"comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/comments/94170253","html_url":"https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602#issuecomment-94170253","issue_url":"https://api.github.com/repos/Sage-Bionetworks/SynapseWebClient/issues/1602","id":94170253,"user":{"login":"jay-hodgson","id":1864447,"avatar_url":"https://avatars.githubusercontent.com/u/1864447?v=3","gravatar_id":"","url":"https://api.github.com/users/jay-hodgson","html_url":"https://github.com/jay-hodgson","followers_url":"https://api.github.com/users/jay-hodgson/followers","following_url":"https://api.github.com/users/jay-hodgson/following{/other_user}","gists_url":"https://api.github.com/users/jay-hodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/jay-hodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay-hodgson/subscriptions","organizations_url":"https://api.github.com/users/jay-hodgson/orgs","repos_url":"https://api.github.com/users/jay-hodgson/repos","events_url":"https://api.github.com/users/jay-hodgson/events{/privacy}","received_events_url":"https://api.github.com/users/jay-hodgson/received_events","type":"User","site_admin":false},"created_at":"2015-04-18T14:46:15Z","updated_at":"2015-04-18T14:46:15Z","body":"You may want to spend the time configuring a custom mergetool for git (I\nthink I'm just using opendiff), if you haven't already.\n\nThere is a merge conflict. I will look into this.\nVerified that the Sharing dialog is generated dynamically, so there is no\n\"dataDismiss='MODAL'\". However, the view\n(SharingAndDataUseConditionWidgetViewImpl) is handling the logic by itself.\nSo we may want to add it to the list of need-to-be-refactored views.\n------------------------------\nYou can view, comment on, or merge this pull request online at:\n\n  https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602\nCommit Summary\n\n   - when Cancel is clicked, hide the widget\n   - fix some bugs\n\nFile Changes\n\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/RestrictionWidget.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-0>\n   (15)\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/RestrictionWidgetView.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-1>\n   (9)\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/RestrictionWidgetViewImpl.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-2>\n   (24)\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/browse/FilesBrowser.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-3>\n   (25)\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/browse/FilesBrowserView.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-4>\n   (7)\n   - *M*\n   src/main/java/org/sagebionetworks/web/client/widget/entity/browse/FilesBrowserViewImpl.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-5>\n   (70)\n   - *M*\n   src/main/resources/org/sagebionetworks/web/client/widget/entity/RestrictionWidgetViewImpl.ui.xml\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-6>\n   (2)\n   - *M*\n   src/main/resources/org/sagebionetworks/web/client/widget/entity/browse/FilesBrowserViewImpl.ui.xml\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-7>\n   (4)\n   - *M*\n   src/test/java/org/sagebionetworks/web/unitclient/widget/entity/RestrictionWidgetTest.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-8>\n   (39)\n   - *M*\n   src/test/java/org/sagebionetworks/web/unitclient/widget/entity/browse/FilesBrowserTest.java\n   <https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602/files#diff-9>\n   (10)\n\nPatch Links:\n\n   - https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602.patch\n   - https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602.diff\n\n—\nReply to this email directly or view it on GitHub\n<https://github.com/Sage-Bionetworks/SynapseWebClient/pull/1602>.\n"}}