{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/comments/40456426","id":40456426,"diff_hunk":"@@ -0,0 +1,39 @@\n+<dom-module id=\"app-element\">\n+  <template>\n+    <style>\n+      :host {\n+        display: block;\n+      }\n+    </style>\n+\n+    <div class=\"horizontal center-justified layout\">\n+      <div class=\"vertical-section\">\n+        <h3>Dinosaurs by Height</h3>\n+        <template is=\"dom-bind\">\n+          <firebase-collection\n+              order-by-child=\"height\"\n+              location=\"https://dinosaur-facts.firebaseio.com/dinosaurs\"\n+              data=\"{{dinosaurs}}\"></firebase-collection>\n+          <template is=\"dom-repeat\" items=\"[[dinosaurs]]\" as=\"dinosaur\">","path":"demo/web/firebase_element/app_element.html","position":17,"original_position":17,"commit_id":"dc146745b2683e3e811cf9f65517bcf4a8cdf7fe","original_commit_id":"dc146745b2683e3e811cf9f65517bcf4a8cdf7fe","user":{"login":"zoechi","id":405837,"avatar_url":"https://avatars.githubusercontent.com/u/405837?v=3","gravatar_id":"","url":"https://api.github.com/users/zoechi","html_url":"https://github.com/zoechi","followers_url":"https://api.github.com/users/zoechi/followers","following_url":"https://api.github.com/users/zoechi/following{/other_user}","gists_url":"https://api.github.com/users/zoechi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoechi/subscriptions","organizations_url":"https://api.github.com/users/zoechi/orgs","repos_url":"https://api.github.com/users/zoechi/repos","events_url":"https://api.github.com/users/zoechi/events{/privacy}","received_events_url":"https://api.github.com/users/zoechi/received_events","type":"User","site_admin":false},"body":"Yup, but some styles are not applied when I wrap the demo inside an `<app-element>`.\r\n\r\nTo import styles in the entry page you use `<style is=\"custom-style\"...>` in the imported file, to import the styles in an element the styles need to be wrapped in `<dom-element id=\"demo-pages\"><template>`.\r\nSee also: https://www.polymer-project.org/1.0/docs/devguide/styling.html#style-modules\r\nSome styles in `demo-pages.html` as it currently is, are only applied on the entry page and only target elements in the entry page, but not elements inside other elements.\r\nI modified `polymer_elements/lib/src/paper-styles/demo-pages.html` locally from `<style is=\"custom-style\">` to `<dom-module id=\"demo-pages><template>` and the styles are applied inside `<app-element>`.\r\n\r\nCreating a copy of the about 30 lines of styles in `demo-pages.html` file wrapped as `<dom-module id=\"demo-pages\">` (inside `demo-pages.html` or in a new file) would fix this.\r\nWhat do you think?","created_at":"2015-09-25T17:48:32Z","updated_at":"2015-09-25T17:48:32Z","html_url":"https://github.com/dart-lang/polymer_elements/pull/63#discussion_r40456426","pull_request_url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/comments/40456426"},"html":{"href":"https://github.com/dart-lang/polymer_elements/pull/63#discussion_r40456426"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63","id":45999177,"html_url":"https://github.com/dart-lang/polymer_elements/pull/63","diff_url":"https://github.com/dart-lang/polymer_elements/pull/63.diff","patch_url":"https://github.com/dart-lang/polymer_elements/pull/63.patch","issue_url":"https://api.github.com/repos/dart-lang/polymer_elements/issues/63","number":63,"state":"open","locked":false,"title":"add firebase_element demo","user":{"login":"zoechi","id":405837,"avatar_url":"https://avatars.githubusercontent.com/u/405837?v=3","gravatar_id":"","url":"https://api.github.com/users/zoechi","html_url":"https://github.com/zoechi","followers_url":"https://api.github.com/users/zoechi/followers","following_url":"https://api.github.com/users/zoechi/following{/other_user}","gists_url":"https://api.github.com/users/zoechi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoechi/subscriptions","organizations_url":"https://api.github.com/users/zoechi/orgs","repos_url":"https://api.github.com/users/zoechi/repos","events_url":"https://api.github.com/users/zoechi/events{/privacy}","received_events_url":"https://api.github.com/users/zoechi/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-25T10:48:27Z","updated_at":"2015-09-25T17:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07c40cb5f26571df5d32ac65a39a45d35cd5b65b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63/commits","review_comments_url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63/comments","review_comment_url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/polymer_elements/issues/63/comments","statuses_url":"https://api.github.com/repos/dart-lang/polymer_elements/statuses/dc146745b2683e3e811cf9f65517bcf4a8cdf7fe","head":{"label":"bwu-dart-contributing:demo2","ref":"demo2","sha":"dc146745b2683e3e811cf9f65517bcf4a8cdf7fe","user":{"login":"bwu-dart-contributing","id":12327325,"avatar_url":"https://avatars.githubusercontent.com/u/12327325?v=3","gravatar_id":"","url":"https://api.github.com/users/bwu-dart-contributing","html_url":"https://github.com/bwu-dart-contributing","followers_url":"https://api.github.com/users/bwu-dart-contributing/followers","following_url":"https://api.github.com/users/bwu-dart-contributing/following{/other_user}","gists_url":"https://api.github.com/users/bwu-dart-contributing/gists{/gist_id}","starred_url":"https://api.github.com/users/bwu-dart-contributing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwu-dart-contributing/subscriptions","organizations_url":"https://api.github.com/users/bwu-dart-contributing/orgs","repos_url":"https://api.github.com/users/bwu-dart-contributing/repos","events_url":"https://api.github.com/users/bwu-dart-contributing/events{/privacy}","received_events_url":"https://api.github.com/users/bwu-dart-contributing/received_events","type":"Organization","site_admin":false},"repo":{"id":43023007,"name":"polymer_elements","full_name":"bwu-dart-contributing/polymer_elements","owner":{"login":"bwu-dart-contributing","id":12327325,"avatar_url":"https://avatars.githubusercontent.com/u/12327325?v=3","gravatar_id":"","url":"https://api.github.com/users/bwu-dart-contributing","html_url":"https://github.com/bwu-dart-contributing","followers_url":"https://api.github.com/users/bwu-dart-contributing/followers","following_url":"https://api.github.com/users/bwu-dart-contributing/following{/other_user}","gists_url":"https://api.github.com/users/bwu-dart-contributing/gists{/gist_id}","starred_url":"https://api.github.com/users/bwu-dart-contributing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwu-dart-contributing/subscriptions","organizations_url":"https://api.github.com/users/bwu-dart-contributing/orgs","repos_url":"https://api.github.com/users/bwu-dart-contributing/repos","events_url":"https://api.github.com/users/bwu-dart-contributing/events{/privacy}","received_events_url":"https://api.github.com/users/bwu-dart-contributing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bwu-dart-contributing/polymer_elements","description":"","fork":true,"url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements","forks_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/forks","keys_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/teams","hooks_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/hooks","issue_events_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/issues/events{/number}","events_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/events","assignees_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/assignees{/user}","branches_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/branches{/branch}","tags_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/tags","blobs_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/statuses/{sha}","languages_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/languages","stargazers_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/stargazers","contributors_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/contributors","subscribers_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/subscribers","subscription_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/subscription","commits_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/contents/{+path}","compare_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/merges","archive_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/downloads","issues_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/issues{/number}","pulls_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/pulls{/number}","milestones_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/milestones{/number}","notifications_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/labels{/name}","releases_url":"https://api.github.com/repos/bwu-dart-contributing/polymer_elements/releases{/id}","created_at":"2015-09-23T19:45:54Z","updated_at":"2015-09-23T19:45:57Z","pushed_at":"2015-09-25T12:23:24Z","git_url":"git://github.com/bwu-dart-contributing/polymer_elements.git","ssh_url":"git@github.com:bwu-dart-contributing/polymer_elements.git","clone_url":"https://github.com/bwu-dart-contributing/polymer_elements.git","svn_url":"https://github.com/bwu-dart-contributing/polymer_elements","homepage":null,"size":3615,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"593a6a30e40584ae672b26174e372c16127d5a18","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":40261353,"name":"polymer_elements","full_name":"dart-lang/polymer_elements","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/polymer_elements","description":"","fork":false,"url":"https://api.github.com/repos/dart-lang/polymer_elements","forks_url":"https://api.github.com/repos/dart-lang/polymer_elements/forks","keys_url":"https://api.github.com/repos/dart-lang/polymer_elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/polymer_elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/polymer_elements/teams","hooks_url":"https://api.github.com/repos/dart-lang/polymer_elements/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/polymer_elements/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/polymer_elements/events","assignees_url":"https://api.github.com/repos/dart-lang/polymer_elements/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/polymer_elements/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/polymer_elements/tags","blobs_url":"https://api.github.com/repos/dart-lang/polymer_elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/polymer_elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/polymer_elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/polymer_elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/polymer_elements/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/polymer_elements/languages","stargazers_url":"https://api.github.com/repos/dart-lang/polymer_elements/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/polymer_elements/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/polymer_elements/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/polymer_elements/subscription","commits_url":"https://api.github.com/repos/dart-lang/polymer_elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/polymer_elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/polymer_elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/polymer_elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/polymer_elements/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/polymer_elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/polymer_elements/merges","archive_url":"https://api.github.com/repos/dart-lang/polymer_elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/polymer_elements/downloads","issues_url":"https://api.github.com/repos/dart-lang/polymer_elements/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/polymer_elements/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/polymer_elements/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/polymer_elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/polymer_elements/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/polymer_elements/releases{/id}","created_at":"2015-08-05T18:11:50Z","updated_at":"2015-09-15T16:03:19Z","pushed_at":"2015-09-25T12:23:24Z","git_url":"git://github.com/dart-lang/polymer_elements.git","ssh_url":"git@github.com:dart-lang/polymer_elements.git","clone_url":"https://github.com/dart-lang/polymer_elements.git","svn_url":"https://github.com/dart-lang/polymer_elements","homepage":null,"size":3959,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":18,"forks":6,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63"},"html":{"href":"https://github.com/dart-lang/polymer_elements/pull/63"},"issue":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/issues/63"},"comments":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/polymer_elements/statuses/dc146745b2683e3e811cf9f65517bcf4a8cdf7fe"}}}}