{"action":"created","comment":{"url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/comments/44441397","id":44441397,"diff_hunk":"@@ -98,4 +98,41 @@ describe('filters', function() {\n       expect(challengeLinksFilter(_ch, 'registrants')).to.be.equal('https://community.'+domain+'/longcontest/?module=ViewStandings&rd=3');\n     });\n   });\n+\n+  describe('externalLinkColorFilter', function() {\n+    \n+    it('should handle twitter and linkedin correctly', function() {\n+      expect(externalLinkColorFilter('el-twitter')).to.be.equal('#62AADC');\n+      expect(externalLinkColorFilter('el-linkedin')).to.be.equal('#127CB5');\n+    });\n+  });\n+\n+  describe('emptyFilter', function() {\n+    it('should handle empty stuff correctly', function() {\n+      var a = emptyFilter(0);\n+      var b = emptyFilter(12);\n+      var c = emptyFilter(false);\n+      var d = emptyFilter(NaN);\n+      var e = emptyFilter('NaN');\n+      var f = emptyFilter('');\n+      var g = emptyFilter('%');\n+      expect(a).to.be.equal(0);\n+      expect(b).to.be.equal(12);\n+      expect(c).to.be.equal('-');\n+      expect(d).to.be.equal('-');\n+      expect(e).to.be.equal('-');\n+      expect(f).to.be.equal('-');\n+      expect(g).to.be.equal('-');\n+    });\n+  });\n+\n+  describe('iifFilter', function() {","path":"app/filters/filters.spec.js","position":41,"original_position":41,"commit_id":"c820807797e0237820b0594fa8a359515756d9ea","original_commit_id":"c820807797e0237820b0594fa8a359515756d9ea","user":{"login":"nlitwin","id":5829188,"avatar_url":"https://avatars.githubusercontent.com/u/5829188?v=3","gravatar_id":"","url":"https://api.github.com/users/nlitwin","html_url":"https://github.com/nlitwin","followers_url":"https://api.github.com/users/nlitwin/followers","following_url":"https://api.github.com/users/nlitwin/following{/other_user}","gists_url":"https://api.github.com/users/nlitwin/gists{/gist_id}","starred_url":"https://api.github.com/users/nlitwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlitwin/subscriptions","organizations_url":"https://api.github.com/users/nlitwin/orgs","repos_url":"https://api.github.com/users/nlitwin/repos","events_url":"https://api.github.com/users/nlitwin/events{/privacy}","received_events_url":"https://api.github.com/users/nlitwin/received_events","type":"User","site_admin":false},"body":"It took me a bit to figure out what iif meant. Should we name it something like ternary operator to avoid the acronym?","created_at":"2015-11-10T18:05:49Z","updated_at":"2015-11-10T18:05:49Z","html_url":"https://github.com/appirio-tech/topcoder-app/pull/545#discussion_r44441397","pull_request_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545","_links":{"self":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/comments/44441397"},"html":{"href":"https://github.com/appirio-tech/topcoder-app/pull/545#discussion_r44441397"},"pull_request":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545"}}},"pull_request":{"url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545","id":50213921,"html_url":"https://github.com/appirio-tech/topcoder-app/pull/545","diff_url":"https://github.com/appirio-tech/topcoder-app/pull/545.diff","patch_url":"https://github.com/appirio-tech/topcoder-app/pull/545.patch","issue_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/545","number":545,"state":"open","locked":false,"title":"buncha new tests","user":{"login":"tladendo","id":1618768,"avatar_url":"https://avatars.githubusercontent.com/u/1618768?v=3","gravatar_id":"","url":"https://api.github.com/users/tladendo","html_url":"https://github.com/tladendo","followers_url":"https://api.github.com/users/tladendo/followers","following_url":"https://api.github.com/users/tladendo/following{/other_user}","gists_url":"https://api.github.com/users/tladendo/gists{/gist_id}","starred_url":"https://api.github.com/users/tladendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tladendo/subscriptions","organizations_url":"https://api.github.com/users/tladendo/orgs","repos_url":"https://api.github.com/users/tladendo/repos","events_url":"https://api.github.com/users/tladendo/events{/privacy}","received_events_url":"https://api.github.com/users/tladendo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-10T04:45:53Z","updated_at":"2015-11-10T18:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"022a4e0ee7c80e8c0571f41356777b1a04cd8103","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545/commits","review_comments_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545/comments","review_comment_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/545/comments","statuses_url":"https://api.github.com/repos/appirio-tech/topcoder-app/statuses/c820807797e0237820b0594fa8a359515756d9ea","head":{"label":"appirio-tech:feature/SUP-1286","ref":"feature/SUP-1286","sha":"c820807797e0237820b0594fa8a359515756d9ea","user":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=3","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":37817999,"name":"topcoder-app","full_name":"appirio-tech/topcoder-app","owner":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=3","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appirio-tech/topcoder-app","description":"Topcoder-App is the new version of tc-site, where all new or imported Angular apps on topcoder live.","fork":false,"url":"https://api.github.com/repos/appirio-tech/topcoder-app","forks_url":"https://api.github.com/repos/appirio-tech/topcoder-app/forks","keys_url":"https://api.github.com/repos/appirio-tech/topcoder-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appirio-tech/topcoder-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appirio-tech/topcoder-app/teams","hooks_url":"https://api.github.com/repos/appirio-tech/topcoder-app/hooks","issue_events_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/events{/number}","events_url":"https://api.github.com/repos/appirio-tech/topcoder-app/events","assignees_url":"https://api.github.com/repos/appirio-tech/topcoder-app/assignees{/user}","branches_url":"https://api.github.com/repos/appirio-tech/topcoder-app/branches{/branch}","tags_url":"https://api.github.com/repos/appirio-tech/topcoder-app/tags","blobs_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appirio-tech/topcoder-app/statuses/{sha}","languages_url":"https://api.github.com/repos/appirio-tech/topcoder-app/languages","stargazers_url":"https://api.github.com/repos/appirio-tech/topcoder-app/stargazers","contributors_url":"https://api.github.com/repos/appirio-tech/topcoder-app/contributors","subscribers_url":"https://api.github.com/repos/appirio-tech/topcoder-app/subscribers","subscription_url":"https://api.github.com/repos/appirio-tech/topcoder-app/subscription","commits_url":"https://api.github.com/repos/appirio-tech/topcoder-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/appirio-tech/topcoder-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/appirio-tech/topcoder-app/contents/{+path}","compare_url":"https://api.github.com/repos/appirio-tech/topcoder-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appirio-tech/topcoder-app/merges","archive_url":"https://api.github.com/repos/appirio-tech/topcoder-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appirio-tech/topcoder-app/downloads","issues_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues{/number}","pulls_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls{/number}","milestones_url":"https://api.github.com/repos/appirio-tech/topcoder-app/milestones{/number}","notifications_url":"https://api.github.com/repos/appirio-tech/topcoder-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appirio-tech/topcoder-app/labels{/name}","releases_url":"https://api.github.com/repos/appirio-tech/topcoder-app/releases{/id}","created_at":"2015-06-21T17:19:05Z","updated_at":"2015-10-24T17:43:00Z","pushed_at":"2015-11-10T16:14:28Z","git_url":"git://github.com/appirio-tech/topcoder-app.git","ssh_url":"git@github.com:appirio-tech/topcoder-app.git","clone_url":"https://github.com/appirio-tech/topcoder-app.git","svn_url":"https://github.com/appirio-tech/topcoder-app","homepage":"","size":14678,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":5,"default_branch":"dev"}},"base":{"label":"appirio-tech:dev","ref":"dev","sha":"f3aae7865cf948f9c3ce2071f875f9bc70681a4b","user":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=3","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":37817999,"name":"topcoder-app","full_name":"appirio-tech/topcoder-app","owner":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=3","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appirio-tech/topcoder-app","description":"Topcoder-App is the new version of tc-site, where all new or imported Angular apps on topcoder live.","fork":false,"url":"https://api.github.com/repos/appirio-tech/topcoder-app","forks_url":"https://api.github.com/repos/appirio-tech/topcoder-app/forks","keys_url":"https://api.github.com/repos/appirio-tech/topcoder-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appirio-tech/topcoder-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appirio-tech/topcoder-app/teams","hooks_url":"https://api.github.com/repos/appirio-tech/topcoder-app/hooks","issue_events_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/events{/number}","events_url":"https://api.github.com/repos/appirio-tech/topcoder-app/events","assignees_url":"https://api.github.com/repos/appirio-tech/topcoder-app/assignees{/user}","branches_url":"https://api.github.com/repos/appirio-tech/topcoder-app/branches{/branch}","tags_url":"https://api.github.com/repos/appirio-tech/topcoder-app/tags","blobs_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appirio-tech/topcoder-app/statuses/{sha}","languages_url":"https://api.github.com/repos/appirio-tech/topcoder-app/languages","stargazers_url":"https://api.github.com/repos/appirio-tech/topcoder-app/stargazers","contributors_url":"https://api.github.com/repos/appirio-tech/topcoder-app/contributors","subscribers_url":"https://api.github.com/repos/appirio-tech/topcoder-app/subscribers","subscription_url":"https://api.github.com/repos/appirio-tech/topcoder-app/subscription","commits_url":"https://api.github.com/repos/appirio-tech/topcoder-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/appirio-tech/topcoder-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/appirio-tech/topcoder-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/appirio-tech/topcoder-app/contents/{+path}","compare_url":"https://api.github.com/repos/appirio-tech/topcoder-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appirio-tech/topcoder-app/merges","archive_url":"https://api.github.com/repos/appirio-tech/topcoder-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appirio-tech/topcoder-app/downloads","issues_url":"https://api.github.com/repos/appirio-tech/topcoder-app/issues{/number}","pulls_url":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls{/number}","milestones_url":"https://api.github.com/repos/appirio-tech/topcoder-app/milestones{/number}","notifications_url":"https://api.github.com/repos/appirio-tech/topcoder-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appirio-tech/topcoder-app/labels{/name}","releases_url":"https://api.github.com/repos/appirio-tech/topcoder-app/releases{/id}","created_at":"2015-06-21T17:19:05Z","updated_at":"2015-10-24T17:43:00Z","pushed_at":"2015-11-10T16:14:28Z","git_url":"git://github.com/appirio-tech/topcoder-app.git","ssh_url":"git@github.com:appirio-tech/topcoder-app.git","clone_url":"https://github.com/appirio-tech/topcoder-app.git","svn_url":"https://github.com/appirio-tech/topcoder-app","homepage":"","size":14678,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":5,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545"},"html":{"href":"https://github.com/appirio-tech/topcoder-app/pull/545"},"issue":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/545"},"comments":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/issues/545/comments"},"review_comments":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545/comments"},"review_comment":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/pulls/545/commits"},"statuses":{"href":"https://api.github.com/repos/appirio-tech/topcoder-app/statuses/c820807797e0237820b0594fa8a359515756d9ea"}}}}