{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/14618","labels_url":"https://api.github.com/repos/owncloud/core/issues/14618/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/14618/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/14618/events","html_url":"https://github.com/owncloud/core/pull/14618","id":59397617,"number":14618,"title":"[WIP] Check checksum of all files of a app when installing it","user":{"login":"LEDfan","id":2996275,"avatar_url":"https://avatars.githubusercontent.com/u/2996275?v=3","gravatar_id":"","url":"https://api.github.com/users/LEDfan","html_url":"https://github.com/LEDfan","followers_url":"https://api.github.com/users/LEDfan/followers","following_url":"https://api.github.com/users/LEDfan/following{/other_user}","gists_url":"https://api.github.com/users/LEDfan/gists{/gist_id}","starred_url":"https://api.github.com/users/LEDfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEDfan/subscriptions","organizations_url":"https://api.github.com/users/LEDfan/orgs","repos_url":"https://api.github.com/users/LEDfan/repos","events_url":"https://api.github.com/users/LEDfan/events{/privacy}","received_events_url":"https://api.github.com/users/LEDfan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-next","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-next","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":475,"closed_issues":1,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-05-21T15:44:50Z","due_on":null,"closed_at":null},"comments":29,"created_at":"2015-03-01T14:24:01Z","updated_at":"2015-05-22T07:03:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/14618","html_url":"https://github.com/owncloud/core/pull/14618","diff_url":"https://github.com/owncloud/core/pull/14618.diff","patch_url":"https://github.com/owncloud/core/pull/14618.patch"},"body":"Refs  #14616\r\nThis currently works when:\r\n - enabling an app via the web interface\r\n - enabling an app via the CLI\r\n - when the app is available on the filesystem\r\n - or when the app is downloaded via the AppStore ~~(not sure if so. I'll upload an app to the appstore which should fail when installing)~~ I checked this. The checksums are checked.\r\n - and when it has never been installed before (so the SQL tables aren't in the DB and in the oc_appconfig table)\r\n\r\ncc @Raydiation @LukasReschke\r\n\r\n(please also review the error messages)\r\nTODO:\r\n - [ ] documentation for developers\r\n - [ ] documentation for end-users and administrators\r\n - [ ] improve errors\r\n - [ ] log when there is no checksum.json file\r\n - [x] also call the checksum stuff in the updateApp method\r\n - [ ] replace copyr with rename\r\n - [ ] add unit tests"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/104542154","html_url":"https://github.com/owncloud/core/pull/14618#issuecomment-104542154","issue_url":"https://api.github.com/repos/owncloud/core/issues/14618","id":104542154,"user":{"login":"Raydiation","id":195053,"avatar_url":"https://avatars.githubusercontent.com/u/195053?v=3","gravatar_id":"","url":"https://api.github.com/users/Raydiation","html_url":"https://github.com/Raydiation","followers_url":"https://api.github.com/users/Raydiation/followers","following_url":"https://api.github.com/users/Raydiation/following{/other_user}","gists_url":"https://api.github.com/users/Raydiation/gists{/gist_id}","starred_url":"https://api.github.com/users/Raydiation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raydiation/subscriptions","organizations_url":"https://api.github.com/users/Raydiation/orgs","repos_url":"https://api.github.com/users/Raydiation/repos","events_url":"https://api.github.com/users/Raydiation/events{/privacy}","received_events_url":"https://api.github.com/users/Raydiation/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T07:03:03Z","updated_at":"2015-05-22T07:03:03Z","body":"@LEDfan something that came to my mind when using it: Maybe its better to use one indentation to be able to add options and other stuff later on, e.g.\r\n\r\n```js\r\n{\r\n    \"checksums\": {\r\n    },\r\n    // etc\r\n}\r\n```"}}