{"action":"created","issue":{"url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/23","labels_url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/23/comments","events_url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/23/events","html_url":"https://github.com/bjornstar/Tumblr-Savior/pull/23","id":67713862,"number":23,"title":"Minor: check_tags option","user":{"login":"Izzette","id":7987724,"avatar_url":"https://avatars.githubusercontent.com/u/7987724?v=3","gravatar_id":"","url":"https://api.github.com/users/Izzette","html_url":"https://github.com/Izzette","followers_url":"https://api.github.com/users/Izzette/followers","following_url":"https://api.github.com/users/Izzette/following{/other_user}","gists_url":"https://api.github.com/users/Izzette/gists{/gist_id}","starred_url":"https://api.github.com/users/Izzette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Izzette/subscriptions","organizations_url":"https://api.github.com/users/Izzette/orgs","repos_url":"https://api.github.com/users/Izzette/repos","events_url":"https://api.github.com/users/Izzette/events{/privacy}","received_events_url":"https://api.github.com/users/Izzette/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-04-11T00:55:30Z","updated_at":"2015-04-11T02:20:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/pulls/23","html_url":"https://github.com/bjornstar/Tumblr-Savior/pull/23","diff_url":"https://github.com/bjornstar/Tumblr-Savior/pull/23.diff","patch_url":"https://github.com/bjornstar/Tumblr-Savior/pull/23.patch"},"body":"### New option—\"Include tags when determining if a post matches something from your black or white lists.\"\r\n- [x] Add boolean ``check_tags`` option\r\n    * Main changes would be made at line **456** of ``data/script.js`` in ``parseSettings(savedSettings)``.\r\n    * These changes would provided greater flexibility on how posts are filtered and increase visibility around filtering of posts by tags.\r\n    * If updated, the extension would keep the old behavior without user modification.  This is because the default value of ``check_tags`` is true.\r\n- [x] Check for missing options in local settings on load \r\n    * Changes would be made at line **38** of ``lib/main.js`` in ``parseSettings()``.\r\n    * This would useful if any more options are added in the future, or if (for whatever reason) an option gets removed form the local settings.\r\n    * Checks parsed settings against the default settings.\r\n    * If a key-value pair is missing in the parsed settings, the default pair is appended to parsed settings.\r\n    * Upon completion of the loop, if changes were made, local settings are updated to match the corrected parsed settings.\r\n- [ ] Check for deprecated settings on load\r\n    * Just like checking for missing options, any deprecated settings (past or future) could be removed on parsing.\r\n    * It would not be necessary in this change, as no settings would become deprecated.  However, I don't see why it shouldn't be done.\r\n- [x] Made minor readability changes\r\n    * They just irked me as I was reading through the source.\r\n- [ ] Tested on Chromium and Google Chrome\r\n    * I found no issues in these browsers.\r\n- [ ] Testing on other browsers and platforms\r\n    * I do not suspect any browser or platform incompatibility issues would be introduced with this change."},"comment":{"url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/comments/91743819","html_url":"https://github.com/bjornstar/Tumblr-Savior/pull/23#issuecomment-91743819","issue_url":"https://api.github.com/repos/bjornstar/Tumblr-Savior/issues/23","id":91743819,"user":{"login":"Izzette","id":7987724,"avatar_url":"https://avatars.githubusercontent.com/u/7987724?v=3","gravatar_id":"","url":"https://api.github.com/users/Izzette","html_url":"https://github.com/Izzette","followers_url":"https://api.github.com/users/Izzette/followers","following_url":"https://api.github.com/users/Izzette/following{/other_user}","gists_url":"https://api.github.com/users/Izzette/gists{/gist_id}","starred_url":"https://api.github.com/users/Izzette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Izzette/subscriptions","organizations_url":"https://api.github.com/users/Izzette/orgs","repos_url":"https://api.github.com/users/Izzette/repos","events_url":"https://api.github.com/users/Izzette/events{/privacy}","received_events_url":"https://api.github.com/users/Izzette/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T02:20:03Z","updated_at":"2015-04-11T02:20:03Z","body":"wait, something happend"}}