{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/33247334","id":33247334,"diff_hunk":"@@ -0,0 +1,47 @@\n+﻿#region Copyright & License Information\n+/*\n+ * Copyright 2007-2015 The OpenRA Developers (see AUTHORS)\n+ * This file is part of OpenRA, which is free software. It is made\n+ * available to you under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation. For more information,\n+ * see COPYING.\n+ */\n+#endregion\n+\n+using OpenRA.Traits;\n+\n+namespace OpenRA.Mods.Common.Traits\n+{\n+\t[Desc(\"Actors possessing this trait should define the GainsExperience trait beforehand. When the prerequisites are fulfilled, \",","path":"OpenRA.Mods.Common/Traits/LevelupWhenCreated.cs","position":15,"original_position":15,"commit_id":"bc05097898502fbe0f9716562248bee069b43cbd","original_commit_id":"bc05097898502fbe0f9716562248bee069b43cbd","user":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"body":"Answered by @pchote in IRC.","created_at":"2015-06-25T12:07:18Z","updated_at":"2015-06-25T12:07:18Z","html_url":"https://github.com/OpenRA/OpenRA/pull/8210#discussion_r33247334","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/33247334"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8210#discussion_r33247334"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210","id":35964999,"html_url":"https://github.com/OpenRA/OpenRA/pull/8210","diff_url":"https://github.com/OpenRA/OpenRA/pull/8210.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/8210.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8210","number":8210,"state":"open","locked":false,"title":"Veteran unit production & unlocking through spies.","user":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"body":"A stab at #7585.\r\n\r\n~~Sample veteran unit (E1.upgraded) is defined (using GainsExperience trait, InitialExperience property) and its production made available through tech tree prerequisite (barracks.upgraded under Player.ProvidesPrerequisite (1)) that is normally disabled. The prerequisite gets enabled when a spy infiltrates the appropriate building (BARR or TENT) that has the InfiltrateForUpgrade trait which references the prerequisite trait definition (1) under Player.~~\r\n\r\n~~In case the idea is OK, I'd remove the yaml entries and the improvised cameo, leaving just the logic, until the upgraded units' cameos are all available.~~\r\n\r\nThis PR basically introduces three things.\r\n* Upgrading icons in the production queue.\r\n* Spawning upgraded units.\r\n* Triggering both these upgrades with spies.","created_at":"2015-05-21T18:48:23Z","updated_at":"2015-06-25T12:07:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dccb605230b0b48b0af630f3f1c973e5ba91c806","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8210/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/bc05097898502fbe0f9716562248bee069b43cbd","head":{"label":"matija-hustic:ra2_veterancy_icon","ref":"ra2_veterancy_icon","sha":"bc05097898502fbe0f9716562248bee069b43cbd","user":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"repo":{"id":19147701,"name":"OpenRA","full_name":"matija-hustic/OpenRA","owner":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matija-hustic/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/matija-hustic/OpenRA","forks_url":"https://api.github.com/repos/matija-hustic/OpenRA/forks","keys_url":"https://api.github.com/repos/matija-hustic/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matija-hustic/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matija-hustic/OpenRA/teams","hooks_url":"https://api.github.com/repos/matija-hustic/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/matija-hustic/OpenRA/events","assignees_url":"https://api.github.com/repos/matija-hustic/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/matija-hustic/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/matija-hustic/OpenRA/tags","blobs_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matija-hustic/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/matija-hustic/OpenRA/languages","stargazers_url":"https://api.github.com/repos/matija-hustic/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/matija-hustic/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/matija-hustic/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/matija-hustic/OpenRA/subscription","commits_url":"https://api.github.com/repos/matija-hustic/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/matija-hustic/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/matija-hustic/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/matija-hustic/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matija-hustic/OpenRA/merges","archive_url":"https://api.github.com/repos/matija-hustic/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matija-hustic/OpenRA/downloads","issues_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/matija-hustic/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/matija-hustic/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/matija-hustic/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matija-hustic/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/matija-hustic/OpenRA/releases{/id}","created_at":"2014-04-25T13:51:56Z","updated_at":"2015-04-28T22:34:07Z","pushed_at":"2015-06-21T19:15:08Z","git_url":"git://github.com/matija-hustic/OpenRA.git","ssh_url":"git@github.com:matija-hustic/OpenRA.git","clone_url":"https://github.com/matija-hustic/OpenRA.git","svn_url":"https://github.com/matija-hustic/OpenRA","homepage":"http://open-ra.org","size":89469,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"01cda29eef961961f124d740dc92f8fa1952f023","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-06-24T22:38:50Z","pushed_at":"2015-06-25T11:08:09Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":179321,"stargazers_count":1979,"watchers_count":1979,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":712,"mirror_url":null,"open_issues_count":809,"forks":712,"open_issues":809,"watchers":1979,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8210"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8210"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8210/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8210/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/bc05097898502fbe0f9716562248bee069b43cbd"}}}}