{"comment":{"url":"https://api.github.com/repos/inanhkn/analysis/comments/9489501","html_url":"https://github.com/inanhkn/analysis/commit/01711a6fe2d0464bb1258c612439ad2eb42b1db3#commitcomment-9489501","id":9489501,"user":{"login":"jmaxey","id":7634264,"avatar_url":"https://avatars.githubusercontent.com/u/7634264?v=3","gravatar_id":"","url":"https://api.github.com/users/jmaxey","html_url":"https://github.com/jmaxey","followers_url":"https://api.github.com/users/jmaxey/followers","following_url":"https://api.github.com/users/jmaxey/following{/other_user}","gists_url":"https://api.github.com/users/jmaxey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmaxey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmaxey/subscriptions","organizations_url":"https://api.github.com/users/jmaxey/orgs","repos_url":"https://api.github.com/users/jmaxey/repos","events_url":"https://api.github.com/users/jmaxey/events{/privacy}","received_events_url":"https://api.github.com/users/jmaxey/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"01711a6fe2d0464bb1258c612439ad2eb42b1db3","created_at":"2015-01-28T23:44:49Z","updated_at":"2015-01-28T23:44:49Z","body":"The only other thing I would recommend for the write function (depending on how you see the function used) would be to generalize the size of the dataset. With the way it is now, you would not be able to append something to the dataset later on. I would instead use:\n\nh5create(filename,dataset,[Inf,Inf,Inf],'ChunkSize',chunkSize,'DatasetType',...);\n\nWith this change you would also need to change the write line:\n\nh5write(filename,dataset,movie,[1,1,1],[height,width,num_frames]);\n\nFor the default dataset name, that works for now! If we decide to have a different file structure, then we could change it to what the base directory is.\n\n----- Original Message -----\nFrom: \"Tony\" <notifications@github.com>\nTo: \"inanhkn/analysis\" <analysis@noreply.github.com>\nCc: \"jmaxey\" <jmaxey@stanford.edu>\nSent: Wednesday, January 28, 2015 3:37:19 PM\nSubject: Re: [analysis] Generic save and load of movies from HDF5 (01711a6)\n\nI agree on the dataset being an input parameter for both load and save functions. I'll make the change.\n\nIn this case, when we're opening only one file, I'd prefer not having to segregate the output directory and the name. (I think the only case where we require a directory was to the folder containing all the XML/TIF recordings.) I find it cumbersome to have to provide multiple parameters to a function, unless necessary.\n\n---\nReply to this email directly or view it on GitHub:\nhttps://github.com/inanhkn/analysis/commit/01711a6fe2d0464bb1258c612439ad2eb42b1db3#commitcomment-9489416"}}