{"action":"created","issue":{"url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/58","labels_url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/58/comments","events_url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/58/events","html_url":"https://github.com/cs4278-2015/assignment2-handin/pull/58","id":105391061,"number":58,"title":"Review/connormcgowan/michaelbassett","user":{"login":"bassettmb","id":5882507,"avatar_url":"https://avatars.githubusercontent.com/u/5882507?v=3","gravatar_id":"","url":"https://api.github.com/users/bassettmb","html_url":"https://github.com/bassettmb","followers_url":"https://api.github.com/users/bassettmb/followers","following_url":"https://api.github.com/users/bassettmb/following{/other_user}","gists_url":"https://api.github.com/users/bassettmb/gists{/gist_id}","starred_url":"https://api.github.com/users/bassettmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassettmb/subscriptions","organizations_url":"https://api.github.com/users/bassettmb/orgs","repos_url":"https://api.github.com/users/bassettmb/repos","events_url":"https://api.github.com/users/bassettmb/events{/privacy}","received_events_url":"https://api.github.com/users/bassettmb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-08T14:18:45Z","updated_at":"2015-09-15T05:08:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/pulls/58","html_url":"https://github.com/cs4278-2015/assignment2-handin/pull/58","diff_url":"https://github.com/cs4278-2015/assignment2-handin/pull/58.diff","patch_url":"https://github.com/cs4278-2015/assignment2-handin/pull/58.patch"},"body":"- Replace manual path catenation with node.js path module function.\r\n- Inline counter function in version checker.\r\n- Replace _.each with _.filter.\r\n\r\nAdditionally, I would recommend rethinking the structure of the batch versions of version management functions in order to minimize disk reads since currently there are a lot of redundant accesses that could be pipelined into a single read. Also, some comments explaining the code would be nice, although it is very clear already."},"comment":{"url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/comments/140284297","html_url":"https://github.com/cs4278-2015/assignment2-handin/pull/58#issuecomment-140284297","issue_url":"https://api.github.com/repos/cs4278-2015/assignment2-handin/issues/58","id":140284297,"user":{"login":"mcgowacr","id":8533914,"avatar_url":"https://avatars.githubusercontent.com/u/8533914?v=3","gravatar_id":"","url":"https://api.github.com/users/mcgowacr","html_url":"https://github.com/mcgowacr","followers_url":"https://api.github.com/users/mcgowacr/followers","following_url":"https://api.github.com/users/mcgowacr/following{/other_user}","gists_url":"https://api.github.com/users/mcgowacr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgowacr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgowacr/subscriptions","organizations_url":"https://api.github.com/users/mcgowacr/orgs","repos_url":"https://api.github.com/users/mcgowacr/repos","events_url":"https://api.github.com/users/mcgowacr/events{/privacy}","received_events_url":"https://api.github.com/users/mcgowacr/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T05:08:21Z","updated_at":"2015-09-15T05:08:21Z","body":"The first two commits are good changes, and I like the idea behind the third. However, the current implementation of the change in commit 830d1fe breaks the code in the module. Since pull requests seem to be all or nothing, I can't just use the first two changes and leave the third. As such, I have to reject this pull request and make the relevant changes on my own in the next iteration of the project."}}