{"action":"created","issue":{"url":"https://api.github.com/repos/scopely-devops/skew/issues/75","labels_url":"https://api.github.com/repos/scopely-devops/skew/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/scopely-devops/skew/issues/75/comments","events_url":"https://api.github.com/repos/scopely-devops/skew/issues/75/events","html_url":"https://github.com/scopely-devops/skew/pull/75","id":122927318,"number":75,"title":"Work In Progress: Threadsafe credential handling","user":{"login":"larsbutler","id":464394,"avatar_url":"https://avatars.githubusercontent.com/u/464394?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbutler","html_url":"https://github.com/larsbutler","followers_url":"https://api.github.com/users/larsbutler/followers","following_url":"https://api.github.com/users/larsbutler/following{/other_user}","gists_url":"https://api.github.com/users/larsbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbutler/subscriptions","organizations_url":"https://api.github.com/users/larsbutler/orgs","repos_url":"https://api.github.com/users/larsbutler/repos","events_url":"https://api.github.com/users/larsbutler/events{/privacy}","received_events_url":"https://api.github.com/users/larsbutler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-12-18T10:56:33Z","updated_at":"2016-01-01T17:47:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scopely-devops/skew/pulls/75","html_url":"https://github.com/scopely-devops/skew/pull/75","diff_url":"https://github.com/scopely-devops/skew/pull/75.diff","patch_url":"https://github.com/scopely-devops/skew/pull/75.patch"},"body":"The global credential cache introduced in a [recent patch](https://github.com/josh-paul/skew/commit/ea86cdf4a0e3e492fe91d168f9934021ceba75cc) has proven to be problematic in a multi-threaded environment. We've seen cached credentials get leaked across thread boundaries, resulting in spurious errors.\r\n\r\nThis patch is an attempt to explicitly pass credentials programmatically but avoid using a global var for storing the credentials. I haven't spent much time on this so far, and wanted to get some feedback before I invest more time in it. Let me know what you think."},"comment":{"url":"https://api.github.com/repos/scopely-devops/skew/issues/comments/168320678","html_url":"https://github.com/scopely-devops/skew/pull/75#issuecomment-168320678","issue_url":"https://api.github.com/repos/scopely-devops/skew/issues/75","id":168320678,"user":{"login":"larsbutler","id":464394,"avatar_url":"https://avatars.githubusercontent.com/u/464394?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbutler","html_url":"https://github.com/larsbutler","followers_url":"https://api.github.com/users/larsbutler/followers","following_url":"https://api.github.com/users/larsbutler/following{/other_user}","gists_url":"https://api.github.com/users/larsbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbutler/subscriptions","organizations_url":"https://api.github.com/users/larsbutler/orgs","repos_url":"https://api.github.com/users/larsbutler/repos","events_url":"https://api.github.com/users/larsbutler/events{/privacy}","received_events_url":"https://api.github.com/users/larsbutler/received_events","type":"User","site_admin":false},"created_at":"2016-01-01T17:47:45Z","updated_at":"2016-01-01T17:47:45Z","body":"> Or, actually, if you want to remove it in this PR, that would be fine, too.\r\n\r\nGo head and remove it if you have the time--otherwise, I'll follow up with a patch later and take care of it. :) I'm not on my dev box at the moment, so it will be a little while til I can work on it."}}