{"action":"created","issue":{"url":"https://api.github.com/repos/square/wire/issues/208","labels_url":"https://api.github.com/repos/square/wire/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/square/wire/issues/208/comments","events_url":"https://api.github.com/repos/square/wire/issues/208/events","html_url":"https://github.com/square/wire/pull/208","id":88569319,"number":208,"title":"Drop the oneof choice enum.","user":{"login":"swankjesse","id":133019,"avatar_url":"https://avatars.githubusercontent.com/u/133019?v=3","gravatar_id":"","url":"https://api.github.com/users/swankjesse","html_url":"https://github.com/swankjesse","followers_url":"https://api.github.com/users/swankjesse/followers","following_url":"https://api.github.com/users/swankjesse/following{/other_user}","gists_url":"https://api.github.com/users/swankjesse/gists{/gist_id}","starred_url":"https://api.github.com/users/swankjesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swankjesse/subscriptions","organizations_url":"https://api.github.com/users/swankjesse/orgs","repos_url":"https://api.github.com/users/swankjesse/repos","events_url":"https://api.github.com/users/swankjesse/events{/privacy}","received_events_url":"https://api.github.com/users/swankjesse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-15T23:43:43Z","updated_at":"2015-06-16T12:16:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/wire/pulls/208","html_url":"https://github.com/square/wire/pull/208","diff_url":"https://github.com/square/wire/pull/208.diff","patch_url":"https://github.com/square/wire/pull/208.patch"},"body":"It is particularly weird in JSON encoding, since it may be\r\neither absent or redundant.\r\n\r\nChecking the presence of a oneof with a series of null checks\r\nis simpler and safer."},"comment":{"url":"https://api.github.com/repos/square/wire/issues/comments/112404061","html_url":"https://github.com/square/wire/pull/208#issuecomment-112404061","issue_url":"https://api.github.com/repos/square/wire/issues/208","id":112404061,"user":{"login":"danrice-square","id":1952897,"avatar_url":"https://avatars.githubusercontent.com/u/1952897?v=3","gravatar_id":"","url":"https://api.github.com/users/danrice-square","html_url":"https://github.com/danrice-square","followers_url":"https://api.github.com/users/danrice-square/followers","following_url":"https://api.github.com/users/danrice-square/following{/other_user}","gists_url":"https://api.github.com/users/danrice-square/gists{/gist_id}","starred_url":"https://api.github.com/users/danrice-square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrice-square/subscriptions","organizations_url":"https://api.github.com/users/danrice-square/orgs","repos_url":"https://api.github.com/users/danrice-square/repos","events_url":"https://api.github.com/users/danrice-square/events{/privacy}","received_events_url":"https://api.github.com/users/danrice-square/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T12:16:48Z","updated_at":"2015-06-16T12:16:48Z","body":"If you are trying to accomplish something json-specific, the right place would be in WireGsonConverter. In general you don't want to use a raw Gson instance on a Wire Message.\r\n\r\nOtherwise, I'd be interested in feedback from developers using oneof to see what style they prefer."}}