{"action":"created","issue":{"url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/53","labels_url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/53/comments","events_url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/53/events","html_url":"https://github.com/egeloen/ivory-http-adapter/pull/53","id":52822254,"number":53,"title":"[WIP] Add OAuth2 Subscriber","user":{"login":"jeromegamez","id":67554,"avatar_url":"https://avatars.githubusercontent.com/u/67554?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromegamez","html_url":"https://github.com/jeromegamez","followers_url":"https://api.github.com/users/jeromegamez/followers","following_url":"https://api.github.com/users/jeromegamez/following{/other_user}","gists_url":"https://api.github.com/users/jeromegamez/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromegamez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromegamez/subscriptions","organizations_url":"https://api.github.com/users/jeromegamez/orgs","repos_url":"https://api.github.com/users/jeromegamez/repos","events_url":"https://api.github.com/users/jeromegamez/events{/privacy}","received_events_url":"https://api.github.com/users/jeromegamez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/egeloen/ivory-http-adapter/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-24T14:41:31Z","updated_at":"2015-01-03T14:13:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/egeloen/ivory-http-adapter/pulls/53","html_url":"https://github.com/egeloen/ivory-http-adapter/pull/53","diff_url":"https://github.com/egeloen/ivory-http-adapter/pull/53.diff","patch_url":"https://github.com/egeloen/ivory-http-adapter/pull/53.patch"},"body":"Salut Eric,\r\n\r\nthis is a very rough first implementation of an OAuth2 subscriber, that I've been working on since yesterday. It currently only supports the Authorization Code Grant and the Refresh Token Grant, the PHP Doc is not cleaned up, the subscriber itself is not in place yet, and so on :). At least everything is fully tested!\r\n\r\nI have published the PR already because of two reasons:\r\n- Would you include an OAuth2 subscriber in your HTTP Adapter at all? :) Or would you rather recommend making it a separate extension in a separate repository?\r\n- Either way, if you can look past the obvious stylistic flaws which are in the code at the moment, I would really appreciate your feedback on this.\r\n- ~~And at last, on my machine, the `Ivory\\Event\\OAuth2\\Configuration` class gets no code coverage although the tests are covering it. I wonder if Travis gets it right.~~ _Update: Turns out that `Oauth2` is not the same as `OAuth2` :smile:_\r\n\r\nCheers\r\n:christmas_tree: Jérôme\r\n\r\nPS: I tested the OAuth2 workflow locally and manually with my Spotify account, and it worked great :)."},"comment":{"url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/comments/68596103","html_url":"https://github.com/egeloen/ivory-http-adapter/pull/53#issuecomment-68596103","issue_url":"https://api.github.com/repos/egeloen/ivory-http-adapter/issues/53","id":68596103,"user":{"login":"egeloen","id":737992,"avatar_url":"https://avatars.githubusercontent.com/u/737992?v=3","gravatar_id":"","url":"https://api.github.com/users/egeloen","html_url":"https://github.com/egeloen","followers_url":"https://api.github.com/users/egeloen/followers","following_url":"https://api.github.com/users/egeloen/following{/other_user}","gists_url":"https://api.github.com/users/egeloen/gists{/gist_id}","starred_url":"https://api.github.com/users/egeloen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeloen/subscriptions","organizations_url":"https://api.github.com/users/egeloen/orgs","repos_url":"https://api.github.com/users/egeloen/repos","events_url":"https://api.github.com/users/egeloen/events{/privacy}","received_events_url":"https://api.github.com/users/egeloen/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T14:13:28Z","updated_at":"2015-01-03T14:13:28Z","body":"Can you take a look to https://github.com/widop/twitter-oauth? I don't see something related to signature in your PR."}}