{"action":"closed","number":65,"pull_request":{"url":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65","id":29193874,"html_url":"https://github.com/nvd3-community/nvd3/pull/65","diff_url":"https://github.com/nvd3-community/nvd3/pull/65.diff","patch_url":"https://github.com/nvd3-community/nvd3/pull/65.patch","issue_url":"https://api.github.com/repos/nvd3-community/nvd3/issues/65","number":65,"state":"closed","locked":false,"title":"Fixed DOM iteration when calculating the totalTooltipOffset","user":{"login":"klangfarbe","id":386914,"avatar_url":"https://avatars.githubusercontent.com/u/386914?v=3","gravatar_id":"","url":"https://api.github.com/users/klangfarbe","html_url":"https://github.com/klangfarbe","followers_url":"https://api.github.com/users/klangfarbe/followers","following_url":"https://api.github.com/users/klangfarbe/following{/other_user}","gists_url":"https://api.github.com/users/klangfarbe/gists{/gist_id}","starred_url":"https://api.github.com/users/klangfarbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klangfarbe/subscriptions","organizations_url":"https://api.github.com/users/klangfarbe/orgs","repos_url":"https://api.github.com/users/klangfarbe/repos","events_url":"https://api.github.com/users/klangfarbe/events{/privacy}","received_events_url":"https://api.github.com/users/klangfarbe/received_events","type":"User","site_admin":false},"body":"This fixes an issue which leads to a misplacement of the tooltip in case it is nearby the right or top window border. To make it clear that we are iterating the DOM I decided to put the assignment of the parent node into the loop and check for the element instead of doing it inside the while condition (as it was before).","created_at":"2015-02-12T16:35:39Z","updated_at":"2015-02-16T19:08:35Z","closed_at":"2015-02-16T19:08:35Z","merged_at":"2015-02-16T19:08:35Z","merge_commit_sha":"a44199b155a4a776b00c0125e81fb772b46ae303","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65/commits","review_comments_url":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65/comments","review_comment_url":"https://api.github.com/repos/nvd3-community/nvd3/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nvd3-community/nvd3/issues/65/comments","statuses_url":"https://api.github.com/repos/nvd3-community/nvd3/statuses/44a394d50255f088f7515c3c9461a1591f9a2f58","head":{"label":"klangfarbe:pull_request_fix_tooltipOffsetCalculation","ref":"pull_request_fix_tooltipOffsetCalculation","sha":"44a394d50255f088f7515c3c9461a1591f9a2f58","user":{"login":"klangfarbe","id":386914,"avatar_url":"https://avatars.githubusercontent.com/u/386914?v=3","gravatar_id":"","url":"https://api.github.com/users/klangfarbe","html_url":"https://github.com/klangfarbe","followers_url":"https://api.github.com/users/klangfarbe/followers","following_url":"https://api.github.com/users/klangfarbe/following{/other_user}","gists_url":"https://api.github.com/users/klangfarbe/gists{/gist_id}","starred_url":"https://api.github.com/users/klangfarbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klangfarbe/subscriptions","organizations_url":"https://api.github.com/users/klangfarbe/orgs","repos_url":"https://api.github.com/users/klangfarbe/repos","events_url":"https://api.github.com/users/klangfarbe/events{/privacy}","received_events_url":"https://api.github.com/users/klangfarbe/received_events","type":"User","site_admin":false},"repo":{"id":30242797,"name":"nvd3","full_name":"klangfarbe/nvd3","owner":{"login":"klangfarbe","id":386914,"avatar_url":"https://avatars.githubusercontent.com/u/386914?v=3","gravatar_id":"","url":"https://api.github.com/users/klangfarbe","html_url":"https://github.com/klangfarbe","followers_url":"https://api.github.com/users/klangfarbe/followers","following_url":"https://api.github.com/users/klangfarbe/following{/other_user}","gists_url":"https://api.github.com/users/klangfarbe/gists{/gist_id}","starred_url":"https://api.github.com/users/klangfarbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klangfarbe/subscriptions","organizations_url":"https://api.github.com/users/klangfarbe/orgs","repos_url":"https://api.github.com/users/klangfarbe/repos","events_url":"https://api.github.com/users/klangfarbe/events{/privacy}","received_events_url":"https://api.github.com/users/klangfarbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klangfarbe/nvd3","description":"A reusable chart library for d3.js","fork":true,"url":"https://api.github.com/repos/klangfarbe/nvd3","forks_url":"https://api.github.com/repos/klangfarbe/nvd3/forks","keys_url":"https://api.github.com/repos/klangfarbe/nvd3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klangfarbe/nvd3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klangfarbe/nvd3/teams","hooks_url":"https://api.github.com/repos/klangfarbe/nvd3/hooks","issue_events_url":"https://api.github.com/repos/klangfarbe/nvd3/issues/events{/number}","events_url":"https://api.github.com/repos/klangfarbe/nvd3/events","assignees_url":"https://api.github.com/repos/klangfarbe/nvd3/assignees{/user}","branches_url":"https://api.github.com/repos/klangfarbe/nvd3/branches{/branch}","tags_url":"https://api.github.com/repos/klangfarbe/nvd3/tags","blobs_url":"https://api.github.com/repos/klangfarbe/nvd3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klangfarbe/nvd3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klangfarbe/nvd3/git/refs{/sha}","trees_url":"https://api.github.com/repos/klangfarbe/nvd3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klangfarbe/nvd3/statuses/{sha}","languages_url":"https://api.github.com/repos/klangfarbe/nvd3/languages","stargazers_url":"https://api.github.com/repos/klangfarbe/nvd3/stargazers","contributors_url":"https://api.github.com/repos/klangfarbe/nvd3/contributors","subscribers_url":"https://api.github.com/repos/klangfarbe/nvd3/subscribers","subscription_url":"https://api.github.com/repos/klangfarbe/nvd3/subscription","commits_url":"https://api.github.com/repos/klangfarbe/nvd3/commits{/sha}","git_commits_url":"https://api.github.com/repos/klangfarbe/nvd3/git/commits{/sha}","comments_url":"https://api.github.com/repos/klangfarbe/nvd3/comments{/number}","issue_comment_url":"https://api.github.com/repos/klangfarbe/nvd3/issues/comments/{number}","contents_url":"https://api.github.com/repos/klangfarbe/nvd3/contents/{+path}","compare_url":"https://api.github.com/repos/klangfarbe/nvd3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klangfarbe/nvd3/merges","archive_url":"https://api.github.com/repos/klangfarbe/nvd3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klangfarbe/nvd3/downloads","issues_url":"https://api.github.com/repos/klangfarbe/nvd3/issues{/number}","pulls_url":"https://api.github.com/repos/klangfarbe/nvd3/pulls{/number}","milestones_url":"https://api.github.com/repos/klangfarbe/nvd3/milestones{/number}","notifications_url":"https://api.github.com/repos/klangfarbe/nvd3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klangfarbe/nvd3/labels{/name}","releases_url":"https://api.github.com/repos/klangfarbe/nvd3/releases{/id}","created_at":"2015-02-03T12:59:28Z","updated_at":"2015-02-03T13:29:05Z","pushed_at":"2015-02-12T16:30:33Z","git_url":"git://github.com/klangfarbe/nvd3.git","ssh_url":"git@github.com:klangfarbe/nvd3.git","clone_url":"https://github.com/klangfarbe/nvd3.git","svn_url":"https://github.com/klangfarbe/nvd3","homepage":"http://nvd3-community.github.io/nvd3/","size":9509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nvd3-community:development","ref":"development","sha":"f63afff148a55d78061c881b39217955c279cb88","user":{"login":"nvd3-community","id":10244924,"avatar_url":"https://avatars.githubusercontent.com/u/10244924?v=3","gravatar_id":"","url":"https://api.github.com/users/nvd3-community","html_url":"https://github.com/nvd3-community","followers_url":"https://api.github.com/users/nvd3-community/followers","following_url":"https://api.github.com/users/nvd3-community/following{/other_user}","gists_url":"https://api.github.com/users/nvd3-community/gists{/gist_id}","starred_url":"https://api.github.com/users/nvd3-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvd3-community/subscriptions","organizations_url":"https://api.github.com/users/nvd3-community/orgs","repos_url":"https://api.github.com/users/nvd3-community/repos","events_url":"https://api.github.com/users/nvd3-community/events{/privacy}","received_events_url":"https://api.github.com/users/nvd3-community/received_events","type":"Organization","site_admin":false},"repo":{"id":28253327,"name":"nvd3","full_name":"nvd3-community/nvd3","owner":{"login":"nvd3-community","id":10244924,"avatar_url":"https://avatars.githubusercontent.com/u/10244924?v=3","gravatar_id":"","url":"https://api.github.com/users/nvd3-community","html_url":"https://github.com/nvd3-community","followers_url":"https://api.github.com/users/nvd3-community/followers","following_url":"https://api.github.com/users/nvd3-community/following{/other_user}","gists_url":"https://api.github.com/users/nvd3-community/gists{/gist_id}","starred_url":"https://api.github.com/users/nvd3-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvd3-community/subscriptions","organizations_url":"https://api.github.com/users/nvd3-community/orgs","repos_url":"https://api.github.com/users/nvd3-community/repos","events_url":"https://api.github.com/users/nvd3-community/events{/privacy}","received_events_url":"https://api.github.com/users/nvd3-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvd3-community/nvd3","description":"A reusable chart library for d3.js","fork":true,"url":"https://api.github.com/repos/nvd3-community/nvd3","forks_url":"https://api.github.com/repos/nvd3-community/nvd3/forks","keys_url":"https://api.github.com/repos/nvd3-community/nvd3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvd3-community/nvd3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvd3-community/nvd3/teams","hooks_url":"https://api.github.com/repos/nvd3-community/nvd3/hooks","issue_events_url":"https://api.github.com/repos/nvd3-community/nvd3/issues/events{/number}","events_url":"https://api.github.com/repos/nvd3-community/nvd3/events","assignees_url":"https://api.github.com/repos/nvd3-community/nvd3/assignees{/user}","branches_url":"https://api.github.com/repos/nvd3-community/nvd3/branches{/branch}","tags_url":"https://api.github.com/repos/nvd3-community/nvd3/tags","blobs_url":"https://api.github.com/repos/nvd3-community/nvd3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvd3-community/nvd3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvd3-community/nvd3/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvd3-community/nvd3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvd3-community/nvd3/statuses/{sha}","languages_url":"https://api.github.com/repos/nvd3-community/nvd3/languages","stargazers_url":"https://api.github.com/repos/nvd3-community/nvd3/stargazers","contributors_url":"https://api.github.com/repos/nvd3-community/nvd3/contributors","subscribers_url":"https://api.github.com/repos/nvd3-community/nvd3/subscribers","subscription_url":"https://api.github.com/repos/nvd3-community/nvd3/subscription","commits_url":"https://api.github.com/repos/nvd3-community/nvd3/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvd3-community/nvd3/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvd3-community/nvd3/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvd3-community/nvd3/issues/comments/{number}","contents_url":"https://api.github.com/repos/nvd3-community/nvd3/contents/{+path}","compare_url":"https://api.github.com/repos/nvd3-community/nvd3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvd3-community/nvd3/merges","archive_url":"https://api.github.com/repos/nvd3-community/nvd3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvd3-community/nvd3/downloads","issues_url":"https://api.github.com/repos/nvd3-community/nvd3/issues{/number}","pulls_url":"https://api.github.com/repos/nvd3-community/nvd3/pulls{/number}","milestones_url":"https://api.github.com/repos/nvd3-community/nvd3/milestones{/number}","notifications_url":"https://api.github.com/repos/nvd3-community/nvd3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvd3-community/nvd3/labels{/name}","releases_url":"https://api.github.com/repos/nvd3-community/nvd3/releases{/id}","created_at":"2014-12-20T01:46:41Z","updated_at":"2015-02-13T18:40:13Z","pushed_at":"2015-02-16T19:08:35Z","git_url":"git://github.com/nvd3-community/nvd3.git","ssh_url":"git@github.com:nvd3-community/nvd3.git","clone_url":"https://github.com/nvd3-community/nvd3.git","svn_url":"https://github.com/nvd3-community/nvd3","homepage":"http://nvd3-community.github.io/nvd3/","size":10093,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":14,"forks":29,"open_issues":14,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65"},"html":{"href":"https://github.com/nvd3-community/nvd3/pull/65"},"issue":{"href":"https://api.github.com/repos/nvd3-community/nvd3/issues/65"},"comments":{"href":"https://api.github.com/repos/nvd3-community/nvd3/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/nvd3-community/nvd3/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nvd3-community/nvd3/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/nvd3-community/nvd3/statuses/44a394d50255f088f7515c3c9461a1591f9a2f58"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"liquidpele","id":1065913,"avatar_url":"https://avatars.githubusercontent.com/u/1065913?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidpele","html_url":"https://github.com/liquidpele","followers_url":"https://api.github.com/users/liquidpele/followers","following_url":"https://api.github.com/users/liquidpele/following{/other_user}","gists_url":"https://api.github.com/users/liquidpele/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidpele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidpele/subscriptions","organizations_url":"https://api.github.com/users/liquidpele/orgs","repos_url":"https://api.github.com/users/liquidpele/repos","events_url":"https://api.github.com/users/liquidpele/events{/privacy}","received_events_url":"https://api.github.com/users/liquidpele/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}