{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/johmue/php_excel/pulls/3","id":51201365,"html_url":"https://github.com/johmue/php_excel/pull/3","diff_url":"https://github.com/johmue/php_excel/pull/3.diff","patch_url":"https://github.com/johmue/php_excel/pull/3.patch","issue_url":"https://api.github.com/repos/johmue/php_excel/issues/3","number":3,"state":"open","locked":false,"title":"Fix tests","user":{"login":"pilif","id":4990,"avatar_url":"https://avatars.githubusercontent.com/u/4990?v=3","gravatar_id":"","url":"https://api.github.com/users/pilif","html_url":"https://github.com/pilif","followers_url":"https://api.github.com/users/pilif/followers","following_url":"https://api.github.com/users/pilif/following{/other_user}","gists_url":"https://api.github.com/users/pilif/gists{/gist_id}","starred_url":"https://api.github.com/users/pilif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilif/subscriptions","organizations_url":"https://api.github.com/users/pilif/orgs","repos_url":"https://api.github.com/users/pilif/repos","events_url":"https://api.github.com/users/pilif/events{/privacy}","received_events_url":"https://api.github.com/users/pilif/received_events","type":"User","site_admin":false},"body":"This fixes all the tests that needed fixing. With this (and if you're using a libxl build with source code, then you also need my previous PR) all tests but \r\n\r\n`Excel date pack/unpack tests [tests/002.phpt]`\r\n\r\nI have analyzed that failing test. It fails if `date.timezone` is set to something that's not the actual time zone of the local machine (conversely, it passes if `date.timezone` is set to the actual time zone of the local machine).\r\n\r\nFixing it is tricky though:\r\n\r\n* either we write all our timestamps in UTC to the excel file (which probably will just confuse the majority of the users) or\r\n* we need a way to convert the date read from excel into a timestamp while going through php's internal DateTime facility. Unfortunately, the `date` extension provides no such thing, so this would come with huge duplication in the code.\r\n\r\nThe problem is that `_php_excel_date_unpack` calls `mktime()` which of course uses the OSes timezone and not the one set to php internally, so the timestamp `_php_excel_date_unpack` returns in in actual local time and not in the timezone set in `date.timezone`.\r\n\r\nI'm tempted to leave this as is.","created_at":"2015-11-19T10:00:15Z","updated_at":"2015-11-19T10:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johmue/php_excel/pulls/3/commits","review_comments_url":"https://api.github.com/repos/johmue/php_excel/pulls/3/comments","review_comment_url":"https://api.github.com/repos/johmue/php_excel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johmue/php_excel/issues/3/comments","statuses_url":"https://api.github.com/repos/johmue/php_excel/statuses/4334ac3f49699accddc51c31646c11b57e219edb","head":{"label":"pilif:fix-tests","ref":"fix-tests","sha":"4334ac3f49699accddc51c31646c11b57e219edb","user":{"login":"pilif","id":4990,"avatar_url":"https://avatars.githubusercontent.com/u/4990?v=3","gravatar_id":"","url":"https://api.github.com/users/pilif","html_url":"https://github.com/pilif","followers_url":"https://api.github.com/users/pilif/followers","following_url":"https://api.github.com/users/pilif/following{/other_user}","gists_url":"https://api.github.com/users/pilif/gists{/gist_id}","starred_url":"https://api.github.com/users/pilif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilif/subscriptions","organizations_url":"https://api.github.com/users/pilif/orgs","repos_url":"https://api.github.com/users/pilif/repos","events_url":"https://api.github.com/users/pilif/events{/privacy}","received_events_url":"https://api.github.com/users/pilif/received_events","type":"User","site_admin":false},"repo":{"id":46412109,"name":"php_excel","full_name":"pilif/php_excel","owner":{"login":"pilif","id":4990,"avatar_url":"https://avatars.githubusercontent.com/u/4990?v=3","gravatar_id":"","url":"https://api.github.com/users/pilif","html_url":"https://github.com/pilif","followers_url":"https://api.github.com/users/pilif/followers","following_url":"https://api.github.com/users/pilif/following{/other_user}","gists_url":"https://api.github.com/users/pilif/gists{/gist_id}","starred_url":"https://api.github.com/users/pilif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilif/subscriptions","organizations_url":"https://api.github.com/users/pilif/orgs","repos_url":"https://api.github.com/users/pilif/repos","events_url":"https://api.github.com/users/pilif/events{/privacy}","received_events_url":"https://api.github.com/users/pilif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pilif/php_excel","description":"PHP Extension interface to the Excel writing/reading library","fork":true,"url":"https://api.github.com/repos/pilif/php_excel","forks_url":"https://api.github.com/repos/pilif/php_excel/forks","keys_url":"https://api.github.com/repos/pilif/php_excel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilif/php_excel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilif/php_excel/teams","hooks_url":"https://api.github.com/repos/pilif/php_excel/hooks","issue_events_url":"https://api.github.com/repos/pilif/php_excel/issues/events{/number}","events_url":"https://api.github.com/repos/pilif/php_excel/events","assignees_url":"https://api.github.com/repos/pilif/php_excel/assignees{/user}","branches_url":"https://api.github.com/repos/pilif/php_excel/branches{/branch}","tags_url":"https://api.github.com/repos/pilif/php_excel/tags","blobs_url":"https://api.github.com/repos/pilif/php_excel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilif/php_excel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilif/php_excel/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilif/php_excel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilif/php_excel/statuses/{sha}","languages_url":"https://api.github.com/repos/pilif/php_excel/languages","stargazers_url":"https://api.github.com/repos/pilif/php_excel/stargazers","contributors_url":"https://api.github.com/repos/pilif/php_excel/contributors","subscribers_url":"https://api.github.com/repos/pilif/php_excel/subscribers","subscription_url":"https://api.github.com/repos/pilif/php_excel/subscription","commits_url":"https://api.github.com/repos/pilif/php_excel/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilif/php_excel/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilif/php_excel/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilif/php_excel/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilif/php_excel/contents/{+path}","compare_url":"https://api.github.com/repos/pilif/php_excel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilif/php_excel/merges","archive_url":"https://api.github.com/repos/pilif/php_excel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilif/php_excel/downloads","issues_url":"https://api.github.com/repos/pilif/php_excel/issues{/number}","pulls_url":"https://api.github.com/repos/pilif/php_excel/pulls{/number}","milestones_url":"https://api.github.com/repos/pilif/php_excel/milestones{/number}","notifications_url":"https://api.github.com/repos/pilif/php_excel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilif/php_excel/labels{/name}","releases_url":"https://api.github.com/repos/pilif/php_excel/releases{/id}","created_at":"2015-11-18T10:38:47Z","updated_at":"2015-11-18T10:38:48Z","pushed_at":"2015-11-19T09:54:39Z","git_url":"git://github.com/pilif/php_excel.git","ssh_url":"git@github.com:pilif/php_excel.git","clone_url":"https://github.com/pilif/php_excel.git","svn_url":"https://github.com/pilif/php_excel","homepage":"http://ilia.ws","size":561,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johmue:php7","ref":"php7","sha":"6e230f56684ae1f78244b5f307cbc2d97303031e","user":{"login":"johmue","id":281784,"avatar_url":"https://avatars.githubusercontent.com/u/281784?v=3","gravatar_id":"","url":"https://api.github.com/users/johmue","html_url":"https://github.com/johmue","followers_url":"https://api.github.com/users/johmue/followers","following_url":"https://api.github.com/users/johmue/following{/other_user}","gists_url":"https://api.github.com/users/johmue/gists{/gist_id}","starred_url":"https://api.github.com/users/johmue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmue/subscriptions","organizations_url":"https://api.github.com/users/johmue/orgs","repos_url":"https://api.github.com/users/johmue/repos","events_url":"https://api.github.com/users/johmue/events{/privacy}","received_events_url":"https://api.github.com/users/johmue/received_events","type":"User","site_admin":false},"repo":{"id":21895783,"name":"php_excel","full_name":"johmue/php_excel","owner":{"login":"johmue","id":281784,"avatar_url":"https://avatars.githubusercontent.com/u/281784?v=3","gravatar_id":"","url":"https://api.github.com/users/johmue","html_url":"https://github.com/johmue","followers_url":"https://api.github.com/users/johmue/followers","following_url":"https://api.github.com/users/johmue/following{/other_user}","gists_url":"https://api.github.com/users/johmue/gists{/gist_id}","starred_url":"https://api.github.com/users/johmue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmue/subscriptions","organizations_url":"https://api.github.com/users/johmue/orgs","repos_url":"https://api.github.com/users/johmue/repos","events_url":"https://api.github.com/users/johmue/events{/privacy}","received_events_url":"https://api.github.com/users/johmue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johmue/php_excel","description":"PHP Extension interface to the Excel writing/reading library","fork":true,"url":"https://api.github.com/repos/johmue/php_excel","forks_url":"https://api.github.com/repos/johmue/php_excel/forks","keys_url":"https://api.github.com/repos/johmue/php_excel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johmue/php_excel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johmue/php_excel/teams","hooks_url":"https://api.github.com/repos/johmue/php_excel/hooks","issue_events_url":"https://api.github.com/repos/johmue/php_excel/issues/events{/number}","events_url":"https://api.github.com/repos/johmue/php_excel/events","assignees_url":"https://api.github.com/repos/johmue/php_excel/assignees{/user}","branches_url":"https://api.github.com/repos/johmue/php_excel/branches{/branch}","tags_url":"https://api.github.com/repos/johmue/php_excel/tags","blobs_url":"https://api.github.com/repos/johmue/php_excel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johmue/php_excel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johmue/php_excel/git/refs{/sha}","trees_url":"https://api.github.com/repos/johmue/php_excel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johmue/php_excel/statuses/{sha}","languages_url":"https://api.github.com/repos/johmue/php_excel/languages","stargazers_url":"https://api.github.com/repos/johmue/php_excel/stargazers","contributors_url":"https://api.github.com/repos/johmue/php_excel/contributors","subscribers_url":"https://api.github.com/repos/johmue/php_excel/subscribers","subscription_url":"https://api.github.com/repos/johmue/php_excel/subscription","commits_url":"https://api.github.com/repos/johmue/php_excel/commits{/sha}","git_commits_url":"https://api.github.com/repos/johmue/php_excel/git/commits{/sha}","comments_url":"https://api.github.com/repos/johmue/php_excel/comments{/number}","issue_comment_url":"https://api.github.com/repos/johmue/php_excel/issues/comments{/number}","contents_url":"https://api.github.com/repos/johmue/php_excel/contents/{+path}","compare_url":"https://api.github.com/repos/johmue/php_excel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johmue/php_excel/merges","archive_url":"https://api.github.com/repos/johmue/php_excel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johmue/php_excel/downloads","issues_url":"https://api.github.com/repos/johmue/php_excel/issues{/number}","pulls_url":"https://api.github.com/repos/johmue/php_excel/pulls{/number}","milestones_url":"https://api.github.com/repos/johmue/php_excel/milestones{/number}","notifications_url":"https://api.github.com/repos/johmue/php_excel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johmue/php_excel/labels{/name}","releases_url":"https://api.github.com/repos/johmue/php_excel/releases{/id}","created_at":"2014-07-16T10:10:01Z","updated_at":"2015-02-13T13:25:23Z","pushed_at":"2015-11-19T09:02:07Z","git_url":"git://github.com/johmue/php_excel.git","ssh_url":"git@github.com:johmue/php_excel.git","clone_url":"https://github.com/johmue/php_excel.git","svn_url":"https://github.com/johmue/php_excel","homepage":"http://ilia.ws","size":555,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johmue/php_excel/pulls/3"},"html":{"href":"https://github.com/johmue/php_excel/pull/3"},"issue":{"href":"https://api.github.com/repos/johmue/php_excel/issues/3"},"comments":{"href":"https://api.github.com/repos/johmue/php_excel/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/johmue/php_excel/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/johmue/php_excel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johmue/php_excel/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/johmue/php_excel/statuses/4334ac3f49699accddc51c31646c11b57e219edb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":14,"deletions":13,"changed_files":3}}