{"action":"created","comment":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/comments/37576569","id":37576569,"diff_hunk":"@@ -138,12 +138,15 @@ var clearUnvisitedDOM = function(node) {\n \n   while (lastChild !== lastVisitedChild) {\n     node.removeChild(lastChild);\n+    notifications.removedNode(lastChild);","path":"src/alignment.js","position":21,"original_position":13,"commit_id":"f033793fab9c162df5168ebb34825776d40d9524","original_commit_id":"2bddc23af91d28842f8a39abab5244d2b436e7fd","user":{"login":"markuskobler","id":61794,"avatar_url":"https://avatars.githubusercontent.com/u/61794?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskobler","html_url":"https://github.com/markuskobler","followers_url":"https://api.github.com/users/markuskobler/followers","following_url":"https://api.github.com/users/markuskobler/following{/other_user}","gists_url":"https://api.github.com/users/markuskobler/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskobler/subscriptions","organizations_url":"https://api.github.com/users/markuskobler/orgs","repos_url":"https://api.github.com/users/markuskobler/repos","events_url":"https://api.github.com/users/markuskobler/events{/privacy}","received_events_url":"https://api.github.com/users/markuskobler/received_events","type":"User","site_admin":false},"body":"The lines below should address the issue now","created_at":"2015-08-20T20:21:09Z","updated_at":"2015-08-20T20:21:09Z","html_url":"https://github.com/google/incremental-dom/pull/109#discussion_r37576569","pull_request_url":"https://api.github.com/repos/google/incremental-dom/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/comments/37576569"},"html":{"href":"https://github.com/google/incremental-dom/pull/109#discussion_r37576569"},"pull_request":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/109","id":42947691,"html_url":"https://github.com/google/incremental-dom/pull/109","diff_url":"https://github.com/google/incremental-dom/pull/109.diff","patch_url":"https://github.com/google/incremental-dom/pull/109.patch","issue_url":"https://api.github.com/repos/google/incremental-dom/issues/109","number":109,"state":"open","locked":false,"title":"Added basic support for node create/remove notfication callbacks","user":{"login":"markuskobler","id":61794,"avatar_url":"https://avatars.githubusercontent.com/u/61794?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskobler","html_url":"https://github.com/markuskobler","followers_url":"https://api.github.com/users/markuskobler/followers","following_url":"https://api.github.com/users/markuskobler/following{/other_user}","gists_url":"https://api.github.com/users/markuskobler/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskobler/subscriptions","organizations_url":"https://api.github.com/users/markuskobler/orgs","repos_url":"https://api.github.com/users/markuskobler/repos","events_url":"https://api.github.com/users/markuskobler/events{/privacy}","received_events_url":"https://api.github.com/users/markuskobler/received_events","type":"User","site_admin":false},"body":"An updated version of #105 which should add support for notifications on node creation and removal. Few things to note:\r\n* Intentionally not called events so as not to confuse with `EventTarget.addEventListener` style handling, also not included with `mutators` as they are not mutating anything. Maybe `mutators` should be refactored to hooks and combine the two?\r\n* If not overriden the default callbacks should get optimized away as they are noops\r\n* I have left `updatedNode` notifications for now\r\n* Callbacks are only passed `node` as first argument and dont change behaviour to make it easier to extend their behavour later \r\n\r\nI also left off `translateIntoNodeName` for another pull request as I think the changes might be invasive (and I personally am not sure its the best way to go).","created_at":"2015-08-20T16:08:48Z","updated_at":"2015-08-20T20:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c9ba78ffbf787a1c8fcbff356a0f21442e15b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/incremental-dom/pulls/109/commits","review_comments_url":"https://api.github.com/repos/google/incremental-dom/pulls/109/comments","review_comment_url":"https://api.github.com/repos/google/incremental-dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/incremental-dom/issues/109/comments","statuses_url":"https://api.github.com/repos/google/incremental-dom/statuses/f033793fab9c162df5168ebb34825776d40d9524","head":{"label":"markuskobler:notifications","ref":"notifications","sha":"f033793fab9c162df5168ebb34825776d40d9524","user":{"login":"markuskobler","id":61794,"avatar_url":"https://avatars.githubusercontent.com/u/61794?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskobler","html_url":"https://github.com/markuskobler","followers_url":"https://api.github.com/users/markuskobler/followers","following_url":"https://api.github.com/users/markuskobler/following{/other_user}","gists_url":"https://api.github.com/users/markuskobler/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskobler/subscriptions","organizations_url":"https://api.github.com/users/markuskobler/orgs","repos_url":"https://api.github.com/users/markuskobler/repos","events_url":"https://api.github.com/users/markuskobler/events{/privacy}","received_events_url":"https://api.github.com/users/markuskobler/received_events","type":"User","site_admin":false},"repo":{"id":40884952,"name":"incremental-dom","full_name":"markuskobler/incremental-dom","owner":{"login":"markuskobler","id":61794,"avatar_url":"https://avatars.githubusercontent.com/u/61794?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskobler","html_url":"https://github.com/markuskobler","followers_url":"https://api.github.com/users/markuskobler/followers","following_url":"https://api.github.com/users/markuskobler/following{/other_user}","gists_url":"https://api.github.com/users/markuskobler/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskobler/subscriptions","organizations_url":"https://api.github.com/users/markuskobler/orgs","repos_url":"https://api.github.com/users/markuskobler/repos","events_url":"https://api.github.com/users/markuskobler/events{/privacy}","received_events_url":"https://api.github.com/users/markuskobler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markuskobler/incremental-dom","description":null,"fork":true,"url":"https://api.github.com/repos/markuskobler/incremental-dom","forks_url":"https://api.github.com/repos/markuskobler/incremental-dom/forks","keys_url":"https://api.github.com/repos/markuskobler/incremental-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markuskobler/incremental-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markuskobler/incremental-dom/teams","hooks_url":"https://api.github.com/repos/markuskobler/incremental-dom/hooks","issue_events_url":"https://api.github.com/repos/markuskobler/incremental-dom/issues/events{/number}","events_url":"https://api.github.com/repos/markuskobler/incremental-dom/events","assignees_url":"https://api.github.com/repos/markuskobler/incremental-dom/assignees{/user}","branches_url":"https://api.github.com/repos/markuskobler/incremental-dom/branches{/branch}","tags_url":"https://api.github.com/repos/markuskobler/incremental-dom/tags","blobs_url":"https://api.github.com/repos/markuskobler/incremental-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markuskobler/incremental-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markuskobler/incremental-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/markuskobler/incremental-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markuskobler/incremental-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/markuskobler/incremental-dom/languages","stargazers_url":"https://api.github.com/repos/markuskobler/incremental-dom/stargazers","contributors_url":"https://api.github.com/repos/markuskobler/incremental-dom/contributors","subscribers_url":"https://api.github.com/repos/markuskobler/incremental-dom/subscribers","subscription_url":"https://api.github.com/repos/markuskobler/incremental-dom/subscription","commits_url":"https://api.github.com/repos/markuskobler/incremental-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/markuskobler/incremental-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/markuskobler/incremental-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/markuskobler/incremental-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/markuskobler/incremental-dom/contents/{+path}","compare_url":"https://api.github.com/repos/markuskobler/incremental-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markuskobler/incremental-dom/merges","archive_url":"https://api.github.com/repos/markuskobler/incremental-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markuskobler/incremental-dom/downloads","issues_url":"https://api.github.com/repos/markuskobler/incremental-dom/issues{/number}","pulls_url":"https://api.github.com/repos/markuskobler/incremental-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/markuskobler/incremental-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/markuskobler/incremental-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markuskobler/incremental-dom/labels{/name}","releases_url":"https://api.github.com/repos/markuskobler/incremental-dom/releases{/id}","created_at":"2015-08-17T10:18:37Z","updated_at":"2015-08-17T10:18:37Z","pushed_at":"2015-08-20T20:20:36Z","git_url":"git://github.com/markuskobler/incremental-dom.git","ssh_url":"git@github.com:markuskobler/incremental-dom.git","clone_url":"https://github.com/markuskobler/incremental-dom.git","svn_url":"https://github.com/markuskobler/incremental-dom","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e0759afa8d69b6b0077548f44606bd0a2b0943d1","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37283747,"name":"incremental-dom","full_name":"google/incremental-dom","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/incremental-dom","description":null,"fork":false,"url":"https://api.github.com/repos/google/incremental-dom","forks_url":"https://api.github.com/repos/google/incremental-dom/forks","keys_url":"https://api.github.com/repos/google/incremental-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/incremental-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/incremental-dom/teams","hooks_url":"https://api.github.com/repos/google/incremental-dom/hooks","issue_events_url":"https://api.github.com/repos/google/incremental-dom/issues/events{/number}","events_url":"https://api.github.com/repos/google/incremental-dom/events","assignees_url":"https://api.github.com/repos/google/incremental-dom/assignees{/user}","branches_url":"https://api.github.com/repos/google/incremental-dom/branches{/branch}","tags_url":"https://api.github.com/repos/google/incremental-dom/tags","blobs_url":"https://api.github.com/repos/google/incremental-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/incremental-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/incremental-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/incremental-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/incremental-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/google/incremental-dom/languages","stargazers_url":"https://api.github.com/repos/google/incremental-dom/stargazers","contributors_url":"https://api.github.com/repos/google/incremental-dom/contributors","subscribers_url":"https://api.github.com/repos/google/incremental-dom/subscribers","subscription_url":"https://api.github.com/repos/google/incremental-dom/subscription","commits_url":"https://api.github.com/repos/google/incremental-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/incremental-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/incremental-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/incremental-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/incremental-dom/contents/{+path}","compare_url":"https://api.github.com/repos/google/incremental-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/incremental-dom/merges","archive_url":"https://api.github.com/repos/google/incremental-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/incremental-dom/downloads","issues_url":"https://api.github.com/repos/google/incremental-dom/issues{/number}","pulls_url":"https://api.github.com/repos/google/incremental-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/google/incremental-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/google/incremental-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/incremental-dom/labels{/name}","releases_url":"https://api.github.com/repos/google/incremental-dom/releases{/id}","created_at":"2015-06-11T20:15:03Z","updated_at":"2015-08-20T19:22:16Z","pushed_at":"2015-08-20T20:20:36Z","git_url":"git://github.com/google/incremental-dom.git","ssh_url":"git@github.com:google/incremental-dom.git","clone_url":"https://github.com/google/incremental-dom.git","svn_url":"https://github.com/google/incremental-dom","homepage":null,"size":1087,"stargazers_count":1378,"watchers_count":1378,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":21,"forks":42,"open_issues":21,"watchers":1378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/109"},"html":{"href":"https://github.com/google/incremental-dom/pull/109"},"issue":{"href":"https://api.github.com/repos/google/incremental-dom/issues/109"},"comments":{"href":"https://api.github.com/repos/google/incremental-dom/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/google/incremental-dom/statuses/f033793fab9c162df5168ebb34825776d40d9524"}}}}