{"push_id":716547946,"size":1,"distinct_size":1,"ref":"refs/heads/wip-fix-erasure-hides-parse","head":"9760c220b80c79f61819d683b36114a1f46f18f6","before":"61c42d5375c6f640a5b58af451c8b69a9441928b","commits":[{"sha":"9760c220b80c79f61819d683b36114a1f46f18f6","author":{"email":"a4b264ee037c625052534d60505bfd0db4776ac4@redhat.com","name":"Kefu Chai"},"message":"erasure-code: do not hide overloaded ErasureCode::parse()\n\n* this change fixes the warning from clang:\n  ErasureCodeJerasure::parse' hides overloaded virtual function\n  [-Woverloaded-virtual]\n* some erasure codecs' ErasureCode::parse() rewrites the profile\n  using the default values when parsing it if the corresponding\n  items are not specified. and we don't call ErasureCode::parse()\n  via its children's references. so no need to make it a virtual\n  function.\n* and ErasureCode::parse() is used as a helper function by its\n  children, so make it `protected`\n* and parse() in ErasureCode's children is but a helper function\n  called by ctor, descendants' parse() and init(). so make them\n  protected or private accordingly.\n\nSigned-off-by: Kefu Chai <kchai@redhat.com>","distinct":true,"url":"https://api.github.com/repos/tchaikov/ceph/commits/9760c220b80c79f61819d683b36114a1f46f18f6"}]}