{"action":"opened","number":4329,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4329","id":47108794,"html_url":"https://github.com/netty/netty/pull/4329","diff_url":"https://github.com/netty/netty/pull/4329.diff","patch_url":"https://github.com/netty/netty/pull/4329.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/4329","number":4329,"state":"open","locked":false,"title":"change type definition of pipeline from DefaultChannelPipeline to Cha…","user":{"login":"skyao","id":1582369,"avatar_url":"https://avatars.githubusercontent.com/u/1582369?v=3","gravatar_id":"","url":"https://api.github.com/users/skyao","html_url":"https://github.com/skyao","followers_url":"https://api.github.com/users/skyao/followers","following_url":"https://api.github.com/users/skyao/following{/other_user}","gists_url":"https://api.github.com/users/skyao/gists{/gist_id}","starred_url":"https://api.github.com/users/skyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyao/subscriptions","organizations_url":"https://api.github.com/users/skyao/orgs","repos_url":"https://api.github.com/users/skyao/repos","events_url":"https://api.github.com/users/skyao/events{/privacy}","received_events_url":"https://api.github.com/users/skyao/received_events","type":"User","site_admin":false},"body":"Netty version: 5.0.0.Alpha3-SNAPSHOT\r\n\r\nContext:\r\nI found that in class AbstractChannel, the type definition of pipeline is \"DefaultChannelPipeline\". I think we would better to use the interface ChannelPipeline, not a detail implementation DefaultChannelPipeline. In fact, in the code we don't use any DefaultChannelPipeline specified code but just use it as ChannelPipeline. \r\n\r\n```java\r\nprivate final DefaultChannelPipeline pipeline;\r\n```","created_at":"2015-10-08T03:43:59Z","updated_at":"2015-10-08T03:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/4329/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/4329/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/4329/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/9d2869aebca0a0268a3116e97462a3791033254f","head":{"label":"skyao:master","ref":"master","sha":"9d2869aebca0a0268a3116e97462a3791033254f","user":{"login":"skyao","id":1582369,"avatar_url":"https://avatars.githubusercontent.com/u/1582369?v=3","gravatar_id":"","url":"https://api.github.com/users/skyao","html_url":"https://github.com/skyao","followers_url":"https://api.github.com/users/skyao/followers","following_url":"https://api.github.com/users/skyao/following{/other_user}","gists_url":"https://api.github.com/users/skyao/gists{/gist_id}","starred_url":"https://api.github.com/users/skyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyao/subscriptions","organizations_url":"https://api.github.com/users/skyao/orgs","repos_url":"https://api.github.com/users/skyao/repos","events_url":"https://api.github.com/users/skyao/events{/privacy}","received_events_url":"https://api.github.com/users/skyao/received_events","type":"User","site_admin":false},"repo":{"id":43858848,"name":"netty","full_name":"skyao/netty","owner":{"login":"skyao","id":1582369,"avatar_url":"https://avatars.githubusercontent.com/u/1582369?v=3","gravatar_id":"","url":"https://api.github.com/users/skyao","html_url":"https://github.com/skyao","followers_url":"https://api.github.com/users/skyao/followers","following_url":"https://api.github.com/users/skyao/following{/other_user}","gists_url":"https://api.github.com/users/skyao/gists{/gist_id}","starred_url":"https://api.github.com/users/skyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyao/subscriptions","organizations_url":"https://api.github.com/users/skyao/orgs","repos_url":"https://api.github.com/users/skyao/repos","events_url":"https://api.github.com/users/skyao/events{/privacy}","received_events_url":"https://api.github.com/users/skyao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skyao/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/skyao/netty","forks_url":"https://api.github.com/repos/skyao/netty/forks","keys_url":"https://api.github.com/repos/skyao/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyao/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyao/netty/teams","hooks_url":"https://api.github.com/repos/skyao/netty/hooks","issue_events_url":"https://api.github.com/repos/skyao/netty/issues/events{/number}","events_url":"https://api.github.com/repos/skyao/netty/events","assignees_url":"https://api.github.com/repos/skyao/netty/assignees{/user}","branches_url":"https://api.github.com/repos/skyao/netty/branches{/branch}","tags_url":"https://api.github.com/repos/skyao/netty/tags","blobs_url":"https://api.github.com/repos/skyao/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyao/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyao/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyao/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyao/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/skyao/netty/languages","stargazers_url":"https://api.github.com/repos/skyao/netty/stargazers","contributors_url":"https://api.github.com/repos/skyao/netty/contributors","subscribers_url":"https://api.github.com/repos/skyao/netty/subscribers","subscription_url":"https://api.github.com/repos/skyao/netty/subscription","commits_url":"https://api.github.com/repos/skyao/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyao/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyao/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyao/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyao/netty/contents/{+path}","compare_url":"https://api.github.com/repos/skyao/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyao/netty/merges","archive_url":"https://api.github.com/repos/skyao/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyao/netty/downloads","issues_url":"https://api.github.com/repos/skyao/netty/issues{/number}","pulls_url":"https://api.github.com/repos/skyao/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/skyao/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/skyao/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyao/netty/labels{/name}","releases_url":"https://api.github.com/repos/skyao/netty/releases{/id}","created_at":"2015-10-08T02:59:38Z","updated_at":"2015-10-08T02:59:50Z","pushed_at":"2015-10-08T03:34:20Z","git_url":"git://github.com/skyao/netty.git","ssh_url":"git@github.com:skyao/netty.git","clone_url":"https://github.com/skyao/netty.git","svn_url":"https://github.com/skyao/netty","homepage":"http://netty.io/","size":133008,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"a605fa4411c15c7eb29f174e74d36a596f478317","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-10-08T02:36:31Z","pushed_at":"2015-10-08T03:43:59Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":133008,"stargazers_count":5316,"watchers_count":5316,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2703,"mirror_url":null,"open_issues_count":311,"forks":2703,"open_issues":311,"watchers":5316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/4329"},"html":{"href":"https://github.com/netty/netty/pull/4329"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/4329"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/4329/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/4329/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/4329/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/9d2869aebca0a0268a3116e97462a3791033254f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}