{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3355","id":122974324,"number":3355,"title":"Partial texture updates: Check the dimensions of the efb copy","user":{"login":"mimimi085181","id":9304938,"avatar_url":"https://avatars.githubusercontent.com/u/9304938?v=3","gravatar_id":"","url":"https://api.github.com/users/mimimi085181","html_url":"https://github.com/mimimi085181","followers_url":"https://api.github.com/users/mimimi085181/followers","following_url":"https://api.github.com/users/mimimi085181/following{/other_user}","gists_url":"https://api.github.com/users/mimimi085181/gists{/gist_id}","starred_url":"https://api.github.com/users/mimimi085181/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimimi085181/subscriptions","organizations_url":"https://api.github.com/users/mimimi085181/orgs","repos_url":"https://api.github.com/users/mimimi085181/repos","events_url":"https://api.github.com/users/mimimi085181/events{/privacy}","received_events_url":"https://api.github.com/users/mimimi085181/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-18T16:01:21Z","updated_at":"2015-12-19T00:27:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3355","html_url":"https://github.com/dolphin-emu/dolphin/pull/3355","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3355.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3355.patch"},"body":"and the target texture, not just the binary size.\r\n\r\nThis should get Donkey Kong Country Returns characters to be as broken as they should be. They will be fixed in a later pr.\r\n\r\nExpected result is:\r\nefbtex: characters are always flickering or invisible, no matter what scaling or IR setting\r\nefb2ram: characters are always working properly at 1xIR, no matter what scaling or IR setting\r\n\r\nThis is related to:\r\nhttps://bugs.dolphin-emu.org/issues/9120\r\n\r\nPS: Donkey Kong is supposed to be invisible with efb2tex, because the efb copy is 1 pixel/texel wider and heigher than the texture the game tries to use from the same offset. So the correct behavior is to not use that efb copy, because currently the efb copy is supposed to fit completely into the texture that is updated. But the partial texture updates code did only check the binary size for updates, so Dolphin refused to use the efb copy directly, but did a partial texture update. But why it was randomly working and not working with different IR settings, i don't know."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/165926461","html_url":"https://github.com/dolphin-emu/dolphin/pull/3355#issuecomment-165926461","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3355","id":165926461,"user":{"login":"dolphin-emu-bot","id":6899296,"avatar_url":"https://avatars.githubusercontent.com/u/6899296?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu-bot","html_url":"https://github.com/dolphin-emu-bot","followers_url":"https://api.github.com/users/dolphin-emu-bot/followers","following_url":"https://api.github.com/users/dolphin-emu-bot/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu-bot/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu-bot/orgs","repos_url":"https://api.github.com/users/dolphin-emu-bot/repos","events_url":"https://api.github.com/users/dolphin-emu-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu-bot/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T00:27:02Z","updated_at":"2015-12-19T00:27:02Z","body":"[FifoCI](https://fifoci.dolphin-emu.org/about/) detected that this change impacts graphical             rendering. Here are the [behavior differences](https://fifoci.dolphin-emu.org/version/67b396b8e49f24abf74c424be828e7f6161d6ea5/)             detected by the system:\n\n* `DKCR-Char` on `dx-win-nv`: [diff](https://fifoci.dolphin-emu.org/compare/939653-938663/)\n* `DKCR-Char` on `ogl-lin-mesa`: [diff](https://fifoci.dolphin-emu.org/compare/939460-938444/)\n\n<sub><sup>automated-fifoci-reporter</sup></sub>"}}