{"action":"created","issue":{"url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/100","labels_url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/100/comments","events_url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/100/events","html_url":"https://github.com/iziz/libPhoneNumber-iOS/pull/100","id":115490171,"number":100,"title":"Use external linkage & const pointers for shared string constants and make unknown region code public","user":{"login":"Johennes","id":1137962,"avatar_url":"https://avatars.githubusercontent.com/u/1137962?v=3","gravatar_id":"","url":"https://api.github.com/users/Johennes","html_url":"https://github.com/Johennes","followers_url":"https://api.github.com/users/Johennes/followers","following_url":"https://api.github.com/users/Johennes/following{/other_user}","gists_url":"https://api.github.com/users/Johennes/gists{/gist_id}","starred_url":"https://api.github.com/users/Johennes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johennes/subscriptions","organizations_url":"https://api.github.com/users/Johennes/orgs","repos_url":"https://api.github.com/users/Johennes/repos","events_url":"https://api.github.com/users/Johennes/events{/privacy}","received_events_url":"https://api.github.com/users/Johennes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-06T11:40:29Z","updated_at":"2015-11-06T11:57:46Z","closed_at":"2015-11-06T11:54:50Z","pull_request":{"url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/pulls/100","html_url":"https://github.com/iziz/libPhoneNumber-iOS/pull/100","diff_url":"https://github.com/iziz/libPhoneNumber-iOS/pull/100.diff","patch_url":"https://github.com/iziz/libPhoneNumber-iOS/pull/100.patch"},"body":"The shared string constants in `NBPhoneNumberDefines.h` were defined as static variables.\r\nAs a result, they were not actually shared but instead a new instance was created for\r\nevery file that imported the header. This commit changes the constants to use external\r\nlinkage which makes them truly shared. On top, the pointers were made immutable. Finally,\r\nthe special `@\"ZZ\"` code for unknown regions was added to the public shared string constants.\r\nSince this code can be returned by a number of public library functions, clients should\r\nhave a way to check for it other than using the internal string literal `@\"ZZ\"`."},"comment":{"url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/comments/154392921","html_url":"https://github.com/iziz/libPhoneNumber-iOS/pull/100#issuecomment-154392921","issue_url":"https://api.github.com/repos/iziz/libPhoneNumber-iOS/issues/100","id":154392921,"user":{"login":"iziz","id":318647,"avatar_url":"https://avatars.githubusercontent.com/u/318647?v=3","gravatar_id":"","url":"https://api.github.com/users/iziz","html_url":"https://github.com/iziz","followers_url":"https://api.github.com/users/iziz/followers","following_url":"https://api.github.com/users/iziz/following{/other_user}","gists_url":"https://api.github.com/users/iziz/gists{/gist_id}","starred_url":"https://api.github.com/users/iziz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iziz/subscriptions","organizations_url":"https://api.github.com/users/iziz/orgs","repos_url":"https://api.github.com/users/iziz/repos","events_url":"https://api.github.com/users/iziz/events{/privacy}","received_events_url":"https://api.github.com/users/iziz/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T11:57:46Z","updated_at":"2015-11-06T11:57:46Z","body":"Thank you for your contribution."}}