{"action":"created","comment":{"url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/comments/27110668","id":27110668,"diff_hunk":"@@ -44,9 +44,6 @@ def view(request, *args, **kwargs):\n         environ = request.environ.copy()\n         if len(args) > 0:\n             shift_path(environ, '/' + args[0])\n-        # Django converts SCRIPT_NAME and PATH_INFO to unicode in WSGIRequest.\n-        environ['SCRIPT_NAME'] = environ['SCRIPT_NAME'].encode('iso-8859-1')\n-        environ['PATH_INFO'] = environ['PATH_INFO'].encode('iso-8859-1')","path":"viewsgi.py","position":15,"original_position":6,"commit_id":"43f8a5ac495d7aeb90e94c9287526ea237de87c7","original_commit_id":"3c9be077f321cf61334bbd2ad140499d035183c4","user":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"body":"ah bon @bors-ltd ? d'après http://stackoverflow.com/questions/4400678/http-header-should-use-what-character-encoding (qui référence la RFC de HTTP 1/1) il semble que les seuls caractères autorisés soient très précisément définis, grosso modo à (pour faire court) l'ASCII printable entre 0 et 127.\r\nintéressant comme question :)","created_at":"2015-03-25T10:58:18Z","updated_at":"2015-03-25T10:58:18Z","html_url":"https://github.com/Polyconseil/django-viewsgi/pull/2#discussion_r27110668","pull_request_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/comments/27110668"},"html":{"href":"https://github.com/Polyconseil/django-viewsgi/pull/2#discussion_r27110668"},"pull_request":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2","id":31906937,"html_url":"https://github.com/Polyconseil/django-viewsgi/pull/2","diff_url":"https://github.com/Polyconseil/django-viewsgi/pull/2.diff","patch_url":"https://github.com/Polyconseil/django-viewsgi/pull/2.patch","issue_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/2","number":2,"state":"open","locked":false,"title":"removing encoding of PATH_INFO and SCRIPT_NAME which leads to error in python 3.4","user":{"login":"gbittoun","id":2226270,"avatar_url":"https://avatars.githubusercontent.com/u/2226270?v=3","gravatar_id":"","url":"https://api.github.com/users/gbittoun","html_url":"https://github.com/gbittoun","followers_url":"https://api.github.com/users/gbittoun/followers","following_url":"https://api.github.com/users/gbittoun/following{/other_user}","gists_url":"https://api.github.com/users/gbittoun/gists{/gist_id}","starred_url":"https://api.github.com/users/gbittoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbittoun/subscriptions","organizations_url":"https://api.github.com/users/gbittoun/orgs","repos_url":"https://api.github.com/users/gbittoun/repos","events_url":"https://api.github.com/users/gbittoun/events{/privacy}","received_events_url":"https://api.github.com/users/gbittoun/received_events","type":"User","site_admin":false},"body":"In a ws application, the PATH_INFO is used by a call of wsgiref.util.request_uri which decode the path info this way :\r\n```    path_info = quote(environ.get('PATH_INFO',''), safe='/;=,', encoding='latin1')``` (line 67)\r\nThis leads to an error ```quote() doesn't support 'encoding' for bytes```. This commit fixes this issue and keeps compatibility with python 2.7","created_at":"2015-03-25T09:55:53Z","updated_at":"2015-03-25T10:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb704a1ef4f56de67f774cddadc019e3e1108e62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/2/comments","statuses_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/statuses/43f8a5ac495d7aeb90e94c9287526ea237de87c7","head":{"label":"Polyconseil:gbittoun/remove-path-info-encoding","ref":"gbittoun/remove-path-info-encoding","sha":"43f8a5ac495d7aeb90e94c9287526ea237de87c7","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":5341718,"name":"django-viewsgi","full_name":"Polyconseil/django-viewsgi","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/django-viewsgi","description":"Embed WSGI applications in Django views.","fork":false,"url":"https://api.github.com/repos/Polyconseil/django-viewsgi","forks_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/forks","keys_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/teams","hooks_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/events","assignees_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/tags","blobs_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/subscription","commits_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/merges","archive_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/downloads","issues_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/releases{/id}","created_at":"2012-08-08T12:55:01Z","updated_at":"2014-03-04T14:06:12Z","pushed_at":"2015-03-25T10:49:12Z","git_url":"git://github.com/Polyconseil/django-viewsgi.git","ssh_url":"git@github.com:Polyconseil/django-viewsgi.git","clone_url":"https://github.com/Polyconseil/django-viewsgi.git","svn_url":"https://github.com/Polyconseil/django-viewsgi","homepage":null,"size":215,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Polyconseil:master","ref":"master","sha":"826bebd6320936ee1c479d005565a05c713d972e","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":5341718,"name":"django-viewsgi","full_name":"Polyconseil/django-viewsgi","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/django-viewsgi","description":"Embed WSGI applications in Django views.","fork":false,"url":"https://api.github.com/repos/Polyconseil/django-viewsgi","forks_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/forks","keys_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/teams","hooks_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/events","assignees_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/tags","blobs_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/subscription","commits_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/merges","archive_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/downloads","issues_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/django-viewsgi/releases{/id}","created_at":"2012-08-08T12:55:01Z","updated_at":"2014-03-04T14:06:12Z","pushed_at":"2015-03-25T10:49:12Z","git_url":"git://github.com/Polyconseil/django-viewsgi.git","ssh_url":"git@github.com:Polyconseil/django-viewsgi.git","clone_url":"https://github.com/Polyconseil/django-viewsgi.git","svn_url":"https://github.com/Polyconseil/django-viewsgi","homepage":null,"size":215,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2"},"html":{"href":"https://github.com/Polyconseil/django-viewsgi/pull/2"},"issue":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/2"},"comments":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Polyconseil/django-viewsgi/statuses/43f8a5ac495d7aeb90e94c9287526ea237de87c7"}}}}