{"action":"created","issue":{"url":"https://api.github.com/repos/haskell/cabal/issues/2620","labels_url":"https://api.github.com/repos/haskell/cabal/issues/2620/labels{/name}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/2620/comments","events_url":"https://api.github.com/repos/haskell/cabal/issues/2620/events","html_url":"https://github.com/haskell/cabal/pull/2620","id":82737253,"number":2620,"title":"Upgrade to zlib >=0.6.","user":{"login":"mf59816","id":216437,"avatar_url":"https://avatars.githubusercontent.com/u/216437?v=3","gravatar_id":"","url":"https://api.github.com/users/mf59816","html_url":"https://github.com/mf59816","followers_url":"https://api.github.com/users/mf59816/followers","following_url":"https://api.github.com/users/mf59816/following{/other_user}","gists_url":"https://api.github.com/users/mf59816/gists{/gist_id}","starred_url":"https://api.github.com/users/mf59816/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mf59816/subscriptions","organizations_url":"https://api.github.com/users/mf59816/orgs","repos_url":"https://api.github.com/users/mf59816/repos","events_url":"https://api.github.com/users/mf59816/events{/privacy}","received_events_url":"https://api.github.com/users/mf59816/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-05-30T07:40:34Z","updated_at":"2015-06-24T12:20:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/2620","html_url":"https://github.com/haskell/cabal/pull/2620","diff_url":"https://github.com/haskell/cabal/pull/2620.diff","patch_url":"https://github.com/haskell/cabal/pull/2620.patch"},"body":"In order to link to hackage-security, we need to bump zlib version and adjust to api changes.\r\n\r\nI am not familiar with cabal coding guidelines and habits, but I appreciate any suggestions.  Also, I have questions:\r\n\r\n1. Should I write a test?  (Haven't found one on this.)\r\n2. Is there really a need for zlib compression?  If we only had to do gzip, things would look a lot easier.\r\n3. Should we really trust the gzip magic header?  It's just two bytes, and they may match for some random reason even on unzipped data.\r\n4. Should I throw out the gzip case?  The zlib case should handle both as before.\r\n\r\nThanks,\r\nm."},"comment":{"url":"https://api.github.com/repos/haskell/cabal/issues/comments/114848675","html_url":"https://github.com/haskell/cabal/pull/2620#issuecomment-114848675","issue_url":"https://api.github.com/repos/haskell/cabal/issues/2620","id":114848675,"user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=3","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T12:20:31Z","updated_at":"2015-06-24T12:20:31Z","body":"```\r\nλ > maybeDecompress compressedGZip        == original\r\nFalse\r\nλ > toChunks (maybeDecompress compressedGZip )\r\n[\"foobar\",\"\"]\r\nλ > toChunks original \r\n[\"foobar\"]\r\n````\r\n\r\nWow, that's news to me! @dcoutts, shouldn't the `bytestring` library be fixed? And perhaps `zlib` shouldn't produce zero-length chunks in the first place."}}