{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/comments/46490507","id":46490507,"diff_hunk":"@@ -14,11 +14,15 @@ export default BaseView.extend({\n   },\n \n   afterRender () {\n+    const startIndex = 1;\n+\n     this.removeSubviews();\n-    let items = this.sliceCollection(this.adapter.results, ActivityResultsCollection, 1, 3);\n+    let items = this.sliceCollection(this.adapter.results, ActivityResultsCollection, startIndex, 3);\n     this.renderCollection(items, ActivityItemView, '.activity-results');\n \n     // if there are results then show otherwise hide\n-    this.adapter.results.length ? this.show() : this.hide(); // eslint-disable-line no-unused-expressions\n+    this.adapter.results.length > startIndex ? this.show() : this.hide(); // eslint-disable-line no-unused-expressions\n+\n+    window.app.trigger('adjust-height');","path":"src/views/activity/activity_index_view.js","position":15,"original_position":15,"commit_id":"1c5901101c13ae211fa7ca5aeda93783a9bfd76e","original_commit_id":"1c5901101c13ae211fa7ca5aeda93783a9bfd76e","user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"body":"Horribly minor nit: It might be good to have a different name than `adjust-height`, so that you can grep for the webchannel signal and the app pubsub signal without getting the results mixed up. Feel free to ignore this suggestion, though--it's a small codebase and not all that confusing :-)","created_at":"2015-12-02T23:08:00Z","updated_at":"2015-12-02T23:08:00Z","html_url":"https://github.com/mozilla/universal-search-content/pull/96#discussion_r46490507","pull_request_url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/comments/46490507"},"html":{"href":"https://github.com/mozilla/universal-search-content/pull/96#discussion_r46490507"},"pull_request":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96","id":52467356,"html_url":"https://github.com/mozilla/universal-search-content/pull/96","diff_url":"https://github.com/mozilla/universal-search-content/pull/96.diff","patch_url":"https://github.com/mozilla/universal-search-content/pull/96.patch","issue_url":"https://api.github.com/repos/mozilla/universal-search-content/issues/96","number":96,"state":"open","locked":false,"title":"Post-hoc review fixes from 71829597:","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"body":"* Correctly hides ActivityIndexView if there is exactly 1 activity item.\r\n* Uses a custom resize event with a single listener to prevent needless window resizes.\r\n* Debounces that window resizing.\r\n* Refers to the icon SVG element in CSS with a class rather than by element name.\r\n* Moves SVG from its own view into the index template to prevent needless rerendering.\r\n* Moves padding from body tag to index container.","created_at":"2015-12-02T22:57:28Z","updated_at":"2015-12-02T23:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bec1dab91ed0bfd6486bf6f70f5ba682c7bbcc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96/commits","review_comments_url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96/comments","review_comment_url":"https://api.github.com/repos/mozilla/universal-search-content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/universal-search-content/issues/96/comments","statuses_url":"https://api.github.com/repos/mozilla/universal-search-content/statuses/1c5901101c13ae211fa7ca5aeda93783a9bfd76e","head":{"label":"chuckharmston:24-popup-resize","ref":"24-popup-resize","sha":"1c5901101c13ae211fa7ca5aeda93783a9bfd76e","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"repo":{"id":43758868,"name":"universal-search-content","full_name":"chuckharmston/universal-search-content","owner":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckharmston/universal-search-content","description":"the iframe that we put inside the autocomplete dropdown","fork":true,"url":"https://api.github.com/repos/chuckharmston/universal-search-content","forks_url":"https://api.github.com/repos/chuckharmston/universal-search-content/forks","keys_url":"https://api.github.com/repos/chuckharmston/universal-search-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckharmston/universal-search-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckharmston/universal-search-content/teams","hooks_url":"https://api.github.com/repos/chuckharmston/universal-search-content/hooks","issue_events_url":"https://api.github.com/repos/chuckharmston/universal-search-content/issues/events{/number}","events_url":"https://api.github.com/repos/chuckharmston/universal-search-content/events","assignees_url":"https://api.github.com/repos/chuckharmston/universal-search-content/assignees{/user}","branches_url":"https://api.github.com/repos/chuckharmston/universal-search-content/branches{/branch}","tags_url":"https://api.github.com/repos/chuckharmston/universal-search-content/tags","blobs_url":"https://api.github.com/repos/chuckharmston/universal-search-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckharmston/universal-search-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckharmston/universal-search-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckharmston/universal-search-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckharmston/universal-search-content/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckharmston/universal-search-content/languages","stargazers_url":"https://api.github.com/repos/chuckharmston/universal-search-content/stargazers","contributors_url":"https://api.github.com/repos/chuckharmston/universal-search-content/contributors","subscribers_url":"https://api.github.com/repos/chuckharmston/universal-search-content/subscribers","subscription_url":"https://api.github.com/repos/chuckharmston/universal-search-content/subscription","commits_url":"https://api.github.com/repos/chuckharmston/universal-search-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckharmston/universal-search-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckharmston/universal-search-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckharmston/universal-search-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuckharmston/universal-search-content/contents/{+path}","compare_url":"https://api.github.com/repos/chuckharmston/universal-search-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckharmston/universal-search-content/merges","archive_url":"https://api.github.com/repos/chuckharmston/universal-search-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckharmston/universal-search-content/downloads","issues_url":"https://api.github.com/repos/chuckharmston/universal-search-content/issues{/number}","pulls_url":"https://api.github.com/repos/chuckharmston/universal-search-content/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckharmston/universal-search-content/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckharmston/universal-search-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckharmston/universal-search-content/labels{/name}","releases_url":"https://api.github.com/repos/chuckharmston/universal-search-content/releases{/id}","created_at":"2015-10-06T15:15:51Z","updated_at":"2015-10-06T15:15:52Z","pushed_at":"2015-12-02T22:55:37Z","git_url":"git://github.com/chuckharmston/universal-search-content.git","ssh_url":"git@github.com:chuckharmston/universal-search-content.git","clone_url":"https://github.com/chuckharmston/universal-search-content.git","svn_url":"https://github.com/chuckharmston/universal-search-content","homepage":"","size":181,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"9122b4b94e40b460a2ebf5ac9a8f1f98ab863531","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":33379085,"name":"universal-search-content","full_name":"mozilla/universal-search-content","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/universal-search-content","description":"the iframe that we put inside the autocomplete dropdown","fork":false,"url":"https://api.github.com/repos/mozilla/universal-search-content","forks_url":"https://api.github.com/repos/mozilla/universal-search-content/forks","keys_url":"https://api.github.com/repos/mozilla/universal-search-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/universal-search-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/universal-search-content/teams","hooks_url":"https://api.github.com/repos/mozilla/universal-search-content/hooks","issue_events_url":"https://api.github.com/repos/mozilla/universal-search-content/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/universal-search-content/events","assignees_url":"https://api.github.com/repos/mozilla/universal-search-content/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/universal-search-content/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/universal-search-content/tags","blobs_url":"https://api.github.com/repos/mozilla/universal-search-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/universal-search-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/universal-search-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/universal-search-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/universal-search-content/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/universal-search-content/languages","stargazers_url":"https://api.github.com/repos/mozilla/universal-search-content/stargazers","contributors_url":"https://api.github.com/repos/mozilla/universal-search-content/contributors","subscribers_url":"https://api.github.com/repos/mozilla/universal-search-content/subscribers","subscription_url":"https://api.github.com/repos/mozilla/universal-search-content/subscription","commits_url":"https://api.github.com/repos/mozilla/universal-search-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/universal-search-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/universal-search-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/universal-search-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/universal-search-content/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/universal-search-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/universal-search-content/merges","archive_url":"https://api.github.com/repos/mozilla/universal-search-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/universal-search-content/downloads","issues_url":"https://api.github.com/repos/mozilla/universal-search-content/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/universal-search-content/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/universal-search-content/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/universal-search-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/universal-search-content/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/universal-search-content/releases{/id}","created_at":"2015-04-03T19:27:42Z","updated_at":"2015-10-06T15:15:46Z","pushed_at":"2015-12-02T22:57:29Z","git_url":"git://github.com/mozilla/universal-search-content.git","ssh_url":"git@github.com:mozilla/universal-search-content.git","clone_url":"https://github.com/mozilla/universal-search-content.git","svn_url":"https://github.com/mozilla/universal-search-content","homepage":"","size":190,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":29,"forks":5,"open_issues":29,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96"},"html":{"href":"https://github.com/mozilla/universal-search-content/pull/96"},"issue":{"href":"https://api.github.com/repos/mozilla/universal-search-content/issues/96"},"comments":{"href":"https://api.github.com/repos/mozilla/universal-search-content/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/universal-search-content/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/universal-search-content/statuses/1c5901101c13ae211fa7ca5aeda93783a9bfd76e"}}}}