{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/44014598","id":44014598,"diff_hunk":"@@ -179,6 +179,12 @@ v3f check_v3f(lua_State *L, int index)\n \tCHECK_POS_COORD(\"z\");\n \tpos.Z = lua_tonumber(L, -1);\n \tlua_pop(L, 1);\n+\tif(util_isnan(pos.X))\n+\t\tthrow LuaError(\"NaN passed as X coordinate\");\n+\tif(util_isnan(pos.Y))\n+\t\tthrow LuaError(\"NaN passed as Y coordinate\");\n+\tif(util_isnan(pos.Z))\n+\t\tthrow LuaError(\"NaN passed as Z coordinate\");","path":"src/script/common/c_converter.cpp","position":9,"original_position":9,"commit_id":"767c7b9c3743ea6e13f662a6234a3597be329baf","original_commit_id":"767c7b9c3743ea6e13f662a6234a3597be329baf","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"Precise errors are better than 4 lines less.","created_at":"2015-11-05T14:11:34Z","updated_at":"2015-11-05T14:11:34Z","html_url":"https://github.com/minetest/minetest/pull/3326#discussion_r44014598","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3326","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/44014598"},"html":{"href":"https://github.com/minetest/minetest/pull/3326#discussion_r44014598"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3326"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3326","id":49382035,"html_url":"https://github.com/minetest/minetest/pull/3326","diff_url":"https://github.com/minetest/minetest/pull/3326.diff","patch_url":"https://github.com/minetest/minetest/pull/3326.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3326","number":3326,"state":"open","locked":false,"title":"Check that LuaEntitySAO::setVelocity's parameter and generally Lua's v3f inputs are not NaN","user":{"login":"celeron55","id":115571,"avatar_url":"https://avatars.githubusercontent.com/u/115571?v=3","gravatar_id":"","url":"https://api.github.com/users/celeron55","html_url":"https://github.com/celeron55","followers_url":"https://api.github.com/users/celeron55/followers","following_url":"https://api.github.com/users/celeron55/following{/other_user}","gists_url":"https://api.github.com/users/celeron55/gists{/gist_id}","starred_url":"https://api.github.com/users/celeron55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celeron55/subscriptions","organizations_url":"https://api.github.com/users/celeron55/orgs","repos_url":"https://api.github.com/users/celeron55/repos","events_url":"https://api.github.com/users/celeron55/events{/privacy}","received_events_url":"https://api.github.com/users/celeron55/received_events","type":"User","site_admin":false},"body":"Check that LuaEntitySAO::setVelocity's parameter and generally Lua's v3f inputs are not NaN.\r\n\r\nWithout this change, a mod can crash the server in a hard-to-debug way when NaN is catched at serialization time, losing information about who actually supplied the erroneus value.","created_at":"2015-11-01T21:58:27Z","updated_at":"2015-11-05T14:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d68ed397261e6e405a15850333a57e6c4b8c3ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3326/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3326/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3326/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/767c7b9c3743ea6e13f662a6234a3597be329baf","head":{"label":"celeron55:check_v3f_not_nan","ref":"check_v3f_not_nan","sha":"767c7b9c3743ea6e13f662a6234a3597be329baf","user":{"login":"celeron55","id":115571,"avatar_url":"https://avatars.githubusercontent.com/u/115571?v=3","gravatar_id":"","url":"https://api.github.com/users/celeron55","html_url":"https://github.com/celeron55","followers_url":"https://api.github.com/users/celeron55/followers","following_url":"https://api.github.com/users/celeron55/following{/other_user}","gists_url":"https://api.github.com/users/celeron55/gists{/gist_id}","starred_url":"https://api.github.com/users/celeron55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celeron55/subscriptions","organizations_url":"https://api.github.com/users/celeron55/orgs","repos_url":"https://api.github.com/users/celeron55/repos","events_url":"https://api.github.com/users/celeron55/events{/privacy}","received_events_url":"https://api.github.com/users/celeron55/received_events","type":"User","site_admin":false},"repo":{"id":8933717,"name":"minetest","full_name":"celeron55/minetest","owner":{"login":"celeron55","id":115571,"avatar_url":"https://avatars.githubusercontent.com/u/115571?v=3","gravatar_id":"","url":"https://api.github.com/users/celeron55","html_url":"https://github.com/celeron55","followers_url":"https://api.github.com/users/celeron55/followers","following_url":"https://api.github.com/users/celeron55/following{/other_user}","gists_url":"https://api.github.com/users/celeron55/gists{/gist_id}","starred_url":"https://api.github.com/users/celeron55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celeron55/subscriptions","organizations_url":"https://api.github.com/users/celeron55/orgs","repos_url":"https://api.github.com/users/celeron55/repos","events_url":"https://api.github.com/users/celeron55/events{/privacy}","received_events_url":"https://api.github.com/users/celeron55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/celeron55/minetest","description":"This is celeron55's personal repo. Minetest upstream moved to: https://github.com/minetest/minetest","fork":true,"url":"https://api.github.com/repos/celeron55/minetest","forks_url":"https://api.github.com/repos/celeron55/minetest/forks","keys_url":"https://api.github.com/repos/celeron55/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celeron55/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celeron55/minetest/teams","hooks_url":"https://api.github.com/repos/celeron55/minetest/hooks","issue_events_url":"https://api.github.com/repos/celeron55/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/celeron55/minetest/events","assignees_url":"https://api.github.com/repos/celeron55/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/celeron55/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/celeron55/minetest/tags","blobs_url":"https://api.github.com/repos/celeron55/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celeron55/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celeron55/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/celeron55/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celeron55/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/celeron55/minetest/languages","stargazers_url":"https://api.github.com/repos/celeron55/minetest/stargazers","contributors_url":"https://api.github.com/repos/celeron55/minetest/contributors","subscribers_url":"https://api.github.com/repos/celeron55/minetest/subscribers","subscription_url":"https://api.github.com/repos/celeron55/minetest/subscription","commits_url":"https://api.github.com/repos/celeron55/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/celeron55/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/celeron55/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/celeron55/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/celeron55/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/celeron55/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celeron55/minetest/merges","archive_url":"https://api.github.com/repos/celeron55/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celeron55/minetest/downloads","issues_url":"https://api.github.com/repos/celeron55/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/celeron55/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/celeron55/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/celeron55/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celeron55/minetest/labels{/name}","releases_url":"https://api.github.com/repos/celeron55/minetest/releases{/id}","created_at":"2013-03-21T16:53:20Z","updated_at":"2015-11-01T17:57:51Z","pushed_at":"2015-11-02T09:16:55Z","git_url":"git://github.com/celeron55/minetest.git","ssh_url":"git@github.com:celeron55/minetest.git","clone_url":"https://github.com/celeron55/minetest.git","svn_url":"https://github.com/celeron55/minetest","homepage":"","size":41130,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"eabfe091b5ecfa6e53b70e08faf76df7f0684529","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-11-05T09:12:41Z","pushed_at":"2015-11-05T06:18:44Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":108205,"stargazers_count":1673,"watchers_count":1673,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":559,"mirror_url":null,"open_issues_count":642,"forks":559,"open_issues":642,"watchers":1673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3326"},"html":{"href":"https://github.com/minetest/minetest/pull/3326"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3326"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3326/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3326/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3326/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/767c7b9c3743ea6e13f662a6234a3597be329baf"}}}}