{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/705","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/705/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/705/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/705/events","html_url":"https://github.com/OpenMW/openmw/pull/705","id":98795883,"number":705,"title":"Magic effect verifier","user":{"login":"smbas","id":12299250,"avatar_url":"https://avatars.githubusercontent.com/u/12299250?v=3","gravatar_id":"","url":"https://api.github.com/users/smbas","html_url":"https://github.com/smbas","followers_url":"https://api.github.com/users/smbas/followers","following_url":"https://api.github.com/users/smbas/following{/other_user}","gists_url":"https://api.github.com/users/smbas/gists{/gist_id}","starred_url":"https://api.github.com/users/smbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smbas/subscriptions","organizations_url":"https://api.github.com/users/smbas/orgs","repos_url":"https://api.github.com/users/smbas/repos","events_url":"https://api.github.com/users/smbas/events{/privacy}","received_events_url":"https://api.github.com/users/smbas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-03T17:10:14Z","updated_at":"2015-08-05T08:01:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/705","html_url":"https://github.com/OpenMW/openmw/pull/705","diff_url":"https://github.com/OpenMW/openmw/pull/705.diff","patch_url":"https://github.com/OpenMW/openmw/pull/705.patch"},"body":"The verifier performs the following checks:\r\n* Is the base cost negative?\r\n* Is the icon specified? Does the icon exist? **required string field**\r\n* Is the particle specified? Does the particle (texture) exist?  **required string field**\r\n* Is the description not empty? **required string field**\r\n* Does the object (hit/area/bolt/casting) exist and has a proper type?\r\n* Does the sound (hit/area/bolt/casting) exist?\r\n\r\nThe verifier checks all magic effects, even some of them aren't presented in a content file (such as #138SummonWolf in Morrowind.esm). This leads to unrelated errors. Ignore such effects would be the right solution, but there is no way to distinguish them.\r\n\r\nAlso I don't know what to do with an empty School field. Is it correct to have a magic effect with no school specified?"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/127906187","html_url":"https://github.com/OpenMW/openmw/pull/705#issuecomment-127906187","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/705","id":127906187,"user":{"login":"zinnschlag","id":287696,"avatar_url":"https://avatars.githubusercontent.com/u/287696?v=3","gravatar_id":"","url":"https://api.github.com/users/zinnschlag","html_url":"https://github.com/zinnschlag","followers_url":"https://api.github.com/users/zinnschlag/followers","following_url":"https://api.github.com/users/zinnschlag/following{/other_user}","gists_url":"https://api.github.com/users/zinnschlag/gists{/gist_id}","starred_url":"https://api.github.com/users/zinnschlag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinnschlag/subscriptions","organizations_url":"https://api.github.com/users/zinnschlag/orgs","repos_url":"https://api.github.com/users/zinnschlag/repos","events_url":"https://api.github.com/users/zinnschlag/events{/privacy}","received_events_url":"https://api.github.com/users/zinnschlag/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T08:01:23Z","updated_at":"2015-08-05T08:01:23Z","body":"I am not sure. Is OpenMW taking a effect record without particles?"}}