{"action":"created","issue":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/38","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/38/comments","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/38/events","html_url":"https://github.com/ligo-cbc/pycbc/pull/38","id":85429684,"number":38,"title":"save/load array, timeseries, frequencyseries to hdf","user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars.githubusercontent.com/u/11317236?v=3","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-06-05T05:12:54Z","updated_at":"2015-06-05T13:52:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/38","html_url":"https://github.com/ligo-cbc/pycbc/pull/38","diff_url":"https://github.com/ligo-cbc/pycbc/pull/38.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/38.patch"},"body":"Add the ability to save and load pycbc types to hdf files using the 'save' method or the load_* methods. "},"comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments/109299384","html_url":"https://github.com/ligo-cbc/pycbc/pull/38#issuecomment-109299384","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/38","id":109299384,"user":{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars.githubusercontent.com/u/11317236?v=3","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T13:52:02Z","updated_at":"2015-06-05T13:52:02Z","body":"Looks good, just two comments:\r\n* The docstrings of the changed methods should be updated to mention the additional hdf support.\r\n* To be consistent with the npy and txt formats, the TimeSeries.sample_times and FrequencySeries.sample_frequencies should also be saved along with the actual data."}}