{"action":"created","issue":{"url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/37","labels_url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/37/comments","events_url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/37/events","html_url":"https://github.com/laszlocsontos/liferay-portal/pull/37","id":57009712,"number":37,"title":"[TECHNICAL SUPPORT] LPS-53349 Scheduled LDAP import doesn't work as expected","user":{"login":"NorbertKocsis","id":1876815,"avatar_url":"https://avatars.githubusercontent.com/u/1876815?v=3","gravatar_id":"","url":"https://api.github.com/users/NorbertKocsis","html_url":"https://github.com/NorbertKocsis","followers_url":"https://api.github.com/users/NorbertKocsis/followers","following_url":"https://api.github.com/users/NorbertKocsis/following{/other_user}","gists_url":"https://api.github.com/users/NorbertKocsis/gists{/gist_id}","starred_url":"https://api.github.com/users/NorbertKocsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NorbertKocsis/subscriptions","organizations_url":"https://api.github.com/users/NorbertKocsis/orgs","repos_url":"https://api.github.com/users/NorbertKocsis/repos","events_url":"https://api.github.com/users/NorbertKocsis/events{/privacy}","received_events_url":"https://api.github.com/users/NorbertKocsis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-09T10:00:06Z","updated_at":"2015-02-10T08:59:02Z","closed_at":"2015-02-10T08:59:02Z","pull_request":{"url":"https://api.github.com/repos/laszlocsontos/liferay-portal/pulls/37","html_url":"https://github.com/laszlocsontos/liferay-portal/pull/37","diff_url":"https://github.com/laszlocsontos/liferay-portal/pull/37.diff","patch_url":"https://github.com/laszlocsontos/liferay-portal/pull/37.patch"},"body":"I made the changes we discussed on the previous pull: https://github.com/laszlocsontos/liferay-portal/pull/36"},"comment":{"url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/comments/73665042","html_url":"https://github.com/laszlocsontos/liferay-portal/pull/37#issuecomment-73665042","issue_url":"https://api.github.com/repos/laszlocsontos/liferay-portal/issues/37","id":73665042,"user":{"login":"laszlocsontos","id":1962230,"avatar_url":"https://avatars.githubusercontent.com/u/1962230?v=3","gravatar_id":"","url":"https://api.github.com/users/laszlocsontos","html_url":"https://github.com/laszlocsontos","followers_url":"https://api.github.com/users/laszlocsontos/followers","following_url":"https://api.github.com/users/laszlocsontos/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsontos/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsontos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsontos/subscriptions","organizations_url":"https://api.github.com/users/laszlocsontos/orgs","repos_url":"https://api.github.com/users/laszlocsontos/repos","events_url":"https://api.github.com/users/laszlocsontos/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsontos/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T08:59:02Z","updated_at":"2015-02-10T08:59:02Z","body":"Hi Norbi,\r\n\r\nI've got one concern:\r\nIf LockLocalServiceUtil.hasLock() throws an exception (here: https://github.com/NorbertKocsis/liferay-portal/commit/df07d10629fc7e0aa96fca49388311cd9ef06b75#diff-7003015ac2840a0a1a03247fc637a639R345) ShardUtil.popCompanyService() will not be called. popCompanyService() has to always be in a finally{} block.\r\n\r\nPlease fix that and resend.\r\n\r\nThanks,\r\nLaci"}}