{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/24500426","id":24500426,"diff_hunk":"@@ -4,26 +4,64 @@ import ReactiveCocoa\n import Kiosk\n import Nimble_Snapshots\n \n+class PlaceBidViewControllerConfiguration: QuickConfiguration {\n+    override class func configure(configuration: Configuration) {\n+        sharedExamples(\"a bid view controller view controller\", { (sharedExampleContext: SharedExampleContext) in\n+            var sut: PlaceBidViewController!\n+            var nav: FulfillmentNavigationController!\n+\n+            beforeEach {\n+                sut = sharedExampleContext()[\"sut\"] as PlaceBidViewController!\n+                nav = sharedExampleContext()[\"nav\"] as FulfillmentNavigationController!\n+            }\n+\n+            describe(\"with lot number\") {\n+                beforeEach {\n+                    nav.bidDetails.saleArtwork?.lotNumber = 13\n+                    return","path":"KioskTests/Bid Fulfillment/PlaceBidViewControllerTests.swift","position":18,"original_position":18,"commit_id":"9e66c480e0312d666a73fef0858c7380993bfaee","original_commit_id":"9e66c480e0312d666a73fef0858c7380993bfaee","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"Yup – a bug in Swift fixed in 1.2 (still in beta): `beforeEach` accepts a closure as a property and that closure needs to return `Void`, essentially. The compiler will often misinterpret single-line closures that are supposed to return nothing as single-line closures that are omitting the optional `return` statement and instead want to return the results of the assignment expression. ","created_at":"2015-02-11T15:00:15Z","updated_at":"2015-02-11T15:00:15Z","html_url":"https://github.com/artsy/eidolon/pull/367#discussion_r24500426","pull_request_url":"https://api.github.com/repos/artsy/eidolon/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/24500426"},"html":{"href":"https://github.com/artsy/eidolon/pull/367#discussion_r24500426"},"pull_request":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/367","id":28954484,"html_url":"https://github.com/artsy/eidolon/pull/367","diff_url":"https://github.com/artsy/eidolon/pull/367.diff","patch_url":"https://github.com/artsy/eidolon/pull/367.patch","issue_url":"https://api.github.com/repos/artsy/eidolon/issues/367","number":367,"state":"open","locked":false,"title":"@alloy => Adds lot numbers","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"Lots of small but related changes. For example, removed reference image references from the Xcode project to prevent compiler errors for failing to copy images that have been renamed, as well as un-pending'd a few tests (and made them pass). \r\n\r\n- [x] Listing table cells\r\n- [x] Listing grid cells\r\n- [x] Sale artwork view controller\r\n- [x] Bid fulfillment view controller\r\n\r\nFixes #362.","created_at":"2015-02-09T20:41:20Z","updated_at":"2015-02-11T15:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37bb1786e225071ee7fb8466831a7fd4e991d8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eidolon/pulls/367/commits","review_comments_url":"https://api.github.com/repos/artsy/eidolon/pulls/367/comments","review_comment_url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/artsy/eidolon/issues/367/comments","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/9e66c480e0312d666a73fef0858c7380993bfaee","head":{"label":"artsy:lot-numbers","ref":"lot-numbers","sha":"9e66c480e0312d666a73fef0858c7380993bfaee","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments/{number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","created_at":"2014-08-04T17:38:26Z","updated_at":"2015-02-11T08:47:01Z","pushed_at":"2015-02-11T12:49:49Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":45988,"stargazers_count":419,"watchers_count":419,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":38,"forks":21,"open_issues":38,"watchers":419,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"f4c453893a3c5b65eb1ab0225bea7210d54a8726","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments/{number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","created_at":"2014-08-04T17:38:26Z","updated_at":"2015-02-11T08:47:01Z","pushed_at":"2015-02-11T12:49:49Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":45988,"stargazers_count":419,"watchers_count":419,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":38,"forks":21,"open_issues":38,"watchers":419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/367"},"html":{"href":"https://github.com/artsy/eidolon/pull/367"},"issue":{"href":"https://api.github.com/repos/artsy/eidolon/issues/367"},"comments":{"href":"https://api.github.com/repos/artsy/eidolon/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eidolon/statuses/9e66c480e0312d666a73fef0858c7380993bfaee"}}}}