{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/1241","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/1241/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/1241/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/1241/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/1241","id":84239205,"number":1241,"title":"Stub circles support","user":{"login":"tmcw","id":32314,"avatar_url":"https://avatars.githubusercontent.com/u/32314?v=3","gravatar_id":"","url":"https://api.github.com/users/tmcw","html_url":"https://github.com/tmcw","followers_url":"https://api.github.com/users/tmcw/followers","following_url":"https://api.github.com/users/tmcw/following{/other_user}","gists_url":"https://api.github.com/users/tmcw/gists{/gist_id}","starred_url":"https://api.github.com/users/tmcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmcw/subscriptions","organizations_url":"https://api.github.com/users/tmcw/orgs","repos_url":"https://api.github.com/users/tmcw/repos","events_url":"https://api.github.com/users/tmcw/events{/privacy}","received_events_url":"https://api.github.com/users/tmcw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"tmcw","id":32314,"avatar_url":"https://avatars.githubusercontent.com/u/32314?v=3","gravatar_id":"","url":"https://api.github.com/users/tmcw","html_url":"https://github.com/tmcw","followers_url":"https://api.github.com/users/tmcw/followers","following_url":"https://api.github.com/users/tmcw/following{/other_user}","gists_url":"https://api.github.com/users/tmcw/gists{/gist_id}","starred_url":"https://api.github.com/users/tmcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmcw/subscriptions","organizations_url":"https://api.github.com/users/tmcw/orgs","repos_url":"https://api.github.com/users/tmcw/repos","events_url":"https://api.github.com/users/tmcw/events{/privacy}","received_events_url":"https://api.github.com/users/tmcw/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-06-02T22:24:29Z","updated_at":"2015-06-04T18:52:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/1241","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/1241","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/1241.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/1241.patch"},"body":"Basic support to allow circle in v8 styles. Both the circle_bucket and\r\ndraw_circle need to be implemented.\r\n\r\nThis stub will not draw circles, but is sufficient to keep from failing\r\nwhen it encounters a circle in a stylesheet.\r\n\r\n* Previously: https://github.com/mapbox/mapbox-gl-js/pull/282\r\n\r\n---\r\n\r\n> if you use gl.POINTS you don't need to use indexed drawing. You don't need an element buffer and you would use drawArrays instead of drawElements. The tradeoffs:\r\n> ansis: gl.POINTS only needs one vertex in the buffer per point. gl.TRIANGLES needs 4 vertices.\r\n> ansis: gl.POINTS has a maximum size that varies depending on the platform. gl.TRIANGLES can be any size. I'm trying to find stats on what the minimum max size is for points.\r\n\r\nThe maximum size of a circle appears to be 64 https://developer.apple.com/opengl/capabilities/\r\n\r\nWith that limitation, we'll need to use triangles\r\n\r\n> you'd draw the circular part in the shader. there would be two triangles to make a square. the fragment shader would figure out the distance of each pixel from the center and shade it appropriately"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/109007452","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/1241#issuecomment-109007452","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/1241","id":109007452,"user":{"login":"tmcw","id":32314,"avatar_url":"https://avatars.githubusercontent.com/u/32314?v=3","gravatar_id":"","url":"https://api.github.com/users/tmcw","html_url":"https://github.com/tmcw","followers_url":"https://api.github.com/users/tmcw/followers","following_url":"https://api.github.com/users/tmcw/following{/other_user}","gists_url":"https://api.github.com/users/tmcw/gists{/gist_id}","starred_url":"https://api.github.com/users/tmcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmcw/subscriptions","organizations_url":"https://api.github.com/users/tmcw/orgs","repos_url":"https://api.github.com/users/tmcw/repos","events_url":"https://api.github.com/users/tmcw/events{/privacy}","received_events_url":"https://api.github.com/users/tmcw/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T18:52:02Z","updated_at":"2015-06-04T18:52:02Z","body":"CIRCLES! This branch is ready for review: it draws circles of various colors, with blurring. I assume we'll merge this into the v8 branch if it passes muster?\r\n\r\n/cc @kkaefer @ansis @jfirebaugh @mourner "}}