{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/andes/pulls/comments/41102462","id":41102462,"diff_hunk":"@@ -180,6 +184,45 @@ protected void createConnectionFactories(Map data, Hashtable environment) throws\n         }\n     }\n \n+    /**\n+     * Resolve carbon secure vault encrypted properties.\n+     * @param environment property values which need to construct the InitialContext\n+     */\n+    private static void resolveEncryptedProperties(Hashtable environment) {\n+\n+        if (environment != null) {\n+\n+            Properties properties = convertToProperties(environment);\n+            SecretResolver secretResolver = SecretResolverFactory.create(properties);\n+\n+            for (Object key : environment.keySet()) {\n+\n+                if (secretResolver != null && secretResolver.isInitialized()) {\n+                    if (secretResolver.isTokenProtected(key.toString())) {\n+                        environment.put(key.toString(), secretResolver.resolve(key.toString()));\n+                    }\n+                }\n+\n+            }\n+","path":"modules/andes-core/client/src/main/java/org/wso2/andes/jndi/PropertiesFileInitialContextFactory.java","position":42,"original_position":42,"commit_id":"f6b296048ae8174faf2abe85d213564b40042579","original_commit_id":"f6b296048ae8174faf2abe85d213564b40042579","user":{"login":"shafreenAnfar","id":6178058,"avatar_url":"https://avatars.githubusercontent.com/u/6178058?v=3","gravatar_id":"","url":"https://api.github.com/users/shafreenAnfar","html_url":"https://github.com/shafreenAnfar","followers_url":"https://api.github.com/users/shafreenAnfar/followers","following_url":"https://api.github.com/users/shafreenAnfar/following{/other_user}","gists_url":"https://api.github.com/users/shafreenAnfar/gists{/gist_id}","starred_url":"https://api.github.com/users/shafreenAnfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shafreenAnfar/subscriptions","organizations_url":"https://api.github.com/users/shafreenAnfar/orgs","repos_url":"https://api.github.com/users/shafreenAnfar/repos","events_url":"https://api.github.com/users/shafreenAnfar/events{/privacy}","received_events_url":"https://api.github.com/users/shafreenAnfar/received_events","type":"User","site_admin":false},"body":"Remove the space.","created_at":"2015-10-04T21:13:29Z","updated_at":"2015-10-04T21:13:29Z","html_url":"https://github.com/wso2/andes/pull/253#discussion_r41102462","pull_request_url":"https://api.github.com/repos/wso2/andes/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments/41102462"},"html":{"href":"https://github.com/wso2/andes/pull/253#discussion_r41102462"},"pull_request":{"href":"https://api.github.com/repos/wso2/andes/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/andes/pulls/253","id":41436714,"html_url":"https://github.com/wso2/andes/pull/253","diff_url":"https://github.com/wso2/andes/pull/253.diff","patch_url":"https://github.com/wso2/andes/pull/253.patch","issue_url":"https://api.github.com/repos/wso2/andes/issues/253","number":253,"state":"closed","locked":false,"title":"[MB-1161]Add secure vault support to the andes client","user":{"login":"prabathariyaratna","id":7678033,"avatar_url":"https://avatars.githubusercontent.com/u/7678033?v=3","gravatar_id":"","url":"https://api.github.com/users/prabathariyaratna","html_url":"https://github.com/prabathariyaratna","followers_url":"https://api.github.com/users/prabathariyaratna/followers","following_url":"https://api.github.com/users/prabathariyaratna/following{/other_user}","gists_url":"https://api.github.com/users/prabathariyaratna/gists{/gist_id}","starred_url":"https://api.github.com/users/prabathariyaratna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabathariyaratna/subscriptions","organizations_url":"https://api.github.com/users/prabathariyaratna/orgs","repos_url":"https://api.github.com/users/prabathariyaratna/repos","events_url":"https://api.github.com/users/prabathariyaratna/events{/privacy}","received_events_url":"https://api.github.com/users/prabathariyaratna/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-03T05:52:15Z","updated_at":"2015-10-04T21:13:29Z","closed_at":"2015-08-03T05:58:56Z","merged_at":"2015-08-03T05:58:56Z","merge_commit_sha":"b576f6dcfd3ec6382f10f91eac23f2019ea4465f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/andes/pulls/253/commits","review_comments_url":"https://api.github.com/repos/wso2/andes/pulls/253/comments","review_comment_url":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/andes/issues/253/comments","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/f6b296048ae8174faf2abe85d213564b40042579","head":{"label":"prabathariyaratna:securevault","ref":"securevault","sha":"f6b296048ae8174faf2abe85d213564b40042579","user":{"login":"prabathariyaratna","id":7678033,"avatar_url":"https://avatars.githubusercontent.com/u/7678033?v=3","gravatar_id":"","url":"https://api.github.com/users/prabathariyaratna","html_url":"https://github.com/prabathariyaratna","followers_url":"https://api.github.com/users/prabathariyaratna/followers","following_url":"https://api.github.com/users/prabathariyaratna/following{/other_user}","gists_url":"https://api.github.com/users/prabathariyaratna/gists{/gist_id}","starred_url":"https://api.github.com/users/prabathariyaratna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabathariyaratna/subscriptions","organizations_url":"https://api.github.com/users/prabathariyaratna/orgs","repos_url":"https://api.github.com/users/prabathariyaratna/repos","events_url":"https://api.github.com/users/prabathariyaratna/events{/privacy}","received_events_url":"https://api.github.com/users/prabathariyaratna/received_events","type":"User","site_admin":false},"repo":{"id":39368873,"name":"andes","full_name":"prabathariyaratna/andes","owner":{"login":"prabathariyaratna","id":7678033,"avatar_url":"https://avatars.githubusercontent.com/u/7678033?v=3","gravatar_id":"","url":"https://api.github.com/users/prabathariyaratna","html_url":"https://github.com/prabathariyaratna","followers_url":"https://api.github.com/users/prabathariyaratna/followers","following_url":"https://api.github.com/users/prabathariyaratna/following{/other_user}","gists_url":"https://api.github.com/users/prabathariyaratna/gists{/gist_id}","starred_url":"https://api.github.com/users/prabathariyaratna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabathariyaratna/subscriptions","organizations_url":"https://api.github.com/users/prabathariyaratna/orgs","repos_url":"https://api.github.com/users/prabathariyaratna/repos","events_url":"https://api.github.com/users/prabathariyaratna/events{/privacy}","received_events_url":"https://api.github.com/users/prabathariyaratna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prabathariyaratna/andes","description":"","fork":true,"url":"https://api.github.com/repos/prabathariyaratna/andes","forks_url":"https://api.github.com/repos/prabathariyaratna/andes/forks","keys_url":"https://api.github.com/repos/prabathariyaratna/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prabathariyaratna/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prabathariyaratna/andes/teams","hooks_url":"https://api.github.com/repos/prabathariyaratna/andes/hooks","issue_events_url":"https://api.github.com/repos/prabathariyaratna/andes/issues/events{/number}","events_url":"https://api.github.com/repos/prabathariyaratna/andes/events","assignees_url":"https://api.github.com/repos/prabathariyaratna/andes/assignees{/user}","branches_url":"https://api.github.com/repos/prabathariyaratna/andes/branches{/branch}","tags_url":"https://api.github.com/repos/prabathariyaratna/andes/tags","blobs_url":"https://api.github.com/repos/prabathariyaratna/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prabathariyaratna/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prabathariyaratna/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/prabathariyaratna/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prabathariyaratna/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/prabathariyaratna/andes/languages","stargazers_url":"https://api.github.com/repos/prabathariyaratna/andes/stargazers","contributors_url":"https://api.github.com/repos/prabathariyaratna/andes/contributors","subscribers_url":"https://api.github.com/repos/prabathariyaratna/andes/subscribers","subscription_url":"https://api.github.com/repos/prabathariyaratna/andes/subscription","commits_url":"https://api.github.com/repos/prabathariyaratna/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/prabathariyaratna/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/prabathariyaratna/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/prabathariyaratna/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/prabathariyaratna/andes/contents/{+path}","compare_url":"https://api.github.com/repos/prabathariyaratna/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prabathariyaratna/andes/merges","archive_url":"https://api.github.com/repos/prabathariyaratna/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prabathariyaratna/andes/downloads","issues_url":"https://api.github.com/repos/prabathariyaratna/andes/issues{/number}","pulls_url":"https://api.github.com/repos/prabathariyaratna/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/prabathariyaratna/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/prabathariyaratna/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prabathariyaratna/andes/labels{/name}","releases_url":"https://api.github.com/repos/prabathariyaratna/andes/releases{/id}","created_at":"2015-07-20T07:12:18Z","updated_at":"2015-07-20T07:12:24Z","pushed_at":"2015-08-03T05:49:26Z","git_url":"git://github.com/prabathariyaratna/andes.git","ssh_url":"git@github.com:prabathariyaratna/andes.git","clone_url":"https://github.com/prabathariyaratna/andes.git","svn_url":"https://github.com/prabathariyaratna/andes","homepage":null,"size":65584,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"0d6dd13cbb48f4f7a09b6b5a7abb41d733617815","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":20559270,"name":"andes","full_name":"wso2/andes","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/andes","description":"","fork":false,"url":"https://api.github.com/repos/wso2/andes","forks_url":"https://api.github.com/repos/wso2/andes/forks","keys_url":"https://api.github.com/repos/wso2/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/andes/teams","hooks_url":"https://api.github.com/repos/wso2/andes/hooks","issue_events_url":"https://api.github.com/repos/wso2/andes/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/andes/events","assignees_url":"https://api.github.com/repos/wso2/andes/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/andes/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/andes/tags","blobs_url":"https://api.github.com/repos/wso2/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/andes/languages","stargazers_url":"https://api.github.com/repos/wso2/andes/stargazers","contributors_url":"https://api.github.com/repos/wso2/andes/contributors","subscribers_url":"https://api.github.com/repos/wso2/andes/subscribers","subscription_url":"https://api.github.com/repos/wso2/andes/subscription","commits_url":"https://api.github.com/repos/wso2/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/andes/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/andes/merges","archive_url":"https://api.github.com/repos/wso2/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/andes/downloads","issues_url":"https://api.github.com/repos/wso2/andes/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/andes/labels{/name}","releases_url":"https://api.github.com/repos/wso2/andes/releases{/id}","created_at":"2014-06-06T10:04:24Z","updated_at":"2015-05-05T14:31:31Z","pushed_at":"2015-10-03T12:54:09Z","git_url":"git://github.com/wso2/andes.git","ssh_url":"git@github.com:wso2/andes.git","clone_url":"https://github.com/wso2/andes.git","svn_url":"https://github.com/wso2/andes","homepage":null,"size":70227,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":6,"forks":38,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/253"},"html":{"href":"https://github.com/wso2/andes/pull/253"},"issue":{"href":"https://api.github.com/repos/wso2/andes/issues/253"},"comments":{"href":"https://api.github.com/repos/wso2/andes/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/andes/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/andes/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/andes/statuses/f6b296048ae8174faf2abe85d213564b40042579"}}}}