{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/32852481","id":32852481,"diff_hunk":"@@ -15,13 +15,15 @@\n package api\n \n const (\n-\tLabelPodId         = \"pod_id\"\n-\tLabelPodName       = \"pod_name\"\n-\tLabelPodNamespace  = \"pod_namespace\"\n-\tLabelContainerName = \"container_name\"\n-\tLabelLabels        = \"labels\"\n-\tLabelHostname      = \"hostname\"\n-\tLabelResourceID    = \"resource_id\"\n+\tLabelPodId               = \"pod_id\"\n+\tLabelPodName             = \"pod_name\"\n+\tLabelPodNamespace        = \"pod_namespace\"\n+\tLabelContainerName       = \"container_name\"\n+\tLabelLabels              = \"labels\"\n+\tLabelHostname            = \"hostname\"\n+\tLabelResourceID          = \"resource_id\"\n+\tLabelComputeResourceID   = \"compute.googleapis.com/resource_id\"","path":"sinks/api/supported_labels.go","position":20,"original_position":18,"commit_id":"a302fde4f62518eb794cd9ef3d07b99101d3d8a7","original_commit_id":"620e8731eedfa98209bda4a7a7bcf36ebe400095","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"Ah! Naming is hard :( Lets not overload \"resource_id\", since it is required for filesystem metrics.\r\nDoes \"instance id\" have to be called \"resource_id\"? Can we call it \"host_id\" instead in GCM side?","created_at":"2015-06-19T17:52:10Z","updated_at":"2015-06-19T17:52:10Z","html_url":"https://github.com/GoogleCloudPlatform/heapster/pull/334#discussion_r32852481","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/32852481"},"html":{"href":"https://github.com/GoogleCloudPlatform/heapster/pull/334#discussion_r32852481"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334","id":37453453,"html_url":"https://github.com/GoogleCloudPlatform/heapster/pull/334","diff_url":"https://github.com/GoogleCloudPlatform/heapster/pull/334.diff","patch_url":"https://github.com/GoogleCloudPlatform/heapster/pull/334.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/334","number":334,"state":"open","locked":false,"title":"Additional node metrics for autoscaling.","user":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"body":"Added additional node metrics (tracking cpu and mem usage) together with additional lables. They are in format compatible with cloud autoscaler, and they can be used to autoscale the numer of nodes in a cluster.","created_at":"2015-06-11T11:26:46Z","updated_at":"2015-06-19T17:52:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6875aaad053ace16ca2c6e2c542eaaaab6bc04ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/334/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/a302fde4f62518eb794cd9ef3d07b99101d3d8a7","head":{"label":"jszczepkowski:autoscaler-metrics","ref":"autoscaler-metrics","sha":"a302fde4f62518eb794cd9ef3d07b99101d3d8a7","user":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"repo":{"id":36804762,"name":"heapster","full_name":"jszczepkowski/heapster","owner":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jszczepkowski/heapster","description":"Monitor container resource usage of a Kubernetes cluster","fork":true,"url":"https://api.github.com/repos/jszczepkowski/heapster","forks_url":"https://api.github.com/repos/jszczepkowski/heapster/forks","keys_url":"https://api.github.com/repos/jszczepkowski/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jszczepkowski/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jszczepkowski/heapster/teams","hooks_url":"https://api.github.com/repos/jszczepkowski/heapster/hooks","issue_events_url":"https://api.github.com/repos/jszczepkowski/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/jszczepkowski/heapster/events","assignees_url":"https://api.github.com/repos/jszczepkowski/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/jszczepkowski/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/jszczepkowski/heapster/tags","blobs_url":"https://api.github.com/repos/jszczepkowski/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jszczepkowski/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jszczepkowski/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jszczepkowski/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jszczepkowski/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/jszczepkowski/heapster/languages","stargazers_url":"https://api.github.com/repos/jszczepkowski/heapster/stargazers","contributors_url":"https://api.github.com/repos/jszczepkowski/heapster/contributors","subscribers_url":"https://api.github.com/repos/jszczepkowski/heapster/subscribers","subscription_url":"https://api.github.com/repos/jszczepkowski/heapster/subscription","commits_url":"https://api.github.com/repos/jszczepkowski/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jszczepkowski/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jszczepkowski/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jszczepkowski/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jszczepkowski/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/jszczepkowski/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jszczepkowski/heapster/merges","archive_url":"https://api.github.com/repos/jszczepkowski/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jszczepkowski/heapster/downloads","issues_url":"https://api.github.com/repos/jszczepkowski/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/jszczepkowski/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/jszczepkowski/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/jszczepkowski/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jszczepkowski/heapster/labels{/name}","releases_url":"https://api.github.com/repos/jszczepkowski/heapster/releases{/id}","created_at":"2015-06-03T13:17:40Z","updated_at":"2015-06-03T13:17:41Z","pushed_at":"2015-06-16T12:08:14Z","git_url":"git://github.com/jszczepkowski/heapster.git","ssh_url":"git@github.com:jszczepkowski/heapster.git","clone_url":"https://github.com/jszczepkowski/heapster.git","svn_url":"https://github.com/jszczepkowski/heapster","homepage":"","size":19606,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ab46d8970f4d90424d6f8926285978fa5a3b0e04","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"name":"heapster","full_name":"GoogleCloudPlatform/heapster","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/heapster","description":"Monitor container resource usage of a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/releases{/id}","created_at":"2014-08-24T03:50:18Z","updated_at":"2015-06-19T09:03:12Z","pushed_at":"2015-06-19T16:53:09Z","git_url":"git://github.com/GoogleCloudPlatform/heapster.git","ssh_url":"git@github.com:GoogleCloudPlatform/heapster.git","clone_url":"https://github.com/GoogleCloudPlatform/heapster.git","svn_url":"https://github.com/GoogleCloudPlatform/heapster","homepage":"","size":21507,"stargazers_count":316,"watchers_count":316,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":67,"forks":76,"open_issues":67,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334"},"html":{"href":"https://github.com/GoogleCloudPlatform/heapster/pull/334"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/334"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/a302fde4f62518eb794cd9ef3d07b99101d3d8a7"}}}}