{"action":"created","issue":{"url":"https://api.github.com/repos/saz/puppet-ssh/issues/98","labels_url":"https://api.github.com/repos/saz/puppet-ssh/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/saz/puppet-ssh/issues/98/comments","events_url":"https://api.github.com/repos/saz/puppet-ssh/issues/98/events","html_url":"https://github.com/saz/puppet-ssh/pull/98","id":65243992,"number":98,"title":"Revert \"Add explicit allow_virtual parameters\"","user":{"login":"sbadia","id":420848,"avatar_url":"https://avatars.githubusercontent.com/u/420848?v=3","gravatar_id":"","url":"https://api.github.com/users/sbadia","html_url":"https://github.com/sbadia","followers_url":"https://api.github.com/users/sbadia/followers","following_url":"https://api.github.com/users/sbadia/following{/other_user}","gists_url":"https://api.github.com/users/sbadia/gists{/gist_id}","starred_url":"https://api.github.com/users/sbadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbadia/subscriptions","organizations_url":"https://api.github.com/users/sbadia/orgs","repos_url":"https://api.github.com/users/sbadia/repos","events_url":"https://api.github.com/users/sbadia/events{/privacy}","received_events_url":"https://api.github.com/users/sbadia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"saz","id":402629,"avatar_url":"https://avatars.githubusercontent.com/u/402629?v=3","gravatar_id":"","url":"https://api.github.com/users/saz","html_url":"https://github.com/saz","followers_url":"https://api.github.com/users/saz/followers","following_url":"https://api.github.com/users/saz/following{/other_user}","gists_url":"https://api.github.com/users/saz/gists{/gist_id}","starred_url":"https://api.github.com/users/saz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saz/subscriptions","organizations_url":"https://api.github.com/users/saz/orgs","repos_url":"https://api.github.com/users/saz/repos","events_url":"https://api.github.com/users/saz/events{/privacy}","received_events_url":"https://api.github.com/users/saz/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-03-30T15:55:52Z","updated_at":"2015-04-08T08:08:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saz/puppet-ssh/pulls/98","html_url":"https://github.com/saz/puppet-ssh/pull/98","diff_url":"https://github.com/saz/puppet-ssh/pull/98.diff","patch_url":"https://github.com/saz/puppet-ssh/pull/98.patch"},"body":"This reverts commit f63ae3b0b15927625b06e7db093ac661743a9ecf.\r\n\r\n`allow_virtual` parameter was added in Puppet 3.6.1. On Puppet version\r\nbefore this version, this parameter cause a catalogue compilation fail\r\n`Invalid parameter allow_virtual`.\r\n\r\nRefs: https://tickets.puppetlabs.com/browse/PUP-2746\r\n\r\nThis parameter should not be managed inside this module, but on top side\r\nor in puppet configuration file.\r\n\r\n```puppet\r\n# site.pp or assimilated\r\nif versioncmp($::puppetversion,'3.6.1') >= 0 {\r\n  $allow_virtual_packages = hiera('allow_virtual_packages',false)\r\n  Package {\r\n    allow_virtual => $allow_virtual_packages,\r\n  }\r\n}\r\n```\r\n\r\nOr in puppet.conf, in order to remove warnings\r\n\r\n```puppet\r\n# puppet.conf\r\n[main]\r\ndisable_warnings=deprecations\r\n```\r\n\r\nRefs: https://docs.puppetlabs.com/references/latest/configuration.html#disablewarnings\r\n"},"comment":{"url":"https://api.github.com/repos/saz/puppet-ssh/issues/comments/90837750","html_url":"https://github.com/saz/puppet-ssh/pull/98#issuecomment-90837750","issue_url":"https://api.github.com/repos/saz/puppet-ssh/issues/98","id":90837750,"user":{"login":"sbadia","id":420848,"avatar_url":"https://avatars.githubusercontent.com/u/420848?v=3","gravatar_id":"","url":"https://api.github.com/users/sbadia","html_url":"https://github.com/sbadia","followers_url":"https://api.github.com/users/sbadia/followers","following_url":"https://api.github.com/users/sbadia/following{/other_user}","gists_url":"https://api.github.com/users/sbadia/gists{/gist_id}","starred_url":"https://api.github.com/users/sbadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbadia/subscriptions","organizations_url":"https://api.github.com/users/sbadia/orgs","repos_url":"https://api.github.com/users/sbadia/repos","events_url":"https://api.github.com/users/sbadia/events{/privacy}","received_events_url":"https://api.github.com/users/sbadia/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T08:08:59Z","updated_at":"2015-04-08T08:08:59Z","body":"thanks :)"}}