{"action":"created","comment":{"url":"https://api.github.com/repos/atom/electron/pulls/comments/47219449","id":47219449,"diff_hunk":"@@ -0,0 +1,388 @@\n+// Copyright (c) 2015 GitHub, Inc.\n+// Use of this source code is governed by the MIT license that can be\n+// found in the LICENSE file.\n+\n+#include \"atom/browser/net/atom_network_delegate.h\"\n+\n+#include \"atom/common/native_mate_converters/net_converter.h\"\n+#include \"content/public/browser/browser_thread.h\"\n+#include \"content/public/browser/resource_request_info.h\"\n+#include \"net/url_request/url_request.h\"\n+\n+using content::BrowserThread;\n+\n+namespace atom {\n+\n+namespace {\n+\n+std::string ResourceTypeToString(content::ResourceType type) {\n+  switch (type) {\n+    case content::RESOURCE_TYPE_MAIN_FRAME:\n+      return \"main_frame\";\n+    case content::RESOURCE_TYPE_SUB_FRAME:\n+      return \"sub_frame\";\n+    case content::RESOURCE_TYPE_STYLESHEET:\n+      return \"stylesheet\";\n+    case content::RESOURCE_TYPE_SCRIPT:\n+      return \"script\";\n+    case content::RESOURCE_TYPE_IMAGE:\n+      return \"image\";\n+    case content::RESOURCE_TYPE_OBJECT:\n+      return \"object\";\n+    case content::RESOURCE_TYPE_XHR:\n+      return \"xmlhttprequest\";\n+    default:\n+      return \"other\";\n+  }\n+}\n+\n+AtomNetworkDelegate::BlockingResponse RunListener(\n+    const AtomNetworkDelegate::Listener& callback,\n+    scoped_ptr<base::DictionaryValue> details) {\n+  return callback.Run(*(details.get()));\n+}\n+\n+bool MatchesFilterCondition(\n+    net::URLRequest* request,\n+    const AtomNetworkDelegate::ListenerInfo& info) {\n+  if (!info.url_patterns.empty()) {\n+    auto url = request->url();\n+    for (auto& pattern : info.url_patterns)\n+      if (pattern.MatchesURL(url))\n+        return true;\n+    return false;\n+  }\n+\n+  return true;\n+}\n+\n+scoped_ptr<base::DictionaryValue> ExtractRequestInfo(net::URLRequest* request) {\n+  scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());\n+  dict->SetInteger(\"id\", request->identifier());\n+  dict->SetString(\"url\", request->url().spec());\n+  dict->SetString(\"method\", request->method());\n+  content::ResourceType resourceType = content::RESOURCE_TYPE_LAST_TYPE;\n+  auto info = content::ResourceRequestInfo::ForRequest(request);\n+  if (info)\n+    resourceType = info->GetResourceType();\n+  dict->SetString(\"resourceType\", ResourceTypeToString(resourceType));\n+  dict->SetDouble(\"timestamp\", base::Time::Now().ToDoubleT() * 1000);\n+\n+  return dict.Pass();\n+}\n+\n+base::DictionaryValue* GetRequestHeadersDict(","path":"atom/browser/net/atom_network_delegate.cc","position":74,"original_position":74,"commit_id":"ad03a27ca608076e657239903618c240686755e2","original_commit_id":"ad03a27ca608076e657239903618c240686755e2","user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"body":"The `base::DictionaryValue*` should also be wrapped in `scoped_ptr` here,  and in `GetResponseHeadersDict` bellow.","created_at":"2015-12-10T12:19:16Z","updated_at":"2015-12-10T12:19:16Z","html_url":"https://github.com/atom/electron/pull/3640#discussion_r47219449","pull_request_url":"https://api.github.com/repos/atom/electron/pulls/3640","_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/comments/47219449"},"html":{"href":"https://github.com/atom/electron/pull/3640#discussion_r47219449"},"pull_request":{"href":"https://api.github.com/repos/atom/electron/pulls/3640"}}},"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/3640","id":52217817,"html_url":"https://github.com/atom/electron/pull/3640","diff_url":"https://github.com/atom/electron/pull/3640.diff","patch_url":"https://github.com/atom/electron/pull/3640.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/3640","number":3640,"state":"open","locked":false,"title":"session: add webrequest api","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"```\r\nsession.webRequest.<method>([filter,] function(details) {\r\n  return result\r\n})\r\n```\r\nwhere result and details will be same as `chrome.webRequest.details` and [chrome.webRequest.BlockingResponse](https://developer.chrome.com/extensions/webRequest#type-BlockingResponse)\r\n\r\n- [x] Filter with URL regex\r\n\r\nFixes #2115 ","created_at":"2015-12-01T05:29:12Z","updated_at":"2015-12-10T12:19:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72397df046f96fb0d2bbb180bc6475ef153c1b0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/3640/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/3640/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/3640/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/ad03a27ca608076e657239903618c240686755e2","head":{"label":"deepak1556:webrequest_api_patch","ref":"webrequest_api_patch","sha":"ad03a27ca608076e657239903618c240686755e2","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":19500833,"name":"atom-shell","full_name":"deepak1556/atom-shell","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/atom-shell","description":"Cross-platform desktop application shell","fork":true,"url":"https://api.github.com/repos/deepak1556/atom-shell","forks_url":"https://api.github.com/repos/deepak1556/atom-shell/forks","keys_url":"https://api.github.com/repos/deepak1556/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/atom-shell/teams","hooks_url":"https://api.github.com/repos/deepak1556/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/atom-shell/events","assignees_url":"https://api.github.com/repos/deepak1556/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/atom-shell/tags","blobs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/atom-shell/languages","stargazers_url":"https://api.github.com/repos/deepak1556/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/atom-shell/subscription","commits_url":"https://api.github.com/repos/deepak1556/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepak1556/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/atom-shell/merges","archive_url":"https://api.github.com/repos/deepak1556/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/atom-shell/downloads","issues_url":"https://api.github.com/repos/deepak1556/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/atom-shell/releases{/id}","created_at":"2014-05-06T15:58:25Z","updated_at":"2015-07-17T09:40:10Z","pushed_at":"2015-12-09T19:16:28Z","git_url":"git://github.com/deepak1556/atom-shell.git","ssh_url":"git@github.com:deepak1556/atom-shell.git","clone_url":"https://github.com/deepak1556/atom-shell.git","svn_url":"https://github.com/deepak1556/atom-shell","homepage":"","size":12442,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"d2e63dfc644e323bf23fbd6654f7493ed94d7991","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-12-10T12:18:57Z","pushed_at":"2015-12-10T11:52:05Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":15866,"stargazers_count":20781,"watchers_count":20781,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1956,"mirror_url":null,"open_issues_count":267,"forks":1956,"open_issues":267,"watchers":20781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/3640"},"html":{"href":"https://github.com/atom/electron/pull/3640"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/3640"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/3640/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/3640/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/3640/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/ad03a27ca608076e657239903618c240686755e2"}}}}