{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/29103445","id":29103445,"diff_hunk":"@@ -0,0 +1,35 @@\n+require 'spec_helper'\n+\n+describe SplitTest do\n+  let(:converter) { CohortConverter.new('spec/test_data.json') }\n+  let(:test) { described_class.new(converter.cohorts) }\n+\n+  describe '#new' do\n+    it 'takes a collection of cohorts and returns a SplitTest object' do\n+      expect(test).instance_of? described_class\n+    end\n+  end\n+\n+  describe '#cohorts' do\n+    it 'returns a collection of cohorts' do\n+      expect(test).instance_of? described_class\n+    end\n+  end\n+\n+  describe '#conversion_rates'\n+    it 'returns a collection of conversion rates, one for each cohort' do\n+      expect(test.conversion_rates[0]).to eq(0.5728155339805825)\n+    end\n+\n+  describe '#confidence' do\n+    it 'finds min/max predictions for a given confidence level' do\n+      expect(test.confidence[0]).to eq([0.5300927453027154, 0.6155383226584495])\n+    end\n+  end\n+\n+  describe '#chi_square' do\n+    it 'returns the p values for a chi_square test' do\n+      expect(test.chi_square).to eq(5.1514348342607263e-14)\n+    end","path":"data_science/spec/split_test_spec.rb","position":33,"original_position":33,"commit_id":"7ab4f5f271961c80259d1a14682c2c4cbf7a01a4","original_commit_id":"7ab4f5f271961c80259d1a14682c2c4cbf7a01a4","user":{"login":"zsyed1","id":8593056,"avatar_url":"https://avatars.githubusercontent.com/u/8593056?v=3","gravatar_id":"","url":"https://api.github.com/users/zsyed1","html_url":"https://github.com/zsyed1","followers_url":"https://api.github.com/users/zsyed1/followers","following_url":"https://api.github.com/users/zsyed1/following{/other_user}","gists_url":"https://api.github.com/users/zsyed1/gists{/gist_id}","starred_url":"https://api.github.com/users/zsyed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsyed1/subscriptions","organizations_url":"https://api.github.com/users/zsyed1/orgs","repos_url":"https://api.github.com/users/zsyed1/repos","events_url":"https://api.github.com/users/zsyed1/events{/privacy}","received_events_url":"https://api.github.com/users/zsyed1/received_events","type":"User","site_admin":false},"body":"Did you generate the data randomly? (`test_data.json`)\r\nThat would make the chi-square close to zero. If instead you made the proportions of successes high like 75% for A and 50% of B you would get a better value (for testing). This is not a coding concern though so don't worry about it.","created_at":"2015-04-25T19:42:50Z","updated_at":"2015-04-25T19:42:50Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/636#discussion_r29103445","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/29103445"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/636#discussion_r29103445"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636","id":34001743,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/636","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/636.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/636.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/636","number":636,"state":"open","locked":false,"title":"Avascience","user":{"login":"avavita","id":11299471,"avatar_url":"https://avatars.githubusercontent.com/u/11299471?v=3","gravatar_id":"","url":"https://api.github.com/users/avavita","html_url":"https://github.com/avavita","followers_url":"https://api.github.com/users/avavita/followers","following_url":"https://api.github.com/users/avavita/following{/other_user}","gists_url":"https://api.github.com/users/avavita/gists{/gist_id}","starred_url":"https://api.github.com/users/avavita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avavita/subscriptions","organizations_url":"https://api.github.com/users/avavita/orgs","repos_url":"https://api.github.com/users/avavita/repos","events_url":"https://api.github.com/users/avavita/events{/privacy}","received_events_url":"https://api.github.com/users/avavita/received_events","type":"User","site_admin":false},"body":"\"It is a wise man that plays the fool.\" ","created_at":"2015-04-23T22:07:01Z","updated_at":"2015-04-25T19:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c06982a6af18ea93840c44e773240c2ca9e695e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/636/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/7ab4f5f271961c80259d1a14682c2c4cbf7a01a4","head":{"label":"avavita:avascience","ref":"avascience","sha":"7ab4f5f271961c80259d1a14682c2c4cbf7a01a4","user":{"login":"avavita","id":11299471,"avatar_url":"https://avatars.githubusercontent.com/u/11299471?v=3","gravatar_id":"","url":"https://api.github.com/users/avavita","html_url":"https://github.com/avavita","followers_url":"https://api.github.com/users/avavita/followers","following_url":"https://api.github.com/users/avavita/following{/other_user}","gists_url":"https://api.github.com/users/avavita/gists{/gist_id}","starred_url":"https://api.github.com/users/avavita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avavita/subscriptions","organizations_url":"https://api.github.com/users/avavita/orgs","repos_url":"https://api.github.com/users/avavita/repos","events_url":"https://api.github.com/users/avavita/events{/privacy}","received_events_url":"https://api.github.com/users/avavita/received_events","type":"User","site_admin":false},"repo":{"id":31669931,"name":"level_up_exercises","full_name":"avavita/level_up_exercises","owner":{"login":"avavita","id":11299471,"avatar_url":"https://avatars.githubusercontent.com/u/11299471?v=3","gravatar_id":"","url":"https://api.github.com/users/avavita","html_url":"https://github.com/avavita","followers_url":"https://api.github.com/users/avavita/followers","following_url":"https://api.github.com/users/avavita/following{/other_user}","gists_url":"https://api.github.com/users/avavita/gists{/gist_id}","starred_url":"https://api.github.com/users/avavita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avavita/subscriptions","organizations_url":"https://api.github.com/users/avavita/orgs","repos_url":"https://api.github.com/users/avavita/repos","events_url":"https://api.github.com/users/avavita/events{/privacy}","received_events_url":"https://api.github.com/users/avavita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avavita/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/avavita/level_up_exercises","forks_url":"https://api.github.com/repos/avavita/level_up_exercises/forks","keys_url":"https://api.github.com/repos/avavita/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avavita/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avavita/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/avavita/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/avavita/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/avavita/level_up_exercises/events","assignees_url":"https://api.github.com/repos/avavita/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/avavita/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/avavita/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/avavita/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avavita/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avavita/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/avavita/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avavita/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/avavita/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/avavita/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/avavita/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/avavita/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/avavita/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/avavita/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/avavita/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/avavita/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/avavita/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/avavita/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/avavita/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avavita/level_up_exercises/merges","archive_url":"https://api.github.com/repos/avavita/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avavita/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/avavita/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/avavita/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/avavita/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/avavita/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avavita/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/avavita/level_up_exercises/releases{/id}","created_at":"2015-03-04T17:26:04Z","updated_at":"2015-03-30T19:59:23Z","pushed_at":"2015-04-23T22:02:42Z","git_url":"git://github.com/avavita/level_up_exercises.git","ssh_url":"git@github.com:avavita/level_up_exercises.git","clone_url":"https://github.com/avavita/level_up_exercises.git","svn_url":"https://github.com/avavita/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":461,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"b941842eff3e5c5063d323069d7096d066054ef4","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-04-20T19:47:40Z","pushed_at":"2015-04-23T22:07:01Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":148569,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":2,"forks":88,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/636"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/636"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/7ab4f5f271961c80259d1a14682c2c4cbf7a01a4"}}}}