{"push_id":909312916,"size":7,"distinct_size":7,"ref":"refs/heads/peiyu/fix-target-root","head":"40e708346e4e5b9d9ae6fbb91da3d319c58c56d4","before":"c76f8885b3e9c8c1da72443edaf0507a7e03c60f","commits":[{"sha":"7fddcc5d68272a03e9a2b4224b8da728d35eabb2","author":{"email":"5496d4fd32b46dcb22e495b96a73063ce8ea956b@gmail.com","name":"Garrett Malmquist"},"message":"Allow specification of extra env vars for junit_tests runs.\n\nI added an `extra_env_vars` parameter to junit_tests in much the\nsame way that apaulin previously added extra_jvm_options previously\nin https://rbcommons.com/s/twitter/r/3140.\n\nI cleaned up code in junit_run.py a little (partitioning the tests\nby workdir, platform, jvm options, and env vars can all easily be\nhandled by the existing functionality of _tests_by_properties()\njust by passing a couple extra parameters).\n\nTesting Done:\nTests added to test_junit_run.py.\n\nCI went green here: https://travis-ci.org/pantsbuild/pants/builds/97500339\n\nBugs closed: 2382, 2736\n\nReviewed at https://rbcommons.com/s/twitter/r/3267/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/7fddcc5d68272a03e9a2b4224b8da728d35eabb2"},{"sha":"2884dc9f9b220513fc2f5042820bb19f7230a0c2","author":{"email":"dcd3ef132fa8ee0a44174e6ac56e2a267446f811@gmail.com","name":"Moses Nakamura"},"message":"Explains how append-style arguments work in pants\n\nTesting Done:\n./build-support/bin/publish_docs.sh -o\n\nlooked around on the local invoke.html page, looks good\n\nReviewed at https://rbcommons.com/s/twitter/r/3268/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/2884dc9f9b220513fc2f5042820bb19f7230a0c2"},{"sha":"50012bd7e169d744223c4e8ba8594cfc9e3be6ce","author":{"email":"6e726a6f00e44168937720f75c924a5bd8dab518@gmail.com","name":"Daniel Bentley"},"message":"Go: Allow users to specify known import prefixes for import paths.\n\nBefore this change, Go's ArchiveFetcher could only determine the root of a prefix by looking at what matched from the regex. This doesn't work if you are downloading tarballs from artifactory, where the files in the tarball may be arbitrarily deep.\n\nInstead, allow a user to pass (or set in pants.ini) a list of known prefixes. Use these prefixes to determine the root, which lets us put go_remote_libraries in the correct package, instead of trying to look them up in their own package.\n\nTesting Done:\nUsed to build from an internal artifactory.\n\nBugs closed: 2560\n\nReviewed at https://rbcommons.com/s/twitter/r/3120/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/50012bd7e169d744223c4e8ba8594cfc9e3be6ce"},{"sha":"1de06d294954cd7c1bff135b8bb8ef0faa64cf9c","author":{"email":"bb1f132dcb86bfc59bf4a043a3139a9ac7c0b658@gmail.com","name":"Stu Hood"},"message":"Make jvm_compile's subsystem dependencies global to fix ignored options\n\nThis change addresses the issue that the `--scala-platform-compile-zinc-fatal-warnings` and `--java-compile-zinc-fatal-warnings` options are registered/recognized, but never used. Rather than actually using a task-specific instance of the subsystem, jvm_compile uses the global instance, and probably should.\n\n- Made JvmCompile's subsystem dependencies global, and moved from the deprecated `task_subsystem`/`global_subsystem` API to the scoping API\n- Added a negative test to confirm that passing the option in the incorrect position explodes\n- Fixed a bug in `subsystem_dependencies_iter` where the scope of global options was incorrect, which caused them not to be fingerprinted\n- Added a TODO to track [#2739](https://github.com/pantsbuild/pants/issues/2739), which was discovered here\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/97571757\n\nBugs closed: 2696\n\nReviewed at https://rbcommons.com/s/twitter/r/3238/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/1de06d294954cd7c1bff135b8bb8ef0faa64cf9c"},{"sha":"f1141b5d0a47094db80d62cd00b013ef89fc6c10","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Fixup `GoFetch` to respect transitive injections.\n\nPreviously, a fetch could trigger injection of a `GoRemoteLibrary`\nsubgraph that was not tracked by `GoFetch` leading to the erroneous\nassumption that it was safe to synthesize a target that was already\nimplicitly injected into the active graph.\n\nAdd a failing test for this scenario that is fixed by this change.\n\nTesting Done:\nI tested this in the Medium/mono repo and the change does fix their\nproblem.  A new unit test also emulates the problem and is likewise\nfixed.\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/97707029\n\nBugs closed: 2733, 2740\n\nReviewed at https://rbcommons.com/s/twitter/r/3270/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/f1141b5d0a47094db80d62cd00b013ef89fc6c10"},{"sha":"8464b0113b65c4169699281371c95604bf8e96cf","author":{"email":"f437cb078acc7c6d79873462334a355eddeb9459@foursquare.com","name":"Patrick Lawson"},"message":"Prepare for the 0.0.65 release.\n\nTesting Done:\nCI is green: https://travis-ci.org/pantsbuild/pants/builds/97728941\n\nBugs closed: 2742\n\nReviewed at https://rbcommons.com/s/twitter/r/3271/","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/8464b0113b65c4169699281371c95604bf8e96cf"},{"sha":"40e708346e4e5b9d9ae6fbb91da3d319c58c56d4","author":{"email":"d5ed231de4182b008876105c5be61eb83ae4c643@gmail.com","name":"Peiyu Wang"},"message":"Merge branch 'master' into peiyu/fix-target-root","distinct":true,"url":"https://api.github.com/repos/peiyuwang/pants/commits/40e708346e4e5b9d9ae6fbb91da3d319c58c56d4"}]}