{"action":"created","comment":{"url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/comments/33886171","id":33886171,"diff_hunk":"@@ -0,0 +1,62 @@\n+package com.ouchadam.loldr.feed;\n+\n+import android.support.v7.widget.RecyclerView;\n+import android.view.LayoutInflater;\n+import android.view.View;\n+import android.view.ViewGroup;\n+import android.widget.TextView;\n+\n+import com.ouchadam.loldr.ui.R;\n+\n+final class PostSummaryViewHolder extends RecyclerView.ViewHolder {\n+\n+    private final View rootView;\n+    private final TextView titleView;\n+    private final TextView timeView;\n+    private final TextView commentsView;\n+    private final TextView subredditView;\n+\n+    static PostSummaryViewHolder inflate(ViewGroup parent, LayoutInflater layoutInflater) {\n+        View view = layoutInflater.inflate(R.layout.view_feed_post_summary, parent, false);\n+\n+        TextView titleView = (TextView) view.findViewById(R.id.feed_post_summary_text_title);","path":"ui/src/main/java/com/ouchadam/loldr/feed/PostSummaryViewHolder.java","position":22,"original_position":22,"commit_id":"7e8c539ce5f60f5b56d08e51f686b985a91fe701","original_commit_id":"7e8c539ce5f60f5b56d08e51f686b985a91fe701","user":{"login":"ataulm","id":2678555,"avatar_url":"https://avatars.githubusercontent.com/u/2678555?v=3","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"body":"This is in the factory method. Or do you mean it's better in ctor?\n\nOn Sat, 4 Jul 2015 10:04 Adam Brown <notifications@github.com> wrote:\n\n> In ui/src/main/java/com/ouchadam/loldr/feed/PostSummaryViewHolder.java\n> <https://github.com/ouchadam/lol-dr/pull/1#discussion_r33886116>:\n>\n> > +import android.widget.TextView;\n> > +\n> > +import com.ouchadam.loldr.ui.R;\n> > +\n> > +final class PostSummaryViewHolder extends RecyclerView.ViewHolder {\n> > +\n> > +    private final View rootView;\n> > +    private final TextView titleView;\n> > +    private final TextView timeView;\n> > +    private final TextView commentsView;\n> > +    private final TextView subredditView;\n> > +\n> > +    static PostSummaryViewHolder inflate(ViewGroup parent, LayoutInflater layoutInflater) {\n> > +        View view = layoutInflater.inflate(R.layout.view_feed_post_summary, parent, false);\n> > +\n> > +        TextView titleView = (TextView) view.findViewById(R.id.feed_post_summary_text_title);\n>\n> I always wonder if the view holder should do the view finding in a factory\n> method?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ouchadam/lol-dr/pull/1/files#r33886116>.\n>\n","created_at":"2015-07-04T09:19:29Z","updated_at":"2015-07-04T09:19:29Z","html_url":"https://github.com/ouchadam/lol-dr/pull/1#discussion_r33886171","pull_request_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/comments/33886171"},"html":{"href":"https://github.com/ouchadam/lol-dr/pull/1#discussion_r33886171"},"pull_request":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1","id":39198504,"html_url":"https://github.com/ouchadam/lol-dr/pull/1","diff_url":"https://github.com/ouchadam/lol-dr/pull/1.diff","patch_url":"https://github.com/ouchadam/lol-dr/pull/1.patch","issue_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/1","number":1,"state":"closed","locked":false,"title":"Scribbles feed","user":{"login":"ataulm","id":2678555,"avatar_url":"https://avatars.githubusercontent.com/u/2678555?v=3","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"body":"no screenies because no dummy data yet... comments welcome. weirdest thing is the PostsProvider so that the adapter doesn't keep data inside it, it's always querying and is fully immutable -> no more updating adapter.","created_at":"2015-07-03T22:40:55Z","updated_at":"2015-07-04T09:19:29Z","closed_at":"2015-07-04T09:06:26Z","merged_at":"2015-07-04T09:06:26Z","merge_commit_sha":"aa5b93a33eb8b34df59ee90b48b52a3a5bbca719","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/1/comments","statuses_url":"https://api.github.com/repos/ouchadam/lol-dr/statuses/7e8c539ce5f60f5b56d08e51f686b985a91fe701","head":{"label":"ouchadam:scribbles_feed","ref":"scribbles_feed","sha":"7e8c539ce5f60f5b56d08e51f686b985a91fe701","user":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars.githubusercontent.com/u/1848238?v=3","gravatar_id":"","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"repo":{"id":37867783,"name":"lol-dr","full_name":"ouchadam/lol-dr","owner":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars.githubusercontent.com/u/1848238?v=3","gravatar_id":"","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ouchadam/lol-dr","description":"EZ","fork":false,"url":"https://api.github.com/repos/ouchadam/lol-dr","forks_url":"https://api.github.com/repos/ouchadam/lol-dr/forks","keys_url":"https://api.github.com/repos/ouchadam/lol-dr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ouchadam/lol-dr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ouchadam/lol-dr/teams","hooks_url":"https://api.github.com/repos/ouchadam/lol-dr/hooks","issue_events_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/events{/number}","events_url":"https://api.github.com/repos/ouchadam/lol-dr/events","assignees_url":"https://api.github.com/repos/ouchadam/lol-dr/assignees{/user}","branches_url":"https://api.github.com/repos/ouchadam/lol-dr/branches{/branch}","tags_url":"https://api.github.com/repos/ouchadam/lol-dr/tags","blobs_url":"https://api.github.com/repos/ouchadam/lol-dr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ouchadam/lol-dr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ouchadam/lol-dr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ouchadam/lol-dr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ouchadam/lol-dr/statuses/{sha}","languages_url":"https://api.github.com/repos/ouchadam/lol-dr/languages","stargazers_url":"https://api.github.com/repos/ouchadam/lol-dr/stargazers","contributors_url":"https://api.github.com/repos/ouchadam/lol-dr/contributors","subscribers_url":"https://api.github.com/repos/ouchadam/lol-dr/subscribers","subscription_url":"https://api.github.com/repos/ouchadam/lol-dr/subscription","commits_url":"https://api.github.com/repos/ouchadam/lol-dr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ouchadam/lol-dr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ouchadam/lol-dr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ouchadam/lol-dr/contents/{+path}","compare_url":"https://api.github.com/repos/ouchadam/lol-dr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ouchadam/lol-dr/merges","archive_url":"https://api.github.com/repos/ouchadam/lol-dr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ouchadam/lol-dr/downloads","issues_url":"https://api.github.com/repos/ouchadam/lol-dr/issues{/number}","pulls_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls{/number}","milestones_url":"https://api.github.com/repos/ouchadam/lol-dr/milestones{/number}","notifications_url":"https://api.github.com/repos/ouchadam/lol-dr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ouchadam/lol-dr/labels{/name}","releases_url":"https://api.github.com/repos/ouchadam/lol-dr/releases{/id}","created_at":"2015-06-22T16:49:24Z","updated_at":"2015-06-29T16:30:40Z","pushed_at":"2015-07-04T09:06:28Z","git_url":"git://github.com/ouchadam/lol-dr.git","ssh_url":"git@github.com:ouchadam/lol-dr.git","clone_url":"https://github.com/ouchadam/lol-dr.git","svn_url":"https://github.com/ouchadam/lol-dr","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ouchadam:master","ref":"master","sha":"0447be57f1b5790e9f526993a1bfde26db4c545c","user":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars.githubusercontent.com/u/1848238?v=3","gravatar_id":"","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"repo":{"id":37867783,"name":"lol-dr","full_name":"ouchadam/lol-dr","owner":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars.githubusercontent.com/u/1848238?v=3","gravatar_id":"","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ouchadam/lol-dr","description":"EZ","fork":false,"url":"https://api.github.com/repos/ouchadam/lol-dr","forks_url":"https://api.github.com/repos/ouchadam/lol-dr/forks","keys_url":"https://api.github.com/repos/ouchadam/lol-dr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ouchadam/lol-dr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ouchadam/lol-dr/teams","hooks_url":"https://api.github.com/repos/ouchadam/lol-dr/hooks","issue_events_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/events{/number}","events_url":"https://api.github.com/repos/ouchadam/lol-dr/events","assignees_url":"https://api.github.com/repos/ouchadam/lol-dr/assignees{/user}","branches_url":"https://api.github.com/repos/ouchadam/lol-dr/branches{/branch}","tags_url":"https://api.github.com/repos/ouchadam/lol-dr/tags","blobs_url":"https://api.github.com/repos/ouchadam/lol-dr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ouchadam/lol-dr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ouchadam/lol-dr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ouchadam/lol-dr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ouchadam/lol-dr/statuses/{sha}","languages_url":"https://api.github.com/repos/ouchadam/lol-dr/languages","stargazers_url":"https://api.github.com/repos/ouchadam/lol-dr/stargazers","contributors_url":"https://api.github.com/repos/ouchadam/lol-dr/contributors","subscribers_url":"https://api.github.com/repos/ouchadam/lol-dr/subscribers","subscription_url":"https://api.github.com/repos/ouchadam/lol-dr/subscription","commits_url":"https://api.github.com/repos/ouchadam/lol-dr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ouchadam/lol-dr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ouchadam/lol-dr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ouchadam/lol-dr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ouchadam/lol-dr/contents/{+path}","compare_url":"https://api.github.com/repos/ouchadam/lol-dr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ouchadam/lol-dr/merges","archive_url":"https://api.github.com/repos/ouchadam/lol-dr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ouchadam/lol-dr/downloads","issues_url":"https://api.github.com/repos/ouchadam/lol-dr/issues{/number}","pulls_url":"https://api.github.com/repos/ouchadam/lol-dr/pulls{/number}","milestones_url":"https://api.github.com/repos/ouchadam/lol-dr/milestones{/number}","notifications_url":"https://api.github.com/repos/ouchadam/lol-dr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ouchadam/lol-dr/labels{/name}","releases_url":"https://api.github.com/repos/ouchadam/lol-dr/releases{/id}","created_at":"2015-06-22T16:49:24Z","updated_at":"2015-06-29T16:30:40Z","pushed_at":"2015-07-04T09:06:28Z","git_url":"git://github.com/ouchadam/lol-dr.git","ssh_url":"git@github.com:ouchadam/lol-dr.git","clone_url":"https://github.com/ouchadam/lol-dr.git","svn_url":"https://github.com/ouchadam/lol-dr","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1"},"html":{"href":"https://github.com/ouchadam/lol-dr/pull/1"},"issue":{"href":"https://api.github.com/repos/ouchadam/lol-dr/issues/1"},"comments":{"href":"https://api.github.com/repos/ouchadam/lol-dr/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ouchadam/lol-dr/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ouchadam/lol-dr/statuses/7e8c539ce5f60f5b56d08e51f686b985a91fe701"}}}}