{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/191","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/191/comments","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/191/events","html_url":"https://github.com/theforeman/puppet-foreman_proxy/issues/191","id":106730042,"number":191,"title":"plugin templates use wrong variable module_enabled?","user":{"login":"cristifalcas","id":3647635,"avatar_url":"https://avatars.githubusercontent.com/u/3647635?v=3","gravatar_id":"","url":"https://api.github.com/users/cristifalcas","html_url":"https://github.com/cristifalcas","followers_url":"https://api.github.com/users/cristifalcas/followers","following_url":"https://api.github.com/users/cristifalcas/following{/other_user}","gists_url":"https://api.github.com/users/cristifalcas/gists{/gist_id}","starred_url":"https://api.github.com/users/cristifalcas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristifalcas/subscriptions","organizations_url":"https://api.github.com/users/cristifalcas/orgs","repos_url":"https://api.github.com/users/cristifalcas/repos","events_url":"https://api.github.com/users/cristifalcas/events{/privacy}","received_events_url":"https://api.github.com/users/cristifalcas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-16T09:00:08Z","updated_at":"2015-09-16T09:04:51Z","closed_at":null,"body":"In almost all plugin templates there is this line:\r\n    :enabled: <%= @module_enabled %>\r\n\r\n Shouldn't that be something like:\r\n    :enabled: <%= scope.lookupvar('::foreman_proxy::plugin::_name_::enabled') %>\r\n?"},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments/140678058","html_url":"https://github.com/theforeman/puppet-foreman_proxy/issues/191#issuecomment-140678058","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/191","id":140678058,"user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T09:04:51Z","updated_at":"2015-09-16T09:04:51Z","body":"No, https://github.com/theforeman/puppet-foreman_proxy/blob/b7eab059e3ea5085cc09a5cfad2db78809bf7a36/manifests/settings_file.pp#L44-L55 takes care of the variable."}}