{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2079","labels_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2079/labels{/name}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2079/comments","events_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2079/events","html_url":"https://github.com/ClusterHQ/flocker/pull/2079","id":113387038,"number":2079,"title":"[FLOC-1853] Added timeout to destroy volume","user":{"login":"mpgomez","id":678471,"avatar_url":"https://avatars.githubusercontent.com/u/678471?v=3","gravatar_id":"","url":"https://api.github.com/users/mpgomez","html_url":"https://github.com/mpgomez","followers_url":"https://api.github.com/users/mpgomez/followers","following_url":"https://api.github.com/users/mpgomez/following{/other_user}","gists_url":"https://api.github.com/users/mpgomez/gists{/gist_id}","starred_url":"https://api.github.com/users/mpgomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpgomez/subscriptions","organizations_url":"https://api.github.com/users/mpgomez/orgs","repos_url":"https://api.github.com/users/mpgomez/repos","events_url":"https://api.github.com/users/mpgomez/events{/privacy}","received_events_url":"https://api.github.com/users/mpgomez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-26T15:56:57Z","updated_at":"2015-10-27T13:24:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2079","html_url":"https://github.com/ClusterHQ/flocker/pull/2079","diff_url":"https://github.com/ClusterHQ/flocker/pull/2079.diff","patch_url":"https://github.com/ClusterHQ/flocker/pull/2079.patch"},"body":"Design for https://clusterhq.atlassian.net/browse/FLOC-1853\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/clusterhq/flocker/2079)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/comments/151492827","html_url":"https://github.com/ClusterHQ/flocker/pull/2079#issuecomment-151492827","issue_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2079","id":151492827,"user":{"login":"itamarst","id":3266662,"avatar_url":"https://avatars.githubusercontent.com/u/3266662?v=3","gravatar_id":"","url":"https://api.github.com/users/itamarst","html_url":"https://github.com/itamarst","followers_url":"https://api.github.com/users/itamarst/followers","following_url":"https://api.github.com/users/itamarst/following{/other_user}","gists_url":"https://api.github.com/users/itamarst/gists{/gist_id}","starred_url":"https://api.github.com/users/itamarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itamarst/subscriptions","organizations_url":"https://api.github.com/users/itamarst/orgs","repos_url":"https://api.github.com/users/itamarst/repos","events_url":"https://api.github.com/users/itamarst/events{/privacy}","received_events_url":"https://api.github.com/users/itamarst/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T13:24:15Z","updated_at":"2015-10-27T13:24:15Z","body":"Thanks for working on this!\r\n\r\n1. There's a bunch of minor comments to address.\r\n2. I don't think this is time to make complete new fake, no, see inline comments.\r\n3. I don't see any test results; I suspect there'll be some lint failures. You can force a build by visiting http://build.clusterhq.com/boxes-flocker , typing in branch name in form at top-right and hitting \"FORCE\" button.\r\n\r\nIt occurs to me (sorry only at this late point) that there is one alternative testing strategy: use a real client, but just make its `delete()` method a no-op via subclassing or setting attribute directly:\r\n\r\n```\r\nc = RealCinderClient()\r\nc.delete = lambda *args, **kwargs: None\r\n# Now c.delete() does nothing.\r\n```\r\n\r\nPerhaps that would be simpler?\r\n\r\nPlease address comments above and resubmit."}}