{"action":"created","comment":{"url":"https://api.github.com/repos/LionsAd/service_container/pulls/comments/33353251","id":33353251,"diff_hunk":"@@ -243,13 +243,15 @@ public function alterContainerDefinition(&$container_definition) {\n    */\n   public function registerAnnotatedPluginTypes(&$container_definition, $parameter_definitions) {\n     foreach($parameter_definitions as $definition) {\n-      $owner = $definition['owner'];\n-      $type = $definition['type'];\n-\n-      $this->registerAliasServices($container_definition, $owner, $type);\n+      if (!isset($definition['type']) || empty($definition['type'])) {","path":"src/ServiceContainer/ServiceProvider/ServiceContainerServiceProvider.php","position":8,"original_position":8,"commit_id":"4ed2362863610cd0efb80b4cd594802fcf582e54","original_commit_id":"4ed2362863610cd0efb80b4cd594802fcf582e54","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"body":"Lets check for 'plugin_manager_name' here. I like that a lot! :)","created_at":"2015-06-26T13:03:13Z","updated_at":"2015-06-26T13:03:13Z","html_url":"https://github.com/LionsAd/service_container/pull/78#discussion_r33353251","pull_request_url":"https://api.github.com/repos/LionsAd/service_container/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/comments/33353251"},"html":{"href":"https://github.com/LionsAd/service_container/pull/78#discussion_r33353251"},"pull_request":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/LionsAd/service_container/pulls/78","id":38646143,"html_url":"https://github.com/LionsAd/service_container/pull/78","diff_url":"https://github.com/LionsAd/service_container/pull/78.diff","patch_url":"https://github.com/LionsAd/service_container/pull/78.patch","issue_url":"https://api.github.com/repos/LionsAd/service_container/issues/78","number":78,"state":"open","locked":false,"title":"Allows Annotation plugins to be declared without type.","user":{"login":"drupol","id":252042,"avatar_url":"https://avatars.githubusercontent.com/u/252042?v=3","gravatar_id":"","url":"https://api.github.com/users/drupol","html_url":"https://github.com/drupol","followers_url":"https://api.github.com/users/drupol/followers","following_url":"https://api.github.com/users/drupol/following{/other_user}","gists_url":"https://api.github.com/users/drupol/gists{/gist_id}","starred_url":"https://api.github.com/users/drupol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupol/subscriptions","organizations_url":"https://api.github.com/users/drupol/orgs","repos_url":"https://api.github.com/users/drupol/repos","events_url":"https://api.github.com/users/drupol/events{/privacy}","received_events_url":"https://api.github.com/users/drupol/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-26T12:53:36Z","updated_at":"2015-06-26T13:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c58f5b028ef311fafa31ad8c06347bd3c2287d22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LionsAd/service_container/pulls/78/commits","review_comments_url":"https://api.github.com/repos/LionsAd/service_container/pulls/78/comments","review_comment_url":"https://api.github.com/repos/LionsAd/service_container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LionsAd/service_container/issues/78/comments","statuses_url":"https://api.github.com/repos/LionsAd/service_container/statuses/4ed2362863610cd0efb80b4cd594802fcf582e54","head":{"label":"drupol:Allow-plugin-type-to-be-undefined","ref":"Allow-plugin-type-to-be-undefined","sha":"4ed2362863610cd0efb80b4cd594802fcf582e54","user":{"login":"drupol","id":252042,"avatar_url":"https://avatars.githubusercontent.com/u/252042?v=3","gravatar_id":"","url":"https://api.github.com/users/drupol","html_url":"https://github.com/drupol","followers_url":"https://api.github.com/users/drupol/followers","following_url":"https://api.github.com/users/drupol/following{/other_user}","gists_url":"https://api.github.com/users/drupol/gists{/gist_id}","starred_url":"https://api.github.com/users/drupol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupol/subscriptions","organizations_url":"https://api.github.com/users/drupol/orgs","repos_url":"https://api.github.com/users/drupol/repos","events_url":"https://api.github.com/users/drupol/events{/privacy}","received_events_url":"https://api.github.com/users/drupol/received_events","type":"User","site_admin":false},"repo":{"id":37182370,"name":"service_container","full_name":"drupol/service_container","owner":{"login":"drupol","id":252042,"avatar_url":"https://avatars.githubusercontent.com/u/252042?v=3","gravatar_id":"","url":"https://api.github.com/users/drupol","html_url":"https://github.com/drupol","followers_url":"https://api.github.com/users/drupol/followers","following_url":"https://api.github.com/users/drupol/following{/other_user}","gists_url":"https://api.github.com/users/drupol/gists{/gist_id}","starred_url":"https://api.github.com/users/drupol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupol/subscriptions","organizations_url":"https://api.github.com/users/drupol/orgs","repos_url":"https://api.github.com/users/drupol/repos","events_url":"https://api.github.com/users/drupol/events{/privacy}","received_events_url":"https://api.github.com/users/drupol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drupol/service_container","description":"Service Container Module on drupal.org - used for development and automated testing via travis","fork":true,"url":"https://api.github.com/repos/drupol/service_container","forks_url":"https://api.github.com/repos/drupol/service_container/forks","keys_url":"https://api.github.com/repos/drupol/service_container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupol/service_container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupol/service_container/teams","hooks_url":"https://api.github.com/repos/drupol/service_container/hooks","issue_events_url":"https://api.github.com/repos/drupol/service_container/issues/events{/number}","events_url":"https://api.github.com/repos/drupol/service_container/events","assignees_url":"https://api.github.com/repos/drupol/service_container/assignees{/user}","branches_url":"https://api.github.com/repos/drupol/service_container/branches{/branch}","tags_url":"https://api.github.com/repos/drupol/service_container/tags","blobs_url":"https://api.github.com/repos/drupol/service_container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupol/service_container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupol/service_container/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupol/service_container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupol/service_container/statuses/{sha}","languages_url":"https://api.github.com/repos/drupol/service_container/languages","stargazers_url":"https://api.github.com/repos/drupol/service_container/stargazers","contributors_url":"https://api.github.com/repos/drupol/service_container/contributors","subscribers_url":"https://api.github.com/repos/drupol/service_container/subscribers","subscription_url":"https://api.github.com/repos/drupol/service_container/subscription","commits_url":"https://api.github.com/repos/drupol/service_container/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupol/service_container/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupol/service_container/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupol/service_container/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupol/service_container/contents/{+path}","compare_url":"https://api.github.com/repos/drupol/service_container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupol/service_container/merges","archive_url":"https://api.github.com/repos/drupol/service_container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupol/service_container/downloads","issues_url":"https://api.github.com/repos/drupol/service_container/issues{/number}","pulls_url":"https://api.github.com/repos/drupol/service_container/pulls{/number}","milestones_url":"https://api.github.com/repos/drupol/service_container/milestones{/number}","notifications_url":"https://api.github.com/repos/drupol/service_container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupol/service_container/labels{/name}","releases_url":"https://api.github.com/repos/drupol/service_container/releases{/id}","created_at":"2015-06-10T07:31:53Z","updated_at":"2015-06-10T07:31:55Z","pushed_at":"2015-06-26T12:53:19Z","git_url":"git://github.com/drupol/service_container.git","ssh_url":"git@github.com:drupol/service_container.git","clone_url":"https://github.com/drupol/service_container.git","svn_url":"https://github.com/drupol/service_container","homepage":null,"size":1336,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"LionsAd:7.x-1.x","ref":"7.x-1.x","sha":"f2264d18cb50d11dceb6ef3166b0541c9fe737ac","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"repo":{"id":27236055,"name":"service_container","full_name":"LionsAd/service_container","owner":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LionsAd/service_container","description":"Service Container Module on drupal.org - used for development and automated testing via travis","fork":false,"url":"https://api.github.com/repos/LionsAd/service_container","forks_url":"https://api.github.com/repos/LionsAd/service_container/forks","keys_url":"https://api.github.com/repos/LionsAd/service_container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LionsAd/service_container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LionsAd/service_container/teams","hooks_url":"https://api.github.com/repos/LionsAd/service_container/hooks","issue_events_url":"https://api.github.com/repos/LionsAd/service_container/issues/events{/number}","events_url":"https://api.github.com/repos/LionsAd/service_container/events","assignees_url":"https://api.github.com/repos/LionsAd/service_container/assignees{/user}","branches_url":"https://api.github.com/repos/LionsAd/service_container/branches{/branch}","tags_url":"https://api.github.com/repos/LionsAd/service_container/tags","blobs_url":"https://api.github.com/repos/LionsAd/service_container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LionsAd/service_container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LionsAd/service_container/git/refs{/sha}","trees_url":"https://api.github.com/repos/LionsAd/service_container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LionsAd/service_container/statuses/{sha}","languages_url":"https://api.github.com/repos/LionsAd/service_container/languages","stargazers_url":"https://api.github.com/repos/LionsAd/service_container/stargazers","contributors_url":"https://api.github.com/repos/LionsAd/service_container/contributors","subscribers_url":"https://api.github.com/repos/LionsAd/service_container/subscribers","subscription_url":"https://api.github.com/repos/LionsAd/service_container/subscription","commits_url":"https://api.github.com/repos/LionsAd/service_container/commits{/sha}","git_commits_url":"https://api.github.com/repos/LionsAd/service_container/git/commits{/sha}","comments_url":"https://api.github.com/repos/LionsAd/service_container/comments{/number}","issue_comment_url":"https://api.github.com/repos/LionsAd/service_container/issues/comments{/number}","contents_url":"https://api.github.com/repos/LionsAd/service_container/contents/{+path}","compare_url":"https://api.github.com/repos/LionsAd/service_container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LionsAd/service_container/merges","archive_url":"https://api.github.com/repos/LionsAd/service_container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LionsAd/service_container/downloads","issues_url":"https://api.github.com/repos/LionsAd/service_container/issues{/number}","pulls_url":"https://api.github.com/repos/LionsAd/service_container/pulls{/number}","milestones_url":"https://api.github.com/repos/LionsAd/service_container/milestones{/number}","notifications_url":"https://api.github.com/repos/LionsAd/service_container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LionsAd/service_container/labels{/name}","releases_url":"https://api.github.com/repos/LionsAd/service_container/releases{/id}","created_at":"2014-11-27T17:50:29Z","updated_at":"2015-06-23T04:16:28Z","pushed_at":"2015-06-26T12:53:36Z","git_url":"git://github.com/LionsAd/service_container.git","ssh_url":"git@github.com:LionsAd/service_container.git","clone_url":"https://github.com/LionsAd/service_container.git","svn_url":"https://github.com/LionsAd/service_container","homepage":null,"size":2407,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":4,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/78"},"html":{"href":"https://github.com/LionsAd/service_container/pull/78"},"issue":{"href":"https://api.github.com/repos/LionsAd/service_container/issues/78"},"comments":{"href":"https://api.github.com/repos/LionsAd/service_container/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/LionsAd/service_container/statuses/4ed2362863610cd0efb80b4cd594802fcf582e54"}}}}