{"action":"created","issue":{"url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/725","labels_url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/725/comments","events_url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/725/events","html_url":"https://github.com/FezVrasta/bootstrap-material-design/pull/725","id":117704506,"number":725,"title":"Standardized form markup and spec compliance","user":{"login":"rosskevin","id":136564,"avatar_url":"https://avatars.githubusercontent.com/u/136564?v=3","gravatar_id":"","url":"https://api.github.com/users/rosskevin","html_url":"https://github.com/rosskevin","followers_url":"https://api.github.com/users/rosskevin/followers","following_url":"https://api.github.com/users/rosskevin/following{/other_user}","gists_url":"https://api.github.com/users/rosskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/rosskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosskevin/subscriptions","organizations_url":"https://api.github.com/users/rosskevin/orgs","repos_url":"https://api.github.com/users/rosskevin/repos","events_url":"https://api.github.com/users/rosskevin/events{/privacy}","received_events_url":"https://api.github.com/users/rosskevin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-18T23:17:39Z","updated_at":"2015-11-19T16:12:42Z","closed_at":"2015-11-19T15:07:33Z","pull_request":{"url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/pulls/725","html_url":"https://github.com/FezVrasta/bootstrap-material-design/pull/725","diff_url":"https://github.com/FezVrasta/bootstrap-material-design/pull/725.diff","patch_url":"https://github.com/FezVrasta/bootstrap-material-design/pull/725.patch"},"body":"This is a refactoring primarily of `_inputs.less` to utilize standardized bootstrap html markup, as well as to comply with details of the Material Design spec such as font-size, padding, margins, and color/opacity.\r\n\r\nBranch demos publish for this PR:\r\n1. http://rosskevin.github.io/bootstrap-material-design/bootstrap-elements.html#forms\r\n2. http://rosskevin.github.io/bootstrap-material-design/#input\r\n3. http://rosskevin.github.io/bootstrap-material-design/#fileinput\r\n\r\nChange summary:\r\n\r\n1.  Spec sizing\r\nWith input font sizing differing from bootstrap, and since bootstrap didn't separate input sizing from `font-size-base`, a new parallel range of variables has been introduced so that inputs can meet the spec sizes without altering the `font-size-base` which would change all typography.\r\n\r\n2. Standard bootstrap markup\r\nMarkup now works with the standard bootstrap form/inputs structure.  Adding bootstrap-material-design to a standard bootstrap app with no changes yields good results\r\n\r\n3. Sizing variations\r\nSince font-size, margin, padding and more are interrelated, `form-group-sm` and `form-group-lg` are preferred to signal size variations.  As such, `material.js` converts `input-sm` and `input-lg` to the `form-group-*` equivalent.\r\n\r\n4. Legacy markup conversion\r\nGiven old styles and markup, `material.js` does some legacy conversion to work with standard structure and css structure.  These are clearly commented in the `js` with `// Legacy ` comments, and sample html also notes that it is legacy markup.  With that said, I think the legacy labels and data-hints work as-is.\r\n\r\n5. Label styles\r\nA ton of work was done with label styling, and the [readme](https://github.com/rosskevin/bootstrap-material-design/tree/standardized-form-markup#forms) is updated to indicate how these work.\r\n\r\nIn general, this refactoring is an iteration on the original code, making styles simpler and using standard bootstrap 3 markup.  A lot of work was done to get default markup to conform with the Material Design spec (sizing/padding/margin).  In addition, work to input-groups was done (samples provided) to make them work better.\r\n\r\nAll in all, this is about a week of work on inputs alone.  I think this is a great evolution of the project towards the spec as well as standard bootstrap markup.  \r\n\r\n@FezVrasta  This is ready to commit/release!"},"comment":{"url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/comments/158103764","html_url":"https://github.com/FezVrasta/bootstrap-material-design/pull/725#issuecomment-158103764","issue_url":"https://api.github.com/repos/FezVrasta/bootstrap-material-design/issues/725","id":158103764,"user":{"login":"FezVrasta","id":5382443,"avatar_url":"https://avatars.githubusercontent.com/u/5382443?v=3","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T16:12:42Z","updated_at":"2015-11-19T16:12:42Z","body":"Thanks :)"}}