{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5493","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5493/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5493/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5493/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5493","id":61908775,"number":5493,"title":"Another step to introduce  fields.Selector","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"ECF7EC"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/status/lgtm","name":"status/lgtm","color":"159818"}],"state":"open","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-03-15T22:11:50Z","updated_at":"2015-03-17T15:28:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5493","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5493","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5493.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5493.patch"},"body":"@nikhiljindal @bgrant0607 @smarterclayton @lavalamp in my previous https://github.com/GoogleCloudPlatform/kubernetes/pull/5171 I simply forgot to move some part of the API.\r\nNote tha in this PR I modified also `pkg/client/request.go`.  `SelectorParam(string, labels.Selector)` is now splitted in `FieldsSelectorParam(fields.Selector)` and `LabelsSelectorParam(labels.Selector)`\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/82413284","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5493#issuecomment-82413284","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5493","id":82413284,"user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T15:28:04Z","updated_at":"2015-03-17T15:28:04Z","body":"Rebasing done: but please have a look at this.\r\n\r\nIn my original PR `SelectorParm` was splitted in `FieldsSelectorParam` and `LabelsSelectorParam`. The idea was to remove the `labels` and `fields` const string during URL encoding.\r\nNow after the https://github.com/GoogleCloudPlatform/kubernetes/pull/5233 the const string may change according to the version from `Client.APIVersion()` given as an input parameter to the XXX`SelectorParam`.\r\n \r\nWhat is puzzling me is that in request we have also an `apiVersion` in `request` here https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/client/request.go#L113 .  Which one should we keep?"}}