{"action":"closed","number":565,"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/565","id":47171520,"html_url":"https://github.com/libuv/libuv/pull/565","diff_url":"https://github.com/libuv/libuv/pull/565.diff","patch_url":"https://github.com/libuv/libuv/pull/565.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/565","number":565,"state":"closed","locked":false,"title":"unix: use QUEUE_MOVE when iterating over lists","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":" Replace uses of QUEUE_FOREACH when the list can get modified while\r\niterating over it, in particular when a callback is made into the\r\nuser's code.  This should fix a number of spurious failures that\r\npeople have been reporting.\r\n\r\nR=@saghul or @piscisaureus\r\n\r\n@indutny There are two QUEUE_FOREACH statements in src/unix/fsevents.c.  They _look_ safe to me (as in: the list isn't mutated concurrently) but can you confirm?","created_at":"2015-10-08T15:56:48Z","updated_at":"2015-10-08T20:18:00Z","closed_at":"2015-10-08T20:18:00Z","merged_at":"2015-10-08T20:18:00Z","merge_commit_sha":"2444f7285d78b203f2c4f2a775a8e72e55475107","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/565/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/565/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/565/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/822969ad2f530278348ac33c716f0c2a51ee5c3d","head":{"label":"bnoordhuis:no-queue-foreach","ref":"no-queue-foreach","sha":"822969ad2f530278348ac33c716f0c2a51ee5c3d","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"repo":{"id":29756917,"name":"libuv","full_name":"bnoordhuis/libuv","owner":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnoordhuis/libuv","description":"Cross-platform asychronous I/O","fork":true,"url":"https://api.github.com/repos/bnoordhuis/libuv","forks_url":"https://api.github.com/repos/bnoordhuis/libuv/forks","keys_url":"https://api.github.com/repos/bnoordhuis/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnoordhuis/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnoordhuis/libuv/teams","hooks_url":"https://api.github.com/repos/bnoordhuis/libuv/hooks","issue_events_url":"https://api.github.com/repos/bnoordhuis/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/bnoordhuis/libuv/events","assignees_url":"https://api.github.com/repos/bnoordhuis/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/bnoordhuis/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/bnoordhuis/libuv/tags","blobs_url":"https://api.github.com/repos/bnoordhuis/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnoordhuis/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnoordhuis/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnoordhuis/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnoordhuis/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/bnoordhuis/libuv/languages","stargazers_url":"https://api.github.com/repos/bnoordhuis/libuv/stargazers","contributors_url":"https://api.github.com/repos/bnoordhuis/libuv/contributors","subscribers_url":"https://api.github.com/repos/bnoordhuis/libuv/subscribers","subscription_url":"https://api.github.com/repos/bnoordhuis/libuv/subscription","commits_url":"https://api.github.com/repos/bnoordhuis/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnoordhuis/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnoordhuis/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnoordhuis/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnoordhuis/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/bnoordhuis/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnoordhuis/libuv/merges","archive_url":"https://api.github.com/repos/bnoordhuis/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnoordhuis/libuv/downloads","issues_url":"https://api.github.com/repos/bnoordhuis/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/bnoordhuis/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/bnoordhuis/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/bnoordhuis/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnoordhuis/libuv/labels{/name}","releases_url":"https://api.github.com/repos/bnoordhuis/libuv/releases{/id}","created_at":"2015-01-23T22:47:25Z","updated_at":"2015-01-23T22:47:51Z","pushed_at":"2015-10-08T20:17:56Z","git_url":"git://github.com/bnoordhuis/libuv.git","ssh_url":"git@github.com:bnoordhuis/libuv.git","clone_url":"https://github.com/bnoordhuis/libuv.git","svn_url":"https://github.com/bnoordhuis/libuv","homepage":"http://libuv.org/","size":12325,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"libuv:v1.x","ref":"v1.x","sha":"26917ddf7a5279c5d913c12121fe955ba4de91c0","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asychronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","created_at":"2013-11-30T00:29:56Z","updated_at":"2015-10-08T03:48:20Z","pushed_at":"2015-10-08T20:17:58Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":18783,"stargazers_count":2405,"watchers_count":2405,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":94,"forks":349,"open_issues":94,"watchers":2405,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/565"},"html":{"href":"https://github.com/libuv/libuv/pull/565"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/565"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/822969ad2f530278348ac33c716f0c2a51ee5c3d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":4,"additions":58,"deletions":33,"changed_files":11}}