{"action":"created","issue":{"url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/10","labels_url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/10/comments","events_url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/10/events","html_url":"https://github.com/BenjaminArmstrong/Hyper-V-PowerShell/pull/10","id":100069755,"number":10,"title":"Externalize configuration","user":{"login":"peterschen","id":1166870,"avatar_url":"https://avatars.githubusercontent.com/u/1166870?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschen","html_url":"https://github.com/peterschen","followers_url":"https://api.github.com/users/peterschen/followers","following_url":"https://api.github.com/users/peterschen/following{/other_user}","gists_url":"https://api.github.com/users/peterschen/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschen/subscriptions","organizations_url":"https://api.github.com/users/peterschen/orgs","repos_url":"https://api.github.com/users/peterschen/repos","events_url":"https://api.github.com/users/peterschen/events{/privacy}","received_events_url":"https://api.github.com/users/peterschen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-10T13:45:03Z","updated_at":"2015-08-10T23:33:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/pulls/10","html_url":"https://github.com/BenjaminArmstrong/Hyper-V-PowerShell/pull/10","diff_url":"https://github.com/BenjaminArmstrong/Hyper-V-PowerShell/pull/10.diff","patch_url":"https://github.com/BenjaminArmstrong/Hyper-V-PowerShell/pull/10.patch"},"body":"Hi Ben,\r\n\r\nWith this pull request I extend on the externalization of the configuration to have everything out of the main processing loop. This way most common scenarios can be adressed (dot-sourcing of the script for individual automation, invocation of the script with either .xml or .ps1 configuration for automation or manual invocation). Furthermore when using xml the configuration could be validated (not implemented yet though).\r\n\r\nFrom the readme:\r\n\r\n* Extended the externalization of the configuration to use either .ps1 based configuration or .xml based configuration\r\n* Extended the main function call to accept $Global configuration values to prevent variable pollution but still limit the number of parameters to be passed\r\n* Implemented separate configurable directories/paths for working/resources/log file\r\n\r\nBR\r\nChris"},"comment":{"url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/comments/129646626","html_url":"https://github.com/BenjaminArmstrong/Hyper-V-PowerShell/pull/10#issuecomment-129646626","issue_url":"https://api.github.com/repos/BenjaminArmstrong/Hyper-V-PowerShell/issues/10","id":129646626,"user":{"login":"BenjaminArmstrong","id":12947071,"avatar_url":"https://avatars.githubusercontent.com/u/12947071?v=3","gravatar_id":"","url":"https://api.github.com/users/BenjaminArmstrong","html_url":"https://github.com/BenjaminArmstrong","followers_url":"https://api.github.com/users/BenjaminArmstrong/followers","following_url":"https://api.github.com/users/BenjaminArmstrong/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminArmstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminArmstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminArmstrong/subscriptions","organizations_url":"https://api.github.com/users/BenjaminArmstrong/orgs","repos_url":"https://api.github.com/users/BenjaminArmstrong/repos","events_url":"https://api.github.com/users/BenjaminArmstrong/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminArmstrong/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T23:33:03Z","updated_at":"2015-08-10T23:33:03Z","body":"I'm really not a fan of the XML configuration approach.  Can we figure out a way to get the code structured so that you can keep that in your fork - but I can avoid breaking you as I work on this?"}}