{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/6953","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/6953/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/6953/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/6953/events","html_url":"https://github.com/edx/edx-platform/pull/6953","id":57268050,"number":6953,"title":"WIP: Refactor create_account","user":{"login":"gwprice","id":4027165,"avatar_url":"https://avatars.githubusercontent.com/u/4027165?v=3","gravatar_id":"","url":"https://api.github.com/users/gwprice","html_url":"https://github.com/gwprice","followers_url":"https://api.github.com/users/gwprice/followers","following_url":"https://api.github.com/users/gwprice/following{/other_user}","gists_url":"https://api.github.com/users/gwprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gwprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwprice/subscriptions","organizations_url":"https://api.github.com/users/gwprice/orgs","repos_url":"https://api.github.com/users/gwprice/repos","events_url":"https://api.github.com/users/gwprice/events{/privacy}","received_events_url":"https://api.github.com/users/gwprice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-11T02:15:42Z","updated_at":"2015-02-13T00:53:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/6953","html_url":"https://github.com/edx/edx-platform/pull/6953","diff_url":"https://github.com/edx/edx-platform/pull/6953.diff","patch_url":"https://github.com/edx/edx-platform/pull/6953.patch"},"body":"This currently contains the first of several changes en route to returning more error information from the new registration endpoint. I have added tests that I think do a decent job of covering the things that are likely to break with this refactoring. One big point that I want to dig into more is whether there's any reason to distinguish between the empty string and None for various fields, since there's a considerable amount of code and effort devoted to making sure we match what gets saved in the UserProfile object exactly.\r\n\r\n@nasthagiri @wedaly @stephensanchez please start looking through this"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/74185868","html_url":"https://github.com/edx/edx-platform/pull/6953#issuecomment-74185868","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/6953","id":74185868,"user":{"login":"gwprice","id":4027165,"avatar_url":"https://avatars.githubusercontent.com/u/4027165?v=3","gravatar_id":"","url":"https://api.github.com/users/gwprice","html_url":"https://github.com/gwprice","followers_url":"https://api.github.com/users/gwprice/followers","following_url":"https://api.github.com/users/gwprice/following{/other_user}","gists_url":"https://api.github.com/users/gwprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gwprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwprice/subscriptions","organizations_url":"https://api.github.com/users/gwprice/orgs","repos_url":"https://api.github.com/users/gwprice/repos","events_url":"https://api.github.com/users/gwprice/events{/privacy}","received_events_url":"https://api.github.com/users/gwprice/received_events","type":"User","site_admin":false},"created_at":"2015-02-13T00:53:11Z","updated_at":"2015-02-13T00:53:11Z","body":"I have added another commit with the refactoring of the two registration endpoints to use common code where appropriate and avoid the need for a shim. I used a placeholder name (foobar) for the new function because I'm really not sure what to call it given that we already have create_account for the old view and _do_create_account as an internal more minimal function and this new thing that sits somewhere in between."}}