{"action":"created","issue":{"url":"https://api.github.com/repos/crowbar/crowbar-core/issues/18","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/18/comments","events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/18/events","html_url":"https://github.com/crowbar/crowbar-core/pull/18","id":104047041,"number":18,"title":"[WIP] add repositories page","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-08-31T12:45:48Z","updated_at":"2015-09-01T12:55:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/18","html_url":"https://github.com/crowbar/crowbar-core/pull/18","diff_url":"https://github.com/crowbar/crowbar-core/pull/18.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/18.patch"},"body":"Part of https://trello.com/c/CRJYcP59/466-5-p6-move-repo-checks-out-of-install-suse-cloud-also-ux\r\n\r\nThis still needs some work, the views are just a very basic table right now, so depending on where we want to go with the whole thing, (adding new repos, first time landing page...) we need to involve @kwwii in the design.\r\nplease don't judge the views too much here, as they are just a dummy right now to have something.\r\n\r\n![repo_page](https://cloud.githubusercontent.com/assets/5364817/9578144/e4fd6f44-4fe7-11e5-9126-f81b40099ddd.png)\r\n\r\nSo for now shall we just implement a simple table like that? or do we need sth. more designed? any concrete suggestions are more than welcome. same goes for the lib, I have put this to WIP to get some input from you.\r\n\r\nBits that are still unclear/TODO:\r\n- [ ] decide on a good UI representation (view)\r\n- [ ] define YAML file\r\n- [ ] where do we store the yaml file(s) ?\r\n- [ ] fit the lib to [repositories.rb](https://github.com/crowbar/crowbar-core/blob/master/chef/cookbooks/provisioner/libraries/repositories.rb) **or** fit [repositories.rb](https://github.com/crowbar/crowbar-core/blob/master/chef/cookbooks/provisioner/libraries/repositories.rb) to the lib?\r\n- [ ] unittests for the lib"},"comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments/136707488","html_url":"https://github.com/crowbar/crowbar-core/pull/18#issuecomment-136707488","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/18","id":136707488,"user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T12:55:23Z","updated_at":"2015-09-01T12:55:23Z","body":"> I think ActiveModel would only be an option if we wouldn't have to care about Chef access... active model is a gem, but it would have to be installed on the nodes i guess, and I don't have any idea if it makes sense to try to use it standalone\r\n\r\nIt seems possible, e.g. http://www.rubyinside.com/rails-3-0s-activemodel-how-to-give-ruby-classes-some-activerecord-magic-2937.html\r\n\r\nbut although it's a nice idea, I wonder if it might be overkill ... Do you think we need to do any queries on `Repository` objects? e.g. \"find all repos for a given platform\" or \"find all repos which require an md5 check\"?  If so then maybe we should use it, otherwise maybe not.\r\n\r\nIf you convert `Repositories` to a singular `Repository` object class which has an interface similar to active model classes then I think the answers to these questions will become more obvious.\r\n\r\n> if we stick to Chef/Crowbar shared code then it will maybe have to be a simple lib like this (or even sth more generic for sharing code between Chef and Crowbar for other use cases)\r\n\r\nI don't follow how the ActiveModel question is related to this?\r\n\r\n> so what shall we do now?\r\n\r\nAre you OK with converting `Repositories` to a singular `Repository` class?\r\n\r\nThanks!"}}