{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35127117","id":35127117,"diff_hunk":"@@ -418,51 +418,518 @@ case class Cast(child: Expression, dataType: DataType)\n   protected override def nullSafeEval(input: Any): Any = cast(input)\n \n   override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {\n-    // TODO: Add support for more data types.\n-    (child.dataType, dataType) match {\n+    val nullSafeCast = nullSafeCastFunction(child.dataType, dataType, ctx)\n+    if (nullSafeCast != null) {\n+      val eval = child.gen(ctx)\n+      eval.code +\n+        castCode(ctx, eval.primitive, eval.isNull, ev.primitive, ev.isNull, dataType, nullSafeCast)\n+    } else {\n+      super.genCode(ctx, ev)\n+    }\n+  }\n+\n+  // three function arguments are: child.primitive, result.primitive and result.isNull\n+  // it returns the code snippets to be put in null safe evaluation region\n+  private[this] type CastFunction = (String, String, String) => String\n+\n+  private[this] def nullSafeCastFunction(\n+      from: DataType,\n+      to: DataType,\n+      ctx: CodeGenContext): CastFunction = to match {\n+\n+    case _ if from == NullType => (c, evPrim, evNull) => s\"$evNull = true;\"\n+    case _ if to == from => (c, evPrim, evNull) => s\"$evPrim = $c;\"\n+    case StringType => castToStringCode(from, ctx)\n+    case BinaryType => castToBinaryCode(from)\n+    case DateType => castToDateCode(from, ctx)\n+    case decimal: DecimalType => castToDecimalCode(from, decimal)\n+    case TimestampType => castToTimestampCode(from, ctx)\n+    case IntervalType => castToIntervalCode(from)\n+    case BooleanType => castToBooleanCode(from)\n+    case ByteType => castToByteCode(from)\n+    case ShortType => castToShortCode(from)\n+    case IntegerType => castToIntCode(from)\n+    case FloatType => castToFloatCode(from)\n+    case LongType => castToLongCode(from)\n+    case DoubleType => castToDoubleCode(from)\n+\n+    case array: ArrayType => castArrayCode(from.asInstanceOf[ArrayType], array, ctx)\n+    case map: MapType => castMapCode(from.asInstanceOf[MapType], map, ctx)\n+    case struct: StructType => castStructCode(from.asInstanceOf[StructType], struct, ctx)\n+    case other => null\n+  }\n+\n+  private[this] def castCode(ctx: CodeGenContext, childPrim: String, childNull: String,\n+    resultPrim: String, resultNull: String, resultType: DataType, cast: CastFunction): String = {","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala","position":48,"original_position":48,"commit_id":"fd7eba4d812ff43307ae766953a33afdfa6f8038","original_commit_id":"fd7eba4d812ff43307ae766953a33afdfa6f8038","user":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"body":"Nit: we can use `result` as GeneratedExpressionCode  for resultPrim, resultNull, child for childPrim and childNull. resultType is `this.dataType`.\r\n\r\nRight now, it has two many parameters, hard to read.","created_at":"2015-07-21T17:05:22Z","updated_at":"2015-07-21T17:05:22Z","html_url":"https://github.com/apache/spark/pull/7365#discussion_r35127117","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7365","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35127117"},"html":{"href":"https://github.com/apache/spark/pull/7365#discussion_r35127117"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7365"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7365","id":39783863,"html_url":"https://github.com/apache/spark/pull/7365","diff_url":"https://github.com/apache/spark/pull/7365.diff","patch_url":"https://github.com/apache/spark/pull/7365.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7365","number":7365,"state":"open","locked":false,"title":"[SPARK-8935][SQL] Implement code generation for all casts","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.apache.org/jira/browse/SPARK-8935","created_at":"2015-07-13T07:02:35Z","updated_at":"2015-07-21T17:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa4877ace903869f5b5f246b83818cba01e4b50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7365/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7365/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7365/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/fd7eba4d812ff43307ae766953a33afdfa6f8038","head":{"label":"yjshen:cast_codegen","ref":"cast_codegen","sha":"fd7eba4d812ff43307ae766953a33afdfa6f8038","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"repo":{"id":32433144,"name":"spark","full_name":"yjshen/spark","owner":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjshen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yjshen/spark","forks_url":"https://api.github.com/repos/yjshen/spark/forks","keys_url":"https://api.github.com/repos/yjshen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjshen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjshen/spark/teams","hooks_url":"https://api.github.com/repos/yjshen/spark/hooks","issue_events_url":"https://api.github.com/repos/yjshen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yjshen/spark/events","assignees_url":"https://api.github.com/repos/yjshen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yjshen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yjshen/spark/tags","blobs_url":"https://api.github.com/repos/yjshen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjshen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjshen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjshen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjshen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yjshen/spark/languages","stargazers_url":"https://api.github.com/repos/yjshen/spark/stargazers","contributors_url":"https://api.github.com/repos/yjshen/spark/contributors","subscribers_url":"https://api.github.com/repos/yjshen/spark/subscribers","subscription_url":"https://api.github.com/repos/yjshen/spark/subscription","commits_url":"https://api.github.com/repos/yjshen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjshen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjshen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjshen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjshen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yjshen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjshen/spark/merges","archive_url":"https://api.github.com/repos/yjshen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjshen/spark/downloads","issues_url":"https://api.github.com/repos/yjshen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yjshen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yjshen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yjshen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjshen/spark/labels{/name}","releases_url":"https://api.github.com/repos/yjshen/spark/releases{/id}","created_at":"2015-03-18T02:27:58Z","updated_at":"2015-05-02T04:50:02Z","pushed_at":"2015-07-21T06:46:46Z","git_url":"git://github.com/yjshen/spark.git","ssh_url":"git@github.com:yjshen/spark.git","clone_url":"https://github.com/yjshen/spark.git","svn_url":"https://github.com/yjshen/spark","homepage":null,"size":113914,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"163e3f1df94f6b7d3dadb46a87dbb3a2bade3f95","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-21T17:02:17Z","pushed_at":"2015-07-21T16:58:30Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1571154,"stargazers_count":4816,"watchers_count":4816,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4316,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":325,"forks":4316,"open_issues":325,"watchers":4816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7365"},"html":{"href":"https://github.com/apache/spark/pull/7365"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7365"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7365/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7365/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7365/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/fd7eba4d812ff43307ae766953a33afdfa6f8038"}}}}