{"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/offliner/pulls/comments/36852329","id":36852329,"diff_hunk":"@@ -27,6 +27,8 @@\n public class Options\n {\n \n+    public static final String DEFAULT_TYPE_MAPPING = \"test-jar=jar:tests;ejb=jar;ejb-client=jar:client;maven-plugin=jar;java-source=jar:sources;javadoc=jar:javadoc\";\n+","path":"src/main/java/com/redhat/rcm/offliner/Options.java","position":5,"original_position":5,"commit_id":"e472c73d6d25c0dbaaad88f4e06e50b56585326a","original_commit_id":"e472c73d6d25c0dbaaad88f4e06e50b56585326a","user":{"login":"pkocandr","id":4548699,"avatar_url":"https://avatars.githubusercontent.com/u/4548699?v=3","gravatar_id":"","url":"https://api.github.com/users/pkocandr","html_url":"https://github.com/pkocandr","followers_url":"https://api.github.com/users/pkocandr/followers","following_url":"https://api.github.com/users/pkocandr/following{/other_user}","gists_url":"https://api.github.com/users/pkocandr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkocandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkocandr/subscriptions","organizations_url":"https://api.github.com/users/pkocandr/orgs","repos_url":"https://api.github.com/users/pkocandr/repos","events_url":"https://api.github.com/users/pkocandr/events{/privacy}","received_events_url":"https://api.github.com/users/pkocandr/received_events","type":"User","site_admin":false},"body":"True, a properties file would be probably better, because even the default value is too long.\r\nNot sure about the default value printing though. I'm afraid that the number of command-line parameters would be too high and since we move to properties file it would be pretty easy to extract the default props.","created_at":"2015-08-12T12:14:52Z","updated_at":"2015-08-12T12:14:52Z","html_url":"https://github.com/release-engineering/offliner/pull/11#discussion_r36852329","pull_request_url":"https://api.github.com/repos/release-engineering/offliner/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/comments/36852329"},"html":{"href":"https://github.com/release-engineering/offliner/pull/11#discussion_r36852329"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/offliner/pulls/11","id":41935372,"html_url":"https://github.com/release-engineering/offliner/pull/11","diff_url":"https://github.com/release-engineering/offliner/pull/11.diff","patch_url":"https://github.com/release-engineering/offliner/pull/11.patch","issue_url":"https://api.github.com/repos/release-engineering/offliner/issues/11","number":11,"state":"closed","locked":false,"title":"Add support for maven type mapping","user":{"login":"pkocandr","id":4548699,"avatar_url":"https://avatars.githubusercontent.com/u/4548699?v=3","gravatar_id":"","url":"https://api.github.com/users/pkocandr","html_url":"https://github.com/pkocandr","followers_url":"https://api.github.com/users/pkocandr/followers","following_url":"https://api.github.com/users/pkocandr/following{/other_user}","gists_url":"https://api.github.com/users/pkocandr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkocandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkocandr/subscriptions","organizations_url":"https://api.github.com/users/pkocandr/orgs","repos_url":"https://api.github.com/users/pkocandr/repos","events_url":"https://api.github.com/users/pkocandr/events{/privacy}","received_events_url":"https://api.github.com/users/pkocandr/received_events","type":"User","site_admin":false},"body":"The artifact type is not always the file extension to use. Sometimes the\r\ntype also declares a classifier, so there is a mapping needed.\r\n\r\nDefault value is the mapping of Maven 3.3.3, but can be overriden on\r\ncommand-line.","created_at":"2015-08-07T21:32:35Z","updated_at":"2015-08-12T12:14:52Z","closed_at":"2015-08-12T02:05:12Z","merged_at":"2015-08-12T02:05:12Z","merge_commit_sha":"682314720d5adbad92743cf633374f5e253bd16a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/offliner/pulls/11/commits","review_comments_url":"https://api.github.com/repos/release-engineering/offliner/pulls/11/comments","review_comment_url":"https://api.github.com/repos/release-engineering/offliner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/offliner/issues/11/comments","statuses_url":"https://api.github.com/repos/release-engineering/offliner/statuses/e472c73d6d25c0dbaaad88f4e06e50b56585326a","head":{"label":"pkocandr:master","ref":"master","sha":"e472c73d6d25c0dbaaad88f4e06e50b56585326a","user":{"login":"pkocandr","id":4548699,"avatar_url":"https://avatars.githubusercontent.com/u/4548699?v=3","gravatar_id":"","url":"https://api.github.com/users/pkocandr","html_url":"https://github.com/pkocandr","followers_url":"https://api.github.com/users/pkocandr/followers","following_url":"https://api.github.com/users/pkocandr/following{/other_user}","gists_url":"https://api.github.com/users/pkocandr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkocandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkocandr/subscriptions","organizations_url":"https://api.github.com/users/pkocandr/orgs","repos_url":"https://api.github.com/users/pkocandr/repos","events_url":"https://api.github.com/users/pkocandr/events{/privacy}","received_events_url":"https://api.github.com/users/pkocandr/received_events","type":"User","site_admin":false},"repo":{"id":37731142,"name":"offliner","full_name":"pkocandr/offliner","owner":{"login":"pkocandr","id":4548699,"avatar_url":"https://avatars.githubusercontent.com/u/4548699?v=3","gravatar_id":"","url":"https://api.github.com/users/pkocandr","html_url":"https://github.com/pkocandr","followers_url":"https://api.github.com/users/pkocandr/followers","following_url":"https://api.github.com/users/pkocandr/following{/other_user}","gists_url":"https://api.github.com/users/pkocandr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkocandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkocandr/subscriptions","organizations_url":"https://api.github.com/users/pkocandr/orgs","repos_url":"https://api.github.com/users/pkocandr/repos","events_url":"https://api.github.com/users/pkocandr/events{/privacy}","received_events_url":"https://api.github.com/users/pkocandr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkocandr/offliner","description":"Offline repository downloader (client)","fork":true,"url":"https://api.github.com/repos/pkocandr/offliner","forks_url":"https://api.github.com/repos/pkocandr/offliner/forks","keys_url":"https://api.github.com/repos/pkocandr/offliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkocandr/offliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkocandr/offliner/teams","hooks_url":"https://api.github.com/repos/pkocandr/offliner/hooks","issue_events_url":"https://api.github.com/repos/pkocandr/offliner/issues/events{/number}","events_url":"https://api.github.com/repos/pkocandr/offliner/events","assignees_url":"https://api.github.com/repos/pkocandr/offliner/assignees{/user}","branches_url":"https://api.github.com/repos/pkocandr/offliner/branches{/branch}","tags_url":"https://api.github.com/repos/pkocandr/offliner/tags","blobs_url":"https://api.github.com/repos/pkocandr/offliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkocandr/offliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkocandr/offliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkocandr/offliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkocandr/offliner/statuses/{sha}","languages_url":"https://api.github.com/repos/pkocandr/offliner/languages","stargazers_url":"https://api.github.com/repos/pkocandr/offliner/stargazers","contributors_url":"https://api.github.com/repos/pkocandr/offliner/contributors","subscribers_url":"https://api.github.com/repos/pkocandr/offliner/subscribers","subscription_url":"https://api.github.com/repos/pkocandr/offliner/subscription","commits_url":"https://api.github.com/repos/pkocandr/offliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkocandr/offliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkocandr/offliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkocandr/offliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkocandr/offliner/contents/{+path}","compare_url":"https://api.github.com/repos/pkocandr/offliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkocandr/offliner/merges","archive_url":"https://api.github.com/repos/pkocandr/offliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkocandr/offliner/downloads","issues_url":"https://api.github.com/repos/pkocandr/offliner/issues{/number}","pulls_url":"https://api.github.com/repos/pkocandr/offliner/pulls{/number}","milestones_url":"https://api.github.com/repos/pkocandr/offliner/milestones{/number}","notifications_url":"https://api.github.com/repos/pkocandr/offliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkocandr/offliner/labels{/name}","releases_url":"https://api.github.com/repos/pkocandr/offliner/releases{/id}","created_at":"2015-06-19T15:47:47Z","updated_at":"2015-06-19T15:47:47Z","pushed_at":"2015-08-07T21:31:25Z","git_url":"git://github.com/pkocandr/offliner.git","ssh_url":"git@github.com:pkocandr/offliner.git","clone_url":"https://github.com/pkocandr/offliner.git","svn_url":"https://github.com/pkocandr/offliner","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"af33422386c731b4d3727a4d3de3679c731961fa","user":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":37638373,"name":"offliner","full_name":"release-engineering/offliner","owner":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/release-engineering/offliner","description":"Offline repository downloader (client)","fork":false,"url":"https://api.github.com/repos/release-engineering/offliner","forks_url":"https://api.github.com/repos/release-engineering/offliner/forks","keys_url":"https://api.github.com/repos/release-engineering/offliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/offliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/offliner/teams","hooks_url":"https://api.github.com/repos/release-engineering/offliner/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/offliner/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/offliner/events","assignees_url":"https://api.github.com/repos/release-engineering/offliner/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/offliner/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/offliner/tags","blobs_url":"https://api.github.com/repos/release-engineering/offliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/offliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/offliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/offliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/offliner/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/offliner/languages","stargazers_url":"https://api.github.com/repos/release-engineering/offliner/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/offliner/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/offliner/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/offliner/subscription","commits_url":"https://api.github.com/repos/release-engineering/offliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/offliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/offliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/offliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/offliner/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/offliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/offliner/merges","archive_url":"https://api.github.com/repos/release-engineering/offliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/offliner/downloads","issues_url":"https://api.github.com/repos/release-engineering/offliner/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/offliner/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/offliner/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/offliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/offliner/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/offliner/releases{/id}","created_at":"2015-06-18T05:05:12Z","updated_at":"2015-06-18T05:05:58Z","pushed_at":"2015-08-12T02:05:12Z","git_url":"git://github.com/release-engineering/offliner.git","ssh_url":"git@github.com:release-engineering/offliner.git","clone_url":"https://github.com/release-engineering/offliner.git","svn_url":"https://github.com/release-engineering/offliner","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/11"},"html":{"href":"https://github.com/release-engineering/offliner/pull/11"},"issue":{"href":"https://api.github.com/repos/release-engineering/offliner/issues/11"},"comments":{"href":"https://api.github.com/repos/release-engineering/offliner/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/offliner/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/offliner/statuses/e472c73d6d25c0dbaaad88f4e06e50b56585326a"}}}}