{"action":"created","issue":{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/207","labels_url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/207/comments","events_url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/207/events","html_url":"https://github.com/Esri/solutions-geoprocessing-toolbox/issues/207","id":56301509,"number":207,"title":"Fast Visibility By Circle fails with Geographic data","user":{"login":"mfunk","id":3093182,"avatar_url":"https://avatars.githubusercontent.com/u/3093182?v=3","gravatar_id":"","url":"https://api.github.com/users/mfunk","html_url":"https://github.com/mfunk","followers_url":"https://api.github.com/users/mfunk/followers","following_url":"https://api.github.com/users/mfunk/following{/other_user}","gists_url":"https://api.github.com/users/mfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfunk/subscriptions","organizations_url":"https://api.github.com/users/mfunk/orgs","repos_url":"https://api.github.com/users/mfunk/repos","events_url":"https://api.github.com/users/mfunk/events{/privacy}","received_events_url":"https://api.github.com/users/mfunk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/0%20-%20Backlog","name":"0 - Backlog","color":"D9D9D9"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/B%20-%20Bug","name":"B - Bug","color":"fc2929"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/F%20-%20Visibility","name":"F - Visibility","color":"bfe5bf"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/G%20-%20Intelligence%20Team","name":"G - Intelligence Team","color":"207de5"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/N%20-%20Visibility%20and%20Range","name":"N - Visibility and Range","color":"009800"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/priority-high","name":"priority-high","color":"f7c6c7"},{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/labels/V%20-%20Services","name":"V - Services","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"mfunk","id":3093182,"avatar_url":"https://avatars.githubusercontent.com/u/3093182?v=3","gravatar_id":"","url":"https://api.github.com/users/mfunk","html_url":"https://github.com/mfunk","followers_url":"https://api.github.com/users/mfunk/followers","following_url":"https://api.github.com/users/mfunk/following{/other_user}","gists_url":"https://api.github.com/users/mfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfunk/subscriptions","organizations_url":"https://api.github.com/users/mfunk/orgs","repos_url":"https://api.github.com/users/mfunk/repos","events_url":"https://api.github.com/users/mfunk/events{/privacy}","received_events_url":"https://api.github.com/users/mfunk/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/milestones/4","html_url":"https://github.com/Esri/solutions-geoprocessing-toolbox/milestones/Version%20-%20Next","labels_url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/milestones/4/labels","id":1087701,"number":4,"title":"Version - Next","description":"* Fix high priority issues and issues specific to ArcGIS Desktop 10.4 and ArcGIS Pro 1.2 (?)","creator":{"login":"conklinbd","id":2582674,"avatar_url":"https://avatars.githubusercontent.com/u/2582674?v=3","gravatar_id":"","url":"https://api.github.com/users/conklinbd","html_url":"https://github.com/conklinbd","followers_url":"https://api.github.com/users/conklinbd/followers","following_url":"https://api.github.com/users/conklinbd/following{/other_user}","gists_url":"https://api.github.com/users/conklinbd/gists{/gist_id}","starred_url":"https://api.github.com/users/conklinbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklinbd/subscriptions","organizations_url":"https://api.github.com/users/conklinbd/orgs","repos_url":"https://api.github.com/users/conklinbd/repos","events_url":"https://api.github.com/users/conklinbd/events{/privacy}","received_events_url":"https://api.github.com/users/conklinbd/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":30,"state":"open","created_at":"2015-04-28T15:36:51Z","updated_at":"2015-12-16T15:53:43Z","due_on":"2015-12-30T08:00:00Z","closed_at":null},"comments":1,"created_at":"2015-02-02T22:15:26Z","updated_at":"2015-12-16T16:01:13Z","closed_at":null,"body":"Fast Visibility By Circle (data_management\\test\\test_publishable_tasks\\TestFastVisibilityByCircle_SingleInput.py ) fails when input elevation data is Geographic. The tool test fails as the Fast Visibility By Circle Tool fails when input elevation data is in Geographic coordinates. The tool should check inputs and change option as needed with warnings.\r\n\r\nTo test:\r\n1. Download latest repo\r\n2. Set up repo test software as in main README\r\n3. Get test data as in main README\r\n4. `cd data_management\\test`\r\n5. `ant test_publishable_tasks`... this should give an error in *test_fv_by_circle*\r\n\r\n```\r\ntest_fv_by_circle:\r\n     [exec] Starting Test: Fast Visibility By Circle - Single input circle\r\n     [exec] ERROR: Executing: FastVisibilityByCircle C:\\Users\\matt2542\\Documents\\GitHub\\solutions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\PublishableTasksData.gdb\\FVBC_InputCircle 5 http://afmcloud.esri.c\r\nom/arcgis/rest/services/Environment/D_DigitalTerrainModel/ImageServer C:\\Users\\matt2542\\Documents\\GitHub\\solutions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\scratch.gdb\\FVBCircle_1_vshed\r\n     [exec] Start Time: Mon Feb 02 13:45:08 2015\r\n     [exec] Executing (Calculate Cell Size): CalculateValue CalcCellSize(r\"C:\\Users\\matt2542\\Documents\\GitHub\\solutions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\PublishableTasksData.gdb\\FVBC_InputCircle\")\r\n\"def CalcCellSize(ds):\\n   width = arcpy.Describe(ds).extent.width\\n   height = arcpy.Describe(ds).extent.height\\n   cellsize = str(max(float(max(width,height))/1000.0,30.0))\\n   #return cellsize + \" \" + cellsize\\n   ret\r\nurn cellsize\" Double\r\n     [exec] Start Time: Mon Feb 02 13:45:12 2015\r\n     [exec] Value = 30.0\r\n     [exec] Succeeded at Mon Feb 02 13:45:12 2015 (Elapsed Time: 0.24 seconds)\r\n     [exec] Executing (Calculate Value): CalculateValue 30 # \"Cell Size\"\r\n     [exec] Start Time: Mon Feb 02 13:45:12 2015\r\n     [exec] Value = 30\r\n     [exec] Succeeded at Mon Feb 02 13:45:12 2015 (Elapsed Time: 0.00 seconds)\r\n     [exec] Executing (Make Image Server Layer): MakeImageServerLayer http://afmcloud.esri.com/arcgis/rest/services/Environment/D_DigitalTerrainModel/ImageServer ImageServer_Layer C:\\Users\\matt2542\\Documents\\GitHub\\solut\r\nions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\PublishableTasksData.gdb\\FVBC_InputCircle # NORTH_WEST Name 0 # 30 #\r\n     [exec] Start Time: Mon Feb 02 13:45:12 2015\r\n     [exec] Succeeded at Mon Feb 02 13:45:14 2015 (Elapsed Time: 2.24 seconds)\r\n     [exec] Executing (Feature To Point): FeatureToPoint C:\\Users\\matt2542\\Documents\\GitHub\\solutions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\PublishableTasksData.gdb\\FVBC_InputCircle in_memory\\Observer I\r\nNSIDE\r\n     [exec] Start Time: Mon Feb 02 13:45:14 2015\r\n     [exec] Succeeded at Mon Feb 02 13:45:14 2015 (Elapsed Time: 0.11 seconds)\r\n     [exec] Executing (Add Field (2)): AddField in_memory\\Observer OFFSETA DOUBLE # # # # NULLABLE NON_REQUIRED #\r\n     [exec] Start Time: Mon Feb 02 13:45:14 2015\r\n     [exec] Adding OFFSETA to in_memory\\Observer...\r\n     [exec] Succeeded at Mon Feb 02 13:45:14 2015 (Elapsed Time: 0.00 seconds)\r\n     [exec] Executing (Calculate Field (2)): CalculateField in_memory\\Observer OFFSETA 5 PYTHON #\r\n     [exec] Start Time: Mon Feb 02 13:45:14 2015\r\n     [exec] Succeeded at Mon Feb 02 13:45:14 2015 (Elapsed Time: 0.00 seconds)\r\n     [exec] Executing (Viewshed): Viewshed ImageServer_Layer in_memory\\Observer C:\\Users\\matt2542\\Documents\\GitHub\\solutions-geoprocessing-toolbox\\data_management\\data\\geodatabases\\scratch.gdb\\FVBCircle_1_vshed 1 CURVED_\r\nEARTH 0.13 #\r\n     [exec] Start Time: Mon Feb 02 13:45:14 2015\r\n     [exec] WARNING 000869: Z factor: The Z units of the output geographical spatial reference are undefined. A default Z factor of 1 was used.\r\n     [exec] ERROR 010425: Earth curvature correction is not supported when the input surface raster is in a Geographic Coordinate System.\r\n     [exec] Failed to execute (Viewshed).\r\n     [exec] Failed at Mon Feb 02 13:45:15 2015 (Elapsed Time: 0.15 seconds)\r\n     [exec] Failed to execute (FastVisibilityByCircle).\r\n     [exec] Failed at Mon Feb 02 13:45:15 2015 (Elapsed Time: 6.15 seconds)\r\n```"},"comment":{"url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/comments/165155692","html_url":"https://github.com/Esri/solutions-geoprocessing-toolbox/issues/207#issuecomment-165155692","issue_url":"https://api.github.com/repos/Esri/solutions-geoprocessing-toolbox/issues/207","id":165155692,"user":{"login":"mfunk","id":3093182,"avatar_url":"https://avatars.githubusercontent.com/u/3093182?v=3","gravatar_id":"","url":"https://api.github.com/users/mfunk","html_url":"https://github.com/mfunk","followers_url":"https://api.github.com/users/mfunk/followers","following_url":"https://api.github.com/users/mfunk/following{/other_user}","gists_url":"https://api.github.com/users/mfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfunk/subscriptions","organizations_url":"https://api.github.com/users/mfunk/orgs","repos_url":"https://api.github.com/users/mfunk/repos","events_url":"https://api.github.com/users/mfunk/events{/privacy}","received_events_url":"https://api.github.com/users/mfunk/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T16:01:13Z","updated_at":"2015-12-16T16:01:13Z","body":"Testing this in the latest dev and on 10.4. I can see the same error for ALL of the Fast Visibility tools. Going to have to go back and change how the base **Viewshed** is working.\r\n\r\nJust an FYI.. the other non-visibility tools, **Drive Time** and **Point-To-Point Routing** are passing tests now.\r\n\r\n"}}