{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/5978","labels_url":"https://api.github.com/repos/openshift/origin/issues/5978/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5978/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/5978/events","html_url":"https://github.com/openshift/origin/issues/5978","id":118001400,"number":5978,"title":"Allow to annotate the build started manually","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/area/usability","name":"area/usability","color":"006b75"},{"url":"https://api.github.com/repos/openshift/origin/labels/component/build","name":"component/build","color":"0052cc"},{"url":"https://api.github.com/repos/openshift/origin/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/openshift/origin/labels/priority/P3","name":"priority/P3","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-11-20T09:35:23Z","updated_at":"2015-12-09T15:45:46Z","closed_at":null,"body":"Related discussion: https://github.com/openshift/origin/pull/5961#issuecomment-158159105\r\n\r\nThis will work similar to the `-e` parameter, but will accept a list of annotations that will be applied to the build output image (if the build output is set).\r\n\r\nIt should also be added as label to the Build object itself. Alternatively we can copy all labels from the Build object to the Docker image.\r\n\r\nWe might need this to identify what started the build (and additional metadata, like if the build was started from verified source ref, etc.)"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/163298088","html_url":"https://github.com/openshift/origin/issues/5978#issuecomment-163298088","issue_url":"https://api.github.com/repos/openshift/origin/issues/5978","id":163298088,"user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T15:45:46Z","updated_at":"2015-12-09T15:45:46Z","body":">  Started-by as a build annotation being part of the image and shown in UI is very reasonable. \r\n\r\ni don't think it is.  I already linked the card in which we want to provide an audit trail for builds, and when we do that, i don't think we should be doing it via a \"start-by\" annotation, we should be adding a first class field to the Build object.\r\n\r\nDoing it as a annotation makes it much more difficult for us to prevent users from mucking with the value, and we have to prevent users from mucking with it to make it useful for an audit trail.\r\n\r\nSo i'm still unclear on the goal of this issue, is this the proposal:  \r\n```\r\nannotations on a Build object should be turned into Labels on the output docker image (which eventually will turn into annotations on the imagestreamtag when the image gets imported, someday)\r\n```\r\n\r\n?\r\n\r\nIf so, I don't like it because just because something is an annotation on a Build doesn't mean it should be a Label on the docker image.\r\n\r\nAlternatively is the proposal:\r\n```\r\nUsers can provide a list of values that should be turned into Labels on the output docker image (which eventually will turn into annotations on the imagestreamtag when the image gets imported, someday)\r\n```\r\n\r\n?\r\n\r\nPlease give me a concrete flow (what is defined on the build object and where).\r\n"}}