{"action":"created","comment":{"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/25558673","id":25558673,"diff_hunk":"@@ -1,9 +1,36 @@\n-var core = module.exports = require('./core');\n-\n-// plugins:\n-core.extras         = require('./extras');\n-core.filters        = require('./filters');\n-core.interaction    = require('./interaction');\n-core.loaders        = require('./loaders');\n-core.spine          = require('./spine');\n-core.text           = require('./text');\n+var core = require('./core'),\n+\tmath = core.math,\n+\t// plugins:\n+\textras         = require('./extras'),\n+\tfilters        = require('./filters'),\n+\tinteraction    = require('./interaction'),\n+\tloaders        = require('./loaders'),\n+\tspine          = require('./spine'),\n+\ttext           = require('./text'),\n+    deprecation    = require('./deprecation');\n+\n+var modules = [];\n+\n+modules.push(math);\n+modules.push(extras);\n+modules.push(filters);\n+modules.push(interaction);\n+modules.push(loaders);\n+modules.push(spine);\n+modules.push(text);\n+\n+for (var i = 0; i < modules.length; i++) {\n+\n+\t// Adds the module to the core, so you can do\n+\t// PIXI.Text instead of PIXI.text.Text\n+\tbundleUp(core,modules[i]);\n+};\n+\n+function bundleUp(object1,object2){\n+\n+    for(var keys in object2){\n+        object1[keys] = object2[keys];\n+    }\n+}\n+\n+module.exports = core;","path":"src/index.js","position":45,"original_position":45,"commit_id":"2eae97c696d3a67b7a19297d981c1008b8aa990c","original_commit_id":"2eae97c696d3a67b7a19297d981c1008b8aa990c","user":{"login":"englercj","id":944497,"avatar_url":"https://avatars.githubusercontent.com/u/944497?v=3","gravatar_id":"","url":"https://api.github.com/users/englercj","html_url":"https://github.com/englercj","followers_url":"https://api.github.com/users/englercj/followers","following_url":"https://api.github.com/users/englercj/following{/other_user}","gists_url":"https://api.github.com/users/englercj/gists{/gist_id}","starred_url":"https://api.github.com/users/englercj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/englercj/subscriptions","organizations_url":"https://api.github.com/users/englercj/orgs","repos_url":"https://api.github.com/users/englercj/repos","events_url":"https://api.github.com/users/englercj/events{/privacy}","received_events_url":"https://api.github.com/users/englercj/received_events","type":"User","site_admin":false},"body":"I like having things in their plugin namespace. If you want to alias things to the root object, it should be in the compatibility layer not the default v3 build imho. If the goal is easier compat with v2, it makes sense to be in the compat layer which people can opt **into** (not out of).","created_at":"2015-02-28T16:23:30Z","updated_at":"2015-02-28T16:23:30Z","html_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1470#discussion_r25558673","pull_request_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470","_links":{"self":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments/25558673"},"html":{"href":"https://github.com/GoodBoyDigital/pixi.js/pull/1470#discussion_r25558673"},"pull_request":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470"}}},"pull_request":{"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470","id":30181807,"html_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1470","diff_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1470.diff","patch_url":"https://github.com/GoodBoyDigital/pixi.js/pull/1470.patch","issue_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1470","number":1470,"state":"open","locked":false,"title":"Bitmap text, cache as bitmap fixes, and deprecation","user":{"login":"alvinsight","id":4254030,"avatar_url":"https://avatars.githubusercontent.com/u/4254030?v=3","gravatar_id":"","url":"https://api.github.com/users/alvinsight","html_url":"https://github.com/alvinsight","followers_url":"https://api.github.com/users/alvinsight/followers","following_url":"https://api.github.com/users/alvinsight/following{/other_user}","gists_url":"https://api.github.com/users/alvinsight/gists{/gist_id}","starred_url":"https://api.github.com/users/alvinsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvinsight/subscriptions","organizations_url":"https://api.github.com/users/alvinsight/orgs","repos_url":"https://api.github.com/users/alvinsight/repos","events_url":"https://api.github.com/users/alvinsight/events{/privacy}","received_events_url":"https://api.github.com/users/alvinsight/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-27T16:56:40Z","updated_at":"2015-02-28T16:23:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"122b0e206bd313b5f4af009bcee65ba66dfaec0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1470/comments","statuses_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/2eae97c696d3a67b7a19297d981c1008b8aa990c","head":{"label":"GoodBoyDigital:alvin/dev","ref":"alvin/dev","sha":"2eae97c696d3a67b7a19297d981c1008b8aa990c","user":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"repo":{"id":7741856,"name":"pixi.js","full_name":"GoodBoyDigital/pixi.js","owner":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoodBoyDigital/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":false,"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js","forks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/forks","keys_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/teams","hooks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/events","assignees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/tags","blobs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/languages","stargazers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscription","commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/merges","archive_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/downloads","issues_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/releases{/id}","created_at":"2013-01-21T22:40:50Z","updated_at":"2015-02-28T15:58:28Z","pushed_at":"2015-02-28T10:56:34Z","git_url":"git://github.com/GoodBoyDigital/pixi.js.git","ssh_url":"git@github.com:GoodBoyDigital/pixi.js.git","clone_url":"https://github.com/GoodBoyDigital/pixi.js.git","svn_url":"https://github.com/GoodBoyDigital/pixi.js","homepage":null,"size":46033,"stargazers_count":6831,"watchers_count":6831,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1373,"mirror_url":null,"open_issues_count":100,"forks":1373,"open_issues":100,"watchers":6831,"default_branch":"master"}},"base":{"label":"GoodBoyDigital:dev","ref":"dev","sha":"3e74008ed48eb24242c75a941a8161cb99d739a8","user":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"repo":{"id":7741856,"name":"pixi.js","full_name":"GoodBoyDigital/pixi.js","owner":{"login":"GoodBoyDigital","id":3112434,"avatar_url":"https://avatars.githubusercontent.com/u/3112434?v=3","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoodBoyDigital/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":false,"url":"https://api.github.com/repos/GoodBoyDigital/pixi.js","forks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/forks","keys_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/teams","hooks_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/events","assignees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/tags","blobs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/languages","stargazers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/subscription","commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/merges","archive_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/downloads","issues_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/GoodBoyDigital/pixi.js/releases{/id}","created_at":"2013-01-21T22:40:50Z","updated_at":"2015-02-28T15:58:28Z","pushed_at":"2015-02-28T10:56:34Z","git_url":"git://github.com/GoodBoyDigital/pixi.js.git","ssh_url":"git@github.com:GoodBoyDigital/pixi.js.git","clone_url":"https://github.com/GoodBoyDigital/pixi.js.git","svn_url":"https://github.com/GoodBoyDigital/pixi.js","homepage":null,"size":46033,"stargazers_count":6831,"watchers_count":6831,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1373,"mirror_url":null,"open_issues_count":100,"forks":1373,"open_issues":100,"watchers":6831,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470"},"html":{"href":"https://github.com/GoodBoyDigital/pixi.js/pull/1470"},"issue":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1470"},"comments":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/GoodBoyDigital/pixi.js/statuses/2eae97c696d3a67b7a19297d981c1008b8aa990c"}}}}