{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/33343028","id":33343028,"diff_hunk":"@@ -343,4 +344,9 @@\n     * Executes a remote script passing a set of named parameters\n     */\n    <T> T execute(String scriptName, Map<String, ?> params);\n+\n+   /**\n+    * Returns segment ownership for this cache\n+    */\n+   Map<SocketAddress, Set<Integer>> getSegmentsByServer();","path":"client/hotrod-client/src/main/java/org/infinispan/client/hotrod/RemoteCache.java","position":15,"original_position":15,"commit_id":"be8b76fd4cb26ff310387e6302b85ee751884514","original_commit_id":"be8b76fd4cb26ff310387e6302b85ee751884514","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"Yeah, I understand, but then I'd probably prefer to encapsulate the return type into an interface like RemoteSegmentMapping instead of Map<SocketAddress, Set<Integer>> (same for retrieveEntries).","created_at":"2015-06-26T10:00:23Z","updated_at":"2015-06-26T10:00:23Z","html_url":"https://github.com/infinispan/infinispan/pull/3532#discussion_r33343028","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3532","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/33343028"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3532#discussion_r33343028"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3532"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3532","id":37409525,"html_url":"https://github.com/infinispan/infinispan/pull/3532","diff_url":"https://github.com/infinispan/infinispan/pull/3532.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3532.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3532","number":3532,"state":"open","locked":false,"title":"ISPN-5528 Expose segment ownership in the Hot Rod client","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-5528\r\n\r\nChanges in the server:\r\n\r\n* Always send ```numSegments``` for clustered caches. \r\n* Sends all owners instead of only 2 during topology changes\r\n\r\nChanges in the client:\r\n\r\n* Added ```getSegmentsByServer()``` method that:\r\n   * if there's topology in the server, but hash function is zero, assumes REPL cache and every server is associated with all segments ```{0...numSegments-1}```\r\n   * if there's no topology present (topologyId < 0), associates the server with an empty set (LOCAL cache)   \r\n   * If both ```numSegments``` and ```hashFunction``` are present (DIST) uses the consistent hash to associate the segments to each server","created_at":"2015-06-10T22:01:08Z","updated_at":"2015-06-26T10:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25dcceefc1840ebd1a193466bd4623b8e32eec4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3532/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3532/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3532/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/be8b76fd4cb26ff310387e6302b85ee751884514","head":{"label":"gustavonalle:ISPN-5528","ref":"ISPN-5528","sha":"be8b76fd4cb26ff310387e6302b85ee751884514","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"repo":{"id":20231400,"name":"infinispan","full_name":"gustavonalle/infinispan","owner":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustavonalle/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/gustavonalle/infinispan","forks_url":"https://api.github.com/repos/gustavonalle/infinispan/forks","keys_url":"https://api.github.com/repos/gustavonalle/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavonalle/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavonalle/infinispan/teams","hooks_url":"https://api.github.com/repos/gustavonalle/infinispan/hooks","issue_events_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/gustavonalle/infinispan/events","assignees_url":"https://api.github.com/repos/gustavonalle/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/gustavonalle/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/gustavonalle/infinispan/tags","blobs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavonalle/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavonalle/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavonalle/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavonalle/infinispan/languages","stargazers_url":"https://api.github.com/repos/gustavonalle/infinispan/stargazers","contributors_url":"https://api.github.com/repos/gustavonalle/infinispan/contributors","subscribers_url":"https://api.github.com/repos/gustavonalle/infinispan/subscribers","subscription_url":"https://api.github.com/repos/gustavonalle/infinispan/subscription","commits_url":"https://api.github.com/repos/gustavonalle/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavonalle/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavonalle/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavonalle/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/gustavonalle/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavonalle/infinispan/merges","archive_url":"https://api.github.com/repos/gustavonalle/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavonalle/infinispan/downloads","issues_url":"https://api.github.com/repos/gustavonalle/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/gustavonalle/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavonalle/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavonalle/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavonalle/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/gustavonalle/infinispan/releases{/id}","created_at":"2014-05-27T18:52:33Z","updated_at":"2015-05-06T08:02:25Z","pushed_at":"2015-06-22T12:58:54Z","git_url":"git://github.com/gustavonalle/infinispan.git","ssh_url":"git@github.com:gustavonalle/infinispan.git","clone_url":"https://github.com/gustavonalle/infinispan.git","svn_url":"https://github.com/gustavonalle/infinispan","homepage":"http://www.infinispan.org","size":67949,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"47b709d7e0017e72d4d850ae9e7e015a8654da20","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-06-21T13:05:17Z","pushed_at":"2015-06-25T13:21:14Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":151648,"stargazers_count":387,"watchers_count":387,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"open_issues_count":14,"forks":295,"open_issues":14,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3532"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3532"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3532"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3532/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3532/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3532/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/be8b76fd4cb26ff310387e6302b85ee751884514"}}}}