{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/otr4j/otr4j/pulls/6","id":26953530,"html_url":"https://github.com/otr4j/otr4j/pull/6","diff_url":"https://github.com/otr4j/otr4j/pull/6.diff","patch_url":"https://github.com/otr4j/otr4j/pull/6.patch","issue_url":"https://api.github.com/repos/otr4j/otr4j/issues/6","number":6,"state":"closed","locked":false,"title":"Fix verify method : the 2 arrays compared were the same -> use this.xEnc...","user":{"login":"MT4NGUY","id":3844057,"avatar_url":"https://avatars.githubusercontent.com/u/3844057?v=3","gravatar_id":"","url":"https://api.github.com/users/MT4NGUY","html_url":"https://github.com/MT4NGUY","followers_url":"https://api.github.com/users/MT4NGUY/followers","following_url":"https://api.github.com/users/MT4NGUY/following{/other_user}","gists_url":"https://api.github.com/users/MT4NGUY/gists{/gist_id}","starred_url":"https://api.github.com/users/MT4NGUY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MT4NGUY/subscriptions","organizations_url":"https://api.github.com/users/MT4NGUY/orgs","repos_url":"https://api.github.com/users/MT4NGUY/repos","events_url":"https://api.github.com/users/MT4NGUY/events{/privacy}","received_events_url":"https://api.github.com/users/MT4NGUY/received_events","type":"User","site_admin":false},"body":"In the verify method there is a mistake when comparing two arrays, the fix is simple : use the xEncryptedMAC instance of the current SignatureMessage object (\"this.xEncryptedMAC\") instead of the local one.","created_at":"2015-01-07T12:09:37Z","updated_at":"2015-01-09T22:25:12Z","closed_at":"2015-01-09T22:25:12Z","merged_at":"2015-01-09T22:25:12Z","merge_commit_sha":"7bd32dccb2e284dd5b8e0841b81a5c8f3ba59702","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otr4j/otr4j/pulls/6/commits","review_comments_url":"https://api.github.com/repos/otr4j/otr4j/pulls/6/comments","review_comment_url":"https://api.github.com/repos/otr4j/otr4j/pulls/comments/{number}","comments_url":"https://api.github.com/repos/otr4j/otr4j/issues/6/comments","statuses_url":"https://api.github.com/repos/otr4j/otr4j/statuses/136e8f1b1210a38470a61d1718af73d4f5029de5","head":{"label":"MT4NGUY:fix_macverif","ref":"fix_macverif","sha":"136e8f1b1210a38470a61d1718af73d4f5029de5","user":{"login":"MT4NGUY","id":3844057,"avatar_url":"https://avatars.githubusercontent.com/u/3844057?v=3","gravatar_id":"","url":"https://api.github.com/users/MT4NGUY","html_url":"https://github.com/MT4NGUY","followers_url":"https://api.github.com/users/MT4NGUY/followers","following_url":"https://api.github.com/users/MT4NGUY/following{/other_user}","gists_url":"https://api.github.com/users/MT4NGUY/gists{/gist_id}","starred_url":"https://api.github.com/users/MT4NGUY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MT4NGUY/subscriptions","organizations_url":"https://api.github.com/users/MT4NGUY/orgs","repos_url":"https://api.github.com/users/MT4NGUY/repos","events_url":"https://api.github.com/users/MT4NGUY/events{/privacy}","received_events_url":"https://api.github.com/users/MT4NGUY/received_events","type":"User","site_admin":false},"repo":{"id":28909258,"name":"otr4j","full_name":"MT4NGUY/otr4j","owner":{"login":"MT4NGUY","id":3844057,"avatar_url":"https://avatars.githubusercontent.com/u/3844057?v=3","gravatar_id":"","url":"https://api.github.com/users/MT4NGUY","html_url":"https://github.com/MT4NGUY","followers_url":"https://api.github.com/users/MT4NGUY/followers","following_url":"https://api.github.com/users/MT4NGUY/following{/other_user}","gists_url":"https://api.github.com/users/MT4NGUY/gists{/gist_id}","starred_url":"https://api.github.com/users/MT4NGUY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MT4NGUY/subscriptions","organizations_url":"https://api.github.com/users/MT4NGUY/orgs","repos_url":"https://api.github.com/users/MT4NGUY/repos","events_url":"https://api.github.com/users/MT4NGUY/events{/privacy}","received_events_url":"https://api.github.com/users/MT4NGUY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MT4NGUY/otr4j","description":"OTR4J fork","fork":true,"url":"https://api.github.com/repos/MT4NGUY/otr4j","forks_url":"https://api.github.com/repos/MT4NGUY/otr4j/forks","keys_url":"https://api.github.com/repos/MT4NGUY/otr4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MT4NGUY/otr4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MT4NGUY/otr4j/teams","hooks_url":"https://api.github.com/repos/MT4NGUY/otr4j/hooks","issue_events_url":"https://api.github.com/repos/MT4NGUY/otr4j/issues/events{/number}","events_url":"https://api.github.com/repos/MT4NGUY/otr4j/events","assignees_url":"https://api.github.com/repos/MT4NGUY/otr4j/assignees{/user}","branches_url":"https://api.github.com/repos/MT4NGUY/otr4j/branches{/branch}","tags_url":"https://api.github.com/repos/MT4NGUY/otr4j/tags","blobs_url":"https://api.github.com/repos/MT4NGUY/otr4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MT4NGUY/otr4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MT4NGUY/otr4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MT4NGUY/otr4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MT4NGUY/otr4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MT4NGUY/otr4j/languages","stargazers_url":"https://api.github.com/repos/MT4NGUY/otr4j/stargazers","contributors_url":"https://api.github.com/repos/MT4NGUY/otr4j/contributors","subscribers_url":"https://api.github.com/repos/MT4NGUY/otr4j/subscribers","subscription_url":"https://api.github.com/repos/MT4NGUY/otr4j/subscription","commits_url":"https://api.github.com/repos/MT4NGUY/otr4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MT4NGUY/otr4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MT4NGUY/otr4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MT4NGUY/otr4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/MT4NGUY/otr4j/contents/{+path}","compare_url":"https://api.github.com/repos/MT4NGUY/otr4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MT4NGUY/otr4j/merges","archive_url":"https://api.github.com/repos/MT4NGUY/otr4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MT4NGUY/otr4j/downloads","issues_url":"https://api.github.com/repos/MT4NGUY/otr4j/issues{/number}","pulls_url":"https://api.github.com/repos/MT4NGUY/otr4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MT4NGUY/otr4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MT4NGUY/otr4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MT4NGUY/otr4j/labels{/name}","releases_url":"https://api.github.com/repos/MT4NGUY/otr4j/releases{/id}","created_at":"2015-01-07T10:10:14Z","updated_at":"2015-01-07T10:10:15Z","pushed_at":"2015-01-07T11:25:45Z","git_url":"git://github.com/MT4NGUY/otr4j.git","ssh_url":"git@github.com:MT4NGUY/otr4j.git","clone_url":"https://github.com/MT4NGUY/otr4j.git","svn_url":"https://github.com/MT4NGUY/otr4j","homepage":null,"size":4142,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"otr4j:master","ref":"master","sha":"d9c38a3f347cdcb80797f09815343d8544e58df5","user":{"login":"otr4j","id":9977580,"avatar_url":"https://avatars.githubusercontent.com/u/9977580?v=3","gravatar_id":"","url":"https://api.github.com/users/otr4j","html_url":"https://github.com/otr4j","followers_url":"https://api.github.com/users/otr4j/followers","following_url":"https://api.github.com/users/otr4j/following{/other_user}","gists_url":"https://api.github.com/users/otr4j/gists{/gist_id}","starred_url":"https://api.github.com/users/otr4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otr4j/subscriptions","organizations_url":"https://api.github.com/users/otr4j/orgs","repos_url":"https://api.github.com/users/otr4j/repos","events_url":"https://api.github.com/users/otr4j/events{/privacy}","received_events_url":"https://api.github.com/users/otr4j/received_events","type":"Organization","site_admin":false},"repo":{"id":27228686,"name":"otr4j","full_name":"otr4j/otr4j","owner":{"login":"otr4j","id":9977580,"avatar_url":"https://avatars.githubusercontent.com/u/9977580?v=3","gravatar_id":"","url":"https://api.github.com/users/otr4j","html_url":"https://github.com/otr4j","followers_url":"https://api.github.com/users/otr4j/followers","following_url":"https://api.github.com/users/otr4j/following{/other_user}","gists_url":"https://api.github.com/users/otr4j/gists{/gist_id}","starred_url":"https://api.github.com/users/otr4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otr4j/subscriptions","organizations_url":"https://api.github.com/users/otr4j/orgs","repos_url":"https://api.github.com/users/otr4j/repos","events_url":"https://api.github.com/users/otr4j/events{/privacy}","received_events_url":"https://api.github.com/users/otr4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otr4j/otr4j","description":"OTR4J fork","fork":true,"url":"https://api.github.com/repos/otr4j/otr4j","forks_url":"https://api.github.com/repos/otr4j/otr4j/forks","keys_url":"https://api.github.com/repos/otr4j/otr4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otr4j/otr4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otr4j/otr4j/teams","hooks_url":"https://api.github.com/repos/otr4j/otr4j/hooks","issue_events_url":"https://api.github.com/repos/otr4j/otr4j/issues/events{/number}","events_url":"https://api.github.com/repos/otr4j/otr4j/events","assignees_url":"https://api.github.com/repos/otr4j/otr4j/assignees{/user}","branches_url":"https://api.github.com/repos/otr4j/otr4j/branches{/branch}","tags_url":"https://api.github.com/repos/otr4j/otr4j/tags","blobs_url":"https://api.github.com/repos/otr4j/otr4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otr4j/otr4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otr4j/otr4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/otr4j/otr4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otr4j/otr4j/statuses/{sha}","languages_url":"https://api.github.com/repos/otr4j/otr4j/languages","stargazers_url":"https://api.github.com/repos/otr4j/otr4j/stargazers","contributors_url":"https://api.github.com/repos/otr4j/otr4j/contributors","subscribers_url":"https://api.github.com/repos/otr4j/otr4j/subscribers","subscription_url":"https://api.github.com/repos/otr4j/otr4j/subscription","commits_url":"https://api.github.com/repos/otr4j/otr4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/otr4j/otr4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/otr4j/otr4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/otr4j/otr4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/otr4j/otr4j/contents/{+path}","compare_url":"https://api.github.com/repos/otr4j/otr4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otr4j/otr4j/merges","archive_url":"https://api.github.com/repos/otr4j/otr4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otr4j/otr4j/downloads","issues_url":"https://api.github.com/repos/otr4j/otr4j/issues{/number}","pulls_url":"https://api.github.com/repos/otr4j/otr4j/pulls{/number}","milestones_url":"https://api.github.com/repos/otr4j/otr4j/milestones{/number}","notifications_url":"https://api.github.com/repos/otr4j/otr4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otr4j/otr4j/labels{/name}","releases_url":"https://api.github.com/repos/otr4j/otr4j/releases{/id}","created_at":"2014-11-27T14:26:47Z","updated_at":"2015-01-09T22:25:12Z","pushed_at":"2015-01-09T22:25:12Z","git_url":"git://github.com/otr4j/otr4j.git","ssh_url":"git@github.com:otr4j/otr4j.git","clone_url":"https://github.com/otr4j/otr4j.git","svn_url":"https://github.com/otr4j/otr4j","homepage":null,"size":4311,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otr4j/otr4j/pulls/6"},"html":{"href":"https://github.com/otr4j/otr4j/pull/6"},"issue":{"href":"https://api.github.com/repos/otr4j/otr4j/issues/6"},"comments":{"href":"https://api.github.com/repos/otr4j/otr4j/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/otr4j/otr4j/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/otr4j/otr4j/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/otr4j/otr4j/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/otr4j/otr4j/statuses/136e8f1b1210a38470a61d1718af73d4f5029de5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eighthave","id":143465,"avatar_url":"https://avatars.githubusercontent.com/u/143465?v=3","gravatar_id":"","url":"https://api.github.com/users/eighthave","html_url":"https://github.com/eighthave","followers_url":"https://api.github.com/users/eighthave/followers","following_url":"https://api.github.com/users/eighthave/following{/other_user}","gists_url":"https://api.github.com/users/eighthave/gists{/gist_id}","starred_url":"https://api.github.com/users/eighthave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eighthave/subscriptions","organizations_url":"https://api.github.com/users/eighthave/orgs","repos_url":"https://api.github.com/users/eighthave/repos","events_url":"https://api.github.com/users/eighthave/events{/privacy}","received_events_url":"https://api.github.com/users/eighthave/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}