{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/23220547","id":23220547,"diff_hunk":"@@ -0,0 +1,122 @@\n+/*\n+ * SonarQube Java\n+ * Copyright (C) 2012 SonarSource\n+ * dev@sonar.codehaus.org\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 3 of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02\n+ */\n+package org.sonar.java.checks;\n+\n+import com.google.common.base.Joiner;\n+import com.google.common.base.Splitter;\n+import com.google.common.collect.ImmutableList;\n+import com.google.common.collect.Lists;\n+import org.apache.commons.lang.StringUtils;\n+import org.sonar.check.Priority;\n+import org.sonar.check.Rule;\n+import org.sonar.check.RuleProperty;\n+import org.sonar.java.model.AbstractTypedTree;\n+import org.sonar.java.model.LiteralUtils;\n+import org.sonar.plugins.java.api.tree.AnnotationTree;\n+import org.sonar.plugins.java.api.tree.ExpressionTree;\n+import org.sonar.plugins.java.api.tree.LiteralTree;\n+import org.sonar.plugins.java.api.tree.NewArrayTree;\n+import org.sonar.plugins.java.api.tree.Tree;\n+import org.sonar.plugins.java.api.tree.Tree.Kind;\n+\n+import java.util.List;\n+\n+@Rule(\n+  key = \"S1309\",\n+  priority = Priority.INFO,\n+  tags = {})\n+public class SuppressWarningsCheck extends SubscriptionBaseVisitor {\n+\n+  @RuleProperty(\n+    key = \"listOfWarnings\",\n+    defaultValue = \"\")\n+  public String warningsCommaSeparated = \"\";\n+\n+  private List<String> forbiddenWarnings;\n+\n+  @Override\n+  public List<Kind> nodesToVisit() {\n+    return ImmutableList.of(Tree.Kind.ANNOTATION);\n+  }\n+\n+  @Override\n+  public void visitNode(Tree tree) {\n+    AnnotationTree annotationTree = (AnnotationTree) tree;\n+    List<String> ruleWarnings = getRuleWarnings();\n+\n+    if (isJavaLangSuppressWarnings(annotationTree)) {\n+      if (ruleWarnings.isEmpty()) {\n+        addIssue(annotationTree, \"Suppressing the warnings is not allowed\");\n+      } else {\n+        List<String> suppressedWarnings = getSuppressedWarnings(annotationTree.arguments().get(0));\n+        List<String> issues = Lists.newArrayList();\n+        for (String currentWarning : suppressedWarnings) {\n+          if (ruleWarnings.contains(currentWarning)) {\n+            issues.add(new StringBuilder().append(\"'\").append(currentWarning).append(\"'\").toString());\n+          }\n+        }\n+        if (!issues.isEmpty()) {\n+          StringBuilder sb = new StringBuilder(\"Suppressing the \").append(Joiner.on(\", \").join(issues))\n+            .append(\" warning\").append(issues.size() > 1 ? \"s\" : \"\").append(\" is not allowed\");\n+          addIssue(annotationTree, sb.toString());\n+        }\n+      }\n+    }\n+  }\n+\n+  private boolean isJavaLangSuppressWarnings(AnnotationTree tree) {\n+    return ((AbstractTypedTree) tree).getSymbolType().is(\"java.lang.SuppressWarnings\");\n+  }\n+\n+  private List<String> getRuleWarnings() {","path":"java-checks/src/main/java/org/sonar/java/checks/SuppressWarningsCheck.java","position":88,"original_position":88,"commit_id":"ba1f4af38bb3e74ddc49dc8475f199d20b0dbeec","original_commit_id":"ba1f4af38bb3e74ddc49dc8475f199d20b0dbeec","user":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"body":"Renaming method to forbiddenWarnings ?","created_at":"2015-01-20T13:09:48Z","updated_at":"2015-01-20T13:09:48Z","html_url":"https://github.com/SonarSource/sonar-java/pull/21#discussion_r23220547","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/23220547"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/21#discussion_r23220547"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21","id":27667920,"html_url":"https://github.com/SonarSource/sonar-java/pull/21","diff_url":"https://github.com/SonarSource/sonar-java/pull/21.diff","patch_url":"https://github.com/SonarSource/sonar-java/pull/21.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/21","number":21,"state":"open","locked":false,"title":"Sonarjava 339 suppress warnings","user":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-20T10:41:40Z","updated_at":"2015-01-20T13:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b125421a61e3a2879208224793676daafd3d1148","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/21/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ba1f4af38bb3e74ddc49dc8475f199d20b0dbeec","head":{"label":"m-g-sonar:SONARJAVA-339_suppressWarnings","ref":"SONARJAVA-339_suppressWarnings","sha":"ba1f4af38bb3e74ddc49dc8475f199d20b0dbeec","user":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"repo":{"id":29524789,"name":"sonar-java","full_name":"m-g-sonar/sonar-java","owner":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m-g-sonar/sonar-java","description":"","fork":true,"url":"https://api.github.com/repos/m-g-sonar/sonar-java","forks_url":"https://api.github.com/repos/m-g-sonar/sonar-java/forks","keys_url":"https://api.github.com/repos/m-g-sonar/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-g-sonar/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-g-sonar/sonar-java/teams","hooks_url":"https://api.github.com/repos/m-g-sonar/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/m-g-sonar/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/m-g-sonar/sonar-java/events","assignees_url":"https://api.github.com/repos/m-g-sonar/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/m-g-sonar/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/m-g-sonar/sonar-java/tags","blobs_url":"https://api.github.com/repos/m-g-sonar/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-g-sonar/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-g-sonar/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-g-sonar/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-g-sonar/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/m-g-sonar/sonar-java/languages","stargazers_url":"https://api.github.com/repos/m-g-sonar/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/m-g-sonar/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/m-g-sonar/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/m-g-sonar/sonar-java/subscription","commits_url":"https://api.github.com/repos/m-g-sonar/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-g-sonar/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-g-sonar/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-g-sonar/sonar-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/m-g-sonar/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/m-g-sonar/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-g-sonar/sonar-java/merges","archive_url":"https://api.github.com/repos/m-g-sonar/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-g-sonar/sonar-java/downloads","issues_url":"https://api.github.com/repos/m-g-sonar/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/m-g-sonar/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/m-g-sonar/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/m-g-sonar/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-g-sonar/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/m-g-sonar/sonar-java/releases{/id}","created_at":"2015-01-20T10:39:06Z","updated_at":"2015-01-20T10:39:09Z","pushed_at":"2015-01-20T13:00:48Z","git_url":"git://github.com/m-g-sonar/sonar-java.git","ssh_url":"git@github.com:m-g-sonar/sonar-java.git","clone_url":"https://github.com/m-g-sonar/sonar-java.git","svn_url":"https://github.com/m-g-sonar/sonar-java","homepage":"","size":24285,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"64aaa9bfab43f0c85deee59cbffbe8c8f84c7f1c","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5674787,"name":"sonar-java","full_name":"SonarSource/sonar-java","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-java","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-java","forks_url":"https://api.github.com/repos/SonarSource/sonar-java/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-java/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-java/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-java/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-java/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-java/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-java/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-java/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-java/releases{/id}","created_at":"2012-09-04T15:53:13Z","updated_at":"2015-01-19T16:41:21Z","pushed_at":"2015-01-19T16:41:21Z","git_url":"git://github.com/SonarSource/sonar-java.git","ssh_url":"git@github.com:SonarSource/sonar-java.git","clone_url":"https://github.com/SonarSource/sonar-java.git","svn_url":"https://github.com/SonarSource/sonar-java","homepage":"","size":24285,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":8,"forks":56,"open_issues":8,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/21"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/21"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ba1f4af38bb3e74ddc49dc8475f199d20b0dbeec"}}}}