{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/process/pulls/comments/43910036","id":43910036,"diff_hunk":"@@ -44,9 +44,16 @@ library\n     exposed-modules:\n         System.Cmd\n         System.Process\n-    if impl(ghc)\n-        exposed-modules:\n-            System.Process.Internals\n+        System.Process.Internals\n+    other-modules: System.Process.Common\n+    if os(windows)\n+        other-modules: System.Process.Windows\n+        build-depends: Win32 >=2.2 && < 2.4\n+        extra-libraries: kernel32\n+        cpp-options: -DWINDOWS","path":"process.cabal","position":13,"original_position":13,"commit_id":"9dae7ad1b5688723f129cd9eb2b2b82f7f2f6ec4","original_commit_id":"9dae7ad1b5688723f129cd9eb2b2b82f7f2f6ec4","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"body":"Usage was inconsistent in the codebase previously around a few different ways of detecting Windows, and I've seen concerns raised in the past about the reliability of those macros. I feel more comfortable using the same logic for the Haskell code conditionals as the Cabal conditionals guiding the package dependencies and module selection.","created_at":"2015-11-04T17:21:20Z","updated_at":"2015-11-04T17:21:20Z","html_url":"https://github.com/haskell/process/pull/47#discussion_r43910036","pull_request_url":"https://api.github.com/repos/haskell/process/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/haskell/process/pulls/comments/43910036"},"html":{"href":"https://github.com/haskell/process/pull/47#discussion_r43910036"},"pull_request":{"href":"https://api.github.com/repos/haskell/process/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/process/pulls/47","id":49581153,"html_url":"https://github.com/haskell/process/pull/47","diff_url":"https://github.com/haskell/process/pull/47.diff","patch_url":"https://github.com/haskell/process/pull/47.patch","issue_url":"https://api.github.com/repos/haskell/process/issues/47","number":47,"state":"open","locked":false,"title":"Use less CPP","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"body":"Major changes:\r\n\r\n* Most Windows-specific and POSIX-specific code live in their own modules\r\n* No more GLASGOW_HASKELL conditionals, since it didn't work anyway\r\n\r\nThis now compiles without warnings on Linux and Windows, addressing Simon's original concern.\r\n\r\n@hvr would you mind reviewing?","created_at":"2015-11-03T16:55:23Z","updated_at":"2015-11-04T17:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1839a4ede2463c5c114c6af55d528d2edac3c523","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell/process/pulls/47/commits","review_comments_url":"https://api.github.com/repos/haskell/process/pulls/47/comments","review_comment_url":"https://api.github.com/repos/haskell/process/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/process/issues/47/comments","statuses_url":"https://api.github.com/repos/haskell/process/statuses/9dae7ad1b5688723f129cd9eb2b2b82f7f2f6ec4","head":{"label":"haskell:less-cpp","ref":"less-cpp","sha":"9dae7ad1b5688723f129cd9eb2b2b82f7f2f6ec4","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":19369721,"name":"process","full_name":"haskell/process","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/process","description":"Library for dealing with system processes","fork":false,"url":"https://api.github.com/repos/haskell/process","forks_url":"https://api.github.com/repos/haskell/process/forks","keys_url":"https://api.github.com/repos/haskell/process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/process/teams","hooks_url":"https://api.github.com/repos/haskell/process/hooks","issue_events_url":"https://api.github.com/repos/haskell/process/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/process/events","assignees_url":"https://api.github.com/repos/haskell/process/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/process/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/process/tags","blobs_url":"https://api.github.com/repos/haskell/process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/process/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/process/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/process/languages","stargazers_url":"https://api.github.com/repos/haskell/process/stargazers","contributors_url":"https://api.github.com/repos/haskell/process/contributors","subscribers_url":"https://api.github.com/repos/haskell/process/subscribers","subscription_url":"https://api.github.com/repos/haskell/process/subscription","commits_url":"https://api.github.com/repos/haskell/process/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/process/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/process/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/process/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/process/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/process/merges","archive_url":"https://api.github.com/repos/haskell/process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/process/downloads","issues_url":"https://api.github.com/repos/haskell/process/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/process/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/process/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/process/labels{/name}","releases_url":"https://api.github.com/repos/haskell/process/releases{/id}","created_at":"2014-05-02T08:20:22Z","updated_at":"2015-10-20T03:25:15Z","pushed_at":"2015-11-03T16:56:24Z","git_url":"git://github.com/haskell/process.git","ssh_url":"git@github.com:haskell/process.git","clone_url":"https://github.com/haskell/process.git","svn_url":"https://github.com/haskell/process","homepage":"http://hackage.haskell.org/package/process","size":2776,"stargazers_count":13,"watchers_count":13,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"7428b614841e6b6416e501453546b0af19a0cd1f","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":19369721,"name":"process","full_name":"haskell/process","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/process","description":"Library for dealing with system processes","fork":false,"url":"https://api.github.com/repos/haskell/process","forks_url":"https://api.github.com/repos/haskell/process/forks","keys_url":"https://api.github.com/repos/haskell/process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/process/teams","hooks_url":"https://api.github.com/repos/haskell/process/hooks","issue_events_url":"https://api.github.com/repos/haskell/process/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/process/events","assignees_url":"https://api.github.com/repos/haskell/process/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/process/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/process/tags","blobs_url":"https://api.github.com/repos/haskell/process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/process/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/process/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/process/languages","stargazers_url":"https://api.github.com/repos/haskell/process/stargazers","contributors_url":"https://api.github.com/repos/haskell/process/contributors","subscribers_url":"https://api.github.com/repos/haskell/process/subscribers","subscription_url":"https://api.github.com/repos/haskell/process/subscription","commits_url":"https://api.github.com/repos/haskell/process/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/process/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/process/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/process/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/process/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/process/merges","archive_url":"https://api.github.com/repos/haskell/process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/process/downloads","issues_url":"https://api.github.com/repos/haskell/process/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/process/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/process/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/process/labels{/name}","releases_url":"https://api.github.com/repos/haskell/process/releases{/id}","created_at":"2014-05-02T08:20:22Z","updated_at":"2015-10-20T03:25:15Z","pushed_at":"2015-11-03T16:56:24Z","git_url":"git://github.com/haskell/process.git","ssh_url":"git@github.com:haskell/process.git","clone_url":"https://github.com/haskell/process.git","svn_url":"https://github.com/haskell/process","homepage":"http://hackage.haskell.org/package/process","size":2776,"stargazers_count":13,"watchers_count":13,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/process/pulls/47"},"html":{"href":"https://github.com/haskell/process/pull/47"},"issue":{"href":"https://api.github.com/repos/haskell/process/issues/47"},"comments":{"href":"https://api.github.com/repos/haskell/process/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/process/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/process/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/process/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/process/statuses/9dae7ad1b5688723f129cd9eb2b2b82f7f2f6ec4"}}}}