{"action":"created","comment":{"url":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments/34429012","id":34429012,"diff_hunk":"@@ -387,6 +387,20 @@\n \n         get: function (recid, returnIndex) {\n             // search records\n+            if ($.isArray(recid)) {\n+                var returnrecs = [];\n+                for (var i = 0; i < this.records.length; i++) {\n+                    if ($.inArray(this.records[i].recid, recid) != -1) {\n+                        if (returnIndex === true) returnrecs.push({'store': 'records', 'index': i}); else returnrecs.push(this.records[i]); ","path":"src/w2grid.js","position":8,"original_position":8,"commit_id":"45a2eb6fddf862df6d68e7cb0e317705cee6cab7","original_commit_id":"45a2eb6fddf862df6d68e7cb0e317705cee6cab7","user":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"body":"I think to be consistent, it should just return a number. I know that there is no way to know if this number belongs to records or summary, but I think that it would be in line with existing functionality. Developer will be able to check by looking up a record if this is in records or in summary. Plus, summary are much less frequently used.","created_at":"2015-07-13T01:41:49Z","updated_at":"2015-07-13T01:41:49Z","html_url":"https://github.com/vitmalina/w2ui/pull/979#discussion_r34429012","pull_request_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments/34429012"},"html":{"href":"https://github.com/vitmalina/w2ui/pull/979#discussion_r34429012"},"pull_request":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/vitmalina/w2ui/pulls/979","id":39119175,"html_url":"https://github.com/vitmalina/w2ui/pull/979","diff_url":"https://github.com/vitmalina/w2ui/pull/979.diff","patch_url":"https://github.com/vitmalina/w2ui/pull/979.patch","issue_url":"https://api.github.com/repos/vitmalina/w2ui/issues/979","number":979,"state":"open","locked":false,"title":"Arrays support in w2grid.get()","user":{"login":"loxiw","id":4063362,"avatar_url":"https://avatars.githubusercontent.com/u/4063362?v=3","gravatar_id":"","url":"https://api.github.com/users/loxiw","html_url":"https://github.com/loxiw","followers_url":"https://api.github.com/users/loxiw/followers","following_url":"https://api.github.com/users/loxiw/following{/other_user}","gists_url":"https://api.github.com/users/loxiw/gists{/gist_id}","starred_url":"https://api.github.com/users/loxiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loxiw/subscriptions","organizations_url":"https://api.github.com/users/loxiw/orgs","repos_url":"https://api.github.com/users/loxiw/repos","events_url":"https://api.github.com/users/loxiw/events{/privacy}","received_events_url":"https://api.github.com/users/loxiw/received_events","type":"User","site_admin":false},"body":"I'm not sure if that's the best way to handle the response when is array and returnIndex is true","created_at":"2015-07-02T19:47:18Z","updated_at":"2015-07-13T01:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"473a7711bb01938b99f65cc0638e4b523d29c302","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/979/commits","review_comments_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/979/comments","review_comment_url":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitmalina/w2ui/issues/979/comments","statuses_url":"https://api.github.com/repos/vitmalina/w2ui/statuses/45a2eb6fddf862df6d68e7cb0e317705cee6cab7","head":{"label":"loxiw:master","ref":"master","sha":"45a2eb6fddf862df6d68e7cb0e317705cee6cab7","user":{"login":"loxiw","id":4063362,"avatar_url":"https://avatars.githubusercontent.com/u/4063362?v=3","gravatar_id":"","url":"https://api.github.com/users/loxiw","html_url":"https://github.com/loxiw","followers_url":"https://api.github.com/users/loxiw/followers","following_url":"https://api.github.com/users/loxiw/following{/other_user}","gists_url":"https://api.github.com/users/loxiw/gists{/gist_id}","starred_url":"https://api.github.com/users/loxiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loxiw/subscriptions","organizations_url":"https://api.github.com/users/loxiw/orgs","repos_url":"https://api.github.com/users/loxiw/repos","events_url":"https://api.github.com/users/loxiw/events{/privacy}","received_events_url":"https://api.github.com/users/loxiw/received_events","type":"User","site_admin":false},"repo":{"id":37342114,"name":"w2ui","full_name":"loxiw/w2ui","owner":{"login":"loxiw","id":4063362,"avatar_url":"https://avatars.githubusercontent.com/u/4063362?v=3","gravatar_id":"","url":"https://api.github.com/users/loxiw","html_url":"https://github.com/loxiw","followers_url":"https://api.github.com/users/loxiw/followers","following_url":"https://api.github.com/users/loxiw/following{/other_user}","gists_url":"https://api.github.com/users/loxiw/gists{/gist_id}","starred_url":"https://api.github.com/users/loxiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loxiw/subscriptions","organizations_url":"https://api.github.com/users/loxiw/orgs","repos_url":"https://api.github.com/users/loxiw/repos","events_url":"https://api.github.com/users/loxiw/events{/privacy}","received_events_url":"https://api.github.com/users/loxiw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loxiw/w2ui","description":"JavaScript UI library for data-driven web applications","fork":true,"url":"https://api.github.com/repos/loxiw/w2ui","forks_url":"https://api.github.com/repos/loxiw/w2ui/forks","keys_url":"https://api.github.com/repos/loxiw/w2ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loxiw/w2ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loxiw/w2ui/teams","hooks_url":"https://api.github.com/repos/loxiw/w2ui/hooks","issue_events_url":"https://api.github.com/repos/loxiw/w2ui/issues/events{/number}","events_url":"https://api.github.com/repos/loxiw/w2ui/events","assignees_url":"https://api.github.com/repos/loxiw/w2ui/assignees{/user}","branches_url":"https://api.github.com/repos/loxiw/w2ui/branches{/branch}","tags_url":"https://api.github.com/repos/loxiw/w2ui/tags","blobs_url":"https://api.github.com/repos/loxiw/w2ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loxiw/w2ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loxiw/w2ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/loxiw/w2ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loxiw/w2ui/statuses/{sha}","languages_url":"https://api.github.com/repos/loxiw/w2ui/languages","stargazers_url":"https://api.github.com/repos/loxiw/w2ui/stargazers","contributors_url":"https://api.github.com/repos/loxiw/w2ui/contributors","subscribers_url":"https://api.github.com/repos/loxiw/w2ui/subscribers","subscription_url":"https://api.github.com/repos/loxiw/w2ui/subscription","commits_url":"https://api.github.com/repos/loxiw/w2ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/loxiw/w2ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/loxiw/w2ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/loxiw/w2ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/loxiw/w2ui/contents/{+path}","compare_url":"https://api.github.com/repos/loxiw/w2ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loxiw/w2ui/merges","archive_url":"https://api.github.com/repos/loxiw/w2ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loxiw/w2ui/downloads","issues_url":"https://api.github.com/repos/loxiw/w2ui/issues{/number}","pulls_url":"https://api.github.com/repos/loxiw/w2ui/pulls{/number}","milestones_url":"https://api.github.com/repos/loxiw/w2ui/milestones{/number}","notifications_url":"https://api.github.com/repos/loxiw/w2ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loxiw/w2ui/labels{/name}","releases_url":"https://api.github.com/repos/loxiw/w2ui/releases{/id}","created_at":"2015-06-12T20:06:37Z","updated_at":"2015-06-12T20:06:38Z","pushed_at":"2015-07-02T19:44:59Z","git_url":"git://github.com/loxiw/w2ui.git","ssh_url":"git@github.com:loxiw/w2ui.git","clone_url":"https://github.com/loxiw/w2ui.git","svn_url":"https://github.com/loxiw/w2ui","homepage":"http://w2ui.com","size":19279,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vitmalina:master","ref":"master","sha":"8d42dd218785d2355f87feab3abf5172942e6dc8","user":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"repo":{"id":1604375,"name":"w2ui","full_name":"vitmalina/w2ui","owner":{"login":"vitmalina","id":561995,"avatar_url":"https://avatars.githubusercontent.com/u/561995?v=3","gravatar_id":"","url":"https://api.github.com/users/vitmalina","html_url":"https://github.com/vitmalina","followers_url":"https://api.github.com/users/vitmalina/followers","following_url":"https://api.github.com/users/vitmalina/following{/other_user}","gists_url":"https://api.github.com/users/vitmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/vitmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitmalina/subscriptions","organizations_url":"https://api.github.com/users/vitmalina/orgs","repos_url":"https://api.github.com/users/vitmalina/repos","events_url":"https://api.github.com/users/vitmalina/events{/privacy}","received_events_url":"https://api.github.com/users/vitmalina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitmalina/w2ui","description":"JavaScript UI library for data-driven web applications","fork":false,"url":"https://api.github.com/repos/vitmalina/w2ui","forks_url":"https://api.github.com/repos/vitmalina/w2ui/forks","keys_url":"https://api.github.com/repos/vitmalina/w2ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitmalina/w2ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitmalina/w2ui/teams","hooks_url":"https://api.github.com/repos/vitmalina/w2ui/hooks","issue_events_url":"https://api.github.com/repos/vitmalina/w2ui/issues/events{/number}","events_url":"https://api.github.com/repos/vitmalina/w2ui/events","assignees_url":"https://api.github.com/repos/vitmalina/w2ui/assignees{/user}","branches_url":"https://api.github.com/repos/vitmalina/w2ui/branches{/branch}","tags_url":"https://api.github.com/repos/vitmalina/w2ui/tags","blobs_url":"https://api.github.com/repos/vitmalina/w2ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitmalina/w2ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitmalina/w2ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitmalina/w2ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitmalina/w2ui/statuses/{sha}","languages_url":"https://api.github.com/repos/vitmalina/w2ui/languages","stargazers_url":"https://api.github.com/repos/vitmalina/w2ui/stargazers","contributors_url":"https://api.github.com/repos/vitmalina/w2ui/contributors","subscribers_url":"https://api.github.com/repos/vitmalina/w2ui/subscribers","subscription_url":"https://api.github.com/repos/vitmalina/w2ui/subscription","commits_url":"https://api.github.com/repos/vitmalina/w2ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitmalina/w2ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitmalina/w2ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitmalina/w2ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitmalina/w2ui/contents/{+path}","compare_url":"https://api.github.com/repos/vitmalina/w2ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitmalina/w2ui/merges","archive_url":"https://api.github.com/repos/vitmalina/w2ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitmalina/w2ui/downloads","issues_url":"https://api.github.com/repos/vitmalina/w2ui/issues{/number}","pulls_url":"https://api.github.com/repos/vitmalina/w2ui/pulls{/number}","milestones_url":"https://api.github.com/repos/vitmalina/w2ui/milestones{/number}","notifications_url":"https://api.github.com/repos/vitmalina/w2ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitmalina/w2ui/labels{/name}","releases_url":"https://api.github.com/repos/vitmalina/w2ui/releases{/id}","created_at":"2011-04-12T14:26:20Z","updated_at":"2015-07-13T01:18:55Z","pushed_at":"2015-07-13T01:28:34Z","git_url":"git://github.com/vitmalina/w2ui.git","ssh_url":"git@github.com:vitmalina/w2ui.git","clone_url":"https://github.com/vitmalina/w2ui.git","svn_url":"https://github.com/vitmalina/w2ui","homepage":"http://w2ui.com","size":24056,"stargazers_count":967,"watchers_count":967,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":132,"forks":316,"open_issues":132,"watchers":967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/979"},"html":{"href":"https://github.com/vitmalina/w2ui/pull/979"},"issue":{"href":"https://api.github.com/repos/vitmalina/w2ui/issues/979"},"comments":{"href":"https://api.github.com/repos/vitmalina/w2ui/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitmalina/w2ui/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/vitmalina/w2ui/statuses/45a2eb6fddf862df6d68e7cb0e317705cee6cab7"}}}}