{"action":"created","issue":{"url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/5","labels_url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/5/comments","events_url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/5/events","html_url":"https://github.com/kamilkp/react-native-file-transfer/pull/5","id":74166854,"number":5,"title":"Add generic \"payload\" option, error first callbacks, change \"path\" key to \"file\"","user":{"login":"rt2zz","id":2302315,"avatar_url":"https://avatars.githubusercontent.com/u/2302315?v=3","gravatar_id":"","url":"https://api.github.com/users/rt2zz","html_url":"https://github.com/rt2zz","followers_url":"https://api.github.com/users/rt2zz/followers","following_url":"https://api.github.com/users/rt2zz/following{/other_user}","gists_url":"https://api.github.com/users/rt2zz/gists{/gist_id}","starred_url":"https://api.github.com/users/rt2zz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rt2zz/subscriptions","organizations_url":"https://api.github.com/users/rt2zz/orgs","repos_url":"https://api.github.com/users/rt2zz/repos","events_url":"https://api.github.com/users/rt2zz/events{/privacy}","received_events_url":"https://api.github.com/users/rt2zz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-07T23:50:47Z","updated_at":"2015-05-19T03:43:02Z","closed_at":"2015-05-19T00:06:55Z","pull_request":{"url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/pulls/5","html_url":"https://github.com/kamilkp/react-native-file-transfer/pull/5","diff_url":"https://github.com/kamilkp/react-native-file-transfer/pull/5.diff","patch_url":"https://github.com/kamilkp/react-native-file-transfer/pull/5.patch"},"body":"This adds a new \"payload\" key which is a UTF8 string that will be sent as the multipart upload.\r\n\r\nI also changed the parameter \"path\" to \"file\" since I believe that is less ambiguous, given the \"uploadUrl\" and \"payload\" parameters.\r\n\r\nLastly I added error first callbacks.\r\n\r\nI realize this is a bit much all in one PR, but nevertheless. Let me know if these changes are disagreeable aethetically or if they overly change the scope of the project."},"comment":{"url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/comments/103322109","html_url":"https://github.com/kamilkp/react-native-file-transfer/pull/5#issuecomment-103322109","issue_url":"https://api.github.com/repos/kamilkp/react-native-file-transfer/issues/5","id":103322109,"user":{"login":"rt2zz","id":2302315,"avatar_url":"https://avatars.githubusercontent.com/u/2302315?v=3","gravatar_id":"","url":"https://api.github.com/users/rt2zz","html_url":"https://github.com/rt2zz","followers_url":"https://api.github.com/users/rt2zz/followers","following_url":"https://api.github.com/users/rt2zz/following{/other_user}","gists_url":"https://api.github.com/users/rt2zz/gists{/gist_id}","starred_url":"https://api.github.com/users/rt2zz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rt2zz/subscriptions","organizations_url":"https://api.github.com/users/rt2zz/orgs","repos_url":"https://api.github.com/users/rt2zz/repos","events_url":"https://api.github.com/users/rt2zz/events{/privacy}","received_events_url":"https://api.github.com/users/rt2zz/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T03:43:02Z","updated_at":"2015-05-19T03:43:02Z","body":"@jtremback agreed, but it would need to be done correctly. There is a place in the ecosystem for being able to move fluidly between native/js contexts, but I think the use cases around it are still being explored. For example if we ever get fully functioning DOM react or canvas within webviews things might start to get really interesting."}}