{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/34951472","id":34951472,"diff_hunk":"@@ -2592,11 +2587,13 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {\n             break;\n \n           case '=':\n-            if (optional && !attrs[attrName]) {\n-              return;\n+            if (!hasOwnProperty.call(attrs, attrName)) {","path":"src/ng/compile.js","position":37,"original_position":37,"commit_id":"df73233d573ab8f70da9c1e8fd9067dc5b9b48a4","original_commit_id":"df73233d573ab8f70da9c1e8fd9067dc5b9b48a4","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"body":"@ThomasBurleson - see @caitp's reply to your question, that the code snippet that is mentioned in the previously linked comment is included in this PR. In other words you shouldn't need to make changes to Material for all your (non-disabled) tests to pass.\r\n\r\nI think the only thing we can do now is see if this PR works for the latest on Material's master branch and if so then merge this PR.","created_at":"2015-07-18T20:50:57Z","updated_at":"2015-07-18T20:50:57Z","html_url":"https://github.com/angular/angular.js/pull/12290#discussion_r34951472","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/12290","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/34951472"},"html":{"href":"https://github.com/angular/angular.js/pull/12290#discussion_r34951472"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12290"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/12290","id":39399588,"html_url":"https://github.com/angular/angular.js/pull/12290","diff_url":"https://github.com/angular/angular.js/pull/12290.diff","patch_url":"https://github.com/angular/angular.js/pull/12290.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/12290","number":12290,"state":"open","locked":false,"title":"fix($compile): ignore optional =-bound properties with empty value","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"body":"Previously, optional empty '='-bound expressions were ignored ---\nerroneously they stopped being ignored, and no tests were caused to fail\nfor this reason. This change restores the original ignoring behaviour while\nstill preventing other errors fixed by 8a1eb16\n\nCloses #12144\nCloses #12259","created_at":"2015-07-07T18:11:01Z","updated_at":"2015-07-18T20:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcf7804f7102e4f71420fab00582128b8113438","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/99","html_url":"https://github.com/angular/angular.js/milestones/1.4.4","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/99/labels","id":1208077,"number":99,"title":"1.4.4","description":"","creator":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":12,"state":"open","created_at":"2015-07-14T20:35:40Z","updated_at":"2015-07-17T18:33:22Z","due_on":"2015-07-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/12290/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/12290/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/12290/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/df73233d573ab8f70da9c1e8fd9067dc5b9b48a4","head":{"label":"caitp:issue-12259","ref":"issue-12259","sha":"df73233d573ab8f70da9c1e8fd9067dc5b9b48a4","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"repo":{"id":12836214,"name":"angular.js","full_name":"caitp/angular.js","owner":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caitp/angular.js","description":"","fork":true,"url":"https://api.github.com/repos/caitp/angular.js","forks_url":"https://api.github.com/repos/caitp/angular.js/forks","keys_url":"https://api.github.com/repos/caitp/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caitp/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caitp/angular.js/teams","hooks_url":"https://api.github.com/repos/caitp/angular.js/hooks","issue_events_url":"https://api.github.com/repos/caitp/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/caitp/angular.js/events","assignees_url":"https://api.github.com/repos/caitp/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/caitp/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/caitp/angular.js/tags","blobs_url":"https://api.github.com/repos/caitp/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caitp/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caitp/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/caitp/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caitp/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/caitp/angular.js/languages","stargazers_url":"https://api.github.com/repos/caitp/angular.js/stargazers","contributors_url":"https://api.github.com/repos/caitp/angular.js/contributors","subscribers_url":"https://api.github.com/repos/caitp/angular.js/subscribers","subscription_url":"https://api.github.com/repos/caitp/angular.js/subscription","commits_url":"https://api.github.com/repos/caitp/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/caitp/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/caitp/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/caitp/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/caitp/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/caitp/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caitp/angular.js/merges","archive_url":"https://api.github.com/repos/caitp/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caitp/angular.js/downloads","issues_url":"https://api.github.com/repos/caitp/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/caitp/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/caitp/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/caitp/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caitp/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/caitp/angular.js/releases{/id}","created_at":"2013-09-14T21:16:31Z","updated_at":"2014-11-18T21:28:55Z","pushed_at":"2015-07-07T18:13:42Z","git_url":"git://github.com/caitp/angular.js.git","ssh_url":"git@github.com:caitp/angular.js.git","clone_url":"https://github.com/caitp/angular.js.git","svn_url":"https://github.com/caitp/angular.js","homepage":"http://angularjs.org","size":70327,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"618356e481fcfeac74bfc9086332e25062fd8133","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2015-07-18T20:37:19Z","pushed_at":"2015-07-18T20:03:38Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":242334,"stargazers_count":40784,"watchers_count":40784,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17704,"mirror_url":null,"open_issues_count":1245,"forks":17704,"open_issues":1245,"watchers":40784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12290"},"html":{"href":"https://github.com/angular/angular.js/pull/12290"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/12290"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/12290/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12290/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/12290/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/df73233d573ab8f70da9c1e8fd9067dc5b9b48a4"}}}}