{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/35924797","id":35924797,"diff_hunk":"@@ -49,105 +50,149 @@ public function getConfigTreeBuilder()\n                 ->thenInvalid('Configure the content_listener.content_key or disable the content_listener when not using the CmfRoutingBundle DynamicRouter.')\n             ->end()\n             ->children()\n-                ->arrayNode('persistence')\n-                    ->addDefaultsIfNotSet()\n-                    ->children()\n-                        ->arrayNode('phpcr')\n-                            ->addDefaultsIfNotSet()\n-                            ->canBeEnabled()\n-                            ->children()\n-                                ->scalarNode('manager_name')->defaultNull()->end()\n-                            ->end()\n-                        ->end() // phpcr\n-                        ->arrayNode('orm')\n-                            ->addDefaultsIfNotSet()\n-                            ->canBeEnabled()\n-                            ->children()\n-                                ->scalarNode('manager_name')->defaultNull()->end()\n-                            ->end()\n-                        ->end() // orm\n-                    ->end()\n-                ->end() // persistence\n                 ->scalarNode('translation_domain')->defaultValue('messages')->end()\n                 ->scalarNode('title')->end()\n                 ->scalarNode('description')->end()\n                 ->scalarNode('original_route_pattern')->defaultValue(SeoPresentation::ORIGINAL_URL_CANONICAL)->end()\n-                ->arrayNode('sonata_admin_extension')\n-                    ->addDefaultsIfNotSet()\n-                    ->beforeNormalization()\n-                        ->ifTrue( function ($v) { return is_scalar($v); })\n-                        ->then(function ($v) {\n-                            return array('enabled' => $v);\n-                        })\n-                    ->end()\n-                    ->children()\n-                        ->enumNode('enabled')\n-                            ->values(array(true, false, 'auto'))\n-                            ->defaultValue('auto')\n+       ;\n+\n+        $this->loadPersistence($nodeBuilder);\n+        $this->loadSonataAdmin($nodeBuilder);\n+        $this->loadAlternateLocale($nodeBuilder);\n+        $this->loadErrorHandler($nodeBuilder);\n+        $this->loadSitemap($nodeBuilder);\n+        $this->loadContentListener($nodeBuilder);\n+\n+        return $treeBuilder;\n+    }\n+","path":"DependencyInjection/Configuration.php","position":67,"original_position":67,"commit_id":"ac160d333840a070003922c8a5bc8a9a8a47bacb","original_commit_id":"ac160d333840a070003922c8a5bc8a9a8a47bacb","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=3","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"Do we need docblock for the sub-methods?","created_at":"2015-07-30T21:44:49Z","updated_at":"2015-07-30T21:44:49Z","html_url":"https://github.com/symfony-cmf/SeoBundle/pull/246#discussion_r35924797","pull_request_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/35924797"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/246#discussion_r35924797"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246","id":41203241,"html_url":"https://github.com/symfony-cmf/SeoBundle/pull/246","diff_url":"https://github.com/symfony-cmf/SeoBundle/pull/246.diff","patch_url":"https://github.com/symfony-cmf/SeoBundle/pull/246.patch","issue_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/246","number":246,"state":"open","locked":false,"title":"split up configuration into methods","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"i want to improve on #245 but notice that the configuration being one huge spaghetti is starting to get into the way. this PR changes no functionality at all, just splits the configuration tree building into separate sections. can we do this? then i will rebase #245 and try to push validation into the configuration definition.","created_at":"2015-07-30T06:56:04Z","updated_at":"2015-07-30T21:44:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b59271859296c6d80975c01e14b8e40039a365e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/246/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/ac160d333840a070003922c8a5bc8a9a8a47bacb","head":{"label":"symfony-cmf:split-config","ref":"split-config","sha":"ac160d333840a070003922c8a5bc8a9a8a47bacb","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2015-05-09T12:05:01Z","pushed_at":"2015-07-30T06:57:29Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":3010,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":18,"forks":16,"open_issues":18,"watchers":14,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"61f36ef5a7c6f5b595811fe41bef0bbebad84284","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2015-05-09T12:05:01Z","pushed_at":"2015-07-30T06:57:29Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":3010,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":18,"forks":16,"open_issues":18,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/246"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/246"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/ac160d333840a070003922c8a5bc8a9a8a47bacb"}}}}