{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/1477","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/1477/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1477/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/1477/events","html_url":"https://github.com/weaveworks/weave/pull/1477","id":108849495,"number":1477,"title":"[WIP] rewrite /etc/hosts in containers","user":{"login":"inercia","id":1841612,"avatar_url":"https://avatars.githubusercontent.com/u/1841612?v=3","gravatar_id":"","url":"https://api.github.com/users/inercia","html_url":"https://github.com/inercia","followers_url":"https://api.github.com/users/inercia/followers","following_url":"https://api.github.com/users/inercia/following{/other_user}","gists_url":"https://api.github.com/users/inercia/gists{/gist_id}","starred_url":"https://api.github.com/users/inercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inercia/subscriptions","organizations_url":"https://api.github.com/users/inercia/orgs","repos_url":"https://api.github.com/users/inercia/repos","events_url":"https://api.github.com/users/inercia/events{/privacy}","received_events_url":"https://api.github.com/users/inercia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-29T11:22:44Z","updated_at":"2015-09-30T08:39:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/1477","html_url":"https://github.com/weaveworks/weave/pull/1477","diff_url":"https://github.com/weaveworks/weave/pull/1477.diff","patch_url":"https://github.com/weaveworks/weave/pull/1477.patch"},"body":"Fix #1374 by rewritting `/etc/hosts` in containers.\r\n\r\n* So far we have been rewritting `/etc/hosts` only when attaching from the proxy. However, we must also do it when invoking Weave with `weave run` or `weave attach`.\r\n* When rewritting hosts, we filter out any existing `X` hostname in `/etc/hosts` if `X.bridge` also exists.\r\n\r\nTODO:\r\n\r\n- [ ] add a `--no-hosts-rewite` option to `weave run`\r\n- [ ] add some integration tests\r\n\r\n_Note_: this branch is currently based on `experimental_docker`, so it must be rebased on `master` before merging...\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/144328537","html_url":"https://github.com/weaveworks/weave/pull/1477#issuecomment-144328537","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/1477","id":144328537,"user":{"login":"inercia","id":1841612,"avatar_url":"https://avatars.githubusercontent.com/u/1841612?v=3","gravatar_id":"","url":"https://api.github.com/users/inercia","html_url":"https://github.com/inercia","followers_url":"https://api.github.com/users/inercia/followers","following_url":"https://api.github.com/users/inercia/following{/other_user}","gists_url":"https://api.github.com/users/inercia/gists{/gist_id}","starred_url":"https://api.github.com/users/inercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inercia/subscriptions","organizations_url":"https://api.github.com/users/inercia/orgs","repos_url":"https://api.github.com/users/inercia/repos","events_url":"https://api.github.com/users/inercia/events{/privacy}","received_events_url":"https://api.github.com/users/inercia/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T08:39:24Z","updated_at":"2015-09-30T08:39:24Z","body":"@rade Should we modify `/etc/hosts` when the user launches the container with `weave run --without-dns`? The `--without-dns` sounds to me like _\"please do not put any of your DNS tricks\"_"}}