{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/6875","labels_url":"https://api.github.com/repos/servo/servo/issues/6875/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/6875/comments","events_url":"https://api.github.com/repos/servo/servo/issues/6875/events","html_url":"https://github.com/servo/servo/pull/6875","id":98445677,"number":6875,"title":"Implement viewport stuffs for window #1718","user":{"login":"farodin91","id":1159212,"avatar_url":"https://avatars.githubusercontent.com/u/1159212?v=3","gravatar_id":"","url":"https://api.github.com/users/farodin91","html_url":"https://github.com/farodin91","followers_url":"https://api.github.com/users/farodin91/followers","following_url":"https://api.github.com/users/farodin91/following{/other_user}","gists_url":"https://api.github.com/users/farodin91/gists{/gist_id}","starred_url":"https://api.github.com/users/farodin91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farodin91/subscriptions","organizations_url":"https://api.github.com/users/farodin91/orgs","repos_url":"https://api.github.com/users/farodin91/repos","events_url":"https://api.github.com/users/farodin91/events{/privacy}","received_events_url":"https://api.github.com/users/farodin91/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2015-07-31T18:25:58Z","updated_at":"2015-08-09T13:52:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6875","html_url":"https://github.com/servo/servo/pull/6875","diff_url":"https://github.com/servo/servo/pull/6875.diff","patch_url":"https://github.com/servo/servo/pull/6875.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6875)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/129189137","html_url":"https://github.com/servo/servo/pull/6875#issuecomment-129189137","issue_url":"https://api.github.com/repos/servo/servo/issues/6875","id":129189137,"user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"created_at":"2015-08-09T13:52:20Z","updated_at":"2015-08-09T13:52:20Z","body":"-S-awaiting-review +S-needs-code-changes \n\n---\n\nReviewed 3 of 3 files at r12.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[components/msg/compositor_msg.rs, line 143 \\[r12\\]](https://reviewable.io:443/reviews/servo/servo/6875#-JwHiph3uThViV2ratui)** ([raw file](https://github.com/servo/servo/blob/9a803396f92cfb2de6853f976fcf27bcbb427281/components/msg/compositor_msg.rs#L143)):</sup>\nLet's call this `_smooth`\n\n---\n\n<sup>**[components/script/dom/window.rs, line 904 \\[r12\\]](https://reviewable.io:443/reviews/servo/servo/6875#-JwHi0pzEUc1xy5q20TO)** ([raw file](https://github.com/servo/servo/blob/9a803396f92cfb2de6853f976fcf27bcbb427281/components/script/dom/window.rs#L904)):</sup>\nThis should take an `Option<&Element>` argument too.\n\n---\n\n<sup>**[components/script/dom/window.rs, line 908 \\[r12\\]](https://reviewable.io:443/reviews/servo/servo/6875#-JwHiHPwKjwJMqxWA6v7)** ([raw file](https://github.com/servo/servo/blob/9a803396f92cfb2de6853f976fcf27bcbb427281/components/script/dom/window.rs#L908)):</sup>\nThis should check be true if there's an element, and have a TODO for computing the scroll-behaviour CSS value like the spec says.\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/6875)\n<!-- Sent from Reviewable.io -->\n"}}