{"action":"created","comment":{"url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/comments/30585128","id":30585128,"diff_hunk":"@@ -49,7 +49,12 @@ TEST(RonexEthercatDrivers, constructor )\n \n   EtherCAT_FMMU_Config fmmu(0);\n   EtherCAT_PD_Config pdcfg(0);\n-  EtherCAT_SlaveHandler sh(0, 0, 0, serial,EC_FixedStationAddress( (uint16_t) 0 ), &fmmu, &pdcfg, 0);\n+  EtherCAT_MbxConfig mbxcfg;\n+  EtherCAT_DataLinkLayer dll;\n+  EC_Logic logic;\n+  EtherCAT_PD_Buffer pdbuf(&logic, &dll);\n+\n+  EtherCAT_SlaveHandler sh(0, 0, 0, serial,EC_FixedStationAddress( (uint16_t) 0 ), &fmmu, &pdcfg, &mbxcfg, &dll, &logic, &pdbuf);","path":"sr_ronex_drivers/test/test_ethercat_drivers.cpp","position":30,"original_position":30,"commit_id":"2b019483bbb4fd12b01242536d40249805540bc4","original_commit_id":"2b019483bbb4fd12b01242536d40249805540bc4","user":{"login":"ugocupcic","id":557182,"avatar_url":"https://avatars.githubusercontent.com/u/557182?v=3","gravatar_id":"","url":"https://api.github.com/users/ugocupcic","html_url":"https://github.com/ugocupcic","followers_url":"https://api.github.com/users/ugocupcic/followers","following_url":"https://api.github.com/users/ugocupcic/following{/other_user}","gists_url":"https://api.github.com/users/ugocupcic/gists{/gist_id}","starred_url":"https://api.github.com/users/ugocupcic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ugocupcic/subscriptions","organizations_url":"https://api.github.com/users/ugocupcic/orgs","repos_url":"https://api.github.com/users/ugocupcic/repos","events_url":"https://api.github.com/users/ugocupcic/events{/privacy}","received_events_url":"https://api.github.com/users/ugocupcic/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2015-05-19T10:04:21Z","updated_at":"2015-05-19T10:04:21Z","html_url":"https://github.com/shadow-robot/sr-ronex/pull/178#discussion_r30585128","pull_request_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/comments/30585128"},"html":{"href":"https://github.com/shadow-robot/sr-ronex/pull/178#discussion_r30585128"},"pull_request":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178","id":35664590,"html_url":"https://github.com/shadow-robot/sr-ronex/pull/178","diff_url":"https://github.com/shadow-robot/sr-ronex/pull/178.diff","patch_url":"https://github.com/shadow-robot/sr-ronex/pull/178.patch","issue_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/178","number":178,"state":"closed","locked":false,"title":"Adding test and test coverage","user":{"login":"ugocupcic","id":557182,"avatar_url":"https://avatars.githubusercontent.com/u/557182?v=3","gravatar_id":"","url":"https://api.github.com/users/ugocupcic","html_url":"https://github.com/ugocupcic","followers_url":"https://api.github.com/users/ugocupcic/followers","following_url":"https://api.github.com/users/ugocupcic/following{/other_user}","gists_url":"https://api.github.com/users/ugocupcic/gists{/gist_id}","starred_url":"https://api.github.com/users/ugocupcic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ugocupcic/subscriptions","organizations_url":"https://api.github.com/users/ugocupcic/orgs","repos_url":"https://api.github.com/users/ugocupcic/repos","events_url":"https://api.github.com/users/ugocupcic/events{/privacy}","received_events_url":"https://api.github.com/users/ugocupcic/received_events","type":"User","site_admin":false},"body":"![image](https://cloud.githubusercontent.com/assets/557182/7688268/925b35dc-fda3-11e4-95bf-f0fa3b97f0d1.png)\r\n\r\nA much better overview of the code coverage is visible here: https://codecov.io/github/shadow-robot/sr-ronex?branch=F_test_coverage\r\n\r\nYou can also install a browser plugin to display the code coverage directly in github.\r\n\r\nThe current code coverage isn't good [![codecov.io](http://codecov.io/github/shadow-robot/sr-ronex/coverage.svg?branch=F_test_coverage)](http://codecov.io/github/shadow-robot/sr-ronex?branch=F_test_coverage) but we have lots of disabled tests since they use hardware.","created_at":"2015-05-18T19:18:43Z","updated_at":"2015-05-19T10:04:21Z","closed_at":"2015-05-19T10:04:10Z","merged_at":"2015-05-19T10:04:10Z","merge_commit_sha":"31d6bbc5b2c44eafe50116ab4ffa2a1e8d70511e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178/commits","review_comments_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178/comments","review_comment_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/178/comments","statuses_url":"https://api.github.com/repos/shadow-robot/sr-ronex/statuses/2b019483bbb4fd12b01242536d40249805540bc4","head":{"label":"shadow-robot:F_test_coverage","ref":"F_test_coverage","sha":"2b019483bbb4fd12b01242536d40249805540bc4","user":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"repo":{"id":10903034,"name":"sr-ronex","full_name":"shadow-robot/sr-ronex","owner":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shadow-robot/sr-ronex","description":"Contains ROS packages for RoNeX (Robot Nervous System) ","fork":false,"url":"https://api.github.com/repos/shadow-robot/sr-ronex","forks_url":"https://api.github.com/repos/shadow-robot/sr-ronex/forks","keys_url":"https://api.github.com/repos/shadow-robot/sr-ronex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shadow-robot/sr-ronex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shadow-robot/sr-ronex/teams","hooks_url":"https://api.github.com/repos/shadow-robot/sr-ronex/hooks","issue_events_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/events{/number}","events_url":"https://api.github.com/repos/shadow-robot/sr-ronex/events","assignees_url":"https://api.github.com/repos/shadow-robot/sr-ronex/assignees{/user}","branches_url":"https://api.github.com/repos/shadow-robot/sr-ronex/branches{/branch}","tags_url":"https://api.github.com/repos/shadow-robot/sr-ronex/tags","blobs_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/refs{/sha}","trees_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shadow-robot/sr-ronex/statuses/{sha}","languages_url":"https://api.github.com/repos/shadow-robot/sr-ronex/languages","stargazers_url":"https://api.github.com/repos/shadow-robot/sr-ronex/stargazers","contributors_url":"https://api.github.com/repos/shadow-robot/sr-ronex/contributors","subscribers_url":"https://api.github.com/repos/shadow-robot/sr-ronex/subscribers","subscription_url":"https://api.github.com/repos/shadow-robot/sr-ronex/subscription","commits_url":"https://api.github.com/repos/shadow-robot/sr-ronex/commits{/sha}","git_commits_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/commits{/sha}","comments_url":"https://api.github.com/repos/shadow-robot/sr-ronex/comments{/number}","issue_comment_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/comments{/number}","contents_url":"https://api.github.com/repos/shadow-robot/sr-ronex/contents/{+path}","compare_url":"https://api.github.com/repos/shadow-robot/sr-ronex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shadow-robot/sr-ronex/merges","archive_url":"https://api.github.com/repos/shadow-robot/sr-ronex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shadow-robot/sr-ronex/downloads","issues_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues{/number}","pulls_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls{/number}","milestones_url":"https://api.github.com/repos/shadow-robot/sr-ronex/milestones{/number}","notifications_url":"https://api.github.com/repos/shadow-robot/sr-ronex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shadow-robot/sr-ronex/labels{/name}","releases_url":"https://api.github.com/repos/shadow-robot/sr-ronex/releases{/id}","created_at":"2013-06-24T08:39:53Z","updated_at":"2015-04-07T16:11:37Z","pushed_at":"2015-05-19T10:04:11Z","git_url":"git://github.com/shadow-robot/sr-ronex.git","ssh_url":"git@github.com:shadow-robot/sr-ronex.git","clone_url":"https://github.com/shadow-robot/sr-ronex.git","svn_url":"https://github.com/shadow-robot/sr-ronex","homepage":"http://www.shadowrobot.com/products/ronex/","size":4330,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":2,"default_branch":"indigo-devel"}},"base":{"label":"shadow-robot:indigo-devel","ref":"indigo-devel","sha":"6b9bd4b337f9478ad7857c1b312699b21a387840","user":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"repo":{"id":10903034,"name":"sr-ronex","full_name":"shadow-robot/sr-ronex","owner":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shadow-robot/sr-ronex","description":"Contains ROS packages for RoNeX (Robot Nervous System) ","fork":false,"url":"https://api.github.com/repos/shadow-robot/sr-ronex","forks_url":"https://api.github.com/repos/shadow-robot/sr-ronex/forks","keys_url":"https://api.github.com/repos/shadow-robot/sr-ronex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shadow-robot/sr-ronex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shadow-robot/sr-ronex/teams","hooks_url":"https://api.github.com/repos/shadow-robot/sr-ronex/hooks","issue_events_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/events{/number}","events_url":"https://api.github.com/repos/shadow-robot/sr-ronex/events","assignees_url":"https://api.github.com/repos/shadow-robot/sr-ronex/assignees{/user}","branches_url":"https://api.github.com/repos/shadow-robot/sr-ronex/branches{/branch}","tags_url":"https://api.github.com/repos/shadow-robot/sr-ronex/tags","blobs_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/refs{/sha}","trees_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shadow-robot/sr-ronex/statuses/{sha}","languages_url":"https://api.github.com/repos/shadow-robot/sr-ronex/languages","stargazers_url":"https://api.github.com/repos/shadow-robot/sr-ronex/stargazers","contributors_url":"https://api.github.com/repos/shadow-robot/sr-ronex/contributors","subscribers_url":"https://api.github.com/repos/shadow-robot/sr-ronex/subscribers","subscription_url":"https://api.github.com/repos/shadow-robot/sr-ronex/subscription","commits_url":"https://api.github.com/repos/shadow-robot/sr-ronex/commits{/sha}","git_commits_url":"https://api.github.com/repos/shadow-robot/sr-ronex/git/commits{/sha}","comments_url":"https://api.github.com/repos/shadow-robot/sr-ronex/comments{/number}","issue_comment_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/comments{/number}","contents_url":"https://api.github.com/repos/shadow-robot/sr-ronex/contents/{+path}","compare_url":"https://api.github.com/repos/shadow-robot/sr-ronex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shadow-robot/sr-ronex/merges","archive_url":"https://api.github.com/repos/shadow-robot/sr-ronex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shadow-robot/sr-ronex/downloads","issues_url":"https://api.github.com/repos/shadow-robot/sr-ronex/issues{/number}","pulls_url":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls{/number}","milestones_url":"https://api.github.com/repos/shadow-robot/sr-ronex/milestones{/number}","notifications_url":"https://api.github.com/repos/shadow-robot/sr-ronex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shadow-robot/sr-ronex/labels{/name}","releases_url":"https://api.github.com/repos/shadow-robot/sr-ronex/releases{/id}","created_at":"2013-06-24T08:39:53Z","updated_at":"2015-04-07T16:11:37Z","pushed_at":"2015-05-19T10:04:11Z","git_url":"git://github.com/shadow-robot/sr-ronex.git","ssh_url":"git@github.com:shadow-robot/sr-ronex.git","clone_url":"https://github.com/shadow-robot/sr-ronex.git","svn_url":"https://github.com/shadow-robot/sr-ronex","homepage":"http://www.shadowrobot.com/products/ronex/","size":4330,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":2,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178"},"html":{"href":"https://github.com/shadow-robot/sr-ronex/pull/178"},"issue":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/178"},"comments":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/shadow-robot/sr-ronex/statuses/2b019483bbb4fd12b01242536d40249805540bc4"}}}}