{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/comments/32966004","id":32966004,"diff_hunk":"@@ -25,7 +25,7 @@\n #  `MAX_MESSAGE_SIZE_IN_BYTES`.\n #\n class LogStash::Outputs::Sns < LogStash::Outputs::Base\n-  include LogStash::PluginMixins::AwsConfig\n+  include LogStash::PluginMixins::AwsConfig::V2\n \n   MAX_SUBJECT_SIZE_IN_CHARACTERS  = 100\n   MAX_MESSAGE_SIZE_IN_BYTES       = 32768","path":"lib/logstash/outputs/sns.rb","position":8,"original_position":8,"commit_id":"1340899df2b77872f7a1dcbf26a2dc5279840fc2","original_commit_id":"1340899df2b77872f7a1dcbf26a2dc5279840fc2","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"Good point! Should we actually just get rid of the format option since now `@codec` works?","created_at":"2015-06-22T18:20:52Z","updated_at":"2015-06-22T18:20:52Z","html_url":"https://github.com/logstash-plugins/logstash-output-sns/pull/6#discussion_r32966004","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/comments/32966004"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-sns/pull/6#discussion_r32966004"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6","id":38060565,"html_url":"https://github.com/logstash-plugins/logstash-output-sns/pull/6","diff_url":"https://github.com/logstash-plugins/logstash-output-sns/pull/6.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-sns/pull/6.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/6","number":6,"state":"open","locked":false,"title":"Use codecs","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"WIP. I still need to add tests here. Fixes #3 . It's now in a structure that is amenable to testing however.","created_at":"2015-06-18T22:34:34Z","updated_at":"2015-06-22T18:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcdb035cb297e158ec28e3cb910a28274cf882f0","assignee":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/6/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/statuses/1340899df2b77872f7a1dcbf26a2dc5279840fc2","head":{"label":"andrewvc:use-codecs","ref":"use-codecs","sha":"1340899df2b77872f7a1dcbf26a2dc5279840fc2","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37608024,"name":"logstash-output-sns","full_name":"andrewvc/logstash-output-sns","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash-output-sns","description":null,"fork":true,"url":"https://api.github.com/repos/andrewvc/logstash-output-sns","forks_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash-output-sns/releases{/id}","created_at":"2015-06-17T16:49:35Z","updated_at":"2015-06-17T16:49:35Z","pushed_at":"2015-06-19T17:18:32Z","git_url":"git://github.com/andrewvc/logstash-output-sns.git","ssh_url":"git@github.com:andrewvc/logstash-output-sns.git","clone_url":"https://github.com/andrewvc/logstash-output-sns.git","svn_url":"https://github.com/andrewvc/logstash-output-sns","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"0d2dd4764ef0255479cb98e0ef34102f8258598f","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25471134,"name":"logstash-output-sns","full_name":"logstash-plugins/logstash-output-sns","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-output-sns","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/releases{/id}","created_at":"2014-10-20T14:49:42Z","updated_at":"2015-04-20T14:01:08Z","pushed_at":"2015-06-19T17:37:56Z","git_url":"git://github.com/logstash-plugins/logstash-output-sns.git","ssh_url":"git@github.com:logstash-plugins/logstash-output-sns.git","clone_url":"https://github.com/logstash-plugins/logstash-output-sns.git","svn_url":"https://github.com/logstash-plugins/logstash-output-sns","homepage":null,"size":243,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-sns/pull/6"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/6"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-sns/statuses/1340899df2b77872f7a1dcbf26a2dc5279840fc2"}}}}