{"action":"closed","number":6187,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6187","id":36225746,"html_url":"https://github.com/servo/servo/pull/6187","diff_url":"https://github.com/servo/servo/pull/6187.diff","patch_url":"https://github.com/servo/servo/pull/6187.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/6187","number":6187,"state":"closed","locked":false,"title":"Avoid extra O(n) scan in `validate_and_extract`","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Also `debug_assert!`s that `splitn` was called with the\r\ncorrect `count` argument.\r\n\r\nAdaptation of #5778.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6187)\n<!-- Reviewable:end -->\n","created_at":"2015-05-26T17:26:59Z","updated_at":"2015-05-26T22:09:52Z","closed_at":"2015-05-26T22:09:52Z","merged_at":"2015-05-26T22:09:52Z","merge_commit_sha":"901ae4a75955691c168a317dab8595575584a677","assignee":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/6187/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/6187/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/6187/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/a3d463093ec6ff445d9e1d3352696754431ae68b","head":{"label":"tamird:cleanup-validate-and-extract","ref":"cleanup-validate-and-extract","sha":"a3d463093ec6ff445d9e1d3352696754431ae68b","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":36138954,"name":"servo","full_name":"tamird/servo","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/tamird/servo","forks_url":"https://api.github.com/repos/tamird/servo/forks","keys_url":"https://api.github.com/repos/tamird/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/servo/teams","hooks_url":"https://api.github.com/repos/tamird/servo/hooks","issue_events_url":"https://api.github.com/repos/tamird/servo/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/servo/events","assignees_url":"https://api.github.com/repos/tamird/servo/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/servo/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/servo/tags","blobs_url":"https://api.github.com/repos/tamird/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/servo/languages","stargazers_url":"https://api.github.com/repos/tamird/servo/stargazers","contributors_url":"https://api.github.com/repos/tamird/servo/contributors","subscribers_url":"https://api.github.com/repos/tamird/servo/subscribers","subscription_url":"https://api.github.com/repos/tamird/servo/subscription","commits_url":"https://api.github.com/repos/tamird/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/servo/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/servo/merges","archive_url":"https://api.github.com/repos/tamird/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/servo/downloads","issues_url":"https://api.github.com/repos/tamird/servo/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/servo/labels{/name}","releases_url":"https://api.github.com/repos/tamird/servo/releases{/id}","created_at":"2015-05-23T19:27:56Z","updated_at":"2015-05-23T19:30:51Z","pushed_at":"2015-05-26T17:26:41Z","git_url":"git://github.com/tamird/servo.git","ssh_url":"git@github.com:tamird/servo.git","clone_url":"https://github.com/tamird/servo.git","svn_url":"https://github.com/tamird/servo","homepage":"","size":103059,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"8759d42559bc5c10f8d90903f33f75bddf44d9fe","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-05-26T22:02:00Z","pushed_at":"2015-05-26T22:09:47Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":1895692,"stargazers_count":4141,"watchers_count":4141,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":890,"forks":647,"open_issues":890,"watchers":4141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/6187"},"html":{"href":"https://github.com/servo/servo/pull/6187"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/6187"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/6187/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/6187/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/6187/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/a3d463093ec6ff445d9e1d3352696754431ae68b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":21,"deletions":11,"changed_files":1}}