{"action":"opened","number":2685,"pull_request":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685","id":31090371,"html_url":"https://github.com/tomchristie/django-rest-framework/pull/2685","diff_url":"https://github.com/tomchristie/django-rest-framework/pull/2685.diff","patch_url":"https://github.com/tomchristie/django-rest-framework/pull/2685.patch","issue_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2685","number":2685,"state":"open","locked":false,"title":"Fix lookup_url_kwarg handling in viewsets (Fixes #2591).","user":{"login":"rbarrois","id":694541,"avatar_url":"https://avatars.githubusercontent.com/u/694541?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarrois","html_url":"https://github.com/rbarrois","followers_url":"https://api.github.com/users/rbarrois/followers","following_url":"https://api.github.com/users/rbarrois/following{/other_user}","gists_url":"https://api.github.com/users/rbarrois/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarrois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarrois/subscriptions","organizations_url":"https://api.github.com/users/rbarrois/orgs","repos_url":"https://api.github.com/users/rbarrois/repos","events_url":"https://api.github.com/users/rbarrois/events{/privacy}","received_events_url":"https://api.github.com/users/rbarrois/received_events","type":"User","site_admin":false},"body":"The ``lookup_url_kwarg`` is intended to set the name of a field in the\r\nURL regexps when using custom ``lookup_field``, but the routers ignore\r\nit altogether.\r\n\r\nWhen a ViewSet is defined with:\r\n```python\r\nclass ProfileViewSet(ViewSet):\r\n    lookup_field = 'user__username'\r\n    lookup_url_kwarg = 'username'\r\n```\r\n\r\nThen we should get an URL along the lines of ``/profiles/(?P<username>[^./]+)/``.\r\nHowever, we get ``/profiles/(?P<user__username>[^./]+)/``...\r\n\r\nThis PR fixes the bug (reported as #2591), along with an inelegant test.","created_at":"2015-03-13T00:13:14Z","updated_at":"2015-03-13T00:13:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685/commits","review_comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685/comments","review_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2685/comments","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/8d0dbc8092a754e1f0f7d80d93506072556f35a2","head":{"label":"rbarrois:rbarrois/fix_lookup_url_kwarg","ref":"rbarrois/fix_lookup_url_kwarg","sha":"8d0dbc8092a754e1f0f7d80d93506072556f35a2","user":{"login":"rbarrois","id":694541,"avatar_url":"https://avatars.githubusercontent.com/u/694541?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarrois","html_url":"https://github.com/rbarrois","followers_url":"https://api.github.com/users/rbarrois/followers","following_url":"https://api.github.com/users/rbarrois/following{/other_user}","gists_url":"https://api.github.com/users/rbarrois/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarrois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarrois/subscriptions","organizations_url":"https://api.github.com/users/rbarrois/orgs","repos_url":"https://api.github.com/users/rbarrois/repos","events_url":"https://api.github.com/users/rbarrois/events{/privacy}","received_events_url":"https://api.github.com/users/rbarrois/received_events","type":"User","site_admin":false},"repo":{"id":32110482,"name":"django-rest-framework","full_name":"rbarrois/django-rest-framework","owner":{"login":"rbarrois","id":694541,"avatar_url":"https://avatars.githubusercontent.com/u/694541?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarrois","html_url":"https://github.com/rbarrois","followers_url":"https://api.github.com/users/rbarrois/followers","following_url":"https://api.github.com/users/rbarrois/following{/other_user}","gists_url":"https://api.github.com/users/rbarrois/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarrois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarrois/subscriptions","organizations_url":"https://api.github.com/users/rbarrois/orgs","repos_url":"https://api.github.com/users/rbarrois/repos","events_url":"https://api.github.com/users/rbarrois/events{/privacy}","received_events_url":"https://api.github.com/users/rbarrois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbarrois/django-rest-framework","description":"Web APIs for Django.","fork":true,"url":"https://api.github.com/repos/rbarrois/django-rest-framework","forks_url":"https://api.github.com/repos/rbarrois/django-rest-framework/forks","keys_url":"https://api.github.com/repos/rbarrois/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbarrois/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbarrois/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/rbarrois/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/rbarrois/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rbarrois/django-rest-framework/events","assignees_url":"https://api.github.com/repos/rbarrois/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rbarrois/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rbarrois/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/rbarrois/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbarrois/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbarrois/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbarrois/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbarrois/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rbarrois/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/rbarrois/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/rbarrois/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/rbarrois/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/rbarrois/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/rbarrois/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbarrois/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbarrois/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbarrois/django-rest-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbarrois/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rbarrois/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbarrois/django-rest-framework/merges","archive_url":"https://api.github.com/repos/rbarrois/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbarrois/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/rbarrois/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rbarrois/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rbarrois/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rbarrois/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbarrois/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/rbarrois/django-rest-framework/releases{/id}","created_at":"2015-03-13T00:08:28Z","updated_at":"2015-03-13T00:08:30Z","pushed_at":"2015-03-13T00:09:09Z","git_url":"git://github.com/rbarrois/django-rest-framework.git","ssh_url":"git@github.com:rbarrois/django-rest-framework.git","clone_url":"https://github.com/rbarrois/django-rest-framework.git","svn_url":"https://github.com/rbarrois/django-rest-framework","homepage":"www.django-rest-framework.org","size":31836,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomchristie:master","ref":"master","sha":"a02098b855aad0847cddacc4bed2d280017b46c5","user":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"repo":{"id":1431547,"name":"django-rest-framework","full_name":"tomchristie/django-rest-framework","owner":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomchristie/django-rest-framework","description":"Web APIs for Django.","fork":false,"url":"https://api.github.com/repos/tomchristie/django-rest-framework","forks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/forks","keys_url":"https://api.github.com/repos/tomchristie/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomchristie/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomchristie/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/events","assignees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/tomchristie/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tomchristie/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/tomchristie/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomchristie/django-rest-framework/merges","archive_url":"https://api.github.com/repos/tomchristie/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomchristie/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tomchristie/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tomchristie/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomchristie/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/tomchristie/django-rest-framework/releases{/id}","created_at":"2011-03-02T17:13:56Z","updated_at":"2015-03-13T00:02:07Z","pushed_at":"2015-03-12T23:16:20Z","git_url":"git://github.com/tomchristie/django-rest-framework.git","ssh_url":"git@github.com:tomchristie/django-rest-framework.git","clone_url":"https://github.com/tomchristie/django-rest-framework.git","svn_url":"https://github.com/tomchristie/django-rest-framework","homepage":"www.django-rest-framework.org","size":31836,"stargazers_count":3718,"watchers_count":3718,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1134,"mirror_url":null,"open_issues_count":92,"forks":1134,"open_issues":92,"watchers":3718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685"},"html":{"href":"https://github.com/tomchristie/django-rest-framework/pull/2685"},"issue":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2685"},"comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2685/comments"},"review_comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685/comments"},"review_comment":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2685/commits"},"statuses":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/8d0dbc8092a754e1f0f7d80d93506072556f35a2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":2,"changed_files":2}}