{"action":"created","issue":{"url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1226","labels_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1226/labels{/name}","comments_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1226/comments","events_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1226/events","html_url":"https://github.com/plone/Products.CMFPlone/issues/1226","id":115213887,"number":1226,"title":"Cleanup and rework: contenttype-icons and showing thumbnails for images/leadimages in listings ...","user":{"login":"fgrcon","id":1640384,"avatar_url":"https://avatars.githubusercontent.com/u/1640384?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrcon","html_url":"https://github.com/fgrcon","followers_url":"https://api.github.com/users/fgrcon/followers","following_url":"https://api.github.com/users/fgrcon/following{/other_user}","gists_url":"https://api.github.com/users/fgrcon/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrcon/subscriptions","organizations_url":"https://api.github.com/users/fgrcon/orgs","repos_url":"https://api.github.com/users/fgrcon/repos","events_url":"https://api.github.com/users/fgrcon/events{/privacy}","received_events_url":"https://api.github.com/users/fgrcon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"fgrcon","id":1640384,"avatar_url":"https://avatars.githubusercontent.com/u/1640384?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrcon","html_url":"https://github.com/fgrcon","followers_url":"https://api.github.com/users/fgrcon/followers","following_url":"https://api.github.com/users/fgrcon/following{/other_user}","gists_url":"https://api.github.com/users/fgrcon/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrcon/subscriptions","organizations_url":"https://api.github.com/users/fgrcon/orgs","repos_url":"https://api.github.com/users/fgrcon/repos","events_url":"https://api.github.com/users/fgrcon/events{/privacy}","received_events_url":"https://api.github.com/users/fgrcon/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-11-05T05:48:45Z","updated_at":"2015-11-05T16:54:57Z","closed_at":null,"body":"Replaces https://github.com/plone/Products.CMFPlone/issues/1151, https://github.com/plone/Products.CMFPlone/issues/1074  and adresses  https://github.com/plone/Products.CMFPlone/issues/1185 and may be some more.\r\n**Detailed documentation: https://github.com/fgrcon/Products.CMFPlone/blob/master/docs/icons_in_plone5.rst**\r\n\r\ncreated testing branch: https://github.com/plone/buildout.coredev/tree/fgrcon-test%231226\r\n\r\nI will reopen pull requests when finished (almost done) and tested (as far as I can).\r\n**PRs are interdependend**\r\n\r\n@jensens:\r\nyou suggested:\r\nnterdependent pull request are not directly possible by now, this was discussed here plone/jenkins.plone.org#126 . But you can make a branch and PR (which is only for testing, not for merge) in buildout.coredev with adjusted sources.cfg - this can then be tested with the PR>mechanism. Its a workaround , but well...\r\n\r\n**I created a branch in coredev (see above) but how to start Jenkins with that? I  created  https://github.com/plone/buildout.coredev/pull/140 -> http://jenkins.plone.org/job/pull-request-5.0/529/ which obviously did not fetch sources from fgrcon....**"},"comment":{"url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/comments/154120971","html_url":"https://github.com/plone/Products.CMFPlone/issues/1226#issuecomment-154120971","issue_url":"https://api.github.com/repos/plone/Products.CMFPlone/issues/1226","id":154120971,"user":{"login":"hvelarde","id":341393,"avatar_url":"https://avatars.githubusercontent.com/u/341393?v=3","gravatar_id":"","url":"https://api.github.com/users/hvelarde","html_url":"https://github.com/hvelarde","followers_url":"https://api.github.com/users/hvelarde/followers","following_url":"https://api.github.com/users/hvelarde/following{/other_user}","gists_url":"https://api.github.com/users/hvelarde/gists{/gist_id}","starred_url":"https://api.github.com/users/hvelarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvelarde/subscriptions","organizations_url":"https://api.github.com/users/hvelarde/orgs","repos_url":"https://api.github.com/users/hvelarde/repos","events_url":"https://api.github.com/users/hvelarde/events{/privacy}","received_events_url":"https://api.github.com/users/hvelarde/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T16:54:57Z","updated_at":"2015-11-05T16:54:57Z","body":"@fgrcon IMO, is a bad idea to include different issues on the scope of one PR; this could lead easily to errors and could delay the merging of it."}}