{"action":"created","issue":{"url":"https://api.github.com/repos/gaearon/redux/issues/219","labels_url":"https://api.github.com/repos/gaearon/redux/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/gaearon/redux/issues/219/comments","events_url":"https://api.github.com/repos/gaearon/redux/issues/219/events","html_url":"https://github.com/gaearon/redux/issues/219","id":93170228,"number":219,"title":"Possibly leaking DOM node references","user":{"login":"kevinrobinson","id":1056957,"avatar_url":"https://avatars.githubusercontent.com/u/1056957?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-06T02:10:17Z","updated_at":"2015-07-06T02:18:44Z","closed_at":null,"body":"I ran into this doing some profiling as part of https://github.com/kevinrobinson/redux/pull/1.  It looks like there's a DOM leak somewhere.\r\n\r\nYou can see the test case I'm using here on the counters app:\r\n\r\n<img width=\"1242\" alt=\"screen shot 2015-07-05 at 10 00 23 pm\" src=\"https://cloud.githubusercontent.com/assets/1056957/8514611/46c8eb94-2361-11e5-9830-e80d1dfebe05.png\">\r\n\r\nThis might not matter much in real applications, and I'm not quite sure how to investigate further.  I tried seeing if I could find more in the profiling tools but didn't get anywhere yet.  I also read through the code to see if anything stuck out but couldn't see anything there either.\r\n\r\nMaybe someone else knows more about profiling this, or can track it down?"},"comment":{"url":"https://api.github.com/repos/gaearon/redux/issues/comments/118692859","html_url":"https://github.com/gaearon/redux/issues/219#issuecomment-118692859","issue_url":"https://api.github.com/repos/gaearon/redux/issues/219","id":118692859,"user":{"login":"kevinrobinson","id":1056957,"avatar_url":"https://avatars.githubusercontent.com/u/1056957?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T02:18:44Z","updated_at":"2015-07-06T02:18:44Z","body":"@acdlite Yeah I'm stumped at the moment too.  One thought was that perhaps the GC cycle is just longer for DOM nodes and it hadn't kicked in yet?  That's just a straight guess though."}}