{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3381","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3381/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3381/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3381/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3381","id":55275211,"number":3381,"title":"Fix ice.config modification when using bin/omero admin ports --prefix","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-23T12:13:19Z","updated_at":"2015-01-26T11:45:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3381","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3381","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3381.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3381.patch"},"body":"Without this PR, calling `admin ports` appends `omero.port=PORT` to the `ice.config`. This results in the following calls:\r\n\r\n```\r\nbin/omero admin ports --prefix=1\r\nbin/omero admin ports --prefix=1 --revert\r\n```\r\n\r\nwill append the following tow lines\r\n\r\n```\r\nomero.port=14064\r\nomero.port=4064\r\n```\r\n\r\nThis PR fixes the `ice.config` modification logic in `bin/omero admin ports` by:\r\n1- looking for an `omero.port=xxx` line in ICE_CONFIG and replacing it using the new port (as for the other configuration files)\r\n2- if not present, looking for the `## omero.port=xxx` line which ships with the default `ice.config` and uncommenting it\r\n3- if 2 is not applicable, appending `omero.port=xxx` as done previously\r\n\r\n--no-rebase"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/71449227","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3381#issuecomment-71449227","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3381","id":71449227,"user":{"login":"mtbc","id":2630707,"avatar_url":"https://avatars.githubusercontent.com/u/2630707?v=3","gravatar_id":"","url":"https://api.github.com/users/mtbc","html_url":"https://github.com/mtbc","followers_url":"https://api.github.com/users/mtbc/followers","following_url":"https://api.github.com/users/mtbc/following{/other_user}","gists_url":"https://api.github.com/users/mtbc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbc/subscriptions","organizations_url":"https://api.github.com/users/mtbc/orgs","repos_url":"https://api.github.com/users/mtbc/repos","events_url":"https://api.github.com/users/mtbc/events{/privacy}","received_events_url":"https://api.github.com/users/mtbc/received_events","type":"User","site_admin":false},"created_at":"2015-01-26T11:45:00Z","updated_at":"2015-01-26T11:45:00Z","body":"Right, that one. :+1:"}}