{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments/47183994","id":47183994,"diff_hunk":"@@ -392,35 +392,39 @@ def packMsi(build_json=None, app_src=None, app_dest=None, app_name=None):\n \r\n     os.chdir(BUILD_ROOT)\r\n     pkg_name = \"org.xwalk.\" + app_name.replace(\"-\", \"\")\r\n-    project_root = os.path.join(BUILD_ROOT, pkg_name)\r\n+    #project_root = os.path.join(BUILD_ROOT, pkg_name)\r\n     crosswalk_app_tools = os.getenv(\"CROSSWALK_APP_TOOLS\")\r\n     if crosswalk_app_tools == None:\r\n         LOG.error(\"Pls add an environment variable named 'CROSSWALK_APP_TOOLS', and set the crosswalk-app-tools path to this environment variable\")\r\n         os.chdir(orig_dir)\r\n         return False\r\n-    create_cmd = \"node %s/src/crosswalk-app create %s --platforms=windows --windows-crosswalk=crosswalk-%s.zip\" \\\r\n-\t        % (crosswalk_app_tools, pkg_name, CROSSWALK_VERSION)\r\n \r\n-    if not doCMD(create_cmd, DEFAULT_CMD_TIMEOUT):\r\n-        os.chdir(orig_dir)\r\n-        return False\r\n+    if not safelyGetValue(build_json, \"apk-type\") or safelyGetValue(build_json, \"apk-type\") != \"MANIFEST\":\r\n+        if os.path.exists(os.path.join(app_src, \"manifest.json\")):\r\n+            if not doRemove([os.path.join(app_src, \"manifest.json\")]):\r\n+                os.chdir(orig_dir)\r\n+                return False\r\n+        if os.path.exists(os.path.join(app_src, \"icon.ico\")):\r\n+            build_cmd = \"node %s/src/crosswalk-pkg -c crosswalk-%s.zip --platforms=windows -m \" \\\r","path":"tools/build/pack_windows.py","position":23,"original_position":23,"commit_id":"d896130b8d9c255563c8eb4a51717d7fdc0e89c8","original_commit_id":"5d6a623c8b5d16fd6b572312585b39a80c311822","user":{"login":"zhuyongyong","id":7732176,"avatar_url":"https://avatars.githubusercontent.com/u/7732176?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuyongyong","html_url":"https://github.com/zhuyongyong","followers_url":"https://api.github.com/users/zhuyongyong/followers","following_url":"https://api.github.com/users/zhuyongyong/following{/other_user}","gists_url":"https://api.github.com/users/zhuyongyong/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuyongyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuyongyong/subscriptions","organizations_url":"https://api.github.com/users/zhuyongyong/orgs","repos_url":"https://api.github.com/users/zhuyongyong/repos","events_url":"https://api.github.com/users/zhuyongyong/events{/privacy}","received_events_url":"https://api.github.com/users/zhuyongyong/received_events","type":"User","site_admin":false},"body":"The apptools for windows can't download crosswalk-*.zip. by itself","created_at":"2015-12-10T02:55:58Z","updated_at":"2015-12-10T02:55:58Z","html_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028#discussion_r47183994","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments/47183994"},"html":{"href":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028#discussion_r47183994"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028","id":49775481,"html_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028","diff_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028.diff","patch_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/3028","number":3028,"state":"open","locked":false,"title":"[windows] Modify pack script to enable webapi test suite msi package","user":{"login":"zhuyongyong","id":7732176,"avatar_url":"https://avatars.githubusercontent.com/u/7732176?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuyongyong","html_url":"https://github.com/zhuyongyong","followers_url":"https://api.github.com/users/zhuyongyong/followers","following_url":"https://api.github.com/users/zhuyongyong/following{/other_user}","gists_url":"https://api.github.com/users/zhuyongyong/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuyongyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuyongyong/subscriptions","organizations_url":"https://api.github.com/users/zhuyongyong/orgs","repos_url":"https://api.github.com/users/zhuyongyong/repos","events_url":"https://api.github.com/users/zhuyongyong/events{/privacy}","received_events_url":"https://api.github.com/users/zhuyongyong/received_events","type":"User","site_admin":false},"body":"- It's fine to pack msi package with the template manifest.json file\r\n\r\nhttps://crosswalk-project.org/jira/browse/XWALK-5632","created_at":"2015-11-05T02:35:10Z","updated_at":"2015-12-10T02:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a73bb7d043b5a69afb879b6dc78b543fab6ec7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/3028/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/d896130b8d9c255563c8eb4a51717d7fdc0e89c8","head":{"label":"zhuyongyong:windows/enableWebapi","ref":"windows/enableWebapi","sha":"d896130b8d9c255563c8eb4a51717d7fdc0e89c8","user":{"login":"zhuyongyong","id":7732176,"avatar_url":"https://avatars.githubusercontent.com/u/7732176?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuyongyong","html_url":"https://github.com/zhuyongyong","followers_url":"https://api.github.com/users/zhuyongyong/followers","following_url":"https://api.github.com/users/zhuyongyong/following{/other_user}","gists_url":"https://api.github.com/users/zhuyongyong/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuyongyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuyongyong/subscriptions","organizations_url":"https://api.github.com/users/zhuyongyong/orgs","repos_url":"https://api.github.com/users/zhuyongyong/repos","events_url":"https://api.github.com/users/zhuyongyong/events{/privacy}","received_events_url":"https://api.github.com/users/zhuyongyong/received_events","type":"User","site_admin":false},"repo":{"id":20671988,"name":"crosswalk-test-suite","full_name":"zhuyongyong/crosswalk-test-suite","owner":{"login":"zhuyongyong","id":7732176,"avatar_url":"https://avatars.githubusercontent.com/u/7732176?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuyongyong","html_url":"https://github.com/zhuyongyong","followers_url":"https://api.github.com/users/zhuyongyong/followers","following_url":"https://api.github.com/users/zhuyongyong/following{/other_user}","gists_url":"https://api.github.com/users/zhuyongyong/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuyongyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuyongyong/subscriptions","organizations_url":"https://api.github.com/users/zhuyongyong/orgs","repos_url":"https://api.github.com/users/zhuyongyong/repos","events_url":"https://api.github.com/users/zhuyongyong/events{/privacy}","received_events_url":"https://api.github.com/users/zhuyongyong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhuyongyong/crosswalk-test-suite","description":"","fork":true,"url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite","forks_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/forks","keys_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/teams","hooks_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/hooks","issue_events_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/events","assignees_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/tags","blobs_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/languages","stargazers_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/stargazers","contributors_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/contributors","subscribers_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/subscribers","subscription_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/subscription","commits_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/merges","archive_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/downloads","issues_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/zhuyongyong/crosswalk-test-suite/releases{/id}","created_at":"2014-06-10T04:08:37Z","updated_at":"2015-05-08T08:19:47Z","pushed_at":"2015-12-10T02:53:46Z","git_url":"git://github.com/zhuyongyong/crosswalk-test-suite.git","ssh_url":"git@github.com:zhuyongyong/crosswalk-test-suite.git","clone_url":"https://github.com/zhuyongyong/crosswalk-test-suite.git","svn_url":"https://github.com/zhuyongyong/crosswalk-test-suite","homepage":null,"size":152627,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"cee9d54ffeffa251be88d2733e02fbdd688dd715","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17703190,"name":"crosswalk-test-suite","full_name":"crosswalk-project/crosswalk-test-suite","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk-test-suite","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/releases{/id}","created_at":"2014-03-13T08:33:13Z","updated_at":"2015-11-19T09:16:49Z","pushed_at":"2015-12-10T02:53:46Z","git_url":"git://github.com/crosswalk-project/crosswalk-test-suite.git","ssh_url":"git@github.com:crosswalk-project/crosswalk-test-suite.git","clone_url":"https://github.com/crosswalk-project/crosswalk-test-suite.git","svn_url":"https://github.com/crosswalk-project/crosswalk-test-suite","homepage":null,"size":186284,"stargazers_count":19,"watchers_count":19,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"open_issues_count":26,"forks":82,"open_issues":26,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028"},"html":{"href":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/3028"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/3028"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/3028/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/3028/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/d896130b8d9c255563c8eb4a51717d7fdc0e89c8"}}}}