{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/23725554","id":23725554,"diff_hunk":"@@ -214,6 +214,26 @@ class CachedSpec extends PlaySpecification {\n     }\n   }\n \n+  \"CacheApi\" should {\n+    \"get items from cache\" in new WithApplication() {\n+      val defaultCache = app.injector.instanceOf[CacheApi]\n+      defaultCache.set(\"foo\", \"bar\")\n+      defaultCache.get[String](\"foo\") must beSome(\"bar\")\n+    }\n+\n+    \"doesnt give items from cache with wrong type\" in new WithApplication() {\n+      val defaultCache = app.injector.instanceOf[CacheApi]\n+      defaultCache.set(\"foo\", \"bar\")\n+      defaultCache.get[Int](\"foo\") must beNone\n+    }\n+\n+    \"get items from the cache without giving a type\" in new WithApplication() {\n+      val defaultCache = app.injector.instanceOf[CacheApi]\n+      defaultCache.set(\"foo\", \"bar\")\n+      defaultCache.get(\"foo\") must beSome(\"bar\")","path":"framework/src/play-cache/src/test/scala/play/api/cache/CachedSpec.scala","position":null,"original_position":20,"commit_id":"992a72de08de48c3e345adb9bc3054bdc80d3a78","original_commit_id":"37961a247d2927d3d72f88ca5ddf2a2f9893e466","user":{"login":"francisdb","id":161305,"avatar_url":"https://avatars.githubusercontent.com/u/161305?v=3","gravatar_id":"","url":"https://api.github.com/users/francisdb","html_url":"https://github.com/francisdb","followers_url":"https://api.github.com/users/francisdb/followers","following_url":"https://api.github.com/users/francisdb/following{/other_user}","gists_url":"https://api.github.com/users/francisdb/gists{/gist_id}","starred_url":"https://api.github.com/users/francisdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisdb/subscriptions","organizations_url":"https://api.github.com/users/francisdb/orgs","repos_url":"https://api.github.com/users/francisdb/repos","events_url":"https://api.github.com/users/francisdb/events{/privacy}","received_events_url":"https://api.github.com/users/francisdb/received_events","type":"User","site_admin":false},"body":"@jroper In the original issue you can see that get[Any](...) was working correctly, get(...) was not","created_at":"2015-01-28T21:31:14Z","updated_at":"2015-01-28T21:31:14Z","html_url":"https://github.com/playframework/playframework/pull/3860#discussion_r23725554","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/3860","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/23725554"},"html":{"href":"https://github.com/playframework/playframework/pull/3860#discussion_r23725554"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3860"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/3860","id":28182161,"html_url":"https://github.com/playframework/playframework/pull/3860","diff_url":"https://github.com/playframework/playframework/pull/3860.diff","patch_url":"https://github.com/playframework/playframework/pull/3860.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/3860","number":3860,"state":"open","locked":false,"title":"fix #3858: CacheApi always returns None when type not provided.","user":{"login":"stephennancekivell","id":727013,"avatar_url":"https://avatars.githubusercontent.com/u/727013?v=3","gravatar_id":"","url":"https://api.github.com/users/stephennancekivell","html_url":"https://github.com/stephennancekivell","followers_url":"https://api.github.com/users/stephennancekivell/followers","following_url":"https://api.github.com/users/stephennancekivell/following{/other_user}","gists_url":"https://api.github.com/users/stephennancekivell/gists{/gist_id}","starred_url":"https://api.github.com/users/stephennancekivell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephennancekivell/subscriptions","organizations_url":"https://api.github.com/users/stephennancekivell/orgs","repos_url":"https://api.github.com/users/stephennancekivell/repos","events_url":"https://api.github.com/users/stephennancekivell/events{/privacy}","received_events_url":"https://api.github.com/users/stephennancekivell/received_events","type":"User","site_admin":false},"body":"Hi\r\nWhat do you guys think, Is this fix Ok? Im a bit unsure about matching on the Nothing, but it seems to work.","created_at":"2015-01-28T10:23:00Z","updated_at":"2015-01-28T21:31:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e2b82ac69c832fbd69a96dbffa1152072ce9d93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/3860/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/3860/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/3860/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/992a72de08de48c3e345adb9bc3054bdc80d3a78","head":{"label":"stephennancekivell:master","ref":"master","sha":"992a72de08de48c3e345adb9bc3054bdc80d3a78","user":{"login":"stephennancekivell","id":727013,"avatar_url":"https://avatars.githubusercontent.com/u/727013?v=3","gravatar_id":"","url":"https://api.github.com/users/stephennancekivell","html_url":"https://github.com/stephennancekivell","followers_url":"https://api.github.com/users/stephennancekivell/followers","following_url":"https://api.github.com/users/stephennancekivell/following{/other_user}","gists_url":"https://api.github.com/users/stephennancekivell/gists{/gist_id}","starred_url":"https://api.github.com/users/stephennancekivell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephennancekivell/subscriptions","organizations_url":"https://api.github.com/users/stephennancekivell/orgs","repos_url":"https://api.github.com/users/stephennancekivell/repos","events_url":"https://api.github.com/users/stephennancekivell/events{/privacy}","received_events_url":"https://api.github.com/users/stephennancekivell/received_events","type":"User","site_admin":false},"repo":{"id":5734411,"name":"Play20","full_name":"stephennancekivell/Play20","owner":{"login":"stephennancekivell","id":727013,"avatar_url":"https://avatars.githubusercontent.com/u/727013?v=3","gravatar_id":"","url":"https://api.github.com/users/stephennancekivell","html_url":"https://github.com/stephennancekivell","followers_url":"https://api.github.com/users/stephennancekivell/followers","following_url":"https://api.github.com/users/stephennancekivell/following{/other_user}","gists_url":"https://api.github.com/users/stephennancekivell/gists{/gist_id}","starred_url":"https://api.github.com/users/stephennancekivell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephennancekivell/subscriptions","organizations_url":"https://api.github.com/users/stephennancekivell/orgs","repos_url":"https://api.github.com/users/stephennancekivell/repos","events_url":"https://api.github.com/users/stephennancekivell/events{/privacy}","received_events_url":"https://api.github.com/users/stephennancekivell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephennancekivell/Play20","description":"Play framework 2.0","fork":true,"url":"https://api.github.com/repos/stephennancekivell/Play20","forks_url":"https://api.github.com/repos/stephennancekivell/Play20/forks","keys_url":"https://api.github.com/repos/stephennancekivell/Play20/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephennancekivell/Play20/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephennancekivell/Play20/teams","hooks_url":"https://api.github.com/repos/stephennancekivell/Play20/hooks","issue_events_url":"https://api.github.com/repos/stephennancekivell/Play20/issues/events{/number}","events_url":"https://api.github.com/repos/stephennancekivell/Play20/events","assignees_url":"https://api.github.com/repos/stephennancekivell/Play20/assignees{/user}","branches_url":"https://api.github.com/repos/stephennancekivell/Play20/branches{/branch}","tags_url":"https://api.github.com/repos/stephennancekivell/Play20/tags","blobs_url":"https://api.github.com/repos/stephennancekivell/Play20/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephennancekivell/Play20/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephennancekivell/Play20/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephennancekivell/Play20/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephennancekivell/Play20/statuses/{sha}","languages_url":"https://api.github.com/repos/stephennancekivell/Play20/languages","stargazers_url":"https://api.github.com/repos/stephennancekivell/Play20/stargazers","contributors_url":"https://api.github.com/repos/stephennancekivell/Play20/contributors","subscribers_url":"https://api.github.com/repos/stephennancekivell/Play20/subscribers","subscription_url":"https://api.github.com/repos/stephennancekivell/Play20/subscription","commits_url":"https://api.github.com/repos/stephennancekivell/Play20/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephennancekivell/Play20/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephennancekivell/Play20/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephennancekivell/Play20/issues/comments/{number}","contents_url":"https://api.github.com/repos/stephennancekivell/Play20/contents/{+path}","compare_url":"https://api.github.com/repos/stephennancekivell/Play20/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephennancekivell/Play20/merges","archive_url":"https://api.github.com/repos/stephennancekivell/Play20/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephennancekivell/Play20/downloads","issues_url":"https://api.github.com/repos/stephennancekivell/Play20/issues{/number}","pulls_url":"https://api.github.com/repos/stephennancekivell/Play20/pulls{/number}","milestones_url":"https://api.github.com/repos/stephennancekivell/Play20/milestones{/number}","notifications_url":"https://api.github.com/repos/stephennancekivell/Play20/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephennancekivell/Play20/labels{/name}","releases_url":"https://api.github.com/repos/stephennancekivell/Play20/releases{/id}","created_at":"2012-09-09T02:54:35Z","updated_at":"2015-01-28T20:48:43Z","pushed_at":"2015-01-28T20:48:42Z","git_url":"git://github.com/stephennancekivell/Play20.git","ssh_url":"git@github.com:stephennancekivell/Play20.git","clone_url":"https://github.com/stephennancekivell/Play20.git","svn_url":"https://github.com/stephennancekivell/Play20","homepage":"http://www.playframework.org/","size":51496,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"b57fdaa70e48870e7788d50023ad8074d64af50f","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments/{number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-01-28T16:13:02Z","pushed_at":"2015-01-28T17:46:01Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":114520,"stargazers_count":5739,"watchers_count":5739,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2072,"mirror_url":null,"open_issues_count":253,"forks":2072,"open_issues":253,"watchers":5739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3860"},"html":{"href":"https://github.com/playframework/playframework/pull/3860"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/3860"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/3860/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3860/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3860/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/992a72de08de48c3e345adb9bc3054bdc80d3a78"}}}}