{"action":"created","issue":{"url":"https://api.github.com/repos/gonum/graph/issues/120","labels_url":"https://api.github.com/repos/gonum/graph/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/gonum/graph/issues/120/comments","events_url":"https://api.github.com/repos/gonum/graph/issues/120/events","html_url":"https://github.com/gonum/graph/pull/120","id":105582174,"number":120,"title":"topo: use use golang.org/x/.../intsets for TarjanSCC","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=3","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-09T12:00:25Z","updated_at":"2015-09-09T13:45:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gonum/graph/pulls/120","html_url":"https://github.com/gonum/graph/pull/120","diff_url":"https://github.com/gonum/graph/pull/120.diff","patch_url":"https://github.com/gonum/graph/pull/120.patch"},"body":"I have looked at similar changes for CyclesIn, but the benefits are mixed, more complicated and incomplete, and clearly not worth the change:\r\n\r\n```\r\nname                  old mean              new mean              delta\r\nCyclesInGnp_10_tenth  46.1µs × (1.00,1.00)  44.9µs × (0.98,1.01)   -2.46% (p=0.000 n=9+9)\r\nCyclesInGnp_20_tenth  1.63ms × (1.00,1.00)  1.71ms × (1.00,1.01)  +4.92% (p=0.000 n=10+8)\r\nCyclesInGnp_10_half   8.03ms × (1.00,1.00)  8.14ms × (0.96,1.01)    ~    (p=0.156 n=9+10)\r\n```\r\n\r\nAlso fix spelling.\r\n\r\n@vladimir-ch Please take a look."},"comment":{"url":"https://api.github.com/repos/gonum/graph/issues/comments/138913391","html_url":"https://github.com/gonum/graph/pull/120#issuecomment-138913391","issue_url":"https://api.github.com/repos/gonum/graph/issues/120","id":138913391,"user":{"login":"btracey","id":3680859,"avatar_url":"https://avatars.githubusercontent.com/u/3680859?v=3","gravatar_id":"","url":"https://api.github.com/users/btracey","html_url":"https://github.com/btracey","followers_url":"https://api.github.com/users/btracey/followers","following_url":"https://api.github.com/users/btracey/following{/other_user}","gists_url":"https://api.github.com/users/btracey/gists{/gist_id}","starred_url":"https://api.github.com/users/btracey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btracey/subscriptions","organizations_url":"https://api.github.com/users/btracey/orgs","repos_url":"https://api.github.com/users/btracey/repos","events_url":"https://api.github.com/users/btracey/events{/privacy}","received_events_url":"https://api.github.com/users/btracey/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T13:45:11Z","updated_at":"2015-09-09T13:45:11Z","body":"Is there a utility in using the external code anyway? The golang/x package will likely be more widely used, which helps legibility, and there will likely be more time spent improving that implementation than internal/IntSet. It isn't faster, but it's not slower either, so it seems a win to have less gonum code. "}}