{"action":"closed","number":428,"pull_request":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/428","id":30048988,"html_url":"https://github.com/EasyRPG/Player/pull/428","diff_url":"https://github.com/EasyRPG/Player/pull/428.diff","patch_url":"https://github.com/EasyRPG/Player/pull/428.patch","issue_url":"https://api.github.com/repos/EasyRPG/Player/issues/428","number":428,"state":"closed","locked":false,"title":"Fixes for Rainbow Treasure OP","user":{"login":"scurest","id":11024420,"avatar_url":"https://avatars.githubusercontent.com/u/11024420?v=3","gravatar_id":"","url":"https://api.github.com/users/scurest","html_url":"https://github.com/scurest","followers_url":"https://api.github.com/users/scurest/followers","following_url":"https://api.github.com/users/scurest/following{/other_user}","gists_url":"https://api.github.com/users/scurest/gists{/gist_id}","starred_url":"https://api.github.com/users/scurest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scurest/subscriptions","organizations_url":"https://api.github.com/users/scurest/orgs","repos_url":"https://api.github.com/users/scurest/repos","events_url":"https://api.github.com/users/scurest/events{/privacy}","received_events_url":"https://api.github.com/users/scurest/received_events","type":"User","site_admin":false},"body":"Fixes the errors I noticed in the Rainbow Treasure OP.\r\n\r\n##### Character placement off  f1fe079\r\n\r\n![tear](https://cloud.githubusercontent.com/assets/11024420/6385990/c19ef2d6-bd37-11e4-8bd2-b2309360efd9.png)\r\n\r\nSome events are drawn off by one pixel. Caused by the formula in `Game_Character::GetScreenX()` and `Y()`. Changed to take the difference in pixels, not real coordinates, which I _think_ is correct. Can someone check?\r\n\r\n##### Pan speed too slow  be05554\r\n\r\n![pan](https://cloud.githubusercontent.com/assets/11024420/6385993/cbf07f84-bd37-11e4-8b73-9e3e35fa9874.png)\r\n\r\nThe pan drags behind the characters during the OP. Changed just by increasing the pan speed, but also changed to use `SCREEN_TILE_WIDTH / 128` instead of `2`, like for characters, I think it goes here too: @Ghabry, you made that change for character speed, what do you think?\r\n\r\n##### Pan jumps after map teleport  8efd1a5\r\n\r\n![copper](https://cloud.githubusercontent.com/assets/11024420/6385998/d35b7e04-bd37-11e4-95ee-b84b525f5154.png)\r\n\r\nCaused by the pan in `Game_Character` being reset too early. I think this also fixes a bug where the pan is lost when teleporting within the same map (?).\r\n\r\n##### Parallax BGs don't scroll backwards  28cedf8\r\n\r\n![manganese](https://cloud.githubusercontent.com/assets/11024420/6385999/d938c868-bd37-11e4-80f6-f60e40dedf26.png)\r\n\r\nManganese's OP uses a parallax background to make it look like she's walking, but it goes the wrong way! Just a missing sign in `UpdateParallax` but I also used `SCREEN_TILE_WIDTH / 128` here and sped it up.\r\n\r\n##### Jumping in place 716623d\r\n\r\n![jump](https://cloud.githubusercontent.com/assets/11024420/6386002/e0356f22-bd37-11e4-94a1-986389d8ee5c.png)\r\n\r\nDiscussed [here](https://github.com/EasyRPG/Player/issues/344#issuecomment-75355015).\r\n\r\n--------------\r\n\r\nThere's also #356 and one more I just noticed—the old man in front of the chest's sweat drop is drawn behind him when it should be drawn in front—that I didn't fix.","created_at":"2015-02-26T03:54:41Z","updated_at":"2015-02-26T19:54:00Z","closed_at":"2015-02-26T19:54:00Z","merged_at":"2015-02-26T19:54:00Z","merge_commit_sha":"5d12d7bdd3e7a98c10a8a82f0c3dc504958469b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EasyRPG/Player/pulls/428/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/Player/pulls/428/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/Player/issues/428/comments","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/be05554921a6332f5064f99438556306b1e6f192","head":{"label":"scurest:RainbowTreasureOP","ref":"RainbowTreasureOP","sha":"be05554921a6332f5064f99438556306b1e6f192","user":{"login":"scurest","id":11024420,"avatar_url":"https://avatars.githubusercontent.com/u/11024420?v=3","gravatar_id":"","url":"https://api.github.com/users/scurest","html_url":"https://github.com/scurest","followers_url":"https://api.github.com/users/scurest/followers","following_url":"https://api.github.com/users/scurest/following{/other_user}","gists_url":"https://api.github.com/users/scurest/gists{/gist_id}","starred_url":"https://api.github.com/users/scurest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scurest/subscriptions","organizations_url":"https://api.github.com/users/scurest/orgs","repos_url":"https://api.github.com/users/scurest/repos","events_url":"https://api.github.com/users/scurest/events{/privacy}","received_events_url":"https://api.github.com/users/scurest/received_events","type":"User","site_admin":false},"repo":{"id":30854855,"name":"Player","full_name":"scurest/Player","owner":{"login":"scurest","id":11024420,"avatar_url":"https://avatars.githubusercontent.com/u/11024420?v=3","gravatar_id":"","url":"https://api.github.com/users/scurest","html_url":"https://github.com/scurest","followers_url":"https://api.github.com/users/scurest/followers","following_url":"https://api.github.com/users/scurest/following{/other_user}","gists_url":"https://api.github.com/users/scurest/gists{/gist_id}","starred_url":"https://api.github.com/users/scurest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scurest/subscriptions","organizations_url":"https://api.github.com/users/scurest/orgs","repos_url":"https://api.github.com/users/scurest/repos","events_url":"https://api.github.com/users/scurest/events{/privacy}","received_events_url":"https://api.github.com/users/scurest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scurest/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":true,"url":"https://api.github.com/repos/scurest/Player","forks_url":"https://api.github.com/repos/scurest/Player/forks","keys_url":"https://api.github.com/repos/scurest/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scurest/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scurest/Player/teams","hooks_url":"https://api.github.com/repos/scurest/Player/hooks","issue_events_url":"https://api.github.com/repos/scurest/Player/issues/events{/number}","events_url":"https://api.github.com/repos/scurest/Player/events","assignees_url":"https://api.github.com/repos/scurest/Player/assignees{/user}","branches_url":"https://api.github.com/repos/scurest/Player/branches{/branch}","tags_url":"https://api.github.com/repos/scurest/Player/tags","blobs_url":"https://api.github.com/repos/scurest/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scurest/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scurest/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/scurest/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scurest/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/scurest/Player/languages","stargazers_url":"https://api.github.com/repos/scurest/Player/stargazers","contributors_url":"https://api.github.com/repos/scurest/Player/contributors","subscribers_url":"https://api.github.com/repos/scurest/Player/subscribers","subscription_url":"https://api.github.com/repos/scurest/Player/subscription","commits_url":"https://api.github.com/repos/scurest/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/scurest/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/scurest/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/scurest/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/scurest/Player/contents/{+path}","compare_url":"https://api.github.com/repos/scurest/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scurest/Player/merges","archive_url":"https://api.github.com/repos/scurest/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scurest/Player/downloads","issues_url":"https://api.github.com/repos/scurest/Player/issues{/number}","pulls_url":"https://api.github.com/repos/scurest/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/scurest/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/scurest/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scurest/Player/labels{/name}","releases_url":"https://api.github.com/repos/scurest/Player/releases{/id}","created_at":"2015-02-16T05:14:03Z","updated_at":"2015-02-22T18:41:13Z","pushed_at":"2015-02-26T03:28:33Z","git_url":"git://github.com/scurest/Player.git","ssh_url":"git@github.com:scurest/Player.git","clone_url":"https://github.com/scurest/Player.git","svn_url":"https://github.com/scurest/Player","homepage":"https://easy-rpg.org/","size":21178,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"fc6be107d14bf5c0fc9ee921ca6e7b45d1bfac13","user":{"login":"EasyRPG","id":1331871,"avatar_url":"https://avatars.githubusercontent.com/u/1331871?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3297519,"name":"Player","full_name":"EasyRPG/Player","owner":{"login":"EasyRPG","id":1331871,"avatar_url":"https://avatars.githubusercontent.com/u/1331871?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EasyRPG/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":false,"url":"https://api.github.com/repos/EasyRPG/Player","forks_url":"https://api.github.com/repos/EasyRPG/Player/forks","keys_url":"https://api.github.com/repos/EasyRPG/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/Player/teams","hooks_url":"https://api.github.com/repos/EasyRPG/Player/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/Player/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/Player/events","assignees_url":"https://api.github.com/repos/EasyRPG/Player/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/Player/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/Player/tags","blobs_url":"https://api.github.com/repos/EasyRPG/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/Player/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/Player/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/Player/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/Player/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/Player/subscription","commits_url":"https://api.github.com/repos/EasyRPG/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/Player/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/Player/merges","archive_url":"https://api.github.com/repos/EasyRPG/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/Player/downloads","issues_url":"https://api.github.com/repos/EasyRPG/Player/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/Player/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/Player/releases{/id}","created_at":"2012-01-29T14:35:47Z","updated_at":"2015-02-26T19:54:00Z","pushed_at":"2015-02-26T19:54:00Z","git_url":"git://github.com/EasyRPG/Player.git","ssh_url":"git@github.com:EasyRPG/Player.git","clone_url":"https://github.com/EasyRPG/Player.git","svn_url":"https://github.com/EasyRPG/Player","homepage":"https://easy-rpg.org/","size":22998,"stargazers_count":94,"watchers_count":94,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":48,"forks":32,"open_issues":48,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/428"},"html":{"href":"https://github.com/EasyRPG/Player/pull/428"},"issue":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/428"},"comments":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/Player/statuses/be05554921a6332f5064f99438556306b1e6f192"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Ghabry","id":1331889,"avatar_url":"https://avatars.githubusercontent.com/u/1331889?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false},"comments":2,"review_comments":4,"commits":5,"additions":15,"deletions":10,"changed_files":3}}