{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments/45263111","id":45263111,"diff_hunk":"@@ -47,3 +31,22 @@ function isEmptyCommand (program) {\n   return false;\n }\n exports.isEmptyCommand = isEmptyCommand;\n+\n+function validateProgram(program) {\n+  Object.keys(program).filter(function (option) {\n+    return ~DEBUG_VALUES.indexOf(option);","path":"lib/cmd.js","position":36,"original_position":36,"commit_id":"cd28fbf7242fc0b3d3eae060aac01cf5a3fc17b6","original_commit_id":"cd28fbf7242fc0b3d3eae060aac01cf5a3fc17b6","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"heh, I didn't even know what this was doing, thanks for the explanation. It's littered all over jpm so I'm hesitant to touch it. There really isn't a lot of test coverage either.","created_at":"2015-11-18T21:29:43Z","updated_at":"2015-11-18T21:29:43Z","html_url":"https://github.com/mozilla-jetpack/jpm/pull/394#discussion_r45263111","pull_request_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments/45263111"},"html":{"href":"https://github.com/mozilla-jetpack/jpm/pull/394#discussion_r45263111"},"pull_request":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394","id":50981829,"html_url":"https://github.com/mozilla-jetpack/jpm/pull/394","diff_url":"https://github.com/mozilla-jetpack/jpm/pull/394.diff","patch_url":"https://github.com/mozilla-jetpack/jpm/pull/394.patch","issue_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/394","number":394,"state":"open","locked":false,"title":"Run jpm sign on a custom XPI file","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"Fixes #393","created_at":"2015-11-17T18:02:33Z","updated_at":"2015-11-18T21:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06cf162ce419df6deb4bd4fac32e5e69a4f54298","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394/commits","review_comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394/comments","review_comment_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/394/comments","statuses_url":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/cd28fbf7242fc0b3d3eae060aac01cf5a3fc17b6","head":{"label":"kumar303:sign-xpi","ref":"sign-xpi","sha":"cd28fbf7242fc0b3d3eae060aac01cf5a3fc17b6","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"repo":{"id":44623541,"name":"jpm","full_name":"kumar303/jpm","owner":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumar303/jpm","description":"Jetpack Manager for Node.js","fork":true,"url":"https://api.github.com/repos/kumar303/jpm","forks_url":"https://api.github.com/repos/kumar303/jpm/forks","keys_url":"https://api.github.com/repos/kumar303/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumar303/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumar303/jpm/teams","hooks_url":"https://api.github.com/repos/kumar303/jpm/hooks","issue_events_url":"https://api.github.com/repos/kumar303/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/kumar303/jpm/events","assignees_url":"https://api.github.com/repos/kumar303/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/kumar303/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/kumar303/jpm/tags","blobs_url":"https://api.github.com/repos/kumar303/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumar303/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumar303/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumar303/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumar303/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/kumar303/jpm/languages","stargazers_url":"https://api.github.com/repos/kumar303/jpm/stargazers","contributors_url":"https://api.github.com/repos/kumar303/jpm/contributors","subscribers_url":"https://api.github.com/repos/kumar303/jpm/subscribers","subscription_url":"https://api.github.com/repos/kumar303/jpm/subscription","commits_url":"https://api.github.com/repos/kumar303/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumar303/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumar303/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumar303/jpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumar303/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/kumar303/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumar303/jpm/merges","archive_url":"https://api.github.com/repos/kumar303/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumar303/jpm/downloads","issues_url":"https://api.github.com/repos/kumar303/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/kumar303/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/kumar303/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/kumar303/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumar303/jpm/labels{/name}","releases_url":"https://api.github.com/repos/kumar303/jpm/releases{/id}","created_at":"2015-10-20T17:35:26Z","updated_at":"2015-10-20T17:35:27Z","pushed_at":"2015-11-17T23:23:36Z","git_url":"git://github.com/kumar303/jpm.git","ssh_url":"git@github.com:kumar303/jpm.git","clone_url":"https://github.com/kumar303/jpm.git","svn_url":"https://github.com/kumar303/jpm","homepage":"https://www.npmjs.org/package/jpm","size":552,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-jetpack:master","ref":"master","sha":"ba1e1054fd3271ba800d78e952c3cdb1fd7037ba","user":{"login":"mozilla-jetpack","id":13967888,"avatar_url":"https://avatars.githubusercontent.com/u/13967888?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-jetpack","html_url":"https://github.com/mozilla-jetpack","followers_url":"https://api.github.com/users/mozilla-jetpack/followers","following_url":"https://api.github.com/users/mozilla-jetpack/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-jetpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-jetpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-jetpack/subscriptions","organizations_url":"https://api.github.com/users/mozilla-jetpack/orgs","repos_url":"https://api.github.com/users/mozilla-jetpack/repos","events_url":"https://api.github.com/users/mozilla-jetpack/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-jetpack/received_events","type":"Organization","site_admin":false},"repo":{"id":14935921,"name":"jpm","full_name":"mozilla-jetpack/jpm","owner":{"login":"mozilla-jetpack","id":13967888,"avatar_url":"https://avatars.githubusercontent.com/u/13967888?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-jetpack","html_url":"https://github.com/mozilla-jetpack","followers_url":"https://api.github.com/users/mozilla-jetpack/followers","following_url":"https://api.github.com/users/mozilla-jetpack/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-jetpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-jetpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-jetpack/subscriptions","organizations_url":"https://api.github.com/users/mozilla-jetpack/orgs","repos_url":"https://api.github.com/users/mozilla-jetpack/repos","events_url":"https://api.github.com/users/mozilla-jetpack/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-jetpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-jetpack/jpm","description":"Jetpack Manager for Node.js","fork":false,"url":"https://api.github.com/repos/mozilla-jetpack/jpm","forks_url":"https://api.github.com/repos/mozilla-jetpack/jpm/forks","keys_url":"https://api.github.com/repos/mozilla-jetpack/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-jetpack/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-jetpack/jpm/teams","hooks_url":"https://api.github.com/repos/mozilla-jetpack/jpm/hooks","issue_events_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-jetpack/jpm/events","assignees_url":"https://api.github.com/repos/mozilla-jetpack/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-jetpack/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-jetpack/jpm/tags","blobs_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-jetpack/jpm/languages","stargazers_url":"https://api.github.com/repos/mozilla-jetpack/jpm/stargazers","contributors_url":"https://api.github.com/repos/mozilla-jetpack/jpm/contributors","subscribers_url":"https://api.github.com/repos/mozilla-jetpack/jpm/subscribers","subscription_url":"https://api.github.com/repos/mozilla-jetpack/jpm/subscription","commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-jetpack/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-jetpack/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-jetpack/jpm/merges","archive_url":"https://api.github.com/repos/mozilla-jetpack/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-jetpack/jpm/downloads","issues_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-jetpack/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-jetpack/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-jetpack/jpm/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-jetpack/jpm/releases{/id}","created_at":"2013-12-04T21:09:56Z","updated_at":"2015-11-11T09:54:42Z","pushed_at":"2015-11-18T16:52:28Z","git_url":"git://github.com/mozilla-jetpack/jpm.git","ssh_url":"git@github.com:mozilla-jetpack/jpm.git","clone_url":"https://github.com/mozilla-jetpack/jpm.git","svn_url":"https://github.com/mozilla-jetpack/jpm","homepage":"https://www.npmjs.org/package/jpm","size":714,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":108,"forks":53,"open_issues":108,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394"},"html":{"href":"https://github.com/mozilla-jetpack/jpm/pull/394"},"issue":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/394"},"comments":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/cd28fbf7242fc0b3d3eae060aac01cf5a3fc17b6"}}}}