{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/28767859","id":28767859,"diff_hunk":"@@ -186,12 +185,11 @@ class GraphFlexiMergeSpec extends AkkaSpec {\n           merge.out ~> o.inlet\n       }.run()\n \n-      val s = SubscriberProbe[String]\n+      val s = TestSubscriber.probe[String]\n       p.subscribe(s)\n       val sub = s.expectSubscription()\n       sub.request(10)\n-      (s.probe.receiveN(6).map { case OnNext(elem) ⇒ elem }).toSet should be(\n-        Set(\"a\", \"b\", \"c\", \"d\", \"e\", \"f\"))\n+      (for (_ ← 1 to 6) yield s.expectNext()).toSet should be(Set(\"a\", \"b\", \"c\", \"d\", \"e\", \"f\"))","path":"akka-stream-tests/src/test/scala/akka/stream/scaladsl/GraphFlexiMergeSpec.scala","position":21,"original_position":21,"commit_id":"01eb2b19ebc35a996061f619667cc082328cd5b9","original_commit_id":"01eb2b19ebc35a996061f619667cc082328cd5b9","user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"body":"make this a pattern, probe.expectNextN for example. Maybe it should also handle completion, truncating the Seq if completed early (this would make the \"Await(x.grouped().runWith(Sink.head)) should be (y)\" pattern go await, since it would be x.runWith(probe).expectNextN() should be(y) given that probe also extends Sink)","created_at":"2015-04-21T10:59:43Z","updated_at":"2015-04-21T10:59:43Z","html_url":"https://github.com/akka/akka/pull/17238#discussion_r28767859","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17238","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/28767859"},"html":{"href":"https://github.com/akka/akka/pull/17238#discussion_r28767859"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17238"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17238","id":33734776,"html_url":"https://github.com/akka/akka/pull/17238","diff_url":"https://github.com/akka/akka/pull/17238.diff","patch_url":"https://github.com/akka/akka/pull/17238.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17238","number":17238,"state":"open","locked":false,"title":"=str #17089 stream testkit","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"body":"This change pulls out Subscriber/Publisher probes to main sources of `akka-stream-testkit` project and adds factory objects for various subscribers/publishers.","created_at":"2015-04-21T07:21:04Z","updated_at":"2015-04-21T10:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b78a097ff8192e3cad29173d6b932efea1846439","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17238/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17238/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17238/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/01eb2b19ebc35a996061f619667cc082328cd5b9","head":{"label":"2m:wip-stream-testkit","ref":"wip-stream-testkit","sha":"01eb2b19ebc35a996061f619667cc082328cd5b9","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"repo":{"id":18794399,"name":"akka","full_name":"2m/akka","owner":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2m/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/2m/akka","forks_url":"https://api.github.com/repos/2m/akka/forks","keys_url":"https://api.github.com/repos/2m/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2m/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2m/akka/teams","hooks_url":"https://api.github.com/repos/2m/akka/hooks","issue_events_url":"https://api.github.com/repos/2m/akka/issues/events{/number}","events_url":"https://api.github.com/repos/2m/akka/events","assignees_url":"https://api.github.com/repos/2m/akka/assignees{/user}","branches_url":"https://api.github.com/repos/2m/akka/branches{/branch}","tags_url":"https://api.github.com/repos/2m/akka/tags","blobs_url":"https://api.github.com/repos/2m/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2m/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2m/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/2m/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2m/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/2m/akka/languages","stargazers_url":"https://api.github.com/repos/2m/akka/stargazers","contributors_url":"https://api.github.com/repos/2m/akka/contributors","subscribers_url":"https://api.github.com/repos/2m/akka/subscribers","subscription_url":"https://api.github.com/repos/2m/akka/subscription","commits_url":"https://api.github.com/repos/2m/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/2m/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/2m/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/2m/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/2m/akka/contents/{+path}","compare_url":"https://api.github.com/repos/2m/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2m/akka/merges","archive_url":"https://api.github.com/repos/2m/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2m/akka/downloads","issues_url":"https://api.github.com/repos/2m/akka/issues{/number}","pulls_url":"https://api.github.com/repos/2m/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/2m/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/2m/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2m/akka/labels{/name}","releases_url":"https://api.github.com/repos/2m/akka/releases{/id}","created_at":"2014-04-15T09:23:35Z","updated_at":"2015-02-04T11:32:40Z","pushed_at":"2015-04-21T09:01:33Z","git_url":"git://github.com/2m/akka.git","ssh_url":"git@github.com:2m/akka.git","clone_url":"https://github.com/2m/akka.git","svn_url":"https://github.com/2m/akka","homepage":"http://akka.io","size":159454,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"242e1b835de55eefad0b9164958ce55e23f218f1","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-04-21T09:30:12Z","pushed_at":"2015-04-21T10:36:31Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":247346,"stargazers_count":3839,"watchers_count":3839,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1097,"mirror_url":null,"open_issues_count":639,"forks":1097,"open_issues":639,"watchers":3839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17238"},"html":{"href":"https://github.com/akka/akka/pull/17238"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17238"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17238/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17238/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17238/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/01eb2b19ebc35a996061f619667cc082328cd5b9"}}}}