{"action":"closed","number":1596,"pull_request":{"url":"https://api.github.com/repos/metomi/rose/pulls/1596","id":33673198,"html_url":"https://github.com/metomi/rose/pull/1596","diff_url":"https://github.com/metomi/rose/pull/1596.diff","patch_url":"https://github.com/metomi/rose/pull/1596.patch","issue_url":"https://api.github.com/repos/metomi/rose/issues/1596","number":1596,"state":"closed","locked":false,"title":"rose test-battery: fix suite-hook smtp clash","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"body":"This fixes the clash between `03-mail.t` and `04-mail-bad.t`.\r\nThe `04-mail-bad.t` test now uses an entirely fake SMTP server\r\non a different set of possible ports.\r\n\r\nThe underlying problem was that `03-mail.t` had hardcoded itself\r\nto port 8025, which may explain the odd failures it had now and\r\nthen in past test battery runs.\r\n\r\n@matthewrmshin, please review.","created_at":"2015-04-20T14:54:38Z","updated_at":"2015-04-20T15:20:43Z","closed_at":"2015-04-20T15:20:42Z","merged_at":"2015-04-20T15:20:42Z","merge_commit_sha":"d886988c7fac0423b4840eda59670ff6cefc9372","assignee":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/metomi/rose/milestones/30","html_url":"https://github.com/metomi/rose/milestones/next-release","labels_url":"https://api.github.com/repos/metomi/rose/milestones/30/labels","id":1040829,"number":30,"title":"next-release","description":"Rose release 26.","creator":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":32,"state":"open","created_at":"2015-03-26T21:50:57Z","updated_at":"2015-04-20T15:20:42Z","due_on":"2015-04-29T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/metomi/rose/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/metomi/rose/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/metomi/rose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metomi/rose/issues/1596/comments","statuses_url":"https://api.github.com/repos/metomi/rose/statuses/5dd6a2b61cfcfac67818213188e43e68a8172ff6","head":{"label":"benfitzpatrick:test-battery.fix-suite-hook-smtp","ref":"test-battery.fix-suite-hook-smtp","sha":"5dd6a2b61cfcfac67818213188e43e68a8172ff6","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"repo":{"id":6224210,"name":"rose","full_name":"benfitzpatrick/rose","owner":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfitzpatrick/rose","description":"Rose is a framework for managing and running meteorological suites.","fork":true,"url":"https://api.github.com/repos/benfitzpatrick/rose","forks_url":"https://api.github.com/repos/benfitzpatrick/rose/forks","keys_url":"https://api.github.com/repos/benfitzpatrick/rose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfitzpatrick/rose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfitzpatrick/rose/teams","hooks_url":"https://api.github.com/repos/benfitzpatrick/rose/hooks","issue_events_url":"https://api.github.com/repos/benfitzpatrick/rose/issues/events{/number}","events_url":"https://api.github.com/repos/benfitzpatrick/rose/events","assignees_url":"https://api.github.com/repos/benfitzpatrick/rose/assignees{/user}","branches_url":"https://api.github.com/repos/benfitzpatrick/rose/branches{/branch}","tags_url":"https://api.github.com/repos/benfitzpatrick/rose/tags","blobs_url":"https://api.github.com/repos/benfitzpatrick/rose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfitzpatrick/rose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfitzpatrick/rose/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfitzpatrick/rose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfitzpatrick/rose/statuses/{sha}","languages_url":"https://api.github.com/repos/benfitzpatrick/rose/languages","stargazers_url":"https://api.github.com/repos/benfitzpatrick/rose/stargazers","contributors_url":"https://api.github.com/repos/benfitzpatrick/rose/contributors","subscribers_url":"https://api.github.com/repos/benfitzpatrick/rose/subscribers","subscription_url":"https://api.github.com/repos/benfitzpatrick/rose/subscription","commits_url":"https://api.github.com/repos/benfitzpatrick/rose/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfitzpatrick/rose/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfitzpatrick/rose/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfitzpatrick/rose/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfitzpatrick/rose/contents/{+path}","compare_url":"https://api.github.com/repos/benfitzpatrick/rose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfitzpatrick/rose/merges","archive_url":"https://api.github.com/repos/benfitzpatrick/rose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfitzpatrick/rose/downloads","issues_url":"https://api.github.com/repos/benfitzpatrick/rose/issues{/number}","pulls_url":"https://api.github.com/repos/benfitzpatrick/rose/pulls{/number}","milestones_url":"https://api.github.com/repos/benfitzpatrick/rose/milestones{/number}","notifications_url":"https://api.github.com/repos/benfitzpatrick/rose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfitzpatrick/rose/labels{/name}","releases_url":"https://api.github.com/repos/benfitzpatrick/rose/releases{/id}","created_at":"2012-10-15T09:01:10Z","updated_at":"2015-04-07T15:02:00Z","pushed_at":"2015-04-20T15:12:29Z","git_url":"git://github.com/benfitzpatrick/rose.git","ssh_url":"git@github.com:benfitzpatrick/rose.git","clone_url":"https://github.com/benfitzpatrick/rose.git","svn_url":"https://github.com/benfitzpatrick/rose","homepage":"benfitzpatrick.github.com/rose","size":17741,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metomi:master","ref":"master","sha":"a3ac852fad948f6b63c681e74b6d7f1b66f8dc48","user":{"login":"metomi","id":2477494,"avatar_url":"https://avatars.githubusercontent.com/u/2477494?v=3","gravatar_id":"","url":"https://api.github.com/users/metomi","html_url":"https://github.com/metomi","followers_url":"https://api.github.com/users/metomi/followers","following_url":"https://api.github.com/users/metomi/following{/other_user}","gists_url":"https://api.github.com/users/metomi/gists{/gist_id}","starred_url":"https://api.github.com/users/metomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metomi/subscriptions","organizations_url":"https://api.github.com/users/metomi/orgs","repos_url":"https://api.github.com/users/metomi/repos","events_url":"https://api.github.com/users/metomi/events{/privacy}","received_events_url":"https://api.github.com/users/metomi/received_events","type":"Organization","site_admin":false},"repo":{"id":6223866,"name":"rose","full_name":"metomi/rose","owner":{"login":"metomi","id":2477494,"avatar_url":"https://avatars.githubusercontent.com/u/2477494?v=3","gravatar_id":"","url":"https://api.github.com/users/metomi","html_url":"https://github.com/metomi","followers_url":"https://api.github.com/users/metomi/followers","following_url":"https://api.github.com/users/metomi/following{/other_user}","gists_url":"https://api.github.com/users/metomi/gists{/gist_id}","starred_url":"https://api.github.com/users/metomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metomi/subscriptions","organizations_url":"https://api.github.com/users/metomi/orgs","repos_url":"https://api.github.com/users/metomi/repos","events_url":"https://api.github.com/users/metomi/events{/privacy}","received_events_url":"https://api.github.com/users/metomi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metomi/rose","description":"Rose: a framework for managing and running meteorological suites.","fork":false,"url":"https://api.github.com/repos/metomi/rose","forks_url":"https://api.github.com/repos/metomi/rose/forks","keys_url":"https://api.github.com/repos/metomi/rose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metomi/rose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metomi/rose/teams","hooks_url":"https://api.github.com/repos/metomi/rose/hooks","issue_events_url":"https://api.github.com/repos/metomi/rose/issues/events{/number}","events_url":"https://api.github.com/repos/metomi/rose/events","assignees_url":"https://api.github.com/repos/metomi/rose/assignees{/user}","branches_url":"https://api.github.com/repos/metomi/rose/branches{/branch}","tags_url":"https://api.github.com/repos/metomi/rose/tags","blobs_url":"https://api.github.com/repos/metomi/rose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metomi/rose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metomi/rose/git/refs{/sha}","trees_url":"https://api.github.com/repos/metomi/rose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metomi/rose/statuses/{sha}","languages_url":"https://api.github.com/repos/metomi/rose/languages","stargazers_url":"https://api.github.com/repos/metomi/rose/stargazers","contributors_url":"https://api.github.com/repos/metomi/rose/contributors","subscribers_url":"https://api.github.com/repos/metomi/rose/subscribers","subscription_url":"https://api.github.com/repos/metomi/rose/subscription","commits_url":"https://api.github.com/repos/metomi/rose/commits{/sha}","git_commits_url":"https://api.github.com/repos/metomi/rose/git/commits{/sha}","comments_url":"https://api.github.com/repos/metomi/rose/comments{/number}","issue_comment_url":"https://api.github.com/repos/metomi/rose/issues/comments{/number}","contents_url":"https://api.github.com/repos/metomi/rose/contents/{+path}","compare_url":"https://api.github.com/repos/metomi/rose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metomi/rose/merges","archive_url":"https://api.github.com/repos/metomi/rose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metomi/rose/downloads","issues_url":"https://api.github.com/repos/metomi/rose/issues{/number}","pulls_url":"https://api.github.com/repos/metomi/rose/pulls{/number}","milestones_url":"https://api.github.com/repos/metomi/rose/milestones{/number}","notifications_url":"https://api.github.com/repos/metomi/rose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metomi/rose/labels{/name}","releases_url":"https://api.github.com/repos/metomi/rose/releases{/id}","created_at":"2012-10-15T08:31:10Z","updated_at":"2015-04-20T11:58:29Z","pushed_at":"2015-04-20T15:20:42Z","git_url":"git://github.com/metomi/rose.git","ssh_url":"git@github.com:metomi/rose.git","clone_url":"https://github.com/metomi/rose.git","svn_url":"https://github.com/metomi/rose","homepage":"metomi.github.io/rose/doc/","size":19863,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":143,"forks":18,"open_issues":143,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metomi/rose/pulls/1596"},"html":{"href":"https://github.com/metomi/rose/pull/1596"},"issue":{"href":"https://api.github.com/repos/metomi/rose/issues/1596"},"comments":{"href":"https://api.github.com/repos/metomi/rose/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/metomi/rose/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/metomi/rose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metomi/rose/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/metomi/rose/statuses/5dd6a2b61cfcfac67818213188e43e68a8172ff6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":3,"additions":68,"deletions":17,"changed_files":4}}