{"action":"created","issue":{"url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/124","labels_url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/124/comments","events_url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/124/events","html_url":"https://github.com/chef-cookbooks/omnibus/pull/124","id":109692867,"number":124,"title":"Publish to supermarket.chef.io during `delivered/deploy`","user":{"login":"schisamo","id":6164,"avatar_url":"https://avatars.githubusercontent.com/u/6164?v=3","gravatar_id":"","url":"https://api.github.com/users/schisamo","html_url":"https://github.com/schisamo","followers_url":"https://api.github.com/users/schisamo/followers","following_url":"https://api.github.com/users/schisamo/following{/other_user}","gists_url":"https://api.github.com/users/schisamo/gists{/gist_id}","starred_url":"https://api.github.com/users/schisamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schisamo/subscriptions","organizations_url":"https://api.github.com/users/schisamo/orgs","repos_url":"https://api.github.com/users/schisamo/repos","events_url":"https://api.github.com/users/schisamo/events{/privacy}","received_events_url":"https://api.github.com/users/schisamo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef-cookbooks/omnibus/labels/Delivery%20Change%20Created","name":"Delivery Change Created","color":"ededed"},{"url":"https://api.github.com/repos/chef-cookbooks/omnibus/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-04T17:34:41Z","updated_at":"2015-10-05T04:05:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/omnibus/pulls/124","html_url":"https://github.com/chef-cookbooks/omnibus/pull/124","diff_url":"https://github.com/chef-cookbooks/omnibus/pull/124.diff","patch_url":"https://github.com/chef-cookbooks/omnibus/pull/124.patch"},"body":"Per some internal discussion, we should publish a cookbook to an internal Supermarket instance at `build/publish` and publish to a public Supermarket instance when things are considered ‘delivered’!\r\n\r\nThis change is an experiment to test that theory, eventually this code should become part of delivery-truck proper (as a `delivery_supermarket` resource).\r\n\r\nThis is change/experiment is based on discussion between @seth, @cwebberOps, @oferrigni and I starting here:\r\nhttps://chefio.slack.com/archives/delivery-rfr/p1443898540000723\r\n\r\n/cc @chef-cookbooks/engineering-services\r\n"},"comment":{"url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/comments/145425177","html_url":"https://github.com/chef-cookbooks/omnibus/pull/124#issuecomment-145425177","issue_url":"https://api.github.com/repos/chef-cookbooks/omnibus/issues/124","id":145425177,"user":{"login":"afiune","id":5712253,"avatar_url":"https://avatars.githubusercontent.com/u/5712253?v=3","gravatar_id":"","url":"https://api.github.com/users/afiune","html_url":"https://github.com/afiune","followers_url":"https://api.github.com/users/afiune/followers","following_url":"https://api.github.com/users/afiune/following{/other_user}","gists_url":"https://api.github.com/users/afiune/gists{/gist_id}","starred_url":"https://api.github.com/users/afiune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afiune/subscriptions","organizations_url":"https://api.github.com/users/afiune/orgs","repos_url":"https://api.github.com/users/afiune/repos","events_url":"https://api.github.com/users/afiune/events{/privacy}","received_events_url":"https://api.github.com/users/afiune/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T04:05:22Z","updated_at":"2015-10-05T04:05:22Z","body":"The code LGTM I just have one more little comment around whether or not `knife-supermarket` gem is installed. I know this cookbook depends on **delivery-truck** that installs the gem in the `default.rb` but this only happens if the user sets in the config a supermarket server. Having said that I would recommend to add the installation in the internal `build-cookbook` on this project like:\r\n```\r\nchef_gem 'knife-supermarket' if delivery_environment.eql?('delivered')\r\n```"}}