{"action":"created","comment":{"url":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/27032692","id":27032692,"diff_hunk":"@@ -53,20 +59,24 @@\n      * Generate record library.\n      *\n      * @param logSchemaVersion the log schema version\n-     * @param logSchema the log schema\n+     * @param logSchema        the log schema\n      * @return the record structure library\n      * @throws Exception the exception\n      */\n     public static FileData generateRecordLibrary(int logSchemaVersion, String logSchema) throws Exception {\n-        Schema recordWrapperSchema = RecordWrapperSchemaGenerator.generateRecordWrapperSchema(logSchema);\n-        List<JavaDynamicBean> javaSources = JavaSdkGenerator.generateSchemaSources(recordWrapperSchema);\n+        final Schema recordWrapperSchema = RecordWrapperSchemaGenerator.generateRecordWrapperSchema(logSchema);\n+\n+        Map<String, Schema> uniqueSchemas = SchemaUtil.getUniqueSchemasMap(new LinkedList<Schema>() {{","path":"server/control/src/main/java/org/kaaproject/kaa/server/control/service/log/RecordLibraryGenerator.java","position":55,"original_position":55,"commit_id":"2b11064ba85939c8eae89405666ba3a846ce1380","original_commit_id":"2b11064ba85939c8eae89405666ba3a846ce1380","user":{"login":"ashvayka","id":5016373,"avatar_url":"https://avatars.githubusercontent.com/u/5016373?v=3","gravatar_id":"","url":"https://api.github.com/users/ashvayka","html_url":"https://github.com/ashvayka","followers_url":"https://api.github.com/users/ashvayka/followers","following_url":"https://api.github.com/users/ashvayka/following{/other_user}","gists_url":"https://api.github.com/users/ashvayka/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvayka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvayka/subscriptions","organizations_url":"https://api.github.com/users/ashvayka/orgs","repos_url":"https://api.github.com/users/ashvayka/repos","events_url":"https://api.github.com/users/ashvayka/events{/privacy}","received_events_url":"https://api.github.com/users/ashvayka/received_events","type":"User","site_admin":false},"body":"remove this syntax please. Also any modifications to this class are meaningless due to processing of single schema (log) here","created_at":"2015-03-24T14:33:06Z","updated_at":"2015-03-24T14:33:06Z","html_url":"https://github.com/kaaproject/kaa/pull/158#discussion_r27032692","pull_request_url":"https://api.github.com/repos/kaaproject/kaa/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/27032692"},"html":{"href":"https://github.com/kaaproject/kaa/pull/158#discussion_r27032692"},"pull_request":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/kaaproject/kaa/pulls/158","id":31823456,"html_url":"https://github.com/kaaproject/kaa/pull/158","diff_url":"https://github.com/kaaproject/kaa/pull/158.diff","patch_url":"https://github.com/kaaproject/kaa/pull/158.patch","issue_url":"https://api.github.com/repos/kaaproject/kaa/issues/158","number":158,"state":"open","locked":false,"title":"Sdk generator improvement","user":{"login":"serye","id":10329404,"avatar_url":"https://avatars.githubusercontent.com/u/10329404?v=3","gravatar_id":"","url":"https://api.github.com/users/serye","html_url":"https://github.com/serye","followers_url":"https://api.github.com/users/serye/followers","following_url":"https://api.github.com/users/serye/following{/other_user}","gists_url":"https://api.github.com/users/serye/gists{/gist_id}","starred_url":"https://api.github.com/users/serye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serye/subscriptions","organizations_url":"https://api.github.com/users/serye/orgs","repos_url":"https://api.github.com/users/serye/repos","events_url":"https://api.github.com/users/serye/events{/privacy}","received_events_url":"https://api.github.com/users/serye/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T12:58:57Z","updated_at":"2015-03-24T14:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab64e99efc39811be6408855bf95340279e618d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaaproject/kaa/pulls/158/commits","review_comments_url":"https://api.github.com/repos/kaaproject/kaa/pulls/158/comments","review_comment_url":"https://api.github.com/repos/kaaproject/kaa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaaproject/kaa/issues/158/comments","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/2b11064ba85939c8eae89405666ba3a846ce1380","head":{"label":"kaaproject:feature/sdk_generator_improvement","ref":"feature/sdk_generator_improvement","sha":"2b11064ba85939c8eae89405666ba3a846ce1380","user":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":17839346,"name":"kaa","full_name":"kaaproject/kaa","owner":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaaproject/kaa","description":"Kaa open-source middleware platform for building, managing, and integrating connected products with the Internet of Everything.","fork":false,"url":"https://api.github.com/repos/kaaproject/kaa","forks_url":"https://api.github.com/repos/kaaproject/kaa/forks","keys_url":"https://api.github.com/repos/kaaproject/kaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaaproject/kaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaaproject/kaa/teams","hooks_url":"https://api.github.com/repos/kaaproject/kaa/hooks","issue_events_url":"https://api.github.com/repos/kaaproject/kaa/issues/events{/number}","events_url":"https://api.github.com/repos/kaaproject/kaa/events","assignees_url":"https://api.github.com/repos/kaaproject/kaa/assignees{/user}","branches_url":"https://api.github.com/repos/kaaproject/kaa/branches{/branch}","tags_url":"https://api.github.com/repos/kaaproject/kaa/tags","blobs_url":"https://api.github.com/repos/kaaproject/kaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaaproject/kaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaaproject/kaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaaproject/kaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/{sha}","languages_url":"https://api.github.com/repos/kaaproject/kaa/languages","stargazers_url":"https://api.github.com/repos/kaaproject/kaa/stargazers","contributors_url":"https://api.github.com/repos/kaaproject/kaa/contributors","subscribers_url":"https://api.github.com/repos/kaaproject/kaa/subscribers","subscription_url":"https://api.github.com/repos/kaaproject/kaa/subscription","commits_url":"https://api.github.com/repos/kaaproject/kaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaaproject/kaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaaproject/kaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaaproject/kaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaaproject/kaa/contents/{+path}","compare_url":"https://api.github.com/repos/kaaproject/kaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaaproject/kaa/merges","archive_url":"https://api.github.com/repos/kaaproject/kaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaaproject/kaa/downloads","issues_url":"https://api.github.com/repos/kaaproject/kaa/issues{/number}","pulls_url":"https://api.github.com/repos/kaaproject/kaa/pulls{/number}","milestones_url":"https://api.github.com/repos/kaaproject/kaa/milestones{/number}","notifications_url":"https://api.github.com/repos/kaaproject/kaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaaproject/kaa/labels{/name}","releases_url":"https://api.github.com/repos/kaaproject/kaa/releases{/id}","created_at":"2014-03-17T18:48:31Z","updated_at":"2015-03-24T13:19:29Z","pushed_at":"2015-03-24T14:30:54Z","git_url":"git://github.com/kaaproject/kaa.git","ssh_url":"git@github.com:kaaproject/kaa.git","clone_url":"https://github.com/kaaproject/kaa.git","svn_url":"https://github.com/kaaproject/kaa","homepage":"http://www.kaaproject.org","size":85673,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":81,"default_branch":"master"}},"base":{"label":"kaaproject:master","ref":"master","sha":"7441b398a78cbfd73ecb80f7cc52a50babef2e88","user":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":17839346,"name":"kaa","full_name":"kaaproject/kaa","owner":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaaproject/kaa","description":"Kaa open-source middleware platform for building, managing, and integrating connected products with the Internet of Everything.","fork":false,"url":"https://api.github.com/repos/kaaproject/kaa","forks_url":"https://api.github.com/repos/kaaproject/kaa/forks","keys_url":"https://api.github.com/repos/kaaproject/kaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaaproject/kaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaaproject/kaa/teams","hooks_url":"https://api.github.com/repos/kaaproject/kaa/hooks","issue_events_url":"https://api.github.com/repos/kaaproject/kaa/issues/events{/number}","events_url":"https://api.github.com/repos/kaaproject/kaa/events","assignees_url":"https://api.github.com/repos/kaaproject/kaa/assignees{/user}","branches_url":"https://api.github.com/repos/kaaproject/kaa/branches{/branch}","tags_url":"https://api.github.com/repos/kaaproject/kaa/tags","blobs_url":"https://api.github.com/repos/kaaproject/kaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaaproject/kaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaaproject/kaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaaproject/kaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/{sha}","languages_url":"https://api.github.com/repos/kaaproject/kaa/languages","stargazers_url":"https://api.github.com/repos/kaaproject/kaa/stargazers","contributors_url":"https://api.github.com/repos/kaaproject/kaa/contributors","subscribers_url":"https://api.github.com/repos/kaaproject/kaa/subscribers","subscription_url":"https://api.github.com/repos/kaaproject/kaa/subscription","commits_url":"https://api.github.com/repos/kaaproject/kaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaaproject/kaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaaproject/kaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaaproject/kaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaaproject/kaa/contents/{+path}","compare_url":"https://api.github.com/repos/kaaproject/kaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaaproject/kaa/merges","archive_url":"https://api.github.com/repos/kaaproject/kaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaaproject/kaa/downloads","issues_url":"https://api.github.com/repos/kaaproject/kaa/issues{/number}","pulls_url":"https://api.github.com/repos/kaaproject/kaa/pulls{/number}","milestones_url":"https://api.github.com/repos/kaaproject/kaa/milestones{/number}","notifications_url":"https://api.github.com/repos/kaaproject/kaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaaproject/kaa/labels{/name}","releases_url":"https://api.github.com/repos/kaaproject/kaa/releases{/id}","created_at":"2014-03-17T18:48:31Z","updated_at":"2015-03-24T13:19:29Z","pushed_at":"2015-03-24T14:30:54Z","git_url":"git://github.com/kaaproject/kaa.git","ssh_url":"git@github.com:kaaproject/kaa.git","clone_url":"https://github.com/kaaproject/kaa.git","svn_url":"https://github.com/kaaproject/kaa","homepage":"http://www.kaaproject.org","size":85673,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/158"},"html":{"href":"https://github.com/kaaproject/kaa/pull/158"},"issue":{"href":"https://api.github.com/repos/kaaproject/kaa/issues/158"},"comments":{"href":"https://api.github.com/repos/kaaproject/kaa/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/kaaproject/kaa/statuses/2b11064ba85939c8eae89405666ba3a846ce1380"}}}}