{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/11391","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11391/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11391/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11391/events","html_url":"https://github.com/elastic/elasticsearch/issues/11391","id":81900389,"number":11391,"title":"REST Test blacklist should not use PathMatcher","user":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/adoptme","name":"adoptme","color":"207de5"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/low%20hanging%20fruit","name":"low hanging fruit","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/test","name":"test","color":"5319e7"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.1.0","name":"v2.1.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-28T12:10:44Z","updated_at":"2015-11-04T08:25:40Z","closed_at":null,"body":"Currently we use `PathMatcher` to perform matching on REST test names against a blacklist. This is an abuse of the the `PathMatcher` class since it is intended to be used with a `Path`, which is intended for file based operations as the javadocs state:\r\n> An object that may be used to locate a file in a file system.\r\n\r\nWhile it may work right now, there are always special cases at play like #11389, which makes this brittle. We should think about another way to do the matching for blacklists. At the same time, there is another issue which is that we specify the blacklist as a comma separated list, but we also have tests with a comma in their name so this is problematic. A workaround exists, which is to use a glob pattern but this can blacklist more tests than necessary."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/153633083","html_url":"https://github.com/elastic/elasticsearch/issues/11391#issuecomment-153633083","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11391","id":153633083,"user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T08:25:40Z","updated_at":"2015-11-04T08:25:40Z","body":"Just a quick update: After some discussion with different developers, we've decided to check with @jaymode when he's back again. I'll assign myself for now."}}