{"action":"created","comment":{"url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/comments/27658879","id":27658879,"diff_hunk":"@@ -80,14 +80,18 @@ describe('JWT auth client', function() {\n       assert.deepEqual(['http://bar', 'http://foo'], opts.scope);\n       assert.equal('bar@subjectaccount.com', opts.sub);\n       return {\n+        key: 'private-key-data',\n+        iss: 'foo@subjectaccount.com',\n         getToken: function(opt_callback) {\n           opt_callback(null, 'initial-access-token');\n-        }\n+        },","path":"test/test.jwt.js","position":null,"original_position":9,"commit_id":"3bc52967047f94a8e565b14fbac4f09ea51668ab","original_commit_id":"1f089423316d195eb812f7a2e4c37df3499d9606","user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"body":"Of course!","created_at":"2015-04-02T13:59:49Z","updated_at":"2015-04-02T13:59:49Z","html_url":"https://github.com/google/google-auth-library-nodejs/pull/23#discussion_r27658879","pull_request_url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/comments/27658879"},"html":{"href":"https://github.com/google/google-auth-library-nodejs/pull/23#discussion_r27658879"},"pull_request":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23","id":32263862,"html_url":"https://github.com/google/google-auth-library-nodejs/pull/23","diff_url":"https://github.com/google/google-auth-library-nodejs/pull/23.diff","patch_url":"https://github.com/google/google-auth-library-nodejs/pull/23.patch","issue_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/23","number":23,"state":"open","locked":false,"title":"update instance email & key properties from gToken","user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"body":"When given a path to a keyfile, gtoken will update its own instance with the extracted email & key data after parsing it from the file. These values are useful to expose to users, as an example, for when [trying to create a signed URL for Storage access](https://github.com/stephenplusplus/gcloud-node/blob/spp--auth/lib/storage/file.js#L774-789).\r\n\r\nPing @ryanseys to see if this is a reliable way to get these values.","created_at":"2015-03-30T20:27:30Z","updated_at":"2015-04-02T13:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df3f924ce0cf39ea537c904b02f12f7062cc42af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23/commits","review_comments_url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23/comments","review_comment_url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/23/comments","statuses_url":"https://api.github.com/repos/google/google-auth-library-nodejs/statuses/3bc52967047f94a8e565b14fbac4f09ea51668ab","head":{"label":"stephenplusplus:master","ref":"master","sha":"3bc52967047f94a8e565b14fbac4f09ea51668ab","user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"repo":{"id":32810060,"name":"google-auth-library-nodejs","full_name":"stephenplusplus/google-auth-library-nodejs","owner":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenplusplus/google-auth-library-nodejs","description":"Google Auth Library for Node.js","fork":true,"url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs","forks_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/forks","keys_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/teams","hooks_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/hooks","issue_events_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/events","assignees_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/tags","blobs_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/languages","stargazers_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/stargazers","contributors_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/contributors","subscribers_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/subscribers","subscription_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/subscription","commits_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/merges","archive_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/downloads","issues_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/stephenplusplus/google-auth-library-nodejs/releases{/id}","created_at":"2015-03-24T16:15:27Z","updated_at":"2015-04-02T13:59:41Z","pushed_at":"2015-04-02T13:59:41Z","git_url":"git://github.com/stephenplusplus/google-auth-library-nodejs.git","ssh_url":"git@github.com:stephenplusplus/google-auth-library-nodejs.git","clone_url":"https://github.com/stephenplusplus/google-auth-library-nodejs.git","svn_url":"https://github.com/stephenplusplus/google-auth-library-nodejs","homepage":"","size":188,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"3315596fdc7ed586ecbef1bde2e2bf7aa240fe09","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":30676220,"name":"google-auth-library-nodejs","full_name":"google/google-auth-library-nodejs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/google-auth-library-nodejs","description":"Google Auth Library for Node.js","fork":false,"url":"https://api.github.com/repos/google/google-auth-library-nodejs","forks_url":"https://api.github.com/repos/google/google-auth-library-nodejs/forks","keys_url":"https://api.github.com/repos/google/google-auth-library-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/google-auth-library-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/google-auth-library-nodejs/teams","hooks_url":"https://api.github.com/repos/google/google-auth-library-nodejs/hooks","issue_events_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/google/google-auth-library-nodejs/events","assignees_url":"https://api.github.com/repos/google/google-auth-library-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/google/google-auth-library-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/google/google-auth-library-nodejs/tags","blobs_url":"https://api.github.com/repos/google/google-auth-library-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/google-auth-library-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/google-auth-library-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/google-auth-library-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/google-auth-library-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/google-auth-library-nodejs/languages","stargazers_url":"https://api.github.com/repos/google/google-auth-library-nodejs/stargazers","contributors_url":"https://api.github.com/repos/google/google-auth-library-nodejs/contributors","subscribers_url":"https://api.github.com/repos/google/google-auth-library-nodejs/subscribers","subscription_url":"https://api.github.com/repos/google/google-auth-library-nodejs/subscription","commits_url":"https://api.github.com/repos/google/google-auth-library-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/google-auth-library-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/google-auth-library-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/google-auth-library-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/google/google-auth-library-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/google-auth-library-nodejs/merges","archive_url":"https://api.github.com/repos/google/google-auth-library-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/google-auth-library-nodejs/downloads","issues_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/google-auth-library-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/google-auth-library-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/google-auth-library-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/google/google-auth-library-nodejs/releases{/id}","created_at":"2015-02-11T23:52:54Z","updated_at":"2015-03-30T20:44:01Z","pushed_at":"2015-04-02T13:59:41Z","git_url":"git://github.com/google/google-auth-library-nodejs.git","ssh_url":"git@github.com:google/google-auth-library-nodejs.git","clone_url":"https://github.com/google/google-auth-library-nodejs.git","svn_url":"https://github.com/google/google-auth-library-nodejs","homepage":"","size":439,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23"},"html":{"href":"https://github.com/google/google-auth-library-nodejs/pull/23"},"issue":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/23"},"comments":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/google/google-auth-library-nodejs/statuses/3bc52967047f94a8e565b14fbac4f09ea51668ab"}}}}