{"action":"created","issue":{"url":"https://api.github.com/repos/cesanta/v7/issues/511","labels_url":"https://api.github.com/repos/cesanta/v7/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/cesanta/v7/issues/511/comments","events_url":"https://api.github.com/repos/cesanta/v7/issues/511/events","html_url":"https://github.com/cesanta/v7/pull/511","id":112124964,"number":511,"title":"Fixes issue #217: there was a bug in to_str() with function declarations","user":{"login":"dimonomid","id":1329932,"avatar_url":"https://avatars.githubusercontent.com/u/1329932?v=3","gravatar_id":"","url":"https://api.github.com/users/dimonomid","html_url":"https://github.com/dimonomid","followers_url":"https://api.github.com/users/dimonomid/followers","following_url":"https://api.github.com/users/dimonomid/following{/other_user}","gists_url":"https://api.github.com/users/dimonomid/gists{/gist_id}","starred_url":"https://api.github.com/users/dimonomid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimonomid/subscriptions","organizations_url":"https://api.github.com/users/dimonomid/orgs","repos_url":"https://api.github.com/users/dimonomid/repos","events_url":"https://api.github.com/users/dimonomid/events{/privacy}","received_events_url":"https://api.github.com/users/dimonomid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mmikulicic","id":52673,"avatar_url":"https://avatars.githubusercontent.com/u/52673?v=3","gravatar_id":"","url":"https://api.github.com/users/mmikulicic","html_url":"https://github.com/mmikulicic","followers_url":"https://api.github.com/users/mmikulicic/followers","following_url":"https://api.github.com/users/mmikulicic/following{/other_user}","gists_url":"https://api.github.com/users/mmikulicic/gists{/gist_id}","starred_url":"https://api.github.com/users/mmikulicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmikulicic/subscriptions","organizations_url":"https://api.github.com/users/mmikulicic/orgs","repos_url":"https://api.github.com/users/mmikulicic/repos","events_url":"https://api.github.com/users/mmikulicic/events{/privacy}","received_events_url":"https://api.github.com/users/mmikulicic/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-19T11:22:16Z","updated_at":"2015-10-19T13:23:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cesanta/v7/pulls/511","html_url":"https://github.com/cesanta/v7/pull/511","diff_url":"https://github.com/cesanta/v7/pull/511.diff","patch_url":"https://github.com/cesanta/v7/pull/511.patch"},"body":"`to_str()` wasn't expecting anything but `VAR_DECL`, although there might as well be a `FUNC_DECL`. Resolves issue #217.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cesanta/v7/511)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cesanta/v7/issues/comments/149211851","html_url":"https://github.com/cesanta/v7/pull/511#issuecomment-149211851","issue_url":"https://api.github.com/repos/cesanta/v7/issues/511","id":149211851,"user":{"login":"mmikulicic","id":52673,"avatar_url":"https://avatars.githubusercontent.com/u/52673?v=3","gravatar_id":"","url":"https://api.github.com/users/mmikulicic","html_url":"https://github.com/mmikulicic","followers_url":"https://api.github.com/users/mmikulicic/followers","following_url":"https://api.github.com/users/mmikulicic/following{/other_user}","gists_url":"https://api.github.com/users/mmikulicic/gists{/gist_id}","starred_url":"https://api.github.com/users/mmikulicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmikulicic/subscriptions","organizations_url":"https://api.github.com/users/mmikulicic/orgs","repos_url":"https://api.github.com/users/mmikulicic/repos","events_url":"https://api.github.com/users/mmikulicic/events{/privacy}","received_events_url":"https://api.github.com/users/mmikulicic/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T13:23:02Z","updated_at":"2015-10-19T13:23:02Z","body":"Hi! \n\nLooks good, good catch. Comments inline. Please amend and force push your branch when addressing the review comments.\n<!-- Reviewable comment -K1-FkMtzzpTcG7yUe3U:-389587094 -->\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n<sup>**[v7.c, line 8112 \\[r1\\]](https://reviewable.io:443/reviews/cesanta/v7/511#-K1-FYCkKGa4i-W2Wvsc)** ([raw file](https://github.com/cesanta/v7/blob/6cb0bcf57388d8d3a00d57f0bc0439f20077b8ca/v7.c#L8112)):</sup>\nlet's avoid the block and the var shadowing.\n\n```\nenum ast_tag vtag = ast_fetch_tag(a, &var);\n...\n```\n<!-- Reviewable comment -K1-FYCkKGa4i-W2Wvsd:2079727363 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cesanta/v7/511)\n<!-- Sent from Reviewable.io -->\n"}}