{"action":"created","issue":{"url":"https://api.github.com/repos/redding/mr/issues/228","labels_url":"https://api.github.com/repos/redding/mr/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/redding/mr/issues/228/comments","events_url":"https://api.github.com/repos/redding/mr/issues/228/events","html_url":"https://github.com/redding/mr/pull/228","id":119579749,"number":228,"title":"Update Record Factory to use `sql_type` if `type` is missing","user":{"login":"Criptak","id":2130355,"avatar_url":"https://avatars.githubusercontent.com/u/2130355?v=3","gravatar_id":"","url":"https://api.github.com/users/Criptak","html_url":"https://github.com/Criptak","followers_url":"https://api.github.com/users/Criptak/followers","following_url":"https://api.github.com/users/Criptak/following{/other_user}","gists_url":"https://api.github.com/users/Criptak/gists{/gist_id}","starred_url":"https://api.github.com/users/Criptak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Criptak/subscriptions","organizations_url":"https://api.github.com/users/Criptak/orgs","repos_url":"https://api.github.com/users/Criptak/repos","events_url":"https://api.github.com/users/Criptak/events{/privacy}","received_events_url":"https://api.github.com/users/Criptak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-30T20:59:24Z","updated_at":"2015-12-01T16:51:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redding/mr/pulls/228","html_url":"https://github.com/redding/mr/pull/228","diff_url":"https://github.com/redding/mr/pull/228.diff","patch_url":"https://github.com/redding/mr/pull/228.patch"},"body":"This updates the Record Factory to use the ActiveRecord Column's\r\n`sql_type` if `type` is missing/nil.  This makes MR more flexible in\r\nwhich columns can be used.  If you are using a field in the database\r\nthat isn't support by ActiveRecord (i.e. `json` or `jsonb` for\r\nActiveRecord earlier than version 4), you can define a factory that\r\nmatches the `sql_type` and still use the factory.  This also updates\r\nthe factory to avoid setting any fields that are not supported.  This\r\nis the least surprising behavior as it does not force the end user\r\nto define every column type that is used, just those that are important\r\nenough to generate data for."},"comment":{"url":"https://api.github.com/repos/redding/mr/issues/comments/161028704","html_url":"https://github.com/redding/mr/pull/228#issuecomment-161028704","issue_url":"https://api.github.com/repos/redding/mr/issues/228","id":161028704,"user":{"login":"Criptak","id":2130355,"avatar_url":"https://avatars.githubusercontent.com/u/2130355?v=3","gravatar_id":"","url":"https://api.github.com/users/Criptak","html_url":"https://github.com/Criptak","followers_url":"https://api.github.com/users/Criptak/followers","following_url":"https://api.github.com/users/Criptak/following{/other_user}","gists_url":"https://api.github.com/users/Criptak/gists{/gist_id}","starred_url":"https://api.github.com/users/Criptak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Criptak/subscriptions","organizations_url":"https://api.github.com/users/Criptak/orgs","repos_url":"https://api.github.com/users/Criptak/repos","events_url":"https://api.github.com/users/Criptak/events{/privacy}","received_events_url":"https://api.github.com/users/Criptak/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T16:51:11Z","updated_at":"2015-12-01T16:51:11Z","body":"@kellyredding @jcredding updated with @jcredding's comments"}}