{"action":"created","comment":{"url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments/47203842","id":47203842,"diff_hunk":"@@ -995,6 +996,9 @@ std::vector<DeprecatedOptionMap> kDeprecatedOptionNameList(\n     kDeprecatedOptionNameData + arraysize(kDeprecatedOptionNameData)\n );\n \n+int kNonAddableResourceHeadersSize = 12;\n+StringPieceVector kNonAddableResourceHeaders(kNonAddableResourceHeadersSize);","path":"net/instaweb/rewriter/rewrite_options.cc","position":null,"original_position":13,"commit_id":"594b6f7d692e706d78c8a59e165d9ffc9814ed78","original_commit_id":"f7a621c0bb8eacacd67f69fdb01e214ef881cf70","user":{"login":"oschaaf","id":2239556,"avatar_url":"https://avatars.githubusercontent.com/u/2239556?v=3","gravatar_id":"","url":"https://api.github.com/users/oschaaf","html_url":"https://github.com/oschaaf","followers_url":"https://api.github.com/users/oschaaf/followers","following_url":"https://api.github.com/users/oschaaf/following{/other_user}","gists_url":"https://api.github.com/users/oschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/oschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oschaaf/subscriptions","organizations_url":"https://api.github.com/users/oschaaf/orgs","repos_url":"https://api.github.com/users/oschaaf/repos","events_url":"https://api.github.com/users/oschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/oschaaf/received_events","type":"User","site_admin":false},"body":"@jmarantz Out of curiosity, is kDeprecatedOptionNameList (declared one line above) valid according to the style guide? That line was why I thought that what I had initially was OK.","created_at":"2015-12-10T09:22:24Z","updated_at":"2015-12-10T09:22:24Z","html_url":"https://github.com/pagespeed/mod_pagespeed/pull/1200#discussion_r47203842","pull_request_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200","_links":{"self":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments/47203842"},"html":{"href":"https://github.com/pagespeed/mod_pagespeed/pull/1200#discussion_r47203842"},"pull_request":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200"}}},"pull_request":{"url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200","id":52951961,"html_url":"https://github.com/pagespeed/mod_pagespeed/pull/1200","diff_url":"https://github.com/pagespeed/mod_pagespeed/pull/1200.diff","patch_url":"https://github.com/pagespeed/mod_pagespeed/pull/1200.patch","issue_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1200","number":1200,"state":"open","locked":false,"title":"New option: AddResourceHeader","user":{"login":"oschaaf","id":2239556,"avatar_url":"https://avatars.githubusercontent.com/u/2239556?v=3","gravatar_id":"","url":"https://api.github.com/users/oschaaf","html_url":"https://github.com/oschaaf","followers_url":"https://api.github.com/users/oschaaf/followers","following_url":"https://api.github.com/users/oschaaf/following{/other_user}","gists_url":"https://api.github.com/users/oschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/oschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oschaaf/subscriptions","organizations_url":"https://api.github.com/users/oschaaf/orgs","repos_url":"https://api.github.com/users/oschaaf/repos","events_url":"https://api.github.com/users/oschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/oschaaf/received_events","type":"User","site_admin":false},"body":"Allows setting headers on PageSpeed resources for CORS support.\r\n\r\nFixes https://github.com/pagespeed/ngx_pagespeed/issues/1005","created_at":"2015-12-08T08:39:25Z","updated_at":"2015-12-10T09:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22c6175492efea43a333a15f6290f2fd645b7275","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200/commits","review_comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200/comments","review_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1200/comments","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/594b6f7d692e706d78c8a59e165d9ffc9814ed78","head":{"label":"pagespeed:oschaaf-master-add-resource-header","ref":"oschaaf-master-add-resource-header","sha":"594b6f7d692e706d78c8a59e165d9ffc9814ed78","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":33489346,"name":"mod_pagespeed","full_name":"pagespeed/mod_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/mod_pagespeed","description":"Apache module for rewriting web pages to reduce latency and bandwidth.","fork":false,"url":"https://api.github.com/repos/pagespeed/mod_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/releases{/id}","created_at":"2015-04-06T15:31:46Z","updated_at":"2015-12-08T09:45:19Z","pushed_at":"2015-12-09T22:26:03Z","git_url":"git://github.com/pagespeed/mod_pagespeed.git","ssh_url":"git@github.com:pagespeed/mod_pagespeed.git","clone_url":"https://github.com/pagespeed/mod_pagespeed.git","svn_url":"https://github.com/pagespeed/mod_pagespeed","homepage":"http://modpagespeed.com","size":39259,"stargazers_count":152,"watchers_count":152,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":287,"forks":24,"open_issues":287,"watchers":152,"default_branch":"master"}},"base":{"label":"pagespeed:master","ref":"master","sha":"d5cb1d214717519969efd118b5847e6100739266","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":33489346,"name":"mod_pagespeed","full_name":"pagespeed/mod_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/mod_pagespeed","description":"Apache module for rewriting web pages to reduce latency and bandwidth.","fork":false,"url":"https://api.github.com/repos/pagespeed/mod_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/releases{/id}","created_at":"2015-04-06T15:31:46Z","updated_at":"2015-12-08T09:45:19Z","pushed_at":"2015-12-09T22:26:03Z","git_url":"git://github.com/pagespeed/mod_pagespeed.git","ssh_url":"git@github.com:pagespeed/mod_pagespeed.git","clone_url":"https://github.com/pagespeed/mod_pagespeed.git","svn_url":"https://github.com/pagespeed/mod_pagespeed","homepage":"http://modpagespeed.com","size":39259,"stargazers_count":152,"watchers_count":152,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":287,"forks":24,"open_issues":287,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200"},"html":{"href":"https://github.com/pagespeed/mod_pagespeed/pull/1200"},"issue":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1200"},"comments":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1200/comments"},"review_comments":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200/comments"},"review_comment":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1200/commits"},"statuses":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/594b6f7d692e706d78c8a59e165d9ffc9814ed78"}}}}