{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments/32400476","id":32400476,"diff_hunk":"@@ -0,0 +1,61 @@\n+class RspecDocker","path":"spec/integration/docker_rspec_helper.rb","position":1,"original_position":1,"commit_id":"6b8aec92f43269dc2c258d5f4576ef19ec25c907","original_commit_id":"6b8aec92f43269dc2c258d5f4576ef19ec25c907","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"I would rather name this as ```DockerHelper```, as this class is independent of the specs and is in reality helping setup and manage docker.\r\n\r\nOn the other side, I tend to see helpers living in their own directory, but this is mostly an organizational taste of mine, what do you think?","created_at":"2015-06-15T08:41:54Z","updated_at":"2015-06-15T08:41:54Z","html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151#discussion_r32400476","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments/32400476"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151#discussion_r32400476"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151","id":35768654,"html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151","diff_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/151","number":151,"state":"open","locked":false,"title":"[WIP] parameterize and split ES spec tests into integration and unit tests split up by specific feature tests","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"Currently, it is rather difficult to maintain the ever-growing\r\nelasticsearch spec file. This Commit is an inital refactor of\r\nthe spec and splits out some of the specs into their own files,\r\nand separates integration tests from unit tests. Uses Docker to\r\nmanage external Elasticsearch instance and fetches host/port \r\ninfo from docker for the specific ES instance. Node Protocol is \r\nnot currently supported.\r\n\r\nCloses https://github.com/logstash-plugins/logstash-output-elasticsearch/issues/111.","created_at":"2015-05-19T20:00:31Z","updated_at":"2015-06-15T08:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de5dbb59b98944e94180314ecc0a248a4779c814","assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/151/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/6b8aec92f43269dc2c258d5f4576ef19ec25c907","head":{"label":"talevy:parameterize-es","ref":"parameterize-es","sha":"6b8aec92f43269dc2c258d5f4576ef19ec25c907","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"repo":{"id":26024509,"name":"logstash-output-elasticsearch","full_name":"talevy/logstash-output-elasticsearch","owner":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talevy/logstash-output-elasticsearch","description":null,"fork":true,"url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch","forks_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/forks","keys_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/teams","hooks_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/events","assignees_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/tags","blobs_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/subscription","commits_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/merges","archive_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/downloads","issues_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/talevy/logstash-output-elasticsearch/releases{/id}","created_at":"2014-10-31T16:42:29Z","updated_at":"2015-05-05T17:37:44Z","pushed_at":"2015-06-12T18:55:52Z","git_url":"git://github.com/talevy/logstash-output-elasticsearch.git","ssh_url":"git@github.com:talevy/logstash-output-elasticsearch.git","clone_url":"https://github.com/talevy/logstash-output-elasticsearch.git","svn_url":"https://github.com/talevy/logstash-output-elasticsearch","homepage":null,"size":29636,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"74fbf07b2638260ddffcb930d7d11c9bf7116947","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25476601,"name":"logstash-output-elasticsearch","full_name":"logstash-plugins/logstash-output-elasticsearch","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/releases{/id}","created_at":"2014-10-20T16:56:37Z","updated_at":"2015-06-08T08:30:51Z","pushed_at":"2015-06-13T10:05:28Z","git_url":"git://github.com/logstash-plugins/logstash-output-elasticsearch.git","ssh_url":"git@github.com:logstash-plugins/logstash-output-elasticsearch.git","clone_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch.git","svn_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch","homepage":null,"size":29959,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":64,"forks":35,"open_issues":64,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/151"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/151"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/6b8aec92f43269dc2c258d5f4576ef19ec25c907"}}}}