{"action":"created","issue":{"url":"https://api.github.com/repos/sneumann/xcms/issues/8","labels_url":"https://api.github.com/repos/sneumann/xcms/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/sneumann/xcms/issues/8/comments","events_url":"https://api.github.com/repos/sneumann/xcms/issues/8/events","html_url":"https://github.com/sneumann/xcms/pull/8","id":56279671,"number":8,"title":"Bug/split","user":{"login":"nathanielguy","id":1205677,"avatar_url":"https://avatars.githubusercontent.com/u/1205677?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielguy","html_url":"https://github.com/nathanielguy","followers_url":"https://api.github.com/users/nathanielguy/followers","following_url":"https://api.github.com/users/nathanielguy/following{/other_user}","gists_url":"https://api.github.com/users/nathanielguy/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielguy/subscriptions","organizations_url":"https://api.github.com/users/nathanielguy/orgs","repos_url":"https://api.github.com/users/nathanielguy/repos","events_url":"https://api.github.com/users/nathanielguy/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-02T19:15:19Z","updated_at":"2015-02-02T21:43:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sneumann/xcms/pulls/8","html_url":"https://github.com/sneumann/xcms/pull/8","diff_url":"https://github.com/sneumann/xcms/pull/8.diff","patch_url":"https://github.com/sneumann/xcms/pull/8.patch"},"body":"split.xcmsSet in master doesn't work (Peaks are lost, wrong phenodata is copied).  Here is a fix that works as expected.\r\n\r\nFirst pull request and I don't know if I followed all your conventions so someone should check this over."},"comment":{"url":"https://api.github.com/repos/sneumann/xcms/issues/comments/72544153","html_url":"https://github.com/sneumann/xcms/pull/8#issuecomment-72544153","issue_url":"https://api.github.com/repos/sneumann/xcms/issues/8","id":72544153,"user":{"login":"nathanielguy","id":1205677,"avatar_url":"https://avatars.githubusercontent.com/u/1205677?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielguy","html_url":"https://github.com/nathanielguy","followers_url":"https://api.github.com/users/nathanielguy/followers","following_url":"https://api.github.com/users/nathanielguy/following{/other_user}","gists_url":"https://api.github.com/users/nathanielguy/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielguy/subscriptions","organizations_url":"https://api.github.com/users/nathanielguy/orgs","repos_url":"https://api.github.com/users/nathanielguy/repos","events_url":"https://api.github.com/users/nathanielguy/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielguy/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T21:43:16Z","updated_at":"2015-02-02T21:43:16Z","body":"I was mistaken about the form of f and as such my pull request is not a drop in replacement and should not be merged.\r\n\r\nI need to revise this pull request or replace it with another.  This issue is:  Output of split.xcmsSet is nonsensical when length(f) < nrow(x@phenodata).\r\n\r\nI will submit a second pull request which raises an error when length(f) != nrow(x@phenodata).\r\n\r\nSorry for the clutter."}}