{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/27127876","id":27127876,"diff_hunk":"@@ -39,8 +39,9 @@ THE SOFTWARE.\n       <j:if test=\"${!c.acceptingTasks}\"> <st:nbsp/> (${%suspended})</j:if>\n     </d:tag>\n     <d:tag name=\"executor\">\n+      <j:set var=\"ae\" value=\"${e.asynchronousExecution}\"/>","path":"core/src/main/resources/lib/hudson/executors.jelly","position":4,"original_position":4,"commit_id":"b106ae347f2c7ac1db6d3bea516263b43d76815e","original_commit_id":"b106ae347f2c7ac1db6d3bea516263b43d76815e","user":{"login":"stephenc","id":209336,"avatar_url":"https://avatars.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"body":"revisit against race conditions after #1596 is merged","created_at":"2015-03-25T14:54:22Z","updated_at":"2015-03-25T14:54:22Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1610#discussion_r27127876","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/27127876"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1610#discussion_r27127876"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610","id":31566646,"html_url":"https://github.com/jenkinsci/jenkins/pull/1610","diff_url":"https://github.com/jenkinsci/jenkins/pull/1610.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1610.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1610","number":1610,"state":"open","locked":false,"title":"API improvements around Executor/Executable","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"See https://github.com/jenkinsci/workflow-plugin/pull/95 for main use cases.\r\n\r\n- [X] [JENKINS-26090](https://issues.jenkins-ci.org/browse/JENKINS-26090): `Executables.getExecutor`\r\n- ~~[JENKINS-26092](https://issues.jenkins-ci.org/browse/JENKINS-26092): `executors.jelly` interface underspecified~~\r\n- [x] [JENKINS-25938](https://issues.jenkins-ci.org/browse/JENKINS-25938): lock an `Executor` without creating a `Thread`\r\n- [x] [JENKINS-22941](https://issues.jenkins-ci.org/browse/JENKINS-22941): way to mark an `Executable` that should not block `isReadyToRestart`\r\n- [x] [JENKINS-26900](https://issues.jenkins-ci.org/browse/JENKINS-26900): hide flyweight master executor when ≥1 heavyweight executors running as subtasks\r\n\r\n@reviewbybees","created_at":"2015-03-19T21:11:23Z","updated_at":"2015-03-25T14:54:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f6f6b9957f2ff8322f79857a12e2e56921c16f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1610/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/b106ae347f2c7ac1db6d3bea516263b43d76815e","head":{"label":"jglick:Executable-JENKINS-25938","ref":"Executable-JENKINS-25938","sha":"b106ae347f2c7ac1db6d3bea516263b43d76815e","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":4914128,"name":"jenkins","full_name":"jglick/jenkins","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jglick/jenkins","forks_url":"https://api.github.com/repos/jglick/jenkins/forks","keys_url":"https://api.github.com/repos/jglick/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/jenkins/teams","hooks_url":"https://api.github.com/repos/jglick/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jglick/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/jenkins/events","assignees_url":"https://api.github.com/repos/jglick/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/jenkins/tags","blobs_url":"https://api.github.com/repos/jglick/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/jenkins/languages","stargazers_url":"https://api.github.com/repos/jglick/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jglick/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jglick/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jglick/jenkins/subscription","commits_url":"https://api.github.com/repos/jglick/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/jenkins/merges","archive_url":"https://api.github.com/repos/jglick/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/jenkins/downloads","issues_url":"https://api.github.com/repos/jglick/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jglick/jenkins/releases{/id}","created_at":"2012-07-05T19:53:26Z","updated_at":"2015-02-22T21:27:52Z","pushed_at":"2015-03-24T21:40:08Z","git_url":"git://github.com/jglick/jenkins.git","ssh_url":"git@github.com:jglick/jenkins.git","clone_url":"https://github.com/jglick/jenkins.git","svn_url":"https://github.com/jglick/jenkins","homepage":"http://jenkins-ci.org/","size":82790,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"a6cd99f2107e9dc197641a8f266089f4619c3693","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-03-25T12:40:09Z","pushed_at":"2015-03-25T14:25:17Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":400281,"stargazers_count":3838,"watchers_count":3838,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1733,"mirror_url":null,"open_issues_count":114,"forks":1733,"open_issues":114,"watchers":3838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1610"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1610"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1610/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1610/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/b106ae347f2c7ac1db6d3bea516263b43d76815e"}}}}