{"action":"created","comment":{"url":"https://api.github.com/repos/mesos/chronos/pulls/comments/31641642","id":31641642,"diff_hunk":"@@ -1,27 +1,39 @@\n #!/bin/bash\n-set -o errexit -o nounset -o pipefail\n+set -o errexit -o pipefail\n \n-chronos_home=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && cd .. && pwd -P )\"\n-echo \"Chronos home set to $chronos_home\"\n-export JAVA_LIBRARY_PATH=\"/usr/local/lib:/lib:/usr/lib\"\n-export LD_LIBRARY_PATH=\"${LD_LIBRARY_PATH:-/lib}\"\n-export LD_LIBRARY_PATH=\"$JAVA_LIBRARY_PATH:$LD_LIBRARY_PATH\"","path":"bin/start-chronos.bash","position":8,"original_position":9,"commit_id":"83ee2615e676ca0447b0cafe0b78c50347bf0611","original_commit_id":"2e2ef669c9da5c23878ad1cc4a6822c82554891f","user":{"login":"elingg","id":8423887,"avatar_url":"https://avatars.githubusercontent.com/u/8423887?v=3","gravatar_id":"","url":"https://api.github.com/users/elingg","html_url":"https://github.com/elingg","followers_url":"https://api.github.com/users/elingg/followers","following_url":"https://api.github.com/users/elingg/following{/other_user}","gists_url":"https://api.github.com/users/elingg/gists{/gist_id}","starred_url":"https://api.github.com/users/elingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elingg/subscriptions","organizations_url":"https://api.github.com/users/elingg/orgs","repos_url":"https://api.github.com/users/elingg/repos","events_url":"https://api.github.com/users/elingg/events{/privacy}","received_events_url":"https://api.github.com/users/elingg/received_events","type":"User","site_admin":false},"body":"yep, I want to use that safeguard in all cases if possible (not just if we enter the if statement). Your fix looks good to me!","created_at":"2015-06-03T16:28:09Z","updated_at":"2015-06-03T16:28:09Z","html_url":"https://github.com/mesos/chronos/pull/456#discussion_r31641642","pull_request_url":"https://api.github.com/repos/mesos/chronos/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/mesos/chronos/pulls/comments/31641642"},"html":{"href":"https://github.com/mesos/chronos/pull/456#discussion_r31641642"},"pull_request":{"href":"https://api.github.com/repos/mesos/chronos/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/mesos/chronos/pulls/456","id":35847905,"html_url":"https://github.com/mesos/chronos/pull/456","diff_url":"https://github.com/mesos/chronos/pull/456.diff","patch_url":"https://github.com/mesos/chronos/pull/456.patch","issue_url":"https://api.github.com/repos/mesos/chronos/issues/456","number":456,"state":"open","locked":false,"title":"DOCKER: better entrypoint","user":{"login":"anapsix","id":1256199,"avatar_url":"https://avatars.githubusercontent.com/u/1256199?v=3","gravatar_id":"","url":"https://api.github.com/users/anapsix","html_url":"https://github.com/anapsix","followers_url":"https://api.github.com/users/anapsix/followers","following_url":"https://api.github.com/users/anapsix/following{/other_user}","gists_url":"https://api.github.com/users/anapsix/gists{/gist_id}","starred_url":"https://api.github.com/users/anapsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anapsix/subscriptions","organizations_url":"https://api.github.com/users/anapsix/orgs","repos_url":"https://api.github.com/users/anapsix/repos","events_url":"https://api.github.com/users/anapsix/events{/privacy}","received_events_url":"https://api.github.com/users/anapsix/received_events","type":"User","site_admin":false},"body":"As per Docker-Library best practices, it's best to  allow  overriding ENTRYPOINT, when needed by checking  for  \"-\"  arguments.\r\nExamples:\r\n`docker run -it chronos` is possible, and so is passing flags:\r\n`docker run -it chronos --help` will work as expected / before.\r\n`docker run -it chronos /bin/bash` and similar is now possible.\r\n\r\nSee https://github.com/docker-library/official-images/issues/692","created_at":"2015-05-20T16:01:50Z","updated_at":"2015-06-03T16:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467939dff5441512d87914a392281b1642e9510c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesos/chronos/pulls/456/commits","review_comments_url":"https://api.github.com/repos/mesos/chronos/pulls/456/comments","review_comment_url":"https://api.github.com/repos/mesos/chronos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesos/chronos/issues/456/comments","statuses_url":"https://api.github.com/repos/mesos/chronos/statuses/83ee2615e676ca0447b0cafe0b78c50347bf0611","head":{"label":"anapsix:better-entrypoint","ref":"better-entrypoint","sha":"83ee2615e676ca0447b0cafe0b78c50347bf0611","user":{"login":"anapsix","id":1256199,"avatar_url":"https://avatars.githubusercontent.com/u/1256199?v=3","gravatar_id":"","url":"https://api.github.com/users/anapsix","html_url":"https://github.com/anapsix","followers_url":"https://api.github.com/users/anapsix/followers","following_url":"https://api.github.com/users/anapsix/following{/other_user}","gists_url":"https://api.github.com/users/anapsix/gists{/gist_id}","starred_url":"https://api.github.com/users/anapsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anapsix/subscriptions","organizations_url":"https://api.github.com/users/anapsix/orgs","repos_url":"https://api.github.com/users/anapsix/repos","events_url":"https://api.github.com/users/anapsix/events{/privacy}","received_events_url":"https://api.github.com/users/anapsix/received_events","type":"User","site_admin":false},"repo":{"id":8914251,"name":"chronos","full_name":"anapsix/chronos","owner":{"login":"anapsix","id":1256199,"avatar_url":"https://avatars.githubusercontent.com/u/1256199?v=3","gravatar_id":"","url":"https://api.github.com/users/anapsix","html_url":"https://github.com/anapsix","followers_url":"https://api.github.com/users/anapsix/followers","following_url":"https://api.github.com/users/anapsix/following{/other_user}","gists_url":"https://api.github.com/users/anapsix/gists{/gist_id}","starred_url":"https://api.github.com/users/anapsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anapsix/subscriptions","organizations_url":"https://api.github.com/users/anapsix/orgs","repos_url":"https://api.github.com/users/anapsix/repos","events_url":"https://api.github.com/users/anapsix/events{/privacy}","received_events_url":"https://api.github.com/users/anapsix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anapsix/chronos","description":"Fault tolerant job scheduler that handles dependencies and iso8601 based schedules.","fork":true,"url":"https://api.github.com/repos/anapsix/chronos","forks_url":"https://api.github.com/repos/anapsix/chronos/forks","keys_url":"https://api.github.com/repos/anapsix/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anapsix/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anapsix/chronos/teams","hooks_url":"https://api.github.com/repos/anapsix/chronos/hooks","issue_events_url":"https://api.github.com/repos/anapsix/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/anapsix/chronos/events","assignees_url":"https://api.github.com/repos/anapsix/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/anapsix/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/anapsix/chronos/tags","blobs_url":"https://api.github.com/repos/anapsix/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anapsix/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anapsix/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/anapsix/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anapsix/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/anapsix/chronos/languages","stargazers_url":"https://api.github.com/repos/anapsix/chronos/stargazers","contributors_url":"https://api.github.com/repos/anapsix/chronos/contributors","subscribers_url":"https://api.github.com/repos/anapsix/chronos/subscribers","subscription_url":"https://api.github.com/repos/anapsix/chronos/subscription","commits_url":"https://api.github.com/repos/anapsix/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/anapsix/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/anapsix/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/anapsix/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/anapsix/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/anapsix/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anapsix/chronos/merges","archive_url":"https://api.github.com/repos/anapsix/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anapsix/chronos/downloads","issues_url":"https://api.github.com/repos/anapsix/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/anapsix/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/anapsix/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/anapsix/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anapsix/chronos/labels{/name}","releases_url":"https://api.github.com/repos/anapsix/chronos/releases{/id}","created_at":"2013-03-20T20:56:56Z","updated_at":"2015-01-13T22:48:07Z","pushed_at":"2015-06-03T16:00:28Z","git_url":"git://github.com/anapsix/chronos.git","ssh_url":"git@github.com:anapsix/chronos.git","clone_url":"https://github.com/anapsix/chronos.git","svn_url":"https://github.com/anapsix/chronos","homepage":null,"size":5704,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesos:master","ref":"master","sha":"ff3fbdfc2e55ace2dc0b8cd3d45adf8853eea33a","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":8189762,"name":"chronos","full_name":"mesos/chronos","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/chronos","description":"Fault tolerant job scheduler for Mesos which handles dependencies and ISO8601 based schedules","fork":false,"url":"https://api.github.com/repos/mesos/chronos","forks_url":"https://api.github.com/repos/mesos/chronos/forks","keys_url":"https://api.github.com/repos/mesos/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/chronos/teams","hooks_url":"https://api.github.com/repos/mesos/chronos/hooks","issue_events_url":"https://api.github.com/repos/mesos/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/chronos/events","assignees_url":"https://api.github.com/repos/mesos/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/chronos/tags","blobs_url":"https://api.github.com/repos/mesos/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/chronos/languages","stargazers_url":"https://api.github.com/repos/mesos/chronos/stargazers","contributors_url":"https://api.github.com/repos/mesos/chronos/contributors","subscribers_url":"https://api.github.com/repos/mesos/chronos/subscribers","subscription_url":"https://api.github.com/repos/mesos/chronos/subscription","commits_url":"https://api.github.com/repos/mesos/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/chronos/merges","archive_url":"https://api.github.com/repos/mesos/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/chronos/downloads","issues_url":"https://api.github.com/repos/mesos/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/chronos/labels{/name}","releases_url":"https://api.github.com/repos/mesos/chronos/releases{/id}","created_at":"2013-02-13T22:59:14Z","updated_at":"2015-06-02T11:37:34Z","pushed_at":"2015-06-03T16:00:29Z","git_url":"git://github.com/mesos/chronos.git","ssh_url":"git@github.com:mesos/chronos.git","clone_url":"https://github.com/mesos/chronos.git","svn_url":"https://github.com/mesos/chronos","homepage":"http://mesos.github.io/chronos/","size":18339,"stargazers_count":2463,"watchers_count":2463,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":275,"mirror_url":null,"open_issues_count":85,"forks":275,"open_issues":85,"watchers":2463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesos/chronos/pulls/456"},"html":{"href":"https://github.com/mesos/chronos/pull/456"},"issue":{"href":"https://api.github.com/repos/mesos/chronos/issues/456"},"comments":{"href":"https://api.github.com/repos/mesos/chronos/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/mesos/chronos/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/mesos/chronos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesos/chronos/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/mesos/chronos/statuses/83ee2615e676ca0447b0cafe0b78c50347bf0611"}}}}