{"action":"created","comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/31071742","id":31071742,"diff_hunk":"@@ -13,7 +13,7 @@ else(NOT VTK_FOUND)\n endif(NOT VTK_FOUND)\n \n # OpenNI found?\n-if(NOT OPENNI_FOUND OR NOT BUILD_OPENNI)\n+if(NOT OPENNI_FOUND OR NOT WITH_OPENNI)","path":"apps/3d_rec_framework/CMakeLists.txt","position":5,"original_position":5,"commit_id":"f2644cc7c94599b6feeb7da432b6939ec123d7c7","original_commit_id":"f2644cc7c94599b6feeb7da432b6939ec123d7c7","user":{"login":"jspricke","id":480915,"avatar_url":"https://avatars.githubusercontent.com/u/480915?v=3","gravatar_id":"","url":"https://api.github.com/users/jspricke","html_url":"https://github.com/jspricke","followers_url":"https://api.github.com/users/jspricke/followers","following_url":"https://api.github.com/users/jspricke/following{/other_user}","gists_url":"https://api.github.com/users/jspricke/gists{/gist_id}","starred_url":"https://api.github.com/users/jspricke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspricke/subscriptions","organizations_url":"https://api.github.com/users/jspricke/orgs","repos_url":"https://api.github.com/users/jspricke/repos","events_url":"https://api.github.com/users/jspricke/events{/privacy}","received_events_url":"https://api.github.com/users/jspricke/received_events","type":"User","site_admin":false},"body":"WITH_OPENNI | OPENNI_FOUND | NOT OPENNI_FOUND | NOT OPENNI_FOUND OR NOT WITH_OPENNI\r\n------------|--------------|------------------|------------------------------------\r\nF           | F            | T                | T\r\nT           | F            | T                | T\r\nT           | T            | F                | F\r\n\r\nThe last case doesn't happen. Btw. the `WITH_*` where introduced to deliberately disable searching for the dependency.\r\n","created_at":"2015-05-26T19:45:04Z","updated_at":"2015-05-26T19:45:04Z","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1247#discussion_r31071742","pull_request_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247","_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/31071742"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/1247#discussion_r31071742"},"pull_request":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247"}}},"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247","id":36034519,"html_url":"https://github.com/PointCloudLibrary/pcl/pull/1247","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/1247.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/1247.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1247","number":1247,"state":"open","locked":false,"title":"Remove redundant cmake BUILD_* options for grabbers","user":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars.githubusercontent.com/u/1241736?v=3","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"body":"Currently we have a redundancy in options to enable/disable building of some of the grabbers (OpenNI, OpenNI2, Ensenso, DavidSDK). Firstly, there is a set of `WITH_*` options which, among other things, allow to disable building grabbers even when corresponding libraries are present in the system (introduced in #476). Secondly, for each of these grabbers there is a `BUILD_*` option (marked as advanced), that can also be used to disable building.\r\n\r\nThis pull request removes this second layer of build control, leaving the unified `WITH_*` option set as the only means to enable/disable grabber building.","created_at":"2015-05-22T14:13:13Z","updated_at":"2015-05-26T19:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a4e08ff86d4388067568d6f33ecdc5ff907261b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1247/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/f2644cc7c94599b6feeb7da432b6939ec123d7c7","head":{"label":"taketwo:remove-build-openni","ref":"remove-build-openni","sha":"f2644cc7c94599b6feeb7da432b6939ec123d7c7","user":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars.githubusercontent.com/u/1241736?v=3","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"repo":{"id":10551347,"name":"pcl","full_name":"taketwo/pcl","owner":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars.githubusercontent.com/u/1241736?v=3","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taketwo/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/taketwo/pcl","forks_url":"https://api.github.com/repos/taketwo/pcl/forks","keys_url":"https://api.github.com/repos/taketwo/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taketwo/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taketwo/pcl/teams","hooks_url":"https://api.github.com/repos/taketwo/pcl/hooks","issue_events_url":"https://api.github.com/repos/taketwo/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/taketwo/pcl/events","assignees_url":"https://api.github.com/repos/taketwo/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/taketwo/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/taketwo/pcl/tags","blobs_url":"https://api.github.com/repos/taketwo/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taketwo/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taketwo/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/taketwo/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taketwo/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/taketwo/pcl/languages","stargazers_url":"https://api.github.com/repos/taketwo/pcl/stargazers","contributors_url":"https://api.github.com/repos/taketwo/pcl/contributors","subscribers_url":"https://api.github.com/repos/taketwo/pcl/subscribers","subscription_url":"https://api.github.com/repos/taketwo/pcl/subscription","commits_url":"https://api.github.com/repos/taketwo/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/taketwo/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/taketwo/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/taketwo/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/taketwo/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/taketwo/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taketwo/pcl/merges","archive_url":"https://api.github.com/repos/taketwo/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taketwo/pcl/downloads","issues_url":"https://api.github.com/repos/taketwo/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/taketwo/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/taketwo/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/taketwo/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taketwo/pcl/labels{/name}","releases_url":"https://api.github.com/repos/taketwo/pcl/releases{/id}","created_at":"2013-06-07T14:19:39Z","updated_at":"2015-05-07T07:44:16Z","pushed_at":"2015-05-22T14:11:00Z","git_url":"git://github.com/taketwo/pcl.git","ssh_url":"git@github.com:taketwo/pcl.git","clone_url":"https://github.com/taketwo/pcl.git","svn_url":"https://github.com/taketwo/pcl","homepage":"http://www.pointclouds.org","size":220055,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"b60e20d6a1729374810aedaa33fe4186625e3fba","user":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=3","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"name":"pcl","full_name":"PointCloudLibrary/pcl","owner":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=3","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","created_at":"2013-02-12T16:40:25Z","updated_at":"2015-05-26T18:43:13Z","pushed_at":"2015-05-26T14:09:11Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":278089,"stargazers_count":700,"watchers_count":700,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":870,"mirror_url":null,"open_issues_count":166,"forks":870,"open_issues":166,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/1247"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1247"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1247/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1247/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/f2644cc7c94599b6feeb7da432b6939ec123d7c7"}}}}