{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/34982281","id":34982281,"diff_hunk":"@@ -30,12 +28,7 @@ class SapphireTest extends PHPUnit_Framework_TestCase {\n \t * @var FixtureFactory\n \t */\n \tprotected $fixtureFactory;\n-\t\n-\t/**\n-\t * @var bool Set whether to include this test in the TestRunner or to skip this.\n-\t */\n-\tprotected $skipTest = false;","path":"dev/SapphireTest.php","position":15,"original_position":15,"commit_id":"bff6c52865e44e6eceeaab59cf7f5a15a46bbbbd","original_commit_id":"2a666922ce5ee7ae671fed90f97c77a517acf07a","user":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"body":"When `markTestSkipped()` is placed in `setUp()`, it'll skip every test (https://phpunit.de/manual/current/en/incomplete-and-skipped-tests.html#incomplete-and-skipped-tests.skipping-tests). Which I've made sure is the case for the few core uses. You're correct in saying that if somebody discovered this flag, and used without also using `markTestSkipped()`, this test would now be executed. I think that's an acceptable change for a major version, particularly since its duplicating existing PHPUnit functionality. I've made this change more explicit in the upgrading docs though.","created_at":"2015-07-20T10:20:50Z","updated_at":"2015-07-20T10:20:50Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4404#discussion_r34982281","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/34982281"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4404#discussion_r34982281"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404","id":40114840,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4404","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4404.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4404.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4404","number":4404,"state":"open","locked":false,"title":"Remove TestRunner and JSTestRunner","user":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"body":"See https://github.com/silverstripe/silverstripe-framework/issues/4254 for background. As per latest state of discussion, not re-adding this functionality via a module. The docs still have too much duplication, reworked them slightly in addition to removing the oudated references. More consolidation work is required in there, but not a dependency on this pull request.","created_at":"2015-07-16T10:25:44Z","updated_at":"2015-07-20T10:20:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2bab80af527b0851166762627d5210ad06c169","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4404/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/bff6c52865e44e6eceeaab59cf7f5a15a46bbbbd","head":{"label":"chillu:pulls/remove-dev-tests","ref":"pulls/remove-dev-tests","sha":"bff6c52865e44e6eceeaab59cf7f5a15a46bbbbd","user":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"repo":{"id":1352076,"name":"silverstripe-framework","full_name":"chillu/silverstripe-framework","owner":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chillu/silverstripe-framework","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/chillu/silverstripe-framework","forks_url":"https://api.github.com/repos/chillu/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/chillu/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chillu/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chillu/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/chillu/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/chillu/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/chillu/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/chillu/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/chillu/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/chillu/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/chillu/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chillu/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chillu/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/chillu/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chillu/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/chillu/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/chillu/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/chillu/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/chillu/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/chillu/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/chillu/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/chillu/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/chillu/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/chillu/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/chillu/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/chillu/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chillu/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/chillu/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chillu/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/chillu/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/chillu/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/chillu/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/chillu/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chillu/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/chillu/silverstripe-framework/releases{/id}","created_at":"2011-02-10T19:55:43Z","updated_at":"2014-07-27T21:26:40Z","pushed_at":"2015-07-20T10:19:51Z","git_url":"git://github.com/chillu/silverstripe-framework.git","ssh_url":"git@github.com:chillu/silverstripe-framework.git","clone_url":"https://github.com/chillu/silverstripe-framework.git","svn_url":"https://github.com/chillu/silverstripe-framework","homepage":"http://silverstripe.org/","size":52760,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"7b47501296596f1fbc3cd2cb8aa6a39feb894b71","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-07-12T08:56:46Z","pushed_at":"2015-07-20T10:19:52Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":105003,"stargazers_count":458,"watchers_count":458,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":614,"forks":507,"open_issues":614,"watchers":458,"default_branch":"3.2"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4404"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4404"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4404/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4404/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/bff6c52865e44e6eceeaab59cf7f5a15a46bbbbd"}}}}