{"action":"created","issue":{"url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/2","labels_url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/2/comments","events_url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/2/events","html_url":"https://github.com/adlogix/googleads-dfp-utils/pull/2","id":55141834,"number":2,"title":"Support multiple dfp versions using reflection","user":{"login":"piumika","id":7237953,"avatar_url":"https://avatars.githubusercontent.com/u/7237953?v=3","gravatar_id":"","url":"https://api.github.com/users/piumika","html_url":"https://github.com/piumika","followers_url":"https://api.github.com/users/piumika/followers","following_url":"https://api.github.com/users/piumika/following{/other_user}","gists_url":"https://api.github.com/users/piumika/gists{/gist_id}","starred_url":"https://api.github.com/users/piumika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piumika/subscriptions","organizations_url":"https://api.github.com/users/piumika/orgs","repos_url":"https://api.github.com/users/piumika/repos","events_url":"https://api.github.com/users/piumika/events{/privacy}","received_events_url":"https://api.github.com/users/piumika/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tonivdv","id":1267658,"avatar_url":"https://avatars.githubusercontent.com/u/1267658?v=3","gravatar_id":"","url":"https://api.github.com/users/tonivdv","html_url":"https://github.com/tonivdv","followers_url":"https://api.github.com/users/tonivdv/followers","following_url":"https://api.github.com/users/tonivdv/following{/other_user}","gists_url":"https://api.github.com/users/tonivdv/gists{/gist_id}","starred_url":"https://api.github.com/users/tonivdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonivdv/subscriptions","organizations_url":"https://api.github.com/users/tonivdv/orgs","repos_url":"https://api.github.com/users/tonivdv/repos","events_url":"https://api.github.com/users/tonivdv/events{/privacy}","received_events_url":"https://api.github.com/users/tonivdv/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-01-22T11:21:19Z","updated_at":"2015-02-02T07:42:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/pulls/2","html_url":"https://github.com/adlogix/googleads-dfp-utils/pull/2","diff_url":"https://github.com/adlogix/googleads-dfp-utils/pull/2.diff","patch_url":"https://github.com/adlogix/googleads-dfp-utils/pull/2.patch"},"body":"Hi @tonivdv ,\r\n\r\nI have included the joor library for reflection and generics. Please let me know if there is a better way for handling generics.\r\n\r\nIf an older dfp version does not support a certain method it will throw a RunTimeException specifying the class and the method. Let me know if there is any other better way for handling these scenarios.\r\n\r\nAlso I could not find a good way for validating the service objects that are passed to the finders (ex: InventoryServiceInterface in AdUnitFinder), since these objects are proxy objects. I have used the proxy objects invocation handler to find the soapclient specific to the service and validated using this.\r\n\r\nKind Regards\r\nPiumika"},"comment":{"url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/comments/72416788","html_url":"https://github.com/adlogix/googleads-dfp-utils/pull/2#issuecomment-72416788","issue_url":"https://api.github.com/repos/adlogix/googleads-dfp-utils/issues/2","id":72416788,"user":{"login":"tonivdv","id":1267658,"avatar_url":"https://avatars.githubusercontent.com/u/1267658?v=3","gravatar_id":"","url":"https://api.github.com/users/tonivdv","html_url":"https://github.com/tonivdv","followers_url":"https://api.github.com/users/tonivdv/followers","following_url":"https://api.github.com/users/tonivdv/following{/other_user}","gists_url":"https://api.github.com/users/tonivdv/gists{/gist_id}","starred_url":"https://api.github.com/users/tonivdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonivdv/subscriptions","organizations_url":"https://api.github.com/users/tonivdv/orgs","repos_url":"https://api.github.com/users/tonivdv/repos","events_url":"https://api.github.com/users/tonivdv/events{/privacy}","received_events_url":"https://api.github.com/users/tonivdv/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T07:42:29Z","updated_at":"2015-02-02T07:42:29Z","body":"@piumika @gunith fine for me"}}