{"action":"created","comment":{"url":"https://api.github.com/repos/acplt/open62541/pulls/comments/38743622","id":38743622,"diff_hunk":"@@ -36,8 +36,10 @@ add_custom_command(OUTPUT ${PROJECT_BINARY_DIR}/src_generated/nodeset.h ${PROJEC\n                        ${PROJECT_SOURCE_DIR}/tools/pyUANamespace/NodeID_Blacklist_FullNS0.txt\n                        ${PROJECT_SOURCE_DIR}/examples/server_nodeset.xml)\n                \n-add_executable(server_nodeset server_nodeset.c ${PROJECT_BINARY_DIR}/src_generated/nodeset.c)\n-target_link_libraries(server_nodeset ${LIBS})\n+if(ENABLE_GENERATE_NAMESPACE0)","path":"examples/CMakeLists.txt","position":6,"original_position":6,"commit_id":"a92572789de73fb1d3f27f80932b636f8cb8a3db","original_commit_id":"a92572789de73fb1d3f27f80932b636f8cb8a3db","user":{"login":"Stasik0","id":469170,"avatar_url":"https://avatars.githubusercontent.com/u/469170?v=3","gravatar_id":"","url":"https://api.github.com/users/Stasik0","html_url":"https://github.com/Stasik0","followers_url":"https://api.github.com/users/Stasik0/followers","following_url":"https://api.github.com/users/Stasik0/following{/other_user}","gists_url":"https://api.github.com/users/Stasik0/gists{/gist_id}","starred_url":"https://api.github.com/users/Stasik0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stasik0/subscriptions","organizations_url":"https://api.github.com/users/Stasik0/orgs","repos_url":"https://api.github.com/users/Stasik0/repos","events_url":"https://api.github.com/users/Stasik0/events{/privacy}","received_events_url":"https://api.github.com/users/Stasik0/received_events","type":"User","site_admin":false},"body":"why this one? nodeset uses its own nodest.xml and is not dependend on compiled ns0","created_at":"2015-09-04T11:47:20Z","updated_at":"2015-09-04T11:47:20Z","html_url":"https://github.com/acplt/open62541/pull/378#discussion_r38743622","pull_request_url":"https://api.github.com/repos/acplt/open62541/pulls/378","_links":{"self":{"href":"https://api.github.com/repos/acplt/open62541/pulls/comments/38743622"},"html":{"href":"https://github.com/acplt/open62541/pull/378#discussion_r38743622"},"pull_request":{"href":"https://api.github.com/repos/acplt/open62541/pulls/378"}}},"pull_request":{"url":"https://api.github.com/repos/acplt/open62541/pulls/378","id":44207017,"html_url":"https://github.com/acplt/open62541/pull/378","diff_url":"https://github.com/acplt/open62541/pull/378.diff","patch_url":"https://github.com/acplt/open62541/pull/378.patch","issue_url":"https://api.github.com/repos/acplt/open62541/issues/378","number":378,"state":"open","locked":false,"title":"rename get/setNodeAttribute; use inline methods for type safety","user":{"login":"jpfr","id":1726411,"avatar_url":"https://avatars.githubusercontent.com/u/1726411?v=3","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"body":"Some proposed changes to the server API.\r\n\r\n- Use const pointers for setting atttributes\r\n- Rename to UA_Server_getNodeAttribute and similar\r\n- Use static inline functions (with the function body in the header) instead of macros for type safety. Don't use ptrs but const values for specific attribute set functions. That makes clear that values are copied and the user needs to clear the memory on his side.\r\n\r\n@ichrispa \r\n@Stasik0 \r\n\r\nWhat do you say? Is it much work to update the tutorials?\r\n\r\n","created_at":"2015-09-04T11:17:56Z","updated_at":"2015-09-04T11:47:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95a497d849f58ff27a0b9ca48d5845c9db89dbf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acplt/open62541/pulls/378/commits","review_comments_url":"https://api.github.com/repos/acplt/open62541/pulls/378/comments","review_comment_url":"https://api.github.com/repos/acplt/open62541/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acplt/open62541/issues/378/comments","statuses_url":"https://api.github.com/repos/acplt/open62541/statuses/a92572789de73fb1d3f27f80932b636f8cb8a3db","head":{"label":"acplt:inline_setattribute","ref":"inline_setattribute","sha":"a92572789de73fb1d3f27f80932b636f8cb8a3db","user":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"repo":{"id":15333809,"name":"open62541","full_name":"acplt/open62541","owner":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acplt/open62541","description":"An open source and free communication stack implementation of IEC 62541 aka OPC UA (OPC Unified Architecture) licensed under LGPL + static linking exception.","fork":false,"url":"https://api.github.com/repos/acplt/open62541","forks_url":"https://api.github.com/repos/acplt/open62541/forks","keys_url":"https://api.github.com/repos/acplt/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acplt/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acplt/open62541/teams","hooks_url":"https://api.github.com/repos/acplt/open62541/hooks","issue_events_url":"https://api.github.com/repos/acplt/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/acplt/open62541/events","assignees_url":"https://api.github.com/repos/acplt/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/acplt/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/acplt/open62541/tags","blobs_url":"https://api.github.com/repos/acplt/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acplt/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acplt/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/acplt/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acplt/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/acplt/open62541/languages","stargazers_url":"https://api.github.com/repos/acplt/open62541/stargazers","contributors_url":"https://api.github.com/repos/acplt/open62541/contributors","subscribers_url":"https://api.github.com/repos/acplt/open62541/subscribers","subscription_url":"https://api.github.com/repos/acplt/open62541/subscription","commits_url":"https://api.github.com/repos/acplt/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/acplt/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/acplt/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/acplt/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/acplt/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/acplt/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acplt/open62541/merges","archive_url":"https://api.github.com/repos/acplt/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acplt/open62541/downloads","issues_url":"https://api.github.com/repos/acplt/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/acplt/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/acplt/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/acplt/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acplt/open62541/labels{/name}","releases_url":"https://api.github.com/repos/acplt/open62541/releases{/id}","created_at":"2013-12-20T08:45:05Z","updated_at":"2015-09-02T15:03:09Z","pushed_at":"2015-09-04T11:46:22Z","git_url":"git://github.com/acplt/open62541.git","ssh_url":"git@github.com:acplt/open62541.git","clone_url":"https://github.com/acplt/open62541.git","svn_url":"https://github.com/acplt/open62541","homepage":"","size":16098,"stargazers_count":46,"watchers_count":46,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":29,"forks":26,"open_issues":29,"watchers":46,"default_branch":"master"}},"base":{"label":"acplt:master","ref":"master","sha":"f47c6dc9838f21ba60f19c1bbe08126814255ddf","user":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"repo":{"id":15333809,"name":"open62541","full_name":"acplt/open62541","owner":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acplt/open62541","description":"An open source and free communication stack implementation of IEC 62541 aka OPC UA (OPC Unified Architecture) licensed under LGPL + static linking exception.","fork":false,"url":"https://api.github.com/repos/acplt/open62541","forks_url":"https://api.github.com/repos/acplt/open62541/forks","keys_url":"https://api.github.com/repos/acplt/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acplt/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acplt/open62541/teams","hooks_url":"https://api.github.com/repos/acplt/open62541/hooks","issue_events_url":"https://api.github.com/repos/acplt/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/acplt/open62541/events","assignees_url":"https://api.github.com/repos/acplt/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/acplt/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/acplt/open62541/tags","blobs_url":"https://api.github.com/repos/acplt/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acplt/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acplt/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/acplt/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acplt/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/acplt/open62541/languages","stargazers_url":"https://api.github.com/repos/acplt/open62541/stargazers","contributors_url":"https://api.github.com/repos/acplt/open62541/contributors","subscribers_url":"https://api.github.com/repos/acplt/open62541/subscribers","subscription_url":"https://api.github.com/repos/acplt/open62541/subscription","commits_url":"https://api.github.com/repos/acplt/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/acplt/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/acplt/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/acplt/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/acplt/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/acplt/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acplt/open62541/merges","archive_url":"https://api.github.com/repos/acplt/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acplt/open62541/downloads","issues_url":"https://api.github.com/repos/acplt/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/acplt/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/acplt/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/acplt/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acplt/open62541/labels{/name}","releases_url":"https://api.github.com/repos/acplt/open62541/releases{/id}","created_at":"2013-12-20T08:45:05Z","updated_at":"2015-09-02T15:03:09Z","pushed_at":"2015-09-04T11:46:22Z","git_url":"git://github.com/acplt/open62541.git","ssh_url":"git@github.com:acplt/open62541.git","clone_url":"https://github.com/acplt/open62541.git","svn_url":"https://github.com/acplt/open62541","homepage":"","size":16098,"stargazers_count":46,"watchers_count":46,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":29,"forks":26,"open_issues":29,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acplt/open62541/pulls/378"},"html":{"href":"https://github.com/acplt/open62541/pull/378"},"issue":{"href":"https://api.github.com/repos/acplt/open62541/issues/378"},"comments":{"href":"https://api.github.com/repos/acplt/open62541/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/acplt/open62541/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/acplt/open62541/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acplt/open62541/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/acplt/open62541/statuses/a92572789de73fb1d3f27f80932b636f8cb8a3db"}}}}