{"comment":{"url":"https://api.github.com/repos/dscho/git/comments/10361746","html_url":"https://github.com/dscho/git/commit/18f608598ed69c4f032c2b76383b2dce1dad7192#commitcomment-10361746","id":10361746,"user":{"login":"sschuberth","id":349154,"avatar_url":"https://avatars.githubusercontent.com/u/349154?v=3","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"position":43,"line":196,"path":"compat/win32/git-wrapper.c","commit_id":"18f608598ed69c4f032c2b76383b2dce1dad7192","created_at":"2015-03-24T08:42:23Z","updated_at":"2015-03-24T08:42:23Z","body":"I don't think the information which terminal program to use (be it mintty or something lese) should go to git-wrapper in the first place. Lines 196 to 198 are terminal program specific configuration options, and as such, they should be set in the terminal program, not here.\r\n\r\nAnyway, now that we have it, I'm ok with keeping it as-is. But how about at least renaming the executable from `git-bash.exe` to `git-mintty.exe` to make the dependency on mintty more obvious? Later on, we could add code paths that try to find and make use of existing ConEmu and ConsoleZ installations if the git-wrapper is started as `git-conemu.exe` or `git-consolez.exe` respectively."}}