{"action":"closed","number":217,"pull_request":{"url":"https://api.github.com/repos/brianbianco/redisio/pulls/217","id":40441512,"html_url":"https://github.com/brianbianco/redisio/pull/217","diff_url":"https://github.com/brianbianco/redisio/pull/217.diff","patch_url":"https://github.com/brianbianco/redisio/pull/217.patch","issue_url":"https://api.github.com/repos/brianbianco/redisio/issues/217","number":217,"state":"closed","locked":false,"title":"Fix bug. not valid `only_if` of `user_ulimit`","user":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"body":"## Bug\r\n\r\n`default[\"redisio\"][\"default_settings\"][\"ulimit\"]` attribute set `nil`,  but it would have been made `/etc/security/limits.d/redis_limits.conf`\r\n\r\n## Cause\r\n\r\n`user_ulimit` is  `definition`, not `lwrp`. \r\nref: https://github.com/bmhatfield/chef-ulimit/blob/master/definitions/user_ulimit.rb\r\n\r\nChef definition does not support nof_if/only_if.","created_at":"2015-07-21T10:10:07Z","updated_at":"2015-08-07T11:31:56Z","closed_at":"2015-08-07T11:31:56Z","merged_at":"2015-08-07T11:31:56Z","merge_commit_sha":"409081a1cf962796ca70fd2d8826a44f68053769","assignee":null,"milestone":{"url":"https://api.github.com/repos/brianbianco/redisio/milestones/7","html_url":"https://github.com/brianbianco/redisio/milestones/2.next","labels_url":"https://api.github.com/repos/brianbianco/redisio/milestones/7/labels","id":1059197,"number":7,"title":"2.next","description":"","creator":{"login":"martinb3","id":103033,"avatar_url":"https://avatars.githubusercontent.com/u/103033?v=3","gravatar_id":"","url":"https://api.github.com/users/martinb3","html_url":"https://github.com/martinb3","followers_url":"https://api.github.com/users/martinb3/followers","following_url":"https://api.github.com/users/martinb3/following{/other_user}","gists_url":"https://api.github.com/users/martinb3/gists{/gist_id}","starred_url":"https://api.github.com/users/martinb3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinb3/subscriptions","organizations_url":"https://api.github.com/users/martinb3/orgs","repos_url":"https://api.github.com/users/martinb3/repos","events_url":"https://api.github.com/users/martinb3/events{/privacy}","received_events_url":"https://api.github.com/users/martinb3/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":10,"state":"open","created_at":"2015-04-08T20:50:21Z","updated_at":"2015-08-07T11:31:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brianbianco/redisio/pulls/217/commits","review_comments_url":"https://api.github.com/repos/brianbianco/redisio/pulls/217/comments","review_comment_url":"https://api.github.com/repos/brianbianco/redisio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianbianco/redisio/issues/217/comments","statuses_url":"https://api.github.com/repos/brianbianco/redisio/statuses/4ee9aad3b53029cc3b6c6cf741f5126755e712cd","head":{"label":"w1mvy:fix_bug_ulimit_only_if","ref":"fix_bug_ulimit_only_if","sha":"4ee9aad3b53029cc3b6c6cf741f5126755e712cd","user":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"repo":{"id":37439316,"name":"redisio","full_name":"w1mvy/redisio","owner":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w1mvy/redisio","description":"A chef cookbook for installing and managing redis instances","fork":true,"url":"https://api.github.com/repos/w1mvy/redisio","forks_url":"https://api.github.com/repos/w1mvy/redisio/forks","keys_url":"https://api.github.com/repos/w1mvy/redisio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w1mvy/redisio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w1mvy/redisio/teams","hooks_url":"https://api.github.com/repos/w1mvy/redisio/hooks","issue_events_url":"https://api.github.com/repos/w1mvy/redisio/issues/events{/number}","events_url":"https://api.github.com/repos/w1mvy/redisio/events","assignees_url":"https://api.github.com/repos/w1mvy/redisio/assignees{/user}","branches_url":"https://api.github.com/repos/w1mvy/redisio/branches{/branch}","tags_url":"https://api.github.com/repos/w1mvy/redisio/tags","blobs_url":"https://api.github.com/repos/w1mvy/redisio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w1mvy/redisio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w1mvy/redisio/git/refs{/sha}","trees_url":"https://api.github.com/repos/w1mvy/redisio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w1mvy/redisio/statuses/{sha}","languages_url":"https://api.github.com/repos/w1mvy/redisio/languages","stargazers_url":"https://api.github.com/repos/w1mvy/redisio/stargazers","contributors_url":"https://api.github.com/repos/w1mvy/redisio/contributors","subscribers_url":"https://api.github.com/repos/w1mvy/redisio/subscribers","subscription_url":"https://api.github.com/repos/w1mvy/redisio/subscription","commits_url":"https://api.github.com/repos/w1mvy/redisio/commits{/sha}","git_commits_url":"https://api.github.com/repos/w1mvy/redisio/git/commits{/sha}","comments_url":"https://api.github.com/repos/w1mvy/redisio/comments{/number}","issue_comment_url":"https://api.github.com/repos/w1mvy/redisio/issues/comments{/number}","contents_url":"https://api.github.com/repos/w1mvy/redisio/contents/{+path}","compare_url":"https://api.github.com/repos/w1mvy/redisio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w1mvy/redisio/merges","archive_url":"https://api.github.com/repos/w1mvy/redisio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w1mvy/redisio/downloads","issues_url":"https://api.github.com/repos/w1mvy/redisio/issues{/number}","pulls_url":"https://api.github.com/repos/w1mvy/redisio/pulls{/number}","milestones_url":"https://api.github.com/repos/w1mvy/redisio/milestones{/number}","notifications_url":"https://api.github.com/repos/w1mvy/redisio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w1mvy/redisio/labels{/name}","releases_url":"https://api.github.com/repos/w1mvy/redisio/releases{/id}","created_at":"2015-06-15T02:31:55Z","updated_at":"2015-06-15T02:31:55Z","pushed_at":"2015-07-21T10:14:19Z","git_url":"git://github.com/w1mvy/redisio.git","ssh_url":"git@github.com:w1mvy/redisio.git","clone_url":"https://github.com/w1mvy/redisio.git","svn_url":"https://github.com/w1mvy/redisio","homepage":"","size":490,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brianbianco:master","ref":"master","sha":"d34858583753ba61923795b41619089c65802366","user":{"login":"brianbianco","id":523384,"avatar_url":"https://avatars.githubusercontent.com/u/523384?v=3","gravatar_id":"","url":"https://api.github.com/users/brianbianco","html_url":"https://github.com/brianbianco","followers_url":"https://api.github.com/users/brianbianco/followers","following_url":"https://api.github.com/users/brianbianco/following{/other_user}","gists_url":"https://api.github.com/users/brianbianco/gists{/gist_id}","starred_url":"https://api.github.com/users/brianbianco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianbianco/subscriptions","organizations_url":"https://api.github.com/users/brianbianco/orgs","repos_url":"https://api.github.com/users/brianbianco/repos","events_url":"https://api.github.com/users/brianbianco/events{/privacy}","received_events_url":"https://api.github.com/users/brianbianco/received_events","type":"User","site_admin":false},"repo":{"id":3957494,"name":"redisio","full_name":"brianbianco/redisio","owner":{"login":"brianbianco","id":523384,"avatar_url":"https://avatars.githubusercontent.com/u/523384?v=3","gravatar_id":"","url":"https://api.github.com/users/brianbianco","html_url":"https://github.com/brianbianco","followers_url":"https://api.github.com/users/brianbianco/followers","following_url":"https://api.github.com/users/brianbianco/following{/other_user}","gists_url":"https://api.github.com/users/brianbianco/gists{/gist_id}","starred_url":"https://api.github.com/users/brianbianco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianbianco/subscriptions","organizations_url":"https://api.github.com/users/brianbianco/orgs","repos_url":"https://api.github.com/users/brianbianco/repos","events_url":"https://api.github.com/users/brianbianco/events{/privacy}","received_events_url":"https://api.github.com/users/brianbianco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianbianco/redisio","description":"A chef cookbook for installing and managing redis instances","fork":false,"url":"https://api.github.com/repos/brianbianco/redisio","forks_url":"https://api.github.com/repos/brianbianco/redisio/forks","keys_url":"https://api.github.com/repos/brianbianco/redisio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianbianco/redisio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianbianco/redisio/teams","hooks_url":"https://api.github.com/repos/brianbianco/redisio/hooks","issue_events_url":"https://api.github.com/repos/brianbianco/redisio/issues/events{/number}","events_url":"https://api.github.com/repos/brianbianco/redisio/events","assignees_url":"https://api.github.com/repos/brianbianco/redisio/assignees{/user}","branches_url":"https://api.github.com/repos/brianbianco/redisio/branches{/branch}","tags_url":"https://api.github.com/repos/brianbianco/redisio/tags","blobs_url":"https://api.github.com/repos/brianbianco/redisio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianbianco/redisio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianbianco/redisio/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianbianco/redisio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianbianco/redisio/statuses/{sha}","languages_url":"https://api.github.com/repos/brianbianco/redisio/languages","stargazers_url":"https://api.github.com/repos/brianbianco/redisio/stargazers","contributors_url":"https://api.github.com/repos/brianbianco/redisio/contributors","subscribers_url":"https://api.github.com/repos/brianbianco/redisio/subscribers","subscription_url":"https://api.github.com/repos/brianbianco/redisio/subscription","commits_url":"https://api.github.com/repos/brianbianco/redisio/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianbianco/redisio/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianbianco/redisio/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianbianco/redisio/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianbianco/redisio/contents/{+path}","compare_url":"https://api.github.com/repos/brianbianco/redisio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianbianco/redisio/merges","archive_url":"https://api.github.com/repos/brianbianco/redisio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianbianco/redisio/downloads","issues_url":"https://api.github.com/repos/brianbianco/redisio/issues{/number}","pulls_url":"https://api.github.com/repos/brianbianco/redisio/pulls{/number}","milestones_url":"https://api.github.com/repos/brianbianco/redisio/milestones{/number}","notifications_url":"https://api.github.com/repos/brianbianco/redisio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianbianco/redisio/labels{/name}","releases_url":"https://api.github.com/repos/brianbianco/redisio/releases{/id}","created_at":"2012-04-07T11:59:56Z","updated_at":"2015-08-05T15:23:19Z","pushed_at":"2015-08-07T11:31:56Z","git_url":"git://github.com/brianbianco/redisio.git","ssh_url":"git@github.com:brianbianco/redisio.git","clone_url":"https://github.com/brianbianco/redisio.git","svn_url":"https://github.com/brianbianco/redisio","homepage":"","size":1486,"stargazers_count":244,"watchers_count":244,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":34,"forks":206,"open_issues":34,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianbianco/redisio/pulls/217"},"html":{"href":"https://github.com/brianbianco/redisio/pull/217"},"issue":{"href":"https://api.github.com/repos/brianbianco/redisio/issues/217"},"comments":{"href":"https://api.github.com/repos/brianbianco/redisio/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/brianbianco/redisio/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/brianbianco/redisio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianbianco/redisio/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/brianbianco/redisio/statuses/4ee9aad3b53029cc3b6c6cf741f5126755e712cd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"martinb3","id":103033,"avatar_url":"https://avatars.githubusercontent.com/u/103033?v=3","gravatar_id":"","url":"https://api.github.com/users/martinb3","html_url":"https://github.com/martinb3","followers_url":"https://api.github.com/users/martinb3/followers","following_url":"https://api.github.com/users/martinb3/following{/other_user}","gists_url":"https://api.github.com/users/martinb3/gists{/gist_id}","starred_url":"https://api.github.com/users/martinb3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinb3/subscriptions","organizations_url":"https://api.github.com/users/martinb3/orgs","repos_url":"https://api.github.com/users/martinb3/repos","events_url":"https://api.github.com/users/martinb3/events{/privacy}","received_events_url":"https://api.github.com/users/martinb3/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":3,"changed_files":1}}