{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/mjibson/snmp/pulls/3","id":29476929,"html_url":"https://github.com/mjibson/snmp/pull/3","diff_url":"https://github.com/mjibson/snmp/pull/3.diff","patch_url":"https://github.com/mjibson/snmp/pull/3.patch","issue_url":"https://api.github.com/repos/mjibson/snmp/issues/3","number":3,"state":"open","locked":false,"title":"Refactor to close connections","user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"body":"The PR in #1 would have fixed this problem for Get requests, but only because of\r\nhow the SNMP package uses the connection structure. Walk requests, though, would\r\nhave used the closed connection on requests after the first and thus been\r\nbroken.\r\n\r\nInstead, just make a new connection each time with the UDP dialer. It\r\nappears that the structure of this package was copied from net/http, which\r\nmay not have been a good model. In any case, we can now have a better API\r\nif one is doing multiple requests to the same host, while maintaining the\r\nold API.\r\n\r\nfixes #2\r\ncloses #1","created_at":"2015-02-17T20:58:56Z","updated_at":"2015-02-17T20:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mjibson/snmp/pulls/3/commits","review_comments_url":"https://api.github.com/repos/mjibson/snmp/pulls/3/comments","review_comment_url":"https://api.github.com/repos/mjibson/snmp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mjibson/snmp/issues/3/comments","statuses_url":"https://api.github.com/repos/mjibson/snmp/statuses/f74be4ae14ccfea18de9b8c2ded309150351d839","head":{"label":"mjibson:refactor","ref":"refactor","sha":"f74be4ae14ccfea18de9b8c2ded309150351d839","user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"repo":{"id":17727228,"name":"snmp","full_name":"mjibson/snmp","owner":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjibson/snmp","description":"SNMP implementation for Go","fork":true,"url":"https://api.github.com/repos/mjibson/snmp","forks_url":"https://api.github.com/repos/mjibson/snmp/forks","keys_url":"https://api.github.com/repos/mjibson/snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjibson/snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjibson/snmp/teams","hooks_url":"https://api.github.com/repos/mjibson/snmp/hooks","issue_events_url":"https://api.github.com/repos/mjibson/snmp/issues/events{/number}","events_url":"https://api.github.com/repos/mjibson/snmp/events","assignees_url":"https://api.github.com/repos/mjibson/snmp/assignees{/user}","branches_url":"https://api.github.com/repos/mjibson/snmp/branches{/branch}","tags_url":"https://api.github.com/repos/mjibson/snmp/tags","blobs_url":"https://api.github.com/repos/mjibson/snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjibson/snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjibson/snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjibson/snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjibson/snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/mjibson/snmp/languages","stargazers_url":"https://api.github.com/repos/mjibson/snmp/stargazers","contributors_url":"https://api.github.com/repos/mjibson/snmp/contributors","subscribers_url":"https://api.github.com/repos/mjibson/snmp/subscribers","subscription_url":"https://api.github.com/repos/mjibson/snmp/subscription","commits_url":"https://api.github.com/repos/mjibson/snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjibson/snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjibson/snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjibson/snmp/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjibson/snmp/contents/{+path}","compare_url":"https://api.github.com/repos/mjibson/snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjibson/snmp/merges","archive_url":"https://api.github.com/repos/mjibson/snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjibson/snmp/downloads","issues_url":"https://api.github.com/repos/mjibson/snmp/issues{/number}","pulls_url":"https://api.github.com/repos/mjibson/snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/mjibson/snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/mjibson/snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjibson/snmp/labels{/name}","releases_url":"https://api.github.com/repos/mjibson/snmp/releases{/id}","created_at":"2014-03-13T21:47:34Z","updated_at":"2015-02-17T20:49:39Z","pushed_at":"2015-02-17T20:58:23Z","git_url":"git://github.com/mjibson/snmp.git","ssh_url":"git@github.com:mjibson/snmp.git","clone_url":"https://github.com/mjibson/snmp.git","svn_url":"https://github.com/mjibson/snmp","homepage":"http://godoc.org/github.com/masiulaniec/snmp","size":203,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"mjibson:master","ref":"master","sha":"cd55f8c22a36333bc741975e8ae87218f4285348","user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"repo":{"id":17727228,"name":"snmp","full_name":"mjibson/snmp","owner":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjibson/snmp","description":"SNMP implementation for Go","fork":true,"url":"https://api.github.com/repos/mjibson/snmp","forks_url":"https://api.github.com/repos/mjibson/snmp/forks","keys_url":"https://api.github.com/repos/mjibson/snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjibson/snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjibson/snmp/teams","hooks_url":"https://api.github.com/repos/mjibson/snmp/hooks","issue_events_url":"https://api.github.com/repos/mjibson/snmp/issues/events{/number}","events_url":"https://api.github.com/repos/mjibson/snmp/events","assignees_url":"https://api.github.com/repos/mjibson/snmp/assignees{/user}","branches_url":"https://api.github.com/repos/mjibson/snmp/branches{/branch}","tags_url":"https://api.github.com/repos/mjibson/snmp/tags","blobs_url":"https://api.github.com/repos/mjibson/snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjibson/snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjibson/snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjibson/snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjibson/snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/mjibson/snmp/languages","stargazers_url":"https://api.github.com/repos/mjibson/snmp/stargazers","contributors_url":"https://api.github.com/repos/mjibson/snmp/contributors","subscribers_url":"https://api.github.com/repos/mjibson/snmp/subscribers","subscription_url":"https://api.github.com/repos/mjibson/snmp/subscription","commits_url":"https://api.github.com/repos/mjibson/snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjibson/snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjibson/snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjibson/snmp/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjibson/snmp/contents/{+path}","compare_url":"https://api.github.com/repos/mjibson/snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjibson/snmp/merges","archive_url":"https://api.github.com/repos/mjibson/snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjibson/snmp/downloads","issues_url":"https://api.github.com/repos/mjibson/snmp/issues{/number}","pulls_url":"https://api.github.com/repos/mjibson/snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/mjibson/snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/mjibson/snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjibson/snmp/labels{/name}","releases_url":"https://api.github.com/repos/mjibson/snmp/releases{/id}","created_at":"2014-03-13T21:47:34Z","updated_at":"2015-02-17T20:49:39Z","pushed_at":"2015-02-17T20:58:23Z","git_url":"git://github.com/mjibson/snmp.git","ssh_url":"git@github.com:mjibson/snmp.git","clone_url":"https://github.com/mjibson/snmp.git","svn_url":"https://github.com/mjibson/snmp","homepage":"http://godoc.org/github.com/masiulaniec/snmp","size":203,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjibson/snmp/pulls/3"},"html":{"href":"https://github.com/mjibson/snmp/pull/3"},"issue":{"href":"https://api.github.com/repos/mjibson/snmp/issues/3"},"comments":{"href":"https://api.github.com/repos/mjibson/snmp/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/mjibson/snmp/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/mjibson/snmp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mjibson/snmp/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/mjibson/snmp/statuses/f74be4ae14ccfea18de9b8c2ded309150351d839"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":91,"deletions":88,"changed_files":3}}