{"action":"created","issue":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/196","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/196/comments","events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/196/events","html_url":"https://github.com/meetecho/janus-gateway/issues/196","id":63958462,"number":196,"title":"Missing Call to g_atomic_int_get() in SIP Plugin","user":{"login":"MichaelB76","id":10531932,"avatar_url":"https://avatars.githubusercontent.com/u/10531932?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelB76","html_url":"https://github.com/MichaelB76","followers_url":"https://api.github.com/users/MichaelB76/followers","following_url":"https://api.github.com/users/MichaelB76/following{/other_user}","gists_url":"https://api.github.com/users/MichaelB76/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelB76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelB76/subscriptions","organizations_url":"https://api.github.com/users/MichaelB76/orgs","repos_url":"https://api.github.com/users/MichaelB76/repos","events_url":"https://api.github.com/users/MichaelB76/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelB76/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-24T10:15:16Z","updated_at":"2015-03-24T12:25:39Z","closed_at":null,"body":"Just a minor thing I noticed when looking at the SIP plugin. In janus_sip_sofia_callback(), case nua_r_shutdown: there is the following line:\r\n\r\nif(status < 200 && stopping < 3)\r\n\r\nThe access to the stopping variable isn't wrapped with g_atomic_int_get() like the others so this isn't thread safe. Also, the check is for \"stopping < 3\" but searching through the file this is only ever set to 0 or 1. I guess the use of this variable was changed at some point but this was missed."},"comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments/85477122","html_url":"https://github.com/meetecho/janus-gateway/issues/196#issuecomment-85477122","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/196","id":85477122,"user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T12:25:39Z","updated_at":"2015-03-24T12:25:39Z","body":"Probably a leftover, I'll fix this in the next revision, thanks."}}