{"action":"opened","number":93,"pull_request":{"url":"https://api.github.com/repos/MyGUI/mygui/pulls/93","id":42520620,"html_url":"https://github.com/MyGUI/mygui/pull/93","diff_url":"https://github.com/MyGUI/mygui/pull/93.diff","patch_url":"https://github.com/MyGUI/mygui/pull/93.patch","issue_url":"https://api.github.com/repos/MyGUI/mygui/issues/93","number":93,"state":"open","locked":false,"title":".so versioning fix","user":{"login":"scrawl","id":720642,"avatar_url":"https://avatars.githubusercontent.com/u/720642?v=3","gravatar_id":"","url":"https://api.github.com/users/scrawl","html_url":"https://github.com/scrawl","followers_url":"https://api.github.com/users/scrawl/followers","following_url":"https://api.github.com/users/scrawl/following{/other_user}","gists_url":"https://api.github.com/users/scrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/scrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrawl/subscriptions","organizations_url":"https://api.github.com/users/scrawl/orgs","repos_url":"https://api.github.com/users/scrawl/repos","events_url":"https://api.github.com/users/scrawl/events{/privacy}","received_events_url":"https://api.github.com/users/scrawl/received_events","type":"User","site_admin":false},"body":"Via https://bugs.openmw.org/issues/2373\r\n\r\nMyGUI does not provide binary compatibility across minor or patch releases. Setting the SOVERSION to ${MYGUI_VERSION_MAJOR} is therefore wrong.\r\n\r\nAn example of this causing problems is that applications will be linked against the MAJOR version of MyGUI, e.g. libMyGUIEngine.so.3. Now imagine MyGUI gets updated to a new minor version, e.g. 3.2.2 to 3.2.3, but we forget to re-link the application against that version.\r\nThe Result: a weird crash.\r\nExpected result: the application should refuse to launch with an error such as \"ibMyGUIEngine.so.3.2.2: cannot open shared object file: No such file or directory\"\r\n\r\nThis patch sets SOVERSION to X.Y.Z instead of X, so that client applications effectively link against version X.Y.Z, which you can verify with \"ldd ./bin/Demo_Picking\".","created_at":"2015-08-15T15:12:00Z","updated_at":"2015-08-15T15:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MyGUI/mygui/pulls/93/commits","review_comments_url":"https://api.github.com/repos/MyGUI/mygui/pulls/93/comments","review_comment_url":"https://api.github.com/repos/MyGUI/mygui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MyGUI/mygui/issues/93/comments","statuses_url":"https://api.github.com/repos/MyGUI/mygui/statuses/f4796d6a6a2eedb08eff454acd078b4abf81d196","head":{"label":"scrawl:soversion","ref":"soversion","sha":"f4796d6a6a2eedb08eff454acd078b4abf81d196","user":{"login":"scrawl","id":720642,"avatar_url":"https://avatars.githubusercontent.com/u/720642?v=3","gravatar_id":"","url":"https://api.github.com/users/scrawl","html_url":"https://github.com/scrawl","followers_url":"https://api.github.com/users/scrawl/followers","following_url":"https://api.github.com/users/scrawl/following{/other_user}","gists_url":"https://api.github.com/users/scrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/scrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrawl/subscriptions","organizations_url":"https://api.github.com/users/scrawl/orgs","repos_url":"https://api.github.com/users/scrawl/repos","events_url":"https://api.github.com/users/scrawl/events{/privacy}","received_events_url":"https://api.github.com/users/scrawl/received_events","type":"User","site_admin":false},"repo":{"id":22971671,"name":"mygui","full_name":"scrawl/mygui","owner":{"login":"scrawl","id":720642,"avatar_url":"https://avatars.githubusercontent.com/u/720642?v=3","gravatar_id":"","url":"https://api.github.com/users/scrawl","html_url":"https://github.com/scrawl","followers_url":"https://api.github.com/users/scrawl/followers","following_url":"https://api.github.com/users/scrawl/following{/other_user}","gists_url":"https://api.github.com/users/scrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/scrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrawl/subscriptions","organizations_url":"https://api.github.com/users/scrawl/orgs","repos_url":"https://api.github.com/users/scrawl/repos","events_url":"https://api.github.com/users/scrawl/events{/privacy}","received_events_url":"https://api.github.com/users/scrawl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scrawl/mygui","description":"Fast, flexible and simple GUI.","fork":true,"url":"https://api.github.com/repos/scrawl/mygui","forks_url":"https://api.github.com/repos/scrawl/mygui/forks","keys_url":"https://api.github.com/repos/scrawl/mygui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrawl/mygui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrawl/mygui/teams","hooks_url":"https://api.github.com/repos/scrawl/mygui/hooks","issue_events_url":"https://api.github.com/repos/scrawl/mygui/issues/events{/number}","events_url":"https://api.github.com/repos/scrawl/mygui/events","assignees_url":"https://api.github.com/repos/scrawl/mygui/assignees{/user}","branches_url":"https://api.github.com/repos/scrawl/mygui/branches{/branch}","tags_url":"https://api.github.com/repos/scrawl/mygui/tags","blobs_url":"https://api.github.com/repos/scrawl/mygui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrawl/mygui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrawl/mygui/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrawl/mygui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrawl/mygui/statuses/{sha}","languages_url":"https://api.github.com/repos/scrawl/mygui/languages","stargazers_url":"https://api.github.com/repos/scrawl/mygui/stargazers","contributors_url":"https://api.github.com/repos/scrawl/mygui/contributors","subscribers_url":"https://api.github.com/repos/scrawl/mygui/subscribers","subscription_url":"https://api.github.com/repos/scrawl/mygui/subscription","commits_url":"https://api.github.com/repos/scrawl/mygui/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrawl/mygui/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrawl/mygui/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrawl/mygui/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrawl/mygui/contents/{+path}","compare_url":"https://api.github.com/repos/scrawl/mygui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrawl/mygui/merges","archive_url":"https://api.github.com/repos/scrawl/mygui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrawl/mygui/downloads","issues_url":"https://api.github.com/repos/scrawl/mygui/issues{/number}","pulls_url":"https://api.github.com/repos/scrawl/mygui/pulls{/number}","milestones_url":"https://api.github.com/repos/scrawl/mygui/milestones{/number}","notifications_url":"https://api.github.com/repos/scrawl/mygui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrawl/mygui/labels{/name}","releases_url":"https://api.github.com/repos/scrawl/mygui/releases{/id}","created_at":"2014-08-14T23:17:16Z","updated_at":"2015-01-26T16:21:15Z","pushed_at":"2015-08-15T15:10:59Z","git_url":"git://github.com/scrawl/mygui.git","ssh_url":"git@github.com:scrawl/mygui.git","clone_url":"https://github.com/scrawl/mygui.git","svn_url":"https://github.com/scrawl/mygui","homepage":"http://mygui.info/","size":69074,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MyGUI:master","ref":"master","sha":"fe8b837478e9225f701a64ed9eb7aa05953bbff4","user":{"login":"MyGUI","id":8388582,"avatar_url":"https://avatars.githubusercontent.com/u/8388582?v=3","gravatar_id":"","url":"https://api.github.com/users/MyGUI","html_url":"https://github.com/MyGUI","followers_url":"https://api.github.com/users/MyGUI/followers","following_url":"https://api.github.com/users/MyGUI/following{/other_user}","gists_url":"https://api.github.com/users/MyGUI/gists{/gist_id}","starred_url":"https://api.github.com/users/MyGUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyGUI/subscriptions","organizations_url":"https://api.github.com/users/MyGUI/orgs","repos_url":"https://api.github.com/users/MyGUI/repos","events_url":"https://api.github.com/users/MyGUI/events{/privacy}","received_events_url":"https://api.github.com/users/MyGUI/received_events","type":"Organization","site_admin":false},"repo":{"id":22758435,"name":"mygui","full_name":"MyGUI/mygui","owner":{"login":"MyGUI","id":8388582,"avatar_url":"https://avatars.githubusercontent.com/u/8388582?v=3","gravatar_id":"","url":"https://api.github.com/users/MyGUI","html_url":"https://github.com/MyGUI","followers_url":"https://api.github.com/users/MyGUI/followers","following_url":"https://api.github.com/users/MyGUI/following{/other_user}","gists_url":"https://api.github.com/users/MyGUI/gists{/gist_id}","starred_url":"https://api.github.com/users/MyGUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MyGUI/subscriptions","organizations_url":"https://api.github.com/users/MyGUI/orgs","repos_url":"https://api.github.com/users/MyGUI/repos","events_url":"https://api.github.com/users/MyGUI/events{/privacy}","received_events_url":"https://api.github.com/users/MyGUI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MyGUI/mygui","description":"Fast, flexible and simple GUI.","fork":false,"url":"https://api.github.com/repos/MyGUI/mygui","forks_url":"https://api.github.com/repos/MyGUI/mygui/forks","keys_url":"https://api.github.com/repos/MyGUI/mygui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MyGUI/mygui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MyGUI/mygui/teams","hooks_url":"https://api.github.com/repos/MyGUI/mygui/hooks","issue_events_url":"https://api.github.com/repos/MyGUI/mygui/issues/events{/number}","events_url":"https://api.github.com/repos/MyGUI/mygui/events","assignees_url":"https://api.github.com/repos/MyGUI/mygui/assignees{/user}","branches_url":"https://api.github.com/repos/MyGUI/mygui/branches{/branch}","tags_url":"https://api.github.com/repos/MyGUI/mygui/tags","blobs_url":"https://api.github.com/repos/MyGUI/mygui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MyGUI/mygui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MyGUI/mygui/git/refs{/sha}","trees_url":"https://api.github.com/repos/MyGUI/mygui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MyGUI/mygui/statuses/{sha}","languages_url":"https://api.github.com/repos/MyGUI/mygui/languages","stargazers_url":"https://api.github.com/repos/MyGUI/mygui/stargazers","contributors_url":"https://api.github.com/repos/MyGUI/mygui/contributors","subscribers_url":"https://api.github.com/repos/MyGUI/mygui/subscribers","subscription_url":"https://api.github.com/repos/MyGUI/mygui/subscription","commits_url":"https://api.github.com/repos/MyGUI/mygui/commits{/sha}","git_commits_url":"https://api.github.com/repos/MyGUI/mygui/git/commits{/sha}","comments_url":"https://api.github.com/repos/MyGUI/mygui/comments{/number}","issue_comment_url":"https://api.github.com/repos/MyGUI/mygui/issues/comments{/number}","contents_url":"https://api.github.com/repos/MyGUI/mygui/contents/{+path}","compare_url":"https://api.github.com/repos/MyGUI/mygui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MyGUI/mygui/merges","archive_url":"https://api.github.com/repos/MyGUI/mygui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MyGUI/mygui/downloads","issues_url":"https://api.github.com/repos/MyGUI/mygui/issues{/number}","pulls_url":"https://api.github.com/repos/MyGUI/mygui/pulls{/number}","milestones_url":"https://api.github.com/repos/MyGUI/mygui/milestones{/number}","notifications_url":"https://api.github.com/repos/MyGUI/mygui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MyGUI/mygui/labels{/name}","releases_url":"https://api.github.com/repos/MyGUI/mygui/releases{/id}","created_at":"2014-08-08T13:22:46Z","updated_at":"2015-08-07T14:20:12Z","pushed_at":"2015-08-11T11:30:08Z","git_url":"git://github.com/MyGUI/mygui.git","ssh_url":"git@github.com:MyGUI/mygui.git","clone_url":"https://github.com/MyGUI/mygui.git","svn_url":"https://github.com/MyGUI/mygui","homepage":"http://mygui.info/","size":87782,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":23,"forks":65,"open_issues":23,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MyGUI/mygui/pulls/93"},"html":{"href":"https://github.com/MyGUI/mygui/pull/93"},"issue":{"href":"https://api.github.com/repos/MyGUI/mygui/issues/93"},"comments":{"href":"https://api.github.com/repos/MyGUI/mygui/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/MyGUI/mygui/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/MyGUI/mygui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MyGUI/mygui/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/MyGUI/mygui/statuses/f4796d6a6a2eedb08eff454acd078b4abf81d196"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}