{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/utils/pulls/comments/28178533","id":28178533,"diff_hunk":"@@ -115,12 +117,15 @@ def findFileFromRoot(ifile):\n #-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-\n \n class temporaryFile:\n-    \"\"\"A class to be used with a with statement to ensure that a file is deleted\n-E.g.\n+    \"\"\"!A class to be used with a with statement to ensure that a file is deleted\n+\n+    @warning deprecated: use getTempFilePath instead","path":"python/lsst/utils/tests.py","position":71,"original_position":71,"commit_id":"0b34856815c1007dd2c5b6812693b14e619f39c5","original_commit_id":"0b34856815c1007dd2c5b6812693b14e619f39c5","user":{"login":"jdswinbank","id":460854,"avatar_url":"https://avatars.githubusercontent.com/u/460854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdswinbank","html_url":"https://github.com/jdswinbank","followers_url":"https://api.github.com/users/jdswinbank/followers","following_url":"https://api.github.com/users/jdswinbank/following{/other_user}","gists_url":"https://api.github.com/users/jdswinbank/gists{/gist_id}","starred_url":"https://api.github.com/users/jdswinbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdswinbank/subscriptions","organizations_url":"https://api.github.com/users/jdswinbank/orgs","repos_url":"https://api.github.com/users/jdswinbank/repos","events_url":"https://api.github.com/users/jdswinbank/events{/privacy}","received_events_url":"https://api.github.com/users/jdswinbank/received_events","type":"User","site_admin":false},"body":"Is there a reason to maintain & deprecate this rather than removing it outright? I think you've removed the only place it was being used as part of this ticket, so just trashing it shouldn't break anything.","created_at":"2015-04-10T20:39:30Z","updated_at":"2015-04-10T20:39:30Z","html_url":"https://github.com/lsst/utils/pull/1#discussion_r28178533","pull_request_url":"https://api.github.com/repos/lsst/utils/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lsst/utils/pulls/comments/28178533"},"html":{"href":"https://github.com/lsst/utils/pull/1#discussion_r28178533"},"pull_request":{"href":"https://api.github.com/repos/lsst/utils/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/utils/pulls/1","id":33079096,"html_url":"https://github.com/lsst/utils/pull/1","diff_url":"https://github.com/lsst/utils/pull/1.diff","patch_url":"https://github.com/lsst/utils/pull/1.patch","issue_url":"https://api.github.com/repos/lsst/utils/issues/1","number":1,"state":"open","locked":false,"title":"Review comments for DM-2418 (\"afw tests reuse the same filenames\")","user":{"login":"jdswinbank","id":460854,"avatar_url":"https://avatars.githubusercontent.com/u/460854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdswinbank","html_url":"https://github.com/jdswinbank","followers_url":"https://api.github.com/users/jdswinbank/followers","following_url":"https://api.github.com/users/jdswinbank/following{/other_user}","gists_url":"https://api.github.com/users/jdswinbank/gists{/gist_id}","starred_url":"https://api.github.com/users/jdswinbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdswinbank/subscriptions","organizations_url":"https://api.github.com/users/jdswinbank/orgs","repos_url":"https://api.github.com/users/jdswinbank/repos","events_url":"https://api.github.com/users/jdswinbank/events{/privacy}","received_events_url":"https://api.github.com/users/jdswinbank/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-10T20:08:11Z","updated_at":"2015-04-10T20:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96a581d94a1bdc57ddca904022b6d924a40dbbef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lsst/utils/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lsst/utils/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lsst/utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/utils/issues/1/comments","statuses_url":"https://api.github.com/repos/lsst/utils/statuses/0b34856815c1007dd2c5b6812693b14e619f39c5","head":{"label":"lsst:tickets/DM-2418","ref":"tickets/DM-2418","sha":"0b34856815c1007dd2c5b6812693b14e619f39c5","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013661,"name":"utils","full_name":"lsst/utils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/utils","description":"Common Swig code, floating-point utilities, and angle stringification for LSST Data Management.","fork":false,"url":"https://api.github.com/repos/lsst/utils","forks_url":"https://api.github.com/repos/lsst/utils/forks","keys_url":"https://api.github.com/repos/lsst/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/utils/teams","hooks_url":"https://api.github.com/repos/lsst/utils/hooks","issue_events_url":"https://api.github.com/repos/lsst/utils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/utils/events","assignees_url":"https://api.github.com/repos/lsst/utils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/utils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/utils/tags","blobs_url":"https://api.github.com/repos/lsst/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/utils/languages","stargazers_url":"https://api.github.com/repos/lsst/utils/stargazers","contributors_url":"https://api.github.com/repos/lsst/utils/contributors","subscribers_url":"https://api.github.com/repos/lsst/utils/subscribers","subscription_url":"https://api.github.com/repos/lsst/utils/subscription","commits_url":"https://api.github.com/repos/lsst/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/utils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/utils/merges","archive_url":"https://api.github.com/repos/lsst/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/utils/downloads","issues_url":"https://api.github.com/repos/lsst/utils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/utils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/utils/releases{/id}","created_at":"2014-08-16T08:00:41Z","updated_at":"2015-03-26T18:04:28Z","pushed_at":"2015-04-10T20:08:14Z","git_url":"git://github.com/lsst/utils.git","ssh_url":"git@github.com:lsst/utils.git","clone_url":"https://github.com/lsst/utils.git","svn_url":"https://github.com/lsst/utils","homepage":"http://dm.lsstcorp.org","size":644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"65c9fa1db32cf0c95472626a4216918714b6e438","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013661,"name":"utils","full_name":"lsst/utils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/utils","description":"Common Swig code, floating-point utilities, and angle stringification for LSST Data Management.","fork":false,"url":"https://api.github.com/repos/lsst/utils","forks_url":"https://api.github.com/repos/lsst/utils/forks","keys_url":"https://api.github.com/repos/lsst/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/utils/teams","hooks_url":"https://api.github.com/repos/lsst/utils/hooks","issue_events_url":"https://api.github.com/repos/lsst/utils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/utils/events","assignees_url":"https://api.github.com/repos/lsst/utils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/utils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/utils/tags","blobs_url":"https://api.github.com/repos/lsst/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/utils/languages","stargazers_url":"https://api.github.com/repos/lsst/utils/stargazers","contributors_url":"https://api.github.com/repos/lsst/utils/contributors","subscribers_url":"https://api.github.com/repos/lsst/utils/subscribers","subscription_url":"https://api.github.com/repos/lsst/utils/subscription","commits_url":"https://api.github.com/repos/lsst/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/utils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/utils/merges","archive_url":"https://api.github.com/repos/lsst/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/utils/downloads","issues_url":"https://api.github.com/repos/lsst/utils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/utils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/utils/releases{/id}","created_at":"2014-08-16T08:00:41Z","updated_at":"2015-03-26T18:04:28Z","pushed_at":"2015-04-10T20:08:14Z","git_url":"git://github.com/lsst/utils.git","ssh_url":"git@github.com:lsst/utils.git","clone_url":"https://github.com/lsst/utils.git","svn_url":"https://github.com/lsst/utils","homepage":"http://dm.lsstcorp.org","size":644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/utils/pulls/1"},"html":{"href":"https://github.com/lsst/utils/pull/1"},"issue":{"href":"https://api.github.com/repos/lsst/utils/issues/1"},"comments":{"href":"https://api.github.com/repos/lsst/utils/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/utils/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/utils/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/utils/statuses/0b34856815c1007dd2c5b6812693b14e619f39c5"}}}}