{"action":"created","comment":{"url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/comments/36596507","id":36596507,"diff_hunk":"@@ -36,7 +37,6 @@ IS_SUN_CC = $(shell $(CXX) -V 2>&1 | $(EGREP) -c \"CC: Sun\")\n GAS210_OR_LATER = $(shell echo \"\" | $(AS) -v 2>&1 | $(EGREP) -c \"GNU assembler version (2\\.[1-9][0-9]|[3-9])\")","path":"cppForSwig/cryptopp/Makefile","position":11,"original_position":11,"commit_id":"4dde4d246a77913e28dd92467b8172592ee586d4","original_commit_id":"4c76b331c3d4d9935377bd99720daf7c5cb8c183","user":{"login":"droark","id":5931802,"avatar_url":"https://avatars.githubusercontent.com/u/5931802?v=3","gravatar_id":"","url":"https://api.github.com/users/droark","html_url":"https://github.com/droark","followers_url":"https://api.github.com/users/droark/followers","following_url":"https://api.github.com/users/droark/following{/other_user}","gists_url":"https://api.github.com/users/droark/gists{/gist_id}","starred_url":"https://api.github.com/users/droark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droark/subscriptions","organizations_url":"https://api.github.com/users/droark/orgs","repos_url":"https://api.github.com/users/droark/repos","events_url":"https://api.github.com/users/droark/events{/privacy}","received_events_url":"https://api.github.com/users/droark/received_events","type":"User","site_admin":false},"body":"If possible, I'd prefer that the Crypto++ make system be left alone for a couple of reasons.\r\n\r\n- At my last job, we used third-party packages and were basically told to leave the code alone whenever possible. Our build system would just kick off whatever it was given and leave it at that, unless there was a major problem that had to be addressed, specific values that had to be modified, etc. The idea of redoing a third-party Makefile, no matter how messy it may be, just seems like asking for trouble.\r\n- AFAIK, we're going to drop Crypto++ as soon as is feasible. Wei has seemingly abandoned it, and it's not fun to have to patch it every time a new version of GCC comes out.","created_at":"2015-08-10T01:02:40Z","updated_at":"2015-08-10T01:02:40Z","html_url":"https://github.com/etotheipi/BitcoinArmory/pull/304#discussion_r36596507","pull_request_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304","_links":{"self":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/comments/36596507"},"html":{"href":"https://github.com/etotheipi/BitcoinArmory/pull/304#discussion_r36596507"},"pull_request":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304","id":38679213,"html_url":"https://github.com/etotheipi/BitcoinArmory/pull/304","diff_url":"https://github.com/etotheipi/BitcoinArmory/pull/304.diff","patch_url":"https://github.com/etotheipi/BitcoinArmory/pull/304.patch","issue_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/304","number":304,"state":"open","locked":false,"title":"Autotools gitian 0.94","user":{"login":"josephbisch","id":665854,"avatar_url":"https://avatars.githubusercontent.com/u/665854?v=3","gravatar_id":"","url":"https://api.github.com/users/josephbisch","html_url":"https://github.com/josephbisch","followers_url":"https://api.github.com/users/josephbisch/followers","following_url":"https://api.github.com/users/josephbisch/following{/other_user}","gists_url":"https://api.github.com/users/josephbisch/gists{/gist_id}","starred_url":"https://api.github.com/users/josephbisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephbisch/subscriptions","organizations_url":"https://api.github.com/users/josephbisch/orgs","repos_url":"https://api.github.com/users/josephbisch/repos","events_url":"https://api.github.com/users/josephbisch/events{/privacy}","received_events_url":"https://api.github.com/users/josephbisch/received_events","type":"User","site_admin":false},"body":"@droark \r\n\r\nThis should be everything needed for deb packages with the Debian reproducible build toolchain and for the RPi version with Gitian with the exception of the signing stuff. I tested the RPi Gitian build and it reproduces exactly. Since my last reported status, it uses all native\\_qt48 dependencies from depends instead of from the package manager. The deb package scripts are not tested on this branch, but nothing should have changed from when I tested it on the other branch it was on and was able to reproduce the binary package (.deb).\r\n\r\nI moved the existing Makefiles to Makefile.old. The documentation will have to be updated to reflect that change. I think that is just the page on the website. I don't see any explanation of building from source within the actual Armory source tree.\r\n\r\nWe don't currently use the Linux Gitian descriptor. Unless we want to also offer a basic compressed version of the source tree after having built \\_CppBlockUtils.so, I suggest we delete the descriptor and just go with the scripts in dpkgfiles.\r\n\r\nThis PR being merged may cause conflicts when merging the Windows and OS X PRs in the future, because there are instances where there are differences due to the Windows and OS X PRs using Python 3 and this PR being reverted to Python 2, but we will just deal with resolving merge conflicts when we get to that point.\r\n\r\nI had to add native\\_qt48 and native versions of all of its dependencies. For Raspberry Pi, I only build native PyQt, host Python, and all of their dependencies (native Qt, native Python, etc.). This is because we don't bundle Python and Qt with the Raspberry Pi download. So we just need native PyQt for pyrcc4 and host Python for the Python libs.\r\n\r\nThat is why the packages/packages.mk file may look a little messy, due to only building certain packages if the architecture is not arm.\r\n\r\nThe Gitian descriptor for RPi relies on a compressed version of [the RPi tools](https://github.com/raspberrypi/tools) that can be added to gitian-build/inputs/ to make it accessible to Gitian.\r\n\r\n@theuni - The explanations you offered and changes you suggested in the past have been very helpful. It would mean a lot to me if you would take another look, particularly at the Gitian/depends stuff for Raspberry Pi. As I have already stated, I was able to reproduce the Raspberry Pi version of Armory, but I am sure there are things I don't do quite right or the optimal way.","created_at":"2015-06-26T18:59:47Z","updated_at":"2015-08-10T01:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec4d649d33bafa3e3f93536038f5f758c7ae151c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304/commits","review_comments_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304/comments","review_comment_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/304/comments","statuses_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/statuses/4dde4d246a77913e28dd92467b8172592ee586d4","head":{"label":"josephbisch:autotools-gitian-0.94","ref":"autotools-gitian-0.94","sha":"4dde4d246a77913e28dd92467b8172592ee586d4","user":{"login":"josephbisch","id":665854,"avatar_url":"https://avatars.githubusercontent.com/u/665854?v=3","gravatar_id":"","url":"https://api.github.com/users/josephbisch","html_url":"https://github.com/josephbisch","followers_url":"https://api.github.com/users/josephbisch/followers","following_url":"https://api.github.com/users/josephbisch/following{/other_user}","gists_url":"https://api.github.com/users/josephbisch/gists{/gist_id}","starred_url":"https://api.github.com/users/josephbisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephbisch/subscriptions","organizations_url":"https://api.github.com/users/josephbisch/orgs","repos_url":"https://api.github.com/users/josephbisch/repos","events_url":"https://api.github.com/users/josephbisch/events{/privacy}","received_events_url":"https://api.github.com/users/josephbisch/received_events","type":"User","site_admin":false},"repo":{"id":26604063,"name":"BitcoinArmory","full_name":"josephbisch/BitcoinArmory","owner":{"login":"josephbisch","id":665854,"avatar_url":"https://avatars.githubusercontent.com/u/665854?v=3","gravatar_id":"","url":"https://api.github.com/users/josephbisch","html_url":"https://github.com/josephbisch","followers_url":"https://api.github.com/users/josephbisch/followers","following_url":"https://api.github.com/users/josephbisch/following{/other_user}","gists_url":"https://api.github.com/users/josephbisch/gists{/gist_id}","starred_url":"https://api.github.com/users/josephbisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephbisch/subscriptions","organizations_url":"https://api.github.com/users/josephbisch/orgs","repos_url":"https://api.github.com/users/josephbisch/repos","events_url":"https://api.github.com/users/josephbisch/events{/privacy}","received_events_url":"https://api.github.com/users/josephbisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephbisch/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":true,"url":"https://api.github.com/repos/josephbisch/BitcoinArmory","forks_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/josephbisch/BitcoinArmory/releases{/id}","created_at":"2014-11-13T19:31:31Z","updated_at":"2014-11-18T23:20:19Z","pushed_at":"2015-08-10T00:59:29Z","git_url":"git://github.com/josephbisch/BitcoinArmory.git","ssh_url":"git@github.com:josephbisch/BitcoinArmory.git","clone_url":"https://github.com/josephbisch/BitcoinArmory.git","svn_url":"https://github.com/josephbisch/BitcoinArmory","homepage":"","size":81066,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"etotheipi:ffreeze","ref":"ffreeze","sha":"875ac898db1364cc4f707b16d1ed7d318058b929","user":{"login":"etotheipi","id":384526,"avatar_url":"https://avatars.githubusercontent.com/u/384526?v=3","gravatar_id":"","url":"https://api.github.com/users/etotheipi","html_url":"https://github.com/etotheipi","followers_url":"https://api.github.com/users/etotheipi/followers","following_url":"https://api.github.com/users/etotheipi/following{/other_user}","gists_url":"https://api.github.com/users/etotheipi/gists{/gist_id}","starred_url":"https://api.github.com/users/etotheipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etotheipi/subscriptions","organizations_url":"https://api.github.com/users/etotheipi/orgs","repos_url":"https://api.github.com/users/etotheipi/repos","events_url":"https://api.github.com/users/etotheipi/events{/privacy}","received_events_url":"https://api.github.com/users/etotheipi/received_events","type":"User","site_admin":false},"repo":{"id":2809086,"name":"BitcoinArmory","full_name":"etotheipi/BitcoinArmory","owner":{"login":"etotheipi","id":384526,"avatar_url":"https://avatars.githubusercontent.com/u/384526?v=3","gravatar_id":"","url":"https://api.github.com/users/etotheipi","html_url":"https://github.com/etotheipi","followers_url":"https://api.github.com/users/etotheipi/followers","following_url":"https://api.github.com/users/etotheipi/following{/other_user}","gists_url":"https://api.github.com/users/etotheipi/gists{/gist_id}","starred_url":"https://api.github.com/users/etotheipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etotheipi/subscriptions","organizations_url":"https://api.github.com/users/etotheipi/orgs","repos_url":"https://api.github.com/users/etotheipi/repos","events_url":"https://api.github.com/users/etotheipi/events{/privacy}","received_events_url":"https://api.github.com/users/etotheipi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etotheipi/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":false,"url":"https://api.github.com/repos/etotheipi/BitcoinArmory","forks_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/etotheipi/BitcoinArmory/releases{/id}","created_at":"2011-11-19T14:46:58Z","updated_at":"2015-08-05T21:37:37Z","pushed_at":"2015-08-10T00:59:30Z","git_url":"git://github.com/etotheipi/BitcoinArmory.git","ssh_url":"git@github.com:etotheipi/BitcoinArmory.git","clone_url":"https://github.com/etotheipi/BitcoinArmory.git","svn_url":"https://github.com/etotheipi/BitcoinArmory","homepage":"","size":93697,"stargazers_count":446,"watchers_count":446,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":192,"forks":221,"open_issues":192,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304"},"html":{"href":"https://github.com/etotheipi/BitcoinArmory/pull/304"},"issue":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/304"},"comments":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/etotheipi/BitcoinArmory/statuses/4dde4d246a77913e28dd92467b8172592ee586d4"}}}}