{"action":"opened","number":7682,"pull_request":{"url":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682","id":30815130,"html_url":"https://github.com/woothemes/woocommerce/pull/7682","diff_url":"https://github.com/woothemes/woocommerce/pull/7682.diff","patch_url":"https://github.com/woothemes/woocommerce/pull/7682.patch","issue_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7682","number":7682,"state":"open","locked":false,"title":"[2.3] Fix: Handling of zero min/max input qty attributes in scripts","user":{"login":"franticpsyx","id":1783726,"avatar_url":"https://avatars.githubusercontent.com/u/1783726?v=3","gravatar_id":"","url":"https://api.github.com/users/franticpsyx","html_url":"https://github.com/franticpsyx","followers_url":"https://api.github.com/users/franticpsyx/followers","following_url":"https://api.github.com/users/franticpsyx/following{/other_user}","gists_url":"https://api.github.com/users/franticpsyx/gists{/gist_id}","starred_url":"https://api.github.com/users/franticpsyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franticpsyx/subscriptions","organizations_url":"https://api.github.com/users/franticpsyx/orgs","repos_url":"https://api.github.com/users/franticpsyx/repos","events_url":"https://api.github.com/users/franticpsyx/events{/privacy}","received_events_url":"https://api.github.com/users/franticpsyx/received_events","type":"User","site_admin":false},"body":"Currently, the add-to-cart-variation script removes min/max qty attributes when `variation.min_qty` or `variation.max_qty` is `0`. When that happens, negative qty values may be entered.\r\n\r\nSimilarly, zero min qty values are not handled correctly when initializing qty inputs in `woocommerce.js`.\r\n\r\nPlease consider any possible implications of these changes in other edge cases.\r\n- the `woocommerce.js` change shouldn't have any adverse effects when the min/max attributes are undefined or empty.\r\n- the `add-to-cart-variation.js` fix could be improved.\r\n\r\nref - https://woothemes.zendesk.com/agent/tickets/267057","created_at":"2015-03-10T01:12:36Z","updated_at":"2015-03-10T01:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682/commits","review_comments_url":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682/comments","review_comment_url":"https://api.github.com/repos/woothemes/woocommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7682/comments","statuses_url":"https://api.github.com/repos/woothemes/woocommerce/statuses/c11399cb5256f8f66d62a59533a962e2bddc5c81","head":{"label":"franticpsyx:variations_min_max_quantity_js","ref":"variations_min_max_quantity_js","sha":"c11399cb5256f8f66d62a59533a962e2bddc5c81","user":{"login":"franticpsyx","id":1783726,"avatar_url":"https://avatars.githubusercontent.com/u/1783726?v=3","gravatar_id":"","url":"https://api.github.com/users/franticpsyx","html_url":"https://github.com/franticpsyx","followers_url":"https://api.github.com/users/franticpsyx/followers","following_url":"https://api.github.com/users/franticpsyx/following{/other_user}","gists_url":"https://api.github.com/users/franticpsyx/gists{/gist_id}","starred_url":"https://api.github.com/users/franticpsyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franticpsyx/subscriptions","organizations_url":"https://api.github.com/users/franticpsyx/orgs","repos_url":"https://api.github.com/users/franticpsyx/repos","events_url":"https://api.github.com/users/franticpsyx/events{/privacy}","received_events_url":"https://api.github.com/users/franticpsyx/received_events","type":"User","site_admin":false},"repo":{"id":4616567,"name":"woocommerce","full_name":"franticpsyx/woocommerce","owner":{"login":"franticpsyx","id":1783726,"avatar_url":"https://avatars.githubusercontent.com/u/1783726?v=3","gravatar_id":"","url":"https://api.github.com/users/franticpsyx","html_url":"https://github.com/franticpsyx","followers_url":"https://api.github.com/users/franticpsyx/followers","following_url":"https://api.github.com/users/franticpsyx/following{/other_user}","gists_url":"https://api.github.com/users/franticpsyx/gists{/gist_id}","starred_url":"https://api.github.com/users/franticpsyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franticpsyx/subscriptions","organizations_url":"https://api.github.com/users/franticpsyx/orgs","repos_url":"https://api.github.com/users/franticpsyx/repos","events_url":"https://api.github.com/users/franticpsyx/events{/privacy}","received_events_url":"https://api.github.com/users/franticpsyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franticpsyx/woocommerce","description":"An open source eCommerce plugin for WordPress created by WooThemes.","fork":true,"url":"https://api.github.com/repos/franticpsyx/woocommerce","forks_url":"https://api.github.com/repos/franticpsyx/woocommerce/forks","keys_url":"https://api.github.com/repos/franticpsyx/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franticpsyx/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franticpsyx/woocommerce/teams","hooks_url":"https://api.github.com/repos/franticpsyx/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/franticpsyx/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/franticpsyx/woocommerce/events","assignees_url":"https://api.github.com/repos/franticpsyx/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/franticpsyx/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/franticpsyx/woocommerce/tags","blobs_url":"https://api.github.com/repos/franticpsyx/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franticpsyx/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franticpsyx/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/franticpsyx/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franticpsyx/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/franticpsyx/woocommerce/languages","stargazers_url":"https://api.github.com/repos/franticpsyx/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/franticpsyx/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/franticpsyx/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/franticpsyx/woocommerce/subscription","commits_url":"https://api.github.com/repos/franticpsyx/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/franticpsyx/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/franticpsyx/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/franticpsyx/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/franticpsyx/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/franticpsyx/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franticpsyx/woocommerce/merges","archive_url":"https://api.github.com/repos/franticpsyx/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franticpsyx/woocommerce/downloads","issues_url":"https://api.github.com/repos/franticpsyx/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/franticpsyx/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/franticpsyx/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/franticpsyx/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franticpsyx/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/franticpsyx/woocommerce/releases{/id}","created_at":"2012-06-10T16:42:01Z","updated_at":"2015-03-10T00:35:05Z","pushed_at":"2015-03-10T01:06:20Z","git_url":"git://github.com/franticpsyx/woocommerce.git","ssh_url":"git@github.com:franticpsyx/woocommerce.git","clone_url":"https://github.com/franticpsyx/woocommerce.git","svn_url":"https://github.com/franticpsyx/woocommerce","homepage":"http://www.woothemes.com/woocommerce/","size":91202,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"woothemes:master","ref":"master","sha":"b5d64ba9328ce7094dc26b40d77e7e4c99da511c","user":{"login":"woothemes","id":473596,"avatar_url":"https://avatars.githubusercontent.com/u/473596?v=3","gravatar_id":"","url":"https://api.github.com/users/woothemes","html_url":"https://github.com/woothemes","followers_url":"https://api.github.com/users/woothemes/followers","following_url":"https://api.github.com/users/woothemes/following{/other_user}","gists_url":"https://api.github.com/users/woothemes/gists{/gist_id}","starred_url":"https://api.github.com/users/woothemes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woothemes/subscriptions","organizations_url":"https://api.github.com/users/woothemes/orgs","repos_url":"https://api.github.com/users/woothemes/repos","events_url":"https://api.github.com/users/woothemes/events{/privacy}","received_events_url":"https://api.github.com/users/woothemes/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woothemes/woocommerce","owner":{"login":"woothemes","id":473596,"avatar_url":"https://avatars.githubusercontent.com/u/473596?v=3","gravatar_id":"","url":"https://api.github.com/users/woothemes","html_url":"https://github.com/woothemes","followers_url":"https://api.github.com/users/woothemes/followers","following_url":"https://api.github.com/users/woothemes/following{/other_user}","gists_url":"https://api.github.com/users/woothemes/gists{/gist_id}","starred_url":"https://api.github.com/users/woothemes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woothemes/subscriptions","organizations_url":"https://api.github.com/users/woothemes/orgs","repos_url":"https://api.github.com/users/woothemes/repos","events_url":"https://api.github.com/users/woothemes/events{/privacy}","received_events_url":"https://api.github.com/users/woothemes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woothemes/woocommerce","description":"An open source eCommerce plugin for WordPress created by WooThemes.","fork":false,"url":"https://api.github.com/repos/woothemes/woocommerce","forks_url":"https://api.github.com/repos/woothemes/woocommerce/forks","keys_url":"https://api.github.com/repos/woothemes/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woothemes/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woothemes/woocommerce/teams","hooks_url":"https://api.github.com/repos/woothemes/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woothemes/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woothemes/woocommerce/events","assignees_url":"https://api.github.com/repos/woothemes/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woothemes/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woothemes/woocommerce/tags","blobs_url":"https://api.github.com/repos/woothemes/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woothemes/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woothemes/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woothemes/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woothemes/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woothemes/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woothemes/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woothemes/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woothemes/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woothemes/woocommerce/subscription","commits_url":"https://api.github.com/repos/woothemes/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woothemes/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woothemes/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woothemes/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woothemes/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woothemes/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woothemes/woocommerce/merges","archive_url":"https://api.github.com/repos/woothemes/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woothemes/woocommerce/downloads","issues_url":"https://api.github.com/repos/woothemes/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woothemes/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woothemes/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woothemes/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woothemes/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woothemes/woocommerce/releases{/id}","created_at":"2011-08-09T15:12:11Z","updated_at":"2015-03-10T00:45:43Z","pushed_at":"2015-03-09T18:07:07Z","git_url":"git://github.com/woothemes/woocommerce.git","ssh_url":"git@github.com:woothemes/woocommerce.git","clone_url":"https://github.com/woothemes/woocommerce.git","svn_url":"https://github.com/woothemes/woocommerce","homepage":"http://www.woothemes.com/woocommerce/","size":129100,"stargazers_count":1891,"watchers_count":1891,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1453,"mirror_url":null,"open_issues_count":65,"forks":1453,"open_issues":65,"watchers":1891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682"},"html":{"href":"https://github.com/woothemes/woocommerce/pull/7682"},"issue":{"href":"https://api.github.com/repos/woothemes/woocommerce/issues/7682"},"comments":{"href":"https://api.github.com/repos/woothemes/woocommerce/issues/7682/comments"},"review_comments":{"href":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682/comments"},"review_comment":{"href":"https://api.github.com/repos/woothemes/woocommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woothemes/woocommerce/pulls/7682/commits"},"statuses":{"href":"https://api.github.com/repos/woothemes/woocommerce/statuses/c11399cb5256f8f66d62a59533a962e2bddc5c81"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":2}}