{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoinjs/bip38/issues/13","labels_url":"https://api.github.com/repos/bitcoinjs/bip38/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/bitcoinjs/bip38/issues/13/comments","events_url":"https://api.github.com/repos/bitcoinjs/bip38/issues/13/events","html_url":"https://github.com/bitcoinjs/bip38/pull/13","id":103201546,"number":13,"title":"2.0.0","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoinjs/bip38/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=3","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bitcoinjs/bip38/milestones/2","html_url":"https://github.com/bitcoinjs/bip38/milestones/2.0.0","labels_url":"https://api.github.com/repos/bitcoinjs/bip38/milestones/2/labels","id":1272946,"number":2,"title":"2.0.0","description":null,"creator":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-08-26T07:51:45Z","updated_at":"2015-08-26T07:51:45Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-08-26T07:51:39Z","updated_at":"2015-08-27T19:13:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bip38/pulls/13","html_url":"https://github.com/bitcoinjs/bip38/pull/13","diff_url":"https://github.com/bitcoinjs/bip38/pull/13.diff","patch_url":"https://github.com/bitcoinjs/bip38/pull/13.patch"},"body":"Resolves all remaining points in https://github.com/bitcoinjs/bip38/issues/5.\r\nSpecifically:\r\n\r\n* consider removing coinstring [DONE]\r\n* consider removing class instantiation, ~~pass script params as optional param~~ [DONE]\r\n\r\nScript params were not put as optional, as there has been at least some consensus over time that the parameters given are suitable.\r\nHappy to revise that.\r\n\r\nI did not only keep the raw methods, as I felt the base58check encoded BIP38 string was important and specific to the encoding of this module.\r\n\r\nInstead, I remove encoding/decoding of WIF format private keys as part of the `encrypt` interface.  You now specifically pass in a private key 32-byte buffer with a compression flag."},"comment":{"url":"https://api.github.com/repos/bitcoinjs/bip38/issues/comments/135526826","html_url":"https://github.com/bitcoinjs/bip38/pull/13#issuecomment-135526826","issue_url":"https://api.github.com/repos/bitcoinjs/bip38/issues/13","id":135526826,"user":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=3","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T19:13:15Z","updated_at":"2015-08-27T19:13:15Z","body":"> It is an implicit contract of state for something that isn't stateful.\r\n\r\nBut there is state, namely the scrypt parameters."}}