{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/48108421","id":48108421,"diff_hunk":"@@ -128,19 +128,26 @@\n      * and job/user association.\n      */\n     private void recover(SchedulerStateImpl sState) {\n+        Vector<JobState> pendingJobs = sState.getPendingJobs();\n+        Vector<JobState> runningJobs = sState.getRunningJobs();\n+        Vector<JobState> finishedJobs = sState.getFinishedJobs();","path":"scheduler/scheduler-server/src/main/java/org/ow2/proactive/scheduler/core/SchedulerFrontendState.java","position":6,"original_position":6,"commit_id":"8ee99e04bf2fc6f38a22ad13fd43ee577674931c","original_commit_id":"8ee99e04bf2fc6f38a22ad13fd43ee577674931c","user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars.githubusercontent.com/u/14940028?v=3","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Replace the synchronized class \"Vector\" by an unsynchronized one such as \"ArrayList\" or \"LinkedList\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1149)\n","created_at":"2015-12-20T21:27:23Z","updated_at":"2015-12-20T21:27:23Z","html_url":"https://github.com/ow2-proactive/scheduling/pull/2419#discussion_r48108421","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/48108421"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/2419#discussion_r48108421"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419","id":54121584,"html_url":"https://github.com/ow2-proactive/scheduling/pull/2419","diff_url":"https://github.com/ow2-proactive/scheduling/pull/2419.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/2419.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2419","number":2419,"state":"open","locked":false,"title":"Improve tests related to job recovery","user":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"body":"The main changes are summarized below:\r\n\r\n  - Some clean up while reading code related to job recovery\r\n  - Add test for RecoveredSchedulerState\r\n  - Add tests for SchedulerStateRecoverHelper\r\n  - Remove and replace tests related to recovery by others running against the database.","created_at":"2015-12-18T16:27:36Z","updated_at":"2015-12-20T21:27:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47f9d59016e5f8893fe1c7cbbb488b4ee432b534","assignee":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones/40","html_url":"https://github.com/ow2-proactive/scheduling/milestones/7.2.0","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones/40/labels","id":1466968,"number":40,"title":"7.2.0","description":"","creator":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-12-18T16:29:08Z","updated_at":"2015-12-18T16:39:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2419/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/8ee99e04bf2fc6f38a22ad13fd43ee577674931c","head":{"label":"lpellegr:improvement/tests-related-to-job-recovery","ref":"improvement/tests-related-to-job-recovery","sha":"8ee99e04bf2fc6f38a22ad13fd43ee577674931c","user":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"repo":{"id":35726762,"name":"scheduling","full_name":"lpellegr/scheduling","owner":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpellegr/scheduling","description":"Multi-platform Scheduling and Workflows engine","fork":true,"url":"https://api.github.com/repos/lpellegr/scheduling","forks_url":"https://api.github.com/repos/lpellegr/scheduling/forks","keys_url":"https://api.github.com/repos/lpellegr/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpellegr/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpellegr/scheduling/teams","hooks_url":"https://api.github.com/repos/lpellegr/scheduling/hooks","issue_events_url":"https://api.github.com/repos/lpellegr/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/lpellegr/scheduling/events","assignees_url":"https://api.github.com/repos/lpellegr/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/lpellegr/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/lpellegr/scheduling/tags","blobs_url":"https://api.github.com/repos/lpellegr/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpellegr/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpellegr/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpellegr/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpellegr/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/lpellegr/scheduling/languages","stargazers_url":"https://api.github.com/repos/lpellegr/scheduling/stargazers","contributors_url":"https://api.github.com/repos/lpellegr/scheduling/contributors","subscribers_url":"https://api.github.com/repos/lpellegr/scheduling/subscribers","subscription_url":"https://api.github.com/repos/lpellegr/scheduling/subscription","commits_url":"https://api.github.com/repos/lpellegr/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpellegr/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpellegr/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpellegr/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpellegr/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/lpellegr/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpellegr/scheduling/merges","archive_url":"https://api.github.com/repos/lpellegr/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpellegr/scheduling/downloads","issues_url":"https://api.github.com/repos/lpellegr/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/lpellegr/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/lpellegr/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/lpellegr/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpellegr/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/lpellegr/scheduling/releases{/id}","created_at":"2015-05-16T14:28:51Z","updated_at":"2015-05-16T14:29:04Z","pushed_at":"2015-12-20T20:09:04Z","git_url":"git://github.com/lpellegr/scheduling.git","ssh_url":"git@github.com:lpellegr/scheduling.git","clone_url":"https://github.com/lpellegr/scheduling.git","svn_url":"https://github.com/lpellegr/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":54496,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"31ca67d0f46bed84984ec6c449309c40868d450b","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725079,"name":"scheduling","full_name":"ow2-proactive/scheduling","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling","description":"Multi-platform Scheduling and Workflows engine","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling/releases{/id}","created_at":"2015-05-16T13:38:55Z","updated_at":"2015-11-07T02:35:54Z","pushed_at":"2015-12-20T20:09:04Z","git_url":"git://github.com/ow2-proactive/scheduling.git","ssh_url":"git@github.com:ow2-proactive/scheduling.git","clone_url":"https://github.com/ow2-proactive/scheduling.git","svn_url":"https://github.com/ow2-proactive/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":53419,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":145,"forks":10,"open_issues":145,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/2419"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2419"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2419/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2419/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/8ee99e04bf2fc6f38a22ad13fd43ee577674931c"}}}}