{"action":"created","issue":{"url":"https://api.github.com/repos/drush-ops/drush/issues/1134","labels_url":"https://api.github.com/repos/drush-ops/drush/issues/1134/labels{/name}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/1134/comments","events_url":"https://api.github.com/repos/drush-ops/drush/issues/1134/events","html_url":"https://github.com/drush-ops/drush/issues/1134","id":55982781,"number":1134,"title":"Passwords with slashes breaks parsing of --db-url ","user":{"login":"hansfn","id":92755,"avatar_url":"https://avatars.githubusercontent.com/u/92755?v=3","gravatar_id":"","url":"https://api.github.com/users/hansfn","html_url":"https://github.com/hansfn","followers_url":"https://api.github.com/users/hansfn/followers","following_url":"https://api.github.com/users/hansfn/following{/other_user}","gists_url":"https://api.github.com/users/hansfn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansfn/subscriptions","organizations_url":"https://api.github.com/users/hansfn/orgs","repos_url":"https://api.github.com/users/hansfn/repos","events_url":"https://api.github.com/users/hansfn/events{/privacy}","received_events_url":"https://api.github.com/users/hansfn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-30T01:24:38Z","updated_at":"2015-01-31T16:53:23Z","closed_at":null,"body":"I'm auto-generating passwords for MySQL and tried to use one of them when running site-install. It failed. It took some tries before I noticed the problem - see simplified example:\r\n\r\n```\r\n$ drush site-install standard --db-url=mysql://drush_si_test:12/34@localhost/drush_si_test\r\nYou are about to CREATE the '34@localhost/drush_si_test' database. Do you want to continue? (y/n): n\r\n```\r\nThe database name is wrong because of the slash in the password - '34@localhost/drush_si_test' versus the expected 'drush_si_test'. The reason this happens is that function drush_convert_db_from_db_url (in includes/sitealias.inc) uses parse_url to parse the DB URL.\r\n\r\nOne solution is to document that Drush doesn't support passwords with slashes. Another is to introduce some type of escaping of the slash.\r\n\r\nI think the best fix is to parse the db-url string manually. I'm happy to write a patch if people think Drush should handle passwords with slashes.\r\n\r\nPS! This has been discussed and turned down before -  see https://www.drupal.org/node/1526858 "},"comment":{"url":"https://api.github.com/repos/drush-ops/drush/issues/comments/72325641","html_url":"https://github.com/drush-ops/drush/issues/1134#issuecomment-72325641","issue_url":"https://api.github.com/repos/drush-ops/drush/issues/1134","id":72325641,"user":{"login":"dpi","id":21850,"avatar_url":"https://avatars.githubusercontent.com/u/21850?v=3","gravatar_id":"","url":"https://api.github.com/users/dpi","html_url":"https://github.com/dpi","followers_url":"https://api.github.com/users/dpi/followers","following_url":"https://api.github.com/users/dpi/following{/other_user}","gists_url":"https://api.github.com/users/dpi/gists{/gist_id}","starred_url":"https://api.github.com/users/dpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpi/subscriptions","organizations_url":"https://api.github.com/users/dpi/orgs","repos_url":"https://api.github.com/users/dpi/repos","events_url":"https://api.github.com/users/dpi/events{/privacy}","received_events_url":"https://api.github.com/users/dpi/received_events","type":"User","site_admin":false},"created_at":"2015-01-31T16:53:23Z","updated_at":"2015-01-31T16:53:23Z","body":"The connect string is a URL scheme, you should urlencode your password as a slash character will mess things up. The other issue is not quite the same."}}