{"action":"closed","number":538,"pull_request":{"url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538","id":19596106,"html_url":"https://github.com/cjohansen/Sinon.JS/pull/538","diff_url":"https://github.com/cjohansen/Sinon.JS/pull/538.diff","patch_url":"https://github.com/cjohansen/Sinon.JS/pull/538.patch","issue_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/538","number":538,"state":"closed","locked":false,"title":"Browserify","user":{"login":"mroderick","id":20321,"avatar_url":"https://avatars.githubusercontent.com/u/20321?v=3","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"body":"This pull request is an(other) attempt at using [browserify](http://browserify.org).\r\n\r\nThis is very much under :construction:, I am opening it so we can discuss approaches and outstanding issues.\r\n\r\n---\r\n\r\nThe `lib/sinon.js` file would build up the top level of the api by requiring all the relevant files.\r\n\r\nWe should probably make a decision on whether or not we're going to keep the API unchanged or clean it up and create a new major version. For instance, is it essential that `sinon.format` is public? @cjohansen @mantoni, what you do think?\r\n\r\nSo far, I've been working with the idea of splitting everything into it's own file and reduce dependencies between the different parts of Sinon. Thus, the circular dependency between `deepEqual` and `sinon.match` has been broken. Unless I hear otherwise, I'll continue down this path.\r\n\r\n---\r\n\r\nYou can run the tests in vanilla Buster with\r\n\r\n```\r\n$(npm bin)/buster-test --config test-buster/buster.js\r\n```","created_at":"2014-08-11T11:50:12Z","updated_at":"2015-02-02T21:17:18Z","closed_at":"2015-02-02T21:17:18Z","merged_at":null,"merge_commit_sha":"62e4c2186032d1e071135884962fb9229aca79c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538/commits","review_comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538/comments","review_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/538/comments","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/a4d2735dbd075818fa34ac9b527e1d5da7a421b4","head":{"label":"mroderick:browserify","ref":"browserify","sha":"a4d2735dbd075818fa34ac9b527e1d5da7a421b4","user":{"login":"mroderick","id":20321,"avatar_url":"https://avatars.githubusercontent.com/u/20321?v=3","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"repo":{"id":1342453,"name":"Sinon.JS","full_name":"mroderick/Sinon.JS","owner":{"login":"mroderick","id":20321,"avatar_url":"https://avatars.githubusercontent.com/u/20321?v=3","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroderick/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/mroderick/Sinon.JS","forks_url":"https://api.github.com/repos/mroderick/Sinon.JS/forks","keys_url":"https://api.github.com/repos/mroderick/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroderick/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroderick/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/mroderick/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/mroderick/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/mroderick/Sinon.JS/events","assignees_url":"https://api.github.com/repos/mroderick/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/mroderick/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/mroderick/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/mroderick/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroderick/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroderick/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroderick/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroderick/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/mroderick/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/mroderick/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/mroderick/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/mroderick/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/mroderick/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/mroderick/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroderick/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroderick/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroderick/Sinon.JS/issues/comments/{number}","contents_url":"https://api.github.com/repos/mroderick/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/mroderick/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroderick/Sinon.JS/merges","archive_url":"https://api.github.com/repos/mroderick/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroderick/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/mroderick/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/mroderick/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/mroderick/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/mroderick/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroderick/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/mroderick/Sinon.JS/releases{/id}","created_at":"2011-02-08T15:47:25Z","updated_at":"2015-02-02T21:05:09Z","pushed_at":"2015-02-02T21:15:28Z","git_url":"git://github.com/mroderick/Sinon.JS.git","ssh_url":"git@github.com:mroderick/Sinon.JS.git","clone_url":"https://github.com/mroderick/Sinon.JS.git","svn_url":"https://github.com/mroderick/Sinon.JS","homepage":"http://cjohansen.no/sinon/","size":2142,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cjohansen:master","ref":"master","sha":"583c736fbe48a1cb771ed3db1cdc4ec14f7a2247","user":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"repo":{"id":747698,"name":"Sinon.JS","full_name":"cjohansen/Sinon.JS","owner":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjohansen/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/cjohansen/Sinon.JS","forks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/forks","keys_url":"https://api.github.com/repos/cjohansen/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjohansen/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjohansen/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/events","assignees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/cjohansen/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/cjohansen/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/comments/{number}","contents_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/cjohansen/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjohansen/Sinon.JS/merges","archive_url":"https://api.github.com/repos/cjohansen/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjohansen/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/cjohansen/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/cjohansen/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjohansen/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/cjohansen/Sinon.JS/releases{/id}","created_at":"2010-06-29T21:15:32Z","updated_at":"2015-02-02T21:15:27Z","pushed_at":"2015-02-02T21:15:27Z","git_url":"git://github.com/cjohansen/Sinon.JS.git","ssh_url":"git@github.com:cjohansen/Sinon.JS.git","clone_url":"https://github.com/cjohansen/Sinon.JS.git","svn_url":"https://github.com/cjohansen/Sinon.JS","homepage":"http://sinonjs.org/","size":3648,"stargazers_count":1827,"watchers_count":1827,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":77,"forks":300,"open_issues":77,"watchers":1827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538"},"html":{"href":"https://github.com/cjohansen/Sinon.JS/pull/538"},"issue":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/538"},"comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/a4d2735dbd075818fa34ac9b527e1d5da7a421b4"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"commits":8,"additions":1465,"deletions":318,"changed_files":17}}