{"action":"created","comment":{"url":"https://api.github.com/repos/mesos/mesos-go/pulls/comments/38144678","id":38144678,"diff_hunk":"@@ -88,14 +88,22 @@ func NewMesosExecutorDriver(config DriverConfig) (*MesosExecutorDriver, error) {\n \t}\n \n \tdriver := &MesosExecutorDriver{\n-\t\texec:      config.Executor,\n-\t\tstatus:    mesosproto.Status_DRIVER_NOT_STARTED,\n-\t\tstopCh:    make(chan struct{}),\n-\t\tdestroyCh: make(chan struct{}),\n-\t\tstopped:   true,\n-\t\tupdates:   make(map[string]*mesosproto.StatusUpdate),\n-\t\ttasks:     make(map[string]*mesosproto.TaskInfo),\n-\t\tworkDir:   \".\",\n+\t\tstatus:  mesosproto.Status_DRIVER_NOT_STARTED,\n+\t\tstopCh:  make(chan struct{}),\n+\t\tupdates: make(map[string]*mesosproto.StatusUpdate),\n+\t\ttasks:   make(map[string]*mesosproto.TaskInfo),\n+\t\tworkDir: \".\",\n+\t\tstarted: make(chan struct{}),\n+\t}\n+\tdriver.cond = sync.NewCond(&driver.lock)\n+\t// decouple serialized executor callback execution from goroutines of this driver\n+\tvar execLock sync.Mutex\n+\tdriver.withExecutor = func(f func(e Executor)) {\n+\t\tgo func() {","path":"executor/executor.go","position":45,"original_position":45,"commit_id":"29683b3a38e60151d5eba86fe5a3df5902739309","original_commit_id":"29683b3a38e60151d5eba86fe5a3df5902739309","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"status updates are expected to be delivered in-order. are they timestamped? what's the delivery window look like? how strict is this?","created_at":"2015-08-27T20:52:41Z","updated_at":"2015-08-27T20:52:41Z","html_url":"https://github.com/mesos/mesos-go/pull/159#discussion_r38144678","pull_request_url":"https://api.github.com/repos/mesos/mesos-go/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/comments/38144678"},"html":{"href":"https://github.com/mesos/mesos-go/pull/159#discussion_r38144678"},"pull_request":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/mesos/mesos-go/pulls/159","id":42646529,"html_url":"https://github.com/mesos/mesos-go/pull/159","diff_url":"https://github.com/mesos/mesos-go/pull/159.diff","patch_url":"https://github.com/mesos/mesos-go/pull/159.patch","issue_url":"https://api.github.com/repos/mesos/mesos-go/issues/159","number":159,"state":"open","locked":false,"title":"WIP: align uuid/ack handling with core scheduler driver, and MORE","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"motivation:\r\n- fixes #156 \r\n\r\nother things that happened on the way:\r\n- i want all the unit tests passing (kill the data races!)\r\n- i want the synchronization code in the scheduler and executor to be (more) reasonable (helps with the above)\r\n- updated godeps to latest samuel/go-zookeeper\r\n- `make check` should ignore files in `Godeps/`\r\n- use travis' container-based infra\r\n- hijack the net/http server connections to implement decoding that's compat with mesos libprocess\r\n\r\ntodo:\r\n- [ ] unit test for `updateRequiresAck` logic\r\n- [x] fix remaining zk test flakes\r\n- [x] test example scheduler/executor against running mesos cluster\r\n- [ ] the HTTP lib workarounds currently require go1.5 -- this probably won't work for all frameworks that require 1.3/1.4 API compat.\r\n\r\nxref https://issues.apache.org/jira/browse/MESOS-2865","created_at":"2015-08-17T23:33:46Z","updated_at":"2015-08-27T20:52:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9399b62b9906e99363ab90699a1f297f330523cc","assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mesos/mesos-go/pulls/159/commits","review_comments_url":"https://api.github.com/repos/mesos/mesos-go/pulls/159/comments","review_comment_url":"https://api.github.com/repos/mesos/mesos-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesos/mesos-go/issues/159/comments","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/29683b3a38e60151d5eba86fe5a3df5902739309","head":{"label":"mesos:fix-acking-non-slave-updates","ref":"fix-acking-non-slave-updates","sha":"29683b3a38e60151d5eba86fe5a3df5902739309","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":14454411,"name":"mesos-go","full_name":"mesos/mesos-go","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/mesos-go","description":"Go language bindings for Apache Mesos","fork":false,"url":"https://api.github.com/repos/mesos/mesos-go","forks_url":"https://api.github.com/repos/mesos/mesos-go/forks","keys_url":"https://api.github.com/repos/mesos/mesos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/mesos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/mesos-go/teams","hooks_url":"https://api.github.com/repos/mesos/mesos-go/hooks","issue_events_url":"https://api.github.com/repos/mesos/mesos-go/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/mesos-go/events","assignees_url":"https://api.github.com/repos/mesos/mesos-go/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/mesos-go/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/mesos-go/tags","blobs_url":"https://api.github.com/repos/mesos/mesos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/mesos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/mesos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/mesos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/mesos-go/languages","stargazers_url":"https://api.github.com/repos/mesos/mesos-go/stargazers","contributors_url":"https://api.github.com/repos/mesos/mesos-go/contributors","subscribers_url":"https://api.github.com/repos/mesos/mesos-go/subscribers","subscription_url":"https://api.github.com/repos/mesos/mesos-go/subscription","commits_url":"https://api.github.com/repos/mesos/mesos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/mesos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/mesos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/mesos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/mesos-go/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/mesos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/mesos-go/merges","archive_url":"https://api.github.com/repos/mesos/mesos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/mesos-go/downloads","issues_url":"https://api.github.com/repos/mesos/mesos-go/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/mesos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/mesos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/mesos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/mesos-go/labels{/name}","releases_url":"https://api.github.com/repos/mesos/mesos-go/releases{/id}","created_at":"2013-11-16T20:40:30Z","updated_at":"2015-08-26T23:06:53Z","pushed_at":"2015-08-22T07:52:23Z","git_url":"git://github.com/mesos/mesos-go.git","ssh_url":"git@github.com:mesos/mesos-go.git","clone_url":"https://github.com/mesos/mesos-go.git","svn_url":"https://github.com/mesos/mesos-go","homepage":"","size":10269,"stargazers_count":237,"watchers_count":237,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":28,"forks":59,"open_issues":28,"watchers":237,"default_branch":"master"}},"base":{"label":"mesos:master","ref":"master","sha":"d23a18b51b1ddf4072a223b38cc8d05cffb1ea42","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":14454411,"name":"mesos-go","full_name":"mesos/mesos-go","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/mesos-go","description":"Go language bindings for Apache Mesos","fork":false,"url":"https://api.github.com/repos/mesos/mesos-go","forks_url":"https://api.github.com/repos/mesos/mesos-go/forks","keys_url":"https://api.github.com/repos/mesos/mesos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/mesos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/mesos-go/teams","hooks_url":"https://api.github.com/repos/mesos/mesos-go/hooks","issue_events_url":"https://api.github.com/repos/mesos/mesos-go/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/mesos-go/events","assignees_url":"https://api.github.com/repos/mesos/mesos-go/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/mesos-go/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/mesos-go/tags","blobs_url":"https://api.github.com/repos/mesos/mesos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/mesos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/mesos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/mesos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/mesos-go/languages","stargazers_url":"https://api.github.com/repos/mesos/mesos-go/stargazers","contributors_url":"https://api.github.com/repos/mesos/mesos-go/contributors","subscribers_url":"https://api.github.com/repos/mesos/mesos-go/subscribers","subscription_url":"https://api.github.com/repos/mesos/mesos-go/subscription","commits_url":"https://api.github.com/repos/mesos/mesos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/mesos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/mesos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/mesos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/mesos-go/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/mesos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/mesos-go/merges","archive_url":"https://api.github.com/repos/mesos/mesos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/mesos-go/downloads","issues_url":"https://api.github.com/repos/mesos/mesos-go/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/mesos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/mesos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/mesos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/mesos-go/labels{/name}","releases_url":"https://api.github.com/repos/mesos/mesos-go/releases{/id}","created_at":"2013-11-16T20:40:30Z","updated_at":"2015-08-26T23:06:53Z","pushed_at":"2015-08-22T07:52:23Z","git_url":"git://github.com/mesos/mesos-go.git","ssh_url":"git@github.com:mesos/mesos-go.git","clone_url":"https://github.com/mesos/mesos-go.git","svn_url":"https://github.com/mesos/mesos-go","homepage":"","size":10269,"stargazers_count":237,"watchers_count":237,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":28,"forks":59,"open_issues":28,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/159"},"html":{"href":"https://github.com/mesos/mesos-go/pull/159"},"issue":{"href":"https://api.github.com/repos/mesos/mesos-go/issues/159"},"comments":{"href":"https://api.github.com/repos/mesos/mesos-go/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/mesos/mesos-go/statuses/29683b3a38e60151d5eba86fe5a3df5902739309"}}}}