{"action":"closed","number":2944,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/2944","id":41963040,"html_url":"https://github.com/juju/juju/pull/2944","diff_url":"https://github.com/juju/juju/pull/2944.diff","patch_url":"https://github.com/juju/juju/pull/2944.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/2944","number":2944,"state":"closed","locked":false,"title":"consolidate Agent interface","user":{"login":"fwereade","id":372078,"avatar_url":"https://avatars.githubusercontent.com/u/372078?v=3","gravatar_id":"","url":"https://api.github.com/users/fwereade","html_url":"https://github.com/fwereade","followers_url":"https://api.github.com/users/fwereade/followers","following_url":"https://api.github.com/users/fwereade/following{/other_user}","gists_url":"https://api.github.com/users/fwereade/gists{/gist_id}","starred_url":"https://api.github.com/users/fwereade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwereade/subscriptions","organizations_url":"https://api.github.com/users/fwereade/orgs","repos_url":"https://api.github.com/users/fwereade/repos","events_url":"https://api.github.com/users/fwereade/events{/privacy}","received_events_url":"https://api.github.com/users/fwereade/received_events","type":"User","site_admin":false},"body":"Why:\r\n\r\nIt will make it easier to fully extract and properly test jujud/agent.OpenAPIState, which is my most immediate current goal on the way towards imposing some sanity on agents in general.\r\n\r\nWhat:\r\n\r\n  * cut Agent interface down to 2 methods, moved to top-level agent package\r\n  * moved OpenAPIState and associated code into jujud/agent/open.go\r\n  * cut a couple of interface-satisfying methods off AgentConf, represented them as wrapper types for Agent (which AgentConf already implements)\r\n  * dropped unnecessary params from OpenAPIState and OpenAPIStateUsingInfo\r\n  * deleted random dead code\r\n  * slightly improved the OpenAPIState testing embedded in machine/unit agent suites; too hard to extract it properly in this CL\n\n(Review request: http://reviews.vapour.ws/r/2323/)","created_at":"2015-08-09T00:23:17Z","updated_at":"2015-08-09T11:40:38Z","closed_at":"2015-08-09T11:40:38Z","merged_at":"2015-08-09T11:40:38Z","merge_commit_sha":"905454b56d8db70dce77d208e4e64e09874bf584","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/2944/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/d864ea25d7fa09c1123b15c107a1e4403b2e3955","head":{"label":"fwereade:ude5-consolidate-agent-interface","ref":"ude5-consolidate-agent-interface","sha":"d864ea25d7fa09c1123b15c107a1e4403b2e3955","user":{"login":"fwereade","id":372078,"avatar_url":"https://avatars.githubusercontent.com/u/372078?v=3","gravatar_id":"","url":"https://api.github.com/users/fwereade","html_url":"https://github.com/fwereade","followers_url":"https://api.github.com/users/fwereade/followers","following_url":"https://api.github.com/users/fwereade/following{/other_user}","gists_url":"https://api.github.com/users/fwereade/gists{/gist_id}","starred_url":"https://api.github.com/users/fwereade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwereade/subscriptions","organizations_url":"https://api.github.com/users/fwereade/orgs","repos_url":"https://api.github.com/users/fwereade/repos","events_url":"https://api.github.com/users/fwereade/events{/privacy}","received_events_url":"https://api.github.com/users/fwereade/received_events","type":"User","site_admin":false},"repo":{"id":22044674,"name":"juju","full_name":"fwereade/juju","owner":{"login":"fwereade","id":372078,"avatar_url":"https://avatars.githubusercontent.com/u/372078?v=3","gravatar_id":"","url":"https://api.github.com/users/fwereade","html_url":"https://github.com/fwereade","followers_url":"https://api.github.com/users/fwereade/followers","following_url":"https://api.github.com/users/fwereade/following{/other_user}","gists_url":"https://api.github.com/users/fwereade/gists{/gist_id}","starred_url":"https://api.github.com/users/fwereade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwereade/subscriptions","organizations_url":"https://api.github.com/users/fwereade/orgs","repos_url":"https://api.github.com/users/fwereade/repos","events_url":"https://api.github.com/users/fwereade/events{/privacy}","received_events_url":"https://api.github.com/users/fwereade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwereade/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/fwereade/juju","forks_url":"https://api.github.com/repos/fwereade/juju/forks","keys_url":"https://api.github.com/repos/fwereade/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwereade/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwereade/juju/teams","hooks_url":"https://api.github.com/repos/fwereade/juju/hooks","issue_events_url":"https://api.github.com/repos/fwereade/juju/issues/events{/number}","events_url":"https://api.github.com/repos/fwereade/juju/events","assignees_url":"https://api.github.com/repos/fwereade/juju/assignees{/user}","branches_url":"https://api.github.com/repos/fwereade/juju/branches{/branch}","tags_url":"https://api.github.com/repos/fwereade/juju/tags","blobs_url":"https://api.github.com/repos/fwereade/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwereade/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwereade/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwereade/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwereade/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/fwereade/juju/languages","stargazers_url":"https://api.github.com/repos/fwereade/juju/stargazers","contributors_url":"https://api.github.com/repos/fwereade/juju/contributors","subscribers_url":"https://api.github.com/repos/fwereade/juju/subscribers","subscription_url":"https://api.github.com/repos/fwereade/juju/subscription","commits_url":"https://api.github.com/repos/fwereade/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwereade/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwereade/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwereade/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwereade/juju/contents/{+path}","compare_url":"https://api.github.com/repos/fwereade/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwereade/juju/merges","archive_url":"https://api.github.com/repos/fwereade/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwereade/juju/downloads","issues_url":"https://api.github.com/repos/fwereade/juju/issues{/number}","pulls_url":"https://api.github.com/repos/fwereade/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/fwereade/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/fwereade/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwereade/juju/labels{/name}","releases_url":"https://api.github.com/repos/fwereade/juju/releases{/id}","created_at":"2014-07-20T22:14:05Z","updated_at":"2015-04-21T08:32:03Z","pushed_at":"2015-08-09T09:05:36Z","git_url":"git://github.com/fwereade/juju.git","ssh_url":"git@github.com:fwereade/juju.git","clone_url":"https://github.com/fwereade/juju.git","svn_url":"https://github.com/fwereade/juju","homepage":"juju.ubuntu.com","size":54581,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"d408b051cc52cd66394ad397964b025703fa33a1","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-08-09T00:51:44Z","pushed_at":"2015-08-09T11:40:38Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":89820,"stargazers_count":306,"watchers_count":306,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":78,"forks":102,"open_issues":78,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/2944"},"html":{"href":"https://github.com/juju/juju/pull/2944"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/2944"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/d864ea25d7fa09c1123b15c107a1e4403b2e3955"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":498,"deletions":403,"changed_files":12}}