{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/42472671","id":42472671,"diff_hunk":"@@ -330,11 +352,17 @@ void Connection::parseOptions(ICodeContext * ctx, const char * _options)\n         }\n     }\n }\n-void Connection::resetContextErr()\n+void Connection::reset()\n {\n     if (context)\n         context->err = REDIS_OK;\n }\n+void SubConnection::reset()\n+{\n+    Connection::reset();","path":"plugins/redis/redis.cpp","position":155,"original_position":155,"commit_id":"34e1165a442afa9cfe515f6c7efb8e194a83854f","original_commit_id":"23e429699e878c5d4bdb93892f17c9c9efe7477a","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"minor; Should this call be after the unsubscribe command?\r\n","created_at":"2015-10-20T09:20:46Z","updated_at":"2015-10-20T09:20:46Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853#discussion_r42472671","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/42472671"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853#discussion_r42472671"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853","id":47588402,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7853","number":7853,"state":"open","locked":false,"title":"HPCC-14286 Redis Plugin - add publish and subscribe functions","user":{"login":"jamienoss","id":5013975,"avatar_url":"https://avatars.githubusercontent.com/u/5013975?v=3","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"body":"Signed-off-by: James Noss <james.noss@lexisnexis.com>","created_at":"2015-10-13T21:05:22Z","updated_at":"2015-10-20T09:20:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b388a29f1164fa7a93e79e023d6c3e6c41f5f74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7853/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/34e1165a442afa9cfe515f6c7efb8e194a83854f","head":{"label":"jamienoss:issue14286-redis-plugin-add-independent-pub-sub-functionality-with-db","ref":"issue14286-redis-plugin-add-independent-pub-sub-functionality-with-db","sha":"34e1165a442afa9cfe515f6c7efb8e194a83854f","user":{"login":"jamienoss","id":5013975,"avatar_url":"https://avatars.githubusercontent.com/u/5013975?v=3","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"repo":{"id":12548948,"name":"HPCC-Platform","full_name":"jamienoss/HPCC-Platform","owner":{"login":"jamienoss","id":5013975,"avatar_url":"https://avatars.githubusercontent.com/u/5013975?v=3","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamienoss/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/jamienoss/HPCC-Platform","forks_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/jamienoss/HPCC-Platform/releases{/id}","created_at":"2013-09-02T20:57:07Z","updated_at":"2014-12-20T18:48:40Z","pushed_at":"2015-10-19T19:52:28Z","git_url":"git://github.com/jamienoss/HPCC-Platform.git","ssh_url":"git@github.com:jamienoss/HPCC-Platform.git","clone_url":"https://github.com/jamienoss/HPCC-Platform.git","svn_url":"https://github.com/jamienoss/HPCC-Platform","homepage":"track.hpccsystems.com","size":158932,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.0.0","ref":"candidate-6.0.0","sha":"b7006646c23123cd4275d8b1da3c8a445080e30d","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-10-14T13:56:56Z","pushed_at":"2015-10-20T08:47:32Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":345677,"stargazers_count":257,"watchers_count":257,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":429,"forks":123,"open_issues":429,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7853"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7853"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7853/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7853/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/34e1165a442afa9cfe515f6c7efb8e194a83854f"}}}}