{"action":"closed","issue":{"url":"https://api.github.com/repos/causes/overcommit/issues/150","labels_url":"https://api.github.com/repos/causes/overcommit/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/causes/overcommit/issues/150/comments","events_url":"https://api.github.com/repos/causes/overcommit/issues/150/events","html_url":"https://github.com/causes/overcommit/issues/150","id":64434967,"number":150,"title":"Various spec blocks return raw Boolean values rather than using should-matchers","user":{"login":"jawshooah","id":4551271,"avatar_url":"https://avatars.githubusercontent.com/u/4551271?v=3","gravatar_id":"","url":"https://api.github.com/users/jawshooah","html_url":"https://github.com/jawshooah","followers_url":"https://api.github.com/users/jawshooah/followers","following_url":"https://api.github.com/users/jawshooah/following{/other_user}","gists_url":"https://api.github.com/users/jawshooah/gists{/gist_id}","starred_url":"https://api.github.com/users/jawshooah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawshooah/subscriptions","organizations_url":"https://api.github.com/users/jawshooah/orgs","repos_url":"https://api.github.com/users/jawshooah/repos","events_url":"https://api.github.com/users/jawshooah/events{/privacy}","received_events_url":"https://api.github.com/users/jawshooah/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-26T03:57:05Z","updated_at":"2015-03-26T17:52:05Z","closed_at":"2015-03-26T17:52:05Z","body":"Throughout the specs, I've noticed a bunch of blocks ending with something like the following:\r\n\r\n```ruby\r\nFile.open('tracked-file', 'r').read == 'Hello World'\r\n```\r\n\r\nThis simply returns a Boolean rather than actually performing a test. We know that this doesn't work, because the comparison evaluates to `false` (RHS should be `\"Hello World\\n\"`), but the test still passes. It should be:\r\n\r\n```ruby\r\nFile.open('tracked-file', 'r').read.should == \"Hello World\\n\"\r\n```\r\n\r\nSuch invalid tests are peppered throughout the specs. I'm working on a PR now to clean them up."}}