{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/comments/47808226","id":47808226,"diff_hunk":"@@ -0,0 +1,486 @@\n+swagger: '2.0'\n+info:\n+  title: Nakadi Event Bus API Definition\n+  description: |\n+    -------------------------------\n+    Nakadi Event Bus API Definition\n+    -------------------------------\n+\n+    * Low-level API\n+    * Stantardised event format (see #/definitions/Event)\n+    * Partition strategy: event store will infer the partition from the `partitioning_key` in the message body\n+\n+  version: '0.4'\n+  contact:\n+    name: Team Aruha @ Zalando\n+    email: nakadi-users@zalando.de\n+schemes:\n+  - https\n+consumes:\n+  - application/json\n+produces:\n+  - application/json\n+securityDefinitions:\n+  oauth2:\n+    type: oauth2\n+    flow: implicit\n+    authorizationUrl: 'https://auth.example.com/oauth2/tokeninfo'\n+\n+paths:\n+  /metrics:\n+    get:\n+      tags:\n+        - monitoring\n+      summary: Get monitoring metrics\n+      responses:\n+        '200':\n+          description: Metrics data\n+          schema:\n+            $ref: '#/definitions/Metrics'\n+        '401':\n+          description: User is not authenticated\n+          schema:\n+            $ref: '#/definitions/Problem'\n+        '503':\n+          description: Not available\n+          schema:\n+            $ref: '#/definitions/Problem'\n+  /topics:\n+    get:\n+      description: Lists all known `Topics` of this Nakadi cluster\n+      tags:\n+        - monitoring\n+      responses:\n+        '200':\n+          description: The request was successful. Returns a list `Topic`s in the response body.\n+          schema:\n+            type: array\n+            description: An array of topics\n+            items:\n+              $ref: '#/definitions/Topic'\n+        '401':\n+          description: User is not authenticated\n+          schema:\n+            $ref: '#/definitions/Problem'\n+        '503':\n+          description: Not available\n+          schema:\n+            $ref: '#/definitions/Problem'\n+  '/topics/{topic}/events':\n+    get:\n+      tags:\n+        - low-level-api\n+      summary: |\n+        Starts a stream delivery for the specified partitions of the given topic.\n+        The tracking of the current position in the partitions and of which\n+        partitions is being read is in the responsibility of the client.\n+        No commits are needed.\n+      parameters:\n+        - name: topic\n+          in: path\n+          description: Topic where to get events from\n+          type: string\n+          required: true\n+        - name: x-nakadi-cursors\n+          in: header\n+          description: Cursors pointing to partitions/offsets to start read from\n+          required: false","path":"api/nakadi-event-bus-api.yaml","position":87,"original_position":87,"commit_id":"4bf874166617f101cd0c83ac8d21eaf28e07b4b7","original_commit_id":"4bf874166617f101cd0c83ac8d21eaf28e07b4b7","user":{"login":"tfrauenstein","id":13256199,"avatar_url":"https://avatars.githubusercontent.com/u/13256199?v=3","gravatar_id":"","url":"https://api.github.com/users/tfrauenstein","html_url":"https://github.com/tfrauenstein","followers_url":"https://api.github.com/users/tfrauenstein/followers","following_url":"https://api.github.com/users/tfrauenstein/following{/other_user}","gists_url":"https://api.github.com/users/tfrauenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/tfrauenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfrauenstein/subscriptions","organizations_url":"https://api.github.com/users/tfrauenstein/orgs","repos_url":"https://api.github.com/users/tfrauenstein/repos","events_url":"https://api.github.com/users/tfrauenstein/events{/privacy}","received_events_url":"https://api.github.com/users/tfrauenstein/received_events","type":"User","site_admin":false},"body":"See comment above.","created_at":"2015-12-16T17:41:58Z","updated_at":"2015-12-16T17:41:58Z","html_url":"https://github.com/zalando/nakadi/pull/43#discussion_r47808226","pull_request_url":"https://api.github.com/repos/zalando/nakadi/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments/47808226"},"html":{"href":"https://github.com/zalando/nakadi/pull/43#discussion_r47808226"},"pull_request":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/43","id":53414509,"html_url":"https://github.com/zalando/nakadi/pull/43","diff_url":"https://github.com/zalando/nakadi/pull/43.diff","patch_url":"https://github.com/zalando/nakadi/pull/43.patch","issue_url":"https://api.github.com/repos/zalando/nakadi/issues/43","number":43,"state":"open","locked":false,"title":"Nakadi event bus low level api review","user":{"login":"tmuehl","id":6663328,"avatar_url":"https://avatars.githubusercontent.com/u/6663328?v=3","gravatar_id":"","url":"https://api.github.com/users/tmuehl","html_url":"https://github.com/tmuehl","followers_url":"https://api.github.com/users/tmuehl/followers","following_url":"https://api.github.com/users/tmuehl/following{/other_user}","gists_url":"https://api.github.com/users/tmuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/tmuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmuehl/subscriptions","organizations_url":"https://api.github.com/users/tmuehl/orgs","repos_url":"https://api.github.com/users/tmuehl/repos","events_url":"https://api.github.com/users/tmuehl/events{/privacy}","received_events_url":"https://api.github.com/users/tmuehl/received_events","type":"User","site_admin":false},"body":"This is a review request for the API Guild.\r\n\r\nThis is the first stage of the review, where we minimised the file to contain only Nakadi Low-Level API related endpoints.\r\n\r\nThis API provides:\r\n\r\n* Standardised event format (see `#/definitions/Event`)\r\n\r\n* Low-level API\r\n  > (`LoLa`) allows the consumers to get event streams from the specified partitions\r\n  > for specified cursor positions. That means, that consumers should implement a protocol, \r\n  > to distribute partitions, that are being consumed between themselves.\r\n  > They also are responsible for storing current cursor positions per partition.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/zalando/nakadi/pull/43%23issuecomment-163997138%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23issuecomment-164014880%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47383926%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47384428%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47772591%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47772663%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47773847%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47774439%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47774483%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47805779%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47805869%22%2C%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47807557%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23issuecomment-163997138%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40tfrauenstein%20please%20have%20a%20look%20on%20the%20pull%20request.%20Do%20you%20think%20it%20is%20ok%20to%20submit%20it%20like%20this%20to%20the%20API%20guild%3F%22%2C%20%22created_at%22%3A%20%222015-12-11T17%3A26%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/448014%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/valgog%22%7D%7D%2C%20%7B%22body%22%3A%20%22yes%2C%20let%27s%20submit%20this%20pull%20request%20for%20review%21%20Thx.%22%2C%20%22created_at%22%3A%20%222015-12-11T18%3A45%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/13256199%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tfrauenstein%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%20400%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47774483%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22There%20is%20no%20information%20on%20required%20vs.%20optional%20fields%20in%20the%20%60Event%60.%22%2C%20%22created_at%22%3A%20%222015-12-16T13%3A23%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/711379%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/bocytko%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%2074%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47807557%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20don%27t%20understand%20this%20resource%20method.%20How%20is%20the%20%5C%22specified%20partition%5C%22%20info%20passed%3F%20%5Cr%5CnVia%20the%20x-nakadi-cursor%20header%3F%20If%20yes%2C%20the%20header%20need%20to%20be%20mandatory%2C%20not%20optional.%5Cr%5Cn%5Cr%5CnWhat%20is%20the%20difference%20to%20the%20GET%20/topics/%7Btopic%7D/partitions/%7Bpartition%7D%20resource%20method%3F%5Cr%5CnDo%20we%20really%20need%20both%20LL%20methods%3F%22%2C%20%22created_at%22%3A%20%222015-12-16T17%3A36%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/13256199%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tfrauenstein%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%20408%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47774439%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22So%20further%20properties%20can%20be%20added%20on%20the%20top-level%2C%20right%3F%20Would%20be%20cool%20to%20include%20this%20in%20the%20spec%20as%20well.%22%2C%20%22created_at%22%3A%20%222015-12-16T13%3A23%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/711379%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/bocytko%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%2027%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47805779%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20think%20we%20should%20also%20authorize%20event%20bus%20access%20using%20scopes.%5Cr%5CnWould%20expect%202%20scopes%3A%20%20%3Cstups-appl-id%3E.read%20and%20%3Cstups-appl-id%3E.write%22%2C%20%22created_at%22%3A%20%222015-12-16T17%3A22%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/13256199%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tfrauenstein%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%2049%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47805869%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22How%20topics%20are%20created%3F%20Would%20also%20expect%20API%20support%20here.%22%2C%20%22created_at%22%3A%20%222015-12-16T17%3A22%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/13256199%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tfrauenstein%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%20179%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47383926%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20is%20very%20controversial%20point%20here%2C%20as%20we%20are%20expecting%20%60POST%60%20to%20inject%20an%20array%20of%20events.%20This%20is%20needed%20to%20enable%20batching.%20So%20posting%20one%20event%20will%20be%20done%20as%20an%20array%20of%20one%20element.%22%2C%20%22created_at%22%3A%20%222015-12-11T17%3A58%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/448014%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/valgog%22%7D%7D%2C%20%7B%22body%22%3A%20%22Maybe%20the%20better%20way%20would%20be%20to%20use%20%60Content-Type%60%20here%2C%20that%20defines%2C%20what%20kind%20of%20an%20object%20is%20being%20passed%20in.%20Is%20there%20some%20standard%2C%20that%20would%20define%20an%20batch%20operation%3F%22%2C%20%22created_at%22%3A%20%222015-12-11T18%3A03%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/448014%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/valgog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%20426%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47772663%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Some%20documentation%20for%20%60root_id%60%2C%20%60parent_id%60%20and%20%60scopes%60%20would%20be%20helpful.%22%2C%20%22created_at%22%3A%20%222015-12-16T13%3A03%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/689138%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jhorstmann%22%7D%7D%2C%20%7B%22body%22%3A%20%22%2B1%20especially%20for%20scopes%22%2C%20%22created_at%22%3A%20%222015-12-16T13%3A16%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/711379%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/bocytko%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%2C%20%22Pull%204bf874166617f101cd0c83ac8d21eaf28e07b4b7%20api/nakadi-event-bus-api.yaml%20425%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zalando/nakadi/pull/43%23discussion_r47772591%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Typo%2C%20should%20be%20%60date-time%60.%22%2C%20%22created_at%22%3A%20%222015-12-16T13%3A02%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/689138%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jhorstmann%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20api/nakadi-event-bus-api.yaml%3AL1-487%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#issuecomment-163997138'>General Comment</a></b>\n- <a href='https://github.com/valgog'><img border=0 src='https://avatars.githubusercontent.com/u/448014?v=3' height=16 width=16'></a> @tfrauenstein please have a look on the pull request. Do you think it is ok to submit it like this to the API guild?\n- <a href='https://github.com/tfrauenstein'><img border=0 src='https://avatars.githubusercontent.com/u/13256199?v=3' height=16 width=16'></a> yes, let's submit this pull request for review! Thx.\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 179'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47383926'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/valgog'><img border=0 src='https://avatars.githubusercontent.com/u/448014?v=3' height=16 width=16'></a> This is very controversial point here, as we are expecting `POST` to inject an array of events. This is needed to enable batching. So posting one event will be done as an array of one element.\n- <a href='https://github.com/valgog'><img border=0 src='https://avatars.githubusercontent.com/u/448014?v=3' height=16 width=16'></a> Maybe the better way would be to use `Content-Type` here, that defines, what kind of an object is being passed in. Is there some standard, that would define an batch operation?\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 425'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47772591'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/jhorstmann'><img border=0 src='https://avatars.githubusercontent.com/u/689138?v=3' height=16 width=16'></a> Typo, should be `date-time`.\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 426'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47772663'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/jhorstmann'><img border=0 src='https://avatars.githubusercontent.com/u/689138?v=3' height=16 width=16'></a> Some documentation for `root_id`, `parent_id` and `scopes` would be helpful.\n- <a href='https://github.com/bocytko'><img border=0 src='https://avatars.githubusercontent.com/u/711379?v=3' height=16 width=16'></a> +1 especially for scopes\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 408'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47774439'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/bocytko'><img border=0 src='https://avatars.githubusercontent.com/u/711379?v=3' height=16 width=16'></a> So further properties can be added on the top-level, right? Would be cool to include this in the spec as well.\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 400'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47774483'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/bocytko'><img border=0 src='https://avatars.githubusercontent.com/u/711379?v=3' height=16 width=16'></a> There is no information on required vs. optional fields in the `Event`.\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 27'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47805779'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/tfrauenstein'><img border=0 src='https://avatars.githubusercontent.com/u/13256199?v=3' height=16 width=16'></a> I think we should also authorize event bus access using scopes.\nWould expect 2 scopes:  <stups-appl-id>.read and <stups-appl-id>.write\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 49'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47805869'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/tfrauenstein'><img border=0 src='https://avatars.githubusercontent.com/u/13256199?v=3' height=16 width=16'></a> How topics are created? Would also expect API support here.\n- [ ] <a href='#crh-comment-Pull 4bf874166617f101cd0c83ac8d21eaf28e07b4b7 api/nakadi-event-bus-api.yaml 74'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zalando/nakadi/pull/43#discussion_r47807557'>File: api/nakadi-event-bus-api.yaml:L1-487</a></b>\n- <a href='https://github.com/tfrauenstein'><img border=0 src='https://avatars.githubusercontent.com/u/13256199?v=3' height=16 width=16'></a> I don't understand this resource method. How is the \"specified partition\" info passed?\nVia the x-nakadi-cursor header? If yes, the header need to be mandatory, not optional.\nWhat is the difference to the GET /topics/{topic}/partitions/{partition} resource method?\nDo we really need both LL methods?\n\n\n<a href='https://www.codereviewhub.com/zalando/nakadi/pull/43?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/zalando/nakadi/pull/43?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/zalando/nakadi/pull/43'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-12-11T16:37:11Z","updated_at":"2015-12-16T17:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa20f931012ac6b7b9425200ec705203982f45f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando/nakadi/pulls/43/commits","review_comments_url":"https://api.github.com/repos/zalando/nakadi/pulls/43/comments","review_comment_url":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/nakadi/issues/43/comments","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/4bf874166617f101cd0c83ac8d21eaf28e07b4b7","head":{"label":"zalando:nakadi-low-level-api-review","ref":"nakadi-low-level-api-review","sha":"4bf874166617f101cd0c83ac8d21eaf28e07b4b7","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"Zalando Distributed Event Bus","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","created_at":"2015-10-14T08:30:17Z","updated_at":"2015-10-19T10:21:06Z","pushed_at":"2015-12-16T15:59:46Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"git@github.com:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":248,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"de388725c08a72a5364f80d7c467e1824a7092bb","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"Zalando Distributed Event Bus","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","created_at":"2015-10-14T08:30:17Z","updated_at":"2015-10-19T10:21:06Z","pushed_at":"2015-12-16T15:59:46Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"git@github.com:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":248,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/43"},"html":{"href":"https://github.com/zalando/nakadi/pull/43"},"issue":{"href":"https://api.github.com/repos/zalando/nakadi/issues/43"},"comments":{"href":"https://api.github.com/repos/zalando/nakadi/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/nakadi/statuses/4bf874166617f101cd0c83ac8d21eaf28e07b4b7"}}}}