{"action":"created","issue":{"url":"https://api.github.com/repos/gawkermedia/soy/issues/7","labels_url":"https://api.github.com/repos/gawkermedia/soy/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/gawkermedia/soy/issues/7/comments","events_url":"https://api.github.com/repos/gawkermedia/soy/issues/7/events","html_url":"https://github.com/gawkermedia/soy/pull/7","id":89642479,"number":7,"title":"Remove SoyDouble and change SoyFloat to match Closure's actual type-matching.","user":{"login":"ChrisNeveu","id":1002726,"avatar_url":"https://avatars.githubusercontent.com/u/1002726?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisNeveu","html_url":"https://github.com/ChrisNeveu","followers_url":"https://api.github.com/users/ChrisNeveu/followers","following_url":"https://api.github.com/users/ChrisNeveu/following{/other_user}","gists_url":"https://api.github.com/users/ChrisNeveu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisNeveu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisNeveu/subscriptions","organizations_url":"https://api.github.com/users/ChrisNeveu/orgs","repos_url":"https://api.github.com/users/ChrisNeveu/repos","events_url":"https://api.github.com/users/ChrisNeveu/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisNeveu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pjrt","id":1610164,"avatar_url":"https://avatars.githubusercontent.com/u/1610164?v=3","gravatar_id":"","url":"https://api.github.com/users/pjrt","html_url":"https://github.com/pjrt","followers_url":"https://api.github.com/users/pjrt/followers","following_url":"https://api.github.com/users/pjrt/following{/other_user}","gists_url":"https://api.github.com/users/pjrt/gists{/gist_id}","starred_url":"https://api.github.com/users/pjrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjrt/subscriptions","organizations_url":"https://api.github.com/users/pjrt/orgs","repos_url":"https://api.github.com/users/pjrt/repos","events_url":"https://api.github.com/users/pjrt/events{/privacy}","received_events_url":"https://api.github.com/users/pjrt/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-06-19T19:35:49Z","updated_at":"2015-06-22T14:32:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gawkermedia/soy/pulls/7","html_url":"https://github.com/gawkermedia/soy/pull/7","diff_url":"https://github.com/gawkermedia/soy/pull/7.diff","patch_url":"https://github.com/gawkermedia/soy/pull/7.patch"},"body":"@pjrt The latest versions of Google Closure Templates have reduced support for `Float`s. They are now converted to `Double`s which produces surprising behavior like `2.1f` being printed as `2.0999999046325684` in a template.\r\n\r\nAs a consequence, I'm removing the support for floats from our wrappers. I'm also taking this opportunity to align our types with those in [Google's Documentation](https://developers.google.com/closure/templates/docs/java_usage) where `float` is represented by `Double`."},"comment":{"url":"https://api.github.com/repos/gawkermedia/soy/issues/comments/114131268","html_url":"https://github.com/gawkermedia/soy/pull/7#issuecomment-114131268","issue_url":"https://api.github.com/repos/gawkermedia/soy/issues/7","id":114131268,"user":{"login":"ChrisNeveu","id":1002726,"avatar_url":"https://avatars.githubusercontent.com/u/1002726?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisNeveu","html_url":"https://github.com/ChrisNeveu","followers_url":"https://api.github.com/users/ChrisNeveu/followers","following_url":"https://api.github.com/users/ChrisNeveu/following{/other_user}","gists_url":"https://api.github.com/users/ChrisNeveu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisNeveu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisNeveu/subscriptions","organizations_url":"https://api.github.com/users/ChrisNeveu/orgs","repos_url":"https://api.github.com/users/ChrisNeveu/repos","events_url":"https://api.github.com/users/ChrisNeveu/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisNeveu/received_events","type":"User","site_admin":false},"created_at":"2015-06-22T14:32:55Z","updated_at":"2015-06-22T14:32:55Z","body":"I'm not talking about the implicit conversion provided by Scala, I'm just talking about the `SoyWrites[Float]` instance that creates a `SoyFloat` which necessarily contains a conversion from `Float` → `Double`.\r\n\r\nBy leaving out this instance it becomes more clear that you cannot pass a `Float` to the Soy templates without first converting to a `Double`."}}