{"action":"created","issue":{"url":"https://api.github.com/repos/grunwaldlab/poppr/issues/35","labels_url":"https://api.github.com/repos/grunwaldlab/poppr/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/grunwaldlab/poppr/issues/35/comments","events_url":"https://api.github.com/repos/grunwaldlab/poppr/issues/35/events","html_url":"https://github.com/grunwaldlab/poppr/pull/35","id":93398554,"number":35,"title":"2.0 rc","user":{"login":"zkamvar","id":3639446,"avatar_url":"https://avatars.githubusercontent.com/u/3639446?v=3","gravatar_id":"","url":"https://api.github.com/users/zkamvar","html_url":"https://github.com/zkamvar","followers_url":"https://api.github.com/users/zkamvar/followers","following_url":"https://api.github.com/users/zkamvar/following{/other_user}","gists_url":"https://api.github.com/users/zkamvar/gists{/gist_id}","starred_url":"https://api.github.com/users/zkamvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkamvar/subscriptions","organizations_url":"https://api.github.com/users/zkamvar/orgs","repos_url":"https://api.github.com/users/zkamvar/repos","events_url":"https://api.github.com/users/zkamvar/events{/privacy}","received_events_url":"https://api.github.com/users/zkamvar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/grunwaldlab/poppr/milestones/2","html_url":"https://github.com/grunwaldlab/poppr/milestones/Next%20CRAN%20Release","labels_url":"https://api.github.com/repos/grunwaldlab/poppr/milestones/2/labels","id":1195886,"number":2,"title":"Next CRAN Release","description":"This is symbolic. Most of the work has been done to make sure everything is in working order. It would be good to submit this before adegenet gets submitted so that we don't have a lapse in functionality, but I can't guarantee that will happen.\r\n\r\nThings that need to be done before submission:\r\n\r\n- [ ] merge 2.0-rc into master and devel\r\n- [ ] remove 2.0-rc branch\r\n- [ ] tag as `2.0-rc` so that link in frontiers paper still works.\r\n- [ ] make a small commit and then tag as `v.2.0.0`\r\n- [ ] [`git pupdate`](https://github.com/grunwaldlab/poppr/wiki/Versioning-in-poppr#incrementing-major-minor-or-patch-version)\r\n- [ ] submit to CRAN","creator":{"login":"zkamvar","id":3639446,"avatar_url":"https://avatars.githubusercontent.com/u/3639446?v=3","gravatar_id":"","url":"https://api.github.com/users/zkamvar","html_url":"https://github.com/zkamvar","followers_url":"https://api.github.com/users/zkamvar/followers","following_url":"https://api.github.com/users/zkamvar/following{/other_user}","gists_url":"https://api.github.com/users/zkamvar/gists{/gist_id}","starred_url":"https://api.github.com/users/zkamvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkamvar/subscriptions","organizations_url":"https://api.github.com/users/zkamvar/orgs","repos_url":"https://api.github.com/users/zkamvar/repos","events_url":"https://api.github.com/users/zkamvar/events{/privacy}","received_events_url":"https://api.github.com/users/zkamvar/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-07-06T23:20:16Z","updated_at":"2015-07-07T15:13:29Z","due_on":"2015-07-07T07:00:00Z","closed_at":null},"comments":5,"created_at":"2015-07-06T23:13:07Z","updated_at":"2015-07-07T16:48:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grunwaldlab/poppr/pulls/35","html_url":"https://github.com/grunwaldlab/poppr/pull/35","diff_url":"https://github.com/grunwaldlab/poppr/pull/35.diff","patch_url":"https://github.com/grunwaldlab/poppr/pull/35.patch"},"body":"I believe this version is stable with clear documentation.\r\n\r\nThese represent the major changes from version 2.0\r\n\r\nThe best option, perhaps, is to compare the NEWS diff.\r\n\r\nCool things to happen:\r\n\r\n- bootstrap diversity stats\r\n- interactive minimum spanning networks\r\n- pairwise index of association\r\n- a new vignettes for multilocus genotypes\r\n- genclone and snpclone objects retain memory of distance, threshold, and algorithm used for filtering.\r\n\r\nIt would be nice if people would kick the tires a little bit and make sure that things like documentation are clear. \r\n"},"comment":{"url":"https://api.github.com/repos/grunwaldlab/poppr/issues/comments/119265285","html_url":"https://github.com/grunwaldlab/poppr/pull/35#issuecomment-119265285","issue_url":"https://api.github.com/repos/grunwaldlab/poppr/issues/35","id":119265285,"user":{"login":"zachary-foster","id":6090555,"avatar_url":"https://avatars.githubusercontent.com/u/6090555?v=3","gravatar_id":"","url":"https://api.github.com/users/zachary-foster","html_url":"https://github.com/zachary-foster","followers_url":"https://api.github.com/users/zachary-foster/followers","following_url":"https://api.github.com/users/zachary-foster/following{/other_user}","gists_url":"https://api.github.com/users/zachary-foster/gists{/gist_id}","starred_url":"https://api.github.com/users/zachary-foster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachary-foster/subscriptions","organizations_url":"https://api.github.com/users/zachary-foster/orgs","repos_url":"https://api.github.com/users/zachary-foster/repos","events_url":"https://api.github.com/users/zachary-foster/events{/privacy}","received_events_url":"https://api.github.com/users/zachary-foster/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T16:48:04Z","updated_at":"2015-07-07T16:48:04Z","body":"Here is what I have noticed so far. I skimmed over the documentation to look for spelling errors mostly since im not all that familiar with the logic/purpose of the package. I can dig into it more, but I am reaching the point of diminishing returns. Most of the comments below are rather minor: \r\n\r\n* The following files do not have the license at the start that the rest do: `aaMLGclass.R`, `aaaMLGmethods.R`, `filter_stats.R`, `poppr.R`\r\n* Mixture of `.r` and `.R` extensions in `R/`\r\n* \"univariate\" or \"unvarying\" in  `R/data_subset.r:#' @param drop \\code{logical}. If \\code{TRUE}, unvariate alleles will be dropped` ?\r\n* A few typos (fixed in my commit)"}}