{"action":"created","issue":{"url":"https://api.github.com/repos/ioam/imagen/issues/45","labels_url":"https://api.github.com/repos/ioam/imagen/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/ioam/imagen/issues/45/comments","events_url":"https://api.github.com/repos/ioam/imagen/issues/45/events","html_url":"https://github.com/ioam/imagen/issues/45","id":71337863,"number":45,"title":"GaussianRandom needs a parameter for the variance","user":{"login":"jlstevens","id":890576,"avatar_url":"https://avatars.githubusercontent.com/u/890576?v=3","gravatar_id":"","url":"https://api.github.com/users/jlstevens","html_url":"https://github.com/jlstevens","followers_url":"https://api.github.com/users/jlstevens/followers","following_url":"https://api.github.com/users/jlstevens/following{/other_user}","gists_url":"https://api.github.com/users/jlstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/jlstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlstevens/subscriptions","organizations_url":"https://api.github.com/users/jlstevens/orgs","repos_url":"https://api.github.com/users/jlstevens/repos","events_url":"https://api.github.com/users/jlstevens/events{/privacy}","received_events_url":"https://api.github.com/users/jlstevens/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-27T16:35:07Z","updated_at":"2015-04-27T20:43:04Z","closed_at":"2015-04-27T20:43:04Z","body":"What is the point of a Gaussian distribution is I can't change the standard deviation or variance?!? \r\n\r\nHere is the current definition:\r\n\r\n```python\r\nclass GaussianRandom(RandomGenerator):\r\n    scale  = param.Number(default=0.25,softbounds=(0.0,2.0))\r\n    offset = param.Number(default=0.50,softbounds=(-2.0,2.0))\r\n\r\n    def _distrib(self,shape,p):\r\n        return p.offset+p.scale*p.random_generator.standard_normal(shape)\r\n```\r\n\r\nWhy would you do this when you can make something useful?\r\n\r\n```python\r\nclass GaussianRandom(RandomGenerator):\r\n\r\n    standard_deviation = param.Number(default=1, softbounds=(0,None))\r\n    scale  = param.Number(default=0.25,softbounds=(0.0,2.0))\r\n    offset = param.Number(default=0.50,softbounds=(-2.0,2.0))\r\n\r\n    def _distrib(self,shape,p):\r\n        return p.offset+p.scale*p.random_generator.normal(scale=p.standard_deviation,\r\n                                                          size=shape)\r\n```\r\n\r\nThat wasn't so hard now, was it? I can't fathom the logic behind the original implementation; maybe someone deliberately went out of their way to come up with  an annoying and useless? Who the hell uses ``standard_normal`` when ``normal`` is more general and actually useful?!\r\n\r\nAnyway, I am happy to commit the sane version to master except that I am now worried about breaking backward compatibility. I suppose I need to see whether ``.standard_normal`` behaves like  ``,normal`` with unit standard deviation."},"comment":{"url":"https://api.github.com/repos/ioam/imagen/issues/comments/96814220","html_url":"https://github.com/ioam/imagen/issues/45#issuecomment-96814220","issue_url":"https://api.github.com/repos/ioam/imagen/issues/45","id":96814220,"user":{"login":"jbednar","id":1695496,"avatar_url":"https://avatars.githubusercontent.com/u/1695496?v=3","gravatar_id":"","url":"https://api.github.com/users/jbednar","html_url":"https://github.com/jbednar","followers_url":"https://api.github.com/users/jbednar/followers","following_url":"https://api.github.com/users/jbednar/following{/other_user}","gists_url":"https://api.github.com/users/jbednar/gists{/gist_id}","starred_url":"https://api.github.com/users/jbednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbednar/subscriptions","organizations_url":"https://api.github.com/users/jbednar/orgs","repos_url":"https://api.github.com/users/jbednar/repos","events_url":"https://api.github.com/users/jbednar/events{/privacy}","received_events_url":"https://api.github.com/users/jbednar/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T20:43:04Z","updated_at":"2015-04-27T20:43:04Z","body":"Ok, I think we've both gotten ourselves confused at different points -- e.g. I didn't see your edits to your earlier comment when I replied.  I'll close the issue now as being not needed, by my initial reasoning."}}