{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/3490","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/3490/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3490/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/3490/events","html_url":"https://github.com/jekyll/jekyll/pull/3490","id":58436827,"number":3490,"title":"always include file extension on destination files","user":{"login":"willnorris","id":1112,"avatar_url":"https://avatars.githubusercontent.com/u/1112?v=3","gravatar_id":"","url":"https://api.github.com/users/willnorris","html_url":"https://github.com/willnorris","followers_url":"https://api.github.com/users/willnorris/followers","following_url":"https://api.github.com/users/willnorris/following{/other_user}","gists_url":"https://api.github.com/users/willnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/willnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willnorris/subscriptions","organizations_url":"https://api.github.com/users/willnorris/orgs","repos_url":"https://api.github.com/users/willnorris/repos","events_url":"https://api.github.com/users/willnorris/events{/privacy}","received_events_url":"https://api.github.com/users/willnorris/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jekyll/jekyll/labels/Enhancement","name":"Enhancement","color":"5D76CB"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2015-02-21T02:31:36Z","updated_at":"2015-04-27T19:39:29Z","closed_at":"2015-03-03T18:53:08Z","pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3490","html_url":"https://github.com/jekyll/jekyll/pull/3490","diff_url":"https://github.com/jekyll/jekyll/pull/3490.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3490.patch"},"body":"This is an initial take at always including file extensions on destination files written to disk.  This is a continuation of the discussion that's happened on #2294 and #3463, and coincides with the WEBrick changes in #3452.  \r\n\r\nThis should only have any impact when the site or post permalink setting is configured without either a trailing slash or the file extension for that file type.  In that case, the file written to disk will contain the correct extension for that type, while the URL will remain as specified in the permalink setting.\r\n\r\nNotably, this does break the test that was added in #2925 to support files ending in \".htm\" rather than \".html\" (cc @pathawks to discuss), because this is using the `output_ext` value to determine the expected extension for the destination file.  I believe this is the correct behavior.  I think that any attempt to support alternate extensions (like \".htm\") should make sure one way or another that `output_ext` returns the desired alternate extension.  Not doing so seems likely to cause more problems down the road.  Either way, we certainly need to resolve this breaking test before this can be safely merged."},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/96792102","html_url":"https://github.com/jekyll/jekyll/pull/3490#issuecomment-96792102","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3490","id":96792102,"user":{"login":"willnorris","id":1112,"avatar_url":"https://avatars.githubusercontent.com/u/1112?v=3","gravatar_id":"","url":"https://api.github.com/users/willnorris","html_url":"https://github.com/willnorris","followers_url":"https://api.github.com/users/willnorris/followers","following_url":"https://api.github.com/users/willnorris/following{/other_user}","gists_url":"https://api.github.com/users/willnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/willnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willnorris/subscriptions","organizations_url":"https://api.github.com/users/willnorris/orgs","repos_url":"https://api.github.com/users/willnorris/repos","events_url":"https://api.github.com/users/willnorris/events{/privacy}","received_events_url":"https://api.github.com/users/willnorris/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T19:39:28Z","updated_at":"2015-04-27T19:39:28Z","body":"err, you might actually need to patch the Markdown converter, but it would still be the `output_ext` method."}}