{"action":"created","comment":{"url":"https://api.github.com/repos/Tapjoy/tass/pulls/comments/42523174","id":42523174,"diff_hunk":"@@ -153,7 +154,9 @@ def confirm_config(keypair:, zones:, security_groups:, instance_type:,\n \n       # configure environment\n \n-      def configure_environment(filename, env=nil)\n+      def configure_environment(opts)\n+        filename = opts[:filename]\n+        env = opts[:env] if opts.key?(:env)","path":"lib/tapjoy/autoscaling_bootstrap.rb","position":15,"original_position":15,"commit_id":"f902513a9d46f7e86f7f47279dc3ad5bb84be805","original_commit_id":"f902513a9d46f7e86f7f47279dc3ad5bb84be805","user":{"login":"StabbyCutyou","id":1528618,"avatar_url":"https://avatars.githubusercontent.com/u/1528618?v=3","gravatar_id":"","url":"https://api.github.com/users/StabbyCutyou","html_url":"https://github.com/StabbyCutyou","followers_url":"https://api.github.com/users/StabbyCutyou/followers","following_url":"https://api.github.com/users/StabbyCutyou/following{/other_user}","gists_url":"https://api.github.com/users/StabbyCutyou/gists{/gist_id}","starred_url":"https://api.github.com/users/StabbyCutyou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StabbyCutyou/subscriptions","organizations_url":"https://api.github.com/users/StabbyCutyou/orgs","repos_url":"https://api.github.com/users/StabbyCutyou/repos","events_url":"https://api.github.com/users/StabbyCutyou/events{/privacy}","received_events_url":"https://api.github.com/users/StabbyCutyou/received_events","type":"User","site_admin":false},"body":"You could clean this up, I think\r\n\r\n```ruby\r\nenv = ops[:env] || facet_hash[:environment] || defaults_hash[:environment]\r\n```","created_at":"2015-10-20T17:03:11Z","updated_at":"2015-10-20T17:03:11Z","html_url":"https://github.com/Tapjoy/tass/pull/15#discussion_r42523174","pull_request_url":"https://api.github.com/repos/Tapjoy/tass/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/comments/42523174"},"html":{"href":"https://github.com/Tapjoy/tass/pull/15#discussion_r42523174"},"pull_request":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Tapjoy/tass/pulls/15","id":47836808,"html_url":"https://github.com/Tapjoy/tass/pull/15","diff_url":"https://github.com/Tapjoy/tass/pull/15.diff","patch_url":"https://github.com/Tapjoy/tass/pull/15.patch","issue_url":"https://api.github.com/repos/Tapjoy/tass/issues/15","number":15,"state":"open","locked":false,"title":"Static and Dynamic scaling","user":{"login":"atayarani","id":619512,"avatar_url":"https://avatars.githubusercontent.com/u/619512?v=3","gravatar_id":"","url":"https://api.github.com/users/atayarani","html_url":"https://github.com/atayarani","followers_url":"https://api.github.com/users/atayarani/followers","following_url":"https://api.github.com/users/atayarani/following{/other_user}","gists_url":"https://api.github.com/users/atayarani/gists{/gist_id}","starred_url":"https://api.github.com/users/atayarani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atayarani/subscriptions","organizations_url":"https://api.github.com/users/atayarani/orgs","repos_url":"https://api.github.com/users/atayarani/repos","events_url":"https://api.github.com/users/atayarani/events{/privacy}","received_events_url":"https://api.github.com/users/atayarani/received_events","type":"User","site_admin":false},"body":"@marcuswalser @StabbyCutyou @ehealy \r\n/cc @Tapjoy/eng-group-ops \r\n\r\nNotes: \r\n* Had to implement a small code change to fix specs.  The error when they failed was misleading.\r\n* Moved the instance counts from args to yaml params\r\n* Added the new gem dependency because it makes CircleCI easier to use","created_at":"2015-10-15T20:25:33Z","updated_at":"2015-10-20T17:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de709c50b8471265c962895c7c375f7b9764be58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tapjoy/tass/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Tapjoy/tass/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Tapjoy/tass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tapjoy/tass/issues/15/comments","statuses_url":"https://api.github.com/repos/Tapjoy/tass/statuses/f902513a9d46f7e86f7f47279dc3ad5bb84be805","head":{"label":"Tapjoy:scaling","ref":"scaling","sha":"f902513a9d46f7e86f7f47279dc3ad5bb84be805","user":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"repo":{"id":38378986,"name":"tass","full_name":"Tapjoy/tass","owner":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tapjoy/tass","description":"Tapjoy Autoscaling Suite","fork":false,"url":"https://api.github.com/repos/Tapjoy/tass","forks_url":"https://api.github.com/repos/Tapjoy/tass/forks","keys_url":"https://api.github.com/repos/Tapjoy/tass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tapjoy/tass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tapjoy/tass/teams","hooks_url":"https://api.github.com/repos/Tapjoy/tass/hooks","issue_events_url":"https://api.github.com/repos/Tapjoy/tass/issues/events{/number}","events_url":"https://api.github.com/repos/Tapjoy/tass/events","assignees_url":"https://api.github.com/repos/Tapjoy/tass/assignees{/user}","branches_url":"https://api.github.com/repos/Tapjoy/tass/branches{/branch}","tags_url":"https://api.github.com/repos/Tapjoy/tass/tags","blobs_url":"https://api.github.com/repos/Tapjoy/tass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tapjoy/tass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tapjoy/tass/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tapjoy/tass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tapjoy/tass/statuses/{sha}","languages_url":"https://api.github.com/repos/Tapjoy/tass/languages","stargazers_url":"https://api.github.com/repos/Tapjoy/tass/stargazers","contributors_url":"https://api.github.com/repos/Tapjoy/tass/contributors","subscribers_url":"https://api.github.com/repos/Tapjoy/tass/subscribers","subscription_url":"https://api.github.com/repos/Tapjoy/tass/subscription","commits_url":"https://api.github.com/repos/Tapjoy/tass/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tapjoy/tass/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tapjoy/tass/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tapjoy/tass/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tapjoy/tass/contents/{+path}","compare_url":"https://api.github.com/repos/Tapjoy/tass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tapjoy/tass/merges","archive_url":"https://api.github.com/repos/Tapjoy/tass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tapjoy/tass/downloads","issues_url":"https://api.github.com/repos/Tapjoy/tass/issues{/number}","pulls_url":"https://api.github.com/repos/Tapjoy/tass/pulls{/number}","milestones_url":"https://api.github.com/repos/Tapjoy/tass/milestones{/number}","notifications_url":"https://api.github.com/repos/Tapjoy/tass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tapjoy/tass/labels{/name}","releases_url":"https://api.github.com/repos/Tapjoy/tass/releases{/id}","created_at":"2015-07-01T15:29:54Z","updated_at":"2015-07-14T14:29:07Z","pushed_at":"2015-10-16T16:00:09Z","git_url":"git://github.com/Tapjoy/tass.git","ssh_url":"git@github.com:Tapjoy/tass.git","clone_url":"https://github.com/Tapjoy/tass.git","svn_url":"https://github.com/Tapjoy/tass","homepage":null,"size":301,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"Tapjoy:v100","ref":"v100","sha":"c7a09d2da94b6f65c44d8f9e1d03b6ea255a9673","user":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"repo":{"id":38378986,"name":"tass","full_name":"Tapjoy/tass","owner":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tapjoy/tass","description":"Tapjoy Autoscaling Suite","fork":false,"url":"https://api.github.com/repos/Tapjoy/tass","forks_url":"https://api.github.com/repos/Tapjoy/tass/forks","keys_url":"https://api.github.com/repos/Tapjoy/tass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tapjoy/tass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tapjoy/tass/teams","hooks_url":"https://api.github.com/repos/Tapjoy/tass/hooks","issue_events_url":"https://api.github.com/repos/Tapjoy/tass/issues/events{/number}","events_url":"https://api.github.com/repos/Tapjoy/tass/events","assignees_url":"https://api.github.com/repos/Tapjoy/tass/assignees{/user}","branches_url":"https://api.github.com/repos/Tapjoy/tass/branches{/branch}","tags_url":"https://api.github.com/repos/Tapjoy/tass/tags","blobs_url":"https://api.github.com/repos/Tapjoy/tass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tapjoy/tass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tapjoy/tass/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tapjoy/tass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tapjoy/tass/statuses/{sha}","languages_url":"https://api.github.com/repos/Tapjoy/tass/languages","stargazers_url":"https://api.github.com/repos/Tapjoy/tass/stargazers","contributors_url":"https://api.github.com/repos/Tapjoy/tass/contributors","subscribers_url":"https://api.github.com/repos/Tapjoy/tass/subscribers","subscription_url":"https://api.github.com/repos/Tapjoy/tass/subscription","commits_url":"https://api.github.com/repos/Tapjoy/tass/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tapjoy/tass/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tapjoy/tass/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tapjoy/tass/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tapjoy/tass/contents/{+path}","compare_url":"https://api.github.com/repos/Tapjoy/tass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tapjoy/tass/merges","archive_url":"https://api.github.com/repos/Tapjoy/tass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tapjoy/tass/downloads","issues_url":"https://api.github.com/repos/Tapjoy/tass/issues{/number}","pulls_url":"https://api.github.com/repos/Tapjoy/tass/pulls{/number}","milestones_url":"https://api.github.com/repos/Tapjoy/tass/milestones{/number}","notifications_url":"https://api.github.com/repos/Tapjoy/tass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tapjoy/tass/labels{/name}","releases_url":"https://api.github.com/repos/Tapjoy/tass/releases{/id}","created_at":"2015-07-01T15:29:54Z","updated_at":"2015-07-14T14:29:07Z","pushed_at":"2015-10-16T16:00:09Z","git_url":"git://github.com/Tapjoy/tass.git","ssh_url":"git@github.com:Tapjoy/tass.git","clone_url":"https://github.com/Tapjoy/tass.git","svn_url":"https://github.com/Tapjoy/tass","homepage":null,"size":301,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/15"},"html":{"href":"https://github.com/Tapjoy/tass/pull/15"},"issue":{"href":"https://api.github.com/repos/Tapjoy/tass/issues/15"},"comments":{"href":"https://api.github.com/repos/Tapjoy/tass/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tapjoy/tass/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Tapjoy/tass/statuses/f902513a9d46f7e86f7f47279dc3ad5bb84be805"}}}}