{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/22752871","id":22752871,"diff_hunk":"@@ -227,11 +227,13 @@ createView.define(Panel, (panel, document) => {\n   const frame = document.createElement(\"iframe\");\n   setAttributes(frame, {\n     \"sandbox\": \"allow-scripts\",\n-    // It would be great if we could allow remote iframes for sandboxing\n-    // panel documents in a content process, but for now platform implementation\n-    // is buggy on linux so this is disabled.\n+    // We end up using chrome iframe with forced message manager\n+    // as fixing a swapFrameLoader seemd like a giant task (see\n+    // Bug 1075490).\n     // \"remote\": true,\n-    \"type\": \"content\",\n+    // \"type\": \"content\",\n+    \"type\": \"chrome\",","path":"lib/dev/panel.js","position":13,"original_position":13,"commit_id":"50d313567e9b825a1f93af422bedd8d467dc3541","original_commit_id":"50d313567e9b825a1f93af422bedd8d467dc3541","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"> Do we have a test that remote content is not used?\r\n\r\nI don't think that's relevant to this change, but yes we options are validated:\r\n\r\nhttps://github.com/mozilla/addon-sdk/blob/master/lib/dev/panel.js#L158-L164\r\n","created_at":"2015-01-10T00:24:14Z","updated_at":"2015-01-10T00:24:14Z","html_url":"https://github.com/mozilla/addon-sdk/pull/1829#discussion_r22752871","pull_request_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/22752871"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/1829#discussion_r22752871"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829","id":27075253,"html_url":"https://github.com/mozilla/addon-sdk/pull/1829","diff_url":"https://github.com/mozilla/addon-sdk/pull/1829.diff","patch_url":"https://github.com/mozilla/addon-sdk/pull/1829.patch","issue_url":"https://api.github.com/repos/mozilla/addon-sdk/issues/1829","number":1829,"state":"open","locked":false,"title":"Bug 1075490 - Fix devtools docking.","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"Depends on platform change attached here (https://bug1075490.bugzilla.mozilla.org/attachment.cgi?id=8546311)","created_at":"2015-01-09T01:52:18Z","updated_at":"2015-01-10T00:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecc2c2ec9e269e6d9c19fbb266f15eafdaeb3b26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829/commits","review_comments_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829/comments","review_comment_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/addon-sdk/issues/1829/comments","statuses_url":"https://api.github.com/repos/mozilla/addon-sdk/statuses/50d313567e9b825a1f93af422bedd8d467dc3541","head":{"label":"Gozala:dev-panel-chrome","ref":"dev-panel-chrome","sha":"50d313567e9b825a1f93af422bedd8d467dc3541","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"repo":{"id":971833,"name":"addon-sdk","full_name":"Gozala/addon-sdk","owner":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gozala/addon-sdk","description":"The Add-on SDK repository.","fork":true,"url":"https://api.github.com/repos/Gozala/addon-sdk","forks_url":"https://api.github.com/repos/Gozala/addon-sdk/forks","keys_url":"https://api.github.com/repos/Gozala/addon-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gozala/addon-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gozala/addon-sdk/teams","hooks_url":"https://api.github.com/repos/Gozala/addon-sdk/hooks","issue_events_url":"https://api.github.com/repos/Gozala/addon-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Gozala/addon-sdk/events","assignees_url":"https://api.github.com/repos/Gozala/addon-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Gozala/addon-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Gozala/addon-sdk/tags","blobs_url":"https://api.github.com/repos/Gozala/addon-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gozala/addon-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gozala/addon-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gozala/addon-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gozala/addon-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Gozala/addon-sdk/languages","stargazers_url":"https://api.github.com/repos/Gozala/addon-sdk/stargazers","contributors_url":"https://api.github.com/repos/Gozala/addon-sdk/contributors","subscribers_url":"https://api.github.com/repos/Gozala/addon-sdk/subscribers","subscription_url":"https://api.github.com/repos/Gozala/addon-sdk/subscription","commits_url":"https://api.github.com/repos/Gozala/addon-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gozala/addon-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gozala/addon-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gozala/addon-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gozala/addon-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Gozala/addon-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gozala/addon-sdk/merges","archive_url":"https://api.github.com/repos/Gozala/addon-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gozala/addon-sdk/downloads","issues_url":"https://api.github.com/repos/Gozala/addon-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Gozala/addon-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Gozala/addon-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Gozala/addon-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gozala/addon-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Gozala/addon-sdk/releases{/id}","created_at":"2010-10-08T10:06:22Z","updated_at":"2015-01-09T00:13:59Z","pushed_at":"2015-01-09T01:48:14Z","git_url":"git://github.com/Gozala/addon-sdk.git","ssh_url":"git@github.com:Gozala/addon-sdk.git","clone_url":"https://github.com/Gozala/addon-sdk.git","svn_url":"https://github.com/Gozala/addon-sdk","homepage":"https://wiki.mozilla.org/Labs/Jetpack","size":19932,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"081acf346094fc5e8195dda5c1cf8e9623cd976b","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":748030,"name":"addon-sdk","full_name":"mozilla/addon-sdk","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addon-sdk","description":"The Add-on SDK repository.","fork":false,"url":"https://api.github.com/repos/mozilla/addon-sdk","forks_url":"https://api.github.com/repos/mozilla/addon-sdk/forks","keys_url":"https://api.github.com/repos/mozilla/addon-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addon-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addon-sdk/teams","hooks_url":"https://api.github.com/repos/mozilla/addon-sdk/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addon-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addon-sdk/events","assignees_url":"https://api.github.com/repos/mozilla/addon-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addon-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addon-sdk/tags","blobs_url":"https://api.github.com/repos/mozilla/addon-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addon-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addon-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addon-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addon-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addon-sdk/languages","stargazers_url":"https://api.github.com/repos/mozilla/addon-sdk/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addon-sdk/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addon-sdk/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addon-sdk/subscription","commits_url":"https://api.github.com/repos/mozilla/addon-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addon-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addon-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addon-sdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/addon-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addon-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addon-sdk/merges","archive_url":"https://api.github.com/repos/mozilla/addon-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addon-sdk/downloads","issues_url":"https://api.github.com/repos/mozilla/addon-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addon-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addon-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addon-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addon-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addon-sdk/releases{/id}","created_at":"2010-06-30T00:38:20Z","updated_at":"2015-01-09T22:50:43Z","pushed_at":"2015-01-09T22:50:43Z","git_url":"git://github.com/mozilla/addon-sdk.git","ssh_url":"git@github.com:mozilla/addon-sdk.git","clone_url":"https://github.com/mozilla/addon-sdk.git","svn_url":"https://github.com/mozilla/addon-sdk","homepage":"https://wiki.mozilla.org/Labs/Jetpack","size":39173,"stargazers_count":527,"watchers_count":527,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":67,"forks":280,"open_issues":67,"watchers":527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829"},"html":{"href":"https://github.com/mozilla/addon-sdk/pull/1829"},"issue":{"href":"https://api.github.com/repos/mozilla/addon-sdk/issues/1829"},"comments":{"href":"https://api.github.com/repos/mozilla/addon-sdk/issues/1829/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addon-sdk/pulls/1829/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addon-sdk/statuses/50d313567e9b825a1f93af422bedd8d467dc3541"}}}}