{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/29820334","id":29820334,"diff_hunk":"@@ -22,6 +22,8 @@ export default {\n       return;\n     }\n \n+    hash.isComponentHelper = true;","path":"packages/ember-htmlbars/lib/keywords/component.js","position":4,"original_position":4,"commit_id":"ba315c7a212ed2dc70c9f04e9f9fb360ba0f5e52","original_commit_id":"ba315c7a212ed2dc70c9f04e9f9fb360ba0f5e52","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"You can add a flag above (in `setupState`) instead of modifying the hash.\r\n\r\nSomething like:\r\n\r\n```javascript\r\nsetupState(lastState, env, scope, params, hash) {\r\n    let state = {\r\n      componentPath: env.hooks.getValue(params[0]),\r\n      manager: lastState && lastState.manager,\r\n      isComponentHelper: true\r\n    };\r\n\r\n    return state;\r\n  }\r\n```\r\n\r\nThen access that in the `ComponentNodeManager.create` (it is called `renderNode` there) as `renderNode.isComponentHelper`. ","created_at":"2015-05-07T02:27:30Z","updated_at":"2015-05-07T02:27:30Z","html_url":"https://github.com/emberjs/ember.js/pull/11045#discussion_r29820334","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11045","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/29820334"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11045#discussion_r29820334"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11045"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/11045","id":34839478,"html_url":"https://github.com/emberjs/ember.js/pull/11045","diff_url":"https://github.com/emberjs/ember.js/pull/11045.diff","patch_url":"https://github.com/emberjs/ember.js/pull/11045.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/11045","number":11045,"state":"open","locked":false,"title":"Fix positionalParams when using {{component}} helper","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"body":"Since the first parameter passed to the `{{component}}` helper is the\r\nname of the component which shall be rendered, this needs to be\r\nconsidered when the positionalParams are constructed for the specific\r\ncomponent.","created_at":"2015-05-06T17:20:51Z","updated_at":"2015-05-07T02:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6aba6f252e14938e9982b34de084b606e98150a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11045/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/11045/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/11045/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/ba315c7a212ed2dc70c9f04e9f9fb360ba0f5e52","head":{"label":"pangratz:positional_params_in_component_helper","ref":"positional_params_in_component_helper","sha":"ba315c7a212ed2dc70c9f04e9f9fb360ba0f5e52","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"repo":{"id":2997378,"name":"ember.js","full_name":"pangratz/ember.js","owner":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pangratz/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/pangratz/ember.js","forks_url":"https://api.github.com/repos/pangratz/ember.js/forks","keys_url":"https://api.github.com/repos/pangratz/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pangratz/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pangratz/ember.js/teams","hooks_url":"https://api.github.com/repos/pangratz/ember.js/hooks","issue_events_url":"https://api.github.com/repos/pangratz/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/pangratz/ember.js/events","assignees_url":"https://api.github.com/repos/pangratz/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/pangratz/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/pangratz/ember.js/tags","blobs_url":"https://api.github.com/repos/pangratz/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pangratz/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pangratz/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pangratz/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pangratz/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/pangratz/ember.js/languages","stargazers_url":"https://api.github.com/repos/pangratz/ember.js/stargazers","contributors_url":"https://api.github.com/repos/pangratz/ember.js/contributors","subscribers_url":"https://api.github.com/repos/pangratz/ember.js/subscribers","subscription_url":"https://api.github.com/repos/pangratz/ember.js/subscription","commits_url":"https://api.github.com/repos/pangratz/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pangratz/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pangratz/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pangratz/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pangratz/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/pangratz/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pangratz/ember.js/merges","archive_url":"https://api.github.com/repos/pangratz/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pangratz/ember.js/downloads","issues_url":"https://api.github.com/repos/pangratz/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/pangratz/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/pangratz/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/pangratz/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pangratz/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/pangratz/ember.js/releases{/id}","created_at":"2011-12-16T20:12:37Z","updated_at":"2015-05-06T15:47:42Z","pushed_at":"2015-05-06T17:20:42Z","git_url":"git://github.com/pangratz/ember.js.git","ssh_url":"git@github.com:pangratz/ember.js.git","clone_url":"https://github.com/pangratz/ember.js.git","svn_url":"https://github.com/pangratz/ember.js","homepage":"http://www.emberjs.com","size":21578,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"b2163fd241feaddec7a64844756acac7cb83d972","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-05-07T00:25:57Z","pushed_at":"2015-05-07T02:06:49Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":81968,"stargazers_count":13631,"watchers_count":13631,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2907,"mirror_url":null,"open_issues_count":435,"forks":2907,"open_issues":435,"watchers":13631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11045"},"html":{"href":"https://github.com/emberjs/ember.js/pull/11045"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11045"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/11045/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11045/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/11045/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/ba315c7a212ed2dc70c9f04e9f9fb360ba0f5e52"}}}}