{"action":"created","issue":{"url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/71","labels_url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/71/comments","events_url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/71/events","html_url":"https://github.com/BanManagement/BanManager-WebUI/pull/71","id":96723025,"number":71,"title":"Improve UUID array SELECT query by using IN clause.","user":{"login":"SupaHam","id":1299921,"avatar_url":"https://avatars.githubusercontent.com/u/1299921?v=3","gravatar_id":"","url":"https://api.github.com/users/SupaHam","html_url":"https://github.com/SupaHam","followers_url":"https://api.github.com/users/SupaHam/followers","following_url":"https://api.github.com/users/SupaHam/following{/other_user}","gists_url":"https://api.github.com/users/SupaHam/gists{/gist_id}","starred_url":"https://api.github.com/users/SupaHam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SupaHam/subscriptions","organizations_url":"https://api.github.com/users/SupaHam/orgs","repos_url":"https://api.github.com/users/SupaHam/repos","events_url":"https://api.github.com/users/SupaHam/events{/privacy}","received_events_url":"https://api.github.com/users/SupaHam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-23T03:59:16Z","updated_at":"2015-07-23T19:15:05Z","closed_at":"2015-07-23T12:33:49Z","pull_request":{"url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/pulls/71","html_url":"https://github.com/BanManagement/BanManager-WebUI/pull/71","diff_url":"https://github.com/BanManagement/BanManager-WebUI/pull/71.diff","patch_url":"https://github.com/BanManagement/BanManager-WebUI/pull/71.patch"},"body":"This PR improves the SELECT query in constructWhereWithUUIDs($uuidArray, $idColumn) by utilizing the IN clause provided by MySQL instead of repeating if-field-equals statement in the WHERE clause.\r\n\r\nThis still doesn't fully improve the performance as mentioned in #70 but it does a little bit, caching should definitely be looked at.\r\n\r\nP.S.: I'm not a PHP developer but I've tested this code and it works. I hope I'm not breaking any conventions with my one extra line. :P"},"comment":{"url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/comments/124215235","html_url":"https://github.com/BanManagement/BanManager-WebUI/pull/71#issuecomment-124215235","issue_url":"https://api.github.com/repos/BanManagement/BanManager-WebUI/issues/71","id":124215235,"user":{"login":"SupaHam","id":1299921,"avatar_url":"https://avatars.githubusercontent.com/u/1299921?v=3","gravatar_id":"","url":"https://api.github.com/users/SupaHam","html_url":"https://github.com/SupaHam","followers_url":"https://api.github.com/users/SupaHam/followers","following_url":"https://api.github.com/users/SupaHam/following{/other_user}","gists_url":"https://api.github.com/users/SupaHam/gists{/gist_id}","starred_url":"https://api.github.com/users/SupaHam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SupaHam/subscriptions","organizations_url":"https://api.github.com/users/SupaHam/orgs","repos_url":"https://api.github.com/users/SupaHam/repos","events_url":"https://api.github.com/users/SupaHam/events{/privacy}","received_events_url":"https://api.github.com/users/SupaHam/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T19:15:05Z","updated_at":"2015-07-23T19:15:05Z","body":"I wish I could say the same. Sadly my requests over 3k entries take at the very least 15 seconds. Even when I just increase the page by one. The cache really needs to be looked at for fixing, unless this part of the code doesn't even get cached, which wouldn't be a very wise decision to keep."}}