{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2","id":33608678,"html_url":"https://github.com/Yelp/garethr-docker/pull/2","diff_url":"https://github.com/Yelp/garethr-docker/pull/2.diff","patch_url":"https://github.com/Yelp/garethr-docker/pull/2.patch","issue_url":"https://api.github.com/repos/Yelp/garethr-docker/issues/2","number":2,"state":"open","locked":false,"title":"Convergent docker image","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"body":"Primary: @bobtfish \r\n\r\nThis brings us back up to upstream and adds a wrapper for docker pull to allow puppet to know when an update has been applied, so it can correctly converge and refresh other resources.\r\n\r\nThe addresses the problem of `docker::image { 'foo': ensure => latest }` never converging. And it also solves the problem of \r\n\r\n```puppet\r\ndocker::image { 'foo': ensure => latest } ~>\r\ndocker::run { 'foo': }\r\n```\r\n\r\nnever converging and always restarting the image. (which it does now with the recent init script fixes)\r\n\r\nI intend to dogfood this at yelp for a while and then PR upstream cc @garethr \r\nOr if he is a true-believer, can take it based on my test coverage?","created_at":"2015-04-18T20:57:14Z","updated_at":"2015-04-18T20:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Yelp/garethr-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/garethr-docker/issues/2/comments","statuses_url":"https://api.github.com/repos/Yelp/garethr-docker/statuses/e029316abdda2746fb76c738e9936e58c98d058c","head":{"label":"solarkennedy:convergent_docker_image","ref":"convergent_docker_image","sha":"e029316abdda2746fb76c738e9936e58c98d058c","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"repo":{"id":27639899,"name":"garethr-docker","full_name":"solarkennedy/garethr-docker","owner":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solarkennedy/garethr-docker","description":"Puppet module for managing docker","fork":true,"url":"https://api.github.com/repos/solarkennedy/garethr-docker","forks_url":"https://api.github.com/repos/solarkennedy/garethr-docker/forks","keys_url":"https://api.github.com/repos/solarkennedy/garethr-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solarkennedy/garethr-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solarkennedy/garethr-docker/teams","hooks_url":"https://api.github.com/repos/solarkennedy/garethr-docker/hooks","issue_events_url":"https://api.github.com/repos/solarkennedy/garethr-docker/issues/events{/number}","events_url":"https://api.github.com/repos/solarkennedy/garethr-docker/events","assignees_url":"https://api.github.com/repos/solarkennedy/garethr-docker/assignees{/user}","branches_url":"https://api.github.com/repos/solarkennedy/garethr-docker/branches{/branch}","tags_url":"https://api.github.com/repos/solarkennedy/garethr-docker/tags","blobs_url":"https://api.github.com/repos/solarkennedy/garethr-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solarkennedy/garethr-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solarkennedy/garethr-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/solarkennedy/garethr-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solarkennedy/garethr-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/solarkennedy/garethr-docker/languages","stargazers_url":"https://api.github.com/repos/solarkennedy/garethr-docker/stargazers","contributors_url":"https://api.github.com/repos/solarkennedy/garethr-docker/contributors","subscribers_url":"https://api.github.com/repos/solarkennedy/garethr-docker/subscribers","subscription_url":"https://api.github.com/repos/solarkennedy/garethr-docker/subscription","commits_url":"https://api.github.com/repos/solarkennedy/garethr-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/solarkennedy/garethr-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/solarkennedy/garethr-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/solarkennedy/garethr-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/solarkennedy/garethr-docker/contents/{+path}","compare_url":"https://api.github.com/repos/solarkennedy/garethr-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solarkennedy/garethr-docker/merges","archive_url":"https://api.github.com/repos/solarkennedy/garethr-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solarkennedy/garethr-docker/downloads","issues_url":"https://api.github.com/repos/solarkennedy/garethr-docker/issues{/number}","pulls_url":"https://api.github.com/repos/solarkennedy/garethr-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/solarkennedy/garethr-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/solarkennedy/garethr-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solarkennedy/garethr-docker/labels{/name}","releases_url":"https://api.github.com/repos/solarkennedy/garethr-docker/releases{/id}","created_at":"2014-12-06T16:04:55Z","updated_at":"2015-04-18T17:41:50Z","pushed_at":"2015-04-18T20:50:39Z","git_url":"git://github.com/solarkennedy/garethr-docker.git","ssh_url":"git@github.com:solarkennedy/garethr-docker.git","clone_url":"https://github.com/solarkennedy/garethr-docker.git","svn_url":"https://github.com/solarkennedy/garethr-docker","homepage":null,"size":718,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"627b5d501a263a724bc3017d9beba9f7634cd036","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":24427349,"name":"garethr-docker","full_name":"Yelp/garethr-docker","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/garethr-docker","description":"Puppet module for managing docker","fork":true,"url":"https://api.github.com/repos/Yelp/garethr-docker","forks_url":"https://api.github.com/repos/Yelp/garethr-docker/forks","keys_url":"https://api.github.com/repos/Yelp/garethr-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/garethr-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/garethr-docker/teams","hooks_url":"https://api.github.com/repos/Yelp/garethr-docker/hooks","issue_events_url":"https://api.github.com/repos/Yelp/garethr-docker/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/garethr-docker/events","assignees_url":"https://api.github.com/repos/Yelp/garethr-docker/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/garethr-docker/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/garethr-docker/tags","blobs_url":"https://api.github.com/repos/Yelp/garethr-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/garethr-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/garethr-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/garethr-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/garethr-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/garethr-docker/languages","stargazers_url":"https://api.github.com/repos/Yelp/garethr-docker/stargazers","contributors_url":"https://api.github.com/repos/Yelp/garethr-docker/contributors","subscribers_url":"https://api.github.com/repos/Yelp/garethr-docker/subscribers","subscription_url":"https://api.github.com/repos/Yelp/garethr-docker/subscription","commits_url":"https://api.github.com/repos/Yelp/garethr-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/garethr-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/garethr-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/garethr-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/garethr-docker/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/garethr-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/garethr-docker/merges","archive_url":"https://api.github.com/repos/Yelp/garethr-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/garethr-docker/downloads","issues_url":"https://api.github.com/repos/Yelp/garethr-docker/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/garethr-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/garethr-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/garethr-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/garethr-docker/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/garethr-docker/releases{/id}","created_at":"2014-09-24T18:30:04Z","updated_at":"2015-04-17T03:31:38Z","pushed_at":"2015-04-18T20:57:14Z","git_url":"git://github.com/Yelp/garethr-docker.git","ssh_url":"git@github.com:Yelp/garethr-docker.git","clone_url":"https://github.com/Yelp/garethr-docker.git","svn_url":"https://github.com/Yelp/garethr-docker","homepage":null,"size":685,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2"},"html":{"href":"https://github.com/Yelp/garethr-docker/pull/2"},"issue":{"href":"https://api.github.com/repos/Yelp/garethr-docker/issues/2"},"comments":{"href":"https://api.github.com/repos/Yelp/garethr-docker/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/garethr-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/garethr-docker/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/garethr-docker/statuses/e029316abdda2746fb76c738e9936e58c98d058c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":14,"additions":142,"deletions":35,"changed_files":20}}