{"action":"created","issue":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/1470","labels_url":"https://api.github.com/repos/scala-js/scala-js/issues/1470/labels{/name}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1470/comments","events_url":"https://api.github.com/repos/scala-js/scala-js/issues/1470/events","html_url":"https://github.com/scala-js/scala-js/pull/1470","id":55766576,"number":1470,"title":"Fix #1469: Add NaN, Infinity and undefined to Closure externs.","user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-28T15:01:22Z","updated_at":"2015-01-28T15:01:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1470","html_url":"https://github.com/scala-js/scala-js/pull/1470","diff_url":"https://github.com/scala-js/scala-js/pull/1470.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1470.patch"},"body":"Apparently, Closure really wants those to be defined in externs, otherwise its constant folding can cause it to crash.\r\n\r\nI consider this a sufficiently low risk fix not to warrant an additional RC cycle."},"comment":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/comments/71848361","html_url":"https://github.com/scala-js/scala-js/pull/1470#issuecomment-71848361","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1470","id":71848361,"user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T15:01:55Z","updated_at":"2015-01-28T15:01:55Z","body":"Review by @gzm0 please.\r\nAnd yes, I did verify that test regression test I came up with does crash fullOpt before I applied the fix."}}