{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10","id":53921022,"html_url":"https://github.com/abenassi/Google-Search-API/pull/10","diff_url":"https://github.com/abenassi/Google-Search-API/pull/10.diff","patch_url":"https://github.com/abenassi/Google-Search-API/pull/10.patch","issue_url":"https://api.github.com/repos/abenassi/Google-Search-API/issues/10","number":10,"state":"open","locked":false,"title":"Removed the call to normalize_query() for searches.","user":{"login":"hugsy","id":590234,"avatar_url":"https://avatars.githubusercontent.com/u/590234?v=3","gravatar_id":"","url":"https://api.github.com/users/hugsy","html_url":"https://github.com/hugsy","followers_url":"https://api.github.com/users/hugsy/followers","following_url":"https://api.github.com/users/hugsy/following{/other_user}","gists_url":"https://api.github.com/users/hugsy/gists{/gist_id}","starred_url":"https://api.github.com/users/hugsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugsy/subscriptions","organizations_url":"https://api.github.com/users/hugsy/orgs","repos_url":"https://api.github.com/users/hugsy/repos","events_url":"https://api.github.com/users/hugsy/events{/privacy}","received_events_url":"https://api.github.com/users/hugsy/received_events","type":"User","site_admin":false},"body":"In `_get_search_url()`, we removed the call to `normalize_query()` for the `q` parameter.\r\nThe normalization is already performed by `urllib.urlencode()` (L36). \r\nExample:\r\n```python\r\n>>> import urllib\r\n>>> urllib.urlencode({\"q\": \"a:b+c\"})  \r\n'q=a%3Ab%2Bc' # good value\r\n>>> def normalize_query(query): return query.strip().replace(\":\", \"%3A\").replace(\"+\", \"%2B\").replace(\"&\", \"%26\").replace(\" \", \"+\" )\r\n>>> urllib.urlencode({\"q\": normalize_query(\"a:b+c\")})\r\n'q=a%253Ab%252Bc' # wrong value because characters like + or : were encoded twice.\r\n```\r\nThis simple hack allows Google keywords (`site:`, `filetype:`, etc.) to work as expected.","created_at":"2015-12-17T00:52:12Z","updated_at":"2015-12-17T00:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10/commits","review_comments_url":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10/comments","review_comment_url":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abenassi/Google-Search-API/issues/10/comments","statuses_url":"https://api.github.com/repos/abenassi/Google-Search-API/statuses/564694c25684c0f236a8023e6281f52ca2250b63","head":{"label":"hugsy:master","ref":"master","sha":"564694c25684c0f236a8023e6281f52ca2250b63","user":{"login":"hugsy","id":590234,"avatar_url":"https://avatars.githubusercontent.com/u/590234?v=3","gravatar_id":"","url":"https://api.github.com/users/hugsy","html_url":"https://github.com/hugsy","followers_url":"https://api.github.com/users/hugsy/followers","following_url":"https://api.github.com/users/hugsy/following{/other_user}","gists_url":"https://api.github.com/users/hugsy/gists{/gist_id}","starred_url":"https://api.github.com/users/hugsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugsy/subscriptions","organizations_url":"https://api.github.com/users/hugsy/orgs","repos_url":"https://api.github.com/users/hugsy/repos","events_url":"https://api.github.com/users/hugsy/events{/privacy}","received_events_url":"https://api.github.com/users/hugsy/received_events","type":"User","site_admin":false},"repo":{"id":48143352,"name":"Google-Search-API","full_name":"hugsy/Google-Search-API","owner":{"login":"hugsy","id":590234,"avatar_url":"https://avatars.githubusercontent.com/u/590234?v=3","gravatar_id":"","url":"https://api.github.com/users/hugsy","html_url":"https://github.com/hugsy","followers_url":"https://api.github.com/users/hugsy/followers","following_url":"https://api.github.com/users/hugsy/following{/other_user}","gists_url":"https://api.github.com/users/hugsy/gists{/gist_id}","starred_url":"https://api.github.com/users/hugsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugsy/subscriptions","organizations_url":"https://api.github.com/users/hugsy/orgs","repos_url":"https://api.github.com/users/hugsy/repos","events_url":"https://api.github.com/users/hugsy/events{/privacy}","received_events_url":"https://api.github.com/users/hugsy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hugsy/Google-Search-API","description":"Python based api for searching google web, images, calc, and currency conversion.","fork":true,"url":"https://api.github.com/repos/hugsy/Google-Search-API","forks_url":"https://api.github.com/repos/hugsy/Google-Search-API/forks","keys_url":"https://api.github.com/repos/hugsy/Google-Search-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hugsy/Google-Search-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hugsy/Google-Search-API/teams","hooks_url":"https://api.github.com/repos/hugsy/Google-Search-API/hooks","issue_events_url":"https://api.github.com/repos/hugsy/Google-Search-API/issues/events{/number}","events_url":"https://api.github.com/repos/hugsy/Google-Search-API/events","assignees_url":"https://api.github.com/repos/hugsy/Google-Search-API/assignees{/user}","branches_url":"https://api.github.com/repos/hugsy/Google-Search-API/branches{/branch}","tags_url":"https://api.github.com/repos/hugsy/Google-Search-API/tags","blobs_url":"https://api.github.com/repos/hugsy/Google-Search-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hugsy/Google-Search-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hugsy/Google-Search-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/hugsy/Google-Search-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hugsy/Google-Search-API/statuses/{sha}","languages_url":"https://api.github.com/repos/hugsy/Google-Search-API/languages","stargazers_url":"https://api.github.com/repos/hugsy/Google-Search-API/stargazers","contributors_url":"https://api.github.com/repos/hugsy/Google-Search-API/contributors","subscribers_url":"https://api.github.com/repos/hugsy/Google-Search-API/subscribers","subscription_url":"https://api.github.com/repos/hugsy/Google-Search-API/subscription","commits_url":"https://api.github.com/repos/hugsy/Google-Search-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/hugsy/Google-Search-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/hugsy/Google-Search-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/hugsy/Google-Search-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/hugsy/Google-Search-API/contents/{+path}","compare_url":"https://api.github.com/repos/hugsy/Google-Search-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hugsy/Google-Search-API/merges","archive_url":"https://api.github.com/repos/hugsy/Google-Search-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hugsy/Google-Search-API/downloads","issues_url":"https://api.github.com/repos/hugsy/Google-Search-API/issues{/number}","pulls_url":"https://api.github.com/repos/hugsy/Google-Search-API/pulls{/number}","milestones_url":"https://api.github.com/repos/hugsy/Google-Search-API/milestones{/number}","notifications_url":"https://api.github.com/repos/hugsy/Google-Search-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hugsy/Google-Search-API/labels{/name}","releases_url":"https://api.github.com/repos/hugsy/Google-Search-API/releases{/id}","created_at":"2015-12-17T00:43:46Z","updated_at":"2015-12-17T00:43:46Z","pushed_at":"2015-12-17T00:47:54Z","git_url":"git://github.com/hugsy/Google-Search-API.git","ssh_url":"git@github.com:hugsy/Google-Search-API.git","clone_url":"https://github.com/hugsy/Google-Search-API.git","svn_url":"https://github.com/hugsy/Google-Search-API","homepage":"","size":455,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abenassi:master","ref":"master","sha":"dff4a35291cabe93a9206db98e7b7114982f14b2","user":{"login":"abenassi","id":4405346,"avatar_url":"https://avatars.githubusercontent.com/u/4405346?v=3","gravatar_id":"","url":"https://api.github.com/users/abenassi","html_url":"https://github.com/abenassi","followers_url":"https://api.github.com/users/abenassi/followers","following_url":"https://api.github.com/users/abenassi/following{/other_user}","gists_url":"https://api.github.com/users/abenassi/gists{/gist_id}","starred_url":"https://api.github.com/users/abenassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abenassi/subscriptions","organizations_url":"https://api.github.com/users/abenassi/orgs","repos_url":"https://api.github.com/users/abenassi/repos","events_url":"https://api.github.com/users/abenassi/events{/privacy}","received_events_url":"https://api.github.com/users/abenassi/received_events","type":"User","site_admin":false},"repo":{"id":26150368,"name":"Google-Search-API","full_name":"abenassi/Google-Search-API","owner":{"login":"abenassi","id":4405346,"avatar_url":"https://avatars.githubusercontent.com/u/4405346?v=3","gravatar_id":"","url":"https://api.github.com/users/abenassi","html_url":"https://github.com/abenassi","followers_url":"https://api.github.com/users/abenassi/followers","following_url":"https://api.github.com/users/abenassi/following{/other_user}","gists_url":"https://api.github.com/users/abenassi/gists{/gist_id}","starred_url":"https://api.github.com/users/abenassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abenassi/subscriptions","organizations_url":"https://api.github.com/users/abenassi/orgs","repos_url":"https://api.github.com/users/abenassi/repos","events_url":"https://api.github.com/users/abenassi/events{/privacy}","received_events_url":"https://api.github.com/users/abenassi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abenassi/Google-Search-API","description":"Python based api for searching google web, images, calc, and currency conversion.","fork":true,"url":"https://api.github.com/repos/abenassi/Google-Search-API","forks_url":"https://api.github.com/repos/abenassi/Google-Search-API/forks","keys_url":"https://api.github.com/repos/abenassi/Google-Search-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abenassi/Google-Search-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abenassi/Google-Search-API/teams","hooks_url":"https://api.github.com/repos/abenassi/Google-Search-API/hooks","issue_events_url":"https://api.github.com/repos/abenassi/Google-Search-API/issues/events{/number}","events_url":"https://api.github.com/repos/abenassi/Google-Search-API/events","assignees_url":"https://api.github.com/repos/abenassi/Google-Search-API/assignees{/user}","branches_url":"https://api.github.com/repos/abenassi/Google-Search-API/branches{/branch}","tags_url":"https://api.github.com/repos/abenassi/Google-Search-API/tags","blobs_url":"https://api.github.com/repos/abenassi/Google-Search-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abenassi/Google-Search-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abenassi/Google-Search-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/abenassi/Google-Search-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abenassi/Google-Search-API/statuses/{sha}","languages_url":"https://api.github.com/repos/abenassi/Google-Search-API/languages","stargazers_url":"https://api.github.com/repos/abenassi/Google-Search-API/stargazers","contributors_url":"https://api.github.com/repos/abenassi/Google-Search-API/contributors","subscribers_url":"https://api.github.com/repos/abenassi/Google-Search-API/subscribers","subscription_url":"https://api.github.com/repos/abenassi/Google-Search-API/subscription","commits_url":"https://api.github.com/repos/abenassi/Google-Search-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/abenassi/Google-Search-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/abenassi/Google-Search-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/abenassi/Google-Search-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/abenassi/Google-Search-API/contents/{+path}","compare_url":"https://api.github.com/repos/abenassi/Google-Search-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abenassi/Google-Search-API/merges","archive_url":"https://api.github.com/repos/abenassi/Google-Search-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abenassi/Google-Search-API/downloads","issues_url":"https://api.github.com/repos/abenassi/Google-Search-API/issues{/number}","pulls_url":"https://api.github.com/repos/abenassi/Google-Search-API/pulls{/number}","milestones_url":"https://api.github.com/repos/abenassi/Google-Search-API/milestones{/number}","notifications_url":"https://api.github.com/repos/abenassi/Google-Search-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abenassi/Google-Search-API/labels{/name}","releases_url":"https://api.github.com/repos/abenassi/Google-Search-API/releases{/id}","created_at":"2014-11-04T03:06:40Z","updated_at":"2015-12-12T08:07:54Z","pushed_at":"2015-12-17T00:52:12Z","git_url":"git://github.com/abenassi/Google-Search-API.git","ssh_url":"git@github.com:abenassi/Google-Search-API.git","clone_url":"https://github.com/abenassi/Google-Search-API.git","svn_url":"https://github.com/abenassi/Google-Search-API","homepage":"","size":912,"stargazers_count":36,"watchers_count":36,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10"},"html":{"href":"https://github.com/abenassi/Google-Search-API/pull/10"},"issue":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/issues/10"},"comments":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/abenassi/Google-Search-API/statuses/564694c25684c0f236a8023e6281f52ca2250b63"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}