{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/44728766","id":44728766,"diff_hunk":"@@ -422,11 +423,16 @@ static ScanResult scan(Collection<URL> pathsToScan, Collection<String> packagePr\n     }\n   }\n \n-  private static void verifyClassUnicity(List<AnnotatedClassDescriptor> annotatedClasses) {\n+  private static void verifyClassUnicity(List<AnnotatedClassDescriptor> annotatedClasses, Collection<URL> pathsScanned) {\n     Set<String> scanned = new HashSet<>();\n     for (AnnotatedClassDescriptor annotated : annotatedClasses) {\n       if (!scanned.add(annotated.getClassName())) {\n-        throw new RuntimeException(\"BUG: \" + annotated.getClassName() + \" scanned twice\");\n+        throw UserException.functionError()\n+            .message(\n+                \"function %s scanned twice in %s\\nDo you have conflicting jars on the classpath?\",\n+                annotated.getClassName(), pathsScanned","path":"common/src/main/java/org/apache/drill/common/scanner/ClassPathScanner.java","position":30,"original_position":30,"commit_id":"2caed6a32af84161ae154d092bf673a7efaf24b9","original_commit_id":"2caed6a32af84161ae154d092bf673a7efaf24b9","user":{"login":"jaltekruse","id":365366,"avatar_url":"https://avatars.githubusercontent.com/u/365366?v=3","gravatar_id":"","url":"https://api.github.com/users/jaltekruse","html_url":"https://github.com/jaltekruse","followers_url":"https://api.github.com/users/jaltekruse/followers","following_url":"https://api.github.com/users/jaltekruse/following{/other_user}","gists_url":"https://api.github.com/users/jaltekruse/gists{/gist_id}","starred_url":"https://api.github.com/users/jaltekruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaltekruse/subscriptions","organizations_url":"https://api.github.com/users/jaltekruse/orgs","repos_url":"https://api.github.com/users/jaltekruse/repos","events_url":"https://api.github.com/users/jaltekruse/events{/privacy}","received_events_url":"https://api.github.com/users/jaltekruse/received_events","type":"User","site_admin":false},"body":"I did not know that, will have to remember it for future reference. In this case it might make sense to put the URLs on separate lines. The message is already multi-line and if these are going to be long paths it would make it easier to read the list and look for duplicated jars.","created_at":"2015-11-12T23:05:07Z","updated_at":"2015-11-12T23:05:07Z","html_url":"https://github.com/apache/drill/pull/252#discussion_r44728766","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/252","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/44728766"},"html":{"href":"https://github.com/apache/drill/pull/252#discussion_r44728766"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/252","id":50577569,"html_url":"https://github.com/apache/drill/pull/252","diff_url":"https://github.com/apache/drill/pull/252.diff","patch_url":"https://github.com/apache/drill/pull/252.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/252","number":252,"state":"open","locked":false,"title":"DRILL-4082: Better error message when multiple versions of the same f…","user":{"login":"julienledem","id":367841,"avatar_url":"https://avatars.githubusercontent.com/u/367841?v=3","gravatar_id":"","url":"https://api.github.com/users/julienledem","html_url":"https://github.com/julienledem","followers_url":"https://api.github.com/users/julienledem/followers","following_url":"https://api.github.com/users/julienledem/following{/other_user}","gists_url":"https://api.github.com/users/julienledem/gists{/gist_id}","starred_url":"https://api.github.com/users/julienledem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienledem/subscriptions","organizations_url":"https://api.github.com/users/julienledem/orgs","repos_url":"https://api.github.com/users/julienledem/repos","events_url":"https://api.github.com/users/julienledem/events{/privacy}","received_events_url":"https://api.github.com/users/julienledem/received_events","type":"User","site_admin":false},"body":"…unction are found by the classpath scanner","created_at":"2015-11-12T22:27:51Z","updated_at":"2015-11-12T23:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70e91b782b13144b1bf25481b1fd0a32a520d161","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/252/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/252/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/252/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/2caed6a32af84161ae154d092bf673a7efaf24b9","head":{"label":"julienledem:DRILL-4082","ref":"DRILL-4082","sha":"2caed6a32af84161ae154d092bf673a7efaf24b9","user":{"login":"julienledem","id":367841,"avatar_url":"https://avatars.githubusercontent.com/u/367841?v=3","gravatar_id":"","url":"https://api.github.com/users/julienledem","html_url":"https://github.com/julienledem","followers_url":"https://api.github.com/users/julienledem/followers","following_url":"https://api.github.com/users/julienledem/following{/other_user}","gists_url":"https://api.github.com/users/julienledem/gists{/gist_id}","starred_url":"https://api.github.com/users/julienledem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienledem/subscriptions","organizations_url":"https://api.github.com/users/julienledem/orgs","repos_url":"https://api.github.com/users/julienledem/repos","events_url":"https://api.github.com/users/julienledem/events{/privacy}","received_events_url":"https://api.github.com/users/julienledem/received_events","type":"User","site_admin":false},"repo":{"id":40999073,"name":"drill","full_name":"julienledem/drill","owner":{"login":"julienledem","id":367841,"avatar_url":"https://avatars.githubusercontent.com/u/367841?v=3","gravatar_id":"","url":"https://api.github.com/users/julienledem","html_url":"https://github.com/julienledem","followers_url":"https://api.github.com/users/julienledem/followers","following_url":"https://api.github.com/users/julienledem/following{/other_user}","gists_url":"https://api.github.com/users/julienledem/gists{/gist_id}","starred_url":"https://api.github.com/users/julienledem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienledem/subscriptions","organizations_url":"https://api.github.com/users/julienledem/orgs","repos_url":"https://api.github.com/users/julienledem/repos","events_url":"https://api.github.com/users/julienledem/events{/privacy}","received_events_url":"https://api.github.com/users/julienledem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienledem/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/julienledem/drill","forks_url":"https://api.github.com/repos/julienledem/drill/forks","keys_url":"https://api.github.com/repos/julienledem/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienledem/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienledem/drill/teams","hooks_url":"https://api.github.com/repos/julienledem/drill/hooks","issue_events_url":"https://api.github.com/repos/julienledem/drill/issues/events{/number}","events_url":"https://api.github.com/repos/julienledem/drill/events","assignees_url":"https://api.github.com/repos/julienledem/drill/assignees{/user}","branches_url":"https://api.github.com/repos/julienledem/drill/branches{/branch}","tags_url":"https://api.github.com/repos/julienledem/drill/tags","blobs_url":"https://api.github.com/repos/julienledem/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienledem/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienledem/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienledem/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienledem/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/julienledem/drill/languages","stargazers_url":"https://api.github.com/repos/julienledem/drill/stargazers","contributors_url":"https://api.github.com/repos/julienledem/drill/contributors","subscribers_url":"https://api.github.com/repos/julienledem/drill/subscribers","subscription_url":"https://api.github.com/repos/julienledem/drill/subscription","commits_url":"https://api.github.com/repos/julienledem/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienledem/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienledem/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienledem/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienledem/drill/contents/{+path}","compare_url":"https://api.github.com/repos/julienledem/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienledem/drill/merges","archive_url":"https://api.github.com/repos/julienledem/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienledem/drill/downloads","issues_url":"https://api.github.com/repos/julienledem/drill/issues{/number}","pulls_url":"https://api.github.com/repos/julienledem/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/julienledem/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/julienledem/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienledem/drill/labels{/name}","releases_url":"https://api.github.com/repos/julienledem/drill/releases{/id}","created_at":"2015-08-18T21:45:00Z","updated_at":"2015-08-18T21:45:08Z","pushed_at":"2015-11-12T22:27:34Z","git_url":"git://github.com/julienledem/drill.git","ssh_url":"git@github.com:julienledem/drill.git","clone_url":"https://github.com/julienledem/drill.git","svn_url":"https://github.com/julienledem/drill","homepage":"","size":37013,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9b88d591450110b4a238d228138097c0f664a73e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","created_at":"2012-09-05T07:00:26Z","updated_at":"2015-11-11T12:09:33Z","pushed_at":"2015-11-12T22:27:51Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":49903,"stargazers_count":511,"watchers_count":511,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":335,"mirror_url":"git://git.apache.org/incubator-drill.git","open_issues_count":48,"forks":335,"open_issues":48,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/252"},"html":{"href":"https://github.com/apache/drill/pull/252"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/252"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/2caed6a32af84161ae154d092bf673a7efaf24b9"}}}}