{"action":"created","issue":{"url":"https://api.github.com/repos/colinmollenhour/modman/issues/96","labels_url":"https://api.github.com/repos/colinmollenhour/modman/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/colinmollenhour/modman/issues/96/comments","events_url":"https://api.github.com/repos/colinmollenhour/modman/issues/96/events","html_url":"https://github.com/colinmollenhour/modman/issues/96","id":83540442,"number":96,"title":"Modules with tags produce 'Update Error'","user":{"login":"adamj88","id":1053393,"avatar_url":"https://avatars.githubusercontent.com/u/1053393?v=3","gravatar_id":"","url":"https://api.github.com/users/adamj88","html_url":"https://github.com/adamj88","followers_url":"https://api.github.com/users/adamj88/followers","following_url":"https://api.github.com/users/adamj88/following{/other_user}","gists_url":"https://api.github.com/users/adamj88/gists{/gist_id}","starred_url":"https://api.github.com/users/adamj88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamj88/subscriptions","organizations_url":"https://api.github.com/users/adamj88/orgs","repos_url":"https://api.github.com/users/adamj88/repos","events_url":"https://api.github.com/users/adamj88/events{/privacy}","received_events_url":"https://api.github.com/users/adamj88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-01T14:49:52Z","updated_at":"2015-11-18T21:27:03Z","closed_at":null,"body":"I'm using modman to deploy specific versions (tagged as releases) of modules, when running `modman update-all` these modules produce the following error: \r\n\r\n```\r\nUpdating module_name\r\nCould not resolve remote tracking branch, code will not be updated.\r\n\r\nERROR: Error occurred while updating module_name\r\n```\r\n\r\nIt appears the following git command is responsible when returning an empty string: https://github.com/colinmollenhour/modman/blob/d58b80f2f9e60d3287577480ad78066d44ed530c/modman#L706-L714\r\n\r\nExpected behaviour should be:\r\n\r\n```Updating module_name\r\nAlready up-to-date.```\r\n\r\nor resolving the tag to a commit and updating the module"},"comment":{"url":"https://api.github.com/repos/colinmollenhour/modman/issues/comments/157869741","html_url":"https://github.com/colinmollenhour/modman/issues/96#issuecomment-157869741","issue_url":"https://api.github.com/repos/colinmollenhour/modman/issues/96","id":157869741,"user":{"login":"Silarn","id":826174,"avatar_url":"https://avatars.githubusercontent.com/u/826174?v=3","gravatar_id":"","url":"https://api.github.com/users/Silarn","html_url":"https://github.com/Silarn","followers_url":"https://api.github.com/users/Silarn/followers","following_url":"https://api.github.com/users/Silarn/following{/other_user}","gists_url":"https://api.github.com/users/Silarn/gists{/gist_id}","starred_url":"https://api.github.com/users/Silarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silarn/subscriptions","organizations_url":"https://api.github.com/users/Silarn/orgs","repos_url":"https://api.github.com/users/Silarn/repos","events_url":"https://api.github.com/users/Silarn/events{/privacy}","received_events_url":"https://api.github.com/users/Silarn/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T21:27:03Z","updated_at":"2015-11-18T21:27:03Z","body":"I submitted a pull request a while back which partially resolved this, as this is a case where your repo is not on an actual branch and is instead checked out at a specific commit. (A tag, in your case.)\r\n\r\nMy code attempts to identify the branch with that commit in it and checkout that branch before updating the code. I had a flaw in my detection though which made it only work for HEAD commits... I just submitted a new PR to fix this.\r\n\r\nHowever, this doesn't include tag detection. I feel like this would require some kind of additional flag to tell modman \"hey, keep my repos on any tagged commits\" as the default functionality is to run a fetch and pull - which assumes a branch setup.\r\n\r\nWhat sounds better to you?"}}