{"action":"created","issue":{"url":"https://api.github.com/repos/glue-viz/glue/issues/814","labels_url":"https://api.github.com/repos/glue-viz/glue/issues/814/labels{/name}","comments_url":"https://api.github.com/repos/glue-viz/glue/issues/814/comments","events_url":"https://api.github.com/repos/glue-viz/glue/issues/814/events","html_url":"https://github.com/glue-viz/glue/pull/814","id":124238357,"number":814,"title":"WIP: Create documentation about layer artists","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/glue-viz/glue/labels/documention","name":"documention","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-29T16:58:57Z","updated_at":"2015-12-30T19:45:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/glue-viz/glue/pulls/814","html_url":"https://github.com/glue-viz/glue/pull/814","diff_url":"https://github.com/glue-viz/glue/pull/814.diff","patch_url":"https://github.com/glue-viz/glue/pull/814.patch"},"body":"@ChrisBeaumont - while working on this, I ran across a couple of things in the API that would be nice to update:\r\n\r\n* ``DataViewer._container``: this name is pretty obscure, and it should maybe instead be ``DataViewer._layer_artists`` or ``DataViewer._layer_artist_container``.\r\n\r\n* Maybe the layer artist container should have a consistent name between clients and widgets (at the moment it's ``.artists`` vs ``_container`` for the same object, and ``artist_container`` in some kwargs). What about ``.layer_artists``, and make it public for both clients and widgets?\r\n\r\n* I have a mental block when I run across instances of the ``layer`` variable which really is the layer *data*. Would you have any objections to me renaming ``layer`` to ``layer_data``? So then we'd never have just 'layer' - either layer artist or layer data.\r\n\r\nWhat do you think?\r\n\r\nSide note: at the moment, we don't really talk about the possibility of using clients in these docs - and that's because in principle one doesn't *have* to use a separate client class. Before writing docs on how to better separate client functionality and GUI, I think it would be good to converge on a solution in https://github.com/glue-viz/glue/issues/775 first, so adding details of clients to the page here is low priority for now in my view.\r\n\r\n@PennyQ - just for info, I've started working on this, but it's by no means complete. I'll work on it more over the next couple of days (in my spare time)."},"comment":{"url":"https://api.github.com/repos/glue-viz/glue/issues/comments/168062956","html_url":"https://github.com/glue-viz/glue/pull/814#issuecomment-168062956","issue_url":"https://api.github.com/repos/glue-viz/glue/issues/814","id":168062956,"user":{"login":"ChrisBeaumont","id":796752,"avatar_url":"https://avatars.githubusercontent.com/u/796752?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBeaumont","html_url":"https://github.com/ChrisBeaumont","followers_url":"https://api.github.com/users/ChrisBeaumont/followers","following_url":"https://api.github.com/users/ChrisBeaumont/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBeaumont/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBeaumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBeaumont/subscriptions","organizations_url":"https://api.github.com/users/ChrisBeaumont/orgs","repos_url":"https://api.github.com/users/ChrisBeaumont/repos","events_url":"https://api.github.com/users/ChrisBeaumont/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBeaumont/received_events","type":"User","site_admin":false},"created_at":"2015-12-30T19:45:52Z","updated_at":"2015-12-30T19:45:52Z","body":"Doc changes LGTM.\r\n\r\n> DataViewer._container: this name is pretty obscure, and it should maybe instead be DataViewer._layer_artists or DataViewer._layer_artist_container.\r\n\r\n`DataViewer._layer_artist_container` sounds good\r\n\r\n> I have a mental block when I run across instances of the layer variable which really is the layer data. Would you have any objections to me renaming layer to layer_data? \r\n\r\nI can't remember, but doesn't `layer` sometimes refer to a Subset as well? In that case `layer_data` sounds misleading to my ears (as I recall I think I started using `layer` as an alias for `subset or data`, but I agree this isn't very obvious)\r\n\r\n"}}