{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments/25322198","id":25322198,"diff_hunk":"@@ -0,0 +1,29 @@\n+test_name 'temporary aio workarounds: ensure puppet and friends are on the path'\n+\n+step 'setup the symbolic links that aio packaging is not yet providing'\n+puppet_bindir = options[:puppetbindir]\n+new_puppet_bindir = '/opt/puppetlabs/bin'\n+agents.each do |agent|\n+  # stick current puppet hard-path in the ... PATH so we can use configprint\n+  agent.add_env_var('PATH', \"#{puppet_bindir}/puppet:$PATH\")\n+  on(agent, \"mkdir #{new_puppet_bindir}\")\n+  on(agent, \"ln -s #{puppet_bindir}/puppet \" \\\n+            \"#{new_puppet_bindir}/puppet\")\n+  on(agent, \"ln -s #{puppet_bindir}/hiera \" \\\n+            \"#{new_puppet_bindir}/hiera\")\n+  on(agent, \"ln -s #{puppet_bindir}/facter \" \\\n+            \"#{new_puppet_bindir}/facter\")\n+  agent.add_env_var('PATH', \"#{new_puppet_bindir}:$PATH\")\n+end\n+\n+# The AIO puppet-agent package does not create the puppet user or group, but\n+# puppet-server does. However, some puppet acceptance tests assume the user\n+# is present. This is a temporary setup step to create the puppet user and\n+# group, but only on nodes that are agents and not the master\n+step '(PUP-3997) Puppet User and Group on agents only'\n+agents.each do |agent|\n+  step \"Ensure puppet user and group added to #{agent}\" do\n+    on(agent, puppet('resource user puppet ensure=present'))\n+    on(agent, puppet('resource group puppet ensure=present'))\n+  end","path":"acceptance/setup/aio/pre-suite/020_AIO_Workarounds.rb","position":28,"original_position":28,"commit_id":"ae1e656d1b434e40953c4f0a730fcbdccff58b51","original_commit_id":"ae1e656d1b434e40953c4f0a730fcbdccff58b51","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"I'm pretty sure this isn't necessary for hiera acceptance tests. It's an issue in puppet because some tests assume the user exists: https://github.com/puppetlabs/puppet/blob/master/acceptance/tests/resource/user/should_not_create_existing.rb#L5","created_at":"2015-02-25T07:25:08Z","updated_at":"2015-02-25T07:25:08Z","html_url":"https://github.com/puppetlabs/hiera/pull/256#discussion_r25322198","pull_request_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments/25322198"},"html":{"href":"https://github.com/puppetlabs/hiera/pull/256#discussion_r25322198"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/hiera/pulls/256","id":29948398,"html_url":"https://github.com/puppetlabs/hiera/pull/256","diff_url":"https://github.com/puppetlabs/hiera/pull/256.diff","patch_url":"https://github.com/puppetlabs/hiera/pull/256.patch","issue_url":"https://api.github.com/repos/puppetlabs/hiera/issues/256","number":256,"state":"open","locked":false,"title":"(maint) HI-345 fix hiera pre-suite for aio","user":{"login":"er0ck","id":7454093,"avatar_url":"https://avatars.githubusercontent.com/u/7454093?v=3","gravatar_id":"","url":"https://api.github.com/users/er0ck","html_url":"https://github.com/er0ck","followers_url":"https://api.github.com/users/er0ck/followers","following_url":"https://api.github.com/users/er0ck/following{/other_user}","gists_url":"https://api.github.com/users/er0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/er0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/er0ck/subscriptions","organizations_url":"https://api.github.com/users/er0ck/orgs","repos_url":"https://api.github.com/users/er0ck/repos","events_url":"https://api.github.com/users/er0ck/events{/privacy}","received_events_url":"https://api.github.com/users/er0ck/received_events","type":"User","site_admin":false},"body":"Before this change the hiera pre-suite could not run puppet to configure\r\ntests properly.\r\nThis change creates temporary work-arounds until the aio packaging\r\ncreates and links binaries into the path properly.","created_at":"2015-02-24T23:51:37Z","updated_at":"2015-02-25T07:25:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a010f52c28e6a37f8720692cf137510702a22af7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/256/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/256/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/hiera/issues/256/comments","statuses_url":"https://api.github.com/repos/puppetlabs/hiera/statuses/ae1e656d1b434e40953c4f0a730fcbdccff58b51","head":{"label":"er0ck:maint/master/HI-345-fix_hiera_pre-suite_for_aio","ref":"maint/master/HI-345-fix_hiera_pre-suite_for_aio","sha":"ae1e656d1b434e40953c4f0a730fcbdccff58b51","user":{"login":"er0ck","id":7454093,"avatar_url":"https://avatars.githubusercontent.com/u/7454093?v=3","gravatar_id":"","url":"https://api.github.com/users/er0ck","html_url":"https://github.com/er0ck","followers_url":"https://api.github.com/users/er0ck/followers","following_url":"https://api.github.com/users/er0ck/following{/other_user}","gists_url":"https://api.github.com/users/er0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/er0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/er0ck/subscriptions","organizations_url":"https://api.github.com/users/er0ck/orgs","repos_url":"https://api.github.com/users/er0ck/repos","events_url":"https://api.github.com/users/er0ck/events{/privacy}","received_events_url":"https://api.github.com/users/er0ck/received_events","type":"User","site_admin":false},"repo":{"id":23802558,"name":"hiera","full_name":"er0ck/hiera","owner":{"login":"er0ck","id":7454093,"avatar_url":"https://avatars.githubusercontent.com/u/7454093?v=3","gravatar_id":"","url":"https://api.github.com/users/er0ck","html_url":"https://github.com/er0ck","followers_url":"https://api.github.com/users/er0ck/followers","following_url":"https://api.github.com/users/er0ck/following{/other_user}","gists_url":"https://api.github.com/users/er0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/er0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/er0ck/subscriptions","organizations_url":"https://api.github.com/users/er0ck/orgs","repos_url":"https://api.github.com/users/er0ck/repos","events_url":"https://api.github.com/users/er0ck/events{/privacy}","received_events_url":"https://api.github.com/users/er0ck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/er0ck/hiera","description":"Lightweight Pluggable Hierarchical Database","fork":true,"url":"https://api.github.com/repos/er0ck/hiera","forks_url":"https://api.github.com/repos/er0ck/hiera/forks","keys_url":"https://api.github.com/repos/er0ck/hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/er0ck/hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/er0ck/hiera/teams","hooks_url":"https://api.github.com/repos/er0ck/hiera/hooks","issue_events_url":"https://api.github.com/repos/er0ck/hiera/issues/events{/number}","events_url":"https://api.github.com/repos/er0ck/hiera/events","assignees_url":"https://api.github.com/repos/er0ck/hiera/assignees{/user}","branches_url":"https://api.github.com/repos/er0ck/hiera/branches{/branch}","tags_url":"https://api.github.com/repos/er0ck/hiera/tags","blobs_url":"https://api.github.com/repos/er0ck/hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/er0ck/hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/er0ck/hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/er0ck/hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/er0ck/hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/er0ck/hiera/languages","stargazers_url":"https://api.github.com/repos/er0ck/hiera/stargazers","contributors_url":"https://api.github.com/repos/er0ck/hiera/contributors","subscribers_url":"https://api.github.com/repos/er0ck/hiera/subscribers","subscription_url":"https://api.github.com/repos/er0ck/hiera/subscription","commits_url":"https://api.github.com/repos/er0ck/hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/er0ck/hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/er0ck/hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/er0ck/hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/er0ck/hiera/contents/{+path}","compare_url":"https://api.github.com/repos/er0ck/hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/er0ck/hiera/merges","archive_url":"https://api.github.com/repos/er0ck/hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/er0ck/hiera/downloads","issues_url":"https://api.github.com/repos/er0ck/hiera/issues{/number}","pulls_url":"https://api.github.com/repos/er0ck/hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/er0ck/hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/er0ck/hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/er0ck/hiera/labels{/name}","releases_url":"https://api.github.com/repos/er0ck/hiera/releases{/id}","created_at":"2014-09-08T18:20:17Z","updated_at":"2014-09-08T17:32:25Z","pushed_at":"2015-02-24T23:50:45Z","git_url":"git://github.com/er0ck/hiera.git","ssh_url":"git@github.com:er0ck/hiera.git","clone_url":"https://github.com/er0ck/hiera.git","svn_url":"https://github.com/er0ck/hiera","homepage":"http://projects.puppetlabs.com/projects/hiera/","size":635,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"00ce542ac8baaa52ff5dff87a48f74b51f67777d","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1845241,"name":"hiera","full_name":"puppetlabs/hiera","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/hiera","description":"Lightweight Pluggable Hierarchical Database","fork":false,"url":"https://api.github.com/repos/puppetlabs/hiera","forks_url":"https://api.github.com/repos/puppetlabs/hiera/forks","keys_url":"https://api.github.com/repos/puppetlabs/hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/hiera/teams","hooks_url":"https://api.github.com/repos/puppetlabs/hiera/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/hiera/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/hiera/events","assignees_url":"https://api.github.com/repos/puppetlabs/hiera/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/hiera/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/hiera/tags","blobs_url":"https://api.github.com/repos/puppetlabs/hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/hiera/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/hiera/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/hiera/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/hiera/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/hiera/subscription","commits_url":"https://api.github.com/repos/puppetlabs/hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/hiera/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/hiera/merges","archive_url":"https://api.github.com/repos/puppetlabs/hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/hiera/downloads","issues_url":"https://api.github.com/repos/puppetlabs/hiera/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/hiera/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/hiera/releases{/id}","created_at":"2011-06-04T00:48:22Z","updated_at":"2015-02-20T21:29:47Z","pushed_at":"2015-02-20T21:29:46Z","git_url":"git://github.com/puppetlabs/hiera.git","ssh_url":"git@github.com:puppetlabs/hiera.git","clone_url":"https://github.com/puppetlabs/hiera.git","svn_url":"https://github.com/puppetlabs/hiera","homepage":"http://projects.puppetlabs.com/projects/hiera/","size":2213,"stargazers_count":234,"watchers_count":234,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":5,"forks":156,"open_issues":5,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/256"},"html":{"href":"https://github.com/puppetlabs/hiera/pull/256"},"issue":{"href":"https://api.github.com/repos/puppetlabs/hiera/issues/256"},"comments":{"href":"https://api.github.com/repos/puppetlabs/hiera/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/hiera/statuses/ae1e656d1b434e40953c4f0a730fcbdccff58b51"}}}}