{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48","id":40685111,"html_url":"https://github.com/xapi-project/xcp-rrdd/pull/48","diff_url":"https://github.com/xapi-project/xcp-rrdd/pull/48.diff","patch_url":"https://github.com/xapi-project/xcp-rrdd/pull/48.patch","issue_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/48","number":48,"state":"closed","locked":false,"title":"Check actual datasource values rather than just list lengths","user":{"login":"euanh","id":789066,"avatar_url":"https://avatars.githubusercontent.com/u/789066?v=3","gravatar_id":"","url":"https://api.github.com/users/euanh","html_url":"https://github.com/euanh","followers_url":"https://api.github.com/users/euanh/followers","following_url":"https://api.github.com/users/euanh/following{/other_user}","gists_url":"https://api.github.com/users/euanh/gists{/gist_id}","starred_url":"https://api.github.com/users/euanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euanh/subscriptions","organizations_url":"https://api.github.com/users/euanh/orgs","repos_url":"https://api.github.com/users/euanh/repos","events_url":"https://api.github.com/users/euanh/events{/privacy}","received_events_url":"https://api.github.com/users/euanh/received_events","type":"User","site_admin":false},"body":"Theses changes make the tests much stronger and improve debug output when they fail.\r\nCA-177649.","created_at":"2015-07-23T15:31:35Z","updated_at":"2015-07-23T16:33:57Z","closed_at":"2015-07-23T16:33:57Z","merged_at":"2015-07-23T16:33:57Z","merge_commit_sha":"71cec71ee43937b86835f85b0b83027852752f0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/48/comments","statuses_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/7459e1208accbb559687d584101640e8746e328e","head":{"label":"euanh:add-unit-testing","ref":"add-unit-testing","sha":"7459e1208accbb559687d584101640e8746e328e","user":{"login":"euanh","id":789066,"avatar_url":"https://avatars.githubusercontent.com/u/789066?v=3","gravatar_id":"","url":"https://api.github.com/users/euanh","html_url":"https://github.com/euanh","followers_url":"https://api.github.com/users/euanh/followers","following_url":"https://api.github.com/users/euanh/following{/other_user}","gists_url":"https://api.github.com/users/euanh/gists{/gist_id}","starred_url":"https://api.github.com/users/euanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euanh/subscriptions","organizations_url":"https://api.github.com/users/euanh/orgs","repos_url":"https://api.github.com/users/euanh/repos","events_url":"https://api.github.com/users/euanh/events{/privacy}","received_events_url":"https://api.github.com/users/euanh/received_events","type":"User","site_admin":false},"repo":{"id":38880872,"name":"xcp-rrdd","full_name":"euanh/xcp-rrdd","owner":{"login":"euanh","id":789066,"avatar_url":"https://avatars.githubusercontent.com/u/789066?v=3","gravatar_id":"","url":"https://api.github.com/users/euanh","html_url":"https://github.com/euanh","followers_url":"https://api.github.com/users/euanh/followers","following_url":"https://api.github.com/users/euanh/following{/other_user}","gists_url":"https://api.github.com/users/euanh/gists{/gist_id}","starred_url":"https://api.github.com/users/euanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euanh/subscriptions","organizations_url":"https://api.github.com/users/euanh/orgs","repos_url":"https://api.github.com/users/euanh/repos","events_url":"https://api.github.com/users/euanh/events{/privacy}","received_events_url":"https://api.github.com/users/euanh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euanh/xcp-rrdd","description":"The XCP RRDD daemon","fork":true,"url":"https://api.github.com/repos/euanh/xcp-rrdd","forks_url":"https://api.github.com/repos/euanh/xcp-rrdd/forks","keys_url":"https://api.github.com/repos/euanh/xcp-rrdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euanh/xcp-rrdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euanh/xcp-rrdd/teams","hooks_url":"https://api.github.com/repos/euanh/xcp-rrdd/hooks","issue_events_url":"https://api.github.com/repos/euanh/xcp-rrdd/issues/events{/number}","events_url":"https://api.github.com/repos/euanh/xcp-rrdd/events","assignees_url":"https://api.github.com/repos/euanh/xcp-rrdd/assignees{/user}","branches_url":"https://api.github.com/repos/euanh/xcp-rrdd/branches{/branch}","tags_url":"https://api.github.com/repos/euanh/xcp-rrdd/tags","blobs_url":"https://api.github.com/repos/euanh/xcp-rrdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euanh/xcp-rrdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euanh/xcp-rrdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/euanh/xcp-rrdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euanh/xcp-rrdd/statuses/{sha}","languages_url":"https://api.github.com/repos/euanh/xcp-rrdd/languages","stargazers_url":"https://api.github.com/repos/euanh/xcp-rrdd/stargazers","contributors_url":"https://api.github.com/repos/euanh/xcp-rrdd/contributors","subscribers_url":"https://api.github.com/repos/euanh/xcp-rrdd/subscribers","subscription_url":"https://api.github.com/repos/euanh/xcp-rrdd/subscription","commits_url":"https://api.github.com/repos/euanh/xcp-rrdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/euanh/xcp-rrdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/euanh/xcp-rrdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/euanh/xcp-rrdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/euanh/xcp-rrdd/contents/{+path}","compare_url":"https://api.github.com/repos/euanh/xcp-rrdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euanh/xcp-rrdd/merges","archive_url":"https://api.github.com/repos/euanh/xcp-rrdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euanh/xcp-rrdd/downloads","issues_url":"https://api.github.com/repos/euanh/xcp-rrdd/issues{/number}","pulls_url":"https://api.github.com/repos/euanh/xcp-rrdd/pulls{/number}","milestones_url":"https://api.github.com/repos/euanh/xcp-rrdd/milestones{/number}","notifications_url":"https://api.github.com/repos/euanh/xcp-rrdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euanh/xcp-rrdd/labels{/name}","releases_url":"https://api.github.com/repos/euanh/xcp-rrdd/releases{/id}","created_at":"2015-07-10T13:06:15Z","updated_at":"2015-07-10T13:06:16Z","pushed_at":"2015-07-23T16:25:50Z","git_url":"git://github.com/euanh/xcp-rrdd.git","ssh_url":"git@github.com:euanh/xcp-rrdd.git","clone_url":"https://github.com/euanh/xcp-rrdd.git","svn_url":"https://github.com/euanh/xcp-rrdd","homepage":null,"size":28754,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"e3c7d8657323c8379d26e61c794fd49e2f4dc549","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":8459591,"name":"xcp-rrdd","full_name":"xapi-project/xcp-rrdd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xcp-rrdd","description":"The XCP RRDD daemon","fork":false,"url":"https://api.github.com/repos/xapi-project/xcp-rrdd","forks_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/forks","keys_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/events","assignees_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/merges","archive_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/releases{/id}","created_at":"2013-02-27T16:02:11Z","updated_at":"2015-04-02T21:52:44Z","pushed_at":"2015-07-23T16:33:57Z","git_url":"git://github.com/xapi-project/xcp-rrdd.git","ssh_url":"git@github.com:xapi-project/xcp-rrdd.git","clone_url":"https://github.com/xapi-project/xcp-rrdd.git","svn_url":"https://github.com/xapi-project/xcp-rrdd","homepage":null,"size":29183,"stargazers_count":2,"watchers_count":2,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48"},"html":{"href":"https://github.com/xapi-project/xcp-rrdd/pull/48"},"issue":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/48"},"comments":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/7459e1208accbb559687d584101640e8746e328e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"euanh","id":789066,"avatar_url":"https://avatars.githubusercontent.com/u/789066?v=3","gravatar_id":"","url":"https://api.github.com/users/euanh","html_url":"https://github.com/euanh","followers_url":"https://api.github.com/users/euanh/followers","following_url":"https://api.github.com/users/euanh/following{/other_user}","gists_url":"https://api.github.com/users/euanh/gists{/gist_id}","starred_url":"https://api.github.com/users/euanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euanh/subscriptions","organizations_url":"https://api.github.com/users/euanh/orgs","repos_url":"https://api.github.com/users/euanh/repos","events_url":"https://api.github.com/users/euanh/events{/privacy}","received_events_url":"https://api.github.com/users/euanh/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":88,"deletions":23,"changed_files":1}}