{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/29886692","id":29886692,"diff_hunk":"@@ -165,6 +178,33 @@ void DMainWindow::OnOpen()\n \t\tStartGame(filename);\n }\n \n+void DMainWindow::OnBrowse()\n+{\n+\tstd::string path = ShowFolderDialog().toStdString();\n+\tstd::vector<std::string>& iso_folder = SConfig::GetInstance().m_ISOFolder;\n+\tif (!path.empty())\n+\t{\n+\t\tauto itResult = std::find(\n+\t\t\t\tiso_folder.begin(),\n+\t\t\t\tiso_folder.end(), path);","path":"Source/Core/DolphinQt/MainWindow.cpp","position":55,"original_position":55,"commit_id":"39a869c80054e095717f53b3c3472017446548bc","original_commit_id":"39a869c80054e095717f53b3c3472017446548bc","user":{"login":"darkengine-io","id":447479,"avatar_url":"https://avatars.githubusercontent.com/u/447479?v=3","gravatar_id":"","url":"https://api.github.com/users/darkengine-io","html_url":"https://github.com/darkengine-io","followers_url":"https://api.github.com/users/darkengine-io/followers","following_url":"https://api.github.com/users/darkengine-io/following{/other_user}","gists_url":"https://api.github.com/users/darkengine-io/gists{/gist_id}","starred_url":"https://api.github.com/users/darkengine-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkengine-io/subscriptions","organizations_url":"https://api.github.com/users/darkengine-io/orgs","repos_url":"https://api.github.com/users/darkengine-io/repos","events_url":"https://api.github.com/users/darkengine-io/events{/privacy}","received_events_url":"https://api.github.com/users/darkengine-io/received_events","type":"User","site_admin":false},"body":"Should spaces be used over tabs here as well? If so, CGameListCtrl::BrowseForDirectory() should be altered as it uses the same indentation on its iterator (I lifted most of that method for this one).","created_at":"2015-05-07T19:22:57Z","updated_at":"2015-05-07T19:22:57Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2359#discussion_r29886692","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/29886692"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2359#discussion_r29886692"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359","id":34593577,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2359","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2359.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2359.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2359","number":2359,"state":"open","locked":false,"title":"DolphinQt updates","user":{"login":"darkengine-io","id":447479,"avatar_url":"https://avatars.githubusercontent.com/u/447479?v=3","gravatar_id":"","url":"https://api.github.com/users/darkengine-io","html_url":"https://github.com/darkengine-io","followers_url":"https://api.github.com/users/darkengine-io/followers","following_url":"https://api.github.com/users/darkengine-io/following{/other_user}","gists_url":"https://api.github.com/users/darkengine-io/gists{/gist_id}","starred_url":"https://api.github.com/users/darkengine-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkengine-io/subscriptions","organizations_url":"https://api.github.com/users/darkengine-io/orgs","repos_url":"https://api.github.com/users/darkengine-io/repos","events_url":"https://api.github.com/users/darkengine-io/events{/privacy}","received_events_url":"https://api.github.com/users/darkengine-io/received_events","type":"User","site_admin":false},"body":"Since wxWidgets is terrible and the QT frontend hasn't been touched in a while, I've been working on bringing DolphinQT up to speed with the wx frontend.\r\n\r\nIn the interest of proper code review, I've been told it's probably better to send smaller PRs more often vs massive PRs less often.","created_at":"2015-05-02T23:27:07Z","updated_at":"2015-05-07T19:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b36cbde9de4d148607b7af7f35110b58d7396c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2359/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/39a869c80054e095717f53b3c3472017446548bc","head":{"label":"darkengine-io:new-qt","ref":"new-qt","sha":"39a869c80054e095717f53b3c3472017446548bc","user":{"login":"darkengine-io","id":447479,"avatar_url":"https://avatars.githubusercontent.com/u/447479?v=3","gravatar_id":"","url":"https://api.github.com/users/darkengine-io","html_url":"https://github.com/darkengine-io","followers_url":"https://api.github.com/users/darkengine-io/followers","following_url":"https://api.github.com/users/darkengine-io/following{/other_user}","gists_url":"https://api.github.com/users/darkengine-io/gists{/gist_id}","starred_url":"https://api.github.com/users/darkengine-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkengine-io/subscriptions","organizations_url":"https://api.github.com/users/darkengine-io/orgs","repos_url":"https://api.github.com/users/darkengine-io/repos","events_url":"https://api.github.com/users/darkengine-io/events{/privacy}","received_events_url":"https://api.github.com/users/darkengine-io/received_events","type":"User","site_admin":false},"repo":{"id":34710511,"name":"dolphin","full_name":"darkengine-io/dolphin","owner":{"login":"darkengine-io","id":447479,"avatar_url":"https://avatars.githubusercontent.com/u/447479?v=3","gravatar_id":"","url":"https://api.github.com/users/darkengine-io","html_url":"https://github.com/darkengine-io","followers_url":"https://api.github.com/users/darkengine-io/followers","following_url":"https://api.github.com/users/darkengine-io/following{/other_user}","gists_url":"https://api.github.com/users/darkengine-io/gists{/gist_id}","starred_url":"https://api.github.com/users/darkengine-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkengine-io/subscriptions","organizations_url":"https://api.github.com/users/darkengine-io/orgs","repos_url":"https://api.github.com/users/darkengine-io/repos","events_url":"https://api.github.com/users/darkengine-io/events{/privacy}","received_events_url":"https://api.github.com/users/darkengine-io/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darkengine-io/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/darkengine-io/dolphin","forks_url":"https://api.github.com/repos/darkengine-io/dolphin/forks","keys_url":"https://api.github.com/repos/darkengine-io/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkengine-io/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkengine-io/dolphin/teams","hooks_url":"https://api.github.com/repos/darkengine-io/dolphin/hooks","issue_events_url":"https://api.github.com/repos/darkengine-io/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/darkengine-io/dolphin/events","assignees_url":"https://api.github.com/repos/darkengine-io/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/darkengine-io/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/darkengine-io/dolphin/tags","blobs_url":"https://api.github.com/repos/darkengine-io/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkengine-io/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkengine-io/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkengine-io/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkengine-io/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/darkengine-io/dolphin/languages","stargazers_url":"https://api.github.com/repos/darkengine-io/dolphin/stargazers","contributors_url":"https://api.github.com/repos/darkengine-io/dolphin/contributors","subscribers_url":"https://api.github.com/repos/darkengine-io/dolphin/subscribers","subscription_url":"https://api.github.com/repos/darkengine-io/dolphin/subscription","commits_url":"https://api.github.com/repos/darkengine-io/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkengine-io/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkengine-io/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkengine-io/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkengine-io/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/darkengine-io/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkengine-io/dolphin/merges","archive_url":"https://api.github.com/repos/darkengine-io/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkengine-io/dolphin/downloads","issues_url":"https://api.github.com/repos/darkengine-io/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/darkengine-io/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/darkengine-io/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/darkengine-io/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkengine-io/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/darkengine-io/dolphin/releases{/id}","created_at":"2015-04-28T05:30:44Z","updated_at":"2015-05-02T08:30:43Z","pushed_at":"2015-05-06T00:58:36Z","git_url":"git://github.com/darkengine-io/dolphin.git","ssh_url":"git@github.com:darkengine-io/dolphin.git","clone_url":"https://github.com/darkengine-io/dolphin.git","svn_url":"https://github.com/darkengine-io/dolphin","homepage":"https://dolphin-emu.org/","size":216529,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"6414cdabb2ae7762f2d98427b9ff024af07bb959","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-05-07T18:19:37Z","pushed_at":"2015-05-07T10:51:57Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":289898,"stargazers_count":1350,"watchers_count":1350,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":406,"mirror_url":null,"open_issues_count":62,"forks":406,"open_issues":62,"watchers":1350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2359"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2359"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2359/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2359/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/39a869c80054e095717f53b3c3472017446548bc"}}}}