{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/comments/22805453","id":22805453,"diff_hunk":"@@ -52,10 +50,13 @@ this.util = this.util || {};\n \t\t\tthrow new Error( 'Bad function name given. At least one word character or $ required.' );\n \t\t}\n \n-\t\teval( 'namedFn = function ' + fnName +\n-\t\t\t'(){ evilsSeed.apply( this, arguments ); }' );\n+\t\t// No, none of these functions is superfluous! Before this used to fail with a\n+\t\t// \"ReferenceError: evilsSeed is not defined\" when Shift+reloading in Firefox.\n+\t\t// Source: http://stackoverflow.com/a/22880379\n+\t\tnamedFn = ( new Function( 'return function( fn ) { return function ' + fnName +\n+\t\t\t'() { return fn( this, arguments ); }; };' )() )( Function.apply.bind( evilsSeed ) );","path":"lib/util/util.inherit.js","position":19,"original_position":19,"commit_id":"8a41e6673b2096f6282851ea6c7d80ab9d060376","original_commit_id":"8a41e6673b2096f6282851ea6c7d80ab9d060376","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"Yay for the `'fn'` bit. Need to test this but looks good. Nay for the dropped `bind`. I think this is crucial.","created_at":"2015-01-12T17:25:40Z","updated_at":"2015-01-12T17:25:40Z","html_url":"https://github.com/wmde/DataValuesJavascript/pull/43#discussion_r22805453","pull_request_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/comments/22805453"},"html":{"href":"https://github.com/wmde/DataValuesJavascript/pull/43#discussion_r22805453"},"pull_request":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43","id":18031893,"html_url":"https://github.com/wmde/DataValuesJavascript/pull/43","diff_url":"https://github.com/wmde/DataValuesJavascript/pull/43.diff","patch_url":"https://github.com/wmde/DataValuesJavascript/pull/43.patch","issue_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/43","number":43,"state":"open","locked":false,"title":"[WIP] Reimplement removed constructor naming","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"This `ReferenceError: evilsSeed is not defined` is driving me crazy. I can always reproduce it by simply shift+reloading a page in my local Wikibase Repo. This is a huge pain when debugging.\r\n\r\n__Update:__ #45 removes this feature. It should be readded when the PhantomJS bug mentioned below got fixed and the Travis tests pass.","created_at":"2014-07-07T08:29:47Z","updated_at":"2015-01-12T17:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25609c902d513f2132f7c3c794334808ee6b865","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43/commits","review_comments_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43/comments","review_comment_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/43/comments","statuses_url":"https://api.github.com/repos/wmde/DataValuesJavascript/statuses/8a41e6673b2096f6282851ea6c7d80ab9d060376","head":{"label":"wmde:evil","ref":"evil","sha":"8a41e6673b2096f6282851ea6c7d80ab9d060376","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15207281,"name":"DataValuesJavascript","full_name":"wmde/DataValuesJavascript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/DataValuesJavascript","description":"JavaScript implementations of various DataValues and associated parsers and formatters","fork":false,"url":"https://api.github.com/repos/wmde/DataValuesJavascript","forks_url":"https://api.github.com/repos/wmde/DataValuesJavascript/forks","keys_url":"https://api.github.com/repos/wmde/DataValuesJavascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/DataValuesJavascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/DataValuesJavascript/teams","hooks_url":"https://api.github.com/repos/wmde/DataValuesJavascript/hooks","issue_events_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/DataValuesJavascript/events","assignees_url":"https://api.github.com/repos/wmde/DataValuesJavascript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/DataValuesJavascript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/DataValuesJavascript/tags","blobs_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/DataValuesJavascript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/DataValuesJavascript/languages","stargazers_url":"https://api.github.com/repos/wmde/DataValuesJavascript/stargazers","contributors_url":"https://api.github.com/repos/wmde/DataValuesJavascript/contributors","subscribers_url":"https://api.github.com/repos/wmde/DataValuesJavascript/subscribers","subscription_url":"https://api.github.com/repos/wmde/DataValuesJavascript/subscription","commits_url":"https://api.github.com/repos/wmde/DataValuesJavascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/DataValuesJavascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/DataValuesJavascript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/DataValuesJavascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/DataValuesJavascript/merges","archive_url":"https://api.github.com/repos/wmde/DataValuesJavascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/DataValuesJavascript/downloads","issues_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/DataValuesJavascript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/DataValuesJavascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/DataValuesJavascript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/DataValuesJavascript/releases{/id}","created_at":"2013-12-15T17:06:03Z","updated_at":"2015-01-08T08:18:22Z","pushed_at":"2015-01-08T08:18:24Z","git_url":"git://github.com/wmde/DataValuesJavascript.git","ssh_url":"git@github.com:wmde/DataValuesJavascript.git","clone_url":"https://github.com/wmde/DataValuesJavascript.git","svn_url":"https://github.com/wmde/DataValuesJavascript","homepage":"","size":1996,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"60f187577b8ebaac0b24a8535c49b0eadf2ce731","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15207281,"name":"DataValuesJavascript","full_name":"wmde/DataValuesJavascript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/DataValuesJavascript","description":"JavaScript implementations of various DataValues and associated parsers and formatters","fork":false,"url":"https://api.github.com/repos/wmde/DataValuesJavascript","forks_url":"https://api.github.com/repos/wmde/DataValuesJavascript/forks","keys_url":"https://api.github.com/repos/wmde/DataValuesJavascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/DataValuesJavascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/DataValuesJavascript/teams","hooks_url":"https://api.github.com/repos/wmde/DataValuesJavascript/hooks","issue_events_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/DataValuesJavascript/events","assignees_url":"https://api.github.com/repos/wmde/DataValuesJavascript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/DataValuesJavascript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/DataValuesJavascript/tags","blobs_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/DataValuesJavascript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/DataValuesJavascript/languages","stargazers_url":"https://api.github.com/repos/wmde/DataValuesJavascript/stargazers","contributors_url":"https://api.github.com/repos/wmde/DataValuesJavascript/contributors","subscribers_url":"https://api.github.com/repos/wmde/DataValuesJavascript/subscribers","subscription_url":"https://api.github.com/repos/wmde/DataValuesJavascript/subscription","commits_url":"https://api.github.com/repos/wmde/DataValuesJavascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/DataValuesJavascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/DataValuesJavascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/DataValuesJavascript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/DataValuesJavascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/DataValuesJavascript/merges","archive_url":"https://api.github.com/repos/wmde/DataValuesJavascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/DataValuesJavascript/downloads","issues_url":"https://api.github.com/repos/wmde/DataValuesJavascript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/DataValuesJavascript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/DataValuesJavascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/DataValuesJavascript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/DataValuesJavascript/releases{/id}","created_at":"2013-12-15T17:06:03Z","updated_at":"2015-01-08T08:18:22Z","pushed_at":"2015-01-08T08:18:24Z","git_url":"git://github.com/wmde/DataValuesJavascript.git","ssh_url":"git@github.com:wmde/DataValuesJavascript.git","clone_url":"https://github.com/wmde/DataValuesJavascript.git","svn_url":"https://github.com/wmde/DataValuesJavascript","homepage":"","size":1996,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43"},"html":{"href":"https://github.com/wmde/DataValuesJavascript/pull/43"},"issue":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/43"},"comments":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/DataValuesJavascript/statuses/8a41e6673b2096f6282851ea6c7d80ab9d060376"}}}}