{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5","id":36388112,"html_url":"https://github.com/NuckChorris/sidekiq-debounce/pull/5","diff_url":"https://github.com/NuckChorris/sidekiq-debounce/pull/5.diff","patch_url":"https://github.com/NuckChorris/sidekiq-debounce/pull/5.patch","issue_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/5","number":5,"state":"closed","locked":false,"title":"Store & retrieve job as hash instead of jid (WIP, DO NOT MERGE)","user":{"login":"Darep","id":218910,"avatar_url":"https://avatars.githubusercontent.com/u/218910?v=3","gravatar_id":"","url":"https://api.github.com/users/Darep","html_url":"https://github.com/Darep","followers_url":"https://api.github.com/users/Darep/followers","following_url":"https://api.github.com/users/Darep/following{/other_user}","gists_url":"https://api.github.com/users/Darep/gists{/gist_id}","starred_url":"https://api.github.com/users/Darep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darep/subscriptions","organizations_url":"https://api.github.com/users/Darep/orgs","repos_url":"https://api.github.com/users/Darep/repos","events_url":"https://api.github.com/users/Darep/events{/privacy}","received_events_url":"https://api.github.com/users/Darep/received_events","type":"User","site_admin":false},"body":"*Work in progress, needs more testing, need to get rid of `eval`.*\r\n\r\nIt looks to me like the output of `yield` in Sidekiq client middleware's API was changed at some point: it doesn't return a job ID in my app, but instead a hash which contains the job id. Thus, the `store_expiry` method saved a string representation of the hash, and the plugin never found the previously scheduled job and never debounced anything.\r\n\r\nI changed the code to adjust to the `yield` change and now it works beautifully! All the current tests were passing even before this change, so I think we should try to come up with a test that first fails and then add this to fix that test.\r\n\r\nPS. The `yield` change is not mentioned anywhere in the changelogs, so I'm a bit sceptical that the reason might be e.g. my application config or something else.","created_at":"2015-05-28T09:37:53Z","updated_at":"2015-08-08T06:31:13Z","closed_at":"2015-08-08T06:31:13Z","merged_at":null,"merge_commit_sha":"55e3f3161a23370bc10564fa0f5f23d20a4031f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5/commits","review_comments_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5/comments","review_comment_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/5/comments","statuses_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/statuses/5d17d9e52089cbb5132315cea4545b011e7456f7","head":{"label":"Darep:fix/jid-store-retrieve","ref":"fix/jid-store-retrieve","sha":"5d17d9e52089cbb5132315cea4545b011e7456f7","user":{"login":"Darep","id":218910,"avatar_url":"https://avatars.githubusercontent.com/u/218910?v=3","gravatar_id":"","url":"https://api.github.com/users/Darep","html_url":"https://github.com/Darep","followers_url":"https://api.github.com/users/Darep/followers","following_url":"https://api.github.com/users/Darep/following{/other_user}","gists_url":"https://api.github.com/users/Darep/gists{/gist_id}","starred_url":"https://api.github.com/users/Darep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darep/subscriptions","organizations_url":"https://api.github.com/users/Darep/orgs","repos_url":"https://api.github.com/users/Darep/repos","events_url":"https://api.github.com/users/Darep/events{/privacy}","received_events_url":"https://api.github.com/users/Darep/received_events","type":"User","site_admin":false},"repo":{"id":36281871,"name":"sidekiq-debounce","full_name":"Darep/sidekiq-debounce","owner":{"login":"Darep","id":218910,"avatar_url":"https://avatars.githubusercontent.com/u/218910?v=3","gravatar_id":"","url":"https://api.github.com/users/Darep","html_url":"https://github.com/Darep","followers_url":"https://api.github.com/users/Darep/followers","following_url":"https://api.github.com/users/Darep/following{/other_user}","gists_url":"https://api.github.com/users/Darep/gists{/gist_id}","starred_url":"https://api.github.com/users/Darep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darep/subscriptions","organizations_url":"https://api.github.com/users/Darep/orgs","repos_url":"https://api.github.com/users/Darep/repos","events_url":"https://api.github.com/users/Darep/events{/privacy}","received_events_url":"https://api.github.com/users/Darep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Darep/sidekiq-debounce","description":"Debouncing for Sidekiq tasks","fork":true,"url":"https://api.github.com/repos/Darep/sidekiq-debounce","forks_url":"https://api.github.com/repos/Darep/sidekiq-debounce/forks","keys_url":"https://api.github.com/repos/Darep/sidekiq-debounce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Darep/sidekiq-debounce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Darep/sidekiq-debounce/teams","hooks_url":"https://api.github.com/repos/Darep/sidekiq-debounce/hooks","issue_events_url":"https://api.github.com/repos/Darep/sidekiq-debounce/issues/events{/number}","events_url":"https://api.github.com/repos/Darep/sidekiq-debounce/events","assignees_url":"https://api.github.com/repos/Darep/sidekiq-debounce/assignees{/user}","branches_url":"https://api.github.com/repos/Darep/sidekiq-debounce/branches{/branch}","tags_url":"https://api.github.com/repos/Darep/sidekiq-debounce/tags","blobs_url":"https://api.github.com/repos/Darep/sidekiq-debounce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Darep/sidekiq-debounce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Darep/sidekiq-debounce/git/refs{/sha}","trees_url":"https://api.github.com/repos/Darep/sidekiq-debounce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Darep/sidekiq-debounce/statuses/{sha}","languages_url":"https://api.github.com/repos/Darep/sidekiq-debounce/languages","stargazers_url":"https://api.github.com/repos/Darep/sidekiq-debounce/stargazers","contributors_url":"https://api.github.com/repos/Darep/sidekiq-debounce/contributors","subscribers_url":"https://api.github.com/repos/Darep/sidekiq-debounce/subscribers","subscription_url":"https://api.github.com/repos/Darep/sidekiq-debounce/subscription","commits_url":"https://api.github.com/repos/Darep/sidekiq-debounce/commits{/sha}","git_commits_url":"https://api.github.com/repos/Darep/sidekiq-debounce/git/commits{/sha}","comments_url":"https://api.github.com/repos/Darep/sidekiq-debounce/comments{/number}","issue_comment_url":"https://api.github.com/repos/Darep/sidekiq-debounce/issues/comments{/number}","contents_url":"https://api.github.com/repos/Darep/sidekiq-debounce/contents/{+path}","compare_url":"https://api.github.com/repos/Darep/sidekiq-debounce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Darep/sidekiq-debounce/merges","archive_url":"https://api.github.com/repos/Darep/sidekiq-debounce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Darep/sidekiq-debounce/downloads","issues_url":"https://api.github.com/repos/Darep/sidekiq-debounce/issues{/number}","pulls_url":"https://api.github.com/repos/Darep/sidekiq-debounce/pulls{/number}","milestones_url":"https://api.github.com/repos/Darep/sidekiq-debounce/milestones{/number}","notifications_url":"https://api.github.com/repos/Darep/sidekiq-debounce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Darep/sidekiq-debounce/labels{/name}","releases_url":"https://api.github.com/repos/Darep/sidekiq-debounce/releases{/id}","created_at":"2015-05-26T08:17:33Z","updated_at":"2015-05-26T08:17:33Z","pushed_at":"2015-08-08T06:29:54Z","git_url":"git://github.com/Darep/sidekiq-debounce.git","ssh_url":"git@github.com:Darep/sidekiq-debounce.git","clone_url":"https://github.com/Darep/sidekiq-debounce.git","svn_url":"https://github.com/Darep/sidekiq-debounce","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NuckChorris:master","ref":"master","sha":"56fa2a7f5502c6c485ab9e6ae6b4bd58f0774ef0","user":{"login":"NuckChorris","id":430411,"avatar_url":"https://avatars.githubusercontent.com/u/430411?v=3","gravatar_id":"","url":"https://api.github.com/users/NuckChorris","html_url":"https://github.com/NuckChorris","followers_url":"https://api.github.com/users/NuckChorris/followers","following_url":"https://api.github.com/users/NuckChorris/following{/other_user}","gists_url":"https://api.github.com/users/NuckChorris/gists{/gist_id}","starred_url":"https://api.github.com/users/NuckChorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuckChorris/subscriptions","organizations_url":"https://api.github.com/users/NuckChorris/orgs","repos_url":"https://api.github.com/users/NuckChorris/repos","events_url":"https://api.github.com/users/NuckChorris/events{/privacy}","received_events_url":"https://api.github.com/users/NuckChorris/received_events","type":"User","site_admin":false},"repo":{"id":34240309,"name":"sidekiq-debounce","full_name":"NuckChorris/sidekiq-debounce","owner":{"login":"NuckChorris","id":430411,"avatar_url":"https://avatars.githubusercontent.com/u/430411?v=3","gravatar_id":"","url":"https://api.github.com/users/NuckChorris","html_url":"https://github.com/NuckChorris","followers_url":"https://api.github.com/users/NuckChorris/followers","following_url":"https://api.github.com/users/NuckChorris/following{/other_user}","gists_url":"https://api.github.com/users/NuckChorris/gists{/gist_id}","starred_url":"https://api.github.com/users/NuckChorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuckChorris/subscriptions","organizations_url":"https://api.github.com/users/NuckChorris/orgs","repos_url":"https://api.github.com/users/NuckChorris/repos","events_url":"https://api.github.com/users/NuckChorris/events{/privacy}","received_events_url":"https://api.github.com/users/NuckChorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NuckChorris/sidekiq-debounce","description":"Debouncing for Sidekiq tasks","fork":false,"url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce","forks_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/forks","keys_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/teams","hooks_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/hooks","issue_events_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/events{/number}","events_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/events","assignees_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/assignees{/user}","branches_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/branches{/branch}","tags_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/tags","blobs_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/statuses/{sha}","languages_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/languages","stargazers_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/stargazers","contributors_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/contributors","subscribers_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/subscribers","subscription_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/subscription","commits_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/contents/{+path}","compare_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/merges","archive_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/downloads","issues_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues{/number}","pulls_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls{/number}","milestones_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/milestones{/number}","notifications_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/labels{/name}","releases_url":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/releases{/id}","created_at":"2015-04-20T05:39:40Z","updated_at":"2015-07-15T14:39:44Z","pushed_at":"2015-08-08T05:55:17Z","git_url":"git://github.com/NuckChorris/sidekiq-debounce.git","ssh_url":"git@github.com:NuckChorris/sidekiq-debounce.git","clone_url":"https://github.com/NuckChorris/sidekiq-debounce.git","svn_url":"https://github.com/NuckChorris/sidekiq-debounce","homepage":null,"size":192,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5"},"html":{"href":"https://github.com/NuckChorris/sidekiq-debounce/pull/5"},"issue":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/5"},"comments":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/NuckChorris/sidekiq-debounce/statuses/5d17d9e52089cbb5132315cea4545b011e7456f7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":2,"commits":1,"additions":14,"deletions":9,"changed_files":1}}