{"action":"created","comment":{"url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/comments/29887696","id":29887696,"diff_hunk":"@@ -6,9 +6,9 @@ module DelayTouching\n     extend ActiveSupport::Concern\n \n     # Override ActiveRecord::Base#touch.\n-    def touch(name = nil)\n+    def touch(*names)\n       if self.class.delay_touching? && !try(:no_touching?)\n-        DelayTouching.add_record(self, name)\n+        DelayTouching.add_record(self, names)","path":"lib/activerecord/delay_touching.rb","position":8,"original_position":8,"commit_id":"1d1b8fa121b43dd3da8cdc405febe6e6fc4ef3c7","original_commit_id":"1d1b8fa121b43dd3da8cdc405febe6e6fc4ef3c7","user":{"login":"mtuckergd","id":4377828,"avatar_url":"https://avatars.githubusercontent.com/u/4377828?v=3","gravatar_id":"","url":"https://api.github.com/users/mtuckergd","html_url":"https://github.com/mtuckergd","followers_url":"https://api.github.com/users/mtuckergd/followers","following_url":"https://api.github.com/users/mtuckergd/following{/other_user}","gists_url":"https://api.github.com/users/mtuckergd/gists{/gist_id}","starred_url":"https://api.github.com/users/mtuckergd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtuckergd/subscriptions","organizations_url":"https://api.github.com/users/mtuckergd/orgs","repos_url":"https://api.github.com/users/mtuckergd/repos","events_url":"https://api.github.com/users/mtuckergd/events{/privacy}","received_events_url":"https://api.github.com/users/mtuckergd/received_events","type":"User","site_admin":false},"body":"Yep. I was missing a splat in the touch method that alleviates the need to flatten the array. I can greatly simplify the logic based on this. \r\n\r\nthere are also a couple of minor tweaks that I plan to do. I'm going to close this PR and resubmit through a separate branch so that I can squash the changes.","created_at":"2015-05-07T19:34:15Z","updated_at":"2015-05-07T19:34:15Z","html_url":"https://github.com/godaddy/activerecord-delay_touching/pull/4#discussion_r29887696","pull_request_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/comments/29887696"},"html":{"href":"https://github.com/godaddy/activerecord-delay_touching/pull/4#discussion_r29887696"},"pull_request":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4","id":34888149,"html_url":"https://github.com/godaddy/activerecord-delay_touching/pull/4","diff_url":"https://github.com/godaddy/activerecord-delay_touching/pull/4.diff","patch_url":"https://github.com/godaddy/activerecord-delay_touching/pull/4.patch","issue_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/4","number":4,"state":"open","locked":false,"title":"update touch to support splat signature introduced in ActiveRecord 4.2","user":{"login":"mtuckergd","id":4377828,"avatar_url":"https://avatars.githubusercontent.com/u/4377828?v=3","gravatar_id":"","url":"https://api.github.com/users/mtuckergd","html_url":"https://github.com/mtuckergd","followers_url":"https://api.github.com/users/mtuckergd/followers","following_url":"https://api.github.com/users/mtuckergd/following{/other_user}","gists_url":"https://api.github.com/users/mtuckergd/gists{/gist_id}","starred_url":"https://api.github.com/users/mtuckergd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtuckergd/subscriptions","organizations_url":"https://api.github.com/users/mtuckergd/orgs","repos_url":"https://api.github.com/users/mtuckergd/repos","events_url":"https://api.github.com/users/mtuckergd/events{/privacy}","received_events_url":"https://api.github.com/users/mtuckergd/received_events","type":"User","site_admin":false},"body":"ActiveRecord modified the touch method signature in 4.2 to take a splat of column names, rather than the traditional single field name. \r\nI tried to solve for this in a way that supports both formats, but things got ugly quickly. SO, I've elected to branch the 0.0.1 version to the pre-activerecord-4.2 branch and move forward on master with ~> 4.2 support of ActiveRecord.\r\n\r\nresolves issue #3 ","created_at":"2015-05-07T07:02:48Z","updated_at":"2015-05-07T19:34:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b51ab6e760cb66f28c30ca002ac2880372b4dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4/commits","review_comments_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4/comments","review_comment_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/4/comments","statuses_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/statuses/1d1b8fa121b43dd3da8cdc405febe6e6fc4ef3c7","head":{"label":"godaddy:ar_42_fix","ref":"ar_42_fix","sha":"1d1b8fa121b43dd3da8cdc405febe6e6fc4ef3c7","user":{"login":"godaddy","id":1406546,"avatar_url":"https://avatars.githubusercontent.com/u/1406546?v=3","gravatar_id":"","url":"https://api.github.com/users/godaddy","html_url":"https://github.com/godaddy","followers_url":"https://api.github.com/users/godaddy/followers","following_url":"https://api.github.com/users/godaddy/following{/other_user}","gists_url":"https://api.github.com/users/godaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/godaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godaddy/subscriptions","organizations_url":"https://api.github.com/users/godaddy/orgs","repos_url":"https://api.github.com/users/godaddy/repos","events_url":"https://api.github.com/users/godaddy/events{/privacy}","received_events_url":"https://api.github.com/users/godaddy/received_events","type":"Organization","site_admin":false},"repo":{"id":22970999,"name":"activerecord-delay_touching","full_name":"godaddy/activerecord-delay_touching","owner":{"login":"godaddy","id":1406546,"avatar_url":"https://avatars.githubusercontent.com/u/1406546?v=3","gravatar_id":"","url":"https://api.github.com/users/godaddy","html_url":"https://github.com/godaddy","followers_url":"https://api.github.com/users/godaddy/followers","following_url":"https://api.github.com/users/godaddy/following{/other_user}","gists_url":"https://api.github.com/users/godaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/godaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godaddy/subscriptions","organizations_url":"https://api.github.com/users/godaddy/orgs","repos_url":"https://api.github.com/users/godaddy/repos","events_url":"https://api.github.com/users/godaddy/events{/privacy}","received_events_url":"https://api.github.com/users/godaddy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godaddy/activerecord-delay_touching","description":"","fork":false,"url":"https://api.github.com/repos/godaddy/activerecord-delay_touching","forks_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/forks","keys_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/teams","hooks_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/hooks","issue_events_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/events{/number}","events_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/events","assignees_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/assignees{/user}","branches_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/branches{/branch}","tags_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/tags","blobs_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/refs{/sha}","trees_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/statuses/{sha}","languages_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/languages","stargazers_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/stargazers","contributors_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/contributors","subscribers_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/subscribers","subscription_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/subscription","commits_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/commits{/sha}","git_commits_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/commits{/sha}","comments_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/comments{/number}","issue_comment_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/comments{/number}","contents_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/contents/{+path}","compare_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/merges","archive_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/downloads","issues_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues{/number}","pulls_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls{/number}","milestones_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/milestones{/number}","notifications_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/labels{/name}","releases_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/releases{/id}","created_at":"2014-08-14T22:45:00Z","updated_at":"2015-05-07T03:11:17Z","pushed_at":"2015-05-07T07:02:48Z","git_url":"git://github.com/godaddy/activerecord-delay_touching.git","ssh_url":"git@github.com:godaddy/activerecord-delay_touching.git","clone_url":"https://github.com/godaddy/activerecord-delay_touching.git","svn_url":"https://github.com/godaddy/activerecord-delay_touching","homepage":null,"size":195,"stargazers_count":72,"watchers_count":72,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":72,"default_branch":"master"}},"base":{"label":"godaddy:master","ref":"master","sha":"b2885fb4354005ee2091aa945a02c8785984dca6","user":{"login":"godaddy","id":1406546,"avatar_url":"https://avatars.githubusercontent.com/u/1406546?v=3","gravatar_id":"","url":"https://api.github.com/users/godaddy","html_url":"https://github.com/godaddy","followers_url":"https://api.github.com/users/godaddy/followers","following_url":"https://api.github.com/users/godaddy/following{/other_user}","gists_url":"https://api.github.com/users/godaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/godaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godaddy/subscriptions","organizations_url":"https://api.github.com/users/godaddy/orgs","repos_url":"https://api.github.com/users/godaddy/repos","events_url":"https://api.github.com/users/godaddy/events{/privacy}","received_events_url":"https://api.github.com/users/godaddy/received_events","type":"Organization","site_admin":false},"repo":{"id":22970999,"name":"activerecord-delay_touching","full_name":"godaddy/activerecord-delay_touching","owner":{"login":"godaddy","id":1406546,"avatar_url":"https://avatars.githubusercontent.com/u/1406546?v=3","gravatar_id":"","url":"https://api.github.com/users/godaddy","html_url":"https://github.com/godaddy","followers_url":"https://api.github.com/users/godaddy/followers","following_url":"https://api.github.com/users/godaddy/following{/other_user}","gists_url":"https://api.github.com/users/godaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/godaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godaddy/subscriptions","organizations_url":"https://api.github.com/users/godaddy/orgs","repos_url":"https://api.github.com/users/godaddy/repos","events_url":"https://api.github.com/users/godaddy/events{/privacy}","received_events_url":"https://api.github.com/users/godaddy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godaddy/activerecord-delay_touching","description":"","fork":false,"url":"https://api.github.com/repos/godaddy/activerecord-delay_touching","forks_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/forks","keys_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/teams","hooks_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/hooks","issue_events_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/events{/number}","events_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/events","assignees_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/assignees{/user}","branches_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/branches{/branch}","tags_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/tags","blobs_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/refs{/sha}","trees_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/statuses/{sha}","languages_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/languages","stargazers_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/stargazers","contributors_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/contributors","subscribers_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/subscribers","subscription_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/subscription","commits_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/commits{/sha}","git_commits_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/git/commits{/sha}","comments_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/comments{/number}","issue_comment_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/comments{/number}","contents_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/contents/{+path}","compare_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/merges","archive_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/downloads","issues_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues{/number}","pulls_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls{/number}","milestones_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/milestones{/number}","notifications_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/labels{/name}","releases_url":"https://api.github.com/repos/godaddy/activerecord-delay_touching/releases{/id}","created_at":"2014-08-14T22:45:00Z","updated_at":"2015-05-07T03:11:17Z","pushed_at":"2015-05-07T07:02:48Z","git_url":"git://github.com/godaddy/activerecord-delay_touching.git","ssh_url":"git@github.com:godaddy/activerecord-delay_touching.git","clone_url":"https://github.com/godaddy/activerecord-delay_touching.git","svn_url":"https://github.com/godaddy/activerecord-delay_touching","homepage":null,"size":195,"stargazers_count":72,"watchers_count":72,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4"},"html":{"href":"https://github.com/godaddy/activerecord-delay_touching/pull/4"},"issue":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/4"},"comments":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/godaddy/activerecord-delay_touching/statuses/1d1b8fa121b43dd3da8cdc405febe6e6fc4ef3c7"}}}}