{"action":"created","issue":{"url":"https://api.github.com/repos/Gottox/child_pty/issues/7","labels_url":"https://api.github.com/repos/Gottox/child_pty/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/Gottox/child_pty/issues/7/comments","events_url":"https://api.github.com/repos/Gottox/child_pty/issues/7/events","html_url":"https://github.com/Gottox/child_pty/issues/7","id":105077635,"number":7,"title":"doesn't work on iojs 3.3.0","user":{"login":"vlahupetar","id":1672011,"avatar_url":"https://avatars.githubusercontent.com/u/1672011?v=3","gravatar_id":"","url":"https://api.github.com/users/vlahupetar","html_url":"https://github.com/vlahupetar","followers_url":"https://api.github.com/users/vlahupetar/followers","following_url":"https://api.github.com/users/vlahupetar/following{/other_user}","gists_url":"https://api.github.com/users/vlahupetar/gists{/gist_id}","starred_url":"https://api.github.com/users/vlahupetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlahupetar/subscriptions","organizations_url":"https://api.github.com/users/vlahupetar/orgs","repos_url":"https://api.github.com/users/vlahupetar/repos","events_url":"https://api.github.com/users/vlahupetar/events{/privacy}","received_events_url":"https://api.github.com/users/vlahupetar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Gottox/child_pty/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-06T07:49:18Z","updated_at":"2015-09-08T16:53:52Z","closed_at":null,"body":"I've seen similar bugs with other modules (node-inspector just recently fixed a similar bug)\r\n```\r\n% npm install child_pty                                                                                                                  15-09-06 - 2:45:00\r\n\r\n> child_pty@1.0.0 install /Users/petarvlahu/black-screen/node_modules/child_pty\r\n> node-gyp rebuild\r\n\r\n  CXX(target) Release/obj.target/exechelper/src/exechelper.o\r\n  LINK(target) Release/exechelper\r\n  CXX(target) Release/obj.target/pty/src/pty.o\r\nIn file included from ../src/pty.cpp:1:\r\n../node_modules/nan/nan.h:324:27: error: redefinition of 'NanEnsureHandleOrPersistent'\r\n  NAN_INLINE v8::Local<T> NanEnsureHandleOrPersistent(const v8::Local<T> &val) {\r\n                          ^\r\n../node_modules/nan/nan.h:319:17: note: previous definition is here\r\n  v8::Handle<T> NanEnsureHandleOrPersistent(const v8::Handle<T> &val) {\r\n                ^\r\n../node_modules/nan/nan.h:344:27: error: redefinition of 'NanEnsureLocal'\r\n  NAN_INLINE v8::Local<T> NanEnsureLocal(const v8::Handle<T> &val) {\r\n                          ^\r\n../node_modules/nan/nan.h:334:27: note: previous definition is here\r\n  NAN_INLINE v8::Local<T> NanEnsureLocal(const v8::Local<T> &val) {\r\n                          ^\r\n../node_modules/nan/nan.h:757:13: error: no member named 'smalloc' in namespace 'node'\r\n    , node::smalloc::FreeCallback callback\r\n      ~~~~~~^\r\n../node_modules/nan/nan.h:768:12: error: no matching function for call to 'New'\r\n    return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);\r\n           ^~~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'uint32_t'\r\n      (aka 'unsigned int') to 'enum encoding' for 3rd argument\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument ('const char *') would lose const\r\n      qualifier\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 3 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);\r\n                                       ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 3 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\nIn file included from ../src/pty.cpp:1:\r\n../node_modules/nan/nan.h:772:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'\r\n    return node::Buffer::New(v8::Isolate::GetCurrent(), size);\r\n           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from\r\n      'v8::MaybeLocal<v8::Object>' to 'const v8::Local<v8::Object> &' for 1st argument\r\nclass Local {\r\n      ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from\r\n      'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object> &&' for 1st argument\r\nclass Local {\r\n      ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'\r\n  V8_INLINE Local(Local<S> that)\r\n            ^\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:327:13: note: candidate template ignored: could not match 'S *' against 'v8::MaybeLocal<v8::Object>'\r\n  V8_INLINE Local(S* that)\r\n            ^\r\nIn file included from ../src/pty.cpp:1:\r\n../node_modules/nan/nan.h:779:26: error: no member named 'Use' in namespace 'node::Buffer'\r\n    return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);\r\n           ~~~~~~~~~~~~~~^\r\nIn file included from ../src/pty.cpp:1:\r\nIn file included from ../node_modules/nan/nan.h:24:\r\nIn file included from /Users/petarvlahu/.node-gyp/3.3.0/include/node/node.h:42:\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'\r\n    TYPE_CHECK(T, S);\r\n    ^~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'\r\n    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \\\r\n                                    ^ ~~~~~~~~~~~~~~~~~~\r\n../node_modules/nan/nan.h:501:12: note: in instantiation of function template specialization 'v8::Local<v8::Primitive>::Local<v8::Value>' requested here\r\n    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));\r\n           ^\r\n../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'\r\n# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))\r\n                             ^\r\nIn file included from ../src/pty.cpp:1:\r\nIn file included from ../node_modules/nan/nan.h:24:\r\nIn file included from /Users/petarvlahu/.node-gyp/3.3.0/include/node/node.h:42:\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:221:5: error: assigning to 'v8::Boolean *volatile' from incompatible type 'v8::Value *'\r\n    TYPE_CHECK(T, S);\r\n    ^~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'\r\n    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \\\r\n                                    ^ ~~~~~~~~~~~~~~~~~~\r\n../node_modules/nan/nan.h:511:12: note: in instantiation of function template specialization 'v8::Local<v8::Boolean>::Local<v8::Value>' requested here\r\n    return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));\r\n           ^\r\n../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'\r\n# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))\r\n                             ^\r\nIn file included from ../src/pty.cpp:1:\r\nIn file included from ../node_modules/nan/nan.h:24:\r\nIn file included from /Users/petarvlahu/.node-gyp/3.3.0/include/node/node.h:42:\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:221:5: error: assigning to 'v8::Function *volatile' from incompatible type 'v8::Value *'\r\n    TYPE_CHECK(T, S);\r\n    ^~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'\r\n    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \\\r\n                                    ^ ~~~~~~~~~~~~~~~~~~\r\n../node_modules/nan/nan.h:1645:12: note: in instantiation of function template specialization 'v8::Local<v8::Function>::Local<v8::Value>' requested here\r\n    return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)\r\n           ^\r\n../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'\r\n# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))\r\n                             ^\r\nIn file included from ../src/pty.cpp:1:\r\nIn file included from ../node_modules/nan/nan.h:24:\r\nIn file included from /Users/petarvlahu/.node-gyp/3.3.0/include/node/node.h:42:\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type 'v8::Value *'\r\n    TYPE_CHECK(T, S);\r\n    ^~~~~~~~~~~~~~~~\r\n/Users/petarvlahu/.node-gyp/3.3.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'\r\n    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \\\r\n                                    ^ ~~~~~~~~~~~~~~~~~~\r\n../node_modules/nan/nan.h:1776:12: note: in instantiation of function template specialization 'v8::Local<v8::Object>::Local<v8::Value>' requested here\r\n    return NanEscapeScope(\r\n           ^\r\n../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'\r\n# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))\r\n                             ^\r\n10 errors generated.\r\nmake: *** [Release/obj.target/pty/src/pty.o] Error 1\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)\r\ngyp ERR! stack     at emitTwo (events.js:87:13)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:172:7)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)\r\ngyp ERR! System Darwin 14.5.0\r\ngyp ERR! command \"/usr/local/bin/iojs\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /Users/petarvlahu/black-screen/node_modules/child_pty\r\ngyp ERR! node -v v3.3.0\r\ngyp ERR! node-gyp -v v2.0.2\r\ngyp ERR! not ok \r\nnpm ERR! Darwin 14.5.0\r\nnpm ERR! argv \"/usr/local/bin/iojs\" \"/usr/local/bin/npm\" \"install\" \"child_pty\"\r\nnpm ERR! node v3.3.0\r\nnpm ERR! npm  v2.13.3\r\nnpm ERR! code ELIFECYCLE\r\n\r\nnpm ERR! child_pty@1.0.0 install: `node-gyp rebuild`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the child_pty@1.0.0 install script 'node-gyp rebuild'.\r\nnpm ERR! This is most likely a problem with the child_pty package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR!     node-gyp rebuild\r\nnpm ERR! You can get their info via:\r\nnpm ERR!     npm owner ls child_pty\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR!     /Users/petarvlahu/black-screen/npm-debug.log\r\n```"},"comment":{"url":"https://api.github.com/repos/Gottox/child_pty/issues/comments/138632129","html_url":"https://github.com/Gottox/child_pty/issues/7#issuecomment-138632129","issue_url":"https://api.github.com/repos/Gottox/child_pty/issues/7","id":138632129,"user":{"login":"Gottox","id":1056976,"avatar_url":"https://avatars.githubusercontent.com/u/1056976?v=3","gravatar_id":"","url":"https://api.github.com/users/Gottox","html_url":"https://github.com/Gottox","followers_url":"https://api.github.com/users/Gottox/followers","following_url":"https://api.github.com/users/Gottox/following{/other_user}","gists_url":"https://api.github.com/users/Gottox/gists{/gist_id}","starred_url":"https://api.github.com/users/Gottox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gottox/subscriptions","organizations_url":"https://api.github.com/users/Gottox/orgs","repos_url":"https://api.github.com/users/Gottox/repos","events_url":"https://api.github.com/users/Gottox/events{/privacy}","received_events_url":"https://api.github.com/users/Gottox/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T16:53:52Z","updated_at":"2015-09-08T16:53:52Z","body":"I delayed that issue till NAN has a decent migration guide. Can waste time in digging through their source to understand the changes."}}