{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/37156363","id":37156363,"diff_hunk":"@@ -39,7 +38,7 @@\n  * 3.Write a JCA provider that registers the factory\n  */\n public class PlainSaslServer implements SaslServer {\n-  private String mAuthcid;\n+  private String mAuthzid;","path":"common/src/main/java/tachyon/security/PlainSaslServer.java","position":13,"original_position":13,"commit_id":"1ac0847bac1baa3467c025f2c339eab17dc989c0","original_commit_id":"308d350b9a0f8a471aaf1d0181d281f95e82a6fb","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"body":"Done. ","created_at":"2015-08-17T03:19:23Z","updated_at":"2015-08-17T03:19:23Z","html_url":"https://github.com/amplab/tachyon/pull/1269#discussion_r37156363","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1269","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/37156363"},"html":{"href":"https://github.com/amplab/tachyon/pull/1269#discussion_r37156363"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1269"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1269","id":41998979,"html_url":"https://github.com/amplab/tachyon/pull/1269","diff_url":"https://github.com/amplab/tachyon/pull/1269.diff","patch_url":"https://github.com/amplab/tachyon/pull/1269.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1269","number":1269,"state":"open","locked":false,"title":"[TACHYON-736] Add authenticated client user into a threadlocal variable","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"body":"JIRA: https://tachyon.atlassian.net/browse/TACHYON-736\r\n\r\nAfter build the SASL transport in TACHYON-726(#1229), client could connect to server with its user info and server could verify the user based on authentication mechanism.\r\nThen, if user is authenticated successfully, we should save the user and bind it with current thread for following RPC methods usage. The context is that, in thrift server, one client connection is allocated a thread during its lifecycle. This PR take care of this to assign the connected client user to a threadlocal.\r\n\r\nBesides, for testing, a very simple thrift RPC service class is added (only one method). Not sure this is a good way. If it is fine, shall I need to upload the thrift definition file `xxx.thrift`?\r\n\r\n@ooq , @apc999 , could you please help to review this PR? Thanks.","created_at":"2015-08-10T08:55:17Z","updated_at":"2015-08-17T03:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9508bc9e7e11a22bd3ac719b36e87267c3be688f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1269/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1269/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1269/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/1ac0847bac1baa3467c025f2c339eab17dc989c0","head":{"label":"dongche:security-736","ref":"security-736","sha":"1ac0847bac1baa3467c025f2c339eab17dc989c0","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"repo":{"id":38419009,"name":"tachyon","full_name":"dongche/tachyon","owner":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dongche/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/dongche/tachyon","forks_url":"https://api.github.com/repos/dongche/tachyon/forks","keys_url":"https://api.github.com/repos/dongche/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dongche/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dongche/tachyon/teams","hooks_url":"https://api.github.com/repos/dongche/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dongche/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dongche/tachyon/events","assignees_url":"https://api.github.com/repos/dongche/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dongche/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dongche/tachyon/tags","blobs_url":"https://api.github.com/repos/dongche/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dongche/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dongche/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dongche/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dongche/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dongche/tachyon/languages","stargazers_url":"https://api.github.com/repos/dongche/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dongche/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dongche/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dongche/tachyon/subscription","commits_url":"https://api.github.com/repos/dongche/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dongche/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dongche/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dongche/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dongche/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dongche/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dongche/tachyon/merges","archive_url":"https://api.github.com/repos/dongche/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dongche/tachyon/downloads","issues_url":"https://api.github.com/repos/dongche/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dongche/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dongche/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dongche/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dongche/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dongche/tachyon/releases{/id}","created_at":"2015-07-02T07:53:56Z","updated_at":"2015-07-02T07:53:58Z","pushed_at":"2015-08-13T02:58:43Z","git_url":"git://github.com/dongche/tachyon.git","ssh_url":"git@github.com:dongche/tachyon.git","clone_url":"https://github.com/dongche/tachyon.git","svn_url":"https://github.com/dongche/tachyon","homepage":"http://tachyon-project.org","size":16215,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:security","ref":"security","sha":"3dbaab04deeb257f65863c95787bde726f5f8dee","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-08-14T19:04:01Z","pushed_at":"2015-08-17T00:56:48Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":39624,"stargazers_count":1502,"watchers_count":1502,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":579,"mirror_url":null,"open_issues_count":25,"forks":579,"open_issues":25,"watchers":1502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1269"},"html":{"href":"https://github.com/amplab/tachyon/pull/1269"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1269"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1269/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1269/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1269/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/1ac0847bac1baa3467c025f2c339eab17dc989c0"}}}}