{"action":"created","comment":{"url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/comments/44249197","id":44249197,"diff_hunk":"@@ -0,0 +1,283 @@\n+/* Copyright 2015 MultiMC Contributors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"WonkoVersionList.h\"","path":"logic/wonko/WonkoVersionList.cpp","position":16,"original_position":16,"commit_id":"2e6c4d171016fd9137f42cd689b8375e5a9f871c","original_commit_id":"2e6c4d171016fd9137f42cd689b8375e5a9f871c","user":{"login":"02JanDal","id":3686998,"avatar_url":"https://avatars.githubusercontent.com/u/3686998?v=3","gravatar_id":"","url":"https://api.github.com/users/02JanDal","html_url":"https://github.com/02JanDal","followers_url":"https://api.github.com/users/02JanDal/followers","following_url":"https://api.github.com/users/02JanDal/following{/other_user}","gists_url":"https://api.github.com/users/02JanDal/gists{/gist_id}","starred_url":"https://api.github.com/users/02JanDal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/02JanDal/subscriptions","organizations_url":"https://api.github.com/users/02JanDal/orgs","repos_url":"https://api.github.com/users/02JanDal/repos","events_url":"https://api.github.com/users/02JanDal/events{/privacy}","received_events_url":"https://api.github.com/users/02JanDal/received_events","type":"User","site_admin":false},"body":"Hm? Don't quite understand what you want changed.","created_at":"2015-11-09T08:14:51Z","updated_at":"2015-11-09T08:14:51Z","html_url":"https://github.com/MultiMC/MultiMC5/pull/1323#discussion_r44249197","pull_request_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323","_links":{"self":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/comments/44249197"},"html":{"href":"https://github.com/MultiMC/MultiMC5/pull/1323#discussion_r44249197"},"pull_request":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323"}}},"pull_request":{"url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323","id":50064087,"html_url":"https://github.com/MultiMC/MultiMC5/pull/1323","diff_url":"https://github.com/MultiMC/MultiMC5/pull/1323.diff","patch_url":"https://github.com/MultiMC/MultiMC5/pull/1323.patch","issue_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/1323","number":1323,"state":"open","locked":false,"title":"Wonko","user":{"login":"02JanDal","id":3686998,"avatar_url":"https://avatars.githubusercontent.com/u/3686998?v=3","gravatar_id":"","url":"https://api.github.com/users/02JanDal","html_url":"https://github.com/02JanDal","followers_url":"https://api.github.com/users/02JanDal/followers","following_url":"https://api.github.com/users/02JanDal/following{/other_user}","gists_url":"https://api.github.com/users/02JanDal/gists{/gist_id}","starred_url":"https://api.github.com/users/02JanDal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/02JanDal/subscriptions","organizations_url":"https://api.github.com/users/02JanDal/orgs","repos_url":"https://api.github.com/users/02JanDal/repos","events_url":"https://api.github.com/users/02JanDal/events{/privacy}","received_events_url":"https://api.github.com/users/02JanDal/received_events","type":"User","site_admin":false},"body":"A wonko client implementation. Needs [MMCWonko/WonkoTheSane](https://github.com/MMCWonko/WonkoTheSane) and [MMCWonko/SomebodyElsesProblem](https://github.com/MMCWonko/SomebodyElsesProblem).\r\n\r\nPoint `MultiMC_WONKO_ROOT_URL` (cmake variable) at the folder containing the wonko files (the folder which contains `index.json`).\r\n\r\nThis should still be regarded as a prototype. While the basic functionality is here (of what we want to do in the first iteration), some more work is needed:\r\n\r\n- [ ] Take a look at various TODO/FIXME comments in the code\r\n    - [ ] Especially getting rid of showing dialogs in the constructor of the MultiMC class\r\n- [ ] Make sure Minecraft, Forge and LiteLoader work, both newly created instances and existing instances, of as many version combinations as possible\r\n- [ ] Setting up WTS and SEP on a server\r\n- [ ] Clean up and consider which parts of the Wonko and OneSix classes could/should be merged (for example we have two parsers)\r\n- [ ] General cleanup\r\n- [ ] Code review by someone else (aka not me)","created_at":"2015-11-08T16:46:55Z","updated_at":"2015-11-09T08:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27b02651adf7ebbdde922f6d0ee96f49e02d952a","assignee":{"login":"02JanDal","id":3686998,"avatar_url":"https://avatars.githubusercontent.com/u/3686998?v=3","gravatar_id":"","url":"https://api.github.com/users/02JanDal","html_url":"https://github.com/02JanDal","followers_url":"https://api.github.com/users/02JanDal/followers","following_url":"https://api.github.com/users/02JanDal/following{/other_user}","gists_url":"https://api.github.com/users/02JanDal/gists{/gist_id}","starred_url":"https://api.github.com/users/02JanDal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/02JanDal/subscriptions","organizations_url":"https://api.github.com/users/02JanDal/orgs","repos_url":"https://api.github.com/users/02JanDal/repos","events_url":"https://api.github.com/users/02JanDal/events{/privacy}","received_events_url":"https://api.github.com/users/02JanDal/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/1323/comments","statuses_url":"https://api.github.com/repos/MultiMC/MultiMC5/statuses/2e6c4d171016fd9137f42cd689b8375e5a9f871c","head":{"label":"MultiMC:feature/wonko","ref":"feature/wonko","sha":"2e6c4d171016fd9137f42cd689b8375e5a9f871c","user":{"login":"MultiMC","id":5411890,"avatar_url":"https://avatars.githubusercontent.com/u/5411890?v=3","gravatar_id":"","url":"https://api.github.com/users/MultiMC","html_url":"https://github.com/MultiMC","followers_url":"https://api.github.com/users/MultiMC/followers","following_url":"https://api.github.com/users/MultiMC/following{/other_user}","gists_url":"https://api.github.com/users/MultiMC/gists{/gist_id}","starred_url":"https://api.github.com/users/MultiMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MultiMC/subscriptions","organizations_url":"https://api.github.com/users/MultiMC/orgs","repos_url":"https://api.github.com/users/MultiMC/repos","events_url":"https://api.github.com/users/MultiMC/events{/privacy}","received_events_url":"https://api.github.com/users/MultiMC/received_events","type":"Organization","site_admin":false},"repo":{"id":12682212,"name":"MultiMC5","full_name":"MultiMC/MultiMC5","owner":{"login":"MultiMC","id":5411890,"avatar_url":"https://avatars.githubusercontent.com/u/5411890?v=3","gravatar_id":"","url":"https://api.github.com/users/MultiMC","html_url":"https://github.com/MultiMC","followers_url":"https://api.github.com/users/MultiMC/followers","following_url":"https://api.github.com/users/MultiMC/following{/other_user}","gists_url":"https://api.github.com/users/MultiMC/gists{/gist_id}","starred_url":"https://api.github.com/users/MultiMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MultiMC/subscriptions","organizations_url":"https://api.github.com/users/MultiMC/orgs","repos_url":"https://api.github.com/users/MultiMC/repos","events_url":"https://api.github.com/users/MultiMC/events{/privacy}","received_events_url":"https://api.github.com/users/MultiMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MultiMC/MultiMC5","description":"MultiMC is a free, open source launcher that helps you manage multiple, cleanly separated, instances of Minecraft.","fork":false,"url":"https://api.github.com/repos/MultiMC/MultiMC5","forks_url":"https://api.github.com/repos/MultiMC/MultiMC5/forks","keys_url":"https://api.github.com/repos/MultiMC/MultiMC5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MultiMC/MultiMC5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MultiMC/MultiMC5/teams","hooks_url":"https://api.github.com/repos/MultiMC/MultiMC5/hooks","issue_events_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/events{/number}","events_url":"https://api.github.com/repos/MultiMC/MultiMC5/events","assignees_url":"https://api.github.com/repos/MultiMC/MultiMC5/assignees{/user}","branches_url":"https://api.github.com/repos/MultiMC/MultiMC5/branches{/branch}","tags_url":"https://api.github.com/repos/MultiMC/MultiMC5/tags","blobs_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/refs{/sha}","trees_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MultiMC/MultiMC5/statuses/{sha}","languages_url":"https://api.github.com/repos/MultiMC/MultiMC5/languages","stargazers_url":"https://api.github.com/repos/MultiMC/MultiMC5/stargazers","contributors_url":"https://api.github.com/repos/MultiMC/MultiMC5/contributors","subscribers_url":"https://api.github.com/repos/MultiMC/MultiMC5/subscribers","subscription_url":"https://api.github.com/repos/MultiMC/MultiMC5/subscription","commits_url":"https://api.github.com/repos/MultiMC/MultiMC5/commits{/sha}","git_commits_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/commits{/sha}","comments_url":"https://api.github.com/repos/MultiMC/MultiMC5/comments{/number}","issue_comment_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/comments{/number}","contents_url":"https://api.github.com/repos/MultiMC/MultiMC5/contents/{+path}","compare_url":"https://api.github.com/repos/MultiMC/MultiMC5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MultiMC/MultiMC5/merges","archive_url":"https://api.github.com/repos/MultiMC/MultiMC5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MultiMC/MultiMC5/downloads","issues_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues{/number}","pulls_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls{/number}","milestones_url":"https://api.github.com/repos/MultiMC/MultiMC5/milestones{/number}","notifications_url":"https://api.github.com/repos/MultiMC/MultiMC5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MultiMC/MultiMC5/labels{/name}","releases_url":"https://api.github.com/repos/MultiMC/MultiMC5/releases{/id}","created_at":"2013-09-08T14:51:29Z","updated_at":"2015-11-07T04:43:15Z","pushed_at":"2015-11-08T23:29:51Z","git_url":"git://github.com/MultiMC/MultiMC5.git","ssh_url":"git@github.com:MultiMC/MultiMC5.git","clone_url":"https://github.com/MultiMC/MultiMC5.git","svn_url":"https://github.com/MultiMC/MultiMC5","homepage":"http://multimc.org/","size":21394,"stargazers_count":237,"watchers_count":237,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":240,"forks":128,"open_issues":240,"watchers":237,"default_branch":"develop"}},"base":{"label":"MultiMC:develop","ref":"develop","sha":"895d8ab4699f1b50bf03532c967a91f5ecb62a50","user":{"login":"MultiMC","id":5411890,"avatar_url":"https://avatars.githubusercontent.com/u/5411890?v=3","gravatar_id":"","url":"https://api.github.com/users/MultiMC","html_url":"https://github.com/MultiMC","followers_url":"https://api.github.com/users/MultiMC/followers","following_url":"https://api.github.com/users/MultiMC/following{/other_user}","gists_url":"https://api.github.com/users/MultiMC/gists{/gist_id}","starred_url":"https://api.github.com/users/MultiMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MultiMC/subscriptions","organizations_url":"https://api.github.com/users/MultiMC/orgs","repos_url":"https://api.github.com/users/MultiMC/repos","events_url":"https://api.github.com/users/MultiMC/events{/privacy}","received_events_url":"https://api.github.com/users/MultiMC/received_events","type":"Organization","site_admin":false},"repo":{"id":12682212,"name":"MultiMC5","full_name":"MultiMC/MultiMC5","owner":{"login":"MultiMC","id":5411890,"avatar_url":"https://avatars.githubusercontent.com/u/5411890?v=3","gravatar_id":"","url":"https://api.github.com/users/MultiMC","html_url":"https://github.com/MultiMC","followers_url":"https://api.github.com/users/MultiMC/followers","following_url":"https://api.github.com/users/MultiMC/following{/other_user}","gists_url":"https://api.github.com/users/MultiMC/gists{/gist_id}","starred_url":"https://api.github.com/users/MultiMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MultiMC/subscriptions","organizations_url":"https://api.github.com/users/MultiMC/orgs","repos_url":"https://api.github.com/users/MultiMC/repos","events_url":"https://api.github.com/users/MultiMC/events{/privacy}","received_events_url":"https://api.github.com/users/MultiMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MultiMC/MultiMC5","description":"MultiMC is a free, open source launcher that helps you manage multiple, cleanly separated, instances of Minecraft.","fork":false,"url":"https://api.github.com/repos/MultiMC/MultiMC5","forks_url":"https://api.github.com/repos/MultiMC/MultiMC5/forks","keys_url":"https://api.github.com/repos/MultiMC/MultiMC5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MultiMC/MultiMC5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MultiMC/MultiMC5/teams","hooks_url":"https://api.github.com/repos/MultiMC/MultiMC5/hooks","issue_events_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/events{/number}","events_url":"https://api.github.com/repos/MultiMC/MultiMC5/events","assignees_url":"https://api.github.com/repos/MultiMC/MultiMC5/assignees{/user}","branches_url":"https://api.github.com/repos/MultiMC/MultiMC5/branches{/branch}","tags_url":"https://api.github.com/repos/MultiMC/MultiMC5/tags","blobs_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/refs{/sha}","trees_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MultiMC/MultiMC5/statuses/{sha}","languages_url":"https://api.github.com/repos/MultiMC/MultiMC5/languages","stargazers_url":"https://api.github.com/repos/MultiMC/MultiMC5/stargazers","contributors_url":"https://api.github.com/repos/MultiMC/MultiMC5/contributors","subscribers_url":"https://api.github.com/repos/MultiMC/MultiMC5/subscribers","subscription_url":"https://api.github.com/repos/MultiMC/MultiMC5/subscription","commits_url":"https://api.github.com/repos/MultiMC/MultiMC5/commits{/sha}","git_commits_url":"https://api.github.com/repos/MultiMC/MultiMC5/git/commits{/sha}","comments_url":"https://api.github.com/repos/MultiMC/MultiMC5/comments{/number}","issue_comment_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues/comments{/number}","contents_url":"https://api.github.com/repos/MultiMC/MultiMC5/contents/{+path}","compare_url":"https://api.github.com/repos/MultiMC/MultiMC5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MultiMC/MultiMC5/merges","archive_url":"https://api.github.com/repos/MultiMC/MultiMC5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MultiMC/MultiMC5/downloads","issues_url":"https://api.github.com/repos/MultiMC/MultiMC5/issues{/number}","pulls_url":"https://api.github.com/repos/MultiMC/MultiMC5/pulls{/number}","milestones_url":"https://api.github.com/repos/MultiMC/MultiMC5/milestones{/number}","notifications_url":"https://api.github.com/repos/MultiMC/MultiMC5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MultiMC/MultiMC5/labels{/name}","releases_url":"https://api.github.com/repos/MultiMC/MultiMC5/releases{/id}","created_at":"2013-09-08T14:51:29Z","updated_at":"2015-11-07T04:43:15Z","pushed_at":"2015-11-08T23:29:51Z","git_url":"git://github.com/MultiMC/MultiMC5.git","ssh_url":"git@github.com:MultiMC/MultiMC5.git","clone_url":"https://github.com/MultiMC/MultiMC5.git","svn_url":"https://github.com/MultiMC/MultiMC5","homepage":"http://multimc.org/","size":21394,"stargazers_count":237,"watchers_count":237,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":240,"forks":128,"open_issues":240,"watchers":237,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323"},"html":{"href":"https://github.com/MultiMC/MultiMC5/pull/1323"},"issue":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/issues/1323"},"comments":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/MultiMC/MultiMC5/statuses/2e6c4d171016fd9137f42cd689b8375e5a9f871c"}}}}