{"action":"created","issue":{"url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/138","labels_url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/138/comments","events_url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/138/events","html_url":"https://github.com/michaeluno/admin-page-framework/issues/138","id":44295432,"number":138,"title":"Should the demo plugin be separated from the main framework?","user":{"login":"michaeluno","id":3408158,"avatar_url":"https://avatars.githubusercontent.com/u/3408158?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeluno","html_url":"https://github.com/michaeluno","followers_url":"https://api.github.com/users/michaeluno/followers","following_url":"https://api.github.com/users/michaeluno/following{/other_user}","gists_url":"https://api.github.com/users/michaeluno/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeluno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeluno/subscriptions","organizations_url":"https://api.github.com/users/michaeluno/orgs","repos_url":"https://api.github.com/users/michaeluno/repos","events_url":"https://api.github.com/users/michaeluno/events{/privacy}","received_events_url":"https://api.github.com/users/michaeluno/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/michaeluno/admin-page-framework/labels/Change","name":"Change","color":"5319e7"},{"url":"https://api.github.com/repos/michaeluno/admin-page-framework/labels/Need+Opinions","name":"Need Opinions","color":"EBCEBC"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/michaeluno/admin-page-framework/milestones/9","labels_url":"https://api.github.com/repos/michaeluno/admin-page-framework/milestones/9/labels","id":832020,"number":9,"title":"3.5","description":null,"creator":{"login":"michaeluno","id":3408158,"avatar_url":"https://avatars.githubusercontent.com/u/3408158?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeluno","html_url":"https://github.com/michaeluno","followers_url":"https://api.github.com/users/michaeluno/followers","following_url":"https://api.github.com/users/michaeluno/following{/other_user}","gists_url":"https://api.github.com/users/michaeluno/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeluno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeluno/subscriptions","organizations_url":"https://api.github.com/users/michaeluno/orgs","repos_url":"https://api.github.com/users/michaeluno/repos","events_url":"https://api.github.com/users/michaeluno/events{/privacy}","received_events_url":"https://api.github.com/users/michaeluno/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2014-10-19T23:47:55Z","updated_at":"2015-01-08T13:04:37Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2014-09-29T13:53:15Z","updated_at":"2015-01-16T23:10:18Z","closed_at":null,"body":"I'm wondering whether the demo plugin should be a separate plugin then make the main framework plugin just serve as a framework installer which just includes the framework file(s).  \r\n\r\nThis way, each developer who uses the framework does not have to call `include( 'admin-page-framework.min.php' )`. However, their plugin or theme will need to require the framework installer to be installed as a dependency so their products will not be portable. \r\n\r\nBut I sense that some don't mind it and rather prefer that way. I'm not completely sure why but maybe it can avoid library conflicts or something."},"comment":{"url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/comments/70337686","html_url":"https://github.com/michaeluno/admin-page-framework/issues/138#issuecomment-70337686","issue_url":"https://api.github.com/repos/michaeluno/admin-page-framework/issues/138","id":70337686,"user":{"login":"michaeluno","id":3408158,"avatar_url":"https://avatars.githubusercontent.com/u/3408158?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeluno","html_url":"https://github.com/michaeluno","followers_url":"https://api.github.com/users/michaeluno/followers","following_url":"https://api.github.com/users/michaeluno/following{/other_user}","gists_url":"https://api.github.com/users/michaeluno/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeluno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeluno/subscriptions","organizations_url":"https://api.github.com/users/michaeluno/orgs","repos_url":"https://api.github.com/users/michaeluno/repos","events_url":"https://api.github.com/users/michaeluno/events{/privacy}","received_events_url":"https://api.github.com/users/michaeluno/received_events","type":"User","site_admin":false},"created_at":"2015-01-16T23:10:18Z","updated_at":"2015-01-16T23:10:18Z","body":"@vladkucherov in v3.5.0 the demo part will be optional. \r\n\r\nYou may try the 3.5.0b branch. https://github.com/michaeluno/admin-page-framework/tree/3.5.0b ([Download](https://github.com/michaeluno/admin-page-framework/archive/3.5.0b.zip))\r\n\r\n> I prefer the plugin as a plugin and not as a library inside my code.\r\n\r\nI'm curious whether you don't mind requiring your users to install an extra plugin for your products."}}