{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38","id":28047506,"html_url":"https://github.com/mirage/ocaml-dns/pull/38","diff_url":"https://github.com/mirage/ocaml-dns/pull/38.diff","patch_url":"https://github.com/mirage/ocaml-dns/pull/38.patch","issue_url":"https://api.github.com/repos/mirage/ocaml-dns/issues/38","number":38,"state":"closed","locked":false,"title":"Release 0.13.0","user":{"login":"avsm","id":53164,"avatar_url":"https://avatars.githubusercontent.com/u/53164?v=3","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"body":"* Add support for multicast DNS (RFC6762) in the trie. (#35 from Luke Dunstan)\r\n  * mDNS doesn't use SOA nor delegation (RFC 6762 section 12), so some minor changes\r\n    to Trie are required to handle this.\r\n  * mDNS doesn't echo the questions in the response (RFC 6762 section 6), except\r\n    in legacy mode, so a `bool` argument was added to `Query.response_of_answer`.\r\n  * `Query.answer` still exists but now `Query.answer_multiple` is also available\r\n    for answering multiple questions in one query to produce a single answer \r\n    (RFC 6762 section 5.3). One caveat is that responses may exceed the maximum\r\n    message length, but that is not really specific to mDNS. Also, in theory multiple\r\n    questions might require multiple separate response messages in unusual cases,\r\n    but that is complicated and the library does not deal with that yet.\r\n  * `Query.answer_multiple` takes an optional function to allow the caller to control\r\n    the `cache-flush` bit. This bit is only set for records that have been \"confirmed\r\n    as unique\". Using a callback requires minimal changes here but puts the burden of\r\n    maintaining uniqueness state elsewhere.\r\n  * `Query.answer_multiple` takes an optional function to filter the answer, in order\r\n    to support \"known answer suppression\" (RFC 6762 section 7.1). Again, using a callback\r\n    requires minimal change to the core, but later on the mDNS-specific known answer\r\n    suppression logic could move into the `Query` module if that turns out to be simpler.\r\n  * A query for `PTR` returns additional records for `SRV` and `TXT`, to support efficient\r\n    service discovery.\r\n  * `Trie.iter` was added to support mDNS announcements.\r\n* Switch to `Bytes` instead of `String` for eventual `-safe-string` support.\r\n* Partially remove some error printing to stderr. (#36)\r\n\r\nUnit tests were added for some of the changes above, including a test-only\r\ndependency on `pcap-format`.\r\n","created_at":"2015-01-26T18:13:46Z","updated_at":"2015-01-26T21:25:34Z","closed_at":"2015-01-26T21:25:34Z","merged_at":"2015-01-26T21:25:34Z","merge_commit_sha":"56c779749c6576b343b30bbf629718709754f088","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38/commits","review_comments_url":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38/comments","review_comment_url":"https://api.github.com/repos/mirage/ocaml-dns/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mirage/ocaml-dns/issues/38/comments","statuses_url":"https://api.github.com/repos/mirage/ocaml-dns/statuses/71ada1e8007728651b731c801daf736425475bae","head":{"label":"avsm:master","ref":"master","sha":"71ada1e8007728651b731c801daf736425475bae","user":{"login":"avsm","id":53164,"avatar_url":"https://avatars.githubusercontent.com/u/53164?v=3","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"repo":{"id":18948091,"name":"ocaml-dns","full_name":"avsm/ocaml-dns","owner":{"login":"avsm","id":53164,"avatar_url":"https://avatars.githubusercontent.com/u/53164?v=3","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avsm/ocaml-dns","description":"OCaml implementation of the DNS protocol","fork":true,"url":"https://api.github.com/repos/avsm/ocaml-dns","forks_url":"https://api.github.com/repos/avsm/ocaml-dns/forks","keys_url":"https://api.github.com/repos/avsm/ocaml-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avsm/ocaml-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avsm/ocaml-dns/teams","hooks_url":"https://api.github.com/repos/avsm/ocaml-dns/hooks","issue_events_url":"https://api.github.com/repos/avsm/ocaml-dns/issues/events{/number}","events_url":"https://api.github.com/repos/avsm/ocaml-dns/events","assignees_url":"https://api.github.com/repos/avsm/ocaml-dns/assignees{/user}","branches_url":"https://api.github.com/repos/avsm/ocaml-dns/branches{/branch}","tags_url":"https://api.github.com/repos/avsm/ocaml-dns/tags","blobs_url":"https://api.github.com/repos/avsm/ocaml-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avsm/ocaml-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avsm/ocaml-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/avsm/ocaml-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avsm/ocaml-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/avsm/ocaml-dns/languages","stargazers_url":"https://api.github.com/repos/avsm/ocaml-dns/stargazers","contributors_url":"https://api.github.com/repos/avsm/ocaml-dns/contributors","subscribers_url":"https://api.github.com/repos/avsm/ocaml-dns/subscribers","subscription_url":"https://api.github.com/repos/avsm/ocaml-dns/subscription","commits_url":"https://api.github.com/repos/avsm/ocaml-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/avsm/ocaml-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/avsm/ocaml-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/avsm/ocaml-dns/issues/comments/{number}","contents_url":"https://api.github.com/repos/avsm/ocaml-dns/contents/{+path}","compare_url":"https://api.github.com/repos/avsm/ocaml-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avsm/ocaml-dns/merges","archive_url":"https://api.github.com/repos/avsm/ocaml-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avsm/ocaml-dns/downloads","issues_url":"https://api.github.com/repos/avsm/ocaml-dns/issues{/number}","pulls_url":"https://api.github.com/repos/avsm/ocaml-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/avsm/ocaml-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/avsm/ocaml-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avsm/ocaml-dns/labels{/name}","releases_url":"https://api.github.com/repos/avsm/ocaml-dns/releases{/id}","created_at":"2014-04-19T18:40:43Z","updated_at":"2015-01-26T18:13:22Z","pushed_at":"2015-01-26T18:13:22Z","git_url":"git://github.com/avsm/ocaml-dns.git","ssh_url":"git@github.com:avsm/ocaml-dns.git","clone_url":"https://github.com/avsm/ocaml-dns.git","svn_url":"https://github.com/avsm/ocaml-dns","homepage":"","size":1511,"stargazers_count":1,"watchers_count":1,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"d003599268ede9af688c9a6442f4c202b96858a6","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":3141834,"name":"ocaml-dns","full_name":"mirage/ocaml-dns","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/ocaml-dns","description":"OCaml implementation of the DNS protocol","fork":false,"url":"https://api.github.com/repos/mirage/ocaml-dns","forks_url":"https://api.github.com/repos/mirage/ocaml-dns/forks","keys_url":"https://api.github.com/repos/mirage/ocaml-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/ocaml-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/ocaml-dns/teams","hooks_url":"https://api.github.com/repos/mirage/ocaml-dns/hooks","issue_events_url":"https://api.github.com/repos/mirage/ocaml-dns/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/ocaml-dns/events","assignees_url":"https://api.github.com/repos/mirage/ocaml-dns/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/ocaml-dns/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/ocaml-dns/tags","blobs_url":"https://api.github.com/repos/mirage/ocaml-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/ocaml-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/ocaml-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/ocaml-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/ocaml-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/ocaml-dns/languages","stargazers_url":"https://api.github.com/repos/mirage/ocaml-dns/stargazers","contributors_url":"https://api.github.com/repos/mirage/ocaml-dns/contributors","subscribers_url":"https://api.github.com/repos/mirage/ocaml-dns/subscribers","subscription_url":"https://api.github.com/repos/mirage/ocaml-dns/subscription","commits_url":"https://api.github.com/repos/mirage/ocaml-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/ocaml-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/ocaml-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/ocaml-dns/issues/comments/{number}","contents_url":"https://api.github.com/repos/mirage/ocaml-dns/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/ocaml-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/ocaml-dns/merges","archive_url":"https://api.github.com/repos/mirage/ocaml-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/ocaml-dns/downloads","issues_url":"https://api.github.com/repos/mirage/ocaml-dns/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/ocaml-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/ocaml-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/ocaml-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/ocaml-dns/labels{/name}","releases_url":"https://api.github.com/repos/mirage/ocaml-dns/releases{/id}","created_at":"2012-01-10T01:38:53Z","updated_at":"2015-01-22T09:03:02Z","pushed_at":"2015-01-26T21:25:34Z","git_url":"git://github.com/mirage/ocaml-dns.git","ssh_url":"git@github.com:mirage/ocaml-dns.git","clone_url":"https://github.com/mirage/ocaml-dns.git","svn_url":"https://github.com/mirage/ocaml-dns","homepage":"","size":1690,"stargazers_count":23,"watchers_count":23,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38"},"html":{"href":"https://github.com/mirage/ocaml-dns/pull/38"},"issue":{"href":"https://api.github.com/repos/mirage/ocaml-dns/issues/38"},"comments":{"href":"https://api.github.com/repos/mirage/ocaml-dns/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/ocaml-dns/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mirage/ocaml-dns/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/ocaml-dns/statuses/71ada1e8007728651b731c801daf736425475bae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"avsm","id":53164,"avatar_url":"https://avatars.githubusercontent.com/u/53164?v=3","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":29,"additions":676,"deletions":69,"changed_files":18}}