{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24172026","id":24172026,"diff_hunk":"@@ -517,13 +518,13 @@ struct PushParticlePerFrame\n          * y=1 for dir = 1\n          * y=2 for dir = -1\n          */\n-        const int direction = 1 +\n-            (dir.x() + int(dir.x() < 0)*3) +\n-            (dir.y() + int(dir.y() < 0)*3) * BOTTOM\n-#if (SIMDIM==DIM3)\n-            + (dir.z() + int(dir.z() < 0)*3) * BACK\n-#endif\n-            ;\n+        int direction = 1;\n+        uint32_t exchangeType = 1; // see libPMacc/include/types.h for RIGHT, BOTTOM and BACK\n+        for (uint32_t i = 0; i < simDim; ++i)\n+        {\n+            direction += (dir[i] + (dir[i] < 0 ? 3 : 0)) * exchangeType; \n+            exchangeType *= 3; // =3^i\n+        }","path":"src/picongpu/include/particles/Particles.kernel","position":27,"original_position":27,"commit_id":"d5ff6c07b63e9cd1c8ad56e6720c0af5b4d61ae5","original_commit_id":"d5ff6c07b63e9cd1c8ad56e6720c0af5b4d61ae5","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":":)\r\n![i_see_magic_numbers](https://cloud.githubusercontent.com/assets/1353258/6063373/039526b0-ad57-11e4-83b9-7eaa0a37ca64.png)\r\n\r\n","created_at":"2015-02-05T15:49:59Z","updated_at":"2015-02-05T15:49:59Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678#discussion_r24172026","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24172026"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678#discussion_r24172026"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678","id":28730498,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/678","number":678,"state":"open","locked":false,"title":"fix CUDA6.5 int(bool) bug in particle kernel","user":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"body":"This pull request solves the CUDA6.5 `int(bool)` bug (#570) in `Particles.kernel`.\r\n\r\nIn order to work with the bool arrays of size `simDim`, `for` loops were used. These also avoid using *ugly* pre-compiler `#if`.\r\n\r\n**TO DOs:**\r\n - [x] verify that this change does not slow done PIConGPU\r\n - [x] varify that particles are still transported correctly","created_at":"2015-02-05T14:56:14Z","updated_at":"2015-02-05T15:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53a1798cc6606538855607d6a48e1765e768bcbf","assignee":null,"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":549,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-02-05T14:56:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/678/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/d5ff6c07b63e9cd1c8ad56e6720c0af5b4d61ae5","head":{"label":"PrometheusPi:fix-03boolBugCUDA6.5","ref":"fix-03boolBugCUDA6.5","sha":"d5ff6c07b63e9cd1c8ad56e6720c0af5b4d61ae5","user":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"repo":{"id":12809053,"name":"picongpu","full_name":"PrometheusPi/picongpu","owner":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PrometheusPi/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/PrometheusPi/picongpu","forks_url":"https://api.github.com/repos/PrometheusPi/picongpu/forks","keys_url":"https://api.github.com/repos/PrometheusPi/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrometheusPi/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrometheusPi/picongpu/teams","hooks_url":"https://api.github.com/repos/PrometheusPi/picongpu/hooks","issue_events_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/PrometheusPi/picongpu/events","assignees_url":"https://api.github.com/repos/PrometheusPi/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/PrometheusPi/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/PrometheusPi/picongpu/tags","blobs_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrometheusPi/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/PrometheusPi/picongpu/languages","stargazers_url":"https://api.github.com/repos/PrometheusPi/picongpu/stargazers","contributors_url":"https://api.github.com/repos/PrometheusPi/picongpu/contributors","subscribers_url":"https://api.github.com/repos/PrometheusPi/picongpu/subscribers","subscription_url":"https://api.github.com/repos/PrometheusPi/picongpu/subscription","commits_url":"https://api.github.com/repos/PrometheusPi/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrometheusPi/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/PrometheusPi/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/PrometheusPi/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrometheusPi/picongpu/merges","archive_url":"https://api.github.com/repos/PrometheusPi/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrometheusPi/picongpu/downloads","issues_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/PrometheusPi/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/PrometheusPi/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/PrometheusPi/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrometheusPi/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/PrometheusPi/picongpu/releases{/id}","created_at":"2013-09-13T12:32:47Z","updated_at":"2014-05-26T14:41:37Z","pushed_at":"2015-02-05T14:50:14Z","git_url":"git://github.com/PrometheusPi/picongpu.git","ssh_url":"git@github.com:PrometheusPi/picongpu.git","clone_url":"https://github.com/PrometheusPi/picongpu.git","svn_url":"https://github.com/PrometheusPi/picongpu","homepage":"http://picongpu.hzdr.de","size":8546,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"5d81eac8218833319efe68b73f4b8d906962571a","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-02-04T14:43:29Z","pushed_at":"2015-02-05T13:39:41Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":13526,"stargazers_count":83,"watchers_count":83,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":97,"forks":45,"open_issues":97,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/678"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/678"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/678/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/678/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/d5ff6c07b63e9cd1c8ad56e6720c0af5b4d61ae5"}}}}