{"action":"created","issue":{"url":"https://api.github.com/repos/karussell/snacktory/issues/44","labels_url":"https://api.github.com/repos/karussell/snacktory/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/karussell/snacktory/issues/44/comments","events_url":"https://api.github.com/repos/karussell/snacktory/issues/44/events","html_url":"https://github.com/karussell/snacktory/pull/44","id":56272775,"number":44,"title":"Fix issue #10 allow users to set a proxy","user":{"login":"kinow","id":304786,"avatar_url":"https://avatars.githubusercontent.com/u/304786?v=3","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-02T18:17:48Z","updated_at":"2015-02-03T21:13:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/karussell/snacktory/pulls/44","html_url":"https://github.com/karussell/snacktory/pull/44","diff_url":"https://github.com/karussell/snacktory/pull/44.diff","patch_url":"https://github.com/karussell/snacktory/pull/44.patch"},"body":"Hi @karussell, \r\n\r\nHere's a first tentative to add proxies to Snacktory (thanks for writing it by the way). I didn't want to expose the Type object in Snacktory API, so users have to provide the proxy type as text (they can use the Type enum to get the type name). \r\n\r\nSome simple JUNit tests attached. Tried to keep the code style (no tabs), but feel free to further massage the code if needed, as I didn't spend much time looking at the rest of the code to standardize the code.\r\n\r\nSuccessfully tested with Snacktory against a CNTLM HTTP proxy and a SSH SOCKS proxy. Both seemed to work, but as your comment in the code suggested, quite slow.\r\n\r\nHope that helps,\r\nBruno"},"comment":{"url":"https://api.github.com/repos/karussell/snacktory/issues/comments/72735841","html_url":"https://github.com/karussell/snacktory/pull/44#issuecomment-72735841","issue_url":"https://api.github.com/repos/karussell/snacktory/issues/44","id":72735841,"user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T21:13:04Z","updated_at":"2015-02-03T21:13:04Z","body":"> Let me know if you want me to submit another pull request, \r\n\r\nYou can just push to your branch and this will change here. I would prefer using the Proxy object only. But this can be done only if it is really threadsafe - do you know about it?\r\n\r\n> I wasn't sure if you'd be all right with that or not :-) \r\n\r\nI'm okay with that, sure :)\r\n\r\n> BTW, I had a look at the Travis CI failure, but I'm not sure if the PR caused the error.\r\n\r\nYeah, I think that this failed before (some integration tests)"}}