{"action":"created","comment":{"url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/comments/43533086","id":43533086,"diff_hunk":"@@ -36,44 +37,79 @@ current session status.\n \n + Response 201 (application/vnd.api+json)\n \n-        {\n-            \"links\": {\n-                \"self\": \"https://example.com/session\"\n-            },\n-            \"data\": {\n-                \"id\": \"sessionid123\",\n-                \"type\": \"session\"\n-            },\n-            \"related\": {\n-                \"account\": {\n-                    \"links\": {\n-                        \"related\": \"https://example.com/session/account\"\n-                    },\n-                    \"data\": {\n-                        \"id\": \"abc1234\",\n-                        \"type\": \"account\"\n+    + Headers\n+\n+            Location: https://example.com/session\n+\n+    + Body\n+\n+            {\n+                \"links\": {\n+                    \"self\": \"https://example.com/session\"\n+                },\n+                \"data\": {\n+                    \"id\": \"sessionid123\",\n+                    \"type\": \"session\",\n+                    \"relationships\": {\n+                        \"account\": {\n+                            \"links\": {\n+                                \"related\": \"https://example.com/session/account\"\n+                            },\n+                            \"data\": {\n+                                \"id\": \"abc1234\",\n+                                \"type\": \"account\"\n+                            }\n+                        }\n                     }\n                 },\n-                \"profile\": {\n-                    \"links\": {\n-                        \"related\": \"https://example.com/session/account/profile\"\n+                \"included\": [{\n+                    \"id\": \"abc1234\",\n+                    \"type\": \"account\",\n+                    \"attributes\": {\n+                        \"username\": \"jane-doe\"\n                     },\n-                    \"data\": {\n-                        \"id\": \"profile\",\n-                        \"type\": \"accountProfile\"\n+                    \"relationships\": {\n+                        \"profile\": {\n+                            \"links\": {\n+                                \"related\": \"https://example.com/session/account/profile\"\n+                            },\n+                            \"data\": {\n+                                \"id\": \"abc1234-profile\",\n+                                \"type\": \"accountProfile\"\n+                            }\n+                        }\n                     }\n-                }\n+                }]\n             }","path":"apiary.apib","position":81,"original_position":81,"commit_id":"10a8682aa8d1434ef6c70ff86603e7d327a4f620","original_commit_id":"53c0f916a403be4953afd9c06476a130e685a2a2","user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars.githubusercontent.com/u/39992?v=3","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"body":"I think the `\"indcluded\"` part requires `?include=account`, doesn't it? Or can we send this anyway, because in the context of sign in, it probably doesn't make sense to sign in without getting a username and an account id in response?","created_at":"2015-10-30T17:59:35Z","updated_at":"2015-10-30T17:59:35Z","html_url":"https://github.com/gr2m/account-rest-api/pull/4#discussion_r43533086","pull_request_url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/comments/43533086"},"html":{"href":"https://github.com/gr2m/account-rest-api/pull/4#discussion_r43533086"},"pull_request":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4","id":49192897,"html_url":"https://github.com/gr2m/account-rest-api/pull/4","diff_url":"https://github.com/gr2m/account-rest-api/pull/4.diff","patch_url":"https://github.com/gr2m/account-rest-api/pull/4.patch","issue_url":"https://api.github.com/repos/gr2m/account-rest-api/issues/4","number":4,"state":"open","locked":false,"title":"fix: update non JSON API compliant parts","user":{"login":"patriciagarcia","id":572958,"avatar_url":"https://avatars.githubusercontent.com/u/572958?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciagarcia","html_url":"https://github.com/patriciagarcia","followers_url":"https://api.github.com/users/patriciagarcia/followers","following_url":"https://api.github.com/users/patriciagarcia/following{/other_user}","gists_url":"https://api.github.com/users/patriciagarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciagarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciagarcia/subscriptions","organizations_url":"https://api.github.com/users/patriciagarcia/orgs","repos_url":"https://api.github.com/users/patriciagarcia/repos","events_url":"https://api.github.com/users/patriciagarcia/events{/privacy}","received_events_url":"https://api.github.com/users/patriciagarcia/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-29T20:08:43Z","updated_at":"2015-10-30T17:59:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3735d150c1e22e32ce3daa9c789f8d9a903fff2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4/commits","review_comments_url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4/comments","review_comment_url":"https://api.github.com/repos/gr2m/account-rest-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gr2m/account-rest-api/issues/4/comments","statuses_url":"https://api.github.com/repos/gr2m/account-rest-api/statuses/10a8682aa8d1434ef6c70ff86603e7d327a4f620","head":{"label":"patriciagarcia:update-api","ref":"update-api","sha":"10a8682aa8d1434ef6c70ff86603e7d327a4f620","user":{"login":"patriciagarcia","id":572958,"avatar_url":"https://avatars.githubusercontent.com/u/572958?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciagarcia","html_url":"https://github.com/patriciagarcia","followers_url":"https://api.github.com/users/patriciagarcia/followers","following_url":"https://api.github.com/users/patriciagarcia/following{/other_user}","gists_url":"https://api.github.com/users/patriciagarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciagarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciagarcia/subscriptions","organizations_url":"https://api.github.com/users/patriciagarcia/orgs","repos_url":"https://api.github.com/users/patriciagarcia/repos","events_url":"https://api.github.com/users/patriciagarcia/events{/privacy}","received_events_url":"https://api.github.com/users/patriciagarcia/received_events","type":"User","site_admin":false},"repo":{"id":44986799,"name":"account-rest-api","full_name":"patriciagarcia/account-rest-api","owner":{"login":"patriciagarcia","id":572958,"avatar_url":"https://avatars.githubusercontent.com/u/572958?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciagarcia","html_url":"https://github.com/patriciagarcia","followers_url":"https://api.github.com/users/patriciagarcia/followers","following_url":"https://api.github.com/users/patriciagarcia/following{/other_user}","gists_url":"https://api.github.com/users/patriciagarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciagarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciagarcia/subscriptions","organizations_url":"https://api.github.com/users/patriciagarcia/orgs","repos_url":"https://api.github.com/users/patriciagarcia/repos","events_url":"https://api.github.com/users/patriciagarcia/events{/privacy}","received_events_url":"https://api.github.com/users/patriciagarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patriciagarcia/account-rest-api","description":"REST-API Blueprint for all things user accounts and sesions","fork":true,"url":"https://api.github.com/repos/patriciagarcia/account-rest-api","forks_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/forks","keys_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/teams","hooks_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/hooks","issue_events_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/events","assignees_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/tags","blobs_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/languages","stargazers_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/stargazers","contributors_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/contributors","subscribers_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/subscribers","subscription_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/subscription","commits_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/merges","archive_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/downloads","issues_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/patriciagarcia/account-rest-api/releases{/id}","created_at":"2015-10-26T17:51:53Z","updated_at":"2015-10-26T17:51:54Z","pushed_at":"2015-10-30T17:20:41Z","git_url":"git://github.com/patriciagarcia/account-rest-api.git","ssh_url":"git@github.com:patriciagarcia/account-rest-api.git","clone_url":"https://github.com/patriciagarcia/account-rest-api.git","svn_url":"https://github.com/patriciagarcia/account-rest-api","homepage":"http://docs.accountrestapi.apiary.io","size":91,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gr2m:master","ref":"master","sha":"b0b6ecae59adb58bc5b728cfe47e7b70d4d3b83c","user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars.githubusercontent.com/u/39992?v=3","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"repo":{"id":39162847,"name":"account-rest-api","full_name":"gr2m/account-rest-api","owner":{"login":"gr2m","id":39992,"avatar_url":"https://avatars.githubusercontent.com/u/39992?v=3","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gr2m/account-rest-api","description":"REST-API Blueprint for all things user accounts and sesions","fork":false,"url":"https://api.github.com/repos/gr2m/account-rest-api","forks_url":"https://api.github.com/repos/gr2m/account-rest-api/forks","keys_url":"https://api.github.com/repos/gr2m/account-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gr2m/account-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gr2m/account-rest-api/teams","hooks_url":"https://api.github.com/repos/gr2m/account-rest-api/hooks","issue_events_url":"https://api.github.com/repos/gr2m/account-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/gr2m/account-rest-api/events","assignees_url":"https://api.github.com/repos/gr2m/account-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/gr2m/account-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/gr2m/account-rest-api/tags","blobs_url":"https://api.github.com/repos/gr2m/account-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gr2m/account-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gr2m/account-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/gr2m/account-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gr2m/account-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/gr2m/account-rest-api/languages","stargazers_url":"https://api.github.com/repos/gr2m/account-rest-api/stargazers","contributors_url":"https://api.github.com/repos/gr2m/account-rest-api/contributors","subscribers_url":"https://api.github.com/repos/gr2m/account-rest-api/subscribers","subscription_url":"https://api.github.com/repos/gr2m/account-rest-api/subscription","commits_url":"https://api.github.com/repos/gr2m/account-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/gr2m/account-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/gr2m/account-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/gr2m/account-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/gr2m/account-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/gr2m/account-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gr2m/account-rest-api/merges","archive_url":"https://api.github.com/repos/gr2m/account-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gr2m/account-rest-api/downloads","issues_url":"https://api.github.com/repos/gr2m/account-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/gr2m/account-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/gr2m/account-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/gr2m/account-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gr2m/account-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/gr2m/account-rest-api/releases{/id}","created_at":"2015-07-15T21:46:40Z","updated_at":"2015-07-16T20:05:27Z","pushed_at":"2015-10-30T17:20:41Z","git_url":"git://github.com/gr2m/account-rest-api.git","ssh_url":"git@github.com:gr2m/account-rest-api.git","clone_url":"https://github.com/gr2m/account-rest-api.git","svn_url":"https://github.com/gr2m/account-rest-api","homepage":"http://docs.accountrestapi.apiary.io","size":197,"stargazers_count":1,"watchers_count":1,"language":"API Blueprint","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4"},"html":{"href":"https://github.com/gr2m/account-rest-api/pull/4"},"issue":{"href":"https://api.github.com/repos/gr2m/account-rest-api/issues/4"},"comments":{"href":"https://api.github.com/repos/gr2m/account-rest-api/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gr2m/account-rest-api/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/gr2m/account-rest-api/statuses/10a8682aa8d1434ef6c70ff86603e7d327a4f620"}}}}