{"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88","id":28033497,"html_url":"https://github.com/zfcampus/zf-hal/pull/88","diff_url":"https://github.com/zfcampus/zf-hal/pull/88.diff","patch_url":"https://github.com/zfcampus/zf-hal/pull/88.patch","issue_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/88","number":88,"state":"closed","locked":false,"title":"Fix #66: circular entity references","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"body":"This PR is a follow up of #66 and #67 \r\n\r\nThe `max_depth` param introduced now follows this semantic:\r\n\r\nBy default this value is `null`. Any circular reference between entities will now end up in a `ZF\\Hal\\Exception\\CircularReferenceException` being thrown, rather than a nasty infinite loop.\r\n\r\nWhen `max_depth` is set and the value is reached, one last iteration of embedded entities is rendered, but only consisting of self links, no data is actually rendered. This means that a value of `0` is actually different from setting `render_embedded_entities` to `false` in the `renderer` configuration key of the plugin, because it will render the links of the embedded entities in the first level.","created_at":"2015-01-26T15:19:12Z","updated_at":"2015-02-16T13:56:31Z","closed_at":"2015-02-16T13:56:31Z","merged_at":"2015-02-16T13:56:31Z","merge_commit_sha":"600bd078ac07200a2fb7d76dc34f7d72e47278f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88/commits","review_comments_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88/comments","review_comment_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/88/comments","statuses_url":"https://api.github.com/repos/zfcampus/zf-hal/statuses/57980316543edfa329d7b1d65106fb73988c60ad","head":{"label":"stefanotorresi:fix-66-rendering-max-depth","ref":"fix-66-rendering-max-depth","sha":"57980316543edfa329d7b1d65106fb73988c60ad","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"repo":{"id":29698288,"name":"zf-hal","full_name":"stefanotorresi/zf-hal","owner":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanotorresi/zf-hal","description":null,"fork":true,"url":"https://api.github.com/repos/stefanotorresi/zf-hal","forks_url":"https://api.github.com/repos/stefanotorresi/zf-hal/forks","keys_url":"https://api.github.com/repos/stefanotorresi/zf-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanotorresi/zf-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanotorresi/zf-hal/teams","hooks_url":"https://api.github.com/repos/stefanotorresi/zf-hal/hooks","issue_events_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues/events{/number}","events_url":"https://api.github.com/repos/stefanotorresi/zf-hal/events","assignees_url":"https://api.github.com/repos/stefanotorresi/zf-hal/assignees{/user}","branches_url":"https://api.github.com/repos/stefanotorresi/zf-hal/branches{/branch}","tags_url":"https://api.github.com/repos/stefanotorresi/zf-hal/tags","blobs_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanotorresi/zf-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanotorresi/zf-hal/languages","stargazers_url":"https://api.github.com/repos/stefanotorresi/zf-hal/stargazers","contributors_url":"https://api.github.com/repos/stefanotorresi/zf-hal/contributors","subscribers_url":"https://api.github.com/repos/stefanotorresi/zf-hal/subscribers","subscription_url":"https://api.github.com/repos/stefanotorresi/zf-hal/subscription","commits_url":"https://api.github.com/repos/stefanotorresi/zf-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanotorresi/zf-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanotorresi/zf-hal/contents/{+path}","compare_url":"https://api.github.com/repos/stefanotorresi/zf-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanotorresi/zf-hal/merges","archive_url":"https://api.github.com/repos/stefanotorresi/zf-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanotorresi/zf-hal/downloads","issues_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues{/number}","pulls_url":"https://api.github.com/repos/stefanotorresi/zf-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanotorresi/zf-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanotorresi/zf-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanotorresi/zf-hal/labels{/name}","releases_url":"https://api.github.com/repos/stefanotorresi/zf-hal/releases{/id}","created_at":"2015-01-22T20:22:40Z","updated_at":"2015-01-23T14:02:05Z","pushed_at":"2015-02-05T15:17:17Z","git_url":"git://github.com/stefanotorresi/zf-hal.git","ssh_url":"git@github.com:stefanotorresi/zf-hal.git","clone_url":"https://github.com/stefanotorresi/zf-hal.git","svn_url":"https://github.com/stefanotorresi/zf-hal","homepage":null,"size":1865,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfcampus:master","ref":"master","sha":"9eb87387f3fd44af2024989abf13539b1f9afd8a","user":{"login":"zfcampus","id":5454933,"avatar_url":"https://avatars.githubusercontent.com/u/5454933?v=3","gravatar_id":"","url":"https://api.github.com/users/zfcampus","html_url":"https://github.com/zfcampus","followers_url":"https://api.github.com/users/zfcampus/followers","following_url":"https://api.github.com/users/zfcampus/following{/other_user}","gists_url":"https://api.github.com/users/zfcampus/gists{/gist_id}","starred_url":"https://api.github.com/users/zfcampus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfcampus/subscriptions","organizations_url":"https://api.github.com/users/zfcampus/orgs","repos_url":"https://api.github.com/users/zfcampus/repos","events_url":"https://api.github.com/users/zfcampus/events{/privacy}","received_events_url":"https://api.github.com/users/zfcampus/received_events","type":"Organization","site_admin":false},"repo":{"id":12139719,"name":"zf-hal","full_name":"zfcampus/zf-hal","owner":{"login":"zfcampus","id":5454933,"avatar_url":"https://avatars.githubusercontent.com/u/5454933?v=3","gravatar_id":"","url":"https://api.github.com/users/zfcampus","html_url":"https://github.com/zfcampus","followers_url":"https://api.github.com/users/zfcampus/followers","following_url":"https://api.github.com/users/zfcampus/following{/other_user}","gists_url":"https://api.github.com/users/zfcampus/gists{/gist_id}","starred_url":"https://api.github.com/users/zfcampus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfcampus/subscriptions","organizations_url":"https://api.github.com/users/zfcampus/orgs","repos_url":"https://api.github.com/users/zfcampus/repos","events_url":"https://api.github.com/users/zfcampus/events{/privacy}","received_events_url":"https://api.github.com/users/zfcampus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfcampus/zf-hal","description":null,"fork":false,"url":"https://api.github.com/repos/zfcampus/zf-hal","forks_url":"https://api.github.com/repos/zfcampus/zf-hal/forks","keys_url":"https://api.github.com/repos/zfcampus/zf-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfcampus/zf-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfcampus/zf-hal/teams","hooks_url":"https://api.github.com/repos/zfcampus/zf-hal/hooks","issue_events_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/events{/number}","events_url":"https://api.github.com/repos/zfcampus/zf-hal/events","assignees_url":"https://api.github.com/repos/zfcampus/zf-hal/assignees{/user}","branches_url":"https://api.github.com/repos/zfcampus/zf-hal/branches{/branch}","tags_url":"https://api.github.com/repos/zfcampus/zf-hal/tags","blobs_url":"https://api.github.com/repos/zfcampus/zf-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfcampus/zf-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfcampus/zf-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfcampus/zf-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfcampus/zf-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/zfcampus/zf-hal/languages","stargazers_url":"https://api.github.com/repos/zfcampus/zf-hal/stargazers","contributors_url":"https://api.github.com/repos/zfcampus/zf-hal/contributors","subscribers_url":"https://api.github.com/repos/zfcampus/zf-hal/subscribers","subscription_url":"https://api.github.com/repos/zfcampus/zf-hal/subscription","commits_url":"https://api.github.com/repos/zfcampus/zf-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfcampus/zf-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfcampus/zf-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/comments/{number}","contents_url":"https://api.github.com/repos/zfcampus/zf-hal/contents/{+path}","compare_url":"https://api.github.com/repos/zfcampus/zf-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfcampus/zf-hal/merges","archive_url":"https://api.github.com/repos/zfcampus/zf-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfcampus/zf-hal/downloads","issues_url":"https://api.github.com/repos/zfcampus/zf-hal/issues{/number}","pulls_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/zfcampus/zf-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/zfcampus/zf-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfcampus/zf-hal/labels{/name}","releases_url":"https://api.github.com/repos/zfcampus/zf-hal/releases{/id}","created_at":"2013-08-15T17:40:49Z","updated_at":"2015-01-22T21:16:12Z","pushed_at":"2015-02-16T13:56:31Z","git_url":"git://github.com/zfcampus/zf-hal.git","ssh_url":"git@github.com:zfcampus/zf-hal.git","clone_url":"https://github.com/zfcampus/zf-hal.git","svn_url":"https://github.com/zfcampus/zf-hal","homepage":null,"size":2848,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":8,"forks":36,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88"},"html":{"href":"https://github.com/zfcampus/zf-hal/pull/88"},"issue":{"href":"https://api.github.com/repos/zfcampus/zf-hal/issues/88"},"comments":{"href":"https://api.github.com/repos/zfcampus/zf-hal/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/zfcampus/zf-hal/statuses/57980316543edfa329d7b1d65106fb73988c60ad"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ezimuel","id":475967,"avatar_url":"https://avatars.githubusercontent.com/u/475967?v=3","gravatar_id":"","url":"https://api.github.com/users/ezimuel","html_url":"https://github.com/ezimuel","followers_url":"https://api.github.com/users/ezimuel/followers","following_url":"https://api.github.com/users/ezimuel/following{/other_user}","gists_url":"https://api.github.com/users/ezimuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimuel/subscriptions","organizations_url":"https://api.github.com/users/ezimuel/orgs","repos_url":"https://api.github.com/users/ezimuel/repos","events_url":"https://api.github.com/users/ezimuel/events{/privacy}","received_events_url":"https://api.github.com/users/ezimuel/received_events","type":"User","site_admin":false},"comments":5,"review_comments":1,"commits":32,"additions":566,"deletions":29,"changed_files":7}}