{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/23920796","id":23920796,"diff_hunk":"@@ -310,14 +339,28 @@ describe('inplaceEditor Directive', function() {\n             it('should switch to read view', function() {\n               expect(elementScope.isEditing).to.eq(false);\n             });\n+            it('should propagate changes to all editor including self', function() {\n+              dispatchChangesSpy.should.have.been.calledWith(elementScope.entity);\n+              acceptChangesSpy.should.have.been.calledWith(elementScope.entity);\n+            });\n           });\n           describe('onFail', function() {\n+            var dispatchErrorsSpy;\n             beforeEach(function() {\n+              dispatchErrorsSpy = sinon.spy(OverviewTabInplaceEditorConfig, 'dispatchErrors');\n               elementScope.startEditing();\n-              elementScope.onFail({\n-                status: 500,\n-                statusText: 'Nope'\n+              sinon.stub(WorkPackageService, 'updateWorkPackage', function() {\n+                return {\n+                  then: angular.noop,\n+                  catch: function(cb) {\n+                    cb({\n+                      status: 500,\n+                      statusText: 'Nope'\n+                    })","path":"frontend/tests/unit/tests/work_packages/directives/inplace-editor-directive-test.js","position":91,"original_position":91,"commit_id":"8abee6a3701f98ef276b929d59e8ed180b854d99","original_commit_id":"8abee6a3701f98ef276b929d59e8ed180b854d99","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2015-02-02T12:13:15Z","updated_at":"2015-02-02T12:13:15Z","html_url":"https://github.com/opf/openproject/pull/2478#discussion_r23920796","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/2478","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/23920796"},"html":{"href":"https://github.com/opf/openproject/pull/2478#discussion_r23920796"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/2478"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2478","id":28463617,"html_url":"https://github.com/opf/openproject/pull/2478","diff_url":"https://github.com/opf/openproject/pull/2478.diff","patch_url":"https://github.com/opf/openproject/pull/2478.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/2478","number":2478,"state":"open","locked":false,"title":"inplace editor multiple values preparement","user":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"body":"[``* `#18249` inplace editor multiple values preparement``](http://community.openproject.org/work_packages/18249)","created_at":"2015-02-02T12:13:08Z","updated_at":"2015-02-02T12:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56253fcb5f03d505cf5aeca314fd354f41bb7a6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/2478/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/2478/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2478/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/8abee6a3701f98ef276b929d59e8ed180b854d99","head":{"label":"0xF013:feature/18249-inplace-editor-multiple-values-preparement","ref":"feature/18249-inplace-editor-multiple-values-preparement","sha":"8abee6a3701f98ef276b929d59e8ed180b854d99","user":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"repo":{"id":23571676,"name":"openproject","full_name":"0xF013/openproject","owner":{"login":"0xF013","id":1038822,"avatar_url":"https://avatars.githubusercontent.com/u/1038822?v=3","gravatar_id":"","url":"https://api.github.com/users/0xF013","html_url":"https://github.com/0xF013","followers_url":"https://api.github.com/users/0xF013/followers","following_url":"https://api.github.com/users/0xF013/following{/other_user}","gists_url":"https://api.github.com/users/0xF013/gists{/gist_id}","starred_url":"https://api.github.com/users/0xF013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xF013/subscriptions","organizations_url":"https://api.github.com/users/0xF013/orgs","repos_url":"https://api.github.com/users/0xF013/repos","events_url":"https://api.github.com/users/0xF013/events{/privacy}","received_events_url":"https://api.github.com/users/0xF013/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xF013/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/0xF013/openproject","forks_url":"https://api.github.com/repos/0xF013/openproject/forks","keys_url":"https://api.github.com/repos/0xF013/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xF013/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xF013/openproject/teams","hooks_url":"https://api.github.com/repos/0xF013/openproject/hooks","issue_events_url":"https://api.github.com/repos/0xF013/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/0xF013/openproject/events","assignees_url":"https://api.github.com/repos/0xF013/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/0xF013/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/0xF013/openproject/tags","blobs_url":"https://api.github.com/repos/0xF013/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xF013/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xF013/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xF013/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xF013/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/0xF013/openproject/languages","stargazers_url":"https://api.github.com/repos/0xF013/openproject/stargazers","contributors_url":"https://api.github.com/repos/0xF013/openproject/contributors","subscribers_url":"https://api.github.com/repos/0xF013/openproject/subscribers","subscription_url":"https://api.github.com/repos/0xF013/openproject/subscription","commits_url":"https://api.github.com/repos/0xF013/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xF013/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xF013/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xF013/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/0xF013/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/0xF013/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xF013/openproject/merges","archive_url":"https://api.github.com/repos/0xF013/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xF013/openproject/downloads","issues_url":"https://api.github.com/repos/0xF013/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/0xF013/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/0xF013/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/0xF013/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xF013/openproject/labels{/name}","releases_url":"https://api.github.com/repos/0xF013/openproject/releases{/id}","created_at":"2014-09-02T08:53:59Z","updated_at":"2014-12-04T19:50:30Z","pushed_at":"2015-02-02T12:12:12Z","git_url":"git://github.com/0xF013/openproject.git","ssh_url":"git@github.com:0xF013/openproject.git","clone_url":"https://github.com/0xF013/openproject.git","svn_url":"https://github.com/0xF013/openproject","homepage":"https://www.openproject.org","size":63555,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"feature/15173-subprojects-are-not-copied-correctly"}},"base":{"label":"opf:dev","ref":"dev","sha":"0f649897a5b259fc000f72714a0d46b0104a518a","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-02-02T10:17:11Z","pushed_at":"2015-02-02T12:07:03Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":162635,"stargazers_count":488,"watchers_count":488,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":58,"forks":219,"open_issues":58,"watchers":488,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/2478"},"html":{"href":"https://github.com/opf/openproject/pull/2478"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/2478"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/2478/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/2478/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/2478/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/8abee6a3701f98ef276b929d59e8ed180b854d99"}}}}