{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/imminence/issues/114","labels_url":"https://api.github.com/repos/alphagov/imminence/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/imminence/issues/114/comments","events_url":"https://api.github.com/repos/alphagov/imminence/issues/114/events","html_url":"https://github.com/alphagov/imminence/pull/114","id":111598011,"number":114,"title":"Setup ci-reporter for jenkins correctly","user":{"login":"h-lame","id":608,"avatar_url":"https://avatars.githubusercontent.com/u/608?v=3","gravatar_id":"","url":"https://api.github.com/users/h-lame","html_url":"https://github.com/h-lame","followers_url":"https://api.github.com/users/h-lame/followers","following_url":"https://api.github.com/users/h-lame/following{/other_user}","gists_url":"https://api.github.com/users/h-lame/gists{/gist_id}","starred_url":"https://api.github.com/users/h-lame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-lame/subscriptions","organizations_url":"https://api.github.com/users/h-lame/orgs","repos_url":"https://api.github.com/users/h-lame/repos","events_url":"https://api.github.com/users/h-lame/events{/privacy}","received_events_url":"https://api.github.com/users/h-lame/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-15T11:30:26Z","updated_at":"2015-10-15T11:35:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/imminence/pulls/114","html_url":"https://github.com/alphagov/imminence/pull/114","diff_url":"https://github.com/alphagov/imminence/pull/114.diff","patch_url":"https://github.com/alphagov/imminence/pull/114.patch"},"body":"Now that we have to include testunit and minitest the app seems to think it's\r\nusing testunit not minitest so the ci:setup:minitest task doesn't end up\r\ngenerating the report files.  This means that our build won't pass as a lack of\r\nreports is a considered a failure by ci.\r\n\r\nWe also add the ci:setup:cucumber step so that we get reports from the features.\r\nThis requires a change to the ci build to look at, but it doesn't hurt.\r\n\r\nOnce we're on rails 4.x we can review again which framework we are using for tests; minitest vs. test-unit and only invoke one of the setup tasks."},"comment":{"url":"https://api.github.com/repos/alphagov/imminence/issues/comments/148360967","html_url":"https://github.com/alphagov/imminence/pull/114#issuecomment-148360967","issue_url":"https://api.github.com/repos/alphagov/imminence/issues/114","id":148360967,"user":{"login":"h-lame","id":608,"avatar_url":"https://avatars.githubusercontent.com/u/608?v=3","gravatar_id":"","url":"https://api.github.com/users/h-lame","html_url":"https://github.com/h-lame","followers_url":"https://api.github.com/users/h-lame/followers","following_url":"https://api.github.com/users/h-lame/following{/other_user}","gists_url":"https://api.github.com/users/h-lame/gists{/gist_id}","starred_url":"https://api.github.com/users/h-lame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-lame/subscriptions","organizations_url":"https://api.github.com/users/h-lame/orgs","repos_url":"https://api.github.com/users/h-lame/repos","events_url":"https://api.github.com/users/h-lame/events{/privacy}","received_events_url":"https://api.github.com/users/h-lame/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T11:35:17Z","updated_at":"2015-10-15T11:35:17Z","body":"This is to address the failure on ci when merging #113 (see: https://ci-new.alphagov.co.uk/job/govuk_imminence/279/) - we've also applied the config changes to make govuk_imminence_branches look for junit report files and fail the build if they're not present, so passing branches don't result in failed master because of it."}}