{"action":"created","comment":{"url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/comments/34190530","id":34190530,"diff_hunk":"@@ -142,12 +153,14 @@ public string RecoveryMode\n             set\r\n             {\r\n                 RecoveryMode result;\r\n-                if (!Enum.TryParse(value, true, out result))\r\n+                if (Enum.TryParse(value, true, out result))\r\n                 {\r\n-                    throw new ArgumentOutOfRangeException(\"value\", value, \"The value of 'RecoveryMode' must be one of these values: 'NoChange', 'Simple' or 'Full'.\");\r\n+                    this.recoveryMode = result;\r\n+                }\r\n+                else\r\n+                {\r\n+                    this.loggingHelper.LogError(\"The value of 'RecoveryMode' must be one of these values: 'NoChange', 'Simple' or 'Full'. Actual value was '{0}'.\", value);\r","path":"product/roundhouse.tasks/Roundhouse.cs","position":60,"original_position":60,"commit_id":"5341a90a310a38341be59bc162387014e6bf3640","original_commit_id":"5341a90a310a38341be59bc162387014e6bf3640","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"We should already be using an MSBuild Logger - so just logging the error should work - https://github.com/chucknorris/roundhouse/blob/master/product/roundhouse/infrastructure/logging/custom/MSBuildLogger.cs","created_at":"2015-07-08T19:49:45Z","updated_at":"2015-07-08T19:49:45Z","html_url":"https://github.com/chucknorris/roundhouse/pull/200#discussion_r34190530","pull_request_url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/comments/34190530"},"html":{"href":"https://github.com/chucknorris/roundhouse/pull/200#discussion_r34190530"},"pull_request":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200","id":39475550,"html_url":"https://github.com/chucknorris/roundhouse/pull/200","diff_url":"https://github.com/chucknorris/roundhouse/pull/200.diff","patch_url":"https://github.com/chucknorris/roundhouse/pull/200.patch","issue_url":"https://api.github.com/repos/chucknorris/roundhouse/issues/200","number":200,"state":"open","locked":false,"title":"Improve MSBuild error handling for 'RecoveryMode'","user":{"login":"StevenLiekens","id":1583241,"avatar_url":"https://avatars.githubusercontent.com/u/1583241?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenLiekens","html_url":"https://github.com/StevenLiekens","followers_url":"https://api.github.com/users/StevenLiekens/followers","following_url":"https://api.github.com/users/StevenLiekens/following{/other_user}","gists_url":"https://api.github.com/users/StevenLiekens/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenLiekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenLiekens/subscriptions","organizations_url":"https://api.github.com/users/StevenLiekens/orgs","repos_url":"https://api.github.com/users/StevenLiekens/repos","events_url":"https://api.github.com/users/StevenLiekens/events{/privacy}","received_events_url":"https://api.github.com/users/StevenLiekens/received_events","type":"User","site_admin":false},"body":"This PR adds a reference to Microsoft.Build.Utilities.v4.0 for its `TaskLoggingHelper` class.\r\n\r\nCode that previously threw `ArgumentOutOfRangeException` now instead log an MSBuild error.\r\n\r\nMSBuild errors that were logged using the `TaskLoggingHelper` now cause the Roundhouse task to exit early and crash the build script (unless `ContinueOnError=true`).","created_at":"2015-07-08T13:17:14Z","updated_at":"2015-07-08T19:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64b4575e20c7dc43d92c6543bd6c9cfb9e1abb66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200/commits","review_comments_url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200/comments","review_comment_url":"https://api.github.com/repos/chucknorris/roundhouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chucknorris/roundhouse/issues/200/comments","statuses_url":"https://api.github.com/repos/chucknorris/roundhouse/statuses/5341a90a310a38341be59bc162387014e6bf3640","head":{"label":"StevenLiekens:taskRecoveryModes","ref":"taskRecoveryModes","sha":"5341a90a310a38341be59bc162387014e6bf3640","user":{"login":"StevenLiekens","id":1583241,"avatar_url":"https://avatars.githubusercontent.com/u/1583241?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenLiekens","html_url":"https://github.com/StevenLiekens","followers_url":"https://api.github.com/users/StevenLiekens/followers","following_url":"https://api.github.com/users/StevenLiekens/following{/other_user}","gists_url":"https://api.github.com/users/StevenLiekens/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenLiekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenLiekens/subscriptions","organizations_url":"https://api.github.com/users/StevenLiekens/orgs","repos_url":"https://api.github.com/users/StevenLiekens/repos","events_url":"https://api.github.com/users/StevenLiekens/events{/privacy}","received_events_url":"https://api.github.com/users/StevenLiekens/received_events","type":"User","site_admin":false},"repo":{"id":38621663,"name":"roundhouse","full_name":"StevenLiekens/roundhouse","owner":{"login":"StevenLiekens","id":1583241,"avatar_url":"https://avatars.githubusercontent.com/u/1583241?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenLiekens","html_url":"https://github.com/StevenLiekens","followers_url":"https://api.github.com/users/StevenLiekens/followers","following_url":"https://api.github.com/users/StevenLiekens/following{/other_user}","gists_url":"https://api.github.com/users/StevenLiekens/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenLiekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenLiekens/subscriptions","organizations_url":"https://api.github.com/users/StevenLiekens/orgs","repos_url":"https://api.github.com/users/StevenLiekens/repos","events_url":"https://api.github.com/users/StevenLiekens/events{/privacy}","received_events_url":"https://api.github.com/users/StevenLiekens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StevenLiekens/roundhouse","description":"RoundhousE is a Database Migration Utility for .NET using sql files and versioning based on source control","fork":true,"url":"https://api.github.com/repos/StevenLiekens/roundhouse","forks_url":"https://api.github.com/repos/StevenLiekens/roundhouse/forks","keys_url":"https://api.github.com/repos/StevenLiekens/roundhouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StevenLiekens/roundhouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StevenLiekens/roundhouse/teams","hooks_url":"https://api.github.com/repos/StevenLiekens/roundhouse/hooks","issue_events_url":"https://api.github.com/repos/StevenLiekens/roundhouse/issues/events{/number}","events_url":"https://api.github.com/repos/StevenLiekens/roundhouse/events","assignees_url":"https://api.github.com/repos/StevenLiekens/roundhouse/assignees{/user}","branches_url":"https://api.github.com/repos/StevenLiekens/roundhouse/branches{/branch}","tags_url":"https://api.github.com/repos/StevenLiekens/roundhouse/tags","blobs_url":"https://api.github.com/repos/StevenLiekens/roundhouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StevenLiekens/roundhouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StevenLiekens/roundhouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/StevenLiekens/roundhouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StevenLiekens/roundhouse/statuses/{sha}","languages_url":"https://api.github.com/repos/StevenLiekens/roundhouse/languages","stargazers_url":"https://api.github.com/repos/StevenLiekens/roundhouse/stargazers","contributors_url":"https://api.github.com/repos/StevenLiekens/roundhouse/contributors","subscribers_url":"https://api.github.com/repos/StevenLiekens/roundhouse/subscribers","subscription_url":"https://api.github.com/repos/StevenLiekens/roundhouse/subscription","commits_url":"https://api.github.com/repos/StevenLiekens/roundhouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/StevenLiekens/roundhouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/StevenLiekens/roundhouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/StevenLiekens/roundhouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/StevenLiekens/roundhouse/contents/{+path}","compare_url":"https://api.github.com/repos/StevenLiekens/roundhouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StevenLiekens/roundhouse/merges","archive_url":"https://api.github.com/repos/StevenLiekens/roundhouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StevenLiekens/roundhouse/downloads","issues_url":"https://api.github.com/repos/StevenLiekens/roundhouse/issues{/number}","pulls_url":"https://api.github.com/repos/StevenLiekens/roundhouse/pulls{/number}","milestones_url":"https://api.github.com/repos/StevenLiekens/roundhouse/milestones{/number}","notifications_url":"https://api.github.com/repos/StevenLiekens/roundhouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StevenLiekens/roundhouse/labels{/name}","releases_url":"https://api.github.com/repos/StevenLiekens/roundhouse/releases{/id}","created_at":"2015-07-06T13:47:22Z","updated_at":"2015-07-06T13:47:24Z","pushed_at":"2015-07-08T13:09:52Z","git_url":"git://github.com/StevenLiekens/roundhouse.git","ssh_url":"git@github.com:StevenLiekens/roundhouse.git","clone_url":"https://github.com/StevenLiekens/roundhouse.git","svn_url":"https://github.com/StevenLiekens/roundhouse","homepage":"http://projectroundhouse.org","size":77112,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chucknorris:master","ref":"master","sha":"3705b951307d37aae479a656f8b798ceb28d3f15","user":{"login":"chucknorris","id":150006,"avatar_url":"https://avatars.githubusercontent.com/u/150006?v=3","gravatar_id":"","url":"https://api.github.com/users/chucknorris","html_url":"https://github.com/chucknorris","followers_url":"https://api.github.com/users/chucknorris/followers","following_url":"https://api.github.com/users/chucknorris/following{/other_user}","gists_url":"https://api.github.com/users/chucknorris/gists{/gist_id}","starred_url":"https://api.github.com/users/chucknorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chucknorris/subscriptions","organizations_url":"https://api.github.com/users/chucknorris/orgs","repos_url":"https://api.github.com/users/chucknorris/repos","events_url":"https://api.github.com/users/chucknorris/events{/privacy}","received_events_url":"https://api.github.com/users/chucknorris/received_events","type":"Organization","site_admin":false},"repo":{"id":369782,"name":"roundhouse","full_name":"chucknorris/roundhouse","owner":{"login":"chucknorris","id":150006,"avatar_url":"https://avatars.githubusercontent.com/u/150006?v=3","gravatar_id":"","url":"https://api.github.com/users/chucknorris","html_url":"https://github.com/chucknorris","followers_url":"https://api.github.com/users/chucknorris/followers","following_url":"https://api.github.com/users/chucknorris/following{/other_user}","gists_url":"https://api.github.com/users/chucknorris/gists{/gist_id}","starred_url":"https://api.github.com/users/chucknorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chucknorris/subscriptions","organizations_url":"https://api.github.com/users/chucknorris/orgs","repos_url":"https://api.github.com/users/chucknorris/repos","events_url":"https://api.github.com/users/chucknorris/events{/privacy}","received_events_url":"https://api.github.com/users/chucknorris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chucknorris/roundhouse","description":"RoundhousE is a Database Migration Utility for .NET using sql files and versioning based on source control","fork":false,"url":"https://api.github.com/repos/chucknorris/roundhouse","forks_url":"https://api.github.com/repos/chucknorris/roundhouse/forks","keys_url":"https://api.github.com/repos/chucknorris/roundhouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chucknorris/roundhouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chucknorris/roundhouse/teams","hooks_url":"https://api.github.com/repos/chucknorris/roundhouse/hooks","issue_events_url":"https://api.github.com/repos/chucknorris/roundhouse/issues/events{/number}","events_url":"https://api.github.com/repos/chucknorris/roundhouse/events","assignees_url":"https://api.github.com/repos/chucknorris/roundhouse/assignees{/user}","branches_url":"https://api.github.com/repos/chucknorris/roundhouse/branches{/branch}","tags_url":"https://api.github.com/repos/chucknorris/roundhouse/tags","blobs_url":"https://api.github.com/repos/chucknorris/roundhouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chucknorris/roundhouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chucknorris/roundhouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/chucknorris/roundhouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chucknorris/roundhouse/statuses/{sha}","languages_url":"https://api.github.com/repos/chucknorris/roundhouse/languages","stargazers_url":"https://api.github.com/repos/chucknorris/roundhouse/stargazers","contributors_url":"https://api.github.com/repos/chucknorris/roundhouse/contributors","subscribers_url":"https://api.github.com/repos/chucknorris/roundhouse/subscribers","subscription_url":"https://api.github.com/repos/chucknorris/roundhouse/subscription","commits_url":"https://api.github.com/repos/chucknorris/roundhouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/chucknorris/roundhouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/chucknorris/roundhouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/chucknorris/roundhouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/chucknorris/roundhouse/contents/{+path}","compare_url":"https://api.github.com/repos/chucknorris/roundhouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chucknorris/roundhouse/merges","archive_url":"https://api.github.com/repos/chucknorris/roundhouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chucknorris/roundhouse/downloads","issues_url":"https://api.github.com/repos/chucknorris/roundhouse/issues{/number}","pulls_url":"https://api.github.com/repos/chucknorris/roundhouse/pulls{/number}","milestones_url":"https://api.github.com/repos/chucknorris/roundhouse/milestones{/number}","notifications_url":"https://api.github.com/repos/chucknorris/roundhouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chucknorris/roundhouse/labels{/name}","releases_url":"https://api.github.com/repos/chucknorris/roundhouse/releases{/id}","created_at":"2009-11-12T02:54:12Z","updated_at":"2015-07-03T02:45:04Z","pushed_at":"2015-07-08T13:17:14Z","git_url":"git://github.com/chucknorris/roundhouse.git","ssh_url":"git@github.com:chucknorris/roundhouse.git","clone_url":"https://github.com/chucknorris/roundhouse.git","svn_url":"https://github.com/chucknorris/roundhouse","homepage":"http://projectroundhouse.org","size":77112,"stargazers_count":313,"watchers_count":313,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"open_issues_count":77,"forks":125,"open_issues":77,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200"},"html":{"href":"https://github.com/chucknorris/roundhouse/pull/200"},"issue":{"href":"https://api.github.com/repos/chucknorris/roundhouse/issues/200"},"comments":{"href":"https://api.github.com/repos/chucknorris/roundhouse/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chucknorris/roundhouse/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/chucknorris/roundhouse/statuses/5341a90a310a38341be59bc162387014e6bf3640"}}}}