{"action":"created","comment":{"url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/comments/39350145","id":39350145,"diff_hunk":"@@ -40,15 +40,14 @@ public class MainViewModel : BaseViewModel\n         public Color4 DirectionalLightColor { get; private set; }\r\n         public Color4 AmbientLightColor { get; private set; }\r\n \r\n-\r\n         public MainViewModel()\r\n         {\r\n             // titles\r\n-            this.Title = \"Simple Demo\";\r","path":"Source/Examples/WPF.SharpDX/SimpleDemo/MainViewModel.cs","position":8,"original_position":8,"commit_id":"c31bf068b726120211edea328e9519090d777a8f","original_commit_id":"c31bf068b726120211edea328e9519090d777a8f","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"Whenver I touch a file that has this many redundant uses of `this`, I remove them.","created_at":"2015-09-13T18:04:44Z","updated_at":"2015-09-13T18:04:44Z","html_url":"https://github.com/helix-toolkit/helix-toolkit/pull/209#discussion_r39350145","pull_request_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/comments/39350145"},"html":{"href":"https://github.com/helix-toolkit/helix-toolkit/pull/209#discussion_r39350145"},"pull_request":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209","id":44732419,"html_url":"https://github.com/helix-toolkit/helix-toolkit/pull/209","diff_url":"https://github.com/helix-toolkit/helix-toolkit/pull/209.diff","patch_url":"https://github.com/helix-toolkit/helix-toolkit/pull/209.patch","issue_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/209","number":209,"state":"open","locked":false,"title":"DO NOT MERGE (Work in Progres) : Effects Manager Refactoring","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"### IEffectsManager\r\n\r\nThe `EffectsManager` is currently a singleton. It creates a number of effects that are used for the Helix3D samples, but might not be needed or wanted by third party developers. This PR does the following:\r\n- We create the `IEffectsManager` interface. This interface is compatible with current usages of the `EffectsManager`, but allows for an implementation where third-parties can load whatever effects they like. \r\n- We remove the `EffectsManager` singleton and create a property, `IRenderHost.EffectsManager`. \r\n- All references to the singleton are re-pointed to the render host's `IEffectsManager` instance. \r\n- We create a `DependencyProperty`, `EffectsManager` on `DPFCanvas` so we can provide our own implementation of `EffectsManager`.\r\n\r\n### IRenderTechniquesManager\r\n\r\n`Techniques` is currently a static class which contains a list of `RenderTechniques`. This design does not allow for extensibility by third parties. So, I've done the following:\r\n\r\n- Created the `IRenderTechniqueManager` interface. This interface exposes a method for registering a render technique with the manager and a Dictionary of `RenderTechniques` keyed by their name.\r\n- Made `const string` fields for all `RenderTechnique` names so we didn't have these names as strings in the code.\r\n- Replaced all references to `Technique.Blah` with lookups in the `RenderTechniqueManager.RenderTechniques` dictionary.\r\n- Made a `DependencyProperty`, 'RenderTechniquesManager` on `DPFCanvas` so we can provide our own implementation of `IRenderTechniquesManager`.\r\n- Updated all demos so the `RenderTechniqueManager` is created in the view model.\r\n\r\n@objorke These changes will make it easy for third party developers to make their own techniques and effects.","created_at":"2015-09-10T23:38:34Z","updated_at":"2015-09-13T18:04:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"debfbf520b1671a36e3fa8ba618faa771662147f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209/commits","review_comments_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209/comments","review_comment_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/209/comments","statuses_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/statuses/c31bf068b726120211edea328e9519090d777a8f","head":{"label":"DynamoDS:EffectsManager","ref":"EffectsManager","sha":"c31bf068b726120211edea328e9519090d777a8f","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":26274430,"name":"helix-toolkit","full_name":"DynamoDS/helix-toolkit","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/helix-toolkit","description":"Dynamo's contribution fork for the Helix3D toolkit.","fork":true,"url":"https://api.github.com/repos/DynamoDS/helix-toolkit","forks_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/forks","keys_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/teams","hooks_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/events","assignees_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/tags","blobs_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/subscription","commits_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/merges","archive_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/downloads","issues_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/helix-toolkit/releases{/id}","created_at":"2014-11-06T14:49:55Z","updated_at":"2015-04-07T16:35:57Z","pushed_at":"2015-09-12T22:13:03Z","git_url":"git://github.com/DynamoDS/helix-toolkit.git","ssh_url":"git@github.com:DynamoDS/helix-toolkit.git","clone_url":"https://github.com/DynamoDS/helix-toolkit.git","svn_url":"https://github.com/DynamoDS/helix-toolkit","homepage":"","size":31420,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helix-toolkit:master","ref":"master","sha":"732d0747eac6c93f625963d5d26d868f50f8cc19","user":{"login":"helix-toolkit","id":8432523,"avatar_url":"https://avatars.githubusercontent.com/u/8432523?v=3","gravatar_id":"","url":"https://api.github.com/users/helix-toolkit","html_url":"https://github.com/helix-toolkit","followers_url":"https://api.github.com/users/helix-toolkit/followers","following_url":"https://api.github.com/users/helix-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/helix-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/helix-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helix-toolkit/subscriptions","organizations_url":"https://api.github.com/users/helix-toolkit/orgs","repos_url":"https://api.github.com/users/helix-toolkit/repos","events_url":"https://api.github.com/users/helix-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/helix-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":23380867,"name":"helix-toolkit","full_name":"helix-toolkit/helix-toolkit","owner":{"login":"helix-toolkit","id":8432523,"avatar_url":"https://avatars.githubusercontent.com/u/8432523?v=3","gravatar_id":"","url":"https://api.github.com/users/helix-toolkit","html_url":"https://github.com/helix-toolkit","followers_url":"https://api.github.com/users/helix-toolkit/followers","following_url":"https://api.github.com/users/helix-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/helix-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/helix-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helix-toolkit/subscriptions","organizations_url":"https://api.github.com/users/helix-toolkit/orgs","repos_url":"https://api.github.com/users/helix-toolkit/repos","events_url":"https://api.github.com/users/helix-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/helix-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helix-toolkit/helix-toolkit","description":"","fork":false,"url":"https://api.github.com/repos/helix-toolkit/helix-toolkit","forks_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/forks","keys_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/teams","hooks_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/hooks","issue_events_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/events","assignees_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/tags","blobs_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/languages","stargazers_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/stargazers","contributors_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/contributors","subscribers_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/subscribers","subscription_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/subscription","commits_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/merges","archive_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/downloads","issues_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/helix-toolkit/helix-toolkit/releases{/id}","created_at":"2014-08-27T07:28:47Z","updated_at":"2015-09-08T20:48:35Z","pushed_at":"2015-09-12T22:13:04Z","git_url":"git://github.com/helix-toolkit/helix-toolkit.git","ssh_url":"git@github.com:helix-toolkit/helix-toolkit.git","clone_url":"https://github.com/helix-toolkit/helix-toolkit.git","svn_url":"https://github.com/helix-toolkit/helix-toolkit","homepage":null,"size":32155,"stargazers_count":132,"watchers_count":132,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":89,"forks":83,"open_issues":89,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209"},"html":{"href":"https://github.com/helix-toolkit/helix-toolkit/pull/209"},"issue":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/209"},"comments":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/helix-toolkit/helix-toolkit/statuses/c31bf068b726120211edea328e9519090d777a8f"}}}}