{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3","id":39764371,"html_url":"https://github.com/Magnetme/mm-on-enter-viewport/pull/3","diff_url":"https://github.com/Magnetme/mm-on-enter-viewport/pull/3.diff","patch_url":"https://github.com/Magnetme/mm-on-enter-viewport/pull/3.patch","issue_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/3","number":3,"state":"closed","locked":false,"title":"Improvements","user":{"login":"TiddoLangerak","id":1759192,"avatar_url":"https://avatars.githubusercontent.com/u/1759192?v=3","gravatar_id":"","url":"https://api.github.com/users/TiddoLangerak","html_url":"https://github.com/TiddoLangerak","followers_url":"https://api.github.com/users/TiddoLangerak/followers","following_url":"https://api.github.com/users/TiddoLangerak/following{/other_user}","gists_url":"https://api.github.com/users/TiddoLangerak/gists{/gist_id}","starred_url":"https://api.github.com/users/TiddoLangerak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TiddoLangerak/subscriptions","organizations_url":"https://api.github.com/users/TiddoLangerak/orgs","repos_url":"https://api.github.com/users/TiddoLangerak/repos","events_url":"https://api.github.com/users/TiddoLangerak/events{/privacy}","received_events_url":"https://api.github.com/users/TiddoLangerak/received_events","type":"User","site_admin":false},"body":"This is based on #2. \r\n\r\nContains:\r\n- Update for a later generator project, which includes `jshint` and a `README.md` (as well as some other small changes)\r\n- Replaced weird value construct for settings with a provider, which is the usual way to configure angular modules.\r\n- Excluded one of the tests for PhantomJS since it can't test viewport-specific stuff (viewport is always entire page)\r\n- Improvements to detection of entering the viewport, mostly related to detecting when an element appears on page-load.\r\n- Support for a `trigger-once` option, which will only make the cb trigger once.\r\n\r\nI've already (publicly) published this v1.0.0 version such that it can be used in Magnet.me Any successive changes will result in a new release.","created_at":"2015-07-12T16:20:12Z","updated_at":"2015-07-13T09:52:37Z","closed_at":"2015-07-13T09:52:37Z","merged_at":"2015-07-13T09:52:37Z","merge_commit_sha":"6d3630ce2bb5a327090b38174005167a4f4db33d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/3/comments","statuses_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/statuses/2a8c79a9ccebba2738ac29607d7e7e67eae3ef49","head":{"label":"Magnetme:improvements","ref":"improvements","sha":"2a8c79a9ccebba2738ac29607d7e7e67eae3ef49","user":{"login":"Magnetme","id":3966050,"avatar_url":"https://avatars.githubusercontent.com/u/3966050?v=3","gravatar_id":"","url":"https://api.github.com/users/Magnetme","html_url":"https://github.com/Magnetme","followers_url":"https://api.github.com/users/Magnetme/followers","following_url":"https://api.github.com/users/Magnetme/following{/other_user}","gists_url":"https://api.github.com/users/Magnetme/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetme/subscriptions","organizations_url":"https://api.github.com/users/Magnetme/orgs","repos_url":"https://api.github.com/users/Magnetme/repos","events_url":"https://api.github.com/users/Magnetme/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetme/received_events","type":"Organization","site_admin":false},"repo":{"id":38621315,"name":"mm-on-enter-viewport","full_name":"Magnetme/mm-on-enter-viewport","owner":{"login":"Magnetme","id":3966050,"avatar_url":"https://avatars.githubusercontent.com/u/3966050?v=3","gravatar_id":"","url":"https://api.github.com/users/Magnetme","html_url":"https://github.com/Magnetme","followers_url":"https://api.github.com/users/Magnetme/followers","following_url":"https://api.github.com/users/Magnetme/following{/other_user}","gists_url":"https://api.github.com/users/Magnetme/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetme/subscriptions","organizations_url":"https://api.github.com/users/Magnetme/orgs","repos_url":"https://api.github.com/users/Magnetme/repos","events_url":"https://api.github.com/users/Magnetme/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Magnetme/mm-on-enter-viewport","description":"Angular Directive that detects if an element enters the viewport","fork":false,"url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport","forks_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/forks","keys_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/teams","hooks_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/hooks","issue_events_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/events{/number}","events_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/events","assignees_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/assignees{/user}","branches_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/branches{/branch}","tags_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/tags","blobs_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/statuses/{sha}","languages_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/languages","stargazers_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/stargazers","contributors_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/contributors","subscribers_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/subscribers","subscription_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/subscription","commits_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/contents/{+path}","compare_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/merges","archive_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/downloads","issues_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues{/number}","pulls_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls{/number}","milestones_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/milestones{/number}","notifications_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/labels{/name}","releases_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/releases{/id}","created_at":"2015-07-06T13:40:57Z","updated_at":"2015-07-09T07:21:47Z","pushed_at":"2015-07-13T09:52:37Z","git_url":"git://github.com/Magnetme/mm-on-enter-viewport.git","ssh_url":"git@github.com:Magnetme/mm-on-enter-viewport.git","clone_url":"https://github.com/Magnetme/mm-on-enter-viewport.git","svn_url":"https://github.com/Magnetme/mm-on-enter-viewport","homepage":"https://magnet.me","size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Magnetme:master","ref":"master","sha":"ddc3fcd81a9249fdcb8be9d09840e0ca5b950610","user":{"login":"Magnetme","id":3966050,"avatar_url":"https://avatars.githubusercontent.com/u/3966050?v=3","gravatar_id":"","url":"https://api.github.com/users/Magnetme","html_url":"https://github.com/Magnetme","followers_url":"https://api.github.com/users/Magnetme/followers","following_url":"https://api.github.com/users/Magnetme/following{/other_user}","gists_url":"https://api.github.com/users/Magnetme/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetme/subscriptions","organizations_url":"https://api.github.com/users/Magnetme/orgs","repos_url":"https://api.github.com/users/Magnetme/repos","events_url":"https://api.github.com/users/Magnetme/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetme/received_events","type":"Organization","site_admin":false},"repo":{"id":38621315,"name":"mm-on-enter-viewport","full_name":"Magnetme/mm-on-enter-viewport","owner":{"login":"Magnetme","id":3966050,"avatar_url":"https://avatars.githubusercontent.com/u/3966050?v=3","gravatar_id":"","url":"https://api.github.com/users/Magnetme","html_url":"https://github.com/Magnetme","followers_url":"https://api.github.com/users/Magnetme/followers","following_url":"https://api.github.com/users/Magnetme/following{/other_user}","gists_url":"https://api.github.com/users/Magnetme/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetme/subscriptions","organizations_url":"https://api.github.com/users/Magnetme/orgs","repos_url":"https://api.github.com/users/Magnetme/repos","events_url":"https://api.github.com/users/Magnetme/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Magnetme/mm-on-enter-viewport","description":"Angular Directive that detects if an element enters the viewport","fork":false,"url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport","forks_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/forks","keys_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/teams","hooks_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/hooks","issue_events_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/events{/number}","events_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/events","assignees_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/assignees{/user}","branches_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/branches{/branch}","tags_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/tags","blobs_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/statuses/{sha}","languages_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/languages","stargazers_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/stargazers","contributors_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/contributors","subscribers_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/subscribers","subscription_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/subscription","commits_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/contents/{+path}","compare_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/merges","archive_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/downloads","issues_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues{/number}","pulls_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls{/number}","milestones_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/milestones{/number}","notifications_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/labels{/name}","releases_url":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/releases{/id}","created_at":"2015-07-06T13:40:57Z","updated_at":"2015-07-09T07:21:47Z","pushed_at":"2015-07-13T09:52:37Z","git_url":"git://github.com/Magnetme/mm-on-enter-viewport.git","ssh_url":"git@github.com:Magnetme/mm-on-enter-viewport.git","clone_url":"https://github.com/Magnetme/mm-on-enter-viewport.git","svn_url":"https://github.com/Magnetme/mm-on-enter-viewport","homepage":"https://magnet.me","size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3"},"html":{"href":"https://github.com/Magnetme/mm-on-enter-viewport/pull/3"},"issue":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/3"},"comments":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Magnetme/mm-on-enter-viewport/statuses/2a8c79a9ccebba2738ac29607d7e7e67eae3ef49"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexnederlof","id":992615,"avatar_url":"https://avatars.githubusercontent.com/u/992615?v=3","gravatar_id":"","url":"https://api.github.com/users/alexnederlof","html_url":"https://github.com/alexnederlof","followers_url":"https://api.github.com/users/alexnederlof/followers","following_url":"https://api.github.com/users/alexnederlof/following{/other_user}","gists_url":"https://api.github.com/users/alexnederlof/gists{/gist_id}","starred_url":"https://api.github.com/users/alexnederlof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexnederlof/subscriptions","organizations_url":"https://api.github.com/users/alexnederlof/orgs","repos_url":"https://api.github.com/users/alexnederlof/repos","events_url":"https://api.github.com/users/alexnederlof/events{/privacy}","received_events_url":"https://api.github.com/users/alexnederlof/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":6,"additions":145,"deletions":57,"changed_files":12}}