{"action":"created","issue":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/249","labels_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/249/comments","events_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/249/events","html_url":"https://github.com/gjtorikian/html-proofer/pull/249","id":109710595,"number":249,"title":"Cache external URL results","user":{"login":"gjtorikian","id":64050,"avatar_url":"https://avatars.githubusercontent.com/u/64050?v=3","gravatar_id":"","url":"https://api.github.com/users/gjtorikian","html_url":"https://github.com/gjtorikian","followers_url":"https://api.github.com/users/gjtorikian/followers","following_url":"https://api.github.com/users/gjtorikian/following{/other_user}","gists_url":"https://api.github.com/users/gjtorikian/gists{/gist_id}","starred_url":"https://api.github.com/users/gjtorikian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjtorikian/subscriptions","organizations_url":"https://api.github.com/users/gjtorikian/orgs","repos_url":"https://api.github.com/users/gjtorikian/repos","events_url":"https://api.github.com/users/gjtorikian/events{/privacy}","received_events_url":"https://api.github.com/users/gjtorikian/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":{"login":"gjtorikian","id":64050,"avatar_url":"https://avatars.githubusercontent.com/u/64050?v=3","gravatar_id":"","url":"https://api.github.com/users/gjtorikian","html_url":"https://github.com/gjtorikian","followers_url":"https://api.github.com/users/gjtorikian/followers","following_url":"https://api.github.com/users/gjtorikian/following{/other_user}","gists_url":"https://api.github.com/users/gjtorikian/gists{/gist_id}","starred_url":"https://api.github.com/users/gjtorikian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjtorikian/subscriptions","organizations_url":"https://api.github.com/users/gjtorikian/orgs","repos_url":"https://api.github.com/users/gjtorikian/repos","events_url":"https://api.github.com/users/gjtorikian/events{/privacy}","received_events_url":"https://api.github.com/users/gjtorikian/received_events","type":"User","site_admin":true},"milestone":null,"comments":16,"created_at":"2015-10-04T22:58:03Z","updated_at":"2015-11-20T22:02:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/249","html_url":"https://github.com/gjtorikian/html-proofer/pull/249","diff_url":"https://github.com/gjtorikian/html-proofer/pull/249.diff","patch_url":"https://github.com/gjtorikian/html-proofer/pull/249.patch"},"body":"Closes https://github.com/gjtorikian/html-proofer/issues/237.\r\n\r\nThis implements a cache file, `.htmlproofer.log`, which stores the results of all the external URL lookups. Proofer will consult this file if asked to, given a certain range.\r\n\r\nEverything appears to be working, but I need to write more tests before being certain. "},"comment":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/comments/158538134","html_url":"https://github.com/gjtorikian/html-proofer/pull/249#issuecomment-158538134","issue_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/249","id":158538134,"user":{"login":"msh100","id":4477262,"avatar_url":"https://avatars.githubusercontent.com/u/4477262?v=3","gravatar_id":"","url":"https://api.github.com/users/msh100","html_url":"https://github.com/msh100","followers_url":"https://api.github.com/users/msh100/followers","following_url":"https://api.github.com/users/msh100/following{/other_user}","gists_url":"https://api.github.com/users/msh100/gists{/gist_id}","starred_url":"https://api.github.com/users/msh100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msh100/subscriptions","organizations_url":"https://api.github.com/users/msh100/orgs","repos_url":"https://api.github.com/users/msh100/repos","events_url":"https://api.github.com/users/msh100/events{/privacy}","received_events_url":"https://api.github.com/users/msh100/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T22:02:59Z","updated_at":"2015-11-20T22:02:59Z","body":"> I'm not sure what you mean here. Are hrefs that are IPs passing, when they should be failing? Was that happening before the cache was introduced, or just now?\r\n\r\nYes, and I guess it was always passing as I have never seen them fail. Look out our repo again, you will see some like http://1.2.3.4/ (I am fairly confident this is unrelated to the caching changes)."}}