{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/36583182","id":36583182,"diff_hunk":"@@ -66,3 +71,110 @@ func GarbageCollectAsync(n *core.IpfsNode, ctx context.Context) (<-chan *KeyRemo\n \t}()\n \treturn output, nil\n }\n+\n+func PeriodicGC(ctx context.Context, node *core.IpfsNode) error {\n+\tr := node.Repo\n+\tcfg := r.Config()\n+\tif cfg.Datastore.GCPeriod == \"\" {\n+\t\tr.SetConfigKey(\"Datastore.GCPeriod\", \"1h\")\n+\t\tcfg.Datastore.GCPeriod = \"1h\"\n+\t}\n+\n+\tperiod, err := time.ParseDuration(cfg.Datastore.GCPeriod)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tif int64(period) == 0 {\n+\t\t// if duration is 0, it means GC is disabled.\n+\t\treturn nil\n+\t}\n+\n+\tstorageMax, storageGC, slackGB, err := getGCParam(node.Repo)","path":"core/corerepo/gc.go","position":55,"original_position":55,"commit_id":"f342cb277f08d02be650106cfce3b88952bb8f9d","original_commit_id":"f342cb277f08d02be650106cfce3b88952bb8f9d","user":{"login":"jbenet","id":138401,"avatar_url":"https://avatars.githubusercontent.com/u/138401?v=3","gravatar_id":"","url":"https://api.github.com/users/jbenet","html_url":"https://github.com/jbenet","followers_url":"https://api.github.com/users/jbenet/followers","following_url":"https://api.github.com/users/jbenet/following{/other_user}","gists_url":"https://api.github.com/users/jbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenet/subscriptions","organizations_url":"https://api.github.com/users/jbenet/orgs","repos_url":"https://api.github.com/users/jbenet/repos","events_url":"https://api.github.com/users/jbenet/events{/privacy}","received_events_url":"https://api.github.com/users/jbenet/received_events","type":"User","site_admin":false},"body":"in cases like this we can make structs:\r\n\r\n```go\r\ntype GC struct {\r\n  Node core.IpfsNode\r\n  Repo repo.Repo\r\n  StorageMax uint64\r\n  StorageGC uint64\r\n  SlackGB uint64\r\n}\r\n\r\nfunc NewGC(n core.IpfsNode) (*GC, error) {\r\n  m, gc, s, err := getGCParam(n.Repo)\r\n  if err != nil {\r\n    return nil, err\r\n  }\r\n  return &GC{\r\n    Node: n,\r\n    Repo: n.Repo,\r\n    StorageMax: m,\r\n    StorageGC: gc,\r\n    SlackGB: s,\r\n  }\r\n}\r\n\r\nfunc (gc *GC) PeriodicGC(ctx context.Context) { ... }\r\nfunc (gc *GC) ConditionalGC(ctx context.Context, offset int) { ... }\r\nfunc (gc *GC) maybeGC(ctx context.Context, offset int) { ... }\r\n```\r\nnot a big deal for now, i can merge this without and we can improve it later.","created_at":"2015-08-09T00:34:19Z","updated_at":"2015-08-09T00:34:19Z","html_url":"https://github.com/ipfs/go-ipfs/pull/1495#discussion_r36583182","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/36583182"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1495#discussion_r36583182"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495","id":40290357,"html_url":"https://github.com/ipfs/go-ipfs/pull/1495","diff_url":"https://github.com/ipfs/go-ipfs/pull/1495.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1495.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1495","number":1495,"state":"open","locked":false,"title":"Add fixed-period and conditional repo GC","user":{"login":"rht","id":395821,"avatar_url":"https://avatars.githubusercontent.com/u/395821?v=3","gravatar_id":"","url":"https://api.github.com/users/rht","html_url":"https://github.com/rht","followers_url":"https://api.github.com/users/rht/followers","following_url":"https://api.github.com/users/rht/following{/other_user}","gists_url":"https://api.github.com/users/rht/gists{/gist_id}","starred_url":"https://api.github.com/users/rht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rht/subscriptions","organizations_url":"https://api.github.com/users/rht/orgs","repos_url":"https://api.github.com/users/rht/repos","events_url":"https://api.github.com/users/rht/events{/privacy}","received_events_url":"https://api.github.com/users/rht/received_events","type":"User","site_admin":false},"body":"WIP sketch.\r\n\r\n1. Ok with configurable GC frequency?\r\n2. go-datastore doesn't have size check, so a local system call is used instead\r\n\r\nAddress #972","created_at":"2015-07-18T10:32:32Z","updated_at":"2015-08-09T00:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2842ff6817bc7e84f608a348eb8692179bcd4be5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1495/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/f342cb277f08d02be650106cfce3b88952bb8f9d","head":{"label":"rht:gc","ref":"gc","sha":"f342cb277f08d02be650106cfce3b88952bb8f9d","user":{"login":"rht","id":395821,"avatar_url":"https://avatars.githubusercontent.com/u/395821?v=3","gravatar_id":"","url":"https://api.github.com/users/rht","html_url":"https://github.com/rht","followers_url":"https://api.github.com/users/rht/followers","following_url":"https://api.github.com/users/rht/following{/other_user}","gists_url":"https://api.github.com/users/rht/gists{/gist_id}","starred_url":"https://api.github.com/users/rht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rht/subscriptions","organizations_url":"https://api.github.com/users/rht/orgs","repos_url":"https://api.github.com/users/rht/repos","events_url":"https://api.github.com/users/rht/events{/privacy}","received_events_url":"https://api.github.com/users/rht/received_events","type":"User","site_admin":false},"repo":{"id":35830700,"name":"go-ipfs","full_name":"rht/go-ipfs","owner":{"login":"rht","id":395821,"avatar_url":"https://avatars.githubusercontent.com/u/395821?v=3","gravatar_id":"","url":"https://api.github.com/users/rht","html_url":"https://github.com/rht","followers_url":"https://api.github.com/users/rht/followers","following_url":"https://api.github.com/users/rht/following{/other_user}","gists_url":"https://api.github.com/users/rht/gists{/gist_id}","starred_url":"https://api.github.com/users/rht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rht/subscriptions","organizations_url":"https://api.github.com/users/rht/orgs","repos_url":"https://api.github.com/users/rht/repos","events_url":"https://api.github.com/users/rht/events{/privacy}","received_events_url":"https://api.github.com/users/rht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rht/go-ipfs","description":"ipfs implementation in go","fork":true,"url":"https://api.github.com/repos/rht/go-ipfs","forks_url":"https://api.github.com/repos/rht/go-ipfs/forks","keys_url":"https://api.github.com/repos/rht/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rht/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rht/go-ipfs/teams","hooks_url":"https://api.github.com/repos/rht/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/rht/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/rht/go-ipfs/events","assignees_url":"https://api.github.com/repos/rht/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/rht/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/rht/go-ipfs/tags","blobs_url":"https://api.github.com/repos/rht/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rht/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rht/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rht/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rht/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/rht/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/rht/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/rht/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/rht/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/rht/go-ipfs/subscription","commits_url":"https://api.github.com/repos/rht/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rht/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rht/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rht/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rht/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/rht/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rht/go-ipfs/merges","archive_url":"https://api.github.com/repos/rht/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rht/go-ipfs/downloads","issues_url":"https://api.github.com/repos/rht/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/rht/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/rht/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/rht/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rht/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/rht/go-ipfs/releases{/id}","created_at":"2015-05-18T17:00:33Z","updated_at":"2015-05-18T17:00:35Z","pushed_at":"2015-08-08T08:31:59Z","git_url":"git://github.com/rht/go-ipfs.git","ssh_url":"git@github.com:rht/go-ipfs.git","clone_url":"https://github.com/rht/go-ipfs.git","svn_url":"https://github.com/rht/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":19800,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"d1366cde1b1ae8d5a6557546c26eef134bacb4bc","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"ipfs implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","created_at":"2014-06-26T08:14:34Z","updated_at":"2015-08-08T15:14:13Z","pushed_at":"2015-08-08T23:03:13Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":34073,"stargazers_count":668,"watchers_count":668,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":313,"forks":121,"open_issues":313,"watchers":668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1495"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1495"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1495/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1495/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/f342cb277f08d02be650106cfce3b88952bb8f9d"}}}}