{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/38705073","id":38705073,"diff_hunk":"@@ -103,9 +103,9 @@ public DrillResultSetImpl newResultSet(AvaticaStatement statement,\n                                          TimeZone timeZone) {\n     final ResultSetMetaData metaData =\n         newResultSetMetaData(statement, prepareResult.getColumnList());\n-    return new DrillResultSetImpl( (DrillStatementImpl) statement,\n-                                   (DrillPrepareResult) prepareResult,\n-                                   metaData, timeZone);\n+    return new DrillResultSetImpl(statement,\n+                                  (DrillPrepareResult) prepareResult,","path":"exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java","position":8,"original_position":8,"commit_id":"1a870538c66fa59070facce7e2a4342d9869b51e","original_commit_id":"1a870538c66fa59070facce7e2a4342d9869b51e","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"Cast here is redundant here, DrillResultSetImpl() is expecting an AvaticaPrepareResult object ","created_at":"2015-09-03T22:40:25Z","updated_at":"2015-09-03T22:40:25Z","html_url":"https://github.com/apache/drill/pull/143#discussion_r38705073","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/38705073"},"html":{"href":"https://github.com/apache/drill/pull/143#discussion_r38705073"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/143","id":44162217,"html_url":"https://github.com/apache/drill/pull/143","diff_url":"https://github.com/apache/drill/pull/143.diff","patch_url":"https://github.com/apache/drill/pull/143.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/143","number":143,"state":"open","locked":false,"title":"DRILL-3566: Fix:  PreparedStatement.executeQuery() got ClassCastException.","user":{"login":"dsbos","id":9450469,"avatar_url":"https://avatars.githubusercontent.com/u/9450469?v=3","gravatar_id":"","url":"https://api.github.com/users/dsbos","html_url":"https://github.com/dsbos","followers_url":"https://api.github.com/users/dsbos/followers","following_url":"https://api.github.com/users/dsbos/following{/other_user}","gists_url":"https://api.github.com/users/dsbos/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbos/subscriptions","organizations_url":"https://api.github.com/users/dsbos/orgs","repos_url":"https://api.github.com/users/dsbos/repos","events_url":"https://api.github.com/users/dsbos/events{/privacy}","received_events_url":"https://api.github.com/users/dsbos/received_events","type":"User","site_admin":false},"body":"Main:\r\nRestored DrillResultSetImpl(...)'s statement parameter from overly\r\nrestrictive DrillStatementImpl to AvaticaStatement and removed caller\r\ncast that was throwing.  (Relatedly, adjusted getStatement() and moved\r\ninternal casting from statement to connection.)\r\n\r\nAdded basic test of querying via PreparedStatement.  [PreparedStatementTest]\r\nAdded some case test of statement-creation methods.  [ConnectionTest]","created_at":"2015-09-03T21:52:56Z","updated_at":"2015-09-03T22:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c540021ae1355c5376bada63ce5b375d4e4181d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/143/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/143/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/143/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/1a870538c66fa59070facce7e2a4342d9869b51e","head":{"label":"dsbos:bugs/drill-3566","ref":"bugs/drill-3566","sha":"1a870538c66fa59070facce7e2a4342d9869b51e","user":{"login":"dsbos","id":9450469,"avatar_url":"https://avatars.githubusercontent.com/u/9450469?v=3","gravatar_id":"","url":"https://api.github.com/users/dsbos","html_url":"https://github.com/dsbos","followers_url":"https://api.github.com/users/dsbos/followers","following_url":"https://api.github.com/users/dsbos/following{/other_user}","gists_url":"https://api.github.com/users/dsbos/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbos/subscriptions","organizations_url":"https://api.github.com/users/dsbos/orgs","repos_url":"https://api.github.com/users/dsbos/repos","events_url":"https://api.github.com/users/dsbos/events{/privacy}","received_events_url":"https://api.github.com/users/dsbos/received_events","type":"User","site_admin":false},"repo":{"id":25932978,"name":"incubator-drill","full_name":"dsbos/incubator-drill","owner":{"login":"dsbos","id":9450469,"avatar_url":"https://avatars.githubusercontent.com/u/9450469?v=3","gravatar_id":"","url":"https://api.github.com/users/dsbos","html_url":"https://github.com/dsbos","followers_url":"https://api.github.com/users/dsbos/followers","following_url":"https://api.github.com/users/dsbos/following{/other_user}","gists_url":"https://api.github.com/users/dsbos/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbos/subscriptions","organizations_url":"https://api.github.com/users/dsbos/orgs","repos_url":"https://api.github.com/users/dsbos/repos","events_url":"https://api.github.com/users/dsbos/events{/privacy}","received_events_url":"https://api.github.com/users/dsbos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsbos/incubator-drill","description":"Mirror of Apache Drill (Incubating)","fork":true,"url":"https://api.github.com/repos/dsbos/incubator-drill","forks_url":"https://api.github.com/repos/dsbos/incubator-drill/forks","keys_url":"https://api.github.com/repos/dsbos/incubator-drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsbos/incubator-drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsbos/incubator-drill/teams","hooks_url":"https://api.github.com/repos/dsbos/incubator-drill/hooks","issue_events_url":"https://api.github.com/repos/dsbos/incubator-drill/issues/events{/number}","events_url":"https://api.github.com/repos/dsbos/incubator-drill/events","assignees_url":"https://api.github.com/repos/dsbos/incubator-drill/assignees{/user}","branches_url":"https://api.github.com/repos/dsbos/incubator-drill/branches{/branch}","tags_url":"https://api.github.com/repos/dsbos/incubator-drill/tags","blobs_url":"https://api.github.com/repos/dsbos/incubator-drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsbos/incubator-drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsbos/incubator-drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsbos/incubator-drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsbos/incubator-drill/statuses/{sha}","languages_url":"https://api.github.com/repos/dsbos/incubator-drill/languages","stargazers_url":"https://api.github.com/repos/dsbos/incubator-drill/stargazers","contributors_url":"https://api.github.com/repos/dsbos/incubator-drill/contributors","subscribers_url":"https://api.github.com/repos/dsbos/incubator-drill/subscribers","subscription_url":"https://api.github.com/repos/dsbos/incubator-drill/subscription","commits_url":"https://api.github.com/repos/dsbos/incubator-drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsbos/incubator-drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsbos/incubator-drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsbos/incubator-drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsbos/incubator-drill/contents/{+path}","compare_url":"https://api.github.com/repos/dsbos/incubator-drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsbos/incubator-drill/merges","archive_url":"https://api.github.com/repos/dsbos/incubator-drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsbos/incubator-drill/downloads","issues_url":"https://api.github.com/repos/dsbos/incubator-drill/issues{/number}","pulls_url":"https://api.github.com/repos/dsbos/incubator-drill/pulls{/number}","milestones_url":"https://api.github.com/repos/dsbos/incubator-drill/milestones{/number}","notifications_url":"https://api.github.com/repos/dsbos/incubator-drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsbos/incubator-drill/labels{/name}","releases_url":"https://api.github.com/repos/dsbos/incubator-drill/releases{/id}","created_at":"2014-10-29T17:34:11Z","updated_at":"2015-05-07T06:03:31Z","pushed_at":"2015-09-03T21:56:52Z","git_url":"git://github.com/dsbos/incubator-drill.git","ssh_url":"git@github.com:dsbos/incubator-drill.git","clone_url":"https://github.com/dsbos/incubator-drill.git","svn_url":"https://github.com/dsbos/incubator-drill","homepage":null,"size":21952,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"95623912ebf348962fe8a8846c5f47c5fdcf2f78","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","created_at":"2012-09-05T07:00:26Z","updated_at":"2015-09-02T20:22:25Z","pushed_at":"2015-09-03T22:00:10Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":44339,"stargazers_count":478,"watchers_count":478,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":296,"mirror_url":"git://git.apache.org/incubator-drill.git","open_issues_count":39,"forks":296,"open_issues":39,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/143"},"html":{"href":"https://github.com/apache/drill/pull/143"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/143"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/1a870538c66fa59070facce7e2a4342d9869b51e"}}}}