{"action":"created","issue":{"url":"https://api.github.com/repos/agnwinds/python/issues/172","labels_url":"https://api.github.com/repos/agnwinds/python/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/agnwinds/python/issues/172/comments","events_url":"https://api.github.com/repos/agnwinds/python/issues/172/events","html_url":"https://github.com/agnwinds/python/issues/172","id":105044780,"number":172,"title":"Need for shell_wind?","user":{"login":"kslong","id":2530901,"avatar_url":"https://avatars.githubusercontent.com/u/2530901?v=3","gravatar_id":"","url":"https://api.github.com/users/kslong","html_url":"https://github.com/kslong","followers_url":"https://api.github.com/users/kslong/followers","following_url":"https://api.github.com/users/kslong/following{/other_user}","gists_url":"https://api.github.com/users/kslong/gists{/gist_id}","starred_url":"https://api.github.com/users/kslong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kslong/subscriptions","organizations_url":"https://api.github.com/users/kslong/orgs","repos_url":"https://api.github.com/users/kslong/repos","events_url":"https://api.github.com/users/kslong/events{/privacy}","received_events_url":"https://api.github.com/users/kslong/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/agnwinds/python/labels/medium","name":"medium","color":"fbca04"},{"url":"https://api.github.com/repos/agnwinds/python/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"Higginbottom","id":3329213,"avatar_url":"https://avatars.githubusercontent.com/u/3329213?v=3","gravatar_id":"","url":"https://api.github.com/users/Higginbottom","html_url":"https://github.com/Higginbottom","followers_url":"https://api.github.com/users/Higginbottom/followers","following_url":"https://api.github.com/users/Higginbottom/following{/other_user}","gists_url":"https://api.github.com/users/Higginbottom/gists{/gist_id}","starred_url":"https://api.github.com/users/Higginbottom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Higginbottom/subscriptions","organizations_url":"https://api.github.com/users/Higginbottom/orgs","repos_url":"https://api.github.com/users/Higginbottom/repos","events_url":"https://api.github.com/users/Higginbottom/events{/privacy}","received_events_url":"https://api.github.com/users/Higginbottom/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-09-05T19:35:10Z","updated_at":"2015-11-02T16:20:31Z","closed_at":null,"body":"Shell_wind is a diagnostic mode of the current version of Python.  It is very closely related to the stellar_wind model and in setup, calls many of the same routines, with some parameters hardwired.  It ignores some of the parameters in the .pf and replaces them with hardwired values.  \r\n\r\nThe stated reason having this routine was that with the standard stellar model did not allow one to start the wind anywhere except at the surface of the star (which was not what we want for the AGN, where we would like to investigate the shell far from the origin.\r\n\r\nHowever, the current version of the stellar wind model explicitly allows one to set the minimum radius for the wind.  \r\n\r\nNick, could you please investigate whether this mode is still needed or whether we cannot do the same thing with appropriate parameters for the stellar wind model.  While I have this working with domains, I would prefer to remove it if it does not serve an important purpose that cannot be carried out with the stellar wind model (both for documentation and maintenance reasons)."},"comment":{"url":"https://api.github.com/repos/agnwinds/python/issues/comments/153071777","html_url":"https://github.com/agnwinds/python/issues/172#issuecomment-153071777","issue_url":"https://api.github.com/repos/agnwinds/python/issues/172","id":153071777,"user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T16:20:31Z","updated_at":"2015-11-02T16:20:31Z","body":"I think this is broadly correct, and I checked you can make a thin shell using the stellar wind mode- however there are a bunch of diagnostic things we use the thin shell mode for. I'd suggest mode 9 is changed to be called 'diagnostic shell' or something, and uses the stellar wind machinery but allows the user to print/save additional diagnostic aspects so we can still run our scripts easily. General philosophy being that 9 is the ideal mode for ionization tests and so on."}}