{"action":"created","comment":{"url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/comments/44191274","id":44191274,"diff_hunk":"@@ -9,6 +9,12 @@ Error.stackTraceLimit = Infinity\n {RESERVED, STRICT_PROSCRIBED} = require './lexer'\n iced = require 'iced-runtime'\n \n+# At this stage of development of this branch, it's easy to mess up\n+# runtimes. The one in node_modules/, which is used by default, will\n+# probably be incorrect.\n+if not iced.const.iterator\n+  throw new Error 'Wrong iced runtime!'","path":"src/nodes.coffee","position":8,"original_position":8,"commit_id":"154f77fa5892ff9f86f31349bd6cfee672f3b749","original_commit_id":"154f77fa5892ff9f86f31349bd6cfee672f3b749","user":{"login":"zapu","id":451974,"avatar_url":"https://avatars.githubusercontent.com/u/451974?v=3","gravatar_id":"","url":"https://api.github.com/users/zapu","html_url":"https://github.com/zapu","followers_url":"https://api.github.com/users/zapu/followers","following_url":"https://api.github.com/users/zapu/following{/other_user}","gists_url":"https://api.github.com/users/zapu/gists{/gist_id}","starred_url":"https://api.github.com/users/zapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapu/subscriptions","organizations_url":"https://api.github.com/users/zapu/orgs","repos_url":"https://api.github.com/users/zapu/repos","events_url":"https://api.github.com/users/zapu/events{/privacy}","received_events_url":"https://api.github.com/users/zapu/received_events","type":"User","site_admin":false},"body":"New module sounds fine :+1: ","created_at":"2015-11-06T21:47:17Z","updated_at":"2015-11-06T21:47:17Z","html_url":"https://github.com/maxtaco/coffee-script/pull/168#discussion_r44191274","pull_request_url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/comments/44191274"},"html":{"href":"https://github.com/maxtaco/coffee-script/pull/168#discussion_r44191274"},"pull_request":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168","id":48863400,"html_url":"https://github.com/maxtaco/coffee-script/pull/168","diff_url":"https://github.com/maxtaco/coffee-script/pull/168.diff","patch_url":"https://github.com/maxtaco/coffee-script/pull/168.patch","issue_url":"https://api.github.com/repos/maxtaco/coffee-script/issues/168","number":168,"state":"open","locked":false,"title":"Iced3 noautocb","user":{"login":"zapu","id":451974,"avatar_url":"https://avatars.githubusercontent.com/u/451974?v=3","gravatar_id":"","url":"https://api.github.com/users/zapu","html_url":"https://github.com/zapu","followers_url":"https://api.github.com/users/zapu/followers","following_url":"https://api.github.com/users/zapu/following{/other_user}","gists_url":"https://api.github.com/users/zapu/gists{/gist_id}","starred_url":"https://api.github.com/users/zapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapu/subscriptions","organizations_url":"https://api.github.com/users/zapu/orgs","repos_url":"https://api.github.com/users/zapu/repos","events_url":"https://api.github.com/users/zapu/events{/privacy}","received_events_url":"https://api.github.com/users/zapu/received_events","type":"User","site_admin":false},"body":"I'm making a new pull request. It contains all the fixes from previous PR, but this one has `autocb` support removed. `autocb` will now generate an error while compiling, I feel like this might aid the iced3 adoption. I, for one, was using `autocb` very extensively in iced projects. Good thing that single `grep` might be enough to spot all places one would have to refactor, but having an error will help catching anything that might have slipped.\r\n\r\nUsing this branch, all tests pass, and also `iced-runtime` compiles now.\r\n\r\nThere were some problems in `defer` handling, but they were fixed mostly by looking at `iced2` branch,\r\n\r\nThis code would not run, or even compile:\r\n```\r\na =\r\n  defer: ->\r\n    @\r\n\r\na.defer()\r\n```\r\n\r\nBecause it was parsed as:\r\n```\r\n[IDENTIFIER a] [= =] [INDENT 2] [{ {] [DEFER defer] [: :] [-> ->] [INDENT 2] [@ @] [OUTDENT 4] [} }] [OUTDENT 2] [TERMINATOR \\n] [IDENTIFIER a] [. .] [DEFER defer] [CALL_START (] [CALL_END )] [TERMINATOR \\n]\r\n```\r\n\r\nInstead of:\r\n```\r\n[IDENTIFIER a] [= =] [INDENT 2] [{ {] [IDENTIFIER defer] [: :] [-> ->] [INDENT 2] [@ @] [OUTDENT 4] [} }] [OUTDENT 2] [TERMINATOR \\n] [IDENTIFIER a] [. .] [DEFER defer] [CALL_START (] [CALL_END )] [TERMINATOR \\n]\r\n```\r\n\r\n(notice the `DEFER defer` instead of `IDENTIFIER defer`)\r\n\r\nThe defer call is still compiled as:\r\n\r\n```\r\na.defer({\r\n    lineno: 4,\r\n    context: __iced_deferrals\r\n  });\r\n```\r\n\r\nI'm not sure if that's correct... I've never seen things named `defer` in any iced code (and I personally dislike that this is possible), but `iced-runtime` does this.","created_at":"2015-10-27T12:23:57Z","updated_at":"2015-11-06T21:47:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49155b4260d5a5f03c590bfa17801cb407a67a26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168/commits","review_comments_url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168/comments","review_comment_url":"https://api.github.com/repos/maxtaco/coffee-script/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maxtaco/coffee-script/issues/168/comments","statuses_url":"https://api.github.com/repos/maxtaco/coffee-script/statuses/154f77fa5892ff9f86f31349bd6cfee672f3b749","head":{"label":"zapu:iced3_noautocb","ref":"iced3_noautocb","sha":"154f77fa5892ff9f86f31349bd6cfee672f3b749","user":{"login":"zapu","id":451974,"avatar_url":"https://avatars.githubusercontent.com/u/451974?v=3","gravatar_id":"","url":"https://api.github.com/users/zapu","html_url":"https://github.com/zapu","followers_url":"https://api.github.com/users/zapu/followers","following_url":"https://api.github.com/users/zapu/following{/other_user}","gists_url":"https://api.github.com/users/zapu/gists{/gist_id}","starred_url":"https://api.github.com/users/zapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapu/subscriptions","organizations_url":"https://api.github.com/users/zapu/orgs","repos_url":"https://api.github.com/users/zapu/repos","events_url":"https://api.github.com/users/zapu/events{/privacy}","received_events_url":"https://api.github.com/users/zapu/received_events","type":"User","site_admin":false},"repo":{"id":43575084,"name":"coffeescript","full_name":"zapu/coffeescript","owner":{"login":"zapu","id":451974,"avatar_url":"https://avatars.githubusercontent.com/u/451974?v=3","gravatar_id":"","url":"https://api.github.com/users/zapu","html_url":"https://github.com/zapu","followers_url":"https://api.github.com/users/zapu/followers","following_url":"https://api.github.com/users/zapu/following{/other_user}","gists_url":"https://api.github.com/users/zapu/gists{/gist_id}","starred_url":"https://api.github.com/users/zapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapu/subscriptions","organizations_url":"https://api.github.com/users/zapu/orgs","repos_url":"https://api.github.com/users/zapu/repos","events_url":"https://api.github.com/users/zapu/events{/privacy}","received_events_url":"https://api.github.com/users/zapu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zapu/coffeescript","description":"Unfancy JavaScript","fork":true,"url":"https://api.github.com/repos/zapu/coffeescript","forks_url":"https://api.github.com/repos/zapu/coffeescript/forks","keys_url":"https://api.github.com/repos/zapu/coffeescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zapu/coffeescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zapu/coffeescript/teams","hooks_url":"https://api.github.com/repos/zapu/coffeescript/hooks","issue_events_url":"https://api.github.com/repos/zapu/coffeescript/issues/events{/number}","events_url":"https://api.github.com/repos/zapu/coffeescript/events","assignees_url":"https://api.github.com/repos/zapu/coffeescript/assignees{/user}","branches_url":"https://api.github.com/repos/zapu/coffeescript/branches{/branch}","tags_url":"https://api.github.com/repos/zapu/coffeescript/tags","blobs_url":"https://api.github.com/repos/zapu/coffeescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zapu/coffeescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zapu/coffeescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/zapu/coffeescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zapu/coffeescript/statuses/{sha}","languages_url":"https://api.github.com/repos/zapu/coffeescript/languages","stargazers_url":"https://api.github.com/repos/zapu/coffeescript/stargazers","contributors_url":"https://api.github.com/repos/zapu/coffeescript/contributors","subscribers_url":"https://api.github.com/repos/zapu/coffeescript/subscribers","subscription_url":"https://api.github.com/repos/zapu/coffeescript/subscription","commits_url":"https://api.github.com/repos/zapu/coffeescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/zapu/coffeescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/zapu/coffeescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/zapu/coffeescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/zapu/coffeescript/contents/{+path}","compare_url":"https://api.github.com/repos/zapu/coffeescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zapu/coffeescript/merges","archive_url":"https://api.github.com/repos/zapu/coffeescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zapu/coffeescript/downloads","issues_url":"https://api.github.com/repos/zapu/coffeescript/issues{/number}","pulls_url":"https://api.github.com/repos/zapu/coffeescript/pulls{/number}","milestones_url":"https://api.github.com/repos/zapu/coffeescript/milestones{/number}","notifications_url":"https://api.github.com/repos/zapu/coffeescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zapu/coffeescript/labels{/name}","releases_url":"https://api.github.com/repos/zapu/coffeescript/releases{/id}","created_at":"2015-10-02T20:36:23Z","updated_at":"2015-10-02T20:36:27Z","pushed_at":"2015-10-27T12:12:54Z","git_url":"git://github.com/zapu/coffeescript.git","ssh_url":"git@github.com:zapu/coffeescript.git","clone_url":"https://github.com/zapu/coffeescript.git","svn_url":"https://github.com/zapu/coffeescript","homepage":"http://coffeescript.org/","size":18360,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maxtaco:iced3","ref":"iced3","sha":"415d02861bb8a73f5473b6d673cc4fa53291dcae","user":{"login":"maxtaco","id":866815,"avatar_url":"https://avatars.githubusercontent.com/u/866815?v=3","gravatar_id":"","url":"https://api.github.com/users/maxtaco","html_url":"https://github.com/maxtaco","followers_url":"https://api.github.com/users/maxtaco/followers","following_url":"https://api.github.com/users/maxtaco/following{/other_user}","gists_url":"https://api.github.com/users/maxtaco/gists{/gist_id}","starred_url":"https://api.github.com/users/maxtaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxtaco/subscriptions","organizations_url":"https://api.github.com/users/maxtaco/orgs","repos_url":"https://api.github.com/users/maxtaco/repos","events_url":"https://api.github.com/users/maxtaco/events{/privacy}","received_events_url":"https://api.github.com/users/maxtaco/received_events","type":"User","site_admin":false},"repo":{"id":2766429,"name":"coffee-script","full_name":"maxtaco/coffee-script","owner":{"login":"maxtaco","id":866815,"avatar_url":"https://avatars.githubusercontent.com/u/866815?v=3","gravatar_id":"","url":"https://api.github.com/users/maxtaco","html_url":"https://github.com/maxtaco","followers_url":"https://api.github.com/users/maxtaco/followers","following_url":"https://api.github.com/users/maxtaco/following{/other_user}","gists_url":"https://api.github.com/users/maxtaco/gists{/gist_id}","starred_url":"https://api.github.com/users/maxtaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxtaco/subscriptions","organizations_url":"https://api.github.com/users/maxtaco/orgs","repos_url":"https://api.github.com/users/maxtaco/repos","events_url":"https://api.github.com/users/maxtaco/events{/privacy}","received_events_url":"https://api.github.com/users/maxtaco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxtaco/coffee-script","description":"IcedCoffeeScript","fork":true,"url":"https://api.github.com/repos/maxtaco/coffee-script","forks_url":"https://api.github.com/repos/maxtaco/coffee-script/forks","keys_url":"https://api.github.com/repos/maxtaco/coffee-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxtaco/coffee-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxtaco/coffee-script/teams","hooks_url":"https://api.github.com/repos/maxtaco/coffee-script/hooks","issue_events_url":"https://api.github.com/repos/maxtaco/coffee-script/issues/events{/number}","events_url":"https://api.github.com/repos/maxtaco/coffee-script/events","assignees_url":"https://api.github.com/repos/maxtaco/coffee-script/assignees{/user}","branches_url":"https://api.github.com/repos/maxtaco/coffee-script/branches{/branch}","tags_url":"https://api.github.com/repos/maxtaco/coffee-script/tags","blobs_url":"https://api.github.com/repos/maxtaco/coffee-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxtaco/coffee-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxtaco/coffee-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxtaco/coffee-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxtaco/coffee-script/statuses/{sha}","languages_url":"https://api.github.com/repos/maxtaco/coffee-script/languages","stargazers_url":"https://api.github.com/repos/maxtaco/coffee-script/stargazers","contributors_url":"https://api.github.com/repos/maxtaco/coffee-script/contributors","subscribers_url":"https://api.github.com/repos/maxtaco/coffee-script/subscribers","subscription_url":"https://api.github.com/repos/maxtaco/coffee-script/subscription","commits_url":"https://api.github.com/repos/maxtaco/coffee-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxtaco/coffee-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxtaco/coffee-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxtaco/coffee-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxtaco/coffee-script/contents/{+path}","compare_url":"https://api.github.com/repos/maxtaco/coffee-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxtaco/coffee-script/merges","archive_url":"https://api.github.com/repos/maxtaco/coffee-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxtaco/coffee-script/downloads","issues_url":"https://api.github.com/repos/maxtaco/coffee-script/issues{/number}","pulls_url":"https://api.github.com/repos/maxtaco/coffee-script/pulls{/number}","milestones_url":"https://api.github.com/repos/maxtaco/coffee-script/milestones{/number}","notifications_url":"https://api.github.com/repos/maxtaco/coffee-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxtaco/coffee-script/labels{/name}","releases_url":"https://api.github.com/repos/maxtaco/coffee-script/releases{/id}","created_at":"2011-11-13T13:24:59Z","updated_at":"2015-11-04T18:56:04Z","pushed_at":"2015-10-27T12:23:57Z","git_url":"git://github.com/maxtaco/coffee-script.git","ssh_url":"git@github.com:maxtaco/coffee-script.git","clone_url":"https://github.com/maxtaco/coffee-script.git","svn_url":"https://github.com/maxtaco/coffee-script","homepage":"http://maxtaco.github.com/coffee-script","size":28207,"stargazers_count":687,"watchers_count":687,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":71,"forks":59,"open_issues":71,"watchers":687,"default_branch":"iced2"}},"_links":{"self":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168"},"html":{"href":"https://github.com/maxtaco/coffee-script/pull/168"},"issue":{"href":"https://api.github.com/repos/maxtaco/coffee-script/issues/168"},"comments":{"href":"https://api.github.com/repos/maxtaco/coffee-script/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maxtaco/coffee-script/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/maxtaco/coffee-script/statuses/154f77fa5892ff9f86f31349bd6cfee672f3b749"}}}}