{"action":"created","comment":{"url":"https://api.github.com/repos/pele-python/mcpele/pulls/comments/44913021","id":44913021,"diff_hunk":"@@ -0,0 +1,20 @@\n+#ifndef _MCPELE_RECORD_COORDS_TIMESERIES_H__\n+#define _MCPELE_RECORD_COORDS_TIMESERIES_H__\n+\n+#include \"record_vector_timeseries.h\"\n+\n+namespace mcpele {\n+\n+class RecordCoordsTimeseries : public RecordVectorTimeseries {\n+public:\n+    RecordCoordsTimeseries(const size_t record_every, const size_t eqsteps)\n+        : RecordVectorTimeseries(record_every, eqsteps)\n+    {}\n+    virtual ~RecordCoordsTimeseries() {}\n+    virtual pele::Array<double> get_recorded_vector(pele::Array<double> &coords,","path":"source/mcpele/record_coords_timeseries.h","position":14,"original_position":14,"commit_id":"0decf53363d53ab4a1ce494e7bfb5855874fa8c4","original_commit_id":"0decf53363d53ab4a1ce494e7bfb5855874fa8c4","user":{"login":"kjs73","id":7257339,"avatar_url":"https://avatars.githubusercontent.com/u/7257339?v=3","gravatar_id":"","url":"https://api.github.com/users/kjs73","html_url":"https://github.com/kjs73","followers_url":"https://api.github.com/users/kjs73/followers","following_url":"https://api.github.com/users/kjs73/following{/other_user}","gists_url":"https://api.github.com/users/kjs73/gists{/gist_id}","starred_url":"https://api.github.com/users/kjs73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjs73/subscriptions","organizations_url":"https://api.github.com/users/kjs73/orgs","repos_url":"https://api.github.com/users/kjs73/repos","events_url":"https://api.github.com/users/kjs73/events{/privacy}","received_events_url":"https://api.github.com/users/kjs73/received_events","type":"User","site_admin":false},"body":"This is a bit confusing. Why does it take and return coords?","created_at":"2015-11-16T11:30:42Z","updated_at":"2015-11-16T11:30:42Z","html_url":"https://github.com/pele-python/mcpele/pull/73#discussion_r44913021","pull_request_url":"https://api.github.com/repos/pele-python/mcpele/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/comments/44913021"},"html":{"href":"https://github.com/pele-python/mcpele/pull/73#discussion_r44913021"},"pull_request":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/pele-python/mcpele/pulls/73","id":50667176,"html_url":"https://github.com/pele-python/mcpele/pull/73","diff_url":"https://github.com/pele-python/mcpele/pull/73.diff","patch_url":"https://github.com/pele-python/mcpele/pull/73.patch","issue_url":"https://api.github.com/repos/pele-python/mcpele/issues/73","number":73,"state":"open","locked":false,"title":"Store trajectory","user":{"login":"smcantab","id":3187259,"avatar_url":"https://avatars.githubusercontent.com/u/3187259?v=3","gravatar_id":"","url":"https://api.github.com/users/smcantab","html_url":"https://github.com/smcantab","followers_url":"https://api.github.com/users/smcantab/followers","following_url":"https://api.github.com/users/smcantab/following{/other_user}","gists_url":"https://api.github.com/users/smcantab/gists{/gist_id}","starred_url":"https://api.github.com/users/smcantab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcantab/subscriptions","organizations_url":"https://api.github.com/users/smcantab/orgs","repos_url":"https://api.github.com/users/smcantab/repos","events_url":"https://api.github.com/users/smcantab/events{/privacy}","received_events_url":"https://api.github.com/users/smcantab/received_events","type":"User","site_admin":false},"body":"I have implemented a base function to store a vector timeseries (I used a deque of pele arrays) and implemented child class to record the coordinates as a function of time at regular intervals.\r\n\r\n","created_at":"2015-11-13T17:20:38Z","updated_at":"2015-11-16T11:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7b1840512d045f5fd416899ebdce26c8fac06ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pele-python/mcpele/pulls/73/commits","review_comments_url":"https://api.github.com/repos/pele-python/mcpele/pulls/73/comments","review_comment_url":"https://api.github.com/repos/pele-python/mcpele/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pele-python/mcpele/issues/73/comments","statuses_url":"https://api.github.com/repos/pele-python/mcpele/statuses/0decf53363d53ab4a1ce494e7bfb5855874fa8c4","head":{"label":"pele-python:store_trajectory","ref":"store_trajectory","sha":"0decf53363d53ab4a1ce494e7bfb5855874fa8c4","user":{"login":"pele-python","id":4612288,"avatar_url":"https://avatars.githubusercontent.com/u/4612288?v=3","gravatar_id":"","url":"https://api.github.com/users/pele-python","html_url":"https://github.com/pele-python","followers_url":"https://api.github.com/users/pele-python/followers","following_url":"https://api.github.com/users/pele-python/following{/other_user}","gists_url":"https://api.github.com/users/pele-python/gists{/gist_id}","starred_url":"https://api.github.com/users/pele-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pele-python/subscriptions","organizations_url":"https://api.github.com/users/pele-python/orgs","repos_url":"https://api.github.com/users/pele-python/repos","events_url":"https://api.github.com/users/pele-python/events{/privacy}","received_events_url":"https://api.github.com/users/pele-python/received_events","type":"Organization","site_admin":false},"repo":{"id":19282782,"name":"mcpele","full_name":"pele-python/mcpele","owner":{"login":"pele-python","id":4612288,"avatar_url":"https://avatars.githubusercontent.com/u/4612288?v=3","gravatar_id":"","url":"https://api.github.com/users/pele-python","html_url":"https://github.com/pele-python","followers_url":"https://api.github.com/users/pele-python/followers","following_url":"https://api.github.com/users/pele-python/following{/other_user}","gists_url":"https://api.github.com/users/pele-python/gists{/gist_id}","starred_url":"https://api.github.com/users/pele-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pele-python/subscriptions","organizations_url":"https://api.github.com/users/pele-python/orgs","repos_url":"https://api.github.com/users/pele-python/repos","events_url":"https://api.github.com/users/pele-python/events{/privacy}","received_events_url":"https://api.github.com/users/pele-python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pele-python/mcpele","description":"Monte Carlo and parallel tempering routines built on the pele foundation","fork":false,"url":"https://api.github.com/repos/pele-python/mcpele","forks_url":"https://api.github.com/repos/pele-python/mcpele/forks","keys_url":"https://api.github.com/repos/pele-python/mcpele/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pele-python/mcpele/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pele-python/mcpele/teams","hooks_url":"https://api.github.com/repos/pele-python/mcpele/hooks","issue_events_url":"https://api.github.com/repos/pele-python/mcpele/issues/events{/number}","events_url":"https://api.github.com/repos/pele-python/mcpele/events","assignees_url":"https://api.github.com/repos/pele-python/mcpele/assignees{/user}","branches_url":"https://api.github.com/repos/pele-python/mcpele/branches{/branch}","tags_url":"https://api.github.com/repos/pele-python/mcpele/tags","blobs_url":"https://api.github.com/repos/pele-python/mcpele/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pele-python/mcpele/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pele-python/mcpele/git/refs{/sha}","trees_url":"https://api.github.com/repos/pele-python/mcpele/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pele-python/mcpele/statuses/{sha}","languages_url":"https://api.github.com/repos/pele-python/mcpele/languages","stargazers_url":"https://api.github.com/repos/pele-python/mcpele/stargazers","contributors_url":"https://api.github.com/repos/pele-python/mcpele/contributors","subscribers_url":"https://api.github.com/repos/pele-python/mcpele/subscribers","subscription_url":"https://api.github.com/repos/pele-python/mcpele/subscription","commits_url":"https://api.github.com/repos/pele-python/mcpele/commits{/sha}","git_commits_url":"https://api.github.com/repos/pele-python/mcpele/git/commits{/sha}","comments_url":"https://api.github.com/repos/pele-python/mcpele/comments{/number}","issue_comment_url":"https://api.github.com/repos/pele-python/mcpele/issues/comments{/number}","contents_url":"https://api.github.com/repos/pele-python/mcpele/contents/{+path}","compare_url":"https://api.github.com/repos/pele-python/mcpele/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pele-python/mcpele/merges","archive_url":"https://api.github.com/repos/pele-python/mcpele/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pele-python/mcpele/downloads","issues_url":"https://api.github.com/repos/pele-python/mcpele/issues{/number}","pulls_url":"https://api.github.com/repos/pele-python/mcpele/pulls{/number}","milestones_url":"https://api.github.com/repos/pele-python/mcpele/milestones{/number}","notifications_url":"https://api.github.com/repos/pele-python/mcpele/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pele-python/mcpele/labels{/name}","releases_url":"https://api.github.com/repos/pele-python/mcpele/releases{/id}","created_at":"2014-04-29T16:07:25Z","updated_at":"2015-10-29T20:04:55Z","pushed_at":"2015-11-13T18:31:14Z","git_url":"git://github.com/pele-python/mcpele.git","ssh_url":"git@github.com:pele-python/mcpele.git","clone_url":"https://github.com/pele-python/mcpele.git","svn_url":"https://github.com/pele-python/mcpele","homepage":null,"size":10840,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"pele-python:master","ref":"master","sha":"98708d61df4dd3b2d70d0db2eaf86a52a86aee20","user":{"login":"pele-python","id":4612288,"avatar_url":"https://avatars.githubusercontent.com/u/4612288?v=3","gravatar_id":"","url":"https://api.github.com/users/pele-python","html_url":"https://github.com/pele-python","followers_url":"https://api.github.com/users/pele-python/followers","following_url":"https://api.github.com/users/pele-python/following{/other_user}","gists_url":"https://api.github.com/users/pele-python/gists{/gist_id}","starred_url":"https://api.github.com/users/pele-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pele-python/subscriptions","organizations_url":"https://api.github.com/users/pele-python/orgs","repos_url":"https://api.github.com/users/pele-python/repos","events_url":"https://api.github.com/users/pele-python/events{/privacy}","received_events_url":"https://api.github.com/users/pele-python/received_events","type":"Organization","site_admin":false},"repo":{"id":19282782,"name":"mcpele","full_name":"pele-python/mcpele","owner":{"login":"pele-python","id":4612288,"avatar_url":"https://avatars.githubusercontent.com/u/4612288?v=3","gravatar_id":"","url":"https://api.github.com/users/pele-python","html_url":"https://github.com/pele-python","followers_url":"https://api.github.com/users/pele-python/followers","following_url":"https://api.github.com/users/pele-python/following{/other_user}","gists_url":"https://api.github.com/users/pele-python/gists{/gist_id}","starred_url":"https://api.github.com/users/pele-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pele-python/subscriptions","organizations_url":"https://api.github.com/users/pele-python/orgs","repos_url":"https://api.github.com/users/pele-python/repos","events_url":"https://api.github.com/users/pele-python/events{/privacy}","received_events_url":"https://api.github.com/users/pele-python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pele-python/mcpele","description":"Monte Carlo and parallel tempering routines built on the pele foundation","fork":false,"url":"https://api.github.com/repos/pele-python/mcpele","forks_url":"https://api.github.com/repos/pele-python/mcpele/forks","keys_url":"https://api.github.com/repos/pele-python/mcpele/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pele-python/mcpele/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pele-python/mcpele/teams","hooks_url":"https://api.github.com/repos/pele-python/mcpele/hooks","issue_events_url":"https://api.github.com/repos/pele-python/mcpele/issues/events{/number}","events_url":"https://api.github.com/repos/pele-python/mcpele/events","assignees_url":"https://api.github.com/repos/pele-python/mcpele/assignees{/user}","branches_url":"https://api.github.com/repos/pele-python/mcpele/branches{/branch}","tags_url":"https://api.github.com/repos/pele-python/mcpele/tags","blobs_url":"https://api.github.com/repos/pele-python/mcpele/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pele-python/mcpele/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pele-python/mcpele/git/refs{/sha}","trees_url":"https://api.github.com/repos/pele-python/mcpele/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pele-python/mcpele/statuses/{sha}","languages_url":"https://api.github.com/repos/pele-python/mcpele/languages","stargazers_url":"https://api.github.com/repos/pele-python/mcpele/stargazers","contributors_url":"https://api.github.com/repos/pele-python/mcpele/contributors","subscribers_url":"https://api.github.com/repos/pele-python/mcpele/subscribers","subscription_url":"https://api.github.com/repos/pele-python/mcpele/subscription","commits_url":"https://api.github.com/repos/pele-python/mcpele/commits{/sha}","git_commits_url":"https://api.github.com/repos/pele-python/mcpele/git/commits{/sha}","comments_url":"https://api.github.com/repos/pele-python/mcpele/comments{/number}","issue_comment_url":"https://api.github.com/repos/pele-python/mcpele/issues/comments{/number}","contents_url":"https://api.github.com/repos/pele-python/mcpele/contents/{+path}","compare_url":"https://api.github.com/repos/pele-python/mcpele/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pele-python/mcpele/merges","archive_url":"https://api.github.com/repos/pele-python/mcpele/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pele-python/mcpele/downloads","issues_url":"https://api.github.com/repos/pele-python/mcpele/issues{/number}","pulls_url":"https://api.github.com/repos/pele-python/mcpele/pulls{/number}","milestones_url":"https://api.github.com/repos/pele-python/mcpele/milestones{/number}","notifications_url":"https://api.github.com/repos/pele-python/mcpele/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pele-python/mcpele/labels{/name}","releases_url":"https://api.github.com/repos/pele-python/mcpele/releases{/id}","created_at":"2014-04-29T16:07:25Z","updated_at":"2015-10-29T20:04:55Z","pushed_at":"2015-11-13T18:31:14Z","git_url":"git://github.com/pele-python/mcpele.git","ssh_url":"git@github.com:pele-python/mcpele.git","clone_url":"https://github.com/pele-python/mcpele.git","svn_url":"https://github.com/pele-python/mcpele","homepage":null,"size":10840,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/73"},"html":{"href":"https://github.com/pele-python/mcpele/pull/73"},"issue":{"href":"https://api.github.com/repos/pele-python/mcpele/issues/73"},"comments":{"href":"https://api.github.com/repos/pele-python/mcpele/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pele-python/mcpele/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/pele-python/mcpele/statuses/0decf53363d53ab4a1ce494e7bfb5855874fa8c4"}}}}