{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1431","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1431/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1431/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1431/events","html_url":"https://github.com/ManageIQ/manageiq/pull/1431","id":55071156,"number":1431,"title":"Specs for MiqDisk and MiqPartition classes","user":{"login":"movitto","id":166845,"avatar_url":"https://avatars.githubusercontent.com/u/166845?v=3","gravatar_id":"","url":"https://api.github.com/users/movitto","html_url":"https://github.com/movitto","followers_url":"https://api.github.com/users/movitto/followers","following_url":"https://api.github.com/users/movitto/following{/other_user}","gists_url":"https://api.github.com/users/movitto/gists{/gist_id}","starred_url":"https://api.github.com/users/movitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movitto/subscriptions","organizations_url":"https://api.github.com/users/movitto/orgs","repos_url":"https://api.github.com/users/movitto/repos","events_url":"https://api.github.com/users/movitto/events{/privacy}","received_events_url":"https://api.github.com/users/movitto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/fleecing","name":"fleecing","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/test","name":"test","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"movitto","id":166845,"avatar_url":"https://avatars.githubusercontent.com/u/166845?v=3","gravatar_id":"","url":"https://api.github.com/users/movitto","html_url":"https://github.com/movitto","followers_url":"https://api.github.com/users/movitto/followers","following_url":"https://api.github.com/users/movitto/following{/other_user}","gists_url":"https://api.github.com/users/movitto/gists{/gist_id}","starred_url":"https://api.github.com/users/movitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movitto/subscriptions","organizations_url":"https://api.github.com/users/movitto/orgs","repos_url":"https://api.github.com/users/movitto/repos","events_url":"https://api.github.com/users/movitto/events{/privacy}","received_events_url":"https://api.github.com/users/movitto/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-01-21T20:16:48Z","updated_at":"2015-09-05T13:20:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1431","html_url":"https://github.com/ManageIQ/manageiq/pull/1431","diff_url":"https://github.com/ManageIQ/manageiq/pull/1431.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1431.patch"},"body":"Extracted from #1324"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/137955633","html_url":"https://github.com/ManageIQ/manageiq/pull/1431#issuecomment-137955633","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1431","id":137955633,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T13:20:35Z","updated_at":"2015-09-05T13:20:35Z","body":"<rubocop />Checked commit https://github.com/movitto/manageiq/commit/274229559ad904fca45a4f70728f7d0ec151c4f2 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0\n3 files checked, 24 offenses detected\n\n**gems/pending/spec/disk/miq_disk_spec.rb**\n- [ ] :red_circle: **Warn** - [Line 228](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L228), Col 19 - [Lint/AmbiguousOperator](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/AmbiguousOperator) - Ambiguous negative number operator. Parenthesize the method arguments if it's surely a negative number operator, or add a whitespace to the right of the `-` if it should be a subtraction.\n- [ ] :large_orange_diamond: - [Line 32](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L32), Col 18 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 9) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 92](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L92), Col 9 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 1) spaces for indentation.\n- [ ] :large_orange_diamond: - [Line 137](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L137), Col 60 - [Style/Semicolon](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/Semicolon) - Do not use semicolons to terminate expressions.\n- [ ] :large_orange_diamond: - [Line 144](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L144), Col 66 - [Style/Semicolon](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/Semicolon) - Do not use semicolons to terminate expressions.\n- [ ] :large_orange_diamond: - [Line 151](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L151), Col 67 - [Style/Semicolon](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/Semicolon) - Do not use semicolons to terminate expressions.\n- [ ] :large_orange_diamond: - [Line 159](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L159), Col 1 - [Style/TrailingWhitespace](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/TrailingWhitespace) - Trailing whitespace detected.\n- [ ] :large_orange_diamond: - [Line 181](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L181), Col 22 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 294](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L294), Col 11 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 296](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L296), Col 11 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 298](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L298), Col 40 - [Style/NumericLiterals](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/NumericLiterals) - Separate every 3 digits in the integer portion of a number with underscores(_).\n- [ ] :large_orange_diamond: - [Line 394](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L394), Col 3 - [Style/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/LeadingCommentSpace) - Missing space after #.\n- [ ] :large_orange_diamond: - [Line 396](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/disk/miq_disk_spec.rb#L396), Col 3 - [Style/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/LeadingCommentSpace) - Missing space after #.\n\n**gems/pending/spec/support/core_ext.rb**\n- [ ] :large_orange_diamond: - [Line 6](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/core_ext.rb#L6), Col 5 - [Style/RedundantReturn](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/RedundantReturn) - Redundant `return` detected.\n\n**gems/pending/spec/support/disk/TestDisk.rb**\n- [ ] :red_circle: **Warn** - [Line 6](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L6), Col 14 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `pos`. If it's necessary, use `_` or `_pos` as an argument name to indicate that it won't be used. You can also write as `d_read(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 6](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L6), Col 19 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `len`. If it's necessary, use `_` or `_len` as an argument name to indicate that it won't be used. You can also write as `d_read(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 6](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L6), Col 24 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `offset`. If it's necessary, use `_` or `_offset` as an argument name to indicate that it won't be used. You can also write as `d_read(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 10](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L10), Col 15 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `pos`. If it's necessary, use `_` or `_pos` as an argument name to indicate that it won't be used. You can also write as `d_write(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 10](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L10), Col 20 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `buf`. If it's necessary, use `_` or `_buf` as an argument name to indicate that it won't be used. You can also write as `d_write(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 10](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L10), Col 25 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `len`. If it's necessary, use `_` or `_len` as an argument name to indicate that it won't be used. You can also write as `d_write(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 10](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L10), Col 30 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `offset`. If it's necessary, use `_` or `_offset` as an argument name to indicate that it won't be used. You can also write as `d_write(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :large_orange_diamond: - [Line 1](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L1), Col 1 - [Style/FileName](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/FileName) - Use snake_case for source file names.\n- [ ] :large_orange_diamond: - [Line 3](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L3), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 7](https://github.com/movitto/manageiq/blob/274229559ad904fca45a4f70728f7d0ec151c4f2/gems/pending/spec/support/disk/TestDisk.rb#L7), Col 5 - [Style/RedundantReturn](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/RedundantReturn) - Redundant `return` detected.\n"}}