{"action":"closed","number":347,"pull_request":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/347","id":51439065,"html_url":"https://github.com/ethereum/web3.js/pull/347","diff_url":"https://github.com/ethereum/web3.js/pull/347.diff","patch_url":"https://github.com/ethereum/web3.js/pull/347.patch","issue_url":"https://api.github.com/repos/ethereum/web3.js/issues/347","number":347,"state":"closed","locked":false,"title":"web3/shh: fix non-ASCII payloads","user":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"body":"This PR fixes an issue when filters receive payload with non-ASCII data.\r\n\r\nCloses #346 \r\n\r\n**DO NOT MERGE YET**","created_at":"2015-11-21T10:58:24Z","updated_at":"2015-11-24T13:54:08Z","closed_at":"2015-11-24T13:54:08Z","merged_at":null,"merge_commit_sha":"18001a6164fc9179424c62c926367d9154132919","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/web3.js/pulls/347/commits","review_comments_url":"https://api.github.com/repos/ethereum/web3.js/pulls/347/comments","review_comment_url":"https://api.github.com/repos/ethereum/web3.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/web3.js/issues/347/comments","statuses_url":"https://api.github.com/repos/ethereum/web3.js/statuses/bd55d169abff9bb253fbc2a5436c323b3eab5a1d","head":{"label":"ethereum:obscuren-patch-1","ref":"obscuren-patch-1","sha":"bd55d169abff9bb253fbc2a5436c323b3eab5a1d","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":24655114,"name":"web3.js","full_name":"ethereum/web3.js","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/web3.js","description":"Ethereum Compatible JavaScript API","fork":false,"url":"https://api.github.com/repos/ethereum/web3.js","forks_url":"https://api.github.com/repos/ethereum/web3.js/forks","keys_url":"https://api.github.com/repos/ethereum/web3.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/web3.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/web3.js/teams","hooks_url":"https://api.github.com/repos/ethereum/web3.js/hooks","issue_events_url":"https://api.github.com/repos/ethereum/web3.js/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/web3.js/events","assignees_url":"https://api.github.com/repos/ethereum/web3.js/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/web3.js/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/web3.js/tags","blobs_url":"https://api.github.com/repos/ethereum/web3.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/web3.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/web3.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/web3.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/web3.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/web3.js/languages","stargazers_url":"https://api.github.com/repos/ethereum/web3.js/stargazers","contributors_url":"https://api.github.com/repos/ethereum/web3.js/contributors","subscribers_url":"https://api.github.com/repos/ethereum/web3.js/subscribers","subscription_url":"https://api.github.com/repos/ethereum/web3.js/subscription","commits_url":"https://api.github.com/repos/ethereum/web3.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/web3.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/web3.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/web3.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/web3.js/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/web3.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/web3.js/merges","archive_url":"https://api.github.com/repos/ethereum/web3.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/web3.js/downloads","issues_url":"https://api.github.com/repos/ethereum/web3.js/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/web3.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/web3.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/web3.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/web3.js/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/web3.js/releases{/id}","created_at":"2014-09-30T20:50:37Z","updated_at":"2015-11-23T19:24:33Z","pushed_at":"2015-11-21T11:03:42Z","git_url":"git://github.com/ethereum/web3.js.git","ssh_url":"git@github.com:ethereum/web3.js.git","clone_url":"https://github.com/ethereum/web3.js.git","svn_url":"https://github.com/ethereum/web3.js","homepage":null,"size":17707,"stargazers_count":150,"watchers_count":150,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":39,"forks":67,"open_issues":39,"watchers":150,"default_branch":"master"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"8c3492b656a8aec6b94ed53ba412582ad00ca956","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":24655114,"name":"web3.js","full_name":"ethereum/web3.js","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/web3.js","description":"Ethereum Compatible JavaScript API","fork":false,"url":"https://api.github.com/repos/ethereum/web3.js","forks_url":"https://api.github.com/repos/ethereum/web3.js/forks","keys_url":"https://api.github.com/repos/ethereum/web3.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/web3.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/web3.js/teams","hooks_url":"https://api.github.com/repos/ethereum/web3.js/hooks","issue_events_url":"https://api.github.com/repos/ethereum/web3.js/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/web3.js/events","assignees_url":"https://api.github.com/repos/ethereum/web3.js/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/web3.js/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/web3.js/tags","blobs_url":"https://api.github.com/repos/ethereum/web3.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/web3.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/web3.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/web3.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/web3.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/web3.js/languages","stargazers_url":"https://api.github.com/repos/ethereum/web3.js/stargazers","contributors_url":"https://api.github.com/repos/ethereum/web3.js/contributors","subscribers_url":"https://api.github.com/repos/ethereum/web3.js/subscribers","subscription_url":"https://api.github.com/repos/ethereum/web3.js/subscription","commits_url":"https://api.github.com/repos/ethereum/web3.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/web3.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/web3.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/web3.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/web3.js/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/web3.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/web3.js/merges","archive_url":"https://api.github.com/repos/ethereum/web3.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/web3.js/downloads","issues_url":"https://api.github.com/repos/ethereum/web3.js/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/web3.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/web3.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/web3.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/web3.js/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/web3.js/releases{/id}","created_at":"2014-09-30T20:50:37Z","updated_at":"2015-11-23T19:24:33Z","pushed_at":"2015-11-21T11:03:42Z","git_url":"git://github.com/ethereum/web3.js.git","ssh_url":"git@github.com:ethereum/web3.js.git","clone_url":"https://github.com/ethereum/web3.js.git","svn_url":"https://github.com/ethereum/web3.js","homepage":null,"size":17707,"stargazers_count":150,"watchers_count":150,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":39,"forks":67,"open_issues":39,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/347"},"html":{"href":"https://github.com/ethereum/web3.js/pull/347"},"issue":{"href":"https://api.github.com/repos/ethereum/web3.js/issues/347"},"comments":{"href":"https://api.github.com/repos/ethereum/web3.js/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/web3.js/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/web3.js/statuses/bd55d169abff9bb253fbc2a5436c323b3eab5a1d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":2,"additions":5,"deletions":1,"changed_files":1}}