{"action":"created","comment":{"url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/comments/28653987","id":28653987,"diff_hunk":"@@ -9,23 +9,47 @@ title: Add Bootstrap\n \n %p The app doesn't look very nice yet. Let's do something about that. We'll use the Twitter Bootstrap project to give us nicer styling really easily.\n \n-Open `app/views/layouts/application.html.erb` in your text editor and above the line\n+Open the `Gemfile` in your text editor and below the line\n \n = preserve do\n-  - code(\"erb\") do\n-    ='<%= stylesheet_link_tag    \"application\", media: \"all\", \"data-turbolinks-track\" => true %>'\n+  - code(\"ruby\") do\n+    source 'https://rubygems.org'\n+\n add\n+\n+= preserve do\n+  - code(\"ruby\") do\n+    gem 'bootstrap-sass', '~> 3.2.0'\n+\n+\n+And then run in your terminal:\n = preserve do\n-  - code(\"erb\") do\n-    %link{href: \"http://railsgirls.co.il/bootstrap/css/bootstrap.css\", rel: \"stylesheet\"}/\n-    %link{href: \"http://railsgirls.co.il/bootstrap/css/bootstrap-theme.css\", rel: \"stylesheet\"}/\n-and replace\n-\n-= preserve do \n-  - code(\"erb\") do\n-    \\<%= yield %>\n-with\n+  - code(\"sh\") do\n+    bundle install\n+\n+%br\n+\n+Next, rename `app/assets/stylesheets/application.css` to `app/assets/stylesheets/application.css.sass`.\n+\n+%br\n+\n+Then we can import the Bootstrap assets in your newly-renamed `application.css.sass` file.\n+%p In the end of the file `application.css.sass` add those lines:\n+\n = preserve do\n-  - code(\"erb\") do\n-    .container\n-      \\<%= yield %>\n\\ No newline at end of file\n+  - code(\"ruby\") do\n+    @import \"bootstrap-sprockets\"\n+    @import \"bootstrap\"\n+\n+%br\n+\n+Finally, open the file `app/assets/javascripts/application.js` in your text editor, and under the line:\n+\n+%br\n+%br\n+\n+`//= require jquery`","path":"source/localizable/guides/app/design/bootstrap.en.html.markdown.haml","position":59,"original_position":59,"commit_id":"a1b804e918e07b0da771ea7168d6e8efc06c3bed","original_commit_id":"a1b804e918e07b0da771ea7168d6e8efc06c3bed","user":{"login":"ilonashub","id":8695358,"avatar_url":"https://avatars.githubusercontent.com/u/8695358?v=3","gravatar_id":"","url":"https://api.github.com/users/ilonashub","html_url":"https://github.com/ilonashub","followers_url":"https://api.github.com/users/ilonashub/followers","following_url":"https://api.github.com/users/ilonashub/following{/other_user}","gists_url":"https://api.github.com/users/ilonashub/gists{/gist_id}","starred_url":"https://api.github.com/users/ilonashub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilonashub/subscriptions","organizations_url":"https://api.github.com/users/ilonashub/orgs","repos_url":"https://api.github.com/users/ilonashub/repos","events_url":"https://api.github.com/users/ilonashub/events{/privacy}","received_events_url":"https://api.github.com/users/ilonashub/received_events","type":"User","site_admin":false},"body":"No support for `code` to this kind of JS writing... :(","created_at":"2015-04-19T15:47:26Z","updated_at":"2015-04-19T15:47:26Z","html_url":"https://github.com/rotev/rails-girls-il/pull/52#discussion_r28653987","pull_request_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/comments/28653987"},"html":{"href":"https://github.com/rotev/rails-girls-il/pull/52#discussion_r28653987"},"pull_request":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52","id":33620787,"html_url":"https://github.com/rotev/rails-girls-il/pull/52","diff_url":"https://github.com/rotev/rails-girls-il/pull/52.diff","patch_url":"https://github.com/rotev/rails-girls-il/pull/52.patch","issue_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/52","number":52,"state":"open","locked":false,"title":"Use bootstrap as a gem instead of loading it from the internet each time...","user":{"login":"ilonashub","id":8695358,"avatar_url":"https://avatars.githubusercontent.com/u/8695358?v=3","gravatar_id":"","url":"https://api.github.com/users/ilonashub","html_url":"https://github.com/ilonashub","followers_url":"https://api.github.com/users/ilonashub/followers","following_url":"https://api.github.com/users/ilonashub/following{/other_user}","gists_url":"https://api.github.com/users/ilonashub/gists{/gist_id}","starred_url":"https://api.github.com/users/ilonashub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilonashub/subscriptions","organizations_url":"https://api.github.com/users/ilonashub/orgs","repos_url":"https://api.github.com/users/ilonashub/repos","events_url":"https://api.github.com/users/ilonashub/events{/privacy}","received_events_url":"https://api.github.com/users/ilonashub/received_events","type":"User","site_admin":false},"body":"Use bootstrap as a gem instead of loading it from the internet each time we use it. Also separate the bootstrap gem instructions from the changing the html instructions. Instructions are according to this:\r\nhttp://www.gotealeaf.com/blog/integrating-rails-and-bootstrap-part-1/ \r\n\r\n![image](https://cloud.githubusercontent.com/assets/8695358/7220077/29662e88-e6c4-11e4-9f0e-a4d28d3b8e2e.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8695358/7220078/31f38b40-e6c4-11e4-8f22-38661db60b97.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8695358/7220080/3b7c4aee-e6c4-11e4-8b1d-5be452512372.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8695358/7220082/4419986e-e6c4-11e4-9575-722d9c60cbcc.png)","created_at":"2015-04-19T15:46:24Z","updated_at":"2015-04-19T15:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6969e1a225d6e6b014a1fab65311700248e23a9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52/commits","review_comments_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52/comments","review_comment_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/52/comments","statuses_url":"https://api.github.com/repos/rotev/rails-girls-il/statuses/a1b804e918e07b0da771ea7168d6e8efc06c3bed","head":{"label":"rotev:add-bootstrap-gem","ref":"add-bootstrap-gem","sha":"a1b804e918e07b0da771ea7168d6e8efc06c3bed","user":{"login":"rotev","id":562267,"avatar_url":"https://avatars.githubusercontent.com/u/562267?v=3","gravatar_id":"","url":"https://api.github.com/users/rotev","html_url":"https://github.com/rotev","followers_url":"https://api.github.com/users/rotev/followers","following_url":"https://api.github.com/users/rotev/following{/other_user}","gists_url":"https://api.github.com/users/rotev/gists{/gist_id}","starred_url":"https://api.github.com/users/rotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotev/subscriptions","organizations_url":"https://api.github.com/users/rotev/orgs","repos_url":"https://api.github.com/users/rotev/repos","events_url":"https://api.github.com/users/rotev/events{/privacy}","received_events_url":"https://api.github.com/users/rotev/received_events","type":"User","site_admin":false},"repo":{"id":15176029,"name":"rails-girls-il","full_name":"rotev/rails-girls-il","owner":{"login":"rotev","id":562267,"avatar_url":"https://avatars.githubusercontent.com/u/562267?v=3","gravatar_id":"","url":"https://api.github.com/users/rotev","html_url":"https://github.com/rotev","followers_url":"https://api.github.com/users/rotev/followers","following_url":"https://api.github.com/users/rotev/following{/other_user}","gists_url":"https://api.github.com/users/rotev/gists{/gist_id}","starred_url":"https://api.github.com/users/rotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotev/subscriptions","organizations_url":"https://api.github.com/users/rotev/orgs","repos_url":"https://api.github.com/users/rotev/repos","events_url":"https://api.github.com/users/rotev/events{/privacy}","received_events_url":"https://api.github.com/users/rotev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rotev/rails-girls-il","description":"Rails Girls Tel-Aviv–Yaffo/Israel website","fork":false,"url":"https://api.github.com/repos/rotev/rails-girls-il","forks_url":"https://api.github.com/repos/rotev/rails-girls-il/forks","keys_url":"https://api.github.com/repos/rotev/rails-girls-il/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rotev/rails-girls-il/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rotev/rails-girls-il/teams","hooks_url":"https://api.github.com/repos/rotev/rails-girls-il/hooks","issue_events_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/events{/number}","events_url":"https://api.github.com/repos/rotev/rails-girls-il/events","assignees_url":"https://api.github.com/repos/rotev/rails-girls-il/assignees{/user}","branches_url":"https://api.github.com/repos/rotev/rails-girls-il/branches{/branch}","tags_url":"https://api.github.com/repos/rotev/rails-girls-il/tags","blobs_url":"https://api.github.com/repos/rotev/rails-girls-il/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rotev/rails-girls-il/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rotev/rails-girls-il/git/refs{/sha}","trees_url":"https://api.github.com/repos/rotev/rails-girls-il/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rotev/rails-girls-il/statuses/{sha}","languages_url":"https://api.github.com/repos/rotev/rails-girls-il/languages","stargazers_url":"https://api.github.com/repos/rotev/rails-girls-il/stargazers","contributors_url":"https://api.github.com/repos/rotev/rails-girls-il/contributors","subscribers_url":"https://api.github.com/repos/rotev/rails-girls-il/subscribers","subscription_url":"https://api.github.com/repos/rotev/rails-girls-il/subscription","commits_url":"https://api.github.com/repos/rotev/rails-girls-il/commits{/sha}","git_commits_url":"https://api.github.com/repos/rotev/rails-girls-il/git/commits{/sha}","comments_url":"https://api.github.com/repos/rotev/rails-girls-il/comments{/number}","issue_comment_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/comments{/number}","contents_url":"https://api.github.com/repos/rotev/rails-girls-il/contents/{+path}","compare_url":"https://api.github.com/repos/rotev/rails-girls-il/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rotev/rails-girls-il/merges","archive_url":"https://api.github.com/repos/rotev/rails-girls-il/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rotev/rails-girls-il/downloads","issues_url":"https://api.github.com/repos/rotev/rails-girls-il/issues{/number}","pulls_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls{/number}","milestones_url":"https://api.github.com/repos/rotev/rails-girls-il/milestones{/number}","notifications_url":"https://api.github.com/repos/rotev/rails-girls-il/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rotev/rails-girls-il/labels{/name}","releases_url":"https://api.github.com/repos/rotev/rails-girls-il/releases{/id}","created_at":"2013-12-13T22:55:45Z","updated_at":"2015-03-17T12:48:20Z","pushed_at":"2015-04-19T15:46:25Z","git_url":"git://github.com/rotev/rails-girls-il.git","ssh_url":"git@github.com:rotev/rails-girls-il.git","clone_url":"https://github.com/rotev/rails-girls-il.git","svn_url":"https://github.com/rotev/rails-girls-il","homepage":"http://railsgirls.co.il","size":5309,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"rotev:master","ref":"master","sha":"00d2ae4bb47577b694246f1561c69b399788c4b5","user":{"login":"rotev","id":562267,"avatar_url":"https://avatars.githubusercontent.com/u/562267?v=3","gravatar_id":"","url":"https://api.github.com/users/rotev","html_url":"https://github.com/rotev","followers_url":"https://api.github.com/users/rotev/followers","following_url":"https://api.github.com/users/rotev/following{/other_user}","gists_url":"https://api.github.com/users/rotev/gists{/gist_id}","starred_url":"https://api.github.com/users/rotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotev/subscriptions","organizations_url":"https://api.github.com/users/rotev/orgs","repos_url":"https://api.github.com/users/rotev/repos","events_url":"https://api.github.com/users/rotev/events{/privacy}","received_events_url":"https://api.github.com/users/rotev/received_events","type":"User","site_admin":false},"repo":{"id":15176029,"name":"rails-girls-il","full_name":"rotev/rails-girls-il","owner":{"login":"rotev","id":562267,"avatar_url":"https://avatars.githubusercontent.com/u/562267?v=3","gravatar_id":"","url":"https://api.github.com/users/rotev","html_url":"https://github.com/rotev","followers_url":"https://api.github.com/users/rotev/followers","following_url":"https://api.github.com/users/rotev/following{/other_user}","gists_url":"https://api.github.com/users/rotev/gists{/gist_id}","starred_url":"https://api.github.com/users/rotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotev/subscriptions","organizations_url":"https://api.github.com/users/rotev/orgs","repos_url":"https://api.github.com/users/rotev/repos","events_url":"https://api.github.com/users/rotev/events{/privacy}","received_events_url":"https://api.github.com/users/rotev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rotev/rails-girls-il","description":"Rails Girls Tel-Aviv–Yaffo/Israel website","fork":false,"url":"https://api.github.com/repos/rotev/rails-girls-il","forks_url":"https://api.github.com/repos/rotev/rails-girls-il/forks","keys_url":"https://api.github.com/repos/rotev/rails-girls-il/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rotev/rails-girls-il/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rotev/rails-girls-il/teams","hooks_url":"https://api.github.com/repos/rotev/rails-girls-il/hooks","issue_events_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/events{/number}","events_url":"https://api.github.com/repos/rotev/rails-girls-il/events","assignees_url":"https://api.github.com/repos/rotev/rails-girls-il/assignees{/user}","branches_url":"https://api.github.com/repos/rotev/rails-girls-il/branches{/branch}","tags_url":"https://api.github.com/repos/rotev/rails-girls-il/tags","blobs_url":"https://api.github.com/repos/rotev/rails-girls-il/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rotev/rails-girls-il/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rotev/rails-girls-il/git/refs{/sha}","trees_url":"https://api.github.com/repos/rotev/rails-girls-il/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rotev/rails-girls-il/statuses/{sha}","languages_url":"https://api.github.com/repos/rotev/rails-girls-il/languages","stargazers_url":"https://api.github.com/repos/rotev/rails-girls-il/stargazers","contributors_url":"https://api.github.com/repos/rotev/rails-girls-il/contributors","subscribers_url":"https://api.github.com/repos/rotev/rails-girls-il/subscribers","subscription_url":"https://api.github.com/repos/rotev/rails-girls-il/subscription","commits_url":"https://api.github.com/repos/rotev/rails-girls-il/commits{/sha}","git_commits_url":"https://api.github.com/repos/rotev/rails-girls-il/git/commits{/sha}","comments_url":"https://api.github.com/repos/rotev/rails-girls-il/comments{/number}","issue_comment_url":"https://api.github.com/repos/rotev/rails-girls-il/issues/comments{/number}","contents_url":"https://api.github.com/repos/rotev/rails-girls-il/contents/{+path}","compare_url":"https://api.github.com/repos/rotev/rails-girls-il/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rotev/rails-girls-il/merges","archive_url":"https://api.github.com/repos/rotev/rails-girls-il/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rotev/rails-girls-il/downloads","issues_url":"https://api.github.com/repos/rotev/rails-girls-il/issues{/number}","pulls_url":"https://api.github.com/repos/rotev/rails-girls-il/pulls{/number}","milestones_url":"https://api.github.com/repos/rotev/rails-girls-il/milestones{/number}","notifications_url":"https://api.github.com/repos/rotev/rails-girls-il/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rotev/rails-girls-il/labels{/name}","releases_url":"https://api.github.com/repos/rotev/rails-girls-il/releases{/id}","created_at":"2013-12-13T22:55:45Z","updated_at":"2015-03-17T12:48:20Z","pushed_at":"2015-04-19T15:46:25Z","git_url":"git://github.com/rotev/rails-girls-il.git","ssh_url":"git@github.com:rotev/rails-girls-il.git","clone_url":"https://github.com/rotev/rails-girls-il.git","svn_url":"https://github.com/rotev/rails-girls-il","homepage":"http://railsgirls.co.il","size":5309,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52"},"html":{"href":"https://github.com/rotev/rails-girls-il/pull/52"},"issue":{"href":"https://api.github.com/repos/rotev/rails-girls-il/issues/52"},"comments":{"href":"https://api.github.com/repos/rotev/rails-girls-il/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rotev/rails-girls-il/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/rotev/rails-girls-il/statuses/a1b804e918e07b0da771ea7168d6e8efc06c3bed"}}}}