{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/27190030","id":27190030,"diff_hunk":"@@ -195,7 +186,7 @@ def _find_existing_instance(self):\n         domains = yield self.connection.all()\n         for d in domains:\n             name = yield d.name()\n-            if name.startswith(self.name):\n+            if name.startswith(self.slavename):","path":"master/buildbot/buildslave/libvirt.py","position":30,"original_position":30,"commit_id":"9586d33cd1dfeec4865732feadbb830524be3e5d","original_commit_id":"9586d33cd1dfeec4865732feadbb830524be3e5d","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"I'm inclined toward `name`.  However, `.name` was not available.  It probably needs to be fixed up in the chain...","created_at":"2015-03-26T05:56:48Z","updated_at":"2015-03-26T05:56:48Z","html_url":"https://github.com/buildbot/buildbot/pull/1609#discussion_r27190030","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1609","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/27190030"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1609#discussion_r27190030"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1609"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1609","id":31861063,"html_url":"https://github.com/buildbot/buildbot/pull/1609","diff_url":"https://github.com/buildbot/buildbot/pull/1609.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1609.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1609","number":1609,"state":"open","locked":false,"title":"Refactor buildslave related code","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"* the most important thing is moving handling of commong parameters to base classes","created_at":"2015-03-24T19:22:07Z","updated_at":"2015-03-26T05:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecb9465f1e116283ae4c5d417c4ed8c0b39b6af3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1609/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1609/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1609/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/9586d33cd1dfeec4865732feadbb830524be3e5d","head":{"label":"sa2ajj:simplify-buildslaves","ref":"simplify-buildslaves","sha":"9586d33cd1dfeec4865732feadbb830524be3e5d","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"repo":{"id":21306128,"name":"buildbot","full_name":"sa2ajj/buildbot","owner":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sa2ajj/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/sa2ajj/buildbot","forks_url":"https://api.github.com/repos/sa2ajj/buildbot/forks","keys_url":"https://api.github.com/repos/sa2ajj/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sa2ajj/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sa2ajj/buildbot/teams","hooks_url":"https://api.github.com/repos/sa2ajj/buildbot/hooks","issue_events_url":"https://api.github.com/repos/sa2ajj/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/sa2ajj/buildbot/events","assignees_url":"https://api.github.com/repos/sa2ajj/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/sa2ajj/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/sa2ajj/buildbot/tags","blobs_url":"https://api.github.com/repos/sa2ajj/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sa2ajj/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sa2ajj/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sa2ajj/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sa2ajj/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/sa2ajj/buildbot/languages","stargazers_url":"https://api.github.com/repos/sa2ajj/buildbot/stargazers","contributors_url":"https://api.github.com/repos/sa2ajj/buildbot/contributors","subscribers_url":"https://api.github.com/repos/sa2ajj/buildbot/subscribers","subscription_url":"https://api.github.com/repos/sa2ajj/buildbot/subscription","commits_url":"https://api.github.com/repos/sa2ajj/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sa2ajj/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sa2ajj/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sa2ajj/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sa2ajj/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/sa2ajj/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sa2ajj/buildbot/merges","archive_url":"https://api.github.com/repos/sa2ajj/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sa2ajj/buildbot/downloads","issues_url":"https://api.github.com/repos/sa2ajj/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/sa2ajj/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/sa2ajj/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/sa2ajj/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sa2ajj/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/sa2ajj/buildbot/releases{/id}","created_at":"2014-06-28T15:55:46Z","updated_at":"2015-03-25T18:27:20Z","pushed_at":"2015-03-25T18:33:30Z","git_url":"git://github.com/sa2ajj/buildbot.git","ssh_url":"git@github.com:sa2ajj/buildbot.git","clone_url":"https://github.com/sa2ajj/buildbot.git","svn_url":"https://github.com/sa2ajj/buildbot","homepage":"http://buildbot.net","size":36043,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"upstream"}},"base":{"label":"buildbot:master","ref":"master","sha":"0fdb4c74552c7ed7af89ff827d56e3c132fea375","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2015-03-26T05:55:58Z","pushed_at":"2015-03-25T18:33:31Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":50460,"stargazers_count":1450,"watchers_count":1450,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":676,"mirror_url":null,"open_issues_count":22,"forks":676,"open_issues":22,"watchers":1450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1609"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1609"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1609"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1609/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1609/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1609/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/9586d33cd1dfeec4865732feadbb830524be3e5d"}}}}