{"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/37725029","id":37725029,"diff_hunk":"@@ -334,4 +334,9 @@ class CfgVehicles {\n         GVAR(canRepair) = 1;\n         transportRepair = 0;\n     };\n+\n+    class Quadbike_01_base_F;\n+    class B_Quadbike_01_F: Quadbike_01_base_F {\n+        GVAR(hitpointPositions[]) = {\"HitEngine\", \"0, 0.5, -0.7\", \"HitFuel\", \"0, 0, -0.5\"};","path":"addons/repair/CfgVehicles.hpp","position":7,"original_position":7,"commit_id":"94c4c411e262d6e166a2fda3991f82048faa41b7","original_commit_id":"94c4c411e262d6e166a2fda3991f82048faa41b7","user":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"body":"I dislike this format. I'd prefer a 2d array for this instead. \r\n\r\n`{ {\"HitEngine\", {0, 0.5, -0.7} }, {\"HitFuel\", {0, 0, -0.5} } };`","created_at":"2015-08-24T07:30:52Z","updated_at":"2015-08-24T07:30:52Z","html_url":"https://github.com/acemod/ACE3/pull/2245#discussion_r37725029","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/2245","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/37725029"},"html":{"href":"https://github.com/acemod/ACE3/pull/2245#discussion_r37725029"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2245"}}},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/2245","id":43131473,"html_url":"https://github.com/acemod/ACE3/pull/2245","diff_url":"https://github.com/acemod/ACE3/pull/2245.diff","patch_url":"https://github.com/acemod/ACE3/pull/2245.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/2245","number":2245,"state":"open","locked":false,"title":"Added Custom Hitpoint Repair Positions Framework","user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"body":"**Overview:**\r\nAdds a framework for custom hitpoint positions/selection names to be used as position to render the repair action of the specified hitpoint. Most default selections (except Winch) have position of `[0,0,0]` which obviously doesn't work, the check if it's on that location was added to prevent being over the base interaction menu (if it is on zero location, it will be grouped into the base interaction menu as before).\r\n\r\n**Config entries:**\r\n`GVAR(hitpointPositions[]) = {\"HitPointName\", \"position\"};`\r\nExample:\r\n`GVAR(hitpointPositions[]) = {\"HitEngine\", \"0, 1, -1\", \"HitFuel\", \"0, 0, -0.5\"};`\r\n(It is impossible to use array in a config array, so I decided to parse the string into an array.)\r\n\r\nInstead of a position it can also be a selection name:\r\n`GVAR(hitpointPositions[]) = {\"HitEngine\", \"engineSelection\"};`\r\n\r\n\r\n**Side-note:**\r\n`IGNORED_HITPOINTS` was also removed, since all it did was prevent glasses from being repaired (and it can be freaking nasty to drive/fly with a broken window). I will be adding framework for grouping hitpoints (so you fix another hitpoint when you fix one, but doesn't show in the menu) in another PR.\r\n\r\n**API Suggestion:**\r\nI suggest a check of `[0,0,0]` position is made in public API for adding the actions to interaction menu, the only thing it does is cover the base interaction point.","created_at":"2015-08-23T23:57:55Z","updated_at":"2015-08-24T07:30:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05dce5911d70296ad5497aeac998c1c8d352703b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/2245/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/2245/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/2245/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/94c4c411e262d6e166a2fda3991f82048faa41b7","head":{"label":"jonpas:repairHitpointSelections","ref":"repairHitpointSelections","sha":"94c4c411e262d6e166a2fda3991f82048faa41b7","user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"repo":{"id":35702319,"name":"ACE3","full_name":"jonpas/ACE3","owner":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonpas/ACE3","description":"Open-source realism mod for Arma 3","fork":true,"url":"https://api.github.com/repos/jonpas/ACE3","forks_url":"https://api.github.com/repos/jonpas/ACE3/forks","keys_url":"https://api.github.com/repos/jonpas/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonpas/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonpas/ACE3/teams","hooks_url":"https://api.github.com/repos/jonpas/ACE3/hooks","issue_events_url":"https://api.github.com/repos/jonpas/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/jonpas/ACE3/events","assignees_url":"https://api.github.com/repos/jonpas/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/jonpas/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/jonpas/ACE3/tags","blobs_url":"https://api.github.com/repos/jonpas/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonpas/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonpas/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonpas/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonpas/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/jonpas/ACE3/languages","stargazers_url":"https://api.github.com/repos/jonpas/ACE3/stargazers","contributors_url":"https://api.github.com/repos/jonpas/ACE3/contributors","subscribers_url":"https://api.github.com/repos/jonpas/ACE3/subscribers","subscription_url":"https://api.github.com/repos/jonpas/ACE3/subscription","commits_url":"https://api.github.com/repos/jonpas/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonpas/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonpas/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonpas/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonpas/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/jonpas/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonpas/ACE3/merges","archive_url":"https://api.github.com/repos/jonpas/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonpas/ACE3/downloads","issues_url":"https://api.github.com/repos/jonpas/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/jonpas/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/jonpas/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/jonpas/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonpas/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/jonpas/ACE3/releases{/id}","created_at":"2015-05-15T23:52:18Z","updated_at":"2015-05-15T23:52:23Z","pushed_at":"2015-08-24T03:24:31Z","git_url":"git://github.com/jonpas/ACE3.git","ssh_url":"git@github.com:jonpas/ACE3.git","clone_url":"https://github.com/jonpas/ACE3.git","svn_url":"https://github.com/jonpas/ACE3","homepage":"http://ace3mod.com/","size":243389,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"27d974687e38b3233bdd20907a004db103a551de","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","created_at":"2015-01-10T19:59:12Z","updated_at":"2015-08-22T23:00:03Z","pushed_at":"2015-08-24T06:01:01Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":370446,"stargazers_count":286,"watchers_count":286,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":221,"mirror_url":null,"open_issues_count":280,"forks":221,"open_issues":280,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2245"},"html":{"href":"https://github.com/acemod/ACE3/pull/2245"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/2245"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/2245/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2245/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2245/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/94c4c411e262d6e166a2fda3991f82048faa41b7"}}}}