{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/28990905","id":28990905,"diff_hunk":"@@ -46,7 +47,11 @@ public static function getLangForPageShare( $browserLang, $useLang ) {\n \t\t}\n \t}\n \n-\tpublic static function isValidShareService( $service, $lang ) {\n+\tpublic static function isValidShareService( $service, $lang, $isTouchScreen ) {\n+\t\t//Don't display LINE social network (because it's a mobile app) on desktops\n+\t\tif ( $isTouchScreen === 'false' && ( $service['name'] === self::LINE_NAME ) ) {","path":"extensions/wikia/PageShare/PageShareHelper.class.php","position":15,"original_position":15,"commit_id":"37b5d0c639532c9843f2049b7c3cd8107624797d","original_commit_id":"37b5d0c639532c9843f2049b7c3cd8107624797d","user":{"login":"dianafa","id":3716441,"avatar_url":"https://avatars.githubusercontent.com/u/3716441?v=3","gravatar_id":"","url":"https://api.github.com/users/dianafa","html_url":"https://github.com/dianafa","followers_url":"https://api.github.com/users/dianafa/followers","following_url":"https://api.github.com/users/dianafa/following{/other_user}","gists_url":"https://api.github.com/users/dianafa/gists{/gist_id}","starred_url":"https://api.github.com/users/dianafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianafa/subscriptions","organizations_url":"https://api.github.com/users/dianafa/orgs","repos_url":"https://api.github.com/users/dianafa/repos","events_url":"https://api.github.com/users/dianafa/events{/privacy}","received_events_url":"https://api.github.com/users/dianafa/received_events","type":"User","site_admin":false},"body":"yes, it comes as a param - string. Thus evaluating both 'true' and 'false' strings as a bool values always gives true... so `!$isTouchScreen` was always evaluating to false.","created_at":"2015-04-23T18:41:57Z","updated_at":"2015-04-23T18:41:57Z","html_url":"https://github.com/Wikia/app/pull/7010#discussion_r28990905","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/7010","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/28990905"},"html":{"href":"https://github.com/Wikia/app/pull/7010#discussion_r28990905"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/7010"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/7010","id":33972505,"html_url":"https://github.com/Wikia/app/pull/7010","diff_url":"https://github.com/Wikia/app/pull/7010.diff","patch_url":"https://github.com/Wikia/app/pull/7010.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/7010","number":7010,"state":"open","locked":false,"title":"CONCF-483 Launch social buttons international","user":{"login":"dianafa","id":3716441,"avatar_url":"https://avatars.githubusercontent.com/u/3716441?v=3","gravatar_id":"","url":"https://api.github.com/users/dianafa","html_url":"https://github.com/dianafa","followers_url":"https://api.github.com/users/dianafa/followers","following_url":"https://api.github.com/users/dianafa/following{/other_user}","gists_url":"https://api.github.com/users/dianafa/gists{/gist_id}","starred_url":"https://api.github.com/users/dianafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianafa/subscriptions","organizations_url":"https://api.github.com/users/dianafa/orgs","repos_url":"https://api.github.com/users/dianafa/repos","events_url":"https://api.github.com/users/dianafa/events{/privacy}","received_events_url":"https://api.github.com/users/dianafa/received_events","type":"User","site_admin":false},"body":"- wgEnablePageShareWorldwide set to true \r\n- show LINK only for touch screen devices (and japan language)\r\n- fix tests\r\n\r\nping @bognix @Warkot ","created_at":"2015-04-23T16:26:09Z","updated_at":"2015-04-23T18:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1eebf9c47be61334b4e3197a602d5be1c1993b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/7010/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/7010/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/7010/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/37b5d0c639532c9843f2049b7c3cd8107624797d","head":{"label":"Wikia:CONCF-483","ref":"CONCF-483","sha":"37b5d0c639532c9843f2049b7c3cd8107624797d","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-04-23T17:33:02Z","pushed_at":"2015-04-23T17:33:03Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1393970,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":60,"forks":57,"open_issues":60,"watchers":77,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"13d7c76d00fdd38c8edee32579ed35bd5eee1c1e","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-04-23T17:33:02Z","pushed_at":"2015-04-23T17:33:03Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1393970,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":60,"forks":57,"open_issues":60,"watchers":77,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/7010"},"html":{"href":"https://github.com/Wikia/app/pull/7010"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/7010"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/7010/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/7010/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/7010/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/37b5d0c639532c9843f2049b7c3cd8107624797d"}}}}