{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/29048465","id":29048465,"diff_hunk":"@@ -2,21 +2,69 @@ package templaterouter\n \n import (\n \t\"bytes\"\n+\t\"fmt\"\n \t\"github.com/golang/glog\"\n \t\"io/ioutil\"\n \n \trouteapi \"github.com/openshift/origin/pkg/route/api\"\n+\n+\t\"os\"\n )\n \n+// certManagerConfig provides the configuration necessary for certmanager to manipulate certificates.\n+type certManagerConfig struct {\n+\t// certificateKeyFunc is used to find the edge certificate (which also has the key) from the cert map of the ServiceAliasConfig\n+\tcertificateKeyFunc certificateKeyFunc","path":"plugins/router/template/certmanager.go","position":16,"original_position":16,"commit_id":"6a65155c45b2467584db561c57272d1e41125ef7","original_commit_id":"6a65155c45b2467584db561c57272d1e41125ef7","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Field names","created_at":"2015-04-24T13:36:47Z","updated_at":"2015-04-24T13:36:47Z","html_url":"https://github.com/openshift/origin/pull/1817#discussion_r29048465","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/1817","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/29048465"},"html":{"href":"https://github.com/openshift/origin/pull/1817#discussion_r29048465"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/1817"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1817","id":33689872,"html_url":"https://github.com/openshift/origin/pull/1817","diff_url":"https://github.com/openshift/origin/pull/1817.diff","patch_url":"https://github.com/openshift/origin/pull/1817.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/1817","number":1817,"state":"open","locked":false,"title":"Implement cert delete functionality","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"Cert deletes were marked as TODO, this makes them TODONE\r\n\r\nIn order to make the cert manager testable before implementing the delete I refactored it so that you can inject how it writes (and the other config items that were previously hard coded).  Commits are:\r\n1. the refactor of the cert manager\r\n1. the unit tests for the cert manager with a fake cert writer - tests both adds and deletes as well as valid configurations\r\n1. implement the real delete and call the clean up code from deleting service units (services) and individual routes\r\n\r\n@pmorie @abhgupta @smarterclayton @rajatchopra PTAL","created_at":"2015-04-20T17:57:53Z","updated_at":"2015-04-24T13:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27c2884b74a36cb652e72cb515b1f2f42987c96b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/1817/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/1817/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1817/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/6a65155c45b2467584db561c57272d1e41125ef7","head":{"label":"pweil-:certmanager-test","ref":"certmanager-test","sha":"6a65155c45b2467584db561c57272d1e41125ef7","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":24119315,"name":"origin","full_name":"pweil-/origin","owner":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/pweil-/origin","forks_url":"https://api.github.com/repos/pweil-/origin/forks","keys_url":"https://api.github.com/repos/pweil-/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/origin/teams","hooks_url":"https://api.github.com/repos/pweil-/origin/hooks","issue_events_url":"https://api.github.com/repos/pweil-/origin/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/origin/events","assignees_url":"https://api.github.com/repos/pweil-/origin/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/origin/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/origin/tags","blobs_url":"https://api.github.com/repos/pweil-/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/origin/languages","stargazers_url":"https://api.github.com/repos/pweil-/origin/stargazers","contributors_url":"https://api.github.com/repos/pweil-/origin/contributors","subscribers_url":"https://api.github.com/repos/pweil-/origin/subscribers","subscription_url":"https://api.github.com/repos/pweil-/origin/subscription","commits_url":"https://api.github.com/repos/pweil-/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/origin/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/origin/merges","archive_url":"https://api.github.com/repos/pweil-/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/origin/downloads","issues_url":"https://api.github.com/repos/pweil-/origin/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/origin/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/origin/releases{/id}","created_at":"2014-09-16T21:53:06Z","updated_at":"2015-04-20T18:11:17Z","pushed_at":"2015-04-23T16:21:20Z","git_url":"git://github.com/pweil-/origin.git","ssh_url":"git@github.com:pweil-/origin.git","clone_url":"https://github.com/pweil-/origin.git","svn_url":"https://github.com/pweil-/origin","homepage":"https://openshift.github.io","size":83428,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"01be84befb66180f5a567e0aa299bf2debb9e321","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-04-24T07:31:34Z","pushed_at":"2015-04-24T13:29:46Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":137093,"stargazers_count":383,"watchers_count":383,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":226,"forks":192,"open_issues":226,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/1817"},"html":{"href":"https://github.com/openshift/origin/pull/1817"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/1817"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/1817/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/1817/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/1817/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/6a65155c45b2467584db561c57272d1e41125ef7"}}}}