{"action":"closed","number":2316,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/2316","id":46820719,"html_url":"https://github.com/pantsbuild/pants/pull/2316","diff_url":"https://github.com/pantsbuild/pants/pull/2316.diff","patch_url":"https://github.com/pantsbuild/pants/pull/2316.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2316","number":2316,"state":"closed","locked":false,"title":"Separate out AddressMapper from Graph.","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"body":"This restricts responsibility of Graph to just linking addressables.\r\nCurrently Graph links via inlining fully hydrated objects, but it or an\r\nalternative could also traverse to addressables on demand.\r\n\r\nWith AddressMapper extracted, an interface for BUILD file invalidation\r\ncomes to the fore and allows straight-forward integration of in\r\ninvalidation system that watches the build root for BUILD file\r\nadditions, removals and modifications.","created_at":"2015-10-05T19:11:21Z","updated_at":"2015-10-05T21:36:08Z","closed_at":"2015-10-05T21:36:08Z","merged_at":null,"merge_commit_sha":"7e1b678e57faeb581ae205e13ec15f077ce70b49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2316/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2316/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2316/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/eae2ca56ea821f22aa8f088c1d3e7ce815c91437","head":{"label":"jsirois:jsirois/engine/graph/on_the_fly","ref":"jsirois/engine/graph/on_the_fly","sha":"eae2ca56ea821f22aa8f088c1d3e7ce815c91437","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"repo":{"id":19150258,"name":"pants","full_name":"jsirois/pants","owner":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsirois/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/jsirois/pants","forks_url":"https://api.github.com/repos/jsirois/pants/forks","keys_url":"https://api.github.com/repos/jsirois/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsirois/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsirois/pants/teams","hooks_url":"https://api.github.com/repos/jsirois/pants/hooks","issue_events_url":"https://api.github.com/repos/jsirois/pants/issues/events{/number}","events_url":"https://api.github.com/repos/jsirois/pants/events","assignees_url":"https://api.github.com/repos/jsirois/pants/assignees{/user}","branches_url":"https://api.github.com/repos/jsirois/pants/branches{/branch}","tags_url":"https://api.github.com/repos/jsirois/pants/tags","blobs_url":"https://api.github.com/repos/jsirois/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsirois/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsirois/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsirois/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsirois/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/jsirois/pants/languages","stargazers_url":"https://api.github.com/repos/jsirois/pants/stargazers","contributors_url":"https://api.github.com/repos/jsirois/pants/contributors","subscribers_url":"https://api.github.com/repos/jsirois/pants/subscribers","subscription_url":"https://api.github.com/repos/jsirois/pants/subscription","commits_url":"https://api.github.com/repos/jsirois/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsirois/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsirois/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsirois/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsirois/pants/contents/{+path}","compare_url":"https://api.github.com/repos/jsirois/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsirois/pants/merges","archive_url":"https://api.github.com/repos/jsirois/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsirois/pants/downloads","issues_url":"https://api.github.com/repos/jsirois/pants/issues{/number}","pulls_url":"https://api.github.com/repos/jsirois/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/jsirois/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/jsirois/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsirois/pants/labels{/name}","releases_url":"https://api.github.com/repos/jsirois/pants/releases{/id}","created_at":"2014-04-25T15:11:53Z","updated_at":"2015-05-08T08:37:03Z","pushed_at":"2015-10-05T21:36:08Z","git_url":"git://github.com/jsirois/pants.git","ssh_url":"git@github.com:jsirois/pants.git","clone_url":"https://github.com/jsirois/pants.git","svn_url":"https://github.com/jsirois/pants","homepage":"http://pantsbuild.github.io/","size":59962,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"78d5bb8f53af7bf36b42775852b9ec93373cd096","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-10-04T19:30:28Z","pushed_at":"2015-10-05T21:32:57Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":81791,"stargazers_count":409,"watchers_count":409,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":300,"forks":120,"open_issues":300,"watchers":409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2316"},"html":{"href":"https://github.com/pantsbuild/pants/pull/2316"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2316"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2316/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2316/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2316/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/eae2ca56ea821f22aa8f088c1d3e7ce815c91437"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":248,"deletions":40,"changed_files":8}}