{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/25213794","id":25213794,"diff_hunk":"@@ -176,6 +176,7 @@ Each instance can report to zero or more _sinks_. Sinks are contained in the\n * `JmxSink`: Registers metrics for viewing in a JMX console.\n * `MetricsServlet`: Adds a servlet within the existing Spark UI to serve metrics data as JSON data.\n * `GraphiteSink`: Sends metrics to a Graphite node.\n+* `Slf4jSink`: Sends metrics to log4j as logging entries","path":"docs/monitoring.md","position":4,"original_position":4,"commit_id":"ef837c0b7c79a21982624cb2954376abf8e6e75b","original_commit_id":"ef837c0b7c79a21982624cb2954376abf8e6e75b","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Couldn't it be sent from slf4j to another logging system too? it's possible to swap out the slf4j-log4j binding that Spark uses with a little work.","created_at":"2015-02-23T23:25:27Z","updated_at":"2015-02-23T23:25:27Z","html_url":"https://github.com/apache/spark/pull/4644#discussion_r25213794","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4644","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/25213794"},"html":{"href":"https://github.com/apache/spark/pull/4644#discussion_r25213794"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4644"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4644","id":29424578,"html_url":"https://github.com/apache/spark/pull/4644","diff_url":"https://github.com/apache/spark/pull/4644.diff","patch_url":"https://github.com/apache/spark/pull/4644.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4644","number":4644,"state":"open","locked":false,"title":"Spark-5708: Add Slf4jSink to Spark Metrics","user":{"login":"judynash","id":8895633,"avatar_url":"https://avatars.githubusercontent.com/u/8895633?v=3","gravatar_id":"","url":"https://api.github.com/users/judynash","html_url":"https://github.com/judynash","followers_url":"https://api.github.com/users/judynash/followers","following_url":"https://api.github.com/users/judynash/following{/other_user}","gists_url":"https://api.github.com/users/judynash/gists{/gist_id}","starred_url":"https://api.github.com/users/judynash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judynash/subscriptions","organizations_url":"https://api.github.com/users/judynash/orgs","repos_url":"https://api.github.com/users/judynash/repos","events_url":"https://api.github.com/users/judynash/events{/privacy}","received_events_url":"https://api.github.com/users/judynash/received_events","type":"User","site_admin":false},"body":"Add Slf4jSink to Spark Metrics using Coda Hale's SlfjReporter. \r\nThis sends metrics to log4j, allowing spark users to reuse log4j pipeline for metrics collection. \r\n\r\nReviewed existing unit tests and didn't see any sink-related tests. Please advise on if tests should be added. ","created_at":"2015-02-17T08:19:31Z","updated_at":"2015-02-23T23:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240a7d8ea1e415735086372998335575b0fd6f38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4644/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4644/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4644/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ef837c0b7c79a21982624cb2954376abf8e6e75b","head":{"label":"judynash:master","ref":"master","sha":"ef837c0b7c79a21982624cb2954376abf8e6e75b","user":{"login":"judynash","id":8895633,"avatar_url":"https://avatars.githubusercontent.com/u/8895633?v=3","gravatar_id":"","url":"https://api.github.com/users/judynash","html_url":"https://github.com/judynash","followers_url":"https://api.github.com/users/judynash/followers","following_url":"https://api.github.com/users/judynash/following{/other_user}","gists_url":"https://api.github.com/users/judynash/gists{/gist_id}","starred_url":"https://api.github.com/users/judynash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judynash/subscriptions","organizations_url":"https://api.github.com/users/judynash/orgs","repos_url":"https://api.github.com/users/judynash/repos","events_url":"https://api.github.com/users/judynash/events{/privacy}","received_events_url":"https://api.github.com/users/judynash/received_events","type":"User","site_admin":false},"repo":{"id":25709973,"name":"spark","full_name":"judynash/spark","owner":{"login":"judynash","id":8895633,"avatar_url":"https://avatars.githubusercontent.com/u/8895633?v=3","gravatar_id":"","url":"https://api.github.com/users/judynash","html_url":"https://github.com/judynash","followers_url":"https://api.github.com/users/judynash/followers","following_url":"https://api.github.com/users/judynash/following{/other_user}","gists_url":"https://api.github.com/users/judynash/gists{/gist_id}","starred_url":"https://api.github.com/users/judynash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judynash/subscriptions","organizations_url":"https://api.github.com/users/judynash/orgs","repos_url":"https://api.github.com/users/judynash/repos","events_url":"https://api.github.com/users/judynash/events{/privacy}","received_events_url":"https://api.github.com/users/judynash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/judynash/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/judynash/spark","forks_url":"https://api.github.com/repos/judynash/spark/forks","keys_url":"https://api.github.com/repos/judynash/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/judynash/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/judynash/spark/teams","hooks_url":"https://api.github.com/repos/judynash/spark/hooks","issue_events_url":"https://api.github.com/repos/judynash/spark/issues/events{/number}","events_url":"https://api.github.com/repos/judynash/spark/events","assignees_url":"https://api.github.com/repos/judynash/spark/assignees{/user}","branches_url":"https://api.github.com/repos/judynash/spark/branches{/branch}","tags_url":"https://api.github.com/repos/judynash/spark/tags","blobs_url":"https://api.github.com/repos/judynash/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/judynash/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/judynash/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/judynash/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/judynash/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/judynash/spark/languages","stargazers_url":"https://api.github.com/repos/judynash/spark/stargazers","contributors_url":"https://api.github.com/repos/judynash/spark/contributors","subscribers_url":"https://api.github.com/repos/judynash/spark/subscribers","subscription_url":"https://api.github.com/repos/judynash/spark/subscription","commits_url":"https://api.github.com/repos/judynash/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/judynash/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/judynash/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/judynash/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/judynash/spark/contents/{+path}","compare_url":"https://api.github.com/repos/judynash/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/judynash/spark/merges","archive_url":"https://api.github.com/repos/judynash/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/judynash/spark/downloads","issues_url":"https://api.github.com/repos/judynash/spark/issues{/number}","pulls_url":"https://api.github.com/repos/judynash/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/judynash/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/judynash/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/judynash/spark/labels{/name}","releases_url":"https://api.github.com/repos/judynash/spark/releases{/id}","created_at":"2014-10-24T21:52:21Z","updated_at":"2015-02-17T08:14:18Z","pushed_at":"2015-02-17T08:14:18Z","git_url":"git://github.com/judynash/spark.git","ssh_url":"git@github.com:judynash/spark.git","clone_url":"https://github.com/judynash/spark.git","svn_url":"https://github.com/judynash/spark","homepage":null,"size":91506,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c06e42f2c1e5fcf123b466efd27ee4cb53bbed3f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-02-23T22:33:49Z","pushed_at":"2015-02-23T20:11:13Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1298894,"stargazers_count":2966,"watchers_count":2966,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2584,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":257,"forks":2584,"open_issues":257,"watchers":2966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4644"},"html":{"href":"https://github.com/apache/spark/pull/4644"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4644"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4644/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4644/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4644/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ef837c0b7c79a21982624cb2954376abf8e6e75b"}}}}