{"action":"created","issue":{"url":"https://api.github.com/repos/opf/openproject/issues/2786","labels_url":"https://api.github.com/repos/opf/openproject/issues/2786/labels{/name}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2786/comments","events_url":"https://api.github.com/repos/opf/openproject/issues/2786/events","html_url":"https://github.com/opf/openproject/pull/2786","id":66332184,"number":2786,"title":"19483 Port Test Unit/minitest tests to RSpec","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opf/openproject/labels/feature","name":"feature","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-04-04T15:31:05Z","updated_at":"2015-04-08T20:42:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2786","html_url":"https://github.com/opf/openproject/pull/2786","diff_url":"https://github.com/opf/openproject/pull/2786.diff","patch_url":"https://github.com/opf/openproject/pull/2786.patch"},"body":"Rebased, updated. Succeeds #2115.\r\n\r\n## What this PR/WP does not do:\r\n\r\n* update Test-Unit/xUnit-style assertions. A separate PR will handle this (indeed I've been working on a [tool to help convert these assertions automatically](https://github.com/myabc/unassertive)).\r\n* remove the `rake test` tasks: we should hold off doing this until all CI jobs are updated.\r\n\r\n## What this PR/WP does:\r\n\r\n* rewrites Test-Unit tests using RSpec DSL.\r\n* moves Test-Units into a `spec/legacy` folder.\r\n* updates Rake tasks: \r\n  there are two separate `rake spec:core` and `rake spec:legacy` tasks, which are in turn, dependencies of `rake spec`.\r\n\r\nThe legacy specs are generally not good about cleaning up after themselves: for example, leaving state in the database. As such, the following will still produce errors:\r\n\r\n```bash\r\nrspec spec/**/*_spec.rb\r\nrspec spec/legacy/**/*_spec.rb\r\n``` \r\n\r\nwhile this will work:\r\n\r\n```bash\r\nrspec spec/legacy/unit/**/*_spec.rb\r\nrspec spec/legacy/functional/**/*_spec.rb\r\nrspec spec/legacy/integration/**/*_spec.rb\r\nrspec spec/models/**/*_spec.rb\r\n```\r\nThe Rake tasks take this into account. \r\n\r\nhttps://community.openproject.org/work_packages/19483"},"comment":{"url":"https://api.github.com/repos/opf/openproject/issues/comments/91031136","html_url":"https://github.com/opf/openproject/pull/2786#issuecomment-91031136","issue_url":"https://api.github.com/repos/opf/openproject/issues/2786","id":91031136,"user":{"login":"linki","id":36162,"avatar_url":"https://avatars.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T20:42:06Z","updated_at":"2015-04-08T20:42:06Z","body":"lgtm :+1: "}}