{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/6164","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/6164/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/6164/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/6164/events","html_url":"https://github.com/facebook/hhvm/issues/6164","id":103547529,"number":6164,"title":"RFC: Ban references in partial","user":{"login":"fredemmott","id":360927,"avatar_url":"https://avatars.githubusercontent.com/u/360927?v=3","gravatar_id":"","url":"https://api.github.com/users/fredemmott","html_url":"https://github.com/fredemmott","followers_url":"https://api.github.com/users/fredemmott/followers","following_url":"https://api.github.com/users/fredemmott/following{/other_user}","gists_url":"https://api.github.com/users/fredemmott/gists{/gist_id}","starred_url":"https://api.github.com/users/fredemmott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredemmott/subscriptions","organizations_url":"https://api.github.com/users/fredemmott/orgs","repos_url":"https://api.github.com/users/fredemmott/repos","events_url":"https://api.github.com/users/fredemmott/events{/privacy}","received_events_url":"https://api.github.com/users/fredemmott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/hhvm/labels/hack","name":"hack","color":"fe8700"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-27T16:32:50Z","updated_at":"2015-08-27T22:41:39Z","closed_at":null,"body":"Way too easy to break the type system - eg:\r\n\r\n```Hack\r\n<?hh\r\n\r\nfunction foo(int &$value): void {\r\n  $value = 'herp';\r\n}\r\n\r\nfunction bar(int $value): void {\r\n  var_dump($value);\r\n}\r\n\r\nfunction main(): void {\r\n  $v = 123;\r\n  foo($v);\r\n  bar($v);\r\n}\r\n\r\nmain();\r\n```\r\n\r\nThis typechecks, but at runtime:\r\n\r\n```\r\nCatchable fatal error: Argument 1 passed to bar() must be an instance of int, string given in /home/fredemmott/hhtest/test.php on line 9\r\n```\r\n\r\n - hackificator could use HH_FIXME\r\n - if this is impractical for facebook www, possibly another .hhconfig option like unsafe_xhp?"},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/135575560","html_url":"https://github.com/facebook/hhvm/issues/6164#issuecomment-135575560","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/6164","id":135575560,"user":{"login":"JoelMarcey","id":3757713,"avatar_url":"https://avatars.githubusercontent.com/u/3757713?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelMarcey","html_url":"https://github.com/JoelMarcey","followers_url":"https://api.github.com/users/JoelMarcey/followers","following_url":"https://api.github.com/users/JoelMarcey/following{/other_user}","gists_url":"https://api.github.com/users/JoelMarcey/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelMarcey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelMarcey/subscriptions","organizations_url":"https://api.github.com/users/JoelMarcey/orgs","repos_url":"https://api.github.com/users/JoelMarcey/repos","events_url":"https://api.github.com/users/JoelMarcey/events{/privacy}","received_events_url":"https://api.github.com/users/JoelMarcey/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T22:41:39Z","updated_at":"2015-08-27T22:41:39Z","body":"@fredemmott You are right. yeah. :( \r\n\r\n@Orvid, I was wrong."}}