{"action":"created","issue":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/416","labels_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/416/comments","events_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/416/events","html_url":"https://github.com/TheTorProject/ooni-probe/pull/416","id":110605265,"number":416,"title":"Improve ./bin/ooniprobe-dev","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/labels/ooni-probe","name":"ooni-probe","color":"49A2DD"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-09T07:49:00Z","updated_at":"2015-11-08T09:18:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/416","html_url":"https://github.com/TheTorProject/ooni-probe/pull/416","diff_url":"https://github.com/TheTorProject/ooni-probe/pull/416.diff","patch_url":"https://github.com/TheTorProject/ooni-probe/pull/416.patch"},"body":"- make sure it also works on MacOSX where `realpath` is not available\r\n\r\n- make sure it bails out with an explicit error message if finding out the toplevel directory path is not possible\r\n\r\n- make sure arguments are correctly forwarded to `./bin/ooniprobe` [edit: this was already in #412, I just added quotes around $@ since this appears to be even more correct]\r\n\r\nFixes `./bin/ooniprobe-dev -s` on my system.\r\n\r\nSpotted while performing the review of #410."},"comment":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/comments/154790745","html_url":"https://github.com/TheTorProject/ooni-probe/pull/416#issuecomment-154790745","issue_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/416","id":154790745,"user":{"login":"hellais","id":424620,"avatar_url":"https://avatars.githubusercontent.com/u/424620?v=3","gravatar_id":"","url":"https://api.github.com/users/hellais","html_url":"https://github.com/hellais","followers_url":"https://api.github.com/users/hellais/followers","following_url":"https://api.github.com/users/hellais/following{/other_user}","gists_url":"https://api.github.com/users/hellais/gists{/gist_id}","starred_url":"https://api.github.com/users/hellais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellais/subscriptions","organizations_url":"https://api.github.com/users/hellais/orgs","repos_url":"https://api.github.com/users/hellais/repos","events_url":"https://api.github.com/users/hellais/events{/privacy}","received_events_url":"https://api.github.com/users/hellais/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T09:18:18Z","updated_at":"2015-11-08T09:18:18Z","body":"Looks good to me!"}}