{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1","id":49816690,"html_url":"https://github.com/ocadotechnology/rest-assured/pull/1","diff_url":"https://github.com/ocadotechnology/rest-assured/pull/1.diff","patch_url":"https://github.com/ocadotechnology/rest-assured/pull/1.patch","issue_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/1","number":1,"state":"closed","locked":false,"title":"Modify HttpClientConfig so parameter altering methods respect any pre…","user":{"login":"ajclarkson","id":776802,"avatar_url":"https://avatars.githubusercontent.com/u/776802?v=3","gravatar_id":"","url":"https://api.github.com/users/ajclarkson","html_url":"https://github.com/ajclarkson","followers_url":"https://api.github.com/users/ajclarkson/followers","following_url":"https://api.github.com/users/ajclarkson/following{/other_user}","gists_url":"https://api.github.com/users/ajclarkson/gists{/gist_id}","starred_url":"https://api.github.com/users/ajclarkson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajclarkson/subscriptions","organizations_url":"https://api.github.com/users/ajclarkson/orgs","repos_url":"https://api.github.com/users/ajclarkson/repos","events_url":"https://api.github.com/users/ajclarkson/events{/privacy}","received_events_url":"https://api.github.com/users/ajclarkson/received_events","type":"User","site_admin":false},"body":"…vious configuration. Fixes #612\r\n\r\n\r\nSee [Issue #612] (https://github.com/jayway/rest-assured/issues/612) for full details. HttpClientConfig methods setParams, withParams, addParams were not respecting previous config settings in use. So when using as part of a fluid call, if one of these methods was last in the chain, it would overwrite all previous calls.\r\n\r\nAs part of fixing this a small bug was also discovered with addParams, which meant that instead of merging the provided new parameters with old ones - the old ones were simply replaced.\r\n\r\nThese are now fixed, and unit tests were added to confirm this","created_at":"2015-11-05T12:17:23Z","updated_at":"2015-11-05T13:31:26Z","closed_at":"2015-11-05T13:31:26Z","merged_at":null,"merge_commit_sha":"d308539d066d354f9aa78c18d5f004e3e77f4ca9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/1/comments","statuses_url":"https://api.github.com/repos/ocadotechnology/rest-assured/statuses/b3888ba22ba4388fce4314407691100cab6d7366","head":{"label":"ocadotechnology:612-httpClientConfig","ref":"612-httpClientConfig","sha":"b3888ba22ba4388fce4314407691100cab6d7366","user":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":45555139,"name":"rest-assured","full_name":"ocadotechnology/rest-assured","owner":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocadotechnology/rest-assured","description":"Java DSL for easy testing of REST services","fork":true,"url":"https://api.github.com/repos/ocadotechnology/rest-assured","forks_url":"https://api.github.com/repos/ocadotechnology/rest-assured/forks","keys_url":"https://api.github.com/repos/ocadotechnology/rest-assured/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/rest-assured/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/rest-assured/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/rest-assured/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/rest-assured/events","assignees_url":"https://api.github.com/repos/ocadotechnology/rest-assured/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/rest-assured/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/rest-assured/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/rest-assured/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/rest-assured/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/rest-assured/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/rest-assured/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/rest-assured/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/rest-assured/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/rest-assured/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/rest-assured/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/rest-assured/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/rest-assured/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/rest-assured/merges","archive_url":"https://api.github.com/repos/ocadotechnology/rest-assured/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/rest-assured/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/rest-assured/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/rest-assured/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/rest-assured/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/rest-assured/releases{/id}","created_at":"2015-11-04T17:23:25Z","updated_at":"2015-11-04T17:23:27Z","pushed_at":"2015-11-05T12:17:23Z","git_url":"git://github.com/ocadotechnology/rest-assured.git","ssh_url":"git@github.com:ocadotechnology/rest-assured.git","clone_url":"https://github.com/ocadotechnology/rest-assured.git","svn_url":"https://github.com/ocadotechnology/rest-assured","homepage":"","size":12694,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocadotechnology:master","ref":"master","sha":"0bf482e1c08a3b4073bcb2af49b85e665d83c162","user":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":45555139,"name":"rest-assured","full_name":"ocadotechnology/rest-assured","owner":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocadotechnology/rest-assured","description":"Java DSL for easy testing of REST services","fork":true,"url":"https://api.github.com/repos/ocadotechnology/rest-assured","forks_url":"https://api.github.com/repos/ocadotechnology/rest-assured/forks","keys_url":"https://api.github.com/repos/ocadotechnology/rest-assured/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/rest-assured/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/rest-assured/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/rest-assured/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/rest-assured/events","assignees_url":"https://api.github.com/repos/ocadotechnology/rest-assured/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/rest-assured/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/rest-assured/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/rest-assured/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/rest-assured/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/rest-assured/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/rest-assured/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/rest-assured/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/rest-assured/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/rest-assured/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/rest-assured/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/rest-assured/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/rest-assured/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/rest-assured/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/rest-assured/merges","archive_url":"https://api.github.com/repos/ocadotechnology/rest-assured/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/rest-assured/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/rest-assured/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/rest-assured/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/rest-assured/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/rest-assured/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/rest-assured/releases{/id}","created_at":"2015-11-04T17:23:25Z","updated_at":"2015-11-04T17:23:27Z","pushed_at":"2015-11-05T12:17:23Z","git_url":"git://github.com/ocadotechnology/rest-assured.git","ssh_url":"git@github.com:ocadotechnology/rest-assured.git","clone_url":"https://github.com/ocadotechnology/rest-assured.git","svn_url":"https://github.com/ocadotechnology/rest-assured","homepage":"","size":12694,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1"},"html":{"href":"https://github.com/ocadotechnology/rest-assured/pull/1"},"issue":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/1"},"comments":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ocadotechnology/rest-assured/statuses/b3888ba22ba4388fce4314407691100cab6d7366"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":101,"deletions":7,"changed_files":3}}