{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5110","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5110/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5110/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5110/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/5110","id":100920109,"number":5110,"title":"Generate short name variable for multioutput node in node to code","user":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/LGTM","name":"LGTM","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-14T03:00:31Z","updated_at":"2015-08-19T08:27:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5110","html_url":"https://github.com/DynamoDS/Dynamo/pull/5110","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5110.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5110.patch"},"body":"### Purpose\r\n\r\nThis PR is to fix defect [MAGN 8009 Converting node with multiple output creates less intuitive method names](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8009). This is because in node to code we only collects variables from output port. But for multi-output node, its corresponding variable is not in output ports. \r\n\r\nFor example, for `List.FilterByBoolMask()` node, it will be compiled to:\r\n```\r\nvar_649c8a9d2ae940dd99003c0a2db86046 = List.FilterByBoolMask(t1, t2);\r\nvar_649c8a9d2ae940dd99003c0a2db86046_out1 = __TryGetValueFromNestedDictionaries(var_649c8a9d2ae940dd99003c0a2db86046, \"in\");\r\nvar_649c8a9d2ae940dd99003c0a2db86046_out2 = __TryGetValueFromNestedDictionaries(var_649c8a9d2ae940dd99003c0a2db86046, \"out\");\r\n```\r\n\r\nN2C will provide short names for two output variables `var_649c8a9d2ae940dd99003c0a2db86046_out1` and `var_649c8a9d2ae940dd99003c0a2db86046_out2` but not `var_649c8a9d2ae940dd99003c0a2db86046`, so the variable for the node should be included as well.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n\r\n### Reviewers\r\n\r\n@Benglin "},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/132490950","html_url":"https://github.com/DynamoDS/Dynamo/pull/5110#issuecomment-132490950","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5110","id":132490950,"user":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T08:27:12Z","updated_at":"2015-08-19T08:27:12Z","body":"@Benglin . Thanks. As there are still some tasks regarding to variable naming, will do that in R2. "}}