{"push_id":835878516,"size":64,"distinct_size":1,"ref":"refs/heads/pr/384","head":"93f0f888469c91436a252ff713b64317dc99bd41","before":"b8f11cb20761665e98b771e6931d1076dece17f8","commits":[{"sha":"61c85fe2dca09b0189b7a9dae7a29d8692dcca0c","author":{"email":"ceecf9bed49d1f3cb0a3f75810cf121e7d959499@citrix.com","name":"Harikrishna Patnala"},"message":"CLOUDSTACK-8888: Xenserver 6.0.2 host stuck in disconnected state after upgrade to 4.6\n\nXenServer602Resource class is removed but existing xenserver 6.0.2 hosts are not handled properly.","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/61c85fe2dca09b0189b7a9dae7a29d8692dcca0c"},{"sha":"d413b2c375c2e5c2a0ebeca1fae07c942892ac71","author":{"email":"be4891756a4fdc8c3c6609eb41e49789e971fe07@widodh.nl","name":"Wido den Hollander"},"message":"CLOUDSTACK-8879: Depend in rados-java 0.2.0\n\nThis should fix the CloudStack Agent from crashing when it has to\nhandle more then 16 RBD snapshots on one Volume.","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/d413b2c375c2e5c2a0ebeca1fae07c942892ac71"},{"sha":"542880ae76c5e6eefbf61d42364e881495e6f3af","author":{"email":"9b0b695a0576184b2047bdf926640371215751f7@apache.org","name":"Rene Moser"},"message":"CLOUDSTACK-8848: ensure power state is up to date when handling missing VMs in powerReport\n\nThere 2 things which has been changed.\n\n* We look on power_state_update_time instead of update_time. Didn't make sense to me at all to look at update_time.\n* Due DB update optimisation, powerState will only be updated if < MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT. That is why we can not rely on these information unless we make sure these are up to date.","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/542880ae76c5e6eefbf61d42364e881495e6f3af"},{"sha":"33bdfc773a39d7ff245fb4f50299a7b6cc0391ef","author":{"email":"3fb78c3b6f52134bddf8b0644395839b09fccb9c@apache.org","name":"sanjeev"},"message":"CLOUDSTACK-8924: Removed duplicate test from test_scale_vm.py","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/33bdfc773a39d7ff245fb4f50299a7b6cc0391ef"},{"sha":"1056171aca8816492c16c5bdf8f963745f968b5d","author":{"email":"17b128bc1df4d05a5127d27894885d8c03c1ed16@gmail.com","name":"Rajani Karuturi"},"message":"CLOUDSTACK-8808: Successfully registered VHD template is downloaded\nagain due to missing virtualsize property in template.properties\n\nWe have multiple file processors to process different types of image\nformats. The processor interface has two methods getVirtualSize() and\nprocess().\n\n    1. getVirtualSize() as the name says, returns the virtual size of\nthe file and is used at get the size while copying files from NFS to s3\n    2. process() returns FormatInfo struct which has fileType, size,\nvirutalSize, filename.  on successfully downloading a template, each\nfile is passed to all the processors.process() and whichever returns a\nFormatInfo, that will be used to create template.properties file.  If\nprocess() throws an InternalErrorException, template installation fails.\nBut, if process() returns null, template registration is successful with\ntemplate.properties missing some attributes like virtualSize, file\nformat etc. which results in this bug on restart of ssvm/cloud\nservice/management server.\n\nfailing the template download if virutalsize or some other properties\ncannot be determined.\n\nThe following changes are done:\ngetVirtualSize() to always return size(if it can calculate, get virtual\nsize else return file size). This would mean the following changes\n\n    1. QCOW2Processor.getVirtualSize() to return file size if virtual\nsize calculation fails\n    2. VHDProcessor.getVirtualSize() to return file size if virtual size\ncalculation fails\n\nprocess() to throw InternalErrorException if virtual size calculation\nfails or any other exceptions occur. This would mean the following\nchanges\n\n    1. OVAProcessor to throw InternalErrorException if untar fails\n    2. QCOW2Processor to throw InternalErrorException if virtual size\ncalculation fails\n    3. VHDProcessor to throw InternalErrorException if virtual size\ncalculation fails","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/1056171aca8816492c16c5bdf8f963745f968b5d"},{"sha":"996c2f6ddec57fd5a644f6454911a1e303cc7d8f","author":{"email":"64b2b6d12bfe4baae7dad3d018f8cbf6b0e7a044@remi.nl","name":"Remi Bergsma"},"message":"Merge pull request #900 from sanju1010/scale_vm\n\nCLOUDSTACK-8924: Removed duplicate test from test_scale_vm.pyPlease go through CS-8924 for more details.\n\n* pr/900:\n  CLOUDSTACK-8924: Removed duplicate test from test_scale_vm.py\n\nSigned-off-by: Remi Bergsma <github@remi.nl>","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/996c2f6ddec57fd5a644f6454911a1e303cc7d8f"},{"sha":"78f74295e15fd396c8d8736f4a787cc8d3b165a4","author":{"email":"64b2b6d12bfe4baae7dad3d018f8cbf6b0e7a044@remi.nl","name":"Remi Bergsma"},"message":"Merge pull request #901 from karuturi/CLOUDSTACK-8808\n\nCLOUDSTACK-8808: Successfully registered VHD template is downloaded again due to missing virtualsize property in template.propertiesWe have multiple file processors to process different types of image\nformats. The processor interface has two methods getVirtualSize() and\nprocess().\n\n1.  getVirtualSize() as the name says, returns the virtual size of\nthe file and is used at get the size while copying files from NFS to s3\n2.  process() returns FormatInfo struct which has fileType, size,\nvirutalSize, filename.  on successfully downloading a template, each\nfile is passed to all the processors.process() and whichever returns a\nFormatInfo, that will be used to create template.properties file.  If\nprocess() throws an InternalErrorException, template installation fails.\nBut, if process() returns null, template registration is successful with\ntemplate.properties missing some attributes like virtualSize, file\nformat etc. which results in this bug on restart of ssvm/cloud\nservice/management server.\n\nfailing the template download if virutalsize or some other properties\ncannot be determined.\n\nThe following changes are done:\ngetVirtualSize() to always return size(if it can calculate, get virtual\nsize else return file size). This would mean the following changes\n\n1. QCOW2Processor.getVirtualSize() to return file size if virtual\nsize calculation fails\n2. VHDProcessor.getVirtualSize() to return file size if virtual size\ncalculation fails\n\nprocess() to throw InternalErrorException if virtual size calculation\nfails or any other exceptions occur. This would mean the following\nchanges\n\n1. OVAProcessor to throw InternalErrorException if untar fails\n2. QCOW2Processor to throw InternalErrorException if virtual size\ncalculation fails\n3. VHDProcessor to throw InternalErrorException if virtual size\ncalculation fails\n\nTesting:\nadded unittests for the changes in the file processors.\nmanual test:\nsetup: host xenserver 6.5, management server centos 6.7\ntemplate: disk created using the process specified by andy at https://issues.apache.org/jira/browse/CLOUDSTACK-8808?focusedCommentId=14933368\ntried to register the template and it failed with an error. Template never moved to Ready state.\n![screen shot 2015-09-30 at 3 53 34 pm](https://cloud.githubusercontent.com/assets/186833/10190608/76bcce92-678b-11e5-8f52-b449d149300b.png)\n\n* pr/901:\n  CLOUDSTACK-8808: Successfully registered VHD template is downloaded again due to missing virtualsize property in template.properties\n\nSigned-off-by: Remi Bergsma <github@remi.nl>","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/78f74295e15fd396c8d8736f4a787cc8d3b165a4"},{"sha":"b128e567c4eacf4d22e6a8c0d6888c297c7fb726","author":{"email":"0c11e55e6a36a8185db5745ba7416a2dde0b12ba@onecht.net","name":"Daan Hoogland"},"message":"CLOUDSTACK-8848: added null pointer guard to new public method","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/b128e567c4eacf4d22e6a8c0d6888c297c7fb726"},{"sha":"99059e2212833a13428bef93195e31a2641c644e","author":{"email":"9f2999019888ce7d806829916dea32dbd34ab443@citrix.com","name":"Rajani Karuturi"},"message":"Merge pull request #909 from DaanHoogland/RESMO-CLOUDSTACK-8848\n\nCLOUDSTACK-8848 ensure power state is up to date for missing PowerState handlingadded a null guard to @resmo's #885 A unit test or two would be nice as well but as this is a blocker I want to get it to review asap.\n@koushik-das @wilderrodrigues @anshul1886 @karuturi @remibergsma you all commented on the original, please have a look. @bhaisaab welcome to comment as well.\n\n* pr/909:\n  CLOUDSTACK-8848: added null pointer guard to new public method\n  CLOUDSTACK-8848: ensure power state is up to date when handling missing VMs in powerReport\n\nSigned-off-by: Rajani Karuturi <rajani.karuturi@citrix.com>","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/99059e2212833a13428bef93195e31a2641c644e"},{"sha":"c17fb0ff2829b3db4826954970427916df633434","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Add the default route only on address that have not been configured yet.\n\n   - In case of rVPC we experienced the wrong route being added to the VPC tiers","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/c17fb0ff2829b3db4826954970427916df633434"},{"sha":"0c752eab60ed2b56708e7e48bcdf73c63e76f986","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Rearrenging a bit the default route code in order to make it more clear","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/0c752eab60ed2b56708e7e48bcdf73c63e76f986"},{"sha":"094d29d7cdbb9f3e6e4248875de07fbe3610b2a6","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - VRRP needs a cidr in order to work properly\n\n   - The cidr was replaced by the single IP, which broke the feature.\n   - Wait during transition from master to backup otherwise the test fails due to wronge state","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/094d29d7cdbb9f3e6e4248875de07fbe3610b2a6"},{"sha":"3d34e4a52c95c7585fd49ec07001620621c3c846","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Reverting changes from commit id 18dbc0c4cbe506ad698bc513c901dc2d0e48159f\n\n   - If the file is always copied, it will result in restarting keepalived everytime which makes the routers transit between master/backup","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/3d34e4a52c95c7585fd49ec07001620621c3c846"},{"sha":"260ff836b6d7caf30a6ef0f25034791e193a5a31","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Reverting changes from commit id 1a02773b556a0efa277cf18cd099fc62a4e27706\n\n   - That's not the place to fix the default routes for redundant VPC,\n   - Adding tests to cover PF and FW in isolated networks\n     * Will still add some tests for egress as well","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/260ff836b6d7caf30a6ef0f25034791e193a5a31"},{"sha":"7c7c0149b25435548118c1ddbb3895866fb161ad","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Improve routers tests\n\n   - Add egress tests in order to check if VMs can reach the outside world\n   - Increase the wait when testing redundant routers: they fight to become master\n   - Make sure the clean up is done properly","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/7c7c0149b25435548118c1ddbb3895866fb161ad"},{"sha":"5f79916eeaa6b0c8ecbd3fc938b4528f8f30e46c","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Adding logging to tests","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/5f79916eeaa6b0c8ecbd3fc938b4528f8f30e46c"},{"sha":"a0c93e7778ac85db2c5f5db58d5d778191cf2da8","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - This test is still under construction\n\n   - It will help to increase coverage of VR use: PF; LB and FW","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/a0c93e7778ac85db2c5f5db58d5d778191cf2da8"},{"sha":"9fe040e96d589f9f4bf2a0f1463ffceb5f47b843","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Copy the conntrackd configuration every time _redundant_on() function is called\n\n   - Also refactored the copy() function under CsHelper.py","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/9fe040e96d589f9f4bf2a0f1463ffceb5f47b843"},{"sha":"b1fb1539e9eee605b1eb7b2dd529d44ea1fe7ddc","author":{"email":"0ce741bd7b511df811ee5197af7bf896f3cfa0ed@schubergphilis.com","name":"Wilder Rodrigues"},"message":"CLOUDSTACK-8915 - Fix the assertion used for the default routes test","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/b1fb1539e9eee605b1eb7b2dd529d44ea1fe7ddc"},{"sha":"2651956cf427614f5c50e89c3405e88319961cdd","author":{"email":"5379bb240dc852a77a3225cbacde89ba63583d13@citrix.com","name":"Nitin Kumar Maharana"},"message":"CLOUDSTACK-8930: Showing blank screen when click 'Next' link in final step of Add Zone wizard.","distinct":false,"url":"https://api.github.com/repos/borisroman/cloudstack/commits/2651956cf427614f5c50e89c3405e88319961cdd"}]}