{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/6616","labels_url":"https://api.github.com/repos/servo/servo/issues/6616/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/6616/comments","events_url":"https://api.github.com/repos/servo/servo/issues/6616/events","html_url":"https://github.com/servo/servo/pull/6616","id":94838384,"number":6616,"title":"script: Make most of 2D canvas and WebGL run over IPC.","user":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-blocked-on-external","name":"S-blocked-on-external","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-14T00:04:01Z","updated_at":"2015-07-14T17:49:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6616","html_url":"https://github.com/servo/servo/pull/6616","diff_url":"https://github.com/servo/servo/pull/6616.diff","patch_url":"https://github.com/servo/servo/pull/6616.patch"},"body":"To actually make the multiprocess communication work, we'll need to\r\nreroute the task creation to the pipeline or the compositor. But this\r\nworks as a first step.\r\n\r\nr? @jdm\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6616)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/121321553","html_url":"https://github.com/servo/servo/pull/6616#issuecomment-121321553","issue_url":"https://api.github.com/repos/servo/servo/issues/6616","id":121321553,"user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T17:49:16Z","updated_at":"2015-07-14T17:49:16Z","body":"-S-awaiting-review +S-needs-code-changes +S-blocked-on-external \n\n---\n\nReviewed 29 of 29 files at r1.\nReview status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.\n\n---\n\n<sup>**[components/canvas/canvas_paint_task.rs, line 175 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCerHc48kuwN0GpBqx)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas/canvas_paint_task.rs#L175)):</sup>\nAdd a TODO to share these among all canvases for the same script task.\n\n---\n\n<sup>**[components/canvas/Cargo.toml, line 34 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCYRqyn4VIAl4B4pDz)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas/Cargo.toml#L34)):</sup>\nLet's move back to crates.io.\n\n---\n\n<sup>**[components/canvas/webgl_paint_task.rs, line 150 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCfAmEGr0pWiwYi_SV)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas/webgl_paint_task.rs#L150)):</sup>\nAdd a TODO to share this among all canvases for the same script task.\n\n---\n\n<sup>**[components/canvas_traits/Cargo.toml, line 26 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuC_QVwLksD_2UwQ0en)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas_traits/Cargo.toml#L26)):</sup>\nRevert?\n\n---\n\n<sup>**[components/canvas_traits/lib.rs, line 45 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuC_dvyYPrFAv0zXEpb)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas_traits/lib.rs#L45)):</sup>\nLet's call it FromLayout.\n\n---\n\n<sup>**[components/canvas_traits/lib.rs, line 61 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuC_sfYT7VqSaFk2Hlj)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/canvas_traits/lib.rs#L61)):</sup>\nAdd a TODO to split CanvasMsg into InternalCanvasMsg and ExternalCanvasMsg, with only InternalCanvasMsg deriving Deserialize/Serialize.\n\n---\n\n<sup>**[components/layout/wrapper.rs, line 979 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCfcI5czHmhUFh6jTe)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/layout/wrapper.rs#L979)):</sup>\nI don't believe this is used.\n\n---\n\n<sup>**[components/script/dom/htmlcanvaselement.rs, line 112 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCfgt0pX8w6ArPYSXV)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/script/dom/htmlcanvaselement.rs#L112)):</sup>\nI don't think this is used.\n\n---\n\n<sup>**[components/util/logical_geometry.rs, line 170 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCegptInQ9OKeGo5ww)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/util/logical_geometry.rs#L170)):</sup>\nWhy is this change necessary?\n\n---\n\n<sup>**[components/util/task_state.rs, line 14 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/6616#-JuCejrv8oFtWXuVdu1T)** ([raw file](https://github.com/servo/servo/blob/baf4ea437e6b5928fd8e73de77f1dd33e90db115/components/util/task_state.rs#L14)):</sup>\n?\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/6616)\n<!-- Sent from Reviewable.io -->\n"}}