{"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/lotus/utils/pulls/88","id":46640344,"html_url":"https://github.com/lotus/utils/pull/88","diff_url":"https://github.com/lotus/utils/pull/88.diff","patch_url":"https://github.com/lotus/utils/pull/88.patch","issue_url":"https://api.github.com/repos/lotus/utils/issues/88","number":88,"state":"closed","locked":false,"title":"Fix Encoding::UndefinedConversionError in encode method.","user":{"login":"constXife","id":870327,"avatar_url":"https://avatars.githubusercontent.com/u/870327?v=3","gravatar_id":"","url":"https://api.github.com/users/constXife","html_url":"https://github.com/constXife","followers_url":"https://api.github.com/users/constXife/followers","following_url":"https://api.github.com/users/constXife/following{/other_user}","gists_url":"https://api.github.com/users/constXife/gists{/gist_id}","starred_url":"https://api.github.com/users/constXife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/constXife/subscriptions","organizations_url":"https://api.github.com/users/constXife/orgs","repos_url":"https://api.github.com/users/constXife/repos","events_url":"https://api.github.com/users/constXife/events{/privacy}","received_events_url":"https://api.github.com/users/constXife/received_events","type":"User","site_admin":false},"body":"I defined following code in controller.\r\n```ruby\r\nmodule Web::Controllers::Home\r\n  class Index\r\n    # ...\r\n    def call(params)\r\n      @tag = params[:tag]\r\n    end\r\n  end\r\nend\r\n```\r\nThen I received Encoding::UndefinedConversionError in template from method self.encode in Lotus::Utils when tag contain cyrillic symbols. For some reason params[:tag] have ASCII-8BIT encoding.\r\n\r\nSo, I added quick fix for that issue.","created_at":"2015-10-02T14:20:50Z","updated_at":"2015-10-05T10:00:35Z","closed_at":"2015-10-05T10:00:35Z","merged_at":"2015-10-05T10:00:35Z","merge_commit_sha":"c635b182e7d0d703cf138e83721fbcc4ff0748c2","assignee":null,"milestone":{"url":"https://api.github.com/repos/lotus/utils/milestones/10","html_url":"https://github.com/lotus/utils/milestones/v0.6.0","labels_url":"https://api.github.com/repos/lotus/utils/milestones/10/labels","id":1337691,"number":10,"title":"v0.6.0","description":"","creator":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2015-10-05T09:08:07Z","updated_at":"2015-10-05T10:00:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lotus/utils/pulls/88/commits","review_comments_url":"https://api.github.com/repos/lotus/utils/pulls/88/comments","review_comment_url":"https://api.github.com/repos/lotus/utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lotus/utils/issues/88/comments","statuses_url":"https://api.github.com/repos/lotus/utils/statuses/0bf4a324d5c9f7a2b6e4559ad2d281f1764ce880","head":{"label":"constXife:fix_escape_encode","ref":"fix_escape_encode","sha":"0bf4a324d5c9f7a2b6e4559ad2d281f1764ce880","user":{"login":"constXife","id":870327,"avatar_url":"https://avatars.githubusercontent.com/u/870327?v=3","gravatar_id":"","url":"https://api.github.com/users/constXife","html_url":"https://github.com/constXife","followers_url":"https://api.github.com/users/constXife/followers","following_url":"https://api.github.com/users/constXife/following{/other_user}","gists_url":"https://api.github.com/users/constXife/gists{/gist_id}","starred_url":"https://api.github.com/users/constXife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/constXife/subscriptions","organizations_url":"https://api.github.com/users/constXife/orgs","repos_url":"https://api.github.com/users/constXife/repos","events_url":"https://api.github.com/users/constXife/events{/privacy}","received_events_url":"https://api.github.com/users/constXife/received_events","type":"User","site_admin":false},"repo":{"id":43555862,"name":"utils","full_name":"constXife/utils","owner":{"login":"constXife","id":870327,"avatar_url":"https://avatars.githubusercontent.com/u/870327?v=3","gravatar_id":"","url":"https://api.github.com/users/constXife","html_url":"https://github.com/constXife","followers_url":"https://api.github.com/users/constXife/followers","following_url":"https://api.github.com/users/constXife/following{/other_user}","gists_url":"https://api.github.com/users/constXife/gists{/gist_id}","starred_url":"https://api.github.com/users/constXife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/constXife/subscriptions","organizations_url":"https://api.github.com/users/constXife/orgs","repos_url":"https://api.github.com/users/constXife/repos","events_url":"https://api.github.com/users/constXife/events{/privacy}","received_events_url":"https://api.github.com/users/constXife/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/constXife/utils","description":"Ruby core extentions and class utilities for Lotus","fork":true,"url":"https://api.github.com/repos/constXife/utils","forks_url":"https://api.github.com/repos/constXife/utils/forks","keys_url":"https://api.github.com/repos/constXife/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/constXife/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/constXife/utils/teams","hooks_url":"https://api.github.com/repos/constXife/utils/hooks","issue_events_url":"https://api.github.com/repos/constXife/utils/issues/events{/number}","events_url":"https://api.github.com/repos/constXife/utils/events","assignees_url":"https://api.github.com/repos/constXife/utils/assignees{/user}","branches_url":"https://api.github.com/repos/constXife/utils/branches{/branch}","tags_url":"https://api.github.com/repos/constXife/utils/tags","blobs_url":"https://api.github.com/repos/constXife/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/constXife/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/constXife/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/constXife/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/constXife/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/constXife/utils/languages","stargazers_url":"https://api.github.com/repos/constXife/utils/stargazers","contributors_url":"https://api.github.com/repos/constXife/utils/contributors","subscribers_url":"https://api.github.com/repos/constXife/utils/subscribers","subscription_url":"https://api.github.com/repos/constXife/utils/subscription","commits_url":"https://api.github.com/repos/constXife/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/constXife/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/constXife/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/constXife/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/constXife/utils/contents/{+path}","compare_url":"https://api.github.com/repos/constXife/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/constXife/utils/merges","archive_url":"https://api.github.com/repos/constXife/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/constXife/utils/downloads","issues_url":"https://api.github.com/repos/constXife/utils/issues{/number}","pulls_url":"https://api.github.com/repos/constXife/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/constXife/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/constXife/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/constXife/utils/labels{/name}","releases_url":"https://api.github.com/repos/constXife/utils/releases{/id}","created_at":"2015-10-02T14:00:34Z","updated_at":"2015-10-02T14:00:36Z","pushed_at":"2015-10-02T14:04:23Z","git_url":"git://github.com/constXife/utils.git","ssh_url":"git@github.com:constXife/utils.git","clone_url":"https://github.com/constXife/utils.git","svn_url":"https://github.com/constXife/utils","homepage":"http://lotusrb.org","size":1438,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lotus:master","ref":"master","sha":"db5d0262a51eb31784b786e6889d38b9e43bc954","user":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"repo":{"id":11949423,"name":"utils","full_name":"lotus/utils","owner":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lotus/utils","description":"Ruby core extentions and class utilities for Lotus","fork":false,"url":"https://api.github.com/repos/lotus/utils","forks_url":"https://api.github.com/repos/lotus/utils/forks","keys_url":"https://api.github.com/repos/lotus/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lotus/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lotus/utils/teams","hooks_url":"https://api.github.com/repos/lotus/utils/hooks","issue_events_url":"https://api.github.com/repos/lotus/utils/issues/events{/number}","events_url":"https://api.github.com/repos/lotus/utils/events","assignees_url":"https://api.github.com/repos/lotus/utils/assignees{/user}","branches_url":"https://api.github.com/repos/lotus/utils/branches{/branch}","tags_url":"https://api.github.com/repos/lotus/utils/tags","blobs_url":"https://api.github.com/repos/lotus/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lotus/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lotus/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lotus/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lotus/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/lotus/utils/languages","stargazers_url":"https://api.github.com/repos/lotus/utils/stargazers","contributors_url":"https://api.github.com/repos/lotus/utils/contributors","subscribers_url":"https://api.github.com/repos/lotus/utils/subscribers","subscription_url":"https://api.github.com/repos/lotus/utils/subscription","commits_url":"https://api.github.com/repos/lotus/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lotus/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lotus/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lotus/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lotus/utils/contents/{+path}","compare_url":"https://api.github.com/repos/lotus/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lotus/utils/merges","archive_url":"https://api.github.com/repos/lotus/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lotus/utils/downloads","issues_url":"https://api.github.com/repos/lotus/utils/issues{/number}","pulls_url":"https://api.github.com/repos/lotus/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/lotus/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/lotus/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lotus/utils/labels{/name}","releases_url":"https://api.github.com/repos/lotus/utils/releases{/id}","created_at":"2013-08-07T12:29:45Z","updated_at":"2015-09-25T14:06:08Z","pushed_at":"2015-10-05T10:00:35Z","git_url":"git://github.com/lotus/utils.git","ssh_url":"git@github.com:lotus/utils.git","clone_url":"https://github.com/lotus/utils.git","svn_url":"https://github.com/lotus/utils","homepage":"http://lotusrb.org","size":1438,"stargazers_count":89,"watchers_count":89,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":0,"forks":56,"open_issues":0,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lotus/utils/pulls/88"},"html":{"href":"https://github.com/lotus/utils/pull/88"},"issue":{"href":"https://api.github.com/repos/lotus/utils/issues/88"},"comments":{"href":"https://api.github.com/repos/lotus/utils/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/lotus/utils/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/lotus/utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lotus/utils/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/lotus/utils/statuses/0bf4a324d5c9f7a2b6e4559ad2d281f1764ce880"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":10,"deletions":0,"changed_files":2}}