{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36","id":32242539,"html_url":"https://github.com/smstw/windwalker-joomla-rad/pull/36","diff_url":"https://github.com/smstw/windwalker-joomla-rad/pull/36.diff","patch_url":"https://github.com/smstw/windwalker-joomla-rad/pull/36.patch","issue_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/36","number":36,"state":"closed","locked":false,"title":"[Update #35]add htmlBuilderTest","user":{"login":"skylying","id":2177826,"avatar_url":"https://avatars.githubusercontent.com/u/2177826?v=3","gravatar_id":"","url":"https://api.github.com/users/skylying","html_url":"https://github.com/skylying","followers_url":"https://api.github.com/users/skylying/followers","following_url":"https://api.github.com/users/skylying/following{/other_user}","gists_url":"https://api.github.com/users/skylying/gists{/gist_id}","starred_url":"https://api.github.com/users/skylying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylying/subscriptions","organizations_url":"https://api.github.com/users/skylying/orgs","repos_url":"https://api.github.com/users/skylying/repos","events_url":"https://api.github.com/users/skylying/events{/privacy}","received_events_url":"https://api.github.com/users/skylying/received_events","type":"User","site_admin":false},"body":"For #35 \r\n\r\n - Add HtmlBuilderTest\r\n\r\n  - 另外我發現 `HtmlBuilder::create()` 如果送 `$attributes` 進去的話, render 出來會多一層雙引號, 原本我是要連 `$attributes` 的 test case 一起寫, 但先問問 @asika32764 這怎麼辦好了\r\n![screen shot 2015-03-31 at 12 10 33](https://cloud.githubusercontent.com/assets/2177826/6900815/bde5739a-d73b-11e4-8a9d-d2b5f744090f.png)\r\n\r\n  - 然後 `HtmlBuilder::create()` 有錯字 .... =_=\r\n![screen_shot_2015-03-31_at_ 12_20_36](https://cloud.githubusercontent.com/assets/2177826/6900825/d1fade06-d73b-11e4-9937-f4ffb9631243.png)\r\n\r\n\r\n","created_at":"2015-03-30T16:21:42Z","updated_at":"2015-04-04T15:38:53Z","closed_at":"2015-04-04T15:38:53Z","merged_at":"2015-04-04T15:38:53Z","merge_commit_sha":"2b5b07362648802bfefa7913f6715f6acd48e377","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36/commits","review_comments_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36/comments","review_comment_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/36/comments","statuses_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/statuses/e0483269cc0e01546c46d4bca4883b9827854896","head":{"label":"skylying:Update-add-HtmlBuilder-test","ref":"Update-add-HtmlBuilder-test","sha":"e0483269cc0e01546c46d4bca4883b9827854896","user":{"login":"skylying","id":2177826,"avatar_url":"https://avatars.githubusercontent.com/u/2177826?v=3","gravatar_id":"","url":"https://api.github.com/users/skylying","html_url":"https://github.com/skylying","followers_url":"https://api.github.com/users/skylying/followers","following_url":"https://api.github.com/users/skylying/following{/other_user}","gists_url":"https://api.github.com/users/skylying/gists{/gist_id}","starred_url":"https://api.github.com/users/skylying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylying/subscriptions","organizations_url":"https://api.github.com/users/skylying/orgs","repos_url":"https://api.github.com/users/skylying/repos","events_url":"https://api.github.com/users/skylying/events{/privacy}","received_events_url":"https://api.github.com/users/skylying/received_events","type":"User","site_admin":false},"repo":{"id":32919978,"name":"windwalker-joomla-rad","full_name":"skylying/windwalker-joomla-rad","owner":{"login":"skylying","id":2177826,"avatar_url":"https://avatars.githubusercontent.com/u/2177826?v=3","gravatar_id":"","url":"https://api.github.com/users/skylying","html_url":"https://github.com/skylying","followers_url":"https://api.github.com/users/skylying/followers","following_url":"https://api.github.com/users/skylying/following{/other_user}","gists_url":"https://api.github.com/users/skylying/gists{/gist_id}","starred_url":"https://api.github.com/users/skylying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylying/subscriptions","organizations_url":"https://api.github.com/users/skylying/orgs","repos_url":"https://api.github.com/users/skylying/repos","events_url":"https://api.github.com/users/skylying/events{/privacy}","received_events_url":"https://api.github.com/users/skylying/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skylying/windwalker-joomla-rad","description":"Windwalker RAD framework for Joomla CMS","fork":true,"url":"https://api.github.com/repos/skylying/windwalker-joomla-rad","forks_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/forks","keys_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/teams","hooks_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/hooks","issue_events_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/issues/events{/number}","events_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/events","assignees_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/assignees{/user}","branches_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/branches{/branch}","tags_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/tags","blobs_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/statuses/{sha}","languages_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/languages","stargazers_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/stargazers","contributors_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/contributors","subscribers_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/subscribers","subscription_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/subscription","commits_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/contents/{+path}","compare_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/merges","archive_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/downloads","issues_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/issues{/number}","pulls_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/pulls{/number}","milestones_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/milestones{/number}","notifications_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/labels{/name}","releases_url":"https://api.github.com/repos/skylying/windwalker-joomla-rad/releases{/id}","created_at":"2015-03-26T10:04:26Z","updated_at":"2015-03-26T10:04:27Z","pushed_at":"2015-04-04T07:25:56Z","git_url":"git://github.com/skylying/windwalker-joomla-rad.git","ssh_url":"git@github.com:skylying/windwalker-joomla-rad.git","clone_url":"https://github.com/skylying/windwalker-joomla-rad.git","svn_url":"https://github.com/skylying/windwalker-joomla-rad","homepage":"http://ventoviro.github.io/windwalker-rad-doc/","size":2423,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev-2.1"}},"base":{"label":"smstw:dev-2.1","ref":"dev-2.1","sha":"614595af54f48d75f39b39007d137b1908c16e1a","user":{"login":"smstw","id":5608018,"avatar_url":"https://avatars.githubusercontent.com/u/5608018?v=3","gravatar_id":"","url":"https://api.github.com/users/smstw","html_url":"https://github.com/smstw","followers_url":"https://api.github.com/users/smstw/followers","following_url":"https://api.github.com/users/smstw/following{/other_user}","gists_url":"https://api.github.com/users/smstw/gists{/gist_id}","starred_url":"https://api.github.com/users/smstw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smstw/subscriptions","organizations_url":"https://api.github.com/users/smstw/orgs","repos_url":"https://api.github.com/users/smstw/repos","events_url":"https://api.github.com/users/smstw/events{/privacy}","received_events_url":"https://api.github.com/users/smstw/received_events","type":"Organization","site_admin":false},"repo":{"id":24495433,"name":"windwalker-joomla-rad","full_name":"smstw/windwalker-joomla-rad","owner":{"login":"smstw","id":5608018,"avatar_url":"https://avatars.githubusercontent.com/u/5608018?v=3","gravatar_id":"","url":"https://api.github.com/users/smstw","html_url":"https://github.com/smstw","followers_url":"https://api.github.com/users/smstw/followers","following_url":"https://api.github.com/users/smstw/following{/other_user}","gists_url":"https://api.github.com/users/smstw/gists{/gist_id}","starred_url":"https://api.github.com/users/smstw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smstw/subscriptions","organizations_url":"https://api.github.com/users/smstw/orgs","repos_url":"https://api.github.com/users/smstw/repos","events_url":"https://api.github.com/users/smstw/events{/privacy}","received_events_url":"https://api.github.com/users/smstw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smstw/windwalker-joomla-rad","description":"Windwalker RAD framework for Joomla CMS","fork":true,"url":"https://api.github.com/repos/smstw/windwalker-joomla-rad","forks_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/forks","keys_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/teams","hooks_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/hooks","issue_events_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/events{/number}","events_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/events","assignees_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/assignees{/user}","branches_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/branches{/branch}","tags_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/tags","blobs_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/statuses/{sha}","languages_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/languages","stargazers_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/stargazers","contributors_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/contributors","subscribers_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/subscribers","subscription_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/subscription","commits_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/contents/{+path}","compare_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/merges","archive_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/downloads","issues_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues{/number}","pulls_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls{/number}","milestones_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/milestones{/number}","notifications_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/labels{/name}","releases_url":"https://api.github.com/repos/smstw/windwalker-joomla-rad/releases{/id}","created_at":"2014-09-26T10:20:58Z","updated_at":"2015-04-04T15:38:53Z","pushed_at":"2015-04-04T15:38:53Z","git_url":"git://github.com/smstw/windwalker-joomla-rad.git","ssh_url":"git@github.com:smstw/windwalker-joomla-rad.git","clone_url":"https://github.com/smstw/windwalker-joomla-rad.git","svn_url":"https://github.com/smstw/windwalker-joomla-rad","homepage":"http://ventoviro.github.io/windwalker-rad-doc/","size":3050,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":23,"forks":3,"open_issues":23,"watchers":0,"default_branch":"dev-2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36"},"html":{"href":"https://github.com/smstw/windwalker-joomla-rad/pull/36"},"issue":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/36"},"comments":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/smstw/windwalker-joomla-rad/statuses/e0483269cc0e01546c46d4bca4883b9827854896"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asika32764","id":1639206,"avatar_url":"https://avatars.githubusercontent.com/u/1639206?v=3","gravatar_id":"","url":"https://api.github.com/users/asika32764","html_url":"https://github.com/asika32764","followers_url":"https://api.github.com/users/asika32764/followers","following_url":"https://api.github.com/users/asika32764/following{/other_user}","gists_url":"https://api.github.com/users/asika32764/gists{/gist_id}","starred_url":"https://api.github.com/users/asika32764/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asika32764/subscriptions","organizations_url":"https://api.github.com/users/asika32764/orgs","repos_url":"https://api.github.com/users/asika32764/repos","events_url":"https://api.github.com/users/asika32764/events{/privacy}","received_events_url":"https://api.github.com/users/asika32764/received_events","type":"User","site_admin":false},"comments":12,"review_comments":37,"commits":8,"additions":122,"deletions":2,"changed_files":2}}