{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/24784585","id":24784585,"diff_hunk":"@@ -0,0 +1,279 @@\n+package rafthttp\n+\n+import (\n+\t\"encoding/binary\"\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"io\"\n+\t\"log\"\n+\t\"net/http\"\n+\t\"net/url\"\n+\t\"path\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\t\"github.com/coreos/etcd/pkg/types\"\n+\t\"github.com/coreos/etcd/raft/raftpb\"\n+)\n+\n+var (\n+\tstreamBufSize = 4096\n+\terrHeartbeat  = errors.New(\"the message is heartbeat\")\n+)\n+\n+type encoder interface {\n+\t// isEllegible returns whether the message is ellegible to be encoded.\n+\t// You must ensure the message is ellegible before calling encodeTo.\n+\tisEllegible(m raftpb.Message) bool\n+\t// loadMetadata loads the metadata from the given info. It updates\n+\t// the intenal status and attributes of the encoder.\n+\tloadMetadata(info http.Header)\n+\t// encodeTo encodes the given message to an output stream. The\n+\t// wire-format message must not start with big-endian uint64 zero, which\n+\t// is reserved as heartbeat.\n+\tencodeTo(w io.Writer, m raftpb.Message) error\n+}\n+\n+type decoder interface {\n+\t// needReset returns whether it needs to reset in-using internal\n+\t// attributes.\n+\tneedReset() bool\n+\t// saveMetadata saves the latest metadata into the given info. From now\n+\t// on, it uses the latest metadata as internal attributes.\n+\tsaveMetadata(info http.Header)\n+\t// decodeFrom decodes the message from an input stream. When it reads\n+\t// the data that starts with big-endian uint64 zero, it must return\n+\t// errHeartbeat.\n+\tdecodeFrom(r io.Reader) (raftpb.Message, error)\n+}\n+\n+type WriteFlushCloser interface {\n+\tio.WriteCloser\n+\thttp.Flusher\n+}\n+\n+type outgoingConn struct {\n+\tWriteFlushCloser\n+\tinfo http.Header\n+}\n+\n+type streamWriter struct {\n+\tenc encoder\n+\n+\tmu      sync.Mutex // guard field working\n+\tworking bool\n+\tmsgc    chan raftpb.Message\n+\tconnc   chan outgoingConn\n+\tstopc   chan struct{}\n+\tdone    chan struct{}\n+}\n+\n+func startStreamWriter(enc encoder) *streamWriter {\n+\tw := &streamWriter{\n+\t\tenc:   enc,\n+\t\tmsgc:  make(chan raftpb.Message, streamBufSize),\n+\t\tconnc: make(chan outgoingConn),\n+\t\tstopc: make(chan struct{}),\n+\t\tdone:  make(chan struct{}),\n+\t}\n+\tgo w.run()\n+\treturn w\n+}\n+\n+func (cw *streamWriter) run() {\n+\t// msgc is available iff w is valid\n+\tvar msgc chan raftpb.Message\n+\tvar heartbeatc <-chan time.Time\n+\tvar w WriteFlushCloser\n+\ttickc := time.Tick(ConnReadTimeout / 3)\n+\treset := func(nw WriteFlushCloser) {\n+\t\tif w != nil {\n+\t\t\tw.Close()\n+\t\t}\n+\t\tif nw != nil {\n+\t\t\theartbeatc, msgc = tickc, cw.msgc\n+\t\t} else {\n+\t\t\theartbeatc, msgc = nil, nil\n+\t\t}\n+\t\tw = nw\n+\t\tcw.mu.Lock()\n+\t\tcw.working = nw != nil\n+\t\tcw.mu.Unlock()\n+\t}\n+\tfor {\n+\t\tselect {\n+\t\tcase <-heartbeatc:\n+\t\t\t// send empty message as heartbeat\n+\t\t\tif err := binary.Write(w, binary.BigEndian, uint64(0)); err != nil {\n+\t\t\t\tlog.Printf(\"rafthttp: encountered error heartbeating to connection: %v\", err)\n+\t\t\t\treset(nil)\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tw.Flush()\n+\t\tcase m := <-msgc:\n+\t\t\tif !cw.enc.isEllegible(m) {\n+\t\t\t\tlog.Printf(\"rafthttp: silently dropped message %s because it is not ellegible\", m.Type)\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tif err := cw.enc.encodeTo(w, m); err != nil {\n+\t\t\t\tlog.Printf(\"rafthttp: encountered error writing to connection: %v\", err)\n+\t\t\t\treset(nil)\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tw.Flush()\n+\t\tcase conn := <-cw.connc:\n+\t\t\tcw.enc.loadMetadata(conn.info)\n+\t\t\treset(conn.WriteFlushCloser)\n+\t\tcase <-cw.stopc:\n+\t\t\tif w != nil {\n+\t\t\t\tw.Close()\n+\t\t\t}\n+\t\t\tclose(cw.done)\n+\t\t\treturn\n+\t\t}\n+\t}\n+}\n+\n+func (cw *streamWriter) canSend(m raftpb.Message) bool {\n+\tif !cw.enc.isEllegible(m) {\n+\t\treturn false\n+\t}\n+\tcw.mu.Lock()\n+\tdefer cw.mu.Unlock()\n+\treturn cw.working\n+}\n+\n+func (cw *streamWriter) setOutgoingConn(conn outgoingConn) bool {\n+\tselect {\n+\tcase cw.connc <- conn:\n+\t\treturn true\n+\tcase <-cw.done:\n+\t\treturn false\n+\t}\n+}\n+\n+func (cw *streamWriter) stop() {\n+\tclose(cw.stopc)\n+\t<-cw.done\n+}\n+\n+type streamDialer struct {\n+\tmu      sync.RWMutex // guard field u\n+\tu       string\n+\ttr      http.RoundTripper\n+\tfrom    types.ID\n+\tto      types.ID\n+\tcid     types.ID\n+\ttypeStr string\n+}\n+\n+func newStreamDialer(u string, tr http.RoundTripper, from, to, cid types.ID, typeStr string) *streamDialer {\n+\treturn &streamDialer{\n+\t\tu:       u,\n+\t\ttr:      tr,\n+\t\tfrom:    from,\n+\t\tto:      to,\n+\t\tcid:     cid,\n+\t\ttypeStr: typeStr,\n+\t}\n+}\n+\n+func (d *streamDialer) dial(dec decoder) (io.ReadCloser, error) {\n+\td.mu.RLock()\n+\tuu, err := url.Parse(d.u)\n+\td.mu.RUnlock()\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"parse url %s error: %v\", d.u, err)\n+\t}\n+\tuu.Path = path.Join(RaftStreamPrefix, d.from.String())\n+\treq, err := http.NewRequest(\"GET\", uu.String(), nil)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"new request to %s error: %v\", d.u, err)\n+\t}\n+\treq.Header.Set(\"X-Etcd-Cluster-ID\", d.cid.String())\n+\treq.Header.Set(\"X-Raft-To\", d.to.String())\n+\treq.Header.Set(\"X-Stream-Type\", d.typeStr)\n+\tdec.saveMetadata(req.Header)\n+\tresp, err := d.tr.RoundTrip(req)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"error posting to %q: %v\", d.u, err)\n+\t}\n+\tif resp.StatusCode != http.StatusOK {\n+\t\tresp.Body.Close()\n+\t\treturn nil, fmt.Errorf(\"unhandled http status %d\", resp.StatusCode)\n+\t}\n+\treturn resp.Body, nil\n+}\n+\n+func (d *streamDialer) update(u string) {\n+\td.mu.Lock()\n+\tdefer d.mu.Unlock()\n+\td.u = u\n+}\n+\n+type recvFunc func(m raftpb.Message) error\n+\n+type streamReader struct {\n+\tdialer *streamDialer\n+\tdec    decoder\n+\trecv   recvFunc","path":"rafthttp/stream.go","position":219,"original_position":219,"commit_id":"36807fd596c83f2e3005b942ba724375bfd971af","original_commit_id":"36807fd596c83f2e3005b942ba724375bfd971af","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"change this to a chan. it is better to use chan to do communication rather than a func call in go.","created_at":"2015-02-17T00:21:26Z","updated_at":"2015-02-17T00:21:26Z","html_url":"https://github.com/coreos/etcd/pull/2323#discussion_r24784585","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/2323","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/24784585"},"html":{"href":"https://github.com/coreos/etcd/pull/2323#discussion_r24784585"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/2323"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/2323","id":29402901,"html_url":"https://github.com/coreos/etcd/pull/2323","diff_url":"https://github.com/coreos/etcd/pull/2323.diff","patch_url":"https://github.com/coreos/etcd/pull/2323.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/2323","number":2323,"state":"open","locked":false,"title":"rafthttp: refactor peer","user":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"body":"Architecture:\r\nEach peer manages three worker:\r\nmsgApp stream: receive/send entries of msgApp fast\r\ngeneral stream: receive/send all other messages fast\r\npipeline: the safest but slowest way to receive/send messages\r\n\r\nPerformance:\r\nEnvironment: MacBook Pro (Retina, 15-inch, Mid 2014), 3-member cluster, 200 clients\r\npropose to leader: 7245 req/s\r\npropose to follower: 1963 req/s\r\n\r\nFeedback is welcome.\r\n\r\nKeep working:\r\n- [ ] fix tests\r\n- [ ] add tests\r\n\r\nFurther thoughts:\r\n1. more specific-usage streams can make it faster and more stable\r\n2. the speed that propose to follower is restricted heavily because we don't recover CommitIndex in msgApp stream","created_at":"2015-02-16T21:49:20Z","updated_at":"2015-02-17T00:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/2323/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/2323/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/2323/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/36807fd596c83f2e3005b942ba724375bfd971af","head":{"label":"yichengq:320","ref":"320","sha":"36807fd596c83f2e3005b942ba724375bfd971af","user":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"repo":{"id":16744058,"name":"etcd","full_name":"yichengq/etcd","owner":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yichengq/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/yichengq/etcd","forks_url":"https://api.github.com/repos/yichengq/etcd/forks","keys_url":"https://api.github.com/repos/yichengq/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yichengq/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yichengq/etcd/teams","hooks_url":"https://api.github.com/repos/yichengq/etcd/hooks","issue_events_url":"https://api.github.com/repos/yichengq/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/yichengq/etcd/events","assignees_url":"https://api.github.com/repos/yichengq/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/yichengq/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/yichengq/etcd/tags","blobs_url":"https://api.github.com/repos/yichengq/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yichengq/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yichengq/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/yichengq/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yichengq/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/yichengq/etcd/languages","stargazers_url":"https://api.github.com/repos/yichengq/etcd/stargazers","contributors_url":"https://api.github.com/repos/yichengq/etcd/contributors","subscribers_url":"https://api.github.com/repos/yichengq/etcd/subscribers","subscription_url":"https://api.github.com/repos/yichengq/etcd/subscription","commits_url":"https://api.github.com/repos/yichengq/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/yichengq/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/yichengq/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/yichengq/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/yichengq/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/yichengq/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yichengq/etcd/merges","archive_url":"https://api.github.com/repos/yichengq/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yichengq/etcd/downloads","issues_url":"https://api.github.com/repos/yichengq/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/yichengq/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/yichengq/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/yichengq/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yichengq/etcd/labels{/name}","releases_url":"https://api.github.com/repos/yichengq/etcd/releases{/id}","created_at":"2014-02-11T20:18:23Z","updated_at":"2015-02-12T19:42:08Z","pushed_at":"2015-02-16T21:39:28Z","git_url":"git://github.com/yichengq/etcd.git","ssh_url":"git@github.com:yichengq/etcd.git","clone_url":"https://github.com/yichengq/etcd.git","svn_url":"https://github.com/yichengq/etcd","homepage":"","size":16972,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:210","ref":"210","sha":"d87a628691fcbb8d0526c11515d59c4826420799","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2015-02-16T22:29:27Z","pushed_at":"2015-02-16T20:43:18Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":28651,"stargazers_count":5658,"watchers_count":5658,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":659,"mirror_url":null,"open_issues_count":117,"forks":659,"open_issues":117,"watchers":5658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/2323"},"html":{"href":"https://github.com/coreos/etcd/pull/2323"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/2323"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/2323/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/2323/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/2323/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/36807fd596c83f2e3005b942ba724375bfd971af"}}}}