{"action":"created","comment":{"url":"https://api.github.com/repos/ga4gh/server/pulls/comments/26238110","id":26238110,"diff_hunk":"@@ -91,4 +98,41 @@ def testSearchAllVariants(self):\n \n     def testVariantSetMetadata(self):\n         # TODO get the metadata and test it.\n-        pass\n+        print(\"Testing variantset metadata \" + self._vcfFileName)\n+        keyMap = {}\n+        for metadata in self._gaObject.getMetadata():\n+            keyMap[metadata.key] = metadata\n+\n+        # Test version\n+        metadata = keyMap[\"version\"]\n+        self.assertEqual(metadata.value, self._vcfVersion)\n+\n+        # Test info\n+        for info_i in self._infos.keys():\n+            self.assertEqual( keyMap[\"info.\"+info_i].type, self._infos[info_i].type )\n+            pyvcf_number = self._infos[info_i].num\n+            if pyvcf_number == -1:\n+                pyvcf_number = \"A\"\n+            elif pyvcf_number == -2:\n+                pyvcf_number = \"G\"\n+            elif pyvcf_number is None:\n+                pyvcf_number = \".\"\n+            else:\n+                pyvcf_number = `pyvcf_number`\n+            self.assertEqual( keyMap[\"info.\"+info_i].number, pyvcf_number )\n+\n+        # Test format\n+        for format_i in self._formats.keys():\n+            self.assertEqual( keyMap[\"format.\"+format_i].type, self._formats[format_i].type )\n+            pyvcf_number = self._formats[format_i].num\n+            if pyvcf_number == -1:\n+                pyvcf_number = \"A\"\n+            elif pyvcf_number == -2:\n+                pyvcf_number = \"G\"\n+            elif pyvcf_number is None:\n+                pyvcf_number = \".\"\n+            else:\n+                pyvcf_number = `pyvcf_number`\n+            self.assertEqual( keyMap[\"format.\"+format_i].number, pyvcf_number )","path":"tests/datadriven/test_variants.py","position":54,"original_position":54,"commit_id":"8808595b730a3e67a1ffd726277bc1973493f286","original_commit_id":"8808595b730a3e67a1ffd726277bc1973493f286","user":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"body":"We generally prefer using the `format` method on strings to concatenation. Here we'd use ```\"FORMAT.{}\".format(key)```.","created_at":"2015-03-11T18:00:08Z","updated_at":"2015-03-11T18:00:08Z","html_url":"https://github.com/ga4gh/server/pull/234#discussion_r26238110","pull_request_url":"https://api.github.com/repos/ga4gh/server/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/ga4gh/server/pulls/comments/26238110"},"html":{"href":"https://github.com/ga4gh/server/pull/234#discussion_r26238110"},"pull_request":{"href":"https://api.github.com/repos/ga4gh/server/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/ga4gh/server/pulls/234","id":30963003,"html_url":"https://github.com/ga4gh/server/pull/234","diff_url":"https://github.com/ga4gh/server/pull/234.diff","patch_url":"https://github.com/ga4gh/server/pull/234.patch","issue_url":"https://api.github.com/repos/ga4gh/server/issues/234","number":234,"state":"open","locked":false,"title":"Issue220","user":{"login":"shajoezhu","id":3692541,"avatar_url":"https://avatars.githubusercontent.com/u/3692541?v=3","gravatar_id":"","url":"https://api.github.com/users/shajoezhu","html_url":"https://github.com/shajoezhu","followers_url":"https://api.github.com/users/shajoezhu/followers","following_url":"https://api.github.com/users/shajoezhu/following{/other_user}","gists_url":"https://api.github.com/users/shajoezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/shajoezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajoezhu/subscriptions","organizations_url":"https://api.github.com/users/shajoezhu/orgs","repos_url":"https://api.github.com/users/shajoezhu/repos","events_url":"https://api.github.com/users/shajoezhu/events{/privacy}","received_events_url":"https://api.github.com/users/shajoezhu/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-11T16:59:40Z","updated_at":"2015-03-11T18:00:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"414c7b666440138b70382a067c12978538ddfeba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ga4gh/server/pulls/234/commits","review_comments_url":"https://api.github.com/repos/ga4gh/server/pulls/234/comments","review_comment_url":"https://api.github.com/repos/ga4gh/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga4gh/server/issues/234/comments","statuses_url":"https://api.github.com/repos/ga4gh/server/statuses/8808595b730a3e67a1ffd726277bc1973493f286","head":{"label":"shajoezhu:issue220","ref":"issue220","sha":"8808595b730a3e67a1ffd726277bc1973493f286","user":{"login":"shajoezhu","id":3692541,"avatar_url":"https://avatars.githubusercontent.com/u/3692541?v=3","gravatar_id":"","url":"https://api.github.com/users/shajoezhu","html_url":"https://github.com/shajoezhu","followers_url":"https://api.github.com/users/shajoezhu/followers","following_url":"https://api.github.com/users/shajoezhu/following{/other_user}","gists_url":"https://api.github.com/users/shajoezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/shajoezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajoezhu/subscriptions","organizations_url":"https://api.github.com/users/shajoezhu/orgs","repos_url":"https://api.github.com/users/shajoezhu/repos","events_url":"https://api.github.com/users/shajoezhu/events{/privacy}","received_events_url":"https://api.github.com/users/shajoezhu/received_events","type":"User","site_admin":false},"repo":{"id":31903230,"name":"server","full_name":"shajoezhu/server","owner":{"login":"shajoezhu","id":3692541,"avatar_url":"https://avatars.githubusercontent.com/u/3692541?v=3","gravatar_id":"","url":"https://api.github.com/users/shajoezhu","html_url":"https://github.com/shajoezhu","followers_url":"https://api.github.com/users/shajoezhu/followers","following_url":"https://api.github.com/users/shajoezhu/following{/other_user}","gists_url":"https://api.github.com/users/shajoezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/shajoezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajoezhu/subscriptions","organizations_url":"https://api.github.com/users/shajoezhu/orgs","repos_url":"https://api.github.com/users/shajoezhu/repos","events_url":"https://api.github.com/users/shajoezhu/events{/privacy}","received_events_url":"https://api.github.com/users/shajoezhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shajoezhu/server","description":"A reference implementation of the APIs defined in the schemas repository.","fork":true,"url":"https://api.github.com/repos/shajoezhu/server","forks_url":"https://api.github.com/repos/shajoezhu/server/forks","keys_url":"https://api.github.com/repos/shajoezhu/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shajoezhu/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shajoezhu/server/teams","hooks_url":"https://api.github.com/repos/shajoezhu/server/hooks","issue_events_url":"https://api.github.com/repos/shajoezhu/server/issues/events{/number}","events_url":"https://api.github.com/repos/shajoezhu/server/events","assignees_url":"https://api.github.com/repos/shajoezhu/server/assignees{/user}","branches_url":"https://api.github.com/repos/shajoezhu/server/branches{/branch}","tags_url":"https://api.github.com/repos/shajoezhu/server/tags","blobs_url":"https://api.github.com/repos/shajoezhu/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shajoezhu/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shajoezhu/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/shajoezhu/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shajoezhu/server/statuses/{sha}","languages_url":"https://api.github.com/repos/shajoezhu/server/languages","stargazers_url":"https://api.github.com/repos/shajoezhu/server/stargazers","contributors_url":"https://api.github.com/repos/shajoezhu/server/contributors","subscribers_url":"https://api.github.com/repos/shajoezhu/server/subscribers","subscription_url":"https://api.github.com/repos/shajoezhu/server/subscription","commits_url":"https://api.github.com/repos/shajoezhu/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/shajoezhu/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/shajoezhu/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/shajoezhu/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/shajoezhu/server/contents/{+path}","compare_url":"https://api.github.com/repos/shajoezhu/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shajoezhu/server/merges","archive_url":"https://api.github.com/repos/shajoezhu/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shajoezhu/server/downloads","issues_url":"https://api.github.com/repos/shajoezhu/server/issues{/number}","pulls_url":"https://api.github.com/repos/shajoezhu/server/pulls{/number}","milestones_url":"https://api.github.com/repos/shajoezhu/server/milestones{/number}","notifications_url":"https://api.github.com/repos/shajoezhu/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shajoezhu/server/labels{/name}","releases_url":"https://api.github.com/repos/shajoezhu/server/releases{/id}","created_at":"2015-03-09T14:32:06Z","updated_at":"2015-03-11T17:01:37Z","pushed_at":"2015-03-11T17:01:36Z","git_url":"git://github.com/shajoezhu/server.git","ssh_url":"git@github.com:shajoezhu/server.git","clone_url":"https://github.com/shajoezhu/server.git","svn_url":"https://github.com/shajoezhu/server","homepage":null,"size":2756,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga4gh:master","ref":"master","sha":"4f0943f9b0bead8368e7813389180ac1f01c23d5","user":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"repo":{"id":22882621,"name":"server","full_name":"ga4gh/server","owner":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga4gh/server","description":"A reference implementation of the APIs defined in the schemas repository.","fork":false,"url":"https://api.github.com/repos/ga4gh/server","forks_url":"https://api.github.com/repos/ga4gh/server/forks","keys_url":"https://api.github.com/repos/ga4gh/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga4gh/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga4gh/server/teams","hooks_url":"https://api.github.com/repos/ga4gh/server/hooks","issue_events_url":"https://api.github.com/repos/ga4gh/server/issues/events{/number}","events_url":"https://api.github.com/repos/ga4gh/server/events","assignees_url":"https://api.github.com/repos/ga4gh/server/assignees{/user}","branches_url":"https://api.github.com/repos/ga4gh/server/branches{/branch}","tags_url":"https://api.github.com/repos/ga4gh/server/tags","blobs_url":"https://api.github.com/repos/ga4gh/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga4gh/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga4gh/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga4gh/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga4gh/server/statuses/{sha}","languages_url":"https://api.github.com/repos/ga4gh/server/languages","stargazers_url":"https://api.github.com/repos/ga4gh/server/stargazers","contributors_url":"https://api.github.com/repos/ga4gh/server/contributors","subscribers_url":"https://api.github.com/repos/ga4gh/server/subscribers","subscription_url":"https://api.github.com/repos/ga4gh/server/subscription","commits_url":"https://api.github.com/repos/ga4gh/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga4gh/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga4gh/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga4gh/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga4gh/server/contents/{+path}","compare_url":"https://api.github.com/repos/ga4gh/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga4gh/server/merges","archive_url":"https://api.github.com/repos/ga4gh/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga4gh/server/downloads","issues_url":"https://api.github.com/repos/ga4gh/server/issues{/number}","pulls_url":"https://api.github.com/repos/ga4gh/server/pulls{/number}","milestones_url":"https://api.github.com/repos/ga4gh/server/milestones{/number}","notifications_url":"https://api.github.com/repos/ga4gh/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga4gh/server/labels{/name}","releases_url":"https://api.github.com/repos/ga4gh/server/releases{/id}","created_at":"2014-08-12T15:31:49Z","updated_at":"2015-03-11T09:27:55Z","pushed_at":"2015-03-11T09:27:54Z","git_url":"git://github.com/ga4gh/server.git","ssh_url":"git@github.com:ga4gh/server.git","clone_url":"https://github.com/ga4gh/server.git","svn_url":"https://github.com/ga4gh/server","homepage":null,"size":7792,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":37,"forks":24,"open_issues":37,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga4gh/server/pulls/234"},"html":{"href":"https://github.com/ga4gh/server/pull/234"},"issue":{"href":"https://api.github.com/repos/ga4gh/server/issues/234"},"comments":{"href":"https://api.github.com/repos/ga4gh/server/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/ga4gh/server/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/ga4gh/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga4gh/server/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/ga4gh/server/statuses/8808595b730a3e67a1ffd726277bc1973493f286"}}}}