{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/34","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/34/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/34/events","html_url":"https://github.com/trilinos/Trilinos/issues/34","id":119343950,"number":34,"title":"Xpetra: many tests fail when Epetra, Tpetra, and OpenMP enabled","user":{"login":"mhoemmen","id":926747,"avatar_url":"https://avatars.githubusercontent.com/u/926747?v=3","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Xpetra","name":"Xpetra","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-29T07:05:26Z","updated_at":"2015-11-29T23:03:16Z","closed_at":null,"body":"@trilinos/xpetra \r\n\r\nWhen Epetra is enabled, Xpetra uses `Kokkos::Compat::KokkosSerialWrapperNode` as its Node type.  (This corresponds to the `Kokkos::Serial` execution space.)  There would be nothing particularly wrong with that, except that if Tpetra is also enabled, Xpetra then tries to instantiate Tpetra for that Node type.  This is a problem because Tpetra does not necessarily enable that Node type.  For example, if OpenMP is enabled (`Trilinos_ENABLE_OpenMP=ON`), Tpetra only enables the OpenMP Node type (`Kokkos::Compat::KokkosOpenMPWrapperNode`) by default.\r\n\r\nMy recent commit fixed the MPI_DEBUG build due to the above issue:\r\n\r\nhttps://github.com/trilinos/Trilinos/commit/64c7185b0b60411f65757ad3abc1c333470bdf83\r\n\r\nbut it does NOT fix several failing tests.  My guess is that the test failures are related."},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/160479729","html_url":"https://github.com/trilinos/Trilinos/issues/34#issuecomment-160479729","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/34","id":160479729,"user":{"login":"tawiesn","id":12903075,"avatar_url":"https://avatars.githubusercontent.com/u/12903075?v=3","gravatar_id":"","url":"https://api.github.com/users/tawiesn","html_url":"https://github.com/tawiesn","followers_url":"https://api.github.com/users/tawiesn/followers","following_url":"https://api.github.com/users/tawiesn/following{/other_user}","gists_url":"https://api.github.com/users/tawiesn/gists{/gist_id}","starred_url":"https://api.github.com/users/tawiesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawiesn/subscriptions","organizations_url":"https://api.github.com/users/tawiesn/orgs","repos_url":"https://api.github.com/users/tawiesn/repos","events_url":"https://api.github.com/users/tawiesn/events{/privacy}","received_events_url":"https://api.github.com/users/tawiesn/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T23:03:16Z","updated_at":"2015-11-29T23:03:16Z","body":"The idea was that Epetra requires the SerialNode and the configure should fail in case that both Epetra and Tpetra are enabled when the Serial Node is disabled. But i haven't committed that change since i don't like it. Andrey proposed that we check for the Kokkos::SerialNode directly. That is: if Epetra is enabled and Kokkos is enabled we need the SerialNode enabled. Otherwise the configure should fail. This would be independent on the Node types that Tpetra is using. In case only Epetra is enabled without Kokkos we would use the FakeKokkos SerialNode."}}