{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/7417","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/7417/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/7417/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/7417/events","html_url":"https://github.com/dotnet/roslyn/pull/7417","id":121616682,"number":7417,"title":"Don't perform blocking calls on async work while opening a document to give it a version.","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-11T01:36:31Z","updated_at":"2015-12-17T23:22:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/7417","html_url":"https://github.com/dotnet/roslyn/pull/7417","diff_url":"https://github.com/dotnet/roslyn/pull/7417.diff","patch_url":"https://github.com/dotnet/roslyn/pull/7417.patch"},"body":"Instead, defer the work will later when someone actually needs the version info.\r\n\r\nThis should prevent some hiccoughs we're seeing in TypeScript when they open files.\r\n\r\nFixes https://github.com/dotnet/roslyn/issues/7403 "},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/165613283","html_url":"https://github.com/dotnet/roslyn/pull/7417#issuecomment-165613283","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/7417","id":165613283,"user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T23:22:02Z","updated_at":"2015-12-17T23:22:02Z","body":"@mattwar  @jasonmalinowski   Can you take another look.  I had to do some *interesting* things to make existing code work properly.  Specifically, if we do have a source text from our previous document state, we attempt to squirrel it along so that later calls to TryGetText can succeed.  This is because we have a few clients (like Rename and Interactive) that assume that if the document is open that they'll be able to get the new text in a non-blocking fashion.\r\n\r\nThis is generally true, and something that is supportable.  What wasn't supportable was the idea that you could get the *version* without blocking.  That's because determining the version involves checking the *new* and *old* text against each other.  And getting the old text could be a blocking operation.  "}}