{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/comments/41076013","id":41076013,"diff_hunk":"@@ -565,11 +574,10 @@\n       },\n \n       attached: function() {\n-        this.listen(this.target, 'up', 'upAction');\n-        this.listen(this.target, 'down', 'downAction');\n-\n         if (!this.target.hasAttribute('noink')) {\n           this.keyEventTarget = this.target;\n+          this.listen(this.target, 'up', 'upAction');\n+          this.listen(this.target, 'down', 'downAction');","path":"paper-ripple.html","position":111,"original_position":111,"commit_id":"36bf39409e6a89b3054071c08ca410b7576f3cd1","original_commit_id":"f3cb3326b1ee08e61aacf77dbd89e4482fe9d3a6","user":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"body":"we're not binding `noink`. We can update things if `target` changes, but I have no idea what to do if the `target.noink` changes...","created_at":"2015-10-02T22:49:10Z","updated_at":"2015-10-02T22:49:10Z","html_url":"https://github.com/PolymerElements/paper-ripple/pull/42#discussion_r41076013","pull_request_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/comments/41076013"},"html":{"href":"https://github.com/PolymerElements/paper-ripple/pull/42#discussion_r41076013"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42","id":46689879,"html_url":"https://github.com/PolymerElements/paper-ripple/pull/42","diff_url":"https://github.com/PolymerElements/paper-ripple/pull/42.diff","patch_url":"https://github.com/PolymerElements/paper-ripple/pull/42.patch","issue_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/42","number":42,"state":"open","locked":false,"title":"fix noink on target","user":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"body":"I think the `noink` attribute wasn't implemented correctly. There is a style that applies it to the `host`, but the `attached` was changing something based on the target. In any case, using `noink` on the ripple or the target didn't have any observable effect.\r\n\r\nI'm now living under assumption `noink` is supposed to live on the target, which I think makes sense. In this case, I've removed the listeners (so that tapping the target shows no ink), which also allows the ripple to be called manually (with `simulatedRipple`)\r\n\r\nI've also cleaned up the tests that were manually faking events but didn't need to.","created_at":"2015-10-02T22:39:58Z","updated_at":"2015-10-02T22:49:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5459d951c75face8e3631eaeccf1f07cf44a345","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/42/comments","statuses_url":"https://api.github.com/repos/PolymerElements/paper-ripple/statuses/36bf39409e6a89b3054071c08ca410b7576f3cd1","head":{"label":"PolymerElements:fix-noink","ref":"fix-noink","sha":"36bf39409e6a89b3054071c08ca410b7576f3cd1","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34129761,"name":"paper-ripple","full_name":"PolymerElements/paper-ripple","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-ripple","description":"Adds a Material Design ripple effect to UI elements","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-ripple","forks_url":"https://api.github.com/repos/PolymerElements/paper-ripple/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-ripple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-ripple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-ripple/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-ripple/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-ripple/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-ripple/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-ripple/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-ripple/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-ripple/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-ripple/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-ripple/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-ripple/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-ripple/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-ripple/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-ripple/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-ripple/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-ripple/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-ripple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-ripple/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-ripple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-ripple/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-ripple/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-ripple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-ripple/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-ripple/releases{/id}","created_at":"2015-04-17T17:15:50Z","updated_at":"2015-09-03T21:10:11Z","pushed_at":"2015-10-02T22:46:44Z","git_url":"git://github.com/PolymerElements/paper-ripple.git","ssh_url":"git@github.com:PolymerElements/paper-ripple.git","clone_url":"https://github.com/PolymerElements/paper-ripple.git","svn_url":"https://github.com/PolymerElements/paper-ripple","homepage":"https://elements.polymer-project.org/elements/paper-ripple?view=demo:demo/index.html","size":1771,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":16,"forks":10,"open_issues":16,"watchers":5,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"77533cc6b1f6b1c8858907d1454001e6c3639f02","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34129761,"name":"paper-ripple","full_name":"PolymerElements/paper-ripple","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-ripple","description":"Adds a Material Design ripple effect to UI elements","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-ripple","forks_url":"https://api.github.com/repos/PolymerElements/paper-ripple/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-ripple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-ripple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-ripple/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-ripple/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-ripple/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-ripple/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-ripple/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-ripple/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-ripple/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-ripple/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-ripple/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-ripple/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-ripple/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-ripple/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-ripple/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-ripple/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-ripple/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-ripple/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-ripple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-ripple/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-ripple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-ripple/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-ripple/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-ripple/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-ripple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-ripple/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-ripple/releases{/id}","created_at":"2015-04-17T17:15:50Z","updated_at":"2015-09-03T21:10:11Z","pushed_at":"2015-10-02T22:46:44Z","git_url":"git://github.com/PolymerElements/paper-ripple.git","ssh_url":"git@github.com:PolymerElements/paper-ripple.git","clone_url":"https://github.com/PolymerElements/paper-ripple.git","svn_url":"https://github.com/PolymerElements/paper-ripple","homepage":"https://elements.polymer-project.org/elements/paper-ripple?view=demo:demo/index.html","size":1771,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":16,"forks":10,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42"},"html":{"href":"https://github.com/PolymerElements/paper-ripple/pull/42"},"issue":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/42"},"comments":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/paper-ripple/statuses/36bf39409e6a89b3054071c08ca410b7576f3cd1"}}}}