{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/45230422","id":45230422,"diff_hunk":"@@ -568,27 +569,42 @@ bool AudioClient::switchOutputToAudioDevice(const QString& outputDeviceName) {\n     return switchOutputToAudioDevice(getNamedAudioDeviceForMode(QAudio::AudioOutput, outputDeviceName));\n }\n \n-ty_gverb* AudioClient::createGverbFilter() {\n-    // Initialize a new gverb instance\n-    ty_gverb* filter = gverb_new(_outputFormat.sampleRate(), _reverbOptions->getMaxRoomSize(), _reverbOptions->getRoomSize(),\n-                                 _reverbOptions->getReverbTime(), _reverbOptions->getDamping(), _reverbOptions->getSpread(),\n-                                 _reverbOptions->getInputBandwidth(), _reverbOptions->getEarlyLevel(),\n-                                 _reverbOptions->getTailLevel());\n-\n-    return filter;\n-}\n+//ty_gverb* AudioClient::createGverbFilter() {","path":"libraries/audio-client/src/AudioClient.cpp","position":56,"original_position":56,"commit_id":"c61dad108c5125fad38cf1e360c94904a6fc4bfa","original_commit_id":"c61dad108c5125fad38cf1e360c94904a6fc4bfa","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"let's delete all this old code instead of just commenting it out.","created_at":"2015-11-18T17:25:10Z","updated_at":"2015-11-18T17:25:10Z","html_url":"https://github.com/highfidelity/hifi/pull/6416#discussion_r45230422","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6416","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/45230422"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6416#discussion_r45230422"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6416"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6416","id":51114343,"html_url":"https://github.com/highfidelity/hifi/pull/6416","diff_url":"https://github.com/highfidelity/hifi/pull/6416.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6416.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6416","number":6416,"state":"open","locked":false,"title":"New reverb","user":{"login":"kencooke","id":13965157,"avatar_url":"https://avatars.githubusercontent.com/u/13965157?v=3","gravatar_id":"","url":"https://api.github.com/users/kencooke","html_url":"https://github.com/kencooke","followers_url":"https://api.github.com/users/kencooke/followers","following_url":"https://api.github.com/users/kencooke/following{/other_user}","gists_url":"https://api.github.com/users/kencooke/gists{/gist_id}","starred_url":"https://api.github.com/users/kencooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencooke/subscriptions","organizations_url":"https://api.github.com/users/kencooke/orgs","repos_url":"https://api.github.com/users/kencooke/repos","events_url":"https://api.github.com/users/kencooke/events{/privacy}","received_events_url":"https://api.github.com/users/kencooke/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-18T17:22:19Z","updated_at":"2015-11-18T17:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d7527a0f6516256e8251e5ab8050c92e4bde5ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6416/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6416/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6416/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/c61dad108c5125fad38cf1e360c94904a6fc4bfa","head":{"label":"kencooke:audio-reverb","ref":"audio-reverb","sha":"c61dad108c5125fad38cf1e360c94904a6fc4bfa","user":{"login":"kencooke","id":13965157,"avatar_url":"https://avatars.githubusercontent.com/u/13965157?v=3","gravatar_id":"","url":"https://api.github.com/users/kencooke","html_url":"https://github.com/kencooke","followers_url":"https://api.github.com/users/kencooke/followers","following_url":"https://api.github.com/users/kencooke/following{/other_user}","gists_url":"https://api.github.com/users/kencooke/gists{/gist_id}","starred_url":"https://api.github.com/users/kencooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencooke/subscriptions","organizations_url":"https://api.github.com/users/kencooke/orgs","repos_url":"https://api.github.com/users/kencooke/repos","events_url":"https://api.github.com/users/kencooke/events{/privacy}","received_events_url":"https://api.github.com/users/kencooke/received_events","type":"User","site_admin":false},"repo":{"id":41748824,"name":"hifi","full_name":"kencooke/hifi","owner":{"login":"kencooke","id":13965157,"avatar_url":"https://avatars.githubusercontent.com/u/13965157?v=3","gravatar_id":"","url":"https://api.github.com/users/kencooke","html_url":"https://github.com/kencooke","followers_url":"https://api.github.com/users/kencooke/followers","following_url":"https://api.github.com/users/kencooke/following{/other_user}","gists_url":"https://api.github.com/users/kencooke/gists{/gist_id}","starred_url":"https://api.github.com/users/kencooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencooke/subscriptions","organizations_url":"https://api.github.com/users/kencooke/orgs","repos_url":"https://api.github.com/users/kencooke/repos","events_url":"https://api.github.com/users/kencooke/events{/privacy}","received_events_url":"https://api.github.com/users/kencooke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kencooke/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/kencooke/hifi","forks_url":"https://api.github.com/repos/kencooke/hifi/forks","keys_url":"https://api.github.com/repos/kencooke/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kencooke/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kencooke/hifi/teams","hooks_url":"https://api.github.com/repos/kencooke/hifi/hooks","issue_events_url":"https://api.github.com/repos/kencooke/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/kencooke/hifi/events","assignees_url":"https://api.github.com/repos/kencooke/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/kencooke/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/kencooke/hifi/tags","blobs_url":"https://api.github.com/repos/kencooke/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kencooke/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kencooke/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kencooke/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kencooke/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/kencooke/hifi/languages","stargazers_url":"https://api.github.com/repos/kencooke/hifi/stargazers","contributors_url":"https://api.github.com/repos/kencooke/hifi/contributors","subscribers_url":"https://api.github.com/repos/kencooke/hifi/subscribers","subscription_url":"https://api.github.com/repos/kencooke/hifi/subscription","commits_url":"https://api.github.com/repos/kencooke/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kencooke/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kencooke/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kencooke/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kencooke/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/kencooke/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kencooke/hifi/merges","archive_url":"https://api.github.com/repos/kencooke/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kencooke/hifi/downloads","issues_url":"https://api.github.com/repos/kencooke/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/kencooke/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/kencooke/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/kencooke/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kencooke/hifi/labels{/name}","releases_url":"https://api.github.com/repos/kencooke/hifi/releases{/id}","created_at":"2015-09-01T16:00:50Z","updated_at":"2015-09-01T16:00:55Z","pushed_at":"2015-11-18T17:18:50Z","git_url":"git://github.com/kencooke/hifi.git","ssh_url":"git@github.com:kencooke/hifi.git","clone_url":"https://github.com/kencooke/hifi.git","svn_url":"https://github.com/kencooke/hifi","homepage":"","size":183137,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"9c29ba2ca398735b19a28de9d68944714ca2d923","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-11-17T23:02:50Z","pushed_at":"2015-11-18T17:22:19Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":216287,"stargazers_count":325,"watchers_count":325,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":59,"forks":191,"open_issues":59,"watchers":325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6416"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6416"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6416"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6416/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6416/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6416/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/c61dad108c5125fad38cf1e360c94904a6fc4bfa"}}}}