{"action":"created","issue":{"url":"https://api.github.com/repos/mbedmicro/mbed/issues/1296","labels_url":"https://api.github.com/repos/mbedmicro/mbed/issues/1296/labels{/name}","comments_url":"https://api.github.com/repos/mbedmicro/mbed/issues/1296/comments","events_url":"https://api.github.com/repos/mbedmicro/mbed/issues/1296/events","html_url":"https://github.com/mbedmicro/mbed/pull/1296","id":100882485,"number":1296,"title":"Sync and Remount Copy and Waiting Reset Plugins for Test Suite","user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mbedmicro/mbed/labels/needs:%20review","name":"needs: review","color":"c7def8"},{"url":"https://api.github.com/repos/mbedmicro/mbed/labels/needs:%20work","name":"needs: work","color":"536353"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-13T22:21:31Z","updated_at":"2015-08-17T08:22:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mbedmicro/mbed/pulls/1296","html_url":"https://github.com/mbedmicro/mbed/pull/1296","diff_url":"https://github.com/mbedmicro/mbed/pull/1296.diff","patch_url":"https://github.com/mbedmicro/mbed/pull/1296.patch"},"body":"This pull request adds two copy plugins and one reset plugin to the test suite.\r\n\r\n# Copy Plugins\r\n- **sync:** This copy plugin attempts to use synchronous system calls to flash the test binary. \r\n- **remount:** This copy plugin tries to solve the issue with certain mbed boards appearing to run out of disk space on Linux and Mac. This plugin unmounts then remounts each board to refresh the disk usage data in the OS so that flashing can continue (hopefully) indefinitely.\r\n\r\nBoth of these plugins are fairly experimental, however it would help if they were merged so I can start testing them in the CI system.\r\n\r\n**NOTE:** This moves all python \"sleep\" commands out of the general host_test execution and into the specific copy plugins. I have added the sleeps back into the existing plugins.\r\n\r\n# Reset Plugin\r\n- **wait:** Not a particularly elegant plugin, but this simple adds a 2 second delay before the mbed platform is reset. This fixes issues with boards that reset after flashing. They tend to confuse the test suite by outputting serial data immediately before the soft reset is attempted. By waiting for a short amount of time, we can be sure to flush this data before resetting the mbed."},"comment":{"url":"https://api.github.com/repos/mbedmicro/mbed/issues/comments/131727923","html_url":"https://github.com/mbedmicro/mbed/pull/1296#issuecomment-131727923","issue_url":"https://api.github.com/repos/mbedmicro/mbed/issues/1296","id":131727923,"user":{"login":"PrzemekWirkus","id":6360720,"avatar_url":"https://avatars.githubusercontent.com/u/6360720?v=3","gravatar_id":"","url":"https://api.github.com/users/PrzemekWirkus","html_url":"https://github.com/PrzemekWirkus","followers_url":"https://api.github.com/users/PrzemekWirkus/followers","following_url":"https://api.github.com/users/PrzemekWirkus/following{/other_user}","gists_url":"https://api.github.com/users/PrzemekWirkus/gists{/gist_id}","starred_url":"https://api.github.com/users/PrzemekWirkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrzemekWirkus/subscriptions","organizations_url":"https://api.github.com/users/PrzemekWirkus/orgs","repos_url":"https://api.github.com/users/PrzemekWirkus/repos","events_url":"https://api.github.com/users/PrzemekWirkus/events{/privacy}","received_events_url":"https://api.github.com/users/PrzemekWirkus/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T08:22:16Z","updated_at":"2015-08-17T08:22:16Z","body":"@bridadan \r\nThank you for explanations.\r\n* I didn't test cp+sync on Linux with --parallel (We are not using parallel testing). Thank you for noticing this! Do you know what might be the problem?\r\n* 'program_cycle_s' is a value stored per target in targets.py, not ma magic value. It is a part of target's meta data.\r\n\r\nMy comments for now are:\r\n1. This PR is way to big. You are changing few things. Let's try to separate it into few PRs with smaller scopes.\r\n2. Please create separate PR for only adding your new plugins (remount etc.). This can be decoupled from this PR.\r\n3. We will merge first (but not yet) my PR with sync and work on top of both PRs?\r\n4. Can you test https://github.com/mbedmicro/mbed/pull/1298 does locking behavior can be observed?\r\n\r\nHope it makes sense to you!"}}