{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1973","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1973/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1973/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1973/events","html_url":"https://github.com/ipfs/go-ipfs/pull/1973","id":117075535,"number":1973,"title":"Remove chunker channel","user":{"login":"rht","id":395821,"avatar_url":"https://avatars.githubusercontent.com/u/395821?v=3","gravatar_id":"","url":"https://api.github.com/users/rht","html_url":"https://github.com/rht","followers_url":"https://api.github.com/users/rht/followers","following_url":"https://api.github.com/users/rht/following{/other_user}","gists_url":"https://api.github.com/users/rht/gists{/gist_id}","starred_url":"https://api.github.com/users/rht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rht/subscriptions","organizations_url":"https://api.github.com/users/rht/orgs","repos_url":"https://api.github.com/users/rht/repos","events_url":"https://api.github.com/users/rht/events{/privacy}","received_events_url":"https://api.github.com/users/rht/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/perf","name":"perf","color":"fbca04"},{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/RFCR","name":"RFCR","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-16T08:38:04Z","updated_at":"2015-12-01T16:03:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1973","html_url":"https://github.com/ipfs/go-ipfs/pull/1973","diff_url":"https://github.com/ipfs/go-ipfs/pull/1973.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1973.patch"},"body":"PR to keep track and measure the time and memory perf of `ipfs add` with channel iterator replaced with chunker object. Perhaps have to wait until go2.x when channel iterator becomes about as fast as counter object.\r\n\r\n- [x] fix tests\r\n- [ ] fixes #1969\r\n\r\nRan perf test on lots of 1MB files, `ipfs add` is about O(rsync) (faster than `git add`?)\r\n\r\nEdit: this plot below is misleading (the add operation is run under a goroutine, and without outputDagnode checking, the client exits long before the (ephemeral) daemon has finished the process), updated plot is in my last comment.\r\n![We say that people condemn a man to death and then we say the Law condemns him to death. \"Although the Jury can pardon (acquit?) him, the Law can't.\" (This *may* mean the Law can't take bribes, etc) The idea of something super-strict, something stricter than any judge can be, super-rigidity. The point being, you are inclined to ask: \"Do we have a picture of something more rigorous?\" Hardly. But we are inclined to express ourselves in the form of a superlative.](https://cloud.githubusercontent.com/assets/395821/11177377/b8e630ea-8c77-11e5-9ef1-33cdddfb3ea4.png)\r\n"},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/161013669","html_url":"https://github.com/ipfs/go-ipfs/pull/1973#issuecomment-161013669","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1973","id":161013669,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T16:03:20Z","updated_at":"2015-12-01T16:03:20Z","body":"yeah, it does. Lets get it rebased first though"}}