{"action":"created","comment":{"url":"https://api.github.com/repos/CodeBloom/rice/pulls/comments/45578221","id":45578221,"diff_hunk":"@@ -71,7 +72,7 @@ protected synchronized void initializeMetadata(Collection<Class<?>> types) {\n \t\t\t\t// from the keys of the map\n \t\t\t\tMap<Class<?>, DataObjectMetadata> metadata = null;\n \t\t\t\tif (provider.requiresListOfExistingTypes()) {\n-\t\t\t\t\tmetadata = provider.provideMetadataForTypes(masterMetadataMap.keySet());","path":"rice-framework/krad-data/src/main/java/org/kuali/rice/krad/data/provider/impl/CompositeMetadataProviderImpl.java","position":12,"original_position":12,"commit_id":"da49c19ab8a6354f40297e877f20b688436f7b5f","original_commit_id":"da49c19ab8a6354f40297e877f20b688436f7b5f","user":{"login":"ewestfal","id":1005823,"avatar_url":"https://avatars.githubusercontent.com/u/1005823?v=3","gravatar_id":"","url":"https://api.github.com/users/ewestfal","html_url":"https://github.com/ewestfal","followers_url":"https://api.github.com/users/ewestfal/followers","following_url":"https://api.github.com/users/ewestfal/following{/other_user}","gists_url":"https://api.github.com/users/ewestfal/gists{/gist_id}","starred_url":"https://api.github.com/users/ewestfal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewestfal/subscriptions","organizations_url":"https://api.github.com/users/ewestfal/orgs","repos_url":"https://api.github.com/users/ewestfal/repos","events_url":"https://api.github.com/users/ewestfal/events{/privacy}","received_events_url":"https://api.github.com/users/ewestfal/received_events","type":"User","site_admin":false},"body":"Oh, I should mention this fixes an issue that occurs when you compile with the jdk 1.8 compiler (with source and target set to 1.7) but then try to run the code on a 1.7 jdk (which Eclipse tries to do when you are running tests).","created_at":"2015-11-23T08:02:00Z","updated_at":"2015-11-23T08:02:00Z","html_url":"https://github.com/CodeBloom/rice/pull/9#discussion_r45578221","pull_request_url":"https://api.github.com/repos/CodeBloom/rice/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/comments/45578221"},"html":{"href":"https://github.com/CodeBloom/rice/pull/9#discussion_r45578221"},"pull_request":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/CodeBloom/rice/pulls/9","id":51495339,"html_url":"https://github.com/CodeBloom/rice/pull/9","diff_url":"https://github.com/CodeBloom/rice/pull/9.diff","patch_url":"https://github.com/CodeBloom/rice/pull/9.patch","issue_url":"https://api.github.com/repos/CodeBloom/rice/issues/9","number":9,"state":"open","locked":false,"title":"Fix integration tests","user":{"login":"ewestfal","id":1005823,"avatar_url":"https://avatars.githubusercontent.com/u/1005823?v=3","gravatar_id":"","url":"https://api.github.com/users/ewestfal","html_url":"https://github.com/ewestfal","followers_url":"https://api.github.com/users/ewestfal/followers","following_url":"https://api.github.com/users/ewestfal/following{/other_user}","gists_url":"https://api.github.com/users/ewestfal/gists{/gist_id}","starred_url":"https://api.github.com/users/ewestfal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewestfal/subscriptions","organizations_url":"https://api.github.com/users/ewestfal/orgs","repos_url":"https://api.github.com/users/ewestfal/repos","events_url":"https://api.github.com/users/ewestfal/events{/privacy}","received_events_url":"https://api.github.com/users/ewestfal/received_events","type":"User","site_admin":false},"body":"I did a full run of integration tests against mysql on my local machine (surprisingly only took 1.5 hours to run). I ended up with 2 errors and 1 failure. The errors were related to the fact that TravelerDetail was not using a PortableSequenceGenerator (I assume the test was passing just fine on oracle).The failure was a subtle issue with timestamps and datetime fields on the EntityPersistence test. Switched the test harness factory to use JodaTime (of course) and that fixed the problems.","created_at":"2015-11-23T08:01:02Z","updated_at":"2015-11-23T08:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d3b24be9818153b5e11a8e108733fca0a978d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CodeBloom/rice/pulls/9/commits","review_comments_url":"https://api.github.com/repos/CodeBloom/rice/pulls/9/comments","review_comment_url":"https://api.github.com/repos/CodeBloom/rice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeBloom/rice/issues/9/comments","statuses_url":"https://api.github.com/repos/CodeBloom/rice/statuses/da49c19ab8a6354f40297e877f20b688436f7b5f","head":{"label":"CodeBloom:fix-integration-tests","ref":"fix-integration-tests","sha":"da49c19ab8a6354f40297e877f20b688436f7b5f","user":{"login":"CodeBloom","id":15764547,"avatar_url":"https://avatars.githubusercontent.com/u/15764547?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeBloom","html_url":"https://github.com/CodeBloom","followers_url":"https://api.github.com/users/CodeBloom/followers","following_url":"https://api.github.com/users/CodeBloom/following{/other_user}","gists_url":"https://api.github.com/users/CodeBloom/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeBloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeBloom/subscriptions","organizations_url":"https://api.github.com/users/CodeBloom/orgs","repos_url":"https://api.github.com/users/CodeBloom/repos","events_url":"https://api.github.com/users/CodeBloom/events{/privacy}","received_events_url":"https://api.github.com/users/CodeBloom/received_events","type":"Organization","site_admin":false},"repo":{"id":45888751,"name":"rice","full_name":"CodeBloom/rice","owner":{"login":"CodeBloom","id":15764547,"avatar_url":"https://avatars.githubusercontent.com/u/15764547?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeBloom","html_url":"https://github.com/CodeBloom","followers_url":"https://api.github.com/users/CodeBloom/followers","following_url":"https://api.github.com/users/CodeBloom/following{/other_user}","gists_url":"https://api.github.com/users/CodeBloom/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeBloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeBloom/subscriptions","organizations_url":"https://api.github.com/users/CodeBloom/orgs","repos_url":"https://api.github.com/users/CodeBloom/repos","events_url":"https://api.github.com/users/CodeBloom/events{/privacy}","received_events_url":"https://api.github.com/users/CodeBloom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeBloom/rice","description":"middleware for institutions and kuali client applications","fork":true,"url":"https://api.github.com/repos/CodeBloom/rice","forks_url":"https://api.github.com/repos/CodeBloom/rice/forks","keys_url":"https://api.github.com/repos/CodeBloom/rice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeBloom/rice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeBloom/rice/teams","hooks_url":"https://api.github.com/repos/CodeBloom/rice/hooks","issue_events_url":"https://api.github.com/repos/CodeBloom/rice/issues/events{/number}","events_url":"https://api.github.com/repos/CodeBloom/rice/events","assignees_url":"https://api.github.com/repos/CodeBloom/rice/assignees{/user}","branches_url":"https://api.github.com/repos/CodeBloom/rice/branches{/branch}","tags_url":"https://api.github.com/repos/CodeBloom/rice/tags","blobs_url":"https://api.github.com/repos/CodeBloom/rice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeBloom/rice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeBloom/rice/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeBloom/rice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeBloom/rice/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeBloom/rice/languages","stargazers_url":"https://api.github.com/repos/CodeBloom/rice/stargazers","contributors_url":"https://api.github.com/repos/CodeBloom/rice/contributors","subscribers_url":"https://api.github.com/repos/CodeBloom/rice/subscribers","subscription_url":"https://api.github.com/repos/CodeBloom/rice/subscription","commits_url":"https://api.github.com/repos/CodeBloom/rice/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeBloom/rice/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeBloom/rice/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeBloom/rice/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeBloom/rice/contents/{+path}","compare_url":"https://api.github.com/repos/CodeBloom/rice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeBloom/rice/merges","archive_url":"https://api.github.com/repos/CodeBloom/rice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeBloom/rice/downloads","issues_url":"https://api.github.com/repos/CodeBloom/rice/issues{/number}","pulls_url":"https://api.github.com/repos/CodeBloom/rice/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeBloom/rice/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeBloom/rice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeBloom/rice/labels{/name}","releases_url":"https://api.github.com/repos/CodeBloom/rice/releases{/id}","created_at":"2015-11-10T05:06:12Z","updated_at":"2015-11-10T05:07:05Z","pushed_at":"2015-11-23T08:01:03Z","git_url":"git://github.com/CodeBloom/rice.git","ssh_url":"git@github.com:CodeBloom/rice.git","clone_url":"https://github.com/CodeBloom/rice.git","svn_url":"https://github.com/CodeBloom/rice","homepage":"http://www.kuali.org/rice","size":275580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeBloom:master","ref":"master","sha":"4cbec9ffcd72067710cc7b67b84b6036bdb92ac3","user":{"login":"CodeBloom","id":15764547,"avatar_url":"https://avatars.githubusercontent.com/u/15764547?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeBloom","html_url":"https://github.com/CodeBloom","followers_url":"https://api.github.com/users/CodeBloom/followers","following_url":"https://api.github.com/users/CodeBloom/following{/other_user}","gists_url":"https://api.github.com/users/CodeBloom/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeBloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeBloom/subscriptions","organizations_url":"https://api.github.com/users/CodeBloom/orgs","repos_url":"https://api.github.com/users/CodeBloom/repos","events_url":"https://api.github.com/users/CodeBloom/events{/privacy}","received_events_url":"https://api.github.com/users/CodeBloom/received_events","type":"Organization","site_admin":false},"repo":{"id":45888751,"name":"rice","full_name":"CodeBloom/rice","owner":{"login":"CodeBloom","id":15764547,"avatar_url":"https://avatars.githubusercontent.com/u/15764547?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeBloom","html_url":"https://github.com/CodeBloom","followers_url":"https://api.github.com/users/CodeBloom/followers","following_url":"https://api.github.com/users/CodeBloom/following{/other_user}","gists_url":"https://api.github.com/users/CodeBloom/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeBloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeBloom/subscriptions","organizations_url":"https://api.github.com/users/CodeBloom/orgs","repos_url":"https://api.github.com/users/CodeBloom/repos","events_url":"https://api.github.com/users/CodeBloom/events{/privacy}","received_events_url":"https://api.github.com/users/CodeBloom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeBloom/rice","description":"middleware for institutions and kuali client applications","fork":true,"url":"https://api.github.com/repos/CodeBloom/rice","forks_url":"https://api.github.com/repos/CodeBloom/rice/forks","keys_url":"https://api.github.com/repos/CodeBloom/rice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeBloom/rice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeBloom/rice/teams","hooks_url":"https://api.github.com/repos/CodeBloom/rice/hooks","issue_events_url":"https://api.github.com/repos/CodeBloom/rice/issues/events{/number}","events_url":"https://api.github.com/repos/CodeBloom/rice/events","assignees_url":"https://api.github.com/repos/CodeBloom/rice/assignees{/user}","branches_url":"https://api.github.com/repos/CodeBloom/rice/branches{/branch}","tags_url":"https://api.github.com/repos/CodeBloom/rice/tags","blobs_url":"https://api.github.com/repos/CodeBloom/rice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeBloom/rice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeBloom/rice/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeBloom/rice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeBloom/rice/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeBloom/rice/languages","stargazers_url":"https://api.github.com/repos/CodeBloom/rice/stargazers","contributors_url":"https://api.github.com/repos/CodeBloom/rice/contributors","subscribers_url":"https://api.github.com/repos/CodeBloom/rice/subscribers","subscription_url":"https://api.github.com/repos/CodeBloom/rice/subscription","commits_url":"https://api.github.com/repos/CodeBloom/rice/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeBloom/rice/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeBloom/rice/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeBloom/rice/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeBloom/rice/contents/{+path}","compare_url":"https://api.github.com/repos/CodeBloom/rice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeBloom/rice/merges","archive_url":"https://api.github.com/repos/CodeBloom/rice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeBloom/rice/downloads","issues_url":"https://api.github.com/repos/CodeBloom/rice/issues{/number}","pulls_url":"https://api.github.com/repos/CodeBloom/rice/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeBloom/rice/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeBloom/rice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeBloom/rice/labels{/name}","releases_url":"https://api.github.com/repos/CodeBloom/rice/releases{/id}","created_at":"2015-11-10T05:06:12Z","updated_at":"2015-11-10T05:07:05Z","pushed_at":"2015-11-23T08:01:03Z","git_url":"git://github.com/CodeBloom/rice.git","ssh_url":"git@github.com:CodeBloom/rice.git","clone_url":"https://github.com/CodeBloom/rice.git","svn_url":"https://github.com/CodeBloom/rice","homepage":"http://www.kuali.org/rice","size":275580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/9"},"html":{"href":"https://github.com/CodeBloom/rice/pull/9"},"issue":{"href":"https://api.github.com/repos/CodeBloom/rice/issues/9"},"comments":{"href":"https://api.github.com/repos/CodeBloom/rice/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeBloom/rice/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/CodeBloom/rice/statuses/da49c19ab8a6354f40297e877f20b688436f7b5f"}}}}