{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/28210241","id":28210241,"diff_hunk":"@@ -48,7 +47,7 @@ private[spark] class SortShuffleManager(conf: SparkConf) extends ShuffleManager\n       endPartition: Int,\n       context: TaskContext): ShuffleReader[K, C] = {\n     // We currently use the same block store shuffle fetcher as the hash-based shuffle.\n-    new HashShuffleReader(\n+    new MixedShuffleReader(","path":"core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala","position":13,"original_position":13,"commit_id":"c3275ff2b0b5a83db5c99ba7aaf3180572668ef1","original_commit_id":"c3275ff2b0b5a83db5c99ba7aaf3180572668ef1","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"body":"Yeah, I will figure out a way which is more meaningful.","created_at":"2015-04-13T01:18:41Z","updated_at":"2015-04-13T01:18:41Z","html_url":"https://github.com/apache/spark/pull/3438#discussion_r28210241","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3438","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/28210241"},"html":{"href":"https://github.com/apache/spark/pull/3438#discussion_r28210241"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3438"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3438","id":24979590,"html_url":"https://github.com/apache/spark/pull/3438","diff_url":"https://github.com/apache/spark/pull/3438.diff","patch_url":"https://github.com/apache/spark/pull/3438.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3438","number":3438,"state":"open","locked":false,"title":"[SPARK-2926][Shuffle]Add MR style sort-merge shuffle read for Spark sort-based shuffle","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"body":"This is a joint work with @sryza, Details and performance test report can be seen in [SPARK-2926](https://issues.apache.org/jira/browse/SPARK-2926).\r\n","created_at":"2014-11-25T01:53:39Z","updated_at":"2015-04-13T01:18:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"782571e71ff957f1f5cbda3b91513ce71d922346","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3438/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3438/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3438/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c3275ff2b0b5a83db5c99ba7aaf3180572668ef1","head":{"label":"jerryshao:sort-shuffle-read-new-netty","ref":"sort-shuffle-read-new-netty","sha":"c3275ff2b0b5a83db5c99ba7aaf3180572668ef1","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"repo":{"id":18259371,"name":"apache-spark","full_name":"jerryshao/apache-spark","owner":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryshao/apache-spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/jerryshao/apache-spark","forks_url":"https://api.github.com/repos/jerryshao/apache-spark/forks","keys_url":"https://api.github.com/repos/jerryshao/apache-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryshao/apache-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryshao/apache-spark/teams","hooks_url":"https://api.github.com/repos/jerryshao/apache-spark/hooks","issue_events_url":"https://api.github.com/repos/jerryshao/apache-spark/issues/events{/number}","events_url":"https://api.github.com/repos/jerryshao/apache-spark/events","assignees_url":"https://api.github.com/repos/jerryshao/apache-spark/assignees{/user}","branches_url":"https://api.github.com/repos/jerryshao/apache-spark/branches{/branch}","tags_url":"https://api.github.com/repos/jerryshao/apache-spark/tags","blobs_url":"https://api.github.com/repos/jerryshao/apache-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryshao/apache-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryshao/apache-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryshao/apache-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryshao/apache-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryshao/apache-spark/languages","stargazers_url":"https://api.github.com/repos/jerryshao/apache-spark/stargazers","contributors_url":"https://api.github.com/repos/jerryshao/apache-spark/contributors","subscribers_url":"https://api.github.com/repos/jerryshao/apache-spark/subscribers","subscription_url":"https://api.github.com/repos/jerryshao/apache-spark/subscription","commits_url":"https://api.github.com/repos/jerryshao/apache-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryshao/apache-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryshao/apache-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryshao/apache-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryshao/apache-spark/contents/{+path}","compare_url":"https://api.github.com/repos/jerryshao/apache-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryshao/apache-spark/merges","archive_url":"https://api.github.com/repos/jerryshao/apache-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryshao/apache-spark/downloads","issues_url":"https://api.github.com/repos/jerryshao/apache-spark/issues{/number}","pulls_url":"https://api.github.com/repos/jerryshao/apache-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryshao/apache-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryshao/apache-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryshao/apache-spark/labels{/name}","releases_url":"https://api.github.com/repos/jerryshao/apache-spark/releases{/id}","created_at":"2014-03-30T07:04:45Z","updated_at":"2014-07-09T01:42:23Z","pushed_at":"2015-04-10T03:05:47Z","git_url":"git://github.com/jerryshao/apache-spark.git","ssh_url":"git@github.com:jerryshao/apache-spark.git","clone_url":"https://github.com/jerryshao/apache-spark.git","svn_url":"https://github.com/jerryshao/apache-spark","homepage":null,"size":126794,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7683982faf920b8ac6cf46b79842450e7d46c5cc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-04-12T17:59:15Z","pushed_at":"2015-04-13T01:13:33Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1502544,"stargazers_count":3576,"watchers_count":3576,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3090,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":308,"forks":3090,"open_issues":308,"watchers":3576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3438"},"html":{"href":"https://github.com/apache/spark/pull/3438"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3438"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3438/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3438/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3438/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c3275ff2b0b5a83db5c99ba7aaf3180572668ef1"}}}}