{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/qunit/pulls/comments/37072711","id":37072711,"diff_hunk":"@@ -0,0 +1,34 @@\n+if ( defined.document ) {","path":"src/core/onerror.js","position":1,"original_position":1,"commit_id":"55e98d86f1b86c573883f2192ee345edfedaf197","original_commit_id":"55e98d86f1b86c573883f2192ee345edfedaf197","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"body":"Can we wrap this module in a IEFE? Helps ensure `onErrorFnPrev` isn't visible anywhere else.","created_at":"2015-08-14T12:49:16Z","updated_at":"2015-08-14T12:49:16Z","html_url":"https://github.com/jquery/qunit/pull/813#discussion_r37072711","pull_request_url":"https://api.github.com/repos/jquery/qunit/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/37072711"},"html":{"href":"https://github.com/jquery/qunit/pull/813#discussion_r37072711"},"pull_request":{"href":"https://api.github.com/repos/jquery/qunit/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/813","id":33878943,"html_url":"https://github.com/jquery/qunit/pull/813","diff_url":"https://github.com/jquery/qunit/pull/813.diff","patch_url":"https://github.com/jquery/qunit/pull/813.patch","issue_url":"https://api.github.com/repos/jquery/qunit/issues/813","number":813,"state":"open","locked":false,"title":"Core: Optimize utilization of global and window variables","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"Ref #790\r\n\r\nQUnit was found exported to the global object on Node environment.\r\n\r\nThis PR also removes QUnit.diff and QUnit.init functions on Node, they were always browser functions.\r\n\r\nThis might look as a breaking change, so we should also discuss if this if good to land only on 2.0 or maybe I could set a stub function for them printing a warning about their usage on non-browser envs, which is not functional.","created_at":"2015-04-22T17:01:10Z","updated_at":"2015-08-14T12:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b5900c854f188e3119b000b956257a2bc6ee0eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/qunit/pulls/813/commits","review_comments_url":"https://api.github.com/repos/jquery/qunit/pulls/813/comments","review_comment_url":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/813/comments","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/55e98d86f1b86c573883f2192ee345edfedaf197","head":{"label":"leobalter:node-global","ref":"node-global","sha":"55e98d86f1b86c573883f2192ee345edfedaf197","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"repo":{"id":15093934,"name":"qunit","full_name":"leobalter/qunit","owner":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leobalter/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/leobalter/qunit","forks_url":"https://api.github.com/repos/leobalter/qunit/forks","keys_url":"https://api.github.com/repos/leobalter/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leobalter/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leobalter/qunit/teams","hooks_url":"https://api.github.com/repos/leobalter/qunit/hooks","issue_events_url":"https://api.github.com/repos/leobalter/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/leobalter/qunit/events","assignees_url":"https://api.github.com/repos/leobalter/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/leobalter/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/leobalter/qunit/tags","blobs_url":"https://api.github.com/repos/leobalter/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leobalter/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leobalter/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/leobalter/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leobalter/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/leobalter/qunit/languages","stargazers_url":"https://api.github.com/repos/leobalter/qunit/stargazers","contributors_url":"https://api.github.com/repos/leobalter/qunit/contributors","subscribers_url":"https://api.github.com/repos/leobalter/qunit/subscribers","subscription_url":"https://api.github.com/repos/leobalter/qunit/subscription","commits_url":"https://api.github.com/repos/leobalter/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/leobalter/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/leobalter/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/leobalter/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/leobalter/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/leobalter/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leobalter/qunit/merges","archive_url":"https://api.github.com/repos/leobalter/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leobalter/qunit/downloads","issues_url":"https://api.github.com/repos/leobalter/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/leobalter/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/leobalter/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/leobalter/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leobalter/qunit/labels{/name}","releases_url":"https://api.github.com/repos/leobalter/qunit/releases{/id}","created_at":"2013-12-11T00:34:30Z","updated_at":"2015-04-14T15:26:48Z","pushed_at":"2015-08-13T15:58:11Z","git_url":"git://github.com/leobalter/qunit.git","ssh_url":"git@github.com:leobalter/qunit.git","clone_url":"https://github.com/leobalter/qunit.git","svn_url":"https://github.com/leobalter/qunit","homepage":"http://qunitjs.com","size":2509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"d359314e0ad6a21d998bed450f6fc289c5be3490","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"jquery/qunit","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/jquery/qunit","forks_url":"https://api.github.com/repos/jquery/qunit/forks","keys_url":"https://api.github.com/repos/jquery/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/qunit/teams","hooks_url":"https://api.github.com/repos/jquery/qunit/hooks","issue_events_url":"https://api.github.com/repos/jquery/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/qunit/events","assignees_url":"https://api.github.com/repos/jquery/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/qunit/tags","blobs_url":"https://api.github.com/repos/jquery/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/qunit/languages","stargazers_url":"https://api.github.com/repos/jquery/qunit/stargazers","contributors_url":"https://api.github.com/repos/jquery/qunit/contributors","subscribers_url":"https://api.github.com/repos/jquery/qunit/subscribers","subscription_url":"https://api.github.com/repos/jquery/qunit/subscription","commits_url":"https://api.github.com/repos/jquery/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/qunit/merges","archive_url":"https://api.github.com/repos/jquery/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/qunit/downloads","issues_url":"https://api.github.com/repos/jquery/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/qunit/labels{/name}","releases_url":"https://api.github.com/repos/jquery/qunit/releases{/id}","created_at":"2009-07-24T16:26:23Z","updated_at":"2015-08-14T07:35:29Z","pushed_at":"2015-08-13T15:58:11Z","git_url":"git://github.com/jquery/qunit.git","ssh_url":"git@github.com:jquery/qunit.git","clone_url":"https://github.com/jquery/qunit.git","svn_url":"https://github.com/jquery/qunit","homepage":"http://qunitjs.com","size":4917,"stargazers_count":3227,"watchers_count":3227,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":660,"mirror_url":null,"open_issues_count":56,"forks":660,"open_issues":56,"watchers":3227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/813"},"html":{"href":"https://github.com/jquery/qunit/pull/813"},"issue":{"href":"https://api.github.com/repos/jquery/qunit/issues/813"},"comments":{"href":"https://api.github.com/repos/jquery/qunit/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/qunit/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/qunit/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/qunit/statuses/55e98d86f1b86c573883f2192ee345edfedaf197"}}}}