{"action":"created","comment":{"url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments/35428883","id":35428883,"diff_hunk":"@@ -27,15 +27,13 @@ def pull_docker_images\n         end\n \n         def engine_names\n-          @engine_names ||= parsed_yaml.engine_names\n-        end\n-\n-        def engine_exists?(engine_name)\n-          engines_registry_list.keys.include?(engine_name)\n+          p config.engines","path":"lib/cc/cli/engines/install.rb","position":18,"original_position":18,"commit_id":"57b5ad9b3a2b0eb891c73b5c8e89449de5b07c4a","original_commit_id":"57b5ad9b3a2b0eb891c73b5c8e89449de5b07c4a","user":{"login":"GordonDiggs","id":245083,"avatar_url":"https://avatars.githubusercontent.com/u/245083?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonDiggs","html_url":"https://github.com/GordonDiggs","followers_url":"https://api.github.com/users/GordonDiggs/followers","following_url":"https://api.github.com/users/GordonDiggs/following{/other_user}","gists_url":"https://api.github.com/users/GordonDiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonDiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonDiggs/subscriptions","organizations_url":"https://api.github.com/users/GordonDiggs/orgs","repos_url":"https://api.github.com/users/GordonDiggs/repos","events_url":"https://api.github.com/users/GordonDiggs/events{/privacy}","received_events_url":"https://api.github.com/users/GordonDiggs/received_events","type":"User","site_admin":false},"body":"Should these `p` statements be here?","created_at":"2015-07-24T14:45:49Z","updated_at":"2015-07-24T14:45:49Z","html_url":"https://github.com/codeclimate/codeclimate/pull/69#discussion_r35428883","pull_request_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments/35428883"},"html":{"href":"https://github.com/codeclimate/codeclimate/pull/69#discussion_r35428883"},"pull_request":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69","id":40771539,"html_url":"https://github.com/codeclimate/codeclimate/pull/69","diff_url":"https://github.com/codeclimate/codeclimate/pull/69.diff","patch_url":"https://github.com/codeclimate/codeclimate/pull/69.patch","issue_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/69","number":69,"state":"open","locked":false,"title":"WIP: Replace custom Config object with CC::Yaml","user":{"login":"pbrisbin","id":50812,"avatar_url":"https://avatars.githubusercontent.com/u/50812?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrisbin","html_url":"https://github.com/pbrisbin","followers_url":"https://api.github.com/users/pbrisbin/followers","following_url":"https://api.github.com/users/pbrisbin/following{/other_user}","gists_url":"https://api.github.com/users/pbrisbin/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrisbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrisbin/subscriptions","organizations_url":"https://api.github.com/users/pbrisbin/orgs","repos_url":"https://api.github.com/users/pbrisbin/repos","events_url":"https://api.github.com/users/pbrisbin/events{/privacy}","received_events_url":"https://api.github.com/users/pbrisbin/received_events","type":"User","site_admin":false},"body":"All codeclimate.yml access should go through CC::Yaml to get the proper \nvalidations and content access. Custom Config objects and direct hash access\nshould be avoided at all costs.\n\nIncluded spec improvements:\n\n- Centralize repeated within_temp_dir definitions in helper\n- Centralize repeated create_yml definitions in helper\n- Replace Factory MysteryGuests with in-place HEREDOCs\n\n/cc @codeclimate/review\n\nI'm opening this as WIP to make it visible so someone else doesn't duplicate\nthis work by mistake. It is close enough that reviewing it in this WIP state\nwould still be valuable (I don't have any big changes planned).\n\nTODO:\n\n- config.foo = bar, or config[\"foo\"] = bar explodes with an unknown class error\n  meaning the in-place config updates don't work yet. This will probably have\n  to be fixed in cc-yaml (sigh).\n- Analyze blows up if given an entirely empty config. It's not clear if this\n  should be a validation error or no-enabled-engines error, either way it\n  should probably be better handled.\n- Related, should the require_codeclimate_yaml assertion used for the engines\n  and analyze commands require a *valid* codeclimate.yaml too?","created_at":"2015-07-24T12:50:52Z","updated_at":"2015-07-24T14:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c4280433d7ef2685eb4b3420a39cde1ab590dd7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69/commits","review_comments_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69/comments","review_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/69/comments","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/57b5ad9b3a2b0eb891c73b5c8e89449de5b07c4a","head":{"label":"codeclimate:pb-config","ref":"pb-config","sha":"57b5ad9b3a2b0eb891c73b5c8e89449de5b07c4a","user":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":37724576,"name":"codeclimate","full_name":"codeclimate/codeclimate","owner":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeclimate/codeclimate","description":"Code Climate CLI","fork":false,"url":"https://api.github.com/repos/codeclimate/codeclimate","forks_url":"https://api.github.com/repos/codeclimate/codeclimate/forks","keys_url":"https://api.github.com/repos/codeclimate/codeclimate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeclimate/codeclimate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeclimate/codeclimate/teams","hooks_url":"https://api.github.com/repos/codeclimate/codeclimate/hooks","issue_events_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/events{/number}","events_url":"https://api.github.com/repos/codeclimate/codeclimate/events","assignees_url":"https://api.github.com/repos/codeclimate/codeclimate/assignees{/user}","branches_url":"https://api.github.com/repos/codeclimate/codeclimate/branches{/branch}","tags_url":"https://api.github.com/repos/codeclimate/codeclimate/tags","blobs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeclimate/codeclimate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeclimate/codeclimate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/{sha}","languages_url":"https://api.github.com/repos/codeclimate/codeclimate/languages","stargazers_url":"https://api.github.com/repos/codeclimate/codeclimate/stargazers","contributors_url":"https://api.github.com/repos/codeclimate/codeclimate/contributors","subscribers_url":"https://api.github.com/repos/codeclimate/codeclimate/subscribers","subscription_url":"https://api.github.com/repos/codeclimate/codeclimate/subscription","commits_url":"https://api.github.com/repos/codeclimate/codeclimate/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeclimate/codeclimate/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeclimate/codeclimate/contents/{+path}","compare_url":"https://api.github.com/repos/codeclimate/codeclimate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeclimate/codeclimate/merges","archive_url":"https://api.github.com/repos/codeclimate/codeclimate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeclimate/codeclimate/downloads","issues_url":"https://api.github.com/repos/codeclimate/codeclimate/issues{/number}","pulls_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls{/number}","milestones_url":"https://api.github.com/repos/codeclimate/codeclimate/milestones{/number}","notifications_url":"https://api.github.com/repos/codeclimate/codeclimate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeclimate/codeclimate/labels{/name}","releases_url":"https://api.github.com/repos/codeclimate/codeclimate/releases{/id}","created_at":"2015-06-19T13:54:41Z","updated_at":"2015-07-24T01:11:12Z","pushed_at":"2015-07-24T12:52:54Z","git_url":"git://github.com/codeclimate/codeclimate.git","ssh_url":"git@github.com:codeclimate/codeclimate.git","clone_url":"https://github.com/codeclimate/codeclimate.git","svn_url":"https://github.com/codeclimate/codeclimate","homepage":null,"size":1166,"stargazers_count":425,"watchers_count":425,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":14,"forks":26,"open_issues":14,"watchers":425,"default_branch":"master"}},"base":{"label":"codeclimate:master","ref":"master","sha":"4464ab0f449541c5b5b373296a763699bf079176","user":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":37724576,"name":"codeclimate","full_name":"codeclimate/codeclimate","owner":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeclimate/codeclimate","description":"Code Climate CLI","fork":false,"url":"https://api.github.com/repos/codeclimate/codeclimate","forks_url":"https://api.github.com/repos/codeclimate/codeclimate/forks","keys_url":"https://api.github.com/repos/codeclimate/codeclimate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeclimate/codeclimate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeclimate/codeclimate/teams","hooks_url":"https://api.github.com/repos/codeclimate/codeclimate/hooks","issue_events_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/events{/number}","events_url":"https://api.github.com/repos/codeclimate/codeclimate/events","assignees_url":"https://api.github.com/repos/codeclimate/codeclimate/assignees{/user}","branches_url":"https://api.github.com/repos/codeclimate/codeclimate/branches{/branch}","tags_url":"https://api.github.com/repos/codeclimate/codeclimate/tags","blobs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeclimate/codeclimate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeclimate/codeclimate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/{sha}","languages_url":"https://api.github.com/repos/codeclimate/codeclimate/languages","stargazers_url":"https://api.github.com/repos/codeclimate/codeclimate/stargazers","contributors_url":"https://api.github.com/repos/codeclimate/codeclimate/contributors","subscribers_url":"https://api.github.com/repos/codeclimate/codeclimate/subscribers","subscription_url":"https://api.github.com/repos/codeclimate/codeclimate/subscription","commits_url":"https://api.github.com/repos/codeclimate/codeclimate/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeclimate/codeclimate/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeclimate/codeclimate/contents/{+path}","compare_url":"https://api.github.com/repos/codeclimate/codeclimate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeclimate/codeclimate/merges","archive_url":"https://api.github.com/repos/codeclimate/codeclimate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeclimate/codeclimate/downloads","issues_url":"https://api.github.com/repos/codeclimate/codeclimate/issues{/number}","pulls_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls{/number}","milestones_url":"https://api.github.com/repos/codeclimate/codeclimate/milestones{/number}","notifications_url":"https://api.github.com/repos/codeclimate/codeclimate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeclimate/codeclimate/labels{/name}","releases_url":"https://api.github.com/repos/codeclimate/codeclimate/releases{/id}","created_at":"2015-06-19T13:54:41Z","updated_at":"2015-07-24T01:11:12Z","pushed_at":"2015-07-24T12:52:54Z","git_url":"git://github.com/codeclimate/codeclimate.git","ssh_url":"git@github.com:codeclimate/codeclimate.git","clone_url":"https://github.com/codeclimate/codeclimate.git","svn_url":"https://github.com/codeclimate/codeclimate","homepage":null,"size":1166,"stargazers_count":425,"watchers_count":425,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":14,"forks":26,"open_issues":14,"watchers":425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69"},"html":{"href":"https://github.com/codeclimate/codeclimate/pull/69"},"issue":{"href":"https://api.github.com/repos/codeclimate/codeclimate/issues/69"},"comments":{"href":"https://api.github.com/repos/codeclimate/codeclimate/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/codeclimate/codeclimate/statuses/57b5ad9b3a2b0eb891c73b5c8e89449de5b07c4a"}}}}