{"action":"created","issue":{"url":"https://api.github.com/repos/Soluto/analytics-js/issues/5","labels_url":"https://api.github.com/repos/Soluto/analytics-js/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/Soluto/analytics-js/issues/5/comments","events_url":"https://api.github.com/repos/Soluto/analytics-js/issues/5/events","html_url":"https://github.com/Soluto/analytics-js/issues/5","id":114820523,"number":5,"title":"AnalyticsContext should be an internal class of analytics dispatcher","user":{"login":"omerlh","id":6730584,"avatar_url":"https://avatars.githubusercontent.com/u/6730584?v=3","gravatar_id":"","url":"https://api.github.com/users/omerlh","html_url":"https://github.com/omerlh","followers_url":"https://api.github.com/users/omerlh/followers","following_url":"https://api.github.com/users/omerlh/following{/other_user}","gists_url":"https://api.github.com/users/omerlh/gists{/gist_id}","starred_url":"https://api.github.com/users/omerlh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omerlh/subscriptions","organizations_url":"https://api.github.com/users/omerlh/orgs","repos_url":"https://api.github.com/users/omerlh/repos","events_url":"https://api.github.com/users/omerlh/events{/privacy}","received_events_url":"https://api.github.com/users/omerlh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Soluto/analytics-js/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Soluto/analytics-js/milestones/1","html_url":"https://github.com/Soluto/analytics-js/milestones/0.1","labels_url":"https://api.github.com/repos/Soluto/analytics-js/milestones/1/labels","id":1399872,"number":1,"title":"0.1","description":"First Release","creator":{"login":"odedw","id":1423146,"avatar_url":"https://avatars.githubusercontent.com/u/1423146?v=3","gravatar_id":"","url":"https://api.github.com/users/odedw","html_url":"https://github.com/odedw","followers_url":"https://api.github.com/users/odedw/followers","following_url":"https://api.github.com/users/odedw/following{/other_user}","gists_url":"https://api.github.com/users/odedw/gists{/gist_id}","starred_url":"https://api.github.com/users/odedw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedw/subscriptions","organizations_url":"https://api.github.com/users/odedw/orgs","repos_url":"https://api.github.com/users/odedw/repos","events_url":"https://api.github.com/users/odedw/events{/privacy}","received_events_url":"https://api.github.com/users/odedw/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2015-11-08T08:06:01Z","updated_at":"2015-11-08T08:15:52Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-11-03T13:52:08Z","updated_at":"2015-11-09T11:21:11Z","closed_at":null,"body":"I think today this class is only identical to AnalyticsEventModel, and it seem that the reason is to keep AnalyticsContext internal. \r\nIn order to keep it internal:\r\n - we need to remove the withContext method\r\n - we need to pass to dispatch method the AnalyticsEventModel, not the analyticsContext.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/Soluto/analytics-js/issues/comments/155032072","html_url":"https://github.com/Soluto/analytics-js/issues/5#issuecomment-155032072","issue_url":"https://api.github.com/repos/Soluto/analytics-js/issues/5","id":155032072,"user":{"login":"Yshayy","id":1076078,"avatar_url":"https://avatars.githubusercontent.com/u/1076078?v=3","gravatar_id":"","url":"https://api.github.com/users/Yshayy","html_url":"https://github.com/Yshayy","followers_url":"https://api.github.com/users/Yshayy/followers","following_url":"https://api.github.com/users/Yshayy/following{/other_user}","gists_url":"https://api.github.com/users/Yshayy/gists{/gist_id}","starred_url":"https://api.github.com/users/Yshayy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yshayy/subscriptions","organizations_url":"https://api.github.com/users/Yshayy/orgs","repos_url":"https://api.github.com/users/Yshayy/repos","events_url":"https://api.github.com/users/Yshayy/events{/privacy}","received_events_url":"https://api.github.com/users/Yshayy/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T11:21:11Z","updated_at":"2015-11-09T11:21:11Z","body":"Not sure, AnalyticsContext is dispatcher input, AnalyticsEventModel is dispatcher output."}}