{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/comments/27698392","id":27698392,"diff_hunk":"@@ -135,6 +135,7 @@ func (c *linuxContainer) commandTemplate(p *Process, childPipe *os.File) (*exec.\n \tcmd.Stdin = p.Stdin\n \tcmd.Stdout = p.Stdout\n \tcmd.Stderr = p.Stderr\n+\tcmd.ExtraFiles = p.ExtraFiles","path":"container_linux.go","position":4,"original_position":4,"commit_id":"ba48904bca1cff7f2d19ae35260902872ce7caff","original_commit_id":"ba48904bca1cff7f2d19ae35260902872ce7caff","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"body":"The correct code would look like:\r\n\r\n`cmd.ExtraFiles = append(p.ExtraFiles, childPipe)`","created_at":"2015-04-02T21:21:02Z","updated_at":"2015-04-02T21:21:02Z","html_url":"https://github.com/docker/libcontainer/pull/496#discussion_r27698392","pull_request_url":"https://api.github.com/repos/docker/libcontainer/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments/27698392"},"html":{"href":"https://github.com/docker/libcontainer/pull/496#discussion_r27698392"},"pull_request":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/496","id":32369128,"html_url":"https://github.com/docker/libcontainer/pull/496","diff_url":"https://github.com/docker/libcontainer/pull/496.diff","patch_url":"https://github.com/docker/libcontainer/pull/496.patch","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/496","number":496,"state":"open","locked":false,"title":"add option to pass additional fds to container process","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"This can be usefull to implement socket activated containers for example.","created_at":"2015-03-31T21:43:05Z","updated_at":"2015-04-02T21:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ff5a5f3a176276c132245534572dd011b2c41c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcontainer/pulls/496/commits","review_comments_url":"https://api.github.com/repos/docker/libcontainer/pulls/496/comments","review_comment_url":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/496/comments","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/ba48904bca1cff7f2d19ae35260902872ce7caff","head":{"label":"Mic92:master","ref":"master","sha":"ba48904bca1cff7f2d19ae35260902872ce7caff","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"repo":{"id":33211411,"name":"libcontainer","full_name":"Mic92/libcontainer","owner":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mic92/libcontainer","description":"Linux Containers","fork":true,"url":"https://api.github.com/repos/Mic92/libcontainer","forks_url":"https://api.github.com/repos/Mic92/libcontainer/forks","keys_url":"https://api.github.com/repos/Mic92/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mic92/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mic92/libcontainer/teams","hooks_url":"https://api.github.com/repos/Mic92/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/Mic92/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/Mic92/libcontainer/events","assignees_url":"https://api.github.com/repos/Mic92/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/Mic92/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/Mic92/libcontainer/tags","blobs_url":"https://api.github.com/repos/Mic92/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mic92/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mic92/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mic92/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mic92/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/Mic92/libcontainer/languages","stargazers_url":"https://api.github.com/repos/Mic92/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/Mic92/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/Mic92/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/Mic92/libcontainer/subscription","commits_url":"https://api.github.com/repos/Mic92/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mic92/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mic92/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mic92/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mic92/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/Mic92/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mic92/libcontainer/merges","archive_url":"https://api.github.com/repos/Mic92/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mic92/libcontainer/downloads","issues_url":"https://api.github.com/repos/Mic92/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/Mic92/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/Mic92/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/Mic92/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mic92/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/Mic92/libcontainer/releases{/id}","created_at":"2015-03-31T21:38:04Z","updated_at":"2015-04-01T06:03:02Z","pushed_at":"2015-04-01T06:03:01Z","git_url":"git://github.com/Mic92/libcontainer.git","ssh_url":"git@github.com:Mic92/libcontainer.git","clone_url":"https://github.com/Mic92/libcontainer.git","svn_url":"https://github.com/Mic92/libcontainer","homepage":"http://www.docker.com/","size":1538,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1a246dd54326124df57cb0e8e051f57abb549c9f","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15693680,"name":"libcontainer","full_name":"docker/libcontainer","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcontainer","description":"Linux Containers","fork":false,"url":"https://api.github.com/repos/docker/libcontainer","forks_url":"https://api.github.com/repos/docker/libcontainer/forks","keys_url":"https://api.github.com/repos/docker/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcontainer/teams","hooks_url":"https://api.github.com/repos/docker/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/docker/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcontainer/events","assignees_url":"https://api.github.com/repos/docker/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcontainer/tags","blobs_url":"https://api.github.com/repos/docker/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcontainer/languages","stargazers_url":"https://api.github.com/repos/docker/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/docker/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/docker/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/docker/libcontainer/subscription","commits_url":"https://api.github.com/repos/docker/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcontainer/merges","archive_url":"https://api.github.com/repos/docker/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcontainer/downloads","issues_url":"https://api.github.com/repos/docker/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcontainer/releases{/id}","created_at":"2014-01-07T03:05:05Z","updated_at":"2015-04-02T21:09:47Z","pushed_at":"2015-04-02T21:09:47Z","git_url":"git://github.com/docker/libcontainer.git","ssh_url":"git@github.com:docker/libcontainer.git","clone_url":"https://github.com/docker/libcontainer.git","svn_url":"https://github.com/docker/libcontainer","homepage":"http://www.docker.com/","size":7037,"stargazers_count":734,"watchers_count":734,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":54,"forks":204,"open_issues":54,"watchers":734,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/496"},"html":{"href":"https://github.com/docker/libcontainer/pull/496"},"issue":{"href":"https://api.github.com/repos/docker/libcontainer/issues/496"},"comments":{"href":"https://api.github.com/repos/docker/libcontainer/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcontainer/statuses/ba48904bca1cff7f2d19ae35260902872ce7caff"}}}}