{"action":"closed","number":401,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/401","id":40730731,"html_url":"https://github.com/twitter/finagle/pull/401","diff_url":"https://github.com/twitter/finagle/pull/401.diff","patch_url":"https://github.com/twitter/finagle/pull/401.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/401","number":401,"state":"closed","locked":false,"title":"Server-side wire tracing.","user":{"login":"olix0r","id":240738,"avatar_url":"https://avatars.githubusercontent.com/u/240738?v=3","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"body":"Problem:\r\n\r\nClients annotate WireSend and WireRecv at the bottom of the finagle\r\nstack.  There is no analog on the server-side (i.e. a top-of-the-stack\r\nindicator).\r\n\r\nFurthermore, it looks like WireTracingFilter.module was using the\r\nClientTracingFilter.role instead of WireTracingFilter.role. This may\r\ncause client tracing issues?\r\n\r\nSolution:\r\n\r\nIntroduce WireTracingFilter.serverModule at the top of the default\r\nserver stack.  This module installs a filter that annotates WireRecv\r\non receipt and WireSend on success.\r\n\r\nResult:\r\n\r\nTracers have a definitive 'top of stack' marker.","created_at":"2015-07-23T23:50:52Z","updated_at":"2015-07-23T23:52:53Z","closed_at":"2015-07-23T23:52:53Z","merged_at":null,"merge_commit_sha":"7a40c389168d58991c6ba11399c5fb1c6a01c34a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/401/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/401/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/401/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/7321c69bd40911f3977a0bdff462930562ca063d","head":{"label":"olix0r:server-wire-tracing","ref":"server-wire-tracing","sha":"7321c69bd40911f3977a0bdff462930562ca063d","user":{"login":"olix0r","id":240738,"avatar_url":"https://avatars.githubusercontent.com/u/240738?v=3","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"repo":{"id":30084506,"name":"finagle","full_name":"olix0r/finagle","owner":{"login":"olix0r","id":240738,"avatar_url":"https://avatars.githubusercontent.com/u/240738?v=3","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olix0r/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/olix0r/finagle","forks_url":"https://api.github.com/repos/olix0r/finagle/forks","keys_url":"https://api.github.com/repos/olix0r/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olix0r/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olix0r/finagle/teams","hooks_url":"https://api.github.com/repos/olix0r/finagle/hooks","issue_events_url":"https://api.github.com/repos/olix0r/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/olix0r/finagle/events","assignees_url":"https://api.github.com/repos/olix0r/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/olix0r/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/olix0r/finagle/tags","blobs_url":"https://api.github.com/repos/olix0r/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olix0r/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olix0r/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/olix0r/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olix0r/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/olix0r/finagle/languages","stargazers_url":"https://api.github.com/repos/olix0r/finagle/stargazers","contributors_url":"https://api.github.com/repos/olix0r/finagle/contributors","subscribers_url":"https://api.github.com/repos/olix0r/finagle/subscribers","subscription_url":"https://api.github.com/repos/olix0r/finagle/subscription","commits_url":"https://api.github.com/repos/olix0r/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/olix0r/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/olix0r/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/olix0r/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/olix0r/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/olix0r/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olix0r/finagle/merges","archive_url":"https://api.github.com/repos/olix0r/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olix0r/finagle/downloads","issues_url":"https://api.github.com/repos/olix0r/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/olix0r/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/olix0r/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/olix0r/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olix0r/finagle/labels{/name}","releases_url":"https://api.github.com/repos/olix0r/finagle/releases{/id}","created_at":"2015-01-30T18:10:10Z","updated_at":"2015-01-30T18:10:14Z","pushed_at":"2015-07-23T23:50:01Z","git_url":"git://github.com/olix0r/finagle.git","ssh_url":"git@github.com:olix0r/finagle.git","clone_url":"https://github.com/olix0r/finagle.git","svn_url":"https://github.com/olix0r/finagle","homepage":"http://twitter.github.io/finagle","size":26775,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:develop","ref":"develop","sha":"e0ebcfaa5b7fb08995e65b29d09b4b194e090c9d","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2015-07-23T05:50:24Z","pushed_at":"2015-07-23T23:50:52Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":36645,"stargazers_count":3618,"watchers_count":3618,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":689,"mirror_url":null,"open_issues_count":33,"forks":689,"open_issues":33,"watchers":3618,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/401"},"html":{"href":"https://github.com/twitter/finagle/pull/401"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/401"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/401/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/401/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/401/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/7321c69bd40911f3977a0bdff462930562ca063d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":15,"deletions":1,"changed_files":2}}