{"action":"opened","issue":{"url":"https://api.github.com/repos/WebDevStudios/generator-plugin-wp/issues/17","labels_url":"https://api.github.com/repos/WebDevStudios/generator-plugin-wp/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/WebDevStudios/generator-plugin-wp/issues/17/comments","events_url":"https://api.github.com/repos/WebDevStudios/generator-plugin-wp/issues/17/events","html_url":"https://github.com/WebDevStudios/generator-plugin-wp/issues/17","id":72494071,"number":17,"title":"load_textdomain does not need to be used","user":{"login":"dustyf","id":517178,"avatar_url":"https://avatars.githubusercontent.com/u/517178?v=3","gravatar_id":"","url":"https://api.github.com/users/dustyf","html_url":"https://github.com/dustyf","followers_url":"https://api.github.com/users/dustyf/followers","following_url":"https://api.github.com/users/dustyf/following{/other_user}","gists_url":"https://api.github.com/users/dustyf/gists{/gist_id}","starred_url":"https://api.github.com/users/dustyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustyf/subscriptions","organizations_url":"https://api.github.com/users/dustyf/orgs","repos_url":"https://api.github.com/users/dustyf/repos","events_url":"https://api.github.com/users/dustyf/events{/privacy}","received_events_url":"https://api.github.com/users/dustyf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-05-01T18:38:42Z","updated_at":"2015-05-01T18:38:42Z","closed_at":null,"body":"the load_textdomain function does not need to e used here: https://github.com/WebDevStudios/generator-plugin-wp/blob/master/app/templates/plugin.php#L146\r\n\r\nIf we are trying to use language pack files, load_plugin_textdomain will be able to do that.  See Otto's article here: http://ottopress.com/2013/language-packs-101-prepwork/\r\n\r\n> If you want to use language packs exclusively (note: WP will still check the base /wp-content/plugins directory for language files, just in case):\r\n>\r\n> Text Domain: plugin-slug\r\n> load_plugin_textdomain( 'plugin-slug' );\r\n\r\nI submitted a plugin to the repo using the generator, and although Mika said none of this will prevent the plugin from being accepted she wanted to let me know about it.  She also mentioned in the area where we are using load_textdomain, it should not be using hard coded folders, as someone's weird setup may not have what we expect."}}