{"action":"created","comment":{"url":"https://api.github.com/repos/SyncFree/antidote/pulls/comments/39417192","id":39417192,"diff_hunk":"@@ -33,7 +37,7 @@ confirm() ->\n     decrement_test(Nodes),\n     transfer_test(Nodes),\n     conditional_write_test(Nodes),\n-    rt:clean_cluster(Nodes),\n+    %rt:clean_cluster(Nodes),","path":"riak_test/opbcounter_test.erl","position":16,"original_position":16,"commit_id":"b0be2385e45f2460ba03dce2162e418c688991d0","original_commit_id":"b0be2385e45f2460ba03dce2162e418c688991d0","user":{"login":"cmeiklejohn","id":44939,"avatar_url":"https://avatars.githubusercontent.com/u/44939?v=3","gravatar_id":"","url":"https://api.github.com/users/cmeiklejohn","html_url":"https://github.com/cmeiklejohn","followers_url":"https://api.github.com/users/cmeiklejohn/followers","following_url":"https://api.github.com/users/cmeiklejohn/following{/other_user}","gists_url":"https://api.github.com/users/cmeiklejohn/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeiklejohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeiklejohn/subscriptions","organizations_url":"https://api.github.com/users/cmeiklejohn/orgs","repos_url":"https://api.github.com/users/cmeiklejohn/repos","events_url":"https://api.github.com/users/cmeiklejohn/events{/privacy}","received_events_url":"https://api.github.com/users/cmeiklejohn/received_events","type":"User","site_admin":false},"body":"> but it will slow down everything\r\n\r\nOf course it does, it's responsible for ensuring that no data exists between tests in the same module that would cause the test to fail because of some stale state.  It's doing work, so of course it's going to slow things down.\r\n\r\nRiak Test only ensures that state is clean *between test modules*, not *between multiple tests in the same module*.  If you have multiple tests in the same module, of which Antidote has many, this call is required to ensure *determinism*.  \r\n\r\nYou have two choices here: if the test is going to test multiple things and reconfigures the cluster between tests, this call is required to ensure that the state in the data directory has been reset -- otherwise you run the risk of executing something with the previous ring or reading data from a previous execution if you happen to access the same key.  Your other choice is to break things out into separate test modules.\r\n\r\nBut, I don't believe the call should just be removed without proper investigation.","created_at":"2015-09-14T16:50:30Z","updated_at":"2015-09-14T16:50:30Z","html_url":"https://github.com/SyncFree/antidote/pull/143#discussion_r39417192","pull_request_url":"https://api.github.com/repos/SyncFree/antidote/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/comments/39417192"},"html":{"href":"https://github.com/SyncFree/antidote/pull/143#discussion_r39417192"},"pull_request":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/SyncFree/antidote/pulls/143","id":44917158,"html_url":"https://github.com/SyncFree/antidote/pull/143","diff_url":"https://github.com/SyncFree/antidote/pull/143.diff","patch_url":"https://github.com/SyncFree/antidote/pull/143.patch","issue_url":"https://api.github.com/repos/SyncFree/antidote/issues/143","number":143,"state":"open","locked":false,"title":"Reduce time tests","user":{"login":"angbrav","id":2690993,"avatar_url":"https://avatars.githubusercontent.com/u/2690993?v=3","gravatar_id":"","url":"https://api.github.com/users/angbrav","html_url":"https://github.com/angbrav","followers_url":"https://api.github.com/users/angbrav/followers","following_url":"https://api.github.com/users/angbrav/following{/other_user}","gists_url":"https://api.github.com/users/angbrav/gists{/gist_id}","starred_url":"https://api.github.com/users/angbrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angbrav/subscriptions","organizations_url":"https://api.github.com/users/angbrav/orgs","repos_url":"https://api.github.com/users/angbrav/repos","events_url":"https://api.github.com/users/angbrav/events{/privacy}","received_events_url":"https://api.github.com/users/angbrav/received_events","type":"User","site_admin":false},"body":"I have merged the changes with the latest changes in the master branch.\r\n\r\nI have passed all the tests.\r\n\r\nMain changes are related to the number of vnodes spawned per node. I have parametrized that in every test. Now it uses 8 by default. It can be modified by adding the following line to the riak_test config file:\r\n\r\n%% The total number of virtual nodes to deploy in test by default.\r\n    {num_vnodes, 8},\r\n\r\nRiak_test spends a lot of time, creating cluster, so from now on I would say is better to put test affecting the same part of the code together. For instance, I merged append_test and append_failure_test together, so the riak_test has to only create the cluster once for both.\r\n\r\nOne more thing, I would say is better to use three nodes in the cluster (unless your test requires more) than six, because of the same reason.\r\n\r\nFinally, I have also added a new command into the Makefile called: stage-riak-test, which assumes stagedevrel was previously made.\r\n\r\nI think that's all, I do not know how much we have improved w.r.t. the last version of master (since Tyler already included some of these modifications in some test), but I do not think there are many more things we can do.\r\n\r\nManuel","created_at":"2015-09-14T11:03:08Z","updated_at":"2015-09-14T16:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4edcfde479358687948d4e5f36900eb3ea444ea8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SyncFree/antidote/pulls/143/commits","review_comments_url":"https://api.github.com/repos/SyncFree/antidote/pulls/143/comments","review_comment_url":"https://api.github.com/repos/SyncFree/antidote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SyncFree/antidote/issues/143/comments","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/b0be2385e45f2460ba03dce2162e418c688991d0","head":{"label":"SyncFree:reduce_time_tests","ref":"reduce_time_tests","sha":"b0be2385e45f2460ba03dce2162e418c688991d0","user":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"repo":{"id":17826843,"name":"antidote","full_name":"SyncFree/antidote","owner":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SyncFree/antidote","description":"SyncFree Reference Platform","fork":false,"url":"https://api.github.com/repos/SyncFree/antidote","forks_url":"https://api.github.com/repos/SyncFree/antidote/forks","keys_url":"https://api.github.com/repos/SyncFree/antidote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyncFree/antidote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyncFree/antidote/teams","hooks_url":"https://api.github.com/repos/SyncFree/antidote/hooks","issue_events_url":"https://api.github.com/repos/SyncFree/antidote/issues/events{/number}","events_url":"https://api.github.com/repos/SyncFree/antidote/events","assignees_url":"https://api.github.com/repos/SyncFree/antidote/assignees{/user}","branches_url":"https://api.github.com/repos/SyncFree/antidote/branches{/branch}","tags_url":"https://api.github.com/repos/SyncFree/antidote/tags","blobs_url":"https://api.github.com/repos/SyncFree/antidote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyncFree/antidote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyncFree/antidote/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyncFree/antidote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/{sha}","languages_url":"https://api.github.com/repos/SyncFree/antidote/languages","stargazers_url":"https://api.github.com/repos/SyncFree/antidote/stargazers","contributors_url":"https://api.github.com/repos/SyncFree/antidote/contributors","subscribers_url":"https://api.github.com/repos/SyncFree/antidote/subscribers","subscription_url":"https://api.github.com/repos/SyncFree/antidote/subscription","commits_url":"https://api.github.com/repos/SyncFree/antidote/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyncFree/antidote/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyncFree/antidote/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyncFree/antidote/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyncFree/antidote/contents/{+path}","compare_url":"https://api.github.com/repos/SyncFree/antidote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyncFree/antidote/merges","archive_url":"https://api.github.com/repos/SyncFree/antidote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyncFree/antidote/downloads","issues_url":"https://api.github.com/repos/SyncFree/antidote/issues{/number}","pulls_url":"https://api.github.com/repos/SyncFree/antidote/pulls{/number}","milestones_url":"https://api.github.com/repos/SyncFree/antidote/milestones{/number}","notifications_url":"https://api.github.com/repos/SyncFree/antidote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyncFree/antidote/labels{/name}","releases_url":"https://api.github.com/repos/SyncFree/antidote/releases{/id}","created_at":"2014-03-17T12:15:01Z","updated_at":"2015-07-03T01:20:40Z","pushed_at":"2015-09-14T15:36:01Z","git_url":"git://github.com/SyncFree/antidote.git","ssh_url":"git@github.com:SyncFree/antidote.git","clone_url":"https://github.com/SyncFree/antidote.git","svn_url":"https://github.com/SyncFree/antidote","homepage":"http://syncfree.lip6.fr","size":5788,"stargazers_count":27,"watchers_count":27,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":27,"forks":5,"open_issues":27,"watchers":27,"default_branch":"master"}},"base":{"label":"SyncFree:master","ref":"master","sha":"e7afa800ea48bdab76074d907ada051a7ae0896b","user":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"repo":{"id":17826843,"name":"antidote","full_name":"SyncFree/antidote","owner":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SyncFree/antidote","description":"SyncFree Reference Platform","fork":false,"url":"https://api.github.com/repos/SyncFree/antidote","forks_url":"https://api.github.com/repos/SyncFree/antidote/forks","keys_url":"https://api.github.com/repos/SyncFree/antidote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyncFree/antidote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyncFree/antidote/teams","hooks_url":"https://api.github.com/repos/SyncFree/antidote/hooks","issue_events_url":"https://api.github.com/repos/SyncFree/antidote/issues/events{/number}","events_url":"https://api.github.com/repos/SyncFree/antidote/events","assignees_url":"https://api.github.com/repos/SyncFree/antidote/assignees{/user}","branches_url":"https://api.github.com/repos/SyncFree/antidote/branches{/branch}","tags_url":"https://api.github.com/repos/SyncFree/antidote/tags","blobs_url":"https://api.github.com/repos/SyncFree/antidote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyncFree/antidote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyncFree/antidote/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyncFree/antidote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/{sha}","languages_url":"https://api.github.com/repos/SyncFree/antidote/languages","stargazers_url":"https://api.github.com/repos/SyncFree/antidote/stargazers","contributors_url":"https://api.github.com/repos/SyncFree/antidote/contributors","subscribers_url":"https://api.github.com/repos/SyncFree/antidote/subscribers","subscription_url":"https://api.github.com/repos/SyncFree/antidote/subscription","commits_url":"https://api.github.com/repos/SyncFree/antidote/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyncFree/antidote/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyncFree/antidote/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyncFree/antidote/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyncFree/antidote/contents/{+path}","compare_url":"https://api.github.com/repos/SyncFree/antidote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyncFree/antidote/merges","archive_url":"https://api.github.com/repos/SyncFree/antidote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyncFree/antidote/downloads","issues_url":"https://api.github.com/repos/SyncFree/antidote/issues{/number}","pulls_url":"https://api.github.com/repos/SyncFree/antidote/pulls{/number}","milestones_url":"https://api.github.com/repos/SyncFree/antidote/milestones{/number}","notifications_url":"https://api.github.com/repos/SyncFree/antidote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyncFree/antidote/labels{/name}","releases_url":"https://api.github.com/repos/SyncFree/antidote/releases{/id}","created_at":"2014-03-17T12:15:01Z","updated_at":"2015-07-03T01:20:40Z","pushed_at":"2015-09-14T15:36:01Z","git_url":"git://github.com/SyncFree/antidote.git","ssh_url":"git@github.com:SyncFree/antidote.git","clone_url":"https://github.com/SyncFree/antidote.git","svn_url":"https://github.com/SyncFree/antidote","homepage":"http://syncfree.lip6.fr","size":5788,"stargazers_count":27,"watchers_count":27,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":27,"forks":5,"open_issues":27,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/143"},"html":{"href":"https://github.com/SyncFree/antidote/pull/143"},"issue":{"href":"https://api.github.com/repos/SyncFree/antidote/issues/143"},"comments":{"href":"https://api.github.com/repos/SyncFree/antidote/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/SyncFree/antidote/statuses/b0be2385e45f2460ba03dce2162e418c688991d0"}}}}