{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/27342037","id":27342037,"diff_hunk":"@@ -234,17 +234,15 @@ func (n *Node) initStores(clock *hlc.Clock, engines []engine.Engine) error {\n \t\t\t}\n \t\t\treturn err\n \t\t}\n-\t\tif s.Ident.ClusterID != \"\" {\n-\t\t\tif s.Ident.StoreID == 0 {\n-\t\t\t\treturn util.Error(\"cluster id set for node ident but missing store id\")\n-\t\t\t}\n-\t\t\tcapacity, err := s.Capacity()\n-\t\t\tif err != nil {\n-\t\t\t\treturn err\n-\t\t\t}\n-\t\t\tlog.Infof(\"initialized store %s: %+v\", s, capacity)\n-\t\t\tn.lSender.AddStore(s)\n+\t\tif s.Ident.ClusterID == \"\" || s.Ident.NodeID == 0 {","path":"server/node.go","position":14,"original_position":14,"commit_id":"8295b5594e778e8fd36b17d4baf487814bc4a6e7","original_commit_id":"a32d14ce8a67d9e10599d381e2256fa9f0dabfe4","user":{"login":"kkaneda","id":8353550,"avatar_url":"https://avatars.githubusercontent.com/u/8353550?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaneda","html_url":"https://github.com/kkaneda","followers_url":"https://api.github.com/users/kkaneda/followers","following_url":"https://api.github.com/users/kkaneda/following{/other_user}","gists_url":"https://api.github.com/users/kkaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaneda/subscriptions","organizations_url":"https://api.github.com/users/kkaneda/orgs","repos_url":"https://api.github.com/users/kkaneda/repos","events_url":"https://api.github.com/users/kkaneda/events{/privacy}","received_events_url":"https://api.github.com/users/kkaneda/received_events","type":"User","site_admin":false},"body":"Sure, added a test. This shouldn't happen unless StoreIdent gets corrupted for some reason.","created_at":"2015-03-28T03:38:43Z","updated_at":"2015-03-28T03:38:43Z","html_url":"https://github.com/cockroachdb/cockroach/pull/490#discussion_r27342037","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/27342037"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/490#discussion_r27342037"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490","id":32086300,"html_url":"https://github.com/cockroachdb/cockroach/pull/490","diff_url":"https://github.com/cockroachdb/cockroach/pull/490.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/490.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/490","number":490,"state":"open","locked":false,"title":"Do not silently ignore a store that has no cluster ID","user":{"login":"kkaneda","id":8353550,"avatar_url":"https://avatars.githubusercontent.com/u/8353550?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaneda","html_url":"https://github.com/kkaneda","followers_url":"https://api.github.com/users/kkaneda/followers","following_url":"https://api.github.com/users/kkaneda/following{/other_user}","gists_url":"https://api.github.com/users/kkaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaneda/subscriptions","organizations_url":"https://api.github.com/users/kkaneda/orgs","repos_url":"https://api.github.com/users/kkaneda/repos","events_url":"https://api.github.com/users/kkaneda/events{/privacy}","received_events_url":"https://api.github.com/users/kkaneda/received_events","type":"User","site_admin":false},"body":"IIRC, once a store has successfully started, it should have a valid cluster ID and a node ID. If it doesn't have, something wrong should happen and we should return an error.","created_at":"2015-03-27T06:41:23Z","updated_at":"2015-03-28T03:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1ab8279327f142a226264357a8aaade71d1c8ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/490/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/8295b5594e778e8fd36b17d4baf487814bc4a6e7","head":{"label":"kkaneda:kkaneda/error_on_empty_cluster_id","ref":"kkaneda/error_on_empty_cluster_id","sha":"8295b5594e778e8fd36b17d4baf487814bc4a6e7","user":{"login":"kkaneda","id":8353550,"avatar_url":"https://avatars.githubusercontent.com/u/8353550?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaneda","html_url":"https://github.com/kkaneda","followers_url":"https://api.github.com/users/kkaneda/followers","following_url":"https://api.github.com/users/kkaneda/following{/other_user}","gists_url":"https://api.github.com/users/kkaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaneda/subscriptions","organizations_url":"https://api.github.com/users/kkaneda/orgs","repos_url":"https://api.github.com/users/kkaneda/repos","events_url":"https://api.github.com/users/kkaneda/events{/privacy}","received_events_url":"https://api.github.com/users/kkaneda/received_events","type":"User","site_admin":false},"repo":{"id":32374840,"name":"cockroach","full_name":"kkaneda/cockroach","owner":{"login":"kkaneda","id":8353550,"avatar_url":"https://avatars.githubusercontent.com/u/8353550?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaneda","html_url":"https://github.com/kkaneda","followers_url":"https://api.github.com/users/kkaneda/followers","following_url":"https://api.github.com/users/kkaneda/following{/other_user}","gists_url":"https://api.github.com/users/kkaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaneda/subscriptions","organizations_url":"https://api.github.com/users/kkaneda/orgs","repos_url":"https://api.github.com/users/kkaneda/repos","events_url":"https://api.github.com/users/kkaneda/events{/privacy}","received_events_url":"https://api.github.com/users/kkaneda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkaneda/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/kkaneda/cockroach","forks_url":"https://api.github.com/repos/kkaneda/cockroach/forks","keys_url":"https://api.github.com/repos/kkaneda/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkaneda/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkaneda/cockroach/teams","hooks_url":"https://api.github.com/repos/kkaneda/cockroach/hooks","issue_events_url":"https://api.github.com/repos/kkaneda/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/kkaneda/cockroach/events","assignees_url":"https://api.github.com/repos/kkaneda/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/kkaneda/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/kkaneda/cockroach/tags","blobs_url":"https://api.github.com/repos/kkaneda/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkaneda/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkaneda/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkaneda/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkaneda/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/kkaneda/cockroach/languages","stargazers_url":"https://api.github.com/repos/kkaneda/cockroach/stargazers","contributors_url":"https://api.github.com/repos/kkaneda/cockroach/contributors","subscribers_url":"https://api.github.com/repos/kkaneda/cockroach/subscribers","subscription_url":"https://api.github.com/repos/kkaneda/cockroach/subscription","commits_url":"https://api.github.com/repos/kkaneda/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkaneda/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkaneda/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkaneda/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkaneda/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/kkaneda/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkaneda/cockroach/merges","archive_url":"https://api.github.com/repos/kkaneda/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkaneda/cockroach/downloads","issues_url":"https://api.github.com/repos/kkaneda/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/kkaneda/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/kkaneda/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/kkaneda/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkaneda/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/kkaneda/cockroach/releases{/id}","created_at":"2015-03-17T06:08:36Z","updated_at":"2015-03-17T06:08:37Z","pushed_at":"2015-03-28T03:37:54Z","git_url":"git://github.com/kkaneda/cockroach.git","ssh_url":"git@github.com:kkaneda/cockroach.git","clone_url":"https://github.com/kkaneda/cockroach.git","svn_url":"https://github.com/kkaneda/cockroach","homepage":null,"size":11052,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"ebe9e77d77eaab5e6cdca97eb16683536c1acc67","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-03-28T03:05:17Z","pushed_at":"2015-03-28T03:37:54Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":18378,"stargazers_count":3207,"watchers_count":3207,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":40,"forks":230,"open_issues":40,"watchers":3207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/490"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/490"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/8295b5594e778e8fd36b17d4baf487814bc4a6e7"}}}}