{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/34892082","id":34892082,"diff_hunk":"@@ -470,11 +470,11 @@ function getDefaultIojsUrl(version) {\n if (require.main === module) {\n   var assert = require('assert')\n   console.log('test v2.3.4 -> https://iojs.org/download/release')\n-  assert(getDefaultIojsUrl('v2.3.4', 'https://iojs.org/download/release'))\n+  assert.equal(getDefaultIojsUrl('v2.3.4'), 'https://iojs.org/download/release')\n   console.log('test v2.3.4-nightly12345678aaaaaaaaaa -> https://iojs.org/download/nightly')\n-  assert(getDefaultIojsUrl('v2.3.4-nightly12345678aaaaaaaaaa', 'https://iojs.org/download/nightly'))\n+  assert.equal(getDefaultIojsUrl('v2.3.4-nightly12345678aaaaaaaaaa'), 'https://iojs.org/download/nightly')","path":"deps/npm/node_modules/node-gyp/lib/install.js","position":17,"original_position":17,"commit_id":"a54cda8796113e92b620144af6c6780bb6363c3d","original_commit_id":"a54cda8796113e92b620144af6c6780bb6363c3d","user":{"login":"orangemocha","id":1625870,"avatar_url":"https://avatars.githubusercontent.com/u/1625870?v=3","gravatar_id":"","url":"https://api.github.com/users/orangemocha","html_url":"https://github.com/orangemocha","followers_url":"https://api.github.com/users/orangemocha/followers","following_url":"https://api.github.com/users/orangemocha/following{/other_user}","gists_url":"https://api.github.com/users/orangemocha/gists{/gist_id}","starred_url":"https://api.github.com/users/orangemocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangemocha/subscriptions","organizations_url":"https://api.github.com/users/orangemocha/orgs","repos_url":"https://api.github.com/users/orangemocha/repos","events_url":"https://api.github.com/users/orangemocha/events{/privacy}","received_events_url":"https://api.github.com/users/orangemocha/received_events","type":"User","site_admin":false},"body":"Just an observation that the dot that was appended to the rc format might look good on nightly and next-nightly too. Eg: v2.3.4-nightly.12345678aaaaaaaaaa","created_at":"2015-07-17T14:09:13Z","updated_at":"2015-07-17T14:09:13Z","html_url":"https://github.com/nodejs/io.js/pull/2171#discussion_r34892082","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/2171","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/34892082"},"html":{"href":"https://github.com/nodejs/io.js/pull/2171#discussion_r34892082"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2171"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2171","id":39776966,"html_url":"https://github.com/nodejs/io.js/pull/2171","diff_url":"https://github.com/nodejs/io.js/pull/2171.diff","patch_url":"https://github.com/nodejs/io.js/pull/2171.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2171","number":2171,"state":"open","locked":false,"title":"node-gyp: detect RC build with x.y.z-rc.n format","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"body":"Targetting next, builds on bda3a2dd9d5a4dc3718835b00403b6d1a3d4a7bb but we've changed the version string for RC builds so the regex needs to work.\r\n\r\nI'm thinking that we should probably squash all of the node-gyp patches into one or two since they are getting out of hand. Perhaps we should pull in the latest npm and do it with that. Thoughts?","created_at":"2015-07-13T03:42:36Z","updated_at":"2015-07-17T14:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6de03f6547ed5c01443510b9b732b02db0e48dd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/2171/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/2171/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2171/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/a54cda8796113e92b620144af6c6780bb6363c3d","head":{"label":"rvagg:node-gyp-rc-fix","ref":"node-gyp-rc-fix","sha":"a54cda8796113e92b620144af6c6780bb6363c3d","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"repo":{"id":27289064,"name":"io.js","full_name":"rvagg/io.js","owner":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvagg/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/rvagg/io.js","forks_url":"https://api.github.com/repos/rvagg/io.js/forks","keys_url":"https://api.github.com/repos/rvagg/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvagg/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvagg/io.js/teams","hooks_url":"https://api.github.com/repos/rvagg/io.js/hooks","issue_events_url":"https://api.github.com/repos/rvagg/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/rvagg/io.js/events","assignees_url":"https://api.github.com/repos/rvagg/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/rvagg/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/rvagg/io.js/tags","blobs_url":"https://api.github.com/repos/rvagg/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvagg/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvagg/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvagg/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvagg/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/rvagg/io.js/languages","stargazers_url":"https://api.github.com/repos/rvagg/io.js/stargazers","contributors_url":"https://api.github.com/repos/rvagg/io.js/contributors","subscribers_url":"https://api.github.com/repos/rvagg/io.js/subscribers","subscription_url":"https://api.github.com/repos/rvagg/io.js/subscription","commits_url":"https://api.github.com/repos/rvagg/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvagg/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvagg/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvagg/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvagg/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/rvagg/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvagg/io.js/merges","archive_url":"https://api.github.com/repos/rvagg/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvagg/io.js/downloads","issues_url":"https://api.github.com/repos/rvagg/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/rvagg/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/rvagg/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/rvagg/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvagg/io.js/labels{/name}","releases_url":"https://api.github.com/repos/rvagg/io.js/releases{/id}","created_at":"2014-11-29T02:36:43Z","updated_at":"2015-05-14T08:54:39Z","pushed_at":"2015-07-17T03:45:32Z","git_url":"git://github.com/rvagg/io.js.git","ssh_url":"git@github.com:rvagg/io.js.git","clone_url":"https://github.com/rvagg/io.js.git","svn_url":"https://github.com/rvagg/io.js","homepage":null,"size":138973,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"v1.x"}},"base":{"label":"nodejs:next","ref":"next","sha":"3beae2ca85e6c2c411b2d8e03d9ec07a3d5bb98a","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Future Node.js releases will be based on io.js","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-07-17T10:39:09Z","pushed_at":"2015-07-17T08:42:34Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":189309,"stargazers_count":12870,"watchers_count":12870,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1026,"mirror_url":null,"open_issues_count":292,"forks":1026,"open_issues":292,"watchers":12870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2171"},"html":{"href":"https://github.com/nodejs/io.js/pull/2171"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2171"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2171/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2171/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2171/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/a54cda8796113e92b620144af6c6780bb6363c3d"}}}}