{"action":"created","issue":{"url":"https://api.github.com/repos/pydoit/doit/issues/23","labels_url":"https://api.github.com/repos/pydoit/doit/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/pydoit/doit/issues/23/comments","events_url":"https://api.github.com/repos/pydoit/doit/issues/23/events","html_url":"https://github.com/pydoit/doit/pull/23","id":56800340,"number":23,"title":"Allow to customize how file_dep are checked.","user":{"login":"saimn","id":311639,"avatar_url":"https://avatars.githubusercontent.com/u/311639?v=3","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-06T11:21:34Z","updated_at":"2015-02-06T17:59:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pydoit/doit/pulls/23","html_url":"https://github.com/pydoit/doit/pull/23","diff_url":"https://github.com/pydoit/doit/pull/23.diff","patch_url":"https://github.com/pydoit/doit/pull/23.patch"},"body":"Following #22, I tried to do something, but I don't understand clearly how the config / params are handled. Comments welcome ;)\r\n\r\nAdd a `modified_checkers` option which allows to choose how file_dep are checked\r\nto know if they are modified. `modified_checkers` is a dict with boolean values\r\nfor each checker:\r\n```\r\nDOIT_CONFIG = {\r\n    'modified_checkers' : {\r\n        'timestamp': True,\r\n        'size': True,\r\n        'md5': True\r\n    }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/pydoit/doit/issues/comments/73282991","html_url":"https://github.com/pydoit/doit/pull/23#issuecomment-73282991","issue_url":"https://api.github.com/repos/pydoit/doit/issues/23","id":73282991,"user":{"login":"schettino72","id":138474,"avatar_url":"https://avatars.githubusercontent.com/u/138474?v=3","gravatar_id":"","url":"https://api.github.com/users/schettino72","html_url":"https://github.com/schettino72","followers_url":"https://api.github.com/users/schettino72/followers","following_url":"https://api.github.com/users/schettino72/following{/other_user}","gists_url":"https://api.github.com/users/schettino72/gists{/gist_id}","starred_url":"https://api.github.com/users/schettino72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schettino72/subscriptions","organizations_url":"https://api.github.com/users/schettino72/orgs","repos_url":"https://api.github.com/users/schettino72/repos","events_url":"https://api.github.com/users/schettino72/events{/privacy}","received_events_url":"https://api.github.com/users/schettino72/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T17:59:33Z","updated_at":"2015-02-06T17:59:33Z","body":"Thanks for the patch. I took just a quick look...\r\n\r\n> The idea is that the dict could contain custom implementation for the different checkers (not implemented yet),\r\n\r\nI dont think using a dict like that is a good idea. Maybe the combination of values doesnt make sense...\r\nI would prefer if it was done the same as `reporters` are done. That is, built-in supported can be configured using its name \"string\" or you pass an object. I guess this object will need at least 2 methods as a minimum interface. One method for checking and another one for saving.\r\n\r\n> Also the tests passed locally, so I am not sure if the TestFileWatcher failure on Travis is related to my changes ?\r\n\r\n#7 "}}