{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/49","labels_url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/49/comments","events_url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/49/events","html_url":"https://github.com/jenkinsci/maven-plugin/pull/49","id":99046740,"number":49,"title":"[JENKINS-25272] Extend JENKINS-18403 workaround for newer remoting.jar","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-04T19:48:14Z","updated_at":"2015-08-04T19:51:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/maven-plugin/pulls/49","html_url":"https://github.com/jenkinsci/maven-plugin/pull/49","diff_url":"https://github.com/jenkinsci/maven-plugin/pull/49.diff","patch_url":"https://github.com/jenkinsci/maven-plugin/pull/49.patch"},"body":"[JENKINS-25272](https://issues.jenkins-ci.org/browse/JENKINS-25272)\r\n\r\nThe expected `UnsupportedClassVersionError` was actually getting thrown earlier, from the forked process, since for example [`Maven31Main` loads remoting](https://github.com/jenkinsci/maven-interceptors/blob/5792f2a7f19f76b1ea879cf2198d37d761790bda/maven3-agent/src/main/java/org/jvnet/hudson/maven3/agent/Maven3Main.java#L135) which now assumes a 6+ JRE. That main process died, so `Channels.forProcess` also died with a `SocketException` (unfortunately without a meaningful `cause`).\r\n\r\nThe fix simply makes the original workaround handle this case as well. The `UnsupportedClassVersionError` is still printed to the build log, but\r\n\r\n> JDK 5 not supported to run Maven; retrying with slave Java …\r\n\r\nis printed and the fallback works.\r\n\r\nConfirmed with a sample project that cannot be compiled using the `rt.jar` from a newer JDK. Making a functional test proving this seems hard, since we cannot assume the existence of a JDK 5 installation. Would need a Docker fixture or something like that, which is not even available for `JenkinsRule`.\r\n\r\n@reviewbybees"},"comment":{"url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/comments/127734103","html_url":"https://github.com/jenkinsci/maven-plugin/pull/49#issuecomment-127734103","issue_url":"https://api.github.com/repos/jenkinsci/maven-plugin/issues/49","id":127734103,"user":{"login":"reviewbybees","id":10512980,"avatar_url":"https://avatars.githubusercontent.com/u/10512980?v=3","gravatar_id":"","url":"https://api.github.com/users/reviewbybees","html_url":"https://github.com/reviewbybees","followers_url":"https://api.github.com/users/reviewbybees/followers","following_url":"https://api.github.com/users/reviewbybees/following{/other_user}","gists_url":"https://api.github.com/users/reviewbybees/gists{/gist_id}","starred_url":"https://api.github.com/users/reviewbybees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reviewbybees/subscriptions","organizations_url":"https://api.github.com/users/reviewbybees/orgs","repos_url":"https://api.github.com/users/reviewbybees/repos","events_url":"https://api.github.com/users/reviewbybees/events{/privacy}","received_events_url":"https://api.github.com/users/reviewbybees/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T19:51:03Z","updated_at":"2015-08-04T19:51:03Z","body":"This pull request originates from a [CloudBees](https://www.cloudbees.com/) employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see [this explanation](https://github.com/reviewbybees/about#about-reviewbybees).\n"}}