{"action":"created","issue":{"url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/1","labels_url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/1/comments","events_url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/1/events","html_url":"https://github.com/varunincharge/gridImageSearch/issues/1","id":108568793,"number":1,"title":"Project 2: Grid Image Search - Ready for Review","user":{"login":"varunincharge","id":3100312,"avatar_url":"https://avatars.githubusercontent.com/u/3100312?v=3","gravatar_id":"","url":"https://api.github.com/users/varunincharge","html_url":"https://github.com/varunincharge","followers_url":"https://api.github.com/users/varunincharge/followers","following_url":"https://api.github.com/users/varunincharge/following{/other_user}","gists_url":"https://api.github.com/users/varunincharge/gists{/gist_id}","starred_url":"https://api.github.com/users/varunincharge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varunincharge/subscriptions","organizations_url":"https://api.github.com/users/varunincharge/orgs","repos_url":"https://api.github.com/users/varunincharge/repos","events_url":"https://api.github.com/users/varunincharge/events{/privacy}","received_events_url":"https://api.github.com/users/varunincharge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-27T23:53:56Z","updated_at":"2015-09-28T06:11:16Z","closed_at":null,"body":"My app is complete, please review. /cc @codepathreview @codepath"},"comment":{"url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/comments/143648970","html_url":"https://github.com/varunincharge/gridImageSearch/issues/1#issuecomment-143648970","issue_url":"https://api.github.com/repos/varunincharge/gridImageSearch/issues/1","id":143648970,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T06:11:15Z","updated_at":"2015-09-28T06:11:15Z","body":"Nice work finishing all required stories with, consider adding more optionals next time. A few notes after checking out the code:\r\n\r\n* Properly used spinners (with populated values) to allow users to select filters\r\n* Properly sent and received relevant filters using a bundle to pass data between activities\r\n* Correctly organized source files, consider following java conventions for naming packages.\r\n* Properly reused the single base method in search activity to fetch results for both initial load and the pagination\r\n* Consider using the [ViewHolder pattern](https://github.com/codepath/android_guides/wiki/Using-an-ArrayAdapter-with-ListView#improving-performance-with-the-viewholder-pattern) to improve performance of photos `ListView`.\r\n* Consider moving the search field into the ActionBar using a [custom ActionBar layout](http://guides.codepath.com/android/Extended-ActionBar-Guide#custom-actionbar-layout) or with a [SearchView](http://guides.codepath.com/android/Extended-ActionBar-Guide#adding-searchview-to-actionbar). Also consider adding ShareIntent\r\n* Consider using Parcelable instead of Serializable ([benefits](http://stackoverflow.com/a/5551155))\r\n* Consider moving the search field into the ActionBar using a [custom ActionBar layout](http://guides.codepath.com/android/Extended-ActionBar-Guide#custom-actionbar-layout) or with a [SearchView](http://guides.codepath.com/android/Extended-ActionBar-Guide#adding-searchview-to-actionbar)\r\n* Consider adding [progress bars](http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out\r\n\r\nAlso, here's a more detailed [Project 2 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) which covers the most common issues with this submitted project. Read through the [feedback guide point-by-point](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) to determine how you could improve your submission. \r\n\r\nLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation."}}