{"action":"created","issue":{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/191","labels_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/191/comments","events_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/191/events","html_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/191","id":73998815,"number":191,"title":"Modifed eigenray_listener and wave_queue to use the same design pattern","user":{"login":"islanderjtn","id":3474388,"avatar_url":"https://avatars.githubusercontent.com/u/3474388?v=3","gravatar_id":"","url":"https://api.github.com/users/islanderjtn","html_url":"https://github.com/islanderjtn","followers_url":"https://api.github.com/users/islanderjtn/followers","following_url":"https://api.github.com/users/islanderjtn/following{/other_user}","gists_url":"https://api.github.com/users/islanderjtn/gists{/gist_id}","starred_url":"https://api.github.com/users/islanderjtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islanderjtn/subscriptions","organizations_url":"https://api.github.com/users/islanderjtn/orgs","repos_url":"https://api.github.com/users/islanderjtn/repos","events_url":"https://api.github.com/users/islanderjtn/events{/privacy}","received_events_url":"https://api.github.com/users/islanderjtn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/milestones/5","html_url":"https://github.com/campreilly/UnderSeaModelingLibrary/milestones/Reverberation%20Release","labels_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/milestones/5/labels","id":919759,"number":5,"title":"Reverberation Release","description":"Complete coding along with testing for full bistatic reverberation calulcations.","creator":{"login":"Tibonium","id":2381953,"avatar_url":"https://avatars.githubusercontent.com/u/2381953?v=3","gravatar_id":"","url":"https://api.github.com/users/Tibonium","html_url":"https://github.com/Tibonium","followers_url":"https://api.github.com/users/Tibonium/followers","following_url":"https://api.github.com/users/Tibonium/following{/other_user}","gists_url":"https://api.github.com/users/Tibonium/gists{/gist_id}","starred_url":"https://api.github.com/users/Tibonium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tibonium/subscriptions","organizations_url":"https://api.github.com/users/Tibonium/orgs","repos_url":"https://api.github.com/users/Tibonium/repos","events_url":"https://api.github.com/users/Tibonium/events{/privacy}","received_events_url":"https://api.github.com/users/Tibonium/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":32,"state":"open","created_at":"2015-01-02T16:22:21Z","updated_at":"2015-05-07T14:26:38Z","due_on":"2015-06-30T04:00:00Z","closed_at":null},"comments":4,"created_at":"2015-05-07T14:03:27Z","updated_at":"2015-05-07T15:19:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/191","html_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/191","diff_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/191.diff","patch_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/191.patch"},"body":"Resolves issue #143.\r\n* Modifed eigenray_listener and wave_queue to use the same design pattern as envelope_listener and envelope_notifier.\r\n* Modifed add_eigenverb_listener of wave_queue to use the same design pattern as envelope_listener and envelope_notifier. This removed the _collection item from wave_queue. A has_eigenverb_listener call was provided to check for no _collection. \r\n* The boolean return on add_eigenray_listener was removed, as this was not required, thus causing tests and studies to be updated not to check for failed listener addition. \r\n"},"comment":{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/comments/99907373","html_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/191#issuecomment-99907373","issue_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/191","id":99907373,"user":{"login":"islanderjtn","id":3474388,"avatar_url":"https://avatars.githubusercontent.com/u/3474388?v=3","gravatar_id":"","url":"https://api.github.com/users/islanderjtn","html_url":"https://github.com/islanderjtn","followers_url":"https://api.github.com/users/islanderjtn/followers","following_url":"https://api.github.com/users/islanderjtn/following{/other_user}","gists_url":"https://api.github.com/users/islanderjtn/gists{/gist_id}","starred_url":"https://api.github.com/users/islanderjtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islanderjtn/subscriptions","organizations_url":"https://api.github.com/users/islanderjtn/orgs","repos_url":"https://api.github.com/users/islanderjtn/repos","events_url":"https://api.github.com/users/islanderjtn/events{/privacy}","received_events_url":"https://api.github.com/users/islanderjtn/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T15:19:56Z","updated_at":"2015-05-07T15:19:56Z","body":"Investigated this.  Looking over code in LVCMS, not sure when this requirement was removed. I check again.\r\n\r\n\r\nFrom: Sean Reilly [mailto:notifications@github.com]\r\nSent: Thursday, May 07, 2015 11:17 AM\r\nTo: campreilly/UnderSeaModelingLibrary\r\nCc: Ted Burns\r\nSubject: Re: [UnderSeaModelingLibrary] Modifed eigenray_listener and wave_queue to use the same design pattern (#191)\r\n\r\n\r\nI looks like we are no longer passing runID in the add_eigenray() method of eigenray listener. Don't we need that to support concurrent wavefronts in LVCMS PG?\r\n\r\n/**\r\n\r\n * Pure virtual method to add eigenray to an object.\r\n\r\n *  @param   target_row Index of the target row to add to list of eigenrays\r\n\r\n *  @param   target_col Index of the target row to add to list of eigenrays\r\n\r\n *  @param   ray        eigenray data to add to list of eigenrays\r\n\r\n *  @param   run_id     Run Identification number.\r\n\r\n */\r\n\r\nvirtual void add_eigenray(size_t target_row, size_t target_col, eigenray ray) = 0; //, size_t run_id) = 0;\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/campreilly/UnderSeaModelingLibrary/pull/191#issuecomment-99906345>.\r\n\r\nThe information contained in this message, and any attachments, may contain privileged and/or proprietary information that is intended solely for the person or entity to which it is addressed. Moreover, it may contain export restricted technical data controlled by Export Administration Regulations (EAR) or the International Traffic in Arms Regulations (ITAR). Any review, retransmission, dissemination, or re-export to foreign or domestic entities by anyone other than the intended recipient in accordance with EAR and/or ITAR regulations is prohibited.\r\n"}}