{"action":"created","comment":{"url":"https://api.github.com/repos/mitocw/edx-platform/pulls/comments/35357128","id":35357128,"diff_hunk":"@@ -139,7 +139,7 @@ var edx = edx || {};\n               return !node.hidden;});\n             this.$el.html(schedule_template({chapters: this.showing}));\n             $('table.ccx-schedule .sequential,.vertical').hide();\n-            $('table.ccx-schedule .toggle-collapse').on('click', this.toggle_collapse);\n+            $('table.ccx-schedule .unit a').on('click', this.toggle_collapse);","path":"lms/static/js/ccx/schedule.js","position":5,"original_position":5,"commit_id":"dc049a590078254bebcdef7609289fe65c10c158","original_commit_id":"dc049a590078254bebcdef7609289fe65c10c158","user":{"login":"pwilkins","id":145821,"avatar_url":"https://avatars.githubusercontent.com/u/145821?v=3","gravatar_id":"","url":"https://api.github.com/users/pwilkins","html_url":"https://github.com/pwilkins","followers_url":"https://api.github.com/users/pwilkins/followers","following_url":"https://api.github.com/users/pwilkins/following{/other_user}","gists_url":"https://api.github.com/users/pwilkins/gists{/gist_id}","starred_url":"https://api.github.com/users/pwilkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwilkins/subscriptions","organizations_url":"https://api.github.com/users/pwilkins/orgs","repos_url":"https://api.github.com/users/pwilkins/repos","events_url":"https://api.github.com/users/pwilkins/events{/privacy}","received_events_url":"https://api.github.com/users/pwilkins/received_events","type":"User","site_admin":false},"body":"For my own information: why change ``.toggle-collapse`` to ``.unit a``? What is the difference?","created_at":"2015-07-23T18:48:34Z","updated_at":"2015-07-23T18:48:34Z","html_url":"https://github.com/mitocw/edx-platform/pull/26#discussion_r35357128","pull_request_url":"https://api.github.com/repos/mitocw/edx-platform/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/comments/35357128"},"html":{"href":"https://github.com/mitocw/edx-platform/pull/26#discussion_r35357128"},"pull_request":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/mitocw/edx-platform/pulls/26","id":40679342,"html_url":"https://github.com/mitocw/edx-platform/pull/26","diff_url":"https://github.com/mitocw/edx-platform/pull/26.diff","patch_url":"https://github.com/mitocw/edx-platform/pull/26.patch","issue_url":"https://api.github.com/repos/mitocw/edx-platform/issues/26","number":26,"state":"open","locked":false,"title":"Fixed explicit labels related issues on CCX coach dashboard and membershp team management","user":{"login":"amir-qayyum-khan","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-khan","html_url":"https://github.com/amir-qayyum-khan","followers_url":"https://api.github.com/users/amir-qayyum-khan/followers","following_url":"https://api.github.com/users/amir-qayyum-khan/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-khan/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-khan/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-khan/orgs","repos_url":"https://api.github.com/users/amir-qayyum-khan/repos","events_url":"https://api.github.com/users/amir-qayyum-khan/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-khan/received_events","type":"User","site_admin":false},"body":"### Problem Background\r\n(copied verbatim from **Mark Sadecki's** CCX Accessibility audit - July 17, 2015)\r\n\r\n\"Explicit labels are elements that programmatically associate form fields with accessible text. Many of the fields missing accessible labels in CCX have visible text labels already. They just need to be wrapped in ``<label>`` elements. ``<label>`` elements can be associated with input fields in one of two ways; an implied relationship is assumed if the input is a child of the ``<label>`` element, or, explicit relationships can be defined using a ``for`` attribute on the element that references an ``id`` attribute on the input.\r\n\r\n### CCX Coach Dashboard\r\n\r\n#### Schedule Tab\r\n- “Section” select menu is missing an explicit label.\r\n- “Subsection” select menu is missing an explicit label.\r\n- “Unit” select menu is missing an explicit label.\r\n- “Start Date” is missing explicit label\r\n- “Start Time” is missing explicit label\r\n- “Due Date” is missing explicit label\r\n- “Due Time” is missing explicit label\r\n\r\n#### Enrollment Tab\r\n- “Email Addresses/Usernames” textarea is missing an explicit label.\r\n- “Auto Enroll” checkbox is missing an explicit label.\r\n- “Notify users by email” checkbox is missing an explicit label.\r\n\r\n### Addressed In this PR\r\nIn this PR I fixed all explicit label related issues on schedule tab, enrollment tab inside CCX dashboard along with team management inside membership/Instructor.\r\n\r\nNow screen readers can read schedule and can add units to schedule. You can use screen reading tools like chromeVox (A chrome browser plugin) or command +F5 on mac to verify this PR.\r\nAlso read http://edx-partner-course-staff.readthedocs.org/en/latest/getting_started/accessibility.html\r\n\r\nIssue https://github.com/mitocw/edx-platform/issues/21\r\nEDX https://github.com/edx/edx-platform/pull/7855\r\nEDX https://github.com/edx/edx-platform/pull/7921\r\nEDX https://github.com/edx/edx-platform/pull/7873\r\n@pdpinch @pwilkins ","created_at":"2015-07-23T14:42:28Z","updated_at":"2015-07-23T18:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c94dd258910223e430557e1a79bad5491e745011","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitocw/edx-platform/pulls/26/commits","review_comments_url":"https://api.github.com/repos/mitocw/edx-platform/pulls/26/comments","review_comment_url":"https://api.github.com/repos/mitocw/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitocw/edx-platform/issues/26/comments","statuses_url":"https://api.github.com/repos/mitocw/edx-platform/statuses/dc049a590078254bebcdef7609289fe65c10c158","head":{"label":"mitocw:fix/aq/extended_labels_issues_ccx","ref":"fix/aq/extended_labels_issues_ccx","sha":"dc049a590078254bebcdef7609289fe65c10c158","user":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"repo":{"id":17842334,"name":"edx-platform","full_name":"mitocw/edx-platform","owner":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitocw/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/mitocw/edx-platform","forks_url":"https://api.github.com/repos/mitocw/edx-platform/forks","keys_url":"https://api.github.com/repos/mitocw/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitocw/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitocw/edx-platform/teams","hooks_url":"https://api.github.com/repos/mitocw/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/mitocw/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/mitocw/edx-platform/events","assignees_url":"https://api.github.com/repos/mitocw/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/mitocw/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/mitocw/edx-platform/tags","blobs_url":"https://api.github.com/repos/mitocw/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitocw/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitocw/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitocw/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitocw/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mitocw/edx-platform/languages","stargazers_url":"https://api.github.com/repos/mitocw/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/mitocw/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/mitocw/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/mitocw/edx-platform/subscription","commits_url":"https://api.github.com/repos/mitocw/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitocw/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitocw/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitocw/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitocw/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/mitocw/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitocw/edx-platform/merges","archive_url":"https://api.github.com/repos/mitocw/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitocw/edx-platform/downloads","issues_url":"https://api.github.com/repos/mitocw/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/mitocw/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mitocw/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mitocw/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitocw/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/mitocw/edx-platform/releases{/id}","created_at":"2014-03-17T20:32:05Z","updated_at":"2015-04-30T12:17:39Z","pushed_at":"2015-07-23T14:44:04Z","git_url":"git://github.com/mitocw/edx-platform.git","ssh_url":"git@github.com:mitocw/edx-platform.git","clone_url":"https://github.com/mitocw/edx-platform.git","svn_url":"https://github.com/mitocw/edx-platform","homepage":"http://code.edx.org/","size":504233,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"mitocw:master","ref":"master","sha":"93e31e614980b02b10aebbb0cad847dcd5e1d7d8","user":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"repo":{"id":17842334,"name":"edx-platform","full_name":"mitocw/edx-platform","owner":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitocw/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/mitocw/edx-platform","forks_url":"https://api.github.com/repos/mitocw/edx-platform/forks","keys_url":"https://api.github.com/repos/mitocw/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitocw/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitocw/edx-platform/teams","hooks_url":"https://api.github.com/repos/mitocw/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/mitocw/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/mitocw/edx-platform/events","assignees_url":"https://api.github.com/repos/mitocw/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/mitocw/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/mitocw/edx-platform/tags","blobs_url":"https://api.github.com/repos/mitocw/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitocw/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitocw/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitocw/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitocw/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mitocw/edx-platform/languages","stargazers_url":"https://api.github.com/repos/mitocw/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/mitocw/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/mitocw/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/mitocw/edx-platform/subscription","commits_url":"https://api.github.com/repos/mitocw/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitocw/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitocw/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitocw/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitocw/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/mitocw/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitocw/edx-platform/merges","archive_url":"https://api.github.com/repos/mitocw/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitocw/edx-platform/downloads","issues_url":"https://api.github.com/repos/mitocw/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/mitocw/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mitocw/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mitocw/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitocw/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/mitocw/edx-platform/releases{/id}","created_at":"2014-03-17T20:32:05Z","updated_at":"2015-04-30T12:17:39Z","pushed_at":"2015-07-23T14:44:04Z","git_url":"git://github.com/mitocw/edx-platform.git","ssh_url":"git@github.com:mitocw/edx-platform.git","clone_url":"https://github.com/mitocw/edx-platform.git","svn_url":"https://github.com/mitocw/edx-platform","homepage":"http://code.edx.org/","size":504233,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/26"},"html":{"href":"https://github.com/mitocw/edx-platform/pull/26"},"issue":{"href":"https://api.github.com/repos/mitocw/edx-platform/issues/26"},"comments":{"href":"https://api.github.com/repos/mitocw/edx-platform/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitocw/edx-platform/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/mitocw/edx-platform/statuses/dc049a590078254bebcdef7609289fe65c10c158"}}}}