{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/33794319","id":33794319,"diff_hunk":"@@ -1,63 +1,193 @@\n 'use strict';\n \n+require('./user-cfg.css');\n+\n var ko = require('knockout');\n+var Raven = require('raven-js');\n var $ = require('jquery');\n-require('./jquery.qrcode.min.js');\n+var bootbox = require('bootbox');\n+require('jquery-qrcode');\n \n var osfHelpers = require('js/osfHelpers');\n+var ChangeMessageMixin = require('js/changeMessage');\n \n-var SETTINGS_URL = '/api/v1/settings/twofactor/';\n \n-function ViewModel(qrCodeSelector, otpURL) {\n+function ViewModel(settingsUrl, qrCodeSelector) {\n     var self = this;\n+    self.settingsUrl = settingsUrl;\n     self.qrCodeSelector = qrCodeSelector;\n     self.tfaCode = ko.observable('');\n \n     self.message = ko.observable('');\n     self.messageClass = ko.observable('');\n-    // Initialize QR Code\n-    $(self.qrCodeSelector).qrcode(otpURL);\n-\n-    /** Change the flashed message. */\n-    self.changeMessage = function(text, css, timeout) {\n-        self.message(text);\n-        var cssClass = css || 'text-info';\n-        self.messageClass(cssClass);\n-        if (timeout) {\n-            // Reset message after timeout period\n-            setTimeout(function() {\n-                self.message('');\n-                self.messageClass('text-info');\n-            }, timeout);\n+\n+    self.isEnabled = ko.observable(false);\n+    self.isConfirmed = ko.observable(false);\n+    self.secret = ko.observable('');\n+\n+    self.urls = {};\n+}\n+$.extend(ViewModel.prototype, ChangeMessageMixin.prototype);","path":"website/addons/twofactor/static/twoFactorUserConfig.js","position":47,"original_position":47,"commit_id":"c468dfe151e70d1688a3e7a2221dd9790281ce76","original_commit_id":"c468dfe151e70d1688a3e7a2221dd9790281ce76","user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"body":"That should initialize the `message` and `messageClass` variables, so you would be able to remove their initialization on ~L21-22.","created_at":"2015-07-02T16:12:21Z","updated_at":"2015-07-02T16:12:21Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/3409#discussion_r33794319","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/33794319"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/3409#discussion_r33794319"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409","id":39009534,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/3409","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/3409.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/3409.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3409","number":3409,"state":"open","locked":false,"title":"[feature] Update Add-on User Settings UI","user":{"login":"samanehsan","id":6414394,"avatar_url":"https://avatars.githubusercontent.com/u/6414394?v=3","gravatar_id":"","url":"https://api.github.com/users/samanehsan","html_url":"https://github.com/samanehsan","followers_url":"https://api.github.com/users/samanehsan/followers","following_url":"https://api.github.com/users/samanehsan/following{/other_user}","gists_url":"https://api.github.com/users/samanehsan/gists{/gist_id}","starred_url":"https://api.github.com/users/samanehsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanehsan/subscriptions","organizations_url":"https://api.github.com/users/samanehsan/orgs","repos_url":"https://api.github.com/users/samanehsan/repos","events_url":"https://api.github.com/users/samanehsan/events{/privacy}","received_events_url":"https://api.github.com/users/samanehsan/received_events","type":"User","site_admin":false},"body":"Continuation of https://github.com/CenterForOpenScience/osf.io/pull/2414","created_at":"2015-07-01T18:10:29Z","updated_at":"2015-07-02T16:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b205dde9595a5a4b0750bdc0319020c4ff47fab","assignee":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/40","html_url":"https://github.com/CenterForOpenScience/osf.io/milestones/0.42.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/40/labels","id":1175091,"number":40,"title":"0.42.0","description":"","creator":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":42,"state":"open","created_at":"2015-06-22T13:30:59Z","updated_at":"2015-07-01T19:23:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3409/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/c468dfe151e70d1688a3e7a2221dd9790281ce76","head":{"label":"samanehsan:feature/addon-user-settings","ref":"feature/addon-user-settings","sha":"c468dfe151e70d1688a3e7a2221dd9790281ce76","user":{"login":"samanehsan","id":6414394,"avatar_url":"https://avatars.githubusercontent.com/u/6414394?v=3","gravatar_id":"","url":"https://api.github.com/users/samanehsan","html_url":"https://github.com/samanehsan","followers_url":"https://api.github.com/users/samanehsan/followers","following_url":"https://api.github.com/users/samanehsan/following{/other_user}","gists_url":"https://api.github.com/users/samanehsan/gists{/gist_id}","starred_url":"https://api.github.com/users/samanehsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanehsan/subscriptions","organizations_url":"https://api.github.com/users/samanehsan/orgs","repos_url":"https://api.github.com/users/samanehsan/repos","events_url":"https://api.github.com/users/samanehsan/events{/privacy}","received_events_url":"https://api.github.com/users/samanehsan/received_events","type":"User","site_admin":false},"repo":{"id":26921095,"name":"osf.io","full_name":"samanehsan/osf.io","owner":{"login":"samanehsan","id":6414394,"avatar_url":"https://avatars.githubusercontent.com/u/6414394?v=3","gravatar_id":"","url":"https://api.github.com/users/samanehsan","html_url":"https://github.com/samanehsan","followers_url":"https://api.github.com/users/samanehsan/followers","following_url":"https://api.github.com/users/samanehsan/following{/other_user}","gists_url":"https://api.github.com/users/samanehsan/gists{/gist_id}","starred_url":"https://api.github.com/users/samanehsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samanehsan/subscriptions","organizations_url":"https://api.github.com/users/samanehsan/orgs","repos_url":"https://api.github.com/users/samanehsan/repos","events_url":"https://api.github.com/users/samanehsan/events{/privacy}","received_events_url":"https://api.github.com/users/samanehsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samanehsan/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/samanehsan/osf.io","forks_url":"https://api.github.com/repos/samanehsan/osf.io/forks","keys_url":"https://api.github.com/repos/samanehsan/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samanehsan/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samanehsan/osf.io/teams","hooks_url":"https://api.github.com/repos/samanehsan/osf.io/hooks","issue_events_url":"https://api.github.com/repos/samanehsan/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/samanehsan/osf.io/events","assignees_url":"https://api.github.com/repos/samanehsan/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/samanehsan/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/samanehsan/osf.io/tags","blobs_url":"https://api.github.com/repos/samanehsan/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samanehsan/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samanehsan/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/samanehsan/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samanehsan/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/samanehsan/osf.io/languages","stargazers_url":"https://api.github.com/repos/samanehsan/osf.io/stargazers","contributors_url":"https://api.github.com/repos/samanehsan/osf.io/contributors","subscribers_url":"https://api.github.com/repos/samanehsan/osf.io/subscribers","subscription_url":"https://api.github.com/repos/samanehsan/osf.io/subscription","commits_url":"https://api.github.com/repos/samanehsan/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/samanehsan/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/samanehsan/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/samanehsan/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/samanehsan/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/samanehsan/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samanehsan/osf.io/merges","archive_url":"https://api.github.com/repos/samanehsan/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samanehsan/osf.io/downloads","issues_url":"https://api.github.com/repos/samanehsan/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/samanehsan/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/samanehsan/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/samanehsan/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samanehsan/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/samanehsan/osf.io/releases{/id}","created_at":"2014-11-20T16:27:37Z","updated_at":"2015-06-24T13:47:24Z","pushed_at":"2015-07-02T14:49:38Z","git_url":"git://github.com/samanehsan/osf.io.git","ssh_url":"git@github.com:samanehsan/osf.io.git","clone_url":"https://github.com/samanehsan/osf.io.git","svn_url":"https://github.com/samanehsan/osf.io","homepage":"http://osf.io","size":98861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"a7aa9decfcaddbac4e32bd455566123e364fc284","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","created_at":"2013-05-21T15:53:37Z","updated_at":"2015-06-30T17:47:32Z","pushed_at":"2015-07-02T16:00:10Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":214167,"stargazers_count":119,"watchers_count":119,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":493,"forks":101,"open_issues":493,"watchers":119,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/3409"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3409"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3409/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3409/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/c468dfe151e70d1688a3e7a2221dd9790281ce76"}}}}