{"action":"closed","number":1793,"pull_request":{"url":"https://api.github.com/repos/mozilla-services/heka/pulls/1793","id":51181974,"html_url":"https://github.com/mozilla-services/heka/pull/1793","diff_url":"https://github.com/mozilla-services/heka/pull/1793.diff","patch_url":"https://github.com/mozilla-services/heka/pull/1793.patch","issue_url":"https://api.github.com/repos/mozilla-services/heka/issues/1793","number":1793,"state":"closed","locked":false,"title":"Bugfix/elasticsearch output","user":{"login":"tianchaijz","id":5765465,"avatar_url":"https://avatars.githubusercontent.com/u/5765465?v=3","gravatar_id":"","url":"https://api.github.com/users/tianchaijz","html_url":"https://github.com/tianchaijz","followers_url":"https://api.github.com/users/tianchaijz/followers","following_url":"https://api.github.com/users/tianchaijz/following{/other_user}","gists_url":"https://api.github.com/users/tianchaijz/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchaijz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchaijz/subscriptions","organizations_url":"https://api.github.com/users/tianchaijz/orgs","repos_url":"https://api.github.com/users/tianchaijz/repos","events_url":"https://api.github.com/users/tianchaijz/events{/privacy}","received_events_url":"https://api.github.com/users/tianchaijz/received_events","type":"User","site_admin":false},"body":"- Bugfix: The `ProcessMessage` function in the ES plugin is not synchronized (the `append` function is not thread safe) when goroutines running in parallel.\r\n- Bugfix: Should Drop empty batch instead of sending it to ES (ES will respond 400).\r\n- Enhancement: Only log error message when ES's resonpse code != 200.\r\n\r\n But I didn't find the source code that makes `ProcessMessage` function run in multiple goroutines?","created_at":"2015-11-19T05:30:28Z","updated_at":"2015-11-21T06:07:03Z","closed_at":"2015-11-21T06:07:03Z","merged_at":null,"merge_commit_sha":"e7c8db7cb25fc603629b31b1be077abd965c3370","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/heka/pulls/1793/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/heka/pulls/1793/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/heka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/heka/issues/1793/comments","statuses_url":"https://api.github.com/repos/mozilla-services/heka/statuses/ecdec6ea38200ca323767b7bb14d1ee333019550","head":{"label":"tianchaijz:bugfix/elasticsearch_output","ref":"bugfix/elasticsearch_output","sha":"ecdec6ea38200ca323767b7bb14d1ee333019550","user":{"login":"tianchaijz","id":5765465,"avatar_url":"https://avatars.githubusercontent.com/u/5765465?v=3","gravatar_id":"","url":"https://api.github.com/users/tianchaijz","html_url":"https://github.com/tianchaijz","followers_url":"https://api.github.com/users/tianchaijz/followers","following_url":"https://api.github.com/users/tianchaijz/following{/other_user}","gists_url":"https://api.github.com/users/tianchaijz/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchaijz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchaijz/subscriptions","organizations_url":"https://api.github.com/users/tianchaijz/orgs","repos_url":"https://api.github.com/users/tianchaijz/repos","events_url":"https://api.github.com/users/tianchaijz/events{/privacy}","received_events_url":"https://api.github.com/users/tianchaijz/received_events","type":"User","site_admin":false},"repo":{"id":44947721,"name":"heka","full_name":"tianchaijz/heka","owner":{"login":"tianchaijz","id":5765465,"avatar_url":"https://avatars.githubusercontent.com/u/5765465?v=3","gravatar_id":"","url":"https://api.github.com/users/tianchaijz","html_url":"https://github.com/tianchaijz","followers_url":"https://api.github.com/users/tianchaijz/followers","following_url":"https://api.github.com/users/tianchaijz/following{/other_user}","gists_url":"https://api.github.com/users/tianchaijz/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchaijz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchaijz/subscriptions","organizations_url":"https://api.github.com/users/tianchaijz/orgs","repos_url":"https://api.github.com/users/tianchaijz/repos","events_url":"https://api.github.com/users/tianchaijz/events{/privacy}","received_events_url":"https://api.github.com/users/tianchaijz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tianchaijz/heka","description":"Data collection and processing made easy.","fork":true,"url":"https://api.github.com/repos/tianchaijz/heka","forks_url":"https://api.github.com/repos/tianchaijz/heka/forks","keys_url":"https://api.github.com/repos/tianchaijz/heka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tianchaijz/heka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tianchaijz/heka/teams","hooks_url":"https://api.github.com/repos/tianchaijz/heka/hooks","issue_events_url":"https://api.github.com/repos/tianchaijz/heka/issues/events{/number}","events_url":"https://api.github.com/repos/tianchaijz/heka/events","assignees_url":"https://api.github.com/repos/tianchaijz/heka/assignees{/user}","branches_url":"https://api.github.com/repos/tianchaijz/heka/branches{/branch}","tags_url":"https://api.github.com/repos/tianchaijz/heka/tags","blobs_url":"https://api.github.com/repos/tianchaijz/heka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tianchaijz/heka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tianchaijz/heka/git/refs{/sha}","trees_url":"https://api.github.com/repos/tianchaijz/heka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tianchaijz/heka/statuses/{sha}","languages_url":"https://api.github.com/repos/tianchaijz/heka/languages","stargazers_url":"https://api.github.com/repos/tianchaijz/heka/stargazers","contributors_url":"https://api.github.com/repos/tianchaijz/heka/contributors","subscribers_url":"https://api.github.com/repos/tianchaijz/heka/subscribers","subscription_url":"https://api.github.com/repos/tianchaijz/heka/subscription","commits_url":"https://api.github.com/repos/tianchaijz/heka/commits{/sha}","git_commits_url":"https://api.github.com/repos/tianchaijz/heka/git/commits{/sha}","comments_url":"https://api.github.com/repos/tianchaijz/heka/comments{/number}","issue_comment_url":"https://api.github.com/repos/tianchaijz/heka/issues/comments{/number}","contents_url":"https://api.github.com/repos/tianchaijz/heka/contents/{+path}","compare_url":"https://api.github.com/repos/tianchaijz/heka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tianchaijz/heka/merges","archive_url":"https://api.github.com/repos/tianchaijz/heka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tianchaijz/heka/downloads","issues_url":"https://api.github.com/repos/tianchaijz/heka/issues{/number}","pulls_url":"https://api.github.com/repos/tianchaijz/heka/pulls{/number}","milestones_url":"https://api.github.com/repos/tianchaijz/heka/milestones{/number}","notifications_url":"https://api.github.com/repos/tianchaijz/heka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tianchaijz/heka/labels{/name}","releases_url":"https://api.github.com/repos/tianchaijz/heka/releases{/id}","created_at":"2015-10-26T05:22:13Z","updated_at":"2015-10-26T05:22:16Z","pushed_at":"2015-11-20T08:59:31Z","git_url":"git://github.com/tianchaijz/heka.git","ssh_url":"git@github.com:tianchaijz/heka.git","clone_url":"https://github.com/tianchaijz/heka.git","svn_url":"https://github.com/tianchaijz/heka","homepage":"http://hekad.readthedocs.org/","size":11376,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"debug"}},"base":{"label":"mozilla-services:dev","ref":"dev","sha":"b52991cb01b130256fb9bad2865f53c494e55db9","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":6248212,"name":"heka","full_name":"mozilla-services/heka","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/heka","description":"Data collection and processing made easy.","fork":false,"url":"https://api.github.com/repos/mozilla-services/heka","forks_url":"https://api.github.com/repos/mozilla-services/heka/forks","keys_url":"https://api.github.com/repos/mozilla-services/heka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/heka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/heka/teams","hooks_url":"https://api.github.com/repos/mozilla-services/heka/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/heka/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/heka/events","assignees_url":"https://api.github.com/repos/mozilla-services/heka/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/heka/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/heka/tags","blobs_url":"https://api.github.com/repos/mozilla-services/heka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/heka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/heka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/heka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/heka/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/heka/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/heka/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/heka/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/heka/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/heka/subscription","commits_url":"https://api.github.com/repos/mozilla-services/heka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/heka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/heka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/heka/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/heka/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/heka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/heka/merges","archive_url":"https://api.github.com/repos/mozilla-services/heka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/heka/downloads","issues_url":"https://api.github.com/repos/mozilla-services/heka/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/heka/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/heka/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/heka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/heka/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/heka/releases{/id}","created_at":"2012-10-16T17:20:51Z","updated_at":"2015-11-20T22:46:33Z","pushed_at":"2015-11-21T06:06:04Z","git_url":"git://github.com/mozilla-services/heka.git","ssh_url":"git@github.com:mozilla-services/heka.git","clone_url":"https://github.com/mozilla-services/heka.git","svn_url":"https://github.com/mozilla-services/heka","homepage":"http://hekad.readthedocs.org/","size":12118,"stargazers_count":2696,"watchers_count":2696,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":180,"forks":390,"open_issues":180,"watchers":2696,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/1793"},"html":{"href":"https://github.com/mozilla-services/heka/pull/1793"},"issue":{"href":"https://api.github.com/repos/mozilla-services/heka/issues/1793"},"comments":{"href":"https://api.github.com/repos/mozilla-services/heka/issues/1793/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/1793/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/1793/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/heka/statuses/ecdec6ea38200ca323767b7bb14d1ee333019550"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":21,"deletions":13,"changed_files":1}}