{"action":"closed","number":350,"pull_request":{"url":"https://api.github.com/repos/crossbario/crossbar/pulls/350","id":37088962,"html_url":"https://github.com/crossbario/crossbar/pull/350","diff_url":"https://github.com/crossbario/crossbar/pull/350.diff","patch_url":"https://github.com/crossbario/crossbar/pull/350.patch","issue_url":"https://api.github.com/repos/crossbario/crossbar/issues/350","number":350,"state":"closed","locked":false,"title":"fix for fileupload","user":{"login":"markope","id":1944925,"avatar_url":"https://avatars.githubusercontent.com/u/1944925?v=3","gravatar_id":"","url":"https://api.github.com/users/markope","html_url":"https://github.com/markope","followers_url":"https://api.github.com/users/markope/followers","following_url":"https://api.github.com/users/markope/following{/other_user}","gists_url":"https://api.github.com/users/markope/gists{/gist_id}","starred_url":"https://api.github.com/users/markope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markope/subscriptions","organizations_url":"https://api.github.com/users/markope/orgs","repos_url":"https://api.github.com/users/markope/repos","events_url":"https://api.github.com/users/markope/events{/privacy}","received_events_url":"https://api.github.com/users/markope/received_events","type":"User","site_admin":false},"body":"fix for write after last chunk\r\noptional temp folder with auto clean\r\n\r\nRegarding the file_id as hash I would still propose to not autocompute a sha256 hash or something. The normal id in a folder is the filename. In fact I would remove the file_id altogether and only have the file_name set by the client. If the client whiches a hash it is up to him.\r\nI see no security issue with this.\r\nIf you agree I would remove the file_id option.","created_at":"2015-06-06T11:09:22Z","updated_at":"2015-06-07T10:01:21Z","closed_at":"2015-06-07T10:01:21Z","merged_at":"2015-06-07T10:01:21Z","merge_commit_sha":"c7c695422136df1673a444bd83e8eb1c70f30934","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crossbario/crossbar/pulls/350/commits","review_comments_url":"https://api.github.com/repos/crossbario/crossbar/pulls/350/comments","review_comment_url":"https://api.github.com/repos/crossbario/crossbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossbario/crossbar/issues/350/comments","statuses_url":"https://api.github.com/repos/crossbario/crossbar/statuses/eb31c0d2fb0e9665cb722c15ab2f271764163278","head":{"label":"markope:master","ref":"master","sha":"eb31c0d2fb0e9665cb722c15ab2f271764163278","user":{"login":"markope","id":1944925,"avatar_url":"https://avatars.githubusercontent.com/u/1944925?v=3","gravatar_id":"","url":"https://api.github.com/users/markope","html_url":"https://github.com/markope","followers_url":"https://api.github.com/users/markope/followers","following_url":"https://api.github.com/users/markope/following{/other_user}","gists_url":"https://api.github.com/users/markope/gists{/gist_id}","starred_url":"https://api.github.com/users/markope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markope/subscriptions","organizations_url":"https://api.github.com/users/markope/orgs","repos_url":"https://api.github.com/users/markope/repos","events_url":"https://api.github.com/users/markope/events{/privacy}","received_events_url":"https://api.github.com/users/markope/received_events","type":"User","site_admin":false},"repo":{"id":14275097,"name":"crossbar","full_name":"markope/crossbar","owner":{"login":"markope","id":1944925,"avatar_url":"https://avatars.githubusercontent.com/u/1944925?v=3","gravatar_id":"","url":"https://api.github.com/users/markope","html_url":"https://github.com/markope","followers_url":"https://api.github.com/users/markope/followers","following_url":"https://api.github.com/users/markope/following{/other_user}","gists_url":"https://api.github.com/users/markope/gists{/gist_id}","starred_url":"https://api.github.com/users/markope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markope/subscriptions","organizations_url":"https://api.github.com/users/markope/orgs","repos_url":"https://api.github.com/users/markope/repos","events_url":"https://api.github.com/users/markope/events{/privacy}","received_events_url":"https://api.github.com/users/markope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markope/crossbar","description":"Multi-protocol application router","fork":true,"url":"https://api.github.com/repos/markope/crossbar","forks_url":"https://api.github.com/repos/markope/crossbar/forks","keys_url":"https://api.github.com/repos/markope/crossbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markope/crossbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markope/crossbar/teams","hooks_url":"https://api.github.com/repos/markope/crossbar/hooks","issue_events_url":"https://api.github.com/repos/markope/crossbar/issues/events{/number}","events_url":"https://api.github.com/repos/markope/crossbar/events","assignees_url":"https://api.github.com/repos/markope/crossbar/assignees{/user}","branches_url":"https://api.github.com/repos/markope/crossbar/branches{/branch}","tags_url":"https://api.github.com/repos/markope/crossbar/tags","blobs_url":"https://api.github.com/repos/markope/crossbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markope/crossbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markope/crossbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/markope/crossbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markope/crossbar/statuses/{sha}","languages_url":"https://api.github.com/repos/markope/crossbar/languages","stargazers_url":"https://api.github.com/repos/markope/crossbar/stargazers","contributors_url":"https://api.github.com/repos/markope/crossbar/contributors","subscribers_url":"https://api.github.com/repos/markope/crossbar/subscribers","subscription_url":"https://api.github.com/repos/markope/crossbar/subscription","commits_url":"https://api.github.com/repos/markope/crossbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/markope/crossbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/markope/crossbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/markope/crossbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/markope/crossbar/contents/{+path}","compare_url":"https://api.github.com/repos/markope/crossbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markope/crossbar/merges","archive_url":"https://api.github.com/repos/markope/crossbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markope/crossbar/downloads","issues_url":"https://api.github.com/repos/markope/crossbar/issues{/number}","pulls_url":"https://api.github.com/repos/markope/crossbar/pulls{/number}","milestones_url":"https://api.github.com/repos/markope/crossbar/milestones{/number}","notifications_url":"https://api.github.com/repos/markope/crossbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markope/crossbar/labels{/name}","releases_url":"https://api.github.com/repos/markope/crossbar/releases{/id}","created_at":"2013-11-10T11:17:30Z","updated_at":"2014-12-04T21:06:15Z","pushed_at":"2015-06-06T13:31:52Z","git_url":"git://github.com/markope/crossbar.git","ssh_url":"git@github.com:markope/crossbar.git","clone_url":"https://github.com/markope/crossbar.git","svn_url":"https://github.com/markope/crossbar","homepage":null,"size":10166,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crossbario:master","ref":"master","sha":"8cb6968527baf55b1d609ebfc2b28f8abad2f475","user":{"login":"crossbario","id":5656948,"avatar_url":"https://avatars.githubusercontent.com/u/5656948?v=3","gravatar_id":"","url":"https://api.github.com/users/crossbario","html_url":"https://github.com/crossbario","followers_url":"https://api.github.com/users/crossbario/followers","following_url":"https://api.github.com/users/crossbario/following{/other_user}","gists_url":"https://api.github.com/users/crossbario/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbario/subscriptions","organizations_url":"https://api.github.com/users/crossbario/orgs","repos_url":"https://api.github.com/users/crossbario/repos","events_url":"https://api.github.com/users/crossbario/events{/privacy}","received_events_url":"https://api.github.com/users/crossbario/received_events","type":"Organization","site_admin":false},"repo":{"id":13559106,"name":"crossbar","full_name":"crossbario/crossbar","owner":{"login":"crossbario","id":5656948,"avatar_url":"https://avatars.githubusercontent.com/u/5656948?v=3","gravatar_id":"","url":"https://api.github.com/users/crossbario","html_url":"https://github.com/crossbario","followers_url":"https://api.github.com/users/crossbario/followers","following_url":"https://api.github.com/users/crossbario/following{/other_user}","gists_url":"https://api.github.com/users/crossbario/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbario/subscriptions","organizations_url":"https://api.github.com/users/crossbario/orgs","repos_url":"https://api.github.com/users/crossbario/repos","events_url":"https://api.github.com/users/crossbario/events{/privacy}","received_events_url":"https://api.github.com/users/crossbario/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crossbario/crossbar","description":"Crossbar.io - WAMP application router","fork":false,"url":"https://api.github.com/repos/crossbario/crossbar","forks_url":"https://api.github.com/repos/crossbario/crossbar/forks","keys_url":"https://api.github.com/repos/crossbario/crossbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossbario/crossbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossbario/crossbar/teams","hooks_url":"https://api.github.com/repos/crossbario/crossbar/hooks","issue_events_url":"https://api.github.com/repos/crossbario/crossbar/issues/events{/number}","events_url":"https://api.github.com/repos/crossbario/crossbar/events","assignees_url":"https://api.github.com/repos/crossbario/crossbar/assignees{/user}","branches_url":"https://api.github.com/repos/crossbario/crossbar/branches{/branch}","tags_url":"https://api.github.com/repos/crossbario/crossbar/tags","blobs_url":"https://api.github.com/repos/crossbario/crossbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossbario/crossbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossbario/crossbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossbario/crossbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossbario/crossbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crossbario/crossbar/languages","stargazers_url":"https://api.github.com/repos/crossbario/crossbar/stargazers","contributors_url":"https://api.github.com/repos/crossbario/crossbar/contributors","subscribers_url":"https://api.github.com/repos/crossbario/crossbar/subscribers","subscription_url":"https://api.github.com/repos/crossbario/crossbar/subscription","commits_url":"https://api.github.com/repos/crossbario/crossbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossbario/crossbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossbario/crossbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossbario/crossbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossbario/crossbar/contents/{+path}","compare_url":"https://api.github.com/repos/crossbario/crossbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossbario/crossbar/merges","archive_url":"https://api.github.com/repos/crossbario/crossbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossbario/crossbar/downloads","issues_url":"https://api.github.com/repos/crossbario/crossbar/issues{/number}","pulls_url":"https://api.github.com/repos/crossbario/crossbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crossbario/crossbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crossbario/crossbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossbario/crossbar/labels{/name}","releases_url":"https://api.github.com/repos/crossbario/crossbar/releases{/id}","created_at":"2013-10-14T11:10:50Z","updated_at":"2015-06-07T08:47:20Z","pushed_at":"2015-06-07T10:01:21Z","git_url":"git://github.com/crossbario/crossbar.git","ssh_url":"git@github.com:crossbario/crossbar.git","clone_url":"https://github.com/crossbario/crossbar.git","svn_url":"https://github.com/crossbario/crossbar","homepage":"http://crossbar.io/","size":21484,"stargazers_count":563,"watchers_count":563,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":106,"forks":67,"open_issues":106,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossbario/crossbar/pulls/350"},"html":{"href":"https://github.com/crossbario/crossbar/pull/350"},"issue":{"href":"https://api.github.com/repos/crossbario/crossbar/issues/350"},"comments":{"href":"https://api.github.com/repos/crossbario/crossbar/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/crossbario/crossbar/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/crossbario/crossbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossbario/crossbar/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/crossbario/crossbar/statuses/eb31c0d2fb0e9665cb722c15ab2f271764163278"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oberstet","id":233340,"avatar_url":"https://avatars.githubusercontent.com/u/233340?v=3","gravatar_id":"","url":"https://api.github.com/users/oberstet","html_url":"https://github.com/oberstet","followers_url":"https://api.github.com/users/oberstet/followers","following_url":"https://api.github.com/users/oberstet/following{/other_user}","gists_url":"https://api.github.com/users/oberstet/gists{/gist_id}","starred_url":"https://api.github.com/users/oberstet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberstet/subscriptions","organizations_url":"https://api.github.com/users/oberstet/orgs","repos_url":"https://api.github.com/users/oberstet/repos","events_url":"https://api.github.com/users/oberstet/events{/privacy}","received_events_url":"https://api.github.com/users/oberstet/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":82,"deletions":50,"changed_files":2}}