{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/23497729","id":23497729,"diff_hunk":"@@ -37,6 +37,46 @@ function plain(io::IO, list::List)\n     end\n end\n \n+function plain(io::IO, md::Table)\n+    col_widths = reduce(max, map(cell -> map(ansi_length, cell), md.rows))","path":"base/markdown/render/plain.jl","position":5,"original_position":5,"commit_id":"9607fc2b23cad8ecab0906ad43deeb96896c1db4","original_commit_id":"9607fc2b23cad8ecab0906ad43deeb96896c1db4","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"body":"So the issue here is that length is the length of the array of components rather than the total length of the strings. I could define length too for these - I didn't know the purpose of plain tbh (is it a neat/aligned representation of the tables or just one that is valid markdown - that can be parsed back)?","created_at":"2015-01-24T17:21:32Z","updated_at":"2015-01-24T17:21:32Z","html_url":"https://github.com/JuliaLang/julia/pull/9878#discussion_r23497729","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9878","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/23497729"},"html":{"href":"https://github.com/JuliaLang/julia/pull/9878#discussion_r23497729"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9878"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/9878","id":27826963,"html_url":"https://github.com/JuliaLang/julia/pull/9878","diff_url":"https://github.com/JuliaLang/julia/pull/9878.diff","patch_url":"https://github.com/JuliaLang/julia/pull/9878.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/9878","number":9878,"state":"open","locked":false,"title":"RFC add markdown Table","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"body":"This parses and displays tables in Markdown with [GH syntax](https://help.github.com/articles/github-flavored-markdown#tables), in the terminal and html. *I haven't tested the latex version and the plain is not yet finished.*\r\n\r\nAs discussed in other documentation issues, tables are useful to have...\r\n\r\ncc @one-more-minute, fixes https://github.com/one-more-minute/Markdown.jl/issues/16.\r\n\r\nNo doubt there are a few things I'm not doing correctly here, so comments would be great.\r\n\r\n---\r\n\r\nNote: There aren't any markdown tests at all...","created_at":"2015-01-22T09:01:53Z","updated_at":"2015-01-24T17:21:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b711362b3dd14c50fab06ce62608e2ee807dee33","assignee":{"login":"one-more-minute","id":2234614,"avatar_url":"https://avatars.githubusercontent.com/u/2234614?v=3","gravatar_id":"","url":"https://api.github.com/users/one-more-minute","html_url":"https://github.com/one-more-minute","followers_url":"https://api.github.com/users/one-more-minute/followers","following_url":"https://api.github.com/users/one-more-minute/following{/other_user}","gists_url":"https://api.github.com/users/one-more-minute/gists{/gist_id}","starred_url":"https://api.github.com/users/one-more-minute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/one-more-minute/subscriptions","organizations_url":"https://api.github.com/users/one-more-minute/orgs","repos_url":"https://api.github.com/users/one-more-minute/repos","events_url":"https://api.github.com/users/one-more-minute/events{/privacy}","received_events_url":"https://api.github.com/users/one-more-minute/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9878/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9878/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/9878/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/9607fc2b23cad8ecab0906ad43deeb96896c1db4","head":{"label":"hayd:markdown_table","ref":"markdown_table","sha":"9607fc2b23cad8ecab0906ad43deeb96896c1db4","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"repo":{"id":14515015,"name":"julia","full_name":"hayd/julia","owner":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hayd/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/hayd/julia","forks_url":"https://api.github.com/repos/hayd/julia/forks","keys_url":"https://api.github.com/repos/hayd/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hayd/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hayd/julia/teams","hooks_url":"https://api.github.com/repos/hayd/julia/hooks","issue_events_url":"https://api.github.com/repos/hayd/julia/issues/events{/number}","events_url":"https://api.github.com/repos/hayd/julia/events","assignees_url":"https://api.github.com/repos/hayd/julia/assignees{/user}","branches_url":"https://api.github.com/repos/hayd/julia/branches{/branch}","tags_url":"https://api.github.com/repos/hayd/julia/tags","blobs_url":"https://api.github.com/repos/hayd/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hayd/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hayd/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/hayd/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hayd/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/hayd/julia/languages","stargazers_url":"https://api.github.com/repos/hayd/julia/stargazers","contributors_url":"https://api.github.com/repos/hayd/julia/contributors","subscribers_url":"https://api.github.com/repos/hayd/julia/subscribers","subscription_url":"https://api.github.com/repos/hayd/julia/subscription","commits_url":"https://api.github.com/repos/hayd/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/hayd/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/hayd/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/hayd/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/hayd/julia/contents/{+path}","compare_url":"https://api.github.com/repos/hayd/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hayd/julia/merges","archive_url":"https://api.github.com/repos/hayd/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hayd/julia/downloads","issues_url":"https://api.github.com/repos/hayd/julia/issues{/number}","pulls_url":"https://api.github.com/repos/hayd/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/hayd/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/hayd/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hayd/julia/labels{/name}","releases_url":"https://api.github.com/repos/hayd/julia/releases{/id}","created_at":"2013-11-19T05:18:39Z","updated_at":"2015-01-22T23:29:45Z","pushed_at":"2015-01-24T17:09:51Z","git_url":"git://github.com/hayd/julia.git","ssh_url":"git@github.com:hayd/julia.git","clone_url":"https://github.com/hayd/julia.git","svn_url":"https://github.com/hayd/julia","homepage":"http://julialang.org/","size":54913,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"180a6c5e57f0d03fdce044b9374c3edb8b00f4d6","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-01-24T14:58:47Z","pushed_at":"2015-01-24T14:58:46Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":156107,"stargazers_count":4991,"watchers_count":4991,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1041,"mirror_url":null,"open_issues_count":1127,"forks":1041,"open_issues":1127,"watchers":4991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9878"},"html":{"href":"https://github.com/JuliaLang/julia/pull/9878"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/9878"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/9878/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9878/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9878/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/9607fc2b23cad8ecab0906ad43deeb96896c1db4"}}}}