{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/canoo/open-dolphin/pulls/24","id":53828486,"html_url":"https://github.com/canoo/open-dolphin/pull/24","diff_url":"https://github.com/canoo/open-dolphin/pull/24.diff","patch_url":"https://github.com/canoo/open-dolphin/pull/24.patch","issue_url":"https://api.github.com/repos/canoo/open-dolphin/issues/24","number":24,"state":"closed","locked":false,"title":"specify type for ServerConnector and movement to combined","user":{"login":"blackdrag","id":470278,"avatar_url":"https://avatars.githubusercontent.com/u/470278?v=3","gravatar_id":"","url":"https://api.github.com/users/blackdrag","html_url":"https://github.com/blackdrag","followers_url":"https://api.github.com/users/blackdrag/followers","following_url":"https://api.github.com/users/blackdrag/following{/other_user}","gists_url":"https://api.github.com/users/blackdrag/gists{/gist_id}","starred_url":"https://api.github.com/users/blackdrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackdrag/subscriptions","organizations_url":"https://api.github.com/users/blackdrag/orgs","repos_url":"https://api.github.com/users/blackdrag/repos","events_url":"https://api.github.com/users/blackdrag/events{/privacy}","received_events_url":"https://api.github.com/users/blackdrag/received_events","type":"User","site_admin":false},"body":"this types the server connector in InMemoryClientConnector as ServerConnector as well as making it a final property one has to give in through the constructor. Due to this change several classes have to move to \"combined\" as they now reference a server class from the client side. Before this was hidden through the usage of Object. Since this will move files this PR is of course to be seen a bit more critical","created_at":"2015-12-16T11:20:57Z","updated_at":"2015-12-18T16:05:23Z","closed_at":"2015-12-18T16:05:23Z","merged_at":"2015-12-18T16:05:23Z","merge_commit_sha":"e99a8de597e936e672b987e72b3145666011795b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/canoo/open-dolphin/pulls/24/commits","review_comments_url":"https://api.github.com/repos/canoo/open-dolphin/pulls/24/comments","review_comment_url":"https://api.github.com/repos/canoo/open-dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canoo/open-dolphin/issues/24/comments","statuses_url":"https://api.github.com/repos/canoo/open-dolphin/statuses/d983afb82ce1615f79a5ce343a54bad67ace3704","head":{"label":"blackdrag:move_connector_to_combined","ref":"move_connector_to_combined","sha":"d983afb82ce1615f79a5ce343a54bad67ace3704","user":{"login":"blackdrag","id":470278,"avatar_url":"https://avatars.githubusercontent.com/u/470278?v=3","gravatar_id":"","url":"https://api.github.com/users/blackdrag","html_url":"https://github.com/blackdrag","followers_url":"https://api.github.com/users/blackdrag/followers","following_url":"https://api.github.com/users/blackdrag/following{/other_user}","gists_url":"https://api.github.com/users/blackdrag/gists{/gist_id}","starred_url":"https://api.github.com/users/blackdrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackdrag/subscriptions","organizations_url":"https://api.github.com/users/blackdrag/orgs","repos_url":"https://api.github.com/users/blackdrag/repos","events_url":"https://api.github.com/users/blackdrag/events{/privacy}","received_events_url":"https://api.github.com/users/blackdrag/received_events","type":"User","site_admin":false},"repo":{"id":48105547,"name":"open-dolphin","full_name":"blackdrag/open-dolphin","owner":{"login":"blackdrag","id":470278,"avatar_url":"https://avatars.githubusercontent.com/u/470278?v=3","gravatar_id":"","url":"https://api.github.com/users/blackdrag","html_url":"https://github.com/blackdrag","followers_url":"https://api.github.com/users/blackdrag/followers","following_url":"https://api.github.com/users/blackdrag/following{/other_user}","gists_url":"https://api.github.com/users/blackdrag/gists{/gist_id}","starred_url":"https://api.github.com/users/blackdrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackdrag/subscriptions","organizations_url":"https://api.github.com/users/blackdrag/orgs","repos_url":"https://api.github.com/users/blackdrag/repos","events_url":"https://api.github.com/users/blackdrag/events{/privacy}","received_events_url":"https://api.github.com/users/blackdrag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blackdrag/open-dolphin","description":"Reference implementation for the OpenDolphin architecture","fork":true,"url":"https://api.github.com/repos/blackdrag/open-dolphin","forks_url":"https://api.github.com/repos/blackdrag/open-dolphin/forks","keys_url":"https://api.github.com/repos/blackdrag/open-dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackdrag/open-dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackdrag/open-dolphin/teams","hooks_url":"https://api.github.com/repos/blackdrag/open-dolphin/hooks","issue_events_url":"https://api.github.com/repos/blackdrag/open-dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/blackdrag/open-dolphin/events","assignees_url":"https://api.github.com/repos/blackdrag/open-dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/blackdrag/open-dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/blackdrag/open-dolphin/tags","blobs_url":"https://api.github.com/repos/blackdrag/open-dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackdrag/open-dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackdrag/open-dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackdrag/open-dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackdrag/open-dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/blackdrag/open-dolphin/languages","stargazers_url":"https://api.github.com/repos/blackdrag/open-dolphin/stargazers","contributors_url":"https://api.github.com/repos/blackdrag/open-dolphin/contributors","subscribers_url":"https://api.github.com/repos/blackdrag/open-dolphin/subscribers","subscription_url":"https://api.github.com/repos/blackdrag/open-dolphin/subscription","commits_url":"https://api.github.com/repos/blackdrag/open-dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackdrag/open-dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackdrag/open-dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackdrag/open-dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/blackdrag/open-dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/blackdrag/open-dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackdrag/open-dolphin/merges","archive_url":"https://api.github.com/repos/blackdrag/open-dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackdrag/open-dolphin/downloads","issues_url":"https://api.github.com/repos/blackdrag/open-dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/blackdrag/open-dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/blackdrag/open-dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/blackdrag/open-dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackdrag/open-dolphin/labels{/name}","releases_url":"https://api.github.com/repos/blackdrag/open-dolphin/releases{/id}","created_at":"2015-12-16T11:07:59Z","updated_at":"2015-12-16T11:08:01Z","pushed_at":"2015-12-16T11:17:50Z","git_url":"git://github.com/blackdrag/open-dolphin.git","ssh_url":"git@github.com:blackdrag/open-dolphin.git","clone_url":"https://github.com/blackdrag/open-dolphin.git","svn_url":"https://github.com/blackdrag/open-dolphin","homepage":"http://open-dolphin.org","size":13048,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canoo:master","ref":"master","sha":"fb8f1a4172265c3251e12efc49a52abec309580b","user":{"login":"canoo","id":373257,"avatar_url":"https://avatars.githubusercontent.com/u/373257?v=3","gravatar_id":"","url":"https://api.github.com/users/canoo","html_url":"https://github.com/canoo","followers_url":"https://api.github.com/users/canoo/followers","following_url":"https://api.github.com/users/canoo/following{/other_user}","gists_url":"https://api.github.com/users/canoo/gists{/gist_id}","starred_url":"https://api.github.com/users/canoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canoo/subscriptions","organizations_url":"https://api.github.com/users/canoo/orgs","repos_url":"https://api.github.com/users/canoo/repos","events_url":"https://api.github.com/users/canoo/events{/privacy}","received_events_url":"https://api.github.com/users/canoo/received_events","type":"Organization","site_admin":false},"repo":{"id":5746411,"name":"open-dolphin","full_name":"canoo/open-dolphin","owner":{"login":"canoo","id":373257,"avatar_url":"https://avatars.githubusercontent.com/u/373257?v=3","gravatar_id":"","url":"https://api.github.com/users/canoo","html_url":"https://github.com/canoo","followers_url":"https://api.github.com/users/canoo/followers","following_url":"https://api.github.com/users/canoo/following{/other_user}","gists_url":"https://api.github.com/users/canoo/gists{/gist_id}","starred_url":"https://api.github.com/users/canoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canoo/subscriptions","organizations_url":"https://api.github.com/users/canoo/orgs","repos_url":"https://api.github.com/users/canoo/repos","events_url":"https://api.github.com/users/canoo/events{/privacy}","received_events_url":"https://api.github.com/users/canoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canoo/open-dolphin","description":"Reference implementation for the OpenDolphin architecture","fork":false,"url":"https://api.github.com/repos/canoo/open-dolphin","forks_url":"https://api.github.com/repos/canoo/open-dolphin/forks","keys_url":"https://api.github.com/repos/canoo/open-dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canoo/open-dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canoo/open-dolphin/teams","hooks_url":"https://api.github.com/repos/canoo/open-dolphin/hooks","issue_events_url":"https://api.github.com/repos/canoo/open-dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/canoo/open-dolphin/events","assignees_url":"https://api.github.com/repos/canoo/open-dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/canoo/open-dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/canoo/open-dolphin/tags","blobs_url":"https://api.github.com/repos/canoo/open-dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canoo/open-dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canoo/open-dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/canoo/open-dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canoo/open-dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/canoo/open-dolphin/languages","stargazers_url":"https://api.github.com/repos/canoo/open-dolphin/stargazers","contributors_url":"https://api.github.com/repos/canoo/open-dolphin/contributors","subscribers_url":"https://api.github.com/repos/canoo/open-dolphin/subscribers","subscription_url":"https://api.github.com/repos/canoo/open-dolphin/subscription","commits_url":"https://api.github.com/repos/canoo/open-dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/canoo/open-dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/canoo/open-dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/canoo/open-dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/canoo/open-dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/canoo/open-dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canoo/open-dolphin/merges","archive_url":"https://api.github.com/repos/canoo/open-dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canoo/open-dolphin/downloads","issues_url":"https://api.github.com/repos/canoo/open-dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/canoo/open-dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/canoo/open-dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/canoo/open-dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canoo/open-dolphin/labels{/name}","releases_url":"https://api.github.com/repos/canoo/open-dolphin/releases{/id}","created_at":"2012-09-10T07:50:26Z","updated_at":"2015-10-22T09:37:51Z","pushed_at":"2015-12-18T16:05:23Z","git_url":"git://github.com/canoo/open-dolphin.git","ssh_url":"git@github.com:canoo/open-dolphin.git","clone_url":"https://github.com/canoo/open-dolphin.git","svn_url":"https://github.com/canoo/open-dolphin","homepage":"http://open-dolphin.org","size":14245,"stargazers_count":70,"watchers_count":70,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":14,"forks":23,"open_issues":14,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canoo/open-dolphin/pulls/24"},"html":{"href":"https://github.com/canoo/open-dolphin/pull/24"},"issue":{"href":"https://api.github.com/repos/canoo/open-dolphin/issues/24"},"comments":{"href":"https://api.github.com/repos/canoo/open-dolphin/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/canoo/open-dolphin/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/canoo/open-dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canoo/open-dolphin/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/canoo/open-dolphin/statuses/d983afb82ce1615f79a5ce343a54bad67ace3704"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Dierk","id":51843,"avatar_url":"https://avatars.githubusercontent.com/u/51843?v=3","gravatar_id":"","url":"https://api.github.com/users/Dierk","html_url":"https://github.com/Dierk","followers_url":"https://api.github.com/users/Dierk/followers","following_url":"https://api.github.com/users/Dierk/following{/other_user}","gists_url":"https://api.github.com/users/Dierk/gists{/gist_id}","starred_url":"https://api.github.com/users/Dierk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dierk/subscriptions","organizations_url":"https://api.github.com/users/Dierk/orgs","repos_url":"https://api.github.com/users/Dierk/repos","events_url":"https://api.github.com/users/Dierk/events{/privacy}","received_events_url":"https://api.github.com/users/Dierk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":56,"deletions":54,"changed_files":10}}