{"push_id":646881333,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"e349283d4a7b13a95d20925b5fe2e52eceee565c","before":"f5b1602ed4a36f6de6da316fd8023a2c83924725","commits":[{"sha":"843f806a737c85e44dc92d25753ebba99a6ba82d","author":{"email":"b2b1112b87aa1fd0f8d63cdedd57e377fdf3e659@codevise.de","name":"Tim Fischbach"},"message":"Fix XPath Matchers in Cucumber Asset Steps\n\nThe step definitions looking for assets in the page head produced\nfalse positives since quotes were missing inside the XPath\nexpressions.\n\nXPath expressions of the form `\"contains(@href, #{path})\"` matched no\nmatter what `path` was supplied. In one case even the string\ninterpolation was missing: `\"contains(@href, path)\"`. Surrounding the\nliterals with single quotes caused actual checks to be performed and\nrevealed outdated information inside the tests:\n\n* The generated assets paths actually start with `assets/` in some\n  Rails versions instead of `javascripts/` and `stylesheets/`. Remove\n  the prefix to make tests pass.\n\n* The `active_admin.css` does not live inside an `admin` directory.\n\n* `registering_assets.features` asserted presence of a file called\n  `active_admin_vendor.js` not mentioned elsewhere in the codebase","distinct":true,"url":"https://api.github.com/repos/activeadmin/activeadmin/commits/843f806a737c85e44dc92d25753ebba99a6ba82d"},{"sha":"e349283d4a7b13a95d20925b5fe2e52eceee565c","author":{"email":"98c2d5a1e48c998bd9ba9dbc53d6857beae1c9bd@schilling.io","name":"Timo Schilling"},"message":"Merge pull request #3917 from tf/cucumber-asset-steps\n\nFix XPath Matchers in Cucumber Asset Steps","distinct":true,"url":"https://api.github.com/repos/activeadmin/activeadmin/commits/e349283d4a7b13a95d20925b5fe2e52eceee565c"}]}