{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14166","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14166/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14166/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14166/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14166","id":107174826,"number":14166,"title":"Clean the govet errors","user":{"login":"alfred-huangjian","id":6328548,"avatar_url":"https://avatars.githubusercontent.com/u/6328548?v=3","gravatar_id":"","url":"https://api.github.com/users/alfred-huangjian","html_url":"https://github.com/alfred-huangjian","followers_url":"https://api.github.com/users/alfred-huangjian/followers","following_url":"https://api.github.com/users/alfred-huangjian/following{/other_user}","gists_url":"https://api.github.com/users/alfred-huangjian/gists{/gist_id}","starred_url":"https://api.github.com/users/alfred-huangjian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfred-huangjian/subscriptions","organizations_url":"https://api.github.com/users/alfred-huangjian/orgs","repos_url":"https://api.github.com/users/alfred-huangjian/repos","events_url":"https://api.github.com/users/alfred-huangjian/events{/privacy}","received_events_url":"https://api.github.com/users/alfred-huangjian/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-18T10:12:47Z","updated_at":"2015-09-18T10:13:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14166","html_url":"https://github.com/kubernetes/kubernetes/pull/14166","diff_url":"https://github.com/kubernetes/kubernetes/pull/14166.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14166.patch"},"body":"After running the static check, errors generated as below. \r\n\r\n<pre>\r\n# make vet\r\nhack/vet-go.sh  \r\npkg/api/types.go:1348: struct field tag `json:port` not compatible with reflect.StructTag.Get: bad syntax for struct tag value\r\npkg/api/rest/resttest/resttest.go:571: no formatting directive in Fatalf call\r\npkg/api/rest/resttest/resttest.go:598: no formatting directive in Fatalf call\r\npkg/api/rest/resttest/resttest.go:625: no formatting directive in Fatalf call\r\npkg/api/rest/resttest/resttest.go:657: no formatting directive in Fatalf call\r\npkg/api/rest/resttest/resttest.go:915: arg meta.ResourceVersion for printf verb %d of wrong type: string\r\npkg/api/v1/types.go:1697: struct field tag `json:port` not compatible with reflect.StructTag.Get: bad syntax for struct tag value\r\npkg/api/validation/validation_test.go:461: k8s.io/kubernetes/pkg/api.CinderVolumeSource composite literal uses unkeyed fields\r\npkg/client/unversioned/testclient/fixture.go:94: unreachable code\r\npkg/cloudprovider/providers/aws/aws.go:1291: no formatting directive in Errorf call\r\npkg/cloudprovider/providers/aws/aws_test.go:661: no formatting directive in Errorf call\r\npkg/cloudprovider/providers/gce/gce.go:641: google.golang.org/api/compute/v1.UrlMapReference composite literal uses unkeyed fields\r\npkg/cloudprovider/providers/gce/gce.go:682: google.golang.org/api/compute/v1.TargetReference composite literal uses unkeyed fields\r\npkg/cloudprovider/providers/gce/gce.go:788: google.golang.org/api/compute/v1.InstanceReference composite literal uses unkeyed fields\r\npkg/cloudprovider/providers/gce/gce.go:810: google.golang.org/api/compute/v1.InstanceReference composite literal uses unkeyed fields\r\npkg/cloudprovider/providers/gce/gce.go:836: google.golang.org/api/compute/v1.NamedPort composite literal uses unkeyed fields\r\npkg/controller/job/job_controller_test.go:247: missing argument for Errorf(\"%v\"): format reads arg 2, have only 1 args\r\npkg/kubectl/describe.go:1301: possible formatting directive in Fprint call\r\npkg/kubectl/resource_printer.go:1229: possible formatting directive in Sprint call\r\npkg/kubectl/rolling_updater.go:406: arg controller.Spec for printf verb %d of wrong type: k8s.io/kubernetes/pkg/api.ReplicationControllerSpec\r\npkg/kubectl/cmd/edit.go:282: unreachable code\r\npkg/kubectl/cmd/cmd_test.go:359: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/kubectl/cmd/cmd_test.go:376: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/kubectl/cmd/cmd_test.go:393: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/kubectl/cmd/cmd_test.go:410: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/kubectl/cmd/cmd_test.go:427: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/kubelet/kubelet_test.go:3201: missing argument for Errorf(\"%s\"): format reads arg 2, have only 1 args\r\npkg/kubelet/rkt/rkt.go:1273: missing argument for Errorf(\"%q\"): format reads arg 1, have only 0 args\r\npkg/master/master_test.go:57: setUp returns Lock by value: master.Master contains sync.Mutex\r\npkg/master/master_test.go:440: struct field items has json tag but is not exported\r\npkg/master/thirdparty_controller_test.go:175: missing argument for Errorf(\"%v\"): format reads arg 2, have only 1 args\r\npkg/registry/thirdpartyresourcedata/codec_test.go:42: struct field items has json tag but is not exported\r\npkg/registry/thirdpartyresourcedata/codec_test.go:68: k8s.io/kubernetes/pkg/api/unversioned.Time composite literal uses unkeyed fields\r\npkg/util/backoff_test.go:73: missing argument for Errorf(\"%s\"): format reads arg 5, have only 4 args\r\npkg/util/dbus/dbus_test.go:216: github.com/godbus/dbus.Error composite literal uses unkeyed fields\r\npkg/util/iptables/iptables_test.go:676: k8s.io/kubernetes/pkg/util/exec.FakeExitError composite literal uses unkeyed fields\r\npkg/util/iptables/iptables_test.go:684: k8s.io/kubernetes/pkg/util/exec.FakeExitError composite literal uses unkeyed fields\r\npkg/volume/aws_ebs/aws_ebs.go:109: k8s.io/kubernetes/pkg/util/mount.SafeFormatAndMount composite literal uses unkeyed fields\r\npkg/volume/cephfs/cephfs_test.go:72: missing argument for Errorf(\"%v\"): format reads arg 1, have only 0 args\r\npkg/volume/cephfs/cephfs_test.go:93: missing argument for Errorf(\"%v\"): format reads arg 1, have only 0 args\r\npkg/volume/cinder/cinder_util.go:181: unreachable code\r\npkg/volume/cinder/cinder_util.go:188: possible formatting directive in Sprint call\r\npkg/volume/cinder/cinder_test.go:91: missing argument for Errorf(\"%v\"): format reads arg 1, have only 0 args\r\npkg/volume/cinder/cinder_test.go:122: missing argument for Errorf(\"%v\"): format reads arg 1, have only 0 args\r\npkg/volume/gce_pd/gce_pd.go:107: k8s.io/kubernetes/pkg/util/mount.SafeFormatAndMount composite literal uses unkeyed fields\r\npkg/volume/host_path/host_path_test.go:94: possible formatting directive in Fatal call\r\nplugin/pkg/admission/namespace/lifecycle/admission_test.go:117: no formatting directive in Errorf call\r\nplugin/pkg/admission/namespace/lifecycle/admission_test.go:122: no formatting directive in Errorf call\r\nplugin/pkg/admission/namespace/lifecycle/admission_test.go:127: no formatting directive in Errorf call\r\nmake: *** [vet] Error 1\r\n</pre>"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/141411166","html_url":"https://github.com/kubernetes/kubernetes/pull/14166#issuecomment-141411166","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14166","id":141411166,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T10:13:06Z","updated_at":"2015-09-18T10:13:06Z","body":"Can one of the admins verify that this patch is reasonable to test? (reply \"ok to test\", or if you trust the user, reply \"add to whitelist\")\n\nIf this message is too spammy, please complain to ixdy."}}