{"action":"created","issue":{"url":"https://api.github.com/repos/roeldewit/PSE/issues/29","labels_url":"https://api.github.com/repos/roeldewit/PSE/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/roeldewit/PSE/issues/29/comments","events_url":"https://api.github.com/repos/roeldewit/PSE/issues/29/events","html_url":"https://github.com/roeldewit/PSE/pull/29","id":114285319,"number":29,"title":"Multiple photo upload","user":{"login":"renevdvorst","id":14079526,"avatar_url":"https://avatars.githubusercontent.com/u/14079526?v=3","gravatar_id":"","url":"https://api.github.com/users/renevdvorst","html_url":"https://github.com/renevdvorst","followers_url":"https://api.github.com/users/renevdvorst/followers","following_url":"https://api.github.com/users/renevdvorst/following{/other_user}","gists_url":"https://api.github.com/users/renevdvorst/gists{/gist_id}","starred_url":"https://api.github.com/users/renevdvorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renevdvorst/subscriptions","organizations_url":"https://api.github.com/users/renevdvorst/orgs","repos_url":"https://api.github.com/users/renevdvorst/repos","events_url":"https://api.github.com/users/renevdvorst/events{/privacy}","received_events_url":"https://api.github.com/users/renevdvorst/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-30T14:54:12Z","updated_at":"2015-11-02T13:06:40Z","closed_at":"2015-11-02T13:06:14Z","pull_request":{"url":"https://api.github.com/repos/roeldewit/PSE/pulls/29","html_url":"https://github.com/roeldewit/PSE/pull/29","diff_url":"https://github.com/roeldewit/PSE/pull/29.diff","patch_url":"https://github.com/roeldewit/PSE/pull/29.patch"},"body":"Multi upload klaar. Hij is nu te vinden op:\r\n/app/photographers/shop/{shopnaam}/{sessiecode}/upload\r\noftewel aals voorbeeld: /app/photographers/shop/mooie-kiekjes/blft-8-2-2015!0538/upload\r\n\r\nPaar puntjes: \r\n1. ik heb nu \\photographers\\shop\\index.twig als master gebruikt voor de styling, is dat de bedoeling?(zag dat bij producer ook zoiets dergelijks was)\r\n2. Voor users was een helper om de login te krijgen. Ik heb die erbij gemaakt voor de andere 2 en samen in LoginHelper.java gestopt. Tevens heb ik her en der wat functies nodig gehad om ownership van bv sessies en shops te controleren, daar is ook een helper voor. Wellicht hebben anderen deze ook nodig en kunnen ze uitgebreid worden. Ik heb ze beide in de helpers.authentication package gestopt om een beetje de wildgroei aan packages te remmen.\r\n3. Branch is up to date met main branch\r\n4. Tarkan was ergens op vakantie in deze tijd. Weet iemand wanneer precies? Anders wil ik hem graag toch mergen, dan kan hij later dit checken, anders loopt de branch dadelijk weer achter.\r\n5. Wat betreft de url structuur: dit moeten we misschien aanpassen later. Heb er ook al even met Gijs over gesproken maar er lopen nu meerder dingen die iets met sessies/foto's doen. Dus zet ik hem nu zo weg en dan kunnen we wellicht in de hardening eens kijken of we alle foto gerelateerde functionaliteit samen kunnen voegen op een leuke manier(sessies beheren, fotos toevoegen,weghalen uit sessies etc)\r\n\r\n@Tarkan vooral: wat hij doet( of zou moeten doen ;) is hij checkt of de sessie/shop bestaat, vervolgens of ze wel bij de ingelogde fotograaf horen, of de shop wel van de fotograaf is etc. Alleen foto's mogen worden geupload. Dat soort dingetjes mogen nog wel wat extra getest worden."},"comment":{"url":"https://api.github.com/repos/roeldewit/PSE/issues/comments/153011610","html_url":"https://github.com/roeldewit/PSE/pull/29#issuecomment-153011610","issue_url":"https://api.github.com/repos/roeldewit/PSE/issues/29","id":153011610,"user":{"login":"takcy1980","id":10144001,"avatar_url":"https://avatars.githubusercontent.com/u/10144001?v=3","gravatar_id":"","url":"https://api.github.com/users/takcy1980","html_url":"https://github.com/takcy1980","followers_url":"https://api.github.com/users/takcy1980/followers","following_url":"https://api.github.com/users/takcy1980/following{/other_user}","gists_url":"https://api.github.com/users/takcy1980/gists{/gist_id}","starred_url":"https://api.github.com/users/takcy1980/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takcy1980/subscriptions","organizations_url":"https://api.github.com/users/takcy1980/orgs","repos_url":"https://api.github.com/users/takcy1980/repos","events_url":"https://api.github.com/users/takcy1980/events{/privacy}","received_events_url":"https://api.github.com/users/takcy1980/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T13:06:40Z","updated_at":"2015-11-02T13:06:40Z","body":"Hoi Rene,\r\n\r\nIk ga pas deze week met vakantie, heb een beetje druk gehad in het weekend.\r\nHeb de merge doorgevoerd.\r\n\r\n"}}