{"action":"closed","number":3529,"pull_request":{"url":"https://api.github.com/repos/fog/fog/pulls/3529","id":33237524,"html_url":"https://github.com/fog/fog/pull/3529","diff_url":"https://github.com/fog/fog/pull/3529.diff","patch_url":"https://github.com/fog/fog/pull/3529.patch","issue_url":"https://api.github.com/repos/fog/fog/issues/3529","number":3529,"state":"closed","locked":false,"title":"[XenServer] Fix the 'redirect to master' functionality","user":{"login":"kongslund","id":1836149,"avatar_url":"https://avatars.githubusercontent.com/u/1836149?v=3","gravatar_id":"","url":"https://api.github.com/users/kongslund","html_url":"https://github.com/kongslund","followers_url":"https://api.github.com/users/kongslund/followers","following_url":"https://api.github.com/users/kongslund/following{/other_user}","gists_url":"https://api.github.com/users/kongslund/gists{/gist_id}","starred_url":"https://api.github.com/users/kongslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kongslund/subscriptions","organizations_url":"https://api.github.com/users/kongslund/orgs","repos_url":"https://api.github.com/users/kongslund/repos","events_url":"https://api.github.com/users/kongslund/events{/privacy}","received_events_url":"https://api.github.com/users/kongslund/received_events","type":"User","site_admin":false},"body":"When authenticating towards a slave host, the error `HOST_IS_SLAVE` is returned by the slave host together with the IP address of the master host. Previously this resulted in an `InvalidLogin` exception which was hiding the actual cause. Now it results in an `HostIsSlave` exception which is then used to redirect the connection to the master host in case `:xenserver_redirect_to_master` is true.\r\n\r\nThis fix also removes the previous behaviour of doing a double login when the host is a master.\r\n\r\nThis is a breaking change since I have removed the `find_pool_master` method from the `Fog::XenServer::Connection` class. However it was not working (it invoked `authenticate` at the beginning which resulted in an `InvalidLogin` exception in case of a slave) and the official way is to let `Fog::Compute::XenServer` deal with the connection.","created_at":"2015-04-14T08:53:38Z","updated_at":"2015-04-14T11:36:23Z","closed_at":"2015-04-14T11:36:23Z","merged_at":"2015-04-14T11:36:23Z","merge_commit_sha":"f69ead5a23e57d6a8714811ecd6c741a04977150","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fog/fog/pulls/3529/commits","review_comments_url":"https://api.github.com/repos/fog/fog/pulls/3529/comments","review_comment_url":"https://api.github.com/repos/fog/fog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fog/fog/issues/3529/comments","statuses_url":"https://api.github.com/repos/fog/fog/statuses/5dfaded56cbcb2676d91abbb2cb6b193a23aa36b","head":{"label":"kongslund:xenserver-pool","ref":"xenserver-pool","sha":"5dfaded56cbcb2676d91abbb2cb6b193a23aa36b","user":{"login":"kongslund","id":1836149,"avatar_url":"https://avatars.githubusercontent.com/u/1836149?v=3","gravatar_id":"","url":"https://api.github.com/users/kongslund","html_url":"https://github.com/kongslund","followers_url":"https://api.github.com/users/kongslund/followers","following_url":"https://api.github.com/users/kongslund/following{/other_user}","gists_url":"https://api.github.com/users/kongslund/gists{/gist_id}","starred_url":"https://api.github.com/users/kongslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kongslund/subscriptions","organizations_url":"https://api.github.com/users/kongslund/orgs","repos_url":"https://api.github.com/users/kongslund/repos","events_url":"https://api.github.com/users/kongslund/events{/privacy}","received_events_url":"https://api.github.com/users/kongslund/received_events","type":"User","site_admin":false},"repo":{"id":31697871,"name":"fog","full_name":"kongslund/fog","owner":{"login":"kongslund","id":1836149,"avatar_url":"https://avatars.githubusercontent.com/u/1836149?v=3","gravatar_id":"","url":"https://api.github.com/users/kongslund","html_url":"https://github.com/kongslund","followers_url":"https://api.github.com/users/kongslund/followers","following_url":"https://api.github.com/users/kongslund/following{/other_user}","gists_url":"https://api.github.com/users/kongslund/gists{/gist_id}","starred_url":"https://api.github.com/users/kongslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kongslund/subscriptions","organizations_url":"https://api.github.com/users/kongslund/orgs","repos_url":"https://api.github.com/users/kongslund/repos","events_url":"https://api.github.com/users/kongslund/events{/privacy}","received_events_url":"https://api.github.com/users/kongslund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kongslund/fog","description":"The Ruby cloud services library.","fork":true,"url":"https://api.github.com/repos/kongslund/fog","forks_url":"https://api.github.com/repos/kongslund/fog/forks","keys_url":"https://api.github.com/repos/kongslund/fog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kongslund/fog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kongslund/fog/teams","hooks_url":"https://api.github.com/repos/kongslund/fog/hooks","issue_events_url":"https://api.github.com/repos/kongslund/fog/issues/events{/number}","events_url":"https://api.github.com/repos/kongslund/fog/events","assignees_url":"https://api.github.com/repos/kongslund/fog/assignees{/user}","branches_url":"https://api.github.com/repos/kongslund/fog/branches{/branch}","tags_url":"https://api.github.com/repos/kongslund/fog/tags","blobs_url":"https://api.github.com/repos/kongslund/fog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kongslund/fog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kongslund/fog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kongslund/fog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kongslund/fog/statuses/{sha}","languages_url":"https://api.github.com/repos/kongslund/fog/languages","stargazers_url":"https://api.github.com/repos/kongslund/fog/stargazers","contributors_url":"https://api.github.com/repos/kongslund/fog/contributors","subscribers_url":"https://api.github.com/repos/kongslund/fog/subscribers","subscription_url":"https://api.github.com/repos/kongslund/fog/subscription","commits_url":"https://api.github.com/repos/kongslund/fog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kongslund/fog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kongslund/fog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kongslund/fog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kongslund/fog/contents/{+path}","compare_url":"https://api.github.com/repos/kongslund/fog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kongslund/fog/merges","archive_url":"https://api.github.com/repos/kongslund/fog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kongslund/fog/downloads","issues_url":"https://api.github.com/repos/kongslund/fog/issues{/number}","pulls_url":"https://api.github.com/repos/kongslund/fog/pulls{/number}","milestones_url":"https://api.github.com/repos/kongslund/fog/milestones{/number}","notifications_url":"https://api.github.com/repos/kongslund/fog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kongslund/fog/labels{/name}","releases_url":"https://api.github.com/repos/kongslund/fog/releases{/id}","created_at":"2015-03-05T05:41:54Z","updated_at":"2015-04-14T03:42:36Z","pushed_at":"2015-04-14T08:41:11Z","git_url":"git://github.com/kongslund/fog.git","ssh_url":"git@github.com:kongslund/fog.git","clone_url":"https://github.com/kongslund/fog.git","svn_url":"https://github.com/kongslund/fog","homepage":"http://fog.io","size":20121,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fog:master","ref":"master","sha":"dc4929dfb8f9a35ca3da292cfbb8b69add548a6d","user":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"repo":{"id":203666,"name":"fog","full_name":"fog/fog","owner":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fog/fog","description":"The Ruby cloud services library.","fork":false,"url":"https://api.github.com/repos/fog/fog","forks_url":"https://api.github.com/repos/fog/fog/forks","keys_url":"https://api.github.com/repos/fog/fog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fog/fog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fog/fog/teams","hooks_url":"https://api.github.com/repos/fog/fog/hooks","issue_events_url":"https://api.github.com/repos/fog/fog/issues/events{/number}","events_url":"https://api.github.com/repos/fog/fog/events","assignees_url":"https://api.github.com/repos/fog/fog/assignees{/user}","branches_url":"https://api.github.com/repos/fog/fog/branches{/branch}","tags_url":"https://api.github.com/repos/fog/fog/tags","blobs_url":"https://api.github.com/repos/fog/fog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fog/fog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fog/fog/git/refs{/sha}","trees_url":"https://api.github.com/repos/fog/fog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fog/fog/statuses/{sha}","languages_url":"https://api.github.com/repos/fog/fog/languages","stargazers_url":"https://api.github.com/repos/fog/fog/stargazers","contributors_url":"https://api.github.com/repos/fog/fog/contributors","subscribers_url":"https://api.github.com/repos/fog/fog/subscribers","subscription_url":"https://api.github.com/repos/fog/fog/subscription","commits_url":"https://api.github.com/repos/fog/fog/commits{/sha}","git_commits_url":"https://api.github.com/repos/fog/fog/git/commits{/sha}","comments_url":"https://api.github.com/repos/fog/fog/comments{/number}","issue_comment_url":"https://api.github.com/repos/fog/fog/issues/comments{/number}","contents_url":"https://api.github.com/repos/fog/fog/contents/{+path}","compare_url":"https://api.github.com/repos/fog/fog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fog/fog/merges","archive_url":"https://api.github.com/repos/fog/fog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fog/fog/downloads","issues_url":"https://api.github.com/repos/fog/fog/issues{/number}","pulls_url":"https://api.github.com/repos/fog/fog/pulls{/number}","milestones_url":"https://api.github.com/repos/fog/fog/milestones{/number}","notifications_url":"https://api.github.com/repos/fog/fog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fog/fog/labels{/name}","releases_url":"https://api.github.com/repos/fog/fog/releases{/id}","created_at":"2009-05-18T07:14:04Z","updated_at":"2015-04-12T17:24:43Z","pushed_at":"2015-04-14T11:36:23Z","git_url":"git://github.com/fog/fog.git","ssh_url":"git@github.com:fog/fog.git","clone_url":"https://github.com/fog/fog.git","svn_url":"https://github.com/fog/fog","homepage":"http://fog.io","size":46798,"stargazers_count":3447,"watchers_count":3447,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1425,"mirror_url":null,"open_issues_count":88,"forks":1425,"open_issues":88,"watchers":3447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fog/fog/pulls/3529"},"html":{"href":"https://github.com/fog/fog/pull/3529"},"issue":{"href":"https://api.github.com/repos/fog/fog/issues/3529"},"comments":{"href":"https://api.github.com/repos/fog/fog/issues/3529/comments"},"review_comments":{"href":"https://api.github.com/repos/fog/fog/pulls/3529/comments"},"review_comment":{"href":"https://api.github.com/repos/fog/fog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fog/fog/pulls/3529/commits"},"statuses":{"href":"https://api.github.com/repos/fog/fog/statuses/5dfaded56cbcb2676d91abbb2cb6b193a23aa36b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"plribeiro3000","id":672952,"avatar_url":"https://avatars.githubusercontent.com/u/672952?v=3","gravatar_id":"","url":"https://api.github.com/users/plribeiro3000","html_url":"https://github.com/plribeiro3000","followers_url":"https://api.github.com/users/plribeiro3000/followers","following_url":"https://api.github.com/users/plribeiro3000/following{/other_user}","gists_url":"https://api.github.com/users/plribeiro3000/gists{/gist_id}","starred_url":"https://api.github.com/users/plribeiro3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plribeiro3000/subscriptions","organizations_url":"https://api.github.com/users/plribeiro3000/orgs","repos_url":"https://api.github.com/users/plribeiro3000/repos","events_url":"https://api.github.com/users/plribeiro3000/events{/privacy}","received_events_url":"https://api.github.com/users/plribeiro3000/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":25,"deletions":24,"changed_files":2}}