{"action":"created","issue":{"url":"https://api.github.com/repos/Froal/fetlife/issues/1","labels_url":"https://api.github.com/repos/Froal/fetlife/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Froal/fetlife/issues/1/comments","events_url":"https://api.github.com/repos/Froal/fetlife/issues/1/events","html_url":"https://github.com/Froal/fetlife/issues/1","id":53973985,"number":1,"title":"Unconditional use of mcrypt* extension leads to fatal error","user":{"login":"meitar","id":18677,"avatar_url":"https://avatars.githubusercontent.com/u/18677?v=3","gravatar_id":"","url":"https://api.github.com/users/meitar","html_url":"https://github.com/meitar","followers_url":"https://api.github.com/users/meitar/followers","following_url":"https://api.github.com/users/meitar/following{/other_user}","gists_url":"https://api.github.com/users/meitar/gists{/gist_id}","starred_url":"https://api.github.com/users/meitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meitar/subscriptions","organizations_url":"https://api.github.com/users/meitar/orgs","repos_url":"https://api.github.com/users/meitar/repos","events_url":"https://api.github.com/users/meitar/events{/privacy}","received_events_url":"https://api.github.com/users/meitar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-10T22:35:50Z","updated_at":"2015-01-11T04:37:34Z","closed_at":null,"body":"The `protected static function encrypt` and `protected static function decrypt` functions ([shown here in the source](https://github.com/Froal/fetlife/blob/b5cac542c202ac179c88aa98870e31f8e1763b2c/fetlife.php#L236-L250)) call functions defined in [PHP's mcrypt extension](https://php.net/manual/en/book.mcrypt.php) unconditionally, causing a fatal error when that extension is not installed.\r\n\r\nAlso, I'm not sure I understand what the point of these functions are if the key they use is static. That's effectively security by obscurity. :("},"comment":{"url":"https://api.github.com/repos/Froal/fetlife/issues/comments/69483430","html_url":"https://github.com/Froal/fetlife/issues/1#issuecomment-69483430","issue_url":"https://api.github.com/repos/Froal/fetlife/issues/1","id":69483430,"user":{"login":"Froal","id":10391387,"avatar_url":"https://avatars.githubusercontent.com/u/10391387?v=3","gravatar_id":"","url":"https://api.github.com/users/Froal","html_url":"https://github.com/Froal","followers_url":"https://api.github.com/users/Froal/followers","following_url":"https://api.github.com/users/Froal/following{/other_user}","gists_url":"https://api.github.com/users/Froal/gists{/gist_id}","starred_url":"https://api.github.com/users/Froal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Froal/subscriptions","organizations_url":"https://api.github.com/users/Froal/orgs","repos_url":"https://api.github.com/users/Froal/repos","events_url":"https://api.github.com/users/Froal/events{/privacy}","received_events_url":"https://api.github.com/users/Froal/received_events","type":"User","site_admin":false},"created_at":"2015-01-11T04:37:34Z","updated_at":"2015-01-11T04:37:34Z","body":"Thank you for weighing in!\r\n\r\nThe static key used, and the encryption method, is just for me to get going, really. There is a will to try and make things flexible, but at that point the most important for me was to get it work for my website ASAP - even at the price of taking shortcuts - because the site was down for maybe 6 months.\r\nSo this whole code base is, if you wish, an \"advanced draft\". There is the whole website around that had my priority.\r\n\r\nNow that self-justification is out there (:p), any kind of remark/improvement is very much welcomed please don't hesitate to suggest!\r\n"}}