{"action":"created","issue":{"url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/9","labels_url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/9/comments","events_url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/9/events","html_url":"https://github.com/davidtsadler/ebay-sdk-php/issues/9","id":115239773,"number":9,"title":"CredentialsProvider.php  typo","user":{"login":"dtjones","id":1758785,"avatar_url":"https://avatars.githubusercontent.com/u/1758785?v=3","gravatar_id":"","url":"https://api.github.com/users/dtjones","html_url":"https://github.com/dtjones","followers_url":"https://api.github.com/users/dtjones/followers","following_url":"https://api.github.com/users/dtjones/following{/other_user}","gists_url":"https://api.github.com/users/dtjones/gists{/gist_id}","starred_url":"https://api.github.com/users/dtjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtjones/subscriptions","organizations_url":"https://api.github.com/users/dtjones/orgs","repos_url":"https://api.github.com/users/dtjones/repos","events_url":"https://api.github.com/users/dtjones/events{/privacy}","received_events_url":"https://api.github.com/users/dtjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-05T09:12:54Z","updated_at":"2015-11-05T09:28:56Z","closed_at":null,"body":"Beta branch. \r\nUse of undefined constant homePath - assumed 'homePath' in eBaySDK\\Credentials\\CredentialsProvider.php</b> on line <b>170</b>\r\n\r\n    return ($homeDrive && homePath) ? $homeDrive . $homePath : null;\r\n\r\nshould be \r\n\r\n    return ($homeDrive && $homePath) ? $homeDrive . $homePath : null;\r\n"},"comment":{"url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/comments/154002917","html_url":"https://github.com/davidtsadler/ebay-sdk-php/issues/9#issuecomment-154002917","issue_url":"https://api.github.com/repos/davidtsadler/ebay-sdk-php/issues/9","id":154002917,"user":{"login":"dtjones","id":1758785,"avatar_url":"https://avatars.githubusercontent.com/u/1758785?v=3","gravatar_id":"","url":"https://api.github.com/users/dtjones","html_url":"https://github.com/dtjones","followers_url":"https://api.github.com/users/dtjones/followers","following_url":"https://api.github.com/users/dtjones/following{/other_user}","gists_url":"https://api.github.com/users/dtjones/gists{/gist_id}","starred_url":"https://api.github.com/users/dtjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtjones/subscriptions","organizations_url":"https://api.github.com/users/dtjones/orgs","repos_url":"https://api.github.com/users/dtjones/repos","events_url":"https://api.github.com/users/dtjones/events{/privacy}","received_events_url":"https://api.github.com/users/dtjones/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T09:28:56Z","updated_at":"2015-11-05T09:28:56Z","body":"also constants in Constants\\SiteIds are all ints but the config expects a string.\r\n`'siteId' => Constants\\SiteIds::GB,` gives me this error \r\nUncaught exception 'InvalidArgumentException' with message 'Invalid configuration value provided for \"siteId\". Expected string, but got <pre class='xdebug-var-dump' dir='ltr'><small>int</small> <font color='#4e9a06'>3</font> </pre> \r\n\r\nfor now ive just casted the const to a string\r\n\r\n`'siteId' => (string)Constants\\SiteIds::GB,` "}}