{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/jest/issues/330","labels_url":"https://api.github.com/repos/facebook/jest/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/facebook/jest/issues/330/comments","events_url":"https://api.github.com/repos/facebook/jest/issues/330/events","html_url":"https://github.com/facebook/jest/pull/330","id":68315638,"number":330,"title":"Optional jasmine 2 support","user":{"login":"gagoman","id":1894766,"avatar_url":"https://avatars.githubusercontent.com/u/1894766?v=3","gravatar_id":"","url":"https://api.github.com/users/gagoman","html_url":"https://github.com/gagoman","followers_url":"https://api.github.com/users/gagoman/followers","following_url":"https://api.github.com/users/gagoman/following{/other_user}","gists_url":"https://api.github.com/users/gagoman/gists{/gist_id}","starred_url":"https://api.github.com/users/gagoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagoman/subscriptions","organizations_url":"https://api.github.com/users/gagoman/orgs","repos_url":"https://api.github.com/users/gagoman/repos","events_url":"https://api.github.com/users/gagoman/events{/privacy}","received_events_url":"https://api.github.com/users/gagoman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/jest/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"milestone":null,"comments":22,"created_at":"2015-04-14T09:27:41Z","updated_at":"2015-10-24T07:08:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/330","html_url":"https://github.com/facebook/jest/pull/330","diff_url":"https://github.com/facebook/jest/pull/330.diff","patch_url":"https://github.com/facebook/jest/pull/330.patch"},"body":"Good day.\r\n\r\nThis patch add optional `jasmine 2.x` support to `jest`.\r\n\r\nBenefits:\r\n\r\n* bundled `jasmine` is not modified, it can be updated any time\r\n* `done` callback support\r\n* whatever you need from `jasmine-2.x`\r\n\r\nTODOs:\r\n\r\n- [ ] make https://github.com/jeffmo/jasmine-pit/pull/12 work, so I can remove dependency on my fork of `jasmine-pit`\r\n- [x] extract base code for both runners\r\n- [x] update matchers as I haven't tested them after update\r\n- [x] fix all TODO's\r\n- [x] add note about `jasmine 1.x` and `jasmine 2.x` differences\r\n\r\nPatches are welcome."},"comment":{"url":"https://api.github.com/repos/facebook/jest/issues/comments/150771909","html_url":"https://github.com/facebook/jest/pull/330#issuecomment-150771909","issue_url":"https://api.github.com/repos/facebook/jest/issues/330","id":150771909,"user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T07:08:55Z","updated_at":"2015-10-24T07:08:55Z","body":"I think it is fine to add jasmine 2 support as an option. I'll think about the deprecation strategy for jasmine 1 later and when it makes sense to make jasmine 2 the default. Ideally we'll support any kind of test framework within jest in the future and we can split jasmine1 support out into a separate npm package."}}