{"action":"created","comment":{"url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/comments/34250110","id":34250110,"diff_hunk":"@@ -97,17 +143,23 @@ void setCurrentTransform(AppliedPTransform<?, ?, ?> transform) {\n     return output;\n   }\n \n-  void setOutputRDD(PTransform<?, ?> transform, JavaRDDLike<?, ?> rdd) {\n+  <T> void setOutputRDD(PTransform<?, ?> transform, JavaRDDLike<T, ?> rdd) {","path":"src/main/java/com/cloudera/dataflow/spark/EvaluationContext.java","position":69,"original_position":69,"commit_id":"2d7f49c079531d6e3287c50f08773f76ce9cd7ed","original_commit_id":"34c8d953d9ca49516d6441d0b7f6e2abd1acbf55","user":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars.githubusercontent.com/u/85085?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"body":"It's needed in the call to `setRDD()` to get the type for the `RDDHolder`. So I think it's needed. (In general it's best to have a specific bound, `T`, rather than a wildcard `?`.)","created_at":"2015-07-09T12:38:51Z","updated_at":"2015-07-09T12:38:51Z","html_url":"https://github.com/cloudera/spark-dataflow/pull/60#discussion_r34250110","pull_request_url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/comments/34250110"},"html":{"href":"https://github.com/cloudera/spark-dataflow/pull/60#discussion_r34250110"},"pull_request":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60","id":39572302,"html_url":"https://github.com/cloudera/spark-dataflow/pull/60","diff_url":"https://github.com/cloudera/spark-dataflow/pull/60.diff","patch_url":"https://github.com/cloudera/spark-dataflow/pull/60.patch","issue_url":"https://api.github.com/repos/cloudera/spark-dataflow/issues/60","number":60,"state":"open","locked":false,"title":"Large broadcasts","user":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars.githubusercontent.com/u/85085?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"body":"The is an improvement to reduce the number of copies made of objects when serializing them to bytes[] for transmission across the network. \r\n\r\nThe first is to avoid eagerly parallelizing a PCollection from values that have been turned into byte arrays, since in some cases - notably when creating views - this is not needed.\r\n\r\nThe second is to allow boradcasts to be made of values themselves, rather than their byte array equivalents.\r\n\r\nWith these changes I was able to successfully use a view that was ~3GB in size. Before these changes it ran out of memory since two copies were being made.","created_at":"2015-07-09T11:18:30Z","updated_at":"2015-07-09T12:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45dedd162c487c1983bb4bcae71bb73e75de0328","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60/commits","review_comments_url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60/comments","review_comment_url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudera/spark-dataflow/issues/60/comments","statuses_url":"https://api.github.com/repos/cloudera/spark-dataflow/statuses/2d7f49c079531d6e3287c50f08773f76ce9cd7ed","head":{"label":"tomwhite:large-broadcasts","ref":"large-broadcasts","sha":"2d7f49c079531d6e3287c50f08773f76ce9cd7ed","user":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars.githubusercontent.com/u/85085?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"repo":{"id":34735143,"name":"spark-dataflow","full_name":"tomwhite/spark-dataflow","owner":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars.githubusercontent.com/u/85085?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomwhite/spark-dataflow","description":"Provides a Spark backend for executing Dataflow pipelines.","fork":true,"url":"https://api.github.com/repos/tomwhite/spark-dataflow","forks_url":"https://api.github.com/repos/tomwhite/spark-dataflow/forks","keys_url":"https://api.github.com/repos/tomwhite/spark-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomwhite/spark-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomwhite/spark-dataflow/teams","hooks_url":"https://api.github.com/repos/tomwhite/spark-dataflow/hooks","issue_events_url":"https://api.github.com/repos/tomwhite/spark-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/tomwhite/spark-dataflow/events","assignees_url":"https://api.github.com/repos/tomwhite/spark-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/tomwhite/spark-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/tomwhite/spark-dataflow/tags","blobs_url":"https://api.github.com/repos/tomwhite/spark-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomwhite/spark-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomwhite/spark-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomwhite/spark-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomwhite/spark-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tomwhite/spark-dataflow/languages","stargazers_url":"https://api.github.com/repos/tomwhite/spark-dataflow/stargazers","contributors_url":"https://api.github.com/repos/tomwhite/spark-dataflow/contributors","subscribers_url":"https://api.github.com/repos/tomwhite/spark-dataflow/subscribers","subscription_url":"https://api.github.com/repos/tomwhite/spark-dataflow/subscription","commits_url":"https://api.github.com/repos/tomwhite/spark-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomwhite/spark-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomwhite/spark-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomwhite/spark-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomwhite/spark-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/tomwhite/spark-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomwhite/spark-dataflow/merges","archive_url":"https://api.github.com/repos/tomwhite/spark-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomwhite/spark-dataflow/downloads","issues_url":"https://api.github.com/repos/tomwhite/spark-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/tomwhite/spark-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tomwhite/spark-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tomwhite/spark-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomwhite/spark-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/tomwhite/spark-dataflow/releases{/id}","created_at":"2015-04-28T14:23:05Z","updated_at":"2015-04-28T14:23:06Z","pushed_at":"2015-07-09T11:36:52Z","git_url":"git://github.com/tomwhite/spark-dataflow.git","ssh_url":"git@github.com:tomwhite/spark-dataflow.git","clone_url":"https://github.com/tomwhite/spark-dataflow.git","svn_url":"https://github.com/tomwhite/spark-dataflow","homepage":"","size":540,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudera:master","ref":"master","sha":"d492c7d3a62c9fdd50deac3337b5fb6f12d4e51c","user":{"login":"cloudera","id":87383,"avatar_url":"https://avatars.githubusercontent.com/u/87383?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudera","html_url":"https://github.com/cloudera","followers_url":"https://api.github.com/users/cloudera/followers","following_url":"https://api.github.com/users/cloudera/following{/other_user}","gists_url":"https://api.github.com/users/cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudera/subscriptions","organizations_url":"https://api.github.com/users/cloudera/orgs","repos_url":"https://api.github.com/users/cloudera/repos","events_url":"https://api.github.com/users/cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/cloudera/received_events","type":"Organization","site_admin":false},"repo":{"id":27842884,"name":"spark-dataflow","full_name":"cloudera/spark-dataflow","owner":{"login":"cloudera","id":87383,"avatar_url":"https://avatars.githubusercontent.com/u/87383?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudera","html_url":"https://github.com/cloudera","followers_url":"https://api.github.com/users/cloudera/followers","following_url":"https://api.github.com/users/cloudera/following{/other_user}","gists_url":"https://api.github.com/users/cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudera/subscriptions","organizations_url":"https://api.github.com/users/cloudera/orgs","repos_url":"https://api.github.com/users/cloudera/repos","events_url":"https://api.github.com/users/cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/cloudera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudera/spark-dataflow","description":"Provides a Spark backend for executing Dataflow pipelines.","fork":false,"url":"https://api.github.com/repos/cloudera/spark-dataflow","forks_url":"https://api.github.com/repos/cloudera/spark-dataflow/forks","keys_url":"https://api.github.com/repos/cloudera/spark-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudera/spark-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudera/spark-dataflow/teams","hooks_url":"https://api.github.com/repos/cloudera/spark-dataflow/hooks","issue_events_url":"https://api.github.com/repos/cloudera/spark-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/cloudera/spark-dataflow/events","assignees_url":"https://api.github.com/repos/cloudera/spark-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/cloudera/spark-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/cloudera/spark-dataflow/tags","blobs_url":"https://api.github.com/repos/cloudera/spark-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudera/spark-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudera/spark-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudera/spark-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudera/spark-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudera/spark-dataflow/languages","stargazers_url":"https://api.github.com/repos/cloudera/spark-dataflow/stargazers","contributors_url":"https://api.github.com/repos/cloudera/spark-dataflow/contributors","subscribers_url":"https://api.github.com/repos/cloudera/spark-dataflow/subscribers","subscription_url":"https://api.github.com/repos/cloudera/spark-dataflow/subscription","commits_url":"https://api.github.com/repos/cloudera/spark-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudera/spark-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudera/spark-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudera/spark-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudera/spark-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/cloudera/spark-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudera/spark-dataflow/merges","archive_url":"https://api.github.com/repos/cloudera/spark-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudera/spark-dataflow/downloads","issues_url":"https://api.github.com/repos/cloudera/spark-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/cloudera/spark-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudera/spark-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudera/spark-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudera/spark-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/cloudera/spark-dataflow/releases{/id}","created_at":"2014-12-10T22:29:54Z","updated_at":"2015-07-07T12:37:09Z","pushed_at":"2015-07-09T11:36:52Z","git_url":"git://github.com/cloudera/spark-dataflow.git","ssh_url":"git@github.com:cloudera/spark-dataflow.git","clone_url":"https://github.com/cloudera/spark-dataflow.git","svn_url":"https://github.com/cloudera/spark-dataflow","homepage":"","size":920,"stargazers_count":150,"watchers_count":150,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":6,"forks":29,"open_issues":6,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60"},"html":{"href":"https://github.com/cloudera/spark-dataflow/pull/60"},"issue":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/issues/60"},"comments":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/cloudera/spark-dataflow/statuses/2d7f49c079531d6e3287c50f08773f76ce9cd7ed"}}}}