{"action":"opened","number":69,"pull_request":{"url":"https://api.github.com/repos/kylef/django-request/pulls/69","id":39208337,"html_url":"https://github.com/kylef/django-request/pull/69","diff_url":"https://github.com/kylef/django-request/pull/69.diff","patch_url":"https://github.com/kylef/django-request/pull/69.patch","issue_url":"https://api.github.com/repos/kylef/django-request/issues/69","number":69,"state":"open","locked":false,"title":"make use of staticfiles app","user":{"login":"tiberius","id":597334,"avatar_url":"https://avatars.githubusercontent.com/u/597334?v=3","gravatar_id":"","url":"https://api.github.com/users/tiberius","html_url":"https://github.com/tiberius","followers_url":"https://api.github.com/users/tiberius/followers","following_url":"https://api.github.com/users/tiberius/following{/other_user}","gists_url":"https://api.github.com/users/tiberius/gists{/gist_id}","starred_url":"https://api.github.com/users/tiberius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiberius/subscriptions","organizations_url":"https://api.github.com/users/tiberius/orgs","repos_url":"https://api.github.com/users/tiberius/repos","events_url":"https://api.github.com/users/tiberius/events{/privacy}","received_events_url":"https://api.github.com/users/tiberius/received_events","type":"User","site_admin":false},"body":"I had problems when using django-request's graph functions in the admin overview because the scripts could not be loaded using the debug server (404 error); I created a simple patch that just makes use of django.contrib.staticfiles instead of using `{{ STATIC_URL }}` to retrieve the correct urls for the scripts. \r\n\r\nWithout this patch the following kind of urls where generated: `<script type=\"text/javascript\" src=\"request/js/jquery-1.4.2.min.js\"></script>`\r\n\r\nwhich are translated to `http://localhost:18000/admin/request/request/overview/request/js/jquery-1.4.2.min.js` by the browser, which resulted in the 404 error. it seems STATIC_URL is undefined in the template, but it's set in my settings.py: `STATIC_URL = '/static/'`\r\n\r\nUsing the applied patch urls of the following kind are generated:\r\n`<script type=\"text/javascript\" src=\"/static/request/js/jquery-1.4.2.min.js\"></script>` and translated to `http://localhost:18000/static/request/js/jquery-1.4.2.min.js`\r\n(Which is what probably was desired in the first place by using `{{ STATIC_URL }}`)\r\n\r\nin general it might be a good idea to use the staticfiles app instead of `{{ STATIC_URL }}`, but I haven't looked into the other files, to see if anything might break.\r\n\r\n\r\n","created_at":"2015-07-04T14:15:04Z","updated_at":"2015-07-04T14:15:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kylef/django-request/pulls/69/commits","review_comments_url":"https://api.github.com/repos/kylef/django-request/pulls/69/comments","review_comment_url":"https://api.github.com/repos/kylef/django-request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kylef/django-request/issues/69/comments","statuses_url":"https://api.github.com/repos/kylef/django-request/statuses/5f4ba5c6f178f3f7a6ab1b2e9494ae741efd30d6","head":{"label":"tiberius:master","ref":"master","sha":"5f4ba5c6f178f3f7a6ab1b2e9494ae741efd30d6","user":{"login":"tiberius","id":597334,"avatar_url":"https://avatars.githubusercontent.com/u/597334?v=3","gravatar_id":"","url":"https://api.github.com/users/tiberius","html_url":"https://github.com/tiberius","followers_url":"https://api.github.com/users/tiberius/followers","following_url":"https://api.github.com/users/tiberius/following{/other_user}","gists_url":"https://api.github.com/users/tiberius/gists{/gist_id}","starred_url":"https://api.github.com/users/tiberius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiberius/subscriptions","organizations_url":"https://api.github.com/users/tiberius/orgs","repos_url":"https://api.github.com/users/tiberius/repos","events_url":"https://api.github.com/users/tiberius/events{/privacy}","received_events_url":"https://api.github.com/users/tiberius/received_events","type":"User","site_admin":false},"repo":{"id":38535204,"name":"django-request","full_name":"tiberius/django-request","owner":{"login":"tiberius","id":597334,"avatar_url":"https://avatars.githubusercontent.com/u/597334?v=3","gravatar_id":"","url":"https://api.github.com/users/tiberius","html_url":"https://github.com/tiberius","followers_url":"https://api.github.com/users/tiberius/followers","following_url":"https://api.github.com/users/tiberius/following{/other_user}","gists_url":"https://api.github.com/users/tiberius/gists{/gist_id}","starred_url":"https://api.github.com/users/tiberius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiberius/subscriptions","organizations_url":"https://api.github.com/users/tiberius/orgs","repos_url":"https://api.github.com/users/tiberius/repos","events_url":"https://api.github.com/users/tiberius/events{/privacy}","received_events_url":"https://api.github.com/users/tiberius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiberius/django-request","description":"django-request is a statistics module for django. It stores requests in a database for admins to see, it can also be used to get statistics on who is online etc.","fork":true,"url":"https://api.github.com/repos/tiberius/django-request","forks_url":"https://api.github.com/repos/tiberius/django-request/forks","keys_url":"https://api.github.com/repos/tiberius/django-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiberius/django-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiberius/django-request/teams","hooks_url":"https://api.github.com/repos/tiberius/django-request/hooks","issue_events_url":"https://api.github.com/repos/tiberius/django-request/issues/events{/number}","events_url":"https://api.github.com/repos/tiberius/django-request/events","assignees_url":"https://api.github.com/repos/tiberius/django-request/assignees{/user}","branches_url":"https://api.github.com/repos/tiberius/django-request/branches{/branch}","tags_url":"https://api.github.com/repos/tiberius/django-request/tags","blobs_url":"https://api.github.com/repos/tiberius/django-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiberius/django-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiberius/django-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiberius/django-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiberius/django-request/statuses/{sha}","languages_url":"https://api.github.com/repos/tiberius/django-request/languages","stargazers_url":"https://api.github.com/repos/tiberius/django-request/stargazers","contributors_url":"https://api.github.com/repos/tiberius/django-request/contributors","subscribers_url":"https://api.github.com/repos/tiberius/django-request/subscribers","subscription_url":"https://api.github.com/repos/tiberius/django-request/subscription","commits_url":"https://api.github.com/repos/tiberius/django-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiberius/django-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiberius/django-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiberius/django-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiberius/django-request/contents/{+path}","compare_url":"https://api.github.com/repos/tiberius/django-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiberius/django-request/merges","archive_url":"https://api.github.com/repos/tiberius/django-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiberius/django-request/downloads","issues_url":"https://api.github.com/repos/tiberius/django-request/issues{/number}","pulls_url":"https://api.github.com/repos/tiberius/django-request/pulls{/number}","milestones_url":"https://api.github.com/repos/tiberius/django-request/milestones{/number}","notifications_url":"https://api.github.com/repos/tiberius/django-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiberius/django-request/labels{/name}","releases_url":"https://api.github.com/repos/tiberius/django-request/releases{/id}","created_at":"2015-07-04T13:45:08Z","updated_at":"2015-07-04T13:45:09Z","pushed_at":"2015-07-04T13:48:31Z","git_url":"git://github.com/tiberius/django-request.git","ssh_url":"git@github.com:tiberius/django-request.git","clone_url":"https://github.com/tiberius/django-request.git","svn_url":"https://github.com/tiberius/django-request","homepage":"https://django-request.readthedocs.org/en/latest/","size":811,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kylef:master","ref":"master","sha":"7b2d0fb68f025ef79c87c4cc1bb8ef77b876a024","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"repo":{"id":246591,"name":"django-request","full_name":"kylef/django-request","owner":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kylef/django-request","description":"django-request is a statistics module for django. It stores requests in a database for admins to see, it can also be used to get statistics on who is online etc.","fork":false,"url":"https://api.github.com/repos/kylef/django-request","forks_url":"https://api.github.com/repos/kylef/django-request/forks","keys_url":"https://api.github.com/repos/kylef/django-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kylef/django-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kylef/django-request/teams","hooks_url":"https://api.github.com/repos/kylef/django-request/hooks","issue_events_url":"https://api.github.com/repos/kylef/django-request/issues/events{/number}","events_url":"https://api.github.com/repos/kylef/django-request/events","assignees_url":"https://api.github.com/repos/kylef/django-request/assignees{/user}","branches_url":"https://api.github.com/repos/kylef/django-request/branches{/branch}","tags_url":"https://api.github.com/repos/kylef/django-request/tags","blobs_url":"https://api.github.com/repos/kylef/django-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kylef/django-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kylef/django-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/kylef/django-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kylef/django-request/statuses/{sha}","languages_url":"https://api.github.com/repos/kylef/django-request/languages","stargazers_url":"https://api.github.com/repos/kylef/django-request/stargazers","contributors_url":"https://api.github.com/repos/kylef/django-request/contributors","subscribers_url":"https://api.github.com/repos/kylef/django-request/subscribers","subscription_url":"https://api.github.com/repos/kylef/django-request/subscription","commits_url":"https://api.github.com/repos/kylef/django-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/kylef/django-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/kylef/django-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/kylef/django-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/kylef/django-request/contents/{+path}","compare_url":"https://api.github.com/repos/kylef/django-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kylef/django-request/merges","archive_url":"https://api.github.com/repos/kylef/django-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kylef/django-request/downloads","issues_url":"https://api.github.com/repos/kylef/django-request/issues{/number}","pulls_url":"https://api.github.com/repos/kylef/django-request/pulls{/number}","milestones_url":"https://api.github.com/repos/kylef/django-request/milestones{/number}","notifications_url":"https://api.github.com/repos/kylef/django-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kylef/django-request/labels{/name}","releases_url":"https://api.github.com/repos/kylef/django-request/releases{/id}","created_at":"2009-07-08T21:42:45Z","updated_at":"2015-06-01T11:14:28Z","pushed_at":"2015-05-28T18:41:43Z","git_url":"git://github.com/kylef/django-request.git","ssh_url":"git@github.com:kylef/django-request.git","clone_url":"https://github.com/kylef/django-request.git","svn_url":"https://github.com/kylef/django-request","homepage":"https://django-request.readthedocs.org/en/latest/","size":811,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":11,"forks":53,"open_issues":11,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kylef/django-request/pulls/69"},"html":{"href":"https://github.com/kylef/django-request/pull/69"},"issue":{"href":"https://api.github.com/repos/kylef/django-request/issues/69"},"comments":{"href":"https://api.github.com/repos/kylef/django-request/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/kylef/django-request/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/kylef/django-request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kylef/django-request/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/kylef/django-request/statuses/5f4ba5c6f178f3f7a6ab1b2e9494ae741efd30d6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":5,"changed_files":1}}