{"action":"created","comment":{"url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/comments/41393767","id":41393767,"diff_hunk":"@@ -46,6 +47,27 @@ char *escape_shell_string(const char *str)\n \treturn escaped_string;\n }\n \n+char *string_escape_shell( const char *str )\n+{\n+\tbuffer_t buffer;\n+\tbuffer_init(&buffer);","path":"dttools/src/stringtools.c","position":15,"original_position":15,"commit_id":"e7606a26156c1d2c912b6a8d5711a71bf5ac683c","original_commit_id":"e7606a26156c1d2c912b6a8d5711a71bf5ac683c","user":{"login":"batrick","id":548304,"avatar_url":"https://avatars.githubusercontent.com/u/548304?v=3","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false},"body":"I'm guessing you also want `bufer_abortonfailure` since you're not checking for (memory) errors when using the buffer.","created_at":"2015-10-07T14:05:01Z","updated_at":"2015-10-07T14:05:01Z","html_url":"https://github.com/cooperative-computing-lab/cctools/pull/954#discussion_r41393767","pull_request_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954","_links":{"self":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/comments/41393767"},"html":{"href":"https://github.com/cooperative-computing-lab/cctools/pull/954#discussion_r41393767"},"pull_request":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954"}}},"pull_request":{"url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954","id":47028732,"html_url":"https://github.com/cooperative-computing-lab/cctools/pull/954","diff_url":"https://github.com/cooperative-computing-lab/cctools/pull/954.diff","patch_url":"https://github.com/cooperative-computing-lab/cctools/pull/954.patch","issue_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/954","number":954,"state":"open","locked":false,"title":"Shell escape","user":{"login":"nhazekam","id":5231159,"avatar_url":"https://avatars.githubusercontent.com/u/5231159?v=3","gravatar_id":"","url":"https://api.github.com/users/nhazekam","html_url":"https://github.com/nhazekam","followers_url":"https://api.github.com/users/nhazekam/followers","following_url":"https://api.github.com/users/nhazekam/following{/other_user}","gists_url":"https://api.github.com/users/nhazekam/gists{/gist_id}","starred_url":"https://api.github.com/users/nhazekam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhazekam/subscriptions","organizations_url":"https://api.github.com/users/nhazekam/orgs","repos_url":"https://api.github.com/users/nhazekam/repos","events_url":"https://api.github.com/users/nhazekam/events{/privacy}","received_events_url":"https://api.github.com/users/nhazekam/received_events","type":"User","site_admin":false},"body":"@btovar Take a look. Slightly confusing, but there was an older escape_shell_string that I am told is used for hadoop. Naming changes and whatnot can be addressed as needed just wanted to get this to you.","created_at":"2015-10-07T13:45:37Z","updated_at":"2015-10-07T14:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78ff434a2887752f49ab9044c3695e1a467b20b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954/commits","review_comments_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954/comments","review_comment_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/954/comments","statuses_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/statuses/e7606a26156c1d2c912b6a8d5711a71bf5ac683c","head":{"label":"nhazekam:shell_escape","ref":"shell_escape","sha":"e7606a26156c1d2c912b6a8d5711a71bf5ac683c","user":{"login":"nhazekam","id":5231159,"avatar_url":"https://avatars.githubusercontent.com/u/5231159?v=3","gravatar_id":"","url":"https://api.github.com/users/nhazekam","html_url":"https://github.com/nhazekam","followers_url":"https://api.github.com/users/nhazekam/followers","following_url":"https://api.github.com/users/nhazekam/following{/other_user}","gists_url":"https://api.github.com/users/nhazekam/gists{/gist_id}","starred_url":"https://api.github.com/users/nhazekam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhazekam/subscriptions","organizations_url":"https://api.github.com/users/nhazekam/orgs","repos_url":"https://api.github.com/users/nhazekam/repos","events_url":"https://api.github.com/users/nhazekam/events{/privacy}","received_events_url":"https://api.github.com/users/nhazekam/received_events","type":"User","site_admin":false},"repo":{"id":13475227,"name":"cctools","full_name":"nhazekam/cctools","owner":{"login":"nhazekam","id":5231159,"avatar_url":"https://avatars.githubusercontent.com/u/5231159?v=3","gravatar_id":"","url":"https://api.github.com/users/nhazekam","html_url":"https://github.com/nhazekam","followers_url":"https://api.github.com/users/nhazekam/followers","following_url":"https://api.github.com/users/nhazekam/following{/other_user}","gists_url":"https://api.github.com/users/nhazekam/gists{/gist_id}","starred_url":"https://api.github.com/users/nhazekam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhazekam/subscriptions","organizations_url":"https://api.github.com/users/nhazekam/orgs","repos_url":"https://api.github.com/users/nhazekam/repos","events_url":"https://api.github.com/users/nhazekam/events{/privacy}","received_events_url":"https://api.github.com/users/nhazekam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhazekam/cctools","description":"The Cooperative Computing Tools (cctools) enable large scale distributed computations to harness hundreds to thousands of machines from clusters, clouds, and grids.","fork":true,"url":"https://api.github.com/repos/nhazekam/cctools","forks_url":"https://api.github.com/repos/nhazekam/cctools/forks","keys_url":"https://api.github.com/repos/nhazekam/cctools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhazekam/cctools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhazekam/cctools/teams","hooks_url":"https://api.github.com/repos/nhazekam/cctools/hooks","issue_events_url":"https://api.github.com/repos/nhazekam/cctools/issues/events{/number}","events_url":"https://api.github.com/repos/nhazekam/cctools/events","assignees_url":"https://api.github.com/repos/nhazekam/cctools/assignees{/user}","branches_url":"https://api.github.com/repos/nhazekam/cctools/branches{/branch}","tags_url":"https://api.github.com/repos/nhazekam/cctools/tags","blobs_url":"https://api.github.com/repos/nhazekam/cctools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhazekam/cctools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhazekam/cctools/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhazekam/cctools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhazekam/cctools/statuses/{sha}","languages_url":"https://api.github.com/repos/nhazekam/cctools/languages","stargazers_url":"https://api.github.com/repos/nhazekam/cctools/stargazers","contributors_url":"https://api.github.com/repos/nhazekam/cctools/contributors","subscribers_url":"https://api.github.com/repos/nhazekam/cctools/subscribers","subscription_url":"https://api.github.com/repos/nhazekam/cctools/subscription","commits_url":"https://api.github.com/repos/nhazekam/cctools/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhazekam/cctools/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhazekam/cctools/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhazekam/cctools/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhazekam/cctools/contents/{+path}","compare_url":"https://api.github.com/repos/nhazekam/cctools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhazekam/cctools/merges","archive_url":"https://api.github.com/repos/nhazekam/cctools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhazekam/cctools/downloads","issues_url":"https://api.github.com/repos/nhazekam/cctools/issues{/number}","pulls_url":"https://api.github.com/repos/nhazekam/cctools/pulls{/number}","milestones_url":"https://api.github.com/repos/nhazekam/cctools/milestones{/number}","notifications_url":"https://api.github.com/repos/nhazekam/cctools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhazekam/cctools/labels{/name}","releases_url":"https://api.github.com/repos/nhazekam/cctools/releases{/id}","created_at":"2013-10-10T15:27:16Z","updated_at":"2015-05-04T13:32:33Z","pushed_at":"2015-10-07T13:59:40Z","git_url":"git://github.com/nhazekam/cctools.git","ssh_url":"git@github.com:nhazekam/cctools.git","clone_url":"https://github.com/nhazekam/cctools.git","svn_url":"https://github.com/nhazekam/cctools","homepage":"http://www.nd.edu/~ccl/","size":74344,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cooperative-computing-lab:master","ref":"master","sha":"c056549bd681379fc45026ae83d81f862a23a4d2","user":{"login":"cooperative-computing-lab","id":2520573,"avatar_url":"https://avatars.githubusercontent.com/u/2520573?v=3","gravatar_id":"","url":"https://api.github.com/users/cooperative-computing-lab","html_url":"https://github.com/cooperative-computing-lab","followers_url":"https://api.github.com/users/cooperative-computing-lab/followers","following_url":"https://api.github.com/users/cooperative-computing-lab/following{/other_user}","gists_url":"https://api.github.com/users/cooperative-computing-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/cooperative-computing-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooperative-computing-lab/subscriptions","organizations_url":"https://api.github.com/users/cooperative-computing-lab/orgs","repos_url":"https://api.github.com/users/cooperative-computing-lab/repos","events_url":"https://api.github.com/users/cooperative-computing-lab/events{/privacy}","received_events_url":"https://api.github.com/users/cooperative-computing-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":8759937,"name":"cctools","full_name":"cooperative-computing-lab/cctools","owner":{"login":"cooperative-computing-lab","id":2520573,"avatar_url":"https://avatars.githubusercontent.com/u/2520573?v=3","gravatar_id":"","url":"https://api.github.com/users/cooperative-computing-lab","html_url":"https://github.com/cooperative-computing-lab","followers_url":"https://api.github.com/users/cooperative-computing-lab/followers","following_url":"https://api.github.com/users/cooperative-computing-lab/following{/other_user}","gists_url":"https://api.github.com/users/cooperative-computing-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/cooperative-computing-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooperative-computing-lab/subscriptions","organizations_url":"https://api.github.com/users/cooperative-computing-lab/orgs","repos_url":"https://api.github.com/users/cooperative-computing-lab/repos","events_url":"https://api.github.com/users/cooperative-computing-lab/events{/privacy}","received_events_url":"https://api.github.com/users/cooperative-computing-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cooperative-computing-lab/cctools","description":"The Cooperative Computing Tools (cctools) enable large scale distributed computations to harness hundreds to thousands of machines from clusters, clouds, and grids.","fork":false,"url":"https://api.github.com/repos/cooperative-computing-lab/cctools","forks_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/forks","keys_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/teams","hooks_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/hooks","issue_events_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/events{/number}","events_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/events","assignees_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/assignees{/user}","branches_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/branches{/branch}","tags_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/tags","blobs_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/git/refs{/sha}","trees_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/statuses/{sha}","languages_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/languages","stargazers_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/stargazers","contributors_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/contributors","subscribers_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/subscribers","subscription_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/subscription","commits_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/commits{/sha}","git_commits_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/git/commits{/sha}","comments_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/comments{/number}","issue_comment_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/comments{/number}","contents_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/contents/{+path}","compare_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/merges","archive_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/downloads","issues_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues{/number}","pulls_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls{/number}","milestones_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/milestones{/number}","notifications_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/labels{/name}","releases_url":"https://api.github.com/repos/cooperative-computing-lab/cctools/releases{/id}","created_at":"2013-03-13T19:39:45Z","updated_at":"2015-09-25T13:59:03Z","pushed_at":"2015-10-07T13:59:40Z","git_url":"git://github.com/cooperative-computing-lab/cctools.git","ssh_url":"git@github.com:cooperative-computing-lab/cctools.git","clone_url":"https://github.com/cooperative-computing-lab/cctools.git","svn_url":"https://github.com/cooperative-computing-lab/cctools","homepage":"http://ccl.cse.nd.edu","size":89950,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":54,"forks":50,"open_issues":54,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954"},"html":{"href":"https://github.com/cooperative-computing-lab/cctools/pull/954"},"issue":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/954"},"comments":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/issues/954/comments"},"review_comments":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954/comments"},"review_comment":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/pulls/954/commits"},"statuses":{"href":"https://api.github.com/repos/cooperative-computing-lab/cctools/statuses/e7606a26156c1d2c912b6a8d5711a71bf5ac683c"}}}}