{"action":"created","issue":{"url":"https://api.github.com/repos/ninenines/erlang.mk/issues/411","labels_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/411/labels{/name}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/411/comments","events_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/411/events","html_url":"https://github.com/ninenines/erlang.mk/pull/411","id":113369807,"number":411,"title":"deps.mk: In dep_target, call dep_autopatch during the second eval","user":{"login":"dumbbell","id":159804,"avatar_url":"https://avatars.githubusercontent.com/u/159804?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbbell","html_url":"https://github.com/dumbbell","followers_url":"https://api.github.com/users/dumbbell/followers","following_url":"https://api.github.com/users/dumbbell/following{/other_user}","gists_url":"https://api.github.com/users/dumbbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbbell/subscriptions","organizations_url":"https://api.github.com/users/dumbbell/orgs","repos_url":"https://api.github.com/users/dumbbell/repos","events_url":"https://api.github.com/users/dumbbell/events{/privacy}","received_events_url":"https://api.github.com/users/dumbbell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-26T14:35:37Z","updated_at":"2015-11-09T16:27:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/411","html_url":"https://github.com/ninenines/erlang.mk/pull/411","diff_url":"https://github.com/ninenines/erlang.mk/pull/411.diff","patch_url":"https://github.com/ninenines/erlang.mk/pull/411.patch"},"body":"... not the first.\r\n\r\n`dep_autopatch` can be an expensive macro, in particular because it executes Erlang. So if `NO_AUTOPATCH` is set, it's best to avoid calling `dep_autopatch` as the result will be unused anyway."},"comment":{"url":"https://api.github.com/repos/ninenines/erlang.mk/issues/comments/155114330","html_url":"https://github.com/ninenines/erlang.mk/pull/411#issuecomment-155114330","issue_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/411","id":155114330,"user":{"login":"ash-lshift","id":6576021,"avatar_url":"https://avatars.githubusercontent.com/u/6576021?v=3","gravatar_id":"","url":"https://api.github.com/users/ash-lshift","html_url":"https://github.com/ash-lshift","followers_url":"https://api.github.com/users/ash-lshift/followers","following_url":"https://api.github.com/users/ash-lshift/following{/other_user}","gists_url":"https://api.github.com/users/ash-lshift/gists{/gist_id}","starred_url":"https://api.github.com/users/ash-lshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash-lshift/subscriptions","organizations_url":"https://api.github.com/users/ash-lshift/orgs","repos_url":"https://api.github.com/users/ash-lshift/repos","events_url":"https://api.github.com/users/ash-lshift/events{/privacy}","received_events_url":"https://api.github.com/users/ash-lshift/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T16:27:45Z","updated_at":"2015-11-09T16:27:45Z","body":"This breaks the `dep_autopatch_rebar.erl` target of `erlang.mk`.\r\nTo reproduce the problem, depend on a package which uses rebar and `port_specs`, eg https://github.com/vinoski/erlsha2 or https://github.com/davisp/jiffy, then run `make deps` and you will find that it fails because the auto-patching has corrupted `deps/$DEP/Makefile` by writing apparently random numbers into it.\r\nThe string `$$$$` appears several times in `dep_autopatch_rebar.erl` and I think this patch causes `$$$$` to be interpolated into a PID."}}