{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/667","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/667/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/667/events","html_url":"https://github.com/dotnet/coreclr/issues/667","id":67179982,"number":667,"title":"PAL: symbol timezone redefined in time.cpp on FreeBSD","user":{"login":"josteink","id":411338,"avatar_url":"https://avatars.githubusercontent.com/u/411338?v=3","gravatar_id":"","url":"https://api.github.com/users/josteink","html_url":"https://github.com/josteink","followers_url":"https://api.github.com/users/josteink/followers","following_url":"https://api.github.com/users/josteink/following{/other_user}","gists_url":"https://api.github.com/users/josteink/gists{/gist_id}","starred_url":"https://api.github.com/users/josteink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josteink/subscriptions","organizations_url":"https://api.github.com/users/josteink/orgs","repos_url":"https://api.github.com/users/josteink/repos","events_url":"https://api.github.com/users/josteink/events{/privacy}","received_events_url":"https://api.github.com/users/josteink/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/FreeBSD","name":"FreeBSD","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-08T17:33:39Z","updated_at":"2015-04-09T06:30:13Z","closed_at":null,"body":"This breaks the build. Output from `VERBOSE=1 ./build.sh`:\r\n\r\n````\r\ncd /home/josteink/build/cc/bin/obj/FreeBSD.x64.Debug/src/utilcode/staticnohost && /usr/local/bin/clang++35   -DAMD64 -DBETA=0 -DBIT64=1 -DBUILDENV_CHECKED=1 -DCONDITION_HANDLING=1 -DDBG_TARGET_AMD64 -DDBG_TARGET_AMD64_UNIX -DDEBUG -DDEBUGGING_SUPPORTED -DDEV10 -DDEVL=1 -DDISABLE_CONTRACTS -DFEATURE_APPDOMAIN_RESOURCE_MONITORING -DFEATURE_ARRAYSTUB_AS_IL -DFEATURE_ASYNC_IO -DFEATURE_BCL_FORMATTING -DFEATURE_COLLECTIBLE_TYPES -DFEATURE_CORECLR -DFEATURE_COREFX_GLOBALIZATION -DFEATURE_CORESYSTEM -DFEATURE_CORRUPTING_EXCEPTIONS -DFEATURE_DBGIPC_TRANSPORT_DI -DFEATURE_DBGIPC_TRANSPORT_VM -DFEATURE_EXCEPTIONDISPATCHINFO -DFEATURE_FRAMEWORK_INTERNAL -DFEATURE_HOSTED_BINDER -DFEATURE_HOST_ASSEMBLY_RESOLVER -DFEATURE_ICASTABLE -DFEATURE_IMPLICIT_TLS -DFEATURE_ISYM_READER -DFEATURE_LEGACYNETCF -DFEATURE_LEGACYNETCFFAS -DFEATURE_LEGACYNETCF_DBG_HOST_CONTROL -DFEATURE_LOADER_OPTIMIZATION -DFEATURE_MAIN_CLR_MODULE_USES_CORE_NAME -DFEATURE_MANAGED_ETW -DFEATURE_MANAGED_ETW_CHANNELS -DFEATURE_MERGE_CULTURE_SUPPORT_AND_ENGINE -DFEATURE_MULTICOREJIT -DFEATURE_NORM_IDNA_ONLY -DFEATURE_PAL -DFEATURE_PAL_SXS -DFEATURE_PREJIT -DFEATURE_STANDALONE_SN -DFEATURE_STRONGNAME_DELAY_SIGNING_ALLOWED -DFEATURE_STRONGNAME_MIGRATION -DFEATURE_STUBS_AS_IL -DFEATURE_SVR_GC -DFEATURE_SYMDIFF -DFEATURE_SYNTHETIC_CULTURES -DFEATURE_USE_ASM_GC_WRITE_BARRIERS -DFEATURE_VERSIONING -DFEATURE_WIN32_REGISTRY -DFEATURE_WINDOWSPHONE -DFEATURE_WINMD_RESILIENT -DFX_BRANCH_SYNC_COUNTER_VALUE=0 -DNO_CRT -DNTDDI_VERSION=NTDDI_WIN8 -DNTMAKEENV -DNT_INST=0 -DOFFICIAL_BUILD=0 -DPLATFORM_UNIX=1 -DSELF_NO_HOST -DUNICODE -DUNIX_AMD64_ABI -DURTBLDENV_FRIENDLY=Checked -DWIN32 -DWIN32_LEAN_AND_MEAN=1 -DWINNT=1 -DWINVER=0x0602 -DWRITE_BARRIER_CHECK=1 -D_AMD64_ -D_AMD64_SIMULATOR_ -D_AMD64_SIMULATOR_PERF_ -D_AMD64_WORKAROUND_ -D_BLD_CLR -D_CRT_STDIO_ARBITRARY_WIDE_SPECIFIERS -D_DBG -D_DEBUG -D_NEW_SDK=1 -D_SECURE_SCL=0 -D_SKIP_IF_SIMULATOR_ -D_TARGET_AMD64_=1 -D_UNICODE -D_WIN32_IE=0x0900 -D_WIN32_WINNT=0x0602 -D_WIN64 -Wall -Wno-null-conversion -std=c++11 -nostdinc++ -g -O0 -I/home/josteink/build/cc/bin/obj/FreeBSD.x64.Debug/src/utilcode/staticnohost -I/home/josteink/build/cc/src/utilcode/staticnohost -I/home/josteink/build/cc/src/pal/prebuilt/inc -I/home/josteink/build/cc/src/pal/inc -I/home/josteink/build/cc/src/pal/inc/rt -I/home/josteink/build/cc/src/pal/src/safecrt -I/home/josteink/build/cc/src/inc -I/home/josteink/build/cc/src/strongname/inc -I/home/josteink/build/cc/src/inc/winrt -I/home/josteink/build/cc/src/debug/inc -I/home/josteink/build/cc/src/debug/inc/amd64 -I/home/josteink/build/cc/src/debug/inc/dump -I/home/josteink/build/cc/src/md/inc -I/home/josteink/build/cc/src/classlibnative/bcltype -I/home/josteink/build/cc/src/classlibnative/cryptography -I/home/josteink/build/cc/src/classlibnative/inc    -ferror-limit=4096 -Wno-unused-private-field -Wno-dangling-else -Wno-implicit-exception-spec-mismatch -Wno-overloaded-virtual -Wno-unused-variable -Wno-switch -Wno-microsoft -Wno-tautological-compare -Wno-constant-logical-operand -Wno-unknown-warning-option -Wno-invalid-offsetof -Wno-delete-non-virtual-dtor -Wno-incompatible-ms-struct -fms-extensions -nostdinc -fPIC -o CMakeFiles/utilcodestaticnohost.dir/__/stgpooli.cpp.o -c /home/josteink/build/cc/src/utilcode/stgpooli.cpp\r\n--- src/pal/src/CMakeFiles/CoreClrPal.dir/all ---\r\n/home/josteink/build/cc/src/pal/src/misc/time.cpp:164:21: error: redefinition of 'timezone' as different kind of symbol\r\n    extern long int timezone;\r\n                    ^\r\n/usr/include/time.h:193:7: note: previous definition is here\r\nchar *timezone(int, int);       /* XXX XSI conflict */\r\n      ^\r\n1 error generated.\r\n````\r\n\r\nNot sure what the best strategy here is... Renaming the symbol in `time.cpp`? To me, it seems like it's only used internally in `time.cpp` a very few places:\r\n\r\n````c++\r\n164:    extern long int timezone;\r\n211:    TRACE(\"timezone offset = %ld\\n\", (-timezone + (utPtr->tm_isdst ? 3600 : 0)) / 60);\r\n218:    lpTimeZoneInformation->Bias = (timezone - (utPtr->tm_isdst ? 3600 : 0)) / 60;\r\n````\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/91126854","html_url":"https://github.com/dotnet/coreclr/issues/667#issuecomment-91126854","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/667","id":91126854,"user":{"login":"ellismg","id":9602953,"avatar_url":"https://avatars.githubusercontent.com/u/9602953?v=3","gravatar_id":"","url":"https://api.github.com/users/ellismg","html_url":"https://github.com/ellismg","followers_url":"https://api.github.com/users/ellismg/followers","following_url":"https://api.github.com/users/ellismg/following{/other_user}","gists_url":"https://api.github.com/users/ellismg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellismg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellismg/subscriptions","organizations_url":"https://api.github.com/users/ellismg/orgs","repos_url":"https://api.github.com/users/ellismg/repos","events_url":"https://api.github.com/users/ellismg/events{/privacy}","received_events_url":"https://api.github.com/users/ellismg/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T06:30:13Z","updated_at":"2015-04-09T06:30:13Z","body":"Long term, I wonder if this code is needed anymore.  It looks like it might only be used by the tests.  I wonder if we can just remove it from the PAL.  I don't believe that managed code should need this anymore (we parse the TZInfo files directly now)."}}