{"action":"created","comment":{"url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments/31382534","id":31382534,"diff_hunk":"@@ -44,9 +44,22 @@ public HeaderType getHeaderType() {\n \t}\n \n \t@Override\n-\tpublic short readUntransparentColor(ByteReader reader)\n-\t\t\tthrows IOException {\n-\t\treturn (short) ((reader.read16() << 1) | 0x01);\n+\tpublic short readUntransparentColor(ByteReader reader) throws IOException {\n+\t\tint read = reader.read16();\n+\n+\t\tint R5 = (int)((read & 0xF800) >> 11);","path":"jsettlers.graphics/src/jsettlers/graphics/reader/translator/SettlerTranslator.java","position":null,"original_position":19,"commit_id":"aabfc02ce8cf5684a3e97eb05ac2bbb49f3fce4c","original_commit_id":"1a6d53c5b528273f3c0fd2f74058d19fbe420c24","user":{"login":"michaelzangl","id":5981823,"avatar_url":"https://avatars.githubusercontent.com/u/5981823?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelzangl","html_url":"https://github.com/michaelzangl","followers_url":"https://api.github.com/users/michaelzangl/followers","following_url":"https://api.github.com/users/michaelzangl/following{/other_user}","gists_url":"https://api.github.com/users/michaelzangl/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelzangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelzangl/subscriptions","organizations_url":"https://api.github.com/users/michaelzangl/orgs","repos_url":"https://api.github.com/users/michaelzangl/repos","events_url":"https://api.github.com/users/michaelzangl/events{/privacy}","received_events_url":"https://api.github.com/users/michaelzangl/received_events","type":"User","site_admin":false},"body":"Looks fine, although I prefer lower case variable names for non-constants ;-).\r\n\r\nI don't think that the ByteReader is the best place to put that. We could add it as a read-and-convert method. But the way it is now I would rather see it as a static method in one of the image-reading related classes, since the byte reader has nothing to do with the interpretation of images. You can also create a new class (ColorUtils, ...) or simply add it as static method to our Color-Class (which also does 16 Bit to 24 Bit conversion, ...)","created_at":"2015-05-30T17:08:00Z","updated_at":"2015-05-30T17:08:00Z","html_url":"https://github.com/jsettlers/settlers-remake/pull/91#discussion_r31382534","pull_request_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments/31382534"},"html":{"href":"https://github.com/jsettlers/settlers-remake/pull/91#discussion_r31382534"},"pull_request":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91","id":36566634,"html_url":"https://github.com/jsettlers/settlers-remake/pull/91","diff_url":"https://github.com/jsettlers/settlers-remake/pull/91.diff","patch_url":"https://github.com/jsettlers/settlers-remake/pull/91.patch","issue_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/91","number":91,"state":"open","locked":false,"title":"Support reading f8007e01f.dat files","user":{"login":"justangel","id":6223199,"avatar_url":"https://avatars.githubusercontent.com/u/6223199?v=3","gravatar_id":"","url":"https://api.github.com/users/justangel","html_url":"https://github.com/justangel","followers_url":"https://api.github.com/users/justangel/followers","following_url":"https://api.github.com/users/justangel/following{/other_user}","gists_url":"https://api.github.com/users/justangel/gists{/gist_id}","starred_url":"https://api.github.com/users/justangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justangel/subscriptions","organizations_url":"https://api.github.com/users/justangel/orgs","repos_url":"https://api.github.com/users/justangel/repos","events_url":"https://api.github.com/users/justangel/events{/privacy}","received_events_url":"https://api.github.com/users/justangel/received_events","type":"User","site_admin":false},"body":"I spent the time to research and implemented support for reading files \"f8007e01f\"\r\ntransmitting the data in the format of 5-5-5-1\r\n\r\nTODO:\r\nif not available 7c003e01f file, search and use f8007e01f or vice versa","created_at":"2015-05-30T14:50:06Z","updated_at":"2015-05-30T17:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16de53d3cbd3b7a7d5b8dbf8a78c32f224ef80e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91/commits","review_comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91/comments","review_comment_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/91/comments","statuses_url":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/aabfc02ce8cf5684a3e97eb05ac2bbb49f3fce4c","head":{"label":"justangel:support_reading_f8007e01f.dat_files","ref":"support_reading_f8007e01f.dat_files","sha":"aabfc02ce8cf5684a3e97eb05ac2bbb49f3fce4c","user":{"login":"justangel","id":6223199,"avatar_url":"https://avatars.githubusercontent.com/u/6223199?v=3","gravatar_id":"","url":"https://api.github.com/users/justangel","html_url":"https://github.com/justangel","followers_url":"https://api.github.com/users/justangel/followers","following_url":"https://api.github.com/users/justangel/following{/other_user}","gists_url":"https://api.github.com/users/justangel/gists{/gist_id}","starred_url":"https://api.github.com/users/justangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justangel/subscriptions","organizations_url":"https://api.github.com/users/justangel/orgs","repos_url":"https://api.github.com/users/justangel/repos","events_url":"https://api.github.com/users/justangel/events{/privacy}","received_events_url":"https://api.github.com/users/justangel/received_events","type":"User","site_admin":false},"repo":{"id":33525826,"name":"settlers-remake","full_name":"justangel/settlers-remake","owner":{"login":"justangel","id":6223199,"avatar_url":"https://avatars.githubusercontent.com/u/6223199?v=3","gravatar_id":"","url":"https://api.github.com/users/justangel","html_url":"https://github.com/justangel","followers_url":"https://api.github.com/users/justangel/followers","following_url":"https://api.github.com/users/justangel/following{/other_user}","gists_url":"https://api.github.com/users/justangel/gists{/gist_id}","starred_url":"https://api.github.com/users/justangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justangel/subscriptions","organizations_url":"https://api.github.com/users/justangel/orgs","repos_url":"https://api.github.com/users/justangel/repos","events_url":"https://api.github.com/users/justangel/events{/privacy}","received_events_url":"https://api.github.com/users/justangel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justangel/settlers-remake","description":"A Remake of \"The Settlers III\" for Windows, Linux, Mac and Android","fork":true,"url":"https://api.github.com/repos/justangel/settlers-remake","forks_url":"https://api.github.com/repos/justangel/settlers-remake/forks","keys_url":"https://api.github.com/repos/justangel/settlers-remake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justangel/settlers-remake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justangel/settlers-remake/teams","hooks_url":"https://api.github.com/repos/justangel/settlers-remake/hooks","issue_events_url":"https://api.github.com/repos/justangel/settlers-remake/issues/events{/number}","events_url":"https://api.github.com/repos/justangel/settlers-remake/events","assignees_url":"https://api.github.com/repos/justangel/settlers-remake/assignees{/user}","branches_url":"https://api.github.com/repos/justangel/settlers-remake/branches{/branch}","tags_url":"https://api.github.com/repos/justangel/settlers-remake/tags","blobs_url":"https://api.github.com/repos/justangel/settlers-remake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justangel/settlers-remake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justangel/settlers-remake/git/refs{/sha}","trees_url":"https://api.github.com/repos/justangel/settlers-remake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justangel/settlers-remake/statuses/{sha}","languages_url":"https://api.github.com/repos/justangel/settlers-remake/languages","stargazers_url":"https://api.github.com/repos/justangel/settlers-remake/stargazers","contributors_url":"https://api.github.com/repos/justangel/settlers-remake/contributors","subscribers_url":"https://api.github.com/repos/justangel/settlers-remake/subscribers","subscription_url":"https://api.github.com/repos/justangel/settlers-remake/subscription","commits_url":"https://api.github.com/repos/justangel/settlers-remake/commits{/sha}","git_commits_url":"https://api.github.com/repos/justangel/settlers-remake/git/commits{/sha}","comments_url":"https://api.github.com/repos/justangel/settlers-remake/comments{/number}","issue_comment_url":"https://api.github.com/repos/justangel/settlers-remake/issues/comments{/number}","contents_url":"https://api.github.com/repos/justangel/settlers-remake/contents/{+path}","compare_url":"https://api.github.com/repos/justangel/settlers-remake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justangel/settlers-remake/merges","archive_url":"https://api.github.com/repos/justangel/settlers-remake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justangel/settlers-remake/downloads","issues_url":"https://api.github.com/repos/justangel/settlers-remake/issues{/number}","pulls_url":"https://api.github.com/repos/justangel/settlers-remake/pulls{/number}","milestones_url":"https://api.github.com/repos/justangel/settlers-remake/milestones{/number}","notifications_url":"https://api.github.com/repos/justangel/settlers-remake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justangel/settlers-remake/labels{/name}","releases_url":"https://api.github.com/repos/justangel/settlers-remake/releases{/id}","created_at":"2015-04-07T06:19:20Z","updated_at":"2015-05-05T21:56:21Z","pushed_at":"2015-05-30T16:47:10Z","git_url":"git://github.com/justangel/settlers-remake.git","ssh_url":"git@github.com:justangel/settlers-remake.git","clone_url":"https://github.com/justangel/settlers-remake.git","svn_url":"https://github.com/justangel/settlers-remake","homepage":"http://www.settlers-android-clone.com","size":117856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsettlers:master","ref":"master","sha":"eee78ecb6d05221d00d1693701c1a0a7ab746f46","user":{"login":"jsettlers","id":10380489,"avatar_url":"https://avatars.githubusercontent.com/u/10380489?v=3","gravatar_id":"","url":"https://api.github.com/users/jsettlers","html_url":"https://github.com/jsettlers","followers_url":"https://api.github.com/users/jsettlers/followers","following_url":"https://api.github.com/users/jsettlers/following{/other_user}","gists_url":"https://api.github.com/users/jsettlers/gists{/gist_id}","starred_url":"https://api.github.com/users/jsettlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsettlers/subscriptions","organizations_url":"https://api.github.com/users/jsettlers/orgs","repos_url":"https://api.github.com/users/jsettlers/repos","events_url":"https://api.github.com/users/jsettlers/events{/privacy}","received_events_url":"https://api.github.com/users/jsettlers/received_events","type":"Organization","site_admin":false},"repo":{"id":25301488,"name":"settlers-remake","full_name":"jsettlers/settlers-remake","owner":{"login":"jsettlers","id":10380489,"avatar_url":"https://avatars.githubusercontent.com/u/10380489?v=3","gravatar_id":"","url":"https://api.github.com/users/jsettlers","html_url":"https://github.com/jsettlers","followers_url":"https://api.github.com/users/jsettlers/followers","following_url":"https://api.github.com/users/jsettlers/following{/other_user}","gists_url":"https://api.github.com/users/jsettlers/gists{/gist_id}","starred_url":"https://api.github.com/users/jsettlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsettlers/subscriptions","organizations_url":"https://api.github.com/users/jsettlers/orgs","repos_url":"https://api.github.com/users/jsettlers/repos","events_url":"https://api.github.com/users/jsettlers/events{/privacy}","received_events_url":"https://api.github.com/users/jsettlers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsettlers/settlers-remake","description":"A Remake of \"The Settlers III\" for Windows, Linux, Mac and Android","fork":false,"url":"https://api.github.com/repos/jsettlers/settlers-remake","forks_url":"https://api.github.com/repos/jsettlers/settlers-remake/forks","keys_url":"https://api.github.com/repos/jsettlers/settlers-remake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsettlers/settlers-remake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsettlers/settlers-remake/teams","hooks_url":"https://api.github.com/repos/jsettlers/settlers-remake/hooks","issue_events_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/events{/number}","events_url":"https://api.github.com/repos/jsettlers/settlers-remake/events","assignees_url":"https://api.github.com/repos/jsettlers/settlers-remake/assignees{/user}","branches_url":"https://api.github.com/repos/jsettlers/settlers-remake/branches{/branch}","tags_url":"https://api.github.com/repos/jsettlers/settlers-remake/tags","blobs_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/{sha}","languages_url":"https://api.github.com/repos/jsettlers/settlers-remake/languages","stargazers_url":"https://api.github.com/repos/jsettlers/settlers-remake/stargazers","contributors_url":"https://api.github.com/repos/jsettlers/settlers-remake/contributors","subscribers_url":"https://api.github.com/repos/jsettlers/settlers-remake/subscribers","subscription_url":"https://api.github.com/repos/jsettlers/settlers-remake/subscription","commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsettlers/settlers-remake/contents/{+path}","compare_url":"https://api.github.com/repos/jsettlers/settlers-remake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsettlers/settlers-remake/merges","archive_url":"https://api.github.com/repos/jsettlers/settlers-remake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsettlers/settlers-remake/downloads","issues_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues{/number}","pulls_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls{/number}","milestones_url":"https://api.github.com/repos/jsettlers/settlers-remake/milestones{/number}","notifications_url":"https://api.github.com/repos/jsettlers/settlers-remake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsettlers/settlers-remake/labels{/name}","releases_url":"https://api.github.com/repos/jsettlers/settlers-remake/releases{/id}","created_at":"2014-10-16T12:41:40Z","updated_at":"2015-05-24T15:21:54Z","pushed_at":"2015-05-30T16:47:10Z","git_url":"git://github.com/jsettlers/settlers-remake.git","ssh_url":"git@github.com:jsettlers/settlers-remake.git","clone_url":"https://github.com/jsettlers/settlers-remake.git","svn_url":"https://github.com/jsettlers/settlers-remake","homepage":"http://www.settlers-android-clone.com","size":130439,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":23,"forks":14,"open_issues":23,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91"},"html":{"href":"https://github.com/jsettlers/settlers-remake/pull/91"},"issue":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/issues/91"},"comments":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/aabfc02ce8cf5684a3e97eb05ac2bbb49f3fce4c"}}}}