{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments/39688660","id":39688660,"diff_hunk":"@@ -368,6 +368,11 @@\n \n           newVisibleRows = grid.getVisibleRowCount();\n \n+          var canvasHeight = rowHeight * newVisibleRows;\n+          if (grid.infiniteScroll.scrollDown && (viewportHeight > canvasHeight)) {\n+            grid.api.infiniteScroll.raise.needLoadMoreData();\n+          }\n+","path":"src/features/infinite-scroll/js/infinite-scroll.js","position":8,"original_position":8,"commit_id":"341a561e0d317b87ed9546f97dcc7626b866c631","original_commit_id":"341a561e0d317b87ed9546f97dcc7626b866c631","user":{"login":"JLLeitschuh","id":1323708,"avatar_url":"https://avatars.githubusercontent.com/u/1323708?v=3","gravatar_id":"","url":"https://api.github.com/users/JLLeitschuh","html_url":"https://github.com/JLLeitschuh","followers_url":"https://api.github.com/users/JLLeitschuh/followers","following_url":"https://api.github.com/users/JLLeitschuh/following{/other_user}","gists_url":"https://api.github.com/users/JLLeitschuh/gists{/gist_id}","starred_url":"https://api.github.com/users/JLLeitschuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLLeitschuh/subscriptions","organizations_url":"https://api.github.com/users/JLLeitschuh/orgs","repos_url":"https://api.github.com/users/JLLeitschuh/repos","events_url":"https://api.github.com/users/JLLeitschuh/events{/privacy}","received_events_url":"https://api.github.com/users/JLLeitschuh/received_events","type":"User","site_admin":false},"body":"Can you add a comment explicitly describing what is going on here and why. Without the context of the commit message future developers will have no idea why this chunk of code is here.","created_at":"2015-09-16T21:37:37Z","updated_at":"2015-09-16T21:37:37Z","html_url":"https://github.com/angular-ui/ui-grid/pull/4365#discussion_r39688660","pull_request_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments/39688660"},"html":{"href":"https://github.com/angular-ui/ui-grid/pull/4365#discussion_r39688660"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365","id":44992755,"html_url":"https://github.com/angular-ui/ui-grid/pull/4365","diff_url":"https://github.com/angular-ui/ui-grid/pull/4365.diff","patch_url":"https://github.com/angular-ui/ui-grid/pull/4365.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/4365","number":4365,"state":"open","locked":false,"title":"fix(infinite-scroll): load more data if needed","user":{"login":"DmitryEfimenko","id":2098175,"avatar_url":"https://avatars.githubusercontent.com/u/2098175?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryEfimenko","html_url":"https://github.com/DmitryEfimenko","followers_url":"https://api.github.com/users/DmitryEfimenko/followers","following_url":"https://api.github.com/users/DmitryEfimenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryEfimenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryEfimenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryEfimenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryEfimenko/orgs","repos_url":"https://api.github.com/users/DmitryEfimenko/repos","events_url":"https://api.github.com/users/DmitryEfimenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryEfimenko/received_events","type":"User","site_admin":false},"body":"detect if more data needs to be loaded after the initial load. Before if\r\nnot enough data was loaded to enable scrolling, no more data would be\r\nloaded. Resolves issue [4363](https://github.com/angular-ui/ui-grid/issues/4363)","created_at":"2015-09-14T23:18:14Z","updated_at":"2015-09-16T21:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4cd2ad5e9ff6e28f2c714296eb0793579e2611","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/4365/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/341a561e0d317b87ed9546f97dcc7626b866c631","head":{"label":"DmitryEfimenko:infinite-scroll-bug-fix","ref":"infinite-scroll-bug-fix","sha":"341a561e0d317b87ed9546f97dcc7626b866c631","user":{"login":"DmitryEfimenko","id":2098175,"avatar_url":"https://avatars.githubusercontent.com/u/2098175?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryEfimenko","html_url":"https://github.com/DmitryEfimenko","followers_url":"https://api.github.com/users/DmitryEfimenko/followers","following_url":"https://api.github.com/users/DmitryEfimenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryEfimenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryEfimenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryEfimenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryEfimenko/orgs","repos_url":"https://api.github.com/users/DmitryEfimenko/repos","events_url":"https://api.github.com/users/DmitryEfimenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryEfimenko/received_events","type":"User","site_admin":false},"repo":{"id":42481417,"name":"ui-grid","full_name":"DmitryEfimenko/ui-grid","owner":{"login":"DmitryEfimenko","id":2098175,"avatar_url":"https://avatars.githubusercontent.com/u/2098175?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryEfimenko","html_url":"https://github.com/DmitryEfimenko","followers_url":"https://api.github.com/users/DmitryEfimenko/followers","following_url":"https://api.github.com/users/DmitryEfimenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryEfimenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryEfimenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryEfimenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryEfimenko/orgs","repos_url":"https://api.github.com/users/DmitryEfimenko/repos","events_url":"https://api.github.com/users/DmitryEfimenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryEfimenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DmitryEfimenko/ui-grid","description":"UI Grid: an Angular Data Grid","fork":true,"url":"https://api.github.com/repos/DmitryEfimenko/ui-grid","forks_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/forks","keys_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/teams","hooks_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/events","assignees_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/tags","blobs_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/languages","stargazers_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/subscription","commits_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/merges","archive_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/downloads","issues_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/DmitryEfimenko/ui-grid/releases{/id}","created_at":"2015-09-14T22:49:26Z","updated_at":"2015-09-14T22:49:28Z","pushed_at":"2015-09-14T23:29:10Z","git_url":"git://github.com/DmitryEfimenko/ui-grid.git","ssh_url":"git@github.com:DmitryEfimenko/ui-grid.git","clone_url":"https://github.com/DmitryEfimenko/ui-grid.git","svn_url":"https://github.com/DmitryEfimenko/ui-grid","homepage":"http://ui-grid.info","size":28819,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"f1370227b7b9428ecb2e888ab87afb53dc0bf261","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6198699,"name":"ui-grid","full_name":"angular-ui/ui-grid","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-grid","description":"UI Grid: an Angular Data Grid","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-grid","forks_url":"https://api.github.com/repos/angular-ui/ui-grid/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-grid/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-grid/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-grid/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-grid/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-grid/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-grid/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-grid/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-grid/releases{/id}","created_at":"2012-10-13T01:39:25Z","updated_at":"2015-09-16T20:35:33Z","pushed_at":"2015-09-16T20:09:42Z","git_url":"git://github.com/angular-ui/ui-grid.git","ssh_url":"git@github.com:angular-ui/ui-grid.git","clone_url":"https://github.com/angular-ui/ui-grid.git","svn_url":"https://github.com/angular-ui/ui-grid","homepage":"http://ui-grid.info","size":28819,"stargazers_count":3178,"watchers_count":3178,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1574,"mirror_url":null,"open_issues_count":721,"forks":1574,"open_issues":721,"watchers":3178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365"},"html":{"href":"https://github.com/angular-ui/ui-grid/pull/4365"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/4365"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/4365/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4365/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-grid/statuses/341a561e0d317b87ed9546f97dcc7626b866c631"}}}}