{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/26324265","id":26324265,"diff_hunk":"@@ -326,6 +326,14 @@ func (container *Container) Start() (err error) {\n \t\treturn nil\n \t}\n \n+\tif container.RemovalInProgress {\n+\t\treturn fmt.Errorf(\"Container is already being removed. Can not start it.\")\n+\t}\n+\n+\tif container.Dead {\n+\t\treturn fmt.Errorf(\"Container is already dead. Can not start it.\")","path":"daemon/container.go","position":9,"original_position":9,"commit_id":"db8281a9b0f69601ab4f7ecb5d3c8103def9995e","original_commit_id":"db8281a9b0f69601ab4f7ecb5d3c8103def9995e","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Would zombie clear it up  :^)","created_at":"2015-03-12T17:27:57Z","updated_at":"2015-03-12T17:27:57Z","html_url":"https://github.com/docker/docker/pull/11137#discussion_r26324265","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11137","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/26324265"},"html":{"href":"https://github.com/docker/docker/pull/11137#discussion_r26324265"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11137"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11137","id":30405232,"html_url":"https://github.com/docker/docker/pull/11137","diff_url":"https://github.com/docker/docker/pull/11137.diff","patch_url":"https://github.com/docker/docker/pull/11137.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11137","number":11137,"state":"open","locked":false,"title":"Do not remove container if underlying resource cleanup failed","user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"body":"This should fix issue #10955 and #6746 \r\n\r\nThis patch series does two things. First of all it does not remove container from a user's view if container removal failed. Secondly, it extends force option (-f) to forcibly remove the container even if resource cleanup failed. That way those user who are willing to let resources leak, can use --force.\r\n\r\n","created_at":"2015-03-03T19:39:36Z","updated_at":"2015-03-12T17:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac97e72e902e5dcd3fa332ddd41c4bbf6a8f5d2b","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/37","html_url":"https://github.com/docker/docker/milestones/1.6.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/37/labels","id":952335,"number":37,"title":"1.6.0","description":"","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":13,"state":"open","created_at":"2015-01-26T23:40:13Z","updated_at":"2015-03-11T20:44:13Z","due_on":"2015-03-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/11137/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11137/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11137/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/db8281a9b0f69601ab4f7ecb5d3c8103def9995e","head":{"label":"rhvgoyal:fix-removal","ref":"fix-removal","sha":"db8281a9b0f69601ab4f7ecb5d3c8103def9995e","user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"repo":{"id":26138734,"name":"docker","full_name":"rhvgoyal/docker","owner":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhvgoyal/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/rhvgoyal/docker","forks_url":"https://api.github.com/repos/rhvgoyal/docker/forks","keys_url":"https://api.github.com/repos/rhvgoyal/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhvgoyal/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhvgoyal/docker/teams","hooks_url":"https://api.github.com/repos/rhvgoyal/docker/hooks","issue_events_url":"https://api.github.com/repos/rhvgoyal/docker/issues/events{/number}","events_url":"https://api.github.com/repos/rhvgoyal/docker/events","assignees_url":"https://api.github.com/repos/rhvgoyal/docker/assignees{/user}","branches_url":"https://api.github.com/repos/rhvgoyal/docker/branches{/branch}","tags_url":"https://api.github.com/repos/rhvgoyal/docker/tags","blobs_url":"https://api.github.com/repos/rhvgoyal/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhvgoyal/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhvgoyal/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhvgoyal/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhvgoyal/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/rhvgoyal/docker/languages","stargazers_url":"https://api.github.com/repos/rhvgoyal/docker/stargazers","contributors_url":"https://api.github.com/repos/rhvgoyal/docker/contributors","subscribers_url":"https://api.github.com/repos/rhvgoyal/docker/subscribers","subscription_url":"https://api.github.com/repos/rhvgoyal/docker/subscription","commits_url":"https://api.github.com/repos/rhvgoyal/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhvgoyal/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhvgoyal/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhvgoyal/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhvgoyal/docker/contents/{+path}","compare_url":"https://api.github.com/repos/rhvgoyal/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhvgoyal/docker/merges","archive_url":"https://api.github.com/repos/rhvgoyal/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhvgoyal/docker/downloads","issues_url":"https://api.github.com/repos/rhvgoyal/docker/issues{/number}","pulls_url":"https://api.github.com/repos/rhvgoyal/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/rhvgoyal/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/rhvgoyal/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhvgoyal/docker/labels{/name}","releases_url":"https://api.github.com/repos/rhvgoyal/docker/releases{/id}","created_at":"2014-11-03T21:06:15Z","updated_at":"2015-03-03T19:27:31Z","pushed_at":"2015-03-12T14:29:09Z","git_url":"git://github.com/rhvgoyal/docker.git","ssh_url":"git@github.com:rhvgoyal/docker.git","clone_url":"https://github.com/rhvgoyal/docker.git","svn_url":"https://github.com/rhvgoyal/docker","homepage":"http://www.docker.com","size":42126,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"5d174e000f9e0d0d4d557367ab7685834d190a71","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-03-12T16:02:34Z","pushed_at":"2015-03-12T14:30:56Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":152708,"stargazers_count":19775,"watchers_count":19775,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4117,"mirror_url":null,"open_issues_count":821,"forks":4117,"open_issues":821,"watchers":19775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11137"},"html":{"href":"https://github.com/docker/docker/pull/11137"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11137"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11137/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11137/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11137/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/db8281a9b0f69601ab4f7ecb5d3c8103def9995e"}}}}