{"action":"created","comment":{"url":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/26175781","id":26175781,"diff_hunk":"@@ -597,27 +622,43 @@ private static void GenerateApplicationHostXdt(string installationDirectory, str\n                 throw new DirectoryNotFoundException(installationDirectory);\n             }\n \n-            var externalCommandFactory = new ExternalCommandFactory(_environment, _settings, installationDirectory);\n+            JsonSettings siteExtensionSettings = GetSettingManager(id);\n+            string packageTypeStr = siteExtensionSettings.GetValue(_packageType);\n+            SiteExtensionInfo.SiteExtensionType packageType;\n+            if (Enum.TryParse<SiteExtensionInfo.SiteExtensionType>(packageTypeStr, out packageType)","path":"Kudu.Core/SiteExtensions/SiteExtensionManager.cs","position":166,"original_position":166,"commit_id":"e3819900b22689404e32932832172b9cce60ba67","original_commit_id":"e3819900b22689404e32932832172b9cce60ba67","user":{"login":"shrimpy","id":79823,"avatar_url":"https://avatars.githubusercontent.com/u/79823?v=3","gravatar_id":"","url":"https://api.github.com/users/shrimpy","html_url":"https://github.com/shrimpy","followers_url":"https://api.github.com/users/shrimpy/followers","following_url":"https://api.github.com/users/shrimpy/following{/other_user}","gists_url":"https://api.github.com/users/shrimpy/gists{/gist_id}","starred_url":"https://api.github.com/users/shrimpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrimpy/subscriptions","organizations_url":"https://api.github.com/users/shrimpy/orgs","repos_url":"https://api.github.com/users/shrimpy/repos","events_url":"https://api.github.com/users/shrimpy/events{/privacy}","received_events_url":"https://api.github.com/users/shrimpy/received_events","type":"User","site_admin":false},"body":"sure.. let me update it.","created_at":"2015-03-10T23:08:23Z","updated_at":"2015-03-10T23:08:23Z","html_url":"https://github.com/projectkudu/kudu/pull/1489#discussion_r26175781","pull_request_url":"https://api.github.com/repos/projectkudu/kudu/pulls/1489","_links":{"self":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/26175781"},"html":{"href":"https://github.com/projectkudu/kudu/pull/1489#discussion_r26175781"},"pull_request":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/1489"}}},"pull_request":{"url":"https://api.github.com/repos/projectkudu/kudu/pulls/1489","id":30695358,"html_url":"https://github.com/projectkudu/kudu/pull/1489","diff_url":"https://github.com/projectkudu/kudu/pull/1489.diff","patch_url":"https://github.com/projectkudu/kudu/pull/1489.patch","issue_url":"https://api.github.com/repos/projectkudu/kudu/issues/1489","number":1489,"state":"open","locked":false,"title":"Micro-Service support","user":{"login":"shrimpy","id":79823,"avatar_url":"https://avatars.githubusercontent.com/u/79823?v=3","gravatar_id":"","url":"https://api.github.com/users/shrimpy","html_url":"https://github.com/shrimpy","followers_url":"https://api.github.com/users/shrimpy/followers","following_url":"https://api.github.com/users/shrimpy/following{/other_user}","gists_url":"https://api.github.com/users/shrimpy/gists{/gist_id}","starred_url":"https://api.github.com/users/shrimpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrimpy/subscriptions","organizations_url":"https://api.github.com/users/shrimpy/orgs","repos_url":"https://api.github.com/users/shrimpy/repos","events_url":"https://api.github.com/users/shrimpy/events{/privacy}","received_events_url":"https://api.github.com/users/shrimpy/received_events","type":"User","site_admin":false},"body":"if given type is \"WebRoot\", it would indicate we will need to copy site extension content to \"wwwroot\"\r\n\r\ninstall:\r\n   package content will be extra to wwwroot\r\n   nupkg will still site in siteextenion/{packageid}\r\n   not to check xdt file\r\n   not to deploy webjob\r\n   ignore install.cmd\r\n\r\nUninstall:\r\n   remove content from wwwroot\r\n   remove folder siteextenion/{packageid}\r\n   not to undeploy webjob\r\n   ignore uninstall.cmd\r\n\r\n\r\nall site extension test case are passed","created_at":"2015-03-07T02:23:04Z","updated_at":"2015-03-10T23:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eb5e16da5dc80723c0a8373f240b8541d129074","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectkudu/kudu/pulls/1489/commits","review_comments_url":"https://api.github.com/repos/projectkudu/kudu/pulls/1489/comments","review_comment_url":"https://api.github.com/repos/projectkudu/kudu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectkudu/kudu/issues/1489/comments","statuses_url":"https://api.github.com/repos/projectkudu/kudu/statuses/e3819900b22689404e32932832172b9cce60ba67","head":{"label":"projectkudu:xiaowu-micro-services","ref":"xiaowu-micro-services","sha":"e3819900b22689404e32932832172b9cce60ba67","user":{"login":"projectkudu","id":927131,"avatar_url":"https://avatars.githubusercontent.com/u/927131?v=3","gravatar_id":"","url":"https://api.github.com/users/projectkudu","html_url":"https://github.com/projectkudu","followers_url":"https://api.github.com/users/projectkudu/followers","following_url":"https://api.github.com/users/projectkudu/following{/other_user}","gists_url":"https://api.github.com/users/projectkudu/gists{/gist_id}","starred_url":"https://api.github.com/users/projectkudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectkudu/subscriptions","organizations_url":"https://api.github.com/users/projectkudu/orgs","repos_url":"https://api.github.com/users/projectkudu/repos","events_url":"https://api.github.com/users/projectkudu/events{/privacy}","received_events_url":"https://api.github.com/users/projectkudu/received_events","type":"Organization","site_admin":false},"repo":{"id":1939769,"name":"kudu","full_name":"projectkudu/kudu","owner":{"login":"projectkudu","id":927131,"avatar_url":"https://avatars.githubusercontent.com/u/927131?v=3","gravatar_id":"","url":"https://api.github.com/users/projectkudu","html_url":"https://github.com/projectkudu","followers_url":"https://api.github.com/users/projectkudu/followers","following_url":"https://api.github.com/users/projectkudu/following{/other_user}","gists_url":"https://api.github.com/users/projectkudu/gists{/gist_id}","starred_url":"https://api.github.com/users/projectkudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectkudu/subscriptions","organizations_url":"https://api.github.com/users/projectkudu/orgs","repos_url":"https://api.github.com/users/projectkudu/repos","events_url":"https://api.github.com/users/projectkudu/events{/privacy}","received_events_url":"https://api.github.com/users/projectkudu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectkudu/kudu","description":"Kudu is the engine behind git/hg deployments, WebJobs, and various other features in Azure Web Sites. It can also run outside of Azure.","fork":false,"url":"https://api.github.com/repos/projectkudu/kudu","forks_url":"https://api.github.com/repos/projectkudu/kudu/forks","keys_url":"https://api.github.com/repos/projectkudu/kudu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectkudu/kudu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectkudu/kudu/teams","hooks_url":"https://api.github.com/repos/projectkudu/kudu/hooks","issue_events_url":"https://api.github.com/repos/projectkudu/kudu/issues/events{/number}","events_url":"https://api.github.com/repos/projectkudu/kudu/events","assignees_url":"https://api.github.com/repos/projectkudu/kudu/assignees{/user}","branches_url":"https://api.github.com/repos/projectkudu/kudu/branches{/branch}","tags_url":"https://api.github.com/repos/projectkudu/kudu/tags","blobs_url":"https://api.github.com/repos/projectkudu/kudu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectkudu/kudu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectkudu/kudu/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectkudu/kudu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectkudu/kudu/statuses/{sha}","languages_url":"https://api.github.com/repos/projectkudu/kudu/languages","stargazers_url":"https://api.github.com/repos/projectkudu/kudu/stargazers","contributors_url":"https://api.github.com/repos/projectkudu/kudu/contributors","subscribers_url":"https://api.github.com/repos/projectkudu/kudu/subscribers","subscription_url":"https://api.github.com/repos/projectkudu/kudu/subscription","commits_url":"https://api.github.com/repos/projectkudu/kudu/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectkudu/kudu/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectkudu/kudu/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectkudu/kudu/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectkudu/kudu/contents/{+path}","compare_url":"https://api.github.com/repos/projectkudu/kudu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectkudu/kudu/merges","archive_url":"https://api.github.com/repos/projectkudu/kudu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectkudu/kudu/downloads","issues_url":"https://api.github.com/repos/projectkudu/kudu/issues{/number}","pulls_url":"https://api.github.com/repos/projectkudu/kudu/pulls{/number}","milestones_url":"https://api.github.com/repos/projectkudu/kudu/milestones{/number}","notifications_url":"https://api.github.com/repos/projectkudu/kudu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectkudu/kudu/labels{/name}","releases_url":"https://api.github.com/repos/projectkudu/kudu/releases{/id}","created_at":"2011-06-23T05:36:20Z","updated_at":"2015-03-10T21:26:20Z","pushed_at":"2015-03-10T21:26:22Z","git_url":"git://github.com/projectkudu/kudu.git","ssh_url":"git@github.com:projectkudu/kudu.git","clone_url":"https://github.com/projectkudu/kudu.git","svn_url":"https://github.com/projectkudu/kudu","homepage":"","size":45646,"stargazers_count":859,"watchers_count":859,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":101,"forks":172,"open_issues":101,"watchers":859,"default_branch":"master"}},"base":{"label":"projectkudu:master","ref":"master","sha":"1c76added97a2391aa6e438bec20c943373f7b90","user":{"login":"projectkudu","id":927131,"avatar_url":"https://avatars.githubusercontent.com/u/927131?v=3","gravatar_id":"","url":"https://api.github.com/users/projectkudu","html_url":"https://github.com/projectkudu","followers_url":"https://api.github.com/users/projectkudu/followers","following_url":"https://api.github.com/users/projectkudu/following{/other_user}","gists_url":"https://api.github.com/users/projectkudu/gists{/gist_id}","starred_url":"https://api.github.com/users/projectkudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectkudu/subscriptions","organizations_url":"https://api.github.com/users/projectkudu/orgs","repos_url":"https://api.github.com/users/projectkudu/repos","events_url":"https://api.github.com/users/projectkudu/events{/privacy}","received_events_url":"https://api.github.com/users/projectkudu/received_events","type":"Organization","site_admin":false},"repo":{"id":1939769,"name":"kudu","full_name":"projectkudu/kudu","owner":{"login":"projectkudu","id":927131,"avatar_url":"https://avatars.githubusercontent.com/u/927131?v=3","gravatar_id":"","url":"https://api.github.com/users/projectkudu","html_url":"https://github.com/projectkudu","followers_url":"https://api.github.com/users/projectkudu/followers","following_url":"https://api.github.com/users/projectkudu/following{/other_user}","gists_url":"https://api.github.com/users/projectkudu/gists{/gist_id}","starred_url":"https://api.github.com/users/projectkudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectkudu/subscriptions","organizations_url":"https://api.github.com/users/projectkudu/orgs","repos_url":"https://api.github.com/users/projectkudu/repos","events_url":"https://api.github.com/users/projectkudu/events{/privacy}","received_events_url":"https://api.github.com/users/projectkudu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectkudu/kudu","description":"Kudu is the engine behind git/hg deployments, WebJobs, and various other features in Azure Web Sites. It can also run outside of Azure.","fork":false,"url":"https://api.github.com/repos/projectkudu/kudu","forks_url":"https://api.github.com/repos/projectkudu/kudu/forks","keys_url":"https://api.github.com/repos/projectkudu/kudu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectkudu/kudu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectkudu/kudu/teams","hooks_url":"https://api.github.com/repos/projectkudu/kudu/hooks","issue_events_url":"https://api.github.com/repos/projectkudu/kudu/issues/events{/number}","events_url":"https://api.github.com/repos/projectkudu/kudu/events","assignees_url":"https://api.github.com/repos/projectkudu/kudu/assignees{/user}","branches_url":"https://api.github.com/repos/projectkudu/kudu/branches{/branch}","tags_url":"https://api.github.com/repos/projectkudu/kudu/tags","blobs_url":"https://api.github.com/repos/projectkudu/kudu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectkudu/kudu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectkudu/kudu/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectkudu/kudu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectkudu/kudu/statuses/{sha}","languages_url":"https://api.github.com/repos/projectkudu/kudu/languages","stargazers_url":"https://api.github.com/repos/projectkudu/kudu/stargazers","contributors_url":"https://api.github.com/repos/projectkudu/kudu/contributors","subscribers_url":"https://api.github.com/repos/projectkudu/kudu/subscribers","subscription_url":"https://api.github.com/repos/projectkudu/kudu/subscription","commits_url":"https://api.github.com/repos/projectkudu/kudu/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectkudu/kudu/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectkudu/kudu/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectkudu/kudu/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectkudu/kudu/contents/{+path}","compare_url":"https://api.github.com/repos/projectkudu/kudu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectkudu/kudu/merges","archive_url":"https://api.github.com/repos/projectkudu/kudu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectkudu/kudu/downloads","issues_url":"https://api.github.com/repos/projectkudu/kudu/issues{/number}","pulls_url":"https://api.github.com/repos/projectkudu/kudu/pulls{/number}","milestones_url":"https://api.github.com/repos/projectkudu/kudu/milestones{/number}","notifications_url":"https://api.github.com/repos/projectkudu/kudu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectkudu/kudu/labels{/name}","releases_url":"https://api.github.com/repos/projectkudu/kudu/releases{/id}","created_at":"2011-06-23T05:36:20Z","updated_at":"2015-03-10T21:26:20Z","pushed_at":"2015-03-10T21:26:22Z","git_url":"git://github.com/projectkudu/kudu.git","ssh_url":"git@github.com:projectkudu/kudu.git","clone_url":"https://github.com/projectkudu/kudu.git","svn_url":"https://github.com/projectkudu/kudu","homepage":"","size":45646,"stargazers_count":859,"watchers_count":859,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":101,"forks":172,"open_issues":101,"watchers":859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/1489"},"html":{"href":"https://github.com/projectkudu/kudu/pull/1489"},"issue":{"href":"https://api.github.com/repos/projectkudu/kudu/issues/1489"},"comments":{"href":"https://api.github.com/repos/projectkudu/kudu/issues/1489/comments"},"review_comments":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/1489/comments"},"review_comment":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/1489/commits"},"statuses":{"href":"https://api.github.com/repos/projectkudu/kudu/statuses/e3819900b22689404e32932832172b9cce60ba67"}}}}