{"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/27776124","id":27776124,"diff_hunk":"@@ -562,9 +561,9 @@ struct buffered_piece_collection\n                 }\n                 // Walk through them, in reverse to insert at right index\n                 int index_offset = pc.robust_turns.size() - 1;\n-                for (typename std::vector<robust_turn>::const_reverse_iterator\n-                        rit = pc.robust_turns.rbegin();\n-                    rit != pc.robust_turns.rend();\n+                for (typename boost::range_reverse_iterator<const std::vector<robust_turn> >::type\n+                        rit = boost::const_rbegin(pc.robust_turns);\n+                    rit != boost::const_rend(pc.robust_turns);\n                     ++rit, --index_offset)\n                 {\n                     int const index_in_vector = 1 + rit->seg_id.segment_index - piece_segment_index;","path":"include/boost/geometry/algorithms/detail/buffer/buffered_piece_collection.hpp","position":24,"original_position":24,"commit_id":"1113955b88909834b47089b813fd93d242f07f76","original_commit_id":"1113955b88909834b47089b813fd93d242f07f76","user":{"login":"barendgehrels","id":334849,"avatar_url":"https://avatars.githubusercontent.com/u/334849?v=3","gravatar_id":"","url":"https://api.github.com/users/barendgehrels","html_url":"https://github.com/barendgehrels","followers_url":"https://api.github.com/users/barendgehrels/followers","following_url":"https://api.github.com/users/barendgehrels/following{/other_user}","gists_url":"https://api.github.com/users/barendgehrels/gists{/gist_id}","starred_url":"https://api.github.com/users/barendgehrels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barendgehrels/subscriptions","organizations_url":"https://api.github.com/users/barendgehrels/orgs","repos_url":"https://api.github.com/users/barendgehrels/repos","events_url":"https://api.github.com/users/barendgehrels/events{/privacy}","received_events_url":"https://api.github.com/users/barendgehrels/received_events","type":"User","site_admin":false},"body":"Thanks for explaining - I'm OK with merging","created_at":"2015-04-05T09:58:36Z","updated_at":"2015-04-05T09:58:36Z","html_url":"https://github.com/boostorg/geometry/pull/277#discussion_r27776124","pull_request_url":"https://api.github.com/repos/boostorg/geometry/pulls/277","_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/27776124"},"html":{"href":"https://github.com/boostorg/geometry/pull/277#discussion_r27776124"},"pull_request":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/277"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/277","id":32468064,"html_url":"https://github.com/boostorg/geometry/pull/277","diff_url":"https://github.com/boostorg/geometry/pull/277.diff","patch_url":"https://github.com/boostorg/geometry/pull/277.patch","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/277","number":277,"state":"open","locked":false,"title":"Workarounds for SunOS","user":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"body":"The proposed changes are workarounds, the code compiles on other platforms. Though I think merging them could be beneficient. Plus, there would be more green in the matrix.\r\n\r\nThere are a few more failing tests for which workarounds (2 issues) could be added:\r\n* Spherical [distance](http://www.boost.org/development/tests/develop/developer/output/oracle-intel-S2-stlport4-boost-bin-v2-libs-geometry-test-algorithms-distance-distance_se_pl_pl-test-sun-stlport4-release-address-model-32-architecture-x86-threading-multi.html) tests - the use of `comparable_type` private member in the definition of public member struct template `haversine<>::calculation_type<>`, it's hard to believe that this fails only in haversine.\r\n* [point_iterator](http://www.boost.org/development/tests/develop/developer/output/oracle-intel-S2-stlport4-boost-bin-v2-libs-geometry-test-iterators-point_iterator-test-sun-stlport4-release-address-model-32-architecture-x86-threading-multi.html) test - the implicit conversion of reverse iterator to const reverse iterator in the test itself. E.g. only assignment/explicit conversion and comparison could be tested, without implicit conversion.\r\n\r\nThe workarounds would be trivial, what do you think?","created_at":"2015-04-01T22:38:18Z","updated_at":"2015-04-05T09:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f0c7b5017a3ee084b0eaff76d06a39dac9440e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/geometry/pulls/277/commits","review_comments_url":"https://api.github.com/repos/boostorg/geometry/pulls/277/comments","review_comment_url":"https://api.github.com/repos/boostorg/geometry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/277/comments","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/1113955b88909834b47089b813fd93d242f07f76","head":{"label":"awulkiew:fix/sunos","ref":"fix/sunos","sha":"1113955b88909834b47089b813fd93d242f07f76","user":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"repo":{"id":20000078,"name":"geometry","full_name":"awulkiew/geometry","owner":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awulkiew/geometry","description":"Boost.org geometry module","fork":true,"url":"https://api.github.com/repos/awulkiew/geometry","forks_url":"https://api.github.com/repos/awulkiew/geometry/forks","keys_url":"https://api.github.com/repos/awulkiew/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awulkiew/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awulkiew/geometry/teams","hooks_url":"https://api.github.com/repos/awulkiew/geometry/hooks","issue_events_url":"https://api.github.com/repos/awulkiew/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/awulkiew/geometry/events","assignees_url":"https://api.github.com/repos/awulkiew/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/awulkiew/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/awulkiew/geometry/tags","blobs_url":"https://api.github.com/repos/awulkiew/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awulkiew/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awulkiew/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/awulkiew/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awulkiew/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/awulkiew/geometry/languages","stargazers_url":"https://api.github.com/repos/awulkiew/geometry/stargazers","contributors_url":"https://api.github.com/repos/awulkiew/geometry/contributors","subscribers_url":"https://api.github.com/repos/awulkiew/geometry/subscribers","subscription_url":"https://api.github.com/repos/awulkiew/geometry/subscription","commits_url":"https://api.github.com/repos/awulkiew/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/awulkiew/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/awulkiew/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/awulkiew/geometry/issues/comments{/number}","contents_url":"https://api.github.com/repos/awulkiew/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/awulkiew/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awulkiew/geometry/merges","archive_url":"https://api.github.com/repos/awulkiew/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awulkiew/geometry/downloads","issues_url":"https://api.github.com/repos/awulkiew/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/awulkiew/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/awulkiew/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/awulkiew/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awulkiew/geometry/labels{/name}","releases_url":"https://api.github.com/repos/awulkiew/geometry/releases{/id}","created_at":"2014-05-20T22:38:29Z","updated_at":"2014-11-21T16:24:43Z","pushed_at":"2015-04-02T01:24:36Z","git_url":"git://github.com/awulkiew/geometry.git","ssh_url":"git@github.com:awulkiew/geometry.git","clone_url":"https://github.com/awulkiew/geometry.git","svn_url":"https://github.com/awulkiew/geometry","homepage":"http://boost.org/libs/geometry","size":34825,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"292cbb489b01336d6925296ee377e2570fd24ac6","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7590021,"name":"geometry","full_name":"boostorg/geometry","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/geometry","description":"Boost.org geometry module","fork":false,"url":"https://api.github.com/repos/boostorg/geometry","forks_url":"https://api.github.com/repos/boostorg/geometry/forks","keys_url":"https://api.github.com/repos/boostorg/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/geometry/teams","hooks_url":"https://api.github.com/repos/boostorg/geometry/hooks","issue_events_url":"https://api.github.com/repos/boostorg/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/geometry/events","assignees_url":"https://api.github.com/repos/boostorg/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/geometry/tags","blobs_url":"https://api.github.com/repos/boostorg/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/geometry/languages","stargazers_url":"https://api.github.com/repos/boostorg/geometry/stargazers","contributors_url":"https://api.github.com/repos/boostorg/geometry/contributors","subscribers_url":"https://api.github.com/repos/boostorg/geometry/subscribers","subscription_url":"https://api.github.com/repos/boostorg/geometry/subscription","commits_url":"https://api.github.com/repos/boostorg/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/geometry/issues/comments{/number}","contents_url":"https://api.github.com/repos/boostorg/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/geometry/merges","archive_url":"https://api.github.com/repos/boostorg/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/geometry/downloads","issues_url":"https://api.github.com/repos/boostorg/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/geometry/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/geometry/releases{/id}","created_at":"2013-01-13T15:59:29Z","updated_at":"2015-03-30T16:25:08Z","pushed_at":"2015-04-05T00:31:36Z","git_url":"git://github.com/boostorg/geometry.git","ssh_url":"git@github.com:boostorg/geometry.git","clone_url":"https://github.com/boostorg/geometry.git","svn_url":"https://github.com/boostorg/geometry","homepage":"http://boost.org/libs/geometry","size":48301,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/277"},"html":{"href":"https://github.com/boostorg/geometry/pull/277"},"issue":{"href":"https://api.github.com/repos/boostorg/geometry/issues/277"},"comments":{"href":"https://api.github.com/repos/boostorg/geometry/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/geometry/statuses/1113955b88909834b47089b813fd93d242f07f76"}}}}