{"action":"closed","number":151,"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151","id":54492458,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/151","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/151.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/151.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/151","number":151,"state":"closed","locked":false,"title":"api & test cleanups for platform differences","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"1. Platform excludes in the yaml file to handle N7K vs N77, mt_full vs mt_lite, etc\r\n2. Related to the first item, these are mostly feature enablement and feature checking changes\r\n3. Test file changes: we had a lot of tests that we couldn't run on N3/N7/N9 without proper setup and teardowns (e.g. the vxlan, vni, vlan tests that rely on mt_full need a special line card to be present, whereas the mt_lite properties don't need the card but only work on N3/N9.\r\n\r\n\r\nTest results from affected tests:\r\n\r\n```\r\n---\r\ntest_interface.rb\r\nN7: 44 runs, 44 assertions, 10 failures, 14 errors, 1 skips (failures unrelated to my changes)\r\nN9: 44 runs, 320 assertions, 0 failures, 0 errors, 2 skips\r\nN3: 44 runs, 343 assertions, 0 failures, 0 errors, 5 skips\r\n---\r\ntest_interface_service.rb\r\nN7:  4 runs, 23 assertions, 0 failures, 0 errors, 0 skips\r\nN39: 4 runs, 0 assertions, 0 failures, 0 errors, 4 skips\r\n---\r\ntest_interface_svi.rb\r\nN7:\r\nN39: 19 runs, 46 assertions, 0 failures, 0 errors, 0 skips\r\n---\r\ntest_interface_switchport.rb\r\nN7: 53 runs, 59 assertions, 5 failures, 6 errors, 0 skips (failures unrelated to my changes)\r\nN39:53 runs, 97 assertions, 0 failures, 0 errors, 0 skips\r\n---\r\ntest_platform.rb\r\nN7:  14 runs, 16 assertions, 3 failures, 0 errors, 1 skips (failures unrelated to my changes)\r\nN39: 14 runs, 19 assertions, 0 failures, 0 errors, 0 skips\r\n---\r\ntest_vdc.rb\r\nN7: 3 runs, 6 assertions, 0 failures, 0 errors, 0 skips\r\nN39:3 runs, 0 assertions, 0 failures, 0 errors, 3 skips\r\n---\r\ntest_vni.rb\r\nN7:  3 runs, 7 assertions, 0 failures, 0 errors, 1 skips\r\nN39: 3 runs, 8 assertions, 0 failures, 0 errors, 2 skips\r\n---\r\ntest_vlan.rb\r\nN7: 21 runs, 44 assertions, 0 failures, 3 errors, 0 skips (failures unrelated to my changes)\r\nN9: 21 runs, 45 assertions, 0 failures, 0 errors, 1 skips\r\nN3: 21 runs, 45 assertions, 0 failures, 0 errors, 1 skips\r\n---\r\ntest_vtp.rb\r\nN7:  31 runs, 123 assertions, 2 failures, 0 errors, 0 skips (failures unrelated to my changes)\r\nN39: 31 runs, 123 assertions, 0 failures, 0 errors, 0 skips\r\n---\r\ntest_vrf.rb\r\nN7: 8 runs, 17 assertions, 0 failures, 1 errors, 1 skips (failures unrelated to my changes)\r\nN9: 8 runs, 21 assertions, 0 failures, 0 errors, 0 skips\r\nN3: 8 runs, 19 assertions, 0 failures, 0 errors, 1 skips\r\n---\r\ntest_vxlan_vtep.rb\r\nN7: 7 runs, 54 assertions, 0 failures, 0 errors, 0 skips\r\nN9: 7 runs, 22 assertions, 0 failures, 0 errors, 1 skips\r\nN3: 7 runs, 19 assertions, 0 failures, 0 errors, 2 skips\r\n---\r\ntest_router_bgp.rb\r\nN7: 62 runs, 227 assertions, 1 failures, 0 errors, 2 skips\r\nN9: 62 runs, 235 assertions, 0 failures, 0 errors, 0 skips\r\nN3: 62 runs, 231 assertions, 0 failures, 1 errors, 0 skips (failures unrelated to my changes)\r\n---\r\ntest_bgp_neighbor.rb\r\nN7: 22 runs, 206 assertions, 0 failures, 1 errors, 0 skips (failures unrelated to my changes)\r\nN39: 22 runs, 220 assertions, 0 failures, 0 errors, 0 skips\r\n---\r\n``` ","created_at":"2015-12-23T17:57:09Z","updated_at":"2015-12-28T16:12:03Z","closed_at":"2015-12-28T16:12:03Z","merged_at":"2015-12-28T16:12:03Z","merge_commit_sha":"395fde664d3b18863ca87edc79d2bed9bf38aed2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/151/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/a91818880d36318564e83bce71fb03fb20a9ebb7","head":{"label":"chrisvanheuveln:vlan_translation","ref":"vlan_translation","sha":"a91818880d36318564e83bce71fb03fb20a9ebb7","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"repo":{"id":46866688,"name":"cisco-network-node-utils","full_name":"chrisvanheuveln/cisco-network-node-utils","owner":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvanheuveln/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils","forks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-node-utils/releases{/id}","created_at":"2015-11-25T14:31:41Z","updated_at":"2015-12-08T13:34:17Z","pushed_at":"2015-12-24T17:11:41Z","git_url":"git://github.com/chrisvanheuveln/cisco-network-node-utils.git","ssh_url":"git@github.com:chrisvanheuveln/cisco-network-node-utils.git","clone_url":"https://github.com/chrisvanheuveln/cisco-network-node-utils.git","svn_url":"https://github.com/chrisvanheuveln/cisco-network-node-utils","homepage":null,"size":1627,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"4f7f42c31c87995b931221738d767dca3e8502e9","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-12-28T04:46:38Z","pushed_at":"2015-12-28T16:12:03Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2920,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":4,"forks":31,"open_issues":4,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/151"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/151"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/a91818880d36318564e83bce71fb03fb20a9ebb7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"comments":0,"review_comments":13,"commits":11,"additions":336,"deletions":200,"changed_files":27}}