{"action":"created","issue":{"url":"https://api.github.com/repos/h2database/h2database/issues/127","labels_url":"https://api.github.com/repos/h2database/h2database/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/h2database/h2database/issues/127/comments","events_url":"https://api.github.com/repos/h2database/h2database/issues/127/events","html_url":"https://github.com/h2database/h2database/pull/127","id":81980033,"number":127,"title":"Fix linked table with geometry field","user":{"login":"nicolas-f","id":1382241,"avatar_url":"https://avatars.githubusercontent.com/u/1382241?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-f","html_url":"https://github.com/nicolas-f","followers_url":"https://api.github.com/users/nicolas-f/followers","following_url":"https://api.github.com/users/nicolas-f/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-f/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-f/subscriptions","organizations_url":"https://api.github.com/users/nicolas-f/orgs","repos_url":"https://api.github.com/users/nicolas-f/repos","events_url":"https://api.github.com/users/nicolas-f/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-f/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-28T15:21:29Z","updated_at":"2015-06-05T16:08:44Z","closed_at":"2015-05-29T05:50:54Z","pull_request":{"url":"https://api.github.com/repos/h2database/h2database/pulls/127","html_url":"https://github.com/h2database/h2database/pull/127","diff_url":"https://github.com/h2database/h2database/pull/127.diff","patch_url":"https://github.com/h2database/h2database/pull/127.patch"},"body":"Linked table (by providing only table name) does not work for geometry columns as it only use sqlType for defining column type.\r\n\r\nThis fix has a unit test and have been also tested (externally) with PostGIS.\r\n\r\nIf you have some recommendation you can write it here in comments (In this case I add more commits), or add your modifications as a pull request on my branch (that will automatically add up here) \r\n\r\nI've been somewhat \"sad\" when the last time you closed my pr and you do the commit separately :cry: \r\n\r\nThank you !"},"comment":{"url":"https://api.github.com/repos/h2database/h2database/issues/comments/109343549","html_url":"https://github.com/h2database/h2database/pull/127#issuecomment-109343549","issue_url":"https://api.github.com/repos/h2database/h2database/issues/127","id":109343549,"user":{"login":"thomasmueller","id":932377,"avatar_url":"https://avatars.githubusercontent.com/u/932377?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasmueller","html_url":"https://github.com/thomasmueller","followers_url":"https://api.github.com/users/thomasmueller/followers","following_url":"https://api.github.com/users/thomasmueller/following{/other_user}","gists_url":"https://api.github.com/users/thomasmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmueller/subscriptions","organizations_url":"https://api.github.com/users/thomasmueller/orgs","repos_url":"https://api.github.com/users/thomasmueller/repos","events_url":"https://api.github.com/users/thomasmueller/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmueller/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T16:08:44Z","updated_at":"2015-06-05T16:08:44Z","body":"Hi,\n\nSorry I just saw that now.\n\nThe way I have used will make it harder on your side to merge, right? Or is\nthere another reason?\n\nThere are usually quite many changes needed when I get a pull request.\nFormatting, spellchecking, adding tests, adding an entry to the change log.\nOf course it would be nice if pull requests were already \"finished\". In the\nfuture I will comment what changes are needed (maybe with patches), so that\nin the future it will be easier for all parties.\n\nRegards,\nThomas\n\nOn Friday, May 29, 2015, nicolas-f <notifications@github.com\n<javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:\n\n> This is not what I expected.\n>\n> I understand that you are not used to git and github..\n> You don't make change to my contribution, you discard it and made your own\n> commit.\n> If you don't want to accept any pull request, there is still two way to do\n> it properly.\n>\n> The first way is to merge into your local repository, add more commit then\n> push it in master public repo.\n>\n> Or you can do something called cherry-picking:\n>\n> In your local repository:\n>\n> git remote add nicolas-f https://github.com/nicolas-f/h2database.git\n> git fetch --all -p\n> git cherry-pick 064a449205f2a97b1baa3131669b21e398add931\n> git cherry-pick 702fc0eeb01f2adc44c60b244aa228daed73f70d\n> git remote remove nicolas-f\n>\n> Then you can modify the code, commit and finally push it in public repo.\n>\n> The most easy way for you is to comment in the pull request what the\n> contributor have to change before his pull request has a chance to be\n> accepted.\n>\n> https://help.github.com/articles/using-pull-requests/\n>\n> It's just an advice with respect to other contributors. Anyway, Thank you\n> for your feedback.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/h2database/h2database/pull/127#issuecomment-106716938>\n> .\n>\n"}}