{"action":"created","issue":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/52","labels_url":"https://api.github.com/repos/freeorion/freeorion/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/52/comments","events_url":"https://api.github.com/repos/freeorion/freeorion/issues/52/events","html_url":"https://github.com/freeorion/freeorion/pull/52","id":72596419,"number":52,"title":"Post combat visibility","user":{"login":"Dilvish-fo","id":10995939,"avatar_url":"https://avatars.githubusercontent.com/u/10995939?v=3","gravatar_id":"","url":"https://api.github.com/users/Dilvish-fo","html_url":"https://github.com/Dilvish-fo","followers_url":"https://api.github.com/users/Dilvish-fo/followers","following_url":"https://api.github.com/users/Dilvish-fo/following{/other_user}","gists_url":"https://api.github.com/users/Dilvish-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Dilvish-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dilvish-fo/subscriptions","organizations_url":"https://api.github.com/users/Dilvish-fo/orgs","repos_url":"https://api.github.com/users/Dilvish-fo/repos","events_url":"https://api.github.com/users/Dilvish-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Dilvish-fo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/freeorion/freeorion/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-02T06:24:37Z","updated_at":"2015-05-05T10:48:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/52","html_url":"https://github.com/freeorion/freeorion/pull/52","diff_url":"https://github.com/freeorion/freeorion/pull/52.diff","patch_url":"https://github.com/freeorion/freeorion/pull/52.patch"},"body":"So, this PR is just submitted for discussion; it is a derivation from  Mitten's PR #29.  I only wound up using a portion of lines from that & so these commits just start from scratch rather than start from his and then revert 70% of it.  Perhaps I should do just that, though, or perhaps just make a new commit in his name with the portion of his that I kept-- someone with more experience with standard git practice please advise about recommended protocol here.\r\n\r\nAnyway, I think this accomplishes 95% of what we want for this.  With this, stealthed attackers reveal Basic Visibility of themselves to their targets (as opposed to the Partial Vis granted in the Mittens PR).  It is broken into two commits in case Geoff prefers some other way than what I have in the second commit to deal with the MapWnd suppression issue, perhaps by adjusting the Universe::UpdateEmpireStaleObjectKnowledge() algorithm.  Geoff, I think this does address all your concerns mentioned regarding PR #29 (in our forum thread on it).\r\n\r\nBelow is a screenshot immediately post-combat after a stealthed Asteroid Snail killed my scout. ![post combat ghost ship] (http://i.imgur.com/BaPrvAg.png).  Once I research Active Radar and observe the snail, its icon on the map, etc., gets updated properly.  The reason I say this is currently only 95% of what we want is because if the \"Ship\" link in the combat log is not working as an active link, and I haven't figured out why.  "},"comment":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/comments/99031186","html_url":"https://github.com/freeorion/freeorion/pull/52#issuecomment-99031186","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/52","id":99031186,"user":{"login":"geoffthemedio","id":11386908,"avatar_url":"https://avatars.githubusercontent.com/u/11386908?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffthemedio","html_url":"https://github.com/geoffthemedio","followers_url":"https://api.github.com/users/geoffthemedio/followers","following_url":"https://api.github.com/users/geoffthemedio/following{/other_user}","gists_url":"https://api.github.com/users/geoffthemedio/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffthemedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffthemedio/subscriptions","organizations_url":"https://api.github.com/users/geoffthemedio/orgs","repos_url":"https://api.github.com/users/geoffthemedio/repos","events_url":"https://api.github.com/users/geoffthemedio/events{/privacy}","received_events_url":"https://api.github.com/users/geoffthemedio/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T10:48:53Z","updated_at":"2015-05-05T10:48:53Z","body":"Re: the Ship link, do any of the combatant or system links work for you? The CombatLogWnd class is a CUILinkTextMultiEdit but I don't see anywhere that its link clicked signals are connected to anything which would react to the clicking of a link in the text. See line 442 of EncyclopediaDetailPanel.cpp for the needed connection(s)."}}