{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/38435705","id":38435705,"diff_hunk":"@@ -376,6 +383,17 @@ ngx_http_lua_shdict_get_stale(lua_State *L)\n   return ngx_http_lua_shdict_get_helper(L, 1 /* stale */);\n }\n \n+static inline ngx_shm_zone_t *","path":"src/ngx_http_lua_shdict.c","position":32,"original_position":32,"commit_id":"02eb9b6b5ccc6e9af06ee4486fdd7a058a0db684","original_commit_id":"02eb9b6b5ccc6e9af06ee4486fdd7a058a0db684","user":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"body":"Ok! Thanks! :)","created_at":"2015-09-01T15:53:14Z","updated_at":"2015-09-01T15:53:14Z","html_url":"https://github.com/openresty/lua-nginx-module/pull/557#discussion_r38435705","pull_request_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/38435705"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/557#discussion_r38435705"},"pull_request":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557","id":43771051,"html_url":"https://github.com/openresty/lua-nginx-module/pull/557","diff_url":"https://github.com/openresty/lua-nginx-module/pull/557.diff","patch_url":"https://github.com/openresty/lua-nginx-module/pull/557.patch","issue_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/557","number":557,"state":"open","locked":false,"title":"Issue548","user":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"body":"Belated pull request.\r\n\r\nA potential problem is that the metatable of lightuserdata would changed in \"shdict\", if it set metatable for lightuserdata that anywhere in ngx_lua's VM. The reason is lightuserdata share the metatable globally.\r\n\r\ntest:\r\n```shell\r\n    $ PATH=${PATH}:/usr/local/openresty/nginx/sbin prove  -I./t/lib  t/126-shdict- frag.t t/043-shdict.t t/080-hup-shdict.t \r\n    t/126-shdict-frag.t .. ok     \r\n    t/043-shdict.t ....... ok       \r\n    t/080-hup-shdict.t ... ok     \r\n    All tests successful.\r\n    Files=3, Tests=320, 40 wallclock secs ( 0.14 usr  0.01 sys +  4.49 cusr  1.49  csys =  6.13 CPU)\r\n    Result: PASS\r\n```\r\n\r\nI find some test-suits rely on external configuration of nginx.\r\nCould you please provide your nginx configuration in `t/servroot`.\r\n\r\nThanks!","created_at":"2015-08-31T14:39:51Z","updated_at":"2015-09-01T15:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3fc4caa05d4e3d1ab4e5dc27e73cc43798f8bea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557/commits","review_comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557/comments","review_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/557/comments","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/02eb9b6b5ccc6e9af06ee4486fdd7a058a0db684","head":{"label":"helloyi:issue548","ref":"issue548","sha":"02eb9b6b5ccc6e9af06ee4486fdd7a058a0db684","user":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"repo":{"id":41372910,"name":"lua-nginx-module","full_name":"helloyi/lua-nginx-module","owner":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helloyi/lua-nginx-module","description":"Embed the Power of Lua into NGINX","fork":true,"url":"https://api.github.com/repos/helloyi/lua-nginx-module","forks_url":"https://api.github.com/repos/helloyi/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/helloyi/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helloyi/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helloyi/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/helloyi/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/helloyi/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/helloyi/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/helloyi/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/helloyi/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helloyi/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/helloyi/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/helloyi/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/helloyi/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/helloyi/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/helloyi/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/helloyi/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/helloyi/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/helloyi/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/helloyi/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helloyi/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/helloyi/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helloyi/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/helloyi/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/helloyi/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/helloyi/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helloyi/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/helloyi/lua-nginx-module/releases{/id}","created_at":"2015-08-25T15:52:42Z","updated_at":"2015-08-25T15:52:45Z","pushed_at":"2015-09-01T15:35:23Z","git_url":"git://github.com/helloyi/lua-nginx-module.git","ssh_url":"git@github.com:helloyi/lua-nginx-module.git","clone_url":"https://github.com/helloyi/lua-nginx-module.git","svn_url":"https://github.com/helloyi/lua-nginx-module","homepage":"http://openresty.org","size":13827,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"b6189f87f560260bf7eebb4066bf5c2f03c3036e","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":613829,"name":"lua-nginx-module","full_name":"openresty/lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/lua-nginx-module","description":"Embed the Power of Lua into NGINX","fork":false,"url":"https://api.github.com/repos/openresty/lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/lua-nginx-module/releases{/id}","created_at":"2010-04-16T15:59:01Z","updated_at":"2015-09-01T11:44:35Z","pushed_at":"2015-09-01T15:35:24Z","git_url":"git://github.com/openresty/lua-nginx-module.git","ssh_url":"git@github.com:openresty/lua-nginx-module.git","clone_url":"https://github.com/openresty/lua-nginx-module.git","svn_url":"https://github.com/openresty/lua-nginx-module","homepage":"http://openresty.org","size":23046,"stargazers_count":1780,"watchers_count":1780,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"open_issues_count":81,"forks":400,"open_issues":81,"watchers":1780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/557"},"issue":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/557"},"comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/02eb9b6b5ccc6e9af06ee4486fdd7a058a0db684"}}}}