{"action":"created","comment":{"url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments/44646638","id":44646638,"diff_hunk":"@@ -70,6 +70,13 @@ function splash_screen_theme($existing, $type, $theme, $path) {\n  * Implements hook_preprocess().\n  */\n function splash_screen_preprocess_splash(&$variables) {\n+  // Set our custom title.\n+  $splash_screen_title = variable_get('splash_screen_title_value', variable_get('site_name'));","path":"profiles/common/modules/features/splash_screen/splash_screen.module","position":5,"original_position":5,"commit_id":"4dfca20109c77d1d50bf661184c59d83365ee291","original_commit_id":"4dfca20109c77d1d50bf661184c59d83365ee291","user":{"login":"gervasek","id":14055017,"avatar_url":"https://avatars.githubusercontent.com/u/14055017?v=3","gravatar_id":"","url":"https://api.github.com/users/gervasek","html_url":"https://github.com/gervasek","followers_url":"https://api.github.com/users/gervasek/followers","following_url":"https://api.github.com/users/gervasek/following{/other_user}","gists_url":"https://api.github.com/users/gervasek/gists{/gist_id}","starred_url":"https://api.github.com/users/gervasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gervasek/subscriptions","organizations_url":"https://api.github.com/users/gervasek/orgs","repos_url":"https://api.github.com/users/gervasek/repos","events_url":"https://api.github.com/users/gervasek/events{/privacy}","received_events_url":"https://api.github.com/users/gervasek/received_events","type":"User","site_admin":false},"body":"I'm sorry, I asked you to simplify this line, but I found problem: If the title field is filled, and after is emptied, the variable exist and the value is \"\" (empty string).\r\nSo you first version was better (empty value is checked)\r\n```\r\n  // Cache our custom title.\r\n  // Set our custom title.\r\n  $custom_splash_screen_title = variable_get('splash_screen_title_value', FALSE);\r\n  $splash_screen_title = variable_get('splash_screen_title_value', variable_get('site_name'));\r\n  // Fallback to the site name if it is not configured.\r\n  $splash_screen_title = $custom_splash_screen_title ? $custom_splash_screen_title : variable_get('site_name');\r\n```\r\n\r\nReally sorry for that lost time !","created_at":"2015-11-12T11:26:38Z","updated_at":"2015-11-12T11:26:38Z","html_url":"https://github.com/ec-europa/platform-dev/pull/190#discussion_r44646638","pull_request_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments/44646638"},"html":{"href":"https://github.com/ec-europa/platform-dev/pull/190#discussion_r44646638"},"pull_request":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190","id":50252949,"html_url":"https://github.com/ec-europa/platform-dev/pull/190","diff_url":"https://github.com/ec-europa/platform-dev/pull/190.diff","patch_url":"https://github.com/ec-europa/platform-dev/pull/190.patch","issue_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/190","number":190,"state":"open","locked":false,"title":"Hotfix/nexteuropa 6001","user":{"login":"haringsrob","id":866743,"avatar_url":"https://avatars.githubusercontent.com/u/866743?v=3","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-10T13:25:09Z","updated_at":"2015-11-12T11:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08c4133d3c5087edb538c68530912455801fe071","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190/commits","review_comments_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190/comments","review_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/190/comments","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/4dfca20109c77d1d50bf661184c59d83365ee291","head":{"label":"ec-europa:hotfix/NEXTEUROPA-6001","ref":"hotfix/NEXTEUROPA-6001","sha":"4dfca20109c77d1d50bf661184c59d83365ee291","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":41666809,"name":"platform-dev","full_name":"ec-europa/platform-dev","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/platform-dev","description":"NextEuropa platform","fork":false,"url":"https://api.github.com/repos/ec-europa/platform-dev","forks_url":"https://api.github.com/repos/ec-europa/platform-dev/forks","keys_url":"https://api.github.com/repos/ec-europa/platform-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/platform-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/platform-dev/teams","hooks_url":"https://api.github.com/repos/ec-europa/platform-dev/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/platform-dev/events","assignees_url":"https://api.github.com/repos/ec-europa/platform-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/platform-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/platform-dev/tags","blobs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/platform-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/platform-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/platform-dev/languages","stargazers_url":"https://api.github.com/repos/ec-europa/platform-dev/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/platform-dev/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/platform-dev/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/platform-dev/subscription","commits_url":"https://api.github.com/repos/ec-europa/platform-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/platform-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/platform-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/platform-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/platform-dev/merges","archive_url":"https://api.github.com/repos/ec-europa/platform-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/platform-dev/downloads","issues_url":"https://api.github.com/repos/ec-europa/platform-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/platform-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/platform-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/platform-dev/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/platform-dev/releases{/id}","created_at":"2015-08-31T09:16:12Z","updated_at":"2015-11-05T11:23:19Z","pushed_at":"2015-11-12T11:24:23Z","git_url":"git://github.com/ec-europa/platform-dev.git","ssh_url":"git@github.com:ec-europa/platform-dev.git","clone_url":"https://github.com/ec-europa/platform-dev.git","svn_url":"https://github.com/ec-europa/platform-dev","homepage":null,"size":47478,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":8,"default_branch":"develop"}},"base":{"label":"ec-europa:master","ref":"master","sha":"f1a55d59a7ee5aff66f748a141f8025f41867ca9","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":41666809,"name":"platform-dev","full_name":"ec-europa/platform-dev","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/platform-dev","description":"NextEuropa platform","fork":false,"url":"https://api.github.com/repos/ec-europa/platform-dev","forks_url":"https://api.github.com/repos/ec-europa/platform-dev/forks","keys_url":"https://api.github.com/repos/ec-europa/platform-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/platform-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/platform-dev/teams","hooks_url":"https://api.github.com/repos/ec-europa/platform-dev/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/platform-dev/events","assignees_url":"https://api.github.com/repos/ec-europa/platform-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/platform-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/platform-dev/tags","blobs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/platform-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/platform-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/platform-dev/languages","stargazers_url":"https://api.github.com/repos/ec-europa/platform-dev/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/platform-dev/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/platform-dev/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/platform-dev/subscription","commits_url":"https://api.github.com/repos/ec-europa/platform-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/platform-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/platform-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/platform-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/platform-dev/merges","archive_url":"https://api.github.com/repos/ec-europa/platform-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/platform-dev/downloads","issues_url":"https://api.github.com/repos/ec-europa/platform-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/platform-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/platform-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/platform-dev/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/platform-dev/releases{/id}","created_at":"2015-08-31T09:16:12Z","updated_at":"2015-11-05T11:23:19Z","pushed_at":"2015-11-12T11:24:23Z","git_url":"git://github.com/ec-europa/platform-dev.git","ssh_url":"git@github.com:ec-europa/platform-dev.git","clone_url":"https://github.com/ec-europa/platform-dev.git","svn_url":"https://github.com/ec-europa/platform-dev","homepage":null,"size":47478,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190"},"html":{"href":"https://github.com/ec-europa/platform-dev/pull/190"},"issue":{"href":"https://api.github.com/repos/ec-europa/platform-dev/issues/190"},"comments":{"href":"https://api.github.com/repos/ec-europa/platform-dev/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/ec-europa/platform-dev/statuses/4dfca20109c77d1d50bf661184c59d83365ee291"}}}}