{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments/45322385","id":45322385,"diff_hunk":"@@ -372,6 +389,73 @@\n   <!-- End of FxCop section-->\n   <!-- **************************************************************************** -->\n \n+  <!-- **************************************************************************** -->\n+  <!-- Roslyn analysis section -->\n+  <!-- **************************************************************************** -->\n+  <!-- Set the properties required to run Roslyn analysis as part of the build. \n+       Note: Roslyn analysis is run using the CSC task in MSBuild 14.0 onwards.\n+       Analysis is controlled by the following properties:\n+         ResolvedCodeAnalysisRuleSet - the full path to the ruleset to use\n+         ErrorLog - the file path for the error reporting file\n+         \n+       We want to run after the core \"ResolveCodeAnalysisRuleSet\" target which\n+       assigns a value to \"ResolvedCodeAnalysisRuleSet\".\n+  -->\n+  <Target Name=\"OverrideRoslynCodeAnalysisProperties\"\n+        Condition=\" $(SonarQubeTempPath) != '' \"\n+        DependsOnTargets=\"SonarQubeCategoriseProject\"\n+        AfterTargets=\"ResolveCodeAnalysisRuleSet\"\n+        BeforeTargets=\"CoreCompile\">\n+\n+    <PropertyGroup>\n+      <!-- Check if the ruleset exists -->\n+      <SonarQubeRoslynRulesetFullName>$(SonarQubeConfigPath)SonarQubeRoslyn-cs.ruleset</SonarQubeRoslynRulesetFullName>\n+      <SonarQubeRoslynRulesetExists>$([System.IO.File]::Exists($(SonarQubeRoslynRulesetFullName)))</SonarQubeRoslynRulesetExists>\n+\n+      <!-- Run FxCop only if the ruleset exists (else it means no Roslyn rules are enabled) -->","path":"SonarQube.MSBuild.Tasks/Targets/SonarQube.Integration.targets","position":55,"original_position":55,"commit_id":"0fab4367ad43c1982e5215ba8ecaae5190391115","original_commit_id":"0fab4367ad43c1982e5215ba8ecaae5190391115","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"body":"@dbolkensteyn Yep. I've corrected it here and in lines 421 and 424 as well (and fixed a \"Rolsyn\" typo). It'll be part of my next PR.","created_at":"2015-11-19T10:16:54Z","updated_at":"2015-11-19T10:16:54Z","html_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131#discussion_r45322385","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments/45322385"},"html":{"href":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131#discussion_r45322385"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131","id":50260822,"html_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131","diff_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131.diff","patch_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/131","number":131,"state":"closed","locked":false,"title":"Update targets files to override Roslyn code analysis properties","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"body":"The targets now look for a well-known ruleset name on disc and configures the Roslyn analysis based on whether the file exists or not.\r\nCurrently the Roslyn ruleset is separate from the FxCop ruleset. The build properties are set appropriately so the correct ruleset is used. However, it might be simpler to generate a single combined ruleset file and use that - I'll see how it works out in practice.","created_at":"2015-11-10T14:37:38Z","updated_at":"2015-11-19T10:16:54Z","closed_at":"2015-11-11T08:11:15Z","merged_at":"2015-11-11T08:11:15Z","merge_commit_sha":"07375d96a44a873de971a1003e7cd35453a08185","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/131/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/0fab4367ad43c1982e5215ba8ecaae5190391115","head":{"label":"duncanpMS:sonarmsbru-164","ref":"sonarmsbru-164","sha":"0fab4367ad43c1982e5215ba8ecaae5190391115","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"repo":{"id":36438614,"name":"sonar-msbuild-runner","full_name":"duncanpMS/sonar-msbuild-runner","owner":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duncanpMS/sonar-msbuild-runner","description":"","fork":true,"url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner","forks_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/forks","keys_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/teams","hooks_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/hooks","issue_events_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/issues/events{/number}","events_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/events","assignees_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/assignees{/user}","branches_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/branches{/branch}","tags_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/tags","blobs_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/languages","stargazers_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/stargazers","contributors_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/contributors","subscribers_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/subscribers","subscription_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/subscription","commits_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/contents/{+path}","compare_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/merges","archive_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/downloads","issues_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/issues{/number}","pulls_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/labels{/name}","releases_url":"https://api.github.com/repos/duncanpMS/sonar-msbuild-runner/releases{/id}","created_at":"2015-05-28T13:02:03Z","updated_at":"2015-08-27T20:11:31Z","pushed_at":"2015-11-19T10:09:49Z","git_url":"git://github.com/duncanpMS/sonar-msbuild-runner.git","ssh_url":"git@github.com:duncanpMS/sonar-msbuild-runner.git","clone_url":"https://github.com/duncanpMS/sonar-msbuild-runner.git","svn_url":"https://github.com/duncanpMS/sonar-msbuild-runner","homepage":null,"size":2862,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"8a61f9f4b6c3555a0450de6f50cb9ed447bb0696","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":34444711,"name":"sonar-msbuild-runner","full_name":"SonarSource/sonar-msbuild-runner","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-msbuild-runner","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner","forks_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/releases{/id}","created_at":"2015-04-23T08:45:40Z","updated_at":"2015-11-18T07:58:58Z","pushed_at":"2015-11-19T09:45:31Z","git_url":"git://github.com/SonarSource/sonar-msbuild-runner.git","ssh_url":"git@github.com:SonarSource/sonar-msbuild-runner.git","clone_url":"https://github.com/SonarSource/sonar-msbuild-runner.git","svn_url":"https://github.com/SonarSource/sonar-msbuild-runner","homepage":null,"size":2950,"stargazers_count":23,"watchers_count":23,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":3,"forks":22,"open_issues":3,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131"},"html":{"href":"https://github.com/SonarSource/sonar-msbuild-runner/pull/131"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/131"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/0fab4367ad43c1982e5215ba8ecaae5190391115"}}}}