{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/43575825","id":43575825,"diff_hunk":"@@ -0,0 +1,178 @@\n+# Copyright 1999-2015 Gentoo Foundation\n+# Distributed under the terms of the GNU General Public License v2\n+# $Id$\n+\n+EAPI=\"5\"\n+PYTHON_COMPAT=( python2_7 )\n+\n+WX_GTK_VER=\"3.0\"\n+\n+inherit bzr cmake-utils fdo-mime flag-o-matic gnome2-utils python-r1 vcs-snapshot wxwidgets versionator\n+\n+DESCRIPTION=\"Electronic Schematic and PCB design tools.\"\n+HOMEPAGE=\"http://www.kicad-pcb.org\"\n+\n+SERIES=$(get_version_component_range 1-2)\n+MY_PV=$(replace_version_separator 3 '-')\n+\n+LIB_REVISION=\"bd0ec6a20c7cc0556093f60eac723e4505947784\"\n+DOC_REVISION=\"0d0ed7b9de3afbba5d51fb6d7a25834000ed1099\"\n+I18N_REVISION=\"bf793d30d64f4e75ea7a109ea434c1a27926b158\"\n+\n+SRC_URI=\"https://launchpad.net/${PN}/${SERIES}/${MY_PV}/+download/${PN}-${MY_PV}.tar.xz","path":"sci-electronics/kicad/kicad-4.0.0_rc1.ebuild","position":22,"original_position":22,"commit_id":"8dcf98719a8133349e5c4bff489c0e820a5f44ac","original_commit_id":"8dcf98719a8133349e5c4bff489c0e820a5f44ac","user":{"login":"hasufell","id":1241845,"avatar_url":"https://avatars.githubusercontent.com/u/1241845?v=3","gravatar_id":"","url":"https://api.github.com/users/hasufell","html_url":"https://github.com/hasufell","followers_url":"https://api.github.com/users/hasufell/followers","following_url":"https://api.github.com/users/hasufell/following{/other_user}","gists_url":"https://api.github.com/users/hasufell/gists{/gist_id}","starred_url":"https://api.github.com/users/hasufell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasufell/subscriptions","organizations_url":"https://api.github.com/users/hasufell/orgs","repos_url":"https://api.github.com/users/hasufell/repos","events_url":"https://api.github.com/users/hasufell/events{/privacy}","received_events_url":"https://api.github.com/users/hasufell/received_events","type":"User","site_admin":false},"body":"that's not $PN, but $P which includes $PV... $PV should never be hardcoded in SRC_URI. Those are two different things","created_at":"2015-10-31T20:25:01Z","updated_at":"2015-10-31T20:25:01Z","html_url":"https://github.com/gentoo/gentoo/pull/313#discussion_r43575825","pull_request_url":"https://api.github.com/repos/gentoo/gentoo/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/43575825"},"html":{"href":"https://github.com/gentoo/gentoo/pull/313#discussion_r43575825"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/313","id":49352735,"html_url":"https://github.com/gentoo/gentoo/pull/313","diff_url":"https://github.com/gentoo/gentoo/pull/313.diff","patch_url":"https://github.com/gentoo/gentoo/pull/313.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/313","number":313,"state":"open","locked":false,"title":"Kicad 4.0.0 rc1","user":{"login":"zpuskas","id":6266669,"avatar_url":"https://avatars.githubusercontent.com/u/6266669?v=3","gravatar_id":"","url":"https://api.github.com/users/zpuskas","html_url":"https://github.com/zpuskas","followers_url":"https://api.github.com/users/zpuskas/followers","following_url":"https://api.github.com/users/zpuskas/following{/other_user}","gists_url":"https://api.github.com/users/zpuskas/gists{/gist_id}","starred_url":"https://api.github.com/users/zpuskas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpuskas/subscriptions","organizations_url":"https://api.github.com/users/zpuskas/orgs","repos_url":"https://api.github.com/users/zpuskas/repos","events_url":"https://api.github.com/users/zpuskas/events{/privacy}","received_events_url":"https://api.github.com/users/zpuskas/received_events","type":"User","site_admin":false},"body":"Adding new kicad ebuild. Changes addressed as per IRC chat. Details of change in commit message.\r\n\r\ncc: @idella @gktrk\r\nfor the record: @jlec ","created_at":"2015-10-31T16:20:35Z","updated_at":"2015-10-31T20:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f53f39cac55aaa4e86555002693dfc837e94bbc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo/pulls/313/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo/pulls/313/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/313/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/8dcf98719a8133349e5c4bff489c0e820a5f44ac","head":{"label":"zpuskas:kicad-4.0.0-rc1","ref":"kicad-4.0.0-rc1","sha":"8dcf98719a8133349e5c4bff489c0e820a5f44ac","user":{"login":"zpuskas","id":6266669,"avatar_url":"https://avatars.githubusercontent.com/u/6266669?v=3","gravatar_id":"","url":"https://api.github.com/users/zpuskas","html_url":"https://github.com/zpuskas","followers_url":"https://api.github.com/users/zpuskas/followers","following_url":"https://api.github.com/users/zpuskas/following{/other_user}","gists_url":"https://api.github.com/users/zpuskas/gists{/gist_id}","starred_url":"https://api.github.com/users/zpuskas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpuskas/subscriptions","organizations_url":"https://api.github.com/users/zpuskas/orgs","repos_url":"https://api.github.com/users/zpuskas/repos","events_url":"https://api.github.com/users/zpuskas/events{/privacy}","received_events_url":"https://api.github.com/users/zpuskas/received_events","type":"User","site_admin":false},"repo":{"id":44742958,"name":"gentoo","full_name":"zpuskas/gentoo","owner":{"login":"zpuskas","id":6266669,"avatar_url":"https://avatars.githubusercontent.com/u/6266669?v=3","gravatar_id":"","url":"https://api.github.com/users/zpuskas","html_url":"https://github.com/zpuskas","followers_url":"https://api.github.com/users/zpuskas/followers","following_url":"https://api.github.com/users/zpuskas/following{/other_user}","gists_url":"https://api.github.com/users/zpuskas/gists{/gist_id}","starred_url":"https://api.github.com/users/zpuskas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpuskas/subscriptions","organizations_url":"https://api.github.com/users/zpuskas/orgs","repos_url":"https://api.github.com/users/zpuskas/repos","events_url":"https://api.github.com/users/zpuskas/events{/privacy}","received_events_url":"https://api.github.com/users/zpuskas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpuskas/gentoo","description":"The official mirror the Gentoo ebuild repository (now in true git!)","fork":true,"url":"https://api.github.com/repos/zpuskas/gentoo","forks_url":"https://api.github.com/repos/zpuskas/gentoo/forks","keys_url":"https://api.github.com/repos/zpuskas/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpuskas/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpuskas/gentoo/teams","hooks_url":"https://api.github.com/repos/zpuskas/gentoo/hooks","issue_events_url":"https://api.github.com/repos/zpuskas/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/zpuskas/gentoo/events","assignees_url":"https://api.github.com/repos/zpuskas/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/zpuskas/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/zpuskas/gentoo/tags","blobs_url":"https://api.github.com/repos/zpuskas/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpuskas/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpuskas/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpuskas/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpuskas/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/zpuskas/gentoo/languages","stargazers_url":"https://api.github.com/repos/zpuskas/gentoo/stargazers","contributors_url":"https://api.github.com/repos/zpuskas/gentoo/contributors","subscribers_url":"https://api.github.com/repos/zpuskas/gentoo/subscribers","subscription_url":"https://api.github.com/repos/zpuskas/gentoo/subscription","commits_url":"https://api.github.com/repos/zpuskas/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpuskas/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpuskas/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpuskas/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpuskas/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/zpuskas/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpuskas/gentoo/merges","archive_url":"https://api.github.com/repos/zpuskas/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpuskas/gentoo/downloads","issues_url":"https://api.github.com/repos/zpuskas/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/zpuskas/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/zpuskas/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/zpuskas/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpuskas/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/zpuskas/gentoo/releases{/id}","created_at":"2015-10-22T12:12:43Z","updated_at":"2015-10-21T16:08:15Z","pushed_at":"2015-10-31T20:16:56Z","git_url":"git://github.com/zpuskas/gentoo.git","ssh_url":"git@github.com:zpuskas/gentoo.git","clone_url":"https://github.com/zpuskas/gentoo.git","svn_url":"https://github.com/zpuskas/gentoo","homepage":null,"size":91139,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"70e304f4a946ded932efc2a9a2f1637053129802","user":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":40499714,"name":"gentoo","full_name":"gentoo/gentoo","owner":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/gentoo","description":"The official mirror the Gentoo ebuild repository (now in true git!)","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo","forks_url":"https://api.github.com/repos/gentoo/gentoo/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo/releases{/id}","created_at":"2015-08-10T18:47:32Z","updated_at":"2015-10-31T10:18:13Z","pushed_at":"2015-10-31T19:42:48Z","git_url":"git://github.com/gentoo/gentoo.git","ssh_url":"git@github.com:gentoo/gentoo.git","clone_url":"https://github.com/gentoo/gentoo.git","svn_url":"https://github.com/gentoo/gentoo","homepage":null,"size":117257,"stargazers_count":160,"watchers_count":160,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":28,"forks":101,"open_issues":28,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/313"},"html":{"href":"https://github.com/gentoo/gentoo/pull/313"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/313"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo/statuses/8dcf98719a8133349e5c4bff489c0e820a5f44ac"}}}}