{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/15136","labels_url":"https://api.github.com/repos/twbs/bootstrap/issues/15136/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/15136/comments","events_url":"https://api.github.com/repos/twbs/bootstrap/issues/15136/events","html_url":"https://github.com/twbs/bootstrap/issues/15136","id":48806228,"number":15136,"title":"Modal Backdrop (nearly) never fits","user":{"login":"DaSchTour","id":1907266,"avatar_url":"https://avatars.githubusercontent.com/u/1907266?v=3","gravatar_id":"","url":"https://api.github.com/users/DaSchTour","html_url":"https://github.com/DaSchTour","followers_url":"https://api.github.com/users/DaSchTour/followers","following_url":"https://api.github.com/users/DaSchTour/following{/other_user}","gists_url":"https://api.github.com/users/DaSchTour/gists{/gist_id}","starred_url":"https://api.github.com/users/DaSchTour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaSchTour/subscriptions","organizations_url":"https://api.github.com/users/DaSchTour/orgs","repos_url":"https://api.github.com/users/DaSchTour/repos","events_url":"https://api.github.com/users/DaSchTour/events{/privacy}","received_events_url":"https://api.github.com/users/DaSchTour/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/twbs/bootstrap/labels/js","name":"js","color":"ffc40d"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/twbs/bootstrap/milestones/30","labels_url":"https://api.github.com/repos/twbs/bootstrap/milestones/30/labels","id":927525,"number":30,"title":"v3.3.4","description":"Skipping over v3.3.3 due to\r\nhttps://github.com/twbs/bootstrap-sass/commit/107ca189e406bbe314eb84f0372ed3706b81c761","creator":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":8,"state":"open","created_at":"2015-01-08T19:01:33Z","updated_at":"2015-01-21T09:29:50Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2014-11-14T16:05:10Z","updated_at":"2015-01-21T14:13:18Z","closed_at":null,"body":"Because of the change with modal backdrop and the new function from #15106 there are a lot of problems with the modal backdrop now.\r\n1. It's a major break in backward compatibility. I have to rewrite the complete handling of modals to ensure that with every action inside the modal the backdrop is updated\r\n2. Even bootstraps own functions don't use the modal handling. So with every collapsable panel inside a modal I will have problems with the backdrop.\r\n3. Why the hell was this changed in 3.3.0? From my point of view the modals worked perfectly before 3.3.0!\r\n4. Is there any solution to attach a \"size changes\" handler to the modal that updates the modal without having to manually call the the update handler?\r\n"},"comment":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/70843412","html_url":"https://github.com/twbs/bootstrap/issues/15136#issuecomment-70843412","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/15136","id":70843412,"user":{"login":"sdalezman","id":3371541,"avatar_url":"https://avatars.githubusercontent.com/u/3371541?v=3","gravatar_id":"","url":"https://api.github.com/users/sdalezman","html_url":"https://github.com/sdalezman","followers_url":"https://api.github.com/users/sdalezman/followers","following_url":"https://api.github.com/users/sdalezman/following{/other_user}","gists_url":"https://api.github.com/users/sdalezman/gists{/gist_id}","starred_url":"https://api.github.com/users/sdalezman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdalezman/subscriptions","organizations_url":"https://api.github.com/users/sdalezman/orgs","repos_url":"https://api.github.com/users/sdalezman/repos","events_url":"https://api.github.com/users/sdalezman/events{/privacy}","received_events_url":"https://api.github.com/users/sdalezman/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T14:13:18Z","updated_at":"2015-01-21T14:13:18Z","body":"@hnrch02 I agree to the `position: fixed;` + padding fix, but I am pretty sure most browsers hide the scroll bar if you aren't currently scrolling by default (chrome, safari, ff on mac osx). On Safari in osx if you switch back to position fixed though the scroll bar doesn't appear even when a user scrolls. So not really sure it's a viable solution because then [#14916](https://github.com/twbs/bootstrap/issues/14916) is reintroduced as a usability problem in safari. \r\n\r\nAnother solution might be to dynamically check the height of the modal after it is show and compare the modal inner + outer height to the window height, if the modal inner + outer is greater apply the padding to take into account the scroll bar. However, I am not sure if the code maintenance on something so minor is really worth it and it wouldn't solve the problem on safari. \r\n\r\n@DaSchTour  if you want to go back to the way it was before just add to your css:\r\n``` css\r\n.modal-backdrop {\r\n  position: fixed;\r\n  bottom: 0;\r\n  height: auto !important; \\\\ to override bootstrap defined height which won't take into account dynamic height\r\n}\r\n```"}}