{"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments/29430106","id":29430106,"diff_hunk":"@@ -326,6 +329,66 @@ public function userManagerSetFactoryProvider()\n         );\n     }\n \n+    /**\n+     * @dataProvider loadRoutingProvider\n+     */\n+    public function testLoadRouting($routeName, $path, array $methods)","path":"Tests/DependencyInjection/FOSUserExtensionTest.php","position":20,"original_position":20,"commit_id":"2b88392082eb6ae44daa332af9310a2c25b3de16","original_commit_id":"2b88392082eb6ae44daa332af9310a2c25b3de16","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"a new testcase dedicated to checking the routing files","created_at":"2015-04-30T13:46:33Z","updated_at":"2015-04-30T13:46:33Z","html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823#discussion_r29430106","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments/29430106"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823#discussion_r29430106"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823"}}},"pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823","id":34217419,"html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823","diff_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823.patch","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/1823","number":1823,"state":"open","locked":false,"title":"Fix deprecated routing configuration","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"This PR fix deprecated routing config throwing related errors:\r\n\r\n> The \"pattern\" is deprecated since version 2.2 and will be removed in 3.0. Use the \"path\" option in the route definition instead.\r\n\r\n> The \"_method\" requirement is deprecated since version 2.2 and will be removed in 3.0. Use the setMethods() method instead or the \"methods\" option in the route definition.\r\n\r\nThe added tests reveal the errors by loading routing configuration files.","created_at":"2015-04-27T22:33:28Z","updated_at":"2015-04-30T13:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e231c58b8d857331cbea30cab54c22f083574271","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823/commits","review_comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823/comments","review_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/1823/comments","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/2b88392082eb6ae44daa332af9310a2c25b3de16","head":{"label":"Soullivaneuh:deprecated-routing","ref":"deprecated-routing","sha":"2b88392082eb6ae44daa332af9310a2c25b3de16","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"repo":{"id":34314118,"name":"FOSUserBundle","full_name":"Soullivaneuh/FOSUserBundle","owner":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Soullivaneuh/FOSUserBundle","description":"Provides user management for your Symfony2 Project. Compatible with Doctrine ORM & ODM, and Propel.","fork":true,"url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle","forks_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/forks","keys_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/teams","hooks_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/hooks","issue_events_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/events","assignees_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/tags","blobs_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/languages","stargazers_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/stargazers","contributors_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/contributors","subscribers_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/subscribers","subscription_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/subscription","commits_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/merges","archive_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/downloads","issues_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/labels{/name}","releases_url":"https://api.github.com/repos/Soullivaneuh/FOSUserBundle/releases{/id}","created_at":"2015-04-21T08:24:29Z","updated_at":"2015-04-21T08:24:32Z","pushed_at":"2015-04-30T13:45:15Z","git_url":"git://github.com/Soullivaneuh/FOSUserBundle.git","ssh_url":"git@github.com:Soullivaneuh/FOSUserBundle.git","clone_url":"https://github.com/Soullivaneuh/FOSUserBundle.git","svn_url":"https://github.com/Soullivaneuh/FOSUserBundle","homepage":"http://friendsofsymfony.github.com/","size":3407,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfSymfony:master","ref":"master","sha":"192c53916942847aee687722af54f431aead0b70","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":1193527,"name":"FOSUserBundle","full_name":"FriendsOfSymfony/FOSUserBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle","description":"Provides user management for your Symfony2 Project. Compatible with Doctrine ORM & ODM, and Propel.","fork":true,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/releases{/id}","created_at":"2010-12-23T15:50:55Z","updated_at":"2015-04-30T13:32:58Z","pushed_at":"2015-04-30T13:45:16Z","git_url":"git://github.com/FriendsOfSymfony/FOSUserBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSUserBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSUserBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSUserBundle","homepage":"http://friendsofsymfony.github.com/","size":7616,"stargazers_count":1929,"watchers_count":1929,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1095,"mirror_url":null,"open_issues_count":302,"forks":1095,"open_issues":302,"watchers":1929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/1823"},"issue":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/1823"},"comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/1823/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/1823/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/2b88392082eb6ae44daa332af9310a2c25b3de16"}}}}