{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/23130489","id":23130489,"diff_hunk":"@@ -44,42 +44,62 @@ class TaskMetrics extends Serializable {\n   /**\n    * Host's name the task runs on\n    */\n-  var hostname: String = _\n-\n+  private var _hostname: String = _\n+  def hostname = _hostname\n+  private[spark] def setHostname(value : String) = _hostname = value","path":"core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala","position":8,"original_position":8,"commit_id":"39f3810f6583cc257635b295205ae94b0cdee053","original_commit_id":"39f3810f6583cc257635b295205ae94b0cdee053","user":{"login":"pwendell","id":320616,"avatar_url":"https://avatars.githubusercontent.com/u/320616?v=3","gravatar_id":"","url":"https://api.github.com/users/pwendell","html_url":"https://github.com/pwendell","followers_url":"https://api.github.com/users/pwendell/followers","following_url":"https://api.github.com/users/pwendell/following{/other_user}","gists_url":"https://api.github.com/users/pwendell/gists{/gist_id}","starred_url":"https://api.github.com/users/pwendell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwendell/subscriptions","organizations_url":"https://api.github.com/users/pwendell/orgs","repos_url":"https://api.github.com/users/pwendell/repos","events_url":"https://api.github.com/users/pwendell/events{/privacy}","received_events_url":"https://api.github.com/users/pwendell/received_events","type":"User","site_admin":false},"body":"`Should be \"value: String\"` with no space (not sure why our style checks didn't catch this).","created_at":"2015-01-18T03:13:05Z","updated_at":"2015-01-18T03:13:05Z","html_url":"https://github.com/apache/spark/pull/4020#discussion_r23130489","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4020","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/23130489"},"html":{"href":"https://github.com/apache/spark/pull/4020#discussion_r23130489"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4020"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4020","id":27290063,"html_url":"https://github.com/apache/spark/pull/4020","diff_url":"https://github.com/apache/spark/pull/4020.diff","patch_url":"https://github.com/apache/spark/pull/4020.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4020","number":4020,"state":"open","locked":false,"title":"[SPARK-3288] All fields in TaskMetrics should be private and use getters/setters","user":{"login":"ilganeli","id":1483345,"avatar_url":"https://avatars.githubusercontent.com/u/1483345?v=3","gravatar_id":"","url":"https://api.github.com/users/ilganeli","html_url":"https://github.com/ilganeli","followers_url":"https://api.github.com/users/ilganeli/followers","following_url":"https://api.github.com/users/ilganeli/following{/other_user}","gists_url":"https://api.github.com/users/ilganeli/gists{/gist_id}","starred_url":"https://api.github.com/users/ilganeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilganeli/subscriptions","organizations_url":"https://api.github.com/users/ilganeli/orgs","repos_url":"https://api.github.com/users/ilganeli/repos","events_url":"https://api.github.com/users/ilganeli/events{/privacy}","received_events_url":"https://api.github.com/users/ilganeli/received_events","type":"User","site_admin":false},"body":"I've updated the fields and all usages of these fields in the Spark code. I've verified that this did not break anything on my local repo. ","created_at":"2015-01-13T17:49:09Z","updated_at":"2015-01-18T03:13:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b96cd1ae727b96f9f01d8ccf9d24725f2e63cff5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4020/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4020/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4020/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/39f3810f6583cc257635b295205ae94b0cdee053","head":{"label":"ilganeli:SPARK-3288","ref":"SPARK-3288","sha":"39f3810f6583cc257635b295205ae94b0cdee053","user":{"login":"ilganeli","id":1483345,"avatar_url":"https://avatars.githubusercontent.com/u/1483345?v=3","gravatar_id":"","url":"https://api.github.com/users/ilganeli","html_url":"https://github.com/ilganeli","followers_url":"https://api.github.com/users/ilganeli/followers","following_url":"https://api.github.com/users/ilganeli/following{/other_user}","gists_url":"https://api.github.com/users/ilganeli/gists{/gist_id}","starred_url":"https://api.github.com/users/ilganeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilganeli/subscriptions","organizations_url":"https://api.github.com/users/ilganeli/orgs","repos_url":"https://api.github.com/users/ilganeli/repos","events_url":"https://api.github.com/users/ilganeli/events{/privacy}","received_events_url":"https://api.github.com/users/ilganeli/received_events","type":"User","site_admin":false},"repo":{"id":24374828,"name":"spark","full_name":"ilganeli/spark","owner":{"login":"ilganeli","id":1483345,"avatar_url":"https://avatars.githubusercontent.com/u/1483345?v=3","gravatar_id":"","url":"https://api.github.com/users/ilganeli","html_url":"https://github.com/ilganeli","followers_url":"https://api.github.com/users/ilganeli/followers","following_url":"https://api.github.com/users/ilganeli/following{/other_user}","gists_url":"https://api.github.com/users/ilganeli/gists{/gist_id}","starred_url":"https://api.github.com/users/ilganeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilganeli/subscriptions","organizations_url":"https://api.github.com/users/ilganeli/orgs","repos_url":"https://api.github.com/users/ilganeli/repos","events_url":"https://api.github.com/users/ilganeli/events{/privacy}","received_events_url":"https://api.github.com/users/ilganeli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilganeli/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ilganeli/spark","forks_url":"https://api.github.com/repos/ilganeli/spark/forks","keys_url":"https://api.github.com/repos/ilganeli/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilganeli/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilganeli/spark/teams","hooks_url":"https://api.github.com/repos/ilganeli/spark/hooks","issue_events_url":"https://api.github.com/repos/ilganeli/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ilganeli/spark/events","assignees_url":"https://api.github.com/repos/ilganeli/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ilganeli/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ilganeli/spark/tags","blobs_url":"https://api.github.com/repos/ilganeli/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilganeli/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilganeli/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilganeli/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilganeli/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ilganeli/spark/languages","stargazers_url":"https://api.github.com/repos/ilganeli/spark/stargazers","contributors_url":"https://api.github.com/repos/ilganeli/spark/contributors","subscribers_url":"https://api.github.com/repos/ilganeli/spark/subscribers","subscription_url":"https://api.github.com/repos/ilganeli/spark/subscription","commits_url":"https://api.github.com/repos/ilganeli/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilganeli/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilganeli/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilganeli/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilganeli/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ilganeli/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilganeli/spark/merges","archive_url":"https://api.github.com/repos/ilganeli/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilganeli/spark/downloads","issues_url":"https://api.github.com/repos/ilganeli/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ilganeli/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ilganeli/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ilganeli/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilganeli/spark/labels{/name}","releases_url":"https://api.github.com/repos/ilganeli/spark/releases{/id}","created_at":"2014-09-23T14:30:54Z","updated_at":"2014-12-17T18:17:41Z","pushed_at":"2015-01-16T19:49:02Z","git_url":"git://github.com/ilganeli/spark.git","ssh_url":"git@github.com:ilganeli/spark.git","clone_url":"https://github.com/ilganeli/spark.git","svn_url":"https://github.com/ilganeli/spark","homepage":null,"size":87826,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e8422c521bc76bc4b03c337605f136403ea9f64a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-01-18T01:36:22Z","pushed_at":"2015-01-18T01:36:22Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1151264,"stargazers_count":2590,"watchers_count":2590,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2283,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":317,"forks":2283,"open_issues":317,"watchers":2590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4020"},"html":{"href":"https://github.com/apache/spark/pull/4020"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4020"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4020/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4020/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4020/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/39f3810f6583cc257635b295205ae94b0cdee053"}}}}