{"action":"closed","number":11342,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/11342","id":53554616,"html_url":"https://github.com/laravel/framework/pull/11342","diff_url":"https://github.com/laravel/framework/pull/11342.diff","patch_url":"https://github.com/laravel/framework/pull/11342.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/11342","number":11342,"state":"closed","locked":false,"title":"Add trim() to validateUnique() $column variable","user":{"login":"ludo237","id":921500,"avatar_url":"https://avatars.githubusercontent.com/u/921500?v=3","gravatar_id":"","url":"https://api.github.com/users/ludo237","html_url":"https://github.com/ludo237","followers_url":"https://api.github.com/users/ludo237/followers","following_url":"https://api.github.com/users/ludo237/following{/other_user}","gists_url":"https://api.github.com/users/ludo237/gists{/gist_id}","starred_url":"https://api.github.com/users/ludo237/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludo237/subscriptions","organizations_url":"https://api.github.com/users/ludo237/orgs","repos_url":"https://api.github.com/users/ludo237/repos","events_url":"https://api.github.com/users/ludo237/events{/privacy}","received_events_url":"https://api.github.com/users/ludo237/received_events","type":"User","site_admin":false},"body":"# Problem\r\n\r\nWhen you use the `unique` validation key you can specify the table name, the column involved and other cool stuff. If you try to write a validation like this\r\n\r\n```PHP\r\n\r\n\"email\" => \"required|unique:users, email\",\r\n\r\n```\r\n\r\nIt will not works\r\n\r\n# Error\r\n\r\nThe error thrown is about the fact that the application is not able to find the column ` email` with a space in it\r\n\r\n```\r\nQueryException in Connection.php line 653:\r\nSQLSTATE[42S22]: Column not found: Unknown column ' email' in 'where clause' (SQL: select count(*) as aggregate from `users` where ` email` = laravel@homestead and `id` <> 1)\r\n```\r\n\r\n# Suggested Fix\r\n\r\nThis is pretty straightforward and simple just add the `trim` function the current column inside `Validator.php`\r\n\r\n```PHP\r\n $column = isset($parameters[1]) ? $parameters[1] : $attribute;\r\n $column = trim($column);\r\n```\r\n\r\n# Suggested Fix 2\r\n\r\nIf the `trim` function seems over power for this task you could simply remove the space from the name by using replacing the first char like so\r\n\r\n```PHP\r\n $column = isset($parameters[1]) ? $parameters[1] : $attribute;\r\n $column[0] = null;\r\n``` \r\n\r\nLet me know what do you think about this.","created_at":"2015-12-14T11:46:37Z","updated_at":"2015-12-14T14:30:14Z","closed_at":"2015-12-14T14:30:14Z","merged_at":null,"merge_commit_sha":"6cdcd393ebc5df00ffdc2828ff2a2bcd38824162","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/11342/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/11342/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/11342/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/956af2494dff966ae2d82008b718965d1bae9951","head":{"label":"ludo237:5.1","ref":"5.1","sha":"956af2494dff966ae2d82008b718965d1bae9951","user":{"login":"ludo237","id":921500,"avatar_url":"https://avatars.githubusercontent.com/u/921500?v=3","gravatar_id":"","url":"https://api.github.com/users/ludo237","html_url":"https://github.com/ludo237","followers_url":"https://api.github.com/users/ludo237/followers","following_url":"https://api.github.com/users/ludo237/following{/other_user}","gists_url":"https://api.github.com/users/ludo237/gists{/gist_id}","starred_url":"https://api.github.com/users/ludo237/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludo237/subscriptions","organizations_url":"https://api.github.com/users/ludo237/orgs","repos_url":"https://api.github.com/users/ludo237/repos","events_url":"https://api.github.com/users/ludo237/events{/privacy}","received_events_url":"https://api.github.com/users/ludo237/received_events","type":"User","site_admin":false},"repo":{"id":47971587,"name":"framework","full_name":"ludo237/framework","owner":{"login":"ludo237","id":921500,"avatar_url":"https://avatars.githubusercontent.com/u/921500?v=3","gravatar_id":"","url":"https://api.github.com/users/ludo237","html_url":"https://github.com/ludo237","followers_url":"https://api.github.com/users/ludo237/followers","following_url":"https://api.github.com/users/ludo237/following{/other_user}","gists_url":"https://api.github.com/users/ludo237/gists{/gist_id}","starred_url":"https://api.github.com/users/ludo237/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludo237/subscriptions","organizations_url":"https://api.github.com/users/ludo237/orgs","repos_url":"https://api.github.com/users/ludo237/repos","events_url":"https://api.github.com/users/ludo237/events{/privacy}","received_events_url":"https://api.github.com/users/ludo237/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ludo237/framework","description":"","fork":true,"url":"https://api.github.com/repos/ludo237/framework","forks_url":"https://api.github.com/repos/ludo237/framework/forks","keys_url":"https://api.github.com/repos/ludo237/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ludo237/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ludo237/framework/teams","hooks_url":"https://api.github.com/repos/ludo237/framework/hooks","issue_events_url":"https://api.github.com/repos/ludo237/framework/issues/events{/number}","events_url":"https://api.github.com/repos/ludo237/framework/events","assignees_url":"https://api.github.com/repos/ludo237/framework/assignees{/user}","branches_url":"https://api.github.com/repos/ludo237/framework/branches{/branch}","tags_url":"https://api.github.com/repos/ludo237/framework/tags","blobs_url":"https://api.github.com/repos/ludo237/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ludo237/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ludo237/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ludo237/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ludo237/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ludo237/framework/languages","stargazers_url":"https://api.github.com/repos/ludo237/framework/stargazers","contributors_url":"https://api.github.com/repos/ludo237/framework/contributors","subscribers_url":"https://api.github.com/repos/ludo237/framework/subscribers","subscription_url":"https://api.github.com/repos/ludo237/framework/subscription","commits_url":"https://api.github.com/repos/ludo237/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ludo237/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ludo237/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ludo237/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ludo237/framework/contents/{+path}","compare_url":"https://api.github.com/repos/ludo237/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ludo237/framework/merges","archive_url":"https://api.github.com/repos/ludo237/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ludo237/framework/downloads","issues_url":"https://api.github.com/repos/ludo237/framework/issues{/number}","pulls_url":"https://api.github.com/repos/ludo237/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ludo237/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ludo237/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ludo237/framework/labels{/name}","releases_url":"https://api.github.com/repos/ludo237/framework/releases{/id}","created_at":"2015-12-14T11:38:56Z","updated_at":"2015-12-14T11:38:59Z","pushed_at":"2015-12-14T12:02:47Z","git_url":"git://github.com/ludo237/framework.git","ssh_url":"git@github.com:ludo237/framework.git","clone_url":"https://github.com/ludo237/framework.git","svn_url":"https://github.com/ludo237/framework","homepage":"http://laravel.com","size":20071,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"bdbec18afd20f22b06552fb209fe1c26c00f57fb","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-12-14T13:32:55Z","pushed_at":"2015-12-14T12:23:21Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":32880,"stargazers_count":4490,"watchers_count":4490,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2575,"mirror_url":null,"open_issues_count":84,"forks":2575,"open_issues":84,"watchers":4490,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/11342"},"html":{"href":"https://github.com/laravel/framework/pull/11342"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/11342"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/11342/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/11342/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/11342/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/956af2494dff966ae2d82008b718965d1bae9951"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":3,"deletions":1,"changed_files":1}}