{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/159","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/159/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/159/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/159","id":110745305,"number":159,"title":"(Re)Enable last scroll position restore for continue reading feature","user":{"login":"coreyfloyd","id":64771,"avatar_url":"https://avatars.githubusercontent.com/u/64771?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyfloyd","html_url":"https://github.com/coreyfloyd","followers_url":"https://api.github.com/users/coreyfloyd/followers","following_url":"https://api.github.com/users/coreyfloyd/following{/other_user}","gists_url":"https://api.github.com/users/coreyfloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyfloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyfloyd/subscriptions","organizations_url":"https://api.github.com/users/coreyfloyd/orgs","repos_url":"https://api.github.com/users/coreyfloyd/repos","events_url":"https://api.github.com/users/coreyfloyd/events{/privacy}","received_events_url":"https://api.github.com/users/coreyfloyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-09T22:21:24Z","updated_at":"2015-10-13T01:38:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/159","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/159","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/159.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/159.patch"},"body":"This enables articles shown on startup (restore) or articles shown from the continue reading section to restore their previous offset (using the legacy logic which used the discovery method to decide whether or not to scroll a user to the previous offset)\r\n\r\n**IMPORTANT:** For evaluating this pull request, please look at each commit in order. They explain why changes were made along the way. Its probably best i walk you through.\r\n\r\nTL;DR\r\nPeeled an onion here. Basically, we needed to pass down the discovery method to the web view controller to get this working again. This involved changing some APIs, and from there I had decisions of whether to update old (soon to be deleted) code to work with the new APIs or delete the old code. I went with the latter. As noted above, I left a detailed story along the way to explain why some refactors were completed.\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/147569992","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/159#issuecomment-147569992","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/159","id":147569992,"user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T01:38:13Z","updated_at":"2015-10-13T01:38:13Z","body":"I'll try to push a commit tonight if I can get it all wrangled in the next hour or so..."}}