{"action":"created","comment":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/35932790","id":35932790,"diff_hunk":"@@ -56,8 +56,8 @@ public void StoreRetrieve()\n             FileAssert.AreEqual(file, cached_file);\n         }\n \n-        [Test, TestCase(\"cheesy.zip\",\"cheesy.zip\"), TestCase(\"Foo-1:2.3\",\"Foo-1-2.3\"),\n-            TestCase(\"Foo-1:2:3\",\"Foo-1-2-3\"), TestCase(\"Foo/../etc/passwd\",\"Foo-..-etc-passwd\")]\n+        [Test, TestCase(\"cheesy.zip\",\"cheesy.zip\"), TestCase(\"Foo-1-2.3\",\"Foo-1-2.3\"),\n+            TestCase(\"Foo-1-2-3\",\"Foo-1-2-3\"), TestCase(\"Foo-..-etc-passwd\",\"Foo-..-etc-passwd\")]","path":"Tests/Core/Cache.cs","position":7,"original_position":7,"commit_id":"0d76a51008d09b7347466d78f546e88568d3e5f5","original_commit_id":"0d76a51008d09b7347466d78f546e88568d3e5f5","user":{"login":"pjf","id":12072,"avatar_url":"https://avatars.githubusercontent.com/u/12072?v=3","gravatar_id":"","url":"https://api.github.com/users/pjf","html_url":"https://github.com/pjf","followers_url":"https://api.github.com/users/pjf/followers","following_url":"https://api.github.com/users/pjf/following{/other_user}","gists_url":"https://api.github.com/users/pjf/gists{/gist_id}","starred_url":"https://api.github.com/users/pjf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjf/subscriptions","organizations_url":"https://api.github.com/users/pjf/orgs","repos_url":"https://api.github.com/users/pjf/repos","events_url":"https://api.github.com/users/pjf/events{/privacy}","received_events_url":"https://api.github.com/users/pjf/received_events","type":"User","site_admin":false},"body":"Just to confirm, we've changed these tests because the assumption is that we'll always pass hints into `cache.Store` which don't result in invalid filenames?\r\n\r\nThat seems reasonable, although I might pop an assert into the code just to make it clear this is the case. :)","created_at":"2015-07-30T23:21:16Z","updated_at":"2015-07-30T23:21:16Z","html_url":"https://github.com/KSP-CKAN/CKAN/pull/1266#discussion_r35932790","pull_request_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266","_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/35932790"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/1266#discussion_r35932790"},"pull_request":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266"}}},"pull_request":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266","id":39462716,"html_url":"https://github.com/KSP-CKAN/CKAN/pull/1266","diff_url":"https://github.com/KSP-CKAN/CKAN/pull/1266.diff","patch_url":"https://github.com/KSP-CKAN/CKAN/pull/1266.patch","issue_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/1266","number":1266,"state":"open","locked":false,"title":"Fix bad characters in filename in module.","user":{"login":"mgsdk","id":856309,"avatar_url":"https://avatars.githubusercontent.com/u/856309?v=3","gravatar_id":"","url":"https://api.github.com/users/mgsdk","html_url":"https://github.com/mgsdk","followers_url":"https://api.github.com/users/mgsdk/followers","following_url":"https://api.github.com/users/mgsdk/following{/other_user}","gists_url":"https://api.github.com/users/mgsdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgsdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgsdk/subscriptions","organizations_url":"https://api.github.com/users/mgsdk/orgs","repos_url":"https://api.github.com/users/mgsdk/repos","events_url":"https://api.github.com/users/mgsdk/events{/privacy}","received_events_url":"https://api.github.com/users/mgsdk/received_events","type":"User","site_admin":false},"body":"@pjf reported a slight issue with show in the cli in #1249. This should fix that by moving the renaming code further up the chain. I cannot test with the case @pjf used, since I can't seem to locate it in my registry.\r\n\r\nCloses #1249.","created_at":"2015-07-08T10:31:38Z","updated_at":"2015-07-30T23:21:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"621e89805e6866c1a5e3ebe53b6f0f8a9d6ca377","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266/commits","review_comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266/comments","review_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/1266/comments","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/0d76a51008d09b7347466d78f546e88568d3e5f5","head":{"label":"mgsdk:fix_ckan_show","ref":"fix_ckan_show","sha":"0d76a51008d09b7347466d78f546e88568d3e5f5","user":{"login":"mgsdk","id":856309,"avatar_url":"https://avatars.githubusercontent.com/u/856309?v=3","gravatar_id":"","url":"https://api.github.com/users/mgsdk","html_url":"https://github.com/mgsdk","followers_url":"https://api.github.com/users/mgsdk/followers","following_url":"https://api.github.com/users/mgsdk/following{/other_user}","gists_url":"https://api.github.com/users/mgsdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgsdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgsdk/subscriptions","organizations_url":"https://api.github.com/users/mgsdk/orgs","repos_url":"https://api.github.com/users/mgsdk/repos","events_url":"https://api.github.com/users/mgsdk/events{/privacy}","received_events_url":"https://api.github.com/users/mgsdk/received_events","type":"User","site_admin":false},"repo":{"id":27397467,"name":"CKAN","full_name":"mgsdk/CKAN","owner":{"login":"mgsdk","id":856309,"avatar_url":"https://avatars.githubusercontent.com/u/856309?v=3","gravatar_id":"","url":"https://api.github.com/users/mgsdk","html_url":"https://github.com/mgsdk","followers_url":"https://api.github.com/users/mgsdk/followers","following_url":"https://api.github.com/users/mgsdk/following{/other_user}","gists_url":"https://api.github.com/users/mgsdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgsdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgsdk/subscriptions","organizations_url":"https://api.github.com/users/mgsdk/orgs","repos_url":"https://api.github.com/users/mgsdk/repos","events_url":"https://api.github.com/users/mgsdk/events{/privacy}","received_events_url":"https://api.github.com/users/mgsdk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgsdk/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":true,"url":"https://api.github.com/repos/mgsdk/CKAN","forks_url":"https://api.github.com/repos/mgsdk/CKAN/forks","keys_url":"https://api.github.com/repos/mgsdk/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgsdk/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgsdk/CKAN/teams","hooks_url":"https://api.github.com/repos/mgsdk/CKAN/hooks","issue_events_url":"https://api.github.com/repos/mgsdk/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/mgsdk/CKAN/events","assignees_url":"https://api.github.com/repos/mgsdk/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/mgsdk/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/mgsdk/CKAN/tags","blobs_url":"https://api.github.com/repos/mgsdk/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgsdk/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgsdk/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgsdk/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgsdk/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/mgsdk/CKAN/languages","stargazers_url":"https://api.github.com/repos/mgsdk/CKAN/stargazers","contributors_url":"https://api.github.com/repos/mgsdk/CKAN/contributors","subscribers_url":"https://api.github.com/repos/mgsdk/CKAN/subscribers","subscription_url":"https://api.github.com/repos/mgsdk/CKAN/subscription","commits_url":"https://api.github.com/repos/mgsdk/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgsdk/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgsdk/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgsdk/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgsdk/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/mgsdk/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgsdk/CKAN/merges","archive_url":"https://api.github.com/repos/mgsdk/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgsdk/CKAN/downloads","issues_url":"https://api.github.com/repos/mgsdk/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/mgsdk/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/mgsdk/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/mgsdk/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgsdk/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/mgsdk/CKAN/releases{/id}","created_at":"2014-12-01T20:09:52Z","updated_at":"2015-05-31T07:47:25Z","pushed_at":"2015-07-21T08:45:25Z","git_url":"git://github.com/mgsdk/CKAN.git","ssh_url":"git@github.com:mgsdk/CKAN.git","clone_url":"https://github.com/mgsdk/CKAN.git","svn_url":"https://github.com/mgsdk/CKAN","homepage":"","size":22519,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KSP-CKAN:master","ref":"master","sha":"99be399f113f15152056f3b5448190988eaf0b52","user":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars.githubusercontent.com/u/9023970?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"repo":{"id":23050594,"name":"CKAN","full_name":"KSP-CKAN/CKAN","owner":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars.githubusercontent.com/u/9023970?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-CKAN/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":false,"url":"https://api.github.com/repos/KSP-CKAN/CKAN","forks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/forks","keys_url":"https://api.github.com/repos/KSP-CKAN/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-CKAN/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-CKAN/CKAN/teams","hooks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/hooks","issue_events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/events","assignees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-CKAN/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/tags","blobs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-CKAN/CKAN/languages","stargazers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/stargazers","contributors_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contributors","subscribers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscribers","subscription_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscription","commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-CKAN/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-CKAN/CKAN/merges","archive_url":"https://api.github.com/repos/KSP-CKAN/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-CKAN/CKAN/downloads","issues_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-CKAN/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-CKAN/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/KSP-CKAN/CKAN/releases{/id}","created_at":"2014-08-17T21:11:54Z","updated_at":"2015-07-29T17:50:57Z","pushed_at":"2015-07-30T22:29:08Z","git_url":"git://github.com/KSP-CKAN/CKAN.git","ssh_url":"git@github.com:KSP-CKAN/CKAN.git","clone_url":"https://github.com/KSP-CKAN/CKAN.git","svn_url":"https://github.com/KSP-CKAN/CKAN","homepage":"","size":29100,"stargazers_count":225,"watchers_count":225,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":218,"forks":71,"open_issues":218,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/1266"},"issue":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/1266"},"comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/1266/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/1266/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/0d76a51008d09b7347466d78f546e88568d3e5f5"}}}}