{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/comments/45458564","id":45458564,"diff_hunk":"@@ -49,19 +50,26 @@ namespace\n const uint32_t INTERNAL_TIMEOUT = 500;\n }\n \n+URI toHostAndPort( const URI& uri )\n+{\n+    URI out;\n+    out.setHost( uri.getHost( ));\n+    out.setPort( uri.getPort( ));\n+    return out;\n+}\n+\n SpikeReport::SpikeReport( const brion::SpikeReportInitData& pluginData )\n-    : _uri( pluginData.getURI( ))\n+    : _uri( toHostAndPort( pluginData.getURI( )))","path":"monsteer/plugin/spikeReport.cpp","position":22,"original_position":22,"commit_id":"744c8d17ff0c3b16674af8963cab5c6607451705","original_commit_id":"744c8d17ff0c3b16674af8963cab5c6607451705","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"Stefan's proposal looks wrong. Since the scheme is used to register and identify the plugin, the zeq::URI constructor will copy the \"monsteer://\" from pluginData.getURI(). I don't know if that's really a problem, but I think  that's what Raphael is trying to avoid here.\r\n\r\nWhat I meant is:\r\nRemove\r\n\r\n    : _uri( toHostAndPort( pluginData.getURI( )))\r\n\r\nAnd add to the contructor body this:\r\n\r\n    _uri.setHost( uri.getHost( ));\r\n    _uri.setPort( uri.getPort( ));\r\n\r\n","created_at":"2015-11-20T11:12:03Z","updated_at":"2015-11-20T11:12:03Z","html_url":"https://github.com/BlueBrain/Monsteer/pull/13#discussion_r45458564","pull_request_url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/comments/45458564"},"html":{"href":"https://github.com/BlueBrain/Monsteer/pull/13#discussion_r45458564"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13","id":51247802,"html_url":"https://github.com/BlueBrain/Monsteer/pull/13","diff_url":"https://github.com/BlueBrain/Monsteer/pull/13.diff","patch_url":"https://github.com/BlueBrain/Monsteer/pull/13.patch","issue_url":"https://api.github.com/repos/BlueBrain/Monsteer/issues/13","number":13,"state":"open","locked":false,"title":"Adaptions for the new ZeroEQ session mechanism","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-19T16:43:26Z","updated_at":"2015-11-20T11:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb538c3e310f769d1dd31efa4111deb8dcdbc041","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Monsteer/issues/13/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Monsteer/statuses/744c8d17ff0c3b16674af8963cab5c6607451705","head":{"label":"rdumusc:master","ref":"master","sha":"744c8d17ff0c3b16674af8963cab5c6607451705","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"repo":{"id":44108866,"name":"Monsteer","full_name":"rdumusc/Monsteer","owner":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdumusc/Monsteer","description":"Interactive Supercomputing tools and library","fork":true,"url":"https://api.github.com/repos/rdumusc/Monsteer","forks_url":"https://api.github.com/repos/rdumusc/Monsteer/forks","keys_url":"https://api.github.com/repos/rdumusc/Monsteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdumusc/Monsteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdumusc/Monsteer/teams","hooks_url":"https://api.github.com/repos/rdumusc/Monsteer/hooks","issue_events_url":"https://api.github.com/repos/rdumusc/Monsteer/issues/events{/number}","events_url":"https://api.github.com/repos/rdumusc/Monsteer/events","assignees_url":"https://api.github.com/repos/rdumusc/Monsteer/assignees{/user}","branches_url":"https://api.github.com/repos/rdumusc/Monsteer/branches{/branch}","tags_url":"https://api.github.com/repos/rdumusc/Monsteer/tags","blobs_url":"https://api.github.com/repos/rdumusc/Monsteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdumusc/Monsteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdumusc/Monsteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdumusc/Monsteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdumusc/Monsteer/statuses/{sha}","languages_url":"https://api.github.com/repos/rdumusc/Monsteer/languages","stargazers_url":"https://api.github.com/repos/rdumusc/Monsteer/stargazers","contributors_url":"https://api.github.com/repos/rdumusc/Monsteer/contributors","subscribers_url":"https://api.github.com/repos/rdumusc/Monsteer/subscribers","subscription_url":"https://api.github.com/repos/rdumusc/Monsteer/subscription","commits_url":"https://api.github.com/repos/rdumusc/Monsteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdumusc/Monsteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdumusc/Monsteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdumusc/Monsteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdumusc/Monsteer/contents/{+path}","compare_url":"https://api.github.com/repos/rdumusc/Monsteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdumusc/Monsteer/merges","archive_url":"https://api.github.com/repos/rdumusc/Monsteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdumusc/Monsteer/downloads","issues_url":"https://api.github.com/repos/rdumusc/Monsteer/issues{/number}","pulls_url":"https://api.github.com/repos/rdumusc/Monsteer/pulls{/number}","milestones_url":"https://api.github.com/repos/rdumusc/Monsteer/milestones{/number}","notifications_url":"https://api.github.com/repos/rdumusc/Monsteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdumusc/Monsteer/labels{/name}","releases_url":"https://api.github.com/repos/rdumusc/Monsteer/releases{/id}","created_at":"2015-10-12T13:24:18Z","updated_at":"2015-10-12T13:24:19Z","pushed_at":"2015-11-19T16:47:16Z","git_url":"git://github.com/rdumusc/Monsteer.git","ssh_url":"git@github.com:rdumusc/Monsteer.git","clone_url":"https://github.com/rdumusc/Monsteer.git","svn_url":"https://github.com/rdumusc/Monsteer","homepage":"","size":6261,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"bff6d3ccdf723925fddcc030675e8b604d91dee0","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":42052091,"name":"Monsteer","full_name":"BlueBrain/Monsteer","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Monsteer","description":"Interactive Supercomputing tools and library","fork":false,"url":"https://api.github.com/repos/BlueBrain/Monsteer","forks_url":"https://api.github.com/repos/BlueBrain/Monsteer/forks","keys_url":"https://api.github.com/repos/BlueBrain/Monsteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Monsteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Monsteer/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Monsteer/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Monsteer/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Monsteer/events","assignees_url":"https://api.github.com/repos/BlueBrain/Monsteer/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Monsteer/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Monsteer/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Monsteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Monsteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Monsteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Monsteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Monsteer/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Monsteer/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Monsteer/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Monsteer/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Monsteer/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Monsteer/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Monsteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Monsteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Monsteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Monsteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Monsteer/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Monsteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Monsteer/merges","archive_url":"https://api.github.com/repos/BlueBrain/Monsteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Monsteer/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Monsteer/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Monsteer/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Monsteer/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Monsteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Monsteer/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Monsteer/releases{/id}","created_at":"2015-09-07T12:36:21Z","updated_at":"2015-10-18T00:40:16Z","pushed_at":"2015-11-19T16:47:16Z","git_url":"git://github.com/BlueBrain/Monsteer.git","ssh_url":"git@github.com:BlueBrain/Monsteer.git","clone_url":"https://github.com/BlueBrain/Monsteer.git","svn_url":"https://github.com/BlueBrain/Monsteer","homepage":"","size":6462,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13"},"html":{"href":"https://github.com/BlueBrain/Monsteer/pull/13"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/issues/13"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Monsteer/statuses/744c8d17ff0c3b16674af8963cab5c6607451705"}}}}