{"action":"opened","number":103,"pull_request":{"url":"https://api.github.com/repos/gsklee/ngStorage/pulls/103","id":38037024,"html_url":"https://github.com/gsklee/ngStorage/pull/103","diff_url":"https://github.com/gsklee/ngStorage/pull/103.diff","patch_url":"https://github.com/gsklee/ngStorage/pull/103.patch","issue_url":"https://api.github.com/repos/gsklee/ngStorage/issues/103","number":103,"state":"open","locked":false,"title":"fix DOM Exception 18 when cookies are blocked by user in Safari","user":{"login":"everdimension","id":5347023,"avatar_url":"https://avatars.githubusercontent.com/u/5347023?v=3","gravatar_id":"","url":"https://api.github.com/users/everdimension","html_url":"https://github.com/everdimension","followers_url":"https://api.github.com/users/everdimension/followers","following_url":"https://api.github.com/users/everdimension/following{/other_user}","gists_url":"https://api.github.com/users/everdimension/gists{/gist_id}","starred_url":"https://api.github.com/users/everdimension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everdimension/subscriptions","organizations_url":"https://api.github.com/users/everdimension/orgs","repos_url":"https://api.github.com/users/everdimension/repos","events_url":"https://api.github.com/users/everdimension/events{/privacy}","received_events_url":"https://api.github.com/users/everdimension/received_events","type":"User","site_admin":false},"body":"If cookies are disabled in Safari browser (`Privacy —> Cookies and website data —> \"Always block\"`), then simply calling localStorage (`$window['localStorage']`) throws an error, which breaks the whole app.\r\n\r\nThis fix simply catches the error.","created_at":"2015-06-18T18:25:18Z","updated_at":"2015-06-18T18:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gsklee/ngStorage/pulls/103/commits","review_comments_url":"https://api.github.com/repos/gsklee/ngStorage/pulls/103/comments","review_comment_url":"https://api.github.com/repos/gsklee/ngStorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gsklee/ngStorage/issues/103/comments","statuses_url":"https://api.github.com/repos/gsklee/ngStorage/statuses/a56382ab56d05804ba235b38fbffdff948c708e8","head":{"label":"everdimension:fix_dom_exception","ref":"fix_dom_exception","sha":"a56382ab56d05804ba235b38fbffdff948c708e8","user":{"login":"everdimension","id":5347023,"avatar_url":"https://avatars.githubusercontent.com/u/5347023?v=3","gravatar_id":"","url":"https://api.github.com/users/everdimension","html_url":"https://github.com/everdimension","followers_url":"https://api.github.com/users/everdimension/followers","following_url":"https://api.github.com/users/everdimension/following{/other_user}","gists_url":"https://api.github.com/users/everdimension/gists{/gist_id}","starred_url":"https://api.github.com/users/everdimension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everdimension/subscriptions","organizations_url":"https://api.github.com/users/everdimension/orgs","repos_url":"https://api.github.com/users/everdimension/repos","events_url":"https://api.github.com/users/everdimension/events{/privacy}","received_events_url":"https://api.github.com/users/everdimension/received_events","type":"User","site_admin":false},"repo":{"id":37675972,"name":"ngStorage","full_name":"everdimension/ngStorage","owner":{"login":"everdimension","id":5347023,"avatar_url":"https://avatars.githubusercontent.com/u/5347023?v=3","gravatar_id":"","url":"https://api.github.com/users/everdimension","html_url":"https://github.com/everdimension","followers_url":"https://api.github.com/users/everdimension/followers","following_url":"https://api.github.com/users/everdimension/following{/other_user}","gists_url":"https://api.github.com/users/everdimension/gists{/gist_id}","starred_url":"https://api.github.com/users/everdimension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everdimension/subscriptions","organizations_url":"https://api.github.com/users/everdimension/orgs","repos_url":"https://api.github.com/users/everdimension/repos","events_url":"https://api.github.com/users/everdimension/events{/privacy}","received_events_url":"https://api.github.com/users/everdimension/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/everdimension/ngStorage","description":"localStorage and sessionStorage done right for AngularJS.","fork":true,"url":"https://api.github.com/repos/everdimension/ngStorage","forks_url":"https://api.github.com/repos/everdimension/ngStorage/forks","keys_url":"https://api.github.com/repos/everdimension/ngStorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everdimension/ngStorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everdimension/ngStorage/teams","hooks_url":"https://api.github.com/repos/everdimension/ngStorage/hooks","issue_events_url":"https://api.github.com/repos/everdimension/ngStorage/issues/events{/number}","events_url":"https://api.github.com/repos/everdimension/ngStorage/events","assignees_url":"https://api.github.com/repos/everdimension/ngStorage/assignees{/user}","branches_url":"https://api.github.com/repos/everdimension/ngStorage/branches{/branch}","tags_url":"https://api.github.com/repos/everdimension/ngStorage/tags","blobs_url":"https://api.github.com/repos/everdimension/ngStorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everdimension/ngStorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everdimension/ngStorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/everdimension/ngStorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everdimension/ngStorage/statuses/{sha}","languages_url":"https://api.github.com/repos/everdimension/ngStorage/languages","stargazers_url":"https://api.github.com/repos/everdimension/ngStorage/stargazers","contributors_url":"https://api.github.com/repos/everdimension/ngStorage/contributors","subscribers_url":"https://api.github.com/repos/everdimension/ngStorage/subscribers","subscription_url":"https://api.github.com/repos/everdimension/ngStorage/subscription","commits_url":"https://api.github.com/repos/everdimension/ngStorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/everdimension/ngStorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/everdimension/ngStorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/everdimension/ngStorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/everdimension/ngStorage/contents/{+path}","compare_url":"https://api.github.com/repos/everdimension/ngStorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everdimension/ngStorage/merges","archive_url":"https://api.github.com/repos/everdimension/ngStorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everdimension/ngStorage/downloads","issues_url":"https://api.github.com/repos/everdimension/ngStorage/issues{/number}","pulls_url":"https://api.github.com/repos/everdimension/ngStorage/pulls{/number}","milestones_url":"https://api.github.com/repos/everdimension/ngStorage/milestones{/number}","notifications_url":"https://api.github.com/repos/everdimension/ngStorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everdimension/ngStorage/labels{/name}","releases_url":"https://api.github.com/repos/everdimension/ngStorage/releases{/id}","created_at":"2015-06-18T18:03:16Z","updated_at":"2015-06-18T18:03:16Z","pushed_at":"2015-06-18T18:11:55Z","git_url":"git://github.com/everdimension/ngStorage.git","ssh_url":"git@github.com:everdimension/ngStorage.git","clone_url":"https://github.com/everdimension/ngStorage.git","svn_url":"https://github.com/everdimension/ngStorage","homepage":"","size":634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gsklee:master","ref":"master","sha":"9d0827882ca7139ea34cce581a9382a939694ff6","user":{"login":"gsklee","id":1006291,"avatar_url":"https://avatars.githubusercontent.com/u/1006291?v=3","gravatar_id":"","url":"https://api.github.com/users/gsklee","html_url":"https://github.com/gsklee","followers_url":"https://api.github.com/users/gsklee/followers","following_url":"https://api.github.com/users/gsklee/following{/other_user}","gists_url":"https://api.github.com/users/gsklee/gists{/gist_id}","starred_url":"https://api.github.com/users/gsklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsklee/subscriptions","organizations_url":"https://api.github.com/users/gsklee/orgs","repos_url":"https://api.github.com/users/gsklee/repos","events_url":"https://api.github.com/users/gsklee/events{/privacy}","received_events_url":"https://api.github.com/users/gsklee/received_events","type":"User","site_admin":false},"repo":{"id":11212142,"name":"ngStorage","full_name":"gsklee/ngStorage","owner":{"login":"gsklee","id":1006291,"avatar_url":"https://avatars.githubusercontent.com/u/1006291?v=3","gravatar_id":"","url":"https://api.github.com/users/gsklee","html_url":"https://github.com/gsklee","followers_url":"https://api.github.com/users/gsklee/followers","following_url":"https://api.github.com/users/gsklee/following{/other_user}","gists_url":"https://api.github.com/users/gsklee/gists{/gist_id}","starred_url":"https://api.github.com/users/gsklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsklee/subscriptions","organizations_url":"https://api.github.com/users/gsklee/orgs","repos_url":"https://api.github.com/users/gsklee/repos","events_url":"https://api.github.com/users/gsklee/events{/privacy}","received_events_url":"https://api.github.com/users/gsklee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsklee/ngStorage","description":"localStorage and sessionStorage done right for AngularJS.","fork":false,"url":"https://api.github.com/repos/gsklee/ngStorage","forks_url":"https://api.github.com/repos/gsklee/ngStorage/forks","keys_url":"https://api.github.com/repos/gsklee/ngStorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsklee/ngStorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsklee/ngStorage/teams","hooks_url":"https://api.github.com/repos/gsklee/ngStorage/hooks","issue_events_url":"https://api.github.com/repos/gsklee/ngStorage/issues/events{/number}","events_url":"https://api.github.com/repos/gsklee/ngStorage/events","assignees_url":"https://api.github.com/repos/gsklee/ngStorage/assignees{/user}","branches_url":"https://api.github.com/repos/gsklee/ngStorage/branches{/branch}","tags_url":"https://api.github.com/repos/gsklee/ngStorage/tags","blobs_url":"https://api.github.com/repos/gsklee/ngStorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsklee/ngStorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsklee/ngStorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsklee/ngStorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsklee/ngStorage/statuses/{sha}","languages_url":"https://api.github.com/repos/gsklee/ngStorage/languages","stargazers_url":"https://api.github.com/repos/gsklee/ngStorage/stargazers","contributors_url":"https://api.github.com/repos/gsklee/ngStorage/contributors","subscribers_url":"https://api.github.com/repos/gsklee/ngStorage/subscribers","subscription_url":"https://api.github.com/repos/gsklee/ngStorage/subscription","commits_url":"https://api.github.com/repos/gsklee/ngStorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsklee/ngStorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsklee/ngStorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsklee/ngStorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsklee/ngStorage/contents/{+path}","compare_url":"https://api.github.com/repos/gsklee/ngStorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsklee/ngStorage/merges","archive_url":"https://api.github.com/repos/gsklee/ngStorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsklee/ngStorage/downloads","issues_url":"https://api.github.com/repos/gsklee/ngStorage/issues{/number}","pulls_url":"https://api.github.com/repos/gsklee/ngStorage/pulls{/number}","milestones_url":"https://api.github.com/repos/gsklee/ngStorage/milestones{/number}","notifications_url":"https://api.github.com/repos/gsklee/ngStorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsklee/ngStorage/labels{/name}","releases_url":"https://api.github.com/repos/gsklee/ngStorage/releases{/id}","created_at":"2013-07-06T02:54:54Z","updated_at":"2015-06-18T13:02:15Z","pushed_at":"2015-06-18T06:16:25Z","git_url":"git://github.com/gsklee/ngStorage.git","ssh_url":"git@github.com:gsklee/ngStorage.git","clone_url":"https://github.com/gsklee/ngStorage.git","svn_url":"https://github.com/gsklee/ngStorage","homepage":"","size":634,"stargazers_count":1192,"watchers_count":1192,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":28,"forks":242,"open_issues":28,"watchers":1192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gsklee/ngStorage/pulls/103"},"html":{"href":"https://github.com/gsklee/ngStorage/pull/103"},"issue":{"href":"https://api.github.com/repos/gsklee/ngStorage/issues/103"},"comments":{"href":"https://api.github.com/repos/gsklee/ngStorage/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/gsklee/ngStorage/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/gsklee/ngStorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gsklee/ngStorage/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/gsklee/ngStorage/statuses/a56382ab56d05804ba235b38fbffdff948c708e8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":1,"changed_files":1}}