{"action":"created","issue":{"url":"https://api.github.com/repos/clappr/clappr/issues/348","labels_url":"https://api.github.com/repos/clappr/clappr/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/348/comments","events_url":"https://api.github.com/repos/clappr/clappr/issues/348/events","html_url":"https://github.com/clappr/clappr/pull/348","id":55669479,"number":348,"title":"start to fix #346","user":{"login":"lewiscowper","id":593574,"avatar_url":"https://avatars.githubusercontent.com/u/593574?v=3","gravatar_id":"","url":"https://api.github.com/users/lewiscowper","html_url":"https://github.com/lewiscowper","followers_url":"https://api.github.com/users/lewiscowper/followers","following_url":"https://api.github.com/users/lewiscowper/following{/other_user}","gists_url":"https://api.github.com/users/lewiscowper/gists{/gist_id}","starred_url":"https://api.github.com/users/lewiscowper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewiscowper/subscriptions","organizations_url":"https://api.github.com/users/lewiscowper/orgs","repos_url":"https://api.github.com/users/lewiscowper/repos","events_url":"https://api.github.com/users/lewiscowper/events{/privacy}","received_events_url":"https://api.github.com/users/lewiscowper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-27T20:23:11Z","updated_at":"2015-01-28T13:54:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clappr/clappr/pulls/348","html_url":"https://github.com/clappr/clappr/pull/348","diff_url":"https://github.com/clappr/clappr/pull/348.diff","patch_url":"https://github.com/clappr/clappr/pull/348.patch"},"body":"Hey there, I'm not sure how close I am, and I think there's more that I'm missing, but I thought I'd get your views on this fix for #346 while I'm early into ES6."},"comment":{"url":"https://api.github.com/repos/clappr/clappr/issues/comments/71837673","html_url":"https://github.com/clappr/clappr/pull/348#issuecomment-71837673","issue_url":"https://api.github.com/repos/clappr/clappr/issues/348","id":71837673,"user":{"login":"flavioribeiro","id":244265,"avatar_url":"https://avatars.githubusercontent.com/u/244265?v=3","gravatar_id":"","url":"https://api.github.com/users/flavioribeiro","html_url":"https://github.com/flavioribeiro","followers_url":"https://api.github.com/users/flavioribeiro/followers","following_url":"https://api.github.com/users/flavioribeiro/following{/other_user}","gists_url":"https://api.github.com/users/flavioribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/flavioribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavioribeiro/subscriptions","organizations_url":"https://api.github.com/users/flavioribeiro/orgs","repos_url":"https://api.github.com/users/flavioribeiro/repos","events_url":"https://api.github.com/users/flavioribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/flavioribeiro/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T13:54:02Z","updated_at":"2015-01-28T13:54:02Z","body":"hey @lewiscowper, thank you for your first pull request. I think you're on the right path and I have only two considerations before merge it:\r\n\r\n- It would be better to have a more descriptive commit message (take a look at our commits)\r\n- The diff on watermark plugin breaks it. We need a `position` attribute on the object. I recommend you to leave that `||` intact for now.\r\n\r\nCan you solve this issues and send the pull request again? Remember to send only one commit (squash and amend are your friends)."}}