{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/47418021","id":47418021,"diff_hunk":"@@ -56,19 +56,20 @@ export class AmpList extends AMP.BaseElement {\n \n   /** @override */\n   layoutCallback() {\n-    const src = this.urlReplacements_.expand(assertHttpsUrl(\n-        this.element.getAttribute('src'), this.element));\n-    const opts = {\n-      credentials: this.element.getAttribute('credentials')\n-    };\n-    return xhrFor(this.getWin()).fetchJson(src, opts).then(data => {\n-      assert(typeof data == 'object' && Array.isArray(data['items']),\n-          'Response must be {items: []} object %s %s',\n-          this.element, data);\n-      const items = data['items'];\n-      return templatesFor(this.getWin()).findAndRenderTemplateArray(\n-          this.element, items).then(this.rendered_.bind(this));\n-    });\n+    return this.urlReplacements_.expand(assertHttpsUrl(\n+        this.element.getAttribute('src'), this.element)).then(src => {\n+          const opts = {\n+            credentials: this.element.getAttribute('credentials')\n+          };\n+          return xhrFor(this.getWin()).fetchJson(src, opts).then(data => {","path":"extensions/amp-list/0.1/amp-list.js","position":22,"original_position":22,"commit_id":"0df74baf23060a2385a6535fdb391308076a662b","original_commit_id":"0df74baf23060a2385a6535fdb391308076a662b","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"Chaining, not nesting.","created_at":"2015-12-11T23:27:32Z","updated_at":"2015-12-11T23:27:32Z","html_url":"https://github.com/ampproject/amphtml/pull/1146#discussion_r47418021","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1146","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/47418021"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1146#discussion_r47418021"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1146"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/1146","id":53456268,"html_url":"https://github.com/ampproject/amphtml/pull/1146","diff_url":"https://github.com/ampproject/amphtml/pull/1146.diff","patch_url":"https://github.com/ampproject/amphtml/pull/1146.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1146","number":1146,"state":"open","locked":false,"title":"Implement URL replacement for client ids available to amp-analytics","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"body":"Also makes the following changes\r\n\r\n- Switches `amp-analytics` to use layoutCallback instead of `buildCallback`. Closes #1141 and makes the tests more straight forward since they are now async.\r\n- Support for promised based URL replacement\r\n- Support for (right now only one) arguments to URL replacement functions.\r\n\r\nRelated to #961 #871\r\nFixes #1124","created_at":"2015-12-11T23:13:19Z","updated_at":"2015-12-11T23:27:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6985d4262d024f1237c3c1c79a789b4e6ab03032","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1146/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/0df74baf23060a2385a6535fdb391308076a662b","head":{"label":"cramforce:cid-url","ref":"cid-url","sha":"0df74baf23060a2385a6535fdb391308076a662b","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"repo":{"id":43817601,"name":"amphtml","full_name":"cramforce/amphtml","owner":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cramforce/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/cramforce/amphtml","forks_url":"https://api.github.com/repos/cramforce/amphtml/forks","keys_url":"https://api.github.com/repos/cramforce/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cramforce/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cramforce/amphtml/teams","hooks_url":"https://api.github.com/repos/cramforce/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cramforce/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cramforce/amphtml/events","assignees_url":"https://api.github.com/repos/cramforce/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cramforce/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cramforce/amphtml/tags","blobs_url":"https://api.github.com/repos/cramforce/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cramforce/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cramforce/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cramforce/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cramforce/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cramforce/amphtml/languages","stargazers_url":"https://api.github.com/repos/cramforce/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cramforce/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cramforce/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cramforce/amphtml/subscription","commits_url":"https://api.github.com/repos/cramforce/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cramforce/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cramforce/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cramforce/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cramforce/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cramforce/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cramforce/amphtml/merges","archive_url":"https://api.github.com/repos/cramforce/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cramforce/amphtml/downloads","issues_url":"https://api.github.com/repos/cramforce/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cramforce/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cramforce/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cramforce/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cramforce/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cramforce/amphtml/releases{/id}","created_at":"2015-10-07T13:28:45Z","updated_at":"2015-10-07T13:28:46Z","pushed_at":"2015-12-11T23:12:35Z","git_url":"git://github.com/cramforce/amphtml.git","ssh_url":"git@github.com:cramforce/amphtml.git","clone_url":"https://github.com/cramforce/amphtml.git","svn_url":"https://github.com/cramforce/amphtml","homepage":"","size":13758,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"fac564707b0bc184886a187a70c1fea271937602","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","created_at":"2015-09-01T22:10:53Z","updated_at":"2015-12-11T22:31:33Z","pushed_at":"2015-12-11T23:27:25Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":15633,"stargazers_count":4959,"watchers_count":4959,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":478,"mirror_url":null,"open_issues_count":173,"forks":478,"open_issues":173,"watchers":4959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1146"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1146"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1146"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/0df74baf23060a2385a6535fdb391308076a662b"}}}}