{"action":"created","comment":{"url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/22913707","id":22913707,"diff_hunk":"@@ -0,0 +1,116 @@\n+% Meridian 59, Copyright 1994-2012 Andrew Kirmse and Chris Kirmse.\n+% All rights reserved.\n+%\n+% This software is distributed under a license that is described in\n+% the LICENSE file that accompanies it.\n+%\n+% Meridian is a registered trademark.\n+\n+\n+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n+BaneEnchantment is RadiusEnchantment\n+\n+constants:\n+\n+   include blakston.khd\n+\n+resources:\n+   \n+   default_hurt_caster = \"A tide of energy retaliates against your spell.\"\n+   default_kills_you = \\\n+      \"The oncoming tide of energy carries you straight to \"\n+      \"the Underworld!\"\n+\n+classvars:\n+   \n+   vrBaneHurt = default_hurt_caster\n+   vrBaneKills = default_kills_you\n+\n+   vrIcon = QorBane_name_rsc","path":"kod/object/passive/spell/radiusench/bane.kod","position":29,"original_position":29,"commit_id":"8fc11b2a0120c64f805916aac315e1c92b7570da","original_commit_id":"8fc11b2a0120c64f805916aac315e1c92b7570da","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"body":"Can't use a resource here from a file that hasn't been built yet. This is a dangerous error, because the buildserver won't pick it up (it uses 103's kodbase.txt) but any attempt to build without a kodbase.txt will fail here. I know we've discussed this to death already but this is why you absolutely MUST compile and test your code on your own, locally (including after an nmake clean) before submitting it. Sorry to sound patronising here, I just really can't stress enough how much of a serious issue this is. If I hadn't caught this now on the buildserver while testing the building of the new keybind (using nmake clean) this would have popped up when we were about to push the update and delayed it. I do want to include your pull requests in updates but I get nervous every time I add one to a milestone, and I feel like it would be really easy for you to solve that issue by just compiling them yourself before submitting, and doing some basic testing.","created_at":"2015-01-14T02:42:37Z","updated_at":"2015-01-14T02:42:37Z","html_url":"https://github.com/Daenks/Meridian59_103/pull/807#discussion_r22913707","pull_request_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/22913707"},"html":{"href":"https://github.com/Daenks/Meridian59_103/pull/807#discussion_r22913707"},"pull_request":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807","id":26620844,"html_url":"https://github.com/Daenks/Meridian59_103/pull/807","diff_url":"https://github.com/Daenks/Meridian59_103/pull/807.diff","patch_url":"https://github.com/Daenks/Meridian59_103/pull/807.patch","issue_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/807","number":807,"state":"open","locked":false,"title":"AE safety issues fixed, RE bugs fixed","user":{"login":"GarOfMeridian","id":7925385,"avatar_url":"https://avatars.githubusercontent.com/u/7925385?v=3","gravatar_id":"","url":"https://api.github.com/users/GarOfMeridian","html_url":"https://github.com/GarOfMeridian","followers_url":"https://api.github.com/users/GarOfMeridian/followers","following_url":"https://api.github.com/users/GarOfMeridian/following{/other_user}","gists_url":"https://api.github.com/users/GarOfMeridian/gists{/gist_id}","starred_url":"https://api.github.com/users/GarOfMeridian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GarOfMeridian/subscriptions","organizations_url":"https://api.github.com/users/GarOfMeridian/orgs","repos_url":"https://api.github.com/users/GarOfMeridian/repos","events_url":"https://api.github.com/users/GarOfMeridian/events{/privacy}","received_events_url":"https://api.github.com/users/GarOfMeridian/received_events","type":"User","site_admin":false},"body":"Qorbane and Shalbane are now using Radius Enchantment safety code, as\r\nold-style AEs similar to AMA, Winds, etc. This means they're now useable\r\nin all conditions. They will apply to both guildmates and enemies. They\r\nare both also now in a \"Bane\" subclass that will allow us to easily add\r\nbanes for any school if we need to. The caster of a Bane also gets\r\nproper credit for a kill now.\r\n\r\nSilence has been converted to RE with a 1 mana per second drain. It no\r\nlonger breaks Jala songs or prevents all casting. For the time being,\r\nit only prevents communication in a large range around the caster. We\r\ncan't have a level 3 spell like this nuking all magic... if someone\r\nthinks of a good use for it, that can be added later.\r\n\r\nFor now, it still remains unique in that it silences communications.\r\nPerhaps enterprising fighters will use it to prevent calls for help from\r\nvictims.\r\n\r\nSandstorm will no longer multi-hit players who are under the effects\r\nof multiple sandstorms. Only the strongest sandstorm will do damage.\r\n\r\nThe \"change zones and get weird\" bug with Radius Enchantments has\r\nbeen fixed. It was caused by the game not knowing how to remove\r\none of two instances of the same spell with the same caster and\r\nsame spellpower. I fixed it by also tying them to the room of origin.\r\nThis bug was also the cause of Truce being weird.","created_at":"2014-12-28T04:53:14Z","updated_at":"2015-01-14T02:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e122e621277bb47211f4e3f8a984fd36f722cc07","assignee":null,"milestone":{"url":"https://api.github.com/repos/Daenks/Meridian59_103/milestones/49","labels_url":"https://api.github.com/repos/Daenks/Meridian59_103/milestones/49/labels","id":903796,"number":49,"title":"1.0.8.0","description":"","creator":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":0,"state":"open","created_at":"2014-12-15T02:56:25Z","updated_at":"2015-01-13T10:15:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807/commits","review_comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807/comments","review_comment_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/807/comments","statuses_url":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/8fc11b2a0120c64f805916aac315e1c92b7570da","head":{"label":"GarOfMeridian:FixAEs","ref":"FixAEs","sha":"8fc11b2a0120c64f805916aac315e1c92b7570da","user":{"login":"GarOfMeridian","id":7925385,"avatar_url":"https://avatars.githubusercontent.com/u/7925385?v=3","gravatar_id":"","url":"https://api.github.com/users/GarOfMeridian","html_url":"https://github.com/GarOfMeridian","followers_url":"https://api.github.com/users/GarOfMeridian/followers","following_url":"https://api.github.com/users/GarOfMeridian/following{/other_user}","gists_url":"https://api.github.com/users/GarOfMeridian/gists{/gist_id}","starred_url":"https://api.github.com/users/GarOfMeridian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GarOfMeridian/subscriptions","organizations_url":"https://api.github.com/users/GarOfMeridian/orgs","repos_url":"https://api.github.com/users/GarOfMeridian/repos","events_url":"https://api.github.com/users/GarOfMeridian/events{/privacy}","received_events_url":"https://api.github.com/users/GarOfMeridian/received_events","type":"User","site_admin":false},"repo":{"id":20969890,"name":"Meridian59_103","full_name":"GarOfMeridian/Meridian59_103","owner":{"login":"GarOfMeridian","id":7925385,"avatar_url":"https://avatars.githubusercontent.com/u/7925385?v=3","gravatar_id":"","url":"https://api.github.com/users/GarOfMeridian","html_url":"https://github.com/GarOfMeridian","followers_url":"https://api.github.com/users/GarOfMeridian/followers","following_url":"https://api.github.com/users/GarOfMeridian/following{/other_user}","gists_url":"https://api.github.com/users/GarOfMeridian/gists{/gist_id}","starred_url":"https://api.github.com/users/GarOfMeridian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GarOfMeridian/subscriptions","organizations_url":"https://api.github.com/users/GarOfMeridian/orgs","repos_url":"https://api.github.com/users/GarOfMeridian/repos","events_url":"https://api.github.com/users/GarOfMeridian/events{/privacy}","received_events_url":"https://api.github.com/users/GarOfMeridian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GarOfMeridian/Meridian59_103","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103","forks_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/forks","keys_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/teams","hooks_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/hooks","issue_events_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/issues/events{/number}","events_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/events","assignees_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/assignees{/user}","branches_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/branches{/branch}","tags_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/tags","blobs_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/git/refs{/sha}","trees_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/statuses/{sha}","languages_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/languages","stargazers_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/stargazers","contributors_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/contributors","subscribers_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/subscribers","subscription_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/subscription","commits_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/commits{/sha}","git_commits_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/git/commits{/sha}","comments_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/comments{/number}","issue_comment_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/issues/comments/{number}","contents_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/contents/{+path}","compare_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/merges","archive_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/downloads","issues_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/issues{/number}","pulls_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/pulls{/number}","milestones_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/milestones{/number}","notifications_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/labels{/name}","releases_url":"https://api.github.com/repos/GarOfMeridian/Meridian59_103/releases{/id}","created_at":"2014-06-18T16:42:59Z","updated_at":"2015-01-13T01:14:16Z","pushed_at":"2015-01-13T03:07:56Z","git_url":"git://github.com/GarOfMeridian/Meridian59_103.git","ssh_url":"git@github.com:GarOfMeridian/Meridian59_103.git","clone_url":"https://github.com/GarOfMeridian/Meridian59_103.git","svn_url":"https://github.com/GarOfMeridian/Meridian59_103","homepage":"openmeridian.org","size":74684,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Daenks:master","ref":"master","sha":"aa0f293ba759bde75a29055980426f863a75738f","user":{"login":"Daenks","id":552647,"avatar_url":"https://avatars.githubusercontent.com/u/552647?v=3","gravatar_id":"","url":"https://api.github.com/users/Daenks","html_url":"https://github.com/Daenks","followers_url":"https://api.github.com/users/Daenks/followers","following_url":"https://api.github.com/users/Daenks/following{/other_user}","gists_url":"https://api.github.com/users/Daenks/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenks/subscriptions","organizations_url":"https://api.github.com/users/Daenks/orgs","repos_url":"https://api.github.com/users/Daenks/repos","events_url":"https://api.github.com/users/Daenks/events{/privacy}","received_events_url":"https://api.github.com/users/Daenks/received_events","type":"User","site_admin":false},"repo":{"id":14400546,"name":"Meridian59_103","full_name":"Daenks/Meridian59_103","owner":{"login":"Daenks","id":552647,"avatar_url":"https://avatars.githubusercontent.com/u/552647?v=3","gravatar_id":"","url":"https://api.github.com/users/Daenks","html_url":"https://github.com/Daenks","followers_url":"https://api.github.com/users/Daenks/followers","following_url":"https://api.github.com/users/Daenks/following{/other_user}","gists_url":"https://api.github.com/users/Daenks/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenks/subscriptions","organizations_url":"https://api.github.com/users/Daenks/orgs","repos_url":"https://api.github.com/users/Daenks/repos","events_url":"https://api.github.com/users/Daenks/events{/privacy}","received_events_url":"https://api.github.com/users/Daenks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daenks/Meridian59_103","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/Daenks/Meridian59_103","forks_url":"https://api.github.com/repos/Daenks/Meridian59_103/forks","keys_url":"https://api.github.com/repos/Daenks/Meridian59_103/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daenks/Meridian59_103/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daenks/Meridian59_103/teams","hooks_url":"https://api.github.com/repos/Daenks/Meridian59_103/hooks","issue_events_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/events{/number}","events_url":"https://api.github.com/repos/Daenks/Meridian59_103/events","assignees_url":"https://api.github.com/repos/Daenks/Meridian59_103/assignees{/user}","branches_url":"https://api.github.com/repos/Daenks/Meridian59_103/branches{/branch}","tags_url":"https://api.github.com/repos/Daenks/Meridian59_103/tags","blobs_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/{sha}","languages_url":"https://api.github.com/repos/Daenks/Meridian59_103/languages","stargazers_url":"https://api.github.com/repos/Daenks/Meridian59_103/stargazers","contributors_url":"https://api.github.com/repos/Daenks/Meridian59_103/contributors","subscribers_url":"https://api.github.com/repos/Daenks/Meridian59_103/subscribers","subscription_url":"https://api.github.com/repos/Daenks/Meridian59_103/subscription","commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daenks/Meridian59_103/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daenks/Meridian59_103/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues/comments/{number}","contents_url":"https://api.github.com/repos/Daenks/Meridian59_103/contents/{+path}","compare_url":"https://api.github.com/repos/Daenks/Meridian59_103/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daenks/Meridian59_103/merges","archive_url":"https://api.github.com/repos/Daenks/Meridian59_103/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daenks/Meridian59_103/downloads","issues_url":"https://api.github.com/repos/Daenks/Meridian59_103/issues{/number}","pulls_url":"https://api.github.com/repos/Daenks/Meridian59_103/pulls{/number}","milestones_url":"https://api.github.com/repos/Daenks/Meridian59_103/milestones{/number}","notifications_url":"https://api.github.com/repos/Daenks/Meridian59_103/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daenks/Meridian59_103/labels{/name}","releases_url":"https://api.github.com/repos/Daenks/Meridian59_103/releases{/id}","created_at":"2013-11-14T16:29:15Z","updated_at":"2015-01-12T23:21:41Z","pushed_at":"2015-01-12T23:21:40Z","git_url":"git://github.com/Daenks/Meridian59_103.git","ssh_url":"git@github.com:Daenks/Meridian59_103.git","clone_url":"https://github.com/Daenks/Meridian59_103.git","svn_url":"https://github.com/Daenks/Meridian59_103","homepage":"openmeridian.org","size":96374,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":125,"forks":44,"open_issues":125,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807"},"html":{"href":"https://github.com/Daenks/Meridian59_103/pull/807"},"issue":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/issues/807"},"comments":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/Daenks/Meridian59_103/statuses/8fc11b2a0120c64f805916aac315e1c92b7570da"}}}}