{"action":"created","comment":{"url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/comments/37583935","id":37583935,"diff_hunk":"@@ -50,6 +53,16 @@\n     include_examples 'rejects values', [[1], { two: :three }]\n   end\n \n+  describe 'distance' do\n+    let(:attribute) { :distance }\n+    subject { described_class.attrclass(attribute) }\n+\n+    include_examples 'property'\n+    include_examples '#doc Documentation'\n+    include_examples 'accepts values without munging', %w(1 255)","path":"spec/unit/puppet/type/eos_staticroute_spec.rb","position":25,"original_position":25,"commit_id":"ec45dc43eb56b4f23dcfa62a1c2824a7e97d2528","original_commit_id":"ec45dc43eb56b4f23dcfa62a1c2824a7e97d2528","user":{"login":"devrobo","id":7717874,"avatar_url":"https://avatars.githubusercontent.com/u/7717874?v=3","gravatar_id":"","url":"https://api.github.com/users/devrobo","html_url":"https://github.com/devrobo","followers_url":"https://api.github.com/users/devrobo/followers","following_url":"https://api.github.com/users/devrobo/following{/other_user}","gists_url":"https://api.github.com/users/devrobo/gists{/gist_id}","starred_url":"https://api.github.com/users/devrobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devrobo/subscriptions","organizations_url":"https://api.github.com/users/devrobo/orgs","repos_url":"https://api.github.com/users/devrobo/repos","events_url":"https://api.github.com/users/devrobo/events{/privacy}","received_events_url":"https://api.github.com/users/devrobo/received_events","type":"User","site_admin":false},"body":"Can 62 and 63 be replaced with:\r\n\r\n    include_examples 'numeric parameter', min: 1, max: 255\r\n    include_examples 'rejects values', [0, 256]\r\n\r\nLet me know the outcome. Will the example pass in a string or an int?","created_at":"2015-08-20T21:34:54Z","updated_at":"2015-08-20T21:34:54Z","html_url":"https://github.com/arista-eosplus/puppet-eos/pull/31#discussion_r37583935","pull_request_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/comments/37583935"},"html":{"href":"https://github.com/arista-eosplus/puppet-eos/pull/31#discussion_r37583935"},"pull_request":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31","id":41591455,"html_url":"https://github.com/arista-eosplus/puppet-eos/pull/31","diff_url":"https://github.com/arista-eosplus/puppet-eos/pull/31.diff","patch_url":"https://github.com/arista-eosplus/puppet-eos/pull/31.patch","issue_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/31","number":31,"state":"open","locked":false,"title":"Feature eos_staticroute","user":{"login":"jerearista","id":7839104,"avatar_url":"https://avatars.githubusercontent.com/u/7839104?v=3","gravatar_id":"","url":"https://api.github.com/users/jerearista","html_url":"https://github.com/jerearista","followers_url":"https://api.github.com/users/jerearista/followers","following_url":"https://api.github.com/users/jerearista/following{/other_user}","gists_url":"https://api.github.com/users/jerearista/gists{/gist_id}","starred_url":"https://api.github.com/users/jerearista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerearista/subscriptions","organizations_url":"https://api.github.com/users/jerearista/orgs","repos_url":"https://api.github.com/users/jerearista/repos","events_url":"https://api.github.com/users/jerearista/events{/privacy}","received_events_url":"https://api.github.com/users/jerearista/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-04T16:49:01Z","updated_at":"2015-08-20T21:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b82fac16966d044ebb17282e60b1a62090c6ffe7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31/commits","review_comments_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31/comments","review_comment_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/31/comments","statuses_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/statuses/ec45dc43eb56b4f23dcfa62a1c2824a7e97d2528","head":{"label":"arista-eosplus:feature-staticroute","ref":"feature-staticroute","sha":"ec45dc43eb56b4f23dcfa62a1c2824a7e97d2528","user":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"repo":{"id":24956910,"name":"puppet-eos","full_name":"arista-eosplus/puppet-eos","owner":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arista-eosplus/puppet-eos","description":"Puppet modules for managing Arista EOS nodes","fork":false,"url":"https://api.github.com/repos/arista-eosplus/puppet-eos","forks_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/forks","keys_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/teams","hooks_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/hooks","issue_events_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/events{/number}","events_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/events","assignees_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/assignees{/user}","branches_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/branches{/branch}","tags_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/tags","blobs_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/statuses/{sha}","languages_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/languages","stargazers_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/stargazers","contributors_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/contributors","subscribers_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/subscribers","subscription_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/subscription","commits_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/contents/{+path}","compare_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/merges","archive_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/downloads","issues_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues{/number}","pulls_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls{/number}","milestones_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/milestones{/number}","notifications_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/labels{/name}","releases_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/releases{/id}","created_at":"2014-10-08T19:28:03Z","updated_at":"2015-07-02T18:34:24Z","pushed_at":"2015-08-20T19:51:10Z","git_url":"git://github.com/arista-eosplus/puppet-eos.git","ssh_url":"git@github.com:arista-eosplus/puppet-eos.git","clone_url":"https://github.com/arista-eosplus/puppet-eos.git","svn_url":"https://github.com/arista-eosplus/puppet-eos","homepage":null,"size":1827,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"base":{"label":"arista-eosplus:develop","ref":"develop","sha":"8c9f2a96bec0b5a353737c0c97979c72e15c7a0f","user":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"repo":{"id":24956910,"name":"puppet-eos","full_name":"arista-eosplus/puppet-eos","owner":{"login":"arista-eosplus","id":6643264,"avatar_url":"https://avatars.githubusercontent.com/u/6643264?v=3","gravatar_id":"","url":"https://api.github.com/users/arista-eosplus","html_url":"https://github.com/arista-eosplus","followers_url":"https://api.github.com/users/arista-eosplus/followers","following_url":"https://api.github.com/users/arista-eosplus/following{/other_user}","gists_url":"https://api.github.com/users/arista-eosplus/gists{/gist_id}","starred_url":"https://api.github.com/users/arista-eosplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arista-eosplus/subscriptions","organizations_url":"https://api.github.com/users/arista-eosplus/orgs","repos_url":"https://api.github.com/users/arista-eosplus/repos","events_url":"https://api.github.com/users/arista-eosplus/events{/privacy}","received_events_url":"https://api.github.com/users/arista-eosplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arista-eosplus/puppet-eos","description":"Puppet modules for managing Arista EOS nodes","fork":false,"url":"https://api.github.com/repos/arista-eosplus/puppet-eos","forks_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/forks","keys_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/teams","hooks_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/hooks","issue_events_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/events{/number}","events_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/events","assignees_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/assignees{/user}","branches_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/branches{/branch}","tags_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/tags","blobs_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/statuses/{sha}","languages_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/languages","stargazers_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/stargazers","contributors_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/contributors","subscribers_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/subscribers","subscription_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/subscription","commits_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/contents/{+path}","compare_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/merges","archive_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/downloads","issues_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues{/number}","pulls_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls{/number}","milestones_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/milestones{/number}","notifications_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/labels{/name}","releases_url":"https://api.github.com/repos/arista-eosplus/puppet-eos/releases{/id}","created_at":"2014-10-08T19:28:03Z","updated_at":"2015-07-02T18:34:24Z","pushed_at":"2015-08-20T19:51:10Z","git_url":"git://github.com/arista-eosplus/puppet-eos.git","ssh_url":"git@github.com:arista-eosplus/puppet-eos.git","clone_url":"https://github.com/arista-eosplus/puppet-eos.git","svn_url":"https://github.com/arista-eosplus/puppet-eos","homepage":null,"size":1827,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31"},"html":{"href":"https://github.com/arista-eosplus/puppet-eos/pull/31"},"issue":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/31"},"comments":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/arista-eosplus/puppet-eos/statuses/ec45dc43eb56b4f23dcfa62a1c2824a7e97d2528"}}}}