{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/43273006","id":43273006,"diff_hunk":"@@ -1,11 +1,53 @@\n 'use strict';\n \n-define(['underscore', 'pim/base-fetcher'], function (_, BaseFetcher) {\n+define(['jquery', 'underscore', 'pim/base-fetcher', 'routing'], function ($, _, BaseFetcher, Routing) {\n     return BaseFetcher.extend({\n-        getIdentifierField: function () {\n-            return this.fetchAll().then(function (attributes) {\n-                return _.findWhere(attributes, { type: 'pim_catalog_identifier' });\n-            }).promise();\n+        identifierPromise: null,\n+\n+        /**\n+         * Return the identifier attribute\n+         *\n+         * @return {Promise}\n+         */\n+        getIdentifierAttribute: function () {\n+            if (null !== this.identifierPromise) {","path":"src/Pim/Bundle/EnrichBundle/Resources/public/js/fetcher/attribute-fetcher.js","position":18,"original_position":18,"commit_id":"cb889600dc484f2b9849ed95cbdd09acd04ad003","original_commit_id":"cb889600dc484f2b9849ed95cbdd09acd04ad003","user":{"login":"sumbobyboys","id":1117272,"avatar_url":"https://avatars.githubusercontent.com/u/1117272?v=3","gravatar_id":"","url":"https://api.github.com/users/sumbobyboys","html_url":"https://github.com/sumbobyboys","followers_url":"https://api.github.com/users/sumbobyboys/followers","following_url":"https://api.github.com/users/sumbobyboys/following{/other_user}","gists_url":"https://api.github.com/users/sumbobyboys/gists{/gist_id}","starred_url":"https://api.github.com/users/sumbobyboys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumbobyboys/subscriptions","organizations_url":"https://api.github.com/users/sumbobyboys/orgs","repos_url":"https://api.github.com/users/sumbobyboys/repos","events_url":"https://api.github.com/users/sumbobyboys/events{/privacy}","received_events_url":"https://api.github.com/users/sumbobyboys/received_events","type":"User","site_admin":false},"body":"please turn it like in other fetchers:\r\n```\r\nif (null === this.identifierPromise) {\r\n\r\n}\r\n\r\nreturn this.identifierPromise;\r\n```","created_at":"2015-10-28T15:41:47Z","updated_at":"2015-10-28T15:41:47Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/3417#discussion_r43273006","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/43273006"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/3417#discussion_r43273006"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417","id":47658792,"html_url":"https://github.com/akeneo/pim-community-dev/pull/3417","diff_url":"https://github.com/akeneo/pim-community-dev/pull/3417.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/3417.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/3417","number":3417,"state":"open","locked":false,"title":"[TR] PIM-5008: Optimize PEF when dealing with lots of attributes","user":{"login":"phaseinducer","id":659491,"avatar_url":"https://avatars.githubusercontent.com/u/659491?v=3","gravatar_id":"","url":"https://api.github.com/users/phaseinducer","html_url":"https://github.com/phaseinducer","followers_url":"https://api.github.com/users/phaseinducer/followers","following_url":"https://api.github.com/users/phaseinducer/following{/other_user}","gists_url":"https://api.github.com/users/phaseinducer/gists{/gist_id}","starred_url":"https://api.github.com/users/phaseinducer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaseinducer/subscriptions","organizations_url":"https://api.github.com/users/phaseinducer/orgs","repos_url":"https://api.github.com/users/phaseinducer/repos","events_url":"https://api.github.com/users/phaseinducer/events{/privacy}","received_events_url":"https://api.github.com/users/phaseinducer/received_events","type":"User","site_admin":false},"body":"https://akeneo.atlassian.net/browse/PIM-5008\r\n\r\n| Q                 | A\r\n| ----------------- | ---\r\n| Specs             | no regression\r\n| Behats            | n/a\r\n| Blue CI           | running\r\n| Changelog updated | yes\r\n| Review and 2 GTM  |\r\n\r\nWhat this PR does ?\r\n- Each time we used to fetch all attributes, fetch only needed attributes by codes instead.\r\n- Rework the \"add attributes\" extension (the last one that really needs all attributes) so that the attributes choices are fetched only when the user opens the multiselect.\r\n- Load the associations grid only when the user opens the associations tab.\r\n- Fix the way identifier attribute is fetched.","created_at":"2015-10-14T13:29:22Z","updated_at":"2015-10-28T15:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b63450fe38e32dd3066613874b22979f8e2d206","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/3417/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/cb889600dc484f2b9849ed95cbdd09acd04ad003","head":{"label":"akeneo:PIM-5008","ref":"PIM-5008","sha":"cb889600dc484f2b9849ed95cbdd09acd04ad003","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"Akeneo PIM development repository","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","created_at":"2012-08-10T09:27:26Z","updated_at":"2015-10-28T10:11:37Z","pushed_at":"2015-10-28T15:27:44Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":189384,"stargazers_count":259,"watchers_count":259,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":68,"forks":130,"open_issues":68,"watchers":259,"default_branch":"master"}},"base":{"label":"akeneo:1.4","ref":"1.4","sha":"d2a0fbb97f63d7ac65ceb1d20e9c8dde985177e8","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"Akeneo PIM development repository","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","created_at":"2012-08-10T09:27:26Z","updated_at":"2015-10-28T10:11:37Z","pushed_at":"2015-10-28T15:27:44Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":189384,"stargazers_count":259,"watchers_count":259,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":68,"forks":130,"open_issues":68,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/3417"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/3417"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/3417/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/3417/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/cb889600dc484f2b9849ed95cbdd09acd04ad003"}}}}