{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/46074780","id":46074780,"diff_hunk":"@@ -128,9 +136,20 @@ oppia.controller('Gallery', [\n       urlService, GALLERY_DATA_URL, CATEGORY_LIST, searchService,\n       ratingVisibilityService) {\n \n+  $translate('I18N_GALLERY_PAGE_TITLE', 'I18N_GALLERY_PAGE_SUBTITLE')\n+   .then(function (translatedPageTitle) {\n+    $rootScope.pageTitle = translatedPageTitle;\n+  });\n+\n+  $rootScope.$on('$translateChangeSuccess', function (event, data) {\n+   $rootScope.pageTitle = ($translate.instant('I18N_GALLERY_PAGE_TITLE') +","path":"core/templates/dev/head/galleries/Gallery.js","position":null,"original_position":43,"commit_id":"b2b6f0e30361e03cd9b468588808c1ed076ea9b1","original_commit_id":"7f7ad60fe03026063cdd8e3c0d763c75660d6172","user":{"login":"mit0110","id":5737003,"avatar_url":"https://avatars.githubusercontent.com/u/5737003?v=3","gravatar_id":"","url":"https://api.github.com/users/mit0110","html_url":"https://github.com/mit0110","followers_url":"https://api.github.com/users/mit0110/followers","following_url":"https://api.github.com/users/mit0110/following{/other_user}","gists_url":"https://api.github.com/users/mit0110/gists{/gist_id}","starred_url":"https://api.github.com/users/mit0110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit0110/subscriptions","organizations_url":"https://api.github.com/users/mit0110/orgs","repos_url":"https://api.github.com/users/mit0110/repos","events_url":"https://api.github.com/users/mit0110/events{/privacy}","received_events_url":"https://api.github.com/users/mit0110/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2015-11-28T02:03:27Z","updated_at":"2015-11-28T02:03:27Z","html_url":"https://github.com/oppia/oppia/pull/948#discussion_r46074780","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/948","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/46074780"},"html":{"href":"https://github.com/oppia/oppia/pull/948#discussion_r46074780"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/948"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/948","id":44316548,"html_url":"https://github.com/oppia/oppia/pull/948","diff_url":"https://github.com/oppia/oppia/pull/948.diff","patch_url":"https://github.com/oppia/oppia/pull/948.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/948","number":948,"state":"open","locked":false,"title":"I18n issue 103","user":{"login":"mit0110","id":5737003,"avatar_url":"https://avatars.githubusercontent.com/u/5737003?v=3","gravatar_id":"","url":"https://api.github.com/users/mit0110","html_url":"https://github.com/mit0110","followers_url":"https://api.github.com/users/mit0110/followers","following_url":"https://api.github.com/users/mit0110/following{/other_user}","gists_url":"https://api.github.com/users/mit0110/gists{/gist_id}","starred_url":"https://api.github.com/users/mit0110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit0110/subscriptions","organizations_url":"https://api.github.com/users/mit0110/orgs","repos_url":"https://api.github.com/users/mit0110/repos","events_url":"https://api.github.com/users/mit0110/events{/privacy}","received_events_url":"https://api.github.com/users/mit0110/received_events","type":"User","site_admin":false},"body":"This pull request contains:\r\n-- The fixes based on the comments of Sean's last code review.\r\n-- Fixes for a bug (strings not translated after filtering explorations in the gallery) and for a failure in the tests, where the original strings were replaced for the translations ids,\r\n-- A first approximation to integration tests for i18n. This would have detected the bug from the previous point. The downside is each test takes a while because is creating explorations. I took the initiative here because I wanted to learn how to use Protractor, they can be removed with no problem!","created_at":"2015-09-07T02:58:18Z","updated_at":"2015-11-28T02:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d56a01ed919fcdddffa8b139399094ec68f9af","assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/948/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/948/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/948/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/b2b6f0e30361e03cd9b468588808c1ed076ea9b1","head":{"label":"mit0110:i18n-issue-103","ref":"i18n-issue-103","sha":"b2b6f0e30361e03cd9b468588808c1ed076ea9b1","user":{"login":"mit0110","id":5737003,"avatar_url":"https://avatars.githubusercontent.com/u/5737003?v=3","gravatar_id":"","url":"https://api.github.com/users/mit0110","html_url":"https://github.com/mit0110","followers_url":"https://api.github.com/users/mit0110/followers","following_url":"https://api.github.com/users/mit0110/following{/other_user}","gists_url":"https://api.github.com/users/mit0110/gists{/gist_id}","starred_url":"https://api.github.com/users/mit0110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit0110/subscriptions","organizations_url":"https://api.github.com/users/mit0110/orgs","repos_url":"https://api.github.com/users/mit0110/repos","events_url":"https://api.github.com/users/mit0110/events{/privacy}","received_events_url":"https://api.github.com/users/mit0110/received_events","type":"User","site_admin":false},"repo":{"id":41835426,"name":"oppia","full_name":"mit0110/oppia","owner":{"login":"mit0110","id":5737003,"avatar_url":"https://avatars.githubusercontent.com/u/5737003?v=3","gravatar_id":"","url":"https://api.github.com/users/mit0110","html_url":"https://github.com/mit0110","followers_url":"https://api.github.com/users/mit0110/followers","following_url":"https://api.github.com/users/mit0110/following{/other_user}","gists_url":"https://api.github.com/users/mit0110/gists{/gist_id}","starred_url":"https://api.github.com/users/mit0110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit0110/subscriptions","organizations_url":"https://api.github.com/users/mit0110/orgs","repos_url":"https://api.github.com/users/mit0110/repos","events_url":"https://api.github.com/users/mit0110/events{/privacy}","received_events_url":"https://api.github.com/users/mit0110/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mit0110/oppia","description":"Tool for creating interactive tutors.","fork":true,"url":"https://api.github.com/repos/mit0110/oppia","forks_url":"https://api.github.com/repos/mit0110/oppia/forks","keys_url":"https://api.github.com/repos/mit0110/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit0110/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit0110/oppia/teams","hooks_url":"https://api.github.com/repos/mit0110/oppia/hooks","issue_events_url":"https://api.github.com/repos/mit0110/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/mit0110/oppia/events","assignees_url":"https://api.github.com/repos/mit0110/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/mit0110/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/mit0110/oppia/tags","blobs_url":"https://api.github.com/repos/mit0110/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit0110/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit0110/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit0110/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit0110/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/mit0110/oppia/languages","stargazers_url":"https://api.github.com/repos/mit0110/oppia/stargazers","contributors_url":"https://api.github.com/repos/mit0110/oppia/contributors","subscribers_url":"https://api.github.com/repos/mit0110/oppia/subscribers","subscription_url":"https://api.github.com/repos/mit0110/oppia/subscription","commits_url":"https://api.github.com/repos/mit0110/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit0110/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit0110/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit0110/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit0110/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/mit0110/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit0110/oppia/merges","archive_url":"https://api.github.com/repos/mit0110/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit0110/oppia/downloads","issues_url":"https://api.github.com/repos/mit0110/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/mit0110/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/mit0110/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/mit0110/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit0110/oppia/labels{/name}","releases_url":"https://api.github.com/repos/mit0110/oppia/releases{/id}","created_at":"2015-09-03T00:56:07Z","updated_at":"2015-09-03T00:56:09Z","pushed_at":"2015-11-28T01:48:01Z","git_url":"git://github.com/mit0110/oppia.git","ssh_url":"git@github.com:mit0110/oppia.git","clone_url":"https://github.com/mit0110/oppia.git","svn_url":"https://github.com/mit0110/oppia","homepage":"https://www.oppia.org","size":38374,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:i18n-issue-103","ref":"i18n-issue-103","sha":"7513b87ca23b845d58348f9ec1e2011eb6e2d603","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive tutors.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","created_at":"2015-08-14T00:16:14Z","updated_at":"2015-11-22T21:46:00Z","pushed_at":"2015-11-28T01:56:22Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":43714,"stargazers_count":58,"watchers_count":58,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":227,"forks":75,"open_issues":227,"watchers":58,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/948"},"html":{"href":"https://github.com/oppia/oppia/pull/948"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/948"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/b2b6f0e30361e03cd9b468588808c1ed076ea9b1"}}}}