{"action":"opened","number":124,"pull_request":{"url":"https://api.github.com/repos/tealeg/xlsx/pulls/124","id":37981348,"html_url":"https://github.com/tealeg/xlsx/pull/124","diff_url":"https://github.com/tealeg/xlsx/pull/124.diff","patch_url":"https://github.com/tealeg/xlsx/pull/124.patch","issue_url":"https://api.github.com/repos/tealeg/xlsx/issues/124","number":124,"state":"open","locked":false,"title":"properly check column hidden for cell hidden logic","user":{"login":"trinchan","id":3772659,"avatar_url":"https://avatars.githubusercontent.com/u/3772659?v=3","gravatar_id":"","url":"https://api.github.com/users/trinchan","html_url":"https://github.com/trinchan","followers_url":"https://api.github.com/users/trinchan/followers","following_url":"https://api.github.com/users/trinchan/following{/other_user}","gists_url":"https://api.github.com/users/trinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/trinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trinchan/subscriptions","organizations_url":"https://api.github.com/users/trinchan/orgs","repos_url":"https://api.github.com/users/trinchan/repos","events_url":"https://api.github.com/users/trinchan/events{/privacy}","received_events_url":"https://api.github.com/users/trinchan/received_events","type":"User","site_admin":false},"body":"There is a bug with hidden cells introduced in this commit.\r\nhttps://github.com/tealeg/xlsx/commit/00de551dc6de154cfa6db6b102a41448b251b8ad#diff-1861a0c40780efdec0f4e6e2e19b3d44R429\r\n\r\n```diff\r\n-\t\t\trow.Cells[cellX].date1904 = file.Date1904\r\n-\t\t\trow.Cells[cellX].Hidden = rawrow.Hidden || (len(cols) > cellX && cols[cellX].Hidden)\r\n+\t\t\tcell.date1904 = file.Date1904\r\n+\t\t\tcell.Hidden = rawrow.Hidden || (len(cols) > cellX && cell.Hidden)\r\n```\r\n\r\n`cell` is set to `row.Cells[cellX]` so replacing `cols[cellX].Hidden` with `cell.Hidden` is incorrect. I changed it back to `cols[cellX].Hidden` so that the column hidden status is properly checked. I also added a test case for this.","created_at":"2015-06-18T08:14:38Z","updated_at":"2015-06-18T08:14:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tealeg/xlsx/pulls/124/commits","review_comments_url":"https://api.github.com/repos/tealeg/xlsx/pulls/124/comments","review_comment_url":"https://api.github.com/repos/tealeg/xlsx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tealeg/xlsx/issues/124/comments","statuses_url":"https://api.github.com/repos/tealeg/xlsx/statuses/d67071547ed3d10406b3dc17f439ddbd455552ad","head":{"label":"trinchan:master","ref":"master","sha":"d67071547ed3d10406b3dc17f439ddbd455552ad","user":{"login":"trinchan","id":3772659,"avatar_url":"https://avatars.githubusercontent.com/u/3772659?v=3","gravatar_id":"","url":"https://api.github.com/users/trinchan","html_url":"https://github.com/trinchan","followers_url":"https://api.github.com/users/trinchan/followers","following_url":"https://api.github.com/users/trinchan/following{/other_user}","gists_url":"https://api.github.com/users/trinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/trinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trinchan/subscriptions","organizations_url":"https://api.github.com/users/trinchan/orgs","repos_url":"https://api.github.com/users/trinchan/repos","events_url":"https://api.github.com/users/trinchan/events{/privacy}","received_events_url":"https://api.github.com/users/trinchan/received_events","type":"User","site_admin":false},"repo":{"id":25021972,"name":"xlsx","full_name":"trinchan/xlsx","owner":{"login":"trinchan","id":3772659,"avatar_url":"https://avatars.githubusercontent.com/u/3772659?v=3","gravatar_id":"","url":"https://api.github.com/users/trinchan","html_url":"https://github.com/trinchan","followers_url":"https://api.github.com/users/trinchan/followers","following_url":"https://api.github.com/users/trinchan/following{/other_user}","gists_url":"https://api.github.com/users/trinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/trinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trinchan/subscriptions","organizations_url":"https://api.github.com/users/trinchan/orgs","repos_url":"https://api.github.com/users/trinchan/repos","events_url":"https://api.github.com/users/trinchan/events{/privacy}","received_events_url":"https://api.github.com/users/trinchan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trinchan/xlsx","description":"Google Go (golang) library for reading and writing XLSX files.","fork":true,"url":"https://api.github.com/repos/trinchan/xlsx","forks_url":"https://api.github.com/repos/trinchan/xlsx/forks","keys_url":"https://api.github.com/repos/trinchan/xlsx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trinchan/xlsx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trinchan/xlsx/teams","hooks_url":"https://api.github.com/repos/trinchan/xlsx/hooks","issue_events_url":"https://api.github.com/repos/trinchan/xlsx/issues/events{/number}","events_url":"https://api.github.com/repos/trinchan/xlsx/events","assignees_url":"https://api.github.com/repos/trinchan/xlsx/assignees{/user}","branches_url":"https://api.github.com/repos/trinchan/xlsx/branches{/branch}","tags_url":"https://api.github.com/repos/trinchan/xlsx/tags","blobs_url":"https://api.github.com/repos/trinchan/xlsx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trinchan/xlsx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trinchan/xlsx/git/refs{/sha}","trees_url":"https://api.github.com/repos/trinchan/xlsx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trinchan/xlsx/statuses/{sha}","languages_url":"https://api.github.com/repos/trinchan/xlsx/languages","stargazers_url":"https://api.github.com/repos/trinchan/xlsx/stargazers","contributors_url":"https://api.github.com/repos/trinchan/xlsx/contributors","subscribers_url":"https://api.github.com/repos/trinchan/xlsx/subscribers","subscription_url":"https://api.github.com/repos/trinchan/xlsx/subscription","commits_url":"https://api.github.com/repos/trinchan/xlsx/commits{/sha}","git_commits_url":"https://api.github.com/repos/trinchan/xlsx/git/commits{/sha}","comments_url":"https://api.github.com/repos/trinchan/xlsx/comments{/number}","issue_comment_url":"https://api.github.com/repos/trinchan/xlsx/issues/comments{/number}","contents_url":"https://api.github.com/repos/trinchan/xlsx/contents/{+path}","compare_url":"https://api.github.com/repos/trinchan/xlsx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trinchan/xlsx/merges","archive_url":"https://api.github.com/repos/trinchan/xlsx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trinchan/xlsx/downloads","issues_url":"https://api.github.com/repos/trinchan/xlsx/issues{/number}","pulls_url":"https://api.github.com/repos/trinchan/xlsx/pulls{/number}","milestones_url":"https://api.github.com/repos/trinchan/xlsx/milestones{/number}","notifications_url":"https://api.github.com/repos/trinchan/xlsx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trinchan/xlsx/labels{/name}","releases_url":"https://api.github.com/repos/trinchan/xlsx/releases{/id}","created_at":"2014-10-10T05:39:55Z","updated_at":"2014-10-14T02:10:30Z","pushed_at":"2015-06-18T08:12:07Z","git_url":"git://github.com/trinchan/xlsx.git","ssh_url":"git@github.com:trinchan/xlsx.git","clone_url":"https://github.com/trinchan/xlsx.git","svn_url":"https://github.com/trinchan/xlsx","homepage":"","size":559,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tealeg:master","ref":"master","sha":"cf67e7486c7f87a757dd63f74312532d0f8bf197","user":{"login":"tealeg","id":20375,"avatar_url":"https://avatars.githubusercontent.com/u/20375?v=3","gravatar_id":"","url":"https://api.github.com/users/tealeg","html_url":"https://github.com/tealeg","followers_url":"https://api.github.com/users/tealeg/followers","following_url":"https://api.github.com/users/tealeg/following{/other_user}","gists_url":"https://api.github.com/users/tealeg/gists{/gist_id}","starred_url":"https://api.github.com/users/tealeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tealeg/subscriptions","organizations_url":"https://api.github.com/users/tealeg/orgs","repos_url":"https://api.github.com/users/tealeg/repos","events_url":"https://api.github.com/users/tealeg/events{/privacy}","received_events_url":"https://api.github.com/users/tealeg/received_events","type":"User","site_admin":false},"repo":{"id":1966991,"name":"xlsx","full_name":"tealeg/xlsx","owner":{"login":"tealeg","id":20375,"avatar_url":"https://avatars.githubusercontent.com/u/20375?v=3","gravatar_id":"","url":"https://api.github.com/users/tealeg","html_url":"https://github.com/tealeg","followers_url":"https://api.github.com/users/tealeg/followers","following_url":"https://api.github.com/users/tealeg/following{/other_user}","gists_url":"https://api.github.com/users/tealeg/gists{/gist_id}","starred_url":"https://api.github.com/users/tealeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tealeg/subscriptions","organizations_url":"https://api.github.com/users/tealeg/orgs","repos_url":"https://api.github.com/users/tealeg/repos","events_url":"https://api.github.com/users/tealeg/events{/privacy}","received_events_url":"https://api.github.com/users/tealeg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tealeg/xlsx","description":"Google Go (golang) library for reading and writing XLSX files.","fork":false,"url":"https://api.github.com/repos/tealeg/xlsx","forks_url":"https://api.github.com/repos/tealeg/xlsx/forks","keys_url":"https://api.github.com/repos/tealeg/xlsx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tealeg/xlsx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tealeg/xlsx/teams","hooks_url":"https://api.github.com/repos/tealeg/xlsx/hooks","issue_events_url":"https://api.github.com/repos/tealeg/xlsx/issues/events{/number}","events_url":"https://api.github.com/repos/tealeg/xlsx/events","assignees_url":"https://api.github.com/repos/tealeg/xlsx/assignees{/user}","branches_url":"https://api.github.com/repos/tealeg/xlsx/branches{/branch}","tags_url":"https://api.github.com/repos/tealeg/xlsx/tags","blobs_url":"https://api.github.com/repos/tealeg/xlsx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tealeg/xlsx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tealeg/xlsx/git/refs{/sha}","trees_url":"https://api.github.com/repos/tealeg/xlsx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tealeg/xlsx/statuses/{sha}","languages_url":"https://api.github.com/repos/tealeg/xlsx/languages","stargazers_url":"https://api.github.com/repos/tealeg/xlsx/stargazers","contributors_url":"https://api.github.com/repos/tealeg/xlsx/contributors","subscribers_url":"https://api.github.com/repos/tealeg/xlsx/subscribers","subscription_url":"https://api.github.com/repos/tealeg/xlsx/subscription","commits_url":"https://api.github.com/repos/tealeg/xlsx/commits{/sha}","git_commits_url":"https://api.github.com/repos/tealeg/xlsx/git/commits{/sha}","comments_url":"https://api.github.com/repos/tealeg/xlsx/comments{/number}","issue_comment_url":"https://api.github.com/repos/tealeg/xlsx/issues/comments{/number}","contents_url":"https://api.github.com/repos/tealeg/xlsx/contents/{+path}","compare_url":"https://api.github.com/repos/tealeg/xlsx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tealeg/xlsx/merges","archive_url":"https://api.github.com/repos/tealeg/xlsx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tealeg/xlsx/downloads","issues_url":"https://api.github.com/repos/tealeg/xlsx/issues{/number}","pulls_url":"https://api.github.com/repos/tealeg/xlsx/pulls{/number}","milestones_url":"https://api.github.com/repos/tealeg/xlsx/milestones{/number}","notifications_url":"https://api.github.com/repos/tealeg/xlsx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tealeg/xlsx/labels{/name}","releases_url":"https://api.github.com/repos/tealeg/xlsx/releases{/id}","created_at":"2011-06-28T15:20:28Z","updated_at":"2015-06-17T13:32:27Z","pushed_at":"2015-06-14T15:02:03Z","git_url":"git://github.com/tealeg/xlsx.git","ssh_url":"git@github.com:tealeg/xlsx.git","clone_url":"https://github.com/tealeg/xlsx.git","svn_url":"https://github.com/tealeg/xlsx","homepage":"","size":1723,"stargazers_count":529,"watchers_count":529,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":10,"forks":154,"open_issues":10,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tealeg/xlsx/pulls/124"},"html":{"href":"https://github.com/tealeg/xlsx/pull/124"},"issue":{"href":"https://api.github.com/repos/tealeg/xlsx/issues/124"},"comments":{"href":"https://api.github.com/repos/tealeg/xlsx/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/tealeg/xlsx/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/tealeg/xlsx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tealeg/xlsx/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/tealeg/xlsx/statuses/d67071547ed3d10406b3dc17f439ddbd455552ad"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":51,"deletions":1,"changed_files":2}}