{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/39980628","id":39980628,"diff_hunk":"@@ -213,6 +213,7 @@ func DefaultAllInOneOptions() (*configapi.MasterConfig, *configapi.NodeConfig, e\n \tstartOptions.MasterOptions.MasterArgs, startOptions.NodeArgs, _, _, _ = setupStartOptions()\n \tstartOptions.MasterOptions.MasterArgs.NodeList = nil\n \tstartOptions.NodeArgs.AllowDisabledDocker = true\n+\tstartOptions.ServiceNetworkCIDR = \"172.30.0.0/16\"","path":"test/util/server.go","position":null,"original_position":4,"commit_id":"455ca7a62a63125098785d23d37b20fcbb46c997","original_commit_id":"3c678bb670bb55199071f7ac69b3a6942a11b6de","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"@danwinship sorry for the churn...","created_at":"2015-09-21T14:59:41Z","updated_at":"2015-09-21T14:59:41Z","html_url":"https://github.com/openshift/origin/pull/4432#discussion_r39980628","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4432","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/39980628"},"html":{"href":"https://github.com/openshift/origin/pull/4432#discussion_r39980628"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4432"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4432","id":43765820,"html_url":"https://github.com/openshift/origin/pull/4432","diff_url":"https://github.com/openshift/origin/pull/4432.diff","patch_url":"https://github.com/openshift/origin/pull/4432.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4432","number":4432,"state":"open","locked":false,"title":"Fix all-in-one network args","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"f025ff9 (#4108) accidentally dropped --portal-net from the all-in-one args. Fix that, and also add the other network args that were previously available in master mode but not all-in-one mode (--host-subnet-length\r\nand --network-cidr).","created_at":"2015-08-31T13:47:12Z","updated_at":"2015-09-21T14:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865d3a37671250fc963f8e87b657e010fd117314","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4432/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4432/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4432/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/455ca7a62a63125098785d23d37b20fcbb46c997","head":{"label":"danwinship:all-in-one-portal-net","ref":"all-in-one-portal-net","sha":"455ca7a62a63125098785d23d37b20fcbb46c997","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"repo":{"id":36016405,"name":"origin","full_name":"danwinship/origin","owner":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danwinship/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/danwinship/origin","forks_url":"https://api.github.com/repos/danwinship/origin/forks","keys_url":"https://api.github.com/repos/danwinship/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danwinship/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danwinship/origin/teams","hooks_url":"https://api.github.com/repos/danwinship/origin/hooks","issue_events_url":"https://api.github.com/repos/danwinship/origin/issues/events{/number}","events_url":"https://api.github.com/repos/danwinship/origin/events","assignees_url":"https://api.github.com/repos/danwinship/origin/assignees{/user}","branches_url":"https://api.github.com/repos/danwinship/origin/branches{/branch}","tags_url":"https://api.github.com/repos/danwinship/origin/tags","blobs_url":"https://api.github.com/repos/danwinship/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danwinship/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danwinship/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/danwinship/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danwinship/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/danwinship/origin/languages","stargazers_url":"https://api.github.com/repos/danwinship/origin/stargazers","contributors_url":"https://api.github.com/repos/danwinship/origin/contributors","subscribers_url":"https://api.github.com/repos/danwinship/origin/subscribers","subscription_url":"https://api.github.com/repos/danwinship/origin/subscription","commits_url":"https://api.github.com/repos/danwinship/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/danwinship/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/danwinship/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/danwinship/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/danwinship/origin/contents/{+path}","compare_url":"https://api.github.com/repos/danwinship/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danwinship/origin/merges","archive_url":"https://api.github.com/repos/danwinship/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danwinship/origin/downloads","issues_url":"https://api.github.com/repos/danwinship/origin/issues{/number}","pulls_url":"https://api.github.com/repos/danwinship/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/danwinship/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/danwinship/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danwinship/origin/labels{/name}","releases_url":"https://api.github.com/repos/danwinship/origin/releases{/id}","created_at":"2015-05-21T14:09:10Z","updated_at":"2015-05-21T14:09:13Z","pushed_at":"2015-09-21T14:42:29Z","git_url":"git://github.com/danwinship/origin.git","ssh_url":"git@github.com:danwinship/origin.git","clone_url":"https://github.com/danwinship/origin.git","svn_url":"https://github.com/danwinship/origin","homepage":"http://www.openshift.org","size":138560,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3fbd1af6f484048a6f6926a2b8c2b396dc2adfa1","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-21T13:22:46Z","pushed_at":"2015-09-21T14:58:47Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":229203,"stargazers_count":687,"watchers_count":687,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":415,"mirror_url":null,"open_issues_count":553,"forks":415,"open_issues":553,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4432"},"html":{"href":"https://github.com/openshift/origin/pull/4432"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4432"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4432/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4432/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4432/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/455ca7a62a63125098785d23d37b20fcbb46c997"}}}}