{"action":"created","issue":{"url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/301","labels_url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/301/comments","events_url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/301/events","html_url":"https://github.com/Bluefieldscom/intl-tel-input/pull/301","id":107903775,"number":301,"title":"Remove jQuery dependency","user":{"login":"Ahimta","id":3470403,"avatar_url":"https://avatars.githubusercontent.com/u/3470403?v=3","gravatar_id":"","url":"https://api.github.com/users/Ahimta","html_url":"https://github.com/Ahimta","followers_url":"https://api.github.com/users/Ahimta/followers","following_url":"https://api.github.com/users/Ahimta/following{/other_user}","gists_url":"https://api.github.com/users/Ahimta/gists{/gist_id}","starred_url":"https://api.github.com/users/Ahimta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ahimta/subscriptions","organizations_url":"https://api.github.com/users/Ahimta/orgs","repos_url":"https://api.github.com/users/Ahimta/repos","events_url":"https://api.github.com/users/Ahimta/events{/privacy}","received_events_url":"https://api.github.com/users/Ahimta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-23T11:52:47Z","updated_at":"2015-09-27T16:56:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/pulls/301","html_url":"https://github.com/Bluefieldscom/intl-tel-input/pull/301","diff_url":"https://github.com/Bluefieldscom/intl-tel-input/pull/301.diff","patch_url":"https://github.com/Bluefieldscom/intl-tel-input/pull/301.patch"},"body":"The library now works without jQuery using native Javascript.\r\njQuery is now only a development dependency for tests using\r\njasmine-jquery matchers.\r\n\r\nHowever, the jQuery plugin is still added if jQuery is defined.\r\n\r\nSome caveats:\r\n1- I am not very confident of src/js/wrapper.js.ejs correctness.\r\n2- The minimized version produces errors when jQuery is not defined\r\n  while the non-minfied version works correctly. This is probably\r\n  because of some hacky behavior in the tooling. Most likely in\r\n  grunt/replace.js. In addition, appearantly, replace tasks aren't\r\n  applied to all files (e.g: some files spec/). Anyways, I personally\r\n  think that grunt/replace.js should be replaced by a more\r\n  conventional solution; if library size is so important then all\r\n  scripts that are always used should be concatenated, uglified and\r\n  gzipped.\r\n\r\nPlease, review and let me know what I should do to make it easy to merge the PR.\r\n\r\nThis PR is only one commit squashed from [here](https://github.com/Ahimta/intl-tel-input/tree/abandon-jquery)\r\nAlmost, every single commit in the original branch is functional, however, the commit messages aren't all that helpfull.\r\n\r\nYou can find the demo here: http://ahimta.github.io/intl-tel-input/"},"comment":{"url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/comments/143576828","html_url":"https://github.com/Bluefieldscom/intl-tel-input/pull/301#issuecomment-143576828","issue_url":"https://api.github.com/repos/Bluefieldscom/intl-tel-input/issues/301","id":143576828,"user":{"login":"jackocnr","id":1186883,"avatar_url":"https://avatars.githubusercontent.com/u/1186883?v=3","gravatar_id":"","url":"https://api.github.com/users/jackocnr","html_url":"https://github.com/jackocnr","followers_url":"https://api.github.com/users/jackocnr/followers","following_url":"https://api.github.com/users/jackocnr/following{/other_user}","gists_url":"https://api.github.com/users/jackocnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jackocnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackocnr/subscriptions","organizations_url":"https://api.github.com/users/jackocnr/orgs","repos_url":"https://api.github.com/users/jackocnr/repos","events_url":"https://api.github.com/users/jackocnr/events{/privacy}","received_events_url":"https://api.github.com/users/jackocnr/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T16:56:57Z","updated_at":"2015-09-27T16:56:57Z","body":"Wow this is super cool, thank you! I had wanted to look into this anyway, but not had the time.\r\n\r\nMy only concern is filesize, and it looks like there's a lot of green additions in this pull request! Do you have an idea of filesize of the built minified file before and after this change?"}}