{"action":"closed","number":73,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73","id":44014832,"html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/73","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/73.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/73.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/73","number":73,"state":"closed","locked":false,"title":"DSDEEPB-958: pass on new Google/OAuth headers","user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE without the new Google/OAuth proxy in place, and without reading through this description fully.\r\n\r\nThis is a *theoretical* and *untested* change. I haven't had a chance to spin up the new OAuth proxy locally, and rawls/agora don't support the new OAuth proxy yet, so I have no idea if this works. It'll be up to you to try it and see.\r\n\r\nThe heart of this change is the new FireCloudRequestBuilder trait and its authHeaders function. This looks for auth headers in the incoming request and copies those headers to the outgoing request.\r\n**TODO: verify this is looking for the correct headers.**\r\n\r\n_Other teams, like rawls, may want a copy of this trait!_\r\n\r\nThen, I've modified all our endpoints to remove handling of the OpenAM cookie and replace with a call to the authHeaders function.\r\n\r\nFinally, I did the same for all our tests, which use a dummy auth header instead of a real one.\r\n**TODO: this means tests will only work against mock data; they'll fail against a real version of rawls/agora because the dummy auth header will be rejected as invalid.**\r\nAlternately, we could choose to remove auth headers from our tests entirely, cleaning them up a bit.\r\n\r\nThe FireCloudRequestBuilding trait could probably be optimized from the pure Scala perspective.\r\n","created_at":"2015-09-02T16:44:31Z","updated_at":"2015-09-04T17:22:04Z","closed_at":"2015-09-04T17:22:04Z","merged_at":"2015-09-04T17:22:04Z","merge_commit_sha":"5255d3a13b30c9aff7089b71c3eaca26acef6ef9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/73/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/f03b028b47cafb4fec2bbb5dde424f74c2c6a1fc","head":{"label":"broadinstitute:da_DSDEEPB-958_passAuthHeaders","ref":"da_DSDEEPB-958_passAuthHeaders","sha":"f03b028b47cafb4fec2bbb5dde424f74c2c6a1fc","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","created_at":"2015-06-11T16:26:34Z","updated_at":"2015-08-04T13:01:37Z","pushed_at":"2015-09-04T17:22:04Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":1379,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"ea46c52d0ae45d1c3f16bea7123afc95305da6b2","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","created_at":"2015-06-11T16:26:34Z","updated_at":"2015-08-04T13:01:37Z","pushed_at":"2015-09-04T17:22:04Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":1379,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/73"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/73"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/f03b028b47cafb4fec2bbb5dde424f74c2c6a1fc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars.githubusercontent.com/u/1545444?v=3","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":185,"deletions":171,"changed_files":14}}