{"action":"created","comment":{"url":"https://api.github.com/repos/obspy/obspy/pulls/comments/23270488","id":23270488,"diff_hunk":"@@ -73,23 +73,23 @@ def compressStartend(x, stop_iteration):\n \n \n def parse_file_to_dict(data_dict, samp_int_dict, file, counter, format=None,\n-                       verbose=False, ignore_links=False):\n+                       verbose=False, quiet=False, ignore_links=False):\n     from matplotlib.dates import date2num\n     if ignore_links and os.path.islink(file):\n-        print(\"Ignoring symlink: %s\" % (file))\n+        if verbose or not quiet:","path":"obspy/imaging/scripts/scan.py","position":9,"original_position":9,"commit_id":"d61975381c4d3518d948a0e25b9446debf17fa4a","original_commit_id":"d61975381c4d3518d948a0e25b9446debf17fa4a","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"This changes default behaviour, no?","created_at":"2015-01-21T00:46:25Z","updated_at":"2015-01-21T00:46:25Z","html_url":"https://github.com/obspy/obspy/pull/929#discussion_r23270488","pull_request_url":"https://api.github.com/repos/obspy/obspy/pulls/929","_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments/23270488"},"html":{"href":"https://github.com/obspy/obspy/pull/929#discussion_r23270488"},"pull_request":{"href":"https://api.github.com/repos/obspy/obspy/pulls/929"}}},"pull_request":{"url":"https://api.github.com/repos/obspy/obspy/pulls/929","id":27623554,"html_url":"https://github.com/obspy/obspy/pull/929","diff_url":"https://github.com/obspy/obspy/pull/929.diff","patch_url":"https://github.com/obspy/obspy/pull/929.patch","issue_url":"https://api.github.com/repos/obspy/obspy/issues/929","number":929,"state":"open","locked":false,"title":"Image comparison","user":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"body":"Work in progress...don't merge yet!\r\n\r\nThis PR replaces the import of matplotlib's `compare_images()` function with a modified copy of the version from the latest matplotlib release. This restores some sanity to the imaging tests. The output of different matplotlib versions might differ slightly but now we at least compare the pictures using the same metric!\r\n\r\nPreviously we had custom baseline tolerances for the different matplotlib versions while still having version dependent relative tolerances in quite a lot of tests! Totally crazy to be honest ;-)\r\n\r\nThis furthermore means that `nose` is no longer required and the `HAS_COMPARE_IMAGES` test skipping condition is now obsolete thus I removed it.\r\n\r\nAlso `obspy.signal.spectral_estimation` no longer has the nice failure mode when matplotlib is not present. Matplotlib has been a hard depedency of ObsPy for quite a while now.","created_at":"2015-01-19T17:37:41Z","updated_at":"2015-01-21T00:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47f662525a62b9d09be4dd9a6de7fdae6275dd3c","assignee":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/obspy/obspy/milestones/5","labels_url":"https://api.github.com/repos/obspy/obspy/milestones/5/labels","id":449804,"number":5,"title":"0.10.0","description":"","creator":{"login":"megies","id":1842780,"avatar_url":"https://avatars.githubusercontent.com/u/1842780?v=3","gravatar_id":"","url":"https://api.github.com/users/megies","html_url":"https://github.com/megies","followers_url":"https://api.github.com/users/megies/followers","following_url":"https://api.github.com/users/megies/following{/other_user}","gists_url":"https://api.github.com/users/megies/gists{/gist_id}","starred_url":"https://api.github.com/users/megies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megies/subscriptions","organizations_url":"https://api.github.com/users/megies/orgs","repos_url":"https://api.github.com/users/megies/repos","events_url":"https://api.github.com/users/megies/events{/privacy}","received_events_url":"https://api.github.com/users/megies/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":104,"state":"open","created_at":"2013-10-08T14:41:54Z","updated_at":"2015-01-21T00:02:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/obspy/obspy/pulls/929/commits","review_comments_url":"https://api.github.com/repos/obspy/obspy/pulls/929/comments","review_comment_url":"https://api.github.com/repos/obspy/obspy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/929/comments","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/d61975381c4d3518d948a0e25b9446debf17fa4a","head":{"label":"krischer:image_comparison","ref":"image_comparison","sha":"d61975381c4d3518d948a0e25b9446debf17fa4a","user":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"repo":{"id":5830460,"name":"obspy","full_name":"krischer/obspy","owner":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krischer/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":true,"url":"https://api.github.com/repos/krischer/obspy","forks_url":"https://api.github.com/repos/krischer/obspy/forks","keys_url":"https://api.github.com/repos/krischer/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krischer/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krischer/obspy/teams","hooks_url":"https://api.github.com/repos/krischer/obspy/hooks","issue_events_url":"https://api.github.com/repos/krischer/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/krischer/obspy/events","assignees_url":"https://api.github.com/repos/krischer/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/krischer/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/krischer/obspy/tags","blobs_url":"https://api.github.com/repos/krischer/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krischer/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krischer/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/krischer/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krischer/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/krischer/obspy/languages","stargazers_url":"https://api.github.com/repos/krischer/obspy/stargazers","contributors_url":"https://api.github.com/repos/krischer/obspy/contributors","subscribers_url":"https://api.github.com/repos/krischer/obspy/subscribers","subscription_url":"https://api.github.com/repos/krischer/obspy/subscription","commits_url":"https://api.github.com/repos/krischer/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/krischer/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/krischer/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/krischer/obspy/issues/comments/{number}","contents_url":"https://api.github.com/repos/krischer/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/krischer/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krischer/obspy/merges","archive_url":"https://api.github.com/repos/krischer/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krischer/obspy/downloads","issues_url":"https://api.github.com/repos/krischer/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/krischer/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/krischer/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/krischer/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krischer/obspy/labels{/name}","releases_url":"https://api.github.com/repos/krischer/obspy/releases{/id}","created_at":"2012-09-16T15:34:42Z","updated_at":"2014-11-20T12:15:18Z","pushed_at":"2015-01-20T23:00:25Z","git_url":"git://github.com/krischer/obspy.git","ssh_url":"git@github.com:krischer/obspy.git","clone_url":"https://github.com/krischer/obspy.git","svn_url":"https://github.com/krischer/obspy","homepage":"https://github.com/obspy/obspy/wiki","size":50280,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"obspy:master","ref":"master","sha":"a063c4d893d897f451484141324eaf2f44b3236a","user":{"login":"obspy","id":1701221,"avatar_url":"https://avatars.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"repo":{"id":5731348,"name":"obspy","full_name":"obspy/obspy","owner":{"login":"obspy","id":1701221,"avatar_url":"https://avatars.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obspy/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":false,"url":"https://api.github.com/repos/obspy/obspy","forks_url":"https://api.github.com/repos/obspy/obspy/forks","keys_url":"https://api.github.com/repos/obspy/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obspy/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obspy/obspy/teams","hooks_url":"https://api.github.com/repos/obspy/obspy/hooks","issue_events_url":"https://api.github.com/repos/obspy/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/obspy/obspy/events","assignees_url":"https://api.github.com/repos/obspy/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/obspy/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/obspy/obspy/tags","blobs_url":"https://api.github.com/repos/obspy/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obspy/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obspy/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/obspy/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/obspy/obspy/languages","stargazers_url":"https://api.github.com/repos/obspy/obspy/stargazers","contributors_url":"https://api.github.com/repos/obspy/obspy/contributors","subscribers_url":"https://api.github.com/repos/obspy/obspy/subscribers","subscription_url":"https://api.github.com/repos/obspy/obspy/subscription","commits_url":"https://api.github.com/repos/obspy/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/obspy/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/obspy/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/obspy/obspy/issues/comments/{number}","contents_url":"https://api.github.com/repos/obspy/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/obspy/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obspy/obspy/merges","archive_url":"https://api.github.com/repos/obspy/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obspy/obspy/downloads","issues_url":"https://api.github.com/repos/obspy/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/obspy/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/obspy/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/obspy/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obspy/obspy/labels{/name}","releases_url":"https://api.github.com/repos/obspy/obspy/releases{/id}","created_at":"2012-09-08T19:17:46Z","updated_at":"2015-01-20T22:59:54Z","pushed_at":"2015-01-20T22:59:49Z","git_url":"git://github.com/obspy/obspy.git","ssh_url":"git@github.com:obspy/obspy.git","clone_url":"https://github.com/obspy/obspy.git","svn_url":"https://github.com/obspy/obspy","homepage":"http://www.obspy.org","size":63327,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":74,"forks":84,"open_issues":74,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/929"},"html":{"href":"https://github.com/obspy/obspy/pull/929"},"issue":{"href":"https://api.github.com/repos/obspy/obspy/issues/929"},"comments":{"href":"https://api.github.com/repos/obspy/obspy/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/obspy/obspy/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/obspy/obspy/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/obspy/obspy/statuses/d61975381c4d3518d948a0e25b9446debf17fa4a"}}}}