{"action":"created","issue":{"url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/1","labels_url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/1/comments","events_url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/1/events","html_url":"https://github.com/onitake/gslx680-acpi/pull/1","id":98197254,"number":1,"title":"added -w to \"grep .rodata \" for accurate search","user":{"login":"tiagosales","id":998731,"avatar_url":"https://avatars.githubusercontent.com/u/998731?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagosales","html_url":"https://github.com/tiagosales","followers_url":"https://api.github.com/users/tiagosales/followers","following_url":"https://api.github.com/users/tiagosales/following{/other_user}","gists_url":"https://api.github.com/users/tiagosales/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagosales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagosales/subscriptions","organizations_url":"https://api.github.com/users/tiagosales/orgs","repos_url":"https://api.github.com/users/tiagosales/repos","events_url":"https://api.github.com/users/tiagosales/events{/privacy}","received_events_url":"https://api.github.com/users/tiagosales/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-07-30T15:28:00Z","updated_at":"2015-07-31T18:08:30Z","closed_at":"2015-07-31T15:39:50Z","pull_request":{"url":"https://api.github.com/repos/onitake/gslx680-acpi/pulls/1","html_url":"https://github.com/onitake/gslx680-acpi/pull/1","diff_url":"https://github.com/onitake/gslx680-acpi/pull/1.diff","patch_url":"https://github.com/onitake/gslx680-acpi/pull/1.patch"},"body":"if we have more than one string \".rodata\" the condition \"if len(args) != 1:\" is triggered.\r\nIt's a false positive if we have simple .rodata section.\r\nExample:\r\nroot@vbox-vm:/media/sf_sqfs# readelf -S gslX680.ko| grep  '.rodata\\ '\r\n  [31] .rodata           PROGBITS        00000000 001604 03d7bc 00   A  0   0  4\r\n  [32] .rel.rodata       REL             00000000 05779c 000010 08     62  31  4\r\n\r\nIf we add '-w' to grep, we have:\r\nroot@vbox-vm:/media/sf_sqfs# readelf -S gslX680.ko| grep -w '.rodata\\ '\r\n  [31] .rodata           PROGBITS        00000000 001604 03d7bc 00   A  0   0  4\r\n\r\nWe can continue to extract the firmware."},"comment":{"url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/comments/126773509","html_url":"https://github.com/onitake/gslx680-acpi/pull/1#issuecomment-126773509","issue_url":"https://api.github.com/repos/onitake/gslx680-acpi/issues/1","id":126773509,"user":{"login":"tiagosales","id":998731,"avatar_url":"https://avatars.githubusercontent.com/u/998731?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagosales","html_url":"https://github.com/tiagosales","followers_url":"https://api.github.com/users/tiagosales/followers","following_url":"https://api.github.com/users/tiagosales/following{/other_user}","gists_url":"https://api.github.com/users/tiagosales/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagosales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagosales/subscriptions","organizations_url":"https://api.github.com/users/tiagosales/orgs","repos_url":"https://api.github.com/users/tiagosales/repos","events_url":"https://api.github.com/users/tiagosales/events{/privacy}","received_events_url":"https://api.github.com/users/tiagosales/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T18:08:30Z","updated_at":"2015-07-31T18:08:30Z","body":"Tested.\n\nAll right.\n\nBest regards,\n--\n*Tiago Sales*\n\n2015-07-31 12:45 GMT-03:00 onitake <notifications@github.com>:\n\n> All right, applied. You can test the result, if you like.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/onitake/gslx680-acpi/pull/1#issuecomment-126729152>.\n>\n"}}