{"action":"created","comment":{"url":"https://api.github.com/repos/LK4D4/docker/pulls/comments/25485652","id":25485652,"diff_hunk":"@@ -0,0 +1,25 @@\n+package loggers\n+\n+import (\n+\t\"fmt\"\n+\t\"github.com/docker/docker/daemon/logger\"\n+\t\"github.com/docker/docker/daemon/logger/dockerlog\"\n+)\n+\n+func New(Type string, Config map[string]string) (logger.Logger, error) {","path":"daemon/logger/loggers/loggers.go","position":9,"original_position":9,"commit_id":"7fe98baf3b6e549a6aca2029caedfd07b47d374f","original_commit_id":"7fe98baf3b6e549a6aca2029caedfd07b47d374f","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"Parameters should start from lowercase. ","created_at":"2015-02-27T03:09:54Z","updated_at":"2015-02-27T03:09:54Z","html_url":"https://github.com/LK4D4/docker/pull/8#discussion_r25485652","pull_request_url":"https://api.github.com/repos/LK4D4/docker/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/comments/25485652"},"html":{"href":"https://github.com/LK4D4/docker/pull/8#discussion_r25485652"},"pull_request":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/LK4D4/docker/pulls/8","id":30137762,"html_url":"https://github.com/LK4D4/docker/pull/8","diff_url":"https://github.com/LK4D4/docker/pull/8.diff","patch_url":"https://github.com/LK4D4/docker/pull/8.patch","issue_url":"https://api.github.com/repos/LK4D4/docker/issues/8","number":8,"state":"open","locked":false,"title":"I was curious if extracting the logger creation made sense in this case","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>\r\n\r\nHeya :)\r\n\r\nI was talking to someone at a meetup last week, and I might be able to persuade them to write a very simplistic network based logger next month at the party - so I was looking at your PR, and wondered if it was worth extracting the logger creation code out of the container module.\r\n\r\nI'm not really sure anymore, but as I need to learn more go-style, thought I'd ask - is this a reasonable and worthwhile extraction (on the assumption that there will be more logger drivers soon), or is that not how its done :)\r\n\r\n","created_at":"2015-02-27T02:49:02Z","updated_at":"2015-02-27T03:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8c7ffc280066143e475fffeec2ddc8c9f3f9f6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LK4D4/docker/pulls/8/commits","review_comments_url":"https://api.github.com/repos/LK4D4/docker/pulls/8/comments","review_comment_url":"https://api.github.com/repos/LK4D4/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LK4D4/docker/issues/8/comments","statuses_url":"https://api.github.com/repos/LK4D4/docker/statuses/7fe98baf3b6e549a6aca2029caedfd07b47d374f","head":{"label":"SvenDowideit:does-this-make-sense","ref":"does-this-make-sense","sha":"7fe98baf3b6e549a6aca2029caedfd07b47d374f","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"repo":{"id":13399967,"name":"docker","full_name":"SvenDowideit/docker","owner":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SvenDowideit/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/SvenDowideit/docker","forks_url":"https://api.github.com/repos/SvenDowideit/docker/forks","keys_url":"https://api.github.com/repos/SvenDowideit/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SvenDowideit/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SvenDowideit/docker/teams","hooks_url":"https://api.github.com/repos/SvenDowideit/docker/hooks","issue_events_url":"https://api.github.com/repos/SvenDowideit/docker/issues/events{/number}","events_url":"https://api.github.com/repos/SvenDowideit/docker/events","assignees_url":"https://api.github.com/repos/SvenDowideit/docker/assignees{/user}","branches_url":"https://api.github.com/repos/SvenDowideit/docker/branches{/branch}","tags_url":"https://api.github.com/repos/SvenDowideit/docker/tags","blobs_url":"https://api.github.com/repos/SvenDowideit/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SvenDowideit/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SvenDowideit/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/SvenDowideit/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SvenDowideit/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/SvenDowideit/docker/languages","stargazers_url":"https://api.github.com/repos/SvenDowideit/docker/stargazers","contributors_url":"https://api.github.com/repos/SvenDowideit/docker/contributors","subscribers_url":"https://api.github.com/repos/SvenDowideit/docker/subscribers","subscription_url":"https://api.github.com/repos/SvenDowideit/docker/subscription","commits_url":"https://api.github.com/repos/SvenDowideit/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/SvenDowideit/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/SvenDowideit/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/SvenDowideit/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/SvenDowideit/docker/contents/{+path}","compare_url":"https://api.github.com/repos/SvenDowideit/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SvenDowideit/docker/merges","archive_url":"https://api.github.com/repos/SvenDowideit/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SvenDowideit/docker/downloads","issues_url":"https://api.github.com/repos/SvenDowideit/docker/issues{/number}","pulls_url":"https://api.github.com/repos/SvenDowideit/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/SvenDowideit/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/SvenDowideit/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SvenDowideit/docker/labels{/name}","releases_url":"https://api.github.com/repos/SvenDowideit/docker/releases{/id}","created_at":"2013-10-08T00:56:36Z","updated_at":"2015-02-26T22:43:50Z","pushed_at":"2015-02-27T02:48:53Z","git_url":"git://github.com/SvenDowideit/docker.git","ssh_url":"git@github.com:SvenDowideit/docker.git","clone_url":"https://github.com/SvenDowideit/docker.git","svn_url":"https://github.com/SvenDowideit/docker","homepage":"http://www.docker.io","size":49492,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"LK4D4:logging_drivers","ref":"logging_drivers","sha":"a8037a4ddf6fd86a82c2132d9d91bb86316447d0","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"repo":{"id":17854886,"name":"docker","full_name":"LK4D4/docker","owner":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LK4D4/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/LK4D4/docker","forks_url":"https://api.github.com/repos/LK4D4/docker/forks","keys_url":"https://api.github.com/repos/LK4D4/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LK4D4/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LK4D4/docker/teams","hooks_url":"https://api.github.com/repos/LK4D4/docker/hooks","issue_events_url":"https://api.github.com/repos/LK4D4/docker/issues/events{/number}","events_url":"https://api.github.com/repos/LK4D4/docker/events","assignees_url":"https://api.github.com/repos/LK4D4/docker/assignees{/user}","branches_url":"https://api.github.com/repos/LK4D4/docker/branches{/branch}","tags_url":"https://api.github.com/repos/LK4D4/docker/tags","blobs_url":"https://api.github.com/repos/LK4D4/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LK4D4/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LK4D4/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/LK4D4/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LK4D4/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/LK4D4/docker/languages","stargazers_url":"https://api.github.com/repos/LK4D4/docker/stargazers","contributors_url":"https://api.github.com/repos/LK4D4/docker/contributors","subscribers_url":"https://api.github.com/repos/LK4D4/docker/subscribers","subscription_url":"https://api.github.com/repos/LK4D4/docker/subscription","commits_url":"https://api.github.com/repos/LK4D4/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/LK4D4/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/LK4D4/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/LK4D4/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/LK4D4/docker/contents/{+path}","compare_url":"https://api.github.com/repos/LK4D4/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LK4D4/docker/merges","archive_url":"https://api.github.com/repos/LK4D4/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LK4D4/docker/downloads","issues_url":"https://api.github.com/repos/LK4D4/docker/issues{/number}","pulls_url":"https://api.github.com/repos/LK4D4/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/LK4D4/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/LK4D4/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LK4D4/docker/labels{/name}","releases_url":"https://api.github.com/repos/LK4D4/docker/releases{/id}","created_at":"2014-03-18T05:30:16Z","updated_at":"2014-11-28T02:49:00Z","pushed_at":"2015-02-26T23:47:30Z","git_url":"git://github.com/LK4D4/docker.git","ssh_url":"git@github.com:LK4D4/docker.git","clone_url":"https://github.com/LK4D4/docker.git","svn_url":"https://github.com/LK4D4/docker","homepage":"http://www.docker.io","size":43769,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/8"},"html":{"href":"https://github.com/LK4D4/docker/pull/8"},"issue":{"href":"https://api.github.com/repos/LK4D4/docker/issues/8"},"comments":{"href":"https://api.github.com/repos/LK4D4/docker/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LK4D4/docker/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/LK4D4/docker/statuses/7fe98baf3b6e549a6aca2029caedfd07b47d374f"}}}}