{"action":"created","comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/22439303","id":22439303,"diff_hunk":"@@ -21,17 +22,14 @@ class DlgFilterGames : public QDialog {\n     QSpinBox *maxPlayersFilterMaxSpinBox;\n \n     const QMap<int, QString> &allGameTypes;\n+    // This needs a const someplace","path":"cockatrice/src/dlg_filter_games.h","position":12,"original_position":12,"commit_id":"bb317003b40dc270f89247b2060e8361a6a65b03","original_commit_id":"bb317003b40dc270f89247b2060e8361a6a65b03","user":{"login":"Daenyth","id":14644,"avatar_url":"https://avatars.githubusercontent.com/u/14644?v=3","gravatar_id":"","url":"https://api.github.com/users/Daenyth","html_url":"https://github.com/Daenyth","followers_url":"https://api.github.com/users/Daenyth/followers","following_url":"https://api.github.com/users/Daenyth/following{/other_user}","gists_url":"https://api.github.com/users/Daenyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenyth/subscriptions","organizations_url":"https://api.github.com/users/Daenyth/orgs","repos_url":"https://api.github.com/users/Daenyth/repos","events_url":"https://api.github.com/users/Daenyth/events{/privacy}","received_events_url":"https://api.github.com/users/Daenyth/received_events","type":"User","site_admin":false},"body":"I'd like to see the comment explain why, or it's not very useful","created_at":"2015-01-04T13:46:25Z","updated_at":"2015-01-04T13:46:25Z","html_url":"https://github.com/Cockatrice/Cockatrice/pull/523#discussion_r22439303","pull_request_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/22439303"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/523#discussion_r22439303"},"pull_request":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523","id":26777646,"html_url":"https://github.com/Cockatrice/Cockatrice/pull/523","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/523.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/523.patch","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/523","number":523,"state":"open","locked":false,"title":"Apply filters at start","user":{"login":"kaiserfro","id":997659,"avatar_url":"https://avatars.githubusercontent.com/u/997659?v=3","gravatar_id":"","url":"https://api.github.com/users/kaiserfro","html_url":"https://github.com/kaiserfro","followers_url":"https://api.github.com/users/kaiserfro/followers","following_url":"https://api.github.com/users/kaiserfro/following{/other_user}","gists_url":"https://api.github.com/users/kaiserfro/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiserfro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiserfro/subscriptions","organizations_url":"https://api.github.com/users/kaiserfro/orgs","repos_url":"https://api.github.com/users/kaiserfro/repos","events_url":"https://api.github.com/users/kaiserfro/events{/privacy}","received_events_url":"https://api.github.com/users/kaiserfro/received_events","type":"User","site_admin":false},"body":"Fixes #509 \r\n\r\nBasically, this patch refactors the filter code such that persistence of the filters is not done by the dialog class, but the model instead.  Then the dialog uses the model to set the state of the dialog properly, then save the data back to the model, then on to the qsettings.\r\n\r\nI added a load filters function that is called at the time the games window is created that sets the filters up initially from the saved settings.","created_at":"2015-01-03T01:29:39Z","updated_at":"2015-01-04T13:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b7014c065c062c2ead07a0953c74bfbdcd5d221","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523/commits","review_comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523/comments","review_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/523/comments","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/bb317003b40dc270f89247b2060e8361a6a65b03","head":{"label":"kaiserfro:apply-filters-at-start2","ref":"apply-filters-at-start2","sha":"bb317003b40dc270f89247b2060e8361a6a65b03","user":{"login":"kaiserfro","id":997659,"avatar_url":"https://avatars.githubusercontent.com/u/997659?v=3","gravatar_id":"","url":"https://api.github.com/users/kaiserfro","html_url":"https://github.com/kaiserfro","followers_url":"https://api.github.com/users/kaiserfro/followers","following_url":"https://api.github.com/users/kaiserfro/following{/other_user}","gists_url":"https://api.github.com/users/kaiserfro/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiserfro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiserfro/subscriptions","organizations_url":"https://api.github.com/users/kaiserfro/orgs","repos_url":"https://api.github.com/users/kaiserfro/repos","events_url":"https://api.github.com/users/kaiserfro/events{/privacy}","received_events_url":"https://api.github.com/users/kaiserfro/received_events","type":"User","site_admin":false},"repo":{"id":28701552,"name":"Cockatrice","full_name":"kaiserfro/Cockatrice","owner":{"login":"kaiserfro","id":997659,"avatar_url":"https://avatars.githubusercontent.com/u/997659?v=3","gravatar_id":"","url":"https://api.github.com/users/kaiserfro","html_url":"https://github.com/kaiserfro","followers_url":"https://api.github.com/users/kaiserfro/followers","following_url":"https://api.github.com/users/kaiserfro/following{/other_user}","gists_url":"https://api.github.com/users/kaiserfro/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiserfro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiserfro/subscriptions","organizations_url":"https://api.github.com/users/kaiserfro/orgs","repos_url":"https://api.github.com/users/kaiserfro/repos","events_url":"https://api.github.com/users/kaiserfro/events{/privacy}","received_events_url":"https://api.github.com/users/kaiserfro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaiserfro/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":true,"url":"https://api.github.com/repos/kaiserfro/Cockatrice","forks_url":"https://api.github.com/repos/kaiserfro/Cockatrice/forks","keys_url":"https://api.github.com/repos/kaiserfro/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaiserfro/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaiserfro/Cockatrice/teams","hooks_url":"https://api.github.com/repos/kaiserfro/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/kaiserfro/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/kaiserfro/Cockatrice/events","assignees_url":"https://api.github.com/repos/kaiserfro/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/kaiserfro/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/kaiserfro/Cockatrice/tags","blobs_url":"https://api.github.com/repos/kaiserfro/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaiserfro/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaiserfro/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaiserfro/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaiserfro/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/kaiserfro/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/kaiserfro/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/kaiserfro/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/kaiserfro/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/kaiserfro/Cockatrice/subscription","commits_url":"https://api.github.com/repos/kaiserfro/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaiserfro/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaiserfro/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaiserfro/Cockatrice/issues/comments/{number}","contents_url":"https://api.github.com/repos/kaiserfro/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/kaiserfro/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaiserfro/Cockatrice/merges","archive_url":"https://api.github.com/repos/kaiserfro/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaiserfro/Cockatrice/downloads","issues_url":"https://api.github.com/repos/kaiserfro/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/kaiserfro/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/kaiserfro/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/kaiserfro/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaiserfro/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/kaiserfro/Cockatrice/releases{/id}","created_at":"2015-01-02T02:44:17Z","updated_at":"2015-01-02T02:44:21Z","pushed_at":"2015-01-03T01:24:53Z","git_url":"git://github.com/kaiserfro/Cockatrice.git","ssh_url":"git@github.com:kaiserfro/Cockatrice.git","clone_url":"https://github.com/kaiserfro/Cockatrice.git","svn_url":"https://github.com/kaiserfro/Cockatrice","homepage":"","size":22413,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cockatrice:master","ref":"master","sha":"471a690cf04acf3a5a012dc8420253bbd360ba5f","user":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments/{number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","created_at":"2011-12-03T20:58:09Z","updated_at":"2015-01-04T13:45:20Z","pushed_at":"2015-01-04T13:45:20Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"","size":27987,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":170,"forks":144,"open_issues":170,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/523"},"issue":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/523"},"comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/bb317003b40dc270f89247b2060e8361a6a65b03"}}}}