{"push_id":568378959,"size":11,"distinct_size":10,"ref":"refs/heads/master","head":"1492e83e49f74b1d874585000bad5368d9f09218","before":"b9ba90d59ed28c28c07b04ecdc2035b471aea881","commits":[{"sha":"85400b3384319a05e0f4923a92bde7befd80f5df","author":{"email":"150f33486cd7b50b4b015bd70c95dea78762c3b8@nrel.gov","name":"John Krueger"},"message":"use rails favicon.ico instead or ruby favicon.ico for rails guides","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/85400b3384319a05e0f4923a92bde7befd80f5df"},{"sha":"7b58423251344824b58825d5b5e6597cb3e5c21c","author":{"email":"3cd0e1743d4b0102caa36ea802df98d88fe593cd@vinsol.com","name":"Aditya Kapoor"},"message":"remove noise from AM tests","distinct":false,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/7b58423251344824b58825d5b5e6597cb3e5c21c"},{"sha":"ebe73abea0ae02094ddc28f8fd60ae92373b6113","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@yukinishijima.net","name":"Yuki Nishijima"},"message":"NameError#missing_name? can jsut use NameError#name if the arg is a Symbol\n\nNameError#name returns a missing name as a symbol, so if the given name\nis a symbol, it doesn't have to use #missing_name to get the last constant\nname in the error message.","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/ebe73abea0ae02094ddc28f8fd60ae92373b6113"},{"sha":"ae3e3624c2dc037f6a17226f265eef59243c181a","author":{"email":"be11b38ca2a8492ea688531e4730d7fc0f6b7beb@hashref.com","name":"Xavier Noria"},"message":"Merge pull request #18835 from jtmkrueger/master\n\nUse the Rails favicon.ico instead of the ruby favicon.ico for rails guides [ci skip]","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/ae3e3624c2dc037f6a17226f265eef59243c181a"},{"sha":"70693f08d04292c06e26720e682fc0e1b456935f","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #18574 from aditya-kapoor/silent-actionmailer-tests\n\nremove noise from AM tests","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/70693f08d04292c06e26720e682fc0e1b456935f"},{"sha":"bdeeca84e34d3e0863a6fd03defb9c95fd0241d9","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #18842 from yuki24/simplify-NameError#missing_name\n\nNameError#missing_name? can just use NameError#name if the arg is a Symbol","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/bdeeca84e34d3e0863a6fd03defb9c95fd0241d9"},{"sha":"631707a572fe14f3bbea2779cc97fcc581048d62","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Push multi-parameter assignement into the types\n\nThis allows us to remove `Type::Value#klass`, as it was only used for\nmulti-parameter assignment to reach into the types internals. The\nrelevant type objects now accept a hash in addition to their previous\naccepted arguments to `type_cast_from_user`. This required minor\nmodifications to the tests, since previously they were relying on the\nfact that mulit-parameter assignement was reaching into the internals of\ntime zone aware attributes. In reaility, changing those properties at\nruntime wouldn't change the accessor methods for all other forms of\nassignment.","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/631707a572fe14f3bbea2779cc97fcc581048d62"},{"sha":"7e93e33c1980ea3d08cec9708d2737f1c8d0a10a","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"rm `ActiveRecord::Type::Decorator`\n\nIt only existed to make sure the subclasses of `Delegator` were YAML\nserializable. As of Ruby 2.2, these are YAML dumpable by default, as it\nincludes\nhttps://github.com/tenderlove/psych/commit/2a4d9568f7d5d19c00231cf48eb855cc45ec3394","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/7e93e33c1980ea3d08cec9708d2737f1c8d0a10a"},{"sha":"c4ef73affdc67efb02ca369326aaaaab3fd94d21","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Move non-type objects into the `Type::Helpers` namespace\n\nThe type code is actually quite accessible, and I'm planning to\nencourage people to look at the files in the `type` folder to learn more\nabout how it works. This will help reduce the noise from code that is\nless about type casting, and more about random AR nonsense.","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/c4ef73affdc67efb02ca369326aaaaab3fd94d21"},{"sha":"16629c099ca30895c90661d5cbce40e218f0984e","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"rm `Type#text?`\n\nThis predicate was only to figure out if it's safe to do case\ninsensitive comparison, which is only a problem on PG. Turns out, PG can\njust tell us whether we are able to do it or not. If the query turns out\nto be a problem, let's just replace that method with checking the SQL\ntype for `text` or `character`. I'd rather not burden the type objects\nwith adapter specific knowledge.\n\nThe *real* solution, is to deprecate this behavior entirely. The only\nreason we need it is because the `:case_sensitive` option for\n`validates_uniqueness_of` is documented as \"this option is ignored for\nnon-strings\". It makes no sense for us to do that. If the type can't be\ncompared in a case insensitive way, the user shouldn't tell us to do\ncase insensitive comparison.","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/16629c099ca30895c90661d5cbce40e218f0984e"},{"sha":"1492e83e49f74b1d874585000bad5368d9f09218","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"rm `Type#number?`\n\nThis predicate is only used in `query_attribute`, and is relatively easy\nto remove without adding a bunch of is a checks.","distinct":true,"url":"https://api.github.com/repos/aditya-kapoor/rails/commits/1492e83e49f74b1d874585000bad5368d9f09218"}]}