{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1957","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1957/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1957/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1957/events","html_url":"https://github.com/jenkinsci/jenkins/pull/1957","id":123183631,"number":1957,"title":"walkmod execution to remove dead code","user":{"login":"rpau","id":1483433,"avatar_url":"https://avatars.githubusercontent.com/u/1483433?v=3","gravatar_id":"","url":"https://api.github.com/users/rpau","html_url":"https://github.com/rpau","followers_url":"https://api.github.com/users/rpau/followers","following_url":"https://api.github.com/users/rpau/following{/other_user}","gists_url":"https://api.github.com/users/rpau/gists{/gist_id}","starred_url":"https://api.github.com/users/rpau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpau/subscriptions","organizations_url":"https://api.github.com/users/rpau/orgs","repos_url":"https://api.github.com/users/rpau/repos","events_url":"https://api.github.com/users/rpau/events{/privacy}","received_events_url":"https://api.github.com/users/rpau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-20T21:09:08Z","updated_at":"2015-12-23T14:49:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1957","html_url":"https://github.com/jenkinsci/jenkins/pull/1957","diff_url":"https://github.com/jenkinsci/jenkins/pull/1957.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1957.patch"},"body":"Hi,\r\n\r\nI have executed walkmod, an open source tool to apply code conventions. In this case, I just tried to remove dead code in the core module. After executing it, the results are as follows:\r\n\r\n- Deletes of unused imports\r\n- Deletes of private variables and fields\r\n- Deletes of some private \"readResolve\" methods because classes are not Serializable.\r\n\r\nMoreover, executing walkmod I have discovered some dependency conflicts that I have specified as \"exclusions\" and a missing runtime dependency.\r\n\r\nLet me know if the results seem interesting to you :) and thank you for your time.\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/166915627","html_url":"https://github.com/jenkinsci/jenkins/pull/1957#issuecomment-166915627","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1957","id":166915627,"user":{"login":"rpau","id":1483433,"avatar_url":"https://avatars.githubusercontent.com/u/1483433?v=3","gravatar_id":"","url":"https://api.github.com/users/rpau","html_url":"https://github.com/rpau","followers_url":"https://api.github.com/users/rpau/followers","following_url":"https://api.github.com/users/rpau/following{/other_user}","gists_url":"https://api.github.com/users/rpau/gists{/gist_id}","starred_url":"https://api.github.com/users/rpau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpau/subscriptions","organizations_url":"https://api.github.com/users/rpau/orgs","repos_url":"https://api.github.com/users/rpau/repos","events_url":"https://api.github.com/users/rpau/events{/privacy}","received_events_url":"https://api.github.com/users/rpau/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T14:49:26Z","updated_at":"2015-12-23T14:49:26Z","body":"Hi, I have upgraded the walkmod configuration and the final result. Now, the readResolve methods are not removed. Can you take a look if the rest is ok for you? \r\n\r\nThanks"}}