{"action":"closed","number":79,"pull_request":{"url":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79","id":35755436,"html_url":"https://github.com/andreareginato/oauth-ng/pull/79","diff_url":"https://github.com/andreareginato/oauth-ng/pull/79.diff","patch_url":"https://github.com/andreareginato/oauth-ng/pull/79.patch","issue_url":"https://api.github.com/repos/andreareginato/oauth-ng/issues/79","number":79,"state":"closed","locked":false,"title":"URI encoding of scopes, request type, and adding nonce","user":{"login":"meschbach","id":771422,"avatar_url":"https://avatars.githubusercontent.com/u/771422?v=3","gravatar_id":"","url":"https://api.github.com/users/meschbach","html_url":"https://github.com/meschbach","followers_url":"https://api.github.com/users/meschbach/followers","following_url":"https://api.github.com/users/meschbach/following{/other_user}","gists_url":"https://api.github.com/users/meschbach/gists{/gist_id}","starred_url":"https://api.github.com/users/meschbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meschbach/subscriptions","organizations_url":"https://api.github.com/users/meschbach/orgs","repos_url":"https://api.github.com/users/meschbach/repos","events_url":"https://api.github.com/users/meschbach/events{/privacy}","received_events_url":"https://api.github.com/users/meschbach/received_events","type":"User","site_admin":false},"body":"I'm attempting to support an OpenID Connect 1.0 system using oauth-ng.  Given the UI requirements for displaying user profile information, the project can't use the oauth directive so we are using the associated components manually; so this doesn't include modifications to the tag itself.  I would be happy to add these if you feel like they provide enough value.\r\n\r\nThe attached patches adds support for URI encoding of the scope and request types as well as nonce on the Endpoint factory, including associated tests.  To allow for better capture of state and nonce I added the capability to override the configuration given to Endpoint#set in Endpoint#get.","created_at":"2015-05-19T17:38:42Z","updated_at":"2015-06-11T21:30:37Z","closed_at":"2015-06-11T21:30:37Z","merged_at":"2015-06-11T21:30:37Z","merge_commit_sha":"78914bea9bca14ba698eb7e33224d985713ce399","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79/commits","review_comments_url":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79/comments","review_comment_url":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andreareginato/oauth-ng/issues/79/comments","statuses_url":"https://api.github.com/repos/andreareginato/oauth-ng/statuses/34bcfa183e0f5627baa6b62d12a7440ef01e9bed","head":{"label":"meschbach:nonce","ref":"nonce","sha":"34bcfa183e0f5627baa6b62d12a7440ef01e9bed","user":{"login":"meschbach","id":771422,"avatar_url":"https://avatars.githubusercontent.com/u/771422?v=3","gravatar_id":"","url":"https://api.github.com/users/meschbach","html_url":"https://github.com/meschbach","followers_url":"https://api.github.com/users/meschbach/followers","following_url":"https://api.github.com/users/meschbach/following{/other_user}","gists_url":"https://api.github.com/users/meschbach/gists{/gist_id}","starred_url":"https://api.github.com/users/meschbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meschbach/subscriptions","organizations_url":"https://api.github.com/users/meschbach/orgs","repos_url":"https://api.github.com/users/meschbach/repos","events_url":"https://api.github.com/users/meschbach/events{/privacy}","received_events_url":"https://api.github.com/users/meschbach/received_events","type":"User","site_admin":false},"repo":{"id":35785680,"name":"oauth-ng","full_name":"meschbach/oauth-ng","owner":{"login":"meschbach","id":771422,"avatar_url":"https://avatars.githubusercontent.com/u/771422?v=3","gravatar_id":"","url":"https://api.github.com/users/meschbach","html_url":"https://github.com/meschbach","followers_url":"https://api.github.com/users/meschbach/followers","following_url":"https://api.github.com/users/meschbach/following{/other_user}","gists_url":"https://api.github.com/users/meschbach/gists{/gist_id}","starred_url":"https://api.github.com/users/meschbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meschbach/subscriptions","organizations_url":"https://api.github.com/users/meschbach/orgs","repos_url":"https://api.github.com/users/meschbach/repos","events_url":"https://api.github.com/users/meschbach/events{/privacy}","received_events_url":"https://api.github.com/users/meschbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meschbach/oauth-ng","description":"AngularJS directive for the OAuth 2.0 Implicit Flow","fork":true,"url":"https://api.github.com/repos/meschbach/oauth-ng","forks_url":"https://api.github.com/repos/meschbach/oauth-ng/forks","keys_url":"https://api.github.com/repos/meschbach/oauth-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meschbach/oauth-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meschbach/oauth-ng/teams","hooks_url":"https://api.github.com/repos/meschbach/oauth-ng/hooks","issue_events_url":"https://api.github.com/repos/meschbach/oauth-ng/issues/events{/number}","events_url":"https://api.github.com/repos/meschbach/oauth-ng/events","assignees_url":"https://api.github.com/repos/meschbach/oauth-ng/assignees{/user}","branches_url":"https://api.github.com/repos/meschbach/oauth-ng/branches{/branch}","tags_url":"https://api.github.com/repos/meschbach/oauth-ng/tags","blobs_url":"https://api.github.com/repos/meschbach/oauth-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meschbach/oauth-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meschbach/oauth-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/meschbach/oauth-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meschbach/oauth-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/meschbach/oauth-ng/languages","stargazers_url":"https://api.github.com/repos/meschbach/oauth-ng/stargazers","contributors_url":"https://api.github.com/repos/meschbach/oauth-ng/contributors","subscribers_url":"https://api.github.com/repos/meschbach/oauth-ng/subscribers","subscription_url":"https://api.github.com/repos/meschbach/oauth-ng/subscription","commits_url":"https://api.github.com/repos/meschbach/oauth-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/meschbach/oauth-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/meschbach/oauth-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/meschbach/oauth-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/meschbach/oauth-ng/contents/{+path}","compare_url":"https://api.github.com/repos/meschbach/oauth-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meschbach/oauth-ng/merges","archive_url":"https://api.github.com/repos/meschbach/oauth-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meschbach/oauth-ng/downloads","issues_url":"https://api.github.com/repos/meschbach/oauth-ng/issues{/number}","pulls_url":"https://api.github.com/repos/meschbach/oauth-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/meschbach/oauth-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/meschbach/oauth-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meschbach/oauth-ng/labels{/name}","releases_url":"https://api.github.com/repos/meschbach/oauth-ng/releases{/id}","created_at":"2015-05-17T22:33:36Z","updated_at":"2015-05-17T22:33:37Z","pushed_at":"2015-06-11T18:03:04Z","git_url":"git://github.com/meschbach/oauth-ng.git","ssh_url":"git@github.com:meschbach/oauth-ng.git","clone_url":"https://github.com/meschbach/oauth-ng.git","svn_url":"https://github.com/meschbach/oauth-ng","homepage":"https://andreareginato.github.com/oauth-ng","size":1386,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andreareginato:master","ref":"master","sha":"13578c8e96773e517c323e8a8488a11ec212632c","user":{"login":"andreareginato","id":37480,"avatar_url":"https://avatars.githubusercontent.com/u/37480?v=3","gravatar_id":"","url":"https://api.github.com/users/andreareginato","html_url":"https://github.com/andreareginato","followers_url":"https://api.github.com/users/andreareginato/followers","following_url":"https://api.github.com/users/andreareginato/following{/other_user}","gists_url":"https://api.github.com/users/andreareginato/gists{/gist_id}","starred_url":"https://api.github.com/users/andreareginato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreareginato/subscriptions","organizations_url":"https://api.github.com/users/andreareginato/orgs","repos_url":"https://api.github.com/users/andreareginato/repos","events_url":"https://api.github.com/users/andreareginato/events{/privacy}","received_events_url":"https://api.github.com/users/andreareginato/received_events","type":"User","site_admin":false},"repo":{"id":13938317,"name":"oauth-ng","full_name":"andreareginato/oauth-ng","owner":{"login":"andreareginato","id":37480,"avatar_url":"https://avatars.githubusercontent.com/u/37480?v=3","gravatar_id":"","url":"https://api.github.com/users/andreareginato","html_url":"https://github.com/andreareginato","followers_url":"https://api.github.com/users/andreareginato/followers","following_url":"https://api.github.com/users/andreareginato/following{/other_user}","gists_url":"https://api.github.com/users/andreareginato/gists{/gist_id}","starred_url":"https://api.github.com/users/andreareginato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreareginato/subscriptions","organizations_url":"https://api.github.com/users/andreareginato/orgs","repos_url":"https://api.github.com/users/andreareginato/repos","events_url":"https://api.github.com/users/andreareginato/events{/privacy}","received_events_url":"https://api.github.com/users/andreareginato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreareginato/oauth-ng","description":"AngularJS directive for the OAuth 2.0 Implicit Flow","fork":false,"url":"https://api.github.com/repos/andreareginato/oauth-ng","forks_url":"https://api.github.com/repos/andreareginato/oauth-ng/forks","keys_url":"https://api.github.com/repos/andreareginato/oauth-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreareginato/oauth-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreareginato/oauth-ng/teams","hooks_url":"https://api.github.com/repos/andreareginato/oauth-ng/hooks","issue_events_url":"https://api.github.com/repos/andreareginato/oauth-ng/issues/events{/number}","events_url":"https://api.github.com/repos/andreareginato/oauth-ng/events","assignees_url":"https://api.github.com/repos/andreareginato/oauth-ng/assignees{/user}","branches_url":"https://api.github.com/repos/andreareginato/oauth-ng/branches{/branch}","tags_url":"https://api.github.com/repos/andreareginato/oauth-ng/tags","blobs_url":"https://api.github.com/repos/andreareginato/oauth-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreareginato/oauth-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreareginato/oauth-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreareginato/oauth-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreareginato/oauth-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/andreareginato/oauth-ng/languages","stargazers_url":"https://api.github.com/repos/andreareginato/oauth-ng/stargazers","contributors_url":"https://api.github.com/repos/andreareginato/oauth-ng/contributors","subscribers_url":"https://api.github.com/repos/andreareginato/oauth-ng/subscribers","subscription_url":"https://api.github.com/repos/andreareginato/oauth-ng/subscription","commits_url":"https://api.github.com/repos/andreareginato/oauth-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreareginato/oauth-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreareginato/oauth-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreareginato/oauth-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreareginato/oauth-ng/contents/{+path}","compare_url":"https://api.github.com/repos/andreareginato/oauth-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreareginato/oauth-ng/merges","archive_url":"https://api.github.com/repos/andreareginato/oauth-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreareginato/oauth-ng/downloads","issues_url":"https://api.github.com/repos/andreareginato/oauth-ng/issues{/number}","pulls_url":"https://api.github.com/repos/andreareginato/oauth-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/andreareginato/oauth-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/andreareginato/oauth-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreareginato/oauth-ng/labels{/name}","releases_url":"https://api.github.com/repos/andreareginato/oauth-ng/releases{/id}","created_at":"2013-10-28T20:56:31Z","updated_at":"2015-06-10T07:57:00Z","pushed_at":"2015-06-11T21:30:37Z","git_url":"git://github.com/andreareginato/oauth-ng.git","ssh_url":"git@github.com:andreareginato/oauth-ng.git","clone_url":"https://github.com/andreareginato/oauth-ng.git","svn_url":"https://github.com/andreareginato/oauth-ng","homepage":"https://andreareginato.github.com/oauth-ng","size":1970,"stargazers_count":242,"watchers_count":242,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":19,"forks":74,"open_issues":19,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79"},"html":{"href":"https://github.com/andreareginato/oauth-ng/pull/79"},"issue":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/issues/79"},"comments":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/andreareginato/oauth-ng/statuses/34bcfa183e0f5627baa6b62d12a7440ef01e9bed"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"m00s","id":4352637,"avatar_url":"https://avatars.githubusercontent.com/u/4352637?v=3","gravatar_id":"","url":"https://api.github.com/users/m00s","html_url":"https://github.com/m00s","followers_url":"https://api.github.com/users/m00s/followers","following_url":"https://api.github.com/users/m00s/following{/other_user}","gists_url":"https://api.github.com/users/m00s/gists{/gist_id}","starred_url":"https://api.github.com/users/m00s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m00s/subscriptions","organizations_url":"https://api.github.com/users/m00s/orgs","repos_url":"https://api.github.com/users/m00s/repos","events_url":"https://api.github.com/users/m00s/events{/privacy}","received_events_url":"https://api.github.com/users/m00s/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":8,"additions":139,"deletions":41,"changed_files":4}}