{"action":"created","issue":{"url":"https://api.github.com/repos/suitcss/utils-size/issues/24","labels_url":"https://api.github.com/repos/suitcss/utils-size/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/suitcss/utils-size/issues/24/comments","events_url":"https://api.github.com/repos/suitcss/utils-size/issues/24/events","html_url":"https://github.com/suitcss/utils-size/issues/24","id":105839448,"number":24,"title":"Default Media Query Breakpoints","user":{"login":"oleersoy","id":1163873,"avatar_url":"https://avatars.githubusercontent.com/u/1163873?v=3","gravatar_id":"","url":"https://api.github.com/users/oleersoy","html_url":"https://github.com/oleersoy","followers_url":"https://api.github.com/users/oleersoy/followers","following_url":"https://api.github.com/users/oleersoy/following{/other_user}","gists_url":"https://api.github.com/users/oleersoy/gists{/gist_id}","starred_url":"https://api.github.com/users/oleersoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleersoy/subscriptions","organizations_url":"https://api.github.com/users/oleersoy/orgs","repos_url":"https://api.github.com/users/oleersoy/repos","events_url":"https://api.github.com/users/oleersoy/events{/privacy}","received_events_url":"https://api.github.com/users/oleersoy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-10T15:55:46Z","updated_at":"2015-10-02T02:12:15Z","closed_at":null,"body":"Right now if we run the build, the media query breakpoint classes are not generated, because the index.css file is missing defaults for these parameters.  It would be great if SUIT provided default best practice parameters...probably in a separate file `suit-media-query-breakpoint-defaults` that is imported in index.css.  If this is done the parameters can be removed from `test/test.css`. "},"comment":{"url":"https://api.github.com/repos/suitcss/utils-size/issues/comments/144899140","html_url":"https://github.com/suitcss/utils-size/issues/24#issuecomment-144899140","issue_url":"https://api.github.com/repos/suitcss/utils-size/issues/24","id":144899140,"user":{"login":"oleersoy","id":1163873,"avatar_url":"https://avatars.githubusercontent.com/u/1163873?v=3","gravatar_id":"","url":"https://api.github.com/users/oleersoy","html_url":"https://github.com/oleersoy","followers_url":"https://api.github.com/users/oleersoy/followers","following_url":"https://api.github.com/users/oleersoy/following{/other_user}","gists_url":"https://api.github.com/users/oleersoy/gists{/gist_id}","starred_url":"https://api.github.com/users/oleersoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleersoy/subscriptions","organizations_url":"https://api.github.com/users/oleersoy/orgs","repos_url":"https://api.github.com/users/oleersoy/repos","events_url":"https://api.github.com/users/oleersoy/events{/privacy}","received_events_url":"https://api.github.com/users/oleersoy/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T02:12:15Z","updated_at":"2015-10-02T02:12:15Z","body":"Also suppose that these breakpoints are considered the defaults:\r\n\r\n```css\r\n@custom-media --sm-viewport (min-width:320px) and (max-width:640px);\r\n@custom-media --md-viewport (min-width:640px) and (max-width:960px);\r\n@custom-media --lg-viewport (min-width:960px);\r\n```\r\nAnd therefore included as such in tests that perform testing of the utilities that are responsive.  If the breakpoint defaults are changed, then we should probably change them across the tests in order to stay consistent, but in order to do this each test / package has to be updated individually."}}