{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/comments/28629268","id":28629268,"diff_hunk":"@@ -303,9 +303,10 @@ void GenIR::readerPrePass(uint8_t *Buffer, uint32_t NumBytes) {\n       ABIMethodSignature(MethodSignature, *this, *JitContext->TheABIInfo);\n   Function = ABIMethodSig.createFunction(*this, *JitContext->CurrentModule);\n \n-  EntryBlock = BasicBlock::Create(*JitContext->LLVMContext, \"entry\", Function);\n+  llvm::LLVMContext *LLVMContext = JitContext->LLVMContext;","path":"lib/Reader/readerir.cpp","position":5,"original_position":5,"commit_id":"2dc5993a7867bcd00c9b59d12292ee32bb4e5ec6","original_commit_id":"2dc5993a7867bcd00c9b59d12292ee32bb4e5ec6","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"Nit: this could be `LLVMContext &LLVMContext = *JitContext->LLVMContext`","created_at":"2015-04-17T20:52:09Z","updated_at":"2015-04-17T20:52:09Z","html_url":"https://github.com/dotnet/llilc/pull/458#discussion_r28629268","pull_request_url":"https://api.github.com/repos/dotnet/llilc/pulls/458","_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments/28629268"},"html":{"href":"https://github.com/dotnet/llilc/pull/458#discussion_r28629268"},"pull_request":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/458","id":33580735,"html_url":"https://github.com/dotnet/llilc/pull/458","diff_url":"https://github.com/dotnet/llilc/pull/458.diff","patch_url":"https://github.com/dotnet/llilc/pull/458.patch","issue_url":"https://api.github.com/repos/dotnet/llilc/issues/458","number":458,"state":"open","locked":false,"title":"Support for synchronized methods.","user":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"body":"Add calls to MONITOR_ENTER on entry to the method and MONITOR_EXIT on returns.\r\n\r\nWe can't catch exceptions yet; when we can we will need to add a try/fault for the entire method\r\nso that we can call MONITOR_EXIT on unhandled exceptions.\r\n\r\nWe have a synchronized method in HelloWorld (System.IO.TextWriter+SyncTextWriter.WriteLine).\r\nI verified that the generated IR looks correct. I also tested with a simple two-thread race that the\r\nbehavior of synchronized instance and static methods is as expected.","created_at":"2015-04-17T20:45:10Z","updated_at":"2015-04-17T20:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651cae1ce7e35e5faaf8a37882e86de34fff0ad0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/llilc/pulls/458/commits","review_comments_url":"https://api.github.com/repos/dotnet/llilc/pulls/458/comments","review_comment_url":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/llilc/issues/458/comments","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/2dc5993a7867bcd00c9b59d12292ee32bb4e5ec6","head":{"label":"erozenfeld:SynchMethods","ref":"SynchMethods","sha":"2dc5993a7867bcd00c9b59d12292ee32bb4e5ec6","user":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"repo":{"id":33960070,"name":"llilc","full_name":"erozenfeld/llilc","owner":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erozenfeld/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":true,"url":"https://api.github.com/repos/erozenfeld/llilc","forks_url":"https://api.github.com/repos/erozenfeld/llilc/forks","keys_url":"https://api.github.com/repos/erozenfeld/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erozenfeld/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erozenfeld/llilc/teams","hooks_url":"https://api.github.com/repos/erozenfeld/llilc/hooks","issue_events_url":"https://api.github.com/repos/erozenfeld/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/erozenfeld/llilc/events","assignees_url":"https://api.github.com/repos/erozenfeld/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/erozenfeld/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/erozenfeld/llilc/tags","blobs_url":"https://api.github.com/repos/erozenfeld/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erozenfeld/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erozenfeld/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/erozenfeld/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erozenfeld/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/erozenfeld/llilc/languages","stargazers_url":"https://api.github.com/repos/erozenfeld/llilc/stargazers","contributors_url":"https://api.github.com/repos/erozenfeld/llilc/contributors","subscribers_url":"https://api.github.com/repos/erozenfeld/llilc/subscribers","subscription_url":"https://api.github.com/repos/erozenfeld/llilc/subscription","commits_url":"https://api.github.com/repos/erozenfeld/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/erozenfeld/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/erozenfeld/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/erozenfeld/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/erozenfeld/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/erozenfeld/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erozenfeld/llilc/merges","archive_url":"https://api.github.com/repos/erozenfeld/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erozenfeld/llilc/downloads","issues_url":"https://api.github.com/repos/erozenfeld/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/erozenfeld/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/erozenfeld/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/erozenfeld/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erozenfeld/llilc/labels{/name}","releases_url":"https://api.github.com/repos/erozenfeld/llilc/releases{/id}","created_at":"2015-04-14T22:21:16Z","updated_at":"2015-04-14T22:21:17Z","pushed_at":"2015-04-17T20:44:28Z","git_url":"git://github.com/erozenfeld/llilc.git","ssh_url":"git@github.com:erozenfeld/llilc.git","clone_url":"https://github.com/erozenfeld/llilc.git","svn_url":"https://github.com/erozenfeld/llilc","homepage":"","size":4108,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"44f164ca2e81c41e78afb28142d8d8b8720d1d03","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30043131,"name":"llilc","full_name":"dotnet/llilc","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":false,"url":"https://api.github.com/repos/dotnet/llilc","forks_url":"https://api.github.com/repos/dotnet/llilc/forks","keys_url":"https://api.github.com/repos/dotnet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/llilc/teams","hooks_url":"https://api.github.com/repos/dotnet/llilc/hooks","issue_events_url":"https://api.github.com/repos/dotnet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/llilc/events","assignees_url":"https://api.github.com/repos/dotnet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/llilc/tags","blobs_url":"https://api.github.com/repos/dotnet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/llilc/languages","stargazers_url":"https://api.github.com/repos/dotnet/llilc/stargazers","contributors_url":"https://api.github.com/repos/dotnet/llilc/contributors","subscribers_url":"https://api.github.com/repos/dotnet/llilc/subscribers","subscription_url":"https://api.github.com/repos/dotnet/llilc/subscription","commits_url":"https://api.github.com/repos/dotnet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/llilc/merges","archive_url":"https://api.github.com/repos/dotnet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/llilc/downloads","issues_url":"https://api.github.com/repos/dotnet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/llilc/releases{/id}","created_at":"2015-01-29T21:52:01Z","updated_at":"2015-04-17T19:57:30Z","pushed_at":"2015-04-17T20:45:10Z","git_url":"git://github.com/dotnet/llilc.git","ssh_url":"git@github.com:dotnet/llilc.git","clone_url":"https://github.com/dotnet/llilc.git","svn_url":"https://github.com/dotnet/llilc","homepage":"","size":9621,"stargazers_count":581,"watchers_count":581,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":112,"forks":40,"open_issues":112,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/458"},"html":{"href":"https://github.com/dotnet/llilc/pull/458"},"issue":{"href":"https://api.github.com/repos/dotnet/llilc/issues/458"},"comments":{"href":"https://api.github.com/repos/dotnet/llilc/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/llilc/statuses/2dc5993a7867bcd00c9b59d12292ee32bb4e5ec6"}}}}