{"action":"created","issue":{"url":"https://api.github.com/repos/apache/phoenix/issues/104","labels_url":"https://api.github.com/repos/apache/phoenix/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/apache/phoenix/issues/104/comments","events_url":"https://api.github.com/repos/apache/phoenix/issues/104/events","html_url":"https://github.com/apache/phoenix/pull/104","id":99235401,"number":104,"title":"PHOENIX-1673 Allow TenantId to be of any integral data type","user":{"login":"JeffreyLyonsD2L","id":11636328,"avatar_url":"https://avatars.githubusercontent.com/u/11636328?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffreyLyonsD2L","html_url":"https://github.com/JeffreyLyonsD2L","followers_url":"https://api.github.com/users/JeffreyLyonsD2L/followers","following_url":"https://api.github.com/users/JeffreyLyonsD2L/following{/other_user}","gists_url":"https://api.github.com/users/JeffreyLyonsD2L/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffreyLyonsD2L/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffreyLyonsD2L/subscriptions","organizations_url":"https://api.github.com/users/JeffreyLyonsD2L/orgs","repos_url":"https://api.github.com/users/JeffreyLyonsD2L/repos","events_url":"https://api.github.com/users/JeffreyLyonsD2L/events{/privacy}","received_events_url":"https://api.github.com/users/JeffreyLyonsD2L/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-05T15:44:27Z","updated_at":"2015-08-07T20:45:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/phoenix/pulls/104","html_url":"https://github.com/apache/phoenix/pull/104","diff_url":"https://github.com/apache/phoenix/pull/104.diff","patch_url":"https://github.com/apache/phoenix/pull/104.patch"},"body":"Hopefully everything here is in order, if there are any questions or requests don't hesitate to ask."},"comment":{"url":"https://api.github.com/repos/apache/phoenix/issues/comments/128830531","html_url":"https://github.com/apache/phoenix/pull/104#issuecomment-128830531","issue_url":"https://api.github.com/repos/apache/phoenix/issues/104","id":128830531,"user":{"login":"elilevine","id":552303,"avatar_url":"https://avatars.githubusercontent.com/u/552303?v=3","gravatar_id":"","url":"https://api.github.com/users/elilevine","html_url":"https://github.com/elilevine","followers_url":"https://api.github.com/users/elilevine/followers","following_url":"https://api.github.com/users/elilevine/following{/other_user}","gists_url":"https://api.github.com/users/elilevine/gists{/gist_id}","starred_url":"https://api.github.com/users/elilevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elilevine/subscriptions","organizations_url":"https://api.github.com/users/elilevine/orgs","repos_url":"https://api.github.com/users/elilevine/repos","events_url":"https://api.github.com/users/elilevine/events{/privacy}","received_events_url":"https://api.github.com/users/elilevine/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T20:45:05Z","updated_at":"2015-08-07T20:45:05Z","body":"Good stuff, @JeffreyLyonsD2L. Added a few questions and comments to the PR.  \r\n\r\nThere is one more issue that it not tackled here that we need to at least discuss IMHO. Phoenix's metadata tables, such as SYSTEM.CATALOG lead with TENANT_ID VARCHAR column (take a look in QueryConstants.java). This works well in a world where all multi-tenant tables can only have VARCHAR tenant id columns. Your changes introduce the possibility that different multi-tenant tables will have different types of tenant id columns.\r\n\r\nWhat's the right solution here? The right solution is probably changing TENANT_ID column type to BINARY in system tables. But that will make upgrades for existing clusters a pain. Leave them as VARCHAR?\r\n"}}