{"action":"created","issue":{"url":"https://api.github.com/repos/DBuildService/dock/issues/126","labels_url":"https://api.github.com/repos/DBuildService/dock/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/DBuildService/dock/issues/126/comments","events_url":"https://api.github.com/repos/DBuildService/dock/issues/126/events","html_url":"https://github.com/DBuildService/dock/issues/126","id":82469774,"number":126,"title":"Make pulling from registry configurable for inside-build","user":{"login":"goldmann","id":43489,"avatar_url":"https://avatars.githubusercontent.com/u/43489?v=3","gravatar_id":"","url":"https://api.github.com/users/goldmann","html_url":"https://github.com/goldmann","followers_url":"https://api.github.com/users/goldmann/followers","following_url":"https://api.github.com/users/goldmann/following{/other_user}","gists_url":"https://api.github.com/users/goldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/goldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldmann/subscriptions","organizations_url":"https://api.github.com/users/goldmann/orgs","repos_url":"https://api.github.com/users/goldmann/repos","events_url":"https://api.github.com/users/goldmann/events{/privacy}","received_events_url":"https://api.github.com/users/goldmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DBuildService/dock/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/DBuildService/dock/labels/priority%202","name":"priority 2","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"jpopelka","id":288686,"avatar_url":"https://avatars.githubusercontent.com/u/288686?v=3","gravatar_id":"","url":"https://api.github.com/users/jpopelka","html_url":"https://github.com/jpopelka","followers_url":"https://api.github.com/users/jpopelka/followers","following_url":"https://api.github.com/users/jpopelka/following{/other_user}","gists_url":"https://api.github.com/users/jpopelka/gists{/gist_id}","starred_url":"https://api.github.com/users/jpopelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpopelka/subscriptions","organizations_url":"https://api.github.com/users/jpopelka/orgs","repos_url":"https://api.github.com/users/jpopelka/repos","events_url":"https://api.github.com/users/jpopelka/events{/privacy}","received_events_url":"https://api.github.com/users/jpopelka/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-05-29T15:21:27Z","updated_at":"2015-06-01T12:38:59Z","closed_at":null,"body":"Currently there is no option to disable pulling from registry the base image. In our case this will re-tag the images with older versions which is not what we want."},"comment":{"url":"https://api.github.com/repos/DBuildService/dock/issues/comments/107426307","html_url":"https://github.com/DBuildService/dock/issues/126#issuecomment-107426307","issue_url":"https://api.github.com/repos/DBuildService/dock/issues/126","id":107426307,"user":{"login":"TomasTomecek","id":1662493,"avatar_url":"https://avatars.githubusercontent.com/u/1662493?v=3","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T12:38:59Z","updated_at":"2015-06-01T12:38:59Z","body":"> But I think most common use-case is to pull a base image before build so if we make it a plugin, most build jsons will need to include it.\r\n\r\nYou can build image without pulling base image explicitly because docker has option for that in API:\r\n\r\nhttps://github.com/docker/docker-py/blob/396af7adbe480787ac9cb2ba866d6d2125b8dd30/docker/client.py#L307\r\n\r\nThe reason we are not using that is that you cannot specify source registry. docker wants to pull everything from docker hub. That's pretty bad because I assume that most of our users use custom registries, hence the custom pull function.\r\n\r\n> I mean, we can't make a plugin to not pull image, right ?\r\n\r\nWell, we should provide a way to configure `pull` argument of docker-py's `build` method\r\n\r\n> If we agree that more common is to pull base image, then I'd vote for making this a DockerBuildWorkflow option (called let's say dont_pull_base_image) so one would need to specify it in build json only if the pulling is unwanted.\r\n\r\nIn the end, I don't care much if it's going to be plugin or not. If you feel like that keeping architecture as it is now is better, let's do it that way.\r\n"}}