{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76","id":43111091,"html_url":"https://github.com/yapplabs/ember-modal-dialog/pull/76","diff_url":"https://github.com/yapplabs/ember-modal-dialog/pull/76.diff","patch_url":"https://github.com/yapplabs/ember-modal-dialog/pull/76.patch","issue_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/76","number":76,"state":"closed","locked":false,"title":"Modal Structures","user":{"login":"chrislopresto","id":93691,"avatar_url":"https://avatars.githubusercontent.com/u/93691?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislopresto","html_url":"https://github.com/chrislopresto","followers_url":"https://api.github.com/users/chrislopresto/followers","following_url":"https://api.github.com/users/chrislopresto/following{/other_user}","gists_url":"https://api.github.com/users/chrislopresto/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislopresto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislopresto/subscriptions","organizations_url":"https://api.github.com/users/chrislopresto/orgs","repos_url":"https://api.github.com/users/chrislopresto/repos","events_url":"https://api.github.com/users/chrislopresto/events{/privacy}","received_events_url":"https://api.github.com/users/chrislopresto/received_events","type":"User","site_admin":false},"body":"- Compute modal dialog layout from new structure property\r\n- Provide separate templates for supported modal structures: simple, tethered, nested, in-place\r\n- Wire up defaultStructure environment application option, defaulting to simple\r\n- Add nested structure to support various scrolling/overlay use cases @sandstrom\r\n- Add example where scrolling the overlay scrolls the modal content @samselikoff @sandstrom \r\n- Unify target and attachment terminology with that of Hubspot Tether\r\n- Remove renderInPlace in favor of simple structure\r\n- Remove a bunch of normalization logic that had been providing backwards compatibility for usage patterns prior to the introduction of ember-tether","created_at":"2015-08-22T22:02:46Z","updated_at":"2015-09-06T22:17:54Z","closed_at":"2015-09-06T22:17:54Z","merged_at":null,"merge_commit_sha":"26a953004d3e2ab4e8d4834c77501aa2b66f4629","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76/commits","review_comments_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76/comments","review_comment_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/76/comments","statuses_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/statuses/a9c2ad0a961bd22c0b85366f45a99c97c3347a77","head":{"label":"yapplabs:structures","ref":"structures","sha":"a9c2ad0a961bd22c0b85366f45a99c97c3347a77","user":{"login":"yapplabs","id":4030687,"avatar_url":"https://avatars.githubusercontent.com/u/4030687?v=3","gravatar_id":"","url":"https://api.github.com/users/yapplabs","html_url":"https://github.com/yapplabs","followers_url":"https://api.github.com/users/yapplabs/followers","following_url":"https://api.github.com/users/yapplabs/following{/other_user}","gists_url":"https://api.github.com/users/yapplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/yapplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yapplabs/subscriptions","organizations_url":"https://api.github.com/users/yapplabs/orgs","repos_url":"https://api.github.com/users/yapplabs/repos","events_url":"https://api.github.com/users/yapplabs/events{/privacy}","received_events_url":"https://api.github.com/users/yapplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24808739,"name":"ember-modal-dialog","full_name":"yapplabs/ember-modal-dialog","owner":{"login":"yapplabs","id":4030687,"avatar_url":"https://avatars.githubusercontent.com/u/4030687?v=3","gravatar_id":"","url":"https://api.github.com/users/yapplabs","html_url":"https://github.com/yapplabs","followers_url":"https://api.github.com/users/yapplabs/followers","following_url":"https://api.github.com/users/yapplabs/following{/other_user}","gists_url":"https://api.github.com/users/yapplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/yapplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yapplabs/subscriptions","organizations_url":"https://api.github.com/users/yapplabs/orgs","repos_url":"https://api.github.com/users/yapplabs/repos","events_url":"https://api.github.com/users/yapplabs/events{/privacy}","received_events_url":"https://api.github.com/users/yapplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yapplabs/ember-modal-dialog","description":"An ember-cli addon for implementing modal dialogs","fork":false,"url":"https://api.github.com/repos/yapplabs/ember-modal-dialog","forks_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/forks","keys_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/teams","hooks_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/hooks","issue_events_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/events{/number}","events_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/events","assignees_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/assignees{/user}","branches_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/branches{/branch}","tags_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/tags","blobs_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/statuses/{sha}","languages_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/languages","stargazers_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/stargazers","contributors_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/contributors","subscribers_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/subscribers","subscription_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/subscription","commits_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/comments{/number}","contents_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/contents/{+path}","compare_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/merges","archive_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/downloads","issues_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues{/number}","pulls_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls{/number}","milestones_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/milestones{/number}","notifications_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/labels{/name}","releases_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/releases{/id}","created_at":"2014-10-05T04:48:04Z","updated_at":"2015-09-03T12:27:04Z","pushed_at":"2015-09-06T22:17:33Z","git_url":"git://github.com/yapplabs/ember-modal-dialog.git","ssh_url":"git@github.com:yapplabs/ember-modal-dialog.git","clone_url":"https://github.com/yapplabs/ember-modal-dialog.git","svn_url":"https://github.com/yapplabs/ember-modal-dialog","homepage":"","size":1129,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":115,"default_branch":"master"}},"base":{"label":"yapplabs:master","ref":"master","sha":"31a1d4e2ccfda59580b5d62c55de8f1b23390513","user":{"login":"yapplabs","id":4030687,"avatar_url":"https://avatars.githubusercontent.com/u/4030687?v=3","gravatar_id":"","url":"https://api.github.com/users/yapplabs","html_url":"https://github.com/yapplabs","followers_url":"https://api.github.com/users/yapplabs/followers","following_url":"https://api.github.com/users/yapplabs/following{/other_user}","gists_url":"https://api.github.com/users/yapplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/yapplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yapplabs/subscriptions","organizations_url":"https://api.github.com/users/yapplabs/orgs","repos_url":"https://api.github.com/users/yapplabs/repos","events_url":"https://api.github.com/users/yapplabs/events{/privacy}","received_events_url":"https://api.github.com/users/yapplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24808739,"name":"ember-modal-dialog","full_name":"yapplabs/ember-modal-dialog","owner":{"login":"yapplabs","id":4030687,"avatar_url":"https://avatars.githubusercontent.com/u/4030687?v=3","gravatar_id":"","url":"https://api.github.com/users/yapplabs","html_url":"https://github.com/yapplabs","followers_url":"https://api.github.com/users/yapplabs/followers","following_url":"https://api.github.com/users/yapplabs/following{/other_user}","gists_url":"https://api.github.com/users/yapplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/yapplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yapplabs/subscriptions","organizations_url":"https://api.github.com/users/yapplabs/orgs","repos_url":"https://api.github.com/users/yapplabs/repos","events_url":"https://api.github.com/users/yapplabs/events{/privacy}","received_events_url":"https://api.github.com/users/yapplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yapplabs/ember-modal-dialog","description":"An ember-cli addon for implementing modal dialogs","fork":false,"url":"https://api.github.com/repos/yapplabs/ember-modal-dialog","forks_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/forks","keys_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/teams","hooks_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/hooks","issue_events_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/events{/number}","events_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/events","assignees_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/assignees{/user}","branches_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/branches{/branch}","tags_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/tags","blobs_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/statuses/{sha}","languages_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/languages","stargazers_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/stargazers","contributors_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/contributors","subscribers_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/subscribers","subscription_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/subscription","commits_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/comments{/number}","contents_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/contents/{+path}","compare_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/merges","archive_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/downloads","issues_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues{/number}","pulls_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls{/number}","milestones_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/milestones{/number}","notifications_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/labels{/name}","releases_url":"https://api.github.com/repos/yapplabs/ember-modal-dialog/releases{/id}","created_at":"2014-10-05T04:48:04Z","updated_at":"2015-09-03T12:27:04Z","pushed_at":"2015-09-06T22:17:33Z","git_url":"git://github.com/yapplabs/ember-modal-dialog.git","ssh_url":"git@github.com:yapplabs/ember-modal-dialog.git","clone_url":"https://github.com/yapplabs/ember-modal-dialog.git","svn_url":"https://github.com/yapplabs/ember-modal-dialog","homepage":"","size":1129,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76"},"html":{"href":"https://github.com/yapplabs/ember-modal-dialog/pull/76"},"issue":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/76"},"comments":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/yapplabs/ember-modal-dialog/statuses/a9c2ad0a961bd22c0b85366f45a99c97c3347a77"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":10,"commits":1,"additions":504,"deletions":415,"changed_files":32}}