{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/xlisp/issues/48","labels_url":"https://api.github.com/repos/exercism/xlisp/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/exercism/xlisp/issues/48/comments","events_url":"https://api.github.com/repos/exercism/xlisp/issues/48/events","html_url":"https://github.com/exercism/xlisp/issues/48","id":71785148,"number":48,"title":"Robot name is considered reset when just set to `nil`","user":{"login":"wobh","id":2178906,"avatar_url":"https://avatars.githubusercontent.com/u/2178906?v=3","gravatar_id":"","url":"https://api.github.com/users/wobh","html_url":"https://github.com/wobh","followers_url":"https://api.github.com/users/wobh/followers","following_url":"https://api.github.com/users/wobh/following{/other_user}","gists_url":"https://api.github.com/users/wobh/gists{/gist_id}","starred_url":"https://api.github.com/users/wobh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wobh/subscriptions","organizations_url":"https://api.github.com/users/wobh/orgs","repos_url":"https://api.github.com/users/wobh/repos","events_url":"https://api.github.com/users/wobh/events{/privacy}","received_events_url":"https://api.github.com/users/wobh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/exercism/xlisp/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"wobh","id":2178906,"avatar_url":"https://avatars.githubusercontent.com/u/2178906?v=3","gravatar_id":"","url":"https://api.github.com/users/wobh","html_url":"https://github.com/wobh","followers_url":"https://api.github.com/users/wobh/followers","following_url":"https://api.github.com/users/wobh/following{/other_user}","gists_url":"https://api.github.com/users/wobh/gists{/gist_id}","starred_url":"https://api.github.com/users/wobh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wobh/subscriptions","organizations_url":"https://api.github.com/users/wobh/orgs","repos_url":"https://api.github.com/users/wobh/repos","events_url":"https://api.github.com/users/wobh/events{/privacy}","received_events_url":"https://api.github.com/users/wobh/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-04-29T05:43:17Z","updated_at":"2015-05-07T03:17:00Z","closed_at":null,"body":"I've been thinking about this implementation of the Robot Name exercise: http://exercism.io/submissions/dc01bbe303724a958e509d819ab49853 and it's occurred to me that it reveals a bug in the tests for this exercise.\r\n\r\nWhen `reset-name` is called on a robot, here, it causes that robot's `robot-name` to return `nil`, which, of course, is not `equal` to the `original-name` in the test, and thus the assertion passes. It's okay that a robot not have a name (in fact, the README requires it as the initial state of new robots; we don't test that expectation so everyone implements new robots with names, which is likely another bug in the exercise), but `reset-name` should at least provide the robot with a new name.\r\n\r\nTo fix: break out the code for `name-matches-expected-pattern` into `robot-name-valid-p` to be used in that test and in a new assertion on the robot's reset name in `name-can-be-reset`."},"comment":{"url":"https://api.github.com/repos/exercism/xlisp/issues/comments/99697163","html_url":"https://github.com/exercism/xlisp/issues/48#issuecomment-99697163","issue_url":"https://api.github.com/repos/exercism/xlisp/issues/48","id":99697163,"user":{"login":"kytrinyx","id":276834,"avatar_url":"https://avatars.githubusercontent.com/u/276834?v=3","gravatar_id":"","url":"https://api.github.com/users/kytrinyx","html_url":"https://github.com/kytrinyx","followers_url":"https://api.github.com/users/kytrinyx/followers","following_url":"https://api.github.com/users/kytrinyx/following{/other_user}","gists_url":"https://api.github.com/users/kytrinyx/gists{/gist_id}","starred_url":"https://api.github.com/users/kytrinyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kytrinyx/subscriptions","organizations_url":"https://api.github.com/users/kytrinyx/orgs","repos_url":"https://api.github.com/users/kytrinyx/repos","events_url":"https://api.github.com/users/kytrinyx/events{/privacy}","received_events_url":"https://api.github.com/users/kytrinyx/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T03:17:00Z","updated_at":"2015-05-07T03:17:00Z","body":"I would be happy to fix the README on this one. I originally made it after helping a student explore the idea of memoization in Ruby."}}