{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/comments/30469512","id":30469512,"diff_hunk":"@@ -106,18 +107,76 @@ package com.kaltura.hls.manifest\n \t\t * Decrypts a video or audio stream using AES-128 with the provided initialization vector.\n \t\t */\n \t\t\n-\t\tpublic function decrypt( data:ByteArray, iv:ByteArray ):void\n+\t\tpublic function decrypt( data:ByteArray, iv:ByteArray ):ByteArray","path":"HLSPlugin/src/com/kaltura/hls/manifest/HLSManifestEncryptionKey.as","position":40,"original_position":40,"commit_id":"e6e25afb35c00877bf8546498ca9b3e2f7e55ec3","original_commit_id":"e6e25afb35c00877bf8546498ca9b3e2f7e55ec3","user":{"login":"bengarney","id":132844,"avatar_url":"https://avatars.githubusercontent.com/u/132844?v=3","gravatar_id":"","url":"https://api.github.com/users/bengarney","html_url":"https://github.com/bengarney","followers_url":"https://api.github.com/users/bengarney/followers","following_url":"https://api.github.com/users/bengarney/following{/other_user}","gists_url":"https://api.github.com/users/bengarney/gists{/gist_id}","starred_url":"https://api.github.com/users/bengarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengarney/subscriptions","organizations_url":"https://api.github.com/users/bengarney/orgs","repos_url":"https://api.github.com/users/bengarney/repos","events_url":"https://api.github.com/users/bengarney/events{/privacy}","received_events_url":"https://api.github.com/users/bengarney/received_events","type":"User","site_admin":false},"body":"The iv argument is confusing relative to the member variable of the same name.","created_at":"2015-05-17T11:08:26Z","updated_at":"2015-05-17T11:08:26Z","html_url":"https://github.com/kaltura/HLS-OSMF/pull/107#discussion_r30469512","pull_request_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/comments/30469512"},"html":{"href":"https://github.com/kaltura/HLS-OSMF/pull/107#discussion_r30469512"},"pull_request":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107","id":35577354,"html_url":"https://github.com/kaltura/HLS-OSMF/pull/107","diff_url":"https://github.com/kaltura/HLS-OSMF/pull/107.diff","patch_url":"https://github.com/kaltura/HLS-OSMF/pull/107.patch","issue_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/107","number":107,"state":"open","locked":false,"title":"Fast aes key","user":{"login":"itaykinnrot","id":555225,"avatar_url":"https://avatars.githubusercontent.com/u/555225?v=3","gravatar_id":"","url":"https://api.github.com/users/itaykinnrot","html_url":"https://github.com/itaykinnrot","followers_url":"https://api.github.com/users/itaykinnrot/followers","following_url":"https://api.github.com/users/itaykinnrot/following{/other_user}","gists_url":"https://api.github.com/users/itaykinnrot/gists{/gist_id}","starred_url":"https://api.github.com/users/itaykinnrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaykinnrot/subscriptions","organizations_url":"https://api.github.com/users/itaykinnrot/orgs","repos_url":"https://api.github.com/users/itaykinnrot/repos","events_url":"https://api.github.com/users/itaykinnrot/events{/privacy}","received_events_url":"https://api.github.com/users/itaykinnrot/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-16T21:15:01Z","updated_at":"2015-05-17T11:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70befc2f317358282e7c046a8a16a9eb6bb0a9f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107/commits","review_comments_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107/comments","review_comment_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/107/comments","statuses_url":"https://api.github.com/repos/kaltura/HLS-OSMF/statuses/e6e25afb35c00877bf8546498ca9b3e2f7e55ec3","head":{"label":"kaltura:FastAESKey","ref":"FastAESKey","sha":"e6e25afb35c00877bf8546498ca9b3e2f7e55ec3","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":17934994,"name":"HLS-OSMF","full_name":"kaltura/HLS-OSMF","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/HLS-OSMF","description":"HLS OSMF plugin - help to view m3u8 streams in the KDP/V2 player","fork":false,"url":"https://api.github.com/repos/kaltura/HLS-OSMF","forks_url":"https://api.github.com/repos/kaltura/HLS-OSMF/forks","keys_url":"https://api.github.com/repos/kaltura/HLS-OSMF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/HLS-OSMF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/HLS-OSMF/teams","hooks_url":"https://api.github.com/repos/kaltura/HLS-OSMF/hooks","issue_events_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/HLS-OSMF/events","assignees_url":"https://api.github.com/repos/kaltura/HLS-OSMF/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/HLS-OSMF/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/HLS-OSMF/tags","blobs_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/HLS-OSMF/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/HLS-OSMF/languages","stargazers_url":"https://api.github.com/repos/kaltura/HLS-OSMF/stargazers","contributors_url":"https://api.github.com/repos/kaltura/HLS-OSMF/contributors","subscribers_url":"https://api.github.com/repos/kaltura/HLS-OSMF/subscribers","subscription_url":"https://api.github.com/repos/kaltura/HLS-OSMF/subscription","commits_url":"https://api.github.com/repos/kaltura/HLS-OSMF/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/HLS-OSMF/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/HLS-OSMF/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/HLS-OSMF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/HLS-OSMF/merges","archive_url":"https://api.github.com/repos/kaltura/HLS-OSMF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/HLS-OSMF/downloads","issues_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/HLS-OSMF/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/HLS-OSMF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/HLS-OSMF/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/HLS-OSMF/releases{/id}","created_at":"2014-03-20T08:08:12Z","updated_at":"2015-05-07T11:05:38Z","pushed_at":"2015-05-16T21:15:01Z","git_url":"git://github.com/kaltura/HLS-OSMF.git","ssh_url":"git@github.com:kaltura/HLS-OSMF.git","clone_url":"https://github.com/kaltura/HLS-OSMF.git","svn_url":"https://github.com/kaltura/HLS-OSMF","homepage":null,"size":6500,"stargazers_count":2,"watchers_count":2,"language":"ActionScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"e0aa791f9e1a8c42afdc0864b6ff21ccefcd3d1f","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":17934994,"name":"HLS-OSMF","full_name":"kaltura/HLS-OSMF","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/HLS-OSMF","description":"HLS OSMF plugin - help to view m3u8 streams in the KDP/V2 player","fork":false,"url":"https://api.github.com/repos/kaltura/HLS-OSMF","forks_url":"https://api.github.com/repos/kaltura/HLS-OSMF/forks","keys_url":"https://api.github.com/repos/kaltura/HLS-OSMF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/HLS-OSMF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/HLS-OSMF/teams","hooks_url":"https://api.github.com/repos/kaltura/HLS-OSMF/hooks","issue_events_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/HLS-OSMF/events","assignees_url":"https://api.github.com/repos/kaltura/HLS-OSMF/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/HLS-OSMF/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/HLS-OSMF/tags","blobs_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/HLS-OSMF/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/HLS-OSMF/languages","stargazers_url":"https://api.github.com/repos/kaltura/HLS-OSMF/stargazers","contributors_url":"https://api.github.com/repos/kaltura/HLS-OSMF/contributors","subscribers_url":"https://api.github.com/repos/kaltura/HLS-OSMF/subscribers","subscription_url":"https://api.github.com/repos/kaltura/HLS-OSMF/subscription","commits_url":"https://api.github.com/repos/kaltura/HLS-OSMF/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/HLS-OSMF/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/HLS-OSMF/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/HLS-OSMF/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/HLS-OSMF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/HLS-OSMF/merges","archive_url":"https://api.github.com/repos/kaltura/HLS-OSMF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/HLS-OSMF/downloads","issues_url":"https://api.github.com/repos/kaltura/HLS-OSMF/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/HLS-OSMF/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/HLS-OSMF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/HLS-OSMF/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/HLS-OSMF/releases{/id}","created_at":"2014-03-20T08:08:12Z","updated_at":"2015-05-07T11:05:38Z","pushed_at":"2015-05-16T21:15:01Z","git_url":"git://github.com/kaltura/HLS-OSMF.git","ssh_url":"git@github.com:kaltura/HLS-OSMF.git","clone_url":"https://github.com/kaltura/HLS-OSMF.git","svn_url":"https://github.com/kaltura/HLS-OSMF","homepage":null,"size":6500,"stargazers_count":2,"watchers_count":2,"language":"ActionScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107"},"html":{"href":"https://github.com/kaltura/HLS-OSMF/pull/107"},"issue":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/107"},"comments":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/HLS-OSMF/statuses/e6e25afb35c00877bf8546498ca9b3e2f7e55ec3"}}}}