{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/40209750","id":40209750,"diff_hunk":"@@ -2443,6 +2443,22 @@ void calculateDatasetMeta(CHqlMetaInfo & meta, IHqlExpression * expr)\n             }\n             break;\n         }\n+    case no_quantile:\n+        //It is not be safe to assume that all implementations of the quantile activity will generate their results in order.\n+        if (expr->hasAttribute(localAtom) || isGrouped(dataset))\n+        {\n+            IHqlExpression * transform = expr->queryChild(3);\n+            OwnedHqlExpr leftSelect = createSelector(no_left, dataset, expr->queryAttribute(_selectorSequence_Atom));\n+            TableProjectMapper mapper;\n+            mapper.setMapping(transform, leftSelect);\n+\n+            extractMeta(meta, dataset);\n+            meta.removeAllSortOrders();\n+            meta.applyProject(mapper);  // distribution preserved if local..\n+        }\n+        else\n+            meta.preserveGrouping(dataset);","path":"ecl/hql/hqlmeta.cpp","position":98,"original_position":98,"commit_id":"cffa280445d87874354a8e7f7ba21d90b0f5c8bd","original_commit_id":"cffa280445d87874354a8e7f7ba21d90b0f5c8bd","user":{"login":"jamienoss","id":5013975,"avatar_url":"https://avatars.githubusercontent.com/u/5013975?v=3","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"body":"Something seemed odd (semanticly) given the previous isGrouped(dataset), looking, I see that preserveGrouping also checks this.\r\n\r\nIn addition CHqlMetaInfo::clearGrouping() also clears groupSortOrder, should preserveGrouping do so also and thus just call clearGrouping()?","created_at":"2015-09-23T14:29:46Z","updated_at":"2015-09-23T14:29:46Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820#discussion_r40209750","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/40209750"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820#discussion_r40209750"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820","id":45757786,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7820","number":7820,"state":"open","locked":false,"title":"HPCC-12267 Initial implementation of QUANTILE activity in roxie","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-23T09:16:16Z","updated_at":"2015-09-23T14:29:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd849b96ffee5ebfccb55f4bc0aa255d3e0a83b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7820/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/cffa280445d87874354a8e7f7ba21d90b0f5c8bd","head":{"label":"ghalliday:issue12267","ref":"issue12267","sha":"cffa280445d87874354a8e7f7ba21d90b0f5c8bd","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"repo":{"id":2034867,"name":"HPCC-Platform","full_name":"ghalliday/HPCC-Platform","owner":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghalliday/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/ghalliday/HPCC-Platform","forks_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/releases{/id}","created_at":"2011-07-12T08:05:04Z","updated_at":"2015-05-08T12:57:14Z","pushed_at":"2015-09-23T11:47:18Z","git_url":"git://github.com/ghalliday/HPCC-Platform.git","ssh_url":"git@github.com:ghalliday/HPCC-Platform.git","clone_url":"https://github.com/ghalliday/HPCC-Platform.git","svn_url":"https://github.com/ghalliday/HPCC-Platform","homepage":"www.hpccsystems.com","size":162383,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"3194d7a7505313b30cdb0532692cb2a94fb4564b","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-08-18T14:32:08Z","pushed_at":"2015-09-23T14:28:45Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":345626,"stargazers_count":253,"watchers_count":253,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":421,"forks":120,"open_issues":421,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7820"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7820"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7820/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7820/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/cffa280445d87874354a8e7f7ba21d90b0f5c8bd"}}}}