{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef/pulls/comments/29066034","id":29066034,"diff_hunk":"@@ -23,7 +23,7 @@ class Knife\n     class SubcommandLoader\n \n       MATCHES_CHEF_GEM = %r{/chef-[\\d]+\\.[\\d]+\\.[\\d]+}.freeze\n-      MATCHES_THIS_CHEF_GEM = %r{/chef-#{Chef::VERSION}/}.freeze\n+      MATCHES_THIS_CHEF_GEM = %r{/chef-#{Chef::VERSION}(-x86-mingw32)?/}.freeze","path":"lib/chef/knife/core/subcommand_loader.rb","position":5,"original_position":5,"commit_id":"03c168fac036bc329c5d052152d4b245710e5ff4","original_commit_id":"03c168fac036bc329c5d052152d4b245710e5ff4","user":{"login":"tknerr","id":365744,"avatar_url":"https://avatars.githubusercontent.com/u/365744?v=3","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"body":"Sure. I looked into https://rubygems.org/gems/chef/versions and found only \"-x86-mingw32\" gems, but that might change in the future.\r\n\r\nI think it would be safe to relax the pattern a bit so we will catch 64bit builds as well once we have them.","created_at":"2015-04-24T17:04:49Z","updated_at":"2015-04-24T17:04:49Z","html_url":"https://github.com/chef/chef/pull/3277#discussion_r29066034","pull_request_url":"https://api.github.com/repos/chef/chef/pulls/3277","_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/comments/29066034"},"html":{"href":"https://github.com/chef/chef/pull/3277#discussion_r29066034"},"pull_request":{"href":"https://api.github.com/repos/chef/chef/pulls/3277"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/3277","id":34056045,"html_url":"https://github.com/chef/chef/pull/3277","diff_url":"https://github.com/chef/chef/pull/3277.diff","patch_url":"https://github.com/chef/chef/pull/3277.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/3277","number":3277,"state":"open","locked":false,"title":"Fix knife subcommands on windows","user":{"login":"tknerr","id":365744,"avatar_url":"https://avatars.githubusercontent.com/u/365744?v=3","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/chef/chef/issues/3272\r\n\r\nThe underlying issue was that \"-x86-mingw32\"-platform suffixed chef gem (as it is installed on windows) was filtered out by the regex, thus it was detected as being \"not from this chef version \".\r\n\r\nThe PR adapts the regex and adds some valid / invalid specs for it","created_at":"2015-04-24T14:58:16Z","updated_at":"2015-04-24T17:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"483ac908e53a417e8c6450e669032ca86ab03277","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/3277/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/3277/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/3277/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/03c168fac036bc329c5d052152d4b245710e5ff4","head":{"label":"tknerr:fix-knife-on-windows","ref":"fix-knife-on-windows","sha":"03c168fac036bc329c5d052152d4b245710e5ff4","user":{"login":"tknerr","id":365744,"avatar_url":"https://avatars.githubusercontent.com/u/365744?v=3","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"repo":{"id":34503680,"name":"chef","full_name":"tknerr/chef","owner":{"login":"tknerr","id":365744,"avatar_url":"https://avatars.githubusercontent.com/u/365744?v=3","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tknerr/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":true,"url":"https://api.github.com/repos/tknerr/chef","forks_url":"https://api.github.com/repos/tknerr/chef/forks","keys_url":"https://api.github.com/repos/tknerr/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tknerr/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tknerr/chef/teams","hooks_url":"https://api.github.com/repos/tknerr/chef/hooks","issue_events_url":"https://api.github.com/repos/tknerr/chef/issues/events{/number}","events_url":"https://api.github.com/repos/tknerr/chef/events","assignees_url":"https://api.github.com/repos/tknerr/chef/assignees{/user}","branches_url":"https://api.github.com/repos/tknerr/chef/branches{/branch}","tags_url":"https://api.github.com/repos/tknerr/chef/tags","blobs_url":"https://api.github.com/repos/tknerr/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tknerr/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tknerr/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/tknerr/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tknerr/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/tknerr/chef/languages","stargazers_url":"https://api.github.com/repos/tknerr/chef/stargazers","contributors_url":"https://api.github.com/repos/tknerr/chef/contributors","subscribers_url":"https://api.github.com/repos/tknerr/chef/subscribers","subscription_url":"https://api.github.com/repos/tknerr/chef/subscription","commits_url":"https://api.github.com/repos/tknerr/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/tknerr/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/tknerr/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/tknerr/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/tknerr/chef/contents/{+path}","compare_url":"https://api.github.com/repos/tknerr/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tknerr/chef/merges","archive_url":"https://api.github.com/repos/tknerr/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tknerr/chef/downloads","issues_url":"https://api.github.com/repos/tknerr/chef/issues{/number}","pulls_url":"https://api.github.com/repos/tknerr/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/tknerr/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/tknerr/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tknerr/chef/labels{/name}","releases_url":"https://api.github.com/repos/tknerr/chef/releases{/id}","created_at":"2015-04-24T07:12:24Z","updated_at":"2015-04-24T07:12:31Z","pushed_at":"2015-04-24T14:50:07Z","git_url":"git://github.com/tknerr/chef.git","ssh_url":"git@github.com:tknerr/chef.git","clone_url":"https://github.com/tknerr/chef.git","svn_url":"https://github.com/tknerr/chef","homepage":"http://www.chef.io/chef/","size":166069,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:12.3-stable","ref":"12.3-stable","sha":"f6d43dba7924fa053e46db67deaf43d12a45c8a9","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"chef/chef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","created_at":"2009-01-15T20:40:48Z","updated_at":"2015-04-24T15:53:01Z","pushed_at":"2015-04-24T16:52:16Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":166069,"stargazers_count":3543,"watchers_count":3543,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1437,"mirror_url":null,"open_issues_count":438,"forks":1437,"open_issues":438,"watchers":3543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/3277"},"html":{"href":"https://github.com/chef/chef/pull/3277"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/3277"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/3277/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/3277/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/3277/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/03c168fac036bc329c5d052152d4b245710e5ff4"}}}}