{"action":"created","comment":{"url":"https://api.github.com/repos/JoTerrance/fp/pulls/comments/29996207","id":29996207,"diff_hunk":"@@ -47,13 +175,90 @@ static String speakToMe(int n) {\n \t * dd-MM-yyyy\n \t */\n \tstatic boolean isLeapYear(String fecha) {\n-\t\treturn false;\n+\t\tboolean resp = false;\n+\t\tString año1;\n+\t\tint año2;\n+\t\t\n+\t\tif (fecha.length() == 10) {\n+\t\t\t\n+\t\t\taño1 = fecha.substring(6, 10);\n+\t\t\taño2 = Integer.parseInt(año1);\n+\t\t\t\n+\t\t\tfor ( int i = 0; i < 5000; i = i + 4) {\n+\t\t\t\t\n+\t\t\t\tif ( año2 == i) {\n+\t\t\t\t\t\n+\t\t\t\t\tresp = true;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\t\t\n+\t\treturn resp;\n \t}\n \n \t/*\n-\t * este metodo calgula la tangente de un angulo\n+\t * Fecha valida\n \t */\n \tstatic boolean isValidDate(String date) {\n-\t\treturn false;\n+\t\tboolean resp = false;","path":"src/main/java/fp/Calculator.java","position":210,"original_position":210,"commit_id":"61671e4c346e8833fffc4e5f24bb12bd32af4ade","original_commit_id":"61671e4c346e8833fffc4e5f24bb12bd32af4ade","user":{"login":"JoTerrance","id":6041670,"avatar_url":"https://avatars.githubusercontent.com/u/6041670?v=3","gravatar_id":"","url":"https://api.github.com/users/JoTerrance","html_url":"https://github.com/JoTerrance","followers_url":"https://api.github.com/users/JoTerrance/followers","following_url":"https://api.github.com/users/JoTerrance/following{/other_user}","gists_url":"https://api.github.com/users/JoTerrance/gists{/gist_id}","starred_url":"https://api.github.com/users/JoTerrance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoTerrance/subscriptions","organizations_url":"https://api.github.com/users/JoTerrance/orgs","repos_url":"https://api.github.com/users/JoTerrance/repos","events_url":"https://api.github.com/users/JoTerrance/events{/privacy}","received_events_url":"https://api.github.com/users/JoTerrance/received_events","type":"User","site_admin":false},"body":"el is valid date, no se si he tenido en cuenta los años bisiestos en el test, puede que se me haya escapado... pero tu ten en cuenta que tienes en los años bisiestos 29 dias","created_at":"2015-05-09T20:51:18Z","updated_at":"2015-05-09T20:51:18Z","html_url":"https://github.com/JoTerrance/fp/pull/16#discussion_r29996207","pull_request_url":"https://api.github.com/repos/JoTerrance/fp/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/comments/29996207"},"html":{"href":"https://github.com/JoTerrance/fp/pull/16#discussion_r29996207"},"pull_request":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/JoTerrance/fp/pulls/16","id":35072420,"html_url":"https://github.com/JoTerrance/fp/pull/16","diff_url":"https://github.com/JoTerrance/fp/pull/16.diff","patch_url":"https://github.com/JoTerrance/fp/pull/16.patch","issue_url":"https://api.github.com/repos/JoTerrance/fp/issues/16","number":16,"state":"open","locked":false,"title":"Final","user":{"login":"megadede","id":10352828,"avatar_url":"https://avatars.githubusercontent.com/u/10352828?v=3","gravatar_id":"","url":"https://api.github.com/users/megadede","html_url":"https://github.com/megadede","followers_url":"https://api.github.com/users/megadede/followers","following_url":"https://api.github.com/users/megadede/following{/other_user}","gists_url":"https://api.github.com/users/megadede/gists{/gist_id}","starred_url":"https://api.github.com/users/megadede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megadede/subscriptions","organizations_url":"https://api.github.com/users/megadede/orgs","repos_url":"https://api.github.com/users/megadede/repos","events_url":"https://api.github.com/users/megadede/events{/privacy}","received_events_url":"https://api.github.com/users/megadede/received_events","type":"User","site_admin":false},"body":"No me queda muy claro todavía el tema de las ramas y la master y que te llega a ti al hacer el pull request. Están todas las funciones terminadas, si no es así dímelo","created_at":"2015-05-09T20:25:24Z","updated_at":"2015-05-09T20:51:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JoTerrance/fp/pulls/16/commits","review_comments_url":"https://api.github.com/repos/JoTerrance/fp/pulls/16/comments","review_comment_url":"https://api.github.com/repos/JoTerrance/fp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoTerrance/fp/issues/16/comments","statuses_url":"https://api.github.com/repos/JoTerrance/fp/statuses/61671e4c346e8833fffc4e5f24bb12bd32af4ade","head":{"label":"megadede:master","ref":"master","sha":"61671e4c346e8833fffc4e5f24bb12bd32af4ade","user":{"login":"megadede","id":10352828,"avatar_url":"https://avatars.githubusercontent.com/u/10352828?v=3","gravatar_id":"","url":"https://api.github.com/users/megadede","html_url":"https://github.com/megadede","followers_url":"https://api.github.com/users/megadede/followers","following_url":"https://api.github.com/users/megadede/following{/other_user}","gists_url":"https://api.github.com/users/megadede/gists{/gist_id}","starred_url":"https://api.github.com/users/megadede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megadede/subscriptions","organizations_url":"https://api.github.com/users/megadede/orgs","repos_url":"https://api.github.com/users/megadede/repos","events_url":"https://api.github.com/users/megadede/events{/privacy}","received_events_url":"https://api.github.com/users/megadede/received_events","type":"User","site_admin":false},"repo":{"id":34318403,"name":"fp","full_name":"megadede/fp","owner":{"login":"megadede","id":10352828,"avatar_url":"https://avatars.githubusercontent.com/u/10352828?v=3","gravatar_id":"","url":"https://api.github.com/users/megadede","html_url":"https://github.com/megadede","followers_url":"https://api.github.com/users/megadede/followers","following_url":"https://api.github.com/users/megadede/following{/other_user}","gists_url":"https://api.github.com/users/megadede/gists{/gist_id}","starred_url":"https://api.github.com/users/megadede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megadede/subscriptions","organizations_url":"https://api.github.com/users/megadede/orgs","repos_url":"https://api.github.com/users/megadede/repos","events_url":"https://api.github.com/users/megadede/events{/privacy}","received_events_url":"https://api.github.com/users/megadede/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/megadede/fp","description":"Test para los alumnos de fp","fork":true,"url":"https://api.github.com/repos/megadede/fp","forks_url":"https://api.github.com/repos/megadede/fp/forks","keys_url":"https://api.github.com/repos/megadede/fp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/megadede/fp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/megadede/fp/teams","hooks_url":"https://api.github.com/repos/megadede/fp/hooks","issue_events_url":"https://api.github.com/repos/megadede/fp/issues/events{/number}","events_url":"https://api.github.com/repos/megadede/fp/events","assignees_url":"https://api.github.com/repos/megadede/fp/assignees{/user}","branches_url":"https://api.github.com/repos/megadede/fp/branches{/branch}","tags_url":"https://api.github.com/repos/megadede/fp/tags","blobs_url":"https://api.github.com/repos/megadede/fp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/megadede/fp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/megadede/fp/git/refs{/sha}","trees_url":"https://api.github.com/repos/megadede/fp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/megadede/fp/statuses/{sha}","languages_url":"https://api.github.com/repos/megadede/fp/languages","stargazers_url":"https://api.github.com/repos/megadede/fp/stargazers","contributors_url":"https://api.github.com/repos/megadede/fp/contributors","subscribers_url":"https://api.github.com/repos/megadede/fp/subscribers","subscription_url":"https://api.github.com/repos/megadede/fp/subscription","commits_url":"https://api.github.com/repos/megadede/fp/commits{/sha}","git_commits_url":"https://api.github.com/repos/megadede/fp/git/commits{/sha}","comments_url":"https://api.github.com/repos/megadede/fp/comments{/number}","issue_comment_url":"https://api.github.com/repos/megadede/fp/issues/comments{/number}","contents_url":"https://api.github.com/repos/megadede/fp/contents/{+path}","compare_url":"https://api.github.com/repos/megadede/fp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/megadede/fp/merges","archive_url":"https://api.github.com/repos/megadede/fp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/megadede/fp/downloads","issues_url":"https://api.github.com/repos/megadede/fp/issues{/number}","pulls_url":"https://api.github.com/repos/megadede/fp/pulls{/number}","milestones_url":"https://api.github.com/repos/megadede/fp/milestones{/number}","notifications_url":"https://api.github.com/repos/megadede/fp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/megadede/fp/labels{/name}","releases_url":"https://api.github.com/repos/megadede/fp/releases{/id}","created_at":"2015-04-21T09:46:32Z","updated_at":"2015-04-21T09:46:33Z","pushed_at":"2015-05-09T20:21:41Z","git_url":"git://github.com/megadede/fp.git","ssh_url":"git@github.com:megadede/fp.git","clone_url":"https://github.com/megadede/fp.git","svn_url":"https://github.com/megadede/fp","homepage":null,"size":65,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoTerrance:master","ref":"master","sha":"f3c81b76894ae6da6235090e751e092f119417d7","user":{"login":"JoTerrance","id":6041670,"avatar_url":"https://avatars.githubusercontent.com/u/6041670?v=3","gravatar_id":"","url":"https://api.github.com/users/JoTerrance","html_url":"https://github.com/JoTerrance","followers_url":"https://api.github.com/users/JoTerrance/followers","following_url":"https://api.github.com/users/JoTerrance/following{/other_user}","gists_url":"https://api.github.com/users/JoTerrance/gists{/gist_id}","starred_url":"https://api.github.com/users/JoTerrance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoTerrance/subscriptions","organizations_url":"https://api.github.com/users/JoTerrance/orgs","repos_url":"https://api.github.com/users/JoTerrance/repos","events_url":"https://api.github.com/users/JoTerrance/events{/privacy}","received_events_url":"https://api.github.com/users/JoTerrance/received_events","type":"User","site_admin":false},"repo":{"id":34184606,"name":"fp","full_name":"JoTerrance/fp","owner":{"login":"JoTerrance","id":6041670,"avatar_url":"https://avatars.githubusercontent.com/u/6041670?v=3","gravatar_id":"","url":"https://api.github.com/users/JoTerrance","html_url":"https://github.com/JoTerrance","followers_url":"https://api.github.com/users/JoTerrance/followers","following_url":"https://api.github.com/users/JoTerrance/following{/other_user}","gists_url":"https://api.github.com/users/JoTerrance/gists{/gist_id}","starred_url":"https://api.github.com/users/JoTerrance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoTerrance/subscriptions","organizations_url":"https://api.github.com/users/JoTerrance/orgs","repos_url":"https://api.github.com/users/JoTerrance/repos","events_url":"https://api.github.com/users/JoTerrance/events{/privacy}","received_events_url":"https://api.github.com/users/JoTerrance/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoTerrance/fp","description":"Test para los alumnos de fp","fork":false,"url":"https://api.github.com/repos/JoTerrance/fp","forks_url":"https://api.github.com/repos/JoTerrance/fp/forks","keys_url":"https://api.github.com/repos/JoTerrance/fp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoTerrance/fp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoTerrance/fp/teams","hooks_url":"https://api.github.com/repos/JoTerrance/fp/hooks","issue_events_url":"https://api.github.com/repos/JoTerrance/fp/issues/events{/number}","events_url":"https://api.github.com/repos/JoTerrance/fp/events","assignees_url":"https://api.github.com/repos/JoTerrance/fp/assignees{/user}","branches_url":"https://api.github.com/repos/JoTerrance/fp/branches{/branch}","tags_url":"https://api.github.com/repos/JoTerrance/fp/tags","blobs_url":"https://api.github.com/repos/JoTerrance/fp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoTerrance/fp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoTerrance/fp/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoTerrance/fp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoTerrance/fp/statuses/{sha}","languages_url":"https://api.github.com/repos/JoTerrance/fp/languages","stargazers_url":"https://api.github.com/repos/JoTerrance/fp/stargazers","contributors_url":"https://api.github.com/repos/JoTerrance/fp/contributors","subscribers_url":"https://api.github.com/repos/JoTerrance/fp/subscribers","subscription_url":"https://api.github.com/repos/JoTerrance/fp/subscription","commits_url":"https://api.github.com/repos/JoTerrance/fp/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoTerrance/fp/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoTerrance/fp/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoTerrance/fp/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoTerrance/fp/contents/{+path}","compare_url":"https://api.github.com/repos/JoTerrance/fp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoTerrance/fp/merges","archive_url":"https://api.github.com/repos/JoTerrance/fp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoTerrance/fp/downloads","issues_url":"https://api.github.com/repos/JoTerrance/fp/issues{/number}","pulls_url":"https://api.github.com/repos/JoTerrance/fp/pulls{/number}","milestones_url":"https://api.github.com/repos/JoTerrance/fp/milestones{/number}","notifications_url":"https://api.github.com/repos/JoTerrance/fp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoTerrance/fp/labels{/name}","releases_url":"https://api.github.com/repos/JoTerrance/fp/releases{/id}","created_at":"2015-04-18T22:07:52Z","updated_at":"2015-04-24T20:13:34Z","pushed_at":"2015-05-09T20:25:24Z","git_url":"git://github.com/JoTerrance/fp.git","ssh_url":"git@github.com:JoTerrance/fp.git","clone_url":"https://github.com/JoTerrance/fp.git","svn_url":"https://github.com/JoTerrance/fp","homepage":null,"size":804,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":1,"forks":20,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/16"},"html":{"href":"https://github.com/JoTerrance/fp/pull/16"},"issue":{"href":"https://api.github.com/repos/JoTerrance/fp/issues/16"},"comments":{"href":"https://api.github.com/repos/JoTerrance/fp/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoTerrance/fp/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/JoTerrance/fp/statuses/61671e4c346e8833fffc4e5f24bb12bd32af4ade"}}}}