{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-agent/pulls/comments/28695251","id":28695251,"diff_hunk":"@@ -341,6 +350,10 @@ ROW_LOOP:\n \t\t\t\t\t// Have never seen class before, so get digext text from perf schema.\n \t\t\t\t\tvar err error\n \t\t\t\t\tdigestText, err = w.getText(row.Digest)\n+\t\t\t\t\tif classId == \"NULL\" && digestText == \"\" {\n+\t\t\t\t\t\t// To make explains works\n+\t\t\t\t\t\tdigestText = `SELECT \"perf_schema_tables_are_full\"`","path":"qan/perfschema/worker.go","position":24,"original_position":24,"commit_id":"8fe5775222071ffaa907a16b330ab4ea8211d483","original_commit_id":"8fe5775222071ffaa907a16b330ab4ea8211d483","user":{"login":"daniel-nichter","id":1683183,"avatar_url":"https://avatars.githubusercontent.com/u/1683183?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-nichter","html_url":"https://github.com/daniel-nichter","followers_url":"https://api.github.com/users/daniel-nichter/followers","following_url":"https://api.github.com/users/daniel-nichter/following{/other_user}","gists_url":"https://api.github.com/users/daniel-nichter/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-nichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-nichter/subscriptions","organizations_url":"https://api.github.com/users/daniel-nichter/orgs","repos_url":"https://api.github.com/users/daniel-nichter/repos","events_url":"https://api.github.com/users/daniel-nichter/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-nichter/received_events","type":"User","site_admin":false},"body":"EXPLAIN doesn't need to work for this NULL \"query\", so is there a cleaner, less hackish way to do this? Iirc, API drops queries if the fingerprint is empty, so that won't work, but a fake SELECT seems wrong too. Plus, \"perf_schema_tables_are_full\" is misleading because there are many perf schema tables and not all of them are full, only one is.","created_at":"2015-04-20T14:51:27Z","updated_at":"2015-04-20T14:51:27Z","html_url":"https://github.com/percona/percona-agent/pull/165#discussion_r28695251","pull_request_url":"https://api.github.com/repos/percona/percona-agent/pulls/165","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/comments/28695251"},"html":{"href":"https://github.com/percona/percona-agent/pull/165#discussion_r28695251"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-agent/pulls/165","id":32993067,"html_url":"https://github.com/percona/percona-agent/pull/165","diff_url":"https://github.com/percona/percona-agent/pull/165.diff","patch_url":"https://github.com/percona/percona-agent/pull/165.patch","issue_url":"https://api.github.com/repos/percona/percona-agent/issues/165","number":165,"state":"open","locked":false,"title":"PCT-1619 Agent panicking on null digest in perf schema","user":{"login":"cfsalguero","id":2954232,"avatar_url":"https://avatars.githubusercontent.com/u/2954232?v=3","gravatar_id":"","url":"https://api.github.com/users/cfsalguero","html_url":"https://github.com/cfsalguero","followers_url":"https://api.github.com/users/cfsalguero/followers","following_url":"https://api.github.com/users/cfsalguero/following{/other_user}","gists_url":"https://api.github.com/users/cfsalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/cfsalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfsalguero/subscriptions","organizations_url":"https://api.github.com/users/cfsalguero/orgs","repos_url":"https://api.github.com/users/cfsalguero/repos","events_url":"https://api.github.com/users/cfsalguero/events{/privacy}","received_events_url":"https://api.github.com/users/cfsalguero/received_events","type":"User","site_admin":false},"body":"If events_statements_summary_by_digest is full, MySQL will start setting the digest to NULL and will only compute a summary under that null digest.\r\nSee http://dev.mysql.com/doc/refman/5.6/en/statement-summary-tables.html#idm140190647360848\r\nIn that case, we set the digest to the string NULL to support this  summary in PCT","created_at":"2015-04-09T20:29:25Z","updated_at":"2015-04-20T14:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8f64fa57e1ec96e5ccd37cf15645c5b17292ab7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-agent/pulls/165/commits","review_comments_url":"https://api.github.com/repos/percona/percona-agent/pulls/165/comments","review_comment_url":"https://api.github.com/repos/percona/percona-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-agent/issues/165/comments","statuses_url":"https://api.github.com/repos/percona/percona-agent/statuses/8fe5775222071ffaa907a16b330ab4ea8211d483","head":{"label":"percona:PCT-1619","ref":"PCT-1619","sha":"8fe5775222071ffaa907a16b330ab4ea8211d483","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":11132795,"name":"percona-agent","full_name":"percona/percona-agent","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-agent","description":"Percona Cloud Tools Agent","fork":false,"url":"https://api.github.com/repos/percona/percona-agent","forks_url":"https://api.github.com/repos/percona/percona-agent/forks","keys_url":"https://api.github.com/repos/percona/percona-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-agent/teams","hooks_url":"https://api.github.com/repos/percona/percona-agent/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-agent/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-agent/events","assignees_url":"https://api.github.com/repos/percona/percona-agent/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-agent/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-agent/tags","blobs_url":"https://api.github.com/repos/percona/percona-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-agent/languages","stargazers_url":"https://api.github.com/repos/percona/percona-agent/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-agent/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-agent/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-agent/subscription","commits_url":"https://api.github.com/repos/percona/percona-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-agent/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-agent/merges","archive_url":"https://api.github.com/repos/percona/percona-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-agent/downloads","issues_url":"https://api.github.com/repos/percona/percona-agent/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-agent/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-agent/releases{/id}","created_at":"2013-07-02T19:09:37Z","updated_at":"2015-04-08T13:27:16Z","pushed_at":"2015-04-17T14:50:44Z","git_url":"git://github.com/percona/percona-agent.git","ssh_url":"git@github.com:percona/percona-agent.git","clone_url":"https://github.com/percona/percona-agent.git","svn_url":"https://github.com/percona/percona-agent","homepage":"","size":13402,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":38,"default_branch":"release"}},"base":{"label":"percona:release","ref":"release","sha":"46ce3276f2484fa9f29f468d77e314b6a311cc70","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":11132795,"name":"percona-agent","full_name":"percona/percona-agent","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-agent","description":"Percona Cloud Tools Agent","fork":false,"url":"https://api.github.com/repos/percona/percona-agent","forks_url":"https://api.github.com/repos/percona/percona-agent/forks","keys_url":"https://api.github.com/repos/percona/percona-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-agent/teams","hooks_url":"https://api.github.com/repos/percona/percona-agent/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-agent/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-agent/events","assignees_url":"https://api.github.com/repos/percona/percona-agent/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-agent/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-agent/tags","blobs_url":"https://api.github.com/repos/percona/percona-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-agent/languages","stargazers_url":"https://api.github.com/repos/percona/percona-agent/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-agent/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-agent/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-agent/subscription","commits_url":"https://api.github.com/repos/percona/percona-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-agent/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-agent/merges","archive_url":"https://api.github.com/repos/percona/percona-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-agent/downloads","issues_url":"https://api.github.com/repos/percona/percona-agent/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-agent/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-agent/releases{/id}","created_at":"2013-07-02T19:09:37Z","updated_at":"2015-04-08T13:27:16Z","pushed_at":"2015-04-17T14:50:44Z","git_url":"git://github.com/percona/percona-agent.git","ssh_url":"git@github.com:percona/percona-agent.git","clone_url":"https://github.com/percona/percona-agent.git","svn_url":"https://github.com/percona/percona-agent","homepage":"","size":13402,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":38,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/165"},"html":{"href":"https://github.com/percona/percona-agent/pull/165"},"issue":{"href":"https://api.github.com/repos/percona/percona-agent/issues/165"},"comments":{"href":"https://api.github.com/repos/percona/percona-agent/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-agent/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-agent/statuses/8fe5775222071ffaa907a16b330ab4ea8211d483"}}}}