{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/34689262","id":34689262,"diff_hunk":"@@ -227,13 +227,13 @@ turf/proc/hotspot_expose(exposed_temperature, exposed_volume, soh = 0)\n //Returns the firelevel\n /datum/gas_mixture/proc/zburn(zone/zone, force_burn, no_check = 0)\n \t. = 0\n-\tif((temperature > PHORON_MINIMUM_BURN_TEMPERATURE || force_burn) && (no_check ||check_recombustability(zone? zone.fuel_objs : null)))\n-\t\n+\tif((temperature > PHORON_FLASHPOINT || force_burn) && (no_check ||check_recombustability(zone? zone.fuel_objs : null)))","path":"code/ZAS/Fire.dm","position":41,"original_position":41,"commit_id":"062174d0a4238e0626b47a1f02adf50193664419","original_commit_id":"062174d0a4238e0626b47a1f02adf50193664419","user":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"body":"I was thinking there should be something higher level than `zburn()` to handle the logic of, \"If we're not burning, we start burning above flashpoint, otherwise we only burn gas above the minimum gas temperature.\" It would be much better than forcing callees to handle that logic by setting force_burn and no_check flags. Now that I've thought about it though, it would require some refactoring that is probably beyond the scope of this PR.\r\n\r\n","created_at":"2015-07-15T15:16:13Z","updated_at":"2015-07-15T15:16:13Z","html_url":"https://github.com/Baystation12/Baystation12/pull/10186#discussion_r34689262","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/34689262"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/10186#discussion_r34689262"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186","id":39987749,"html_url":"https://github.com/Baystation12/Baystation12/pull/10186","diff_url":"https://github.com/Baystation12/Baystation12/pull/10186.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/10186.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/10186","number":10186,"state":"open","locked":false,"title":"Changes fire behavior to burn at it's flashpoint when enclosed.","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"body":"Changes fire behavior to burn at its flashpoint when enclosed.\r\n\r\nChanged single tank bombs to be less... stupid.\r\nThe 70 liter tanks can now be welded to help with the rupturing of single tank bombs.\r\n\r\nAs a necessary evil, zburn changed from phoron_minimum_burn_temperature to phoron_flashpoint, as all hotspots still function, and the fires are sustained below the flashpoint, but it doesn't cause contained phoron to begin burning below the flashpoint, unless using forced=1 or it's ignited by something else.\r\n\r\nSingle-tank bomb usage: Fill with your gas mixture, weld the tank (don't move, else you damage the tank!) and then attach the assembly. When triggered, ignites contained phoron. The zburn proc and rupture code handles the rest, and more importantly, gives time to escape. Unwelded tanks release their contents, with an added hotspot to ignite the phoron should it be in there. \r\n\r\nIgniter assemblies are single use only, and leave only the tank.\r\n\r\nEdit: (also, changed the name from 'bomb', because that was just silly)","created_at":"2015-07-15T04:45:47Z","updated_at":"2015-07-15T15:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d345d8574cd6210eb4eb02dae9baf07d74c991fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/10186/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/062174d0a4238e0626b47a1f02adf50193664419","head":{"label":"LorenLuke:singletank","ref":"singletank","sha":"062174d0a4238e0626b47a1f02adf50193664419","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"repo":{"id":26836894,"name":"Baystation12","full_name":"LorenLuke/Baystation12","owner":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LorenLuke/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/LorenLuke/Baystation12","forks_url":"https://api.github.com/repos/LorenLuke/Baystation12/forks","keys_url":"https://api.github.com/repos/LorenLuke/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LorenLuke/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LorenLuke/Baystation12/teams","hooks_url":"https://api.github.com/repos/LorenLuke/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/LorenLuke/Baystation12/events","assignees_url":"https://api.github.com/repos/LorenLuke/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/LorenLuke/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/tags","blobs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LorenLuke/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/LorenLuke/Baystation12/languages","stargazers_url":"https://api.github.com/repos/LorenLuke/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/LorenLuke/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscription","commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/LorenLuke/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/LorenLuke/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/LorenLuke/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LorenLuke/Baystation12/merges","archive_url":"https://api.github.com/repos/LorenLuke/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LorenLuke/Baystation12/downloads","issues_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/LorenLuke/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/LorenLuke/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/LorenLuke/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LorenLuke/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/LorenLuke/Baystation12/releases{/id}","created_at":"2014-11-19T00:30:53Z","updated_at":"2014-11-19T00:31:03Z","pushed_at":"2015-07-15T03:34:48Z","git_url":"git://github.com/LorenLuke/Baystation12.git","ssh_url":"git@github.com:LorenLuke/Baystation12.git","clone_url":"https://github.com/LorenLuke/Baystation12.git","svn_url":"https://github.com/LorenLuke/Baystation12","homepage":"http://baystation12.net/","size":675589,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"456d07ee79d9d17bec9ea3e6e4bfa5db390a6444","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2015-07-13T21:47:54Z","pushed_at":"2015-07-15T15:04:28Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1553500,"stargazers_count":199,"watchers_count":199,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":784,"mirror_url":null,"open_issues_count":233,"forks":784,"open_issues":233,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/10186"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/10186"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/10186/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/10186/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/062174d0a4238e0626b47a1f02adf50193664419"}}}}