{"action":"created","comment":{"url":"https://api.github.com/repos/juju/httprequest/pulls/comments/24503375","id":24503375,"diff_hunk":"@@ -45,6 +45,9 @@ type resultMaker func(reflect.Value) reflect.Value\n // but passed to makeResult and then updated.\n type unmarshaler func(v reflect.Value, p Params, makeResult resultMaker) error\n \n+// marshaler marshals the specified value into params.","path":"type.go","position":4,"original_position":4,"commit_id":"7e54309ca9455969128da89d1afd221d2002cb36","original_commit_id":"7e54309ca9455969128da89d1afd221d2002cb36","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"After my remarks above, I would suggest this:\r\n\r\n    // The value is always the value type, even if the field type\r\n    // is a pointer.","created_at":"2015-02-11T15:31:58Z","updated_at":"2015-02-11T15:31:58Z","html_url":"https://github.com/juju/httprequest/pull/6#discussion_r24503375","pull_request_url":"https://api.github.com/repos/juju/httprequest/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/juju/httprequest/pulls/comments/24503375"},"html":{"href":"https://github.com/juju/httprequest/pull/6#discussion_r24503375"},"pull_request":{"href":"https://api.github.com/repos/juju/httprequest/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/juju/httprequest/pulls/6","id":29088772,"html_url":"https://github.com/juju/httprequest/pull/6","diff_url":"https://github.com/juju/httprequest/pull/6.diff","patch_url":"https://github.com/juju/httprequest/pull/6.patch","issue_url":"https://api.github.com/repos/juju/httprequest/issues/6","number":6,"state":"open","locked":false,"title":"Implemented Marshal","user":{"login":"alesstimec","id":5555154,"avatar_url":"https://avatars.githubusercontent.com/u/5555154?v=3","gravatar_id":"","url":"https://api.github.com/users/alesstimec","html_url":"https://github.com/alesstimec","followers_url":"https://api.github.com/users/alesstimec/followers","following_url":"https://api.github.com/users/alesstimec/following{/other_user}","gists_url":"https://api.github.com/users/alesstimec/gists{/gist_id}","starred_url":"https://api.github.com/users/alesstimec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesstimec/subscriptions","organizations_url":"https://api.github.com/users/alesstimec/orgs","repos_url":"https://api.github.com/users/alesstimec/repos","events_url":"https://api.github.com/users/alesstimec/events{/privacy}","received_events_url":"https://api.github.com/users/alesstimec/received_events","type":"User","site_admin":false},"body":"Added implementation of the Marshal method that takes the base url, method and\r\nand input (pointer to struct) and returns an http Request with appropriately\r\nmarshaled input.","created_at":"2015-02-11T12:58:59Z","updated_at":"2015-02-11T15:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eca8300feff7977f66f3ddcf48ba51d2f0feba54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/httprequest/pulls/6/commits","review_comments_url":"https://api.github.com/repos/juju/httprequest/pulls/6/comments","review_comment_url":"https://api.github.com/repos/juju/httprequest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/httprequest/issues/6/comments","statuses_url":"https://api.github.com/repos/juju/httprequest/statuses/7e54309ca9455969128da89d1afd221d2002cb36","head":{"label":"alesstimec:marshal","ref":"marshal","sha":"7e54309ca9455969128da89d1afd221d2002cb36","user":{"login":"alesstimec","id":5555154,"avatar_url":"https://avatars.githubusercontent.com/u/5555154?v=3","gravatar_id":"","url":"https://api.github.com/users/alesstimec","html_url":"https://github.com/alesstimec","followers_url":"https://api.github.com/users/alesstimec/followers","following_url":"https://api.github.com/users/alesstimec/following{/other_user}","gists_url":"https://api.github.com/users/alesstimec/gists{/gist_id}","starred_url":"https://api.github.com/users/alesstimec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesstimec/subscriptions","organizations_url":"https://api.github.com/users/alesstimec/orgs","repos_url":"https://api.github.com/users/alesstimec/repos","events_url":"https://api.github.com/users/alesstimec/events{/privacy}","received_events_url":"https://api.github.com/users/alesstimec/received_events","type":"User","site_admin":false},"repo":{"id":30544756,"name":"httprequest","full_name":"alesstimec/httprequest","owner":{"login":"alesstimec","id":5555154,"avatar_url":"https://avatars.githubusercontent.com/u/5555154?v=3","gravatar_id":"","url":"https://api.github.com/users/alesstimec","html_url":"https://github.com/alesstimec","followers_url":"https://api.github.com/users/alesstimec/followers","following_url":"https://api.github.com/users/alesstimec/following{/other_user}","gists_url":"https://api.github.com/users/alesstimec/gists{/gist_id}","starred_url":"https://api.github.com/users/alesstimec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesstimec/subscriptions","organizations_url":"https://api.github.com/users/alesstimec/orgs","repos_url":"https://api.github.com/users/alesstimec/repos","events_url":"https://api.github.com/users/alesstimec/events{/privacy}","received_events_url":"https://api.github.com/users/alesstimec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alesstimec/httprequest","description":"Unmarshaling of HTTP request parameters","fork":true,"url":"https://api.github.com/repos/alesstimec/httprequest","forks_url":"https://api.github.com/repos/alesstimec/httprequest/forks","keys_url":"https://api.github.com/repos/alesstimec/httprequest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alesstimec/httprequest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alesstimec/httprequest/teams","hooks_url":"https://api.github.com/repos/alesstimec/httprequest/hooks","issue_events_url":"https://api.github.com/repos/alesstimec/httprequest/issues/events{/number}","events_url":"https://api.github.com/repos/alesstimec/httprequest/events","assignees_url":"https://api.github.com/repos/alesstimec/httprequest/assignees{/user}","branches_url":"https://api.github.com/repos/alesstimec/httprequest/branches{/branch}","tags_url":"https://api.github.com/repos/alesstimec/httprequest/tags","blobs_url":"https://api.github.com/repos/alesstimec/httprequest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alesstimec/httprequest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alesstimec/httprequest/git/refs{/sha}","trees_url":"https://api.github.com/repos/alesstimec/httprequest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alesstimec/httprequest/statuses/{sha}","languages_url":"https://api.github.com/repos/alesstimec/httprequest/languages","stargazers_url":"https://api.github.com/repos/alesstimec/httprequest/stargazers","contributors_url":"https://api.github.com/repos/alesstimec/httprequest/contributors","subscribers_url":"https://api.github.com/repos/alesstimec/httprequest/subscribers","subscription_url":"https://api.github.com/repos/alesstimec/httprequest/subscription","commits_url":"https://api.github.com/repos/alesstimec/httprequest/commits{/sha}","git_commits_url":"https://api.github.com/repos/alesstimec/httprequest/git/commits{/sha}","comments_url":"https://api.github.com/repos/alesstimec/httprequest/comments{/number}","issue_comment_url":"https://api.github.com/repos/alesstimec/httprequest/issues/comments/{number}","contents_url":"https://api.github.com/repos/alesstimec/httprequest/contents/{+path}","compare_url":"https://api.github.com/repos/alesstimec/httprequest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alesstimec/httprequest/merges","archive_url":"https://api.github.com/repos/alesstimec/httprequest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alesstimec/httprequest/downloads","issues_url":"https://api.github.com/repos/alesstimec/httprequest/issues{/number}","pulls_url":"https://api.github.com/repos/alesstimec/httprequest/pulls{/number}","milestones_url":"https://api.github.com/repos/alesstimec/httprequest/milestones{/number}","notifications_url":"https://api.github.com/repos/alesstimec/httprequest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alesstimec/httprequest/labels{/name}","releases_url":"https://api.github.com/repos/alesstimec/httprequest/releases{/id}","created_at":"2015-02-09T16:14:33Z","updated_at":"2015-02-11T13:01:47Z","pushed_at":"2015-02-11T14:32:23Z","git_url":"git://github.com/alesstimec/httprequest.git","ssh_url":"git@github.com:alesstimec/httprequest.git","clone_url":"https://github.com/alesstimec/httprequest.git","svn_url":"https://github.com/alesstimec/httprequest","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"c5411ed89d2572545d3e0ff13818038586a8bffa","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":30354147,"name":"httprequest","full_name":"juju/httprequest","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/httprequest","description":"Unmarshaling of HTTP request parameters","fork":false,"url":"https://api.github.com/repos/juju/httprequest","forks_url":"https://api.github.com/repos/juju/httprequest/forks","keys_url":"https://api.github.com/repos/juju/httprequest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/httprequest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/httprequest/teams","hooks_url":"https://api.github.com/repos/juju/httprequest/hooks","issue_events_url":"https://api.github.com/repos/juju/httprequest/issues/events{/number}","events_url":"https://api.github.com/repos/juju/httprequest/events","assignees_url":"https://api.github.com/repos/juju/httprequest/assignees{/user}","branches_url":"https://api.github.com/repos/juju/httprequest/branches{/branch}","tags_url":"https://api.github.com/repos/juju/httprequest/tags","blobs_url":"https://api.github.com/repos/juju/httprequest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/httprequest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/httprequest/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/httprequest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/httprequest/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/httprequest/languages","stargazers_url":"https://api.github.com/repos/juju/httprequest/stargazers","contributors_url":"https://api.github.com/repos/juju/httprequest/contributors","subscribers_url":"https://api.github.com/repos/juju/httprequest/subscribers","subscription_url":"https://api.github.com/repos/juju/httprequest/subscription","commits_url":"https://api.github.com/repos/juju/httprequest/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/httprequest/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/httprequest/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/httprequest/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/httprequest/contents/{+path}","compare_url":"https://api.github.com/repos/juju/httprequest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/httprequest/merges","archive_url":"https://api.github.com/repos/juju/httprequest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/httprequest/downloads","issues_url":"https://api.github.com/repos/juju/httprequest/issues{/number}","pulls_url":"https://api.github.com/repos/juju/httprequest/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/httprequest/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/httprequest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/httprequest/labels{/name}","releases_url":"https://api.github.com/repos/juju/httprequest/releases{/id}","created_at":"2015-02-05T12:23:01Z","updated_at":"2015-02-10T11:24:52Z","pushed_at":"2015-02-10T11:24:50Z","git_url":"git://github.com/juju/httprequest.git","ssh_url":"git@github.com:juju/httprequest.git","clone_url":"https://github.com/juju/httprequest.git","svn_url":"https://github.com/juju/httprequest","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/httprequest/pulls/6"},"html":{"href":"https://github.com/juju/httprequest/pull/6"},"issue":{"href":"https://api.github.com/repos/juju/httprequest/issues/6"},"comments":{"href":"https://api.github.com/repos/juju/httprequest/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/httprequest/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/httprequest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/httprequest/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/juju/httprequest/statuses/7e54309ca9455969128da89d1afd221d2002cb36"}}}}