{"action":"created","issue":{"url":"https://api.github.com/repos/piwik/piwik/issues/8892","labels_url":"https://api.github.com/repos/piwik/piwik/issues/8892/labels{/name}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/8892/comments","events_url":"https://api.github.com/repos/piwik/piwik/issues/8892/events","html_url":"https://github.com/piwik/piwik/pull/8892","id":109387240,"number":8892,"title":"Segment subquery cache: minor code review items","user":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/piwik/piwik/labels/not-in-changelog","name":"not-in-changelog","color":"ffffff"},{"url":"https://api.github.com/repos/piwik/piwik/labels/Pull%20Request%20WIP","name":"Pull Request WIP","color":"006b75"}],"state":"closed","locked":false,"assignee":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/84","html_url":"https://github.com/piwik/piwik/milestones/2.15.0","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/84/labels","id":1202482,"number":84,"title":"2.15.0","description":"","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":284,"state":"open","created_at":"2015-07-10T13:26:16Z","updated_at":"2015-10-05T21:43:07Z","due_on":"2015-10-14T11:00:00Z","closed_at":null},"comments":1,"created_at":"2015-10-01T21:16:29Z","updated_at":"2015-10-05T22:18:04Z","closed_at":"2015-10-04T23:43:29Z","pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/8892","html_url":"https://github.com/piwik/piwik/pull/8892","diff_url":"https://github.com/piwik/piwik/pull/8892.diff","patch_url":"https://github.com/piwik/piwik/pull/8892.patch"},"body":"follows up: #8850\r\n\r\nTodo\r\n\r\n * [x] Put class in DI, and dependencies too"},"comment":{"url":"https://api.github.com/repos/piwik/piwik/issues/comments/145685672","html_url":"https://github.com/piwik/piwik/pull/8892#issuecomment-145685672","issue_url":"https://api.github.com/repos/piwik/piwik/issues/8892","id":145685672,"user":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T22:18:04Z","updated_at":"2015-10-05T22:18:04Z","body":"> This change is not complete. If TableLogAction/Cache is stored in the DI container, you do not need to use Config::getInstance() or StaticContainer. \r\n\r\nOh ok! I just understand this. Thanks, will create a new PR."}}