{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/46908234","id":46908234,"diff_hunk":"@@ -324,6 +332,11 @@ func RunEnv(f *clientcmd.Factory, in io.Reader, out io.Writer, cmd *cobra.Comman\n \n \tfailed := false\n \tfor i, info := range infos {\n+\t\tshortOutput := cmdutil.GetFlagString(cmd, \"output\") == \"name\"","path":"pkg/cmd/cli/cmd/env.go","position":39,"original_position":39,"commit_id":"2cbfd4a6f2a134d4a33114578ffca9c8491b4a34","original_commit_id":"2cbfd4a6f2a134d4a33114578ffca9c8491b4a34","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"move `shortOutput := cmdutil.GetFlagString(cmd, \"output\") == \"name\"` outside the loop","created_at":"2015-12-08T02:22:52Z","updated_at":"2015-12-08T02:22:52Z","html_url":"https://github.com/openshift/origin/pull/6104#discussion_r46908234","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6104","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/46908234"},"html":{"href":"https://github.com/openshift/origin/pull/6104#discussion_r46908234"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6104"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6104","id":51927849,"html_url":"https://github.com/openshift/origin/pull/6104","diff_url":"https://github.com/openshift/origin/pull/6104.diff","patch_url":"https://github.com/openshift/origin/pull/6104.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6104","number":6104,"state":"open","locked":false,"title":"Bug1277038 - Differ between `oc env` updates(removes/adds) the resource(s) envvars and when it doesnt ","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"body":"When adding/removing envvars with `oc env` cmd, differ between states when the command actually updates the resource(s) and when it doesnt.\r\nEg: When updating resource by adding the envvar with a value that is already present in the resource, or removing a envvar that is not present, the printed output will look accordingly:\r\n`replicationcontroller \"database-1\" nothing to update`\r\ninstead of \r\n`replicationcontroller \"database-1\" updated`\r\n\r\n+ added a TC\r\n\r\nWasnt sure if we also wanna print due to which envar the resource wasnt updated (eg1. removing envvar thats not present in the resource || updating envar with the same value), since we would have to revrite some parts of the `env.go` and will end up with dup. messages in case user would want to update all rcs/dc with wrong envars(eg1).\r\n\r\n@fabianofranz thoughts ?","created_at":"2015-11-26T16:00:19Z","updated_at":"2015-12-08T02:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91cff53d91f44d6755102f2d797804c5a9697a5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6104/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6104/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6104/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/2cbfd4a6f2a134d4a33114578ffca9c8491b4a34","head":{"label":"jhadvig:BZ_1277038","ref":"BZ_1277038","sha":"2cbfd4a6f2a134d4a33114578ffca9c8491b4a34","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"repo":{"id":24180023,"name":"origin","full_name":"jhadvig/origin","owner":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhadvig/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jhadvig/origin","forks_url":"https://api.github.com/repos/jhadvig/origin/forks","keys_url":"https://api.github.com/repos/jhadvig/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhadvig/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhadvig/origin/teams","hooks_url":"https://api.github.com/repos/jhadvig/origin/hooks","issue_events_url":"https://api.github.com/repos/jhadvig/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jhadvig/origin/events","assignees_url":"https://api.github.com/repos/jhadvig/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jhadvig/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jhadvig/origin/tags","blobs_url":"https://api.github.com/repos/jhadvig/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhadvig/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhadvig/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhadvig/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhadvig/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jhadvig/origin/languages","stargazers_url":"https://api.github.com/repos/jhadvig/origin/stargazers","contributors_url":"https://api.github.com/repos/jhadvig/origin/contributors","subscribers_url":"https://api.github.com/repos/jhadvig/origin/subscribers","subscription_url":"https://api.github.com/repos/jhadvig/origin/subscription","commits_url":"https://api.github.com/repos/jhadvig/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhadvig/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhadvig/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhadvig/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhadvig/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jhadvig/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhadvig/origin/merges","archive_url":"https://api.github.com/repos/jhadvig/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhadvig/origin/downloads","issues_url":"https://api.github.com/repos/jhadvig/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jhadvig/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jhadvig/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jhadvig/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhadvig/origin/labels{/name}","releases_url":"https://api.github.com/repos/jhadvig/origin/releases{/id}","created_at":"2014-09-18T08:22:36Z","updated_at":"2015-08-13T16:47:19Z","pushed_at":"2015-12-08T00:30:20Z","git_url":"git://github.com/jhadvig/origin.git","ssh_url":"git@github.com:jhadvig/origin.git","clone_url":"https://github.com/jhadvig/origin.git","svn_url":"https://github.com/jhadvig/origin","homepage":"https://openshift.github.io","size":178714,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"9db11169b35dec54b3fbe7a8860a57f7c5bd705d","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-12-07T22:56:28Z","pushed_at":"2015-12-08T00:30:21Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":227231,"stargazers_count":857,"watchers_count":857,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":536,"mirror_url":null,"open_issues_count":717,"forks":536,"open_issues":717,"watchers":857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6104"},"html":{"href":"https://github.com/openshift/origin/pull/6104"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6104"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6104/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6104/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6104/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/2cbfd4a6f2a134d4a33114578ffca9c8491b4a34"}}}}