{"action":"created","comment":{"url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/comments/44869841","id":44869841,"diff_hunk":"@@ -2720,9 +2888,34 @@ static mrb_value mrb_http2_server_rputs(mrb_state *mrb, mrb_value self)\n   char *msg;\n   mrb_int len;\n   int rv;\n+  ssize_t nread;\n+  mrb_http2_large_buf *b;","path":"src/mrb_http2_server.c","position":276,"original_position":276,"commit_id":"9f0ea49ab1d23876f73d963549eb71e93286a59a","original_commit_id":"9f0ea49ab1d23876f73d963549eb71e93286a59a","user":{"login":"kjunichi","id":2083826,"avatar_url":"https://avatars.githubusercontent.com/u/2083826?v=3","gravatar_id":"","url":"https://api.github.com/users/kjunichi","html_url":"https://github.com/kjunichi","followers_url":"https://api.github.com/users/kjunichi/followers","following_url":"https://api.github.com/users/kjunichi/following{/other_user}","gists_url":"https://api.github.com/users/kjunichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kjunichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjunichi/subscriptions","organizations_url":"https://api.github.com/users/kjunichi/orgs","repos_url":"https://api.github.com/users/kjunichi/repos","events_url":"https://api.github.com/users/kjunichi/events{/privacy}","received_events_url":"https://api.github.com/users/kjunichi/received_events","type":"User","site_admin":false},"body":"C99以前のC言語が馴染んでしまって、モダンな書き方がまだできずにいます。\r\nご指摘ありがとうございます。修正します。\r\n\r\nまた、nreadが未使用なので、消しました。\r\n未使用変数の警告が出ないんですね。うっかりしてました。\r\n","created_at":"2015-11-15T10:14:22Z","updated_at":"2015-11-15T10:14:22Z","html_url":"https://github.com/matsumoto-r/mruby-http2/pull/35#discussion_r44869841","pull_request_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/comments/44869841"},"html":{"href":"https://github.com/matsumoto-r/mruby-http2/pull/35#discussion_r44869841"},"pull_request":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35","id":40885118,"html_url":"https://github.com/matsumoto-r/mruby-http2/pull/35","diff_url":"https://github.com/matsumoto-r/mruby-http2/pull/35.diff","patch_url":"https://github.com/matsumoto-r/mruby-http2/pull/35.patch","issue_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/35","number":35,"state":"open","locked":false,"title":"fix to work rputs over 64k bytes.","user":{"login":"kjunichi","id":2083826,"avatar_url":"https://avatars.githubusercontent.com/u/2083826?v=3","gravatar_id":"","url":"https://api.github.com/users/kjunichi","html_url":"https://github.com/kjunichi","followers_url":"https://api.github.com/users/kjunichi/followers","following_url":"https://api.github.com/users/kjunichi/following{/other_user}","gists_url":"https://api.github.com/users/kjunichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kjunichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjunichi/subscriptions","organizations_url":"https://api.github.com/users/kjunichi/orgs","repos_url":"https://api.github.com/users/kjunichi/repos","events_url":"https://api.github.com/users/kjunichi/events{/privacy}","received_events_url":"https://api.github.com/users/kjunichi/received_events","type":"User","site_admin":false},"body":"When we rputs over 64k bytes,write system call is blocked.This patch is fix it.","created_at":"2015-07-27T09:33:55Z","updated_at":"2015-11-15T10:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21fcf519541383a964daf008f9366ab372e3d03e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35/commits","review_comments_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35/comments","review_comment_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/35/comments","statuses_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/statuses/9f0ea49ab1d23876f73d963549eb71e93286a59a","head":{"label":"kjunichi:fix-mruby-response-with-over-64kb","ref":"fix-mruby-response-with-over-64kb","sha":"9f0ea49ab1d23876f73d963549eb71e93286a59a","user":{"login":"kjunichi","id":2083826,"avatar_url":"https://avatars.githubusercontent.com/u/2083826?v=3","gravatar_id":"","url":"https://api.github.com/users/kjunichi","html_url":"https://github.com/kjunichi","followers_url":"https://api.github.com/users/kjunichi/followers","following_url":"https://api.github.com/users/kjunichi/following{/other_user}","gists_url":"https://api.github.com/users/kjunichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kjunichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjunichi/subscriptions","organizations_url":"https://api.github.com/users/kjunichi/orgs","repos_url":"https://api.github.com/users/kjunichi/repos","events_url":"https://api.github.com/users/kjunichi/events{/privacy}","received_events_url":"https://api.github.com/users/kjunichi/received_events","type":"User","site_admin":false},"repo":{"id":32963737,"name":"mruby-http2","full_name":"kjunichi/mruby-http2","owner":{"login":"kjunichi","id":2083826,"avatar_url":"https://avatars.githubusercontent.com/u/2083826?v=3","gravatar_id":"","url":"https://api.github.com/users/kjunichi","html_url":"https://github.com/kjunichi","followers_url":"https://api.github.com/users/kjunichi/followers","following_url":"https://api.github.com/users/kjunichi/following{/other_user}","gists_url":"https://api.github.com/users/kjunichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kjunichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjunichi/subscriptions","organizations_url":"https://api.github.com/users/kjunichi/orgs","repos_url":"https://api.github.com/users/kjunichi/repos","events_url":"https://api.github.com/users/kjunichi/events{/privacy}","received_events_url":"https://api.github.com/users/kjunichi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjunichi/mruby-http2","description":"HTTP2 Module for mruby","fork":true,"url":"https://api.github.com/repos/kjunichi/mruby-http2","forks_url":"https://api.github.com/repos/kjunichi/mruby-http2/forks","keys_url":"https://api.github.com/repos/kjunichi/mruby-http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjunichi/mruby-http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjunichi/mruby-http2/teams","hooks_url":"https://api.github.com/repos/kjunichi/mruby-http2/hooks","issue_events_url":"https://api.github.com/repos/kjunichi/mruby-http2/issues/events{/number}","events_url":"https://api.github.com/repos/kjunichi/mruby-http2/events","assignees_url":"https://api.github.com/repos/kjunichi/mruby-http2/assignees{/user}","branches_url":"https://api.github.com/repos/kjunichi/mruby-http2/branches{/branch}","tags_url":"https://api.github.com/repos/kjunichi/mruby-http2/tags","blobs_url":"https://api.github.com/repos/kjunichi/mruby-http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjunichi/mruby-http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjunichi/mruby-http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjunichi/mruby-http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjunichi/mruby-http2/statuses/{sha}","languages_url":"https://api.github.com/repos/kjunichi/mruby-http2/languages","stargazers_url":"https://api.github.com/repos/kjunichi/mruby-http2/stargazers","contributors_url":"https://api.github.com/repos/kjunichi/mruby-http2/contributors","subscribers_url":"https://api.github.com/repos/kjunichi/mruby-http2/subscribers","subscription_url":"https://api.github.com/repos/kjunichi/mruby-http2/subscription","commits_url":"https://api.github.com/repos/kjunichi/mruby-http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjunichi/mruby-http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjunichi/mruby-http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjunichi/mruby-http2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjunichi/mruby-http2/contents/{+path}","compare_url":"https://api.github.com/repos/kjunichi/mruby-http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjunichi/mruby-http2/merges","archive_url":"https://api.github.com/repos/kjunichi/mruby-http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjunichi/mruby-http2/downloads","issues_url":"https://api.github.com/repos/kjunichi/mruby-http2/issues{/number}","pulls_url":"https://api.github.com/repos/kjunichi/mruby-http2/pulls{/number}","milestones_url":"https://api.github.com/repos/kjunichi/mruby-http2/milestones{/number}","notifications_url":"https://api.github.com/repos/kjunichi/mruby-http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjunichi/mruby-http2/labels{/name}","releases_url":"https://api.github.com/repos/kjunichi/mruby-http2/releases{/id}","created_at":"2015-03-27T02:32:58Z","updated_at":"2015-03-27T02:32:59Z","pushed_at":"2015-11-14T21:06:44Z","git_url":"git://github.com/kjunichi/mruby-http2.git","ssh_url":"git@github.com:kjunichi/mruby-http2.git","clone_url":"https://github.com/kjunichi/mruby-http2.git","svn_url":"https://github.com/kjunichi/mruby-http2","homepage":"","size":999,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matsumoto-r:master","ref":"master","sha":"856aba5b5700645188444f06b5416a8eaaf33469","user":{"login":"matsumoto-r","id":648437,"avatar_url":"https://avatars.githubusercontent.com/u/648437?v=3","gravatar_id":"","url":"https://api.github.com/users/matsumoto-r","html_url":"https://github.com/matsumoto-r","followers_url":"https://api.github.com/users/matsumoto-r/followers","following_url":"https://api.github.com/users/matsumoto-r/following{/other_user}","gists_url":"https://api.github.com/users/matsumoto-r/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumoto-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumoto-r/subscriptions","organizations_url":"https://api.github.com/users/matsumoto-r/orgs","repos_url":"https://api.github.com/users/matsumoto-r/repos","events_url":"https://api.github.com/users/matsumoto-r/events{/privacy}","received_events_url":"https://api.github.com/users/matsumoto-r/received_events","type":"User","site_admin":false},"repo":{"id":15548481,"name":"mruby-http2","full_name":"matsumoto-r/mruby-http2","owner":{"login":"matsumoto-r","id":648437,"avatar_url":"https://avatars.githubusercontent.com/u/648437?v=3","gravatar_id":"","url":"https://api.github.com/users/matsumoto-r","html_url":"https://github.com/matsumoto-r","followers_url":"https://api.github.com/users/matsumoto-r/followers","following_url":"https://api.github.com/users/matsumoto-r/following{/other_user}","gists_url":"https://api.github.com/users/matsumoto-r/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumoto-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumoto-r/subscriptions","organizations_url":"https://api.github.com/users/matsumoto-r/orgs","repos_url":"https://api.github.com/users/matsumoto-r/repos","events_url":"https://api.github.com/users/matsumoto-r/events{/privacy}","received_events_url":"https://api.github.com/users/matsumoto-r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matsumoto-r/mruby-http2","description":"HTTP2 Module for mruby","fork":false,"url":"https://api.github.com/repos/matsumoto-r/mruby-http2","forks_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/forks","keys_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/teams","hooks_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/hooks","issue_events_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/events{/number}","events_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/events","assignees_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/assignees{/user}","branches_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/branches{/branch}","tags_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/tags","blobs_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/statuses/{sha}","languages_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/languages","stargazers_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/stargazers","contributors_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/contributors","subscribers_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/subscribers","subscription_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/subscription","commits_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/contents/{+path}","compare_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/merges","archive_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/downloads","issues_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues{/number}","pulls_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls{/number}","milestones_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/milestones{/number}","notifications_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/labels{/name}","releases_url":"https://api.github.com/repos/matsumoto-r/mruby-http2/releases{/id}","created_at":"2013-12-31T10:58:16Z","updated_at":"2015-11-10T08:09:40Z","pushed_at":"2015-11-14T21:06:45Z","git_url":"git://github.com/matsumoto-r/mruby-http2.git","ssh_url":"git@github.com:matsumoto-r/mruby-http2.git","clone_url":"https://github.com/matsumoto-r/mruby-http2.git","svn_url":"https://github.com/matsumoto-r/mruby-http2","homepage":"","size":2468,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35"},"html":{"href":"https://github.com/matsumoto-r/mruby-http2/pull/35"},"issue":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/35"},"comments":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/matsumoto-r/mruby-http2/statuses/9f0ea49ab1d23876f73d963549eb71e93286a59a"}}}}