{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/22510634","id":22510634,"diff_hunk":"@@ -2,8 +2,8 @@\n require 'open3'\n \n Puppet::Type.type(:reboot).provide :windows do\n-  confine :operatingsystem => :windows\n-  defaultfor :operatingsystem => :windows\n+  confine :kernel => :windows\n+  defaultfor :kernel => :windows","path":"lib/puppet/provider/reboot/windows.rb","position":7,"original_position":7,"commit_id":"f8fea0b96b44a4b0be1083f965b4232b22ca33ee","original_commit_id":"cb56e817dd6f80e460a55a4672f56fe50219da7a","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"body":"I can revert it if you think it's worth doing but it seemed to make sense to leave it in for parity with the Linux provider, plus the fact that it shouldn't cause any change in behavior.  The acceptance tests validated that it works, by my understanding.  Thoughts?","created_at":"2015-01-06T06:42:18Z","updated_at":"2015-01-06T06:42:18Z","html_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57#discussion_r22510634","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/22510634"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57#discussion_r22510634"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57","id":25390240,"html_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57","diff_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/57","number":57,"state":"closed","locked":false,"title":"Add Linux support","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"body":"This adds a basic Linux provider, as requested in [MODULES-1560](https://tickets.puppetlabs.com/browse/MODULES-1560).  It does not presently update the spec tests to handle that.  Suggestions on which tests to look at fixing are welcome.","created_at":"2014-12-03T01:43:26Z","updated_at":"2015-01-06T06:42:18Z","closed_at":"2014-12-26T19:02:18Z","merged_at":"2014-12-26T19:02:18Z","merge_commit_sha":"16fdacb330054aaf836925e95141fe49052c7dc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/57/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/f8fea0b96b44a4b0be1083f965b4232b22ca33ee","head":{"label":"elyscape:linux_support","ref":"linux_support","sha":"f8fea0b96b44a4b0be1083f965b4232b22ca33ee","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"repo":{"id":27152756,"name":"puppetlabs-reboot","full_name":"elyscape/puppetlabs-reboot","owner":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elyscape/puppetlabs-reboot","description":"Reboot type and provider","fork":true,"url":"https://api.github.com/repos/elyscape/puppetlabs-reboot","forks_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/forks","keys_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/teams","hooks_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/hooks","issue_events_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/issues/events{/number}","events_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/events","assignees_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/assignees{/user}","branches_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/branches{/branch}","tags_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/tags","blobs_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/statuses/{sha}","languages_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/languages","stargazers_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/stargazers","contributors_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/contributors","subscribers_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/subscribers","subscription_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/subscription","commits_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/issues/comments/{number}","contents_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/contents/{+path}","compare_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/merges","archive_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/downloads","issues_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/issues{/number}","pulls_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/pulls{/number}","milestones_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/milestones{/number}","notifications_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/labels{/name}","releases_url":"https://api.github.com/repos/elyscape/puppetlabs-reboot/releases{/id}","created_at":"2014-11-26T00:32:35Z","updated_at":"2015-01-06T05:34:01Z","pushed_at":"2015-01-06T06:35:51Z","git_url":"git://github.com/elyscape/puppetlabs-reboot.git","ssh_url":"git@github.com:elyscape/puppetlabs-reboot.git","clone_url":"https://github.com/elyscape/puppetlabs-reboot.git","svn_url":"https://github.com/elyscape/puppetlabs-reboot","homepage":null,"size":430,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9ec01930c975e02c97c72636e57ab3b2d5161362","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":8871577,"name":"puppetlabs-reboot","full_name":"puppetlabs/puppetlabs-reboot","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-reboot","description":"Reboot type and provider","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/releases{/id}","created_at":"2013-03-19T05:35:15Z","updated_at":"2014-12-29T22:58:29Z","pushed_at":"2014-12-29T22:58:29Z","git_url":"git://github.com/puppetlabs/puppetlabs-reboot.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-reboot.git","clone_url":"https://github.com/puppetlabs/puppetlabs-reboot.git","svn_url":"https://github.com/puppetlabs/puppetlabs-reboot","homepage":null,"size":919,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-reboot/pull/57"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/57"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/f8fea0b96b44a4b0be1083f965b4232b22ca33ee"}}}}