{"action":"created","comment":{"url":"https://api.github.com/repos/CommBank/parlour/pulls/comments/30205509","id":30205509,"diff_hunk":"@@ -74,122 +65,64 @@ class ExportSqoopSpec  extends ThermometerSpec with ExportDb { def is = s2\"\"\"\n     .inputFieldsTerminatedBy('|')\n     .hadoopMapRedHome(System.getProperty(\"user.home\") + \"/.ivy2/cache\")\n \n-\n-  object jobTest {\n-    def endToEndJob =\n-      withEnvironment(path(resourceUrl.toString)) {\n-        val expected = newData ++ oldData\n-\n-        val table = tableSetup(oldData)\n-        val dsl = createDsl(table)\n-\n-        val source = Csv(exportDir, \"|\").createTap(Read)\n-        val sink   = TableTap(dsl.toSqoopOptions)\n-        val job    = new ExportSqoopJob(dsl, source, sink)(scaldingArgs)\n-\n-        job.runsOk\n-        tableData(table) must containTheSameElementsAs(expected)\n-      }\n-\n-    def failingJob =\n-      withEnvironment(path(resourceUrl.toString)) {\n-        val dsl = createDsl(\"INVALID\")\n-\n-        val source   = Csv(exportDir).createTap(Read)\n-        val sink = TableTap(dsl.toSqoopOptions)\n-        val job    = new SquishExceptionsExportSqoopJob(dsl, source, sink)(scaldingArgs)\n-        (new VerifiableJob(job)).run must_== Some(s\"Job failed to run <${job.name}>\".left)\n-      }\n-\n-    def exceptionalJob =\n-      withEnvironment(path(resourceUrl.toString)) {\n-        val dsl = createDsl(\"INVALID\")\n-\n-        val source   = Csv(exportDir).createTap(Read)\n-        val sink = TableTap(dsl.toSqoopOptions)\n-        val job    = new ExportSqoopJob(dsl, source, sink)(scaldingArgs)\n-        (new VerifiableJob(job)).run must beLike { case Some(\\/-(_)) => ok }\n-      }\n+  def endToEndConsole = withEnvironment(path(resourceUrl.toString)) {\n+    val expected = newData ++ oldData\n+    val table    = tableSetup(oldData)\n+    val dsl      = createDsl(table)\n+    val args     = Map(\n+      \"connection-string\"     -> connectionString,\n+      \"username\"              -> username,\n+      \"password\"              -> password,\n+      \"table-name\"            -> table,\n+      \"export-dir\"            -> exportDir,\n+      \"mappers\"               -> \"1\",\n+      \"input-field-delimiter\" -> \"|\",\n+      \"hadoop-mapred-home\"    -> dsl.getHadoopMapRedHome.get\n+    )\n+\n+    executesOk(ExportSqoopConsoleJob.job, args.mapValues(List(_)))\n+    tableData(table) must containTheSameElementsAs(expected)\n   }\n+  def endToEndExecution = withEnvironment(path(resourceUrl.toString)) {\n+    val expected = newData ++ oldData\n \n-  object flowTest {\n-    def endToEndFlow =\n-      withEnvironment(path(resourceUrl.toString)) {\n-        val expected = newData ++ oldData\n-        val table = tableSetup(oldData)\n-        val dsl = createDsl(table)\n-\n-        val source = Csv(exportDir, \"|\").createTap(Read)\n-        val sink   = TableTap(dsl.toSqoopOptions)\n-        val flow   = new ExportSqoopFlow(\"endToEndFlow\", dsl, Some(source), Some(sink))\n+    val table = tableSetup(oldData)\n+    val dsl = createDsl(table)","path":"src/test/scala/au/com/cba/omnia/parlour/ExportSqoopSpec.scala","position":null,"original_position":120,"commit_id":"fbf98124318d8c1aaeff4ebe1d340a320cd8de5c","original_commit_id":"a0e1cb97dc104cb565522b47fa2d6c73a6f08d4b","user":{"login":"stephanh","id":376868,"avatar_url":"https://avatars.githubusercontent.com/u/376868?v=3","gravatar_id":"","url":"https://api.github.com/users/stephanh","html_url":"https://github.com/stephanh","followers_url":"https://api.github.com/users/stephanh/followers","following_url":"https://api.github.com/users/stephanh/following{/other_user}","gists_url":"https://api.github.com/users/stephanh/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanh/subscriptions","organizations_url":"https://api.github.com/users/stephanh/orgs","repos_url":"https://api.github.com/users/stephanh/repos","events_url":"https://api.github.com/users/stephanh/events{/privacy}","received_events_url":"https://api.github.com/users/stephanh/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-05-13T06:38:12Z","updated_at":"2015-05-13T06:38:12Z","html_url":"https://github.com/CommBank/parlour/pull/66#discussion_r30205509","pull_request_url":"https://api.github.com/repos/CommBank/parlour/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/comments/30205509"},"html":{"href":"https://github.com/CommBank/parlour/pull/66#discussion_r30205509"},"pull_request":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/CommBank/parlour/pulls/66","id":35296496,"html_url":"https://github.com/CommBank/parlour/pull/66","diff_url":"https://github.com/CommBank/parlour/pull/66.diff","patch_url":"https://github.com/CommBank/parlour/pull/66.patch","issue_url":"https://api.github.com/repos/CommBank/parlour/issues/66","number":66,"state":"open","locked":false,"title":"Removes the old Job/Flow API","user":{"login":"stephanh","id":376868,"avatar_url":"https://avatars.githubusercontent.com/u/376868?v=3","gravatar_id":"","url":"https://api.github.com/users/stephanh","html_url":"https://github.com/stephanh","followers_url":"https://api.github.com/users/stephanh/followers","following_url":"https://api.github.com/users/stephanh/following{/other_user}","gists_url":"https://api.github.com/users/stephanh/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanh/subscriptions","organizations_url":"https://api.github.com/users/stephanh/orgs","repos_url":"https://api.github.com/users/stephanh/repos","events_url":"https://api.github.com/users/stephanh/events{/privacy}","received_events_url":"https://api.github.com/users/stephanh/received_events","type":"User","site_admin":false},"body":"This PR removes the old Job/Flow API in preparation for the Scala 2.11 upgrade where Thermometer no longer jobs Scalding Jobs/Flows.\r\n\r\n* Adds tests for the existing console jobs\r\n* Changes the console jobs to use execution API as backend\r\n* Removes the old Job/Flow based API.\r\n\r\nThis closes #65.","created_at":"2015-05-13T05:59:01Z","updated_at":"2015-05-13T06:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9641abd87fdcf674488c156ba4eb5a0d3fa49e82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CommBank/parlour/pulls/66/commits","review_comments_url":"https://api.github.com/repos/CommBank/parlour/pulls/66/comments","review_comment_url":"https://api.github.com/repos/CommBank/parlour/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CommBank/parlour/issues/66/comments","statuses_url":"https://api.github.com/repos/CommBank/parlour/statuses/fbf98124318d8c1aaeff4ebe1d340a320cd8de5c","head":{"label":"CommBank:execution","ref":"execution","sha":"fbf98124318d8c1aaeff4ebe1d340a320cd8de5c","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":18421649,"name":"parlour","full_name":"CommBank/parlour","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/parlour","description":"A Cascading-Sqoop Integration","fork":false,"url":"https://api.github.com/repos/CommBank/parlour","forks_url":"https://api.github.com/repos/CommBank/parlour/forks","keys_url":"https://api.github.com/repos/CommBank/parlour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/parlour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/parlour/teams","hooks_url":"https://api.github.com/repos/CommBank/parlour/hooks","issue_events_url":"https://api.github.com/repos/CommBank/parlour/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/parlour/events","assignees_url":"https://api.github.com/repos/CommBank/parlour/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/parlour/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/parlour/tags","blobs_url":"https://api.github.com/repos/CommBank/parlour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/parlour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/parlour/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/parlour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/parlour/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/parlour/languages","stargazers_url":"https://api.github.com/repos/CommBank/parlour/stargazers","contributors_url":"https://api.github.com/repos/CommBank/parlour/contributors","subscribers_url":"https://api.github.com/repos/CommBank/parlour/subscribers","subscription_url":"https://api.github.com/repos/CommBank/parlour/subscription","commits_url":"https://api.github.com/repos/CommBank/parlour/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/parlour/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/parlour/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/parlour/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/parlour/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/parlour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/parlour/merges","archive_url":"https://api.github.com/repos/CommBank/parlour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/parlour/downloads","issues_url":"https://api.github.com/repos/CommBank/parlour/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/parlour/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/parlour/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/parlour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/parlour/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/parlour/releases{/id}","created_at":"2014-04-03T23:35:44Z","updated_at":"2015-03-26T03:57:55Z","pushed_at":"2015-05-13T06:38:10Z","git_url":"git://github.com/CommBank/parlour.git","ssh_url":"git@github.com:CommBank/parlour.git","clone_url":"https://github.com/CommBank/parlour.git","svn_url":"https://github.com/CommBank/parlour","homepage":"http://commbank.github.io/parlour/","size":3871,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"CommBank:master","ref":"master","sha":"18bc8d986ec325cf54979c941b5f50d63deec354","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":18421649,"name":"parlour","full_name":"CommBank/parlour","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/parlour","description":"A Cascading-Sqoop Integration","fork":false,"url":"https://api.github.com/repos/CommBank/parlour","forks_url":"https://api.github.com/repos/CommBank/parlour/forks","keys_url":"https://api.github.com/repos/CommBank/parlour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/parlour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/parlour/teams","hooks_url":"https://api.github.com/repos/CommBank/parlour/hooks","issue_events_url":"https://api.github.com/repos/CommBank/parlour/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/parlour/events","assignees_url":"https://api.github.com/repos/CommBank/parlour/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/parlour/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/parlour/tags","blobs_url":"https://api.github.com/repos/CommBank/parlour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/parlour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/parlour/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/parlour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/parlour/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/parlour/languages","stargazers_url":"https://api.github.com/repos/CommBank/parlour/stargazers","contributors_url":"https://api.github.com/repos/CommBank/parlour/contributors","subscribers_url":"https://api.github.com/repos/CommBank/parlour/subscribers","subscription_url":"https://api.github.com/repos/CommBank/parlour/subscription","commits_url":"https://api.github.com/repos/CommBank/parlour/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/parlour/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/parlour/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/parlour/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/parlour/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/parlour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/parlour/merges","archive_url":"https://api.github.com/repos/CommBank/parlour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/parlour/downloads","issues_url":"https://api.github.com/repos/CommBank/parlour/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/parlour/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/parlour/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/parlour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/parlour/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/parlour/releases{/id}","created_at":"2014-04-03T23:35:44Z","updated_at":"2015-03-26T03:57:55Z","pushed_at":"2015-05-13T06:38:10Z","git_url":"git://github.com/CommBank/parlour.git","ssh_url":"git@github.com:CommBank/parlour.git","clone_url":"https://github.com/CommBank/parlour.git","svn_url":"https://github.com/CommBank/parlour","homepage":"http://commbank.github.io/parlour/","size":3871,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/66"},"html":{"href":"https://github.com/CommBank/parlour/pull/66"},"issue":{"href":"https://api.github.com/repos/CommBank/parlour/issues/66"},"comments":{"href":"https://api.github.com/repos/CommBank/parlour/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CommBank/parlour/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/CommBank/parlour/statuses/fbf98124318d8c1aaeff4ebe1d340a320cd8de5c"}}}}