{"action":"created","comment":{"url":"https://api.github.com/repos/godbus/dbus/pulls/comments/23387000","id":23387000,"diff_hunk":"@@ -0,0 +1,490 @@\n+package dbus_test","path":"signal_test.go","position":1,"original_position":1,"commit_id":"9e23ddcc5814dbb8a62d055b414637cdfcb8ecea","original_commit_id":"9e23ddcc5814dbb8a62d055b414637cdfcb8ecea","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"This should be `package dbus`","created_at":"2015-01-22T16:19:02Z","updated_at":"2015-01-22T16:19:02Z","html_url":"https://github.com/godbus/dbus/pull/12#discussion_r23387000","pull_request_url":"https://api.github.com/repos/godbus/dbus/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/godbus/dbus/pulls/comments/23387000"},"html":{"href":"https://github.com/godbus/dbus/pull/12#discussion_r23387000"},"pull_request":{"href":"https://api.github.com/repos/godbus/dbus/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/godbus/dbus/pulls/12","id":27853917,"html_url":"https://github.com/godbus/dbus/pull/12","diff_url":"https://github.com/godbus/dbus/pull/12.diff","patch_url":"https://github.com/godbus/dbus/pull/12.patch","issue_url":"https://api.github.com/repos/godbus/dbus/issues/12","number":12,"state":"open","locked":false,"title":"Fix signal related contentions and bugs","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"This PR is to fix issue #8.\r\n\r\nFirst commit adds a bunch of tests for testing contentions. Also, while working on this issue I noticed that Signal function does not behave as it should, so I added tests for it as well.\r\n\r\nSecond commit should fix the contentions.\r\n\r\nThird commit should fix the signal watchers adding and removing, so all the tests I've added in first commit pass.\r\n\r\nFourth commit is there, because \"appropriate\" is hard to type. :)","created_at":"2015-01-22T16:06:49Z","updated_at":"2015-01-22T16:19:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ff497b87e7e13881eec461b815f163b20589d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/godbus/dbus/pulls/12/commits","review_comments_url":"https://api.github.com/repos/godbus/dbus/pulls/12/comments","review_comment_url":"https://api.github.com/repos/godbus/dbus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/godbus/dbus/issues/12/comments","statuses_url":"https://api.github.com/repos/godbus/dbus/statuses/9e23ddcc5814dbb8a62d055b414637cdfcb8ecea","head":{"label":"endocode:krnowak/contention-fix","ref":"krnowak/contention-fix","sha":"9e23ddcc5814dbb8a62d055b414637cdfcb8ecea","user":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"repo":{"id":29535551,"name":"dbus","full_name":"endocode/dbus","owner":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endocode/dbus","description":"Native Go bindings for D-Bus","fork":true,"url":"https://api.github.com/repos/endocode/dbus","forks_url":"https://api.github.com/repos/endocode/dbus/forks","keys_url":"https://api.github.com/repos/endocode/dbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endocode/dbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endocode/dbus/teams","hooks_url":"https://api.github.com/repos/endocode/dbus/hooks","issue_events_url":"https://api.github.com/repos/endocode/dbus/issues/events{/number}","events_url":"https://api.github.com/repos/endocode/dbus/events","assignees_url":"https://api.github.com/repos/endocode/dbus/assignees{/user}","branches_url":"https://api.github.com/repos/endocode/dbus/branches{/branch}","tags_url":"https://api.github.com/repos/endocode/dbus/tags","blobs_url":"https://api.github.com/repos/endocode/dbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endocode/dbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endocode/dbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/endocode/dbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endocode/dbus/statuses/{sha}","languages_url":"https://api.github.com/repos/endocode/dbus/languages","stargazers_url":"https://api.github.com/repos/endocode/dbus/stargazers","contributors_url":"https://api.github.com/repos/endocode/dbus/contributors","subscribers_url":"https://api.github.com/repos/endocode/dbus/subscribers","subscription_url":"https://api.github.com/repos/endocode/dbus/subscription","commits_url":"https://api.github.com/repos/endocode/dbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/endocode/dbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/endocode/dbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/endocode/dbus/issues/comments/{number}","contents_url":"https://api.github.com/repos/endocode/dbus/contents/{+path}","compare_url":"https://api.github.com/repos/endocode/dbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endocode/dbus/merges","archive_url":"https://api.github.com/repos/endocode/dbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endocode/dbus/downloads","issues_url":"https://api.github.com/repos/endocode/dbus/issues{/number}","pulls_url":"https://api.github.com/repos/endocode/dbus/pulls{/number}","milestones_url":"https://api.github.com/repos/endocode/dbus/milestones{/number}","notifications_url":"https://api.github.com/repos/endocode/dbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endocode/dbus/labels{/name}","releases_url":"https://api.github.com/repos/endocode/dbus/releases{/id}","created_at":"2015-01-20T15:07:00Z","updated_at":"2015-01-20T15:07:00Z","pushed_at":"2015-01-22T16:00:26Z","git_url":"git://github.com/endocode/dbus.git","ssh_url":"git@github.com:endocode/dbus.git","clone_url":"https://github.com/endocode/dbus.git","svn_url":"https://github.com/endocode/dbus","homepage":"","size":424,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godbus:master","ref":"master","sha":"25a4b8ca48c64b3d631110fb74a210f56c401e0b","user":{"login":"godbus","id":7084884,"avatar_url":"https://avatars.githubusercontent.com/u/7084884?v=3","gravatar_id":"","url":"https://api.github.com/users/godbus","html_url":"https://github.com/godbus","followers_url":"https://api.github.com/users/godbus/followers","following_url":"https://api.github.com/users/godbus/following{/other_user}","gists_url":"https://api.github.com/users/godbus/gists{/gist_id}","starred_url":"https://api.github.com/users/godbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godbus/subscriptions","organizations_url":"https://api.github.com/users/godbus/orgs","repos_url":"https://api.github.com/users/godbus/repos","events_url":"https://api.github.com/users/godbus/events{/privacy}","received_events_url":"https://api.github.com/users/godbus/received_events","type":"Organization","site_admin":false},"repo":{"id":18187912,"name":"dbus","full_name":"godbus/dbus","owner":{"login":"godbus","id":7084884,"avatar_url":"https://avatars.githubusercontent.com/u/7084884?v=3","gravatar_id":"","url":"https://api.github.com/users/godbus","html_url":"https://github.com/godbus","followers_url":"https://api.github.com/users/godbus/followers","following_url":"https://api.github.com/users/godbus/following{/other_user}","gists_url":"https://api.github.com/users/godbus/gists{/gist_id}","starred_url":"https://api.github.com/users/godbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godbus/subscriptions","organizations_url":"https://api.github.com/users/godbus/orgs","repos_url":"https://api.github.com/users/godbus/repos","events_url":"https://api.github.com/users/godbus/events{/privacy}","received_events_url":"https://api.github.com/users/godbus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godbus/dbus","description":"Native Go bindings for D-Bus","fork":true,"url":"https://api.github.com/repos/godbus/dbus","forks_url":"https://api.github.com/repos/godbus/dbus/forks","keys_url":"https://api.github.com/repos/godbus/dbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godbus/dbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godbus/dbus/teams","hooks_url":"https://api.github.com/repos/godbus/dbus/hooks","issue_events_url":"https://api.github.com/repos/godbus/dbus/issues/events{/number}","events_url":"https://api.github.com/repos/godbus/dbus/events","assignees_url":"https://api.github.com/repos/godbus/dbus/assignees{/user}","branches_url":"https://api.github.com/repos/godbus/dbus/branches{/branch}","tags_url":"https://api.github.com/repos/godbus/dbus/tags","blobs_url":"https://api.github.com/repos/godbus/dbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godbus/dbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godbus/dbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/godbus/dbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godbus/dbus/statuses/{sha}","languages_url":"https://api.github.com/repos/godbus/dbus/languages","stargazers_url":"https://api.github.com/repos/godbus/dbus/stargazers","contributors_url":"https://api.github.com/repos/godbus/dbus/contributors","subscribers_url":"https://api.github.com/repos/godbus/dbus/subscribers","subscription_url":"https://api.github.com/repos/godbus/dbus/subscription","commits_url":"https://api.github.com/repos/godbus/dbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/godbus/dbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/godbus/dbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/godbus/dbus/issues/comments/{number}","contents_url":"https://api.github.com/repos/godbus/dbus/contents/{+path}","compare_url":"https://api.github.com/repos/godbus/dbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godbus/dbus/merges","archive_url":"https://api.github.com/repos/godbus/dbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godbus/dbus/downloads","issues_url":"https://api.github.com/repos/godbus/dbus/issues{/number}","pulls_url":"https://api.github.com/repos/godbus/dbus/pulls{/number}","milestones_url":"https://api.github.com/repos/godbus/dbus/milestones{/number}","notifications_url":"https://api.github.com/repos/godbus/dbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godbus/dbus/labels{/name}","releases_url":"https://api.github.com/repos/godbus/dbus/releases{/id}","created_at":"2014-03-27T19:07:41Z","updated_at":"2015-01-17T07:44:14Z","pushed_at":"2014-10-07T18:58:35Z","git_url":"git://github.com/godbus/dbus.git","ssh_url":"git@github.com:godbus/dbus.git","clone_url":"https://github.com/godbus/dbus.git","svn_url":"https://github.com/godbus/dbus","homepage":"","size":637,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godbus/dbus/pulls/12"},"html":{"href":"https://github.com/godbus/dbus/pull/12"},"issue":{"href":"https://api.github.com/repos/godbus/dbus/issues/12"},"comments":{"href":"https://api.github.com/repos/godbus/dbus/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/godbus/dbus/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/godbus/dbus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/godbus/dbus/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/godbus/dbus/statuses/9e23ddcc5814dbb8a62d055b414637cdfcb8ecea"}}}}