{"action":"created","issue":{"url":"https://api.github.com/repos/google/grr/issues/257","labels_url":"https://api.github.com/repos/google/grr/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/google/grr/issues/257/comments","events_url":"https://api.github.com/repos/google/grr/issues/257/events","html_url":"https://github.com/google/grr/issues/257","id":107792863,"number":257,"title":"Don't pass the approval reason in HTTP headers","user":{"login":"destijl","id":1291767,"avatar_url":"https://avatars.githubusercontent.com/u/1291767?v=3","gravatar_id":"","url":"https://api.github.com/users/destijl","html_url":"https://github.com/destijl","followers_url":"https://api.github.com/users/destijl/followers","following_url":"https://api.github.com/users/destijl/following{/other_user}","gists_url":"https://api.github.com/users/destijl/gists{/gist_id}","starred_url":"https://api.github.com/users/destijl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destijl/subscriptions","organizations_url":"https://api.github.com/users/destijl/orgs","repos_url":"https://api.github.com/users/destijl/repos","events_url":"https://api.github.com/users/destijl/events{/privacy}","received_events_url":"https://api.github.com/users/destijl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/grr/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T20:17:21Z","updated_at":"2015-09-22T20:38:27Z","closed_at":null,"body":"Currently we pass the approval reason in HTTP headers for POST and as a URL parameter for GETs.\r\nhttps://github.com/google/grr/blob/4b7f9b06d1dfebd3dc86a6fa2eb7592f233b5330/gui/http_api.py#L34\r\n\r\nWe should remove the need to pass the reason at all and just let the server find the approval for the machine/hunt and user."},"comment":{"url":"https://api.github.com/repos/google/grr/issues/comments/142412804","html_url":"https://github.com/google/grr/issues/257#issuecomment-142412804","issue_url":"https://api.github.com/repos/google/grr/issues/257","id":142412804,"user":{"login":"scudette","id":3856546,"avatar_url":"https://avatars.githubusercontent.com/u/3856546?v=3","gravatar_id":"","url":"https://api.github.com/users/scudette","html_url":"https://github.com/scudette","followers_url":"https://api.github.com/users/scudette/followers","following_url":"https://api.github.com/users/scudette/following{/other_user}","gists_url":"https://api.github.com/users/scudette/gists{/gist_id}","starred_url":"https://api.github.com/users/scudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scudette/subscriptions","organizations_url":"https://api.github.com/users/scudette/orgs","repos_url":"https://api.github.com/users/scudette/repos","events_url":"https://api.github.com/users/scudette/events{/privacy}","received_events_url":"https://api.github.com/users/scudette/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T20:38:27Z","updated_at":"2015-09-22T20:38:27Z","body":"We should never pass anything in a header since custom headers are often stripped depending on environment. Maybe put it in a cookie?"}}