{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/comments/24365736","id":24365736,"diff_hunk":"@@ -1,26 +1,39 @@\n #\n-class mysql::server::service {\n+class mysql::server::service (\n+  $real_service_manage  = $mysql::server::real_service_manage,\n+  $manage_config_file   = $mysql::server::manage_config_file,\n+  $real_service_enabled = $mysql::server::real_service_enabled,\n+  $log_error            = $mysql::params::log_error,\n+  $service_name         = $mysql::server::service_name,\n+  $service_provider     = $mysql::server::service_provider\n+) inherits mysql::params {","path":"manifests/server/service.pp","position":10,"original_position":10,"commit_id":"b5d696c70601d5819ca21ad80791ea2e85835a12","original_commit_id":"b5d696c70601d5819ca21ad80791ea2e85835a12","user":{"login":"mhaskel","id":553464,"avatar_url":"https://avatars.githubusercontent.com/u/553464?v=3","gravatar_id":"","url":"https://api.github.com/users/mhaskel","html_url":"https://github.com/mhaskel","followers_url":"https://api.github.com/users/mhaskel/followers","following_url":"https://api.github.com/users/mhaskel/following{/other_user}","gists_url":"https://api.github.com/users/mhaskel/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaskel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaskel/subscriptions","organizations_url":"https://api.github.com/users/mhaskel/orgs","repos_url":"https://api.github.com/users/mhaskel/repos","events_url":"https://api.github.com/users/mhaskel/events{/privacy}","received_events_url":"https://api.github.com/users/mhaskel/received_events","type":"User","site_admin":false},"body":"Revert these changes.","created_at":"2015-02-09T21:12:00Z","updated_at":"2015-02-09T21:12:00Z","html_url":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653#discussion_r24365736","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/comments/24365736"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653#discussion_r24365736"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653","id":28185254,"html_url":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653","diff_url":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/653","number":653,"state":"open","locked":false,"title":"fix config requirement","user":{"login":"CharlieR-o-o-t","id":9932208,"avatar_url":"https://avatars.githubusercontent.com/u/9932208?v=3","gravatar_id":"","url":"https://api.github.com/users/CharlieR-o-o-t","html_url":"https://github.com/CharlieR-o-o-t","followers_url":"https://api.github.com/users/CharlieR-o-o-t/followers","following_url":"https://api.github.com/users/CharlieR-o-o-t/following{/other_user}","gists_url":"https://api.github.com/users/CharlieR-o-o-t/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieR-o-o-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieR-o-o-t/subscriptions","organizations_url":"https://api.github.com/users/CharlieR-o-o-t/orgs","repos_url":"https://api.github.com/users/CharlieR-o-o-t/repos","events_url":"https://api.github.com/users/CharlieR-o-o-t/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieR-o-o-t/received_events","type":"User","site_admin":false},"body":"used variables at service.pp is not at visible scope\r\n\r\nconfig requirements should absent in cases if config file unmanaged.  ","created_at":"2015-01-28T11:12:41Z","updated_at":"2015-02-09T21:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"881e9f788f02f8f4c8785f15ec69ff08a1ff33ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/653/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/statuses/b5d696c70601d5819ca21ad80791ea2e85835a12","head":{"label":"CharlieR-o-o-t:fix_config_req","ref":"fix_config_req","sha":"b5d696c70601d5819ca21ad80791ea2e85835a12","user":{"login":"CharlieR-o-o-t","id":9932208,"avatar_url":"https://avatars.githubusercontent.com/u/9932208?v=3","gravatar_id":"","url":"https://api.github.com/users/CharlieR-o-o-t","html_url":"https://github.com/CharlieR-o-o-t","followers_url":"https://api.github.com/users/CharlieR-o-o-t/followers","following_url":"https://api.github.com/users/CharlieR-o-o-t/following{/other_user}","gists_url":"https://api.github.com/users/CharlieR-o-o-t/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieR-o-o-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieR-o-o-t/subscriptions","organizations_url":"https://api.github.com/users/CharlieR-o-o-t/orgs","repos_url":"https://api.github.com/users/CharlieR-o-o-t/repos","events_url":"https://api.github.com/users/CharlieR-o-o-t/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieR-o-o-t/received_events","type":"User","site_admin":false},"repo":{"id":29957690,"name":"puppetlabs-mysql","full_name":"CharlieR-o-o-t/puppetlabs-mysql","owner":{"login":"CharlieR-o-o-t","id":9932208,"avatar_url":"https://avatars.githubusercontent.com/u/9932208?v=3","gravatar_id":"","url":"https://api.github.com/users/CharlieR-o-o-t","html_url":"https://github.com/CharlieR-o-o-t","followers_url":"https://api.github.com/users/CharlieR-o-o-t/followers","following_url":"https://api.github.com/users/CharlieR-o-o-t/following{/other_user}","gists_url":"https://api.github.com/users/CharlieR-o-o-t/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieR-o-o-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieR-o-o-t/subscriptions","organizations_url":"https://api.github.com/users/CharlieR-o-o-t/orgs","repos_url":"https://api.github.com/users/CharlieR-o-o-t/repos","events_url":"https://api.github.com/users/CharlieR-o-o-t/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieR-o-o-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CharlieR-o-o-t/puppetlabs-mysql","description":"MySQL Puppet Module / Manifests + Types & Providers","fork":true,"url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql","forks_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/forks","keys_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/teams","hooks_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/hooks","issue_events_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/events","assignees_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/tags","blobs_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/languages","stargazers_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/stargazers","contributors_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/contributors","subscribers_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/subscribers","subscription_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/subscription","commits_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/issues/comments/{number}","contents_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/merges","archive_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/downloads","issues_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/labels{/name}","releases_url":"https://api.github.com/repos/CharlieR-o-o-t/puppetlabs-mysql/releases{/id}","created_at":"2015-01-28T08:26:45Z","updated_at":"2015-01-28T08:26:46Z","pushed_at":"2015-01-28T08:56:22Z","git_url":"git://github.com/CharlieR-o-o-t/puppetlabs-mysql.git","ssh_url":"git@github.com:CharlieR-o-o-t/puppetlabs-mysql.git","clone_url":"https://github.com/CharlieR-o-o-t/puppetlabs-mysql.git","svn_url":"https://github.com/CharlieR-o-o-t/puppetlabs-mysql","homepage":"","size":1085,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"74e19691a241ebc99a8bb5936903215bff4a7ae7","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1797486,"name":"puppetlabs-mysql","full_name":"puppetlabs/puppetlabs-mysql","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-mysql","description":"MySQL Puppet Module / Manifests + Types & Providers","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/releases{/id}","created_at":"2011-05-25T06:10:41Z","updated_at":"2015-02-06T21:51:14Z","pushed_at":"2015-02-06T21:51:14Z","git_url":"git://github.com/puppetlabs/puppetlabs-mysql.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-mysql.git","clone_url":"https://github.com/puppetlabs/puppetlabs-mysql.git","svn_url":"https://github.com/puppetlabs/puppetlabs-mysql","homepage":"","size":3858,"stargazers_count":332,"watchers_count":332,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":69,"forks":518,"open_issues":69,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-mysql/pull/653"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/653"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/issues/653/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/pulls/653/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-mysql/statuses/b5d696c70601d5819ca21ad80791ea2e85835a12"}}}}