{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3","id":28544744,"html_url":"https://github.com/target/f5-bigip-cookbook/pull/3","diff_url":"https://github.com/target/f5-bigip-cookbook/pull/3.diff","patch_url":"https://github.com/target/f5-bigip-cookbook/pull/3.patch","issue_url":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/3","number":3,"state":"closed","locked":false,"title":"Add support for non-ip node name to f5_ltm_node","user":{"login":"sunruh","id":4139965,"avatar_url":"https://avatars.githubusercontent.com/u/4139965?v=3","gravatar_id":"","url":"https://api.github.com/users/sunruh","html_url":"https://github.com/sunruh","followers_url":"https://api.github.com/users/sunruh/followers","following_url":"https://api.github.com/users/sunruh/following{/other_user}","gists_url":"https://api.github.com/users/sunruh/gists{/gist_id}","starred_url":"https://api.github.com/users/sunruh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunruh/subscriptions","organizations_url":"https://api.github.com/users/sunruh/orgs","repos_url":"https://api.github.com/users/sunruh/repos","events_url":"https://api.github.com/users/sunruh/events{/privacy}","received_events_url":"https://api.github.com/users/sunruh/received_events","type":"User","site_admin":false},"body":"Currently, the `node_name` attribute of a `f5_ltm_node` resource is used as the ip address and object name for the node to create in LTM. It is not possible to create nodes with a name other than the ip address.\r\n\r\nTo allow the creation of nodes with object names differing from the ip address, the following would have to be done:\r\n* Add `address` attribute to `f5_ltm_node` resource, defaulting to `node_name` for backward compatibility\r\n* Change call of `client['LocalLB.NodeAddressV2'].create` to use the new attribute\r\n* Document new attribute\r\n* Change documentation to reflect that the node (object) name must be used as address in `f5_ltm_pool` `members` attribute\r\n* Add documentation to `f5_vip` definition, indicating that it will create node objects in LTM with object name matching ip address","created_at":"2015-02-03T11:25:05Z","updated_at":"2015-02-04T17:27:39Z","closed_at":"2015-02-04T17:27:39Z","merged_at":"2015-02-04T17:27:39Z","merge_commit_sha":"1eb8bf7eed849010db4eefb75015a65075432cd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3/commits","review_comments_url":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3/comments","review_comment_url":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/comments/{number}","comments_url":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/3/comments","statuses_url":"https://api.github.com/repos/target/f5-bigip-cookbook/statuses/1136ad031ada0008313857482d04cc8512dc9a55","head":{"label":"humance:issue-3","ref":"issue-3","sha":"1136ad031ada0008313857482d04cc8512dc9a55","user":{"login":"humance","id":9211406,"avatar_url":"https://avatars.githubusercontent.com/u/9211406?v=3","gravatar_id":"","url":"https://api.github.com/users/humance","html_url":"https://github.com/humance","followers_url":"https://api.github.com/users/humance/followers","following_url":"https://api.github.com/users/humance/following{/other_user}","gists_url":"https://api.github.com/users/humance/gists{/gist_id}","starred_url":"https://api.github.com/users/humance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humance/subscriptions","organizations_url":"https://api.github.com/users/humance/orgs","repos_url":"https://api.github.com/users/humance/repos","events_url":"https://api.github.com/users/humance/events{/privacy}","received_events_url":"https://api.github.com/users/humance/received_events","type":"Organization","site_admin":false},"repo":{"id":30238022,"name":"chef-f5-bigip-cookbook","full_name":"humance/chef-f5-bigip-cookbook","owner":{"login":"humance","id":9211406,"avatar_url":"https://avatars.githubusercontent.com/u/9211406?v=3","gravatar_id":"","url":"https://api.github.com/users/humance","html_url":"https://github.com/humance","followers_url":"https://api.github.com/users/humance/followers","following_url":"https://api.github.com/users/humance/following{/other_user}","gists_url":"https://api.github.com/users/humance/gists{/gist_id}","starred_url":"https://api.github.com/users/humance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humance/subscriptions","organizations_url":"https://api.github.com/users/humance/orgs","repos_url":"https://api.github.com/users/humance/repos","events_url":"https://api.github.com/users/humance/events{/privacy}","received_events_url":"https://api.github.com/users/humance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/humance/chef-f5-bigip-cookbook","description":"Chef cookbook for F5 Big IP","fork":true,"url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook","forks_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/forks","keys_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/teams","hooks_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/hooks","issue_events_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/events","assignees_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/tags","blobs_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/languages","stargazers_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/stargazers","contributors_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/contributors","subscribers_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/subscribers","subscription_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/subscription","commits_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/issues/comments/{number}","contents_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/merges","archive_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/downloads","issues_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/humance/chef-f5-bigip-cookbook/releases{/id}","created_at":"2015-02-03T10:45:03Z","updated_at":"2015-02-03T10:45:20Z","pushed_at":"2015-02-04T15:51:49Z","git_url":"git://github.com/humance/chef-f5-bigip-cookbook.git","ssh_url":"git@github.com:humance/chef-f5-bigip-cookbook.git","clone_url":"https://github.com/humance/chef-f5-bigip-cookbook.git","svn_url":"https://github.com/humance/chef-f5-bigip-cookbook","homepage":null,"size":1817,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"target:master","ref":"master","sha":"1f66e02c155fba0be0bc6584d6733516f7129e4d","user":{"login":"target","id":932489,"avatar_url":"https://avatars.githubusercontent.com/u/932489?v=3","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"repo":{"id":28348460,"name":"f5-bigip-cookbook","full_name":"target/f5-bigip-cookbook","owner":{"login":"target","id":932489,"avatar_url":"https://avatars.githubusercontent.com/u/932489?v=3","gravatar_id":"","url":"https://api.github.com/users/target","html_url":"https://github.com/target","followers_url":"https://api.github.com/users/target/followers","following_url":"https://api.github.com/users/target/following{/other_user}","gists_url":"https://api.github.com/users/target/gists{/gist_id}","starred_url":"https://api.github.com/users/target/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/target/subscriptions","organizations_url":"https://api.github.com/users/target/orgs","repos_url":"https://api.github.com/users/target/repos","events_url":"https://api.github.com/users/target/events{/privacy}","received_events_url":"https://api.github.com/users/target/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/target/f5-bigip-cookbook","description":"Chef cookbook for F5 Big IP","fork":false,"url":"https://api.github.com/repos/target/f5-bigip-cookbook","forks_url":"https://api.github.com/repos/target/f5-bigip-cookbook/forks","keys_url":"https://api.github.com/repos/target/f5-bigip-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/target/f5-bigip-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/target/f5-bigip-cookbook/teams","hooks_url":"https://api.github.com/repos/target/f5-bigip-cookbook/hooks","issue_events_url":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/target/f5-bigip-cookbook/events","assignees_url":"https://api.github.com/repos/target/f5-bigip-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/target/f5-bigip-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/target/f5-bigip-cookbook/tags","blobs_url":"https://api.github.com/repos/target/f5-bigip-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/target/f5-bigip-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/target/f5-bigip-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/target/f5-bigip-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/target/f5-bigip-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/target/f5-bigip-cookbook/languages","stargazers_url":"https://api.github.com/repos/target/f5-bigip-cookbook/stargazers","contributors_url":"https://api.github.com/repos/target/f5-bigip-cookbook/contributors","subscribers_url":"https://api.github.com/repos/target/f5-bigip-cookbook/subscribers","subscription_url":"https://api.github.com/repos/target/f5-bigip-cookbook/subscription","commits_url":"https://api.github.com/repos/target/f5-bigip-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/target/f5-bigip-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/target/f5-bigip-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/comments/{number}","contents_url":"https://api.github.com/repos/target/f5-bigip-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/target/f5-bigip-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/target/f5-bigip-cookbook/merges","archive_url":"https://api.github.com/repos/target/f5-bigip-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/target/f5-bigip-cookbook/downloads","issues_url":"https://api.github.com/repos/target/f5-bigip-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/target/f5-bigip-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/target/f5-bigip-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/target/f5-bigip-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/target/f5-bigip-cookbook/releases{/id}","created_at":"2014-12-22T16:55:29Z","updated_at":"2015-02-03T14:15:46Z","pushed_at":"2015-02-04T17:27:39Z","git_url":"git://github.com/target/f5-bigip-cookbook.git","ssh_url":"git@github.com:target/f5-bigip-cookbook.git","clone_url":"https://github.com/target/f5-bigip-cookbook.git","svn_url":"https://github.com/target/f5-bigip-cookbook","homepage":null,"size":1969,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3"},"html":{"href":"https://github.com/target/f5-bigip-cookbook/pull/3"},"issue":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/3"},"comments":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/target/f5-bigip-cookbook/statuses/1136ad031ada0008313857482d04cc8512dc9a55"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmccann","id":1228349,"avatar_url":"https://avatars.githubusercontent.com/u/1228349?v=3","gravatar_id":"","url":"https://api.github.com/users/jmccann","html_url":"https://github.com/jmccann","followers_url":"https://api.github.com/users/jmccann/followers","following_url":"https://api.github.com/users/jmccann/following{/other_user}","gists_url":"https://api.github.com/users/jmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmccann/subscriptions","organizations_url":"https://api.github.com/users/jmccann/orgs","repos_url":"https://api.github.com/users/jmccann/repos","events_url":"https://api.github.com/users/jmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jmccann/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":34,"deletions":8,"changed_files":3}}