{"action":"created","comment":{"url":"https://api.github.com/repos/docker/distribution/pulls/comments/23176474","id":23176474,"diff_hunk":"@@ -40,28 +40,28 @@ func init() {\n \n type azureDriverFactory struct{}\n \n-func (factory *azureDriverFactory) Create(parameters map[string]string) (storagedriver.StorageDriver, error) {\n+func (factory *azureDriverFactory) Create(parameters map[string]interface{}) (storagedriver.StorageDriver, error) {\n \treturn FromParameters(parameters)\n }\n \n // FromParameters constructs a new Driver with a given parameters map.\n-func FromParameters(parameters map[string]string) (*Driver, error) {\n+func FromParameters(parameters map[string]interface{}) (*Driver, error) {\n \taccountName, ok := parameters[paramAccountName]\n-\tif !ok {\n+\tif !ok || accountName.(string) == \"\" {","path":"storagedriver/azure/azure.go","position":31,"original_position":31,"commit_id":"69476e51879d857329d9fbba38472c7352ea1343","original_commit_id":"69476e51879d857329d9fbba38472c7352ea1343","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"These statements will panic if the contents of the argument is not a string. Please check the type assertion result and report an error.","created_at":"2015-01-19T18:07:46Z","updated_at":"2015-01-19T18:07:46Z","html_url":"https://github.com/docker/distribution/pull/76#discussion_r23176474","pull_request_url":"https://api.github.com/repos/docker/distribution/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments/23176474"},"html":{"href":"https://github.com/docker/distribution/pull/76#discussion_r23176474"},"pull_request":{"href":"https://api.github.com/repos/docker/distribution/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/docker/distribution/pulls/76","id":27567890,"html_url":"https://github.com/docker/distribution/pull/76","diff_url":"https://github.com/docker/distribution/pull/76.diff","patch_url":"https://github.com/docker/distribution/pull/76.patch","issue_url":"https://api.github.com/repos/docker/distribution/issues/76","number":76,"state":"open","locked":false,"title":"Fix Azure storage driver methods, implement Stat","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"Catching up with some recent changes in the storage driver API.\r\n\r\nAdded Stat method, removed CurrentSize and fixed some issues revealed in recent tests.\r\n\r\nSome issues are still remaining:\r\n* #71: time problems in Stat\r\n* Tested with 5 GB blobs, usually works fine. Will work better with #75.\r\n\r\nUncommented relevant parts for the test to be included in the suite when it is set up.\r\ncc: @stevvooe @BrianBland \r\n\r\nSigned-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>","created_at":"2015-01-18T07:02:30Z","updated_at":"2015-01-19T18:07:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cba099c0b4c3d6f8035600fbf737315da46d159","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/distribution/pulls/76/commits","review_comments_url":"https://api.github.com/repos/docker/distribution/pulls/76/comments","review_comment_url":"https://api.github.com/repos/docker/distribution/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/distribution/issues/76/comments","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/69476e51879d857329d9fbba38472c7352ea1343","head":{"label":"ahmetalpbalkan:azure-fixes","ref":"azure-fixes","sha":"69476e51879d857329d9fbba38472c7352ea1343","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"repo":{"id":29375295,"name":"distribution","full_name":"ahmetalpbalkan/distribution","owner":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetalpbalkan/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":true,"url":"https://api.github.com/repos/ahmetalpbalkan/distribution","forks_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/forks","keys_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/teams","hooks_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/hooks","issue_events_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/events","assignees_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/tags","blobs_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/languages","stargazers_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/stargazers","contributors_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/contributors","subscribers_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/subscribers","subscription_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/subscription","commits_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/issues/comments/{number}","contents_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/merges","archive_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/downloads","issues_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/labels{/name}","releases_url":"https://api.github.com/repos/ahmetalpbalkan/distribution/releases{/id}","created_at":"2015-01-17T01:10:37Z","updated_at":"2015-01-18T04:52:14Z","pushed_at":"2015-01-18T22:55:19Z","git_url":"git://github.com/ahmetalpbalkan/distribution.git","ssh_url":"git@github.com:ahmetalpbalkan/distribution.git","clone_url":"https://github.com/ahmetalpbalkan/distribution.git","svn_url":"https://github.com/ahmetalpbalkan/distribution","homepage":null,"size":1873,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"03406ab708a284dd27e64f2157784b65943d882d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":28366058,"name":"distribution","full_name":"docker/distribution","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":false,"url":"https://api.github.com/repos/docker/distribution","forks_url":"https://api.github.com/repos/docker/distribution/forks","keys_url":"https://api.github.com/repos/docker/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/distribution/teams","hooks_url":"https://api.github.com/repos/docker/distribution/hooks","issue_events_url":"https://api.github.com/repos/docker/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/docker/distribution/events","assignees_url":"https://api.github.com/repos/docker/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/docker/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/docker/distribution/tags","blobs_url":"https://api.github.com/repos/docker/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/distribution/languages","stargazers_url":"https://api.github.com/repos/docker/distribution/stargazers","contributors_url":"https://api.github.com/repos/docker/distribution/contributors","subscribers_url":"https://api.github.com/repos/docker/distribution/subscribers","subscription_url":"https://api.github.com/repos/docker/distribution/subscription","commits_url":"https://api.github.com/repos/docker/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/distribution/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/docker/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/distribution/merges","archive_url":"https://api.github.com/repos/docker/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/distribution/downloads","issues_url":"https://api.github.com/repos/docker/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/docker/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/distribution/labels{/name}","releases_url":"https://api.github.com/repos/docker/distribution/releases{/id}","created_at":"2014-12-22T23:49:26Z","updated_at":"2015-01-19T01:22:40Z","pushed_at":"2015-01-16T22:05:16Z","git_url":"git://github.com/docker/distribution.git","ssh_url":"git@github.com:docker/distribution.git","clone_url":"https://github.com/docker/distribution.git","svn_url":"https://github.com/docker/distribution","homepage":null,"size":1873,"stargazers_count":45,"watchers_count":45,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":26,"forks":12,"open_issues":26,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/76"},"html":{"href":"https://github.com/docker/distribution/pull/76"},"issue":{"href":"https://api.github.com/repos/docker/distribution/issues/76"},"comments":{"href":"https://api.github.com/repos/docker/distribution/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/distribution/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/distribution/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/docker/distribution/statuses/69476e51879d857329d9fbba38472c7352ea1343"}}}}