{"action":"created","comment":{"url":"https://api.github.com/repos/mgedmin/objgraph/pulls/comments/25155042","id":25155042,"diff_hunk":"@@ -815,8 +834,10 @@ def gradient(start_color, end_color, depth, max_depth):\n     return h, s, v\n \n \n-def edge_label(source, target, shortnames=True):\n-    if isinstance(target, dict) and target is getattr(source, '__dict__', None):\n+def _edge_label(source, target, shortnames=True):\n+    if isinstance(target, dict) and target is getattr(source,\n+                                                      '__dict__',\n+                                                      None):","path":"objgraph.py","position":385,"original_position":385,"commit_id":"ffda35e4e81124cf8c82839c49489d08649c7ea2","original_commit_id":"ffda35e4e81124cf8c82839c49489d08649c7ea2","user":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"body":"No.  Better a line longer than 80 characters than this.  Or\r\n\r\n```python\r\nif (isinstance(target, dict) and\r\n        target is getattr(source, '__dict__', None)):\r\n```\r\nwould also be acceptable.","created_at":"2015-02-23T10:44:26Z","updated_at":"2015-02-23T10:44:26Z","html_url":"https://github.com/mgedmin/objgraph/pull/15#discussion_r25155042","pull_request_url":"https://api.github.com/repos/mgedmin/objgraph/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/comments/25155042"},"html":{"href":"https://github.com/mgedmin/objgraph/pull/15#discussion_r25155042"},"pull_request":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/mgedmin/objgraph/pulls/15","id":29753769,"html_url":"https://github.com/mgedmin/objgraph/pull/15","diff_url":"https://github.com/mgedmin/objgraph/pull/15.diff","patch_url":"https://github.com/mgedmin/objgraph/pull/15.patch","issue_url":"https://api.github.com/repos/mgedmin/objgraph/issues/15","number":15,"state":"open","locked":false,"title":"Make objgraph pass flake8","user":{"login":"pcostell","id":1728051,"avatar_url":"https://avatars.githubusercontent.com/u/1728051?v=3","gravatar_id":"","url":"https://api.github.com/users/pcostell","html_url":"https://github.com/pcostell","followers_url":"https://api.github.com/users/pcostell/followers","following_url":"https://api.github.com/users/pcostell/following{/other_user}","gists_url":"https://api.github.com/users/pcostell/gists{/gist_id}","starred_url":"https://api.github.com/users/pcostell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcostell/subscriptions","organizations_url":"https://api.github.com/users/pcostell/orgs","repos_url":"https://api.github.com/users/pcostell/repos","events_url":"https://api.github.com/users/pcostell/events{/privacy}","received_events_url":"https://api.github.com/users/pcostell/received_events","type":"User","site_admin":false},"body":"This adds flake8 testing to the Makefile and to the travis build. It also updates objgraph.py and tests.py to pass flake8.\r\n\r\nThis request was branched from https://github.com/mgedmin/objgraph/pull/14, so please review that one first. ","created_at":"2015-02-21T13:39:57Z","updated_at":"2015-02-23T10:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7975836109bbb11620f2d005877454676108b401","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mgedmin/objgraph/pulls/15/commits","review_comments_url":"https://api.github.com/repos/mgedmin/objgraph/pulls/15/comments","review_comment_url":"https://api.github.com/repos/mgedmin/objgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mgedmin/objgraph/issues/15/comments","statuses_url":"https://api.github.com/repos/mgedmin/objgraph/statuses/ffda35e4e81124cf8c82839c49489d08649c7ea2","head":{"label":"pcostell:pass_flake8","ref":"pass_flake8","sha":"ffda35e4e81124cf8c82839c49489d08649c7ea2","user":{"login":"pcostell","id":1728051,"avatar_url":"https://avatars.githubusercontent.com/u/1728051?v=3","gravatar_id":"","url":"https://api.github.com/users/pcostell","html_url":"https://github.com/pcostell","followers_url":"https://api.github.com/users/pcostell/followers","following_url":"https://api.github.com/users/pcostell/following{/other_user}","gists_url":"https://api.github.com/users/pcostell/gists{/gist_id}","starred_url":"https://api.github.com/users/pcostell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcostell/subscriptions","organizations_url":"https://api.github.com/users/pcostell/orgs","repos_url":"https://api.github.com/users/pcostell/repos","events_url":"https://api.github.com/users/pcostell/events{/privacy}","received_events_url":"https://api.github.com/users/pcostell/received_events","type":"User","site_admin":false},"repo":{"id":30934065,"name":"objgraph","full_name":"pcostell/objgraph","owner":{"login":"pcostell","id":1728051,"avatar_url":"https://avatars.githubusercontent.com/u/1728051?v=3","gravatar_id":"","url":"https://api.github.com/users/pcostell","html_url":"https://github.com/pcostell","followers_url":"https://api.github.com/users/pcostell/followers","following_url":"https://api.github.com/users/pcostell/following{/other_user}","gists_url":"https://api.github.com/users/pcostell/gists{/gist_id}","starred_url":"https://api.github.com/users/pcostell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcostell/subscriptions","organizations_url":"https://api.github.com/users/pcostell/orgs","repos_url":"https://api.github.com/users/pcostell/repos","events_url":"https://api.github.com/users/pcostell/events{/privacy}","received_events_url":"https://api.github.com/users/pcostell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcostell/objgraph","description":"Visually explore Python object graphs","fork":true,"url":"https://api.github.com/repos/pcostell/objgraph","forks_url":"https://api.github.com/repos/pcostell/objgraph/forks","keys_url":"https://api.github.com/repos/pcostell/objgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcostell/objgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcostell/objgraph/teams","hooks_url":"https://api.github.com/repos/pcostell/objgraph/hooks","issue_events_url":"https://api.github.com/repos/pcostell/objgraph/issues/events{/number}","events_url":"https://api.github.com/repos/pcostell/objgraph/events","assignees_url":"https://api.github.com/repos/pcostell/objgraph/assignees{/user}","branches_url":"https://api.github.com/repos/pcostell/objgraph/branches{/branch}","tags_url":"https://api.github.com/repos/pcostell/objgraph/tags","blobs_url":"https://api.github.com/repos/pcostell/objgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcostell/objgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcostell/objgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcostell/objgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcostell/objgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/pcostell/objgraph/languages","stargazers_url":"https://api.github.com/repos/pcostell/objgraph/stargazers","contributors_url":"https://api.github.com/repos/pcostell/objgraph/contributors","subscribers_url":"https://api.github.com/repos/pcostell/objgraph/subscribers","subscription_url":"https://api.github.com/repos/pcostell/objgraph/subscription","commits_url":"https://api.github.com/repos/pcostell/objgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcostell/objgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcostell/objgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcostell/objgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcostell/objgraph/contents/{+path}","compare_url":"https://api.github.com/repos/pcostell/objgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcostell/objgraph/merges","archive_url":"https://api.github.com/repos/pcostell/objgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcostell/objgraph/downloads","issues_url":"https://api.github.com/repos/pcostell/objgraph/issues{/number}","pulls_url":"https://api.github.com/repos/pcostell/objgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/pcostell/objgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/pcostell/objgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcostell/objgraph/labels{/name}","releases_url":"https://api.github.com/repos/pcostell/objgraph/releases{/id}","created_at":"2015-02-17T19:41:23Z","updated_at":"2015-02-19T17:50:54Z","pushed_at":"2015-02-21T15:37:49Z","git_url":"git://github.com/pcostell/objgraph.git","ssh_url":"git@github.com:pcostell/objgraph.git","clone_url":"https://github.com/pcostell/objgraph.git","svn_url":"https://github.com/pcostell/objgraph","homepage":"http://mg.pov.lt/objgraph/","size":4280,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgedmin:master","ref":"master","sha":"807a940fa53c316fc3b6ae7bb255fcfcdd710e45","user":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"repo":{"id":11996836,"name":"objgraph","full_name":"mgedmin/objgraph","owner":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgedmin/objgraph","description":"Visually explore Python object graphs","fork":false,"url":"https://api.github.com/repos/mgedmin/objgraph","forks_url":"https://api.github.com/repos/mgedmin/objgraph/forks","keys_url":"https://api.github.com/repos/mgedmin/objgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgedmin/objgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgedmin/objgraph/teams","hooks_url":"https://api.github.com/repos/mgedmin/objgraph/hooks","issue_events_url":"https://api.github.com/repos/mgedmin/objgraph/issues/events{/number}","events_url":"https://api.github.com/repos/mgedmin/objgraph/events","assignees_url":"https://api.github.com/repos/mgedmin/objgraph/assignees{/user}","branches_url":"https://api.github.com/repos/mgedmin/objgraph/branches{/branch}","tags_url":"https://api.github.com/repos/mgedmin/objgraph/tags","blobs_url":"https://api.github.com/repos/mgedmin/objgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgedmin/objgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgedmin/objgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgedmin/objgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgedmin/objgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/mgedmin/objgraph/languages","stargazers_url":"https://api.github.com/repos/mgedmin/objgraph/stargazers","contributors_url":"https://api.github.com/repos/mgedmin/objgraph/contributors","subscribers_url":"https://api.github.com/repos/mgedmin/objgraph/subscribers","subscription_url":"https://api.github.com/repos/mgedmin/objgraph/subscription","commits_url":"https://api.github.com/repos/mgedmin/objgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgedmin/objgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgedmin/objgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgedmin/objgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgedmin/objgraph/contents/{+path}","compare_url":"https://api.github.com/repos/mgedmin/objgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgedmin/objgraph/merges","archive_url":"https://api.github.com/repos/mgedmin/objgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgedmin/objgraph/downloads","issues_url":"https://api.github.com/repos/mgedmin/objgraph/issues{/number}","pulls_url":"https://api.github.com/repos/mgedmin/objgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/mgedmin/objgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/mgedmin/objgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgedmin/objgraph/labels{/name}","releases_url":"https://api.github.com/repos/mgedmin/objgraph/releases{/id}","created_at":"2013-08-09T08:48:21Z","updated_at":"2015-02-21T14:36:26Z","pushed_at":"2015-02-21T14:36:25Z","git_url":"git://github.com/mgedmin/objgraph.git","ssh_url":"git@github.com:mgedmin/objgraph.git","clone_url":"https://github.com/mgedmin/objgraph.git","svn_url":"https://github.com/mgedmin/objgraph","homepage":"http://mg.pov.lt/objgraph/","size":4443,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/15"},"html":{"href":"https://github.com/mgedmin/objgraph/pull/15"},"issue":{"href":"https://api.github.com/repos/mgedmin/objgraph/issues/15"},"comments":{"href":"https://api.github.com/repos/mgedmin/objgraph/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mgedmin/objgraph/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/mgedmin/objgraph/statuses/ffda35e4e81124cf8c82839c49489d08649c7ea2"}}}}