{"action":"created","comment":{"url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/comments/35521674","id":35521674,"diff_hunk":"@@ -9,22 +9,29 @@ class << self\n       def post(path, options = {})\n         uri = build_uri(path)\n         options.merge!(client_id: Plaid.customer_id, secret: Plaid.secret)\n-        res = Net::HTTP.post_form(uri,options)\n+        http = Net::HTTP.new(uri.host, uri.port)\n+        http.use_ssl = (uri.scheme == 'https')","path":"lib/plaid/connection.rb","position":6,"original_position":6,"commit_id":"d86477af59d3f835ba4f3792d2c2050288dee0a9","original_commit_id":"d86477af59d3f835ba4f3792d2c2050288dee0a9","user":{"login":"nitesh-varma","id":8529089,"avatar_url":"https://avatars.githubusercontent.com/u/8529089?v=3","gravatar_id":"","url":"https://api.github.com/users/nitesh-varma","html_url":"https://github.com/nitesh-varma","followers_url":"https://api.github.com/users/nitesh-varma/followers","following_url":"https://api.github.com/users/nitesh-varma/following{/other_user}","gists_url":"https://api.github.com/users/nitesh-varma/gists{/gist_id}","starred_url":"https://api.github.com/users/nitesh-varma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitesh-varma/subscriptions","organizations_url":"https://api.github.com/users/nitesh-varma/orgs","repos_url":"https://api.github.com/users/nitesh-varma/repos","events_url":"https://api.github.com/users/nitesh-varma/events{/privacy}","received_events_url":"https://api.github.com/users/nitesh-varma/received_events","type":"User","site_admin":false},"body":"Yes, as per https://github.com/plaid/plaid-ruby#configuring-plaid\r\n\r\n<pre>\r\nPlaid.config do |p|\r\n  p.customer_id = 'Plaid provided customer ID here'\r\n  p.secret = 'Plaid provided secret key here'\r\n  p.environment_location = 'URL for the development or production environment'\r\n  # i.e. 'https://tartan.plaid.com/' for development, or\r\n  # 'https://api.plaid.com/' for production\r\nend\r\n</pre>\r\n\r\nWe either use 'https://tartan.plaid.com/' or 'https://api.plaid.com/'. So both the cases it would be https only and ssl will be set true.\r\n\r\n> i think Plaid always uses SSL\r\n> I think this http vs https logic could be safely replaced for strict http in current master code too.\r\n\r\nYes, we should strictly use https i.e :use_ssl => true for plaid requests.\r\n\r\nThanks,\r\nNitesh","created_at":"2015-07-27T10:08:40Z","updated_at":"2015-07-27T10:08:40Z","html_url":"https://github.com/plaid/plaid-ruby/pull/73#discussion_r35521674","pull_request_url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/comments/35521674"},"html":{"href":"https://github.com/plaid/plaid-ruby/pull/73#discussion_r35521674"},"pull_request":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73","id":40835592,"html_url":"https://github.com/plaid/plaid-ruby/pull/73","diff_url":"https://github.com/plaid/plaid-ruby/pull/73.diff","patch_url":"https://github.com/plaid/plaid-ruby/pull/73.patch","issue_url":"https://api.github.com/repos/plaid/plaid-ruby/issues/73","number":73,"state":"open","locked":false,"title":"Support added for ruby 1.9.3","user":{"login":"nitesh-varma","id":8529089,"avatar_url":"https://avatars.githubusercontent.com/u/8529089?v=3","gravatar_id":"","url":"https://api.github.com/users/nitesh-varma","html_url":"https://github.com/nitesh-varma","followers_url":"https://api.github.com/users/nitesh-varma/followers","following_url":"https://api.github.com/users/nitesh-varma/following{/other_user}","gists_url":"https://api.github.com/users/nitesh-varma/gists{/gist_id}","starred_url":"https://api.github.com/users/nitesh-varma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitesh-varma/subscriptions","organizations_url":"https://api.github.com/users/nitesh-varma/orgs","repos_url":"https://api.github.com/users/nitesh-varma/repos","events_url":"https://api.github.com/users/nitesh-varma/events{/privacy}","received_events_url":"https://api.github.com/users/nitesh-varma/received_events","type":"User","site_admin":false},"body":"Support added for ruby 1.9.3\r\nSuccessfully executed specs both in 1.9.3 & 2.2.0\r\n\r\n=> ruby-2.2.0 [ i686 ]\r\nFinished in 1 minute 54.09 seconds (files took 0.31953 seconds to load)\r\n122 examples, 0 failures, 4 pending\r\n\r\n=* ruby-1.9.3-p551 [ i686 ]\r\nFinished in 2 minutes 23.5 seconds (files took 0.37978 seconds to load)\r\n122 examples, 0 failures, 4 pending\r\n","created_at":"2015-07-25T11:29:26Z","updated_at":"2015-07-27T10:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e191a2327cb4980be28357c7a4c71f7618ac1633","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73/commits","review_comments_url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73/comments","review_comment_url":"https://api.github.com/repos/plaid/plaid-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plaid/plaid-ruby/issues/73/comments","statuses_url":"https://api.github.com/repos/plaid/plaid-ruby/statuses/d86477af59d3f835ba4f3792d2c2050288dee0a9","head":{"label":"nitesh-varma:master","ref":"master","sha":"d86477af59d3f835ba4f3792d2c2050288dee0a9","user":{"login":"nitesh-varma","id":8529089,"avatar_url":"https://avatars.githubusercontent.com/u/8529089?v=3","gravatar_id":"","url":"https://api.github.com/users/nitesh-varma","html_url":"https://github.com/nitesh-varma","followers_url":"https://api.github.com/users/nitesh-varma/followers","following_url":"https://api.github.com/users/nitesh-varma/following{/other_user}","gists_url":"https://api.github.com/users/nitesh-varma/gists{/gist_id}","starred_url":"https://api.github.com/users/nitesh-varma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitesh-varma/subscriptions","organizations_url":"https://api.github.com/users/nitesh-varma/orgs","repos_url":"https://api.github.com/users/nitesh-varma/repos","events_url":"https://api.github.com/users/nitesh-varma/events{/privacy}","received_events_url":"https://api.github.com/users/nitesh-varma/received_events","type":"User","site_admin":false},"repo":{"id":39674466,"name":"plaid-ruby","full_name":"nitesh-varma/plaid-ruby","owner":{"login":"nitesh-varma","id":8529089,"avatar_url":"https://avatars.githubusercontent.com/u/8529089?v=3","gravatar_id":"","url":"https://api.github.com/users/nitesh-varma","html_url":"https://github.com/nitesh-varma","followers_url":"https://api.github.com/users/nitesh-varma/followers","following_url":"https://api.github.com/users/nitesh-varma/following{/other_user}","gists_url":"https://api.github.com/users/nitesh-varma/gists{/gist_id}","starred_url":"https://api.github.com/users/nitesh-varma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitesh-varma/subscriptions","organizations_url":"https://api.github.com/users/nitesh-varma/orgs","repos_url":"https://api.github.com/users/nitesh-varma/repos","events_url":"https://api.github.com/users/nitesh-varma/events{/privacy}","received_events_url":"https://api.github.com/users/nitesh-varma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitesh-varma/plaid-ruby","description":"Ruby bindings for the Plaid API.","fork":true,"url":"https://api.github.com/repos/nitesh-varma/plaid-ruby","forks_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/forks","keys_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/teams","hooks_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/hooks","issue_events_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/events","assignees_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/tags","blobs_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/languages","stargazers_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/stargazers","contributors_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/contributors","subscribers_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/subscribers","subscription_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/subscription","commits_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/merges","archive_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/downloads","issues_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/labels{/name}","releases_url":"https://api.github.com/repos/nitesh-varma/plaid-ruby/releases{/id}","created_at":"2015-07-25T06:04:48Z","updated_at":"2015-07-25T06:10:49Z","pushed_at":"2015-07-25T11:21:58Z","git_url":"git://github.com/nitesh-varma/plaid-ruby.git","ssh_url":"git@github.com:nitesh-varma/plaid-ruby.git","clone_url":"https://github.com/nitesh-varma/plaid-ruby.git","svn_url":"https://github.com/nitesh-varma/plaid-ruby","homepage":"https://plaid.com","size":283,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plaid:master","ref":"master","sha":"f1f5bbf0853cbe2a0e4077aa6a7a53b84cd3ca87","user":{"login":"plaid","id":3579888,"avatar_url":"https://avatars.githubusercontent.com/u/3579888?v=3","gravatar_id":"","url":"https://api.github.com/users/plaid","html_url":"https://github.com/plaid","followers_url":"https://api.github.com/users/plaid/followers","following_url":"https://api.github.com/users/plaid/following{/other_user}","gists_url":"https://api.github.com/users/plaid/gists{/gist_id}","starred_url":"https://api.github.com/users/plaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaid/subscriptions","organizations_url":"https://api.github.com/users/plaid/orgs","repos_url":"https://api.github.com/users/plaid/repos","events_url":"https://api.github.com/users/plaid/events{/privacy}","received_events_url":"https://api.github.com/users/plaid/received_events","type":"Organization","site_admin":false},"repo":{"id":16990413,"name":"plaid-ruby","full_name":"plaid/plaid-ruby","owner":{"login":"plaid","id":3579888,"avatar_url":"https://avatars.githubusercontent.com/u/3579888?v=3","gravatar_id":"","url":"https://api.github.com/users/plaid","html_url":"https://github.com/plaid","followers_url":"https://api.github.com/users/plaid/followers","following_url":"https://api.github.com/users/plaid/following{/other_user}","gists_url":"https://api.github.com/users/plaid/gists{/gist_id}","starred_url":"https://api.github.com/users/plaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaid/subscriptions","organizations_url":"https://api.github.com/users/plaid/orgs","repos_url":"https://api.github.com/users/plaid/repos","events_url":"https://api.github.com/users/plaid/events{/privacy}","received_events_url":"https://api.github.com/users/plaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plaid/plaid-ruby","description":"Ruby bindings for the Plaid API.","fork":false,"url":"https://api.github.com/repos/plaid/plaid-ruby","forks_url":"https://api.github.com/repos/plaid/plaid-ruby/forks","keys_url":"https://api.github.com/repos/plaid/plaid-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plaid/plaid-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plaid/plaid-ruby/teams","hooks_url":"https://api.github.com/repos/plaid/plaid-ruby/hooks","issue_events_url":"https://api.github.com/repos/plaid/plaid-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/plaid/plaid-ruby/events","assignees_url":"https://api.github.com/repos/plaid/plaid-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/plaid/plaid-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/plaid/plaid-ruby/tags","blobs_url":"https://api.github.com/repos/plaid/plaid-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plaid/plaid-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plaid/plaid-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/plaid/plaid-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plaid/plaid-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/plaid/plaid-ruby/languages","stargazers_url":"https://api.github.com/repos/plaid/plaid-ruby/stargazers","contributors_url":"https://api.github.com/repos/plaid/plaid-ruby/contributors","subscribers_url":"https://api.github.com/repos/plaid/plaid-ruby/subscribers","subscription_url":"https://api.github.com/repos/plaid/plaid-ruby/subscription","commits_url":"https://api.github.com/repos/plaid/plaid-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/plaid/plaid-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/plaid/plaid-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/plaid/plaid-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/plaid/plaid-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/plaid/plaid-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plaid/plaid-ruby/merges","archive_url":"https://api.github.com/repos/plaid/plaid-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plaid/plaid-ruby/downloads","issues_url":"https://api.github.com/repos/plaid/plaid-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/plaid/plaid-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/plaid/plaid-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/plaid/plaid-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plaid/plaid-ruby/labels{/name}","releases_url":"https://api.github.com/repos/plaid/plaid-ruby/releases{/id}","created_at":"2014-02-19T16:21:31Z","updated_at":"2015-07-10T13:26:44Z","pushed_at":"2015-07-25T11:29:26Z","git_url":"git://github.com/plaid/plaid-ruby.git","ssh_url":"git@github.com:plaid/plaid-ruby.git","clone_url":"https://github.com/plaid/plaid-ruby.git","svn_url":"https://github.com/plaid/plaid-ruby","homepage":"https://plaid.com","size":1090,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":6,"forks":40,"open_issues":6,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73"},"html":{"href":"https://github.com/plaid/plaid-ruby/pull/73"},"issue":{"href":"https://api.github.com/repos/plaid/plaid-ruby/issues/73"},"comments":{"href":"https://api.github.com/repos/plaid/plaid-ruby/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plaid/plaid-ruby/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/plaid/plaid-ruby/statuses/d86477af59d3f835ba4f3792d2c2050288dee0a9"}}}}