{"action":"created","issue":{"url":"https://api.github.com/repos/ChandraCXC/iris/issues/200","labels_url":"https://api.github.com/repos/ChandraCXC/iris/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/ChandraCXC/iris/issues/200/comments","events_url":"https://api.github.com/repos/ChandraCXC/iris/issues/200/events","html_url":"https://github.com/ChandraCXC/iris/pull/200","id":118632225,"number":200,"title":"Iris 187 188 start sherpa samp for it","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ChandraCXC/iris/labels/3%20-%20In%20Review","name":"3 - In Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ChandraCXC/iris/milestones/5","html_url":"https://github.com/ChandraCXC/iris/milestones/Sprint%2012/03/15","labels_url":"https://api.github.com/repos/ChandraCXC/iris/milestones/5/labels","id":1410854,"number":5,"title":"Sprint 12/03/15","description":"Sprint ending December 3rd, 2015","creator":{"login":"eholum","id":7966037,"avatar_url":"https://avatars.githubusercontent.com/u/7966037?v=3","gravatar_id":"","url":"https://api.github.com/users/eholum","html_url":"https://github.com/eholum","followers_url":"https://api.github.com/users/eholum/followers","following_url":"https://api.github.com/users/eholum/following{/other_user}","gists_url":"https://api.github.com/users/eholum/gists{/gist_id}","starred_url":"https://api.github.com/users/eholum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholum/subscriptions","organizations_url":"https://api.github.com/users/eholum/orgs","repos_url":"https://api.github.com/users/eholum/repos","events_url":"https://api.github.com/users/eholum/events{/privacy}","received_events_url":"https://api.github.com/users/eholum/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":5,"state":"open","created_at":"2015-11-13T18:57:02Z","updated_at":"2015-11-25T17:52:03Z","due_on":"2015-12-03T05:00:00Z","closed_at":null},"comments":5,"created_at":"2015-11-24T15:20:24Z","updated_at":"2015-12-01T19:02:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ChandraCXC/iris/pulls/200","html_url":"https://github.com/ChandraCXC/iris/pull/200","diff_url":"https://github.com/ChandraCXC/iris/pull/200.diff","patch_url":"https://github.com/ChandraCXC/iris/pull/200.patch"},"body":"Address #187 and address #188 \r\n\r\nThis PR instructs maven to start a samp hub and sherpa-samp as external processes in the pre- and post-integration test maven phases. More work needs to be done as issues came up during tests (see Coming Soon section below).\r\n\r\n# Notes\r\nI started working on task #188 and then realized that #187 was pretty similar to it and easy to implement and test in the changes I was already making. Since Jamie hadn't start working on it I prototyped something for #187 as well.\r\n\r\nI would still consider this as a prototype, especially because we still don't have the IntegrationTest abstract classes (suites?) in place. However, one of the several successful tests was to see the old BuilderMainViewIT integration test fail because the SAMP window did not show up. This is expected (even though I had forgot about it) because we don't need the SAMPUISpecAdapter anymore: the samp hub will be launched by maven in the pre-integration-test phase and there is no need for a special adapter to intercept the SAMP hub window.\r\n\r\nSo, with the above commit I also removed the unnecessary adapter, and I modified the BuilderMainViewIT to extend the AbstractGUIComponent class.\r\n\r\n# Testing\r\nI did several tests locally on my workstation, but here is the proof of the configuration working on Travis CI:\r\nhttps://travis-ci.org/ChandraCXC/iris/jobs/91914863\r\n\r\nFor the record, here is the build that failed because the SAMP hub window did not show up:\r\nhttps://travis-ci.org/ChandraCXC/iris/jobs/91910559\r\n\r\nAnother commit piggy backs the one above as I replicated the logging configuration defined for surefire (unit tests) on failsafe (integration tests), so integration tests do not log during the maven execution.\r\n\r\n# Coming Soon\r\nThe sed-builder does not have any integration tests (yet), so the ant-run plugin execution should be removed from its pom.\r\n\r\nAlso, killall fails on OSX, so I'll replace it with `pkill -f` which seems to work the same on Linux and OSX."},"comment":{"url":"https://api.github.com/repos/ChandraCXC/iris/issues/comments/161063454","html_url":"https://github.com/ChandraCXC/iris/pull/200#issuecomment-161063454","issue_url":"https://api.github.com/repos/ChandraCXC/iris/issues/200","id":161063454,"user":{"login":"eholum","id":7966037,"avatar_url":"https://avatars.githubusercontent.com/u/7966037?v=3","gravatar_id":"","url":"https://api.github.com/users/eholum","html_url":"https://github.com/eholum","followers_url":"https://api.github.com/users/eholum/followers","following_url":"https://api.github.com/users/eholum/following{/other_user}","gists_url":"https://api.github.com/users/eholum/gists{/gist_id}","starred_url":"https://api.github.com/users/eholum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholum/subscriptions","organizations_url":"https://api.github.com/users/eholum/orgs","repos_url":"https://api.github.com/users/eholum/repos","events_url":"https://api.github.com/users/eholum/events{/privacy}","received_events_url":"https://api.github.com/users/eholum/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T19:02:04Z","updated_at":"2015-12-01T19:02:04Z","body":"Looks good. Still behaving as expected on my linux machine, though I haven't tested it on mac either. "}}