{"action":"closed","number":86,"pull_request":{"url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86","id":27875939,"html_url":"https://github.com/zfcampus/zf-hal/pull/86","diff_url":"https://github.com/zfcampus/zf-hal/pull/86.diff","patch_url":"https://github.com/zfcampus/zf-hal/pull/86.patch","issue_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/86","number":86,"state":"closed","locked":false,"title":"Fix autoinvokable hydrators usage","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"body":"currently `ZF\\Hal\\Plugin::addHydrator()` throws an exception when taking advantage of `AbstractPluginManager::$autoAddInvokableClass` flag, which is on by default.\r\n\r\nthe additional validation that is being done, which uses `ServiceManager::has()` method, ignores the aforementioned flag, leading to unpredictable behaviours when hydrators may be or may not be already available in the plugin manager (i.e. `AbstractPluginManager::get()` being called somewhere else before `ZF\\Hal\\Plugin::addHydrator()`)\r\n\r\nthis PR removes this validation and leaves any validation of hydrator instances to the `HydratorPluginManager` itself, which should throw informative enough exceptions.","created_at":"2015-01-22T20:41:23Z","updated_at":"2015-01-22T21:16:13Z","closed_at":"2015-01-22T21:16:13Z","merged_at":"2015-01-22T21:16:13Z","merge_commit_sha":"e024704140cfb7ad0f3ccf2c89e6758d11cc2b38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86/commits","review_comments_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86/comments","review_comment_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/86/comments","statuses_url":"https://api.github.com/repos/zfcampus/zf-hal/statuses/b7a04c138be50b67aea6b8637007cc887c6d71d9","head":{"label":"stefanotorresi:fix-add-autoinvokable-hydrators","ref":"fix-add-autoinvokable-hydrators","sha":"b7a04c138be50b67aea6b8637007cc887c6d71d9","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"repo":{"id":29698288,"name":"zf-hal","full_name":"stefanotorresi/zf-hal","owner":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanotorresi/zf-hal","description":null,"fork":true,"url":"https://api.github.com/repos/stefanotorresi/zf-hal","forks_url":"https://api.github.com/repos/stefanotorresi/zf-hal/forks","keys_url":"https://api.github.com/repos/stefanotorresi/zf-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanotorresi/zf-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanotorresi/zf-hal/teams","hooks_url":"https://api.github.com/repos/stefanotorresi/zf-hal/hooks","issue_events_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues/events{/number}","events_url":"https://api.github.com/repos/stefanotorresi/zf-hal/events","assignees_url":"https://api.github.com/repos/stefanotorresi/zf-hal/assignees{/user}","branches_url":"https://api.github.com/repos/stefanotorresi/zf-hal/branches{/branch}","tags_url":"https://api.github.com/repos/stefanotorresi/zf-hal/tags","blobs_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanotorresi/zf-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanotorresi/zf-hal/languages","stargazers_url":"https://api.github.com/repos/stefanotorresi/zf-hal/stargazers","contributors_url":"https://api.github.com/repos/stefanotorresi/zf-hal/contributors","subscribers_url":"https://api.github.com/repos/stefanotorresi/zf-hal/subscribers","subscription_url":"https://api.github.com/repos/stefanotorresi/zf-hal/subscription","commits_url":"https://api.github.com/repos/stefanotorresi/zf-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanotorresi/zf-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanotorresi/zf-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanotorresi/zf-hal/contents/{+path}","compare_url":"https://api.github.com/repos/stefanotorresi/zf-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanotorresi/zf-hal/merges","archive_url":"https://api.github.com/repos/stefanotorresi/zf-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanotorresi/zf-hal/downloads","issues_url":"https://api.github.com/repos/stefanotorresi/zf-hal/issues{/number}","pulls_url":"https://api.github.com/repos/stefanotorresi/zf-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanotorresi/zf-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanotorresi/zf-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanotorresi/zf-hal/labels{/name}","releases_url":"https://api.github.com/repos/stefanotorresi/zf-hal/releases{/id}","created_at":"2015-01-22T20:22:40Z","updated_at":"2015-01-22T20:22:41Z","pushed_at":"2015-01-22T20:30:46Z","git_url":"git://github.com/stefanotorresi/zf-hal.git","ssh_url":"git@github.com:stefanotorresi/zf-hal.git","clone_url":"https://github.com/stefanotorresi/zf-hal.git","svn_url":"https://github.com/stefanotorresi/zf-hal","homepage":null,"size":2574,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfcampus:master","ref":"master","sha":"37a6b9f96be5ccdccda9363b6ed48a0d9500e3c6","user":{"login":"zfcampus","id":5454933,"avatar_url":"https://avatars.githubusercontent.com/u/5454933?v=3","gravatar_id":"","url":"https://api.github.com/users/zfcampus","html_url":"https://github.com/zfcampus","followers_url":"https://api.github.com/users/zfcampus/followers","following_url":"https://api.github.com/users/zfcampus/following{/other_user}","gists_url":"https://api.github.com/users/zfcampus/gists{/gist_id}","starred_url":"https://api.github.com/users/zfcampus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfcampus/subscriptions","organizations_url":"https://api.github.com/users/zfcampus/orgs","repos_url":"https://api.github.com/users/zfcampus/repos","events_url":"https://api.github.com/users/zfcampus/events{/privacy}","received_events_url":"https://api.github.com/users/zfcampus/received_events","type":"Organization","site_admin":false},"repo":{"id":12139719,"name":"zf-hal","full_name":"zfcampus/zf-hal","owner":{"login":"zfcampus","id":5454933,"avatar_url":"https://avatars.githubusercontent.com/u/5454933?v=3","gravatar_id":"","url":"https://api.github.com/users/zfcampus","html_url":"https://github.com/zfcampus","followers_url":"https://api.github.com/users/zfcampus/followers","following_url":"https://api.github.com/users/zfcampus/following{/other_user}","gists_url":"https://api.github.com/users/zfcampus/gists{/gist_id}","starred_url":"https://api.github.com/users/zfcampus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfcampus/subscriptions","organizations_url":"https://api.github.com/users/zfcampus/orgs","repos_url":"https://api.github.com/users/zfcampus/repos","events_url":"https://api.github.com/users/zfcampus/events{/privacy}","received_events_url":"https://api.github.com/users/zfcampus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfcampus/zf-hal","description":null,"fork":false,"url":"https://api.github.com/repos/zfcampus/zf-hal","forks_url":"https://api.github.com/repos/zfcampus/zf-hal/forks","keys_url":"https://api.github.com/repos/zfcampus/zf-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfcampus/zf-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfcampus/zf-hal/teams","hooks_url":"https://api.github.com/repos/zfcampus/zf-hal/hooks","issue_events_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/events{/number}","events_url":"https://api.github.com/repos/zfcampus/zf-hal/events","assignees_url":"https://api.github.com/repos/zfcampus/zf-hal/assignees{/user}","branches_url":"https://api.github.com/repos/zfcampus/zf-hal/branches{/branch}","tags_url":"https://api.github.com/repos/zfcampus/zf-hal/tags","blobs_url":"https://api.github.com/repos/zfcampus/zf-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfcampus/zf-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfcampus/zf-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfcampus/zf-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfcampus/zf-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/zfcampus/zf-hal/languages","stargazers_url":"https://api.github.com/repos/zfcampus/zf-hal/stargazers","contributors_url":"https://api.github.com/repos/zfcampus/zf-hal/contributors","subscribers_url":"https://api.github.com/repos/zfcampus/zf-hal/subscribers","subscription_url":"https://api.github.com/repos/zfcampus/zf-hal/subscription","commits_url":"https://api.github.com/repos/zfcampus/zf-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfcampus/zf-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfcampus/zf-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfcampus/zf-hal/issues/comments/{number}","contents_url":"https://api.github.com/repos/zfcampus/zf-hal/contents/{+path}","compare_url":"https://api.github.com/repos/zfcampus/zf-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfcampus/zf-hal/merges","archive_url":"https://api.github.com/repos/zfcampus/zf-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfcampus/zf-hal/downloads","issues_url":"https://api.github.com/repos/zfcampus/zf-hal/issues{/number}","pulls_url":"https://api.github.com/repos/zfcampus/zf-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/zfcampus/zf-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/zfcampus/zf-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfcampus/zf-hal/labels{/name}","releases_url":"https://api.github.com/repos/zfcampus/zf-hal/releases{/id}","created_at":"2013-08-15T17:40:49Z","updated_at":"2015-01-22T21:16:12Z","pushed_at":"2015-01-22T21:16:12Z","git_url":"git://github.com/zfcampus/zf-hal.git","ssh_url":"git@github.com:zfcampus/zf-hal.git","clone_url":"https://github.com/zfcampus/zf-hal.git","svn_url":"https://github.com/zfcampus/zf-hal","homepage":null,"size":2574,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":8,"forks":34,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86"},"html":{"href":"https://github.com/zfcampus/zf-hal/pull/86"},"issue":{"href":"https://api.github.com/repos/zfcampus/zf-hal/issues/86"},"comments":{"href":"https://api.github.com/repos/zfcampus/zf-hal/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zfcampus/zf-hal/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/zfcampus/zf-hal/statuses/b7a04c138be50b67aea6b8637007cc887c6d71d9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":30,"deletions":13,"changed_files":3}}