{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/27091557","id":27091557,"diff_hunk":"@@ -1093,6 +1093,26 @@ type (required, string):\n To validate a DNS challenge, the server queries for TXT records under the validation domain name.  If it receives a record whose contents match the token in the challenge, then the validation succeeds.  Otherwise, the validation fails.\n \n \n+## Wildcard Domain Validation\n+\n+When the identifier being validated is a domain name, it may contain a wildcard character \"\\*\" as its left-most label (e.g., \"\\*.foo.example.com\"). A wildcard certificate contains a wildcard domain in a CN or subjectAltName of type DNS-ID and automatically vouches for any and all host names within the bare domain name (the FQDN to the immediate right of the wildcard label).\n+\n+Domain validation for issuance of a wildcard certificate proceeds as follows:\n+1. The server MUST validate that the identifier contains a single wildcard character and that the wildcard character is the left-most label. For instance, \"foo.\\*.example.com\" is invalid.\n+2. The server MUST validate that the wildcard label does not fall immediately to the left of a registry-controlled or public suffix. For instance, \"\\*.co.uk\" is invalid.\n+3. The server SHOULD validate that there exists a valid DNS A, AAAA, or CNAME record for the identifier. For instance, if the identifier being validated is \"\\*.example.com\", the following record would suffice:\n+\n+~~~~~~~~~~\n+\n+*.example.com. IN A 203.0.113.0","path":"draft-barnes-acme.md","position":15,"original_position":15,"commit_id":"1734abf6005278a8fa400fda3836db280a483c86","original_commit_id":"1734abf6005278a8fa400fda3836db280a483c86","user":{"login":"titanous","id":13026,"avatar_url":"https://avatars.githubusercontent.com/u/13026?v=3","gravatar_id":"","url":"https://api.github.com/users/titanous","html_url":"https://github.com/titanous","followers_url":"https://api.github.com/users/titanous/followers","following_url":"https://api.github.com/users/titanous/following{/other_user}","gists_url":"https://api.github.com/users/titanous/gists{/gist_id}","starred_url":"https://api.github.com/users/titanous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titanous/subscriptions","organizations_url":"https://api.github.com/users/titanous/orgs","repos_url":"https://api.github.com/users/titanous/repos","events_url":"https://api.github.com/users/titanous/events{/privacy}","received_events_url":"https://api.github.com/users/titanous/received_events","type":"User","site_admin":false},"body":"This isn't actually a real DNS record, the DNS server sees it in the zone and responds to all questions that don't match any other records with an answer containing the wildcard record from the zone.","created_at":"2015-03-25T02:46:27Z","updated_at":"2015-03-25T02:46:27Z","html_url":"https://github.com/letsencrypt/acme-spec/pull/97#discussion_r27091557","pull_request_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/27091557"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/97#discussion_r27091557"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97","id":31885806,"html_url":"https://github.com/letsencrypt/acme-spec/pull/97","diff_url":"https://github.com/letsencrypt/acme-spec/pull/97.diff","patch_url":"https://github.com/letsencrypt/acme-spec/pull/97.patch","issue_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/97","number":97,"state":"open","locked":false,"title":"Add section about domain validation for wildcard domains","user":{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars.githubusercontent.com/u/549654?v=3","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"body":"Fix #64. Unfortunately a lot of substantial discussion happened in that github issue instead of on the proper mailing list (which i'll ping for review now).\r\n\r\nI only added support for wildcard domain validation via DVSNI for now, because that seems to best fulfill the needs of everyone who has asked for wildcard certs so far.","created_at":"2015-03-25T01:19:40Z","updated_at":"2015-03-25T02:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c10796da62b6e8ed7eda4036032d4ccd559e480d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/97/comments","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/1734abf6005278a8fa400fda3836db280a483c86","head":{"label":"diracdeltas:feature/wildcards","ref":"feature/wildcards","sha":"1734abf6005278a8fa400fda3836db280a483c86","user":{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars.githubusercontent.com/u/549654?v=3","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"repo":{"id":32829314,"name":"acme-spec","full_name":"diracdeltas/acme-spec","owner":{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars.githubusercontent.com/u/549654?v=3","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diracdeltas/acme-spec","description":"ACME Specification","fork":true,"url":"https://api.github.com/repos/diracdeltas/acme-spec","forks_url":"https://api.github.com/repos/diracdeltas/acme-spec/forks","keys_url":"https://api.github.com/repos/diracdeltas/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diracdeltas/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diracdeltas/acme-spec/teams","hooks_url":"https://api.github.com/repos/diracdeltas/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/diracdeltas/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/diracdeltas/acme-spec/events","assignees_url":"https://api.github.com/repos/diracdeltas/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/diracdeltas/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/diracdeltas/acme-spec/tags","blobs_url":"https://api.github.com/repos/diracdeltas/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diracdeltas/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diracdeltas/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/diracdeltas/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diracdeltas/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/diracdeltas/acme-spec/languages","stargazers_url":"https://api.github.com/repos/diracdeltas/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/diracdeltas/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/diracdeltas/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/diracdeltas/acme-spec/subscription","commits_url":"https://api.github.com/repos/diracdeltas/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/diracdeltas/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/diracdeltas/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/diracdeltas/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/diracdeltas/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/diracdeltas/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diracdeltas/acme-spec/merges","archive_url":"https://api.github.com/repos/diracdeltas/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diracdeltas/acme-spec/downloads","issues_url":"https://api.github.com/repos/diracdeltas/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/diracdeltas/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/diracdeltas/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/diracdeltas/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diracdeltas/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/diracdeltas/acme-spec/releases{/id}","created_at":"2015-03-24T22:39:58Z","updated_at":"2015-03-24T22:39:58Z","pushed_at":"2015-03-25T01:10:14Z","git_url":"git://github.com/diracdeltas/acme-spec.git","ssh_url":"git@github.com:diracdeltas/acme-spec.git","clone_url":"https://github.com/diracdeltas/acme-spec.git","svn_url":"https://github.com/diracdeltas/acme-spec","homepage":null,"size":1009,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"301875a9571b47233f5617f898134c98fb158d19","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":25449702,"name":"acme-spec","full_name":"letsencrypt/acme-spec","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/acme-spec","description":"ACME Specification","fork":false,"url":"https://api.github.com/repos/letsencrypt/acme-spec","forks_url":"https://api.github.com/repos/letsencrypt/acme-spec/forks","keys_url":"https://api.github.com/repos/letsencrypt/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/acme-spec/teams","hooks_url":"https://api.github.com/repos/letsencrypt/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/acme-spec/events","assignees_url":"https://api.github.com/repos/letsencrypt/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/tags","blobs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/acme-spec/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscription","commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/acme-spec/merges","archive_url":"https://api.github.com/repos/letsencrypt/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/acme-spec/downloads","issues_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/acme-spec/releases{/id}","created_at":"2014-10-20T03:43:00Z","updated_at":"2015-03-25T01:17:02Z","pushed_at":"2015-03-25T01:19:41Z","git_url":"git://github.com/letsencrypt/acme-spec.git","ssh_url":"git@github.com:letsencrypt/acme-spec.git","clone_url":"https://github.com/letsencrypt/acme-spec.git","svn_url":"https://github.com/letsencrypt/acme-spec","homepage":null,"size":1009,"stargazers_count":554,"watchers_count":554,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":53,"forks":56,"open_issues":53,"watchers":554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/97"},"issue":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/97"},"comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/1734abf6005278a8fa400fda3836db280a483c86"}}}}