{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/3508","labels_url":"https://api.github.com/repos/netty/netty/issues/3508/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/3508/comments","events_url":"https://api.github.com/repos/netty/netty/issues/3508/events","html_url":"https://github.com/netty/netty/pull/3508","id":62532902,"number":3508,"title":"Safely encode Strings to ASCII","user":{"login":"luciferous","id":24509,"avatar_url":"https://avatars.githubusercontent.com/u/24509?v=3","gravatar_id":"","url":"https://api.github.com/users/luciferous","html_url":"https://github.com/luciferous","followers_url":"https://api.github.com/users/luciferous/followers","following_url":"https://api.github.com/users/luciferous/following{/other_user}","gists_url":"https://api.github.com/users/luciferous/gists{/gist_id}","starred_url":"https://api.github.com/users/luciferous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luciferous/subscriptions","organizations_url":"https://api.github.com/users/luciferous/orgs","repos_url":"https://api.github.com/users/luciferous/repos","events_url":"https://api.github.com/users/luciferous/events{/privacy}","received_events_url":"https://api.github.com/users/luciferous/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-17T22:27:27Z","updated_at":"2015-03-18T03:47:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3508","html_url":"https://github.com/netty/netty/pull/3508","diff_url":"https://github.com/netty/netty/pull/3508.diff","patch_url":"https://github.com/netty/netty/pull/3508.patch"},"body":"Motivation:\r\n\r\nThe current implementation of the encoder writes each character of the\r\nString as a single byte to the buffer, however not all characters are\r\nmappable to a single byte.\r\n\r\nModifications:\r\n\r\nUse an ASCII CharsetEncoder to do the encoding.\r\n\r\nResult:\r\n\r\nA safer encoder for String to ASCII, which replaces unmappable\r\ncharacters."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/82728104","html_url":"https://github.com/netty/netty/pull/3508#issuecomment-82728104","issue_url":"https://api.github.com/repos/netty/netty/issues/3508","id":82728104,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2015-03-18T03:47:47Z","updated_at":"2015-03-18T03:47:47Z","body":"@luciferous  I may be confused but isn't US_ASCII be supposed to work like it was implemented before. Can you show a test-case which failed with the previous implementation ? /cc @trustin "}}