{"action":"created","comment":{"url":"https://api.github.com/repos/pyne/pyne/pulls/comments/39085750","id":39085750,"diff_hunk":"@@ -266,20 +266,21 @@ def record_to_geom(mesh, cell_fracs, cell_mats, geom_file, matlib_file,\n \n         ve_mixture = {}\n         for row in cell_fracs[cell_fracs['idx'] == i]:\n-            if cell_mats[row['cell']].metadata['mat_number'] \\\n-                not in ve_mixture.keys():\n-                ve_mixture[cell_mats[row['cell']].metadata['mat_number']] = \\\n-                    round(row['vol_frac'], sig_figs)\n+            cell_mat = cell_mats[row['cell']]\n+            name = cell_mat.metadata['name']\n+            if _is_void(name):\n+                name = \"mat_void\"\n+            if name not in ve_mixture.keys():\n+                ve_mixture[name] = round(row['vol_frac'], sig_figs)","path":"pyne/alara.py","position":22,"original_position":22,"commit_id":"0d7818e057e47a22dc8dd3d3974537ae59c9802b","original_commit_id":"0d7818e057e47a22dc8dd3d3974537ae59c9802b","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"body":"Not that this is blocking, per say, but should `np.round()` be used instead of the built-in `round()`","created_at":"2015-09-09T19:31:26Z","updated_at":"2015-09-09T19:31:26Z","html_url":"https://github.com/pyne/pyne/pull/761#discussion_r39085750","pull_request_url":"https://api.github.com/repos/pyne/pyne/pulls/761","_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments/39085750"},"html":{"href":"https://github.com/pyne/pyne/pull/761#discussion_r39085750"},"pull_request":{"href":"https://api.github.com/repos/pyne/pyne/pulls/761"}}},"pull_request":{"url":"https://api.github.com/repos/pyne/pyne/pulls/761","id":44586874,"html_url":"https://github.com/pyne/pyne/pull/761","diff_url":"https://github.com/pyne/pyne/pull/761.diff","patch_url":"https://github.com/pyne/pyne/pull/761.patch","issue_url":"https://api.github.com/repos/pyne/pyne/issues/761","number":761,"state":"open","locked":false,"title":"alara.record_to_geom() improvements","user":{"login":"elliottbiondo","id":1749283,"avatar_url":"https://avatars.githubusercontent.com/u/1749283?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottbiondo","html_url":"https://github.com/elliottbiondo","followers_url":"https://api.github.com/users/elliottbiondo/followers","following_url":"https://api.github.com/users/elliottbiondo/following{/other_user}","gists_url":"https://api.github.com/users/elliottbiondo/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottbiondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottbiondo/subscriptions","organizations_url":"https://api.github.com/users/elliottbiondo/orgs","repos_url":"https://api.github.com/users/elliottbiondo/repos","events_url":"https://api.github.com/users/elliottbiondo/events{/privacy}","received_events_url":"https://api.github.com/users/elliottbiondo/received_events","type":"User","site_admin":false},"body":"This PR adds a few improvement to `alara.record_to_geom()`:\r\n\r\n1. `Materials` that specify void regions are now supported, and this is compatible with what I added in PR #759. \r\n\r\n2. `Material.metadata['name']` is now the name that is printed to the ALARA input file. This makes more sense in the general case, and will also benefit us here at UW with some of our new workflows. \r\n\r\nIt looks like the commits from PR #759 are in here too, so that should go in first.","created_at":"2015-09-09T18:56:37Z","updated_at":"2015-09-09T19:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"627497aa4ba55a99cd271f834315b0f07b5025d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyne/pyne/pulls/761/commits","review_comments_url":"https://api.github.com/repos/pyne/pyne/pulls/761/comments","review_comment_url":"https://api.github.com/repos/pyne/pyne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyne/pyne/issues/761/comments","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/0d7818e057e47a22dc8dd3d3974537ae59c9802b","head":{"label":"elliottbiondo:r2s","ref":"r2s","sha":"0d7818e057e47a22dc8dd3d3974537ae59c9802b","user":{"login":"elliottbiondo","id":1749283,"avatar_url":"https://avatars.githubusercontent.com/u/1749283?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottbiondo","html_url":"https://github.com/elliottbiondo","followers_url":"https://api.github.com/users/elliottbiondo/followers","following_url":"https://api.github.com/users/elliottbiondo/following{/other_user}","gists_url":"https://api.github.com/users/elliottbiondo/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottbiondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottbiondo/subscriptions","organizations_url":"https://api.github.com/users/elliottbiondo/orgs","repos_url":"https://api.github.com/users/elliottbiondo/repos","events_url":"https://api.github.com/users/elliottbiondo/events{/privacy}","received_events_url":"https://api.github.com/users/elliottbiondo/received_events","type":"User","site_admin":false},"repo":{"id":23330634,"name":"pyne","full_name":"elliottbiondo/pyne","owner":{"login":"elliottbiondo","id":1749283,"avatar_url":"https://avatars.githubusercontent.com/u/1749283?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottbiondo","html_url":"https://github.com/elliottbiondo","followers_url":"https://api.github.com/users/elliottbiondo/followers","following_url":"https://api.github.com/users/elliottbiondo/following{/other_user}","gists_url":"https://api.github.com/users/elliottbiondo/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottbiondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottbiondo/subscriptions","organizations_url":"https://api.github.com/users/elliottbiondo/orgs","repos_url":"https://api.github.com/users/elliottbiondo/repos","events_url":"https://api.github.com/users/elliottbiondo/events{/privacy}","received_events_url":"https://api.github.com/users/elliottbiondo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elliottbiondo/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":true,"url":"https://api.github.com/repos/elliottbiondo/pyne","forks_url":"https://api.github.com/repos/elliottbiondo/pyne/forks","keys_url":"https://api.github.com/repos/elliottbiondo/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elliottbiondo/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elliottbiondo/pyne/teams","hooks_url":"https://api.github.com/repos/elliottbiondo/pyne/hooks","issue_events_url":"https://api.github.com/repos/elliottbiondo/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/elliottbiondo/pyne/events","assignees_url":"https://api.github.com/repos/elliottbiondo/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/elliottbiondo/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/elliottbiondo/pyne/tags","blobs_url":"https://api.github.com/repos/elliottbiondo/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elliottbiondo/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elliottbiondo/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/elliottbiondo/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elliottbiondo/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/elliottbiondo/pyne/languages","stargazers_url":"https://api.github.com/repos/elliottbiondo/pyne/stargazers","contributors_url":"https://api.github.com/repos/elliottbiondo/pyne/contributors","subscribers_url":"https://api.github.com/repos/elliottbiondo/pyne/subscribers","subscription_url":"https://api.github.com/repos/elliottbiondo/pyne/subscription","commits_url":"https://api.github.com/repos/elliottbiondo/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/elliottbiondo/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/elliottbiondo/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/elliottbiondo/pyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/elliottbiondo/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/elliottbiondo/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elliottbiondo/pyne/merges","archive_url":"https://api.github.com/repos/elliottbiondo/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elliottbiondo/pyne/downloads","issues_url":"https://api.github.com/repos/elliottbiondo/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/elliottbiondo/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/elliottbiondo/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/elliottbiondo/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elliottbiondo/pyne/labels{/name}","releases_url":"https://api.github.com/repos/elliottbiondo/pyne/releases{/id}","created_at":"2014-08-25T22:17:03Z","updated_at":"2015-04-17T18:44:13Z","pushed_at":"2015-09-09T18:54:50Z","git_url":"git://github.com/elliottbiondo/pyne.git","ssh_url":"git@github.com:elliottbiondo/pyne.git","clone_url":"https://github.com/elliottbiondo/pyne.git","svn_url":"https://github.com/elliottbiondo/pyne","homepage":"http://pyne.io/","size":18237,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pyne:develop","ref":"develop","sha":"3e4f248f4a9f484e6224adc33425c869772eb024","user":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"repo":{"id":1684953,"name":"pyne","full_name":"pyne/pyne","owner":{"login":"pyne","id":760696,"avatar_url":"https://avatars.githubusercontent.com/u/760696?v=3","gravatar_id":"","url":"https://api.github.com/users/pyne","html_url":"https://github.com/pyne","followers_url":"https://api.github.com/users/pyne/followers","following_url":"https://api.github.com/users/pyne/following{/other_user}","gists_url":"https://api.github.com/users/pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyne/subscriptions","organizations_url":"https://api.github.com/users/pyne/orgs","repos_url":"https://api.github.com/users/pyne/repos","events_url":"https://api.github.com/users/pyne/events{/privacy}","received_events_url":"https://api.github.com/users/pyne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyne/pyne","description":"PyNE: The Nuclear Engineering Toolkit","fork":false,"url":"https://api.github.com/repos/pyne/pyne","forks_url":"https://api.github.com/repos/pyne/pyne/forks","keys_url":"https://api.github.com/repos/pyne/pyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyne/pyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyne/pyne/teams","hooks_url":"https://api.github.com/repos/pyne/pyne/hooks","issue_events_url":"https://api.github.com/repos/pyne/pyne/issues/events{/number}","events_url":"https://api.github.com/repos/pyne/pyne/events","assignees_url":"https://api.github.com/repos/pyne/pyne/assignees{/user}","branches_url":"https://api.github.com/repos/pyne/pyne/branches{/branch}","tags_url":"https://api.github.com/repos/pyne/pyne/tags","blobs_url":"https://api.github.com/repos/pyne/pyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyne/pyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyne/pyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyne/pyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyne/pyne/statuses/{sha}","languages_url":"https://api.github.com/repos/pyne/pyne/languages","stargazers_url":"https://api.github.com/repos/pyne/pyne/stargazers","contributors_url":"https://api.github.com/repos/pyne/pyne/contributors","subscribers_url":"https://api.github.com/repos/pyne/pyne/subscribers","subscription_url":"https://api.github.com/repos/pyne/pyne/subscription","commits_url":"https://api.github.com/repos/pyne/pyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyne/pyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyne/pyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyne/pyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyne/pyne/contents/{+path}","compare_url":"https://api.github.com/repos/pyne/pyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyne/pyne/merges","archive_url":"https://api.github.com/repos/pyne/pyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyne/pyne/downloads","issues_url":"https://api.github.com/repos/pyne/pyne/issues{/number}","pulls_url":"https://api.github.com/repos/pyne/pyne/pulls{/number}","milestones_url":"https://api.github.com/repos/pyne/pyne/milestones{/number}","notifications_url":"https://api.github.com/repos/pyne/pyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyne/pyne/labels{/name}","releases_url":"https://api.github.com/repos/pyne/pyne/releases{/id}","created_at":"2011-04-30T15:04:07Z","updated_at":"2015-06-03T02:07:22Z","pushed_at":"2015-09-09T18:56:38Z","git_url":"git://github.com/pyne/pyne.git","ssh_url":"git@github.com:pyne/pyne.git","clone_url":"https://github.com/pyne/pyne.git","svn_url":"https://github.com/pyne/pyne","homepage":"http://pyne.io/","size":89292,"stargazers_count":50,"watchers_count":50,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":66,"forks":73,"open_issues":66,"watchers":50,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyne/pyne/pulls/761"},"html":{"href":"https://github.com/pyne/pyne/pull/761"},"issue":{"href":"https://api.github.com/repos/pyne/pyne/issues/761"},"comments":{"href":"https://api.github.com/repos/pyne/pyne/issues/761/comments"},"review_comments":{"href":"https://api.github.com/repos/pyne/pyne/pulls/761/comments"},"review_comment":{"href":"https://api.github.com/repos/pyne/pyne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyne/pyne/pulls/761/commits"},"statuses":{"href":"https://api.github.com/repos/pyne/pyne/statuses/0d7818e057e47a22dc8dd3d3974537ae59c9802b"}}}}