{"push_id":734576577,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"89cc750e9b2623aae3c257ce6c72f4ffe3e1bb33","before":"f5b46079621801ced3c24e37507e58299953c814","commits":[{"sha":"b7dfb79b53c516e54a8964ba66e207a3bb4db9ee","author":{"email":"fb1ff2593b127bfde0b4997587790c54be0eac27@gmail.com","name":"Spencer Low"},"message":"adb: win32: fix exec-in and exec-out to use binary mode\n\nadb exec-in and exec-out are designed to read/write binary data\naccording to the commit description at:\nhttps://android.googlesource.com/platform/system/core/+/5d9d434%5E!/\n\nOn Windows, when adb_read and adb_write are used, they are always in\nbinary mode (because sysdeps_win32.cpp calls Windows APIs direct). But\nunix_read, unix_write, fread, fwrite, read, write use the text\ntranslation mode of the C Runtime file descriptor, which is by default\ntextmode.\n\nadb exec-in and exec-out use copy_to_file() which uses unix_read() and\nfwrite() when reading/writing stdin and stdout, thus, copy_to_file()\nshould switch to binary mode for those cases (it already uses binary\nmode for file descriptors other than stdin and stdout).\n\ncopy_to_file() is also called by adb backup, adb restore, and adb\ninstall-multiple, but those do not use stdin or stdout, so those\ncodepaths should not be affected by this change.\n\nChange-Id: I3446d9b363d20a2c2f6be2b96e55b653d99df2f9\nSigned-off-by: Spencer Low <CompareAndSwap@gmail.com>","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/b7dfb79b53c516e54a8964ba66e207a3bb4db9ee"},{"sha":"3d2904cdf2371e26c0465184436bd063979a5d97","author":{"email":"6a6e81840130faf487a180a0dbc979c5180b645e@google.com","name":"Tamas Berghammer"},"message":"Increase size of the the adb packets sent over the wire\n\nThe reason behing this change is to increase the adb push/pull speed\nwith reduceing the number of packets sent between the host and the\ndevice because the communication is heavily bound by packet latency.\n\nThe change maintains two way compatibility in the communication\nprotocol with negotiating a packet size between the target and the\nhost with the CONNECT packets.\n\nAfter this change the push/pull speeds improved significantly\n(measured from Linux-x86_64 with 100MB of data):\n\n           | Old push | Old pull || New push  | New pull  |\n-----------------------------------------------------------\nHammerhead | 4.6 MB/s | 3.9 MB/s || 13.1 MB/s | 16.5 MB/s |\n-----------------------------------------------------------\nVolantis   | 6.0 MB/s | 6.2 MS/s || 25.9 MB/s | 29.0 MB/s |\n-----------------------------------------------------------\nFugu       | 6.0 MB/s | 5.1 MB/s || 27.9 MB/s | 33.2 MB/s |\n-----------------------------------------------------------\n\nChange-Id: Id9625de31266e43394289e325c7e7e473379c5d8","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/3d2904cdf2371e26c0465184436bd063979a5d97"},{"sha":"571c8d713c43d418f722ee71105457b8e76adc20","author":{"email":"fcce078dda1e415b072bbd7a0d74a20c665f0947@google.com","name":"Elliott Hughes"},"message":"Merge \"Increase size of the the adb packets sent over the wire\"","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/571c8d713c43d418f722ee71105457b8e76adc20"},{"sha":"6b40d0aaa1e8142dbe14a1fb1bfd7ff04de54e53","author":{"email":"fcce078dda1e415b072bbd7a0d74a20c665f0947@google.com","name":"Elliott Hughes"},"message":"Merge \"adb: win32: fix exec-in and exec-out to use binary mode\"","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/6b40d0aaa1e8142dbe14a1fb1bfd7ff04de54e53"},{"sha":"61ee830ec93059f022903d48677c1c6211cd1757","author":{"email":"fcce078dda1e415b072bbd7a0d74a20c665f0947@google.com","name":"Elliott Hughes"},"message":"Don't limit Windows USB reads.\n\nIn 3d2904cdf2371e26c0465184436bd063979a5d97 we removed the code that broke\nLinux USB reads into 4KiB chunks. This patch does the same for Windows. This\nimproves Windows \"adb pull\" speeds 6x in my VM. (There was no equivalent\nproblem with writes, so this change only affects pull speeds.)\n\nChange-Id: If19013e5f51975f4824bf9147b7b76cebd305b96","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/61ee830ec93059f022903d48677c1c6211cd1757"},{"sha":"89cc750e9b2623aae3c257ce6c72f4ffe3e1bb33","author":{"email":"fcce078dda1e415b072bbd7a0d74a20c665f0947@google.com","name":"Elliott Hughes"},"message":"Merge \"Don't limit Windows USB reads.\"","distinct":true,"url":"https://api.github.com/repos/android/platform_system_core/commits/89cc750e9b2623aae3c257ce6c72f4ffe3e1bb33"}]}