{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/comments/37036851","id":37036851,"diff_hunk":"@@ -8,12 +8,13 @@ class LiKerberosUtil {\n \n   static Logger logger = LoggerFactory.getLogger(LiKerberosUtil.class);\n   private static final String OOZIE_KRB5_CONF = \"oozie-krb5.conf\";\n+  private static final String JAVA_TMP_DIR = System.getProperty(\"java.io.tmpdir\");\n \n   /**\n    * We need to copy the oozie-krb5.conf file to a temporary location since we cannot point property java.security.krb5.conf to the file inside jar.\n    */\n   static void writeConfToTemp() {\n-    logger.debug(\"writing oozie-krb5.conf file to ${System.getProperty(\"java.io.tmpdir\")}\");","path":"li-hadoop-plugin/src/main/groovy/com/linkedin/gradle/liutil/LiKerberosUtil.groovy","position":10,"original_position":10,"commit_id":"952c93f2cf79151e31a7d2b9555ff2bd818f2145","original_commit_id":"952c93f2cf79151e31a7d2b9555ff2bd818f2145","user":{"login":"convexquad","id":7005765,"avatar_url":"https://avatars.githubusercontent.com/u/7005765?v=3","gravatar_id":"","url":"https://api.github.com/users/convexquad","html_url":"https://github.com/convexquad","followers_url":"https://api.github.com/users/convexquad/followers","following_url":"https://api.github.com/users/convexquad/following{/other_user}","gists_url":"https://api.github.com/users/convexquad/gists{/gist_id}","starred_url":"https://api.github.com/users/convexquad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convexquad/subscriptions","organizations_url":"https://api.github.com/users/convexquad/orgs","repos_url":"https://api.github.com/users/convexquad/repos","events_url":"https://api.github.com/users/convexquad/events{/privacy}","received_events_url":"https://api.github.com/users/convexquad/received_events","type":"User","site_admin":false},"body":"Is there something in particular that made you have to change this? I think it's good to get the temp dir at the time the method is used, rather than as a static class variable, even if this means you might call System.getProperty(\"java.io.tmpdir\") more than once. Generally, getting things like temp directory locations at static classloading times is kind of a bad thing.","created_at":"2015-08-13T23:22:04Z","updated_at":"2015-08-13T23:22:04Z","html_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11#discussion_r37036851","pull_request_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/comments/37036851"},"html":{"href":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11#discussion_r37036851"},"pull_request":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11","id":42217051,"html_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11","diff_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11.diff","patch_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11.patch","issue_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/11","number":11,"state":"open","locked":false,"title":"Oozie upload task","user":{"login":"nntnag17","id":4449496,"avatar_url":"https://avatars.githubusercontent.com/u/4449496?v=3","gravatar_id":"","url":"https://api.github.com/users/nntnag17","html_url":"https://github.com/nntnag17","followers_url":"https://api.github.com/users/nntnag17/followers","following_url":"https://api.github.com/users/nntnag17/following{/other_user}","gists_url":"https://api.github.com/users/nntnag17/gists{/gist_id}","starred_url":"https://api.github.com/users/nntnag17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nntnag17/subscriptions","organizations_url":"https://api.github.com/users/nntnag17/orgs","repos_url":"https://api.github.com/users/nntnag17/repos","events_url":"https://api.github.com/users/nntnag17/events{/privacy}","received_events_url":"https://api.github.com/users/nntnag17/received_events","type":"User","site_admin":false},"body":"JIRAs fixed: \r\nLIHADOOP-13353 Hadoop Plugin oozieUpload task should upload to versioned directory.\r\nLIHADOOP-13457 Fix Stackoverflow exception thrown by OozieUploadTask.","created_at":"2015-08-12T08:50:48Z","updated_at":"2015-08-13T23:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"225c9f40edcc43330df19b66da085665629f061f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11/commits","review_comments_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11/comments","review_comment_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/11/comments","statuses_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/statuses/952c93f2cf79151e31a7d2b9555ff2bd818f2145","head":{"label":"nntnag17:oozieUploadTask","ref":"oozieUploadTask","sha":"952c93f2cf79151e31a7d2b9555ff2bd818f2145","user":{"login":"nntnag17","id":4449496,"avatar_url":"https://avatars.githubusercontent.com/u/4449496?v=3","gravatar_id":"","url":"https://api.github.com/users/nntnag17","html_url":"https://github.com/nntnag17","followers_url":"https://api.github.com/users/nntnag17/followers","following_url":"https://api.github.com/users/nntnag17/following{/other_user}","gists_url":"https://api.github.com/users/nntnag17/gists{/gist_id}","starred_url":"https://api.github.com/users/nntnag17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nntnag17/subscriptions","organizations_url":"https://api.github.com/users/nntnag17/orgs","repos_url":"https://api.github.com/users/nntnag17/repos","events_url":"https://api.github.com/users/nntnag17/events{/privacy}","received_events_url":"https://api.github.com/users/nntnag17/received_events","type":"User","site_admin":false},"repo":{"id":40587030,"name":"linkedin-gradle-plugin-for-apache-hadoop-1","full_name":"nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1","owner":{"login":"nntnag17","id":4449496,"avatar_url":"https://avatars.githubusercontent.com/u/4449496?v=3","gravatar_id":"","url":"https://api.github.com/users/nntnag17","html_url":"https://github.com/nntnag17","followers_url":"https://api.github.com/users/nntnag17/followers","following_url":"https://api.github.com/users/nntnag17/following{/other_user}","gists_url":"https://api.github.com/users/nntnag17/gists{/gist_id}","starred_url":"https://api.github.com/users/nntnag17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nntnag17/subscriptions","organizations_url":"https://api.github.com/users/nntnag17/orgs","repos_url":"https://api.github.com/users/nntnag17/repos","events_url":"https://api.github.com/users/nntnag17/events{/privacy}","received_events_url":"https://api.github.com/users/nntnag17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1","description":"","fork":true,"url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1","forks_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/forks","keys_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/teams","hooks_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/hooks","issue_events_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/issues/events{/number}","events_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/events","assignees_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/assignees{/user}","branches_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/branches{/branch}","tags_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/tags","blobs_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/statuses/{sha}","languages_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/languages","stargazers_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/stargazers","contributors_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/contributors","subscribers_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/subscribers","subscription_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/subscription","commits_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/contents/{+path}","compare_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/merges","archive_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/downloads","issues_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/issues{/number}","pulls_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/pulls{/number}","milestones_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/milestones{/number}","notifications_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/labels{/name}","releases_url":"https://api.github.com/repos/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1/releases{/id}","created_at":"2015-08-12T07:38:57Z","updated_at":"2015-08-12T07:38:58Z","pushed_at":"2015-08-12T08:48:28Z","git_url":"git://github.com/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1.git","ssh_url":"git@github.com:nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1.git","clone_url":"https://github.com/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1.git","svn_url":"https://github.com/nntnag17/linkedin-gradle-plugin-for-apache-hadoop-1","homepage":null,"size":549,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"60fb1b14d08f25f9f950125d8cc004ec063a44b7","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":39574084,"name":"linkedin-gradle-plugin-for-apache-hadoop","full_name":"linkedin/linkedin-gradle-plugin-for-apache-hadoop","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop","description":"","fork":false,"url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop","forks_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/forks","keys_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/teams","hooks_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/hooks","issue_events_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/events","assignees_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/tags","blobs_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/languages","stargazers_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/stargazers","contributors_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/contributors","subscribers_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/subscribers","subscription_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/subscription","commits_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/merges","archive_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/downloads","issues_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/releases{/id}","created_at":"2015-07-23T15:06:43Z","updated_at":"2015-08-13T22:11:07Z","pushed_at":"2015-08-13T23:15:00Z","git_url":"git://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop.git","ssh_url":"git@github.com:linkedin/linkedin-gradle-plugin-for-apache-hadoop.git","clone_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop.git","svn_url":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop","homepage":null,"size":882,"stargazers_count":5,"watchers_count":5,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11"},"html":{"href":"https://github.com/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pull/11"},"issue":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/11"},"comments":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/linkedin-gradle-plugin-for-apache-hadoop/statuses/952c93f2cf79151e31a7d2b9555ff2bd818f2145"}}}}