{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12","id":44520622,"html_url":"https://github.com/openzipkin/zipkin-tracer/pull/12","diff_url":"https://github.com/openzipkin/zipkin-tracer/pull/12.diff","patch_url":"https://github.com/openzipkin/zipkin-tracer/pull/12.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/12","number":12,"state":"closed","locked":false,"title":"extracting out config","user":{"login":"jcarres-mdsol","id":1803073,"avatar_url":"https://avatars.githubusercontent.com/u/1803073?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarres-mdsol","html_url":"https://github.com/jcarres-mdsol","followers_url":"https://api.github.com/users/jcarres-mdsol/followers","following_url":"https://api.github.com/users/jcarres-mdsol/following{/other_user}","gists_url":"https://api.github.com/users/jcarres-mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarres-mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarres-mdsol/subscriptions","organizations_url":"https://api.github.com/users/jcarres-mdsol/orgs","repos_url":"https://api.github.com/users/jcarres-mdsol/repos","events_url":"https://api.github.com/users/jcarres-mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/jcarres-mdsol/received_events","type":"User","site_admin":false},"body":"Part of a grand plan to spec better the code.\r\nconfiguration related code and logic lives in its own file and added a spec for it\r\n@jamescway @adriancole ","created_at":"2015-09-09T08:03:36Z","updated_at":"2015-09-09T08:28:59Z","closed_at":"2015-09-09T08:28:59Z","merged_at":"2015-09-09T08:28:59Z","merge_commit_sha":"1fc117bd221a392763c8177434f1da780486925d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/12/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/statuses/91c4d590a82733d8c55e3f19a0f89ccfac6f8929","head":{"label":"JordiPolo:feature/config","ref":"feature/config","sha":"91c4d590a82733d8c55e3f19a0f89ccfac6f8929","user":{"login":"JordiPolo","id":21734,"avatar_url":"https://avatars.githubusercontent.com/u/21734?v=3","gravatar_id":"","url":"https://api.github.com/users/JordiPolo","html_url":"https://github.com/JordiPolo","followers_url":"https://api.github.com/users/JordiPolo/followers","following_url":"https://api.github.com/users/JordiPolo/following{/other_user}","gists_url":"https://api.github.com/users/JordiPolo/gists{/gist_id}","starred_url":"https://api.github.com/users/JordiPolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordiPolo/subscriptions","organizations_url":"https://api.github.com/users/JordiPolo/orgs","repos_url":"https://api.github.com/users/JordiPolo/repos","events_url":"https://api.github.com/users/JordiPolo/events{/privacy}","received_events_url":"https://api.github.com/users/JordiPolo/received_events","type":"User","site_admin":false},"repo":{"id":41978917,"name":"zipkin-tracer","full_name":"JordiPolo/zipkin-tracer","owner":{"login":"JordiPolo","id":21734,"avatar_url":"https://avatars.githubusercontent.com/u/21734?v=3","gravatar_id":"","url":"https://api.github.com/users/JordiPolo","html_url":"https://github.com/JordiPolo","followers_url":"https://api.github.com/users/JordiPolo/followers","following_url":"https://api.github.com/users/JordiPolo/following{/other_user}","gists_url":"https://api.github.com/users/JordiPolo/gists{/gist_id}","starred_url":"https://api.github.com/users/JordiPolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordiPolo/subscriptions","organizations_url":"https://api.github.com/users/JordiPolo/orgs","repos_url":"https://api.github.com/users/JordiPolo/repos","events_url":"https://api.github.com/users/JordiPolo/events{/privacy}","received_events_url":"https://api.github.com/users/JordiPolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JordiPolo/zipkin-tracer","description":"zipkin-tracer ruby gem","fork":true,"url":"https://api.github.com/repos/JordiPolo/zipkin-tracer","forks_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/forks","keys_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/teams","hooks_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/hooks","issue_events_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/issues/events{/number}","events_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/events","assignees_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/assignees{/user}","branches_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/branches{/branch}","tags_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/tags","blobs_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/statuses/{sha}","languages_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/languages","stargazers_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/stargazers","contributors_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/contributors","subscribers_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/subscribers","subscription_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/subscription","commits_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/contents/{+path}","compare_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/merges","archive_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/downloads","issues_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/issues{/number}","pulls_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/pulls{/number}","milestones_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/milestones{/number}","notifications_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/labels{/name}","releases_url":"https://api.github.com/repos/JordiPolo/zipkin-tracer/releases{/id}","created_at":"2015-09-05T23:11:06Z","updated_at":"2015-09-05T23:11:06Z","pushed_at":"2015-09-09T07:59:40Z","git_url":"git://github.com/JordiPolo/zipkin-tracer.git","ssh_url":"git@github.com:JordiPolo/zipkin-tracer.git","clone_url":"https://github.com/JordiPolo/zipkin-tracer.git","svn_url":"https://github.com/JordiPolo/zipkin-tracer","homepage":null,"size":299,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"dac8bb757804d4a659bb1c1cd835a3da2a51f42f","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":38572925,"name":"zipkin-tracer","full_name":"openzipkin/zipkin-tracer","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-tracer","description":"zipkin-tracer ruby gem","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-tracer","forks_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-tracer/releases{/id}","created_at":"2015-07-05T15:01:07Z","updated_at":"2015-08-19T16:21:19Z","pushed_at":"2015-09-09T08:28:59Z","git_url":"git://github.com/openzipkin/zipkin-tracer.git","ssh_url":"git@github.com:openzipkin/zipkin-tracer.git","clone_url":"https://github.com/openzipkin/zipkin-tracer.git","svn_url":"https://github.com/openzipkin/zipkin-tracer","homepage":null,"size":299,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12"},"html":{"href":"https://github.com/openzipkin/zipkin-tracer/pull/12"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/12"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-tracer/statuses/91c4d590a82733d8c55e3f19a0f89ccfac6f8929"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":128,"deletions":18,"changed_files":3}}