{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40870284","id":40870284,"diff_hunk":"@@ -110,134 +110,99 @@ private static unsafe IPHostEntry CreateHostEntry(Interop.libc.hostent* hostent)\n \n         public static unsafe SocketError TryGetAddrInfo(string name, out IPHostEntry hostinfo, out int nativeErrorCode)\n         {\n-            var hints = new Interop.libc.addrinfo\n+            Interop.Sys.HostEntry* entry = null;\n+            int result = Interop.Sys.GetHostEntriesForName(name, &entry);\n+            if (result != 0)\n             {\n-                ai_family = Interop.libc.AF_UNSPEC, // Get all address families\n-                ai_flags = Interop.libc.AI_CANONNAME\n-            };\n+                hostinfo = NameResolutionUtilities.GetUnresolvedAnswer(name);\n+                nativeErrorCode = result;\n+                return GetSocketErrorForNativeError(result);\n+            }\n \n-            Interop.libc.addrinfo* addrinfo = null;\n-            string canonicalName = null;\n-            IPAddress[] ipAddresses;\n             try\n             {\n-                int errorCode = Interop.libc.getaddrinfo(name, null, &hints, &addrinfo);\n-                if (errorCode != 0)\n-                {\n-                    hostinfo = NameResolutionUtilities.GetUnresolvedAnswer(name);\n-                    nativeErrorCode = errorCode;\n-                    return GetSocketErrorForNativeError(errorCode);\n-                }\n+                string canonicalName = Marshal.PtrToStringAnsi((IntPtr)entry->CanonicalName);\n \n-                int numAddresses = 0;\n-                for (Interop.libc.addrinfo* ai = addrinfo; ai != null; ai = ai->ai_next)\n+                hostinfo = new IPHostEntry\n+                {\n+                    HostName = string.IsNullOrEmpty(canonicalName) ? name : canonicalName,\n+                    Aliases = Array.Empty<string>(),\n+                    AddressList = new IPAddress[entry->Count]\n+                };\n+    \n+                var buffer = new byte[SocketAddressPal.IPv6AddressSize];\n+                for (int i = 0; i < entry->Count; i++)\n                 {\n-                    if (canonicalName == null && ai->ai_canonname != null)\n+                    SocketAddress sockaddr;\n+                    IPEndPoint factory;\n+                    int bufferLength;\n+                    if (entry->Addresses[i].IsIpv6)\n                     {\n-                        canonicalName = Marshal.PtrToStringAnsi((IntPtr)ai->ai_canonname);\n-                    }\n+                        sockaddr = new SocketAddress(AddressFamily.InterNetworkV6);\n+                        factory = IPEndPointStatics.IPv6Any;\n+                        bufferLength = SocketAddressPal.IPv6AddressSize;","path":"src/System.Net.NameResolution/src/System/Net/NameResolutionPal.Unix.cs","position":92,"original_position":92,"commit_id":"e9a8ac441673d0b625b65223e9fc513c2f71d587","original_commit_id":"dcbdc2263b3351f37d9868ee1b6a8f2348ae3e90","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Opened issue #3570","created_at":"2015-10-01T00:51:40Z","updated_at":"2015-10-01T00:51:40Z","html_url":"https://github.com/dotnet/corefx/pull/3471#discussion_r40870284","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3471","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40870284"},"html":{"href":"https://github.com/dotnet/corefx/pull/3471#discussion_r40870284"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3471"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3471","id":46057355,"html_url":"https://github.com/dotnet/corefx/pull/3471","diff_url":"https://github.com/dotnet/corefx/pull/3471.diff","patch_url":"https://github.com/dotnet/corefx/pull/3471.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3471","number":3471,"state":"open","locked":false,"title":"Shim'ing out GetNameInfo, get/free addrinfo, and GetHostName","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Shim'ing out GetNameInfo, get/free addrinfo, and GetHostName. The calls to getaddrinfo are not 1-to-1 with the native calls due to\r\ncomplexities around the native structs. Calls using sockaddr and\r\naddrinfo have nested structs pointing to different data depending\r\non if the IP is IPv4 or IPv6. To mitigate the complexities around\r\nthis code and around the underlying struct differences on the\r\ncurrently supported platforms, I kept the same calling pattern (as\r\nin Get* and Free*) but converted them to use an intermediate data\r\nstructure that is defined in the PAL. We can then take in the\r\nrequired data from the Managed World and determine which native\r\ntypes are required, handle all the native structs and casts, and\r\ngive back only the information that the managed code needs in a\r\nmuch simpler format.\r\n\r\n/cc @nguerrera @stephentoub @jasonwilliams200OK @pgavlin ","created_at":"2015-09-25T20:56:59Z","updated_at":"2015-10-01T00:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8ae67b6c34e0fb6f2f5a2302ccc3a02e68151ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3471/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3471/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3471/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/e9a8ac441673d0b625b65223e9fc513c2f71d587","head":{"label":"sokket:pal","ref":"pal","sha":"e9a8ac441673d0b625b65223e9fc513c2f71d587","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","created_at":"2015-03-10T18:45:28Z","updated_at":"2015-05-06T18:55:19Z","pushed_at":"2015-10-01T00:14:54Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":33504,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"05137b690dedb6f71ea3decafd8ff99fe0d11b3b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-09-30T21:51:20Z","pushed_at":"2015-10-01T00:47:09Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":74455,"stargazers_count":8414,"watchers_count":8414,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1828,"mirror_url":null,"open_issues_count":635,"forks":1828,"open_issues":635,"watchers":8414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3471"},"html":{"href":"https://github.com/dotnet/corefx/pull/3471"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3471"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3471/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3471/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3471/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/e9a8ac441673d0b625b65223e9fc513c2f71d587"}}}}