{"action":"created","issue":{"url":"https://api.github.com/repos/jorissteyn/edep/issues/4","labels_url":"https://api.github.com/repos/jorissteyn/edep/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/jorissteyn/edep/issues/4/comments","events_url":"https://api.github.com/repos/jorissteyn/edep/issues/4/events","html_url":"https://github.com/jorissteyn/edep/issues/4","id":73736700,"number":4,"title":"Make USEDECL emit include tags?","user":{"login":"trashofmasters","id":30650,"avatar_url":"https://avatars.githubusercontent.com/u/30650?v=3","gravatar_id":"","url":"https://api.github.com/users/trashofmasters","html_url":"https://github.com/trashofmasters","followers_url":"https://api.github.com/users/trashofmasters/followers","following_url":"https://api.github.com/users/trashofmasters/following{/other_user}","gists_url":"https://api.github.com/users/trashofmasters/gists{/gist_id}","starred_url":"https://api.github.com/users/trashofmasters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashofmasters/subscriptions","organizations_url":"https://api.github.com/users/trashofmasters/orgs","repos_url":"https://api.github.com/users/trashofmasters/repos","events_url":"https://api.github.com/users/trashofmasters/events{/privacy}","received_events_url":"https://api.github.com/users/trashofmasters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-06T21:04:02Z","updated_at":"2015-06-21T20:57:44Z","closed_at":null,"body":"I have been using EDEP for the past week with the Semantic version built in Emacs 24.5 and more recently with CEDET 2.0 because of its greater parser debugging capabilities. \r\n\r\nYour grammar has only had a few hiccups in a couple of files that used `var` instead of `public`, besides that it has been churning code all day, every day, like nothing.\r\n\r\nAnyway, the first thing that caught my eye about EDEP is the lack of include tags :)\r\n\r\nAs I was playing about with SemanticDB, I've immediately noticed that I could get EDEP to emit includes with the simple change of `USEDECL` to `INCLUDE-TAG`\r\n\r\n```\r\nuse_declaration\r\n  : namespace_name                              (INCLUDE-TAG $1 nil)\r\n  | namespace_name T_AS T_STRING                (INCLUDE-TAG $1 nil :alias $3)\r\n  | T_NS_SEPARATOR namespace_name               (INCLUDE-TAG $2 nil)\r\n  | T_NS_SEPARATOR namespace_name T_AS T_STRING (INCLUDE-TAG $2 nil :alias $4)\r\n  ;\r\n```\r\n\r\nYou clearly know what you are doing, so I figure you know already about the macro `INCLUDE-TAG`. \r\n\r\nI would like to know what's your rationale for not using the built-in macro for it cannot be as simple a fix like I suggest above.\r\n\r\nAs far as I understand PHPTags is there to reproduce some of the SemanticDB functionality without the need to give SemanticDB knowledge about the project files through EDE. Perhaps this is why you opted for a custom macro?\r\n\r\nReal good work @jorissteyn. I'm really enjoying using EDEP thank you very much for it.\r\n\r\nP.S.: this is very much related to php-mode issue #235, I will be replying to that thread next weekend.\r\n"},"comment":{"url":"https://api.github.com/repos/jorissteyn/edep/issues/comments/113956654","html_url":"https://github.com/jorissteyn/edep/issues/4#issuecomment-113956654","issue_url":"https://api.github.com/repos/jorissteyn/edep/issues/4","id":113956654,"user":{"login":"jorissteyn","id":448056,"avatar_url":"https://avatars.githubusercontent.com/u/448056?v=3","gravatar_id":"","url":"https://api.github.com/users/jorissteyn","html_url":"https://github.com/jorissteyn","followers_url":"https://api.github.com/users/jorissteyn/followers","following_url":"https://api.github.com/users/jorissteyn/following{/other_user}","gists_url":"https://api.github.com/users/jorissteyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jorissteyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorissteyn/subscriptions","organizations_url":"https://api.github.com/users/jorissteyn/orgs","repos_url":"https://api.github.com/users/jorissteyn/repos","events_url":"https://api.github.com/users/jorissteyn/events{/privacy}","received_events_url":"https://api.github.com/users/jorissteyn/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T20:57:44Z","updated_at":"2015-06-21T20:57:44Z","body":"I wasn't planning on making EDEP work with ede-php-autoload, since phptags is so hard-wired and another backend besides phptags makes little sense. But I did it anyway. I wanted to experiment with how multiple/pluggable backends would work in semantic so I created the branch `multiple-db-backends`, see commit message if interested. It works great at least in the ways I've tried it, had to ignore a test failure though. \r\n\r\nI won't merge the branch in or make any further commits. I want to focus on the splitting semantic-php and phptags from EDEP, making it obsolete.\r\n\r\nFor the record: some of what I wrote in my previous message is incorrect. I got rid of both the find-translate-path hack and the semanticdb-typecache-find hack. Semantic does use system databases for non-deep searches, so no problems there. The whole db stuff in semantic isn't very straightforward.\r\n"}}