{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/27242","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/27242/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27242/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/27242/events","html_url":"https://github.com/rust-lang/rust/issues/27242","id":96880215,"number":27242,"title":"Push HashMap into libcollections","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/A-libs","name":"A-libs","color":"d7e102"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/E-mentor","name":"E-mentor","color":"02E10C"}],"state":"open","locked":false,"assignee":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-07-23T18:44:16Z","updated_at":"2015-07-28T14:23:07Z","closed_at":null,"body":"This is blocked on https://github.com/rust-lang/rust/pull/26870\r\n\r\n* [ ] Move FnvHasher from src/librustc/util/nodemap.rs to libcollections\r\n* [ ] Expose FnvHasher as DeterministicState\r\n* [ ] Move HashMap's implementation into libcollections defaulting to DeterministicState\r\n* [ ] Unhardcode HashMap's constructors/methods from using RandomState (instead relying on default fallback)\r\n* [ ] Re-export HashMap in std::collections as `pub type HashMap<K, V, S = RandomState> = core_collections::HashMap<K, V, S>`\r\n* [ ] Do the same for HashSet\r\n* [ ] Re-export DeterministicState in std as well (so we have a better answer to \"HashMap is slow\")\r\n* [ ] Document the performance-stability/security tradeoff between DeterministicState and RandomState, and that users of the std facade will get a different default from direct users of libcollections (because RandomState requires OS rng to seed its state)\r\n\r\nI am willing to mentor this if someone else wants to do it. \r\n\r\nNote that re-exporting HashMap may be the trickiest one; it's not clear to me that it's trivial, and may involve manually re-exporting everything in std::collections::hash_map to get the right behaviour (annoying and potentially fragile)."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/125625829","html_url":"https://github.com/rust-lang/rust/issues/27242#issuecomment-125625829","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27242","id":125625829,"user":{"login":"pczarn","id":3356767,"avatar_url":"https://avatars.githubusercontent.com/u/3356767?v=3","gravatar_id":"","url":"https://api.github.com/users/pczarn","html_url":"https://github.com/pczarn","followers_url":"https://api.github.com/users/pczarn/followers","following_url":"https://api.github.com/users/pczarn/following{/other_user}","gists_url":"https://api.github.com/users/pczarn/gists{/gist_id}","starred_url":"https://api.github.com/users/pczarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pczarn/subscriptions","organizations_url":"https://api.github.com/users/pczarn/orgs","repos_url":"https://api.github.com/users/pczarn/repos","events_url":"https://api.github.com/users/pczarn/events{/privacy}","received_events_url":"https://api.github.com/users/pczarn/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T14:23:07Z","updated_at":"2015-07-28T14:23:07Z","body":"Thanks, snapshot landed just now. I would be happy to do this."}}