{"action":"created","comment":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/comments/41079057","id":41079057,"diff_hunk":"@@ -44,13 +47,11 @@ describe('Rollbar', function() {\n       it('should create the window.Rollbar object', function() {\n         analytics.assert(!window.Rollbar);\n         analytics.initialize();\n-        analytics.page();\n         analytics.assert(window.Rollbar);\n       });\n \n       it('should have all of the correct methods', function() {\n         analytics.initialize();\n-        analytics.page();","path":"test/index.test.js","position":31,"original_position":31,"commit_id":"7b983b257e00a3610c0e45e6e007608b276667e3","original_commit_id":"7b983b257e00a3610c0e45e6e007608b276667e3","user":{"login":"coryvirok","id":769323,"avatar_url":"https://avatars.githubusercontent.com/u/769323?v=3","gravatar_id":"","url":"https://api.github.com/users/coryvirok","html_url":"https://github.com/coryvirok","followers_url":"https://api.github.com/users/coryvirok/followers","following_url":"https://api.github.com/users/coryvirok/following{/other_user}","gists_url":"https://api.github.com/users/coryvirok/gists{/gist_id}","starred_url":"https://api.github.com/users/coryvirok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryvirok/subscriptions","organizations_url":"https://api.github.com/users/coryvirok/orgs","repos_url":"https://api.github.com/users/coryvirok/repos","events_url":"https://api.github.com/users/coryvirok/events{/privacy}","received_events_url":"https://api.github.com/users/coryvirok/received_events","type":"User","site_admin":false},"body":"These weren't actually doing anything. I think I originally copied them from some other integration's tests.\r\n\r\nE.g. We don't need `page()` to be called in order to verify that the Rollbar notifier has all of the appropriate methods after initialization.","created_at":"2015-10-02T23:44:32Z","updated_at":"2015-10-02T23:44:32Z","html_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6#discussion_r41079057","pull_request_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/comments/41079057"},"html":{"href":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6#discussion_r41079057"},"pull_request":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6","id":46589406,"html_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6","diff_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6.diff","patch_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6.patch","issue_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/6","number":6,"state":"open","locked":false,"title":"Fixes a bug where the Rollbar integration was loading twice","user":{"login":"coryvirok","id":769323,"avatar_url":"https://avatars.githubusercontent.com/u/769323?v=3","gravatar_id":"","url":"https://api.github.com/users/coryvirok","html_url":"https://github.com/coryvirok","followers_url":"https://api.github.com/users/coryvirok/followers","following_url":"https://api.github.com/users/coryvirok/following{/other_user}","gists_url":"https://api.github.com/users/coryvirok/gists{/gist_id}","starred_url":"https://api.github.com/users/coryvirok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryvirok/subscriptions","organizations_url":"https://api.github.com/users/coryvirok/orgs","repos_url":"https://api.github.com/users/coryvirok/repos","events_url":"https://api.github.com/users/coryvirok/events{/privacy}","received_events_url":"https://api.github.com/users/coryvirok/received_events","type":"User","site_admin":false},"body":"The integration was previously loading the full Rollbar javascript code asynchronously in the `initialize()` method and again in the `load()` method. This was done in order to ensure the Rollbar interface was available once the callback passed to `load()` was executed. This was unnecessary.\r\n\r\nThis change loads the full Rollbar javascript only once, inside the `initialize()` method. The `load()` method has been modified to wait for the full source to download before it calls the `load()` callback.","created_at":"2015-10-01T23:29:12Z","updated_at":"2015-10-02T23:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94fcaab647efd51efe93dce430e3c905c7a376aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6/commits","review_comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6/comments","review_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/6/comments","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/statuses/7b983b257e00a3610c0e45e6e007608b276667e3","head":{"label":"rollbar:bugfix/load-twice","ref":"bugfix/load-twice","sha":"7b983b257e00a3610c0e45e6e007608b276667e3","user":{"login":"rollbar","id":3219584,"avatar_url":"https://avatars.githubusercontent.com/u/3219584?v=3","gravatar_id":"","url":"https://api.github.com/users/rollbar","html_url":"https://github.com/rollbar","followers_url":"https://api.github.com/users/rollbar/followers","following_url":"https://api.github.com/users/rollbar/following{/other_user}","gists_url":"https://api.github.com/users/rollbar/gists{/gist_id}","starred_url":"https://api.github.com/users/rollbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollbar/subscriptions","organizations_url":"https://api.github.com/users/rollbar/orgs","repos_url":"https://api.github.com/users/rollbar/repos","events_url":"https://api.github.com/users/rollbar/events{/privacy}","received_events_url":"https://api.github.com/users/rollbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39851647,"name":"analytics.js-integration-rollbar","full_name":"rollbar/analytics.js-integration-rollbar","owner":{"login":"rollbar","id":3219584,"avatar_url":"https://avatars.githubusercontent.com/u/3219584?v=3","gravatar_id":"","url":"https://api.github.com/users/rollbar","html_url":"https://github.com/rollbar","followers_url":"https://api.github.com/users/rollbar/followers","following_url":"https://api.github.com/users/rollbar/following{/other_user}","gists_url":"https://api.github.com/users/rollbar/gists{/gist_id}","starred_url":"https://api.github.com/users/rollbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollbar/subscriptions","organizations_url":"https://api.github.com/users/rollbar/orgs","repos_url":"https://api.github.com/users/rollbar/repos","events_url":"https://api.github.com/users/rollbar/events{/privacy}","received_events_url":"https://api.github.com/users/rollbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rollbar/analytics.js-integration-rollbar","description":"The Rollbar analytics.js integration.","fork":true,"url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar","forks_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/forks","keys_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/teams","hooks_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/hooks","issue_events_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/issues/events{/number}","events_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/events","assignees_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/assignees{/user}","branches_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/branches{/branch}","tags_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/tags","blobs_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/statuses/{sha}","languages_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/languages","stargazers_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/stargazers","contributors_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/contributors","subscribers_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/subscribers","subscription_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/subscription","commits_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/contents/{+path}","compare_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/merges","archive_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/downloads","issues_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/issues{/number}","pulls_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/pulls{/number}","milestones_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/milestones{/number}","notifications_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/labels{/name}","releases_url":"https://api.github.com/repos/rollbar/analytics.js-integration-rollbar/releases{/id}","created_at":"2015-07-28T18:43:49Z","updated_at":"2015-07-28T18:43:50Z","pushed_at":"2015-10-01T21:31:34Z","git_url":"git://github.com/rollbar/analytics.js-integration-rollbar.git","ssh_url":"git@github.com:rollbar/analytics.js-integration-rollbar.git","clone_url":"https://github.com/rollbar/analytics.js-integration-rollbar.git","svn_url":"https://github.com/rollbar/analytics.js-integration-rollbar","homepage":"https://segment.com/docs/integrations/rollbar/","size":103,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"segment-integrations:master","ref":"master","sha":"f84d2de6b2315aa10cb64c78eca1616db90494e3","user":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":37163404,"name":"analytics.js-integration-rollbar","full_name":"segment-integrations/analytics.js-integration-rollbar","owner":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar","description":"The Rollbar analytics.js integration.","fork":false,"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar","forks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/forks","keys_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/teams","hooks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/hooks","issue_events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/events{/number}","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/events","assignees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/assignees{/user}","branches_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/branches{/branch}","tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/tags","blobs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/statuses/{sha}","languages_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/languages","stargazers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/stargazers","contributors_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/contributors","subscribers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/subscribers","subscription_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/subscription","commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/contents/{+path}","compare_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/merges","archive_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/downloads","issues_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues{/number}","pulls_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls{/number}","milestones_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/milestones{/number}","notifications_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/labels{/name}","releases_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/releases{/id}","created_at":"2015-06-09T23:04:21Z","updated_at":"2015-06-30T02:16:35Z","pushed_at":"2015-10-01T23:29:12Z","git_url":"git://github.com/segment-integrations/analytics.js-integration-rollbar.git","ssh_url":"git@github.com:segment-integrations/analytics.js-integration-rollbar.git","clone_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar.git","svn_url":"https://github.com/segment-integrations/analytics.js-integration-rollbar","homepage":"https://segment.com/docs/integrations/rollbar/","size":172,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6"},"html":{"href":"https://github.com/segment-integrations/analytics.js-integration-rollbar/pull/6"},"issue":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/6"},"comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-rollbar/statuses/7b983b257e00a3610c0e45e6e007608b276667e3"}}}}