{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/47828554","id":47828554,"diff_hunk":"@@ -404,6 +404,84 @@ void draw_top_bottom_3d_mode(Camera& camera, bool show_hud,\n \tcamera.getCameraNode()->setTarget(oldTarget);\n }\n \n+void draw_pageflip_3d_mode(Camera& camera, bool show_hud,\n+\t\tHud& hud, std::vector<aabb3f> hilightboxes, video::IVideoDriver* driver,\n+\t\tscene::ISceneManager* smgr, const v2u32& screensize,\n+\t\tbool draw_wield_tool, Client& client, gui::IGUIEnvironment* guienv,\n+\t\tvideo::SColor skycolor )\n+{\n+\t/* preserve old setup*/\n+\tirr::core::vector3df oldPosition = camera.getCameraNode()->getPosition();\n+\tirr::core::vector3df oldTarget   = camera.getCameraNode()->getTarget();\n+\n+\tirr::core::matrix4 startMatrix =\n+\t\t\tcamera.getCameraNode()->getAbsoluteTransformation();\n+\tirr::core::vector3df focusPoint = (camera.getCameraNode()->getTarget()\n+\t\t\t- camera.getCameraNode()->getAbsolutePosition()).setLength(1)\n+\t\t\t+ camera.getCameraNode()->getAbsolutePosition();\n+\n+\t//Left eye...\n+\tdriver->setRenderTarget( irr::video::ERT_STEREO_LEFT_BUFFER);","path":"src/drawscene.cpp","position":21,"original_position":21,"commit_id":"b4a7a787c80630c20861cb951915e1d0acc55792","original_commit_id":"b4a7a787c80630c20861cb951915e1d0acc55792","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"one space too much :)","created_at":"2015-12-16T20:21:44Z","updated_at":"2015-12-16T20:21:44Z","html_url":"https://github.com/minetest/minetest/pull/3460#discussion_r47828554","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3460","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/47828554"},"html":{"href":"https://github.com/minetest/minetest/pull/3460#discussion_r47828554"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3460"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3460","id":53849587,"html_url":"https://github.com/minetest/minetest/pull/3460","diff_url":"https://github.com/minetest/minetest/pull/3460.diff","patch_url":"https://github.com/minetest/minetest/pull/3460.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3460","number":3460,"state":"open","locked":false,"title":"New 3D Mode: Pageflip","user":{"login":"dfelinto","id":843498,"avatar_url":"https://avatars.githubusercontent.com/u/843498?v=3","gravatar_id":"","url":"https://api.github.com/users/dfelinto","html_url":"https://github.com/dfelinto","followers_url":"https://api.github.com/users/dfelinto/followers","following_url":"https://api.github.com/users/dfelinto/following{/other_user}","gists_url":"https://api.github.com/users/dfelinto/gists{/gist_id}","starred_url":"https://api.github.com/users/dfelinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfelinto/subscriptions","organizations_url":"https://api.github.com/users/dfelinto/orgs","repos_url":"https://api.github.com/users/dfelinto/repos","events_url":"https://api.github.com/users/dfelinto/events{/privacy}","received_events_url":"https://api.github.com/users/dfelinto/received_events","type":"User","site_admin":false},"body":"The pageflip mode requires a stereo quadbuffer, and a modern graphic\r\ncard. Patch tested with NVidia 3D Vision + Quadro FX 580 on Linux.\r\n\r\nThe mini-map is not drawn, but that's what is done for topbottom and\r\nsidebyside modes as well.\r\n\r\nAlso most of the time the user would prefer the HUD to be off. That's\r\nfor the user to decide though, and toggle it manually.\r\n\r\nFinally, the interocular distance (aka eye separation) is twice as much\r\nas the \"3d_paralax_strength\" settings. I find this a strange design\r\ndecision. I didn't want to chance this though, since it's how the other\r\n3d modes interpret this settings.","created_at":"2015-12-16T14:43:58Z","updated_at":"2015-12-16T20:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"615d5ee1c82885e3584a2abe03f00e0b48910822","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3460/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3460/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3460/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/b4a7a787c80630c20861cb951915e1d0acc55792","head":{"label":"dfelinto:stereo_pageflip","ref":"stereo_pageflip","sha":"b4a7a787c80630c20861cb951915e1d0acc55792","user":{"login":"dfelinto","id":843498,"avatar_url":"https://avatars.githubusercontent.com/u/843498?v=3","gravatar_id":"","url":"https://api.github.com/users/dfelinto","html_url":"https://github.com/dfelinto","followers_url":"https://api.github.com/users/dfelinto/followers","following_url":"https://api.github.com/users/dfelinto/following{/other_user}","gists_url":"https://api.github.com/users/dfelinto/gists{/gist_id}","starred_url":"https://api.github.com/users/dfelinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfelinto/subscriptions","organizations_url":"https://api.github.com/users/dfelinto/orgs","repos_url":"https://api.github.com/users/dfelinto/repos","events_url":"https://api.github.com/users/dfelinto/events{/privacy}","received_events_url":"https://api.github.com/users/dfelinto/received_events","type":"User","site_admin":false},"repo":{"id":47999268,"name":"minetest","full_name":"dfelinto/minetest","owner":{"login":"dfelinto","id":843498,"avatar_url":"https://avatars.githubusercontent.com/u/843498?v=3","gravatar_id":"","url":"https://api.github.com/users/dfelinto","html_url":"https://github.com/dfelinto","followers_url":"https://api.github.com/users/dfelinto/followers","following_url":"https://api.github.com/users/dfelinto/following{/other_user}","gists_url":"https://api.github.com/users/dfelinto/gists{/gist_id}","starred_url":"https://api.github.com/users/dfelinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfelinto/subscriptions","organizations_url":"https://api.github.com/users/dfelinto/orgs","repos_url":"https://api.github.com/users/dfelinto/repos","events_url":"https://api.github.com/users/dfelinto/events{/privacy}","received_events_url":"https://api.github.com/users/dfelinto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfelinto/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/dfelinto/minetest","forks_url":"https://api.github.com/repos/dfelinto/minetest/forks","keys_url":"https://api.github.com/repos/dfelinto/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfelinto/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfelinto/minetest/teams","hooks_url":"https://api.github.com/repos/dfelinto/minetest/hooks","issue_events_url":"https://api.github.com/repos/dfelinto/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/dfelinto/minetest/events","assignees_url":"https://api.github.com/repos/dfelinto/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/dfelinto/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/dfelinto/minetest/tags","blobs_url":"https://api.github.com/repos/dfelinto/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfelinto/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfelinto/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfelinto/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfelinto/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/dfelinto/minetest/languages","stargazers_url":"https://api.github.com/repos/dfelinto/minetest/stargazers","contributors_url":"https://api.github.com/repos/dfelinto/minetest/contributors","subscribers_url":"https://api.github.com/repos/dfelinto/minetest/subscribers","subscription_url":"https://api.github.com/repos/dfelinto/minetest/subscription","commits_url":"https://api.github.com/repos/dfelinto/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfelinto/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfelinto/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfelinto/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfelinto/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/dfelinto/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfelinto/minetest/merges","archive_url":"https://api.github.com/repos/dfelinto/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfelinto/minetest/downloads","issues_url":"https://api.github.com/repos/dfelinto/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/dfelinto/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/dfelinto/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/dfelinto/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfelinto/minetest/labels{/name}","releases_url":"https://api.github.com/repos/dfelinto/minetest/releases{/id}","created_at":"2015-12-14T20:24:51Z","updated_at":"2015-12-14T20:24:55Z","pushed_at":"2015-12-16T17:04:05Z","git_url":"git://github.com/dfelinto/minetest.git","ssh_url":"git@github.com:dfelinto/minetest.git","clone_url":"https://github.com/dfelinto/minetest.git","svn_url":"https://github.com/dfelinto/minetest","homepage":"http://minetest.net/","size":40383,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"9eee3c3f465c071bb9908749cf48be3c131a1bdf","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-12-16T11:26:20Z","pushed_at":"2015-12-16T17:04:07Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":84970,"stargazers_count":1713,"watchers_count":1713,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"open_issues_count":654,"forks":574,"open_issues":654,"watchers":1713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3460"},"html":{"href":"https://github.com/minetest/minetest/pull/3460"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3460"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3460/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3460/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3460/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/b4a7a787c80630c20861cb951915e1d0acc55792"}}}}