{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/11969","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11969/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11969/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11969/events","html_url":"https://github.com/elastic/elasticsearch/pull/11969","id":92309171,"number":11969,"title":"Refactoring of GeoBoundingBoxQueryBuilder and -Parser","user":{"login":"MaineC","id":70953,"avatar_url":"https://avatars.githubusercontent.com/u/70953?v=3","gravatar_id":"","url":"https://api.github.com/users/MaineC","html_url":"https://github.com/MaineC","followers_url":"https://api.github.com/users/MaineC/followers","following_url":"https://api.github.com/users/MaineC/following{/other_user}","gists_url":"https://api.github.com/users/MaineC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaineC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaineC/subscriptions","organizations_url":"https://api.github.com/users/MaineC/orgs","repos_url":"https://api.github.com/users/MaineC/repos","events_url":"https://api.github.com/users/MaineC/events{/privacy}","received_events_url":"https://api.github.com/users/MaineC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Query%20Refactoring","name":":Query Refactoring","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"MaineC","id":70953,"avatar_url":"https://avatars.githubusercontent.com/u/70953?v=3","gravatar_id":"","url":"https://api.github.com/users/MaineC","html_url":"https://github.com/MaineC","followers_url":"https://api.github.com/users/MaineC/followers","following_url":"https://api.github.com/users/MaineC/following{/other_user}","gists_url":"https://api.github.com/users/MaineC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaineC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaineC/subscriptions","organizations_url":"https://api.github.com/users/MaineC/orgs","repos_url":"https://api.github.com/users/MaineC/repos","events_url":"https://api.github.com/users/MaineC/events{/privacy}","received_events_url":"https://api.github.com/users/MaineC/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-07-01T08:11:26Z","updated_at":"2015-07-07T10:00:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/11969","html_url":"https://github.com/elastic/elasticsearch/pull/11969","diff_url":"https://github.com/elastic/elasticsearch/pull/11969.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/11969.patch"},"body":"... -Builder/-Parser. This add equals, hashcode, read/write methods, separates toQuery and JSON parsing and adds first tests.\r\n\r\nDeprecates two types of initializing the bounding box: In our documentation we speak about specifying top/left and bottom/right corner of a bounding box. Here we also allow for top/right and bottom/left. This adds not only to the amount of code but also testing needed w/o too much benefit for the user other than more chances to confuse top/right/bottom/left/latitude/longitude IMHO.\r\n\r\nMissing: validation, there are some easy opportunities for cleaning parser and builder.\r\n\r\nThe test path that checks the toQuery method if type is set to \"indexed\" fails at the moment due to missing Guice initialisations. I tried to add everything needed but felt like the result looked a lot like it would actually like to be an ElasticsearchSingleNodeTest so not sure how to proceed here?\r\n\r\nRelates to #10217"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/119151271","html_url":"https://github.com/elastic/elasticsearch/pull/11969#issuecomment-119151271","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11969","id":119151271,"user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T10:00:48Z","updated_at":"2015-07-07T10:00:48Z","body":"wrong Nik @MaineC that should have been @nknize ;)"}}