{"action":"created","issue":{"url":"https://api.github.com/repos/nnnick/Chart.js/issues/677","labels_url":"https://api.github.com/repos/nnnick/Chart.js/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/nnnick/Chart.js/issues/677/comments","events_url":"https://api.github.com/repos/nnnick/Chart.js/issues/677/events","html_url":"https://github.com/nnnick/Chart.js/pull/677","id":45261297,"number":677,"title":"add 10 to yLabelWidth on set, rather than on use","user":{"login":"rylanhalteman","id":2278079,"avatar_url":"https://avatars.githubusercontent.com/u/2278079?v=3","gravatar_id":"","url":"https://api.github.com/users/rylanhalteman","html_url":"https://github.com/rylanhalteman","followers_url":"https://api.github.com/users/rylanhalteman/followers","following_url":"https://api.github.com/users/rylanhalteman/following{/other_user}","gists_url":"https://api.github.com/users/rylanhalteman/gists{/gist_id}","starred_url":"https://api.github.com/users/rylanhalteman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylanhalteman/subscriptions","organizations_url":"https://api.github.com/users/rylanhalteman/orgs","repos_url":"https://api.github.com/users/rylanhalteman/repos","events_url":"https://api.github.com/users/rylanhalteman/events{/privacy}","received_events_url":"https://api.github.com/users/rylanhalteman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nnnick/Chart.js/milestones/2","html_url":"https://github.com/nnnick/Chart.js/milestones/Future","labels_url":"https://api.github.com/repos/nnnick/Chart.js/milestones/2/labels","id":917790,"number":2,"title":"Future","description":"These items are good enough that someone with project access cared to put them into this milestone, but not enough to put them into the NEXT milestone.","creator":{"login":"derekperkins","id":3588778,"avatar_url":"https://avatars.githubusercontent.com/u/3588778?v=3","gravatar_id":"","url":"https://api.github.com/users/derekperkins","html_url":"https://github.com/derekperkins","followers_url":"https://api.github.com/users/derekperkins/followers","following_url":"https://api.github.com/users/derekperkins/following{/other_user}","gists_url":"https://api.github.com/users/derekperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/derekperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekperkins/subscriptions","organizations_url":"https://api.github.com/users/derekperkins/orgs","repos_url":"https://api.github.com/users/derekperkins/repos","events_url":"https://api.github.com/users/derekperkins/events{/privacy}","received_events_url":"https://api.github.com/users/derekperkins/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":17,"state":"open","created_at":"2014-12-30T17:30:46Z","updated_at":"2015-04-30T21:45:50Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2014-10-08T15:54:00Z","updated_at":"2015-05-04T15:54:40Z","closed_at":"2015-04-12T12:06:23Z","pull_request":{"url":"https://api.github.com/repos/nnnick/Chart.js/pulls/677","html_url":"https://github.com/nnnick/Chart.js/pull/677","diff_url":"https://github.com/nnnick/Chart.js/pull/677.diff","patch_url":"https://github.com/nnnick/Chart.js/pull/677.patch"},"body":"Padding on the line chart's y-axis labels can get crowded because when checking the x-axis label rotation (line 1506) it checks for `this.yLabelWidth + 8` rather than `this.yLabelWidth + 10`.\r\nEx:\r\n![screen shot 2014-10-08 at 11 38 08](https://cloud.githubusercontent.com/assets/2278079/4562069/cc7e411a-4f01-11e4-97d3-9979ef334120.png)\r\n\r\nChanging this check to `yLabelWidth + 10` fixes this issue.  However, since the `yLabelWidth` variable is either used to only check against itself (in the `fit()` method, lines 1462 & 1468), or checking against `yLabelWidth + 10` (line 1487 * 2, line 1506), I moved the addition to the setting of `yLabelWidth`, rather than when checking the variable.\r\n\r\nResult:\r\n![screen shot 2014-10-08 at 11 52 47](https://cloud.githubusercontent.com/assets/2278079/4562265/37381944-4f03-11e4-9f43-9e397055a442.png)\r\n\r\nThe result is correctly padded y-axis labels."},"comment":{"url":"https://api.github.com/repos/nnnick/Chart.js/issues/comments/98764210","html_url":"https://github.com/nnnick/Chart.js/pull/677#issuecomment-98764210","issue_url":"https://api.github.com/repos/nnnick/Chart.js/issues/677","id":98764210,"user":{"login":"rylanhalteman","id":2278079,"avatar_url":"https://avatars.githubusercontent.com/u/2278079?v=3","gravatar_id":"","url":"https://api.github.com/users/rylanhalteman","html_url":"https://github.com/rylanhalteman","followers_url":"https://api.github.com/users/rylanhalteman/followers","following_url":"https://api.github.com/users/rylanhalteman/following{/other_user}","gists_url":"https://api.github.com/users/rylanhalteman/gists{/gist_id}","starred_url":"https://api.github.com/users/rylanhalteman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylanhalteman/subscriptions","organizations_url":"https://api.github.com/users/rylanhalteman/orgs","repos_url":"https://api.github.com/users/rylanhalteman/repos","events_url":"https://api.github.com/users/rylanhalteman/events{/privacy}","received_events_url":"https://api.github.com/users/rylanhalteman/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T15:54:40Z","updated_at":"2015-05-04T15:54:40Z","body":"@jakesyl @fulldecent @etimberg My apologies for being unresponsive. I finished my project and was filtering out github emails by mistake. :(  Thanks for the merge!"}}