{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/48444110","id":48444110,"diff_hunk":"@@ -952,7 +987,8 @@ void AuctionBotSeller::AddNewAuctions(SellerConfiguration& config)\n             continue;\n         }\n \n-        uint32 stackCount = urand(1, prototype->GetMaxStackSize());\n+        uint32 stackCount = 1;\n+        SetStackSizeForItem(prototype, config, stackCount);","path":"src/server/game/AuctionHouseBot/AuctionHouseBotSeller.cpp","position":55,"original_position":55,"commit_id":"33a75afb60f8e9ad44c7a87f7f52dae27dab62b6","original_commit_id":"33a75afb60f8e9ad44c7a87f7f52dae27dab62b6","user":{"login":"DDuarte","id":530940,"avatar_url":"https://avatars.githubusercontent.com/u/530940?v=3","gravatar_id":"","url":"https://api.github.com/users/DDuarte","html_url":"https://github.com/DDuarte","followers_url":"https://api.github.com/users/DDuarte/followers","following_url":"https://api.github.com/users/DDuarte/following{/other_user}","gists_url":"https://api.github.com/users/DDuarte/gists{/gist_id}","starred_url":"https://api.github.com/users/DDuarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDuarte/subscriptions","organizations_url":"https://api.github.com/users/DDuarte/orgs","repos_url":"https://api.github.com/users/DDuarte/repos","events_url":"https://api.github.com/users/DDuarte/events{/privacy}","received_events_url":"https://api.github.com/users/DDuarte/received_events","type":"User","site_admin":false},"body":"Make the function return the stackCount instead of using the reference.","created_at":"2015-12-26T01:29:11Z","updated_at":"2015-12-26T01:29:11Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/16101#discussion_r48444110","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/48444110"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16101#discussion_r48444110"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101","id":54595256,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/16101","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/16101.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/16101.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16101","number":16101,"state":"open","locked":false,"title":"Updated AuctionHouseSeller to have item class level stack control","user":{"login":"NathanHandley","id":7952091,"avatar_url":"https://avatars.githubusercontent.com/u/7952091?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanHandley","html_url":"https://github.com/NathanHandley","followers_url":"https://api.github.com/users/NathanHandley/followers","following_url":"https://api.github.com/users/NathanHandley/following{/other_user}","gists_url":"https://api.github.com/users/NathanHandley/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanHandley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanHandley/subscriptions","organizations_url":"https://api.github.com/users/NathanHandley/orgs","repos_url":"https://api.github.com/users/NathanHandley/repos","events_url":"https://api.github.com/users/NathanHandley/events{/privacy}","received_events_url":"https://api.github.com/users/NathanHandley/received_events","type":"User","site_admin":false},"body":"For each item class (consumable, glyph), you can now edit the worldserver.conf to configure the ratio (percent) of random compared to single stack auction postings.  For example,you can configure it so that all Glyphs are non-stacked, gems are sometimes stacked, reagents are always randomly stacked, etc.  I did this locally to give a more blizzlike behavior.\r\n\r\n*Example 1*\r\nAuctionHouseBot.Class.RandomStackRatio.Consumable = 0\r\n- New consumable auctions posted by AuctionHouseSeller will always be single stack (1).\r\n\r\n*Example 2*\r\nAuctionHouseBot.Class.RandomStackRatio.Consumable = 100\r\n- New consumable auctions posted by AuctionHouseSeller will always be of a random stack size (1...n).\r\n\r\n*Example 3*\r\nAuctionHouseBot.Class.RandomStackRatio.Consumable = 20\r\n- New consumable auctions posted by AuctionHouseSeller have a 20% chance of being a random stack size (1...n), and an 80% chance of being single stack size (1).\r\n\r\n_Note:_ This is my first pull request.  I emulated the coding conventions in the files I changed, including terms (ratio).  Please point out anywhere that I egregiously violated the coding guidelines.","created_at":"2015-12-26T01:05:12Z","updated_at":"2015-12-26T01:29:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b28f929a627c657b7dd9acde509f367734a517ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16101/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/33a75afb60f8e9ad44c7a87f7f52dae27dab62b6","head":{"label":"NathanHandley:3.3.5","ref":"3.3.5","sha":"33a75afb60f8e9ad44c7a87f7f52dae27dab62b6","user":{"login":"NathanHandley","id":7952091,"avatar_url":"https://avatars.githubusercontent.com/u/7952091?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanHandley","html_url":"https://github.com/NathanHandley","followers_url":"https://api.github.com/users/NathanHandley/followers","following_url":"https://api.github.com/users/NathanHandley/following{/other_user}","gists_url":"https://api.github.com/users/NathanHandley/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanHandley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanHandley/subscriptions","organizations_url":"https://api.github.com/users/NathanHandley/orgs","repos_url":"https://api.github.com/users/NathanHandley/repos","events_url":"https://api.github.com/users/NathanHandley/events{/privacy}","received_events_url":"https://api.github.com/users/NathanHandley/received_events","type":"User","site_admin":false},"repo":{"id":48594886,"name":"TrinityCore","full_name":"NathanHandley/TrinityCore","owner":{"login":"NathanHandley","id":7952091,"avatar_url":"https://avatars.githubusercontent.com/u/7952091?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanHandley","html_url":"https://github.com/NathanHandley","followers_url":"https://api.github.com/users/NathanHandley/followers","following_url":"https://api.github.com/users/NathanHandley/following{/other_user}","gists_url":"https://api.github.com/users/NathanHandley/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanHandley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanHandley/subscriptions","organizations_url":"https://api.github.com/users/NathanHandley/orgs","repos_url":"https://api.github.com/users/NathanHandley/repos","events_url":"https://api.github.com/users/NathanHandley/events{/privacy}","received_events_url":"https://api.github.com/users/NathanHandley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NathanHandley/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/NathanHandley/TrinityCore","forks_url":"https://api.github.com/repos/NathanHandley/TrinityCore/forks","keys_url":"https://api.github.com/repos/NathanHandley/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NathanHandley/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NathanHandley/TrinityCore/teams","hooks_url":"https://api.github.com/repos/NathanHandley/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/NathanHandley/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/NathanHandley/TrinityCore/events","assignees_url":"https://api.github.com/repos/NathanHandley/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/NathanHandley/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/NathanHandley/TrinityCore/tags","blobs_url":"https://api.github.com/repos/NathanHandley/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NathanHandley/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NathanHandley/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/NathanHandley/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NathanHandley/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/NathanHandley/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/NathanHandley/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/NathanHandley/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/NathanHandley/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/NathanHandley/TrinityCore/subscription","commits_url":"https://api.github.com/repos/NathanHandley/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/NathanHandley/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/NathanHandley/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/NathanHandley/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/NathanHandley/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/NathanHandley/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NathanHandley/TrinityCore/merges","archive_url":"https://api.github.com/repos/NathanHandley/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NathanHandley/TrinityCore/downloads","issues_url":"https://api.github.com/repos/NathanHandley/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/NathanHandley/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/NathanHandley/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/NathanHandley/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NathanHandley/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/NathanHandley/TrinityCore/releases{/id}","created_at":"2015-12-26T00:35:47Z","updated_at":"2015-12-26T00:36:01Z","pushed_at":"2015-12-26T00:54:49Z","git_url":"git://github.com/NathanHandley/TrinityCore.git","ssh_url":"git@github.com:NathanHandley/TrinityCore.git","clone_url":"https://github.com/NathanHandley/TrinityCore.git","svn_url":"https://github.com/NathanHandley/TrinityCore","homepage":"http://www.trinitycore.org","size":366994,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"347373264b4ca5046af5c23378117e6ddb66504d","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-12-23T17:24:10Z","pushed_at":"2015-12-26T01:05:12Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":755423,"stargazers_count":3063,"watchers_count":3063,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3222,"mirror_url":null,"open_issues_count":1270,"forks":3222,"open_issues":1270,"watchers":3063,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16101"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16101"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16101/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16101/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/33a75afb60f8e9ad44c7a87f7f52dae27dab62b6"}}}}