{"action":"created","comment":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/40179537","id":40179537,"diff_hunk":"@@ -30,3 +32,38 @@ var TimeBefore = CheckerFunc{\n func TimeBeforeCaveat(t time.Time) Caveat {\n \treturn firstParty(CondTimeBefore, t.UTC().Format(time.RFC3339Nano))\n }\n+\n+// ExpireTime finds any caveats created by TimeBeforeCaveat and\n+// calculates the time at which the macaroon will no longer be valid. If\n+// there are no such caveats expires will be false, otherwise expires is true.\n+func ExpireTime(cavs []macaroon.Caveat) (t time.Time, expires bool) {\n+\tfor _, cav := range cavs {\n+\t\tif strings.HasPrefix(cav.Id, CondTimeBefore) {\n+\t\t\tet, err := time.Parse(CondTimeBefore+\" \"+time.RFC3339Nano, cav.Id)\n+\t\t\tif err != nil {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tif t.IsZero() || t.After(et) {\n+\t\t\t\tt = et\n+\t\t\t\texpires = true\n+\t\t\t}\n+\t\t}\n+\t}\n+\treturn\n+}\n+\n+// MacaroonsExpireTime finds any caveats created by TimeBeforeCaveat and","path":"bakery/checkers/time.go","position":36,"original_position":36,"commit_id":"5db926f121ce5e3a7866427a42fea98a74620454","original_commit_id":"5db926f121ce5e3a7866427a42fea98a74620454","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-09-23T08:19:53Z","updated_at":"2015-09-23T08:19:53Z","html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65#discussion_r40179537","pull_request_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/40179537"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65#discussion_r40179537"},"pull_request":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65","id":45748766,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65","diff_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65.diff","patch_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65.patch","issue_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/65","number":65,"state":"open","locked":false,"title":"set cookie.Expires based on any time-before caveats","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-23T07:03:50Z","updated_at":"2015-09-23T08:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0893eec25a864f0205c1e8b471a174062fce79b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65/commits","review_comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65/comments","review_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/65/comments","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/5db926f121ce5e3a7866427a42fea98a74620454","head":{"label":"mhilton:008-cookie-expires","ref":"008-cookie-expires","sha":"5db926f121ce5e3a7866427a42fea98a74620454","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"repo":{"id":29598274,"name":"macaroon-bakery","full_name":"mhilton/macaroon-bakery","owner":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhilton/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":true,"url":"https://api.github.com/repos/mhilton/macaroon-bakery","forks_url":"https://api.github.com/repos/mhilton/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/mhilton/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhilton/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhilton/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/mhilton/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/mhilton/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/mhilton/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/mhilton/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/mhilton/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhilton/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/mhilton/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/mhilton/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/mhilton/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/mhilton/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/mhilton/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/mhilton/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhilton/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhilton/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/mhilton/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhilton/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/mhilton/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhilton/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/mhilton/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/mhilton/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/mhilton/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhilton/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/mhilton/macaroon-bakery/releases{/id}","created_at":"2015-01-21T16:15:10Z","updated_at":"2015-01-21T16:15:11Z","pushed_at":"2015-09-23T07:03:03Z","git_url":"git://github.com/mhilton/macaroon-bakery.git","ssh_url":"git@github.com:mhilton/macaroon-bakery.git","clone_url":"https://github.com/mhilton/macaroon-bakery.git","svn_url":"https://github.com/mhilton/macaroon-bakery","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0"}},"base":{"label":"go-macaroon-bakery:v1","ref":"v1","sha":"02515960824f7efa4c3553055877bb2572da7a88","user":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"repo":{"id":26593206,"name":"macaroon-bakery","full_name":"go-macaroon-bakery/macaroon-bakery","owner":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":false,"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery","forks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/releases{/id}","created_at":"2014-11-13T15:08:41Z","updated_at":"2015-06-04T11:37:00Z","pushed_at":"2015-09-23T07:03:50Z","git_url":"git://github.com/go-macaroon-bakery/macaroon-bakery.git","ssh_url":"git@github.com:go-macaroon-bakery/macaroon-bakery.git","clone_url":"https://github.com/go-macaroon-bakery/macaroon-bakery.git","svn_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","homepage":null,"size":792,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":13,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/65"},"issue":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/65"},"comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/5db926f121ce5e3a7866427a42fea98a74620454"}}}}