{"action":"created","comment":{"url":"https://api.github.com/repos/CatalystCode/react-native/pulls/comments/48416177","id":48416177,"diff_hunk":"@@ -0,0 +1,75 @@\n+﻿using ReactNative.Bridge;\n+using ReactNative.Modules.Core;\n+using ReactNative.Tracing;\n+using ReactNative.UIManager;\n+using System;\n+using System.Collections.Generic;\n+using Windows.UI.Xaml;\n+\n+namespace ReactNative\n+{\n+    /// <summary>\n+    /// Package defining core framework modules (e.g., <see cref=\"UIManagerModule\"/>). \n+    /// It should be used for modules that require special integration with\n+    /// other framework parts (e.g., with the list of packages to load view\n+    /// managers from).\n+    /// \n+    /// TODO:\n+    /// 1. Add Core native modules\n+    /// 2. Implement UIManagerModule\n+    /// 3. Add remaining JavaScript modules\n+    /// </summary>\n+    class CoreModulesPackage : IReactPackage","path":"ReactWindows/ReactNative/CoreModulesPackage.cs","position":22,"original_position":22,"commit_id":"c213636e014072938ae7e2705cf5c380e2fda846","original_commit_id":"c213636e014072938ae7e2705cf5c380e2fda846","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"We could consider creating an IReactPackage base class that did some of the type checking that we do in JavaScriptModulesConfig.  We don't have the Class<? extends T> syntax in C#...","created_at":"2015-12-24T14:19:04Z","updated_at":"2015-12-24T14:19:04Z","html_url":"https://github.com/CatalystCode/react-native/pull/30#discussion_r48416177","pull_request_url":"https://api.github.com/repos/CatalystCode/react-native/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/comments/48416177"},"html":{"href":"https://github.com/CatalystCode/react-native/pull/30#discussion_r48416177"},"pull_request":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/CatalystCode/react-native/pulls/30","id":54506087,"html_url":"https://github.com/CatalystCode/react-native/pull/30","diff_url":"https://github.com/CatalystCode/react-native/pull/30.diff","patch_url":"https://github.com/CatalystCode/react-native/pull/30.patch","issue_url":"https://api.github.com/repos/CatalystCode/react-native/issues/30","number":30,"state":"open","locked":false,"title":"Integrate top level ReactInstanceManager changes","user":{"login":"erikschlegel","id":7635865,"avatar_url":"https://avatars.githubusercontent.com/u/7635865?v=3","gravatar_id":"","url":"https://api.github.com/users/erikschlegel","html_url":"https://github.com/erikschlegel","followers_url":"https://api.github.com/users/erikschlegel/followers","following_url":"https://api.github.com/users/erikschlegel/following{/other_user}","gists_url":"https://api.github.com/users/erikschlegel/gists{/gist_id}","starred_url":"https://api.github.com/users/erikschlegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikschlegel/subscriptions","organizations_url":"https://api.github.com/users/erikschlegel/orgs","repos_url":"https://api.github.com/users/erikschlegel/repos","events_url":"https://api.github.com/users/erikschlegel/events{/privacy}","received_events_url":"https://api.github.com/users/erikschlegel/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-23T20:57:45Z","updated_at":"2015-12-24T14:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b60aa509b75e04d444e92e95f0219382b2dfc9be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CatalystCode/react-native/pulls/30/commits","review_comments_url":"https://api.github.com/repos/CatalystCode/react-native/pulls/30/comments","review_comment_url":"https://api.github.com/repos/CatalystCode/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CatalystCode/react-native/issues/30/comments","statuses_url":"https://api.github.com/repos/CatalystCode/react-native/statuses/c213636e014072938ae7e2705cf5c380e2fda846","head":{"label":"CatalystCode:ReactWindows-ES","ref":"ReactWindows-ES","sha":"c213636e014072938ae7e2705cf5c380e2fda846","user":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars.githubusercontent.com/u/12663554?v=3","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native","full_name":"CatalystCode/react-native","owner":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars.githubusercontent.com/u/12663554?v=3","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CatalystCode/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/CatalystCode/react-native","forks_url":"https://api.github.com/repos/CatalystCode/react-native/forks","keys_url":"https://api.github.com/repos/CatalystCode/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CatalystCode/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CatalystCode/react-native/teams","hooks_url":"https://api.github.com/repos/CatalystCode/react-native/hooks","issue_events_url":"https://api.github.com/repos/CatalystCode/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/CatalystCode/react-native/events","assignees_url":"https://api.github.com/repos/CatalystCode/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/CatalystCode/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/CatalystCode/react-native/tags","blobs_url":"https://api.github.com/repos/CatalystCode/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CatalystCode/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CatalystCode/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/CatalystCode/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CatalystCode/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/CatalystCode/react-native/languages","stargazers_url":"https://api.github.com/repos/CatalystCode/react-native/stargazers","contributors_url":"https://api.github.com/repos/CatalystCode/react-native/contributors","subscribers_url":"https://api.github.com/repos/CatalystCode/react-native/subscribers","subscription_url":"https://api.github.com/repos/CatalystCode/react-native/subscription","commits_url":"https://api.github.com/repos/CatalystCode/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/CatalystCode/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/CatalystCode/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/CatalystCode/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/CatalystCode/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/CatalystCode/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CatalystCode/react-native/merges","archive_url":"https://api.github.com/repos/CatalystCode/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CatalystCode/react-native/downloads","issues_url":"https://api.github.com/repos/CatalystCode/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/CatalystCode/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/CatalystCode/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/CatalystCode/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CatalystCode/react-native/labels{/name}","releases_url":"https://api.github.com/repos/CatalystCode/react-native/releases{/id}","created_at":"2015-12-15T00:16:54Z","updated_at":"2015-12-15T15:04:46Z","pushed_at":"2015-12-23T20:57:46Z","git_url":"git://github.com/CatalystCode/react-native.git","ssh_url":"git@github.com:CatalystCode/react-native.git","clone_url":"https://github.com/CatalystCode/react-native.git","svn_url":"https://github.com/CatalystCode/react-native","homepage":"http://facebook.github.io/react-native/","size":36497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"CatalystCode:ReactWindows","ref":"ReactWindows","sha":"4d34ca818b7add73a8eda261c91261a3fe964edf","user":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars.githubusercontent.com/u/12663554?v=3","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native","full_name":"CatalystCode/react-native","owner":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars.githubusercontent.com/u/12663554?v=3","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CatalystCode/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/CatalystCode/react-native","forks_url":"https://api.github.com/repos/CatalystCode/react-native/forks","keys_url":"https://api.github.com/repos/CatalystCode/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CatalystCode/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CatalystCode/react-native/teams","hooks_url":"https://api.github.com/repos/CatalystCode/react-native/hooks","issue_events_url":"https://api.github.com/repos/CatalystCode/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/CatalystCode/react-native/events","assignees_url":"https://api.github.com/repos/CatalystCode/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/CatalystCode/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/CatalystCode/react-native/tags","blobs_url":"https://api.github.com/repos/CatalystCode/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CatalystCode/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CatalystCode/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/CatalystCode/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CatalystCode/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/CatalystCode/react-native/languages","stargazers_url":"https://api.github.com/repos/CatalystCode/react-native/stargazers","contributors_url":"https://api.github.com/repos/CatalystCode/react-native/contributors","subscribers_url":"https://api.github.com/repos/CatalystCode/react-native/subscribers","subscription_url":"https://api.github.com/repos/CatalystCode/react-native/subscription","commits_url":"https://api.github.com/repos/CatalystCode/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/CatalystCode/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/CatalystCode/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/CatalystCode/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/CatalystCode/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/CatalystCode/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CatalystCode/react-native/merges","archive_url":"https://api.github.com/repos/CatalystCode/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CatalystCode/react-native/downloads","issues_url":"https://api.github.com/repos/CatalystCode/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/CatalystCode/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/CatalystCode/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/CatalystCode/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CatalystCode/react-native/labels{/name}","releases_url":"https://api.github.com/repos/CatalystCode/react-native/releases{/id}","created_at":"2015-12-15T00:16:54Z","updated_at":"2015-12-15T15:04:46Z","pushed_at":"2015-12-23T20:57:46Z","git_url":"git://github.com/CatalystCode/react-native.git","ssh_url":"git@github.com:CatalystCode/react-native.git","clone_url":"https://github.com/CatalystCode/react-native.git","svn_url":"https://github.com/CatalystCode/react-native","homepage":"http://facebook.github.io/react-native/","size":36497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/30"},"html":{"href":"https://github.com/CatalystCode/react-native/pull/30"},"issue":{"href":"https://api.github.com/repos/CatalystCode/react-native/issues/30"},"comments":{"href":"https://api.github.com/repos/CatalystCode/react-native/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CatalystCode/react-native/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/CatalystCode/react-native/statuses/c213636e014072938ae7e2705cf5c380e2fda846"}}}}