{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/46231252","id":46231252,"diff_hunk":"@@ -77,6 +76,12 @@ class AmpLightbox extends AMP.BaseElement {\n \n   /** @override */\n   activate() {\n+    /**  @private {function(this:AmpLightbox, Event)}*/\n+    this.boundCloseOnClick_ = event => this.closeOnClick(event);\n+    this.boundCloseOnEscape_ = event => this.closeOnEscape(event);\n+    this.getWin().document.documentElement.addEventListener(","path":"extensions/amp-lightbox/0.1/amp-lightbox.js","position":20,"original_position":20,"commit_id":"c3bf727a69b543aa1d87967fafaef8e7a19c2b62","original_commit_id":"c3bf727a69b543aa1d87967fafaef8e7a19c2b62","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"We'd also want \"ESC\" processing for image lightbox. I'd say, let's get rid of `close` attribute entirely and add `keydown` handler in image lightbox - then they'd work consistently.","created_at":"2015-12-01T01:45:19Z","updated_at":"2015-12-01T01:45:19Z","html_url":"https://github.com/ampproject/amphtml/pull/1029#discussion_r46231252","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1029","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/46231252"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1029#discussion_r46231252"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1029"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/1029","id":52190782,"html_url":"https://github.com/ampproject/amphtml/pull/1029","diff_url":"https://github.com/ampproject/amphtml/pull/1029.diff","patch_url":"https://github.com/ampproject/amphtml/pull/1029.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1029","number":1029,"state":"open","locked":false,"title":"Lightbox(es) should support exiting","user":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"body":" - When ESC key is hit\r\n - When a child element with `close` attribute is clicked\r\n - When a child element with on attribute is set to \"tap:lightbox-id.close\"\r\nRemove functionality that closes lightbox when tapped anywhere.\r\n\r\nThis is being tracked in #342 ","created_at":"2015-11-30T22:46:59Z","updated_at":"2015-12-01T01:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9773fa5be47b27b7b8c28cf63aad6f5aa90d6f7b","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1029/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1029/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1029/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/c3bf727a69b543aa1d87967fafaef8e7a19c2b62","head":{"label":"sriramkrish85:lightbox","ref":"lightbox","sha":"c3bf727a69b543aa1d87967fafaef8e7a19c2b62","user":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"repo":{"id":44337813,"name":"amphtml","full_name":"sriramkrish85/amphtml","owner":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sriramkrish85/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/sriramkrish85/amphtml","forks_url":"https://api.github.com/repos/sriramkrish85/amphtml/forks","keys_url":"https://api.github.com/repos/sriramkrish85/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sriramkrish85/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sriramkrish85/amphtml/teams","hooks_url":"https://api.github.com/repos/sriramkrish85/amphtml/hooks","issue_events_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/sriramkrish85/amphtml/events","assignees_url":"https://api.github.com/repos/sriramkrish85/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/sriramkrish85/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/sriramkrish85/amphtml/tags","blobs_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sriramkrish85/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/sriramkrish85/amphtml/languages","stargazers_url":"https://api.github.com/repos/sriramkrish85/amphtml/stargazers","contributors_url":"https://api.github.com/repos/sriramkrish85/amphtml/contributors","subscribers_url":"https://api.github.com/repos/sriramkrish85/amphtml/subscribers","subscription_url":"https://api.github.com/repos/sriramkrish85/amphtml/subscription","commits_url":"https://api.github.com/repos/sriramkrish85/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/sriramkrish85/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/sriramkrish85/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/sriramkrish85/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sriramkrish85/amphtml/merges","archive_url":"https://api.github.com/repos/sriramkrish85/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sriramkrish85/amphtml/downloads","issues_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/sriramkrish85/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/sriramkrish85/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/sriramkrish85/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sriramkrish85/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/sriramkrish85/amphtml/releases{/id}","created_at":"2015-10-15T18:39:52Z","updated_at":"2015-10-15T18:39:54Z","pushed_at":"2015-11-30T23:01:28Z","git_url":"git://github.com/sriramkrish85/amphtml.git","ssh_url":"git@github.com:sriramkrish85/amphtml.git","clone_url":"https://github.com/sriramkrish85/amphtml.git","svn_url":"https://github.com/sriramkrish85/amphtml","homepage":"https://ampproject.org","size":13812,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"f0159666c43652067886bf48cfcb81c86d6ee6a8","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","created_at":"2015-09-01T22:10:53Z","updated_at":"2015-11-30T23:48:20Z","pushed_at":"2015-12-01T01:43:29Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":14843,"stargazers_count":4788,"watchers_count":4788,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":448,"mirror_url":null,"open_issues_count":146,"forks":448,"open_issues":146,"watchers":4788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1029"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1029"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1029"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1029/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1029/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1029/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/c3bf727a69b543aa1d87967fafaef8e7a19c2b62"}}}}