{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33","id":30275334,"html_url":"https://github.com/bcosca/fatfree-core/pull/33","diff_url":"https://github.com/bcosca/fatfree-core/pull/33.diff","patch_url":"https://github.com/bcosca/fatfree-core/pull/33.patch","issue_url":"https://api.github.com/repos/bcosca/fatfree-core/issues/33","number":33,"state":"closed","locked":false,"title":"Reroute: code reduction + fix","user":{"login":"xfra35","id":1838531,"avatar_url":"https://avatars.githubusercontent.com/u/1838531?v=3","gravatar_id":"","url":"https://api.github.com/users/xfra35","html_url":"https://github.com/xfra35","followers_url":"https://api.github.com/users/xfra35/followers","following_url":"https://api.github.com/users/xfra35/following{/other_user}","gists_url":"https://api.github.com/users/xfra35/gists{/gist_id}","starred_url":"https://api.github.com/users/xfra35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfra35/subscriptions","organizations_url":"https://api.github.com/users/xfra35/orgs","repos_url":"https://api.github.com/users/xfra35/repos","events_url":"https://api.github.com/users/xfra35/events{/privacy}","received_events_url":"https://api.github.com/users/xfra35/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nin order for the `REROUTE` hook to receive the same kind of arguments as `$f3->reroute`, we should add the `BASE` prefix *after* calling the hook.\r\n\r\nSee [this test](https://github.com/bcosca/fatfree/blob/dev/app/router.php#L31) which was failing in a subfolder environment.","created_at":"2015-03-02T11:17:31Z","updated_at":"2015-03-05T01:42:49Z","closed_at":"2015-03-05T01:42:49Z","merged_at":"2015-03-05T01:42:49Z","merge_commit_sha":"80f7e993dd3e990a723bc17faff26b0eeecfcddd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33/commits","review_comments_url":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33/comments","review_comment_url":"https://api.github.com/repos/bcosca/fatfree-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcosca/fatfree-core/issues/33/comments","statuses_url":"https://api.github.com/repos/bcosca/fatfree-core/statuses/6152a2d3196fc380d97678c661265ab31c3742f2","head":{"label":"xfra35:issue33","ref":"issue33","sha":"6152a2d3196fc380d97678c661265ab31c3742f2","user":{"login":"xfra35","id":1838531,"avatar_url":"https://avatars.githubusercontent.com/u/1838531?v=3","gravatar_id":"","url":"https://api.github.com/users/xfra35","html_url":"https://github.com/xfra35","followers_url":"https://api.github.com/users/xfra35/followers","following_url":"https://api.github.com/users/xfra35/following{/other_user}","gists_url":"https://api.github.com/users/xfra35/gists{/gist_id}","starred_url":"https://api.github.com/users/xfra35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfra35/subscriptions","organizations_url":"https://api.github.com/users/xfra35/orgs","repos_url":"https://api.github.com/users/xfra35/repos","events_url":"https://api.github.com/users/xfra35/events{/privacy}","received_events_url":"https://api.github.com/users/xfra35/received_events","type":"User","site_admin":false},"repo":{"id":26635783,"name":"fatfree-core","full_name":"xfra35/fatfree-core","owner":{"login":"xfra35","id":1838531,"avatar_url":"https://avatars.githubusercontent.com/u/1838531?v=3","gravatar_id":"","url":"https://api.github.com/users/xfra35","html_url":"https://github.com/xfra35","followers_url":"https://api.github.com/users/xfra35/followers","following_url":"https://api.github.com/users/xfra35/following{/other_user}","gists_url":"https://api.github.com/users/xfra35/gists{/gist_id}","starred_url":"https://api.github.com/users/xfra35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfra35/subscriptions","organizations_url":"https://api.github.com/users/xfra35/orgs","repos_url":"https://api.github.com/users/xfra35/repos","events_url":"https://api.github.com/users/xfra35/events{/privacy}","received_events_url":"https://api.github.com/users/xfra35/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xfra35/fatfree-core","description":"Fat-Free Framework core library","fork":true,"url":"https://api.github.com/repos/xfra35/fatfree-core","forks_url":"https://api.github.com/repos/xfra35/fatfree-core/forks","keys_url":"https://api.github.com/repos/xfra35/fatfree-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xfra35/fatfree-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xfra35/fatfree-core/teams","hooks_url":"https://api.github.com/repos/xfra35/fatfree-core/hooks","issue_events_url":"https://api.github.com/repos/xfra35/fatfree-core/issues/events{/number}","events_url":"https://api.github.com/repos/xfra35/fatfree-core/events","assignees_url":"https://api.github.com/repos/xfra35/fatfree-core/assignees{/user}","branches_url":"https://api.github.com/repos/xfra35/fatfree-core/branches{/branch}","tags_url":"https://api.github.com/repos/xfra35/fatfree-core/tags","blobs_url":"https://api.github.com/repos/xfra35/fatfree-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xfra35/fatfree-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xfra35/fatfree-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xfra35/fatfree-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xfra35/fatfree-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xfra35/fatfree-core/languages","stargazers_url":"https://api.github.com/repos/xfra35/fatfree-core/stargazers","contributors_url":"https://api.github.com/repos/xfra35/fatfree-core/contributors","subscribers_url":"https://api.github.com/repos/xfra35/fatfree-core/subscribers","subscription_url":"https://api.github.com/repos/xfra35/fatfree-core/subscription","commits_url":"https://api.github.com/repos/xfra35/fatfree-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xfra35/fatfree-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xfra35/fatfree-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xfra35/fatfree-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xfra35/fatfree-core/contents/{+path}","compare_url":"https://api.github.com/repos/xfra35/fatfree-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xfra35/fatfree-core/merges","archive_url":"https://api.github.com/repos/xfra35/fatfree-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xfra35/fatfree-core/downloads","issues_url":"https://api.github.com/repos/xfra35/fatfree-core/issues{/number}","pulls_url":"https://api.github.com/repos/xfra35/fatfree-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xfra35/fatfree-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xfra35/fatfree-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xfra35/fatfree-core/labels{/name}","releases_url":"https://api.github.com/repos/xfra35/fatfree-core/releases{/id}","created_at":"2014-11-14T11:29:53Z","updated_at":"2015-02-18T13:47:06Z","pushed_at":"2015-03-02T11:07:03Z","git_url":"git://github.com/xfra35/fatfree-core.git","ssh_url":"git@github.com:xfra35/fatfree-core.git","clone_url":"https://github.com/xfra35/fatfree-core.git","svn_url":"https://github.com/xfra35/fatfree-core","homepage":null,"size":11044,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bcosca:master","ref":"master","sha":"f2a1a50b24a6138cceeafa321cea303061f4d7cd","user":{"login":"bcosca","id":199570,"avatar_url":"https://avatars.githubusercontent.com/u/199570?v=3","gravatar_id":"","url":"https://api.github.com/users/bcosca","html_url":"https://github.com/bcosca","followers_url":"https://api.github.com/users/bcosca/followers","following_url":"https://api.github.com/users/bcosca/following{/other_user}","gists_url":"https://api.github.com/users/bcosca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcosca/subscriptions","organizations_url":"https://api.github.com/users/bcosca/orgs","repos_url":"https://api.github.com/users/bcosca/repos","events_url":"https://api.github.com/users/bcosca/events{/privacy}","received_events_url":"https://api.github.com/users/bcosca/received_events","type":"User","site_admin":false},"repo":{"id":26320119,"name":"fatfree-core","full_name":"bcosca/fatfree-core","owner":{"login":"bcosca","id":199570,"avatar_url":"https://avatars.githubusercontent.com/u/199570?v=3","gravatar_id":"","url":"https://api.github.com/users/bcosca","html_url":"https://github.com/bcosca","followers_url":"https://api.github.com/users/bcosca/followers","following_url":"https://api.github.com/users/bcosca/following{/other_user}","gists_url":"https://api.github.com/users/bcosca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcosca/subscriptions","organizations_url":"https://api.github.com/users/bcosca/orgs","repos_url":"https://api.github.com/users/bcosca/repos","events_url":"https://api.github.com/users/bcosca/events{/privacy}","received_events_url":"https://api.github.com/users/bcosca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcosca/fatfree-core","description":"Fat-Free Framework core library","fork":false,"url":"https://api.github.com/repos/bcosca/fatfree-core","forks_url":"https://api.github.com/repos/bcosca/fatfree-core/forks","keys_url":"https://api.github.com/repos/bcosca/fatfree-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcosca/fatfree-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcosca/fatfree-core/teams","hooks_url":"https://api.github.com/repos/bcosca/fatfree-core/hooks","issue_events_url":"https://api.github.com/repos/bcosca/fatfree-core/issues/events{/number}","events_url":"https://api.github.com/repos/bcosca/fatfree-core/events","assignees_url":"https://api.github.com/repos/bcosca/fatfree-core/assignees{/user}","branches_url":"https://api.github.com/repos/bcosca/fatfree-core/branches{/branch}","tags_url":"https://api.github.com/repos/bcosca/fatfree-core/tags","blobs_url":"https://api.github.com/repos/bcosca/fatfree-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcosca/fatfree-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcosca/fatfree-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcosca/fatfree-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcosca/fatfree-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bcosca/fatfree-core/languages","stargazers_url":"https://api.github.com/repos/bcosca/fatfree-core/stargazers","contributors_url":"https://api.github.com/repos/bcosca/fatfree-core/contributors","subscribers_url":"https://api.github.com/repos/bcosca/fatfree-core/subscribers","subscription_url":"https://api.github.com/repos/bcosca/fatfree-core/subscription","commits_url":"https://api.github.com/repos/bcosca/fatfree-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcosca/fatfree-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcosca/fatfree-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcosca/fatfree-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcosca/fatfree-core/contents/{+path}","compare_url":"https://api.github.com/repos/bcosca/fatfree-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcosca/fatfree-core/merges","archive_url":"https://api.github.com/repos/bcosca/fatfree-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcosca/fatfree-core/downloads","issues_url":"https://api.github.com/repos/bcosca/fatfree-core/issues{/number}","pulls_url":"https://api.github.com/repos/bcosca/fatfree-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bcosca/fatfree-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bcosca/fatfree-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcosca/fatfree-core/labels{/name}","releases_url":"https://api.github.com/repos/bcosca/fatfree-core/releases{/id}","created_at":"2014-11-07T13:08:48Z","updated_at":"2015-03-05T01:42:49Z","pushed_at":"2015-03-05T01:42:49Z","git_url":"git://github.com/bcosca/fatfree-core.git","ssh_url":"git@github.com:bcosca/fatfree-core.git","clone_url":"https://github.com/bcosca/fatfree-core.git","svn_url":"https://github.com/bcosca/fatfree-core","homepage":null,"size":11459,"stargazers_count":14,"watchers_count":14,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33"},"html":{"href":"https://github.com/bcosca/fatfree-core/pull/33"},"issue":{"href":"https://api.github.com/repos/bcosca/fatfree-core/issues/33"},"comments":{"href":"https://api.github.com/repos/bcosca/fatfree-core/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/bcosca/fatfree-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcosca/fatfree-core/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/bcosca/fatfree-core/statuses/6152a2d3196fc380d97678c661265ab31c3742f2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bcosca","id":199570,"avatar_url":"https://avatars.githubusercontent.com/u/199570?v=3","gravatar_id":"","url":"https://api.github.com/users/bcosca","html_url":"https://github.com/bcosca","followers_url":"https://api.github.com/users/bcosca/followers","following_url":"https://api.github.com/users/bcosca/following{/other_user}","gists_url":"https://api.github.com/users/bcosca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcosca/subscriptions","organizations_url":"https://api.github.com/users/bcosca/orgs","repos_url":"https://api.github.com/users/bcosca/repos","events_url":"https://api.github.com/users/bcosca/events{/privacy}","received_events_url":"https://api.github.com/users/bcosca/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":10,"changed_files":1}}