{"action":"created","comment":{"url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/comments/30795432","id":30795432,"diff_hunk":"@@ -60,6 +59,10 @@ export default Ember.ArrayProxy.extend({\n     }\n   },\n \n+  _totalCount: Ember.computed(function() {\n+    return parseInt(this.get('totalCount'));\n+  }).property('totalCount'),\n+","path":"addon/models/lazy-array.js","position":43,"original_position":43,"commit_id":"f2c8a1ca939487f125db44efe097f5e9a22ef8f5","original_commit_id":"f2c8a1ca939487f125db44efe097f5e9a22ef8f5","user":{"login":"jefflage","id":1093605,"avatar_url":"https://avatars.githubusercontent.com/u/1093605?v=3","gravatar_id":"","url":"https://api.github.com/users/jefflage","html_url":"https://github.com/jefflage","followers_url":"https://api.github.com/users/jefflage/followers","following_url":"https://api.github.com/users/jefflage/following{/other_user}","gists_url":"https://api.github.com/users/jefflage/gists{/gist_id}","starred_url":"https://api.github.com/users/jefflage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefflage/subscriptions","organizations_url":"https://api.github.com/users/jefflage/orgs","repos_url":"https://api.github.com/users/jefflage/repos","events_url":"https://api.github.com/users/jefflage/events{/privacy}","received_events_url":"https://api.github.com/users/jefflage/received_events","type":"User","site_admin":false},"body":"why do we need to protect for `totalCount` being a string?","created_at":"2015-05-21T12:09:38Z","updated_at":"2015-05-21T12:09:38Z","html_url":"https://github.com/hedgeserv/ember-table-addon/pull/15#discussion_r30795432","pull_request_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/comments/30795432"},"html":{"href":"https://github.com/hedgeserv/ember-table-addon/pull/15#discussion_r30795432"},"pull_request":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15","id":35902438,"html_url":"https://github.com/hedgeserv/ember-table-addon/pull/15","diff_url":"https://github.com/hedgeserv/ember-table-addon/pull/15.diff","patch_url":"https://github.com/hedgeserv/ember-table-addon/pull/15.patch","issue_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/15","number":15,"state":"open","locked":false,"title":"allow totalcount to be string.","user":{"login":"cyjia","id":462308,"avatar_url":"https://avatars.githubusercontent.com/u/462308?v=3","gravatar_id":"","url":"https://api.github.com/users/cyjia","html_url":"https://github.com/cyjia","followers_url":"https://api.github.com/users/cyjia/followers","following_url":"https://api.github.com/users/cyjia/following{/other_user}","gists_url":"https://api.github.com/users/cyjia/gists{/gist_id}","starred_url":"https://api.github.com/users/cyjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyjia/subscriptions","organizations_url":"https://api.github.com/users/cyjia/orgs","repos_url":"https://api.github.com/users/cyjia/repos","events_url":"https://api.github.com/users/cyjia/events{/privacy}","received_events_url":"https://api.github.com/users/cyjia/received_events","type":"User","site_admin":false},"body":"With totalCount be String, `new Array(\"100\")` will result in an Array with first element `\"100\"`.","created_at":"2015-05-21T06:05:48Z","updated_at":"2015-05-21T12:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2e3e5bd255773d6ccb07d248e82b1d51aa2b7e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15/commits","review_comments_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15/comments","review_comment_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/15/comments","statuses_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/statuses/f2c8a1ca939487f125db44efe097f5e9a22ef8f5","head":{"label":"cyjia:lazy-array-totalcount","ref":"lazy-array-totalcount","sha":"f2c8a1ca939487f125db44efe097f5e9a22ef8f5","user":{"login":"cyjia","id":462308,"avatar_url":"https://avatars.githubusercontent.com/u/462308?v=3","gravatar_id":"","url":"https://api.github.com/users/cyjia","html_url":"https://github.com/cyjia","followers_url":"https://api.github.com/users/cyjia/followers","following_url":"https://api.github.com/users/cyjia/following{/other_user}","gists_url":"https://api.github.com/users/cyjia/gists{/gist_id}","starred_url":"https://api.github.com/users/cyjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyjia/subscriptions","organizations_url":"https://api.github.com/users/cyjia/orgs","repos_url":"https://api.github.com/users/cyjia/repos","events_url":"https://api.github.com/users/cyjia/events{/privacy}","received_events_url":"https://api.github.com/users/cyjia/received_events","type":"User","site_admin":false},"repo":{"id":34644843,"name":"ember-table-addon","full_name":"cyjia/ember-table-addon","owner":{"login":"cyjia","id":462308,"avatar_url":"https://avatars.githubusercontent.com/u/462308?v=3","gravatar_id":"","url":"https://api.github.com/users/cyjia","html_url":"https://github.com/cyjia","followers_url":"https://api.github.com/users/cyjia/followers","following_url":"https://api.github.com/users/cyjia/following{/other_user}","gists_url":"https://api.github.com/users/cyjia/gists{/gist_id}","starred_url":"https://api.github.com/users/cyjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyjia/subscriptions","organizations_url":"https://api.github.com/users/cyjia/orgs","repos_url":"https://api.github.com/users/cyjia/repos","events_url":"https://api.github.com/users/cyjia/events{/privacy}","received_events_url":"https://api.github.com/users/cyjia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyjia/ember-table-addon","description":"","fork":true,"url":"https://api.github.com/repos/cyjia/ember-table-addon","forks_url":"https://api.github.com/repos/cyjia/ember-table-addon/forks","keys_url":"https://api.github.com/repos/cyjia/ember-table-addon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyjia/ember-table-addon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyjia/ember-table-addon/teams","hooks_url":"https://api.github.com/repos/cyjia/ember-table-addon/hooks","issue_events_url":"https://api.github.com/repos/cyjia/ember-table-addon/issues/events{/number}","events_url":"https://api.github.com/repos/cyjia/ember-table-addon/events","assignees_url":"https://api.github.com/repos/cyjia/ember-table-addon/assignees{/user}","branches_url":"https://api.github.com/repos/cyjia/ember-table-addon/branches{/branch}","tags_url":"https://api.github.com/repos/cyjia/ember-table-addon/tags","blobs_url":"https://api.github.com/repos/cyjia/ember-table-addon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyjia/ember-table-addon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyjia/ember-table-addon/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyjia/ember-table-addon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyjia/ember-table-addon/statuses/{sha}","languages_url":"https://api.github.com/repos/cyjia/ember-table-addon/languages","stargazers_url":"https://api.github.com/repos/cyjia/ember-table-addon/stargazers","contributors_url":"https://api.github.com/repos/cyjia/ember-table-addon/contributors","subscribers_url":"https://api.github.com/repos/cyjia/ember-table-addon/subscribers","subscription_url":"https://api.github.com/repos/cyjia/ember-table-addon/subscription","commits_url":"https://api.github.com/repos/cyjia/ember-table-addon/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyjia/ember-table-addon/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyjia/ember-table-addon/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyjia/ember-table-addon/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyjia/ember-table-addon/contents/{+path}","compare_url":"https://api.github.com/repos/cyjia/ember-table-addon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyjia/ember-table-addon/merges","archive_url":"https://api.github.com/repos/cyjia/ember-table-addon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyjia/ember-table-addon/downloads","issues_url":"https://api.github.com/repos/cyjia/ember-table-addon/issues{/number}","pulls_url":"https://api.github.com/repos/cyjia/ember-table-addon/pulls{/number}","milestones_url":"https://api.github.com/repos/cyjia/ember-table-addon/milestones{/number}","notifications_url":"https://api.github.com/repos/cyjia/ember-table-addon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyjia/ember-table-addon/labels{/name}","releases_url":"https://api.github.com/repos/cyjia/ember-table-addon/releases{/id}","created_at":"2015-04-27T03:54:03Z","updated_at":"2015-04-27T07:29:12Z","pushed_at":"2015-05-21T06:03:40Z","git_url":"git://github.com/cyjia/ember-table-addon.git","ssh_url":"git@github.com:cyjia/ember-table-addon.git","clone_url":"https://github.com/cyjia/ember-table-addon.git","svn_url":"https://github.com/cyjia/ember-table-addon","homepage":null,"size":3966,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hedgeserv:master","ref":"master","sha":"f443172a9b7a4de7870d9a16dfb29198824e8d60","user":{"login":"hedgeserv","id":9663190,"avatar_url":"https://avatars.githubusercontent.com/u/9663190?v=3","gravatar_id":"","url":"https://api.github.com/users/hedgeserv","html_url":"https://github.com/hedgeserv","followers_url":"https://api.github.com/users/hedgeserv/followers","following_url":"https://api.github.com/users/hedgeserv/following{/other_user}","gists_url":"https://api.github.com/users/hedgeserv/gists{/gist_id}","starred_url":"https://api.github.com/users/hedgeserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedgeserv/subscriptions","organizations_url":"https://api.github.com/users/hedgeserv/orgs","repos_url":"https://api.github.com/users/hedgeserv/repos","events_url":"https://api.github.com/users/hedgeserv/events{/privacy}","received_events_url":"https://api.github.com/users/hedgeserv/received_events","type":"Organization","site_admin":false},"repo":{"id":34483078,"name":"ember-table-addon","full_name":"hedgeserv/ember-table-addon","owner":{"login":"hedgeserv","id":9663190,"avatar_url":"https://avatars.githubusercontent.com/u/9663190?v=3","gravatar_id":"","url":"https://api.github.com/users/hedgeserv","html_url":"https://github.com/hedgeserv","followers_url":"https://api.github.com/users/hedgeserv/followers","following_url":"https://api.github.com/users/hedgeserv/following{/other_user}","gists_url":"https://api.github.com/users/hedgeserv/gists{/gist_id}","starred_url":"https://api.github.com/users/hedgeserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedgeserv/subscriptions","organizations_url":"https://api.github.com/users/hedgeserv/orgs","repos_url":"https://api.github.com/users/hedgeserv/repos","events_url":"https://api.github.com/users/hedgeserv/events{/privacy}","received_events_url":"https://api.github.com/users/hedgeserv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hedgeserv/ember-table-addon","description":"","fork":true,"url":"https://api.github.com/repos/hedgeserv/ember-table-addon","forks_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/forks","keys_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/teams","hooks_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/hooks","issue_events_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/events{/number}","events_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/events","assignees_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/assignees{/user}","branches_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/branches{/branch}","tags_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/tags","blobs_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/git/refs{/sha}","trees_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/statuses/{sha}","languages_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/languages","stargazers_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/stargazers","contributors_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/contributors","subscribers_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/subscribers","subscription_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/subscription","commits_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/commits{/sha}","git_commits_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/git/commits{/sha}","comments_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/comments{/number}","issue_comment_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/comments{/number}","contents_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/contents/{+path}","compare_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/merges","archive_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/downloads","issues_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues{/number}","pulls_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls{/number}","milestones_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/milestones{/number}","notifications_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/labels{/name}","releases_url":"https://api.github.com/repos/hedgeserv/ember-table-addon/releases{/id}","created_at":"2015-04-23T21:42:38Z","updated_at":"2015-05-20T02:07:30Z","pushed_at":"2015-05-21T06:10:16Z","git_url":"git://github.com/hedgeserv/ember-table-addon.git","ssh_url":"git@github.com:hedgeserv/ember-table-addon.git","clone_url":"https://github.com/hedgeserv/ember-table-addon.git","svn_url":"https://github.com/hedgeserv/ember-table-addon","homepage":null,"size":4334,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15"},"html":{"href":"https://github.com/hedgeserv/ember-table-addon/pull/15"},"issue":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/15"},"comments":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/hedgeserv/ember-table-addon/statuses/f2c8a1ca939487f125db44efe097f5e9a22ef8f5"}}}}