{"action":"closed","number":1679,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/1679","id":48700999,"html_url":"https://github.com/systemd/systemd/pull/1679","diff_url":"https://github.com/systemd/systemd/pull/1679.diff","patch_url":"https://github.com/systemd/systemd/pull/1679.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/1679","number":1679,"state":"closed","locked":false,"title":"core: don't allow manual start with reload-or-restart too","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"body":"[`systemctl reload-or-restart`](http://www.freedesktop.org/software/systemd/man/systemctl.html#reload-or-restart%20PATTERN...) starts a service with [`RefuseManualStart=yes`](http://www.freedesktop.org/software/systemd/man/systemd.unit.html#RefuseManualStart=)\r\n\r\nHow to reproduce:\r\n```sh\r\nroot@jessie-64:~# systemctl cat refuse-start\r\n# /etc/systemd/system/refuse-start.service\r\n[Unit]\r\nRefuseManualStart=yes\r\n\r\n[Service]\r\nExecStart=/bin/sh -c 'while :; do echo Hola!; sleep 5; done'\r\nExecReload=/bin/true\r\n\r\nroot@jessie-64:~# systemctl status refuse-start\r\n● refuse-start.service\r\n   Loaded: loaded (/etc/systemd/system/refuse-start.service; static; vendor preset: enabled)\r\n   Active: inactive (dead)\r\n\r\nroot@jessie-64:~# systemctl start refuse-start\r\nFailed to start refuse-start.service: Operation refused, unit refuse-start.service may be requested by dependency only.\r\n\r\nroot@jessie-64:~# systemctl reload-or-restart refuse-start\r\n\r\nroot@jessie-64:~# systemctl status refuse-start\r\n● refuse-start.service\r\n   Loaded: loaded (/etc/systemd/system/refuse-start.service; static; vendor preset: enabled)\r\n   Active: active (running) since Mon 2015-10-26 04:35:27 UTC; 7s ago\r\n Main PID: 55 (sh)\r\n   CGroup: /machine.slice/machine-sid\\x2droot.scope/system.slice/refuse-start.service\r\n           ├─55 /bin/sh -c while :; do echo Hola!; sleep 5; done\r\n           └─57 sleep 5\r\n\r\nOct 26 04:35:27 jessie-64 systemd[1]: Started refuse-start.service.\r\nOct 26 04:35:27 jessie-64 sh[55]: Hola!\r\nOct 26 04:35:32 jessie-64 sh[55]: Hola!\r\n```","created_at":"2015-10-26T04:37:18Z","updated_at":"2015-10-26T16:53:59Z","closed_at":"2015-10-26T16:53:59Z","merged_at":"2015-10-26T16:53:59Z","merge_commit_sha":"08674fd0597ba202fa424647ec6bb571e935c1d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/1679/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/1679/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/1679/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/efb30ba1a6476240688b218224ac22c0fa77b8d7","head":{"label":"evverx:refuse-manual-start-by-reload-or-restart","ref":"refuse-manual-start-by-reload-or-restart","sha":"efb30ba1a6476240688b218224ac22c0fa77b8d7","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"repo":{"id":40683534,"name":"systemd","full_name":"evverx/systemd","owner":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evverx/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/evverx/systemd","forks_url":"https://api.github.com/repos/evverx/systemd/forks","keys_url":"https://api.github.com/repos/evverx/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evverx/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evverx/systemd/teams","hooks_url":"https://api.github.com/repos/evverx/systemd/hooks","issue_events_url":"https://api.github.com/repos/evverx/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/evverx/systemd/events","assignees_url":"https://api.github.com/repos/evverx/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/evverx/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/evverx/systemd/tags","blobs_url":"https://api.github.com/repos/evverx/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evverx/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evverx/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/evverx/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evverx/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/evverx/systemd/languages","stargazers_url":"https://api.github.com/repos/evverx/systemd/stargazers","contributors_url":"https://api.github.com/repos/evverx/systemd/contributors","subscribers_url":"https://api.github.com/repos/evverx/systemd/subscribers","subscription_url":"https://api.github.com/repos/evverx/systemd/subscription","commits_url":"https://api.github.com/repos/evverx/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/evverx/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/evverx/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/evverx/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/evverx/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/evverx/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evverx/systemd/merges","archive_url":"https://api.github.com/repos/evverx/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evverx/systemd/downloads","issues_url":"https://api.github.com/repos/evverx/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/evverx/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/evverx/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/evverx/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evverx/systemd/labels{/name}","releases_url":"https://api.github.com/repos/evverx/systemd/releases{/id}","created_at":"2015-08-13T21:54:29Z","updated_at":"2015-08-13T21:54:34Z","pushed_at":"2015-10-26T04:31:14Z","git_url":"git://github.com/evverx/systemd.git","ssh_url":"git@github.com:evverx/systemd.git","clone_url":"https://github.com/evverx/systemd.git","svn_url":"https://github.com/evverx/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":43454,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"e05ac0557f10536c213bf93a3e23e1c82de288bb","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","created_at":"2015-03-25T15:27:27Z","updated_at":"2015-10-26T15:39:48Z","pushed_at":"2015-10-26T16:54:00Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":55405,"stargazers_count":645,"watchers_count":645,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":220,"forks":243,"open_issues":220,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1679"},"html":{"href":"https://github.com/systemd/systemd/pull/1679"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/1679"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/1679/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1679/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1679/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/efb30ba1a6476240688b218224ac22c0fa77b8d7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}