{"action":"opened","number":413,"pull_request":{"url":"https://api.github.com/repos/yhat/ggplot/pulls/413","id":31279857,"html_url":"https://github.com/yhat/ggplot/pull/413","diff_url":"https://github.com/yhat/ggplot/pull/413.diff","patch_url":"https://github.com/yhat/ggplot/pull/413.patch","issue_url":"https://api.github.com/repos/yhat/ggplot/issues/413","number":413,"state":"open","locked":false,"title":"fix legend not being displayed due to wrong axes reference","user":{"login":"aufziehvogel","id":3071022,"avatar_url":"https://avatars.githubusercontent.com/u/3071022?v=3","gravatar_id":"","url":"https://api.github.com/users/aufziehvogel","html_url":"https://github.com/aufziehvogel","followers_url":"https://api.github.com/users/aufziehvogel/followers","following_url":"https://api.github.com/users/aufziehvogel/following{/other_user}","gists_url":"https://api.github.com/users/aufziehvogel/gists{/gist_id}","starred_url":"https://api.github.com/users/aufziehvogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aufziehvogel/subscriptions","organizations_url":"https://api.github.com/users/aufziehvogel/orgs","repos_url":"https://api.github.com/users/aufziehvogel/repos","events_url":"https://api.github.com/users/aufziehvogel/events{/privacy}","received_events_url":"https://api.github.com/users/aufziehvogel/received_events","type":"User","site_admin":false},"body":"Over here legend was not being displayed. Debugging the behaviour showed me, that the references to the axes seemed to be different. The legend box was added correctly to the `ax` object in the `if self.legend:` block, but the `ax = axs[0][self.n_rows - 1]` object seemed to be different from the `for ax in plt.gcf().axes` references (both `plt.gcf().axes` and `axs` had only one element).\r\n\r\nOne was printed as `Axes(0.125,0.1;0.62x0.8)`, the other was printed as `Axes(0.125,0.1;0.775x0.8)`. So the reference seemed to be different, the legend was added to the wrong element.\r\n\r\nThe line replacement from the pull request works on my PC (but I do not know if it has any side effects on other visualizations!).","created_at":"2015-03-16T20:12:12Z","updated_at":"2015-03-16T20:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yhat/ggplot/pulls/413/commits","review_comments_url":"https://api.github.com/repos/yhat/ggplot/pulls/413/comments","review_comment_url":"https://api.github.com/repos/yhat/ggplot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yhat/ggplot/issues/413/comments","statuses_url":"https://api.github.com/repos/yhat/ggplot/statuses/9216b5d722a0f95b15c298462d7fc324eda1d136","head":{"label":"aufziehvogel:master","ref":"master","sha":"9216b5d722a0f95b15c298462d7fc324eda1d136","user":{"login":"aufziehvogel","id":3071022,"avatar_url":"https://avatars.githubusercontent.com/u/3071022?v=3","gravatar_id":"","url":"https://api.github.com/users/aufziehvogel","html_url":"https://github.com/aufziehvogel","followers_url":"https://api.github.com/users/aufziehvogel/followers","following_url":"https://api.github.com/users/aufziehvogel/following{/other_user}","gists_url":"https://api.github.com/users/aufziehvogel/gists{/gist_id}","starred_url":"https://api.github.com/users/aufziehvogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aufziehvogel/subscriptions","organizations_url":"https://api.github.com/users/aufziehvogel/orgs","repos_url":"https://api.github.com/users/aufziehvogel/repos","events_url":"https://api.github.com/users/aufziehvogel/events{/privacy}","received_events_url":"https://api.github.com/users/aufziehvogel/received_events","type":"User","site_admin":false},"repo":{"id":32349734,"name":"ggplot","full_name":"aufziehvogel/ggplot","owner":{"login":"aufziehvogel","id":3071022,"avatar_url":"https://avatars.githubusercontent.com/u/3071022?v=3","gravatar_id":"","url":"https://api.github.com/users/aufziehvogel","html_url":"https://github.com/aufziehvogel","followers_url":"https://api.github.com/users/aufziehvogel/followers","following_url":"https://api.github.com/users/aufziehvogel/following{/other_user}","gists_url":"https://api.github.com/users/aufziehvogel/gists{/gist_id}","starred_url":"https://api.github.com/users/aufziehvogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aufziehvogel/subscriptions","organizations_url":"https://api.github.com/users/aufziehvogel/orgs","repos_url":"https://api.github.com/users/aufziehvogel/repos","events_url":"https://api.github.com/users/aufziehvogel/events{/privacy}","received_events_url":"https://api.github.com/users/aufziehvogel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aufziehvogel/ggplot","description":"ggplot for python","fork":true,"url":"https://api.github.com/repos/aufziehvogel/ggplot","forks_url":"https://api.github.com/repos/aufziehvogel/ggplot/forks","keys_url":"https://api.github.com/repos/aufziehvogel/ggplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aufziehvogel/ggplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aufziehvogel/ggplot/teams","hooks_url":"https://api.github.com/repos/aufziehvogel/ggplot/hooks","issue_events_url":"https://api.github.com/repos/aufziehvogel/ggplot/issues/events{/number}","events_url":"https://api.github.com/repos/aufziehvogel/ggplot/events","assignees_url":"https://api.github.com/repos/aufziehvogel/ggplot/assignees{/user}","branches_url":"https://api.github.com/repos/aufziehvogel/ggplot/branches{/branch}","tags_url":"https://api.github.com/repos/aufziehvogel/ggplot/tags","blobs_url":"https://api.github.com/repos/aufziehvogel/ggplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aufziehvogel/ggplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aufziehvogel/ggplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/aufziehvogel/ggplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aufziehvogel/ggplot/statuses/{sha}","languages_url":"https://api.github.com/repos/aufziehvogel/ggplot/languages","stargazers_url":"https://api.github.com/repos/aufziehvogel/ggplot/stargazers","contributors_url":"https://api.github.com/repos/aufziehvogel/ggplot/contributors","subscribers_url":"https://api.github.com/repos/aufziehvogel/ggplot/subscribers","subscription_url":"https://api.github.com/repos/aufziehvogel/ggplot/subscription","commits_url":"https://api.github.com/repos/aufziehvogel/ggplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/aufziehvogel/ggplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/aufziehvogel/ggplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/aufziehvogel/ggplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/aufziehvogel/ggplot/contents/{+path}","compare_url":"https://api.github.com/repos/aufziehvogel/ggplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aufziehvogel/ggplot/merges","archive_url":"https://api.github.com/repos/aufziehvogel/ggplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aufziehvogel/ggplot/downloads","issues_url":"https://api.github.com/repos/aufziehvogel/ggplot/issues{/number}","pulls_url":"https://api.github.com/repos/aufziehvogel/ggplot/pulls{/number}","milestones_url":"https://api.github.com/repos/aufziehvogel/ggplot/milestones{/number}","notifications_url":"https://api.github.com/repos/aufziehvogel/ggplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aufziehvogel/ggplot/labels{/name}","releases_url":"https://api.github.com/repos/aufziehvogel/ggplot/releases{/id}","created_at":"2015-03-16T20:03:51Z","updated_at":"2015-03-16T20:07:43Z","pushed_at":"2015-03-16T20:07:43Z","git_url":"git://github.com/aufziehvogel/ggplot.git","ssh_url":"git@github.com:aufziehvogel/ggplot.git","clone_url":"https://github.com/aufziehvogel/ggplot.git","svn_url":"https://github.com/aufziehvogel/ggplot","homepage":"ggplot.yhathq.com","size":123218,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yhat:master","ref":"master","sha":"0f3774e6a645796b843d3ce77fb388958773338e","user":{"login":"yhat","id":2684181,"avatar_url":"https://avatars.githubusercontent.com/u/2684181?v=3","gravatar_id":"","url":"https://api.github.com/users/yhat","html_url":"https://github.com/yhat","followers_url":"https://api.github.com/users/yhat/followers","following_url":"https://api.github.com/users/yhat/following{/other_user}","gists_url":"https://api.github.com/users/yhat/gists{/gist_id}","starred_url":"https://api.github.com/users/yhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhat/subscriptions","organizations_url":"https://api.github.com/users/yhat/orgs","repos_url":"https://api.github.com/users/yhat/repos","events_url":"https://api.github.com/users/yhat/events{/privacy}","received_events_url":"https://api.github.com/users/yhat/received_events","type":"Organization","site_admin":false},"repo":{"id":13384593,"name":"ggplot","full_name":"yhat/ggplot","owner":{"login":"yhat","id":2684181,"avatar_url":"https://avatars.githubusercontent.com/u/2684181?v=3","gravatar_id":"","url":"https://api.github.com/users/yhat","html_url":"https://github.com/yhat","followers_url":"https://api.github.com/users/yhat/followers","following_url":"https://api.github.com/users/yhat/following{/other_user}","gists_url":"https://api.github.com/users/yhat/gists{/gist_id}","starred_url":"https://api.github.com/users/yhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhat/subscriptions","organizations_url":"https://api.github.com/users/yhat/orgs","repos_url":"https://api.github.com/users/yhat/repos","events_url":"https://api.github.com/users/yhat/events{/privacy}","received_events_url":"https://api.github.com/users/yhat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yhat/ggplot","description":"ggplot for python","fork":false,"url":"https://api.github.com/repos/yhat/ggplot","forks_url":"https://api.github.com/repos/yhat/ggplot/forks","keys_url":"https://api.github.com/repos/yhat/ggplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yhat/ggplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yhat/ggplot/teams","hooks_url":"https://api.github.com/repos/yhat/ggplot/hooks","issue_events_url":"https://api.github.com/repos/yhat/ggplot/issues/events{/number}","events_url":"https://api.github.com/repos/yhat/ggplot/events","assignees_url":"https://api.github.com/repos/yhat/ggplot/assignees{/user}","branches_url":"https://api.github.com/repos/yhat/ggplot/branches{/branch}","tags_url":"https://api.github.com/repos/yhat/ggplot/tags","blobs_url":"https://api.github.com/repos/yhat/ggplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yhat/ggplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yhat/ggplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/yhat/ggplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yhat/ggplot/statuses/{sha}","languages_url":"https://api.github.com/repos/yhat/ggplot/languages","stargazers_url":"https://api.github.com/repos/yhat/ggplot/stargazers","contributors_url":"https://api.github.com/repos/yhat/ggplot/contributors","subscribers_url":"https://api.github.com/repos/yhat/ggplot/subscribers","subscription_url":"https://api.github.com/repos/yhat/ggplot/subscription","commits_url":"https://api.github.com/repos/yhat/ggplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/yhat/ggplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/yhat/ggplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/yhat/ggplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/yhat/ggplot/contents/{+path}","compare_url":"https://api.github.com/repos/yhat/ggplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yhat/ggplot/merges","archive_url":"https://api.github.com/repos/yhat/ggplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yhat/ggplot/downloads","issues_url":"https://api.github.com/repos/yhat/ggplot/issues{/number}","pulls_url":"https://api.github.com/repos/yhat/ggplot/pulls{/number}","milestones_url":"https://api.github.com/repos/yhat/ggplot/milestones{/number}","notifications_url":"https://api.github.com/repos/yhat/ggplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yhat/ggplot/labels{/name}","releases_url":"https://api.github.com/repos/yhat/ggplot/releases{/id}","created_at":"2013-10-07T13:30:53Z","updated_at":"2015-03-16T06:37:18Z","pushed_at":"2015-01-27T22:01:11Z","git_url":"git://github.com/yhat/ggplot.git","ssh_url":"git@github.com:yhat/ggplot.git","clone_url":"https://github.com/yhat/ggplot.git","svn_url":"https://github.com/yhat/ggplot","homepage":"ggplot.yhathq.com","size":123218,"stargazers_count":1993,"watchers_count":1993,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":216,"mirror_url":null,"open_issues_count":178,"forks":216,"open_issues":178,"watchers":1993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/413"},"html":{"href":"https://github.com/yhat/ggplot/pull/413"},"issue":{"href":"https://api.github.com/repos/yhat/ggplot/issues/413"},"comments":{"href":"https://api.github.com/repos/yhat/ggplot/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/yhat/ggplot/statuses/9216b5d722a0f95b15c298462d7fc324eda1d136"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}