{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/29485863","id":29485863,"diff_hunk":"@@ -1208,6 +1272,42 @@ internal String[] SplitInternal(char[] separator, int count, StringSplitOptions\n             }\n             return foundCount;\n         }\n+\n+        private struct SplitSeparatorArray\n+        {\n+            private readonly bool _single;","path":"src/mscorlib/src/System/String.cs","position":182,"original_position":182,"commit_id":"862da1e5207cea02794ac27f8a78ab929ce61f8f","original_commit_id":"862da1e5207cea02794ac27f8a78ab929ce61f8f","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"The problem is `_separator` can be null, that's a valid value.","created_at":"2015-05-01T01:56:40Z","updated_at":"2015-05-01T01:56:40Z","html_url":"https://github.com/dotnet/coreclr/pull/895#discussion_r29485863","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/895","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/29485863"},"html":{"href":"https://github.com/dotnet/coreclr/pull/895#discussion_r29485863"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/895"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/895","id":34514062,"html_url":"https://github.com/dotnet/coreclr/pull/895","diff_url":"https://github.com/dotnet/coreclr/pull/895.diff","patch_url":"https://github.com/dotnet/coreclr/pull/895.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/895","number":895,"state":"open","locked":false,"title":"Add String.Split overloads that take a single char and string separator","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"Fixes dotnet/corefx/issues/1513\r\n\r\nNotes:\r\n\r\n - Tests are here: dotnet/corefx/pull/1600, although, the tests in corefx won't exercise these new overloads until the new methods are exposed in System.Runtime.dll (the tests are written in a way to \"light up\" once the methods are available). In the meantime, I ran the `Split` tests manually in a one-off app compiled against a CoreCLR mscorlib.dll with the added methods (on Windows).\r\n\r\n - I made the changes as \"surgical\" as possible to minimize the churn. There are some opportunities for stylistic code formatting improvements, but I held off on those for this PR.\r\n\r\n/cc @ellismg","created_at":"2015-05-01T00:40:10Z","updated_at":"2015-05-01T01:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c842c93e0626bdf88bf5f87ab5816dd3849e5c78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/895/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/895/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/895/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/862da1e5207cea02794ac27f8a78ab929ce61f8f","head":{"label":"justinvp:string_splitoverloads","ref":"string_splitoverloads","sha":"862da1e5207cea02794ac27f8a78ab929ce61f8f","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"repo":{"id":30260188,"name":"coreclr","full_name":"justinvp/coreclr","owner":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinvp/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/justinvp/coreclr","forks_url":"https://api.github.com/repos/justinvp/coreclr/forks","keys_url":"https://api.github.com/repos/justinvp/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinvp/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinvp/coreclr/teams","hooks_url":"https://api.github.com/repos/justinvp/coreclr/hooks","issue_events_url":"https://api.github.com/repos/justinvp/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/justinvp/coreclr/events","assignees_url":"https://api.github.com/repos/justinvp/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/justinvp/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/justinvp/coreclr/tags","blobs_url":"https://api.github.com/repos/justinvp/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinvp/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinvp/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinvp/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinvp/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/justinvp/coreclr/languages","stargazers_url":"https://api.github.com/repos/justinvp/coreclr/stargazers","contributors_url":"https://api.github.com/repos/justinvp/coreclr/contributors","subscribers_url":"https://api.github.com/repos/justinvp/coreclr/subscribers","subscription_url":"https://api.github.com/repos/justinvp/coreclr/subscription","commits_url":"https://api.github.com/repos/justinvp/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinvp/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinvp/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinvp/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinvp/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/justinvp/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinvp/coreclr/merges","archive_url":"https://api.github.com/repos/justinvp/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinvp/coreclr/downloads","issues_url":"https://api.github.com/repos/justinvp/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/justinvp/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/justinvp/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/justinvp/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinvp/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/justinvp/coreclr/releases{/id}","created_at":"2015-02-03T19:23:40Z","updated_at":"2015-04-29T05:27:46Z","pushed_at":"2015-05-01T01:27:58Z","git_url":"git://github.com/justinvp/coreclr.git","ssh_url":"git@github.com:justinvp/coreclr.git","clone_url":"https://github.com/justinvp/coreclr.git","svn_url":"https://github.com/justinvp/coreclr","homepage":"","size":30503,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9fd072e9416e5bc6bc04aa4ec0ff630336a05394","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-05-01T01:40:49Z","pushed_at":"2015-05-01T01:27:58Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"","size":44629,"stargazers_count":4418,"watchers_count":4418,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":818,"mirror_url":null,"open_issues_count":125,"forks":818,"open_issues":125,"watchers":4418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/895"},"html":{"href":"https://github.com/dotnet/coreclr/pull/895"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/895"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/862da1e5207cea02794ac27f8a78ab929ce61f8f"}}}}