{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/1731","labels_url":"https://api.github.com/repos/minetest/minetest/issues/1731/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/1731/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/1731/events","html_url":"https://github.com/minetest/minetest/pull/1731","id":45483244,"number":1731,"title":"Extend the allowed protocol versions of strict servers","user":{"login":"SmallJoker","id":1497498,"avatar_url":"https://avatars.githubusercontent.com/u/1497498?v=3","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Startup%20/%20Config%20/%20Util","name":"@ Startup / Config / Util","color":"009800"},{"url":"https://api.github.com/repos/minetest/minetest/labels/low-priority%20enhancement","name":"low-priority enhancement","color":"DDDDDD"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-10-10T13:59:41Z","updated_at":"2015-06-20T22:30:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/1731","html_url":"https://github.com/minetest/minetest/pull/1731","diff_url":"https://github.com/minetest/minetest/pull/1731.diff","patch_url":"https://github.com/minetest/minetest/pull/1731.patch"},"body":"The current strict protocol check is not optimal. 0.4.10 clients can not connect to a strict 0.4.10-dev server. [untested]\r\n\r\nExample: https://forum.minetest.net/viewtopic.php?p=157728#p157728\r\nThis pull allows clients to connect if their protocol version is in the range of +/- 1\r\n\r\nI understand the meaning of \"strict\", but adding an additional setting for this is not required.\r\n~~An other way would be to use `strict_protocol_version_checking` as \"allowed range\".~~\r\nAdded in a 2nd commit. [untested]"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/113832615","html_url":"https://github.com/minetest/minetest/pull/1731#issuecomment-113832615","issue_url":"https://api.github.com/repos/minetest/minetest/issues/1731","id":113832615,"user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T22:30:20Z","updated_at":"2015-06-20T22:30:20Z","body":"ah I see"}}