{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/645","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/645/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/645/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/645","id":80321056,"number":645,"title":"updates+fixes in README.md for Ubuntu builds","user":{"login":"arielf","id":159664,"avatar_url":"https://avatars.githubusercontent.com/u/159664?v=3","gravatar_id":"","url":"https://api.github.com/users/arielf","html_url":"https://github.com/arielf","followers_url":"https://api.github.com/users/arielf/followers","following_url":"https://api.github.com/users/arielf/following{/other_user}","gists_url":"https://api.github.com/users/arielf/gists{/gist_id}","starred_url":"https://api.github.com/users/arielf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielf/subscriptions","organizations_url":"https://api.github.com/users/arielf/orgs","repos_url":"https://api.github.com/users/arielf/repos","events_url":"https://api.github.com/users/arielf/events{/privacy}","received_events_url":"https://api.github.com/users/arielf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-25T00:39:48Z","updated_at":"2015-05-25T13:06:09Z","closed_at":"2015-05-25T12:34:34Z","pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/645","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/645","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/645.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/645.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/105229177","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/645#issuecomment-105229177","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/645","id":105229177,"user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T13:06:09Z","updated_at":"2015-05-25T13:06:09Z","body":"I'd say 'go for it', and would suggest simple removing unused function\narguments rather than commenting out.  Code cleanups like this a valuable\nfor sanity.\n\n-John\n\n\nOn Mon, May 25, 2015 at 6:13 AM, Alexander Trufanov <\nnotifications@github.com> wrote:\n\n> btw, regarding unused things. I'm was working with vw source with\n> QtCreator and its toolchain. Which uses gcc with default params. And was\n> getting ~400 warnings every build. Most of them are unused function\n> arguments. I think there shall be about 50 such functions. And their effect\n> multiplied as some of them are templated or inline.\n>\n> I tremendously tempted to fix these warnings and decrease their number to\n> a dozen or so. By commenting out argument names. Like that:\n>\n> inline void noop(void* data) {} -> inline void noop(void* /*data*/) {}\n>\n> But there are 2 problems:\n>\n> 1. That should be manual work as some warnings are generated by arguments\n> which are not used in Linux code but used in Win code (code switched with\n> typedef). Actually, not so much work.\n> 2. That will affect dozen cpp files that could make any pending PRs\n> unmergable.\n>\n> How do you think, would it be a desirable patch? Or it's better to not\n> touch this?\n>\n> --\n> Reply to this email directly or view it on GitHub\n> <https://github.com/JohnLangford/vowpal_wabbit/pull/645#issuecomment-105198096>\n> .\n>\n"}}