{"push_id":727904084,"size":20,"distinct_size":3,"ref":"refs/heads/2.8","head":"5626d73992cf7fabe4e7be5f2c07cee34dab6e81","before":"0e5eb6b6eb242e3edc47cc349cdb63c4aae191a2","commits":[{"sha":"1dcca1a8df40258168e22a58077873a87b3b623a","author":{"email":"418d940643b1975d62234ee01246ad4b58904184@nmacherey.com","name":"Nicolas Macherey"},"message":"[PropertyAccess] setValue & isWritable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nThis merge request fixes the following cases taht was working with version previous to 2.6.5:\n\nA class with a property myArray which can be a multi dimensional array can now be accesed using myArray[foo][bar][baz]\nPreviously only myArray[foo] was working. The break is since commit e3e4695\n\nThis commit adds additionnal testing, and is rebased from 2.6 upstream","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/1dcca1a8df40258168e22a58077873a87b3b623a"},{"sha":"524ccac97c9e3b180461cac46a9e14e27a60897d","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated CHANGELOG for 2.6.10","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/524ccac97c9e3b180461cac46a9e14e27a60897d"},{"sha":"e246af5f3bdf64fa5a85936ee78e3574e094cf5f","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated VERSION for 2.6.10","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/e246af5f3bdf64fa5a85936ee78e3574e094cf5f"},{"sha":"1e668dd8058b12c4fb787907eb0ca5518ad304d8","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bumped Symfony version to 2.6.11","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/1e668dd8058b12c4fb787907eb0ca5518ad304d8"},{"sha":"e816d28a065925c4ecad07fd40201c753ccef060","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated CHANGELOG for 2.7.2","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/e816d28a065925c4ecad07fd40201c753ccef060"},{"sha":"969d709ad428076bf1084e386dc26dd904d9fb84","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"updated VERSION for 2.7.2","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/969d709ad428076bf1084e386dc26dd904d9fb84"},{"sha":"095bfd61ca0d68f04f4121c18aa4518cb28e960c","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bumped Symfony version to 2.7.3","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/095bfd61ca0d68f04f4121c18aa4518cb28e960c"},{"sha":"7783573d16994ab6544d0da583b6a76b2024f191","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15250 [PropertyAccess] BC Break since 2.6.5 (Nicolas Macherey)\n\nThis PR was merged into the 2.6 branch.\n\nDiscussion\n----------\n\n[PropertyAccess] BC Break since 2.6.5\n\nsetValue & isWratable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nThis merge request fixes the following cases taht was working with version previous to 2.6.5:\n\nA class with a property myArray which can be a multi dimensional array can now be accesed using myArray[foo][bar][baz]\nPreviously only myArray[foo] was working the break is since commit e3e4695\n\nCommits\n-------\n\n1dcca1a [PropertyAccess] setValue & isWritable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/7783573d16994ab6544d0da583b6a76b2024f191"},{"sha":"3fcf61e664ccb12e9dd8ae98b33418cbfd095460","author":{"email":"c7ac92426e513cc074fa0f0f0652e7b75207d3b8@rollerscapes.net","name":"Sebastiaan Stok"},"message":"fix broken ChoiceQuestion","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/3fcf61e664ccb12e9dd8ae98b33418cbfd095460"},{"sha":"bb54d8ce33ebafb505872061b591ecc17d943fa4","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15271 fix broken ChoiceQuestion (sstok)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\nfix broken ChoiceQuestion\n\n|Q            |A  |\n|---          |---|\n|Bug Fix?     |yes|\n|New Feature? |n  |\n|BC Breaks?   |n  |\n|Deprecations?|n  |\n|Tests Pass?  |yes|\n|Fixed Tickets|   |\n|License      |MIT|\n|Doc PR       |   |\n\nCommit https://github.com/symfony/symfony/commit/175af7f3acc0f7f994885388daca366e800db538#diff-e1d5cef4b49c9c530f50aae153f6a541 seems to have introduced an unnoticed bug. QuestionHelperTest hangs the tests (due to throwing an undefined index exception internally).\n\nIts a bit strange why this happend but it seems somehow Git messed-up the patch somewhere during the process. The broken commit only exists in the commit and not in any downstream branches.\n\nCommits\n-------\n\n3fcf61e fix broken ChoiceQuestion","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/bb54d8ce33ebafb505872061b591ecc17d943fa4"},{"sha":"03642b8ffeaf68b25a61308a7ee9f60e3993bdba","author":{"email":"1d3764b91b902f6b45836e2498da81fe35caf6d6@zalas.pl","name":"Jakub Zalas"},"message":"[Form] Fix a BC break in the entity","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/03642b8ffeaf68b25a61308a7ee9f60e3993bdba"},{"sha":"23bc2649ba7b155e846d11e9e4f88ae1d850ff3b","author":{"email":"1d3764b91b902f6b45836e2498da81fe35caf6d6@zalas.pl","name":"Jakub Zalas"},"message":"[Console] Set QuestionHelper max attempts in tests\n\nOtherwise the process will block if a test fails.","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/23bc2649ba7b155e846d11e9e4f88ae1d850ff3b"},{"sha":"be4f2d5b245df10e339b4d57b4ed326d563a5cf5","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15277 [Form] Fix a BC break in the entity (jakzal)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Form] Fix a BC break in the entity\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #15273\n| License       | MIT\n| Doc PR        | -\n\n@webmozart this brings back the old behaviour. Attached test case passes on 2.3 with no code modifications.\n\nCode [here](https://github.com/symfony/symfony/blob/73bbaa6cc7d706b0e945107657fbd240efec0c97/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L199-L206) promises any integer number can be handled with `createChoiceName()`:\n\n```php\n            // If the object has a single-column, numeric ID, use that ID as\n            // field name. We can only use numeric IDs as names, as we cannot\n            // guarantee that a non-numeric ID contains a valid form name\n            if ($idReader->isIntId()) {\n                return array(__CLASS__, 'createChoiceName');\n            }\n            // Otherwise, an incrementing integer is used as name automatically\n```\n\nWhile `createChoiceName()` can only handle natural numbers.\n\nCommits\n-------\n\n03642b8 [Form] Fix a BC break in the entity","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/be4f2d5b245df10e339b4d57b4ed326d563a5cf5"},{"sha":"caba8f4cf1c6b7425e4ba2d98abf3e5f16f060ba","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #15280 [Console] Set QuestionHelper max attempts in tests (jakzal)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Console] Set QuestionHelper max attempts in tests\n\nOtherwise the process will block if a test fails.\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nQuestionHelper tests will block the phpunit process if any of tests fails. This is what's currently happening on 2.8 branch. As soon as this is merged to 2.7 and 2.8, I can work on fixing 2.8 tests.\n\nre #14638\n\nCommits\n-------\n\n23bc264 [Console] Set QuestionHelper max attempts in tests","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/caba8f4cf1c6b7425e4ba2d98abf3e5f16f060ba"},{"sha":"1adb065d7017f07d6b79d345b7bd33448d426959","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"[HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/1adb065d7017f07d6b79d345b7bd33448d426959"},{"sha":"ba129041ba19b6d5a62cfa34789d3b05e6efbacf","author":{"email":"1d3764b91b902f6b45836e2498da81fe35caf6d6@zalas.pl","name":"Jakub Zalas"},"message":"[DependencyInjection] Forbid container cloning","distinct":true,"url":"https://api.github.com/repos/jakzal/symfony/commits/ba129041ba19b6d5a62cfa34789d3b05e6efbacf"},{"sha":"dcb0255b358a1782f6160e1f99ed46824f00994f","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15291 [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3 (nicolas-grekas)\n\nThis PR was merged into the 2.6 branch.\n\nDiscussion\n----------\n\n[HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #15284\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\n1adb065 [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/dcb0255b358a1782f6160e1f99ed46824f00994f"},{"sha":"b9f45d1a0a0cf17f1b547445d0b99280204f1566","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"feature #15290 [DependencyInjection] Forbid container cloning (jakzal)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[DependencyInjection] Forbid container cloning\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #15261\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\nba12904 [DependencyInjection] Forbid container cloning","distinct":true,"url":"https://api.github.com/repos/jakzal/symfony/commits/b9f45d1a0a0cf17f1b547445d0b99280204f1566"},{"sha":"99f3475a2acf859ee14c8183b884c0cd25bb5853","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.6' into 2.7\n\n* 2.6:\n  [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3\n  bumped Symfony version to 2.6.11\n  updated VERSION for 2.6.10\n  updated CHANGELOG for 2.6.10\n  [PropertyAccess] setValue & isWritable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)","distinct":false,"url":"https://api.github.com/repos/jakzal/symfony/commits/99f3475a2acf859ee14c8183b884c0cd25bb5853"},{"sha":"5626d73992cf7fabe4e7be5f2c07cee34dab6e81","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"Merge branch '2.7' into 2.8\n\n* 2.7:\n  [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3\n  [Console] Set QuestionHelper max attempts in tests\n  [Form] Fix a BC break in the entity\n  fix broken ChoiceQuestion\n  bumped Symfony version to 2.7.3\n  updated VERSION for 2.7.2\n  updated CHANGELOG for 2.7.2\n  bumped Symfony version to 2.6.11\n  updated VERSION for 2.6.10\n  updated CHANGELOG for 2.6.10\n  [PropertyAccess] setValue & isWritable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)","distinct":true,"url":"https://api.github.com/repos/jakzal/symfony/commits/5626d73992cf7fabe4e7be5f2c07cee34dab6e81"}]}