{"action":"closed","number":391,"pull_request":{"url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391","id":29427127,"html_url":"https://github.com/mgp25/WhatsAPI-Official/pull/391","diff_url":"https://github.com/mgp25/WhatsAPI-Official/pull/391.diff","patch_url":"https://github.com/mgp25/WhatsAPI-Official/pull/391.patch","issue_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/391","number":391,"state":"closed","locked":false,"title":"more GroupMessages (Audio, vCard, Location) Style 1","user":{"login":"derpue","id":8439720,"avatar_url":"https://avatars.githubusercontent.com/u/8439720?v=3","gravatar_id":"","url":"https://api.github.com/users/derpue","html_url":"https://github.com/derpue","followers_url":"https://api.github.com/users/derpue/followers","following_url":"https://api.github.com/users/derpue/following{/other_user}","gists_url":"https://api.github.com/users/derpue/gists{/gist_id}","starred_url":"https://api.github.com/users/derpue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derpue/subscriptions","organizations_url":"https://api.github.com/users/derpue/orgs","repos_url":"https://api.github.com/users/derpue/repos","events_url":"https://api.github.com/users/derpue/events{/privacy}","received_events_url":"https://api.github.com/users/derpue/received_events","type":"User","site_admin":false},"body":"There are still 3 message types missing for groups, Audio, vCard and Location.\r\n\r\nThis style implements it right in the already existing events as additional parameter for the author/participant. (`null` if normal message, `!null` if group message)\r\nThus the events callback can/must decide if this message belongs to a group or not. But since the handling of normal and group message is IMHO basically mostly the same, it's fine this way. We save us having thousand of mostly similar Events which most of the time will anyway be routed to the same function in our own code.\r\n\r\nThis differs completly than already done for Text, Video, Image Messages with it's own Events.\r\nPersonally i would like to see the already existing GroupMessage Events also to be changed to this style, but this would be a BC break (at least the Image and Video ones are only some few days old).\r\nDue to this BC, there will be a second pull request, with these missing Events done in the already existing style as distinct events.\r\n\r\nSee also #392 ","created_at":"2015-02-17T09:15:52Z","updated_at":"2015-02-17T13:01:16Z","closed_at":"2015-02-17T13:01:16Z","merged_at":"2015-02-17T13:01:16Z","merge_commit_sha":"9c14f8b0154ffa97b45174f34add4888cee205cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391/commits","review_comments_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391/comments","review_comment_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/391/comments","statuses_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/statuses/4cc7c5954a2ea45a701cb41b2cc54db46df7e621","head":{"label":"derpue:moreGroupEventsV1","ref":"moreGroupEventsV1","sha":"4cc7c5954a2ea45a701cb41b2cc54db46df7e621","user":{"login":"derpue","id":8439720,"avatar_url":"https://avatars.githubusercontent.com/u/8439720?v=3","gravatar_id":"","url":"https://api.github.com/users/derpue","html_url":"https://github.com/derpue","followers_url":"https://api.github.com/users/derpue/followers","following_url":"https://api.github.com/users/derpue/following{/other_user}","gists_url":"https://api.github.com/users/derpue/gists{/gist_id}","starred_url":"https://api.github.com/users/derpue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derpue/subscriptions","organizations_url":"https://api.github.com/users/derpue/orgs","repos_url":"https://api.github.com/users/derpue/repos","events_url":"https://api.github.com/users/derpue/events{/privacy}","received_events_url":"https://api.github.com/users/derpue/received_events","type":"User","site_admin":false},"repo":{"id":30650694,"name":"WhatsAPI-Official","full_name":"derpue/WhatsAPI-Official","owner":{"login":"derpue","id":8439720,"avatar_url":"https://avatars.githubusercontent.com/u/8439720?v=3","gravatar_id":"","url":"https://api.github.com/users/derpue","html_url":"https://github.com/derpue","followers_url":"https://api.github.com/users/derpue/followers","following_url":"https://api.github.com/users/derpue/following{/other_user}","gists_url":"https://api.github.com/users/derpue/gists{/gist_id}","starred_url":"https://api.github.com/users/derpue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derpue/subscriptions","organizations_url":"https://api.github.com/users/derpue/orgs","repos_url":"https://api.github.com/users/derpue/repos","events_url":"https://api.github.com/users/derpue/events{/privacy}","received_events_url":"https://api.github.com/users/derpue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derpue/WhatsAPI-Official","description":" The php WhatsApp library","fork":true,"url":"https://api.github.com/repos/derpue/WhatsAPI-Official","forks_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/forks","keys_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/teams","hooks_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/hooks","issue_events_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/issues/events{/number}","events_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/events","assignees_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/assignees{/user}","branches_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/branches{/branch}","tags_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/tags","blobs_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/git/refs{/sha}","trees_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/statuses/{sha}","languages_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/languages","stargazers_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/stargazers","contributors_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/contributors","subscribers_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/subscribers","subscription_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/subscription","commits_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/commits{/sha}","git_commits_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/git/commits{/sha}","comments_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/comments{/number}","issue_comment_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/issues/comments/{number}","contents_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/contents/{+path}","compare_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/merges","archive_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/downloads","issues_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/issues{/number}","pulls_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/pulls{/number}","milestones_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/milestones{/number}","notifications_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/labels{/name}","releases_url":"https://api.github.com/repos/derpue/WhatsAPI-Official/releases{/id}","created_at":"2015-02-11T14:10:51Z","updated_at":"2015-02-16T13:48:26Z","pushed_at":"2015-02-17T10:46:29Z","git_url":"git://github.com/derpue/WhatsAPI-Official.git","ssh_url":"git@github.com:derpue/WhatsAPI-Official.git","clone_url":"https://github.com/derpue/WhatsAPI-Official.git","svn_url":"https://github.com/derpue/WhatsAPI-Official","homepage":"","size":1607,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgp25:master","ref":"master","sha":"602be31d39dddcdf268bfeb157ab1ed2c7c9f2f2","user":{"login":"mgp25","id":5390120,"avatar_url":"https://avatars.githubusercontent.com/u/5390120?v=3","gravatar_id":"","url":"https://api.github.com/users/mgp25","html_url":"https://github.com/mgp25","followers_url":"https://api.github.com/users/mgp25/followers","following_url":"https://api.github.com/users/mgp25/following{/other_user}","gists_url":"https://api.github.com/users/mgp25/gists{/gist_id}","starred_url":"https://api.github.com/users/mgp25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgp25/subscriptions","organizations_url":"https://api.github.com/users/mgp25/orgs","repos_url":"https://api.github.com/users/mgp25/repos","events_url":"https://api.github.com/users/mgp25/events{/privacy}","received_events_url":"https://api.github.com/users/mgp25/received_events","type":"User","site_admin":false},"repo":{"id":24518232,"name":"WhatsAPI-Official","full_name":"mgp25/WhatsAPI-Official","owner":{"login":"mgp25","id":5390120,"avatar_url":"https://avatars.githubusercontent.com/u/5390120?v=3","gravatar_id":"","url":"https://api.github.com/users/mgp25","html_url":"https://github.com/mgp25","followers_url":"https://api.github.com/users/mgp25/followers","following_url":"https://api.github.com/users/mgp25/following{/other_user}","gists_url":"https://api.github.com/users/mgp25/gists{/gist_id}","starred_url":"https://api.github.com/users/mgp25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgp25/subscriptions","organizations_url":"https://api.github.com/users/mgp25/orgs","repos_url":"https://api.github.com/users/mgp25/repos","events_url":"https://api.github.com/users/mgp25/events{/privacy}","received_events_url":"https://api.github.com/users/mgp25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgp25/WhatsAPI-Official","description":" The php WhatsApp library","fork":false,"url":"https://api.github.com/repos/mgp25/WhatsAPI-Official","forks_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/forks","keys_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/teams","hooks_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/hooks","issue_events_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/events{/number}","events_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/events","assignees_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/assignees{/user}","branches_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/branches{/branch}","tags_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/tags","blobs_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/statuses/{sha}","languages_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/languages","stargazers_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/stargazers","contributors_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/contributors","subscribers_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/subscribers","subscription_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/subscription","commits_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/comments/{number}","contents_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/contents/{+path}","compare_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/merges","archive_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/downloads","issues_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues{/number}","pulls_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls{/number}","milestones_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/milestones{/number}","notifications_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/labels{/name}","releases_url":"https://api.github.com/repos/mgp25/WhatsAPI-Official/releases{/id}","created_at":"2014-09-26T23:19:42Z","updated_at":"2015-02-17T12:58:58Z","pushed_at":"2015-02-17T13:01:16Z","git_url":"git://github.com/mgp25/WhatsAPI-Official.git","ssh_url":"git@github.com:mgp25/WhatsAPI-Official.git","clone_url":"https://github.com/mgp25/WhatsAPI-Official.git","svn_url":"https://github.com/mgp25/WhatsAPI-Official","homepage":"","size":3041,"stargazers_count":320,"watchers_count":320,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":4,"forks":130,"open_issues":4,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391"},"html":{"href":"https://github.com/mgp25/WhatsAPI-Official/pull/391"},"issue":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/391"},"comments":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/mgp25/WhatsAPI-Official/statuses/4cc7c5954a2ea45a701cb41b2cc54db46df7e621"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mgp25","id":5390120,"avatar_url":"https://avatars.githubusercontent.com/u/5390120?v=3","gravatar_id":"","url":"https://api.github.com/users/mgp25","html_url":"https://github.com/mgp25","followers_url":"https://api.github.com/users/mgp25/followers","following_url":"https://api.github.com/users/mgp25/following{/other_user}","gists_url":"https://api.github.com/users/mgp25/gists{/gist_id}","starred_url":"https://api.github.com/users/mgp25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgp25/subscriptions","organizations_url":"https://api.github.com/users/mgp25/orgs","repos_url":"https://api.github.com/users/mgp25/repos","events_url":"https://api.github.com/users/mgp25/events{/privacy}","received_events_url":"https://api.github.com/users/mgp25/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":6,"changed_files":2}}