{"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/26760789","id":26760789,"diff_hunk":"@@ -13,7 +13,7 @@ def create_post(content, override = {}, converter_class = Jekyll::Converters::Ma\n     site = Site.new(Jekyll.configuration)\n \n     if override['read_posts']\n-      site.read_posts('')\n+      site.posts += PostReader.new(site).read('')","path":"test/test_tags.rb","position":null,"original_position":5,"commit_id":"324748a5a679a2532baff91ac0d30c44a4f9f072","original_commit_id":"b178358cf9a912ba07ae61e95896b830e7cdde78","user":{"login":"envygeeks","id":99763,"avatar_url":"https://avatars.githubusercontent.com/u/99763?v=3","gravatar_id":"","url":"https://api.github.com/users/envygeeks","html_url":"https://github.com/envygeeks","followers_url":"https://api.github.com/users/envygeeks/followers","following_url":"https://api.github.com/users/envygeeks/following{/other_user}","gists_url":"https://api.github.com/users/envygeeks/gists{/gist_id}","starred_url":"https://api.github.com/users/envygeeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envygeeks/subscriptions","organizations_url":"https://api.github.com/users/envygeeks/orgs","repos_url":"https://api.github.com/users/envygeeks/repos","events_url":"https://api.github.com/users/envygeeks/events{/privacy}","received_events_url":"https://api.github.com/users/envygeeks/received_events","type":"User","site_admin":false},"body":"In the context of optimization (as you implied) that matters very little to Jekyll (as in the type of app we are not the type of programmers we are but, really, it should be applied to both.)  We are a short lived process and our GC  time matters little  we probably don't even hit the exponential scale required of caring about the GC time and whether or not we are creating new array's and marking old objects.","created_at":"2015-03-19T14:51:48Z","updated_at":"2015-03-19T14:51:48Z","html_url":"https://github.com/jekyll/jekyll/pull/3545#discussion_r26760789","pull_request_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3545","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/26760789"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3545#discussion_r26760789"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3545"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3545","id":30503905,"html_url":"https://github.com/jekyll/jekyll/pull/3545","diff_url":"https://github.com/jekyll/jekyll/pull/3545.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3545.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3545","number":3545,"state":"open","locked":false,"title":"Extract reading of data from `site.rb` to reduce responsibilities.","user":{"login":"MartinRogalla","id":1066157,"avatar_url":"https://avatars.githubusercontent.com/u/1066157?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinRogalla","html_url":"https://github.com/MartinRogalla","followers_url":"https://api.github.com/users/MartinRogalla/followers","following_url":"https://api.github.com/users/MartinRogalla/following{/other_user}","gists_url":"https://api.github.com/users/MartinRogalla/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinRogalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinRogalla/subscriptions","organizations_url":"https://api.github.com/users/MartinRogalla/orgs","repos_url":"https://api.github.com/users/MartinRogalla/repos","events_url":"https://api.github.com/users/MartinRogalla/events{/privacy}","received_events_url":"https://api.github.com/users/MartinRogalla/received_events","type":"User","site_admin":false},"body":"I believe that the `site.rb` class right now has too many responsibilities. In this pull request I want to try and take out all the data reading tasks. I took out every single method that I found to have the *reading of data* responsibility and put it in a new class called Reader(`reader.rb`).\r\n\r\nMy methodology per method:\r\n\r\n1. Copy method from `site.rb` and fix references inside of the method.\r\n2. Redirect old method to new method in `reader.rb`\r\n3. Check if the test suite is passing\r\n3. Update all references to the old `site.rb` method  and refer them to the new `reader.rb` method.\r\n4. Run the test suite\r\n5. Commit\r\n\r\nDo you think this is a good idea at all or would you like it to be done differently? \r\n\r\nI'm open to any criticism you might have.\r\n\r\n**Note**: *The usage of quotes is probably incorrect, I will fix these as soon as I know which style I should adhere to.*","created_at":"2015-03-04T21:00:50Z","updated_at":"2015-03-19T14:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e85489def28919bf982f1a127e726141140c4c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3545/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3545/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3545/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/324748a5a679a2532baff91ac0d30c44a4f9f072","head":{"label":"delftswa2014:site_extract_readers","ref":"site_extract_readers","sha":"324748a5a679a2532baff91ac0d30c44a4f9f072","user":{"login":"delftswa2014","id":6429024,"avatar_url":"https://avatars.githubusercontent.com/u/6429024?v=3","gravatar_id":"","url":"https://api.github.com/users/delftswa2014","html_url":"https://github.com/delftswa2014","followers_url":"https://api.github.com/users/delftswa2014/followers","following_url":"https://api.github.com/users/delftswa2014/following{/other_user}","gists_url":"https://api.github.com/users/delftswa2014/gists{/gist_id}","starred_url":"https://api.github.com/users/delftswa2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delftswa2014/subscriptions","organizations_url":"https://api.github.com/users/delftswa2014/orgs","repos_url":"https://api.github.com/users/delftswa2014/repos","events_url":"https://api.github.com/users/delftswa2014/events{/privacy}","received_events_url":"https://api.github.com/users/delftswa2014/received_events","type":"Organization","site_admin":false},"repo":{"id":30771978,"name":"jekyll","full_name":"delftswa2014/jekyll","owner":{"login":"delftswa2014","id":6429024,"avatar_url":"https://avatars.githubusercontent.com/u/6429024?v=3","gravatar_id":"","url":"https://api.github.com/users/delftswa2014","html_url":"https://github.com/delftswa2014","followers_url":"https://api.github.com/users/delftswa2014/followers","following_url":"https://api.github.com/users/delftswa2014/following{/other_user}","gists_url":"https://api.github.com/users/delftswa2014/gists{/gist_id}","starred_url":"https://api.github.com/users/delftswa2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delftswa2014/subscriptions","organizations_url":"https://api.github.com/users/delftswa2014/orgs","repos_url":"https://api.github.com/users/delftswa2014/repos","events_url":"https://api.github.com/users/delftswa2014/events{/privacy}","received_events_url":"https://api.github.com/users/delftswa2014/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/delftswa2014/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":true,"url":"https://api.github.com/repos/delftswa2014/jekyll","forks_url":"https://api.github.com/repos/delftswa2014/jekyll/forks","keys_url":"https://api.github.com/repos/delftswa2014/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delftswa2014/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delftswa2014/jekyll/teams","hooks_url":"https://api.github.com/repos/delftswa2014/jekyll/hooks","issue_events_url":"https://api.github.com/repos/delftswa2014/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/delftswa2014/jekyll/events","assignees_url":"https://api.github.com/repos/delftswa2014/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/delftswa2014/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/delftswa2014/jekyll/tags","blobs_url":"https://api.github.com/repos/delftswa2014/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delftswa2014/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delftswa2014/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/delftswa2014/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delftswa2014/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/delftswa2014/jekyll/languages","stargazers_url":"https://api.github.com/repos/delftswa2014/jekyll/stargazers","contributors_url":"https://api.github.com/repos/delftswa2014/jekyll/contributors","subscribers_url":"https://api.github.com/repos/delftswa2014/jekyll/subscribers","subscription_url":"https://api.github.com/repos/delftswa2014/jekyll/subscription","commits_url":"https://api.github.com/repos/delftswa2014/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/delftswa2014/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/delftswa2014/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/delftswa2014/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/delftswa2014/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/delftswa2014/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delftswa2014/jekyll/merges","archive_url":"https://api.github.com/repos/delftswa2014/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delftswa2014/jekyll/downloads","issues_url":"https://api.github.com/repos/delftswa2014/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/delftswa2014/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/delftswa2014/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/delftswa2014/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delftswa2014/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/delftswa2014/jekyll/releases{/id}","created_at":"2015-02-13T19:24:15Z","updated_at":"2015-03-11T11:02:38Z","pushed_at":"2015-03-19T13:57:22Z","git_url":"git://github.com/delftswa2014/jekyll.git","ssh_url":"git@github.com:delftswa2014/jekyll.git","clone_url":"https://github.com/delftswa2014/jekyll.git","svn_url":"https://github.com/delftswa2014/jekyll","homepage":"http://jekyllrb.com","size":8848,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"66785b43ba55d55db77f1e6983324c54013d1f3c","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2015-03-19T13:28:07Z","pushed_at":"2015-03-18T18:32:23Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":33397,"stargazers_count":19025,"watchers_count":19025,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3919,"mirror_url":null,"open_issues_count":113,"forks":3919,"open_issues":113,"watchers":19025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3545"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3545"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3545"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3545/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3545/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3545/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/324748a5a679a2532baff91ac0d30c44a4f9f072"}}}}