{"action":"created","issue":{"url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31","labels_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31/comments","events_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31/events","html_url":"https://github.com/gregsexton/ob-ipython/pull/31","id":107962550,"number":31,"title":"support both IPython3 and Jupyter by conditional import","user":{"login":"smartass101","id":941907,"avatar_url":"https://avatars.githubusercontent.com/u/941907?v=3","gravatar_id":"","url":"https://api.github.com/users/smartass101","html_url":"https://github.com/smartass101","followers_url":"https://api.github.com/users/smartass101/followers","following_url":"https://api.github.com/users/smartass101/following{/other_user}","gists_url":"https://api.github.com/users/smartass101/gists{/gist_id}","starred_url":"https://api.github.com/users/smartass101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartass101/subscriptions","organizations_url":"https://api.github.com/users/smartass101/orgs","repos_url":"https://api.github.com/users/smartass101/repos","events_url":"https://api.github.com/users/smartass101/events{/privacy}","received_events_url":"https://api.github.com/users/smartass101/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-23T16:58:09Z","updated_at":"2015-09-26T14:12:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31","html_url":"https://github.com/gregsexton/ob-ipython/pull/31","diff_url":"https://github.com/gregsexton/ob-ipython/pull/31.diff","patch_url":"https://github.com/gregsexton/ob-ipython/pull/31.patch"},"body":"I would like to propose a simple change that would deal with the current IPython 3/4 dichotomy and it would simplify installation for users as they wouldn't have to deal with git at all and an MELPA installation would suffice.\r\n\r\nThe code first tries to import the Jupyter libraries, failing that\r\nthe IPython 3 libraries are imported. All that really changed are\r\nmodule names.\r\n\r\nThis simple compatibility workaround may not work\r\nin the long term if Jupyter code diverges significantly from the current state. But by that time IPython 3 will be hopefully obsolete.\r\n\r\nI haven't fully tested it yet with IPython 3, not sure if this will bring #19 back."},"comment":{"url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/comments/143448662","html_url":"https://github.com/gregsexton/ob-ipython/pull/31#issuecomment-143448662","issue_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31","id":143448662,"user":{"login":"gregsexton","id":150883,"avatar_url":"https://avatars.githubusercontent.com/u/150883?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsexton","html_url":"https://github.com/gregsexton","followers_url":"https://api.github.com/users/gregsexton/followers","following_url":"https://api.github.com/users/gregsexton/following{/other_user}","gists_url":"https://api.github.com/users/gregsexton/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsexton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsexton/subscriptions","organizations_url":"https://api.github.com/users/gregsexton/orgs","repos_url":"https://api.github.com/users/gregsexton/repos","events_url":"https://api.github.com/users/gregsexton/events{/privacy}","received_events_url":"https://api.github.com/users/gregsexton/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T14:12:03Z","updated_at":"2015-09-26T14:12:03Z","body":"Thanks this is a nice idea. I'm willing to merge as this should be more human-fault tolerant, if people don't fully read the instructions. I will still stick with the two branches and as new versions come out I'll deprecate and stop supporting the v3 branch."}}