{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6","id":54288021,"html_url":"https://github.com/auth0/angular2-jwt/pull/6","diff_url":"https://github.com/auth0/angular2-jwt/pull/6.diff","patch_url":"https://github.com/auth0/angular2-jwt/pull/6.patch","issue_url":"https://api.github.com/repos/auth0/angular2-jwt/issues/6","number":6,"state":"closed","locked":false,"title":"Remove use of the injector, making configuration more explicit","user":{"login":"escardin","id":12631891,"avatar_url":"https://avatars.githubusercontent.com/u/12631891?v=3","gravatar_id":"","url":"https://api.github.com/users/escardin","html_url":"https://github.com/escardin","followers_url":"https://api.github.com/users/escardin/followers","following_url":"https://api.github.com/users/escardin/following{/other_user}","gists_url":"https://api.github.com/users/escardin/gists{/gist_id}","starred_url":"https://api.github.com/users/escardin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escardin/subscriptions","organizations_url":"https://api.github.com/users/escardin/orgs","repos_url":"https://api.github.com/users/escardin/repos","events_url":"https://api.github.com/users/escardin/events{/privacy}","received_events_url":"https://api.github.com/users/escardin/received_events","type":"User","site_admin":false},"body":"I made this more explicit as implicit configuration is brittle and more problematic. By doing it this way, testing is easier, and potentially AuthHttp is now composable with other Http Wrappers.","created_at":"2015-12-21T18:34:40Z","updated_at":"2015-12-23T14:52:13Z","closed_at":"2015-12-23T14:52:13Z","merged_at":"2015-12-23T14:52:13Z","merge_commit_sha":"1ca0865b3a6acd4472f9aac4c187f9c04e4e9395","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6/commits","review_comments_url":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6/comments","review_comment_url":"https://api.github.com/repos/auth0/angular2-jwt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/angular2-jwt/issues/6/comments","statuses_url":"https://api.github.com/repos/auth0/angular2-jwt/statuses/00b24cbc9ba02129ba23108ef6fe3cfb3eb79772","head":{"label":"escardin:removeMagic","ref":"removeMagic","sha":"00b24cbc9ba02129ba23108ef6fe3cfb3eb79772","user":{"login":"escardin","id":12631891,"avatar_url":"https://avatars.githubusercontent.com/u/12631891?v=3","gravatar_id":"","url":"https://api.github.com/users/escardin","html_url":"https://github.com/escardin","followers_url":"https://api.github.com/users/escardin/followers","following_url":"https://api.github.com/users/escardin/following{/other_user}","gists_url":"https://api.github.com/users/escardin/gists{/gist_id}","starred_url":"https://api.github.com/users/escardin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escardin/subscriptions","organizations_url":"https://api.github.com/users/escardin/orgs","repos_url":"https://api.github.com/users/escardin/repos","events_url":"https://api.github.com/users/escardin/events{/privacy}","received_events_url":"https://api.github.com/users/escardin/received_events","type":"User","site_admin":false},"repo":{"id":48384580,"name":"angular2-jwt","full_name":"escardin/angular2-jwt","owner":{"login":"escardin","id":12631891,"avatar_url":"https://avatars.githubusercontent.com/u/12631891?v=3","gravatar_id":"","url":"https://api.github.com/users/escardin","html_url":"https://github.com/escardin","followers_url":"https://api.github.com/users/escardin/followers","following_url":"https://api.github.com/users/escardin/following{/other_user}","gists_url":"https://api.github.com/users/escardin/gists{/gist_id}","starred_url":"https://api.github.com/users/escardin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escardin/subscriptions","organizations_url":"https://api.github.com/users/escardin/orgs","repos_url":"https://api.github.com/users/escardin/repos","events_url":"https://api.github.com/users/escardin/events{/privacy}","received_events_url":"https://api.github.com/users/escardin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/escardin/angular2-jwt","description":"Helper library for handling JWTs in Angular 2 apps","fork":true,"url":"https://api.github.com/repos/escardin/angular2-jwt","forks_url":"https://api.github.com/repos/escardin/angular2-jwt/forks","keys_url":"https://api.github.com/repos/escardin/angular2-jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/escardin/angular2-jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/escardin/angular2-jwt/teams","hooks_url":"https://api.github.com/repos/escardin/angular2-jwt/hooks","issue_events_url":"https://api.github.com/repos/escardin/angular2-jwt/issues/events{/number}","events_url":"https://api.github.com/repos/escardin/angular2-jwt/events","assignees_url":"https://api.github.com/repos/escardin/angular2-jwt/assignees{/user}","branches_url":"https://api.github.com/repos/escardin/angular2-jwt/branches{/branch}","tags_url":"https://api.github.com/repos/escardin/angular2-jwt/tags","blobs_url":"https://api.github.com/repos/escardin/angular2-jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/escardin/angular2-jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/escardin/angular2-jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/escardin/angular2-jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/escardin/angular2-jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/escardin/angular2-jwt/languages","stargazers_url":"https://api.github.com/repos/escardin/angular2-jwt/stargazers","contributors_url":"https://api.github.com/repos/escardin/angular2-jwt/contributors","subscribers_url":"https://api.github.com/repos/escardin/angular2-jwt/subscribers","subscription_url":"https://api.github.com/repos/escardin/angular2-jwt/subscription","commits_url":"https://api.github.com/repos/escardin/angular2-jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/escardin/angular2-jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/escardin/angular2-jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/escardin/angular2-jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/escardin/angular2-jwt/contents/{+path}","compare_url":"https://api.github.com/repos/escardin/angular2-jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/escardin/angular2-jwt/merges","archive_url":"https://api.github.com/repos/escardin/angular2-jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/escardin/angular2-jwt/downloads","issues_url":"https://api.github.com/repos/escardin/angular2-jwt/issues{/number}","pulls_url":"https://api.github.com/repos/escardin/angular2-jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/escardin/angular2-jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/escardin/angular2-jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/escardin/angular2-jwt/labels{/name}","releases_url":"https://api.github.com/repos/escardin/angular2-jwt/releases{/id}","created_at":"2015-12-21T17:19:31Z","updated_at":"2015-12-21T17:19:32Z","pushed_at":"2015-12-23T13:04:11Z","git_url":"git://github.com/escardin/angular2-jwt.git","ssh_url":"git@github.com:escardin/angular2-jwt.git","clone_url":"https://github.com/escardin/angular2-jwt.git","svn_url":"https://github.com/escardin/angular2-jwt","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"764f3f87abd2dcadbc989eac71ed01f3dec56193","user":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":44948282,"name":"angular2-jwt","full_name":"auth0/angular2-jwt","owner":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/angular2-jwt","description":"Helper library for handling JWTs in Angular 2 apps","fork":false,"url":"https://api.github.com/repos/auth0/angular2-jwt","forks_url":"https://api.github.com/repos/auth0/angular2-jwt/forks","keys_url":"https://api.github.com/repos/auth0/angular2-jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/angular2-jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/angular2-jwt/teams","hooks_url":"https://api.github.com/repos/auth0/angular2-jwt/hooks","issue_events_url":"https://api.github.com/repos/auth0/angular2-jwt/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/angular2-jwt/events","assignees_url":"https://api.github.com/repos/auth0/angular2-jwt/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/angular2-jwt/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/angular2-jwt/tags","blobs_url":"https://api.github.com/repos/auth0/angular2-jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/angular2-jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/angular2-jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/angular2-jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/angular2-jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/angular2-jwt/languages","stargazers_url":"https://api.github.com/repos/auth0/angular2-jwt/stargazers","contributors_url":"https://api.github.com/repos/auth0/angular2-jwt/contributors","subscribers_url":"https://api.github.com/repos/auth0/angular2-jwt/subscribers","subscription_url":"https://api.github.com/repos/auth0/angular2-jwt/subscription","commits_url":"https://api.github.com/repos/auth0/angular2-jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/angular2-jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/angular2-jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/angular2-jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/angular2-jwt/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/angular2-jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/angular2-jwt/merges","archive_url":"https://api.github.com/repos/auth0/angular2-jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/angular2-jwt/downloads","issues_url":"https://api.github.com/repos/auth0/angular2-jwt/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/angular2-jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/angular2-jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/angular2-jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/angular2-jwt/labels{/name}","releases_url":"https://api.github.com/repos/auth0/angular2-jwt/releases{/id}","created_at":"2015-10-26T05:37:39Z","updated_at":"2015-12-22T13:44:11Z","pushed_at":"2015-12-23T14:52:13Z","git_url":"git://github.com/auth0/angular2-jwt.git","ssh_url":"git@github.com:auth0/angular2-jwt.git","clone_url":"https://github.com/auth0/angular2-jwt.git","svn_url":"https://github.com/auth0/angular2-jwt","homepage":null,"size":43,"stargazers_count":40,"watchers_count":40,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6"},"html":{"href":"https://github.com/auth0/angular2-jwt/pull/6"},"issue":{"href":"https://api.github.com/repos/auth0/angular2-jwt/issues/6"},"comments":{"href":"https://api.github.com/repos/auth0/angular2-jwt/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/angular2-jwt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/angular2-jwt/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/angular2-jwt/statuses/00b24cbc9ba02129ba23108ef6fe3cfb3eb79772"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chenkie","id":1847678,"avatar_url":"https://avatars.githubusercontent.com/u/1847678?v=3","gravatar_id":"","url":"https://api.github.com/users/chenkie","html_url":"https://github.com/chenkie","followers_url":"https://api.github.com/users/chenkie/followers","following_url":"https://api.github.com/users/chenkie/following{/other_user}","gists_url":"https://api.github.com/users/chenkie/gists{/gist_id}","starred_url":"https://api.github.com/users/chenkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenkie/subscriptions","organizations_url":"https://api.github.com/users/chenkie/orgs","repos_url":"https://api.github.com/users/chenkie/repos","events_url":"https://api.github.com/users/chenkie/events{/privacy}","received_events_url":"https://api.github.com/users/chenkie/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":11,"changed_files":2}}