{"action":"closed","number":14586,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/14586","id":39808548,"html_url":"https://github.com/docker/docker/pull/14586","diff_url":"https://github.com/docker/docker/pull/14586.diff","patch_url":"https://github.com/docker/docker/pull/14586.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/14586","number":14586,"state":"closed","locked":false,"title":"Improve sockRequest and sockRequestRaw check","user":{"login":"Tenk42","id":13029445,"avatar_url":"https://avatars.githubusercontent.com/u/13029445?v=3","gravatar_id":"","url":"https://api.github.com/users/Tenk42","html_url":"https://github.com/Tenk42","followers_url":"https://api.github.com/users/Tenk42/followers","following_url":"https://api.github.com/users/Tenk42/following{/other_user}","gists_url":"https://api.github.com/users/Tenk42/gists{/gist_id}","starred_url":"https://api.github.com/users/Tenk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tenk42/subscriptions","organizations_url":"https://api.github.com/users/Tenk42/orgs","repos_url":"https://api.github.com/users/Tenk42/repos","events_url":"https://api.github.com/users/Tenk42/events{/privacy}","received_events_url":"https://api.github.com/users/Tenk42/received_events","type":"User","site_admin":false},"body":"Fix: #14362 \r\nFixes: #14362\r\n\r\nImprove error check on SocketRequest and SocketRequestRaw on:\r\nintegration-cli/docker_api_containers_test.go\r\n\r\nSigned-off-by: Quentin Tayssier <qtayssier@gmail.com>","created_at":"2015-07-13T12:58:16Z","updated_at":"2015-07-13T13:59:39Z","closed_at":"2015-07-13T13:59:39Z","merged_at":"2015-07-13T13:59:39Z","merge_commit_sha":"c28cf71d29470f99b9c08db8a0559ddfdca864cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/14586/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/14586/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/14586/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/fa6925aa9b3aad37e93bc38602bb665b4a2badf9","head":{"label":"Tenk42:14362-Improve-sockRequestRaw-check","ref":"14362-Improve-sockRequestRaw-check","sha":"fa6925aa9b3aad37e93bc38602bb665b4a2badf9","user":{"login":"Tenk42","id":13029445,"avatar_url":"https://avatars.githubusercontent.com/u/13029445?v=3","gravatar_id":"","url":"https://api.github.com/users/Tenk42","html_url":"https://github.com/Tenk42","followers_url":"https://api.github.com/users/Tenk42/followers","following_url":"https://api.github.com/users/Tenk42/following{/other_user}","gists_url":"https://api.github.com/users/Tenk42/gists{/gist_id}","starred_url":"https://api.github.com/users/Tenk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tenk42/subscriptions","organizations_url":"https://api.github.com/users/Tenk42/orgs","repos_url":"https://api.github.com/users/Tenk42/repos","events_url":"https://api.github.com/users/Tenk42/events{/privacy}","received_events_url":"https://api.github.com/users/Tenk42/received_events","type":"User","site_admin":false},"repo":{"id":37968976,"name":"docker","full_name":"Tenk42/docker","owner":{"login":"Tenk42","id":13029445,"avatar_url":"https://avatars.githubusercontent.com/u/13029445?v=3","gravatar_id":"","url":"https://api.github.com/users/Tenk42","html_url":"https://github.com/Tenk42","followers_url":"https://api.github.com/users/Tenk42/followers","following_url":"https://api.github.com/users/Tenk42/following{/other_user}","gists_url":"https://api.github.com/users/Tenk42/gists{/gist_id}","starred_url":"https://api.github.com/users/Tenk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tenk42/subscriptions","organizations_url":"https://api.github.com/users/Tenk42/orgs","repos_url":"https://api.github.com/users/Tenk42/repos","events_url":"https://api.github.com/users/Tenk42/events{/privacy}","received_events_url":"https://api.github.com/users/Tenk42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tenk42/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/Tenk42/docker","forks_url":"https://api.github.com/repos/Tenk42/docker/forks","keys_url":"https://api.github.com/repos/Tenk42/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tenk42/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tenk42/docker/teams","hooks_url":"https://api.github.com/repos/Tenk42/docker/hooks","issue_events_url":"https://api.github.com/repos/Tenk42/docker/issues/events{/number}","events_url":"https://api.github.com/repos/Tenk42/docker/events","assignees_url":"https://api.github.com/repos/Tenk42/docker/assignees{/user}","branches_url":"https://api.github.com/repos/Tenk42/docker/branches{/branch}","tags_url":"https://api.github.com/repos/Tenk42/docker/tags","blobs_url":"https://api.github.com/repos/Tenk42/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tenk42/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tenk42/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tenk42/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tenk42/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Tenk42/docker/languages","stargazers_url":"https://api.github.com/repos/Tenk42/docker/stargazers","contributors_url":"https://api.github.com/repos/Tenk42/docker/contributors","subscribers_url":"https://api.github.com/repos/Tenk42/docker/subscribers","subscription_url":"https://api.github.com/repos/Tenk42/docker/subscription","commits_url":"https://api.github.com/repos/Tenk42/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tenk42/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tenk42/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tenk42/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tenk42/docker/contents/{+path}","compare_url":"https://api.github.com/repos/Tenk42/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tenk42/docker/merges","archive_url":"https://api.github.com/repos/Tenk42/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tenk42/docker/downloads","issues_url":"https://api.github.com/repos/Tenk42/docker/issues{/number}","pulls_url":"https://api.github.com/repos/Tenk42/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Tenk42/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Tenk42/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tenk42/docker/labels{/name}","releases_url":"https://api.github.com/repos/Tenk42/docker/releases{/id}","created_at":"2015-06-24T07:21:02Z","updated_at":"2015-06-24T07:21:10Z","pushed_at":"2015-07-13T12:49:54Z","git_url":"git://github.com/Tenk42/docker.git","ssh_url":"git@github.com:Tenk42/docker.git","clone_url":"https://github.com/Tenk42/docker.git","svn_url":"https://github.com/Tenk42/docker","homepage":"http://www.docker.com","size":59736,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b0da494aa30df76533fdb0f66efbf5b17b3ed214","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-07-13T13:39:59Z","pushed_at":"2015-07-13T13:59:39Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":223146,"stargazers_count":23206,"watchers_count":23206,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5734,"mirror_url":null,"open_issues_count":1039,"forks":5734,"open_issues":1039,"watchers":23206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/14586"},"html":{"href":"https://github.com/docker/docker/pull/14586"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/14586"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/14586/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/14586/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/14586/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/fa6925aa9b3aad37e93bc38602bb665b4a2badf9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":44,"deletions":44,"changed_files":1}}