{"action":"closed","number":670,"pull_request":{"url":"https://api.github.com/repos/yabwe/medium-editor/pulls/670","id":36983810,"html_url":"https://github.com/yabwe/medium-editor/pull/670","diff_url":"https://github.com/yabwe/medium-editor/pull/670.diff","patch_url":"https://github.com/yabwe/medium-editor/pull/670.patch","issue_url":"https://api.github.com/repos/yabwe/medium-editor/issues/670","number":670,"state":"closed","locked":false,"title":"Expose button default config (replace MediumEditor.statics.ButtonsData)","user":{"login":"nmielnik","id":2444240,"avatar_url":"https://avatars.githubusercontent.com/u/2444240?v=3","gravatar_id":"","url":"https://api.github.com/users/nmielnik","html_url":"https://github.com/nmielnik","followers_url":"https://api.github.com/users/nmielnik/followers","following_url":"https://api.github.com/users/nmielnik/following{/other_user}","gists_url":"https://api.github.com/users/nmielnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nmielnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmielnik/subscriptions","organizations_url":"https://api.github.com/users/nmielnik/orgs","repos_url":"https://api.github.com/users/nmielnik/repos","events_url":"https://api.github.com/users/nmielnik/events{/privacy}","received_events_url":"https://api.github.com/users/nmielnik/received_events","type":"User","site_admin":false},"body":"Before version 5.0.0, the set of default button configuration was exposed via `MediumEditor.statics.ButtonsData`.  This contained all the config options to differentiate the various built-in MediumEditor buttons (ie `bold`, `italic`, `underline`, etc.)\r\n\r\nTo give users the ability to access the data, but still align with how our other options and defaults are exposed, I've exposed this set of data via the button prototype (`MediumEditor.extensions.button.prototype.defaults`).\r\n\r\nAlso, to help reduce the cases where this data might be needed, I've added 2 additional features:\r\n\r\n1. The button extension constructor can be invoked and passed the name of a built-in button (instead of an object containing all the button options).  For that case, it will initialize itself with the default config data for that button.\r\n2. A `isBuiltInButton()` method is now exposed on the button extension constructor itself (statically).  Now, calls to `MediumEditor.extensions.button.isBuiltInButton(name)` will return true or false if the text describes a built-in button:\r\n  * `MediumEditor.extensions.button.isBuiltInButton('bold')` returns `true`\r\n  * `MediumEditor.extensions.button.isBuiltInButton('blah')` returns `false`\r\n\r\nI've also added documentation that describes what all of the options for the button extension do.","created_at":"2015-06-04T22:11:59Z","updated_at":"2015-06-05T13:10:10Z","closed_at":"2015-06-05T13:10:10Z","merged_at":"2015-06-05T13:10:10Z","merge_commit_sha":"72bfd9813323c0d2f7821ea1e4a585e21b7d91aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yabwe/medium-editor/pulls/670/commits","review_comments_url":"https://api.github.com/repos/yabwe/medium-editor/pulls/670/comments","review_comment_url":"https://api.github.com/repos/yabwe/medium-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yabwe/medium-editor/issues/670/comments","statuses_url":"https://api.github.com/repos/yabwe/medium-editor/statuses/2320c8b32b19720df63da09bb1c2b1391b7cbd3f","head":{"label":"yabwe:buttons-config","ref":"buttons-config","sha":"2320c8b32b19720df63da09bb1c2b1391b7cbd3f","user":{"login":"yabwe","id":12655868,"avatar_url":"https://avatars.githubusercontent.com/u/12655868?v=3","gravatar_id":"","url":"https://api.github.com/users/yabwe","html_url":"https://github.com/yabwe","followers_url":"https://api.github.com/users/yabwe/followers","following_url":"https://api.github.com/users/yabwe/following{/other_user}","gists_url":"https://api.github.com/users/yabwe/gists{/gist_id}","starred_url":"https://api.github.com/users/yabwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabwe/subscriptions","organizations_url":"https://api.github.com/users/yabwe/orgs","repos_url":"https://api.github.com/users/yabwe/repos","events_url":"https://api.github.com/users/yabwe/events{/privacy}","received_events_url":"https://api.github.com/users/yabwe/received_events","type":"Organization","site_admin":false},"repo":{"id":10365411,"name":"medium-editor","full_name":"yabwe/medium-editor","owner":{"login":"yabwe","id":12655868,"avatar_url":"https://avatars.githubusercontent.com/u/12655868?v=3","gravatar_id":"","url":"https://api.github.com/users/yabwe","html_url":"https://github.com/yabwe","followers_url":"https://api.github.com/users/yabwe/followers","following_url":"https://api.github.com/users/yabwe/following{/other_user}","gists_url":"https://api.github.com/users/yabwe/gists{/gist_id}","starred_url":"https://api.github.com/users/yabwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabwe/subscriptions","organizations_url":"https://api.github.com/users/yabwe/orgs","repos_url":"https://api.github.com/users/yabwe/repos","events_url":"https://api.github.com/users/yabwe/events{/privacy}","received_events_url":"https://api.github.com/users/yabwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yabwe/medium-editor","description":"Medium.com WYSIWYG editor clone. Uses contenteditable API to implement a rich text solution.","fork":false,"url":"https://api.github.com/repos/yabwe/medium-editor","forks_url":"https://api.github.com/repos/yabwe/medium-editor/forks","keys_url":"https://api.github.com/repos/yabwe/medium-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yabwe/medium-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yabwe/medium-editor/teams","hooks_url":"https://api.github.com/repos/yabwe/medium-editor/hooks","issue_events_url":"https://api.github.com/repos/yabwe/medium-editor/issues/events{/number}","events_url":"https://api.github.com/repos/yabwe/medium-editor/events","assignees_url":"https://api.github.com/repos/yabwe/medium-editor/assignees{/user}","branches_url":"https://api.github.com/repos/yabwe/medium-editor/branches{/branch}","tags_url":"https://api.github.com/repos/yabwe/medium-editor/tags","blobs_url":"https://api.github.com/repos/yabwe/medium-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yabwe/medium-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yabwe/medium-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/yabwe/medium-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yabwe/medium-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/yabwe/medium-editor/languages","stargazers_url":"https://api.github.com/repos/yabwe/medium-editor/stargazers","contributors_url":"https://api.github.com/repos/yabwe/medium-editor/contributors","subscribers_url":"https://api.github.com/repos/yabwe/medium-editor/subscribers","subscription_url":"https://api.github.com/repos/yabwe/medium-editor/subscription","commits_url":"https://api.github.com/repos/yabwe/medium-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/yabwe/medium-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/yabwe/medium-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/yabwe/medium-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/yabwe/medium-editor/contents/{+path}","compare_url":"https://api.github.com/repos/yabwe/medium-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yabwe/medium-editor/merges","archive_url":"https://api.github.com/repos/yabwe/medium-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yabwe/medium-editor/downloads","issues_url":"https://api.github.com/repos/yabwe/medium-editor/issues{/number}","pulls_url":"https://api.github.com/repos/yabwe/medium-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/yabwe/medium-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/yabwe/medium-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yabwe/medium-editor/labels{/name}","releases_url":"https://api.github.com/repos/yabwe/medium-editor/releases{/id}","created_at":"2013-05-29T17:40:11Z","updated_at":"2015-06-05T06:56:21Z","pushed_at":"2015-06-05T13:10:10Z","git_url":"git://github.com/yabwe/medium-editor.git","ssh_url":"git@github.com:yabwe/medium-editor.git","clone_url":"https://github.com/yabwe/medium-editor.git","svn_url":"https://github.com/yabwe/medium-editor","homepage":"https://yabwe.github.io/medium-editor/","size":13833,"stargazers_count":5063,"watchers_count":5063,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":625,"mirror_url":null,"open_issues_count":91,"forks":625,"open_issues":91,"watchers":5063,"default_branch":"master"}},"base":{"label":"yabwe:v5","ref":"v5","sha":"89ed849f4065bc24a78779bd0b943a90be9f8515","user":{"login":"yabwe","id":12655868,"avatar_url":"https://avatars.githubusercontent.com/u/12655868?v=3","gravatar_id":"","url":"https://api.github.com/users/yabwe","html_url":"https://github.com/yabwe","followers_url":"https://api.github.com/users/yabwe/followers","following_url":"https://api.github.com/users/yabwe/following{/other_user}","gists_url":"https://api.github.com/users/yabwe/gists{/gist_id}","starred_url":"https://api.github.com/users/yabwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabwe/subscriptions","organizations_url":"https://api.github.com/users/yabwe/orgs","repos_url":"https://api.github.com/users/yabwe/repos","events_url":"https://api.github.com/users/yabwe/events{/privacy}","received_events_url":"https://api.github.com/users/yabwe/received_events","type":"Organization","site_admin":false},"repo":{"id":10365411,"name":"medium-editor","full_name":"yabwe/medium-editor","owner":{"login":"yabwe","id":12655868,"avatar_url":"https://avatars.githubusercontent.com/u/12655868?v=3","gravatar_id":"","url":"https://api.github.com/users/yabwe","html_url":"https://github.com/yabwe","followers_url":"https://api.github.com/users/yabwe/followers","following_url":"https://api.github.com/users/yabwe/following{/other_user}","gists_url":"https://api.github.com/users/yabwe/gists{/gist_id}","starred_url":"https://api.github.com/users/yabwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabwe/subscriptions","organizations_url":"https://api.github.com/users/yabwe/orgs","repos_url":"https://api.github.com/users/yabwe/repos","events_url":"https://api.github.com/users/yabwe/events{/privacy}","received_events_url":"https://api.github.com/users/yabwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yabwe/medium-editor","description":"Medium.com WYSIWYG editor clone. Uses contenteditable API to implement a rich text solution.","fork":false,"url":"https://api.github.com/repos/yabwe/medium-editor","forks_url":"https://api.github.com/repos/yabwe/medium-editor/forks","keys_url":"https://api.github.com/repos/yabwe/medium-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yabwe/medium-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yabwe/medium-editor/teams","hooks_url":"https://api.github.com/repos/yabwe/medium-editor/hooks","issue_events_url":"https://api.github.com/repos/yabwe/medium-editor/issues/events{/number}","events_url":"https://api.github.com/repos/yabwe/medium-editor/events","assignees_url":"https://api.github.com/repos/yabwe/medium-editor/assignees{/user}","branches_url":"https://api.github.com/repos/yabwe/medium-editor/branches{/branch}","tags_url":"https://api.github.com/repos/yabwe/medium-editor/tags","blobs_url":"https://api.github.com/repos/yabwe/medium-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yabwe/medium-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yabwe/medium-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/yabwe/medium-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yabwe/medium-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/yabwe/medium-editor/languages","stargazers_url":"https://api.github.com/repos/yabwe/medium-editor/stargazers","contributors_url":"https://api.github.com/repos/yabwe/medium-editor/contributors","subscribers_url":"https://api.github.com/repos/yabwe/medium-editor/subscribers","subscription_url":"https://api.github.com/repos/yabwe/medium-editor/subscription","commits_url":"https://api.github.com/repos/yabwe/medium-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/yabwe/medium-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/yabwe/medium-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/yabwe/medium-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/yabwe/medium-editor/contents/{+path}","compare_url":"https://api.github.com/repos/yabwe/medium-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yabwe/medium-editor/merges","archive_url":"https://api.github.com/repos/yabwe/medium-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yabwe/medium-editor/downloads","issues_url":"https://api.github.com/repos/yabwe/medium-editor/issues{/number}","pulls_url":"https://api.github.com/repos/yabwe/medium-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/yabwe/medium-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/yabwe/medium-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yabwe/medium-editor/labels{/name}","releases_url":"https://api.github.com/repos/yabwe/medium-editor/releases{/id}","created_at":"2013-05-29T17:40:11Z","updated_at":"2015-06-05T06:56:21Z","pushed_at":"2015-06-05T13:10:10Z","git_url":"git://github.com/yabwe/medium-editor.git","ssh_url":"git@github.com:yabwe/medium-editor.git","clone_url":"https://github.com/yabwe/medium-editor.git","svn_url":"https://github.com/yabwe/medium-editor","homepage":"https://yabwe.github.io/medium-editor/","size":13833,"stargazers_count":5063,"watchers_count":5063,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":625,"mirror_url":null,"open_issues_count":91,"forks":625,"open_issues":91,"watchers":5063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yabwe/medium-editor/pulls/670"},"html":{"href":"https://github.com/yabwe/medium-editor/pull/670"},"issue":{"href":"https://api.github.com/repos/yabwe/medium-editor/issues/670"},"comments":{"href":"https://api.github.com/repos/yabwe/medium-editor/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/yabwe/medium-editor/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/yabwe/medium-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yabwe/medium-editor/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/yabwe/medium-editor/statuses/2320c8b32b19720df63da09bb1c2b1391b7cbd3f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"j0k3r","id":62333,"avatar_url":"https://avatars.githubusercontent.com/u/62333?v=3","gravatar_id":"","url":"https://api.github.com/users/j0k3r","html_url":"https://github.com/j0k3r","followers_url":"https://api.github.com/users/j0k3r/followers","following_url":"https://api.github.com/users/j0k3r/following{/other_user}","gists_url":"https://api.github.com/users/j0k3r/gists{/gist_id}","starred_url":"https://api.github.com/users/j0k3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0k3r/subscriptions","organizations_url":"https://api.github.com/users/j0k3r/orgs","repos_url":"https://api.github.com/users/j0k3r/repos","events_url":"https://api.github.com/users/j0k3r/events{/privacy}","received_events_url":"https://api.github.com/users/j0k3r/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":2,"additions":131,"deletions":8,"changed_files":4}}