{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/2870","labels_url":"https://api.github.com/repos/aspnet/Mvc/issues/2870/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2870/comments","events_url":"https://api.github.com/repos/aspnet/Mvc/issues/2870/events","html_url":"https://github.com/aspnet/Mvc/pull/2870","id":97673955,"number":2870,"title":"Add operation JsonPatch => dynamic support","user":{"login":"KevinDockx","id":2431035,"avatar_url":"https://avatars.githubusercontent.com/u/2431035?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinDockx","html_url":"https://github.com/KevinDockx","followers_url":"https://api.github.com/users/KevinDockx/followers","following_url":"https://api.github.com/users/KevinDockx/following{/other_user}","gists_url":"https://api.github.com/users/KevinDockx/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinDockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinDockx/subscriptions","organizations_url":"https://api.github.com/users/KevinDockx/orgs","repos_url":"https://api.github.com/users/KevinDockx/repos","events_url":"https://api.github.com/users/KevinDockx/events{/privacy}","received_events_url":"https://api.github.com/users/KevinDockx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet/Mvc/labels/cla-signed","name":"cla-signed","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-28T10:45:52Z","updated_at":"2015-08-07T16:01:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2870","html_url":"https://github.com/aspnet/Mvc/pull/2870","diff_url":"https://github.com/aspnet/Mvc/pull/2870.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2870.patch"},"body":"(after rebase & including fix for NotNull on path as per Kirthi's comments)\r\n\r\nMost important changes:\r\n- Added ObjectTreeAnalysisResult: this class analyzes the object tree and results in an object that's used by the Add method to know if it should use \"dynamic logic\" (ie: add to the Dictionary) or \"regular logic\" (staticly typed). JsonContract checks moved to this class instead of in the Add method\r\n- Changes in the Add method: split-up between regular & dynamic\r\n- Addition of GetNumericEndResult: used in Add to act differently when a numeric end is found vs when it's found but is invalid\r\n\r\nNote that this is just the Add operation. Once this is approved & suggestions/comments are incorporated, the other methods will be changed as well - and that's when I can clean up the code a bit more (for example: GetNumericEnd can be removed, GetNumericEndResult can be renamed, helpers to find properties with JsonContract can be removed as they now are in ObjectTreeAnalyisResult, ...)"},"comment":{"url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/128747383","html_url":"https://github.com/aspnet/Mvc/pull/2870#issuecomment-128747383","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2870","id":128747383,"user":{"login":"KevinDockx","id":2431035,"avatar_url":"https://avatars.githubusercontent.com/u/2431035?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinDockx","html_url":"https://github.com/KevinDockx","followers_url":"https://api.github.com/users/KevinDockx/followers","following_url":"https://api.github.com/users/KevinDockx/following{/other_user}","gists_url":"https://api.github.com/users/KevinDockx/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinDockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinDockx/subscriptions","organizations_url":"https://api.github.com/users/KevinDockx/orgs","repos_url":"https://api.github.com/users/KevinDockx/repos","events_url":"https://api.github.com/users/KevinDockx/events{/privacy}","received_events_url":"https://api.github.com/users/KevinDockx/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T16:01:42Z","updated_at":"2015-08-07T16:01:42Z","body":"@Eilon No problem, just signed it :-)"}}