{"action":"opened","number":42,"pull_request":{"url":"https://api.github.com/repos/lotus/validations/pulls/42","id":27036225,"html_url":"https://github.com/lotus/validations/pull/42","diff_url":"https://github.com/lotus/validations/pull/42.diff","patch_url":"https://github.com/lotus/validations/pull/42.patch","issue_url":"https://api.github.com/repos/lotus/validations/issues/42","number":42,"state":"open","locked":false,"title":"Ensure whitelisted assignment of attributes doesn't include ruby methods","user":{"login":"stevehodgkiss","id":62331,"avatar_url":"https://avatars.githubusercontent.com/u/62331?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehodgkiss","html_url":"https://github.com/stevehodgkiss","followers_url":"https://api.github.com/users/stevehodgkiss/followers","following_url":"https://api.github.com/users/stevehodgkiss/following{/other_user}","gists_url":"https://api.github.com/users/stevehodgkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehodgkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehodgkiss/subscriptions","organizations_url":"https://api.github.com/users/stevehodgkiss/orgs","repos_url":"https://api.github.com/users/stevehodgkiss/repos","events_url":"https://api.github.com/users/stevehodgkiss/events{/privacy}","received_events_url":"https://api.github.com/users/stevehodgkiss/received_events","type":"User","site_admin":false},"body":"This PR whitelists the assignment of attributes to the set of defined attributes (`public_send(writer, value) if self.class.defined_attributes.include?(key.to_s)`), and also fixes a couple of other issues that came up because of this:\r\n\r\n- confirmation attributes weren't being added as attributes, now they are.\r\n- defined_attributes has been changed to make inheritance and inclusion work as expected.","created_at":"2015-01-08T15:39:04Z","updated_at":"2015-01-08T15:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lotus/validations/pulls/42/commits","review_comments_url":"https://api.github.com/repos/lotus/validations/pulls/42/comments","review_comment_url":"https://api.github.com/repos/lotus/validations/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lotus/validations/issues/42/comments","statuses_url":"https://api.github.com/repos/lotus/validations/statuses/41edd559458d4a5f539be43dcae86ca2bdfa19d8","head":{"label":"stevehodgkiss:ensure_whitelisted_public_send","ref":"ensure_whitelisted_public_send","sha":"41edd559458d4a5f539be43dcae86ca2bdfa19d8","user":{"login":"stevehodgkiss","id":62331,"avatar_url":"https://avatars.githubusercontent.com/u/62331?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehodgkiss","html_url":"https://github.com/stevehodgkiss","followers_url":"https://api.github.com/users/stevehodgkiss/followers","following_url":"https://api.github.com/users/stevehodgkiss/following{/other_user}","gists_url":"https://api.github.com/users/stevehodgkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehodgkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehodgkiss/subscriptions","organizations_url":"https://api.github.com/users/stevehodgkiss/orgs","repos_url":"https://api.github.com/users/stevehodgkiss/repos","events_url":"https://api.github.com/users/stevehodgkiss/events{/privacy}","received_events_url":"https://api.github.com/users/stevehodgkiss/received_events","type":"User","site_admin":false},"repo":{"id":28606101,"name":"validations","full_name":"stevehodgkiss/validations","owner":{"login":"stevehodgkiss","id":62331,"avatar_url":"https://avatars.githubusercontent.com/u/62331?v=3","gravatar_id":"","url":"https://api.github.com/users/stevehodgkiss","html_url":"https://github.com/stevehodgkiss","followers_url":"https://api.github.com/users/stevehodgkiss/followers","following_url":"https://api.github.com/users/stevehodgkiss/following{/other_user}","gists_url":"https://api.github.com/users/stevehodgkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/stevehodgkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevehodgkiss/subscriptions","organizations_url":"https://api.github.com/users/stevehodgkiss/orgs","repos_url":"https://api.github.com/users/stevehodgkiss/repos","events_url":"https://api.github.com/users/stevehodgkiss/events{/privacy}","received_events_url":"https://api.github.com/users/stevehodgkiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevehodgkiss/validations","description":"Validation mixin for Ruby objects","fork":true,"url":"https://api.github.com/repos/stevehodgkiss/validations","forks_url":"https://api.github.com/repos/stevehodgkiss/validations/forks","keys_url":"https://api.github.com/repos/stevehodgkiss/validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevehodgkiss/validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevehodgkiss/validations/teams","hooks_url":"https://api.github.com/repos/stevehodgkiss/validations/hooks","issue_events_url":"https://api.github.com/repos/stevehodgkiss/validations/issues/events{/number}","events_url":"https://api.github.com/repos/stevehodgkiss/validations/events","assignees_url":"https://api.github.com/repos/stevehodgkiss/validations/assignees{/user}","branches_url":"https://api.github.com/repos/stevehodgkiss/validations/branches{/branch}","tags_url":"https://api.github.com/repos/stevehodgkiss/validations/tags","blobs_url":"https://api.github.com/repos/stevehodgkiss/validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevehodgkiss/validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevehodgkiss/validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevehodgkiss/validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevehodgkiss/validations/statuses/{sha}","languages_url":"https://api.github.com/repos/stevehodgkiss/validations/languages","stargazers_url":"https://api.github.com/repos/stevehodgkiss/validations/stargazers","contributors_url":"https://api.github.com/repos/stevehodgkiss/validations/contributors","subscribers_url":"https://api.github.com/repos/stevehodgkiss/validations/subscribers","subscription_url":"https://api.github.com/repos/stevehodgkiss/validations/subscription","commits_url":"https://api.github.com/repos/stevehodgkiss/validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevehodgkiss/validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevehodgkiss/validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevehodgkiss/validations/issues/comments/{number}","contents_url":"https://api.github.com/repos/stevehodgkiss/validations/contents/{+path}","compare_url":"https://api.github.com/repos/stevehodgkiss/validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevehodgkiss/validations/merges","archive_url":"https://api.github.com/repos/stevehodgkiss/validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevehodgkiss/validations/downloads","issues_url":"https://api.github.com/repos/stevehodgkiss/validations/issues{/number}","pulls_url":"https://api.github.com/repos/stevehodgkiss/validations/pulls{/number}","milestones_url":"https://api.github.com/repos/stevehodgkiss/validations/milestones{/number}","notifications_url":"https://api.github.com/repos/stevehodgkiss/validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevehodgkiss/validations/labels{/name}","releases_url":"https://api.github.com/repos/stevehodgkiss/validations/releases{/id}","created_at":"2014-12-29T20:53:49Z","updated_at":"2014-12-29T20:53:50Z","pushed_at":"2015-01-08T15:35:09Z","git_url":"git://github.com/stevehodgkiss/validations.git","ssh_url":"git@github.com:stevehodgkiss/validations.git","clone_url":"https://github.com/stevehodgkiss/validations.git","svn_url":"https://github.com/stevehodgkiss/validations","homepage":"http://lotusrb.org","size":306,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lotus:master","ref":"master","sha":"6ddcfdb67a5b3ceb39ba43cd506f645324a2ca93","user":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"repo":{"id":22643222,"name":"validations","full_name":"lotus/validations","owner":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lotus/validations","description":"Validation mixin for Ruby objects","fork":false,"url":"https://api.github.com/repos/lotus/validations","forks_url":"https://api.github.com/repos/lotus/validations/forks","keys_url":"https://api.github.com/repos/lotus/validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lotus/validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lotus/validations/teams","hooks_url":"https://api.github.com/repos/lotus/validations/hooks","issue_events_url":"https://api.github.com/repos/lotus/validations/issues/events{/number}","events_url":"https://api.github.com/repos/lotus/validations/events","assignees_url":"https://api.github.com/repos/lotus/validations/assignees{/user}","branches_url":"https://api.github.com/repos/lotus/validations/branches{/branch}","tags_url":"https://api.github.com/repos/lotus/validations/tags","blobs_url":"https://api.github.com/repos/lotus/validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lotus/validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lotus/validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/lotus/validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lotus/validations/statuses/{sha}","languages_url":"https://api.github.com/repos/lotus/validations/languages","stargazers_url":"https://api.github.com/repos/lotus/validations/stargazers","contributors_url":"https://api.github.com/repos/lotus/validations/contributors","subscribers_url":"https://api.github.com/repos/lotus/validations/subscribers","subscription_url":"https://api.github.com/repos/lotus/validations/subscription","commits_url":"https://api.github.com/repos/lotus/validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/lotus/validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/lotus/validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/lotus/validations/issues/comments/{number}","contents_url":"https://api.github.com/repos/lotus/validations/contents/{+path}","compare_url":"https://api.github.com/repos/lotus/validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lotus/validations/merges","archive_url":"https://api.github.com/repos/lotus/validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lotus/validations/downloads","issues_url":"https://api.github.com/repos/lotus/validations/issues{/number}","pulls_url":"https://api.github.com/repos/lotus/validations/pulls{/number}","milestones_url":"https://api.github.com/repos/lotus/validations/milestones{/number}","notifications_url":"https://api.github.com/repos/lotus/validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lotus/validations/labels{/name}","releases_url":"https://api.github.com/repos/lotus/validations/releases{/id}","created_at":"2014-08-05T12:49:35Z","updated_at":"2015-01-08T14:31:58Z","pushed_at":"2015-01-08T14:32:16Z","git_url":"git://github.com/lotus/validations.git","ssh_url":"git@github.com:lotus/validations.git","clone_url":"https://github.com/lotus/validations.git","svn_url":"https://github.com/lotus/validations","homepage":"http://lotusrb.org","size":897,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lotus/validations/pulls/42"},"html":{"href":"https://github.com/lotus/validations/pull/42"},"issue":{"href":"https://api.github.com/repos/lotus/validations/issues/42"},"comments":{"href":"https://api.github.com/repos/lotus/validations/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/lotus/validations/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/lotus/validations/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lotus/validations/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/lotus/validations/statuses/41edd559458d4a5f539be43dcae86ca2bdfa19d8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":47,"deletions":12,"changed_files":4}}