{"action":"created","comment":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/29135058","id":29135058,"diff_hunk":"@@ -76,8 +76,10 @@ def _pythran_cppflags():\n \n     def get(*x):\n         return '-I' + os.path.join(curr_dir, *x)\n-    return [get('.'), get('pythran'),\n-            get('pythran', 'pythonic', 'patch')]\n+    flags = [get('.'), get('pythran')]\n+    if cfg.get('pythran', 'complex_hook'): # the patch is *not* portable","path":"pythran/toolchain.py","position":7,"original_position":7,"commit_id":"db3d854b30a67e2f44696ced64413d90f46e9a47","original_commit_id":"db3d854b30a67e2f44696ced64413d90f46e9a47","user":{"login":"pbrunet","id":1872390,"avatar_url":"https://avatars.githubusercontent.com/u/1872390?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrunet","html_url":"https://github.com/pbrunet","followers_url":"https://api.github.com/users/pbrunet/followers","following_url":"https://api.github.com/users/pbrunet/following{/other_user}","gists_url":"https://api.github.com/users/pbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunet/subscriptions","organizations_url":"https://api.github.com/users/pbrunet/orgs","repos_url":"https://api.github.com/users/pbrunet/repos","events_url":"https://api.github.com/users/pbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunet/received_events","type":"User","site_admin":false},"body":"I think you should use \"cfg.getbool\". Otherwise it is almost always True.","created_at":"2015-04-27T10:14:35Z","updated_at":"2015-04-27T10:14:35Z","html_url":"https://github.com/serge-sans-paille/pythran/pull/447#discussion_r29135058","pull_request_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447","_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/29135058"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/447#discussion_r29135058"},"pull_request":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447"}}},"pull_request":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447","id":34152199,"html_url":"https://github.com/serge-sans-paille/pythran/pull/447","diff_url":"https://github.com/serge-sans-paille/pythran/pull/447.diff","patch_url":"https://github.com/serge-sans-paille/pythran/pull/447.patch","issue_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/447","number":447,"state":"open","locked":false,"title":"Minimalist install","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"body":"- remove complex hack dependency\r\n- remove optional tcmalloc dependency\r\n- document the pythranrc customization steps","created_at":"2015-04-27T09:27:59Z","updated_at":"2015-04-27T10:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0493d23563ba9d7f1d976101b6b4afc57075be7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447/commits","review_comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447/comments","review_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/447/comments","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/db3d854b30a67e2f44696ced64413d90f46e9a47","head":{"label":"serge-sans-paille:bugfix/complex-patch-portability","ref":"bugfix/complex-patch-portability","sha":"db3d854b30a67e2f44696ced64413d90f46e9a47","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","created_at":"2012-05-29T08:02:14Z","updated_at":"2015-04-26T19:51:33Z","pushed_at":"2015-04-27T10:13:05Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":19550,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":69,"forks":36,"open_issues":69,"watchers":226,"default_branch":"master"}},"base":{"label":"serge-sans-paille:master","ref":"master","sha":"9e97a21514a6518a29411ec529f21499b0bb4bb5","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","created_at":"2012-05-29T08:02:14Z","updated_at":"2015-04-26T19:51:33Z","pushed_at":"2015-04-27T10:13:05Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":19550,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":69,"forks":36,"open_issues":69,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/447"},"issue":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/447"},"comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/db3d854b30a67e2f44696ced64413d90f46e9a47"}}}}