{"action":"closed","issue":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2926","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2926/labels{/name}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2926/comments","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/2926/events","html_url":"https://github.com/SimpleMachines/SMF2.1/issues/2926","id":95570201,"number":2926,"title":"Buggy behavior in Requestable Membergroups approval/reject","user":{"login":"margarett","id":5584935,"avatar_url":"https://avatars.githubusercontent.com/u/5584935?v=3","gravatar_id":"","url":"https://api.github.com/users/margarett","html_url":"https://github.com/margarett","followers_url":"https://api.github.com/users/margarett/followers","following_url":"https://api.github.com/users/margarett/following{/other_user}","gists_url":"https://api.github.com/users/margarett/gists{/gist_id}","starred_url":"https://api.github.com/users/margarett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margarett/subscriptions","organizations_url":"https://api.github.com/users/margarett/orgs","repos_url":"https://api.github.com/users/margarett/repos","events_url":"https://api.github.com/users/margarett/events{/privacy}","received_events_url":"https://api.github.com/users/margarett/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-17T02:22:36Z","updated_at":"2015-07-17T04:09:26Z","closed_at":"2015-07-17T04:09:26Z","body":"This issue was actually discovered in simplemachines.org (so it is present in 2.0.10) and it \"more or less\" affects 2.1. More or less because there are \"surrounding issues\" that still need polishing, so it actually works in 2.1 but for the wrong reasons :tongue: \r\n\r\nThe code in Groups.php uses the field \"notify_types\" for the condition to fill of the array of the users which will be approved/rejected (which makes no sense). So if a user, like myself, sets his notification preferences to:\r\n\"For topics and boards I've requested notification on, notify me of:\" --> \"Nothing at all\"\r\nThere will be no possibility for him to be approved/rejected in a membergroup access request.\r\nNot only that, the request will be silently removed from the approval list because the log (in 2.1) or delete (in 2.0) is performed irrespective of the actual operation on the user group.\r\n\r\nThis serves to track the issue and to give me a reference for the PR I'm about to submit :)\r\nBesides not conditioning the operation on the user, the email will be sent or not according his preference of \"Receive forum newsletters, announcements and important notifications by email.\"\r\n\r\n@emanuele45 I would suggest that Elk shares the same buggy behavior because I could find the same exact logic as in SMF (on a quick glimpse)"}}